--- Log opened Wed Dec 24 00:00:59 2014
20141224 00:19:13-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20141224 00:24:56-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20141224 00:28:23-!- markus_ [~mjs-de@p508C8A52.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20141224 00:36:11-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit []
20141224 00:45:57< irker420> wesnoth: Chris Beck wesnoth:master eb71fc4d3b41 / / (4 files in 3 dirs): move "set_menu_item" to be implemented via lua rather than C++ http://git.io/oC-u_w
20141224 00:47:14-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Ping timeout: 250 seconds]
20141224 00:51:39< iceiceice> shadowm: i think one possible way to fix the thing you mentioned before is, just give the help browser more horizontal space
20141224 00:51:49< iceiceice> it seems to leave a lot of dead space for no clear reason
20141224 00:52:30< shadowm> If you mean that the dialog isn't as wide as your screen, that's because long lines aren't comfortable to read.
20141224 00:55:34< irker420> wesnoth: Chris Beck wesnoth:master 38f5aaa56ef8 / src/mouse_events.cpp: mouse_events: use unit_map::iterator::operator bool to simplify http://git.io/RSiLvA
20141224 00:55:58< iceiceice> shadowm: i don't think i follow, i mean the message dialogs are as wide as my screen
20141224 00:56:11< shadowm> They aren't.
20141224 00:56:19< shadowm> I mean, not the text lines.
20141224 00:56:24< iceiceice> ok but the help browser could be as wide as the text lines there
20141224 00:56:30< shadowm> Is it not?
20141224 00:56:39< iceiceice> the text area inside it is defintiely not i think
20141224 00:56:55< shadowm> AFAICT from opening the introduction page, the contents fit the dialog width.
20141224 00:56:55< iceiceice> a lot of space is chopped off due to the tree at left
20141224 00:57:04< shadowm> Uh yeah, we can't get rid of the topic list.
20141224 00:57:21< iceiceice> yeah but we could give more space so that the topic list is positioned similarly to a left justified portrait
20141224 00:57:28< iceiceice> or just, a little more to the left...
20141224 00:59:07-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141224 01:00:07< iceiceice> idk, its that or scale the portraits like you suggested,
20141224 01:00:22< iceiceice> or something complicated
20141224 01:00:34< shadowm> Has anyone asked Jetrel or some other artist about xBRZ(), btw?
20141224 01:01:42< iceiceice> well there was a popular forum thread and emails sent about it
20141224 01:02:34< shadowm> There are no artists subscribed to the mailing list and I don't think Jetrel visits the forums regularly nowadays.
20141224 01:02:45< iceiceice> given that scaling the game was fairly broken before i started changing things anyways, it seems unlikely that anyone cares particularly
20141224 01:03:13< shadowm> Hm, right, but I actually was thinking of using xBRZ in the help.
20141224 01:03:20< iceiceice> oh
20141224 01:03:28< iceiceice> well there's definitely been no discussion of that
20141224 01:03:49< iceiceice> other than doofus-1's comment which i linked you to before
20141224 01:04:04< shadowm> He's only an occasional contributor.
20141224 01:04:27< iceiceice> hehe ok
20141224 01:04:38< iceiceice> i tend to consider anyone an artist who is capable of producing things that aren't stick figures
20141224 01:04:45< iceiceice> out of deference mostly :p
20141224 01:05:07< iceiceice> i have definitely made my share of stick figure games
20141224 01:05:10< shadowm> Yeah, sure, given that criterion I qualify as an artist as well.
20141224 01:05:15< iceiceice> yes you definitely do
20141224 01:05:46< shadowm> But I was thinking of "artists" more along the lines of "people who make decisions about the game's visual style".
20141224 01:06:23< shadowm> Okay, so here's the problem with the config cache management code.
20141224 01:07:00< shadowm> The Boost.filesystem implementation of delete_directory() is only intended to do directories, not files.
20141224 01:07:28< shadowm> Hm, and the original implementation...
20141224 01:07:43 * shadowm scratches head.
20141224 01:08:09< shadowm> Okay.
20141224 01:08:44< shadowm> I think I may have missed something when writing my code.
20141224 01:16:43< shadowm> When did I write this?
20141224 01:17:14< shadowm> June 2014, huh.
20141224 01:17:42< shadowm> I don't get it. I was convinced that delete_file() didn't exist and it was, in fact, already there.
20141224 01:21:21< shadowm> What the hell, past shadowm.
20141224 01:23:30< shadowm> Okay, here's why I messed up epicly here: the original implementation of get_files_in_dir() (used by delete_directory()) returns without recording an error in the log if the target is not a directory.
20141224 01:24:17< shadowm> get_files_in_dir() returns, and the lists passed to it by delete_directory() remain empty.
20141224 01:25:06< shadowm> After deleting files and subdirs from the lists, delete_directory() then actually checks if the directory path passed originally is a directory.
20141224 01:25:27< shadowm> On platforms where the distinction matters.
20141224 01:25:37< shadowm> Then it deletes the target.
20141224 01:26:34< shadowm> The only difference here is that get_files_in_dir() used to not say a thing about having a regular file passed to it, whereas the BFS implementation complains.
20141224 01:26:51< shadowm> The behavior at the end is symmetrical save for that little thing.
20141224 01:27:19< shadowm> So... Recommended course of action?
20141224 01:27:21< c74d> There was a change made to the bundled Lua interpreter making the use of undeclared variables a run-time error?
20141224 01:31:03< shadowm> Meh, whatever.
20141224 01:31:24< shadowm> I'll just "fix" my code in the laziest way possible.
20141224 01:31:42-!- Fluffbeast [~Fluffbeas@pool-96-252-61-113.bstnma.fios.verizon.net] has joined #wesnoth-dev
20141224 01:32:43< enchilado> Classic shadowm.
20141224 01:38:44< irker420> wesnoth: Ignacio R. Morelle wesnoth:master d06c39b714ef / src/config_cache.cpp: Use delete_file() to delete reg files in config_cache::delete_cache_files() http://git.io/3SCRKA
20141224 01:42:27< iceiceice> c74d yes
20141224 01:42:39< iceiceice> only global variables,
20141224 01:42:45< iceiceice> you can still dereference undeclared entries in tables
20141224 01:43:01< iceiceice> its very difficult to use lua in an interpretted mode unless you do this, afaict
20141224 01:44:19< shadowm> if(filesystem::file_exists(addon_dir + ".cfg") && !filesystem::delete_directory(addon_dir + ".cfg", true)) {
20141224 01:44:27< shadowm> Actually, you know what, I'm getting rid of that message.
20141224 01:44:58-!- travis-ci [~travis-ci@ec2-174-129-74-8.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 01:44:58< travis-ci> wesnoth/wesnoth#5233 (master - 38f5aaa : Chris Beck): The build was broken.
20141224 01:44:58< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/44995707
20141224 01:44:58-!- travis-ci [~travis-ci@ec2-174-129-74-8.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 01:52:17-!- Fluffbeast [~Fluffbeas@pool-96-252-61-113.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds]
20141224 01:53:17< irker420> wesnoth: Ignacio R. Morelle wesnoth:master 9d1ecacbb15d / src/ (filesystem.cpp filesystem_boost.cpp): fs: Quietly ignore non-dir targets in get_files_in_dir() (BFS only) http://git.io/C_yuRg
20141224 01:53:20< irker420> wesnoth: Ignacio R. Morelle wesnoth:master c6bb5711b03e / src/config_cache.cpp: Revert "Use delete_file() to delete reg files in config_cache::delete_cache_file http://git.io/_BPZxA
20141224 01:53:23< irker420> wesnoth: Ignacio R. Morelle wesnoth:1.12 50eb70943914 / src/ (filesystem.cpp filesystem_boost.cpp): fs: Quietly ignore non-dir targets in get_files_in_dir() (BFS only) http://git.io/PUUC4Q
20141224 01:55:38< c74d> iceiceice: Was this an upstream change that was imported along with a new version of Lua, or was this a local change in BfW?
20141224 01:56:39< iceiceice> basically i merged a weak form of this: http://lua-users.org/wiki/DetectingUndefinedVariables
20141224 01:56:52< iceiceice> "etc/strict.lua " from upstream
20141224 01:57:10< iceiceice> it gets run in all lua kernels on construction
20141224 01:57:13< iceiceice> you can disable it if you want
20141224 01:57:22< iceiceice> but then the lua interpreter won't work very well
20141224 01:59:00< c74d> "construction"?
20141224 01:59:21< c74d> Oh, construction of LuaKernel objects.
20141224 02:00:37< c74d> iceiceice: is this documented in the wiki?
20141224 02:00:53< iceiceice> in release notes, not wiki yet
20141224 02:01:02< iceiceice> there hasn't been a formal discussion about it
20141224 02:02:31< iceiceice> but it did locate several bugs in wml tag implementations
20141224 02:04:08< irker420> wesnoth: Chris Beck wesnoth:master f83675827bd1 / src/mouse_events.cpp: fix compilation after 38f5aaa56ef87ed58ae03239ac0a600988c0fd09 http://git.io/LBo_dw
20141224 02:05:06< shadowm> Huh? It built fine for me
20141224 02:05:42< iceiceice> not for travis
20141224 02:06:06< shadowm> Is anyone building with clang 3.5 yet, btw?
20141224 02:09:11< shadowm> Okay, yes, my question sucks.
20141224 02:09:13< new_one> I did a few days ago, seems to work fine
20141224 02:09:16< shadowm> Especially in view of the date.
20141224 02:09:30< shadowm> iceiceice: Do we build with clang 3.5 on travis yet?
20141224 02:09:37< iceiceice> no
20141224 02:09:47< shadowm> new_one: In strict mode?
20141224 02:09:57-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 02:09:57< travis-ci> wesnoth/wesnoth#5234 (master - d06c39b : Ignacio R. Morelle): The build was broken.
20141224 02:09:57< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/44998184
20141224 02:09:57-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 02:10:06< iceiceice> shadowm: travis is still on precise pangolin,
20141224 02:10:08< shadowm> Shut up, travis.
20141224 02:10:23< iceiceice> probably i'd need to pull utopic or something to get clang 3.5...
20141224 02:10:36< shadowm> Do they have backport repositories?
20141224 02:10:41< iceiceice> idk when they plan ever to upgrade to trusty
20141224 02:10:51< shadowm> Though I guess backporting a compiler is a PITA.
20141224 02:11:03< iceiceice> its really stupid that its still on precise,
20141224 02:11:09< iceiceice> trusty is the new long term stable since april
20141224 02:11:31< shadowm> Is precise the previous LTS? I think Ubuntu LTS releases are supported for like 6 years.
20141224 02:11:46< iceiceice> yeah but you don't even have a C++11 compiler on precise
20141224 02:12:08< new_one> shadowm: not sure, whatever's the default
20141224 02:12:15< iceiceice> its really annoying that to get any software you have to figure out how to pull from these repositories
20141224 02:12:23< iceiceice> and it definitely makes the build unstable
20141224 02:12:27< shadowm> new_one: The default is to not use strict compilation IIRC, so yeah.
20141224 02:12:33< iceiceice> since every single time we defintiely end up replacing libc
20141224 02:12:55< shadowm> If it worked without strict that doesn't mean you might not have gotten warnings, which would halt the build in strict mode.
20141224 02:13:31< shadowm> My problem with clang 3.5 was precisely that I got a barrage of warnings I couldn't really decide how to fix.
20141224 02:13:39< irker420> wesnoth: Chris Beck wesnoth:master 0d76ac3be758 / / (4 files in 3 dirs): move the place, remove shroud WML tags to lua implementation http://git.io/N8K1ww
20141224 02:14:29< shadowm> iceiceice: Could you explain what the point of this last commit is?
20141224 02:15:11< shadowm> I'm asking because AFAICT it's all still implemented in C++, just with a different interface.
20141224 02:15:26< iceiceice> first of all i thought it was a long term goal to eventually move everything to be via lua
20141224 02:16:26< iceiceice> the advantages are, don't have two ways of doing things... (although we seem to love that)
20141224 02:16:32< shadowm> The only person who could possibly know whether that was a goal or not quit, so in his place I'd say it's a goal only where it yields concrete benefits.
20141224 02:16:42< iceiceice> and, you can give custom modifications to place_shroud / remove_shroud in lua
20141224 02:16:44< c74d> iceiceice: while I'm not saying I think it's a bad change, it is a change to the core semantics of Lua; I think it really ought to be documented in the wiki.
20141224 02:17:03< iceiceice> c74d yeah it probably should
20141224 02:17:09< iceiceice> i need to make a post in developer forum about it
20141224 02:17:20< iceiceice> then i will make some wiki docs i guess
20141224 02:17:30< shadowm> iceiceice: And that wasn't the case before?
20141224 02:17:44< iceiceice> no i don't think it was
20141224 02:17:44< c74d> vultraz: ^
20141224 02:18:06< shadowm> http://pastebin.com/sR4nN7v7
20141224 02:18:20< shadowm> I'm fairly sure this works, and [remove_sound_source] is all in C++.
20141224 02:18:20< iceiceice> maybe i'm wrong, i thought that the tags in game_events/action_wml.cpp could not be overwritten
20141224 02:18:53< iceiceice> shadowm: the other reason that i want to do this is,
20141224 02:19:09< iceiceice> the tags implemented via lua are now tied to the resources made available to the game_lua_kernel object
20141224 02:19:15< iceiceice> most of them are methods of it now
20141224 02:19:30< iceiceice> all the tags in game_events/action_wml.cpp, by contrast, are free-floating functions,
20141224 02:19:38< iceiceice> and they can only access the engine by means of global variables
20141224 02:19:56< shadowm> Yeah, you are wrong. :p
20141224 02:20:08< iceiceice> one of my long term goals is to make it so that we can make copies of the game state,
20141224 02:20:10< shadowm> But that last reason is better.
20141224 02:20:12< iceiceice> and restore them seamlessly
20141224 02:20:33< iceiceice> if we leave the tags that are in action_wml.cpp then it becomes alot harder to do that
20141224 02:21:46< iceiceice> re: this compilation thing,
20141224 02:21:53< iceiceice> it looks like it was only for C++11 that there was a problem?
20141224 02:22:00< iceiceice> maybe it means my operator bool is broken somehow...
20141224 02:22:21< iceiceice> https://github.com/wesnoth/wesnoth/commit/d72aa90532aa5f1ad575f8add16335f4953e1842
20141224 02:22:43< shadowm> I'm using clang 3.4 if that matters, using C++98/03.
20141224 02:23:03< iceiceice> yeah everyone is i guess
20141224 02:23:14< iceiceice> maybe travis should use clang 3.4 for the c++11 build actually
20141224 02:23:26< iceiceice> i think clang 3.4 supports more of C++11 than gcc 4.8 anyways
20141224 02:23:31< iceiceice> (as in, all of it?)
20141224 02:23:54< shadowm> Not all of it IIRC, but more than enough for most people.
20141224 02:23:58< c74d> vultraz: I intend to look into updating lp8/SoD to be compatible with BfW's new Lua dialect, but I may or may not do so soon, The Holidays being upon me.
20141224 02:24:11< shadowm> http://clang.llvm.org/cxx_status.html
20141224 02:24:35< iceiceice> c74d: outside of helping to find bugs, the other benefit of the change is that, doing global lookup is generally much slower in lua
20141224 02:24:49< iceiceice> and you usually want to put things in locals anyways
20141224 02:25:02< shadowm> I guess it's actually all of it, okay.
20141224 02:25:44< c74d> iceiceice: I do certainly like programming languages being strict about stuff like using undeclared variables (my two favorite programming languages are presently Rust and Idris).
20141224 02:26:23< iceiceice> one of my friends from college is a developer for Rust
20141224 02:26:47< iceiceice> i don't actually know what idris is
20141224 02:26:58< shadowm> Anyway, re the "Lua can't change C++-implemented tags" argument, if in doubt you should always test.
20141224 02:29:14< shadowm> Especially so if you are making decisions based on assumptions. I'm not saying that's the case here, but since you saved the real reason for last it gave off that vibe at first.
20141224 02:30:13-!- travis-ci [~travis-ci@ec2-54-226-127-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 02:30:13< travis-ci> wesnoth/wesnoth#5235 (master - c6bb571 : Ignacio R. Morelle): The build is still failing.
20141224 02:30:13< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/44998913
20141224 02:30:13-!- travis-ci [~travis-ci@ec2-54-226-127-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 02:32:42< iceiceice> hmm this is kind of wierd: https://github.com/wesnoth/wesnoth/blob/master/src/game_events/action_wml.cpp#L1450
20141224 02:33:07< iceiceice> should topic_id's actually be translatable strings?
20141224 02:33:21< iceiceice> i thought ids usually are not translatable...
20141224 02:36:28< shadowm> Changing that to string won't really change whether the value is translated or not.
20141224 02:37:10< shadowm> It will be translated only if the WML attribute is marked as translatable.
20141224 02:37:57< shadowm> That said, using cfg["topic"].str() would be a better idea regardless of this.
20141224 02:51:47-!- gfgtdf [~chatzilla@f054168246.adsl.alicedsl.de] has joined #wesnoth-dev
20141224 02:53:19< gfgtdf> iceiceice: afaik there was once a config implementation that only has tstrings as possible attribute values (as opposed to the current boost variant implementation) Maybe that's just a leftover.
20141224 02:53:46< iceiceice> maybe
20141224 02:54:04< shadowm> t_strings could already be implicitly converted to std::string back then.
20141224 02:55:12-!- travis-ci [~travis-ci@ec2-174-129-74-8.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 02:55:12< travis-ci> wesnoth/wesnoth#5237 (master - f836758 : Chris Beck): The build was fixed.
20141224 02:55:12< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/44999542
20141224 02:55:12-!- travis-ci [~travis-ci@ec2-174-129-74-8.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 02:55:21< shadowm> And explicitly, as well, using the str() method. I really don't know what to_serialized() does, but it can't be any worse.
20141224 02:55:55< shadowm> Oh, I get it.
20141224 02:56:38< shadowm> Yes, it can be worse, but not in a translation vs. no translation way.
20141224 02:57:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141224 02:58:38< shadowm> It seems it'll give you a representation that includes some implementation details of t_string, so you really do not want to use that.
20141224 02:59:09< shadowm> That does raise the question of why this is the only other existing caller:
20141224 02:59:12< shadowm> src/game_initialization/connect_engine.cpp:159:                 user_team_names_.push_back(user_team_name.t_str().to_serialized());
20141224 02:59:59< shadowm> Perhaps this method was more legitimately used by the ancient binary WML implementation.
20141224 03:06:02< gfgtdf> shadowm: the ocurrance in connect engine was done in this commit: https://github.com/wesnoth/wesnoth/commit/aa09d82c7d882240b8e7f65aedef616449cb6302
20141224 03:06:27< shadowm> Oh, it's that guy.
20141224 03:07:58< shadowm> At least it's consistent in that it uses from/to_serialized(), but it's still odd.
20141224 03:08:27< shadowm> See, this is why people should write correct commit messages, comments, and Doxygen annotations.
20141224 03:09:19< shadowm> Our IRC logs do not even go that far back, so we really don't know what this is supposed to mean.
20141224 03:09:35< irker420> wesnoth: Chris Beck wesnoth:master 41e54fd00911 / / (4 files in 3 dirs): move allow_undo, allow_end_turn impl's to lua http://git.io/BOt0CQ
20141224 03:14:57< iceiceice> if this is the only place it appears and no one can make sense of it its quite likely the author made a mistake.
20141224 03:15:48< iceiceice> but it might be just some niche solution for mp localization...
20141224 03:15:51< shadowm> Hm, yes but no. Since in the mp code case it's paired with a from_serialized() caller, it's likely fine. It's just that the purpose isn't obvious.
20141224 03:16:34< shadowm> i.e. why do this instead of just using a t_string as normal? Is there something special about how translatable strings get sent over the network?
20141224 03:17:30< iceiceice> presumably that's taken care of by the networking code?
20141224 03:17:47-!- Ivanovic_ [~ivanovic@frnk-d93339a4.pool.mediaWays.net] has joined #wesnoth-dev
20141224 03:17:48< shadowm> The WML tag case lacks any kind of justification, though. It probably hasn't caused problems for anyone because a) the tag is used very rarely; and b) the attribute in question is not supposed to be translatable, so it basically never is.
20141224 03:18:32< shadowm> And by not being translatable, it doesn't cause the t_string representation details to spill into the help code call.
20141224 03:21:04-!- Ivanovic [~ivanovic@frnk-5f7502f1.pool.mediaWays.net] has quit [Ping timeout: 250 seconds]
20141224 03:21:40-!- Ivanovic_ is now known as Ivanovic
20141224 03:23:39< irker420> wesnoth: Chris Beck wesnoth:master 09ce8b57740d / / (4 files in 3 dirs): move clear_menu_item to lua implementation http://git.io/U5THpQ
20141224 03:27:51-!- travis-ci [~travis-ci@ec2-54-226-127-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 03:27:51< travis-ci> wesnoth/wesnoth#5238 (master - 0d76ac3 : Chris Beck): The build was fixed.
20141224 03:27:51< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/44999972
20141224 03:27:51-!- travis-ci [~travis-ci@ec2-54-226-127-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 03:30:21< iceiceice> hmm i forget now,
20141224 03:30:40< iceiceice> is there a good way to call "config::attribute_value::to_bool" from lua?
20141224 03:32:30< shadowm> What exactly are you trying to do?
20141224 03:33:22< iceiceice> right now there is a wml tag implemented in C++
20141224 03:33:51< iceiceice> it seems like most of the wml actions implemented in lua, do some parsing in the lua part because its nicer,
20141224 03:34:09< shadowm> Because it's really the only reason for implementing them in Lua.
20141224 03:34:11< iceiceice> and then use wesnoth. callbacks to 
20141224 03:34:13< iceiceice> do the action
20141224 03:34:22< shadowm> Same.
20141224 03:34:24< iceiceice> yes
20141224 03:34:36< iceiceice> however, sometimes you need to use "attribute_value::to_bool"
20141224 03:34:55< iceiceice> which does some special things, like "true", "false", "on", "off" are parsed in a certain way
20141224 03:35:04< shadowm> Lua has its own notion of boolean evaluation.
20141224 03:35:12< iceiceice> yes but for backwards compatibility
20141224 03:35:26< c74d> iceiceice: I have a Lua implementation of the engine to_bool, in case you need it.
20141224 03:35:28< shadowm> If you are dealing with a WML table, boolean evaluation will happen naturally.
20141224 03:35:52< iceiceice> what does this mean
20141224 03:36:04< shadowm> It's part of the magic of the variant-based WML attributes implementation (and in fact it was implemented by the same person who brought Lua to Wesnoth).
20141224 03:36:54< iceiceice> shadowm: to make it very concrete,
20141224 03:37:04< iceiceice> if i have function wml_actions.foo(cfg),
20141224 03:37:19< shadowm> It means that `local foo = cfg.foo; if foo then bar() end` will only call bar() if foo is a true value.
20141224 03:37:20< iceiceice> and my argument cfg has some field "bar = on"
20141224 03:37:42< iceiceice> so the argument cfg is actually a vconfig or something?
20141224 03:37:53< shadowm> It's a WML table.
20141224 03:37:54< iceiceice> i thought it was a vanilla lua table
20141224 03:38:01< iceiceice> hmm i see
20141224 03:38:08< shadowm> It's a Lua table that has a property set that makes it special.
20141224 03:38:19< shadowm> I don't really know the specifics.
20141224 03:38:21< iceiceice> right it has the vconfig metatable or someting
20141224 03:38:27< iceiceice> (that's what i meant)
20141224 03:38:33< iceiceice> i want to check the source to be sure
20141224 03:38:51< shadowm> You can look at existing WML tags implemented in Lua to see how they deal with boolean attributes, really.
20141224 03:39:16< shadowm> I've not found a need to overthink it thus far, so someone did something right.
20141224 03:39:43< shadowm> Hence magic.
20141224 03:40:21< iceiceice> nice
20141224 03:41:25< shadowm> And don't try to think your Lua code as if it were C++, it's really more like Javascript.
20141224 03:42:03-!- gfgtdf [~chatzilla@f054168246.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]]
20141224 03:42:30< shadowm> I've found this methodology has allowed me to be more productive without cursing every few lines.
20141224 03:42:36-!- travis-ci [~travis-ci@ec2-174-129-74-8.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 03:42:36< travis-ci> wesnoth/wesnoth#5239 (master - 41e54fd : Chris Beck): The build was broken.
20141224 03:42:36< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45002318
20141224 03:42:36-!- travis-ci [~travis-ci@ec2-174-129-74-8.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 03:53:59< iceiceice> hmm something is broken in the unit test system,
20141224 03:54:12< iceiceice> it appears that the replay indeed goes out of sync, and errors are reported to travis,
20141224 03:54:20< iceiceice> but for some reason the test is marked as passing anyways
20141224 03:54:51< iceiceice> "Error (strict mode, strict_level = 1): wesnoth reported on channel error replay
20141224 03:54:51< iceiceice> 20141224 03:28:44 error replay: We called random 24 times, but the original game called random -99 times.
20141224 03:54:51< iceiceice> 20141224 03:28:44 error replay: checksum = 9edd5r2fs>3Eob14p9INqpEP0ErHez3GvyCq5QOAvxxsLyFxQsyEBBwyRxFXDkCtGCsssUNBstSSztoGbkVTNyMwdQRbFjOBn3ZEdAWotSUxBrNbwxQauvUIT4zwSSOP"
20141224 03:57:32-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20141224 04:05:24< irker420> wesnoth: Chris Beck wesnoth:master fa32be5602ca / / (4 files in 3 dirs): add time_area registration impl to lua http://git.io/8PaLIA
20141224 04:24:34< c74d> <https://ci.appveyor.com> seems to be a Travis-like thing that builds on Microsoft Windows, in case that's something you might find useful.
20141224 04:35:27< irker420> wesnoth: Chris Beck wesnoth:master defb9e5051ca / / (4 files in 3 dirs): move replace_schedule impl to lua http://git.io/COz7Xg
20141224 04:35:34-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141224 04:44:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20141224 04:47:10-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 04:47:10< travis-ci> wesnoth/wesnoth#5241 (master - fa32be5 : Chris Beck): The build was fixed.
20141224 04:47:10< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45004591
20141224 04:47:10-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 04:49:20-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.0.1]
20141224 05:14:15-!- localuser- [~none@gateway/tor-sasl/localuser-] has joined #wesnoth-dev
20141224 05:14:37-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20141224 05:21:11-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20141224 05:37:43< irker420> wesnoth: Chris Beck wesnoth:master 1fad866dc758 / .travis.yml: travis: refactor, add a clang C++11 build http://git.io/y8pGaQ
20141224 05:39:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20141224 05:47:24-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20141224 05:47:33< irker420> wesnoth: Chris Beck wesnoth:master 8328bdd5c3b9 / .travis.yml: travis: disable a warning for clang c++11 build http://git.io/o0Uh3w
20141224 05:50:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141224 05:57:43-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20141224 06:07:10< irker420> wesnoth: Chris Beck wesnoth:master 2cc38505dcd8 / / (4 files in 3 dirs): move WML [scroll] implementation to lua http://git.io/v81epw
20141224 06:12:35-!- localuser- [~none@gateway/tor-sasl/localuser-] has quit [Ping timeout: 250 seconds]
20141224 06:14:22-!- localuser- [~none@gateway/tor-sasl/localuser-] has joined #wesnoth-dev
20141224 06:15:21-!- travis-ci [~travis-ci@ec2-54-145-22-48.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 06:15:21< travis-ci> wesnoth/wesnoth#5243 (master - 1fad866 : Chris Beck): The build was broken.
20141224 06:15:21< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45008260
20141224 06:15:21-!- travis-ci [~travis-ci@ec2-54-145-22-48.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 06:22:15-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141224 06:27:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141224 06:39:13-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 06:39:13< travis-ci> wesnoth/wesnoth#5244 (master - 8328bdd : Chris Beck): The build was broken.
20141224 06:39:13< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45008687
20141224 06:39:13-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 06:47:08< irker420> wesnoth: Chris Beck wesnoth:master ba95d7eed359 / .travis.yml: travis: fixup $CXX check http://git.io/Dy2iOg
20141224 06:53:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141224 06:54:48-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 06:54:48< travis-ci> wesnoth/wesnoth#5245 (master - 2cc3850 : Chris Beck): The build was broken.
20141224 06:54:48< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45009374
20141224 06:54:48-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 06:55:41-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141224 07:01:54< irker420> wesnoth: Chris Beck wesnoth:master d4440b34cdc2 / .travis.yml: travis: fixup HEAD^ (conjunctions) http://git.io/LHr3xQ
20141224 07:08:45< irker420> wesnoth: Chris Beck wesnoth:master 6fc1ac1bb224 / src/game_events/ (6 files): fixup wml menu items: track the lifetime of the manager http://git.io/V8gaGA
20141224 07:09:36< irker420> wesnoth: Chris Beck wesnoth:master 3b13ac21da68 / .travis.yml: travis: replace build numbers with descriptive names http://git.io/NKEOdg
20141224 07:42:31-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20141224 07:43:33-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer]
20141224 07:44:57< irker420> wesnoth: Chris Beck wesnoth:master 96c35f656045 / / (5 files in 4 dirs): move WML [redraw] impl to lua http://git.io/9VXXmw
20141224 07:58:03< irker420> wesnoth: Chris Beck wesnoth:master 177b4d5da19f / / (4 files in 3 dirs): move WML [color_adjust] impl to lua http://git.io/t9Z38g
20141224 07:58:49< vultraz> so much lua e_e
20141224 08:03:06-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141224 08:03:18< iceiceice> vultraz: we should actually do that thing you were saying about custom conditionals
20141224 08:04:16< vultraz> can you?
20141224 08:04:59< iceiceice> i forget partly what the idea was
20141224 08:06:09< vultraz> like the wesnoth.wml_actions table, have a wesnoth.condition_actions table, allowing users to register new, custom actions that will be recognized by [if] and [filter_condition], and to reduce the extreme code duplication you mentioned
20141224 08:06:27< iceiceice> ok
20141224 08:06:34-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20141224 08:06:45< iceiceice> and so also, there was something about, don't allow to overwrite the default conditionals?
20141224 08:07:31-!- travis-ci [~travis-ci@ec2-54-226-127-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 08:07:31< travis-ci> wesnoth/wesnoth#5247 (master - d4440b3 : Chris Beck): The build was fixed.
20141224 08:07:31< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45011397
20141224 08:07:31-!- travis-ci [~travis-ci@ec2-54-226-127-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 08:07:50< vultraz> yeah, I mentioned that. Dunno whether it's strictly necessary, I mean, we allow overriding wml actions tags. But conditionals might be something that shouldbe protected
20141224 08:08:06< irker420> wesnoth: Chris Beck wesnoth:master 29da15e1c062 / / (4 files in 3 dirs): move wml [end_turn] impl to lua http://git.io/bCwItQ
20141224 08:16:36-!- Ivanovic [~ivanovic@frnk-d93339a4.pool.mediaWays.net] has quit [Changing host]
20141224 08:16:36-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20141224 08:19:23-!- travis-ci [~travis-ci@ec2-54-145-22-48.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 08:19:23< travis-ci> wesnoth/wesnoth#5248 (master - 6fc1ac1 : Chris Beck): The build passed.
20141224 08:19:23< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45011637
20141224 08:19:23-!- travis-ci [~travis-ci@ec2-54-145-22-48.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 08:23:10< shadowm> Not really.
20141224 08:24:04< vultraz> well then
20141224 08:24:16< vultraz> It Has Been Said
20141224 08:27:08-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20141224 08:32:07-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 08:32:07< travis-ci> wesnoth/wesnoth#5249 (master - 3b13ac2 : Chris Beck): The build failed.
20141224 08:32:07< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45011674
20141224 08:32:07-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 08:46:16-!- Sulfur [~Miranda@p5B0080EA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141224 08:58:07-!- travis-ci [~travis-ci@ec2-54-145-22-48.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 08:58:07< travis-ci> wesnoth/wesnoth#5250 (master - 96c35f6 : Chris Beck): The build passed.
20141224 08:58:07< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45013118
20141224 08:58:07-!- travis-ci [~travis-ci@ec2-54-145-22-48.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 09:05:08< iceiceice> hmmmmmm...
20141224 09:05:13< iceiceice> strange error here:
20141224 09:05:23< iceiceice> i'm getting lua errors in this core code: https://github.com/wesnoth/wesnoth/blob/master/data/core/macros/sound-utils.cfg#L940
20141224 09:05:32< iceiceice> when i try to move [event] to be implemented in lua
20141224 09:05:52< iceiceice> i guess this stuff is processed before data/lua/wml-tags.lua ??
20141224 09:06:41< vultraz> yes
20141224 09:07:15< vultraz> data/core/_main.cfg:10 - {core/macros/} []:23 - wesnoth.dofile 'lua/wml-tags.lua'
20141224 09:07:31< iceiceice> hmmm
20141224 09:07:57< iceiceice> i think the lua should happen before the wml
20141224 09:08:17< iceiceice> (good catch btw, thank you)
20141224 09:11:17< vultraz> iceiceice: more like that lua should be WML
20141224 09:11:27< vultraz> there's absolutely 0 optimization there
20141224 09:12:46< iceiceice> hmm
20141224 09:13:03< iceiceice> you think its better to use [lua] tags and preprocessor inclusion than just wesnoth.dofile ?
20141224 09:14:07< vultraz> what do you mean?
20141224 09:14:19< vultraz> I meant that that specific lua that you linked should be written as WML
20141224 09:14:38< vultraz> or dofiled
20141224 09:15:08< vultraz> why is that even there?
20141224 09:15:20< vultraz> Coffee_irc: or zookeeper might know...
20141224 09:16:02< iceiceice> vultraz:
20141224 09:16:19< iceiceice> that lua is the place when 'lua/wml-tags.lua' is actually executed
20141224 09:16:26< iceiceice> and all the wml-tags defined there actually get loaded into the game
20141224 09:16:32-!- cib0 [~cib@tmo-096-16.customers.d1-online.com] has joined #wesnoth-dev
20141224 09:16:37< iceiceice> this happens as part of core i guess,
20141224 09:16:42< vultraz> yes, I know
20141224 09:16:51< iceiceice> but what i think is backwards is that it happens before wml is parsed
20141224 09:17:06< iceiceice> so its like, first read all the wml in the game, then read the part that tells you what it means...
20141224 09:17:45< iceiceice> how do you want to write it as wml?
20141224 09:18:07< iceiceice> you just want those 3 lines to be again in a file?
20141224 09:18:44< iceiceice> (sorry it is late for me now...)
20141224 09:18:44< vultraz>  { "filter_attack", { -> [filter_attack]
20141224 09:18:46< vultraz> etc
20141224 09:18:53< iceiceice> ohhh
20141224 09:19:07< vultraz> there should not be inline lua there and I don't know why there is
20141224 09:19:31< iceiceice> ok so i think its basically a hack,
20141224 09:19:36< iceiceice> that lua is at top level
20141224 09:19:40< iceiceice> so it only gets run once
20141224 09:19:49< iceiceice> err,
20141224 09:19:50< iceiceice> once each game
20141224 09:20:27< iceiceice> maybe its better in a file though
20141224 09:20:43< iceiceice> like "lua/sound_utils.lua" or something
20141224 09:20:50< vultraz> likely
20141224 09:20:56< iceiceice> and also loaded via dofile in data/core/_main.cfg like these others
20141224 09:21:22< iceiceice> i also dont know why it doesn't use the helper tag syntax for readability
20141224 09:22:03< vultraz> which is why I said there's 0 optimization
20141224 09:22:10< vultraz> it's literally WML with {} instead of []
20141224 09:26:45-!- Gallaecio [~quassel@105.153.165.83.dynamic.mundo-r.com] has joined #wesnoth-dev
20141224 09:29:54-!- travis-ci [~travis-ci@ec2-54-226-127-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 09:29:54< travis-ci> wesnoth/wesnoth#5251 (master - 177b4d5 : Chris Beck): The build passed.
20141224 09:29:54< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45013701
20141224 09:29:54-!- travis-ci [~travis-ci@ec2-54-226-127-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 09:40:48-!- localuser- [~none@gateway/tor-sasl/localuser-] has quit [Remote host closed the connection]
20141224 09:41:58-!- localuser- [~none@gateway/tor-sasl/localuser-] has joined #wesnoth-dev
20141224 09:43:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141224 09:52:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141224 10:01:23-!- localuser- [~none@gateway/tor-sasl/localuser-] has quit [Ping timeout: 250 seconds]
20141224 10:03:38-!- localuser- [~none@gateway/tor-sasl/localuser-] has joined #wesnoth-dev
20141224 10:07:50< vultraz> gahh
20141224 10:08:09 * vultraz 's attempt to add a background to the loadscreen is unsuccessful
20141224 10:09:05-!- mjs-de [~mjs-de@p508C8A52.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141224 10:11:47-!- localuser- [~none@gateway/tor-sasl/localuser-] has quit [Ping timeout: 250 seconds]
20141224 10:25:47< vultraz> asghsdgdg
20141224 10:26:15-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20141224 10:26:21-!- localuser- [~none@gateway/tor-sasl/localuser-] has joined #wesnoth-dev
20141224 10:26:59< zookeeper> vultraz, so what does the hang out AI do exactly?
20141224 10:27:22< vultraz> zookeeper: it keeps the affected units at a location until a condition has been met
20141224 10:27:36< zookeeper> "at a location" meaning what?
20141224 10:27:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20141224 10:28:33< vultraz> well, where they are, basically
20141224 10:28:35< vultraz> they're hanging out :P
20141224 10:29:13< zookeeper> does that mean you don't know? :p
20141224 10:29:23< vultraz> you can define locations
20141224 10:29:29< vultraz> with [filter_location]
20141224 10:29:50< vultraz> according to the wiki..
20141224 10:29:51< vultraz> "It defaults to the position of the side leader(s)."
20141224 10:30:36< zookeeper> well, really i'd just like to know whether volk can now move differently in s10
20141224 10:31:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141224 10:31:41< vultraz> well, before, he could never move out of the castle. now, I'm not sure if he'll never move off the keep or not, but the general effect is that he stays there
20141224 10:32:27< zookeeper> why did you change it then? :x the old way was perfectly clear and simple
20141224 10:32:46< zookeeper> i even moved the village next to the castle specifically so that he could also heal himself there
20141224 10:32:57< zookeeper> now, maybe he doesn't
20141224 10:33:22< vultraz> I'll do some testing.
20141224 10:33:43< zookeeper> okay
20141224 10:39:20-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 256 seconds]
20141224 10:40:34< vultraz> zookeeper: adding a location filter makes him go heal as required
20141224 10:40:39< vultraz> terrain=Ce,Cea,*^V*
20141224 10:40:42-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20141224 10:40:46< vultraz> (I can't make that C*, can I?)
20141224 10:44:07< vultraz> apparently I can
20141224 10:46:10< vultraz> zookeeper: ^
20141224 10:46:22< vultraz> well, irker didn't report, but I committed it
20141224 10:46:27-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141224 10:51:20-!- kex [~kex@77.28.28.233] has joined #wesnoth-dev
20141224 10:57:31< zookeeper> ok, great
20141224 11:11:26-!- enchilado [enchilado@defocus/yummy/enchilado] has quit [Remote host closed the connection]
20141224 11:11:53-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-kfsgdxzwzrqqgrel] has joined #wesnoth-dev
20141224 11:14:03-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-kfsgdxzwzrqqgrel] has quit [Changing host]
20141224 11:14:03-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20141224 11:18:57-!- localuser- [~none@gateway/tor-sasl/localuser-] has quit [Ping timeout: 250 seconds]
20141224 11:21:04-!- localuser- [~none@gateway/tor-sasl/localuser-] has joined #wesnoth-dev
20141224 11:24:26-!- Ravana_ [SZ_Bot@27-83-235-80.dyn.estpak.ee] has quit [Disconnected by services]
20141224 11:24:26-!- SZ_Bot [SZ_Bot@27-83-235-80.dyn.estpak.ee] has joined #wesnoth-dev
20141224 11:26:00-!- SZ_Bot is now known as Ravana_
20141224 11:28:08-!- Coffee_irc [~david@ppp118-210-58-226.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20141224 11:36:04< vultraz> random failed experiment https://www.dropbox.com/s/424cnvcm1s116ze/Screenshot%202014-12-24%2021.43.26.png?dl=0
20141224 12:10:59-!- cib_ [~cib@tmo-096-241.customers.d1-online.com] has joined #wesnoth-dev
20141224 12:12:13< shadowm> zookeeper: So how is 1ff69616bfbdcd07add406c759bfd0dff9321919 supposed to work?
20141224 12:12:49< shadowm> I'm asking because, IIRC, these events are only dispatched once the animation finishes.
20141224 12:14:26-!- cib0 [~cib@tmo-096-16.customers.d1-online.com] has quit [Ping timeout: 258 seconds]
20141224 12:14:31< shadowm> Yep, still the case.
20141224 12:15:28< shadowm> So there's now a substantial delay between the target getting the slowed color effect and floating text, and the sound being heard.
20141224 12:16:05< shadowm> Especially if the target's defense animation/the source's attack animation takes long enough to finish.
20141224 12:17:39< shadowm> Also, am I really the only one who likes the minimalistic loadscreen design?
20141224 12:20:43< vultraz> I don't know
20141224 12:20:56< vultraz> which I why I wrote an email to the list but no one's responded
20141224 12:21:19< shadowm> Yeah, I also wrote a REALLY important message and nobody's responded. It's probably because of the holidays.
20141224 12:21:32< vultraz> Likely
20141224 12:21:40< vultraz> It's christmas eve and we're developing wesnoth
20141224 12:21:43< vultraz> That says something
20141224 12:21:47< shadowm> Which means I might need to push the dates a bit further.
20141224 12:22:07< shadowm> It doesn't help that the situation for 1.12 is worse than I thought at the time of the writing.
20141224 12:32:54< zookeeper> shadowm, the events are dispatched once the animation finishes? that's new to me
20141224 12:33:52 * zookeeper checks
20141224 12:34:38< zookeeper> as for your ML message, i remember looking at it and thinking that it sounds good to me
20141224 12:35:11< zookeeper> you're right about the timing though. weird.
20141224 12:36:43< zookeeper> huh. my 1.10.7 doesn't run anymore...
20141224 12:37:59< vultraz> ESC no longer works in the editor...
20141224 12:38:55-!- Kexoth [~kex@77.29.85.171] has joined #wesnoth-dev
20141224 12:40:27< zookeeper> shadowm, i find it weird that the events trigger that late, before today i could have sworn that i was sure they'd fire immediately on hit, but i guess not...
20141224 12:40:35 * zookeeper is afk for a little while
20141224 12:41:32-!- kex [~kex@77.28.28.233] has quit [Ping timeout: 245 seconds]
20141224 12:42:58-!- travis-ci [~travis-ci@ec2-54-226-127-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 12:42:58< travis-ci> wesnoth/wesnoth#5258 (master - 75767d3 : Chris Beck): The build was broken.
20141224 12:42:58< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45021200
20141224 12:42:58-!- travis-ci [~travis-ci@ec2-54-226-127-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 12:43:28< vultraz> shadowm: thoughts on updating the homepage blurb with the text from the default Core description?
20141224 12:46:13< vultraz> (under data/cores.cfg)
20141224 12:46:35< shadowm> No.
20141224 12:47:18< shadowm> It's too busy, and we had replaced a similar version a few years ago.
20141224 12:56:53< vultraz> gah, I really wish we could remove this titlescreen animation option
20141224 12:57:01< vultraz> It's been broken since 1.9
20141224 12:57:03< vultraz> and it was ugly
20141224 13:11:19-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 13:11:20< travis-ci> wesnoth/wesnoth#5259 (master - 2398906 : Charles Dang): The build was broken.
20141224 13:11:20< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45021290
20141224 13:11:20-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 13:12:15< vultraz> god dammit travis
20141224 13:22:15-!- Sulfur [~Miranda@p5B0080EA.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141224 13:22:16< fendrin> shadowm: I think wesnoth work during the holidays is for most older developers who have children nowadays not possible. I don't have children yet but other family buisness. Thus I veto the early 1.12.1 release.
20141224 13:23:43< shadowm> Yes, as I said I proposed those dates under the assumption that 1.12 was in much better shape.
20141224 13:24:09< shadowm> So it wouldn't have needed any extra work from anyone but me and the translators, but guess what.
20141224 13:24:50< vultraz> *drumroll*
20141224 13:28:28-!- prkc [~prkc@4E5CCCAE.dsl.pool.telekom.hu] has joined #wesnoth-dev
20141224 13:28:43< zookeeper> shadowm, do you know of any past fixes/changes/reports/etc WRT when those combat events do/should trigger?
20141224 13:28:54< shadowm> No.
20141224 13:28:57< zookeeper> okay
20141224 13:29:03< zookeeper> i'll see if i can find any...
20141224 13:29:53< shadowm> I'd dare say the animation code might break spectacularly if you had the ability to tamper with units mid-animation, but that's just a hunch.
20141224 13:31:40< shadowm> And I don't mean just killing or replacing the involved units, but changing their animations via [effect]s, altering information matched by attack filters, etc. So it'd probably take some work to make it work flawlessly.
20141224 13:31:52< shadowm> ... work... work.
20141224 13:32:02 * vultraz imagines a lich turning into a bunny and still shooting dark magic
20141224 13:32:28< shadowm> I was thinking more along the lines of incorrect memory accesses resulting in garbage and segmentation faults.
20141224 13:32:49< zookeeper> sure, i'd imagine you could break a lot with it
20141224 13:34:30< zookeeper> what i wonder the most is how is it possible that i've always been sure that they trigger at hit time
20141224 13:35:06< vultraz> try in an earlier version
20141224 13:36:05< zookeeper> i will
20141224 13:36:23< zookeeper> but since my 1.10.7 mysteriously doesn't run anymore, i guess i'll have to redownload+install
20141224 13:40:18-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 13:40:18< travis-ci> wesnoth/wesnoth#5260 (master - 17eae18 : Charles Dang): The build was broken.
20141224 13:40:18< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45024460
20141224 13:40:18-!- travis-ci [~travis-ci@ec2-54-80-135-128.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 13:44:52-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20141224 14:11:07-!- Sulfur [~Miranda@p5B0080EA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141224 14:11:15< zookeeper> wtf. even a re-installed 1.10.7 won't run. 0xc0000005 -.-
20141224 14:12:52-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20141224 14:33:10-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20141224 14:34:10-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.0.1]
20141224 14:35:12-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20141224 14:37:38< zookeeper> attaching msvc debugger tells me "Unhandled exception at 0x90E60000 in wesnoth.exe: 0xC0000005: Access violation reading location 0x90E60000." and that it's related to SDL_ttf.dll
20141224 14:42:03< vultraz> still no irker D:
20141224 14:42:10< zookeeper> some people on the forums have had the same problem when using bitdefender, which i installed recently, but i get the problem even when i shut down bitdefender
20141224 14:44:28< vultraz> . . . wesnoth just crashed when I tried to start an sp game in mp mode o-O
20141224 14:47:15< loonycyborg> zookeeper: and the git master binary still works?
20141224 14:48:09< zookeeper> loonycyborg, huh, it doesn't... i'm sure it worked yesterday
20141224 14:49:00< loonycyborg> maybe you should uninstall that bitdefender thing?
20141224 14:49:06< loonycyborg> not just 'shut down'
20141224 14:49:22< zookeeper> maybe
20141224 14:50:09< zookeeper> the stderr timestamp tells me that i last tried it a day and a half ago, and i sure would remember if it wouldn't have worked :p
20141224 14:51:07< irker420> wesnoth: Chris Beck wesnoth:master 0e365efc1a81 / / (4 files in 3 dirs): move WML [label] impl to lua http://git.io/HekRFA
20141224 14:51:09< irker420> wesnoth: Chris Beck wesnoth:master 0246026940b8 / / (5 files in 4 dirs): move WML [event] impl to lua, fixup core wml vs lua loading order http://git.io/LIr2dg
20141224 14:51:11< irker420> wesnoth: Chris Beck wesnoth:master b70bfddcdeba / .travis.yml: travis: restore descriptive names http://git.io/B1zG7A
20141224 14:51:13< irker420> wesnoth: Chris Beck wesnoth:master ca58a71793bb / / (4 files in 3 dirs): move WML [modify_side] implementation to lua http://git.io/AKuJag
20141224 14:51:15< irker420> wesnoth: Chris Beck wesnoth:master 9922b98fa300 / / (6 files in 3 dirs): move wml [inspect] impl to lua (and lua_gui2 namespace) http://git.io/4gXjrA
20141224 14:51:17< irker420> wesnoth: Chris Beck wesnoth:master 75767d3a7755 / / (4 files in 3 dirs): move WML [kill] impl to lua http://git.io/zLUIHQ
20141224 14:51:19< irker420> wesnoth: Charles Dang wesnoth:master 004af104d9eb / data/campaigns/Descent_Into_Darkness/scenarios/10_Alone_at_Last.cfg: DiD S10: make Volk hang out around his castle and adjacent villages, not just hi http://git.io/IkCi7A
20141224 14:51:22< irker420> wesnoth: Charles Dang wesnoth:master 2398906fd845 / / (8 files in 5 dirs): Merge branch 'master' of github.com:wesnoth/wesnoth http://git.io/uDzQrQ
20141224 14:51:25< irker420> wesnoth: Charles Dang wesnoth:master 17eae18c33b2 / images/misc/orb-enemy.png: Removed a blank, unused image http://git.io/Q2BTrA
20141224 14:51:28< irker420> wesnoth: Charles Dang wesnoth:master 7ae2a72ada00 / src/help/help_impl.cpp: 'Units having this ability' -> 'Units with this ability' http://git.io/rGl-HQ
20141224 14:52:07< vultraz> ah hello irker
20141224 14:52:37< loonycyborg> zookeeper: maybe just reboot?
20141224 14:52:54< irker420> Hi vultraz.
20141224 14:56:38-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20141224 14:59:30-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 244 seconds]
20141224 14:59:44-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit []
20141224 15:01:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20141224 15:02:22< zookeeper> loonycyborg, yeah, uninstalled and rebooted, and now things work again
20141224 15:02:35< loonycyborg> cool
20141224 15:02:37< zookeeper> so i guess i can assume it was bitdefender's fault
20141224 15:03:10< loonycyborg> They often do weird shit
20141224 15:03:36< loonycyborg> Even weirder than trojans and viruses sometimes :P
20141224 15:05:27< zookeeper> which antivirus doesn't?
20141224 15:05:38< zookeeper> i thought i made an informed choice based on what i had read
20141224 15:15:22-!- travis-ci [~travis-ci@ec2-54-226-127-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20141224 15:15:22< travis-ci> wesnoth/wesnoth#5261 (master - 7ae2a72 : Charles Dang): The build was fixed.
20141224 15:15:22< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45034461
20141224 15:15:22-!- travis-ci [~travis-ci@ec2-54-226-127-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20141224 15:16:35-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has joined #wesnoth-dev
20141224 15:17:40< zookeeper> well, looks like the hits/misses events hit after the whole anim even in 1.10. :|
20141224 15:19:40-!- Fluffbeast [~Fluffbeas@pool-96-252-61-113.bstnma.fios.verizon.net] has joined #wesnoth-dev
20141224 15:33:22< loonycyborg> zookeeper: yup, I meant antiviruses in general
20141224 15:33:34< loonycyborg> not just that one
20141224 15:36:51-!- Fluffbeast [~Fluffbeas@pool-96-252-61-113.bstnma.fios.verizon.net] has quit [Ping timeout: 272 seconds]
20141224 15:37:44< zookeeper> right
20141224 16:03:39-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141224 16:16:13< vultraz> zookeeper: I propose in 1.13 we work one expanding the encyclopedia
20141224 16:21:42< zookeeper> i have a bunch of uncommitted encyclopedia fixes
20141224 16:21:47< zookeeper> there's all sorts of things wrong there
20141224 16:24:06< vultraz> Have a diff?
20141224 16:28:10< zookeeper> eh, looks like most of the actual fixes (as opposed to tweaks, half of them just adding periods...) i haven't even made yet, i just have them in a few PM's i've been sent about them
20141224 16:28:15< zookeeper> but here's what i did so far: http://pastebin.com/GUJDDmUr
20141224 16:36:48< vultraz> Not much
20141224 16:37:00< vultraz> Like the Black Forest thing, though
20141224 16:37:11< vultraz> It's nice
20141224 16:38:11-!- cib_ [~cib@tmo-096-241.customers.d1-online.com] has quit [Ping timeout: 244 seconds]
20141224 16:47:37-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Bye for now]
20141224 16:53:50-!- cib0 [~cib@tmo-096-241.customers.d1-online.com] has joined #wesnoth-dev
20141224 17:03:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141224 17:54:41-!- irker420 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20141224 17:55:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141224 17:55:53-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev
20141224 18:22:08-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141224 18:25:51< fendrin> vultraz: Maybe you like to help a little with the editor help section?
20141224 18:27:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20141224 18:28:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141224 18:30:24-!- fendrin [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20141224 18:38:07-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20141224 18:44:23-!- Necrosporus_ is now known as Necrosporus
20141224 18:51:29-!- Kexoth [~kex@77.29.85.171] has quit [Remote host closed the connection]
20141224 18:55:34-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20141224 19:14:53-!- Sulfur [~Miranda@p5B0080EA.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141224 19:21:48< Necrosporus> If it's cool in North and hot in South, it means that main map is depicting the northern hemisphere
20141224 19:22:29< Necrosporus> But does it include equator and parts of southern hemisphere too or it's located in northern entirely?
20141224 19:31:32-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Quit: leaving]
20141224 19:31:53-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20141224 19:32:15< zookeeper> no one knows
20141224 19:33:06< Necrosporus> were there attempts to combine all campaign maps into one?
20141224 19:37:17-!- localuser- [~none@gateway/tor-sasl/localuser-] has quit [Ping timeout: 250 seconds]
20141224 19:38:21< zookeeper> i thought that's what i did
20141224 19:39:36< zookeeper> unless you mean literally, in which case you already know the attempt
20141224 19:40:34< zookeeper> or if not, then nevermind and forget i ever said anything
20141224 19:47:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141224 20:33:51< Necrosporus> I mean literally, overlap this maps by known points to give a large map
20141224 20:44:18< Necrosporus>  {NO_SCOUTS} recruitment_pattern=mixed fighter,fighter,scout,fighter
20141224 20:44:39< Necrosporus> Two lines from TRoW
20141224 20:45:03< Necrosporus> no scouts and in same time scouts in recruitment pattern, is it ok?
20141224 20:49:56-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20141224 20:50:13-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20141224 20:50:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141224 20:54:36< zookeeper> it is ok
20141224 20:55:12< zookeeper> {NO_SCOUTS} only prohibits the extra scouts recruited at scenario start for initial village grab
20141224 20:55:39< zookeeper> which recruitment_pattern doesn't affect
20141224 20:58:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141224 21:08:50< Necrosporus> Seems like on easier diffulty there are more units enemy recruits
20141224 21:08:57< Necrosporus> quite strange
20141224 21:13:15-!- irker665 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20141224 21:13:15< irker665> wesnoth: Chris Beck wesnoth:master 171f92a6a5ef / / (4 files in 3 dirs): move wml [open_help] impl to lua http://git.io/J3ddSg
20141224 21:13:15< irker665> wesnoth: Chris Beck wesnoth:master b6da5d06669d / src/scripting/ (game_lua_kernel.cpp game_lua_kernel.hpp): lua kernel: add accessor for event_info stack http://git.io/1y45TQ
20141224 21:13:16< irker665> wesnoth: Chris Beck wesnoth:master d7bf5be356d7 / / (4 files in 3 dirs): move wml [animate_unit] to lua http://git.io/qfFUGQ
20141224 21:13:17< irker665> wesnoth: Chris Beck wesnoth:master 36f57ff03a18 / / (4 files in 3 dirs): Merge branch 'to_lua' http://git.io/g80Zlg
20141224 21:15:36< Necrosporus> "Free, I’m free, and I feel the Ruby of Fire! It will be mine." - "No you won’t, you soldier of darkness!"
20141224 21:15:46< Necrosporus> Maybe s/you/it/ ?
20141224 21:19:32< irker665> wesnoth: Chris Beck wesnoth:master e73c57ead749 / / (4 files in 3 dirs): move wml [endlevel] impl to lua, and split into many lua funcs http://git.io/iwcH7A
20141224 21:21:40< zookeeper> "No you won’t" isn't referring to the ruby.
20141224 21:27:13< Necrosporus> what is it referring to?
20141224 21:27:42< Necrosporus> I though if there is a shortened sentence it refers to the subject of previous speaker
20141224 21:28:56-!- prkc [~prkc@4E5CCCAE.dsl.pool.telekom.hu] has quit [Read error: Connection reset by peer]
20141224 21:35:32-!- prkc [~prkc@4E5CCCAE.dsl.pool.telekom.hu] has joined #wesnoth-dev
20141224 21:40:43< zookeeper> it refers to whoever it's being said to, if they expressed some kind of intent of what they're going to do
20141224 21:40:46< zookeeper> AFAIK anyway
20141224 21:43:16< Necrosporus> Also in 07_Return_to_Oldwood (store only) woses are in different team and so the minimap shows them as enemies
20141224 21:43:41< zookeeper> well that would be worth fixing
20141224 21:43:50< Necrosporus> It doesn't change much but before I knew it was going to be story-only I though that I was going to fight them
20141224 21:44:03< Necrosporus> * story
20141224 21:46:00-!- ToBeCloud [uid51591@gateway/web/irccloud.com/x-fxsmadzzfgnxzyjs] has joined #wesnoth-dev
20141224 22:19:27-!- cib0 [~cib@tmo-096-241.customers.d1-online.com] has quit [Ping timeout: 245 seconds]
20141224 22:20:31-!- cib0 [~cib@tmo-096-241.customers.d1-online.com] has joined #wesnoth-dev
20141224 22:23:11-!- Coffee_irc [~david@ppp118-210-58-226.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20141224 22:26:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141224 22:41:16-!- cib0 [~cib@tmo-096-241.customers.d1-online.com] has quit [Ping timeout: 256 seconds]
20141224 22:58:00-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20141224 23:27:58-!- markus__ [~mjs-de@p508CB0BB.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141224 23:31:07-!- mjs-de [~mjs-de@p508C8A52.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
20141224 23:31:47-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 258 seconds]
20141224 23:33:56-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20141224 23:36:01-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20141224 23:42:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
--- Log closed Thu Dec 25 00:00:20 2014