--- Log opened Mon Dec 29 00:00:17 2014 20141229 00:11:18< gfgtdf> iceiceice: but carryover also uses the wmi_container container class 20141229 00:12:03-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20141229 00:12:28< iceiceice> y i guess it is just copied 20141229 00:12:50< iceiceice> i guess default copy for std::vector is not too bad? 20141229 00:13:08< iceiceice> i think its not maximally efficient but i dont think it will break anything 20141229 00:13:36< iceiceice> as long as the menu items are detached from the game_events then probably its fine 20141229 00:13:52< iceiceice> since i guess that thing gets torn down when you go to carryover 20141229 00:14:19< iceiceice> i wonder why the menu items are not just serialized as wml when they go to carryover... 20141229 00:14:46< gfgtdf> iceiceice: they are 20141229 00:14:49< iceiceice> hmmm 20141229 00:15:32< iceiceice> no but i mean, 20141229 00:15:43< iceiceice> why is carryover::wml_menu_items_ not just a config 20141229 00:15:54< gfgtdf> iceiceice: well in case that wmi_container is the only one that owns then an owing container would be muhc more clear that that shared_ptr version 20141229 00:16:03< iceiceice> *i mean, carryover_info::wml_menu_items 20141229 00:16:21< iceiceice> gfgtdf: yeah ptr_vector is probably better 20141229 00:16:36< iceiceice> i don't think any other object owns them but i would have to check to be sure 20141229 00:16:45< gfgtdf> iceiceice: idk, all functios it calls on carryover_info::wml_menu_items are set_menu_items(config&) and to_config() 20141229 00:17:00< gfgtdf> iceiceice: wmi_pger also own those obhect i think ? 20141229 00:17:03< gfgtdf> pager* 20141229 00:17:07< gfgtdf> owns* 20141229 00:17:14< iceiceice> wmi pager is just some silly adapter 20141229 00:17:41< iceiceice> up through 1.10 i guess, wmi_container has some hard coded limit that it will only emit 6 or 7 menu items for any given menu 20141229 00:17:51< iceiceice> for gui purposes 20141229 00:18:09< iceiceice> that's kind of grotesque, since its not really a gui object... 20141229 00:18:20< iceiceice> the wmi_pager slightly improves it by allowing to have pages 20141229 00:18:30< iceiceice> and it handles the limit 20141229 00:18:34< iceiceice> but the wmi pager is not realy a gui object either 20141229 00:18:42< iceiceice> the issue is that we don't really have a proper context menu class 20141229 00:18:51< iceiceice> so all these details end up kind of strewn about 20141229 00:19:07< iceiceice> i do not want to write a GUI1 context menu though... 20141229 00:19:42< iceiceice> some of the details are now bundled inside of "hotkey_handler", they were in play_controller before 20141229 00:19:42< gfgtdf> iceiceice: ah no it's hotkey_handler.hpp that own those items 20141229 00:19:52< gfgtdf> or at least the vector 20141229 00:20:17< gfgtdf> iceiceice: do hotkey_handler, and wmi_container whare objewct or do tehy have their own objects ? 20141229 00:20:22< gfgtdf> share* 20141229 00:20:43< iceiceice> i don't remember right now 20141229 00:21:31< iceiceice> i think wml_commands is just temporary actually 20141229 00:21:39< iceiceice> i think it gets populated from gamedata, 20141229 00:22:30-!- travis-ci [~travis-ci@ec2-54-196-66-210.compute-1.amazonaws.com] has joined #wesnoth-dev 20141229 00:22:30< travis-ci> wesnoth/wesnoth#5299 (master - 188e5c7 : Chris Beck): The build was fixed. 20141229 00:22:30< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45312153 20141229 00:22:30-!- travis-ci [~travis-ci@ec2-54-196-66-210.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141229 00:22:56< iceiceice> i think wml_commands_ basically holds the "current" hotkeys 20141229 00:23:06< gfgtdf> iceiceice: you shouldnt call our variable bar and foo_ in wmi_pager.cpp/hpp 20141229 00:23:19< iceiceice> because, the list gets recreated for each possible click, since different hotkeys can be active at different hexes 20141229 00:23:22< iceiceice> gfgtdf: yeah thats true 20141229 00:30:56< irker782> wesnoth: Chris Beck wesnoth:master 098d886db97c / src/ (7 files in 2 dirs): lua: move wesnoth.races code to its own file http://git.io/fFg9kQ 20141229 00:30:58< irker782> wesnoth: Chris Beck wesnoth:master cf665ffbf2a9 / src/seed_rng.cpp: simplify preprocessor code in seed_rng.cpp http://git.io/PeRfPg 20141229 00:31:00< irker782> wesnoth: Chris Beck wesnoth:master 497ed6f5160c / / (4 files in 3 dirs): move wml [heal_unit] impl to lua http://git.io/QARCdQ 20141229 00:31:03< irker782> wesnoth: Chris Beck wesnoth:master 64ee2d8e10d2 / / (11 files in 4 dirs): Merge branch 'lua' http://git.io/QAA3lA 20141229 00:32:04-!- enchilado [~enchilado@defocus/yummy/enchilado] has quit [Remote host closed the connection] 20141229 00:33:14-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-slfkwwjjzbsvxmmp] has joined #wesnoth-dev 20141229 00:34:28-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-slfkwwjjzbsvxmmp] has quit [Changing host] 20141229 00:34:28-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev 20141229 00:40:37< irker782> wesnoth: Chris Beck wesnoth:master 5c9bb9345c0f / .travis.yml: travis: enable MP_TEST on -O0, reduce wml test timer http://git.io/jv3kyQ 20141229 00:42:53< shadowm> iceiceice: This is just a survey and I'm not saying I'll work on it or anything. How would you do changelogs if you wanted to cover the needs of Git-impaired players, content authors, and mainline developers? 20141229 00:43:09< shadowm> (All three simultaneously.) 20141229 00:43:36< iceiceice> i'm assuming this is in reference to the forum thread with anonymissimus 20141229 00:43:48< shadowm> Um. 20141229 00:44:14< iceiceice> anyways i think i would not change anything except, 20141229 00:44:22< shadowm> Potentially? I think I saw the word "changelog" mentioned once or twice but I wasn't really paying attention. This is more of an issue I've beeing observing for years already. 20141229 00:44:43< iceiceice> (1) it should be clear on the wiki that, compatability breaking changes to WML / lua (stuff that would interest UMC authors) should go into the RELEASE NOTES 20141229 00:45:18< shadowm> There's a fourth unmentioned issue which is that at the time we release a .0 stable release, there isn't a unified WML changelog. 20141229 00:45:21< iceiceice> (2) there should be some place, either a new file or that stickied forum thread, that is should get appended with the newly announced changes 20141229 00:45:38< iceiceice> as part of the release process 20141229 00:45:47< shadowm> Or, well, there apparently *is* supposed to be, in the form of a forum thread, which people may forget to edit and isn't as comfortable as having a file on the Git repository anyway? 20141229 00:46:15< shadowm> And I for one have never used it and nobody's told me to do so either? /o\ 20141229 00:46:49< iceiceice> yeah i mean idk about the logistics, but imo we should ideally pick some method like this that's "official" and then document it on the wiki, hopefully people will know then and it won't just fall to zookeeper / whoever to pickup the pieces 20141229 00:46:53< shadowm> I'd like us to abandon forum threads for documentation, really. 20141229 00:47:45< shadowm> Firstly, it forces developers to have moderator powers, which is an issue. Secondly, it forces developers to read the forums at all, and many of them are reluctant to do so for one or another reason. 20141229 00:48:42< iceiceice> yeah, imo even a wiki page is in some ways better than a forum thread... 20141229 00:48:53< iceiceice> but it has the advantage that pretty much all umc makers can use the forum easily, 20141229 00:48:55< shadowm> It has history, which is great. 20141229 00:49:11< iceiceice> and, you can copy paste the release notes stuff to the forum thread in theory i guess.. 20141229 00:49:22< shadowm> They really should be able to use the wiki too (ReferenceWML etc.). 20141229 00:50:04< iceiceice> we could quite easily just start a "wml_changelog" file , ( "umc_changelog" ? ) 20141229 00:50:30< shadowm> Yeah, but then we get the same situation we have right now with players_changelog, people forgetting to add their changes to all changelogs. 20141229 00:50:51< shadowm> Or any of them at all. 20141229 00:51:25-!- travis-ci [~travis-ci@ec2-54-145-247-123.compute-1.amazonaws.com] has joined #wesnoth-dev 20141229 00:51:25< travis-ci> wesnoth/wesnoth#5300 (master - 978ae9e : Chris Beck): The build was fixed. 20141229 00:51:25< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45312355 20141229 00:51:25-!- travis-ci [~travis-ci@ec2-54-145-247-123.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141229 00:51:39< shadowm> From the 1.12 RC 2 front page post: "a considerably more technical “full” changelog." 20141229 00:51:58< shadowm> "Check the forum thread for a list of the most notable changes in this release, some of them mysteriously missing from the full changelog." 20141229 00:52:21< shadowm> It's far from the first time that's happened 20141229 00:52:58< iceiceice> i think part of it is a documentation issue tbh 20141229 00:53:04< iceiceice> the changelogs are mainly mentioned here: 20141229 00:53:05< iceiceice> http://wiki.wesnoth.org/DeveloperGuide 20141229 00:53:23< iceiceice> its not clear from this, what if anything should go in release notes besides dependencies? 20141229 00:53:30< shadowm> The fact is that none of the developers active at the time didn't get told to use the changelogs before. 20141229 00:53:57< shadowm> So yes, we lack documentation, but are people going to check the documentation every time they make a commit? 20141229 00:53:58< iceiceice> i think there might not be a consensus on what is "significant enough" 20141229 00:54:20< shadowm> Full changelog: EVERYTHING is significant enough unless it only concerns mainline developers. 20141229 00:54:33< shadowm> Players changelog: only stuff that directly impacts players. 20141229 00:54:57< shadowm> I don't see much room for ambiguity here. 20141229 00:55:02< iceiceice> where are you reading from? 20141229 00:55:12< iceiceice> I see this: `Don't forget changelogs: changelog for any (significant enough) changes and player_changelog for changes visible to users.` 20141229 00:55:14-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has quit [Remote host closed the connection] 20141229 00:55:18< shadowm> Some portion of my brain. 20141229 00:55:56< iceiceice> yeah maybe that should be photocopied onto the wiki :) 20141229 00:56:11< shadowm> This page is soooo visible. 20141229 00:56:42< iceiceice> to me, ` EVERYTHING is significant enough unless it only concerns mainline developers.` sends a very different message from ` changelog for any (significant enough) changes` 20141229 00:57:14< shadowm> a) It's linked from StartingPoints, which people do not see unless they visit wiki.wesnoth.org's root (which isn't linked anywhere). 20141229 00:58:03< shadowm> b) It's linked from two more pages that are linked to from places which aren't exactly the most visible to new contributors. 20141229 00:58:36< shadowm> It's funny how every talk about change goes back to the issue of having a disorganized wiki. 20141229 00:59:09< iceiceice> idk i actually think most devs have seen the developer resources pages 20141229 00:59:12< shadowm> http://wiki.wesnoth.org/Project <- This is the most visible link a prospective contributor would check. 20141229 00:59:32< shadowm> So I'm there, and I'm a total noob. What do I read first? (Hint: not the top links.) 20141229 01:00:07< shadowm> I need someone to hold my hand for a moment because there are a lot of links and I don't know where to begin if I've never contributed to an OSS project before. 20141229 01:00:20< iceiceice> probly you just read it all 20141229 01:00:33< iceiceice> most likely at some point you read the one described "DeveloperGuide - for those who received repository commit rights" 20141229 01:00:46< shadowm> In fact, in a more realistic scenario, I wouldn't be here if someone didn't pretty much tell me "join #wesnoth-dev, ask around". 20141229 01:00:50< iceiceice> these pages are not very long, most of them are seriously like only one or two printed pages 20141229 01:01:32< shadowm> Yeah, I wasn't told to read DeveloperGuide. 20141229 01:01:32-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Read error: Connection reset by peer] 20141229 01:01:46-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev 20141229 01:01:46-!- iceiceice [~chris@50.245.222.235] has quit [Changing host] 20141229 01:01:46-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141229 01:02:09< shadowm> I figured out all of these on the field, with people telling me off after every mistake. 20141229 01:02:11< iceiceice> i definitely read DeveloperGuide, 20141229 01:02:27< iceiceice> i think that in fact the changelog policy is not documented very clearly 20141229 01:02:39< shadowm> (Also, it looked like this at the time: http://wiki.wesnoth.org/index.php?title=DeveloperGuide&oldid=16987 ) 20141229 01:03:21< iceiceice> yeah its much better now :) 20141229 01:03:22< shadowm> So, if I wanted to correct mis(sing )information now, where would I begin? 20141229 01:03:57< iceiceice> idk, make a section in bold "Changelogs" 20141229 01:04:10< iceiceice> write one sentence about what a changelog is 20141229 01:04:24< iceiceice> copy your sentence before about "EVERYTHING unless ..." to be the `changelog` description 20141229 01:04:33< iceiceice> copy your sentence about player_changelog also 20141229 01:04:34< shadowm> I meant in general. I'd rather not add more pages or sections in existing pages (unless they are already poorly structured). 20141229 01:04:39< iceiceice> then try to write something comprehensive about RELEASE_NOTES 20141229 01:04:41< iceiceice> besides just dependencies 20141229 01:05:59< iceiceice> idk i think this is like a 5 minutes task, i would do it but i don't consider myself authoritative on this 20141229 01:06:10< iceiceice> i mostly haven't edited these kinds of pages unless there is an email / some outside review 20141229 01:07:06< iceiceice> its better to have this kind of stuff on the wiki though, otherwise it might get forgotten when people go on wesbreak 20141229 01:09:13< shadowm> I'm editing DeveloperGuide. 20141229 01:12:51< shadowm> This page mentions commit message style but... 20141229 01:13:27< shadowm> But Project has a link to this: http://wiki.wesnoth.org/GoodCommitCommentingPractice 20141229 01:14:01< shadowm> iceiceice: If you were the hypothetical noob in question, would you prefer to follow yet another link, or have it all on a single page? 20141229 01:14:52< shadowm> I for one think we have too many lists of links everywhere and very few step-by-step guides. 20141229 01:15:49< shadowm> Lists of links labeled with just the target page titles, that is, which are often cryptic and out of order. 20141229 01:17:08< iceiceice> i like that in developer resources, the list is of the form " link -- purpose of that page " 20141229 01:18:02< shadowm> "I want to start coding, what can I do?" -- GettingStarted isn't even the first link. 20141229 01:18:12< iceiceice> to me it makes the most sense to have info oriented on pages based on target audience, and subdivided into sections based on content, rather than have a different page for every "thing" 20141229 01:18:16< shadowm> And... it's not even developer documentation. 20141229 01:18:42< shadowm> And this page has UMC links mixed in. 20141229 01:19:02< shadowm> Old forum topics. 20141229 01:19:18< shadowm> A dead link. 20141229 01:19:30< iceiceice> yeah there are unfortunately several different "developer central" type pages, 20141229 01:19:36< iceiceice> you have to try a few i guess until you find the good ones 20141229 01:19:54< iceiceice> http://wiki.wesnoth.org/DevelopersHome 20141229 01:20:00< shadowm> Well, I'm editing DeveloperGuide and then if I come across an inferior page I'll replace it with a redirect to that. 20141229 01:20:13< iceiceice> http://wiki.wesnoth.org/Project#Developers 20141229 01:20:53< iceiceice> etc. 20141229 01:26:35< shadowm> I'm going to ignore point 5 in http://wiki.wesnoth.org/GoodCommitCommentingPractice because seriously who ever does that. 20141229 01:27:07< shadowm> We have organically embraced SHA1s as a way of life. 20141229 01:27:34-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev 20141229 01:29:31< gfgtdf> shadowm: if the sha referes to a local commit id that is differente from the github repo it isnt useful at all for other people. 20141229 01:30:06< shadowm> Hm, yeah, but that's kind of a given. 20141229 01:31:09< shadowm> I could add a point like "if you need to mention commit SHA1s, make sure to use the upstream repository SHA1s instead of locals that may be changed by a merge or rebase" or so. 20141229 01:33:44-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20141229 01:35:01< shadowm> "Mention a developer's IRC name will ping him on IRC (when the bot report it), and if he's not there, he may see it on the IRC logs" Ah, those were the days. 20141229 01:51:27< shadowm> iceiceice: "Important changes that might be expected to inconvenience or confuse players (including those building from source) or content creators, major bug fixes, and noteworthy feature additions for a future release should be mentioned and explained in RELEASE_NOTES as well, so that the release team can include this information in official announcements. See the contents of the file for instructions." 20141229 01:51:33< shadowm> Good? 20141229 01:52:37< iceiceice> yeah sounds good to me :) 20141229 01:52:43< shadowm> Nowadays I scan the changelogs for other items to mention (especially if R_N seems too short) and ask around, but that's not guaranteed I guess. 20141229 01:53:14< shadowm> Well, I've just finished editing the first two sections here: http://wiki.wesnoth.org/DeveloperGuide#General 20141229 01:53:35< shadowm> I mean the first section, and added another section before it. 20141229 01:54:04< shadowm> "If you build with scons, use clang rather than gcc, as it is 2-3x faster to compile wesnoth." cmake also knows about clang. 20141229 01:55:14< shadowm> Though I honestly don't know why people prefer cmake to scons. It's a nuisance, mostly owing to a few quirks of our recipe. 20141229 01:56:14< shadowm> Like when I told people to tell cmake to not -DNDEBUG for Release/RelWithDebInfo builds. Now we're stuck with CMAKE_CXX_FLAGS getting overwritten by the recipe every time. 20141229 01:57:20< shadowm> Hm wait no, that's not it. 20141229 01:57:56< shadowm> It's because the recipe overwrites it with "-std=c++98 -W -Wall -Werror -Wno-strict-aliasing -Wno-unused-local-typedefs -Wno-literal-suffix -Wold-style-cast", which is a wholly different issue. 20141229 02:00:27< shadowm> It seems like we should be using something else to do that without overwriting the user-supplied CMAKE_CXX_FLAGS. 20141229 02:00:52< shadowm> Maybe I'll go and read its documentation later. 20141229 02:01:55< shadowm> The -DNDEBUG removal is actually non-destructive, good. 20141229 02:04:33-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 256 seconds] 20141229 02:06:22-!- sachith500 [~kvirc@101.189.46.81] has quit [Ping timeout: 250 seconds] 20141229 02:17:13-!- iceiceice [~chris@pool-72-82-162-242.cmdnnj.east.verizon.net] has joined #wesnoth-dev 20141229 02:17:13-!- iceiceice [~chris@pool-72-82-162-242.cmdnnj.east.verizon.net] has quit [Changing host] 20141229 02:17:13-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141229 02:18:48< iceiceice> hmm i got disconnected 20141229 02:18:55< iceiceice> i wrote: 20141229 02:19:01< iceiceice> yeah i think when i wrote that stuff about clang i had basically 0 knowledge of cmake 20141229 02:19:08< iceiceice> it's also mentioned somewhere else, that section probably doesn't need to be there 20141229 02:20:01< iceiceice> back again later 20141229 02:20:03-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Client Quit] 20141229 02:49:23< shadowm> How said is it that I can instantly recognize c74d's documentation prose? 20141229 02:49:26< shadowm> *sad 20141229 02:50:16< shadowm> "needn't". "Apple OS X". "Unix descendent". 20141229 02:50:56< shadowm> "". 20141229 02:55:11< vultraz> yup :P 20141229 02:55:21< vultraz> I can also recognize yours 20141229 02:57:17< shadowm> Shall I try? 20141229 03:02:28< vultraz> and once again, I have no idea how to fix the wiki 20141229 03:02:30< shadowm> "essentially", "potentially", "probably", "perhaps", "maybe", "I surmise", "seems like", "appears", "chocolate", "deplorable", "obtuse", "oblique", "superfluous", "Linux". 20141229 03:02:59< shadowm> That was actually much harder than I expected. 20141229 03:03:37< vultraz> don't forget "pony" 20141229 03:04:06< vultraz> "squeaky mallet" 20141229 03:04:42< shadowm> I misplaced my mallet some months ago. 20141229 03:08:01< vultraz> "[0x][0x][0x][0x]" 20141229 03:08:31< shadowm> I think you mean... 20141229 03:08:32< shadowm>  20141229 03:09:30< shadowm> [DOr the alternative, 20141229 03:10:15< vultraz> yeah 20141229 03:10:27< shadowm> And several others which I can't reliably reproduce under standard conditions. 20141229 03:11:49< shadowm> vultraz: Did you see gfgtdf et al's messages from earlier? They were addressed to you. 20141229 03:12:28-!- Ivanovic_ [~ivanovic@frnk-5f751d06.pool.mediaWays.net] has joined #wesnoth-dev 20141229 03:13:27< shadowm> I don't think anyone reverted your commit since then. 20141229 03:15:04< vultraz> am I supposed to follow number-san's suggestion? 20141229 03:15:42-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 250 seconds] 20141229 03:15:42-!- Ivanovic_ [~ivanovic@frnk-5f751d06.pool.mediaWays.net] has quit [Changing host] 20141229 03:15:42-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20141229 03:15:58< shadowm> I don't like it but it's your choice. 20141229 03:16:03< vultraz> as in, wesnoth.set_variable((trim(w))) 20141229 03:16:36-!- Ivanovic_ is now known as Ivanovic 20141229 03:22:22< vultraz> but then.. 20141229 03:22:24< vultraz> [10:08:36] iceiceice i was pretty sure that lua ignores extra return values if you don't put them somewhere 20141229 03:22:30< vultraz> ...who's correct 20141229 03:25:21< vultraz> ( also: lol: http://wiki.wesnoth.org/Roadmap ) 20141229 03:29:05-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141229 03:40:58-!- irker782 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20141229 03:44:11-!- sachith500 [~kvirc@101.189.46.81] has joined #wesnoth-dev 20141229 03:56:02-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Remote host closed the connection] 20141229 04:03:53-!- gfgtdf [~chatzilla@f054053068.adsl.alicedsl.de] has quit [Read error: Connection reset by peer] 20141229 04:10:51< c74d> What is this? 20141229 04:11:10< c74d> Oh, WesnothRepository. 20141229 04:12:00< c74d> vultraz: `foo(function_returning_multiple_values(...))` does "put them somewhere"; it passes them to `foo`. 20141229 04:12:59-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141229 04:14:15-!- gfgtdf [~chatzilla@f054053068.adsl.alicedsl.de] has joined #wesnoth-dev 20141229 04:15:00< gfgtdf> does anyone here know why we store the original cfg_ in unitclass instead of havin all in member variables ? 20141229 04:15:32< gfgtdf> also for units attack_type we do that 20141229 04:18:02< shadowm> I am no code historian, but I surmise the former might be an artifact of allowing people to set arbitrary attributes in units outside [variables], which IIRC worked (unreliably though) at some point. 20141229 04:18:04-!- gfgtdf [~chatzilla@f054053068.adsl.alicedsl.de] has quit [Client Quit] 20141229 04:19:50< c74d> I'm actually rather surprised to find that there *aren't* any such "gratuitous" brackets around URLs. 20141229 04:20:10< shadowm> Don't you dare add them. 20141229 04:20:25< c74d> I considered it, but decided against it. 20141229 04:20:35< shadowm> Also, what do you mean "there aren't"? 20141229 04:20:52< shadowm> "Then register the key with GitHub, by going to , [...]" 20141229 04:21:34< c74d> Commata are valid as URI pchars. 20141229 04:21:38< shadowm> Noting that the contents between brackets are already a link by virtue of being formatted as HTML elements by MW. 20141229 04:22:02< shadowm> Thus turning the brackets into a pointless eyesore. 20141229 04:22:18< shadowm> The likes of which shall not be tolerated in this wiki, under penalty of death. 20141229 04:22:33< c74d> Thus, the greater-than sign has the purpose and use of separating the URL from the comma. 20141229 04:22:48< shadowm> Nope. 20141229 04:23:03< shadowm> "

Then register the key with GitHub, by going to <https://github.com/settings/ssh>," 20141229 04:23:19-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev 20141229 04:23:19-!- iceiceice [~chris@50.245.222.235] has quit [Changing host] 20141229 04:23:19-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141229 04:23:19-!- irker202 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20141229 04:23:19< irker202> wesnoth: Chris Beck wesnoth:master dec551ee9ea2 / src/ (wmi_pager.cpp wmi_pager.hpp): wmi_pager: give better names to some variables http://git.io/JlOgvA 20141229 04:23:23< shadowm> Look at that, it's an element. 20141229 04:24:19< shadowm> Whyever would you reinvent a wheel your browser already provides four-fold? 20141229 04:25:49< c74d> The markup... ought to be enough. 20141229 04:26:09< shadowm> Ye. 20141229 04:26:15< iceiceice> vultraz: i don't think there was any disagreement on the lua point, 20141229 04:26:40< shadowm> That's what I've been trying to say. I'm glad to see you've finally seen the light, c74d. 20141229 04:26:59< iceiceice> i did have an educational experience about lua's syntax though, much thanks to c74d 20141229 04:27:35< c74d> Ought to, but it won't be if the page is rendered to plain text (and the renderer doesn't delimit the URL itself), nor possibly if the user copies-and-pastes it manually. 20141229 04:27:49< iceiceice> you should use what you think is most readable... in my opinion the double ( ) is less readable, and i doubt if there is any substantive difference 20141229 04:28:13< shadowm> c74d: :| 20141229 04:28:40< iceiceice> i have to leave, and nurse my poor poor battery back to health 20141229 04:28:41< iceiceice> gnight 20141229 04:28:43-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20141229 04:28:51< shadowm> This isnt' funny, c74d. 20141229 04:32:09< irker202> wesnoth: Charles Dang wesnoth:master e35c301ff4f4 / data/lua/wml-tags.lua: Fixed clear_variable by only calling first argument of of trim() http://git.io/ZiShXg 20141229 04:32:12< irker202> wesnoth: Charles Dang wesnoth:master cc0d274c73f9 / projectfiles/CodeBlocks/wesnoth.cbp: Updated codeblocks projectfile http://git.io/lN8wUA 20141229 04:33:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141229 04:33:42< shadowm> vultraz: Um, actually, why is the responsibility of discarding the second string.gsub return value delegated to trim()'s callers? 20141229 04:34:01< shadowm> Shouldn't it be trim()'s responsibility like it used to be= 20141229 04:35:58< vultraz> Is there a way to do that without the local variable? 20141229 04:36:06< vultraz> If not I might as well revert 20141229 04:37:42< shadowm> Maybe the same thing you just did but on the return statement instead. c74d should know. 20141229 04:38:12 * vultraz calls for the great numbers-san 20141229 04:39:49< c74d> vultraz: is that me, or a different one? 20141229 04:39:55< vultraz> you 20141229 04:40:06< c74d> 'k, thanks. 20141229 04:40:13< c74d> Way to do what? 20141229 04:40:32< c74d> Discarding all but the first return values? 20141229 04:41:01< vultraz> yes, within the function without a local variable 20141229 04:41:21< vultraz> hm 20141229 04:41:23< vultraz> return (string.gsub(s, "^%s*(.-)%s*$", "%1")) 20141229 04:41:24< c74d> `return (f(...))` 20141229 04:41:25< vultraz> seems to work 20141229 04:41:50< c74d> `return (s:gsub("^%s*(.-)%s*$", "%1"))` 20141229 04:43:02< vultraz> does that also work for gmatch? 20141229 04:43:51< c74d> The `object:method(args)` syntax? Yes. 20141229 04:44:46< c74d> It should work for any `object` that is a string with any `method` that is a key in the `string` table. 20141229 04:48:00-!- ToBeCloud [uid51591@gateway/web/irccloud.com/x-jpbetpsnqquwtraw] has quit [Quit: Connection closed for inactivity] 20141229 04:48:04< irker202> wesnoth: Charles Dang wesnoth:master fa079a1b3fb2 / data/lua/wml-tags.lua: Return first value of trim() within the function as opposed to at the call http://git.io/YHCuyQ 20141229 04:48:07< irker202> wesnoth: Charles Dang wesnoth:master c762937e746b / data/lua/wml-tags.lua: Simplified object:method syntax for trim() and split() http://git.io/EB07dg 20141229 04:52:47< vultraz> now everyone is happy and nothing is broken 20141229 05:08:51-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev 20141229 05:08:51-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host] 20141229 05:08:51-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141229 05:10:35< iceiceice> actually, i'm still not happy, because things were broken in some trivial way and the unit tests didn't find it... 20141229 05:11:58< vultraz> speaking of broken, someone broke the Esc hotkey in the editor 20141229 05:12:32-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 258 seconds] 20141229 05:29:47-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev 20141229 05:33:20-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.0.1] 20141229 05:39:35< irker202> wesnoth: Chris Beck wesnoth:master a273be552018 / data/test/scenarios/test_clear.cfg wml_test_schedule: add a wml unit test for {CLEAR_VARIABLE} macro http://git.io/sFT9hQ 20141229 05:41:18< iceiceice> vultraz: i think this test would have caught the bug 20141229 06:06:02< vultraz> iceiceice: any progress on the conditionals thing? 20141229 06:09:27< iceiceice> no, i think i probably should fix this other bug before i try to make more features 20141229 06:09:32< vultraz> and in extension, how come [while] and [switch] and [if] implemented in C++ 20141229 06:09:33< vultraz> er 20141229 06:09:35< vultraz> lua 20141229 06:09:35-!- Sulfur [~Miranda@p5B008CF0.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141229 06:09:42< vultraz> and [and] [or] [not] in C++ 20141229 06:09:50< iceiceice> https://gna.org/bugs/index.php?23115 20141229 06:10:13< iceiceice> vultraz: i don't know 20141229 06:10:31< iceiceice> for what it's worth, i also dont really agree with the "65536" maximum loop bound or whatever... 20141229 06:10:36< iceiceice> or at least it should be documented on the wiki imo 20141229 06:10:45< iceiceice> (i don't remember seeing it, maybe it is there...) 20141229 06:11:20< vultraz> I don't see that that bug 20141229 06:11:24< iceiceice> vultraz: i think filters need to be in C++ 20141229 06:11:43< iceiceice> and they also need the [and] [or] [not] code 20141229 06:11:51< iceiceice> but since its all duplicated right now... i have no good explanation 20141229 06:12:12< iceiceice> probably someone just didn't want to go through the trouble of figuring out how best to make it not duplicated 20141229 06:12:45< iceiceice> vultraz: the bug only applies to custom wml menu items 20141229 06:13:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20141229 06:14:32< vultraz> ah 20141229 06:14:36< vultraz> yes, I see it now 20141229 06:16:28< vultraz> this is serious 20141229 06:26:41< iceiceice> yes it is... 20141229 06:27:05< iceiceice> it only broke a few days ago, i know which commit did it... but i think it will take a little bit to figure out what the right thing to do is 20141229 06:28:05< zookeeper> WRT changelogs, i think ideally we'd only have one editable changelog, with some very simple markup to differentiate between all/player/UMC/WML/whatever changes that could trivially be split into several corresponding files on release. 20141229 06:28:37< zookeeper> trivially by some simple tool, that is, not by hand 20141229 06:28:54< irker202> wesnoth: Charles Dang wesnoth:master f8c811fa4f69 / data/lua/wml-tags.lua: Simplified syntax for wml_actions.chat() http://git.io/Sq15lw 20141229 06:39:09< c74d> Egh. MediaWiki parses "https://google.com/, blah" as ", blah", not the correct " blah"? 20141229 06:40:20 * c74d rolls up an imaginary copy of IETF RFC 3986 appendix A. 20141229 06:40:41 * shadowm facepalms. 20141229 06:45:16< vultraz> iceiceice: should calculate_damage and round_damage be helper functions? 20141229 06:47:25< vultraz> jesus, harm_unit is huge o_o 20141229 06:47:39< c74d> And yet it parses "https://google.com/›" as a URL, including the "›"‽ 20141229 06:47:49< c74d> *ttha ttha* 20141229 06:48:43< vultraz> dis...indent... 20141229 06:51:25-!- sachith500 [~kvirc@101.189.46.81] has quit [Ping timeout: 255 seconds] 20141229 07:19:46-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has joined #wesnoth-dev 20141229 07:20:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141229 07:22:54-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20141229 07:51:02-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141229 07:56:12-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141229 07:59:47-!- heirecka_ [~heirecka@j61898.servers.jiffybox.net] has joined #wesnoth-dev 20141229 08:00:18-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 252 seconds] 20141229 08:00:22-!- heirecka_ is now known as heirecka 20141229 08:00:33-!- heirecka [~heirecka@j61898.servers.jiffybox.net] has quit [Changing host] 20141229 08:00:33-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev 20141229 08:19:21-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev 20141229 08:19:28-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host] 20141229 08:19:28-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141229 09:05:01-!- mjs-de [~mjs-de@p508CB614.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141229 09:30:02-!- irker202 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20141229 09:30:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141229 09:43:30-!- sachith500 [~kvirc@101.189.46.81] has joined #wesnoth-dev 20141229 09:53:07-!- cib0 [~cib@tmo-103-81.customers.d1-online.com] has joined #wesnoth-dev 20141229 09:56:29-!- mjs-de [~mjs-de@p508CB614.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20141229 09:59:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20141229 10:00:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141229 10:10:48-!- DCW1 [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev 20141229 10:19:57-!- DCW1 [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Remote host closed the connection] 20141229 10:21:34-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 255 seconds] 20141229 10:44:32< vultraz> wat 20141229 10:48:48< vultraz> icecube seems to have made more bugs 20141229 10:51:34 * vultraz waits for iceiceice's return 20141229 10:56:46-!- cib0 [~cib@tmo-103-81.customers.d1-online.com] has quit [Ping timeout: 258 seconds] 20141229 10:57:50-!- cib0 [~cib@tmo-103-81.customers.d1-online.com] has joined #wesnoth-dev 20141229 11:11:29-!- cib0 [~cib@tmo-103-81.customers.d1-online.com] has quit [Ping timeout: 245 seconds] 20141229 11:21:34-!- cib0 [~cib@tmo-103-81.customers.d1-online.com] has joined #wesnoth-dev 20141229 11:37:10-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Ping timeout: 255 seconds] 20141229 11:40:14-!- kex [~kex@77.28.18.23] has joined #wesnoth-dev 20141229 11:43:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141229 11:43:55-!- irker033 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20141229 11:43:55< irker033> wesnoth: 8573 wesnoth:master e23ff7009c6c / data/lua/ (wml-tags.lua wml/items.lua): Lua: Fix uses of `tostring` calls as LHSs to `or` http://git.io/d3G9xA 20141229 11:43:55< irker033> wesnoth: Charles Dang wesnoth:master 332e64f945da / data/lua/ (wml-tags.lua wml/items.lua): Merge pull request #353 from 8573/8573/fix/lua/tostring-calls-as-1st-operands-of http://git.io/WGq4iA 20141229 11:44:37-!- kex [~kex@77.28.18.23] has quit [Ping timeout: 240 seconds] 20141229 11:48:47-!- sachith500 [~kvirc@101.189.46.81] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 20141229 11:56:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20141229 12:02:44-!- kex [~kex@77.28.18.23] has joined #wesnoth-dev 20141229 12:05:48< zookeeper> merge from... where? O.o 20141229 12:13:49< vultraz> zookeeper: don't think about it too much :P 20141229 12:14:09< vultraz> that's typical branch naming for numbers-san 20141229 12:14:22< zookeeper> roger 20141229 12:15:04-!- Nostromus [~chatzilla@f054013116.adsl.alicedsl.de] has joined #wesnoth-dev 20141229 12:23:02< vultraz> also wesnoth seems to be crashing in the test scenario 20141229 12:25:16 * vultraz goes to do something else 20141229 12:30:04< vultraz> Guess I'll get back to my campaign revamps 20141229 12:30:11< vultraz> Might do something with the tutorial... 20141229 12:30:21< vultraz> ....this code is hideous 20141229 12:34:14< vultraz> what the hell 20141229 12:35:01< vultraz> more crash 20141229 12:37:12< Nostromus> Hi Vultraz, are you aware of bugs in LoW, ka'lian under attack? I get 2 Lua errors and can't finish the survive part. After survive the scenario is lost. 20141229 12:37:22< Nostromus> 1.13 20141229 12:37:32< vultraz> Low is fabi's domain 20141229 12:37:37< Nostromus> ok 20141229 12:37:39< vultraz> He's working on it 20141229 12:38:08< Nostromus> ok, no need to report this on gna? 20141229 12:39:01< vultraz> no 20141229 12:40:07< Nostromus> and the tutorial is that your domain? 20141229 12:41:47< vultraz> I'm simply going through all the campaigns and cleaning up the code 20141229 12:41:51< vultraz> Except LoW 20141229 12:45:14< Nostromus> ok, the tutorial has a bug: At the end of the first scenario, there is on console the message "missing era" or similar, and wesnoth exits. Maybe i should report this one. 20141229 12:45:24< Nostromus> also only 1.13 20141229 12:49:00< irker033> wesnoth: Charles Dang wesnoth:master 62b377235e57 / data/campaigns/tutorial/ (maps/1_Tutorial.map scenarios/1_Tutorial.cfg): Tutorial: split S1 map into its own file http://git.io/iYtOVQ 20141229 12:49:03< irker033> wesnoth: Charles Dang wesnoth:master 18284fef331c / data/campaigns/tutorial/ (8 files in 2 dirs): Renamed files for clarity http://git.io/2fQKQg 20141229 12:49:06< irker033> wesnoth: Charles Dang wesnoth:master d859adef3870 / data/campaigns/tutorial/scenarios/ (02_Tutorial_part_2.cfg 2_Speaking.cfg utils.cfg): Merge util files http://git.io/tvHNAw 20141229 12:55:01-!- mjs-de [~mjs-de@p508CB614.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141229 12:55:27-!- Sulfur [~Miranda@p5B008CF0.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141229 13:00:53< irker033> wesnoth: Charles Dang wesnoth:master c8756ca92cbe / data/campaigns/tutorial/maps/01_Tutorial_part_1.map: T S1: beautified map http://git.io/2sRAaQ 20141229 13:00:56< irker033> wesnoth: Charles Dang wesnoth:master d2fdcefbcb4e / data/campaigns/tutorial/scenarios/utils.cfg: T: dropped variable usage in LABEL and PRINT http://git.io/SDo9Tw 20141229 13:08:01< irker033> wesnoth: Charles Dang wesnoth:master 124d264f0ef1 / data/ (_main.cfg campaigns/tutorial/_main.cfg): Gave the tutorial it's own _main.cfg http://git.io/XcT9EA 20141229 13:08:03< irker033> wesnoth: Charles Dang wesnoth:master 02a79264bd8e / data/campaigns/tutorial/ (5 files in 3 dirs): Include utils only once, from main http://git.io/KRAHYA 20141229 13:10:23-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 256 seconds] 20141229 13:12:12< zookeeper> vultraz, shouldn't you just include the tutorial dir, not its _main.cfg? 20141229 13:12:31< vultraz> oh, right 20141229 13:13:28< vultraz> also, when was the last time this code was looked at...? 20141229 13:13:31< zookeeper> but don't worry, i'm not inspecting the diffs of every commit you make :P 20141229 13:13:40< zookeeper> a long time ago? 20141229 13:13:55< vultraz> Look at the MOVE macro 20141229 13:13:57< vultraz> *cringe* 20141229 13:14:19< zookeeper> i wish one day i'd finish the tutorial i started like 5 years ago or something 20141229 13:16:38< vultraz> oh, god, and the number of times this MOVE macro is used ;_; 20141229 13:22:32-!- boucman_work [~jrosen@193.56.60.161] has joined #wesnoth-dev 20141229 13:22:32-!- boucman_work [~jrosen@193.56.60.161] has quit [Changing host] 20141229 13:22:32-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141229 13:25:07< irker033> wesnoth: Charles Dang wesnoth:master 9b0c1a41bf6f / data/campaigns/tutorial/scenarios/ (01_Tutorial_part_1.cfg 02_Tutorial_part_2.cfg): T: dropped stable_singleplayer ai aliases http://git.io/Sh0nJw 20141229 13:25:10< irker033> wesnoth: Charles Dang wesnoth:master 799ac9d250e6 / data/_main.cfg: Don't include the tutorial's _main.cfg explicitly http://git.io/ImyXgg 20141229 13:25:13< irker033> wesnoth: Charles Dang wesnoth:master beaf189a6a0d / data/campaigns/tutorial/ (3 files in 2 dirs): T: replaced ALL cases of MOVE with MOVE_UNIT and deleted the former http://git.io/YREVyg 20141229 13:25:22< vultraz> god 20141229 13:26:03< vultraz> this code! I can't even 20141229 13:26:24< vultraz> it apparently predates [move_unit] AND turn events 20141229 13:26:27< zookeeper> oh, haha, it had the beginning coordinates too? cool 20141229 13:27:35< zookeeper> well, yes, the tutorial is from what, 1.2, 1.4, something like that? 20141229 13:28:34< vultraz> I have my work cut out for me 20141229 13:28:55< vultraz> made harder because for some reason, wesnoth is crashing at weird times 20141229 13:29:17-!- cib0 [~cib@tmo-103-81.customers.d1-online.com] has quit [Ping timeout: 272 seconds] 20141229 13:30:22-!- cib0 [~cib@tmo-103-81.customers.d1-online.com] has joined #wesnoth-dev 20141229 13:45:10-!- Sulfur [~Miranda@p5B008CF0.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141229 13:46:01-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20141229 13:46:29-!- cib0 [~cib@tmo-103-81.customers.d1-online.com] has quit [Ping timeout: 245 seconds] 20141229 13:46:41-!- boucman_work [~jrosen@193.56.60.161] has joined #wesnoth-dev 20141229 13:46:41-!- boucman_work [~jrosen@193.56.60.161] has quit [Changing host] 20141229 13:46:41-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141229 14:06:50-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev 20141229 14:08:02< vultraz> zookeeper: why...does this sentence have a female variation? "There is a village on the other side of the river. Visiting villages is a good idea, and ending your turn in one will heal you. To the village!" 20141229 14:15:48-!- gfgtdf [~chatzilla@f054053068.adsl.alicedsl.de] has joined #wesnoth-dev 20141229 14:22:03-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 244 seconds] 20141229 14:27:48< zookeeper> vultraz, presumably for the "ending your turn in one will heal you" part 20141229 14:28:10-!- boucman_work [~jrosen@193.56.60.161] has joined #wesnoth-dev 20141229 14:28:10-!- boucman_work [~jrosen@193.56.60.161] has quit [Changing host] 20141229 14:28:10-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141229 14:30:15-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev 20141229 14:32:32< gfgtdf> is one of upkeep=0, upkeep=loyal, upkeep=free deprecated ? 20141229 14:32:46< gfgtdf> actualy it seems like there 3 things do all the same 20141229 14:34:01-!- Nostromus [~chatzilla@f054013116.adsl.alicedsl.de] has quit [Remote host closed the connection] 20141229 14:34:09< vultraz> zookeeper: that has variable translations in different language? 20141229 14:34:12< vultraz> languages* 20141229 14:34:22< zookeeper> i don't know 20141229 14:36:11-!- Nostromus [~chatzilla@f054013116.adsl.alicedsl.de] has joined #wesnoth-dev 20141229 14:38:12< vultraz> It seem innocuous, since there are other, non-varied uses of 'you 20141229 14:38:30< vultraz> er, not innocuous, wrong word 20141229 14:38:32< vultraz> unnecessary 20141229 14:40:32< Nostromus> vultraz: This is not the only message with a female variation which seems not needed in the tutorial, maybe for translations or changes to messages, to remind you for the female part. 20141229 14:40:53< vultraz> *shrug* 20141229 14:40:57< vultraz> it's Delfador speaking 20141229 14:41:06< vultraz> I dunno, I might remove it or not 20141229 14:41:16< vultraz> right now I'm working on refactoring the rest of the code 20141229 14:44:49< irker033> wesnoth: mattsc wesnoth:master 637514e5232e / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project file http://git.io/Nvdr3w 20141229 14:53:30< vultraz> whoever wrote this had a fetish for wmllint comments 20141229 14:55:05< zookeeper> well, they were added afterwards, i'm sure 20141229 14:57:52-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20141229 15:00:57-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 258 seconds] 20141229 15:02:56-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev 20141229 15:11:02-!- Gallaecio [~quassel@105.153.165.83.dynamic.mundo-r.com] has quit [Read error: Connection reset by peer] 20141229 15:12:03< irker033> wesnoth: gfgtdf wesnoth:master 06228f09ecfe / src/ (6 files): put unit attack_type in new file. http://git.io/6JP5EQ 20141229 15:12:05< irker033> wesnoth: gfgtdf wesnoth:master 5c27af29788e / src/ (actions/attack.cpp unit.cpp unit_attack_type.cpp unit_attack_type.hpp): replace attack_type::get_cfg() http://git.io/9kvcig 20141229 15:12:07< irker033> wesnoth: gfgtdf wesnoth:master 4c39a2384357 / src/ (unit_abilities.cpp unit_attack_type.cpp unit_attack_type.hpp): remove duplicate information in attack_type http://git.io/PyJH3g 20141229 15:13:06< irker033> wesnoth: gfgtdf wesnoth:master 505f219c914c / src/unit_attack_type.hpp: fixup comment http://git.io/BODaag 20141229 15:23:50< irker033> wesnoth: mattsc wesnoth:master 77a0be46ad84 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project file http://git.io/jpxlWQ 20141229 15:27:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141229 15:29:55-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20141229 15:30:24< vultraz> hey iceiceice 20141229 15:42:23-!- localuser- [~none@gateway/tor-sasl/localuser-] has joined #wesnoth-dev 20141229 15:43:21-!- travis-ci [~travis-ci@ec2-54-237-37-121.compute-1.amazonaws.com] has joined #wesnoth-dev 20141229 15:43:21< travis-ci> gfgtdf/wesnoth-old#407 (unitattacks - d6ffd8f : gfgtdf): The build passed. 20141229 15:43:21< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/45360081 20141229 15:43:21-!- travis-ci [~travis-ci@ec2-54-237-37-121.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141229 15:43:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20141229 15:59:01-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev 20141229 16:03:29-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev 20141229 16:06:02< vultraz> time for testing 20141229 16:09:42< gfgtdf> does someone know whetre [portrait] in unitttype are used ? 20141229 16:09:45< iceiceice> hey vultraz 20141229 16:09:54< vultraz> iceiceice: I have discovered more bugs 20141229 16:11:32< vultraz> iceiceice: when I launch the test scenario: http://pastebin.com/SDUh7s2A 20141229 16:12:24< vultraz> additionally, trying to execute anything in the test scenario causes wesnoth to crash 20141229 16:13:04< gfgtdf> shikadibot: seen mordante 20141229 16:13:04< shikadibot> gfgtdf: Sorry, I don't know of mordante. 20141229 16:13:38< gfgtdf> shikadibot: seen Mordante 20141229 16:13:38< shikadibot> gfgtdf: Sorry, I don't know of Mordante. 20141229 16:13:41< gfgtdf> shikadibot: seen mordante 20141229 16:13:41< shikadibot> gfgtdf: Sorry, I don't know of mordante. 20141229 16:13:50< iceiceice> hmmm 20141229 16:13:52< vultraz> iceiceice: I don't see the lua errors in a main game, but [time_area] doesn't seem to work either 20141229 16:14:09< iceiceice> yeah i think i forgot to register the time area function... 20141229 16:14:12< gfgtdf> does anyon e know whether the [porttrait] tag is still WIP ? 20141229 16:14:25< vultraz> I have additionally noted that a wml error upon startup will now cause wesnoth to crash to desktop 20141229 16:14:36< iceiceice> yeah this commit 20141229 16:14:48< iceiceice> https://github.com/wesnoth/wesnoth/commit/fa32be5602ca5f00217e2408af09cbd51c0ffd66 20141229 16:16:12< gfgtdf> it seems like this commit https://github.com/wesnoth/wesnoth/commit/5bbd7f3064862484d52c68656f72b30ab367fc60 added some dead code and marked it as wip, i'd relally like to know whether it's still wip. 20141229 16:22:00< vultraz> hm, ignore the last comment of mine about crashing 20141229 16:22:06< vultraz> apparently that's supposed to happen 20141229 16:23:13< zookeeper> gfgtdf, it's been so long that i don't really even remember what all it was supposed to be used for -.- 20141229 16:24:38< zookeeper> gfgtdf, probably things like "if shown on the right side, should it be mirrored or not" (if the portrait has text for example), or perhaps some scaling/cropping rules were supposed to be added 20141229 16:36:11-!- enchilado [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 244 seconds] 20141229 16:36:25-!- localuser- [~none@gateway/tor-sasl/localuser-] has quit [Ping timeout: 250 seconds] 20141229 16:37:25-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-swsyuvqxiywwlctn] has joined #wesnoth-dev 20141229 16:38:30< irker033> wesnoth: Charles Dang wesnoth:master d6d952a7b14e / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: initialize Delf in his [side] http://git.io/lJMK7Q 20141229 16:38:33< irker033> wesnoth: Charles Dang wesnoth:master 40a2a5bf1b98 / / (10 files in 3 dirs): Merge branch 'master' of github.com:wesnoth/wesnoth http://git.io/8NIsYQ 20141229 16:38:36< irker033> wesnoth: Charles Dang wesnoth:master a941e3e7d1ac / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: completely refactored scenario code. More tweaks pending http://git.io/jo8Fww 20141229 16:38:39< irker033> wesnoth: Charles Dang wesnoth:master 9b5ffc8376aa / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Merge branch 'master' of github.com:wesnoth/wesnoth http://git.io/PZ_R0Q 20141229 16:38:55< vultraz> whew 20141229 16:39:29< vultraz> zookeeper: ^ S1 20141229 16:40:16-!- localuser- [~none@gateway/tor-sasl/localuser-] has joined #wesnoth-dev 20141229 16:40:53< zookeeper> well that was fast 20141229 16:41:12 * zookeeper misses wesbot a little bit 20141229 16:42:08< zookeeper> vultraz, so how did you determine that the gender variation string(s?) were not needed? 20141229 16:42:41< vultraz> I just removed any that did not refer to Konrad or Lisar by name or pronoun 20141229 16:42:58< vultraz> (save 'you') 20141229 16:43:05< vultraz> If an issue arises, I can restore them 20141229 16:43:39< zookeeper> if an issue arises after a pot-update then the damage has already been done 20141229 16:44:14-!- localuser- [~none@gateway/tor-sasl/localuser-] has quit [Remote host closed the connection] 20141229 16:44:21< boucman_work> zookeeper, sometime we are fast 20141229 16:44:26< zookeeper> boucman_work, yay 20141229 16:44:41< boucman_work> :) 20141229 16:44:49 * boucman_work feels like an old-timer 20141229 16:45:06< zookeeper> well that's because you are :p 20141229 16:45:12< vultraz> oh god S2 is even worse than S1 20141229 16:45:25 * boucman_work registered on the forums in 2004 20141229 16:45:36< boucman_work> so i'm not the oldest around, but probably quite close 20141229 16:45:48< zookeeper> shadowm, ^ you're probably the closest thing we have to an expert, what do you think about the gender strings stuff? 20141229 16:47:24< zookeeper> oh good grief, good that i went to my forum profile to see if i could see my join date (since i thought that would be faster than finding a post of mine), looks like i've had a nonfunctional email address set there for maybe the past 5 years or so 20141229 16:47:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20141229 16:49:33< boucman_work> hehe 20141229 16:49:34< irker033> wesnoth: Charles Dang wesnoth:master 7b899320dd7b / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: next_turn var doesn't exist anymore, don't clear it http://git.io/tVcg0g 20141229 16:49:37< irker033> wesnoth: Charles Dang wesnoth:master 8646c57b779a / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: T S2: initialize starting units in [side]s http://git.io/hvksgw 20141229 16:49:40< irker033> wesnoth: Charles Dang wesnoth:master 1fab61360d7e / data/campaigns/tutorial/ (scenarios/02_Tutorial_part_2.cfg utils/utils.cfg): T: moved a wmllint spelling exception to the correct file http://git.io/-Y1fkQ 20141229 16:49:47< zookeeper> and to change it i have to change my password too because the old one is too short nowadays... 20141229 16:50:26< irker033> wesnoth: Chris Beck wesnoth:master 9f67233f2220 / src/scripting/game_lua_kernel.cpp: fixup fa32be5602ca5f00217e2408af09cbd51c0ffd66 http://git.io/tlkpQg 20141229 16:50:34< iceiceice> vultraz: ^ this fixes one of the lua errors in the test scenario, 20141229 16:50:38< iceiceice> i'm not sure about the other one yet 20141229 16:52:13-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20141229 16:52:20-!- {V} [~V@72-69-ftth.on.nl] has joined #wesnoth-dev 20141229 16:55:20< zookeeper> oh, i registered in 2004 too 20141229 16:55:24< zookeeper> durr 20141229 16:56:05< Nostromus> vultraz: refactoring brokes translation, i assume you're aware of this. 20141229 16:56:29< vultraz> not if it's just code 20141229 16:56:41< vultraz> I changed only a few strings, and the changes were minor 20141229 16:56:55< Nostromus> some of the dialogs appears in english instead of german 20141229 16:57:04-!- travis-ci [~travis-ci@ec2-54-145-247-123.compute-1.amazonaws.com] has joined #wesnoth-dev 20141229 16:57:04< travis-ci> wesnoth/wesnoth#5316 (master - 77a0be4 : mattsc): The build has errored. 20141229 16:57:04< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45361529 20141229 16:57:04-!- travis-ci [~travis-ci@ec2-54-145-247-123.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141229 16:59:45< irker033> wesnoth: Chris Beck wesnoth:master 4d857e4794e7 / src/scripting/game_lua_kernel.cpp: lua: fixup 9922b98fa30072b93ed9501acdbcadcbdb30cfdd http://git.io/LGMkHQ 20141229 17:03:37< Nostromus> and the dialog for jumping directly to the next scenario after beating the first quintain is missing, now you have to play 13 turns or kill the other 3 dummies 20141229 17:03:41< vultraz> zookeeper: before I go to s2, I'd like to address the attacking dialog in s1. it doesn't allow the contingency that the player will ignore orders and attack again with the same weapons 20141229 17:04:07< vultraz> Nostromus: there's a menu item for that... 20141229 17:04:19-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 255 seconds] 20141229 17:05:07-!- kex [~kex@77.28.18.23] has quit [Remote host closed the connection] 20141229 17:07:29< vultraz> "Cannot find era " 20141229 17:07:30< vultraz> wat 20141229 17:07:45< Nostromus> vultraz: thats the bug i told you 20141229 17:07:53-!- kex [~kex@77.28.18.23] has joined #wesnoth-dev 20141229 17:08:14< Nostromus> vultraz: the menu item doesn't work 20141229 17:08:30< vultraz> Nostromus: that's a bug, iceiceice is working on it 20141229 17:09:50< Nostromus> vultraz: see see commit 41c9e5bd for the cannot find era bug 20141229 17:11:31< Nostromus> when you save the game before you finish the first scenario, load the saved game finish scenario -> bug don't show up 20141229 17:13:21< Nostromus> and it seems to me, this bug appears only in the tutorial not in the other campaigns 20141229 17:15:04-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 264 seconds] 20141229 17:35:22< irker033> wesnoth: Charles Dang wesnoth:master 1c9dc4ae3dcc / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: fixed initial scenario end prompt http://git.io/lA5QwA 20141229 17:35:25< irker033> wesnoth: Charles Dang wesnoth:master 4473e2c532a3 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: made Delf face the keep after he moves http://git.io/Y1SAJg 20141229 17:35:28< irker033> wesnoth: Charles Dang wesnoth:master 8665840ec36d / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: changed the route Delf takes when he leaves. He now goes via the road http://git.io/hx5qvQ 20141229 17:35:31< irker033> wesnoth: Charles Dang wesnoth:master 0e758a419a64 / src/scripting/game_lua_kernel.cpp: Merge branch 'master' of github.com:wesnoth/wesnoth http://git.io/7oZe_Q 20141229 17:35:33< vultraz> Nostromus: ^ 20141229 17:37:46< vultraz> zookeeper: I find it weird that the ai's moves are hardcoded in T S2 20141229 17:41:11-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20141229 17:41:48-!- kex [~kex@77.28.18.23] has quit [Remote host closed the connection] 20141229 17:43:01-!- cib0 [~cib@p508BCFB3.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141229 17:50:44-!- Nostromus [~chatzilla@f054013116.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141127110442]] 20141229 17:57:16< gfgtdf> zookeeper: i thought we can use image path functiosn for scaling ? 20141229 17:57:25< vultraz> hmmmmm 20141229 17:57:44< gfgtdf> there is currently a bug relates to scenario transiations ? 20141229 17:57:49< gfgtdf> related* 20141229 18:01:36< irker033> wesnoth: Charles Dang wesnoth:master 687919b736fc / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: reduce chance of quintain for dying before turn 4 http://git.io/-EzmPQ 20141229 18:01:47< vultraz> zookeeper: please review that commit ^ 20141229 18:05:29-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Quit: DCW] 20141229 18:10:11-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev 20141229 18:10:43< irker033> wesnoth: Charles Dang wesnoth:master 695998693f95 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: clear trying_to_be_a_wiseguy on victory http://git.io/SLKk7Q 20141229 18:14:00-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20141229 18:16:02-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20141229 18:16:40-!- EdB_ [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev 20141229 18:21:43-!- EdB_ [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!] 20141229 18:22:34-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Remote host closed the connection] 20141229 18:25:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Ping timeout: 264 seconds] 20141229 18:26:00-!- travis-ci [~travis-ci@ec2-54-237-37-121.compute-1.amazonaws.com] has joined #wesnoth-dev 20141229 18:26:01< travis-ci> wesnoth/wesnoth#5319 (master - 4d857e4 : Chris Beck): The build passed. 20141229 18:26:01< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45369912 20141229 18:26:01-!- travis-ci [~travis-ci@ec2-54-237-37-121.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141229 18:27:20-!- Netsplit *.net <-> *.split quits: timotei_, EdB 20141229 18:28:34-!- zookeeper_ [zookeeper@37.35.24.98] has joined #wesnoth-dev 20141229 18:30:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds] 20141229 18:30:43< zookeeper_> gfgtdf, well, yes, we can now. but by scaling i meant things like whether to scale down or crop off the top if the portrait is taller than the window height, etc. but i don't really recall what all was intended by it. 20141229 18:30:52-!- zookeeper_ is now known as zookeeper 20141229 18:30:54-!- zookeeper [zookeeper@37.35.24.98] has quit [Changing host] 20141229 18:30:54-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20141229 18:31:04< gfgtdf> zookeeper: hm ok 20141229 18:31:30< irker033> wesnoth: Charles Dang wesnoth:master 220e5912e6b3 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: fixup 1c9dc4ae3dcc. Seems we need new turn after all http://git.io/ZQSlJQ 20141229 18:34:39< zookeeper> "what happens to the [portrait] part will be looked at post 1.6" -someone in 2009 :p 20141229 18:35:46< irker033> wesnoth: Charles Dang wesnoth:master 9dba03953bc3 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: the student variable should not be translatable http://git.io/T3IwFQ 20141229 18:36:04< gfgtdf> zookeeper: y thats quiet some time ago 20141229 18:37:33< zookeeper> gfgtdf, so does the tag do anything in the code at all? 20141229 18:37:49< gfgtdf> zookeeper: from what i saw at teh code no 20141229 18:38:06< zookeeper> yeah because someone in 2010 was telling me that :P 20141229 18:38:21< gfgtdf> zookeeper: surprisingly [portrait] is emtined in the winik 20141229 18:38:23< gfgtdf> wiki* 20141229 18:38:33< gfgtdf> mentioned* 20141229 18:39:05< zookeeper> if it doesn't do anything now then i don't think you have to worry about it... 20141229 18:39:18< zookeeper> and yeah it should be removed from the wiki too in that case 20141229 18:39:26< shadowm> zookeeper: Could you describe the issue for me or point me to a commit? 20141229 18:39:45< gfgtdf> zookeeper: well dead code is confusing. 20141229 18:39:50< shadowm> gfgtdf: [portrait] is an internal GUI2 hack. 20141229 18:40:08< gfgtdf> shadowm: so you think it is currently used somewhere ? 20141229 18:40:18< shadowm> I'd say "undecided, leave it alone until mordante returns". 20141229 18:40:59< gfgtdf> shadowm: hmm k 20141229 18:42:04< vultraz> shadowm: http://git.io/jo8Fww while doing this, I removed some female variations of text that I believed should not have any 20141229 18:42:49< zookeeper> https://github.com/wesnoth/wesnoth/commit/a941e3e7d1ac125981f60caf6a7f154b16ec8663#diff-c64e777d9b6bcbc3964a80e438344b34L495 for example 20141229 18:43:06< shadowm> You shouldn't have removed the wmlindent start/stop ignoring markers. 20141229 18:43:23< vultraz> why? 20141229 18:43:28< vultraz> wmlindent runs correctly 20141229 18:43:38< shadowm> Does it? Okay. 20141229 18:43:58< shadowm> Can you point me to a message? 20141229 18:44:07< vultraz> zookeeper just linked an example 20141229 18:44:18< zookeeper> "Unfortunately, you’ve used up your turn [...]" 20141229 18:44:48< shadowm> vultraz: Japanese comes to mind. 20141229 18:45:03< shadowm> Most first and second person pronouns are gendered in Japanese. 20141229 18:45:33< vultraz> Two issues 20141229 18:45:47< vultraz> A. not all cases of 'you' in text were provided with variants 20141229 18:45:51< shadowm> Spanish doesn't have gendered first/second person pronouns, but there are more obvious cues of gender in speech. 20141229 18:46:03< vultraz> B. Delf could be interpreted as talking to the player 20141229 18:46:23< shadowm> For example, adjectives. 20141229 18:46:35< shadowm> I'm giving you this information, you decide what to do with it. 20141229 18:51:04< vultraz> I would personally prefer only to genderize strings where there's a marked english difference 20141229 18:51:26< shadowm> I would personally like to tell you that that's not how it works. 20141229 18:52:06< shadowm> English does not dictate how other languages work. The best you can do is add exceptions if translators request them, and not remove existing ones. 20141229 19:00:57< zookeeper> vultraz, eh, the {MODIFY_UNIT (id=student) moves 0} thing just breaks the gamerules without explanation (which would be contrived if there was one) 20141229 19:01:33< vultraz> zookeeper: thought so. but what to do instead? just hope the user follows the instructions? 20141229 19:06:02< zookeeper> vultraz, yes, or if you feel like doing extra work, silently tweaking the CTH to prevent disaster 20141229 19:06:39< zookeeper> i never feel a great need to improve the tutorial because it needs to be completely redone, but then again that's not happened so far... 20141229 19:08:24< vultraz> interestingly enough, the student's moves are also set to 0 at like 440 20141229 19:10:16< vultraz> but I guess that's in keeping with game mechanics 20141229 19:12:15< irker033> wesnoth: Charles Dang wesnoth:master a480912ff7e3 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: don't set student's moves to 0 after moving to keep http://git.io/QKbxrw 20141229 19:12:20< vultraz> zookeeper: you say you had some plans for a tutorial rewrite? 20141229 19:14:55< vultraz> (I'm off, I'll read the logs) 20141229 19:25:06-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20141229 19:32:32-!- lipkab [~the_new_l@apn-185-10-126-17.vodafone.hu] has joined #wesnoth-dev 20141229 19:43:18-!- cib0 [~cib@p508BCFB3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141229 19:43:34-!- cib0 [~cib@p508BCFB3.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141229 19:49:13< zookeeper> vultraz, yeah i've had a half-written unpublished new tutorial for the past 4-5 years 20141229 19:49:26< zookeeper> unfortunately i never managed to force myself to finish it properly 20141229 19:52:18< zookeeper> and by half-written i mean that IIRC it covers the basic mechanics of movement, ZoC, combat etc, but doesn't have a full practise scenario 20141229 20:10:15< vultraz> zookeeper: can I see the code? 20141229 20:11:03< zookeeper> of course. gimme a while... 20141229 20:16:51< zookeeper> eh. running wmllint on the add-on's dir outputs some complaints about translation markers in core soulless and WC files. does that mean that if i let it perform changes, it'll mess with those core files? 20141229 20:17:27< vultraz> dunno, but you can always revert 20141229 20:17:52< shadowm> Yes. 20141229 20:17:58< irker033> wesnoth: Charles Dang wesnoth:master 08ef074aff34 / projectfiles/CodeBlocks/wesnoth.cbp: Updated codeblocks projectfile http://git.io/qYynaA 20141229 20:18:50< shadowm> Someone file a FR about wmllint having problems with translation marks and variation_id vs. variation_name and I'll deal with it. 20141229 20:19:06-!- Sulfur [~Miranda@p5B008CF0.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20141229 20:19:45< vultraz> speaking of wmllint, I was going to try to figure out how to exclude 'none' from the ellipsecheck... 20141229 20:22:45< shadowm> I can do that. 20141229 20:23:01< shadowm> Would you prefer to try it yourself? 20141229 20:23:10< vultraz> I can try 20141229 20:29:17< irker033> wesnoth: Charles Dang wesnoth:master 75b2dfcc4c12 / data/tools/wmllint: Don't show ellipsecheck warning if ellipse=none http://git.io/WJaz6Q 20141229 20:29:19< vultraz> ^ that seems to work 20141229 20:30:47 * vultraz off again 20141229 20:33:01-!- lipkab [~the_new_l@apn-185-10-126-17.vodafone.hu] has left #wesnoth-dev ["Sűrű sötét az éj, dühöng a déli szél"] 20141229 20:33:27< zookeeper> vultraz, here you go: https://dl.dropboxusercontent.com/u/63964618/wesnoth/Tutorial.7z 20141229 20:33:55< zookeeper> looks like you need to fix some [end_level]s... i only noticed after i packed and uploaded it 20141229 20:34:38< zookeeper> or [endlevel]s, even 20141229 20:35:45< zookeeper> (namely, the ones in 00-Start.cfg use result=continue_no_save) 20141229 20:50:29< zookeeper> nevermind, i updated the file 20141229 21:19:18-!- boucman [~rosen@2a02-8428-034f-f800-8c25-5760-0387-1100.rev.sfr.net] has joined #wesnoth-dev 20141229 21:19:29-!- boucman [~rosen@2a02-8428-034f-f800-8c25-5760-0387-1100.rev.sfr.net] has quit [Changing host] 20141229 21:19:29-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20141229 21:46:41-!- cib_ [~cib@p508BCFB3.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141229 21:47:27-!- cib0 [~cib@p508BCFB3.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds] 20141229 21:51:21-!- cib_ [~cib@p508BCFB3.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20141229 21:52:01< irker033> wesnoth: gfgtdf wesnoth:master 14616607f517 / src/ (20 files in 5 dirs): fix some spelling in comments. http://git.io/pbgjTA 20141229 21:56:38-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Quit: Off to save the world!] 20141229 22:01:18< irker033> wesnoth: gfgtdf wesnoth:master b09f666aff47 / src/unit.cpp: fix indention http://git.io/j_AViQ 20141229 22:17:26-!- gfgtdf_ [~chatzilla@f054168161.adsl.alicedsl.de] has joined #wesnoth-dev 20141229 22:20:17-!- gfgtdf [~chatzilla@f054053068.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds] 20141229 22:20:21-!- gfgtdf_ is now known as gfgtdf 20141229 22:36:00-!- Nostromus [~chatzilla@f054013116.adsl.alicedsl.de] has joined #wesnoth-dev 20141229 23:01:38-!- Fluffbeast [~Fluffbeas@pool-96-252-61-113.bstnma.fios.verizon.net] has joined #wesnoth-dev 20141229 23:28:06-!- Fluffbeast [~Fluffbeas@pool-96-252-61-113.bstnma.fios.verizon.net] has quit [Ping timeout: 258 seconds] 20141229 23:29:37-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev 20141229 23:31:00-!- markus_ [~mjs-de@p508CAB46.dip0.t-ipconnect.de] has joined #wesnoth-dev 20141229 23:33:57-!- mjs-de [~mjs-de@p508CB614.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 20141229 23:34:57-!- travis-ci [~travis-ci@ec2-54-237-37-121.compute-1.amazonaws.com] has joined #wesnoth-dev 20141229 23:34:57< travis-ci> wesnoth/wesnoth#5329 (master - b09f666 : gfgtdf): The build was broken. 20141229 23:34:57< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45396466 20141229 23:34:57-!- travis-ci [~travis-ci@ec2-54-237-37-121.compute-1.amazonaws.com] has left #wesnoth-dev [] 20141229 23:37:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20141229 23:37:27-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20141229 23:51:17< gfgtdf> can i replace << std::endl with << ''\n' << std::flush ? 20141229 23:51:38< gfgtdf> meaning is the effect the same for out orror logs 20141229 23:54:38< Nostromus> no you can't, on different os the output should be different 20141229 23:56:20< gfgtdf> Necrosporus_: why could that be different? 20141229 23:59:56< Nostromus> oh it is indeed the same --- Log closed Tue Dec 30 00:00:09 2014