--- Log opened Tue Dec 30 00:00:09 2014
--- Day changed Tue Dec 30 2014
20141230 00:00:09< Nostromus> https://cppkid.wordpress.com/2008/08/27/why-i-prefer-n-to-stdendl/
20141230 00:00:36< Nostromus> there are several other sources, but this explains it too
20141230 00:03:18-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20141230 00:05:42< irker033> wesnoth: gfgtdf wesnoth:master fba3a6e4fbb7 / src/ (game_events/menu_item.cpp play_controller.cpp replay_controller.cpp): fix some spelling in comments. http://git.io/Np1OEQ
20141230 00:05:44< irker033> wesnoth: gfgtdf wesnoth:master 12b6af7fc72e / src/ (actions/create.cpp replay.cpp): give better error message http://git.io/FWVteQ
20141230 00:21:47-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141230 00:23:04< iceiceice> gfgtdf: many of the std::endl in the logging were added by me, like a year ago,
20141230 00:23:24< iceiceice> at the time i had not read all the logger implementation but i foudn that some of the loggers need to be flushed and some don't, and it is not really documented
20141230 00:23:53< iceiceice> it confused me for several hours once when trying to fix a segfault...
20141230 00:24:07< gfgtdf> iceiceice: the travis vuidl above just gave me some strange OOS but i cannot really imagne that that some from my commit
20141230 00:24:19< gfgtdf> comes*
20141230 00:24:31< gfgtdf> iceiceice: since it was mostly baout intention and comment
20141230 00:24:32< gfgtdf> s
20141230 00:24:41< gfgtdf> iceiceice: does that happens often that oos ?
20141230 00:24:43< iceiceice> when i added the wml unit tests, since they treat warnings and error logging, i ran a sed script that changed most "\n" to << std::endl for any warning or error channels
20141230 00:24:58< iceiceice> it turns out it probably wasn't necessary except if you are using the log::wml_error
20141230 00:25:25< iceiceice> idk i will look at travis logs...
20141230 00:26:52< iceiceice> gfgtdf: yeah i noticed this before,
20141230 00:27:08< iceiceice> the oos is expected, that is what is supposed to happen
20141230 00:27:23< iceiceice> the error is that for some reason the game does not report that the test has failed (as expected)
20141230 00:27:46< iceiceice> idk when this started to go wrong, it worked for like a year...
20141230 00:27:59< iceiceice> if you rerun the test it will probably pass
20141230 00:28:09< iceiceice> i think its a bug in the "strict mode" thing
20141230 00:29:02< gfgtdf> iceiceice: hm ok
20141230 00:34:06-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141230 00:34:31< gfgtdf> iceiceice: did you read my comments about https://github.com/wesnoth/wesnoth/pull/254 ?
20141230 00:42:39-!- travis-ci [~travis-ci@ec2-54-237-37-121.compute-1.amazonaws.com] has joined #wesnoth-dev
20141230 00:42:39< travis-ci> wesnoth/wesnoth#5330 (master - 12b6af7 : gfgtdf): The build was fixed.
20141230 00:42:39< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45406912
20141230 00:42:39-!- travis-ci [~travis-ci@ec2-54-237-37-121.compute-1.amazonaws.com] has left #wesnoth-dev []
20141230 00:49:34-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-swsyuvqxiywwlctn] has quit [Changing host]
20141230 00:49:34-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20141230 00:52:40-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Ping timeout: 250 seconds]
20141230 00:55:59-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20141230 00:56:45-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20141230 00:58:38< Nostromus> Can someone explain me why we distinct between Tutorial and SP_Campaign? Why not handle the tutorial as sp_campaign just with the extra button on the title screen? 
20141230 01:02:14-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141230 01:05:12< iceiceice> gfgtdf: yeah those are all good questions, i don't have good answers yet
20141230 01:05:25< iceiceice> its probably better if the abstract base class is a template argument i guess
20141230 01:05:44< gfgtdf> iceiceice: i think you can just remove teh abstrace base class
20141230 01:06:17< gfgtdf> abstracet*
20141230 01:06:22< iceiceice> yeah... i think maybe it was just helpful for me conceptually
20141230 01:06:36< iceiceice> the std::vector<std::string> thing...
20141230 01:06:40< gfgtdf> iceiceice: c++11 might have c++ concepts language feauture 
20141230 01:06:46< gfgtdf> c++17*
20141230 01:06:47< iceiceice> yeah
20141230 01:06:48< iceiceice> that too
20141230 01:07:04< iceiceice> there are many cases where we use utils::parse (can't remember fcn name) with various different options,
20141230 01:07:42< iceiceice> for comma separated lists with different delimiter, whether to consume spaces...
20141230 01:07:47< iceiceice> i can't remember other examples atm
20141230 01:07:48< shadowm> utils::split().
20141230 01:08:08< iceiceice> your third example, i think i don't have a way to do that atm
20141230 01:08:22< iceiceice> your fourth is probably valid, i think you said it before also
20141230 01:08:31< iceiceice> it would make the code simpler also
20141230 01:09:21< iceiceice> thanks for comments, i think i will come back to this branch later maybe...
20141230 01:09:35< iceiceice> i'm not certain if the branch is actually a good idea, it might just make the code harder to read
20141230 01:09:56< iceiceice> probably not everyone will agree
20141230 01:10:17< iceiceice> i think it might be convenient in some cases...
20141230 01:11:13< iceiceice> Nostromus: for some reason the tutorial is different also at the level of WML from a campaign,
20141230 01:11:20< iceiceice> it uses the [tutorial] tag instead of [scenario]
20141230 01:11:27< iceiceice> i don't know all the reasons for this
20141230 01:14:22< gfgtdf> iceiceice: is it intended to use the confi converter class as a base class or as a mamber ?
20141230 01:14:35< iceiceice> i think as a member
20141230 01:16:56-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20141230 01:18:47< Nostromus> iceiceice: i saw that the tags are different, for me it seems the distinction makes the code unneccessary complex.  I thought there might be an obvious reason, but i don't see it yet. I try to resolve the era bug with the tutorial, this is why i looked at the code.
20141230 01:26:59< iceiceice> what's the era bug?
20141230 01:30:35< gfgtdf> i dont know about teh era bug but in think i mostly agree with Nostromus.
20141230 01:32:22< Nostromus> iceiceice: if you play the tutorial, loading the second scenario, you get the error "cannt find era". 
20141230 01:32:42< Nostromus> vultraz has the bug today too
20141230 01:33:08< Nostromus> this bug exists sincs commit 41c9e5bd
20141230 01:33:22-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has joined #wesnoth-dev
20141230 01:34:28< iceiceice> Nostromus: based on this commit, i would suggest to try to add at this line:
20141230 01:34:28< iceiceice> https://github.com/wesnoth/wesnoth/commit/41c9e5bd#diff-f3f7c2f44fbe22164552932f6755bf94R470
20141230 01:34:50< iceiceice> `|| classification_.campaign_type == game_classification::TUTORIAL) `
20141230 01:35:05< gfgtdf> or we coudl just remove teh whole if
20141230 01:35:22< iceiceice> sure
20141230 01:35:50< Nostromus> i'll try this
20141230 01:42:56< Nostromus> i added the line, but it doesn't work
20141230 01:45:25< iceiceice> hmm...
20141230 01:48:10< Nostromus> if i save the game before i finish the first scenario and exit and load, the bug doesn't show up
20141230 01:48:23< Nostromus> maybe this is a hint
20141230 01:55:58< gfgtdf> iceiceice: i just played a little arung with the config converters and this is how my version currentyl lloks: http://pastebin.com/vw0LJ8Tz
20141230 02:04:12< vultraz> hmm..
20141230 02:04:14< vultraz> 20141230 12:57:25 error scripting/lua: ...sers/Charles/Documents/wesnoth-git\data\lua/wml-tags.lua:28: attempt to index local 's' (a number value)
20141230 02:08:10< gfgtdf> vultraz: so the : syntag indexes ?
20141230 02:08:16< gfgtdf> syntax*
20141230 02:08:47< vultraz> yeah it doesn't seem to like that in this case ([switch] I believe)
20141230 02:11:19< gfgtdf> vultraz: but [switch] al already implementatin in lua since long time
20141230 02:12:01< gfgtdf> vultraz: ah yes
20141230 02:12:11< gfgtdf> vultraz: its becasue you replaces string. with s:
20141230 02:12:17< gfgtdf> replaced
20141230 02:12:19< vultraz> I added a tostring(s) and it works
20141230 02:13:18< gfgtdf> vultraz: i personly see no gain in using tostring(s):split over string.split(s,
20141230 02:15:27< vultraz> c74d: what say you, since you suggested this?
20141230 02:17:20< gfgtdf> shikadibot: seen anonymissimus ?
20141230 02:17:20< shikadibot> gfgtdf: The person with the nick anonymissimus last spoke 25d 6h ago.  25d 5h ago they left with the message: Quit: ChatZilla 0.9.90.1 [Firefox 12.0/20120423122928]
20141230 02:17:35-!- markus_ [~mjs-de@p508CAB46.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20141230 02:21:44< iceiceice> gfgtdf: yeah that's not a bad way to do it
20141230 02:22:36< iceiceice> its a bit different in that,
20141230 02:22:58< iceiceice> the way that i had set it up, you get complete documentation for what the config should look like and what the struct should look like in one place,
20141230 02:23:30< iceiceice> with this way, the "x" "y" from the map location don't appear in the header
20141230 02:23:40< iceiceice> and if you want to read "x1", "y1" instead or something i guess you cant
20141230 02:23:51< iceiceice> but i guess it doesn't really matter
20141230 02:24:03< gfgtdf> iceiceice: wel making convert::map_location more generic isnt hard
20141230 02:24:21< iceiceice> y
20141230 02:26:10< gfgtdf> iceiceice: http://pastebin.com/JKn7aAEG
20141230 02:27:25< gfgtdf> ahh
20141230 02:27:32< gfgtdf> iceiceice: i cannot use val.write then..
20141230 02:28:00< iceiceice> maybe its not really an issue in practice
20141230 02:28:20< iceiceice> iirc in some cases wehre there are multiple locations, we use a child config to hold x, y?
20141230 02:28:51< gfgtdf> iceiceice: http://pastebin.com/hNhHBVDY
20141230 02:28:59< iceiceice> so then we could use "to_config<map_location>" on the child 
20141230 02:36:44-!- Nostromus_ [~chatzilla@g224151092.adsl.alicedsl.de] has joined #wesnoth-dev
20141230 02:37:19-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has quit [Ping timeout: 256 seconds]
20141230 02:38:34-!- Nostromus [~chatzilla@f054013116.adsl.alicedsl.de] has quit [Ping timeout: 245 seconds]
20141230 02:38:39-!- Nostromus_ is now known as Nostromus
20141230 02:41:24-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has joined #wesnoth-dev
20141230 02:42:08< c74d> vultraz, gfgtdf: Lua types need to be set up to work with the `:` syntax; only strings are by default.
20141230 02:45:08< iceiceice> gfgtdf: yeah that looks good
20141230 02:45:14< gfgtdf> Necrosporus_: do you already know how to fix teh era thing ?
20141230 02:45:17< c74d> `tostring(s):split(...)` and `string.split(s, ...)` aren't exactly equivalent -- I think they'll do different things if `s` is not a string or a number.
20141230 02:45:17< iceiceice> i am trying to figure out why the test scenario is broken right now...
20141230 02:45:35< iceiceice> i want to fix that before i do anything else
20141230 02:45:49< iceiceice> i think i might have somehow broken the tstring lua proxy object or something...
20141230 02:45:55< iceiceice> its probly some damn typo
20141230 02:46:04-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20141230 02:46:39< iceiceice> this would also explain necrosporus' earlier report that translations aren't working in some dialogs
20141230 02:47:27< gfgtdf> iceiceice: how where they related to some dialogs ? 
20141230 02:47:59< iceiceice> i think some of the code that brings up objectives is implemented in lua
20141230 02:48:13< iceiceice> and implicitly does some stuff with vconfig / tstrings
20141230 02:48:20< iceiceice> not really sure right now
20141230 02:48:58< Necrosporus_> gfgtdf, which era things?
20141230 02:49:01< gfgtdf> iceiceice: i think that unrelate to the transiution bug
20141230 02:49:03-!- Necrosporus_ is now known as Necrosporus
20141230 02:49:14< iceiceice> hmm ok
20141230 02:49:16< gfgtdf> Necrosporus: the tuturial bug ?
20141230 02:49:27< iceiceice> but i'm still getting lua errors when i do "wesnoth -t"
20141230 02:49:33< iceiceice> so i'm just going to bisect this
20141230 02:49:38< Necrosporus> What tutorial bug? i though it was fixed already
20141230 02:49:54< Necrosporus> if you are talking about ones i found
20141230 02:51:14-!- Crendgrim_ [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20141230 02:51:22< gfgtdf> Necrosporus: ok then i missed somethign
20141230 02:51:50-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Ping timeout: 250 seconds]
20141230 02:51:51< gfgtdf> Necrosporus: i meant this one Nostromus	if i save the game before i finish the first scenario and exit and load, the bug doesn't show up
20141230 02:52:32< Necrosporus> can't remember
20141230 02:52:59< Nostromus> gfgtdf: ?
20141230 02:53:25< gfgtdf> ah there are 2 people beginnign with N and ending with us :O
20141230 02:53:39< Nostromus> oO confusing ;)
20141230 02:53:58< Necrosporus> I found few bugs in tutorial while playing in 1.11 long time ago but I think they were fixed almost immediately
20141230 02:54:13< Necrosporus> I can't remember what it were though
20141230 02:54:13< Nostromus> no this era bug is introduced in 1.13
20141230 02:54:22< Nostromus> and isn't in gna yet
20141230 02:54:44< Necrosporus> Then I do not know, I didn't run 1.13 ever
20141230 02:54:57< Nostromus> but i think, i get the trouble line
20141230 02:55:08< iceiceice> i think i'm going to merge techtonic's patch
20141230 02:55:18< gfgtdf> iceiceice: which onje ?
20141230 02:55:20< iceiceice> about the iconv vs. lib intl
20141230 02:55:20< Necrosporus> does 1/1
20141230 02:55:32< iceiceice> because, i dont think anyone is building for windows with lib intl actually...
20141230 02:55:33< Necrosporus> 1.13 already have anything worth looking?
20141230 02:55:38< iceiceice> we'll see what happens on mailing list about my patch i guess
20141230 02:55:46< gfgtdf> Necrosporus: yes but it also a litte broken
20141230 02:55:56< gfgtdf> Necrosporus: actually current head is broken a lot
20141230 02:56:05< Necrosporus> what is it?
20141230 02:56:25< iceiceice> if they dont want to drop the no-boost-filesystem option now then i guess i will fixup techtonic's patch then
20141230 02:56:57< iceiceice> gfgtdf: i was write when i wrote that the server does not use any of the gettext stuff right?
20141230 02:57:00< iceiceice> *right?
20141230 02:57:02< gfgtdf> iceiceice: so you don't want to merge your pr ?
20141230 02:57:08< iceiceice> i will but i will wait a few more days
20141230 02:57:12< iceiceice> i thnk
20141230 02:57:31< gfgtdf> iceiceice: no afaik teh server doesnt use gettext stuff
20141230 02:57:39< iceiceice> i guess i can just check the includes
20141230 02:57:44< gfgtdf> iceiceice: the server fails generally when it comes to translations
20141230 02:57:51< gfgtdf> translations*
20141230 02:58:11< iceiceice> i am thinking to remove both lib intl and locale from the server prerequesites then...
20141230 02:58:27< gfgtdf> :o i just assumes i wrote that word wrong bewcasue it is so long, but it seems i got it right the first time :p
20141230 02:58:30< gfgtdf> assumed*
20141230 02:58:40< iceiceice> haha
20141230 03:03:38< vultraz> c74d: which do you recommend?
20141230 03:03:43< gfgtdf> Nostromus: so where do you think is "the trouble line" ? 
20141230 03:04:07< Nostromus> wait a sec, just testing
20141230 03:05:54-!- irker033 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20141230 03:05:59< gfgtdf> iceiceice: you alrady have a plan for wight clich menu bug ?
20141230 03:06:14< Nostromus> doesn't have the exact line, but it is definitly the changes in playcampaign.cpp
20141230 03:07:41< iceiceice> gfgtdf: not exactly
20141230 03:07:55< iceiceice> i think i will have to refactor the menu_items or the manager a little bit
20141230 03:11:24-!- Ivanovic_ [~ivanovic@frnk-5f74c957.pool.mediaWays.net] has joined #wesnoth-dev
20141230 03:11:56-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20141230 03:12:34< gfgtdf> Nostromus: i'd try to set the ery in game_launcher::set_tutorial
20141230 03:13:31< gfgtdf> Nostromus: so that'd be similar to what we do when we load teh game
20141230 03:14:48-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 250 seconds]
20141230 03:15:18-!- Ivanovic_ is now known as Ivanovic
20141230 03:15:41< c74d> vultraz: I would expect that `string.split(s, ...)` would raise an error if `s` is not a string or a number. If that's undesirable, then I'd recommend `tostring(s):split(...)`.
20141230 03:16:02< c74d> Oh, `string.split` isn't a standard Lua function?
20141230 03:16:11< c74d> I don't know what it'd do then.
20141230 03:16:58< gfgtdf> c74d: gmatch not split
20141230 03:17:21< gfgtdf> c74d: and it seems leik it didnt thow an error previously, since the code worked previously
20141230 03:17:25< gfgtdf> like*
20141230 03:18:42< c74d> gfgtdf: even if `s` is not a string or a number?
20141230 03:18:56< gfgtdf> c74d: idk in our case it was a number
20141230 03:19:23-!- kex [~kex@78.157.29.160] has quit [Remote host closed the connection]
20141230 03:19:55-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141230 03:22:08< iceiceice> hmmm...
20141230 03:22:11< iceiceice> ok i see now
20141230 03:22:15-!- Ivanovic [~ivanovic@frnk-5f74c957.pool.mediaWays.net] has quit [Changing host]
20141230 03:22:15-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20141230 03:22:33< iceiceice> gfgtdf, i think that i18n stuff is a server dependency, because filesystem_boost is used by the server and it may refer to boost locale
20141230 03:22:48< iceiceice> if it was not then it could be made a client only dep i guess
20141230 03:23:09< iceiceice> not that this is terribly important
20141230 03:23:51-!- gfgtdf [~chatzilla@f054168161.adsl.alicedsl.de] has quit [Ping timeout: 258 seconds]
20141230 03:24:17-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 244 seconds]
20141230 03:25:06< iceiceice> i think i just leave it how it is for now
20141230 03:26:53-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20141230 03:27:17-!- Crendgrim_ [~crend@wesnoth/forum-moderator/crendgrim] has quit [Ping timeout: 240 seconds]
20141230 03:29:54-!- gfgtdf [~chatzilla@f054168161.adsl.alicedsl.de] has joined #wesnoth-dev
20141230 03:33:34-!- TooLmaN [~TooLmaN@c-73-190-210-54.hsd1.ga.comcast.net] has joined #wesnoth-dev
20141230 03:37:13< gfgtdf> iceiceice: filesystem boost unly uses boost locale for utf8 utf16 conversion i think
20141230 03:37:47< gfgtdf> iceiceice: what do you see ?=
20141230 03:38:56< iceiceice> i tried to move i18n to be client prereq instead of server,
20141230 03:39:13< iceiceice> and then to move the gettext*.cpp file from libwesnoth_core to libwesnoth
20141230 03:39:23< iceiceice> but to leave filesystem boost in the libwesnoth_core,
20141230 03:39:26< iceiceice> and i got some linker errors
20141230 03:39:32< iceiceice> http://pastebin.com/BhB7PDja
20141230 03:40:16< iceiceice> these errors don't really make sense though, i must have messed up somehow...
20141230 03:40:45< iceiceice> if i did what i said i did then i guess i should not see "libwesnoth_core.a(gettext_boost.o)"
20141230 03:43:45< iceiceice> it looks like this commit broke the test executable: https://github.com/wesnoth/wesnoth/commit/9eaba64651944bbe463a77a2611f37697421f15d
20141230 03:43:57< iceiceice> more than a month ago D:
20141230 03:44:01-!- Crendgrim_ [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20141230 03:44:11< iceiceice> * the test scenario i mean
20141230 03:44:52-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Ping timeout: 245 seconds]
20141230 03:50:02< iceiceice> gah i am stupid T_T
20141230 03:51:55< Nostromus> gfgtdf: setting era in set_tutorial doesn't work, unlike the campaign tutorial uses reload_data and new campaign uses no_reload_data
20141230 03:52:09< Nostromus> don't ask me why
20141230 03:53:19< gfgtdf> Nostromus: i thought reload data onyl reloads teh game config ?
20141230 03:58:57< gfgtdf> Nostromus: how did you try to set the era ?
20141230 03:59:30< Nostromus> state_.mp_settings().mp_era = "era_blank";
20141230 04:00:33< gfgtdf> Nostromus: so you think that gets overwritten somewhere ?
20141230 04:00:41< Nostromus> yes i think
20141230 04:01:14-!- irker976 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20141230 04:01:14< irker976> wesnoth: Chris Beck wesnoth:master a1a2e0e527cf / src/scripting/game_lua_kernel.cpp: lua: fixup 9eaba64651944bbe463a77a2611f37697421f15d http://git.io/XFlpkQ
20141230 04:01:42< Nostromus> i got the output in playcampaign from mp_era and it is "".
20141230 04:02:13< Nostromus> for a normal campaign, it is "era_blank"
20141230 04:03:10< Nostromus> i'm new, currently i read lot of code and try to understand whats going on ;)
20141230 04:05:03< gfgtdf> Nostromus: how did you set_tuturil function look then ?
20141230 04:06:41-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20141230 04:07:03< Nostromus> http://pastebin.com/Kjfghb3j
20141230 04:07:14-!- Crendgrim_ [~crend@wesnoth/forum-moderator/crendgrim] has quit [Ping timeout: 250 seconds]
20141230 04:08:18< gfgtdf> Nostromus: and hwere was the check where you notives that that was overwritten ?
20141230 04:09:56< gfgtdf> Nostromus: did you also do what iceiceice said with the scheck in saved_game.cpp ?
20141230 04:10:35< Nostromus> yes i did, but this didn't change anything
20141230 04:11:13< gfgtdf> Nostromus: you you had the set_tutorial patch and teh saved_game patch at the same time ?
20141230 04:11:39< Nostromus> sec, i will check
20141230 04:13:23< iceiceice> anyone: does anyone mind if i merge both of techtonik's patches now?
20141230 04:13:53< iceiceice> i don't see any particular reason against either of them
20141230 04:14:24< iceiceice> gfgtdf, shadowm, loonycyborg, Ivanovic, AI0867, vultraz : ^
20141230 04:15:13< gfgtdf> iceiceice: i don't, but im not expert for buildfiles nreigher
20141230 04:16:22< Nostromus> gfgtdf: i revert this, because of some other check, it seems working now
20141230 04:16:50< gfgtdf> Nostromus: so you found out whhat teh problem was ?
20141230 04:16:52< Nostromus> i will clean the whole thing, edit the changes and test
20141230 04:17:09< Nostromus> set_tutorial and the save_game changes
20141230 04:17:44< irker976> wesnoth: Chris Beck wesnoth:master 1f124ff2ee56 / src/scripting/ (game_lua_kernel.cpp lua_team.cpp): lua: give more specific errors for "unknown modifiable property" http://git.io/tHNeyw
20141230 04:18:24< Nostromus> so in saved game, remove the whole if statement or add an statement for tutorial? which do you prefer?
20141230 04:19:29< gfgtdf> Nostromus: id prefer deleting it
20141230 04:19:35< gfgtdf> Nostromus: there are actually 4 cases
20141230 04:19:44< gfgtdf> Nostromus: MP, SP, TUTUROAL; TEST
20141230 04:20:31< Nostromus> i assume TEST need this too, so deleting the whole thing is best
20141230 04:20:33< gfgtdf> Nostromus: i think that thests shoudl be like the "real" cases if possible
20141230 04:21:07< gfgtdf> Nostromus: iceiceice knows better than me how the TESTS work
20141230 04:21:46< Nostromus> i report this on gna with a patch and a note to iceiceice
20141230 04:21:51< iceiceice> yes i dont see why the era blank should not occur for test
20141230 04:22:00< Nostromus> ok
20141230 04:22:09< iceiceice> also if it will occur in all scenarios this is a good thing, maybe we can change this part in the lua api also:
20141230 04:22:10< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/scripting/game_lua_kernel.cpp#L1224
20141230 04:24:15< gfgtdf> iceiceice: i actuyll think for sp it's aleas teh same ery_blank
20141230 04:24:21< gfgtdf> era*
20141230 04:25:04< gfgtdf> iceiceice: the use it has is getting the player login name
20141230 04:25:08< gfgtdf> iceiceice: in sp 
20141230 04:25:38< iceiceice> where is the player login name?
20141230 04:25:40< iceiceice> in mp_settings?
20141230 04:25:43< iceiceice> or in era
20141230 04:25:50< gfgtdf> iceiceice: mp settings
20141230 04:25:54< iceiceice> ah ok
20141230 04:25:56< iceiceice> yeah that seems useful
20141230 04:26:03< shadowm> iceiceice: Which patches?
20141230 04:26:15< iceiceice> https://github.com/wesnoth/wesnoth/pull/348
20141230 04:26:29< iceiceice> https://github.com/wesnoth/wesnoth/pull/347
20141230 04:27:21< shadowm> #348 needs squashing.
20141230 04:28:10< iceiceice> i have to leave in 5 minutes
20141230 04:28:16< iceiceice> why dont you write it in thread to him
20141230 04:28:22< iceiceice> do you see anything against 347?
20141230 04:28:22< gfgtdf> iceiceice: actually what are teh normal usecases for wesnoth.game_config.mp_settings
20141230 04:28:23< shadowm> I don't understand #347, ask loonycyborg.
20141230 04:28:59< iceiceice> i understand it, i think its fine and depending on mailing list resolution i will follow up on it
20141230 04:29:14< shadowm> What ML resolution?
20141230 04:29:28< iceiceice> can't get into it now, please check your mail
20141230 04:29:31< iceiceice> i will be back later
20141230 04:29:32-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20141230 04:29:50< shadowm> My mail from how recently are we talking about?
20141230 04:30:21-!- gfgtdf [~chatzilla@f054168161.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]]
20141230 04:30:28< shadowm> Is it the thread about BFS? I thought this was about gettext. Anyway, as I said, I don't understand a single thing about this.
20141230 04:30:53< shadowm> loonycyborg knows this stuff and he's the one that's directly impacted by it as the Windows packager.
20141230 04:32:11 * shadowm doesn't even know what iconv is.
20141230 04:34:28< shadowm> And while we are at it, I don't have any problems with making Boost.filesystem mandatory on master. If we need to deal with BFS/non-BFS behavior incongruencies again in the future we can just use 1.12 for reference.
20141230 04:39:02-!- SpoOkyMagician_ [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has joined #wesnoth-dev
20141230 04:39:44-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has quit [Ping timeout: 250 seconds]
20141230 04:39:47-!- SpoOkyMagician_ is now known as SpoOkyMagician
20141230 04:40:35-!- TooLmaN [~TooLmaN@c-73-190-210-54.hsd1.ga.comcast.net] has quit [Quit: Off to save the world!]
20141230 04:53:38-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Quit: http://xkcd.com/91/]
20141230 05:06:01< irker976> wesnoth: Charles Dang wesnoth:master 3acb30e1ca3a / data/lua/wml-tags.lua: Cast arg as string in trim() and split() http://git.io/o9qJ4g
20141230 05:12:04-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 244 seconds]
20141230 05:22:26-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.0.1]
20141230 05:49:03-!- SpoOkyMagician_ [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has joined #wesnoth-dev
20141230 05:52:11-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has quit [Ping timeout: 240 seconds]
20141230 05:52:11-!- SpoOkyMagician_ is now known as SpoOkyMagician
20141230 05:52:12-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has joined #wesnoth-dev
20141230 05:53:13< irker976> wesnoth: Charles Dang wesnoth:master 778c840483d4 / data/lua/wml-tags.lua: Misc cleanup http://git.io/4egH_w
20141230 05:56:22< Nostromus> i reported a bug in gna, for the era carryover bug in the tutorial and prepared a oull request for the fix.
20141230 05:56:31< Nostromus> oull = pill
20141230 05:56:34< Nostromus> pull
20141230 05:56:43< Nostromus> ...
20141230 05:59:40< vultraz> someone other than me will have to take a look at it
20141230 06:06:05-!- Nostromus [~chatzilla@g224151092.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141127110442]]
20141230 06:17:08-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20141230 06:20:17-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20141230 06:39:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141230 06:48:22< vultraz> ya know, whoever raised the point about [tutorial] has a valid point. why isn't it just [scenario]
20141230 07:06:38-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20141230 07:20:15-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20141230 07:20:56-!- Sulfur [~Miranda@p5B008152.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141230 07:24:19-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 240 seconds]
20141230 07:25:36< vultraz> oh hey zookeeper 
20141230 07:25:44< vultraz> I took a look at your tutorial
20141230 07:26:24-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 244 seconds]
20141230 07:27:07< zookeeper> vultraz, what did you think?
20141230 07:29:49< zookeeper> i noticed that at least one message was mysteriously not being shown at all, so i dunno if there's a lot more of that or not
20141230 07:31:14-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20141230 07:33:57< vultraz> zookeeper: it's a slight improvement over the mainline one, in some areas, but IMO, the 'fun' feeling of the mainline one is missing
20141230 07:34:12< vultraz> I dunno what to do with it
20141230 07:34:33< vultraz> Should I work on integrating it with mainlines? finish it and replace it?
20141230 07:35:36< zookeeper> yes, i never paid any attention to making it especially fun, i just wanted to cram all the information in and leave funnification for later
20141230 07:36:03< vultraz> it seems there's too MUCH information
20141230 07:36:14< zookeeper> eh, i dunno, i guess i could re-familiarize myself with it first
20141230 07:36:19< zookeeper> yes, there's a lot
20141230 07:39:41< vultraz> stuff like ZoC and stuff should really be in the second scenario
20141230 07:39:58< vultraz> IMO, the mainline S1 is fine
20141230 07:40:07< vultraz> But looking at the code for S2, I'm tempted to scrap it
20141230 07:40:09< vultraz> and redo it
20141230 07:47:33-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20141230 07:49:02< zookeeper> my main problem with mainline is the constant "click here" "now click here" "and now click here" and how everything is hardcoded
20141230 07:49:37< vultraz> Indeed
20141230 07:49:41< zookeeper> you learn nothing if you don't actually do stuff on your own, but just click where the game tells you to click
20141230 07:50:03< zookeeper> i don't know how badly either scenario breaks if you don't do exactly as you're told, but it used to break a lot
20141230 07:50:04< ancestral> Just curious, where is your tutorial?
20141230 07:50:04< vultraz> Especially the second scenario
20141230 07:50:10< vultraz> the AI is hardcoded!
20141230 07:50:25< zookeeper> ancestral, https://dl.dropboxusercontent.com/u/63964618/wesnoth/Tutorial.7z
20141230 07:51:44< zookeeper> anyway, as i said, i didn't pay any attention to making it fun because i'm not good at that. if it was to be finished then it would need to be funnified and streamlined and re-organized quite a lot, i'd imagine.
20141230 07:52:58< zookeeper> there's a lot of fancy code for demonstrating things like ZoC traps dynamically regardless of the exact unit positioning, so the player wouldn't be straightjacketed
20141230 07:56:57< vultraz> zookeeper: you have a point about hardcoding. I can remove some of the constant click here messages
20141230 08:03:49< zookeeper> yeah i certainly wouldn't mind
20141230 08:04:02< zookeeper> just "move next to the unit" is a lot better than "move exactly here"
20141230 08:04:05< zookeeper> etc
20141230 08:04:20< vultraz> Yeah
20141230 08:04:30< vultraz> we do have adjacent filters
20141230 08:04:30< zookeeper> of course then the player might end up far enough that they can't get to the keep in one turn and that might cause a problem, i dunno
20141230 08:11:10< vultraz> zookeeper: should I also remove the "you moved to the wrong place!"
20141230 08:11:10< vultraz> message
20141230 08:11:50< zookeeper> i dunno, should you? :P
20141230 08:13:55< vultraz> well it works with absolute locations...and for example, you'll get it if you're heading towards the village and accidentally click a hex in the middle.
20141230 08:14:00< vultraz> IMO, it's just confusing
20141230 08:16:17-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 264 seconds]
20141230 08:16:23< zookeeper> well, if the player can't break the tutorial by not undoing after they get that message, then yes, i'd say it should be removed
20141230 08:19:45< vultraz> I made it impossible to end turn if they don't complete requite actions in the first few turns
20141230 08:19:57-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has quit [Ping timeout: 240 seconds]
20141230 08:19:58< vultraz> so I think I'll add a note about undoing if you mess up
20141230 08:20:02< vultraz> but remove the moveto message
20141230 08:21:37< zookeeper> impossible to end turn? what if they mess up and manage to invalidate their undo somehow and get stuck? or is that impossible?
20141230 08:23:20< vultraz> I think it's impossible
20141230 08:23:30< vultraz> since there's no shroud or ambushes
20141230 08:25:02< zookeeper> i hope so
20141230 08:25:33-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20141230 08:33:44< vultraz> I reduced the wrong loc event to a simple catch-all [allow_undo] event
20141230 08:33:50< vultraz> to be safe
20141230 08:36:15< zookeeper> okay
20141230 08:40:49< Necrosporus> Why there are no events in :inspect?
20141230 08:41:56< Necrosporus> There seem to be some event in scenario causing strange effect is there any way to see what event is causing it?
20141230 08:42:09< Necrosporus> beside reading scenario file
20141230 08:43:54< Necrosporus> Also there are no coords in inspect
20141230 08:44:05< Necrosporus> is there a way to see hidden enemy units?
20141230 08:45:14-!- lipkab [~the_new_l@apn-185-10-127-86.vodafone.hu] has joined #wesnoth-dev
20141230 08:50:11< vultraz> zookeeper: is there a reason we get rid of traits for recruits in s1?
20141230 08:50:18< vultraz> " # zookeeper suggested we eliminate traits by killing the recruit and replacing it"
20141230 08:53:28-!- irker976 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20141230 09:02:00< zookeeper> very likely it was to make HP's/MP's consistent
20141230 09:05:30-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141230 09:24:57-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-eomussrgkstmlqos] has quit [Ping timeout: 258 seconds]
20141230 09:27:35-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-ilulotscuksemuzy] has joined #wesnoth-dev
20141230 09:27:58-!- matthiaskrgr is now known as Guest6239
20141230 09:48:30-!- irker696 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20141230 09:48:30< irker696> wesnoth: Charles Dang wesnoth:master 04ca78b4a7e6 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: T S2: fixed some indent to shut wmlindent up http://git.io/Nrs0UA
20141230 09:48:31< irker696> wesnoth: Charles Dang wesnoth:master e2829315a039 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: preliminary reduction of 'hand holding' http://git.io/87xSmA
20141230 09:48:35< vultraz> zookeeper: ^
20141230 09:57:20< zookeeper> why the -in +on change? just because you visually stand on top of the keep? :P
20141230 09:57:54< vultraz> yeah
20141230 09:58:23< zookeeper> right. would you similarly say that "you are standing on a castle"?
20141230 09:58:36< zookeeper> nevermind
20141230 09:59:34< zookeeper> anyway, i don't really see the point of that, and the same thing WRT the end turn button seems wrong to me. surely it's more commonly "in the bottom right of the screen", not "on the bottom right of the screen"?
20141230 10:00:14< vultraz> hm
20141230 10:00:17< vultraz> yes, you're right there
20141230 10:01:27< zookeeper> the [allow_undo] moveto event is now pointless, it doesn't do anything
20141230 10:03:22-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141230 10:04:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 265 seconds]
20141230 10:08:07-!- Guest6239 [matthiaskr@gateway/shell/panicbnc/x-ilulotscuksemuzy] has quit [Changing host]
20141230 10:08:09-!- Guest6239 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20141230 10:08:09-!- Guest6239 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20141230 10:08:09-!- Guest6239 [matthiaskr@gateway/shell/panicbnc/x-ilulotscuksemuzy] has joined #wesnoth-dev
20141230 10:08:17-!- Guest6239 is now known as matthiaskrg
20141230 10:08:46< irker696> wesnoth: Charles Dang wesnoth:master bcce36c683e3 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: removed some unused local macros, and expanded others that were used once http://git.io/WTEtgw
20141230 10:08:49< irker696> wesnoth: Charles Dang wesnoth:master b29b2195accf / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: simplified variable character placement http://git.io/L_gXVA
20141230 10:08:52< irker696> wesnoth: Charles Dang wesnoth:master 571892be4630 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: dropped the now-useless catch-all undo event http://git.io/1aLLHw
20141230 10:08:55< irker696> wesnoth: Charles Dang wesnoth:master 56613ae19c1d / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: fixed an on -> in screwup of mine http://git.io/Ja4aMQ
20141230 10:09:37< vultraz> zookeeper: regarding the attack dialog, I'm considering reducing it to a simple exposition on the attack you used, instead of all these varying bits
20141230 10:18:37-!- lipkab [~the_new_l@apn-185-10-127-86.vodafone.hu] has quit [Ping timeout: 240 seconds]
20141230 10:20:53< irker696> wesnoth: Charles Dang wesnoth:master 3a9a0c9cb09f / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: dropped the now-unused 'student' var http://git.io/btBYKA
20141230 10:20:56< irker696> wesnoth: Charles Dang wesnoth:master 1efb28227d49 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: clear student_store after use http://git.io/PFXk1g
20141230 10:20:59< irker696> wesnoth: Charles Dang wesnoth:master 635f5fa369e3 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: made sure Li'sar is facing correctly http://git.io/YGZX3w
20141230 10:22:01-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev
20141230 10:23:38< irker696> wesnoth: Charles Dang wesnoth:master def9b84698a8 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: dropped wmllint: no-syntax-rewrite comment http://git.io/o6wcUw
20141230 10:23:41< irker696> wesnoth: Charles Dang wesnoth:master 421dad3ebacf / data/campaigns/tutorial/ (scenarios/01_Tutorial_part_1.cfg utils/utils.cfg): T: moved CONTINUE_MSG to utils http://git.io/ry8liw
20141230 10:25:59-!- travis-ci [~travis-ci@ec2-54-145-179-166.compute-1.amazonaws.com] has joined #wesnoth-dev
20141230 10:25:59< travis-ci> wesnoth/wesnoth#5338 (master - e282931 : Charles Dang): The build was broken.
20141230 10:25:59< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45434430
20141230 10:25:59-!- travis-ci [~travis-ci@ec2-54-145-179-166.compute-1.amazonaws.com] has left #wesnoth-dev []
20141230 10:30:17-!- lipkab [~the_new_l@apn-185-10-127-86.vodafone.hu] has joined #wesnoth-dev
20141230 10:33:43-!- Nostromus [~chatzilla@g224151092.adsl.alicedsl.de] has joined #wesnoth-dev
20141230 10:36:09-!- lipkab [~the_new_l@apn-185-10-127-86.vodafone.hu] has quit [Ping timeout: 256 seconds]
20141230 10:43:14< irker696> wesnoth: Charles Dang wesnoth:master 977e7eb6f51f / data/campaigns/tutorial/ (scenarios/01_Tutorial_part_1.cfg utils/utils.cfg): T S1: better explanation for the village heal in turn 3. Also dropped a newline  http://git.io/AVXctg
20141230 10:48:40-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20141230 10:55:02-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 258 seconds]
20141230 11:08:49-!- cib0 [~cib@p5DD214AB.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141230 11:12:56-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20141230 11:14:16-!- Sulfur [~Miranda@p5B008152.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141230 11:37:05< irker696> wesnoth: Charles Dang wesnoth:master 752fae9e2151 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: improved and cleaned up hp state tracking http://git.io/YFbrhg
20141230 11:38:49< vultraz> That commit took way longer to write than it should have
20141230 11:44:21< irker696> wesnoth: Charles Dang wesnoth:master 2659bec58c9e / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: do not cutoff student's moves once they move to Delf http://git.io/IYaYVw
20141230 11:51:26< irker696> wesnoth: Charles Dang wesnoth:master 99b4a835f1dc / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: improved text http://git.io/T1bT1w
20141230 11:53:06-!- kex [~kex@77.29.86.199] has joined #wesnoth-dev
20141230 11:57:04< irker696> wesnoth: Charles Dang wesnoth:master 8c164d598a75 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: greatly simplified Delf's lines about attacking http://git.io/fDEN1w
20141230 11:57:13< vultraz> zookeeper: ^ acceptable? 
20141230 11:58:26< zookeeper> "nearest village"? are there several?
20141230 11:59:26< vultraz> on the outskirts of the map. Just added that to indirectly clarify we mean the one right next to the castle
20141230 11:59:58< zookeeper> "Since it’s probably best not to attempt attacking the quintain this turn, you can recruit two units instead if you return to the keep." <- that "Since [...], you can recruit two units instead [...]" doesn't sound quite right to me?
20141230 12:01:31< zookeeper> also, is "stats" a proper word we should be using in-game?
20141230 12:02:13< vultraz> how about: "You can recruit two units instead if you return to the keep; it’s probably best not to attempt attacking the quintain this turn, "
20141230 12:02:32< vultraz> s/turn,/turn.
20141230 12:03:14< zookeeper> instead of what? that wouldn't be clear, at least grammatically, i believe
20141230 12:03:29< vultraz> er, without the instead
20141230 12:03:36< vultraz> 'units if'
20141230 12:05:43< zookeeper> "you could instead return to the keep and recruit two units"?
20141230 12:05:57-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20141230 12:06:43-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20141230 12:06:57< vultraz> I like
20141230 12:07:00< vultraz> so, full would be
20141230 12:07:07< vultraz> "A splendid idea! It’s probably best not to attempt attacking the quintain this turn. Instead, you could return to the keep and recruit two units; you have plenty of gold for that."
20141230 12:07:18< vultraz> (I swapped instead and you could)
20141230 12:15:09< zookeeper> seems ok to me
20141230 12:15:59< irker696> wesnoth: Charles Dang wesnoth:master 862c061053f5 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: tweaked a line on zookeeper's request http://git.io/ed1-yw
20141230 12:16:02< irker696> wesnoth: Charles Dang wesnoth:master 1fb15f012856 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: used [message] speaker= syntax instead of [message] id= where applicable http://git.io/VFaRNw
20141230 12:17:05-!- travis-ci [~travis-ci@ec2-54-198-140-112.compute-1.amazonaws.com] has joined #wesnoth-dev
20141230 12:17:05< travis-ci> wesnoth/wesnoth#5342 (master - 977e7eb : Charles Dang): The build was fixed.
20141230 12:17:05< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45437393
20141230 12:17:05-!- travis-ci [~travis-ci@ec2-54-198-140-112.compute-1.amazonaws.com] has left #wesnoth-dev []
20141230 12:27:18< irker696> wesnoth: Charles Dang wesnoth:master 6cf655b07b0a / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: show the wesnoth icon on 'lesson' messages http://git.io/LewGkQ
20141230 12:27:37< vultraz> zookeeper: last thing I'd like to address in S1 is the very annoying "Press a mouse button or space bar to continue" message
20141230 12:30:16< zookeeper> what's annoying about it?
20141230 12:30:50< zookeeper> oh, right, it's that common
20141230 12:30:58< zookeeper> sure, trim it down to the first couple of messages only
20141230 12:35:59< irker696> wesnoth: Charles Dang wesnoth:master 379795c94454 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: reduce occurrences of CONTINUE_MESSAGE http://git.io/F-iUtw
20141230 12:39:32-!- Sulfur [~Miranda@p5B008152.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141230 12:40:12< irker696> wesnoth: Charles Dang wesnoth:master 389ea930ee92 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: removed one further case of CONTINUE_MESSAGE http://git.io/wsQMKg
20141230 12:40:16< vultraz> alright. now you just see it twice
20141230 12:48:24< irker696> wesnoth: Charles Dang wesnoth:master c441fda54bfd / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: clear description_num on victory http://git.io/SmhVxg
20141230 12:50:41< irker696> wesnoth: Charles Dang wesnoth:master 3976a5e68dd3 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: fixup 6cf655b07b0a, I forgot the victory message http://git.io/Lxumvw
20141230 13:05:51-!- enchilado [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 270 seconds]
20141230 13:06:25-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-ohzwgbpjhhbunscy] has joined #wesnoth-dev
20141230 13:10:34-!- travis-ci [~travis-ci@ec2-54-198-140-112.compute-1.amazonaws.com] has joined #wesnoth-dev
20141230 13:10:34< travis-ci> wesnoth/wesnoth#5344 (master - 752fae9 : Charles Dang): The build has errored.
20141230 13:10:34< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45440773
20141230 13:10:34-!- travis-ci [~travis-ci@ec2-54-198-140-112.compute-1.amazonaws.com] has left #wesnoth-dev []
20141230 13:11:53-!- cib [~cib@p5DD214AB.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141230 13:12:17-!- cib is now known as Guest22054
20141230 13:12:34-!- cib0 [~cib@p5DD214AB.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds]
20141230 13:15:39-!- mjs-de [~mjs-de@p508CAB46.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141230 13:25:25-!- mjs-de [~mjs-de@p508CAB46.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20141230 13:43:10-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20141230 13:59:40-!- lml [~deepthoug@59.177.12.162] has joined #wesnoth-dev
20141230 14:09:55-!- vultraz [~chatzilla@124.109.10.167] has quit [Read error: Connection reset by peer]
20141230 14:09:55-!- rayblade53 [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20141230 14:10:13-!- rayblade53 is now known as vultraz
20141230 14:24:33-!- gfgtdf [~chatzilla@f054168161.adsl.alicedsl.de] has joined #wesnoth-dev
20141230 14:24:49-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer]
20141230 14:25:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20141230 14:26:30-!- lml [~deepthoug@59.177.12.162] has quit [Ping timeout: 265 seconds]
20141230 14:34:34-!- gfgtdf [~chatzilla@f054168161.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]]
20141230 14:38:38-!- lml [~deepthoug@120.56.140.68] has joined #wesnoth-dev
20141230 14:58:01-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20141230 15:00:45-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 244 seconds]
20141230 15:00:59< Nostromus> gfgtdf: It is recommened to close the pull request and open a clean one with one commit? Or is there another clean way?
20141230 15:04:18-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20141230 15:15:31-!- Guest22054 [~cib@p5DD214AB.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
20141230 15:31:02< Nostromus> gfgtdf: the indentation should now be correct, also there is only 1 commit.
20141230 15:34:04-!- Necrosporus_ is now known as Necrosporus
20141230 15:50:56-!- irker696 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20141230 15:52:01-!- cib0 [~cib@p5DD214AB.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141230 15:52:05-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20141230 15:55:03-!- Nostromus [~chatzilla@g224151092.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141127110442]]
20141230 16:00:18-!- gfgtdf [~chatzilla@e177017139.adsl.alicedsl.de] has joined #wesnoth-dev
20141230 16:00:21< gfgtdf> anyone with an opinion on https://github.com/wesnoth/wesnoth/pull/350 ?
20141230 16:00:44< gfgtdf> should i merge now or wait longer ?
20141230 16:51:01-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20141230 17:02:52-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds]
20141230 17:06:21-!- cib0 [~cib@p5DD214AB.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20141230 17:16:21-!- irker788 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20141230 17:16:21< irker788> wesnoth: Charles Dang wesnoth:master 6ff92aefa32e / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: fixed indent on the lua block http://git.io/EoHDYw
20141230 17:23:29< irker788> wesnoth: Charles Dang wesnoth:master 9ebd5ee46e48 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: purged a space in a message http://git.io/RiS8NA
20141230 17:23:32< irker788> wesnoth: Charles Dang wesnoth:master 90ff3a9b2adf / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: clarified 'the ranged attack' http://git.io/L2oHwQ
20141230 17:23:56-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has joined #wesnoth-dev
20141230 17:33:32< irker788> wesnoth: Charles Dang wesnoth:master 529a0620a74f / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: assign the 'veteran' role to any units who advance instead of flagging a v http://git.io/80pYwQ
20141230 17:48:13-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20141230 17:57:33< irker788> wesnoth: Charles Dang wesnoth:master 550801aa993e / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: removed defeat condition if player reaches turn 12 with the original quint http://git.io/MIQIgA
20141230 17:59:34< irker788> wesnoth: Charles Dang wesnoth:master 24d41a82447a / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: 'go up a level' -> 'gain a level' http://git.io/Il9OUQ
20141230 18:02:11< vultraz> Random fact: in 1.12, the tutorial is 1287 lines, in master, it's 1004
20141230 18:02:50< gfgtdf> sone c++11 expert here ?
20141230 18:08:59< gfgtdf> some*
20141230 18:16:34-!- lml [~deepthoug@120.56.140.68] has quit [Ping timeout: 265 seconds]
20141230 18:16:56< Sirp> gfgtdf: what's your question?
20141230 18:17:53< irker788> wesnoth: Charles Dang wesnoth:master 795a10d830f2 / data/campaigns/tutorial/maps/01_Tutorial_part_1.map: T S1: more map updates http://git.io/kdvwYg
20141230 18:25:23< irker788> wesnoth: Charles Dang wesnoth:master a14fbc7da51a / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: got rid of non-standard word wrap. In one case, split message into two mes http://git.io/MsM3lw
20141230 18:28:55-!- lml [~deepthoug@120.56.132.156] has joined #wesnoth-dev
20141230 18:30:01< gfgtdf> Sirp: this code http://pastebin.com/tCTVCCyS gives me an linker error if complied with clang, and im not sure whether it my fault or clangs fault.
20141230 18:30:29< gfgtdf> Sirp: (or maybe the linkers fault)
20141230 18:30:45< irker788> wesnoth: Charles Dang wesnoth:master e6a7b34555f1 / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: expand village capture SLF to all villages for portability http://git.io/9PdaTg
20141230 18:48:40< Sirp> gfgtdf: well what is the link error specifically?
20141230 18:48:57< gfgtdf> Sirp: undefined reference to `some_constants::c1'
20141230 18:49:53< gfgtdf> Sirp: actuyl i thought sine it is a comnplitim time costant it doesnt its inserted during compilation of the cpp file and not needed at linking
20141230 18:49:58< gfgtdf> since*
20141230 18:50:04< irker788> wesnoth: Charles Dang wesnoth:master f222744f4ec9 / data/ (_main.cfg campaigns/tutorial/_main.cfg): Moved Tutorial textdomain and ifdef into its _main.cfg to avoid it being include http://git.io/poqaqA
20141230 18:50:57< gfgtdf> actually i thought since it is a compile time costant it is replaced during compilation of the cpp file and not needed at linking*
20141230 18:51:19< gfgtdf> Sirp: when i use mingw it works.
20141230 18:51:22-!- kex [~kex@77.29.86.199] has quit [Remote host closed the connection]
20141230 18:53:04-!- kex [~kex@77.29.86.199] has joined #wesnoth-dev
20141230 18:53:09-!- kex [~kex@77.29.86.199] has quit [Remote host closed the connection]
20141230 18:53:22-!- kex [~kex@77.29.86.199] has joined #wesnoth-dev
20141230 18:56:39< Sirp> gfgtdf: so yeah you might need to add a definition of it outside the class?
20141230 18:56:44< Sirp> not sure if this is conforming though
20141230 18:57:50< gfgtdf> Sirp: but i want complie time constants, for ints i can also write static const int i = 9; I thought that's what teh constexpr is about
20141230 18:58:56< Sirp> gfgtdf: hack hack: enum { i = 9 } :p
20141230 19:13:22-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141230 19:22:53-!- kex [~kex@77.29.86.199] has quit [Remote host closed the connection]
20141230 19:34:33-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20141230 19:42:04-!- lml [~deepthoug@120.56.132.156] has quit [Quit: Leaving]
20141230 20:00:23< gfgtdf> Sirp: that code was just an example (anit the version with a raw int also works)
20141230 20:00:46< gfgtdf> Sirp: enum a { ii = some_constants::c1.i_ }; also works
20141230 20:03:22-!- Nostromus [~chatzilla@g224151092.adsl.alicedsl.de] has joined #wesnoth-dev
20141230 20:20:10-!- TooLmaN_ [~TooLmaN@adsl-070-148-222-166.sip.ags.bellsouth.net] has joined #wesnoth-dev
20141230 20:23:28-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Ping timeout: 244 seconds]
20141230 20:26:41-!- TooLmaN__ [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20141230 20:29:46-!- TooLmaN__ [~TooLmaN@mail.thomsonplastics.com] has quit [Client Quit]
20141230 20:30:09-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20141230 20:30:42-!- TooLmaN_ [~TooLmaN@adsl-070-148-222-166.sip.ags.bellsouth.net] has quit [Ping timeout: 245 seconds]
20141230 20:44:52-!- timotei__ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 245 seconds]
20141230 20:46:00-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20141230 20:47:49-!- Sulfur [~Miranda@p5B008152.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20141230 20:53:53< Nostromus> shadowm: i see a lot of bug links in commit messages in almost every other pull request, so which is the right way. i changed it to bug number, but i want to know which is the right way for the future
20141230 20:55:26< shadowm> Bug number.
20141230 20:56:17< Nostromus> ok
20141230 21:01:02-!- lml [~deepthoug@120.56.132.156] has joined #wesnoth-dev
20141230 21:01:11-!- lml [~deepthoug@120.56.132.156] has quit [Max SendQ exceeded]
20141230 21:01:39-!- lml [~deepthoug@120.56.132.156] has joined #wesnoth-dev
20141230 21:05:03-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20141230 21:47:04-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Quit: Off to save the world!]
20141230 21:59:37-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20141230 22:00:06-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141230 22:04:21-!- gfgtdf_ [~chatzilla@e177150102.adsl.alicedsl.de] has joined #wesnoth-dev
20141230 22:05:36-!- lml [~deepthoug@120.56.132.156] has quit [Quit: Leaving]
20141230 22:06:04-!- gfgtdf [~chatzilla@e177017139.adsl.alicedsl.de] has quit [Ping timeout: 245 seconds]
20141230 22:06:17-!- gfgtdf_ is now known as gfgtdf
20141230 22:34:52-!- mjs-de [~mjs-de@p508CAB46.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141230 22:40:10-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has joined #wesnoth-dev
20141230 22:52:33-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has quit [Quit: End Transmission.]
20141230 22:52:51-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has joined #wesnoth-dev
20141230 22:59:38-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20141230 23:00:44-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20141230 23:02:15-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-ohzwgbpjhhbunscy] has quit [Changing host]
20141230 23:02:15-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20141230 23:05:50< shadowm> vultraz: Please backport that wmllint commit.
20141230 23:06:01-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20141230 23:07:15< iceiceice> gfgtdf: one use of wesnoth.game_config.mp_settings is to see if the timer is enabled
20141230 23:07:35< gfgtdf> iceiceice: hm that makes sense i guess.
20141230 23:08:20-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20141230 23:08:32< iceiceice> its unfortunate that i put it under game_config a bit...
20141230 23:08:58< iceiceice> it makes it more complicated if we want to make game_config available to map generators for instance
20141230 23:31:21-!- markus_ [~mjs-de@p508C9EA7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20141230 23:31:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20141230 23:32:07< irker788> wesnoth: Michael Strebel wesnoth:master 96432397f174 / src/ (game_launcher.cpp saved_game.cpp): Fix for era carryover bug in tutorial. http://git.io/y_8AHw
20141230 23:32:09< irker788> wesnoth: gfgtdf wesnoth:master db27f81d0fdf / src/ (game_launcher.cpp saved_game.cpp): Merge pull request #354 from mstrebel/bug-era-carryover http://git.io/mCptmA
20141230 23:34:22-!- mjs-de [~mjs-de@p508CAB46.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20141230 23:38:38-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20141230 23:45:30-!- markus_ [~mjs-de@p508C9EA7.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20141230 23:46:07-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has joined #wesnoth-dev
--- Log closed Wed Dec 31 00:00:36 2014