--- Log opened Thu Jan 01 00:00:54 2015
20150101 00:05:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150101 00:16:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20150101 00:43:32-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150101 00:47:12-!- markus_ [~mjs-de@p508CBD80.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20150101 00:47:34-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150101 00:51:38-!- yarker [~bismilah@li629-190.members.linode.com] has quit [Remote host closed the connection]
20150101 00:55:33-!- yarker [~bismilah@li629-190.members.linode.com] has joined #wesnoth-dev
20150101 01:00:29-!- irker929 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150101 01:04:28-!- cib0 [~cib@p508BC0F6.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20150101 01:28:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150101 01:46:42-!- gfgtdf [~chatzilla@f054049080.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]]
20150101 01:47:10-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150101 02:15:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150101 02:17:00-!- gfgtdf [~chatzilla@f054049080.adsl.alicedsl.de] has joined #wesnoth-dev
20150101 02:17:11< gfgtdf> iceiceice: any explanation for https://github.com/wesnoth/wesnoth/commit/e85c37e161795794e1ae6d2c6b59377a16988c10 ?
20150101 02:18:10< gfgtdf> iceiceice: i guess i'll just make a bug report
20150101 02:27:36-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20150101 02:37:17-!- gfgtdf [~chatzilla@f054049080.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]]
20150101 02:56:12-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Remote host closed the connection]
20150101 02:57:56-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150101 03:09:33-!- Ivanovic_ [~ivanovic@frnk-5f7522b8.pool.mediaWays.net] has joined #wesnoth-dev
20150101 03:13:00-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 250 seconds]
20150101 03:13:27-!- Ivanovic_ is now known as Ivanovic
20150101 03:15:49-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 265 seconds]
20150101 03:19:25-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150101 03:20:08-!- Ivanovic [~ivanovic@frnk-5f7522b8.pool.mediaWays.net] has quit [Changing host]
20150101 03:20:08-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20150101 03:36:02-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has joined #wesnoth-dev
20150101 03:36:04-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has quit [Client Quit]
20150101 03:49:46-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150101 04:08:00-!- ToBeCloud [uid51591@gateway/web/irccloud.com/x-ohsfecxnmrnrlalh] has quit [Quit: Connection closed for inactivity]
20150101 04:13:33-!- oldlaptop_ is now known as oldlaptop
20150101 04:36:43-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has joined #wesnoth-dev
20150101 05:06:02-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150101 05:10:17-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.0.1]
20150101 05:10:22-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has joined #wesnoth-dev
20150101 05:11:57-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20150101 05:32:39-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150101 05:55:24< vultraz-festive> so, who's going to do the new years copyright update?
20150101 06:04:16< ancestral> Happy MMXV!
20150101 06:04:54< ancestral> vultraz-festive: Is it appropriate to make a change just for making a change’s sake?
20150101 06:05:37< ancestral> ;-) In other words, normally, when you make a change you update the date, not to make an update just to change the date.
20150101 07:02:12-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20150101 07:09:03< Necrosporus> Why could AI be wery slow?
20150101 07:40:11-!- Sulfur [~Miranda@p5B009439.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150101 09:03:29-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150101 09:41:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150101 09:47:35-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20150101 09:50:24-!- mjs-de [~mjs-de@p508CBD80.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150101 09:53:24-!- cib0 [~cib@p5DD22B73.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150101 10:05:37-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20150101 10:30:04-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150101 10:42:51-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150101 11:03:52-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Ping timeout: 255 seconds]
20150101 11:29:07-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150101 11:30:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150101 11:32:32-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150101 11:52:09-!- irker988 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150101 11:52:09< irker988> wesnoth: Charles Dang wesnoth:master 7558fa5acd11 / projectfiles/CodeBlocks/wesnoth.cbp: Updated codeblocks projectfile http://git.io/J1sEdw
20150101 12:11:52-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20150101 12:35:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150101 13:00:02< zookeeper> it'll take forever to fix all these not-so-great campaign scenario playlists...
20150101 13:26:20< vultraz-festive> yup//
20150101 13:26:31< vultraz-festive> and I still have T S2 to deal with :(
20150101 13:39:33< vultraz-festive> zookeeper: do you think it's worth reworking T S2 or should I rewrite it
20150101 13:40:17-!- cib0 [~cib@p5DD22B73.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds]
20150101 13:42:25-!- cib0 [~cib@p5DD22B73.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150101 13:47:10-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20150101 13:52:16-!- Sulfur [~Miranda@p5B009439.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150101 14:00:08-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20150101 14:02:31-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 255 seconds]
20150101 14:14:33< zookeeper> vultraz-festive, well, depends on the amount of rework and the quality of the rewrite, i guess :p
20150101 14:17:46-!- Sulfur [~Miranda@p5B009439.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150101 14:37:16< zookeeper> wait, what the heck is this? https://dl.dropboxusercontent.com/u/63964618/wesnoth/fogallyweirdness.jpg
20150101 14:37:34< zookeeper> master, with no vision sharing specified in either [side]
20150101 14:52:28-!- irker988 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150101 14:58:15-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20150101 15:00:34< vultraz-festive> o_O
20150101 15:01:19-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 264 seconds]
20150101 15:17:50-!- Necrosporus_ is now known as Necrosporus
20150101 15:42:59-!- cib [~cib@p5DD22B73.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150101 15:43:00-!- cib0 [~cib@p5DD22B73.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150101 15:43:23-!- cib is now known as Guest4013
20150101 15:49:56< zookeeper> i can't make a manual save in-game either... the savefile just never appears
20150101 15:50:11< vultraz-festive> seems a lot is broken on master
20150101 15:50:28< zookeeper> autosaves work though
20150101 15:51:00< vultraz-festive> anyway...regarding the tutorial s2 .I think first I'll clean up the code, decide what to keep, and then add stuff from there
20150101 15:52:02< vultraz-festive> zookeeper: do you happen to know what the "# ugly trait hack..." is for?
20150101 15:52:10< vultraz-festive> line 54
20150101 15:53:44< zookeeper> must be from before you could have done those more cleanly with [insert_tag] or something
20150101 15:54:36 * vultraz-festive browses the code
20150101 15:55:11< zookeeper> that whole REFUND_AND_REMOVE_RECRUIT thing seems redundant
20150101 15:55:17< zookeeper> you could just unstore the unit to the recall list
20150101 15:56:12< vultraz-festive> yeah...
20150101 15:56:29< zookeeper> i mean, sure keep the macro, but in the recall branch just unstore the unit to the recall list instead of that horrible unit recreation hack
20150101 15:56:49< vultraz-festive> ok this whole scenario is just too screwed up to fix...I'll just have to rewrite everything 
20150101 15:57:06< vultraz-festive> I guess I should identify the key points
20150101 15:57:14< zookeeper> we even have a [put_to_recall_list] tag, woot?
20150101 15:57:20 * zookeeper looked at PUT_TO_RECALL_LIST
20150101 15:57:20< vultraz-festive> yes 
20150101 15:57:27< vultraz-festive> hm...
20150101 15:58:08< vultraz-festive> hmmm...
20150101 15:58:21< vultraz-festive> ok, I'm definitely getting rid of the manual control of the ai to start with
20150101 15:59:05< vultraz-festive> zookeeper: do you consider the part where your recruit gets taken back if you don't recruit what the guy says too 'hand holdy'?
20150101 15:59:29< zookeeper> yeah
20150101 15:59:54-!- gfgtdf [~chatzilla@f054049080.adsl.alicedsl.de] has joined #wesnoth-dev
20150101 16:00:05< zookeeper> ideally it should just allow you to choose whichever unit you want, and give the appropriate lesson for each one in whatever order you choose
20150101 16:00:50< gfgtdf> could we just use wesnoth.put_recall_unit to put a unit on teh recall list
20150101 16:01:06< zookeeper> and afterwards, tell you to recruit some other type of unit... and if you just pick the same unit over and over again, then you just miss out
20150101 16:04:10< gfgtdf> ok didnt read teh last part of teh conversation
20150101 16:05:32< vultraz-festive> good idea
20150101 16:06:29< zookeeper> i mean it's not a problem if the tutorial prevents you from making "mistakes", but i do think it should do so invisibly without burdening the player with explicit prompts
20150101 16:07:51< zookeeper> in this case, you can't really do that
20150101 16:08:31< zookeeper> you could take away archers from the recruit list once they've recruited an archer, and in that way force them to recruit one of every type, but then that'd be terribly confusing because your recruit list would just keep changing
20150101 16:08:34< zookeeper> so that's not good
20150101 16:09:47< zookeeper> but i think that if you're clearly told "now recruit something else" and you disregard that several times, then it's not something that even a tutorial really needs to account for... if it can account for it intelligently then sure, but it's not a problem IMO if it doesn't
20150101 16:11:20< zookeeper> ...not to mention that you can have delfador mention how the archers he really told you to get would have really been nice because you wouldn't be taking all this nasty melee retaliation when attacking
20150101 16:16:08< zookeeper> generally speaking i'd much prefer a tutorial which just tells you which button does what, lets you play around freely and then comments on your decisions and mistakes over a tutorial which tells you which buttons to press to play well
20150101 16:18:03< zookeeper> (of course the tutorial will still need some direction to establish what you're supposed to try to accomplish gameplay-wise and what would be a common sensible approach to it)
20150101 16:21:38< zookeeper> the most important thing to teach in the tutorial is the feel for the core mechanics of movement, turn cycles, attacking and when healing happens, for example
20150101 16:22:09< vultraz-festive> hm...yes
20150101 16:23:20< zookeeper> a completely new player won't know the basics of how the game works, such as how many times you can move a unit and how turns work etc
20150101 16:23:38< vultraz-festive> I think some of that should be discussed in S1
20150101 16:23:42< vultraz-festive> I'll do some more revision
20150101 16:23:53< zookeeper> yes, certainly, that's mostly S1 stuff
20150101 16:27:30< zookeeper> if you're unfamiliar with the genre, it might very well remain unclear for a while just how exactly the unit commands and turns work. like, you move unit A and then unit B but can you move unit A again after that? can you move unit C more if you don't move A or B? and so forth
20150101 16:28:38< zookeeper> sure enough people will pick up the basics quickly if they just start playing, but still, a good tutorial should accomplish that even faster
20150101 16:29:44< zookeeper> i know that when i started playing, i didn't understand the attack stats at all. 8-2? that's some kind of damage range, right, but why is it 8-2 and not 2-8? well 8 is a big number so i guess it does a lot of damage? *click*
20150101 16:36:10-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150101 16:36:35< zookeeper> fabi, ah, i might have found a bug introduced by the [music] change (i see it in master but not with 1.12.0); a scenario-level [music] with only the name= supplied won't play during the story screen.
20150101 16:36:40< zookeeper> should be reproducible anywhere where INTRO_AND_SCENARIO_MUSIC is used
20150101 16:44:01< zookeeper> (starting almost any campaign would qualify; LoW for instance)
20150101 16:51:00-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev
20150101 16:53:48-!- enchilado [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 244 seconds]
20150101 17:02:47-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-ztwccyppuxqcwxro] has joined #wesnoth-dev
20150101 17:03:05-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Quit: DCW]
20150101 17:09:46-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 250 seconds]
20150101 17:11:48-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150101 17:12:32< vultraz-festive> zookeeper: I think we should add, to the beginning of s1, a short dialog explaining the game window
20150101 17:12:54< vultraz-festive> Instead of having it spread out
20150101 17:13:11< vultraz-festive> "oh, end your turn" or "you can see stats by" later
20150101 17:13:16< vultraz-festive> have that in one place
20150101 17:16:54-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-ztwccyppuxqcwxro] has quit [Ping timeout: 245 seconds]
20150101 17:25:58-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-ppzezrggcaylunjq] has joined #wesnoth-dev
20150101 17:43:24-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-ppzezrggcaylunjq] has quit [Ping timeout: 244 seconds]
20150101 17:43:24-!- Guest4013 [~cib@p5DD22B73.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150101 17:43:44-!- cib0 [~cib@p5DD22B73.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150101 18:03:23-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has joined #wesnoth-dev
20150101 18:26:06-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20150101 18:29:58-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20150101 18:35:49-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150101 18:53:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150101 18:53:16-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has joined #wesnoth-dev
20150101 18:59:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150101 19:00:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150101 19:11:41< gfgtdf> vultraz-festive: online ?
20150101 19:12:04< vultraz-festive> yes
20150101 19:12:10< gfgtdf> vultraz-festive: did you test that saving a game still wokrs after https://github.com/wesnoth/wesnoth/commit/db39fd57ecd8d62aa5d093a18176e0374636abed ?
20150101 19:12:32< vultraz-festive> (im in the middle of a dota match so ill talk after)
20150101 19:12:34< gfgtdf> vultraz-festive: to me saving a game doesnt work anymore
20150101 19:12:44< vultraz-festive> but uhhh
20150101 19:12:46< vultraz-festive> hm
20150101 19:12:51< vultraz-festive> i think i just tested loading
20150101 19:13:09< vultraz-festive> did i do something wrong?
20150101 19:15:48< gfgtdf> vultraz-festive: i tried to save a game and teh file wasnt created
20150101 19:16:05< gfgtdf> vultraz-festive: i think you did.
20150101 19:18:12< vultraz-festive> hm
20150101 19:21:01-!- Sulfur [~Miranda@p5B009439.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150101 19:32:21< zookeeper> oh so it was his fault?
20150101 19:32:23 * zookeeper flogs
20150101 19:34:50< vultraz-festive> D:
20150101 19:47:22-!- cib0 [~cib@p5DD22B73.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20150101 19:48:10-!- cib0 [~cib@p5DD22B73.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150101 20:02:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150101 20:03:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150101 20:06:22-!- cib0 [~cib@p5DD22B73.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20150101 20:06:36 * vultraz-festive attempts fix
20150101 20:13:02-!- Fluffbeast [~Fluffbeas@pool-96-252-61-113.bstnma.fios.verizon.net] has joined #wesnoth-dev
20150101 20:13:06< vultraz-festive> hm...
20150101 20:15:12-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150101 20:22:13-!- localuser- [~none@gateway/tor-sasl/localuser-] has joined #wesnoth-dev
20150101 20:22:19< vultraz-festive> hmmm
20150101 20:25:20< vultraz-festive> I think I see the problem
20150101 20:52:19-!- irker542 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150101 20:52:19< irker542> wesnoth: Charles Dang wesnoth:master 6b5ba61761f1 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: T S2: dropped the manual ai control block http://git.io/jIRSrA
20150101 20:52:20< irker542> wesnoth: Charles Dang wesnoth:master c37e2c81f9bb / src/savegame.cpp: Fixed game saving that was broken with PR #344 http://git.io/Ei5swQ
20150101 20:52:26< vultraz-festive> gfgtdf: ^
20150101 20:54:52< shadowm> `while (!exit);`
20150101 20:54:57-!- Fluffbeast [~Fluffbeas@pool-96-252-61-113.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds]
20150101 20:55:02< shadowm> How did that even make it to a commit?
20150101 20:55:26< vultraz-festive> no idea
20150101 20:55:34< vultraz-festive> it was there before I started work
20150101 20:55:41< shadowm> No, it wasn't.
20150101 20:55:45< shadowm> https://github.com/wesnoth/wesnoth/pull/344/files#diff-3146e184b8c11d5b8a291b969f7e9208L379
20150101 20:56:00< shadowm> It was a do-while block, you dropped the do block and left the while statement orphaned.
20150101 20:56:21< vultraz-festive> ...oh
20150101 20:56:22< vultraz-festive> derp
20150101 20:56:27< shadowm> I shouldn't even have to explain the dfference between a do-while block and a while block.
20150101 20:56:35< vultraz-festive> I'm used to seeing while-do blocks
20150101 20:57:10< vultraz-festive> anyway, it's fixed
20150101 20:57:14< shadowm> Was this PR reviewed by anyone?
20150101 20:57:27< vultraz-festive> no. i was collabing with icecube, though
20150101 20:57:29< shadowm> Code-wise, not concept-wise.
20150101 20:57:40< vultraz-festive> but I think he was just checking it built and leaving me to report issues
20150101 20:57:52< shadowm> Next time you want a C++ commit to be merged mainline I strongly advise you get a C++ coder to review it line by line.
20150101 20:58:14< vultraz-festive> I'm not totally incompetent :/
20150101 20:58:45< shadowm> Well, you were asking me what pointers and references are not too long ago, so I have reasons to be concerned. ;)
20150101 21:00:21< vultraz-festive> I assume you'll be happy to see I used braces and added them to the other if block
20150101 21:01:10< shadowm> Somewhat. In this particular case it doesn't matter, but you should keep commits restricted to a single task.
20150101 21:01:40< shadowm> e.g. if you didn't have to reorder code anyway, the syntax changes would fall outside the scope of the fix.
20150101 21:01:42< vultraz-festive> I fixed the issue by refactoring the function
20150101 21:02:12< shadowm> Yes, I see that the code was reordered, hence my example above.
20150101 21:03:11< vultraz-festive> (I wonder if I could probably have done it even simpler with int res = show_save_dialog)
20150101 21:03:44< shadowm> ...
20150101 21:04:14< shadowm> Yes. Obviously. The original assignment is pointless because it's immediately replaced by another assignment and the type's operator= has no side effects.
20150101 21:04:52< shadowm> For that matter, that variable should be const.
20150101 21:05:16< vultraz-festive> const int?
20150101 21:05:44< shadowm> It's an int, yes.
20150101 21:07:39< vultraz-festive> is what I did in changing the default behavior to 'nothing' (return false) is any better/worse then having it default to save?
20150101 21:07:40< shadowm> Don't bother changing it, but in the future, if you are introducing new variables that get assigned exactly once, they should be const.
20150101 21:08:20< shadowm> I can't comment on that because I don't know that code.
20150101 21:08:44< shadowm> I have no idea what it's supposed to do or when it's called.
20150101 21:09:36< vultraz-festive> ok..I really should get a reviewer 
20150101 21:10:11< vultraz-festive> am I right in saying an else true on 'return retval == gui2::twindow::OK;' is useless? 
20150101 21:10:20< vultraz-festive> because I had added an else true
20150101 21:10:40< shadowm> Does it create dead code?
20150101 21:11:12< vultraz-festive> I think so
20150101 21:11:25< shadowm> Actually, what are you trying to do? I don't have a crystal ball and that line isn't in your commit.
20150101 21:12:12< vultraz-festive> it's in the overwrite prompt
20150101 21:12:19< vultraz-festive> 		int retval = gui2::show_message(video, _("Overwrite?"), message.str(), gui2::tmessage::yes_no_buttons);
20150101 21:12:21< vultraz-festive> 		return retval == gui2::twindow::OK;
20150101 21:12:35< shadowm> Yes, that's not in your commit.
20150101 21:12:43< vultraz-festive> it was in the PR
20150101 21:13:27< shadowm> https://github.com/wesnoth/wesnoth/pull/344/files -- can't find "Overwrite?" here.
20150101 21:14:44< vultraz-festive> hm...ok, no it wasn't, it was a similar line in check_filename.
20150101 21:14:57< vultraz-festive> that I added, but I'm wondering now if it was necessary
20150101 21:15:15< vultraz-festive> or the case I modeled it after (check_overwrite) is necessary either
20150101 21:22:59-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150101 21:24:01< vultraz-festive> hm,,
20150101 21:24:03< vultraz-festive> I guess it is
20150101 21:24:30< shadowm> Can I have a file:line reference?
20150101 21:24:34< vultraz-festive> I guess I don't need the else...
20150101 21:24:47< vultraz-festive> savegame.cpp:449 - 471
20150101 21:25:12< shadowm> Unmodified?
20150101 21:25:33< vultraz-festive> yes
20150101 21:25:44< shadowm> Explain why you feel the else block to be unneeded?
20150101 21:26:28< vultraz-festive> well
20150101 21:26:46< vultraz-festive> A. couldn't I just say return true in keeping with the other functions' style 
20150101 21:27:02< shadowm> That's what you do at the moment.
20150101 21:27:16< vultraz-festive> sans else {}
20150101 21:27:30< shadowm> Be the compiler for a second.
20150101 21:27:36< shadowm> Do you feel there's a difference either way?
20150101 21:28:00< vultraz-festive> you're the one always complaining if I miss a space before a bracket 
20150101 21:28:11< shadowm> I don't see any missed spaces here.
20150101 21:28:40< vultraz-festive> . . .
20150101 21:29:28< shadowm> Yes?
20150101 21:30:16< vultraz-festive> ok, two things
20150101 21:30:32< shadowm> I thought you were concerned about "behavior" (you said that), not syntax.
20150101 21:30:38< vultraz-festive> both
20150101 21:30:40< vultraz-festive> the syntax
20150101 21:30:42< vultraz-festive> AND
20150101 21:30:43< shadowm> The "behavior" is identical either way.
20150101 21:30:54< vultraz-festive> in check_overwrite
20150101 21:30:57< shadowm> The syntax is needlessly verbose but correct and not uncommon.
20150101 21:31:07< vultraz-festive> could I just move the return retval == gui2::twindow::OK; line out of the if block
20150101 21:31:11< vultraz-festive> and get rid of the whole else {}
20150101 21:31:26< vultraz-festive> (that wasn't my code, but I noticed it)
20150101 21:31:30< shadowm> Yes, you can but then retval isn't defined outside the if block is it.
20150101 21:32:16< shadowm> So the whole point of this conversation is to make your code "prettier"?
20150101 21:32:34< vultraz-festive> no, it was a question about return values
20150101 21:32:49< shadowm> 18:30:44 <shadowm> The "behavior" is identical either way.
20150101 21:34:27< shadowm> Look, I'm going to show you my version of these functions and you can draw your own conclusions from that.
20150101 21:36:28< shadowm> https://gist.github.com/shikadilord/4dbb42823bd24b2ace59
20150101 21:36:52< shadowm> Hidden in this is only ONE change I consider actually relevant.
20150101 21:37:06< shadowm> As an exercise for you, guess what the change is.
20150101 21:38:25< vultraz-festive> what's the difference between ostringstream and stringstream
20150101 21:38:33< shadowm> And note that line 9 is a matter of personal taste. Some would consider it to be too verbose.
20150101 21:40:22< shadowm> stringstream is a basic_iostream and ostringstream is a basic_ostream.
20150101 21:40:41< vultraz-festive> that doesn't tell me much
20150101 21:40:43< shadowm> basic_iostream is a basic_ostream AND a basic_istream. We don't need the latter's functionality.
20150101 21:41:04< vultraz-festive> is this your relevant change?
20150101 21:41:11< shadowm> No.
20150101 21:43:09< vultraz-festive> only think I could see is returning true without having to fall to else
20150101 21:43:12< vultraz-festive> thing*
20150101 21:43:21< shadowm> That's not it either.
20150101 21:43:32< vultraz-festive> and getting rid of a local variable
20150101 21:43:42< shadowm> Think harder about that local variable.
20150101 21:45:03< vultraz-festive> it's was useless before anyway, but...what else
20150101 21:45:32-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Quit: Sűrű sötét az éj, dühöng a déli szél]
20150101 21:45:32< shadowm> Yes, it was a useless copy.
20150101 21:46:19< shadowm> I'm sure I don't need to explain why you useless copy operations are not wanted.
20150101 21:46:31< vultraz-festive> Obviously
20150101 21:47:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150101 21:49:29-!- Nostromus [~chatzilla@f054013200.adsl.alicedsl.de] has joined #wesnoth-dev
20150101 21:50:59< vultraz-festive> since that amounted to nothing, im off
20150101 21:51:13< irker542> wesnoth: Charles Dang wesnoth:master 97e1a3a6b719 / src/savegame.cpp: Minor additional simplification/improvement to c37e2c81f9bb http://git.io/ycyNIg
20150101 22:00:28-!- OnkV [~quassel@85.124.51.57] has joined #wesnoth-dev
20150101 22:01:17-!- ShikadiLord [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150101 22:01:18-!- shadowm [~ignacio@wesnoth/developer/shadowm] has quit [Killed (kornbluth.freenode.net (Nickname regained by services))]
20150101 22:01:18-!- ShikadiLord is now known as shadowm
20150101 22:01:31< shadowm> vultraz-festive: Remove that pointless local copy, that's what I'm saying. That's not "nothing".
20150101 22:02:19< shadowm> Also, you wanted cosmetic changes in the first place, you got one possible set (of a myriad others) of cosmetic changes.
20150101 22:03:14-!- nurupo_ [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150101 22:04:07-!- cib0 [~cib@p5DD22B73.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150101 22:05:47-!- MaraJade [goossenm@osuosl/staff/MaraJade] has quit [Ping timeout: 256 seconds]
20150101 22:05:49-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 256 seconds]
20150101 22:05:51-!- nurupo_ is now known as nurupo
20150101 22:05:52-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 264 seconds]
20150101 22:07:56< irker542> wesnoth: Ignacio R. Morelle website:master 8505977c029e / gettext.wesnoth.org/ (index.extra.php index.lang.php index.php): gettext.w.o: New Year copyright update http://git.io/FOAf-g
20150101 22:07:59< irker542> wesnoth: Ignacio R. Morelle website:master b5adf2395d43 / eclipse.wesnoth.org/ (download.html features.html index.html): eclipse.w.o: New Year copyright update http://git.io/kU3o9A
20150101 22:08:02< irker542> wesnoth: Ignacio R. Morelle glamdrol:master eeb176583d77 / glamdrol/ (glamdrol.php glamdrol.skin.php): New Year copyright update http://git.io/UR5yzw
20150101 22:08:05< irker542> wesnoth: Ignacio R. Morelle wesnoth:master 57ae45387a4d / / (1250 files in 63 dirs): New Year copyright update http://git.io/LWmyyg
20150101 22:08:08< irker542> wesnoth: Ignacio R. Morelle wesnoth:master 5d82848668f6 / data/tools/unit_tree/html_output.py: units.w.o: New Year copyright update http://git.io/FXz53Q
20150101 22:08:11< irker542> wesnoth: Ignacio R. Morelle wesnoth:master 9171f861748e / data/tools/helptrailer.html: website: New Year copyright update http://git.io/snxhqA
20150101 22:08:14< irker542> wesnoth: Ignacio R. Morelle wesnoth:master c080ed5b2142 / data/tools/addon_manager/html.py: addons.w.o: New Year copyright update http://git.io/xLYaYQ
20150101 22:08:17< irker542> wesnoth: Ignacio R. Morelle wesnoth:1.12 b12f4fabacba / / (1071 files in 54 dirs): New Year copyright update http://git.io/O4a5VA
20150101 22:08:20< irker542> wesnoth: Ignacio R. Morelle wesnoth:1.12 b335b1026d37 / data/tools/unit_tree/html_output.py: units.w.o: New Year copyright update http://git.io/a0h8xw
20150101 22:08:23< irker542> wesnoth: Ignacio R. Morelle wesnoth:1.12 3e5196b0882d / data/tools/helptrailer.html: website: New Year copyright update http://git.io/uGdMmg
20150101 22:08:26< irker542> wesnoth: Ignacio R. Morelle wesnoth:1.12 1398133eacd6 / data/tools/addon_manager/html.py: addons.w.o: New Year copyright update http://git.io/q53sOw
20150101 22:15:56-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150101 22:19:22-!- localuser- [~none@gateway/tor-sasl/localuser-] has quit [Remote host closed the connection]
20150101 22:34:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20150101 22:34:36-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 244 seconds]
20150101 22:35:10-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150101 22:50:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150101 22:55:35-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-qllyrjsimnvohocd] has joined #wesnoth-dev
20150101 22:56:05-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-qllyrjsimnvohocd] has quit [Client Quit]
20150101 22:57:33-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-wzjvjvffzhjwjqrr] has joined #wesnoth-dev
20150101 22:58:11-!- enchilado [enchilado@gateway/shell/blinkenshell.org/x-wzjvjvffzhjwjqrr] has quit [Changing host]
20150101 22:58:11-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20150101 22:59:38-!- gfgtdf_ [~chatzilla@f050180041.adsl.alicedsl.de] has joined #wesnoth-dev
20150101 23:00:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150101 23:01:55-!- gfgtdf [~chatzilla@f054049080.adsl.alicedsl.de] has quit [Ping timeout: 265 seconds]
20150101 23:02:04-!- gfgtdf_ is now known as gfgtdf
20150101 23:02:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150101 23:03:31-!- iceiceice [~mint@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150101 23:05:14-!- cib0 [~cib@p5DD22B73.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
20150101 23:14:38-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150101 23:23:45-!- ancestral [~ancestral@174-20-188-51.mpls.qwest.net] has quit [Quit: End Transmission.]
20150101 23:28:26< iceiceice> gfgtdf: regarding 23131, maybe we should change the way that scoped wml vars work?
20150101 23:28:47< iceiceice> we could make it so that it works liek an adapter that sits between the true variable set and the caller
20150101 23:28:58< iceiceice> and gets discarded at the end of the context
20150101 23:29:15< iceiceice> then the true variable set can be const during this time
20150101 23:32:31-!- markus_ [~mjs-de@p508CAECB.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150101 23:35:49-!- mjs-de [~mjs-de@p508CBD80.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20150101 23:39:16-!- Nostromus [~chatzilla@f054013200.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141127110442]]
20150101 23:44:59-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150101 23:46:14-!- iceiceice [~mint@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150101 23:53:15-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20150101 23:54:37-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Quit: systemctl start real-life.service]
--- Log closed Fri Jan 02 00:00:12 2015