--- Log opened Mon Jan 05 00:00:42 2015
20150105 00:04:48-!- cib0 [~cib@p5DC74237.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20150105 00:10:14-!- cib0 [~cib@p5DC74237.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150105 00:44:31-!- cib0 [~cib@p5DC74237.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
20150105 00:54:00-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has quit [Read error: Connection reset by peer]
20150105 00:54:54-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has joined #wesnoth-dev
20150105 00:57:12-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150105 01:07:14-!- mjs-de [~mjs-de@g228136181.adsl.alicedsl.de] has quit [Remote host closed the connection]
20150105 01:51:36< vultraz> dammit, iceiceice is never around when I am
20150105 02:10:17-!- irker929 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150105 02:10:17< irker929> wesnoth: Charles Dang wesnoth:master 70e040791f8d / misc/fortunes/wesnoth: Added a fortune http://git.io/hGBxbw
20150105 02:25:44-!- aquileia [4e2b85d0@gateway/web/freenode/ip.78.43.133.208] has joined #wesnoth-dev
20150105 02:27:45< aquileia> Just wondering while I update the VC project file - why are the 8 new hotkey_handler files not categorized as src/hotkey/ ?
20150105 02:28:29-!- renketsu0 [45f63b55@gateway/web/freenode/ip.69.246.59.85] has quit [Quit: Page closed]
20150105 02:29:55< aquileia> iceiceice: ^ (Just in case you grep your name...)
20150105 02:32:34-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150105 02:32:36< vultraz> aquileia: I asked that too, he said that they're more related to play_controller
20150105 02:32:52< vultraz> dat timing
20150105 02:32:55< iceiceice> hehe
20150105 02:32:58< iceiceice> howdy
20150105 02:33:02< aquileia> thanks for the answer
20150105 02:33:15< aquileia> hi
20150105 02:34:18< iceiceice> yeah so, the way things work right now, "play_controller" is like the master object for a wesnoth game session,
20150105 02:34:32< iceiceice> it has clients "event_handler" and "mouse handler base" and now "hotkey_handler"
20150105 02:34:41< iceiceice> that do most event handling
20150105 02:34:52< iceiceice> hotkey_handler is actually an inner class of play_controller now
20150105 02:35:25< iceiceice> i guess it could be moved to hotkey folder but it makes it a little harder to find,
20150105 02:35:35< iceiceice> since i guess right now all the stuff in the hotkey folder is actually in the hotkey namespace
20150105 02:36:33< vultraz> iceiceice: regarding e1e5169c95b4f9d48bf471217cbd17dcc90c0331 , do you think we need to parse the id in lua?
20150105 02:36:40< vultraz> if we did, shouldn't we split it in lua too?
20150105 02:38:36< iceiceice> yeah i would support that i think
20150105 02:38:53< iceiceice> i don't think we "have to"
20150105 02:42:17< vultraz> iceiceice: regarding the other issues, A and B worked in 1.12, I know that
20150105 02:42:21< vultraz> I have a testcase in my addon
20150105 02:45:04-!- travis-ci [~travis-ci@ec2-54-237-80-221.compute-1.amazonaws.com] has joined #wesnoth-dev
20150105 02:45:04< travis-ci> wesnoth/wesnoth#5434 (master - 70e0407 : Charles Dang): The build was fixed.
20150105 02:45:04< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45902558
20150105 02:45:04-!- travis-ci [~travis-ci@ec2-54-237-80-221.compute-1.amazonaws.com] has left #wesnoth-dev []
20150105 02:45:58< iceiceice> ok if you can show the test case that is good, i guess most likely it broke when moving stuff to lua :/
20150105 02:46:26< iceiceice> i wonder what is going wrong...
20150105 02:46:45< vultraz> well it's simple. in 1.12, my addon adds the time area in a prestart event. in 1.13, same code. doesn't.
20150105 02:46:59< vultraz> in 1.12, shroud gets placed correctly, in 1.13, not
20150105 02:47:12< iceiceice> did you try the same wml in like a mainline mp map?
20150105 02:47:17< iceiceice> or something similarly simple?
20150105 02:48:47< vultraz> not yet
20150105 02:53:09< vultraz> iceiceice: this also happens http://pastebin.com/m5KbKyYc in master, not in 1.12 (in the latter the name is correctly as dalen_store[0] in inspect)
20150105 02:53:31< vultraz> some behavior must have changed..
20150105 03:01:17< iceiceice> does it happen just before this commit? https://github.com/wesnoth/wesnoth/commit/9eaba64651
20150105 03:02:36< vultraz> it happens on current master
20150105 03:04:01< vultraz> or are you asking if it still happens before that?
20150105 03:04:27-!- Ivanovic_ [~ivanovic@frnk-d9333e42.pool.mediaWays.net] has joined #wesnoth-dev
20150105 03:04:28-!- Ivanovic_ [~ivanovic@frnk-d9333e42.pool.mediaWays.net] has quit [Changing host]
20150105 03:04:28-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20150105 03:04:53< iceiceice> i mean does it happen at that 9eaba64651^
20150105 03:05:03< iceiceice> also, does this commit look broken to anyone else?
20150105 03:05:04< iceiceice> https://github.com/wesnoth/wesnoth/commit/9ad020eea6
20150105 03:05:24< iceiceice> i think that this line is binding a reference to a temporary effectively :/ https://github.com/wesnoth/wesnoth/commit/9ad020eea6#diff-232264d9b4bb8684b7c06df4293376d3R1388
20150105 03:08:31< vultraz> lemme compile before 9eaba64651 and test
20150105 03:08:32-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 250 seconds]
20150105 03:10:23-!- Ivanovic_ is now known as Ivanovic
20150105 03:10:47-!- Ardonik [~user@75.28.98.53] has joined #wesnoth-dev
20150105 03:11:31< iceiceice> i have never seen that syntax for converting const char * to std::string... i'm pretty sure its broken
20150105 03:11:47< iceiceice> i'm surprised its not a segfault actually, if someone can explain why not i would like to know...
20150105 03:11:48< vultraz> welp, apparently it doesn't compile on the commit immediately preceding...
20150105 03:12:11< iceiceice> if not then i guess it could be a memory leak?
20150105 03:12:16< iceiceice> vultraz: hmm...
20150105 03:12:45< vultraz> appears to be a boost thing...probably something with my libs o_O
20150105 03:12:58< iceiceice> whats the error?
20150105 03:13:11< iceiceice> im trying to compile there now
20150105 03:13:14< vultraz> C:\Users\Charles\Documents\wesnoth-git\projectfiles\CodeBlocks\cb\include_tdm_gcc\boost\asio\detail\impl\win_object_handle_service.ipp|106|error: '::UnregisterWaitEx' has not been declared|
20150105 03:13:39-!- Ard0nik [~user@75.28.98.237] has quit [Ping timeout: 244 seconds]
20150105 03:14:24< iceiceice> hmmmm
20150105 03:16:24-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 264 seconds]
20150105 03:18:48< iceiceice> i guess its legal i just forgot some C++ rules :/
20150105 03:19:24< iceiceice> vultraz: i guess maybe the project files just weren't up to date at that commit?
20150105 03:19:30< iceiceice> i would think your libraries should be ok no matter what
20150105 03:19:36< iceiceice> i dont think that commit was so long ago
20150105 03:19:53< iceiceice> like a month and a half
20150105 03:20:37< iceiceice> if not, if you know any commit before that commit that you can compile that's an acceptable substitute
20150105 03:24:24< vultraz> ok, im trying against b79df59e08b265f1ad675ef0260fbf86619b1657
20150105 03:32:30-!- PhaZ90771 [~PhaZ90771@c-24-13-158-17.hsd1.il.comcast.net] has joined #wesnoth-dev
20150105 03:33:00< vultraz> builds
20150105 03:33:29< vultraz> iceiceice: there error is not there
20150105 03:34:15< iceiceice> hmmmmmm
20150105 03:34:30< iceiceice> isn't b79df59e08b265f1ad675ef0260fbf86619b1657 after the commit i siad?
20150105 03:34:37< iceiceice> github says b79df59e08b265f1ad675ef0260fbf86619b1657 was 13 days ago
20150105 03:35:17< iceiceice> so that means it was introduced somewhere more recent i guess...?
20150105 03:35:25< iceiceice> i think i dont have a good candidate atm, let me look at logs
20150105 03:35:26< vultraz> uh...
20150105 03:35:41< vultraz> gui2/tgame_cache_options: Handle negative values from filesystem::dir_size() ?
20150105 03:36:05< iceiceice> yes
20150105 03:36:05< vultraz> Revision: b79df59e08b265f1ad675ef0260fbf86619b1657
20150105 03:36:07< vultraz> Author: Ignacio R. Morelle <shadowm@wesnoth.org>
20150105 03:36:09< vultraz> Date: 12/23/2014 7:53:58 PM
20150105 03:36:14< vultraz> oh
20150105 03:36:16< vultraz> derp
20150105 03:36:26< vultraz> 12 instead of 11
20150105 03:36:27< vultraz> well...
20150105 03:36:34< iceiceice> if theres no error at that commit then its a godo thing
20150105 03:36:45< vultraz> iceiceice: well ok, the var thing isn't there, AND [time_area] works in prestart here
20150105 03:36:49< iceiceice> it means there's only a small number of commits that could be involved
20150105 03:37:33< vultraz> let me test shroud
20150105 03:38:10< vultraz> no, it appears to not
20150105 03:38:58< vultraz> yeah, doesn't work even with the ilua error disabled
20150105 03:39:27< vultraz> iceiceice: ok, so var not broken, time_area not broken, shroud broken as of b79df59e08b265f1ad67
20150105 03:39:59< iceiceice> ok
20150105 03:40:37< vultraz> anything else I should test here or can I go back to HEAD?
20150105 03:41:54< iceiceice> i dont know anything else you should test there
20150105 03:42:04< iceiceice> i dont have a good theory what would cause this right now
20150105 03:42:16< iceiceice> i think it needs to be bisected
20150105 03:42:36< iceiceice> probably the best thing is if you post the test scenarios you are using
20150105 03:42:37< vultraz> im going to test against 1f124ff2ee5604f6d1e5c39a5f68591783bf3a68
20150105 03:42:54< vultraz> they're not test scenarios, they're fully written campaign scenarios
20150105 03:43:06< iceiceice> ok
20150105 03:44:20< vultraz> https://github.com/Vultraz/Shadows_of_Deception/blob/master/episode1/scenarios/00_Descry.cfg#L94 is my test for [place_shroud]
20150105 03:44:52< vultraz> https://github.com/Vultraz/Shadows_of_Deception/blob/master/episode1/scenarios/02_Dwarvish_Trail.cfg#L293 is my test for [time_area]
20150105 03:46:59-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150105 03:49:11< vultraz> iceiceice: [time_area] and the var thing are broken in 1f124ff2ee5604f6d1e5
20150105 03:49:50< vultraz> so they were broken somewhere between december 23rd and 30th
20150105 03:50:32< iceiceice> i guess you can test this commit: https://github.com/wesnoth/wesnoth/commit/fa32be5602ca5f00217e2408af09cbd51c0ffd66
20150105 03:50:58< iceiceice> and this commit: https://github.com/wesnoth/wesnoth/commit/0d76ac3be758c7206054fc0b49de3952b2dea799
20150105 03:51:16< iceiceice> i guess that's most likely candidates now, but if they are broken i would like to understand why
20150105 03:59:00< vultraz> testing against 09ce8b57740d649493bce2f1b4f6e4bcc9942f44 for time_area (immediately prior to the move)
20150105 04:05:29-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20150105 04:08:09< vultraz> iceiceice: 09ce8b57740d649493bc time_area and var works 
20150105 04:08:59< vultraz> testing fa32be5602ca5f00217e2408af09cbd51c0ffd66
20150105 04:20:51-!- ancestral [~ancestral@174-20-166-97.mpls.qwest.net] has joined #wesnoth-dev
20150105 04:42:42-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 265 seconds]
20150105 04:56:58-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150105 04:57:51-!- aquileia [4e2b85d0@gateway/web/freenode/ip.78.43.133.208] has quit [Quit: Page closed]
20150105 04:58:11-!- aquileia [4e2b85d0@gateway/web/freenode/ip.78.43.133.208] has joined #wesnoth-dev
20150105 05:03:56-!- ancestral [~ancestral@174-20-166-97.mpls.qwest.net] has quit [Quit: End Transmission.]
20150105 05:12:56-!- Sulfur [~Miranda@p5B009325.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150105 05:13:50< vultraz> iceiceice: sorry, I went afk
20150105 05:14:00< iceiceice> me too XD
20150105 05:14:13< vultraz> [time_area] was broken in fa32be5602ca5f00217e2408af09cbd51c0ffd66 with 20150105 15:31:19 error scripting/lua: ...sers/Charles/Documents/wesnoth-git\data\lua/wml-tags.lua:1346: attempt to call field 'add_time_area' (a nil value)
20150105 05:14:17-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20150105 05:14:29< vultraz> that doesn't appear in HEAD so I assume it was fixed
20150105 05:14:34< vultraz> (var still works there)
20150105 05:18:20< vultraz> custom menu items are also broken as of this commit, but don't throw the missing manager error
20150105 05:25:10-!- aquileia [4e2b85d0@gateway/web/freenode/ip.78.43.133.208] has quit [Ping timeout: 246 seconds]
20150105 05:32:31< iceiceice> vultraz: that "nil value" error happened because of a different bug, fixed here:
20150105 05:32:32< iceiceice> https://github.com/wesnoth/wesnoth/commit/9f67233f2220ac6ef0c4183d1484ac9cfb0f4109
20150105 05:32:47< iceiceice> you could try going to fa32be560 and cherrypicking this guy 
20150105 05:32:59< iceiceice> or just add the registration manually...
20150105 05:33:18< iceiceice> for the record, the main thing i learned from this is that it was too aggressive to move these functions over without adding unit tests first
20150105 05:34:14< iceiceice> it doesn't really matter that much to cherry-pick, if add_time_area was working just before fa32be5602, and its still broken then that's the bad commit
20150105 05:34:22-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150105 05:40:07-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.0.1]
20150105 05:43:53< vultraz> yeah, it seems we're discovering these issues too late
20150105 05:44:00< vultraz> unit tests would have done it earlier
20150105 05:44:02-!- irker929 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150105 05:44:14< vultraz> well, not too late, but later than we would have
20150105 05:45:41-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has left #wesnoth-dev ["Leaving"]
20150105 05:45:50-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has joined #wesnoth-dev
20150105 05:46:56< vultraz> also I can't find 0d76ac3be758c7206054fc0b49de3952b2dea799
20150105 05:47:42< iceiceice> is there a way in lua to test shroud righ tnow?
20150105 05:49:35< iceiceice> if there isn't i guess i could add one
20150105 05:49:39< vultraz> not that I know of
20150105 05:49:59< iceiceice> do you know if a vision event can be made to fire based on shroud data?
20150105 05:50:24< iceiceice> hmmm maybe this works: http://wiki.wesnoth.org/FilterWML#Filtering_Vision
20150105 05:56:11< vultraz> that should
20150105 05:58:34< iceiceice> hmm wierd question,
20150105 05:58:45< iceiceice> if i place shroud everywhere, but i have units on the board, what is supposed to happen?
20150105 05:58:55< iceiceice> there is supposed to be shroud over my own units?
20150105 06:03:15< vultraz> yes
20150105 06:03:26< vultraz> unless you redraw
20150105 06:05:10< iceiceice> hmmm
20150105 06:05:41< iceiceice> are filter vision checks always supposed to agree with the screen?
20150105 06:05:53< iceiceice> or can they be different
20150105 06:06:16-!- Sulfur [~Miranda@p5B009325.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150105 06:06:44< vultraz> they can be different depending on the side you're filtering on
20150105 06:06:59< vultraz> but i think they should always agree if you're viewing that side
20150105 06:07:04-!- aquileia [4e2b85d0@gateway/web/freenode/ip.78.43.133.208] has joined #wesnoth-dev
20150105 06:07:07< vultraz> like if side 1 has shroud and side 2 doesn't
20150105 06:07:25< vultraz> and you filter on side 2 it should return true, even if you're viewing side 1
20150105 06:07:57< aquileia> timotei_: Would you merge https://github.com/wesnoth/wesnoth/pull/358, please?
20150105 06:09:24-!- irker384 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150105 06:09:24< irker384> wesnoth: aquileia wesnoth:master a59440fe9ef7 / projectfiles/VC9/wesnoth.vcproj: Update wesnoth.vcproj http://git.io/GPrY3w
20150105 06:09:24< irker384> wesnoth: Ignacio R. Morelle wesnoth:master f61a0fa28e29 / projectfiles/VC9/wesnoth.vcproj: Merge pull request #358 from aquileia/VC_proj http://git.io/29yw-w
20150105 06:09:32< vultraz> ahaha
20150105 06:09:56< aquileia> thanks, shadowm
20150105 06:30:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150105 06:30:21< aquileia> gfgtdf: I've added boost locale to the external/VC12 branch because we now have that dependency, but I won't be able to do that for VC10...
20150105 06:30:37< aquileia> gfgtdf_: ^
20150105 07:07:25< aquileia> BTW, https://github.com/wesnoth/wesnoth/pull/259 should be ready to merge.
20150105 07:08:14-!- aquileia [4e2b85d0@gateway/web/freenode/ip.78.43.133.208] has quit [Quit: Page closed]
20150105 07:14:39< iceiceice> vultraz: i can't reproduce time_area prestart problems on master
20150105 07:15:16< iceiceice> i'm not sure about shroud, i'm coming back to that one because i realized time_area was easier
20150105 07:19:49< vultraz> huh...
20150105 07:20:04< vultraz> let me try something
20150105 07:21:15< vultraz> iceiceice: ah...I seem to have been misled by the variable error. 
20150105 07:21:37< vultraz> since my t_a test came after the code with the var problem, it simply didn't get applied at all
20150105 07:21:44< vultraz> I guess that's a different kind of issue
20150105 07:23:20< iceiceice> yeah so 
20150105 07:23:30< iceiceice> i guess lua is different from wml in how it handles errors
20150105 07:23:49< iceiceice> in wml if a tag doesn't work, it craps out an error message but the game tries to plow ahead anyways
20150105 07:23:57< iceiceice> in lua, its more like an exception
20150105 07:24:20< iceiceice> if you don't catch it with "pcall" then your script will stop executing
20150105 07:24:36< vultraz> well that isn't good
20150105 07:24:54< vultraz> it means one little error in the wml makes everything appear broken
20150105 07:24:54< iceiceice> i mean it depends on your point of view
20150105 07:25:11< iceiceice> sometimes things are easier to debug if they are fail fast
20150105 07:25:32< iceiceice> if the program takes great efforts to cover up the bug it may only hinder you
20150105 07:25:55< vultraz> well yes
20150105 07:26:04< vultraz> but it should just give the error and move on
20150105 07:26:08< shadowm> 04:23:49 <iceiceice> in wml if a tag doesn't work, it craps out an error message but the game tries to plow ahead anyways
20150105 07:26:14< shadowm> Huh? When does this happen?
20150105 07:26:20< iceiceice> most of the time
20150105 07:26:30< vultraz> ( also time_area in toplevel doesn't work with non-x,y= filters as the wiki says, apparently)
20150105 07:26:39< shadowm> When a WML tag (outside event actions) doesn't work, the game doesn't even give you an error message.
20150105 07:26:49< iceiceice> well it gives you some logging somewhere
20150105 07:26:57< shadowm> Within an event handler, execution of that handler stops immediately.
20150105 07:27:14< iceiceice> that's not always true,
20150105 07:27:26< iceiceice> i looked at many tags for instance the [time_area] one
20150105 07:27:35< iceiceice> if you specify a list with multiple ids,
20150105 07:27:50< vultraz> for the love of...
20150105 07:27:50< iceiceice> it says "trying to add a time area with multiple ids, ignoring all but the first"
20150105 07:28:01< iceiceice> but it continues from that point
20150105 07:28:07< shadowm> That means the tag works.
20150105 07:28:09< iceiceice> it doesn't say "error, messed up wml"
20150105 07:28:14< vultraz> ok this is another issue related to CARRYOVER >_>
20150105 07:28:54< iceiceice> i'm not trying to say it should be one way or the other
20150105 07:28:59< iceiceice> but i wouldn't characterize that behavior as "fail fast"
20150105 07:29:01< shadowm> I could write a Lua script that ignores bad input too, and in fact that's how many WML tags are implemented.
20150105 07:29:31< shadowm> *ignores/mishandles
20150105 07:29:56< iceiceice> yeah
20150105 07:30:11< iceiceice> i mean the lua way is better
20150105 07:30:15< vultraz> shadowm: can you see if you can reproduce this: latest master, load up SoD's intro, skip through it, and let S1 load. A. see if the shroud placement doesn't work, and cursor is drawn under the intro and B. whether the starting ToD is wrong and shroud appears in S1
20150105 07:30:16< iceiceice> in that you can explicitly handle errors
20150105 07:30:29< iceiceice> in wml there's no way to know really if a tag produced an error
20150105 07:30:38< iceiceice> afaict
20150105 07:30:43< shadowm> There are ways.
20150105 07:30:50< iceiceice> maybe you can do something like set variables at the end of all events?
20150105 07:30:54< shadowm> They are just context-dependent and not always ideal.
20150105 07:30:57< iceiceice> so you know if you executed the whole handler?
20150105 07:31:28< iceiceice> ok
20150105 07:31:40< shadowm> If an EH fails, Wesnoth is particularly noisy about it, so...
20150105 07:32:15< shadowm> And if that happens, you can safely assume it's all gone wrong and it's not worth trying to recover from that.
20150105 07:32:25< iceiceice> there are definitely some things wesnoth is quiet about
20150105 07:34:23< irker384> wesnoth: Chris Beck wesnoth:master 18b5059b2338 / data/test/scenarios/test_grunt_tod_damage.cfg wml_test_schedule: add some [time_area] unit tests http://git.io/8h67CA
20150105 07:34:31< iceiceice> vultraz: ^
20150105 07:42:47-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20150105 07:44:56-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150105 07:56:37-!- fkhodkov [~user@vy2-187.istra.ru] has joined #wesnoth-dev
20150105 08:25:39-!- Coffee_irc [~david@ppp118-210-1-164.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20150105 08:38:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150105 08:41:57-!- Jetrel_ [~Jetrel@c-73-164-34-22.hsd1.mn.comcast.net] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20150105 08:42:12-!- Jetrel [~Jetrel@c-73-164-34-22.hsd1.mn.comcast.net] has joined #wesnoth-dev
20150105 09:05:41-!- fkhodkov [~user@vy2-187.istra.ru] has quit [Remote host closed the connection]
20150105 09:15:02< vultraz> iceiceice: er, what was the last commit I tested for the var issue?
20150105 09:15:35-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150105 09:24:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20150105 09:25:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20150105 09:36:54-!- PhaZ90771 [~PhaZ90771@c-24-13-158-17.hsd1.il.comcast.net] has quit [Ping timeout: 245 seconds]
20150105 09:41:42-!- PhaZ90771 [~PhaZ90771@c-24-13-158-17.hsd1.il.comcast.net] has joined #wesnoth-dev
20150105 09:42:50< irker384> wesnoth: Charles Dang wesnoth:master 3b43c7dcf11c / data/test/ (15 files in 2 dirs): Ran wmlindnet on unit tests. Some formatting had to be manually corrected http://git.io/cpHk_Q
20150105 09:44:08< vultraz> iceiceice: ^
20150105 09:48:19-!- mjs-de [~mjs-de@f049008092.adsl.alicedsl.de] has joined #wesnoth-dev
20150105 09:57:23-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds]
20150105 09:57:24< irker384> wesnoth: Charles Dang wesnoth:master 46fc0d4d93ce / data/test/scenarios/characterize_pathfinding.cfg: Fixup HEAD, small formatting bit I missed http://git.io/bbJpyw
20150105 10:08:57-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20150105 10:11:49-!- boucman_work [~jrosen@193.56.60.161] has joined #wesnoth-dev
20150105 10:11:49-!- boucman_work [~jrosen@193.56.60.161] has quit [Changing host]
20150105 10:11:49-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150105 10:19:23-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 244 seconds]
20150105 10:22:22-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150105 10:27:28-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 245 seconds]
20150105 10:33:51-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150105 10:41:12-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20150105 10:41:14-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Changing host]
20150105 10:41:14-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150105 10:41:14-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 245 seconds]
20150105 10:43:34-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150105 10:49:24-!- cib0 [~cib@p5DD218B7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150105 10:52:02-!- gfgtdf [~chatzilla@e176191067.adsl.alicedsl.de] has joined #wesnoth-dev
20150105 10:52:45< gfgtdf> vultraz: irecentlychangedwesnoth.set_variabletothow an error on an invalid argument
20150105 10:52:53< gfgtdf> i recently  changeed*
20150105 10:53:28< gfgtdf> vultraz: i think it's clear why dalen_side[0][0] is not a valid name for a variable.
20150105 10:59:46-!- Coffee_irc [~david@ppp118-210-1-164.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20150105 11:04:17-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20150105 11:09:02< vultraz> gfgtdf: yes, but the point is in 1.12, the particular code yielded [0] and not [0][0]
20150105 11:10:10-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150105 11:10:57-!- gfgtdf [~chatzilla@e176191067.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20150105 11:12:41-!- gfgtdf [~chatzilla@e176191067.adsl.alicedsl.de] has joined #wesnoth-dev
20150105 11:15:02-!- Kexoth [~kex@78.157.29.160] has joined #wesnoth-dev
20150105 11:26:33-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 244 seconds]
20150105 11:36:33-!- TC01_ [~quassel@magellan.acm.jhu.edu] has joined #wesnoth-dev
20150105 11:36:37-!- Netsplit *.net <-> *.split quits: gfgtdf
20150105 11:36:46-!- Netsplit *.net <-> *.split quits: TC01
20150105 11:41:51-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20150105 11:41:51-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Changing host]
20150105 11:41:51-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150105 11:51:31-!- Netsplit over, joins: gfgtdf
20150105 11:54:58< gfgtdf> vultraz: well we-tags.lua uses string.format("%s[%u]", variable, index)
20150105 11:55:18< vultraz> as in 1.12
20150105 11:55:26< gfgtdf> vultraz: so if variable is dalen_side[0]
20150105 11:55:39< gfgtdf> vultraz: another [0] willbe added
20150105 11:56:00< vultraz> the variable is 'dalen_side'
20150105 11:56:04< vultraz> no [0]
20150105 11:56:17< vultraz> also, you should be able to specify the index when setting variables
20150105 11:59:29< gfgtdf> vultraz: well yes that could be implemented, butit seems like that wasn'T implemented yet because noone needed it yet.
20150105 11:59:47< vultraz> you always have been able to specify index, I think?
20150105 12:01:08< gfgtdf> vultraz: accoing to that code i'd think no. Or maybe we allow vaiaablename like some_name[0][0] in 1.12?
20150105 12:03:03< gfgtdf> vultraz: i  refactored the variablecode in master with the assumption that such names aren't alowed. Allowing such variablenames wouldn't be hard, we could make some_name[a][b] make an alias for some_name[a+b] for example.
20150105 12:10:31-!- aquileia [4e2b85d0@gateway/web/freenode/ip.78.43.133.208] has joined #wesnoth-dev
20150105 12:11:57< aquileia> gfgtdf: Just so you know, the VC10 package in the external repo currently misses two files for boost locale which you probably have locally...
20150105 12:12:25< gfgtdf> yes i can upload that
20150105 12:13:19< vultraz> gfgtdf: I'm trying to find the commit that changed this
20150105 12:13:36< gfgtdf> vultraz: tha changed what?
20150105 12:13:44< vultraz> that caused this problem
20150105 12:15:10< aquileia> libboost_locale-vc100-mt-gd-1_51.lib and libboost_locale-vc100-mt-1_51.lib
20150105 12:15:15< gfgtdf> vultraz: well the commit thatt givesalua erro is this: https://github.com/wesnoth/wesnoth/commit/7f0e7c890d5d4dad3fecd6d180c0acfc2b705eb6 but that doesnt  caused the problem
20150105 12:17:31< vultraz> I've narrowed it to between 75767d3a77555c9d7b8bac5b63ff832708dcad67 and 978ae9ebc39e9e89efe703beb9b0de7623b4cdbe I think
20150105 12:20:05< gfgtdf> vultraz: so https://github.com/wesnoth/wesnoth/commit/75767d3a77555c9d7b8bworks ?
20150105 12:30:22-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Ping timeout: 240 seconds]
20150105 12:35:52-!- PhaZ90771 [~PhaZ90771@c-24-13-158-17.hsd1.il.comcast.net] has quit [Ping timeout: 240 seconds]
20150105 12:36:10-!- PhaZ90771 [~PhaZ90771@c-24-13-158-17.hsd1.il.comcast.net] has joined #wesnoth-dev
20150105 12:38:09-!- Coffee_irc [~david@ppp118-210-1-164.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20150105 12:41:00< vultraz> gfgtdf: I have not noticed any problems with [kill]
20150105 12:49:38< gfgtdf> vultraz: why shouldthe probembe relatedto kill ?
20150105 12:49:43< vultraz> gfgtdf: so it appears 7f0e7c890d5d4dad3fecd6d180c0acfc2b705eb6 is the problem
20150105 12:50:08< gfgtdf> vultraz: no it'snot teh problem
20150105 12:50:20< vultraz> well it's the first commit the error starts appearing
20150105 12:50:36< vultraz> So the brings up the question as to how the game was handling variables
20150105 12:50:41< gfgtdf> vultraz: well yes,but just becasue teh errordidnt ppear sonner it doesnt means the teh codeworked before
20150105 12:50:52< vultraz> the code worked
20150105 12:50:57< vultraz> because the variable was being stored!
20150105 12:51:37< vultraz> the stack of this error even points me back to wesnoth.set_variable(string.format("%s[%u]", variable, index), container), which specifies an index
20150105 12:51:45< vultraz> (in wml_actions.store_side)
20150105 12:52:37< gfgtdf> vultraz: maybe thee was anothe store_side after that, that then stored the side inyour code?
20150105 12:52:57< gfgtdf> vultraz: howdid you testthat theside was stoed ?
20150105 12:53:29-!- cib0 [~cib@p5DD218B7.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20150105 12:55:31< vultraz> what?
20150105 12:55:55< vultraz> well, I am using a custom lua tag
20150105 12:56:01< vultraz> let me try a bare [store_side]
20150105 13:02:47-!- gfgtdf [~chatzilla@e176191067.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0.5/20141126041045]]
20150105 13:08:51-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150105 13:16:36-!- irker384 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150105 13:19:17-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20150105 13:21:46-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 244 seconds]
20150105 13:35:16-!- cib0 [~cib@p5DD218B7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150105 13:36:33-!- PhaZ90771 [~PhaZ90771@c-24-13-158-17.hsd1.il.comcast.net] has quit [Ping timeout: 244 seconds]
20150105 13:48:05-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20150105 13:54:04-!- aquileia [4e2b85d0@gateway/web/freenode/ip.78.43.133.208] has quit [Ping timeout: 246 seconds]
20150105 14:33:04-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Ping timeout: 244 seconds]
20150105 14:37:41-!- cib0 [~cib@p5DD218B7.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20150105 14:40:14-!- Coffee_irc [~david@ppp118-210-1-164.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20150105 14:47:41-!- Kexoth [~kex@78.157.29.160] has quit [Remote host closed the connection]
20150105 14:58:36-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20150105 14:59:49-!- gfgtdf [~chatzilla@e176191067.adsl.alicedsl.de] has joined #wesnoth-dev
20150105 15:01:29-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 245 seconds]
20150105 15:07:05-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150105 15:15:21-!- Ardonik [~user@75.28.98.53] has quit [Read error: Connection reset by peer]
20150105 15:15:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 265 seconds]
20150105 15:16:20-!- Ardonik [~user@adsl-75-28-97-128.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20150105 15:28:56-!- Crendgrim_ is now known as Crendgrim
20150105 15:29:47-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20150105 15:35:47< gfgtdf> vultraz: did  you already found out what the error was?
20150105 15:36:09-!- gfgtdf_ [~chatzilla@e176191067.adsl.alicedsl.de] has joined #wesnoth-dev
20150105 15:36:31< vultraz> gfgtdf: it appeared to be the byproduct of both [store_side] and the custom tag I was using creating an index
20150105 15:36:55< vultraz> so, [0][0]
20150105 15:37:05< vultraz> but prior to your commit, this just got converted to [0]
20150105 15:37:19< vultraz> or perhaps, one became a reference to the [0] index
20150105 15:38:04-!- horrowin1 [~Icedove@x04l2a.wh2.tu-dresden.de] has joined #wesnoth-dev
20150105 15:39:14< gfgtdf_> vultraz: hmm ok but then it not prior to the commit you posted earlier but rather propor to a sooner commit during 1.13+dev.
20150105 15:39:37< vultraz> it was prior, because prior it was working correctly
20150105 15:39:53< vultraz> I have not tested if this affects all index var assignments or not
20150105 15:40:15-!- gfgtdf [~chatzilla@e176191067.adsl.alicedsl.de] has quit [Ping timeout: 264 seconds]
20150105 15:40:17-!- gfgtdf_ is now known as gfgtdf
20150105 15:43:14< gfgtdf> vultraz: i'd still say that using variable names liek somename[0][0] was an undefined or at least undocumented behaviour. And i tink it better t fic store_side no not rely on this hebavious than to allow it.
20150105 15:43:21< gfgtdf> to fix*
20150105 15:43:29< gfgtdf> behaviour*
20150105 15:44:02< vultraz> this is the code, btw
20150105 15:44:04< vultraz> http://pastebin.com/uskTK6Hr
20150105 15:45:43< gfgtdf> vultraz: well yes the string.format is done twice, once by your helper function and once by store_side
20150105 15:46:54< vultraz> yes, but look
20150105 15:46:56< vultraz> 	wesnoth.set_variable(variable, {})
20150105 15:47:06< vultraz> creates an empty array
20150105 15:47:12< gfgtdf> vultraz: yes
20150105 15:47:27< vultraz> local side_store = string.format("%s[%u]", variable, array_index) wesnoth.set_variable(side_store, {}) 
20150105 15:47:38< vultraz> so you have the variable inserted into the array starting at 0
20150105 15:48:53< gfgtdf> vultraz: i'd think wesnoth.set_variable(variable, {}) created aan empty array even on current master.
20150105 15:49:06< vultraz> yes
20150105 15:49:09< gfgtdf> vultraz: it just will stay empty becasue store_side fails
20150105 15:49:32< vultraz> hm...
20150105 15:49:41< vultraz> maybe I can try w/o creating the empty array?
20150105 15:50:16< gfgtdf> vultraz: no that won'T help, store_side on current master simply cannot handle explicit indexes for variable.
20150105 15:51:14< gfgtdf> vultraz: i actually also dont know what it supposed to happen in store_side if multiple sides match the filter if an eplicit index as specified ?
20150105 15:52:22< vultraz> hm
20150105 15:52:27< vultraz> should that be fixed?
20150105 15:54:18< gfgtdf> vultraz: hmm yes we shoudl fix store_side to allow an explicit index, But i corrently wonder whether we should give an error, or just ignore it if somone used side_wml to store multiple sides in an explicit index.
20150105 15:54:25< gfgtdf> currently*
20150105 15:54:41< gfgtdf> s/side_wml/store_side
20150105 16:00:31< vultraz> well ignoring it worked, but...
20150105 16:00:33< vultraz> i dunno
20150105 16:11:28-!- irker746 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150105 16:11:28< irker746> wesnoth: gfgtdf wesnoth:master 201d83f608d0 / data/lua/wml-tags.lua: fix [store_side] to allow explicit indexes http://git.io/DjLe2w
20150105 16:11:50< gfgtdf> vultraz: ^
20150105 16:12:07-!- Nostromus [~chatzilla@g224151060.adsl.alicedsl.de] has joined #wesnoth-dev
20150105 16:13:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150105 16:16:10-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20150105 16:18:01< vultraz> where do you get str?
20150105 16:18:22< vultraz> (it also triggers our new 20150106 03:16:57 error scripting/lua: ...sers/Charles/Documents/wesnoth-git\data\lua/wml-tags.lua:1075: variable 'str' must be assigned before being used )
20150105 16:19:57< Nostromus> FYI: Made a pr for bug #18926. Ready for review. 
20150105 16:20:41< Nostromus> i meant the bug on gna not bugzilla.... ;)
20150105 16:28:39< gfgtdf> vultraz: ahn copypaste erro, ofc i meant variable
20150105 16:29:49< irker746> wesnoth: gfgtdf wesnoth:master 486fc8ed7189 / data/lua/wml-tags.lua: fixup HEAD http://git.io/rCpDUg
20150105 16:31:27< vultraz> gfgtdf: works now
20150105 16:39:30-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150105 17:01:15< iceiceice> vultraz: which of A, B, C are still bugs on master?
20150105 17:05:34< gfgtdf> iceiceice: in https://travis-ci.org/wesnoth/wesnoth/builds/45963694 all tests fail with a timout error.
20150105 17:06:06< gfgtdf> iceiceice: i think it is actualyl no timout, but rather a the error which i accidently introduced in 201d83f608d0 
20150105 17:06:31< gfgtdf> iceiceice: could it be that some lua error get wrongly converted to timout ?
20150105 17:06:43< iceiceice> yeah i think a lua error could easily become timeout
20150105 17:06:55< iceiceice> because, it will cancel the event handler i guess
20150105 17:07:03< iceiceice> and so whatever assertion is checked won't run
20150105 17:07:58< gfgtdf> iceiceice: do you think its possible/easy to give a correct error message in this case ?
20150105 17:08:40< iceiceice> i dont know
20150105 17:08:50< gfgtdf> iceiceice: hm ok
20150105 17:09:16< iceiceice> if you see an easy way to improve it that would be good
20150105 17:15:29< gfgtdf> iceiceice: i thought te test automaticly fails once something gets written to our err log?
20150105 17:20:18< Nostromus> gfgtdf: i made a forcepush so a new travis build is in progress
20150105 17:21:30< Nostromus> the pr are not responsible for the fails, if it fails again something with master is still not right
20150105 17:22:19-!- Jetrel [~Jetrel@c-73-164-34-22.hsd1.mn.comcast.net] has quit [Ping timeout: 245 seconds]
20150105 17:30:08< lipkab> gfgtdf: Do you still need that "Movement Test" campaign?
20150105 17:30:16< iceiceice> gfgtdf: the test fails once it ends if something gets written to err log
20150105 17:30:33< iceiceice> i didn't make it like, writing to log throws an endlevel exception or something
20150105 17:30:45< lipkab> If not, please remove it. The addons server is littered enough anyways.
20150105 17:30:59< iceiceice> gfgtdf: i already installed the movement test addon
20150105 17:31:41< gfgtdf> lipkab: well the addin is to reproduce a movement bug, afaik the bug still exists.
20150105 17:32:08-!- travis-ci [~travis-ci@ec2-54-160-204-185.compute-1.amazonaws.com] has joined #wesnoth-dev
20150105 17:32:08< travis-ci> wesnoth/wesnoth#5442 (master - 201d83f : gfgtdf): The build was broken.
20150105 17:32:08< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/45963786
20150105 17:32:08-!- travis-ci [~travis-ci@ec2-54-160-204-185.compute-1.amazonaws.com] has left #wesnoth-dev []
20150105 17:32:33< gfgtdf> lipkab: well i could remove it
20150105 17:32:47< lipkab> gfgtdf: It would be nice.
20150105 17:32:58< gfgtdf> ar there plans to remove the "1.11" asson server?
20150105 17:33:31< lipkab> I don't know.
20150105 17:33:37< lipkab> shadowm: ^?
20150105 17:38:20< iceiceice> gfgtdf: i wanted for the unit tests to have control flow that's as similar as possible to a normal game,
20150105 17:38:30< iceiceice> right now the logic to handle the results is in game_launcher.cpp
20150105 17:39:00< iceiceice> i guess one thing that could be considered is to try to move the "results" logic to a std::terminate handler
20150105 17:39:09< iceiceice> http://www.cplusplus.com/reference/exception/set_terminate/
20150105 17:39:32< iceiceice> then if something is written to err log it can just call std::terminate i guess
20150105 17:39:44< iceiceice> and if an uncaught exception kills the program, it will still get "handled"
20150105 17:45:07< gfgtdf> ok after 3 minutes of testing i rememberd that my testing scenario cannot work becasue set wml menu doesnt work....
20150105 17:45:27-!- TC01_ is now known as TC01
20150105 17:45:50-!- TC01 is now known as TC01_
20150105 17:48:41-!- TC01_ [~quassel@magellan.acm.jhu.edu] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
20150105 17:48:57-!- TC01 [~quassel@magellan.acm.jhu.edu] has joined #wesnoth-dev
20150105 17:48:57< iceiceice> gfgtdf: i think i'm going to test #355 a bit more and just merge it,
20150105 17:49:29-!- horrowin1 [~Icedove@x04l2a.wh2.tu-dresden.de] has quit [Quit: horrowin1]
20150105 17:49:30< iceiceice> i think i want to add a hotkey simulator like "[do_hotkey]" or something
20150105 17:49:55< iceiceice> or maybe only to lua
20150105 17:51:39< gfgtdf> iceiceice: i still think moving wmi_container from game_data to game event manager seems to be the simple solution if they are really connected.
20150105 17:52:18< iceiceice> yeah maybe
20150105 17:52:23< iceiceice> did you say that before?
20150105 17:52:31< iceiceice> i don't remember this idea
20150105 17:57:03< gfgtdf> iceiceice: what i said was 20141228 23:38:29< gfgtdf> iceiceice: is there a reaso why wml_menu_items_ in part of game_data ?
20150105 17:57:30< iceiceice> y i remember that
20150105 18:14:14-!- Sirp [~Sirp@u17402953.onlinehome-server.com] has quit [Ping timeout: 265 seconds]
20150105 18:14:14-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-ilulotscuksemuzy] has quit [Ping timeout: 265 seconds]
20150105 18:15:40-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Ping timeout: 265 seconds]
20150105 18:15:55< irker746> wesnoth: Chris Beck wesnoth:master eaa078a86db0 / src/ (7 files in 2 dirs): initialize wml menu item handlers when they are set, not in ctor http://git.io/KCLRmw
20150105 18:15:57< irker746> wesnoth: Chris Beck wesnoth:master 567f135f1ee8 / src/ (7 files in 2 dirs): Merge branch 'maybe_fix_23115' http://git.io/_5gppQ
20150105 18:17:24-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20150105 18:18:55-!- Sirp [~Sirp@u17402953.onlinehome-server.com] has joined #wesnoth-dev
20150105 18:19:39< gfgtdf> iceiceice: what exactly does me_ do ?
20150105 18:19:57< iceiceice> its a shared pointer to this
20150105 18:20:05< iceiceice> it allows the menu items to hold weak pointers to their owner
20150105 18:20:53< gfgtdf> iceiceice: so the min reason is that they know when their owner is deleted ?
20150105 18:20:57< iceiceice> yeah
20150105 18:21:17< iceiceice> i'm not saying this is "pretty" its just the least impact change that keeps it working i think
20150105 18:21:45-!- mjs-de [~mjs-de@f049008092.adsl.alicedsl.de] has quit [Remote host closed the connection]
20150105 18:23:54-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150105 18:24:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20150105 18:25:53-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-xspxwxdbnzlsikbm] has joined #wesnoth-dev
20150105 18:26:17-!- matthiaskrgr is now known as Guest53966
20150105 18:26:30-!- Guest53966 [matthiaskr@gateway/shell/panicbnc/x-xspxwxdbnzlsikbm] has quit [Changing host]
20150105 18:26:30-!- Guest53966 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20150105 18:26:30-!- Guest53966 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20150105 18:26:30-!- Guest53966 [matthiaskr@gateway/shell/panicbnc/x-xspxwxdbnzlsikbm] has joined #wesnoth-dev
20150105 18:27:45-!- Guest53966 is now known as matthiaskrgr__
20150105 18:27:46-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20150105 18:29:47-!- DCW1 [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev
20150105 18:38:32-!- DCW1 [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Quit: DCW1]
20150105 18:51:09-!- kex [~kex@78.157.29.160] has quit [Remote host closed the connection]
20150105 18:56:11-!- stikonas_ is now known as stikonas
20150105 18:59:35-!- cib0 [~cib@p5DD218B7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150105 19:11:09-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20150105 19:20:00< shadowm> gfgtdf: Yes.
20150105 19:24:52-!- matthiaskrgr__ is now known as matthiaskrgr
20150105 19:25:39-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 245 seconds]
20150105 19:31:12-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150105 19:32:42-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20150105 19:46:40-!- Sulfur [~Miranda@p5B009325.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150105 20:00:40< irker746> wesnoth: Chris Beck wesnoth:master 748f87209188 / data/lua/ilua.lua: lua: make it easier to disable strict mode global variables http://git.io/zZ67EA
20150105 20:00:43< iceiceice> vultraz: ^
20150105 20:01:14-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has quit [Remote host closed the connection]
20150105 20:04:39-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150105 20:06:52-!- cib0 [~cib@p5DD218B7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150105 20:08:19-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150105 20:13:30-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has joined #wesnoth-dev
20150105 20:30:23-!- gfgtdf [~chatzilla@e176191067.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]]
20150105 20:56:57-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 244 seconds]
20150105 21:17:41-!- Ard0nik [~user@adsl-75-28-101-105.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20150105 21:20:52-!- Ardonik [~user@adsl-75-28-97-128.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20150105 21:30:03-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Ping timeout: 264 seconds]
20150105 21:33:11< mattsc> Hey All: in the unlikely case that anybody cares, I will not be around here much in the foreseeable future.
20150105 21:33:36< mattsc> I thought real life would ease up a bit over the break and after, but it’s rather the opposite.  :P
20150105 21:35:58< mattsc> I’m not going on Wesbreak and will be around from time to time, just not as regularly as I’d like. I’ll also check the logs for my nick and forum PMs.
20150105 21:48:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150105 21:52:00-!- cib0 [~cib@p5DD218B7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150105 22:12:17-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150105 22:17:34-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20150105 22:19:20-!- Sulfur [~Miranda@p5B009325.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150105 22:32:51-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 244 seconds]
20150105 22:34:06-!- fabi [~quassel@p20030051AA4C4679F08FF480241502D5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150105 22:34:28-!- fabi [~quassel@p20030051AA4C4679F08FF480241502D5.dip0.t-ipconnect.de] has quit [Changing host]
20150105 22:34:28-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150105 22:34:56-!- yarker [~bismilah@li629-190.members.linode.com] has quit [Max SendQ exceeded]
20150105 22:37:11-!- yarker [~bismilah@li629-190.members.linode.com] has joined #wesnoth-dev
20150105 22:42:34-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Hibernating of sorts; will check logs and forum PMs]
20150105 22:51:43-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev
20150105 22:56:29-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 245 seconds]
20150105 23:00:58-!- mjs-de [~mjs-de@f049008092.adsl.alicedsl.de] has joined #wesnoth-dev
20150105 23:01:00-!- irker746 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150105 23:11:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150105 23:14:37-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Quit: Sűrű sötét az éj, dühöng a déli szél]
20150105 23:40:12-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150105 23:52:15-!- cib_ [~cib@p5DD218B7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150105 23:52:15-!- cib0 [~cib@p5DD218B7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
--- Log closed Tue Jan 06 00:00:52 2015