--- Log opened Tue Jan 06 00:00:52 2015
20150106 00:18:54-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has quit [Remote host closed the connection]
20150106 00:21:35-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has joined #wesnoth-dev
20150106 00:42:46-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20150106 00:51:00-!- PhaZ90771 [~PhaZ90771@c-24-13-158-17.hsd1.il.comcast.net] has joined #wesnoth-dev
20150106 00:53:49-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20150106 00:53:49-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20150106 00:53:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150106 01:03:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20150106 01:06:13-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150106 01:06:21-!- Nostromus [~chatzilla@g224151060.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141127110442]]
20150106 01:12:03-!- Jetrel [~Jetrel@c-73-164-34-22.hsd1.mn.comcast.net] has joined #wesnoth-dev
20150106 01:15:24-!- cib_ [~cib@p5DD218B7.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20150106 01:36:05-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150106 01:36:47< iceiceice> gfgtdf: i tried to make a lua function that invokes wml menu items, and a unit test that it is working,
20150106 01:36:55< iceiceice> i get an assertion failure related to synced context state though
20150106 01:36:57< iceiceice> wesnoth: src/synced_context.cpp:351: void set_scontext_synced::init(): Assertion `synced_context::get_synced_state() == synced_context::UNSYNCED' failed.
20150106 01:37:26< iceiceice> do you know what i did wrong?
20150106 01:37:26< iceiceice> https://github.com/wesnoth/wesnoth/pull/360/files
20150106 01:38:02< iceiceice> i get assertion failure for the first test
20150106 01:39:06< iceiceice> i think that "start" should be a synced event, am I wrong about this?
20150106 01:45:13< iceiceice> here's full backtrace:
20150106 01:45:13< iceiceice> http://hastebin.com/boyoditedu.vbs
20150106 01:45:41< iceiceice> gfgtdf: i guess that wml menu items are not fired via "run in synced context if not already?"
20150106 01:46:19< iceiceice> do i have to use synchronize choice for this or smth?
20150106 02:07:11< vultraz> iceiceice: B and part of C I think
20150106 02:07:21< vultraz> (if B is remove shroud)
20150106 02:10:50-!- travis-ci [~travis-ci@ec2-54-163-110-171.compute-1.amazonaws.com] has joined #wesnoth-dev
20150106 02:10:50< travis-ci> cbeck88/wesnoth#119 (menu_item_tests - 1b7fde0 : Chris Beck): The build failed.
20150106 02:10:50< travis-ci> Build details : http://travis-ci.org/cbeck88/wesnoth/builds/46021959
20150106 02:10:50-!- travis-ci [~travis-ci@ec2-54-163-110-171.compute-1.amazonaws.com] has left #wesnoth-dev []
20150106 02:11:56< vultraz> iceiceice: C being the issue with errors and the lua environment 
20150106 02:12:11< vultraz> and them causing stuff to fail, and some times the right errors not show up
20150106 02:12:41< iceiceice> gfgtdf: i tried a version putting the function i wrote in synchronize choice, it didn't seem to fix it: http://hastebin.com/xiyavomome.apache
20150106 02:12:42< vultraz> iceiceice: also re 748f87209188 , does that mean addon authors can switch this off on a case basis?
20150106 02:13:02< iceiceice> i also tried a version based on using "set_scontext_local_choice" and it didn't seem to help
20150106 02:13:19< iceiceice> if you could give a hint i would appreciate, i will come back to this later i think
20150106 02:15:25< iceiceice> vultraz: i dont remember what the issues correspond to exactly anymore,
20150106 02:15:43< iceiceice> i tried to make a very simple unit test for shroud, this is what i got: http://hastebin.com/izehuzalik.vhdl
20150106 02:15:57< iceiceice> i'm not sure if place shroud everywhere is working,
20150106 02:16:10< iceiceice> when i run "./wesnoth -u shroud_2 --showgui",
20150106 02:16:18< iceiceice> the test fails (i am defeated) and there is no shroud afaict
20150106 02:16:24< vultraz> correct
20150106 02:16:27< iceiceice> maybe shroud is removed in linger mode
20150106 02:17:05< vultraz> yes, but it's not working in my case
20150106 02:18:28< iceiceice> vultraz: i think its more productive to test small test cases so as not to get confused
20150106 02:18:43< iceiceice> the thing is i'm not sure exactly what is supposed to happen,
20150106 02:19:05< vultraz> https://github.com/Vultraz/Shadows_of_Deception/blob/master/episode1/scenarios/00_Descry.cfg#L94 link again to what I'm testing
20150106 02:19:29< vultraz> since start events redraw shroud, I have that, and on 1.12, shroud is placed everywhere as expected
20150106 02:20:03< iceiceice> yeah for me right now on 1.13, [place_shroud] side=1 {EVERYWHERE} [/place_shroud] followed by redraw does not make any shroud on the screen
20150106 02:20:12< iceiceice> but i don't know if its a visual bug or if theres also no shroud in the engine
20150106 02:20:29< iceiceice> i think its the latter but i'm not sure
20150106 02:20:35< vultraz> there is also a VERY weird related bug that I find hard to describe
20150106 02:23:16< iceiceice> vultraz: afaict C is not actually a bug, its just the way that lua is designed
20150106 02:23:23< vultraz> yeah...
20150106 02:25:25< vultraz> iceiceice: so about this related shroud bug, right now I only have a case in my addon....
20150106 02:26:17< vultraz> basically, if you clone https://github.com/Vultraz/Shadows_of_Deception/ as an addon for master, launch the campaign, go through the cutscene intro scenario, and after it goes over to scenario 1, the ToD will be wrong and shroud will be toggled as yes
20150106 02:26:40< vultraz> even though in my scenario file, the starting tod is completely differernt and there's no shroud set
20150106 02:26:56< vultraz> even WEIRDER is the fact that if I exit and reload the start of scenario save, ToD and shroud will be correct
20150106 02:27:12< iceiceice> vultraz: i think the easiest way to figure out what changed in master is to just bisect this scenario:
20150106 02:27:12< iceiceice> http://hastebin.com/vorudatice.apache
20150106 02:27:20< iceiceice> and see at what point there stops being shroud when you laod it
20150106 02:28:07< iceiceice> vultraz: it might be a problem with the "context_mutated" stuff or something
20150106 02:28:14< iceiceice> maybe its losing track of when the graphics should be updated
20150106 02:33:55-!- un214 [~un214@2602:306:cccf:a879:56a0:50ff:fe57:101d] has joined #wesnoth-dev
20150106 02:34:46< iceiceice> vultraz: i tested the shroud thing at a commit from June 2014
20150106 02:34:47< iceiceice> https://github.com/wesnoth/wesnoth/commit/6c12233d3cdfb4ce9d4bebec13797902804ca4e9
20150106 02:34:51< iceiceice> it is still "broken" there
20150106 02:35:13< vultraz> huh
20150106 02:35:18< iceiceice> idk 
20150106 02:35:23< vultraz> yeah idk...
20150106 02:35:26< vultraz> :(
20150106 02:35:27< iceiceice> i guess i can go to the commit where i added the unit test system
20150106 02:35:34< iceiceice> at some point i guess i should just modify den of onis or seomthing
20150106 02:35:36< iceiceice> and try to boot this
20150106 02:36:57-!- un214 [~un214@2602:306:cccf:a879:56a0:50ff:fe57:101d] has quit [Remote host closed the connection]
20150106 02:39:06< iceiceice> i'm trying this commit now
20150106 02:39:11< iceiceice> this should lead to 1.12 branch i guess? https://github.com/wesnoth/wesnoth/commit/0ed8c1a83717b04ac1dae9eab967462405b356ea
20150106 02:40:34< iceiceice> vultraz: just to be absolutely sure,
20150106 02:40:39< iceiceice> i'm testing this scenario now,
20150106 02:40:40< iceiceice> http://hastebin.com/zugedoziva.apache
20150106 02:40:47< iceiceice> i should see shroud on most of the map if not all, right?
20150106 02:40:54< iceiceice> as soon as i load it?
20150106 02:42:01< vultraz> yes
20150106 02:42:09-!- mjs-de [~mjs-de@f049008092.adsl.alicedsl.de] has quit [Remote host closed the connection]
20150106 02:42:28< vultraz> though i think all since you dont specify a side to redraw
20150106 02:47:06< iceiceice> vultraz: i didn't get any shroud in that scenario either
20150106 02:47:22< vultraz> wat
20150106 02:48:21< iceiceice> i'm trying on 1.12.0 now
20150106 02:56:38< iceiceice> ok it doesnt work on 1.12.0 eiether.
20150106 02:56:51< iceiceice> vultraz: i don't know any commits where this scenario makes any shroud
20150106 03:00:30< iceiceice> i think you should try to reduce it to a simple test case based on modified den of onis or something, it might not actually be a problem with place_shroud
20150106 03:01:38< iceiceice> i'll be back later
20150106 03:01:39-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150106 03:03:03-!- Ivanovic_ [~ivanovic@frnk-d933314e.pool.mediaWays.net] has joined #wesnoth-dev
20150106 03:05:28-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 250 seconds]
20150106 03:06:56-!- Ivanovic_ is now known as Ivanovic
20150106 03:15:03-!- un214 [~un214@2602:306:cccf:a879:56a0:50ff:fe57:101d] has joined #wesnoth-dev
20150106 03:29:01-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20150106 03:50:20-!- renketsu0 [45f63b55@gateway/web/freenode/ip.69.246.59.85] has joined #wesnoth-dev
20150106 04:01:58-!- un214 [~un214@2602:306:cccf:a879:56a0:50ff:fe57:101d] has quit [Remote host closed the connection]
20150106 04:22:11< vultraz> wait a second...
20150106 04:22:48< vultraz> hm..
20150106 04:40:16-!- irker718 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150106 04:40:16< irker718> wesnoth: Charles Dang wesnoth:master 2eff60bc427a / data/core/macros/scenario-utils.cfg: Use [filter_condition] in AI_CANT_PLAY http://git.io/z2g7Dw
20150106 04:40:17< irker718> wesnoth: Charles Dang wesnoth:master 7a9a13c80d43 / data/core/macros/scenario-utils.cfg: Drop border_size= and usage= keys from NO_MAP_DATA http://git.io/N2y5Ig
20150106 05:03:22-!- renketsu0 [45f63b55@gateway/web/freenode/ip.69.246.59.85] has quit [Quit: Page closed]
20150106 05:03:22< irker718> wesnoth: Chris Beck wesnoth:master 7adde8af9c83 / src/scripting/game_lua_kernel.cpp: lua: change a reference variable to a non-reference type http://git.io/L_UdfQ
20150106 05:16:13-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 245 seconds]
20150106 05:22:17< vultraz> I am at a complete loss here
20150106 05:29:05-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150106 05:32:28-!- Sulfur [~Miranda@p5B00869E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150106 05:59:53-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.0.1]
20150106 06:56:23-!- Ivanovic [~ivanovic@frnk-d933314e.pool.mediaWays.net] has quit [Changing host]
20150106 06:56:23-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20150106 06:56:54-!- Ardonik [~user@adsl-75-28-101-59.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20150106 06:58:59-!- Ard0nik [~user@adsl-75-28-101-105.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 245 seconds]
20150106 07:09:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150106 07:52:52< irker718> wesnoth: Charles Dang wesnoth:master f7ff591fe5b1 / data/core/macros/ai_controller.cfg: Use [clear_menu_item] instead of the [set_menu_item] workaround where applicable http://git.io/NysW2A
20150106 08:06:41< irker718> wesnoth: Charles Dang wesnoth:master 10023d79a67e / data/core/macros/conditional-utils.cfg: Use [not] instead of [else] hack in IF_DEAD http://git.io/HF99nw
20150106 08:06:44< irker718> wesnoth: Charles Dang wesnoth:master 75e7d4142566 / data/core/macros/side-utils.cfg: Use [filter_condition] in second part of LIMIT_CONTEMPORANEOUS_RECRUITS http://git.io/_Iem5w
20150106 08:22:03-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20150106 08:27:25-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150106 08:28:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds]
20150106 08:33:32< irker718> wesnoth: Charles Dang wesnoth:master 8a620dd5f136 / data/core/macros/side-utils.cfg: Use [filter_condition] in RECALL_AI_SIDE http://git.io/6PkV8g
20150106 09:04:36-!- mjs-de [~mjs-de@f049135164.adsl.alicedsl.de] has joined #wesnoth-dev
20150106 09:23:37-!- mjs-de [~mjs-de@f049135164.adsl.alicedsl.de] has quit [Remote host closed the connection]
20150106 09:23:37-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150106 09:24:52-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150106 09:32:42-!- Sulfur [~Miranda@p5B00869E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150106 10:08:29-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 244 seconds]
20150106 10:19:48-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150106 10:22:20-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150106 10:27:32-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150106 10:38:15-!- Sulfur [~Miranda@p5B00869E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150106 11:07:19-!- Necrosporus_ is now known as Necrosporus
20150106 11:07:48< Necrosporus> is it ok to use [object] when you want to apply some effect like curing poison?
20150106 11:13:52-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Ping timeout: 240 seconds]
20150106 11:23:27-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150106 11:34:06-!- irker718 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150106 12:14:46-!- cib0 [~cib@p5DD2377B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150106 12:25:21 * vultraz pings zookeeper
20150106 12:26:42 * nurupo broadcasts ping
20150106 12:27:58< zookeeper> yes?
20150106 12:29:18-!- gfgtdf [~chatzilla@f050179193.adsl.alicedsl.de] has joined #wesnoth-dev
20150106 12:29:40-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Ping timeout: 250 seconds]
20150106 12:29:50< vultraz> zookeeper: should we deprecate ON_SIGHTING? according to the wiki, sighted events are fixed now
20150106 12:30:12< zookeeper> i see no reason to
20150106 12:30:35< zookeeper> not this soon, anyway
20150106 12:31:18< vultraz> I would simply update the macro itself, but the arguments wouldn't exactly match up
20150106 12:33:03< gfgtdf> iceiceice: it is impossible to leave a pause a syncedcontext and start a synced context during that. Thre are situations where we want to do  something similar,there weuse synced::context::run_in_synced_context_if_not_already.
20150106 12:33:37< gfgtdf> iceiceice: the other option is to somehowmake a list of qued hotkeys events anf fire then after leavong the synced context.
20150106 12:34:34< zookeeper> i'm also under the impression that sighted events are foolproof now (in the sense that they can't be skipped over), but i'd like to spend at least one full stable cycle convincing myself of that
20150106 12:35:27< zookeeper> if we want to deprecate something like that then the removal should be no sooner than 1.15.0 anyway, so there's plenty of time for that
20150106 12:35:49< vultraz> alright. would it be ok, at least, to drop cases of its use in mainline campaigns?
20150106 12:35:54< zookeeper> of course, feel free to add a note saying that the macro should be unnecessary now
20150106 12:36:04< zookeeper> sure, that's fine by me
20150106 12:36:11< zookeeper> just don't break anything :P
20150106 12:37:19< gfgtdf> Necrosporus: that's possible, but usually i'd do it the other way.
20150106 12:48:22< gfgtdf> iceiceice:i just looked at the pr and run_in_synced_context_if_not_alreadyismost likeleywhat you want, (for examplereplan grun_in_synced_context)
20150106 12:48:52< gfgtdf> in menu_items.cpp with run_in_synced_context_if_not_already
20150106 12:51:07< gfgtdf> iceiceice: maybe it could cause sync/OOS poblems with needsselect wmlmenu items, but assumethat functionis is just for testing anyway
20150106 12:51:48< gfgtdf> iceiceice: if fire_wml_meanu_item is used with needs_select=yes wmlmenu items.
20150106 12:51:56-!- gfgtdf [~chatzilla@f050179193.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0.5/20141126041045]]
20150106 12:53:36-!- irker112 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150106 12:53:36< irker112> wesnoth: Charles Dang wesnoth:master 238a48944477 / data/core/macros/unit-utils.cfg: Use [transform_unit] for TRANSFORM_UNIT http://git.io/CaPrQA
20150106 12:53:37< irker112> wesnoth: Charles Dang wesnoth:master 02ecc00b769c / data/core/macros/utils.cfg: Use [modify_unit] for MODIFY_UNIT http://git.io/MgayuQ
20150106 12:54:33-!- gfgtdf [~chatzilla@f050179193.adsl.alicedsl.de] has joined #wesnoth-dev
20150106 12:57:09-!- gfgtdf [~chatzilla@f050179193.adsl.alicedsl.de] has quit [Client Quit]
20150106 13:09:41< vultraz> hm...
20150106 13:09:50< Necrosporus> I see some code using object to remove poison 
20150106 13:10:23< Necrosporus> I guess it might cause unit's WML to be overloaded with unnecessary [objects]?
20150106 13:10:46< vultraz> dammit, I think 02ecc00b769c might have actually changed the behavior :(
20150106 13:14:05< vultraz> yeah...
20150106 13:14:07< vultraz> blegh :(
20150106 13:17:21< zookeeper> yes, you can't make that conversion
20150106 13:18:01< zookeeper> {MODIFY_UNIT id=foo variables.bar "yes"} etc
20150106 13:18:09< vultraz> yup
20150106 13:18:11< vultraz> damn
20150106 13:19:25< zookeeper> and if you're next going to ask whether you can/should convert all mainline MODIFY_UNITs to [modify_unit] or whatever, then please don't :p
20150106 13:19:44< Necrosporus> WML is quite messy in this part
20150106 13:20:09< zookeeper> it's such an old and established macro that i bet most people are way more familiar with it than [modify_unit] and doing conversions like that is just extra noise and don't really help anyone, i believe
20150106 13:20:53< Necrosporus> I guess I would use modify_unit
20150106 13:20:56< vultraz> yeah, I don't intend to do that
20150106 13:21:02< Necrosporus> Because I do not like macros
20150106 13:21:13< Necrosporus> if they are not really necessary
20150106 13:22:47< zookeeper> well, for common tasks like that i still prefer a one-liner macro that everyone knows over a minimum of 6 lines of non-macro code
20150106 13:23:56< vultraz> yeah, agreed. it's just unfortunate that it gets expanded to a complicated loop for just one unit (common usecase), which is why I thought i could be changed
20150106 13:24:53< zookeeper> sure, it's a bit bloaty
20150106 13:26:03< zookeeper> i've usually changed instances of single-unit MODIFY_UNIT calls to a VARIABLE+[unstore_unit] when possible (which is pretty often)
20150106 13:27:52< irker112> wesnoth: Charles Dang wesnoth:master a0543d8206c8 / data/core/macros/event-utils.cfg: Add note to ON_SIGHTING documentation that it's no longer necessary http://git.io/-HGwBg
20150106 13:27:55< irker112> wesnoth: Charles Dang wesnoth:master 4ac0373d09d9 / data/campaigns/ (5 files in 3 dirs): Converted mainline uses of ON_SIGHTING to sighted events http://git.io/dVlT4g
20150106 13:27:58< irker112> wesnoth: Charles Dang wesnoth:master 6f60640c8e24 / data/core/macros/utils.cfg: Revert "Use [modify_unit] for MODIFY_UNIT" http://git.io/4_Jm0w
20150106 13:28:24< vultraz> I hope the [transform_unit] commit is ok, at least
20150106 13:29:35-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20150106 13:33:41-!- travis-ci [~travis-ci@ec2-54-198-79-106.compute-1.amazonaws.com] has joined #wesnoth-dev
20150106 13:33:41< travis-ci> wesnoth/wesnoth#5454 (master - 02ecc00 : Charles Dang): The build was broken.
20150106 13:33:41< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/46066244
20150106 13:33:41-!- travis-ci [~travis-ci@ec2-54-198-79-106.compute-1.amazonaws.com] has left #wesnoth-dev []
20150106 13:42:39-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20150106 13:42:54< zookeeper> well i'm not familiar with the old TRANSFORM_UNIT, but i'm assuming you tested at least one usecase, and if it works...
20150106 13:48:31< vultraz> derp, I typoed it >_>
20150106 13:49:00< vultraz> I do have spellcheck on, don't I?
20150106 13:50:14< irker112> wesnoth: Charles Dang wesnoth:master d71d39ec7aa8 / data/core/macros/unit-utils.cfg: Fixup 238a48944477, typo in transform_to key http://git.io/hnPcNA
20150106 13:50:54-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150106 14:08:02-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 250 seconds]
20150106 14:10:16-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150106 14:18:43-!- cib0 [~cib@p5DD2377B.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
20150106 14:20:02-!- horrowin1 [~Icedove@x04l2a.wh2.tu-dresden.de] has joined #wesnoth-dev
20150106 14:24:09 * vultraz gets down to it and begins dealing with TS2
20150106 14:28:39< Necrosporus> How to make unique ids for things if you are going to refer to them later?
20150106 14:29:04< Necrosporus> id=thingname$thingcount ?
20150106 14:29:05-!- cib0 [~cib@p5DD2377B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150106 14:29:20< Necrosporus> where thingcount is increased each time a thing is created
20150106 14:31:25< Necrosporus> zookeeper, maybe it's worth to make other macro like MODIFY_SINGLE_UNIT which modifies single unit?
20150106 14:32:24< vultraz> DiD has a modify_single_unit macro but that uses [store_unit] as well
20150106 14:41:21-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20150106 14:48:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150106 14:49:19< Necrosporus> Why not to use store_unit?
20150106 14:49:37< Necrosporus> As far as I can remember [modify_unit] could not modify lot of things
20150106 14:50:00< Necrosporus> So you have to use [object] or [store_unit] / ]
20150106 14:51:39-!- travis-ci [~travis-ci@ec2-54-167-197-210.compute-1.amazonaws.com] has joined #wesnoth-dev
20150106 14:51:39< travis-ci> wesnoth/wesnoth#5456 (master - d71d39e : Charles Dang): The build was fixed.
20150106 14:51:39< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/46071468
20150106 14:51:39-!- travis-ci [~travis-ci@ec2-54-167-197-210.compute-1.amazonaws.com] has left #wesnoth-dev []
20150106 14:58:59-!- mjs-de [~mjs-de@f049135164.adsl.alicedsl.de] has joined #wesnoth-dev
20150106 14:59:00-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20150106 15:02:21-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 256 seconds]
20150106 15:02:45-!- Necrosporus_ is now known as Necrosporus
20150106 15:10:39-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20150106 15:15:46-!- cib0 [~cib@p5DD2377B.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20150106 15:22:48< Ravana_> objects were a pain to remove last time I used them
20150106 15:23:29< vultraz> they still are
20150106 15:23:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150106 15:24:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150106 15:25:00< vultraz> [objects] are some of the biggest PITAs in WML
20150106 15:28:38-!- Sulfur [~Miranda@p5B00869E.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20150106 15:39:24-!- gfgtdf [~chatzilla@f054167175.adsl.alicedsl.de] has joined #wesnoth-dev
20150106 15:46:31-!- Sulfur [~Miranda@p5B00869E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150106 15:51:28< Soliton> vultraz: did you know you can test changes before pushing them upstream and that such behaviour is highly encouraged?
20150106 15:52:50< vultraz> I am aware
20150106 16:00:49-!- Sulfur [~Miranda@p5B00869E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150106 16:03:40-!- cib0 [~cib@p5DD2377B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150106 16:14:22-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 255 seconds]
20150106 16:16:55-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150106 16:22:33-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20150106 16:32:28-!- gfgtdf [~chatzilla@f054167175.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]]
20150106 16:38:24-!- Sulfur [~Miranda@p5B00869E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150106 16:44:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150106 16:50:47-!- irker112 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150106 16:57:22-!- cib0 [~cib@p5DD2377B.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20150106 17:09:43-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 255 seconds]
20150106 17:31:19-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150106 17:36:17-!- Sulfur [~Miranda@p5B00869E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150106 17:39:07-!- horrowin1 [~Icedove@x04l2a.wh2.tu-dresden.de] has quit [Quit: horrowin1]
20150106 17:39:36-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.0.1]
20150106 17:47:19-!- Fluffbeast [~Fluffbeas@173.227.19.200] has joined #wesnoth-dev
20150106 17:48:00-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150106 17:54:45-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150106 18:02:33-!- Fluffbeast [~Fluffbeas@173.227.19.200] has quit [Ping timeout: 256 seconds]
20150106 18:04:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150106 18:22:50-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20150106 18:30:03-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Read error: Network is unreachable]
20150106 18:31:20-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20150106 18:31:26-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20150106 18:34:21-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150106 18:36:34-!- cib0 [~cib@p5DD2377B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150106 18:39:30-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20150106 18:39:43-!- gfgtdf [~chatzilla@f054167175.adsl.alicedsl.de] has joined #wesnoth-dev
20150106 18:44:07-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev
20150106 18:59:37-!- thunderstruck [~thunderst@cpc8-sgyl29-2-0-cust37.sgyl.cable.virginm.net] has joined #wesnoth-dev
20150106 19:03:24< thunderstruck> gfgtdf, is http://gna.org/bugs/?23036 still need to be looked at?
20150106 19:23:09-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150106 19:24:17-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Quit: DCW]
20150106 19:26:30< gfgtdf> thunderstruck: I made a patch about it: https://github.com/wesnoth/wesnoth/commit/9c6b5df2311eb55cf8e9788e6934c30454a30a0c but it wasnt tst verified that it fixes it.
20150106 19:33:28< gfgtdf> s/tst/yet
20150106 19:33:48< thunderstruck> gfgtdf, Would you like me to test it?
20150106 19:35:02< gfgtdf> thunderstruck: if you have time sure.
20150106 19:39:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150106 19:50:09-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150106 19:50:33< iceiceice> vultraz: are you going to revert this? https://github.com/wesnoth/wesnoth/commit/dc807a0ab68387b4579a3acbd51c1b4b8f7fe82c
20150106 19:51:46< vultraz> iceiceice: uh, im not sure
20150106 19:52:07-!- cib0 [~cib@p5DD2377B.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20150106 19:53:16< vultraz> also regarding shroud,  I forgot to tell you that a side= has to have a shroud=yes key for shroud to appear at all
20150106 19:54:08< vultraz> s/side=/[side]
20150106 19:54:23< vultraz> so I went and tested it, and god dammit it worked
20150106 19:54:32< vultraz> shroud was placed as expected
20150106 19:54:54< vultraz> and i ran a multitude of different variations on that onis test you gave
20150106 19:55:00< vultraz> and they all seem to work as expected
20150106 19:55:22< vultraz> but I cannot explain why it doesn't in my campaign. SOMETHING changed somewhere or it wouldn't do this
20150106 19:55:48< vultraz> the shroud behavior in onis in 1.13 and 1.12 seem consistent
20150106 19:58:02< vultraz> shroud is redrawn at start, then placed, and then redrawn when the objectives appear
20150106 19:58:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150106 19:58:59< iceiceice> vultraz: it would be a really good thing if we can take the multitude of variations and find some way to commit them
20150106 19:59:22< iceiceice> so that people don't have to run the exact same tests a year from now
20150106 19:59:50< iceiceice> imo
20150106 19:59:52< vultraz> well they were mostly comparisons with my campaign scenario to see what's gone wrong
20150106 19:59:59< vultraz> so swapping bits of code...
20150106 20:00:03< iceiceice> yeah but it still valuable
20150106 20:00:32< vultraz> let me perform another test here...
20150106 20:01:25< iceiceice> vultraz: i grepped a little bit earlier, it looks like the commit https://github.com/wesnoth/wesnoth/commit/dc807a0ab68387b4579a3acbd51c1b4b8f7fe82c changes a ton of code,
20150106 20:01:37< iceiceice> all of the ai code that uses location filters was using the no border version
20150106 20:01:53< iceiceice> idk exactly what the issue is, what is border, what it does,
20150106 20:02:05< iceiceice> but if you didn't test the crap out of that commit it should probably be reverted
20150106 20:02:47< vultraz> hang on
20150106 20:02:56< vultraz> ok, so im testing my campaign scenario with the shroud with ONLY side 1
20150106 20:02:59< vultraz> and it works as expected
20150106 20:05:37< vultraz> ok...
20150106 20:05:45< vultraz> but NOT with side 2 present
20150106 20:05:52< vultraz> works fine with side 1 and 3 
20150106 20:06:32< vultraz> it also works for side 2 with no units attached
20150106 20:09:52< vultraz> iceiceice: did you change anything with unit placement?
20150106 20:10:12< iceiceice> i dont know what that means
20150106 20:10:26< vultraz> the [unit] tag
20150106 20:11:15< iceiceice> i think its a hard question to answer exactly
20150106 20:11:41< iceiceice> when [unit] tag is executed there is a ton of code that is involved
20150106 20:11:56< iceiceice> a lot of things could be considered to "change" that
20150106 20:12:03< vultraz> if I remove these {NAMED_LOYAL_UNIT inclusions starting here https://github.com/Vultraz/Shadows_of_Deception/blob/master/episode1/scenarios/00_Descry.cfg#L55 it starts working correctly :/
20150106 20:13:51< iceiceice> sounds like progress
20150106 20:15:29< vultraz> But if I stick it in onis it works
20150106 20:15:30< vultraz> AGH
20150106 20:15:37< vultraz> I'll be back later
20150106 20:15:54< vultraz> If you think that commit should be reverted, by all means do so
20150106 20:15:56-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150106 20:16:06< vultraz> but we still have to deal with the fact that it takes shortcuts
20150106 20:21:52-!- Coffee_irc [~david@ppp118-210-1-164.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20150106 20:31:44-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150106 21:03:17-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 265 seconds]
20150106 21:04:47-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150106 21:14:19-!- kex [~kex@77.28.8.59] has joined #wesnoth-dev
20150106 21:16:01-!- kex [~kex@77.28.8.59] has quit [Read error: Connection reset by peer]
20150106 21:16:05-!- Kexoth [~kex@77.28.8.59] has joined #wesnoth-dev
20150106 21:33:32< gfgtdf> iceiceice: did you see my answer comment earlier?
20150106 21:33:38< gfgtdf> thunderstruck: did you test the patch ?
20150106 21:34:08< gfgtdf> vultraz: i wonder whwther i shoudl also apply https://github.com/wesnoth/wesnoth/commit/201d83f608d0838bf21b9698b45bff0037f3988f to [store_unit] and store locations
20150106 21:46:32-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Quit: Sűrű sötét az éj, dühöng a déli szél]
20150106 21:49:01-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has joined #wesnoth-dev
20150106 21:49:43-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150106 21:49:52< iceiceice> gfgtdf: yeah i saw, i'm going to take another look at this now
20150106 21:57:21< gfgtdf> iceiceice: a third option migth to allow invoke synced actions from within the local choice, but i remember rgoughly that thats notpossible on purpose, but i currently dnt know why.
20150106 21:58:39< iceiceice> gfgtdf: i think its hard right now for lua to determine from id if a menu item has needs_select
20150106 21:59:25< iceiceice> i was going to try changing this line: https://github.com/wesnoth/wesnoth/blob/master/src/game_events/menu_item.cpp#L215
20150106 21:59:57< iceiceice> i would rather give a lua error than assertion if someone tries to use the fcn with a needs_select menu item...
20150106 22:00:23< iceiceice> idk if theres an easy way to schedule hotkey events for later
20150106 22:00:39< gfgtdf> iceiceice: we coudl also just ognore teh needs select if called by lua. What i'd liek more though is to reemve teh needs selece, and instead have last_select_x, last_select_y variables in each wml menu option, since i'd call teh current needs select action also rather hacky currently..
20150106 22:01:19< gfgtdf> iceiceice: i currently dont know teh usecases fr needs select so i cannot reylly decide.
20150106 22:01:30< iceiceice> yeah...
20150106 22:01:36< iceiceice> it sounds like its just for fancy menu items or something
20150106 22:03:43-!- Kexoth [~kex@77.28.8.59] has quit [Remote host closed the connection]
20150106 22:04:01-!- kex [~kex@77.28.8.59] has joined #wesnoth-dev
20150106 22:07:57< gfgtdf> iceiceice: afaik in 1.12 needs_select is also slighly broken since it fires the select event on the host twice.
20150106 22:08:06< gfgtdf> iceiceice: also in master
20150106 22:09:48< iceiceice> hmm ok
20150106 22:15:52< fabi> zookeeper: Hello. Happy New Year. You found a bug in [music]?
20150106 22:16:48< iceiceice> gfgtdf: do you think i should change only the line i indicated or both lines?
20150106 22:17:02< iceiceice> my thoguht is that i should change only the line i indicated
20150106 22:17:11< zookeeper> fabi, yeah, as said, and i commented on the report too
20150106 22:17:19< iceiceice> and put a code comment that "fire_wml_menu_item" is not supported with needs_select events right now
20150106 22:18:20-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Ping timeout: 244 seconds]
20150106 22:20:09< gfgtdf> iceiceice: hmm ye for now i'd do the second option, but if you want to make fire_wml_menu_item an offical feature, an assertion failue and a comment in the c++ code is not the way to report a wml error.
20150106 22:22:09< iceiceice> yeah... for now it won't be official i gues
20150106 22:22:45< iceiceice> i guess it shouldn't ever really be needed for an add-on,
20150106 22:22:56< iceiceice> since probably you could make the menu item just call "fire_event" on a custom event
20150106 22:23:04< iceiceice> and ask lua to call that event directly
20150106 22:23:11-!- cib0 [~cib@p5DD2377B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150106 22:23:34< iceiceice> (or just fire that event directly i mean)
20150106 22:23:47< iceiceice> should you have wanted to get the results of "fire_wml_menu_item"
20150106 22:24:34-!- Kexoth [~kex@77.28.11.45] has joined #wesnoth-dev
20150106 22:27:45-!- kex [~kex@77.28.8.59] has quit [Ping timeout: 256 seconds]
20150106 22:33:19-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 244 seconds]
20150106 22:33:42-!- fabi [~quassel@p20030051AA4C4663DC1251BB0A06A4EE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150106 22:33:42-!- fabi [~quassel@p20030051AA4C4663DC1251BB0A06A4EE.dip0.t-ipconnect.de] has quit [Changing host]
20150106 22:33:42-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150106 22:38:36-!- TooLmaN [~TooLmaN@c-73-190-210-54.hsd1.ga.comcast.net] has joined #wesnoth-dev
20150106 22:40:08-!- skyfaller [~skyfaller@pool-96-234-41-41.nwrknj.fios.verizon.net] has joined #wesnoth-dev
20150106 22:40:08-!- skyfaller [~skyfaller@pool-96-234-41-41.nwrknj.fios.verizon.net] has quit [Changing host]
20150106 22:40:08-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev
20150106 22:42:47-!- mjs-de [~mjs-de@f049135164.adsl.alicedsl.de] has quit [Remote host closed the connection]
20150106 22:43:06-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20150106 22:45:02-!- gfgtdf_ [~chatzilla@f054057089.adsl.alicedsl.de] has joined #wesnoth-dev
20150106 22:46:52-!- gfgtdf [~chatzilla@f054167175.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20150106 22:46:56-!- gfgtdf_ is now known as gfgtdf
20150106 22:58:48-!- irker124 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150106 22:58:48< irker124> wesnoth: gfgtdf wesnoth:master 88de21a5ff54 / src/ (4 files in 2 dirs): check is_replay on [set_global_variable] and [do_command] http://git.io/zO_8sw
20150106 23:07:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150106 23:12:43-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150106 23:21:19-!- Netsplit *.net <-> *.split quits: yann, loonycyborg, shadowm, Ivanovic, elias, iceiceice, thunderstruck, Pepe_, vifon, esr,  (+4 more, use /NETSPLIT to show all of them)
20150106 23:21:22-!- Netsplit over, joins: thunderstruck
20150106 23:21:23-!- Netsplit over, joins: Soliton
20150106 23:21:32-!- Netsplit over, joins: loonycyborg
20150106 23:21:39-!- Netsplit over, joins: elias, shadowm
20150106 23:22:27-!- Ivanovic [~ivanovic@frnk-d933314e.pool.mediaWays.net] has joined #wesnoth-dev
20150106 23:22:52-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150106 23:22:52-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150106 23:22:52-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20150106 23:22:52-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev
20150106 23:22:52-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20150106 23:22:52-!- Pepe_ [~ppjet@anderith.bouah.net] has joined #wesnoth-dev
20150106 23:22:52-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20150106 23:22:52-!- vifon [~vifon@bohdan.wu-be.de] has joined #wesnoth-dev
20150106 23:31:27-!- kex [~kex@77.28.11.45] has joined #wesnoth-dev
20150106 23:33:23-!- Crendgrim_ [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20150106 23:33:54-!- Kexoth [~kex@77.28.11.45] has quit [Read error: Connection reset by peer]
20150106 23:33:55-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Quit: No Ping reply in 180 seconds.]
20150106 23:34:28-!- enchilado [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 255 seconds]
20150106 23:35:23-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20150106 23:38:06-!- cib0 [~cib@p5DD2377B.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds]
20150106 23:44:25-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150106 23:52:21-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150106 23:54:47-!- kex [~kex@77.28.11.45] has quit [Remote host closed the connection]
--- Log closed Wed Jan 07 00:00:19 2015