--- Log opened Wed Jan 07 00:00:19 2015
20150107 00:09:14-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20150107 00:19:34-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20150107 00:34:24-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit []
20150107 00:35:45-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has quit [Remote host closed the connection]
20150107 00:42:19-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has joined #wesnoth-dev
20150107 00:42:43-!- Coffee_irc [~david@ppp118-210-1-164.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20150107 00:45:27-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has quit [Remote host closed the connection]
20150107 00:49:12-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has quit [Quit: later all]
20150107 01:06:03-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has joined #wesnoth-dev
20150107 01:41:22-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 240 seconds]
20150107 01:59:00-!- irker124 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150107 02:04:39-!- gfgtdf [~chatzilla@f054057089.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]]
20150107 02:35:51-!- faabumc [~vcr@wesnoth/developer/faabumc] has joined #wesnoth-dev
20150107 02:44:36-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150107 02:44:54< iceiceice> gfgtdf: i updated pull request, it seems to work now, if you could review though i would appreciate
20150107 03:02:26-!- Ivanovic_ [~ivanovic@frnk-5f74e49c.pool.mediaWays.net] has joined #wesnoth-dev
20150107 03:04:24-!- Ivanovic [~ivanovic@frnk-d933314e.pool.mediaWays.net] has quit [Ping timeout: 245 seconds]
20150107 03:06:21-!- Ivanovic_ is now known as Ivanovic
20150107 03:20:15-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150107 03:20:37-!- travis-ci [~travis-ci@ec2-54-198-81-135.compute-1.amazonaws.com] has joined #wesnoth-dev
20150107 03:20:37< travis-ci> cbeck88/wesnoth#120 (menu_item_tests - 8459bf7 : Chris Beck): The build was fixed.
20150107 03:20:37< travis-ci> Build details : http://travis-ci.org/cbeck88/wesnoth/builds/46151297
20150107 03:20:38-!- travis-ci [~travis-ci@ec2-54-198-81-135.compute-1.amazonaws.com] has left #wesnoth-dev []
20150107 03:27:23-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Quit: http://xkcd.com/91/]
20150107 03:29:08-!- irker987 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150107 03:29:08< irker987> wesnoth: Chris Beck wesnoth:master f015745e227f / src/ (4 files in 3 dirs): Revert "Always consider border hexes when filtering locations" http://git.io/MVQm8w
20150107 03:32:30< vultraz> alright, im getting somewhere with the shroud thing
20150107 03:35:36< vultraz> iceiceice: thanks for reverting, btw
20150107 03:38:02< iceiceice> np
20150107 03:38:12< iceiceice> i ran the tests before hand so i dont think anything was broken by reverting anyways
20150107 03:40:29< vultraz> I finally think I have isolated the problem
20150107 03:41:43< vultraz> an allied side with units will cause shroud not to be placed properly
20150107 03:42:11< vultraz> even with share_maps=no
20150107 03:44:00-!- TooLmaN [~TooLmaN@c-73-190-210-54.hsd1.ga.comcast.net] has quit [Quit: Off to save the world!]
20150107 03:44:45< vultraz> shroud WILL be placed for the areas you can see as side 1, but not for locations your allied side can see
20150107 03:46:00< vultraz> this isn't the 1.12 behavior, it seems
20150107 03:47:37< vultraz> share_maps=no doesn't seem to have any affect on this
20150107 03:47:41< vultraz> s/affect/effect
20150107 03:52:11< vultraz> iceiceice: I'm going to hazard a guess and say it's something with game_lua_kernel::get_sides_vector
20150107 03:52:39< iceiceice> i thoguht i just copy pasted that
20150107 03:52:55< iceiceice> let me take a look
20150107 03:55:22-!- faabumc [~vcr@wesnoth/developer/faabumc] has quit [Ping timeout: 240 seconds]
20150107 03:57:24< iceiceice> vultraz: you think this is the bad commit?
20150107 03:57:24< iceiceice> https://github.com/wesnoth/wesnoth/commit/0d76ac3be7
20150107 03:59:15< vultraz> I've just guessing, but I think it's likely
20150107 03:59:45< iceiceice> vultraz: it might be a good idea to add some debugging output at the [place_shroud] get_sides_vector call
20150107 03:59:47< iceiceice> in 1.12 and master
20150107 03:59:50< iceiceice> and see if its different
20150107 04:00:17-!- Ivanovic_ [~ivanovic@frnk-d93335c7.pool.mediaWays.net] has joined #wesnoth-dev
20150107 04:00:22< vultraz> I haven't been building 1.12 :(
20150107 04:00:36< iceiceice> hmm
20150107 04:00:40< iceiceice> do you have ccache or something?
20150107 04:00:52< iceiceice> is there something like that for windows?
20150107 04:01:49< iceiceice> https://code.google.com/p/ccache-win32/
20150107 04:01:50< iceiceice> ?
20150107 04:02:11< vultraz> building doesn't take long, i just haven't figured out how to have builds from different branches in the same lame location
20150107 04:02:28-!- faabumc [~vcr@wesnoth/developer/faabumc] has joined #wesnoth-dev
20150107 04:02:45< iceiceice> oooh
20150107 04:02:50< iceiceice> right so theres another handy trick
20150107 04:02:59< iceiceice> theres this thing called git new work dir
20150107 04:03:11< iceiceice> i assume it works on windows i dont actually know for a fact
20150107 04:03:24< iceiceice> its like, you can have two folders that actually correspond to the same clone
20150107 04:03:25-!- Ivanovic [~ivanovic@frnk-5f74e49c.pool.mediaWays.net] has quit [Ping timeout: 264 seconds]
20150107 04:03:31< iceiceice> so its one repo
20150107 04:03:35< iceiceice> but each folder can be on a different branch
20150107 04:03:37< iceiceice> no problem
20150107 04:03:51< iceiceice> actually it acts strangely if you put them on the same branch
20150107 04:03:57< iceiceice> so you could have like a 1.12 folder and a master folder
20150107 04:04:02< iceiceice> i find this really handy
20150107 04:04:12-!- Ivanovic_ is now known as Ivanovic
20150107 04:04:34< vultraz> ahh
20150107 04:09:04< vultraz> hm...
20150107 04:09:09< vultraz> apparently it doesn't work on windows
20150107 04:09:31< vultraz> oh, here's a port https://github.com/joero74/git-new-workdir
20150107 04:13:56< vultraz> I'll deal with this later
20150107 04:19:17< vultraz> iceiceice: im curious why you changed team &t = (*resources::teams)[index]; to team &t = teams()[index];
20150107 04:19:38< iceiceice> it shouldn't be different,
20150107 04:19:51< iceiceice> tbh i want to get rid of resources::teams in a lot of places where it currently is
20150107 04:19:58< iceiceice> or make it a pointer to const
20150107 04:20:39< iceiceice> vultraz: resources::teams is pretty odd,
20150107 04:20:49< vultraz> ah
20150107 04:20:50< iceiceice> most resources::links related to the game are set in play_controller,
20150107 04:20:55< iceiceice> there's also some copy of it that is made in teams.cpp
20150107 04:21:14< iceiceice> but it should be a pointer to gamestate.gameboard.teams_ basically
20150107 04:21:17< iceiceice> in all cases
20150107 04:23:25-!- faabumc [~vcr@wesnoth/developer/faabumc] has quit [Quit: Ex-Chat]
20150107 04:25:50< vultraz> I just can't think what's causing this :(
20150107 04:28:12-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150107 04:34:30-!- new_one [~new_one@50.15.126.83] has quit [Remote host closed the connection]
20150107 04:51:46-!- ancestral [~ancestral@174-20-166-97.mpls.qwest.net] has joined #wesnoth-dev
20150107 05:06:17-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150107 05:11:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150107 05:12:39-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 264 seconds]
20150107 05:18:58-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150107 05:37:41-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150107 05:48:38-!- ancestral [~ancestral@174-20-166-97.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150107 06:26:03-!- cib0 [~cib@p5DD22F8C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150107 06:30:19-!- irker987 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150107 06:50:22-!- cib0 [~cib@p5DD22F8C.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20150107 06:55:52-!- Ivanovic [~ivanovic@frnk-d93335c7.pool.mediaWays.net] has quit [Changing host]
20150107 06:55:52-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20150107 07:01:13-!- ancestral [~ancestral@174-20-166-97.mpls.qwest.net] has joined #wesnoth-dev
20150107 07:12:09-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20150107 07:33:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150107 07:36:22-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 240 seconds]
20150107 07:37:57-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150107 07:45:23-!- ancestral [~ancestral@174-20-166-97.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150107 07:47:49-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20150107 07:47:49-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Changing host]
20150107 07:47:49-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150107 07:59:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150107 08:21:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150107 08:43:39< AI0867> gfgtdf: PR #359 works fine on travis now
20150107 08:44:26-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150107 08:44:28-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150107 09:22:11< vultraz> zookeeper: so, what do you recommend for the TS2 bit on recalling. right now it tells you exactly who has experience and how much, but I think the player should be able to decide that for themselves. what about something like, just advise recalling if there's anyone >= lvl 2 or with exp on the recall list?
20150107 09:23:25< vultraz> and then give a general list of some units and let the player decide what to recall/recruit
20150107 09:23:38< vultraz> and after that, comment on the general state
20150107 09:23:39< vultraz> like
20150107 09:23:55< vultraz> "oh you recruited too many fighters, now you won't have a ranged attack advantage"
20150107 09:25:09< vultraz> "you have too many shamans, your army doesn't have enough offensive"
20150107 09:25:11< vultraz> etc
20150107 09:28:40< enchilado> I only ever recruit shamans
20150107 09:28:47< zookeeper> the current text seems fine to me, although arguably it's not useful to display names and the XP amounts in the message(s) since you can't actually cross-reference those with what you see in the recall dialog.
20150107 09:30:32< vultraz> well, if you get rid of $recall_name1 gained $recall_xp1 experience points, and $recall_name2 gained $recall_xp2 etc etc etc
20150107 09:30:41< vultraz> you could write just a generic message
20150107 09:31:10< vultraz> "During your training, several of your units gained experience! You should recall them now etc etc etc"
20150107 09:31:34< vultraz> and then definitely get rid of the "right click on the ne hex and recall this guy" thing
20150107 09:32:46< zookeeper> well i don't see what harm the current names and XP amounts do, might as well just leave them in
20150107 09:33:15< vultraz> well, see...
20150107 09:33:21< vultraz> it only talks about two units
20150107 09:33:22< vultraz> "# We have two worth recalling."
20150107 09:33:44< vultraz> I believe initially it only looked at the two units you recruit initially (hence the roles that were given to them)
20150107 09:34:00< vultraz> so I dunno
20150107 09:34:15< vultraz> should we list EVERY unit that has xp and their names and amount?
20150107 09:35:01< vultraz> this dialog never took into account the additional units you can recruit to kill the other quintains
20150107 09:35:16< zookeeper> right
20150107 09:36:22< zookeeper> i guess in that case it makes some sense to scrap it
20150107 09:37:04< zookeeper> are you supposed to recruit/recall more than 2 fighters?
20150107 09:37:24< zookeeper> if not, then only mentioning the two highest-XP ones doesn't seem bad
20150107 09:39:38< vultraz> well right now, it's very restrictive
20150107 09:39:49< vultraz> you have to recall/recruit exact units at exact locations
20150107 09:39:59< vultraz> I want to scrap that
20150107 09:40:10< vultraz> and just allow the player to recruit and recall as they want
20150107 09:42:11< zookeeper> it forces you to recall those two (or one) units? sure, scrap that then
20150107 09:43:02< vultraz> "# You were supposed to recall $recall_name2."
20150107 09:43:51-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 264 seconds]
20150107 09:43:56-!- ToBeCloud [uid51591@gateway/web/irccloud.com/x-wbihwmgnjqtxfsov] has joined #wesnoth-dev
20150107 09:44:52< vultraz> yeah it does
20150107 09:45:07-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20150107 09:46:15-!- Crendgrim_ [~crend@wesnoth/forum-moderator/crendgrim] has quit [Ping timeout: 264 seconds]
20150107 09:47:09-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150107 09:48:17< vultraz> so, to recap
20150107 09:48:23< vultraz> I'm just gonna mention your recall list
20150107 09:48:53< vultraz> mention extra dialog if you have level >=2
20150107 09:49:09< vultraz> and then give an overview of your recruit options
20150107 09:49:12< vultraz> mention generally what you need
20150107 09:49:21< vultraz> and tell the player to recruit or recall as they see fit
20150107 09:49:29< vultraz> then perhaps comment on your choices
20150107 09:52:43< zookeeper> yeah, if you let them recruit/recall as they see fit, then you need to comment (very briefly) on every choice
20150107 10:02:02-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 264 seconds]
20150107 10:05:20-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150107 10:20:34-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150107 10:23:18-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 245 seconds]
20150107 10:24:52-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds]
20150107 10:25:31-!- horrowind [~Icedove@x04l2a.wh2.tu-dresden.de] has joined #wesnoth-dev
20150107 10:28:42< vultraz> hm. it's actually impossible to get a lvl2 unit in the first scenario
20150107 10:28:52< vultraz> well, very unlikely
20150107 10:35:05-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150107 10:42:39-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev
20150107 10:44:23-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Client Quit]
20150107 10:47:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150107 10:53:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20150107 10:53:24-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150107 11:09:43-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 244 seconds]
20150107 11:12:18-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150107 11:18:18-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 245 seconds]
20150107 11:23:26-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150107 11:29:30-!- mjs-de [~mjs-de@g228137182.adsl.alicedsl.de] has joined #wesnoth-dev
20150107 11:45:43-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Ping timeout: 255 seconds]
20150107 11:48:03-!- ToBeCloud [uid51591@gateway/web/irccloud.com/x-wbihwmgnjqtxfsov] has quit [Quit: Connection closed for inactivity]
20150107 12:14:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150107 12:18:39-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 265 seconds]
20150107 12:23:32-!- Coffee_irc [~david@ppp118-210-1-164.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20150107 13:12:26-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20150107 13:15:31-!- enchilado [enchilado@defocus/yummy/enchilado] has quit [Remote host closed the connection]
20150107 13:16:45-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20150107 13:46:41-!- gfgtdf [~chatzilla@f054057089.adsl.alicedsl.de] has joined #wesnoth-dev
20150107 13:48:48< gfgtdf> AI0867: yes i saw, but i don't really know about the actual code, so i dont feel capable to review now. I think mordante wrote that code but mordante wasn't here for quiet some time.
20150107 13:49:32-!- Ard0nik [~user@adsl-75-28-99-138.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20150107 13:53:09-!- Ardonik [~user@adsl-75-28-101-59.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 245 seconds]
20150107 14:20:14-!- gfgtdf [~chatzilla@f054057089.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]]
20150107 14:31:12-!- Nostromus [~chatzilla@g230249164.adsl.alicedsl.de] has joined #wesnoth-dev
20150107 14:39:45-!- enchilado [enchilado@defocus/yummy/enchilado] has quit [Read error: Connection reset by peer]
20150107 14:41:09-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20150107 14:43:51-!- oldlaptop [~quassel@static-50-108-31-113.mskg.mi.frontiernet.net] has quit [Ping timeout: 264 seconds]
20150107 14:48:16-!- Ard0nik [~user@adsl-75-28-99-138.dsl.irvnca.sbcglobal.net] has quit [Read error: Connection reset by peer]
20150107 14:48:25-!- Ard0nik [~user@adsl-75-28-98-234.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20150107 14:59:17< thunderstruck> ggfgtdf: yes, your fix works.
20150107 14:59:32< thunderstruck> gfgtdf*
20150107 15:01:22-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 240 seconds]
20150107 15:05:15-!- gfgtdf [~chatzilla@f054057089.adsl.alicedsl.de] has joined #wesnoth-dev
20150107 15:06:47-!- irker456 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150107 15:06:47< irker456> wesnoth: gfgtdf wesnoth:1.12 cba025d1492a / changelog: Update changelog http://git.io/vm8O8A
20150107 15:06:57< gfgtdf> thunderstruck: ty :) i updated the changelog ^
20150107 15:13:50-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150107 15:17:02< gfgtdf> thunderstruck: chould you also test the "Ai sides assigned to host on mp reload" bug?
20150107 15:17:30< gfgtdf> thunderstruck: (http://gna.org/bugs/?22968)
20150107 15:18:09-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 245 seconds]
20150107 15:22:51-!- horrowind [~Icedove@x04l2a.wh2.tu-dresden.de] has quit [Quit: horrowind]
20150107 15:26:32-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150107 15:32:27-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Ping timeout: 245 seconds]
20150107 15:32:41< gfgtdf> iceiceice: from the mpsync apect  think the pr is fine.
20150107 15:39:12-!- kex [~kex@77.29.141.39] has joined #wesnoth-dev
20150107 15:39:51-!- kex [~kex@77.29.141.39] has quit [Read error: Connection reset by peer]
20150107 15:40:17-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20150107 15:40:22-!- kex [~kex@77.29.141.39] has joined #wesnoth-dev
20150107 15:45:02-!- kex [~kex@77.29.141.39] has quit [Ping timeout: 265 seconds]
20150107 16:00:42-!- kex [~kex@77.29.141.39] has joined #wesnoth-dev
20150107 16:05:21-!- kex [~kex@77.29.141.39] has quit [Ping timeout: 265 seconds]
20150107 16:05:59-!- kex [~kex@77.29.141.39] has joined #wesnoth-dev
20150107 16:12:11-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150107 16:22:59< Nostromus> gfgtdf: i describe the steps to reproduce the bugs in pr. please try again
20150107 16:23:06< Nostromus> -s
20150107 16:23:55< Nostromus> i checkout master, and the bug appears. Build with scons build=debug -j 6
20150107 16:24:13< Nostromus> Should also appear in 1.12 and earlier
20150107 16:29:29< gfgtdf> Nostromus: my build (with msvc) does not reproduce that bug with the steps you decribed.
20150107 16:29:45< Nostromus> interesting
20150107 16:29:58< vultraz> gfgtdf: I can, but only with arrow keys
20150107 16:30:00< vultraz> (master)
20150107 16:30:11< vultraz> (haven't tried 1.12)
20150107 16:30:12< Nostromus> yes mouse works fine
20150107 16:30:50< Nostromus> maybe the compiler handle references in another way, i compiled with clang
20150107 16:31:21< gfgtdf> Noah ok i didnt know that you can switch tips by keys.
20150107 16:31:26< gfgtdf> ok i can reproduce to
20150107 16:31:32< Nostromus> ok fine
20150107 16:31:40< Nostromus> i can explain the patch if you want
20150107 16:32:33< gfgtdf> Nostromus: I guess teh püroblem is thatbecasue we use static variables we alway use teh window pointer from teh first call ?
20150107 16:32:40< Nostromus> right
20150107 16:33:26< Nostromus> i'm not very happy to use copy arguments, but it is here the simplest way. 
20150107 16:37:33< irker456> wesnoth: Michael Strebel wesnoth:master 3b1abdf1e770 / src/gui/dialogs/title_screen.cpp: Changes registration of hotkeys for tips. http://git.io/NeWWbA
20150107 16:37:35< irker456> wesnoth: gfgtdf wesnoth:master a3e2b0e5e49a / src/gui/dialogs/title_screen.cpp: Merge pull request #359 from mstrebel/bug_18926 http://git.io/IvquXQ
20150107 16:39:21< Nostromus> gfgtdf: maybe you want this also for 1.12
20150107 16:41:26< gfgtdf> Nostromus: ok but first i'll test whether it actually fixes it.
20150107 16:41:35< Nostromus> of course
20150107 16:46:16< gfgtdf> vultraz: did you read my comment earlier about store_unit,store_side .. ?
20150107 16:46:45< vultraz> gfgtdf: yeah. im thinking, if the fix has to applied to each tag, perhaps it should be done directly in set_variable?
20150107 16:48:22< gfgtdf> vultraz: hmm if it not possible to fix it in lua without alot of code dublication then i'll do it in set_variable
20150107 16:50:27< vultraz> Nostromus: fix confirmed on master
20150107 16:56:25< irker456> wesnoth: gfgtdf wesnoth:1.12 dc4be12350ae / src/gui/dialogs/title_screen.cpp: fix segfault on hotkeys for titlescreen tips http://git.io/sepv8g
20150107 16:56:51< gfgtdf> vultraz: Nostromus backporte on master
20150107 16:56:54< gfgtdf> backported*
20150107 16:57:35< gfgtdf> ok i also tested that is it fixed
20150107 16:58:50< gfgtdf> on master i mean
20150107 17:00:57< Nostromus> i think i'll work on #23111 next.
20150107 17:03:37-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds]
20150107 17:05:16< gfgtdf> Nostromus: ok
20150107 17:06:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150107 17:06:27< gfgtdf> Nostromus: i just notices taht in pr 359 you forgot teh changelog and also didnt add yourself to the misc contrubutors in about.
20150107 17:07:31< Nostromus> gfgtdf: i#ll change this later
20150107 17:07:52< Nostromus> have to go
20150107 17:13:07-!- Nostromus [~chatzilla@g230249164.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141127110442]]
20150107 17:14:21-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150107 17:14:44-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150107 17:27:45-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150107 17:40:10-!- Coffee_irc [~david@ppp118-210-1-164.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20150107 17:41:52< gfgtdf> vultraz: you have an opinion about https://github.com/gfgtdf/wesnoth-old/commit/ac62e93cac813c9e13041266e5a5014f7f0de4f7 ?
20150107 17:50:06-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20150107 17:53:25-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150107 17:59:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150107 17:59:49-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 245 seconds]
20150107 18:01:10-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150107 18:12:03-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150107 18:28:37-!- travis-ci [~travis-ci@ec2-54-163-15-245.compute-1.amazonaws.com] has joined #wesnoth-dev
20150107 18:28:37< travis-ci> gfgtdf/wesnoth-old#408 (master - ac62e93 : gfgtdf): The build was broken.
20150107 18:28:37< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/46219732
20150107 18:28:37-!- travis-ci [~travis-ci@ec2-54-163-15-245.compute-1.amazonaws.com] has left #wesnoth-dev []
20150107 18:29:34-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150107 18:51:58-!- gfgtdf [~chatzilla@f054057089.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]]
20150107 19:01:57-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Ping timeout: 245 seconds]
20150107 19:03:20-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20150107 19:03:42< irker456> wesnoth: Chris Beck wesnoth:master 8459bf7104e6 / / (5 files in 4 dirs): add lua function "fire_wml_menu_item" and unit tests for menu items http://git.io/bSweCQ
20150107 19:03:44< irker456> wesnoth: Chris Beck wesnoth:master 2c6d4dacf72b / / (5 files in 4 dirs): Merge pull request #360 from cbeck88/menu_item_tests http://git.io/j8dijQ
20150107 19:04:04-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150107 19:08:22< irker456> wesnoth: Charles Dang wesnoth:master d9ef035bc02a / data/test/scenarios/test_menu_items.cfg: Ran wmlindent on the new unit test. Some formatting had to be manually fixed. http://git.io/veBEDA
20150107 19:13:49-!- travis-ci [~travis-ci@ec2-54-163-15-245.compute-1.amazonaws.com] has joined #wesnoth-dev
20150107 19:13:49< travis-ci> gfgtdf/wesnoth-old#409 (master - dfc5e2a : gfgtdf): The build has errored.
20150107 19:13:49< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/46225276
20150107 19:13:49-!- travis-ci [~travis-ci@ec2-54-163-15-245.compute-1.amazonaws.com] has left #wesnoth-dev []
20150107 19:16:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150107 19:21:14-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20150107 19:27:08-!- Haudegen [~quassel@85.124.51.57] has quit [Remote host closed the connection]
20150107 19:30:37< vultraz> gfgtdf: if you read logs, it looks like a good feature, but I think vwriter_init and vwriter_write should be named better
20150107 19:30:41-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150107 19:31:15< vultraz> I also think we've gotten enough util functions that we really should split them into a utils.lua file
20150107 19:39:44-!- renketsu0 [45f63b55@gateway/web/freenode/ip.69.246.59.85] has joined #wesnoth-dev
20150107 19:39:49-!- Haudegen [~quassel@85.124.51.57] has quit [Remote host closed the connection]
20150107 19:40:36< thunderstruck> gfgtdf: okay, I'll take a look
20150107 19:40:47-!- thunderstruck [~thunderst@cpc8-sgyl29-2-0-cust37.sgyl.cable.virginm.net] has quit [Quit: Leaving]
20150107 19:44:03< irker456> wesnoth: Charles Dang wesnoth:master 31b3090cf80e / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: T S1: merged 'Recruits' and 'New Recruits' lessons, and tweaked the product http://git.io/TSzt5A
20150107 19:50:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150107 20:04:33-!- OnkV [~quassel@85.124.51.57] has joined #wesnoth-dev
20150107 20:12:44-!- OnkV [~quassel@85.124.51.57] has quit [Ping timeout: 244 seconds]
20150107 20:14:42-!- OnkV [~quassel@85.124.51.57] has joined #wesnoth-dev
20150107 20:17:55-!- OnkV is now known as Haudegen
20150107 20:19:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150107 20:32:45-!- gfgtdf [~chatzilla@f054057089.adsl.alicedsl.de] has joined #wesnoth-dev
20150107 20:32:52< gfgtdf> vultraz: you know better names ?
20150107 20:51:04-!- kex [~kex@77.29.141.39] has quit [Remote host closed the connection]
20150107 20:58:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150107 21:14:10-!- Nostromus [~chatzilla@g230249164.adsl.alicedsl.de] has joined #wesnoth-dev
20150107 21:25:04< Nostromus> gfgtdf: Update the changelog for 1.12 and 1.13 or only 1.12 because it was backported?
20150107 21:33:15< gfgtdf> Nostromus: well we need it on 1.12 and on 1.13 but i can backport the changelog it if you only want to make one pr.
20150107 21:33:46-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev
20150107 21:34:25< Nostromus> gfgtdf: ok, i have no problem with 2 pr
20150107 21:49:20< gfgtdf> shadowm: 1.12.1 is still planned for jan 10?
20150107 21:51:09< shadowm> Do you see a string freeze in 1.12?
20150107 21:51:46< shadowm> There has to be a string freeze at least one week prior to tagging, and since that hasn't happened, well...
20150107 21:53:05< shadowm> I'm willing to work on it as soon as somebody says that those two bugs are fixed, and thus far I'm only aware of a partial fix for one from the other day, and a full fix for the other from today. That doesn't seem releasable to me. Does it to anyone else?
20150107 21:53:43-!- travis-ci [~travis-ci@ec2-54-163-15-245.compute-1.amazonaws.com] has joined #wesnoth-dev
20150107 21:53:43< travis-ci> gfgtdf/wesnoth-old#410 (master - a3b2c1c : gfgtdf): The build has errored.
20150107 21:53:43< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/46242559
20150107 21:53:43-!- travis-ci [~travis-ci@ec2-54-163-15-245.compute-1.amazonaws.com] has left #wesnoth-dev []
20150107 21:56:03< shadowm> This being the bug that's only partially fixed, according to you, in fact: https://gna.org/bugs/?22968
20150107 21:58:37< gfgtdf> shadowm: so your plan was first fixing the bugs and then do the string  freeze?
20150107 21:59:02< shadowm> Yes, in case somebody decides to introduce an error message or anything like that.
20150107 21:59:59< shadowm> The week after the freeze should also serve as a crucial testing window so any regressions are caught *before* releasing.
20150107 22:01:48-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Quit: DCW]
20150107 22:05:07< gfgtdf> shadowm: do you think we can add an "mp OOS debug mode" in 1.12 even if that will only work if all clients have 1.12.1 ?
20150107 22:08:14< shadowm> I don't know what that entails. Perhaps you could elaborate?
20150107 22:11:24< gfgtdf> shadowm: hm maybe i should try it for 1.13 first then then think about backport
20150107 22:12:11< shadowm> Anyway, the general rule is that anything that changes the WML/Lua API and server protocol is off-limits.
20150107 22:13:24< shadowm> Same for big internal changes since those are almost never without side effects.
20150107 22:13:27< nurupo> is wesnoth stll sdl 1.2?
20150107 22:13:30< shadowm> Yes.
20150107 22:13:34< nurupo> okay
20150107 22:14:53-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Quit: Off to save the world!]
20150107 22:32:45-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 244 seconds]
20150107 22:33:50-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150107 22:44:10-!- gfgtdf_ [~chatzilla@f054175227.adsl.alicedsl.de] has joined #wesnoth-dev
20150107 22:44:54-!- irker456 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150107 22:46:57-!- gfgtdf [~chatzilla@f054057089.adsl.alicedsl.de] has quit [Ping timeout: 245 seconds]
20150107 22:47:04-!- gfgtdf_ is now known as gfgtdf
20150107 22:53:07< Nostromus> gfgtdf: pull requests are online.
20150107 22:55:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150107 22:55:28< Nostromus> exists a list which dialogs are still gui and not gui2?
20150107 22:56:48-!- irker394 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150107 22:56:48< irker394> wesnoth: Michael Strebel wesnoth:master f4f25126bd0f / data/core/about.cfg: Add Michael Strebel to miscellaneous contributors. http://git.io/0Y4yYA
20150107 22:56:48< irker394> wesnoth: Michael Strebel wesnoth:master 50982cec5ba1 / changelog players_changelog: Updates changelog and player_changelog. http://git.io/XZqNqA
20150107 22:56:49< irker394> wesnoth: gfgtdf wesnoth:master 5067ecf932ff / changelog data/core/about.cfg players_changelog: Merge pull request #361 from mstrebel/changelog-1.13 http://git.io/4Fw8Iw
20150107 22:57:10< irker394> wesnoth: Michael Strebel wesnoth:1.12 385501697482 / changelog players_changelog: Update changelog and player_changelog. http://git.io/GjSZEw
20150107 22:57:12< irker394> wesnoth: Michael Strebel wesnoth:1.12 f46baf271191 / data/core/about.cfg: Add Michael Strebel to miscellaneous contributors. http://git.io/I5P2KA
20150107 22:57:14< irker394> wesnoth: gfgtdf wesnoth:1.12 8597e02377f5 / changelog data/core/about.cfg players_changelog: Merge pull request #362 from mstrebel/1.12 http://git.io/sPoX3Q
20150107 23:03:42-!- skyfaller [~skyfaller@pool-96-234-41-41.nwrknj.fios.verizon.net] has joined #wesnoth-dev
20150107 23:03:42-!- skyfaller [~skyfaller@pool-96-234-41-41.nwrknj.fios.verizon.net] has quit [Changing host]
20150107 23:03:42-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev
20150107 23:09:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150107 23:13:20-!- mjs-de [~mjs-de@g228137182.adsl.alicedsl.de] has quit [Remote host closed the connection]
20150107 23:16:57-!- PhaZ90771 [~PhaZ90771@c-24-13-158-17.hsd1.il.comcast.net] has quit [Ping timeout: 256 seconds]
20150107 23:18:08-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Quit: Sűrű sötét az éj, dühöng a déli szél]
20150107 23:20:24-!- PhaZ90771 [~PhaZ90771@c-24-13-158-17.hsd1.il.comcast.net] has joined #wesnoth-dev
20150107 23:38:19-!- oldlaptop [~quassel@50-108-82-79.adr01.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150107 23:39:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20150107 23:40:50-!- Nostromus [~chatzilla@g230249164.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141127110442]]
20150107 23:48:29-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150107 23:55:54-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
--- Log closed Thu Jan 08 00:00:30 2015