--- Log opened Sat Jan 10 00:00:10 2015 --- Day changed Sat Jan 10 2015 20150110 00:00:10< gfgtdf> zookeeper: and that happens hen you quit the game ? :o 20150110 00:01:02< zookeeper> the other player (my other client) quit the game, at which point i chose "replace with AI" and immediately closed the app window -> that assert happened 20150110 00:06:14-!- irker204 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20150110 00:14:19< gfgtdf> zookeeper: ok i was now also able to reproduce the illegal command by recruiting a unit after logging DSU on teh other client. 20150110 00:15:42< zookeeper> great 20150110 00:16:01< zookeeper> btw, i don't think it's wrong for the option to be available for toggling when it's not your turn 20150110 00:18:13< zookeeper> in fact IMO it _should_ be available even when it's not your turn. there's no reason not to, since your next turn will still start exactly the same way regardless of whether it's on or off. 20150110 00:20:29< gfgtdf> zookeeper: well it'd be rather complicated to enable and i see littel gain in it since one can easily toggle it at the end of teh last turn or at teh end of teh nexxt turn. 20150110 00:20:43< gfgtdf> at the start of teh nex turn* 20150110 00:28:50< zookeeper> sure, easily, if you still remember that you forgot it in the wrong position. 20150110 00:29:01< zookeeper> it's not a big deal if it's indeed complicated to allow 20150110 00:35:54-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20150110 00:41:44-!- TooLmaN [~TooLmaN@c-73-190-210-54.hsd1.ga.comcast.net] has quit [Quit: Off to save the world!] 20150110 00:49:50-!- mjs-de [~mjs-de@f049106084.adsl.alicedsl.de] has quit [Remote host closed the connection] 20150110 00:49:53-!- gfgtdf [~chatzilla@f054161115.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]] 20150110 00:57:08-!- irker482 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20150110 00:57:08< irker482> wesnoth: gfgtdf wesnoth:master 2a395fb75011 / src/hotkey_handler_sp.cpp: don't allow toggle shroud during enemies turn. http://git.io/4j2Vsw 20150110 00:57:12-!- gfgtdf [~chatzilla@f054161115.adsl.alicedsl.de] has joined #wesnoth-dev 20150110 00:57:25< gfgtdf> zookeeper: ^ 20150110 00:58:19< zookeeper> cool 20150110 00:59:48-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20150110 01:01:45< irker482> wesnoth: gfgtdf wesnoth:1.12 fd6ad6d46483 / src/playsingle_controller.cpp: don't allow toggle shroud during enemies turn. http://git.io/LIH-dw 20150110 01:11:42-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds] 20150110 01:23:37-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has quit [Quit: leaving] 20150110 01:33:19-!- travis-ci [~travis-ci@ec2-54-167-218-182.compute-1.amazonaws.com] has joined #wesnoth-dev 20150110 01:33:19< travis-ci> wesnoth/wesnoth#5487 (master - 2a395fb : gfgtdf): The build was broken. 20150110 01:33:19< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/46517882 20150110 01:33:19-!- travis-ci [~travis-ci@ec2-54-167-218-182.compute-1.amazonaws.com] has left #wesnoth-dev [] 20150110 01:39:45-!- prkc [~prkc@BC065B03.dsl.pool.telekom.hu] has quit [Remote host closed the connection] 20150110 01:46:45< gfgtdf> iceiceice: you know what's the differene between play_controller::current_side() and game_display::playing_team() ? 20150110 02:11:54< vultraz> iceiceice: the quit (esc) hotkey in the editor is still broken 20150110 02:31:14-!- gfgtdf [~chatzilla@f054161115.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]] 20150110 02:35:41-!- sachith500 [~kvirc@101.189.52.144] has quit [Ping timeout: 244 seconds] 20150110 02:43:45-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 244 seconds] 20150110 02:44:30-!- fabi [~quassel@p20030051AA150E38F9DF3DFA649715B1.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150110 02:44:33-!- fabi [~quassel@p20030051AA150E38F9DF3DFA649715B1.dip0.t-ipconnect.de] has quit [Changing host] 20150110 02:44:33-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20150110 02:48:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20150110 03:16:34-!- un214 [~un214@2602:306:cccf:a879:56a0:50ff:fe57:101d] has joined #wesnoth-dev 20150110 03:37:36-!- sachith500 [~kvirc@101.189.52.144] has joined #wesnoth-dev 20150110 03:43:52-!- TooLmaN [~TooLmaN@c-73-190-210-54.hsd1.ga.comcast.net] has joined #wesnoth-dev 20150110 03:56:40-!- Ivanovic_ [~ivanovic@frnk-5f74f1ed.pool.mediaWays.net] has joined #wesnoth-dev 20150110 03:59:31-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 256 seconds] 20150110 04:00:35-!- Ivanovic_ is now known as Ivanovic 20150110 04:00:44-!- un214 [~un214@2602:306:cccf:a879:56a0:50ff:fe57:101d] has quit [Remote host closed the connection] 20150110 04:01:56-!- irker482 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20150110 04:21:10-!- ancestral [~ancestral@247.sub-70-197-200.myvzw.com] has joined #wesnoth-dev 20150110 04:22:37-!- ancestral [~ancestral@247.sub-70-197-200.myvzw.com] has quit [Client Quit] 20150110 04:26:49-!- ancestral [~ancestral@247.sub-70-197-200.myvzw.com] has joined #wesnoth-dev 20150110 04:34:43-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.0.1] 20150110 04:46:54-!- Crendgrim_ [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev 20150110 04:47:41-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Ping timeout: 252 seconds] 20150110 04:51:31-!- ancestral [~ancestral@247.sub-70-197-200.myvzw.com] has quit [Quit: i go nstuf kthxbai] 20150110 05:17:21-!- Coffee_irc [~david@ppp118-210-1-164.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!] 20150110 05:31:05-!- TooLmaN [~TooLmaN@c-73-190-210-54.hsd1.ga.comcast.net] has quit [Quit: Off to save the world!] 20150110 05:44:49-!- Sulfur [~Miranda@p5B009EF7.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150110 05:45:14-!- fkhodkov [~user@vy2-188.istra.ru] has joined #wesnoth-dev 20150110 05:57:40-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20150110 06:12:21-!- Necrosporus_ is now known as Necrosporus 20150110 07:07:04< Necrosporus> What do you think about http://pastebin.com/etqK77wM such syntax for unit description? Would it be better or worse than existing? 20150110 07:56:47-!- Coffee_irc [~david@ppp118-210-1-164.lns20.adl2.internode.on.net] has joined #wesnoth-dev 20150110 07:59:27-!- Pepe_ [~ppjet@anderith.bouah.net] has quit [Ping timeout: 264 seconds] 20150110 08:00:42-!- sachith500 [~kvirc@101.189.52.144] has quit [Ping timeout: 245 seconds] 20150110 08:05:19-!- Ivanovic [~ivanovic@frnk-5f74f1ed.pool.mediaWays.net] has quit [Changing host] 20150110 08:05:19-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20150110 08:28:47-!- enchilado [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 252 seconds] 20150110 08:34:04-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev 20150110 08:42:13-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20150110 08:56:55-!- Sulfur [~Miranda@p5B009EF7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20150110 09:01:18-!- Ivanovic_ [~ivanovic@frnk-5f751e2f.pool.mediaWays.net] has joined #wesnoth-dev 20150110 09:01:26-!- Ivanovic_ [~ivanovic@frnk-5f751e2f.pool.mediaWays.net] has quit [Changing host] 20150110 09:01:26-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20150110 09:01:33-!- Ravana_ [SZ_Bot@27-83-235-80.dyn.estpak.ee] has quit [Ping timeout: 256 seconds] 20150110 09:01:47-!- SZ_Bot [SZ_Bot@27-83-235-80.dyn.estpak.ee] has joined #wesnoth-dev 20150110 09:01:47-!- SZ_Bot is now known as Ravana_ 20150110 09:03:04-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 264 seconds] 20150110 09:03:32-!- Ivanovic_ is now known as Ivanovic 20150110 09:04:52-!- irker649 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20150110 09:04:52< irker649> wesnoth: Nils Kneuper wesnoth:master 814acfaf7ce2 / po/ (wesnoth-l/ru.po wesnoth/ru.po): updated Russian translation http://git.io/6dbRGw 20150110 09:04:52< irker649> wesnoth: Nils Kneuper wesnoth:1.12 0764e0ac13c5 / changelog players_changelog po/wesnoth-l/ru.po po/wesnoth/ru.po: updated Russian translation http://git.io/BAmyIA 20150110 09:05:44-!- sachith500 [~kvirc@101.189.52.144] has joined #wesnoth-dev 20150110 09:25:00-!- cib0 [~cib@p5DD20F6E.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150110 09:25:39-!- Sulfur [~Miranda@p5B009EF7.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150110 09:34:37-!- cib0 [~cib@p5DD20F6E.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 20150110 09:43:37-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 245 seconds] 20150110 09:45:19-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev 20150110 09:50:19-!- travis-ci [~travis-ci@ec2-54-90-254-135.compute-1.amazonaws.com] has joined #wesnoth-dev 20150110 09:50:19< travis-ci> wesnoth/wesnoth#5489 (master - 814acfa : Nils Kneuper): The build was fixed. 20150110 09:50:19< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/46536198 20150110 09:50:19-!- travis-ci [~travis-ci@ec2-54-90-254-135.compute-1.amazonaws.com] has left #wesnoth-dev [] 20150110 09:53:45-!- atomicbomb [~atomicbom@202.67.34.248] has joined #wesnoth-dev 20150110 10:05:23-!- Duthlet [~Duthlet@wesnoth/mp-mod/Duthlet] has joined #wesnoth-dev 20150110 10:17:03-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20150110 10:20:37-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Client Quit] 20150110 10:20:39-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20150110 10:23:07-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20150110 10:33:22-!- atomicbomb [~atomicbom@202.67.34.248] has quit [Ping timeout: 240 seconds] 20150110 10:37:46-!- sachith500 [~kvirc@101.189.52.144] has quit [Ping timeout: 255 seconds] 20150110 10:39:57-!- cib0 [~cib@132.231.178.69] has joined #wesnoth-dev 20150110 10:48:17-!- atomicbomb [~atomicbom@202.67.35.1] has joined #wesnoth-dev 20150110 11:03:19-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev 20150110 11:08:30-!- atomicbomb [~atomicbom@202.67.35.1] has quit [Quit: Leaving] 20150110 11:12:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20150110 11:49:33-!- Sulfur [~Miranda@p5B009EF7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20150110 12:05:36-!- Pepe_ [~ppjet@anderith.bouah.net] has joined #wesnoth-dev 20150110 12:05:36-!- Pepe_ [~ppjet@anderith.bouah.net] has quit [Client Quit] 20150110 12:06:52-!- irker649 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20150110 12:07:30-!- Pepe_ [~ppjet@anderith.bouah.net] has joined #wesnoth-dev 20150110 12:13:00-!- Coffee_irc [~david@ppp118-210-1-164.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!] 20150110 12:41:32-!- Crendgrim_ is now known as Crendgrim 20150110 12:42:13-!- Sulfur [~Miranda@p5B009EF7.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150110 12:48:19-!- Sulfur [~Miranda@p5B009EF7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20150110 12:53:12-!- prkc [~prkc@BC065B03.dsl.pool.telekom.hu] has joined #wesnoth-dev 20150110 13:01:51-!- cib0 [~cib@132.231.178.69] has quit [Ping timeout: 264 seconds] 20150110 13:10:33-!- lipkab [~the_new_l@apn-185-10-127-200.vodafone.hu] has joined #wesnoth-dev 20150110 13:30:47-!- TooLmaN [~TooLmaN@c-73-190-210-54.hsd1.ga.comcast.net] has joined #wesnoth-dev 20150110 13:38:31-!- cib0 [~cib@132.231.178.20] has joined #wesnoth-dev 20150110 13:46:49-!- TooLmaN [~TooLmaN@c-73-190-210-54.hsd1.ga.comcast.net] has quit [Quit: Off to save the world!] 20150110 13:55:41-!- mjs-de [~mjs-de@f049135028.adsl.alicedsl.de] has joined #wesnoth-dev 20150110 14:00:27-!- TooLmaN [~TooLmaN@c-73-190-210-54.hsd1.ga.comcast.net] has joined #wesnoth-dev 20150110 14:05:54-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev 20150110 14:10:55-!- lipkab [~the_new_l@apn-185-10-127-200.vodafone.hu] has quit [Ping timeout: 244 seconds] 20150110 14:15:34-!- TooLmaN_ [~TooLmaN@c-73-190-210-54.hsd1.ga.comcast.net] has joined #wesnoth-dev 20150110 14:17:49-!- TooLmaN [~TooLmaN@c-73-190-210-54.hsd1.ga.comcast.net] has quit [Ping timeout: 255 seconds] 20150110 14:18:12-!- lipkab [~the_new_l@apn-185-10-127-200.vodafone.hu] has joined #wesnoth-dev 20150110 14:27:21< zookeeper> lipkab, i think the difference in our fog_datas is that eastern cavalryman of mine: i think my client's idea of my fog_data corresponds with what it would be if i had not moved the cavalryman there (because i had DSU on, perhaps?), and your client's idea of my fog_data is the correct one (that is, your client's idea of my fog_data is that much of the northeast corner has been cleared) 20150110 14:27:45-!- lipkab [~the_new_l@apn-185-10-127-200.vodafone.hu] has quit [Ping timeout: 265 seconds] 20150110 14:32:11-!- lipkab [~the_new_l@apn-185-10-127-200.vodafone.hu] has joined #wesnoth-dev 20150110 14:34:07-!- gfgtdf [~chatzilla@f054161115.adsl.alicedsl.de] has joined #wesnoth-dev 20150110 14:34:13< gfgtdf> zookeeper: you still get OOS ? 20150110 14:34:34< gfgtdf> zookeeper: after my commit i mean. 20150110 14:34:46< zookeeper> i don't know 20150110 14:36:26< gfgtdf> zookeeper: i asked becasue you talked about shroud data mismatch 20150110 14:37:49< zookeeper> yes, we made a manual save at the same time during lipkab's turn, and our saves differ in what they think my fog_data is like 20150110 14:38:19< gfgtdf> zookeeper: was this a new game the same game as yesterday ? 20150110 14:38:26< zookeeper> the original game yesterday 20150110 14:38:49< gfgtdf> zookeeper: ok, then probably i shouldnt worry, 20150110 14:38:58< gfgtdf> zookeeper: but shroud data mismatch is likeley to cause OOS. 20150110 14:42:36< zookeeper> oh, wait, the differing client opinion is about his fog_data, not mine. 20150110 14:43:05< gfgtdf> zookeeper: yes 20150110 14:43:22-!- cib0 [~cib@132.231.178.20] has quit [Ping timeout: 240 seconds] 20150110 14:44:07< gfgtdf> zookeeper: toggeling DSU always toggles it for teh currentyl plaing side, so if you toggle DSU while its not your turn you toggle it for hist side but only on your client. 20150110 14:44:20< zookeeper> ah 20150110 14:44:31-!- irker551 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20150110 14:44:31< irker551> wesnoth: gfgtdf wesnoth:1.12 7aaa9829a680 / changelog: Update changelog http://git.io/spGPLg 20150110 14:44:44< zookeeper> well, i guess that could explain all of it? 20150110 14:46:11< gfgtdf> zookeeper: what is "all of it" ? 20150110 14:46:28< zookeeper> all of the OOS we got 20150110 14:47:25< gfgtdf> zookeeper: i think yes. 20150110 14:48:10< zookeeper> i guess my client had DSU on for lipkab's side, so when he moved a unit and sighted my unit and his unit stopped and he moved it again, my client didn't understand why there was two moves because my client thought he didn't sight anything during the move? 20150110 14:49:00< zookeeper> but somehow the unit still ended up in the same place on both clients and there was no "real" OOS? 20150110 14:50:00< zookeeper> i dunno if that makes sense. i think his client would only send the first half of the move 20150110 14:50:11< zookeeper> and then the other, separately 20150110 14:50:13 * zookeeper shrugs 20150110 14:51:01< gfgtdf> zookeeper: no teh client sends teh full move even it was was not completed, and relies on teh other client to calculate teh destination correctly 20150110 14:51:12< zookeeper> really? okay then 20150110 14:51:13< gfgtdf> zookeeper: so yes it can happen exactl as you say. 20150110 14:51:18< zookeeper> cool 20150110 14:53:57< zookeeper> but doesn't that mean that my client would have always moved the unit to the original attempted destination and just ignored the extra moves he made after sighting my units? since he surely sometimes changed plans at that point, shouldn't we have ended up with our clients actually going OOS WRT unit positions? 20150110 14:54:10< zookeeper> or were we just really lucky and he always ended up moving to the original destination? 20150110 14:56:56< gfgtdf> zookeeper: my My guees would be that you were lucky 20150110 14:59:25-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20150110 14:59:41< zookeeper> right 20150110 15:02:35-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 244 seconds] 20150110 15:08:54-!- Sulfur [~Miranda@p5B009EF7.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150110 15:20:20-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20150110 15:24:42-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev 20150110 15:25:57-!- Necrosporus_ is now known as Necrosporus 20150110 15:31:30-!- lipkab [~the_new_l@apn-185-10-127-200.vodafone.hu] has quit [Ping timeout: 264 seconds] 20150110 15:45:57-!- lipkab [~the_new_l@apn-185-10-127-200.vodafone.hu] has joined #wesnoth-dev 20150110 16:02:03-!- cib0 [~cib@132.231.178.96] has joined #wesnoth-dev 20150110 16:05:44< zookeeper> what's with https://github.com/wesnoth/wesnoth/pull/365 ? not that i'm an expert, but "I would there were more I could do to help you" sounds perfectly legitimate to me 20150110 16:12:14< shadowm> The submitter doesn't know about 'would' as an archaic equivalent of 'to wish/desire/want', yes. 20150110 16:14:10-!- Sulfur [~Miranda@p5B009EF7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20150110 16:16:11< irker551> wesnoth: Ignacio R. Morelle wesnoth:master 277402966a05 / data/ai/ (ais/ai_default_rca_strong.cfg dev/akihara_recruitment.cfg): Remove inclusions of data/core/macros from data/ai http://git.io/Lw6zbQ 20150110 16:16:14< irker551> wesnoth: Ignacio R. Morelle wesnoth:master 61a7527a7119 / data/themes/ (8 files): Rename data/themes/macros.cfg and include it only once instead of 7 times http://git.io/8i3Chg 20150110 16:17:12< shadowm> mattsc: If you could verify that I didn't break some weird mode I didn't know about in commit 277402966a05... 20150110 16:23:52-!- lipkab [~the_new_l@apn-185-10-127-200.vodafone.hu] has quit [Ping timeout: 240 seconds] 20150110 16:31:07-!- cib0 [~cib@132.231.178.96] has quit [Ping timeout: 245 seconds] 20150110 16:41:44-!- lipkab [~the_new_l@apn-185-10-127-200.vodafone.hu] has joined #wesnoth-dev 20150110 16:54:41-!- travis-ci [~travis-ci@ec2-23-20-209-230.compute-1.amazonaws.com] has joined #wesnoth-dev 20150110 16:54:41< travis-ci> wesnoth/wesnoth#5492 (master - 61a7527 : Ignacio R. Morelle): The build has errored. 20150110 16:54:41< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/46559255 20150110 16:54:41-!- travis-ci [~travis-ci@ec2-23-20-209-230.compute-1.amazonaws.com] has left #wesnoth-dev [] 20150110 17:02:48< shadowm> master segfaults when attempting to load AtS E1. 20150110 17:03:51< shadowm> Before even displaying the storyscreen, and oddly enough that doesn't happen with E2, which also has a storyscreen. Hm. 20150110 17:07:08< shadowm> Just throwing this in here in case somebody needs to know, although I believe it's a known bug: https://gist.github.com/shikadilord/5f1a2fee91fb1c1fd377 20150110 17:10:58< shadowm> zookeeper: So what do you think of a warning about redefining macros? 20150110 17:11:56< zookeeper> shadowm, hrhm, i think i'd prefer no warning; it seems like a valid use of macros to for example redefine them locally 20150110 17:12:27< shadowm> In that case you can use #undef. 20150110 17:12:36< zookeeper> right 20150110 17:12:43< gfgtdf> shadowm: it maybe teh same bug as discusseed here: https://github.com/wesnoth/wesnoth/pull/364 which happen if you have a starting unit/leader (inside [side]) on a village hex. 20150110 17:13:06< shadowm> A prototype of the warning led me to discover those redundant inclusions in HEAD and HEAD^. 20150110 17:14:09< zookeeper> shadowm, considering that, yeah, i guess there could be a warning... stderr only or also an in-game message? 20150110 17:14:17< shadowm> Only stderr. 20150110 17:14:22< zookeeper> agreed, then 20150110 17:14:36< shadowm> Currently only EI, LoW, and UtBS produce warnings (didn't test all difficulties, only the defaults). 20150110 17:15:39< zookeeper> shadowm, i'm guessing you can't redefine a macro like this? 20150110 17:15:41< zookeeper> #define FOO 20150110 17:15:42< zookeeper> {FOO} # insert contents of previous definition 20150110 17:15:42< zookeeper> # append new stuff here 20150110 17:15:42< zookeeper> #enddef 20150110 17:15:43< shadowm> gfgtdf: I don't have any leaders on villages at the start of the scenario. 20150110 17:15:58< shadowm> zookeeper: I don't know, I've never tried. 20150110 17:16:19< zookeeper> i'm pretty sure i remember trying it once but no way i remember the result :p 20150110 17:16:21< shadowm> gfgtdf: Oh, other units perhaps. 20150110 17:16:27< zookeeper> ah well, i'll just try it quickly... 20150110 17:16:56< shadowm> Yeah, I have the one guy on a village. 20150110 17:17:36< shadowm> gfgtdf: Yeah, that's it. 20150110 17:18:20< shadowm> gfgtdf: But this PR hasn't been merged yet, has it? 20150110 17:18:35< gfgtdf> shadowm: no it hasnt 20150110 17:18:44< shadowm> Oh nvm further down you say it's not a bug from the PR. 20150110 17:19:00< zookeeper> shadowm, looks like it just results in an error: "Too much nested preprocessing inclusions" 20150110 17:19:34< shadowm> Oh yes, now I remember your proposal served as the ultimate test case for a resource starvation bug. 20150110 17:19:40< zookeeper> that is, it goes into infinite recursion or something like that and then hits the limit 20150110 17:22:22< shadowm> The last time I touched UtBS people died, so I'd rather not try to investigate this: http://pastebin.com/G5sEhqzN 20150110 17:23:07< lipkab> *insert fanfares here* https://www.dropbox.com/s/g3kcrsf0xf5gs3s/wesstats.png?dl=0 20150110 17:24:43-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev 20150110 17:26:21< shadowm> Yeah, inefficient reinclusions. 20150110 17:26:58< shadowm> http://pastebin.com/YNjVJYVJ 20150110 17:27:39< shadowm> And of course that file is already included from _main.cfg along with the rest of the utils dir. 20150110 17:29:14< shadowm> All I wanted to do was detect terrain graphics macro redefinitions in my own campaign. 20150110 17:30:03< Necrosporus> What are that stats, lipkab ? 20150110 17:30:54< lipkab> Necrosporus: I'm working a utility that can import data from replays to an SQL database. 20150110 17:31:16< lipkab> That stuff is the first result. 20150110 17:31:26< lipkab> *on a utility 20150110 17:32:18< Necrosporus> So you are trying to calculate how often people play specific scenario 20150110 17:32:33< shadowm> Okay, deaths.cfg is needed in every scenario. 20150110 17:32:34< Necrosporus> I wonder what happens if you do not allow observers 20150110 17:32:39-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20150110 17:32:51< Necrosporus> replays are not saved 20150110 17:32:59< Necrosporus> but what about statistics? 20150110 17:33:09< shadowm> Aaaaaaaand uses macros to give the file some "state". 20150110 17:33:45< lipkab> Necrosporus: Oh no, I don't care how often people play each map. 20150110 17:33:54< lipkab> That's just a demonstration. 20150110 17:34:09< shadowm> dehydration-utils.cfg is evil and includes an event handler directly. 20150110 17:34:15< zookeeper> shadowm, yeah, well, i guess the most common case of redefinition is when a utils file is included for its events... 20150110 17:34:19< shadowm> If [event] worked at top level we'd have problems. 20150110 17:34:24< lipkab> This database stores other stuff as well. 20150110 17:34:42< lipkab> Recruits, battles... 20150110 17:34:47< shadowm> And I wanted to look into making [event] work at top level, so... 20150110 17:34:57< zookeeper> shadowm, if you want me to split the file (or whatever i find the best method) then sure i can, but don't be afraid of touching it yourself :P 20150110 17:35:15< shadowm> kaleh-abilities.cfg is evil too. 20150110 17:35:34< zookeeper> remember, people only die if you break something, so just don't break anything and everything will be fine :> 20150110 17:35:41< lipkab> Obviously I can't analyse those replays that aren't saved, but we still have a lot of data. 20150110 17:35:47< shadowm> terrain.cfg and terrain_graphics.cfg too. 20150110 17:36:04< shadowm> I suppose half of the problem is that I come from "utils is for macros only" land. 20150110 17:36:51< Necrosporus> And for multiplayers. Players still prefer 1.10.7 seems they say 1.12.0 is buggy. I wonder if developers have tried to play 1.12.0 multiplayer especially campaigns 20150110 17:37:00< shadowm> Okay, looking at it from a different perspective, dialog-macros.cfg does not need to be reincluded. 20150110 17:38:52< Necrosporus> What's the problem with macros? If some utils contain event maybe it's better to make another dir for them like eventutils and include files from under there from specific scenarios but not from _main.cfg? 20150110 17:39:36< Necrosporus> eventutils/death.cfg 20150110 17:39:38< Necrosporus> like that 20150110 17:39:40< shadowm> Your question sucks. 20150110 17:39:51-!- prkc [~prkc@BC065B03.dsl.pool.telekom.hu] has quit [Remote host closed the connection] 20150110 17:39:54< Necrosporus> Which one? 20150110 17:39:56< shadowm> I never said there was a "problem with macros". 20150110 17:40:50< shadowm> 20150110 14:40:29 warning config: Redefining macro HYDRATING_TILES at campaigns/Under_the_Burning_Suns/utils/dehydration-utils.cfg:4 20150110 17:41:14< shadowm> So yeah, not sure if perhaps I should demote the warning to info. 20150110 17:41:33< shadowm> Or just keep it to myself, that also works. 20150110 17:42:59< irker551> wesnoth: Ignacio R. Morelle wesnoth:master e8650ac872ba / data/campaigns/Under_the_Burning_Suns/scenarios/ (6 files): UtBS: Drop redundant reinclusions of utils/dialog-macros.cfg http://git.io/B4OsOw 20150110 17:44:06< shadowm> For that matter, someone's decision to add the Fall schedule to core means my add-on also generates warnings and I'm not too sure I want to dignify that decision with #undefs. 20150110 17:45:53< Necrosporus> shadowm, I never said you said there was problem with macros. Anyway you mention problem of double inclusion. Do you think solution I proposed won't help? 20150110 17:46:00< shadowm> And now that I've made sure I don't have any terrain graphics duplicates, I can go back to my original mission of trying to make a terrain work. 20150110 17:46:15-!- cib0 [~cib@p5DD20F6E.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150110 17:47:44-!- lipkab [~the_new_l@apn-185-10-127-200.vodafone.hu] has quit [Ping timeout: 245 seconds] 20150110 17:50:29-!- Sulfur [~Miranda@p5B009EF7.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150110 17:54:27< Necrosporus> shadowm, ok other question. Are there any problems with UtBS in mainline? 20150110 17:54:55< shadowm> UtBS has been in mainline since version 1.1.2. 20150110 17:55:43< Necrosporus> I know 20150110 18:00:39< zookeeper> yes, there are 20150110 18:02:40< shadowm> Okay here's the literal interpretation of the question then: yes, just like with every other thing in mainline, there are problems; people usually call them "bugs" and we've got a tracker full of them. 20150110 18:06:01-!- gfgtdf [~chatzilla@f054161115.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]] 20150110 18:10:34-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 265 seconds] 20150110 18:21:51-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev 20150110 18:23:19-!- trewe [~trewe@bl20-35-26.dsl.telepac.pt] has joined #wesnoth-dev 20150110 18:23:38-!- lipkab [~the_new_l@apn-185-10-127-200.vodafone.hu] has joined #wesnoth-dev 20150110 18:25:45-!- travis-ci [~travis-ci@ec2-54-198-2-185.compute-1.amazonaws.com] has joined #wesnoth-dev 20150110 18:25:45< travis-ci> wesnoth/wesnoth#5493 (master - e8650ac : Ignacio R. Morelle): The build passed. 20150110 18:25:45< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/46565267 20150110 18:25:45-!- travis-ci [~travis-ci@ec2-54-198-2-185.compute-1.amazonaws.com] has left #wesnoth-dev [] 20150110 19:04:26-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Remote host closed the connection] 20150110 19:07:07-!- lipkab [~the_new_l@apn-185-10-127-200.vodafone.hu] has quit [Ping timeout: 265 seconds] 20150110 19:08:13-!- lipkab [~the_new_l@94.248.175.96] has joined #wesnoth-dev 20150110 19:31:41-!- cib0 [~cib@p5DD20F6E.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 20150110 19:36:15-!- cib0 [~cib@p5DD20F6E.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150110 19:55:44-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 0.4.2] 20150110 20:05:51-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20150110 20:05:52-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host] 20150110 20:05:52-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20150110 20:11:40-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Remote host closed the connection] 20150110 20:15:44-!- Rhonda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev 20150110 20:22:27< irker551> wesnoth: Chris Beck wesnoth:master 776a2e70fcc6 / changelog: update changelog http://git.io/KOyujg 20150110 20:39:47-!- cib0 [~cib@p5DD20F6E.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20150110 20:39:58-!- lipkab [~the_new_l@94.248.175.96] has quit [Ping timeout: 244 seconds] 20150110 20:50:21-!- Sulfur [~Miranda@p5B009EF7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20150110 20:56:25< irker551> wesnoth: Elias Pschernig wesnoth:master 5a599b935bb6 / data/tools/unit_tree/html_output.py: [units.wesnoth.org] fix race links http://git.io/H4g_Jw 20150110 21:09:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds] 20150110 21:12:15-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev 20150110 21:26:13-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Ping timeout: 264 seconds] 20150110 21:28:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20150110 21:29:12-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev 20150110 21:34:18-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai] 20150110 21:40:30-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has joined #wesnoth-dev 20150110 21:41:37-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev 20150110 22:15:38-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20150110 22:22:26< mattsc> shadowm: I vaguely remember something from a long time ago that macros weren’t defined yet by the time an AI configuration file was included, but I just did a whole bunch of tests both in MP and SP and that does not seem to be that case any more. 20150110 22:23:22< mattsc> So your commit doesn’t cause any problems, AFAICT, and not including macros twice is definitely a good thing. 20150110 22:26:35-!- Toocan [~elektron@c-174-61-60-225.hsd1.fl.comcast.net] has joined #wesnoth-dev 20150110 22:29:57< mattsc> Oh, I think I know what it was … 20150110 22:30:18< mattsc> Testing … 20150110 22:39:36< mattsc> shadowm: Okay, so there is a problem after all. If you start an AI game from the commandline like this: http://pastebin.com/TFfLxiS4 20150110 22:40:13< mattsc> Then the macros are not defined and the game exits with a “macro missing” error. 20150110 22:41:12< mattsc> Now, I am not sure what the best way to deal with this is. Not including the macros twice would be nice, but I am not sure how easily doable that is. 20150110 22:41:34< mattsc> At the very least though, we should not include all macros, but only core/macros/ai_candidate_actions.cfg 20150110 22:55:12-!- mjs-de [~mjs-de@f049135028.adsl.alicedsl.de] has quit [Remote host closed the connection] 20150110 23:02:42-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 264 seconds] 20150110 23:05:36-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev 20150110 23:50:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Hibernating of sorts; will check logs and forum PMs] 20150110 23:54:57-!- trewe [~trewe@bl20-35-26.dsl.telepac.pt] has quit [Quit: quit] 20150110 23:55:34-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Remote host closed the connection] 20150110 23:56:37-!- fkhodkov [~user@vy2-188.istra.ru] has quit [Quit: ERC Version 5.3 (IRC client for Emacs)] 20150110 23:57:10-!- irker551 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] --- Log closed Sun Jan 11 00:00:02 2015