--- Log opened Wed Jan 14 00:00:44 2015
20150114 00:02:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds]
20150114 00:06:51-!- Pepe__ [~ppjet@anderith.bouah.net] has joined #wesnoth-dev
20150114 00:09:21-!- Pepe_ [~ppjet@anderith.bouah.net] has quit [Ping timeout: 264 seconds]
20150114 00:09:22-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Ping timeout: 264 seconds]
20150114 00:11:20-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150114 00:53:25-!- new_one [~new_one@128.42.74.249] has joined #wesnoth-dev
20150114 00:58:06-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150114 01:06:29-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150114 01:36:37-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20150114 01:39:23-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150114 02:02:47-!- new_one [~new_one@128.42.74.249] has quit [Ping timeout: 245 seconds]
20150114 02:08:50-!- new_one [~new_one@128.42.74.249] has joined #wesnoth-dev
20150114 02:24:01-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20150114 02:26:57-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150114 02:34:20-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev
20150114 02:48:15-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-uncuhnismcgzabfj] has quit [Ping timeout: 265 seconds]
20150114 02:48:44-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds]
20150114 02:50:09-!- fabi [~quassel@p4FDB85C8.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150114 02:50:09-!- fabi [~quassel@p4FDB85C8.dip0.t-ipconnect.de] has quit [Changing host]
20150114 02:50:09-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150114 02:54:06-!- irker968 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150114 02:54:06< irker968> wesnoth: gfgtdf wesnoth:master 2e875d66f636 / src/synced_commands.cpp: add a comment http://git.io/mYIpHw
20150114 02:54:50-!- gfgtdf [~chatzilla@f054151204.adsl.alicedsl.de] has joined #wesnoth-dev
20150114 02:55:45< gfgtdf> hi
20150114 02:55:52< gfgtdf> currently, in networked mp the attackers client chooses the defenders weapon for retaliation.
20150114 02:56:25< gfgtdf> i wonder whether we should change it into that the defender chooses his weapon for retaliation.
20150114 02:56:51< gfgtdf> the drawback would be that the attacker would have to wait for the defenders client to choose a weapon
20150114 02:57:10< shadowm> :(
20150114 02:57:13< gfgtdf> ofc the is no user input involved so it would go fast.
20150114 02:57:46< shadowm> That's assuming a low latency connection.
20150114 02:57:56< gfgtdf> shadowm: yes
20150114 02:58:04-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-punswmvnkedqtwju] has joined #wesnoth-dev
20150114 02:58:19< gfgtdf> especially it yould make per-mail gameing if something like that was planned more or less impossible
20150114 02:58:27-!- matthiaskrgr is now known as Guest53380
20150114 02:59:06< shadowm> I didn't quite get that, but okay.
20150114 02:59:37< shadowm> I'm just uncomfortable with Wesnoth progressively becoming less playable for me over the Internet.
20150114 02:59:57< gfgtdf> the drawback of the current implementation is that is might allow cheats if you attack a unit that has multiple weapons available tor retaliation. making teh defener choose the weaker one
20150114 03:00:25< shadowm> There are a lot of other ways to cheat.
20150114 03:01:08< gfgtdf> shadowm: maybe i allow the deterministic mode for mp, whihc would sure result inless netowrk traffic since we don't have to aks teh server for a rng
20150114 03:01:16< gfgtdf> maybe i shoudl allow*
20150114 03:01:34< shadowm> I honestly can't see why somebody would be so obsessed with winning that they'd go to such lengths to alter Wesnoth's attack code.
20150114 03:01:44< gfgtdf> shadowm: the drawback if yof that you could use cheats to know in advance what the result of teh attacks would be
20150114 03:02:51< gfgtdf> the drawback of determnistic mode in mp i mean
20150114 03:03:13< gfgtdf> maybe we can add a message to only use it agains trustworthy opponents.
20150114 03:04:10< shadowm> I didn't expect the deterministic mode thing to come up in this conversation. I've stated my opinion on the matter before, that it's an unnecessary complexity that shouldn't be under the player's control.
20150114 03:05:12-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20150114 03:05:27< gfgtdf> shadowm: it was an offer since since you stated that you had problems  due to bad internet connection.
20150114 03:06:31< shadowm> My opinion doesn't really count since I don't play MP regularly, I guess. 
20150114 03:07:29< shadowm> But really, most of the time for mainline units you have only one weapon with the same range available.
20150114 03:08:02-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150114 03:09:21< shadowm> When there is one, the "weaker" alternative usually has some catch, e.g. the Druid's entangle attack vs. her thorns attack.
20150114 03:11:24< gfgtdf> shadowm: i though most often they just have different damagetypes, like the melee attack of that drake , or the ranged attack of orkish bowman.
20150114 03:13:04< shadowm> Yes, that is a fact.
20150114 03:18:36-!- Ivanovic_ [~ivanovic@frnk-5f74f90a.pool.mediaWays.net] has joined #wesnoth-dev
20150114 03:21:28-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 244 seconds]
20150114 03:22:31-!- Ivanovic_ is now known as Ivanovic
20150114 03:27:56-!- gfgtdf [~chatzilla@f054151204.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 34.0/20141125180439]]
20150114 03:33:24-!- travis-ci [~travis-ci@ec2-54-163-33-161.compute-1.amazonaws.com] has joined #wesnoth-dev
20150114 03:33:24< travis-ci> wesnoth/wesnoth#5519 (master - 2e875d6 : gfgtdf): The build passed.
20150114 03:33:24< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/46939284
20150114 03:33:24-!- travis-ci [~travis-ci@ec2-54-163-33-161.compute-1.amazonaws.com] has left #wesnoth-dev []
20150114 03:40:34-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has quit [Read error: Connection reset by peer]
20150114 03:41:03-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev
20150114 03:46:34< vultraz> wesnoth y u crash D:
20150114 03:48:58< vultraz> ah yes
20150114 03:49:14< vultraz> it's this 'initializing unit on village' crash
20150114 03:49:20< vultraz> :(
20150114 04:18:59-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20150114 04:21:44-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150114 04:40:42-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20150114 04:46:43-!- new_one [~new_one@128.42.74.249] has quit [Quit: WeeChat 1.1]
20150114 04:53:52-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20150114 04:56:37-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150114 05:12:03-!- oldlaptop [~quassel@50-108-82-79.adr01.mskg.mi.frontiernet.net] has quit [Ping timeout: 245 seconds]
20150114 05:22:27-!- oldlaptop [~quassel@50-108-82-79.adr01.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150114 05:35:20-!- sachith500 [~kvirc@101.189.13.219] has joined #wesnoth-dev
20150114 05:39:53-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20150114 05:42:38-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150114 05:54:17-!- irker968 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150114 05:55:30-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20150114 05:56:54-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has joined #wesnoth-dev
20150114 05:58:21-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150114 05:58:27-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has quit [Remote host closed the connection]
20150114 06:08:44-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150114 06:16:43-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has quit [Quit: well im out... later.]
20150114 06:18:43-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev
20150114 06:34:34-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20150114 06:36:22-!- sachith500 [~kvirc@101.189.13.219] has quit [Ping timeout: 264 seconds]
20150114 06:37:33-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150114 06:39:42-!- irker208 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150114 06:39:42< irker208> wesnoth: Charles Dang wesnoth:master 66e17ca94802 / data/core/units/undead/Necro_Dark_Adept.cfg: Fixed indent in Dark Adept description http://git.io/c4dJFA
20150114 06:45:00-!- sachith500 [~kvirc@101.189.13.219] has joined #wesnoth-dev
20150114 06:54:41-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20150114 06:55:05-!- ancientcc [~ancientcc@123.157.77.141] has joined #wesnoth-dev
20150114 06:57:30-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150114 07:01:19-!- Ivanovic [~ivanovic@frnk-5f74f90a.pool.mediaWays.net] has quit [Changing host]
20150114 07:01:19-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20150114 07:12:56-!- cib0 [~cib@p5DD20284.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150114 07:15:47-!- sachith500 [~kvirc@101.189.13.219] has quit [Ping timeout: 252 seconds]
20150114 07:31:42-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20150114 07:32:34-!- cib0 [~cib@p5DD20284.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds]
20150114 07:34:38-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150114 07:58:12-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 245 seconds]
20150114 08:00:16-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150114 08:14:19-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150114 08:19:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150114 08:35:14-!- cib0 [~cib@132.231.178.215] has joined #wesnoth-dev
20150114 08:52:55-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 255 seconds]
20150114 08:55:14-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150114 08:56:05-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150114 08:57:35-!- sachith500 [~kvirc@101.189.13.219] has joined #wesnoth-dev
20150114 09:01:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20150114 09:04:29-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150114 09:06:22-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds]
20150114 09:14:40-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20150114 09:16:07-!- cib0 [~cib@132.231.178.215] has quit [Ping timeout: 245 seconds]
20150114 09:17:51-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150114 09:27:28-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150114 09:35:20-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has joined #wesnoth-dev
20150114 09:36:47-!- Guest53380 [matthiaskr@gateway/shell/panicbnc/x-punswmvnkedqtwju] has quit [Changing host]
20150114 09:36:47-!- Guest53380 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20150114 09:36:47-!- Guest53380 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20150114 09:36:47-!- Guest53380 [matthiaskr@gateway/shell/panicbnc/x-punswmvnkedqtwju] has joined #wesnoth-dev
20150114 09:36:54-!- Guest53380 is now known as matthiaskrgr
20150114 09:37:37-!- ancientcc [~ancientcc@123.157.77.141] has quit []
20150114 09:40:03-!- irker208 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150114 09:43:51-!- oldlaptop [~quassel@50-108-82-79.adr01.mskg.mi.frontiernet.net] has quit [Ping timeout: 264 seconds]
20150114 09:52:48-!- oldlaptop [~quassel@50-108-82-79.adr01.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150114 09:54:14-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20150114 09:57:22-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150114 10:19:19-!- enchilado [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 255 seconds]
20150114 10:23:05-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20150114 10:27:02-!- Ard0nik [~user@adsl-75-28-96-211.dsl.irvnca.sbcglobal.net] has quit [Read error: Connection reset by peer]
20150114 10:27:42-!- Ardonik [~user@adsl-75-28-96-211.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20150114 10:58:27-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 256 seconds]
20150114 11:00:46-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150114 11:21:45-!- Elvish_Hunter [9710a486@gateway/web/freenode/ip.151.16.164.134] has joined #wesnoth-dev
20150114 11:22:00< Elvish_Hunter> Hi all
20150114 11:22:30< vultraz> hi
20150114 11:23:22-!- kex [~kex@46.217.86.114] has joined #wesnoth-dev
20150114 11:23:34-!- irker483 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150114 11:23:34< irker483> wesnoth: Elvish_Hunter wesnoth:master 6c47130adf97 / changelog src/scripting/lua_kernel_base.cpp: Lua: enabled support for the bit32 (bitwise operations) library http://git.io/LP_pSQ
20150114 11:24:09< Elvish_Hunter> So if someone needs to do a bitwise operation in Lua, now it's possible.
20150114 11:29:52 * vultraz doesn't know what that is
20150114 11:32:45< vultraz> hm, iceiceice isn't around
20150114 11:33:30-!- kex [~kex@46.217.86.114] has quit [Remote host closed the connection]
20150114 11:34:42< Elvish_Hunter> vultraz: basically, with this library numbers are handled as sequences of 1 and 0. It's quite technical and of a limited use for the casual programmer.
20150114 11:35:19< Elvish_Hunter> But in certain situations it may be useful to have it - especially considering that it was added to core Lua in version 5.2.
20150114 11:36:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150114 11:37:53< vultraz> I see
20150114 11:50:02< Elvish_Hunter> Well, now I have to go. Bye!
20150114 11:50:06< vultraz> bye
20150114 11:50:08-!- Elvish_Hunter [9710a486@gateway/web/freenode/ip.151.16.164.134] has quit [Quit: Ciao!]
20150114 11:59:20-!- kex [~kex@46.217.86.114] has joined #wesnoth-dev
20150114 12:03:11-!- cib0 [~cib@132.231.178.12] has joined #wesnoth-dev
20150114 12:04:10-!- kex [~kex@46.217.86.114] has quit [Ping timeout: 255 seconds]
20150114 12:07:59-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev
20150114 12:08:58-!- kex [~kex@46.217.86.114] has joined #wesnoth-dev
20150114 12:09:49-!- cib0 [~cib@132.231.178.12] has quit [Ping timeout: 244 seconds]
20150114 12:11:08-!- DCW [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Client Quit]
20150114 12:18:22-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds]
20150114 12:24:50-!- Sulfur [~Miranda@p5B009DA6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150114 12:35:13-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150114 12:45:21-!- sachith500 [~kvirc@101.189.13.219] has quit [Read error: Connection reset by peer]
20150114 12:49:10-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 255 seconds]
20150114 12:57:33-!- Ard0nik [~user@adsl-75-28-99-19.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20150114 13:00:53-!- Ardonik [~user@adsl-75-28-96-211.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 255 seconds]
20150114 13:01:40-!- boucman_work [~jrosen@247.37.0.109.rev.sfr.net] has joined #wesnoth-dev
20150114 13:01:40-!- boucman_work [~jrosen@247.37.0.109.rev.sfr.net] has quit [Changing host]
20150114 13:01:40-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150114 13:13:01-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev
20150114 13:14:57-!- cib0 [~cib@132.231.178.219] has joined #wesnoth-dev
20150114 13:35:20-!- mjs-de [~mjs-de@f049135235.adsl.alicedsl.de] has joined #wesnoth-dev
20150114 13:52:14-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150114 13:58:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150114 13:59:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150114 14:10:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150114 14:21:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150114 14:23:46-!- irker483 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150114 14:54:45< vultraz> shadowm: is it alright if I make [store_locations
20150114 14:54:53< vultraz> exclude border hexes by default
20150114 14:55:05< vultraz> or should I keep the current behavior 
20150114 14:55:11< vultraz> (always include)
20150114 14:57:35< zookeeper> good heavens, don't change the default behavior of a tag like that
20150114 15:01:03< vultraz> hm, good point
20150114 15:01:42< vultraz> syntax question... *googles*
20150114 15:02:25< vultraz> (only reason I asked was syntax wise, it would be shortest to just make the default false, and im lazy :P )
20150114 15:03:46-!- cib0 [~cib@132.231.178.219] has quit [Read error: Connection reset by peer]
20150114 15:06:39-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150114 15:15:39< vultraz> I'm slightly embarrassed I can't make this work right :/
20150114 15:18:42-!- DCW1 [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has joined #wesnoth-dev
20150114 15:20:52-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150114 15:24:49< vultraz> zookeeper: should I name the key include_borders= or exclude_borders=
20150114 15:25:13< vultraz> (include_border=no or exclude_border=yes)
20150114 15:25:17< zookeeper> why not just border=?
20150114 15:27:02< zookeeper> anyway, if i had to choose from those two i'd prefer include_border
20150114 15:27:33< vultraz> yeah, same
20150114 15:27:41< vultraz> but I feel like a noobish coder that I can't make this check work >_>
20150114 15:28:04< vultraz> I can apparently make checks for negative keys with positive values but not the other way around
20150114 15:33:22< vultraz> maybe uh..
20150114 15:33:24< vultraz> I dunno
20150114 15:33:26< vultraz> :/
20150114 15:40:08< vultraz> ok this works
20150114 15:40:12< vultraz> but it seems hacky
20150114 15:41:39-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Ping timeout: 244 seconds]
20150114 15:41:58-!- Pepe__ is now known as Pepe_
20150114 15:43:49< vultraz> shadowm: can you tell me if there's any better way to do this http://pastebin.com/K61Pk5QE
20150114 15:55:41< vultraz> shadowm: to clarify, that does achieve expected behavior, but is it the only way
20150114 15:57:41-!- new_one [~new_one@128.42.68.242] has joined #wesnoth-dev
20150114 16:02:13-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 255 seconds]
20150114 16:04:53-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150114 16:15:02-!- Kexoth [~kex@46.217.83.51] has joined #wesnoth-dev
20150114 16:15:53-!- DCW1 [~Thunderbi@cpc66866-finc15-2-0-cust47.4-2.cable.virginm.net] has quit [Remote host closed the connection]
20150114 16:16:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150114 16:17:00-!- kex [~kex@46.217.86.114] has quit [Ping timeout: 244 seconds]
20150114 16:19:04< Soliton> vultraz: !filter["include_borders"].empty()  is that supposed to check whether the key is there at all?
20150114 16:19:43< vultraz> yes
20150114 16:19:50< Soliton> vultraz: IIRC we have a has_attribute() or so function. note that with the above you will insert the key unless filter is const.
20150114 16:20:48< Soliton> even easier is giving to_bool() a default which it supports i believe.
20150114 16:21:55< Soliton> so: bool with_borders = filter["include_borders"].to_bool(true);
20150114 16:26:03< Soliton> alternative: bool with_borders = !filter.has_attribute("include_borders") || filter["include_borders"].to_bool();
20150114 16:27:07-!- gfgtdf [~chatzilla@e177155110.adsl.alicedsl.de] has joined #wesnoth-dev
20150114 16:27:13< gfgtdf> to_bool(true) is what you should use
20150114 16:27:30< vultraz> the first one works 
20150114 16:27:32< vultraz> thanks :D
20150114 16:27:39< Soliton> that still leaves the issue of inserting the key though.
20150114 16:27:56< Soliton> but if filter is const or it doesn't matter that's fine.
20150114 16:28:18-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150114 16:28:45< vultraz> filter is a vconfig but not const. I don't think it matters though.
20150114 16:32:29< gfgtdf> Soliton: it inserts teh key but it gives it the "blank" value. Afaik most code shoudl treat "blank value just liek an nonexistent key."
20150114 16:32:52< gfgtdf> "blank value" just like an nonexistent key.*
20150114 16:35:44-!- irker800 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150114 16:35:44< irker800> wesnoth: Charles Dang wesnoth:master 63891c77a1c3 / src/scripting/game_lua_kernel.cpp: Allow location storing to exclude borders by passing cfg.include_borders=false http://git.io/ONZtqQ
20150114 16:38:00-!- thunderstruck [~thunderst@cpc8-sgyl29-2-0-cust37.sgyl.cable.virginm.net] has joined #wesnoth-dev
20150114 16:38:12< thunderstruck> gfgtdf, Hi
20150114 16:38:23< thunderstruck> gfgtdf, It looks that you fixed http://gna.org/bugs/?22968
20150114 16:38:40< thunderstruck> gfgtdf, and looking at the code it makes sense too
20150114 16:39:18< thunderstruck> gfgtdf, while testing it, I noticed that scenario name is missing in games list for reloaded game. Did you notice that too?
20150114 16:40:10< irker800> wesnoth: Charles Dang wesnoth:master 4e8bdfba405c / data/campaigns/Northern_Rebirth/utils/herodeaths.cfg: Use new include_borders=no key for a simpler fix to bug #22097 http://git.io/CLY3dQ
20150114 16:40:59< gfgtdf> thunderstruck: no i didnt is this on 1.12 or on 1.13 or both ?
20150114 16:43:21< vultraz> shadowm:  I seem to recall there was another instance that could make use of that? ^
20150114 16:44:12< vultraz> I'm also not sure where to document this on the wiki, under SLF in general or under [store_location]?
20150114 16:44:21< vultraz> s
20150114 16:45:26< thunderstruck> gfgtdf, 1.12. Haven't checked 1.13
20150114 16:45:39< thunderstruck> gfgtdf, Maybe it's my test campaign. I'll check it later.
20150114 16:47:15-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150114 16:47:46-!- new_one [~new_one@128.42.68.242] has quit [Remote host closed the connection]
20150114 16:52:05-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev
20150114 16:54:39< zookeeper> vultraz, under whichever on it is specific to?
20150114 16:54:45< zookeeper> -on
20150114 16:55:11< vultraz> well wesnoth.get_locations() is used in several tags
20150114 16:55:19< vultraz> so technically it would work in all of them
20150114 16:56:32< vultraz> [store_locations] [terrain] [capture_village] [floating_text] [find_path] [scroll_to] 
20150114 16:56:49< zookeeper> under each one, then
20150114 16:59:41< irker800> wesnoth: gfgtdf wesnoth:master 97971f1fb21a / src/actions/move.cpp: remove a parameter that was always NULL. http://git.io/Ha_0Yg
20150114 17:00:53< vultraz> also [item] [remove_item] [store_items]. hm,. yeah, it isn't under every tag that uses SLFs, though
20150114 17:01:45 * vultraz makes note to ask iceiceice something
20150114 17:01:52< gfgtdf> vultraz: why not impementing it directly in SLF ?
20150114 17:03:49< vultraz> what, in filter::get_locations?
20150114 17:04:08< gfgtdf> yes.
20150114 17:06:01< vultraz> well...that function takes a bool for borders and a set of locations. I'm not sure how you would pass a config key to it
20150114 17:06:40< gfgtdf> vultraz: teh terrain filter object has aalready teh config, you pass it in the terrain_filters constructor
20150114 17:07:53< gfgtdf> vultraz: in teh case of wesnoth.get_locations in the line "const terrain_filter t_filter(filter, &fc);"
20150114 17:08:39< vultraz> the problem is that some function want to pass a border bool explicitly 
20150114 17:08:57< gfgtdf> vultraz: yes you dont need to remobe that boolean parameter
20150114 17:08:58< vultraz> so I guess uh
20150114 17:09:01< gfgtdf> remove*
20150114 17:09:40< gfgtdf> vultraz: you could for  example use teh passed boolean parameter as default that can be overwritten with include_borders config attribute
20150114 17:11:11< vultraz> so something like with_border = cfg_["include_borders"].to_bool(with_border)?
20150114 17:11:21< gfgtdf> vultraz: yes
20150114 17:14:27-!- [Relic] [~Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20150114 17:16:23< vultraz> so should game_lua_kernel::intf_get_locations then pass the with_border bool as true like before, since the overwrite would happen in terrain_filter::get_locations ?
20150114 17:17:56-!- Kexoth [~kex@46.217.83.51] has quit [Remote host closed the connection]
20150114 17:19:01< gfgtdf> vultraz: that was just an idea, if omething like "include_borders" it not needed at other places then we can just leave it that way, but what would be bad is that then someone else add a similar key somewhere else in teh code that uses terrain filters so that in the end it's called "include_borders" in one place and "borders" in another.
20150114 17:19:59< vultraz> so you're suggesting it be added to SLFs directly to prevent future duplication?
20150114 17:23:08< vultraz> ok, I tested, it works
20150114 17:23:25-!- travis-ci [~travis-ci@ec2-54-160-204-185.compute-1.amazonaws.com] has joined #wesnoth-dev
20150114 17:23:25< travis-ci> wesnoth/wesnoth#5522 (master - 63891c7 : Charles Dang): The build was broken.
20150114 17:23:25< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/47005230
20150114 17:23:25-!- travis-ci [~travis-ci@ec2-54-160-204-185.compute-1.amazonaws.com] has left #wesnoth-dev []
20150114 17:28:42< irker800> wesnoth: Charles Dang wesnoth:master ac42e5e2281e / src/ (scripting/game_lua_kernel.cpp terrain_filter.cpp): Elevate 63891c77a1c3 to work in all SLFs http://git.io/Kn8qIQ
20150114 17:29:09< gfgtdf> vultraz: the correctest  solution would be checking whether it makes sense to have it in the other places that use terrain_filter and decide whether we put in in terrain_filter after that.
20150114 17:29:27-!- cib0 [~cib@p5DD238DD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150114 17:32:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150114 17:33:02 * vultraz off
20150114 17:55:13< gfgtdf> shadowm: you have an opinion on https://github.com/wesnoth/wesnoth/pull/370 ?
20150114 18:09:37-!- cib0 [~cib@p5DD238DD.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20150114 18:16:07-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150114 18:38:28-!- travis-ci [~travis-ci@ec2-54-90-218-28.compute-1.amazonaws.com] has joined #wesnoth-dev
20150114 18:38:28< travis-ci> gfgtdf/wesnoth-old#415 (parser_blank - c1c3f12 : gfgtdf): The build passed.
20150114 18:38:28< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/47014976
20150114 18:38:28-!- travis-ci [~travis-ci@ec2-54-90-218-28.compute-1.amazonaws.com] has left #wesnoth-dev []
20150114 19:13:50-!- travis-ci [~travis-ci@ec2-54-160-204-185.compute-1.amazonaws.com] has joined #wesnoth-dev
20150114 19:13:50< travis-ci> wesnoth/wesnoth#5525 (master - ac42e5e : Charles Dang): The build was fixed.
20150114 19:13:50< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/47011833
20150114 19:13:50-!- travis-ci [~travis-ci@ec2-54-160-204-185.compute-1.amazonaws.com] has left #wesnoth-dev []
20150114 19:17:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150114 19:53:27-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150114 19:56:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150114 20:01:40-!- thunderstruck [~thunderst@cpc8-sgyl29-2-0-cust37.sgyl.cable.virginm.net] has quit [Quit: Leaving]
20150114 20:06:39-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 264 seconds]
20150114 20:08:45-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20150114 20:19:45-!- new_one [~new_one@128.42.75.175] has joined #wesnoth-dev
20150114 20:20:25< shadowm> vultraz: Re http://pastebin.com/K61Pk5QE
20150114 20:20:51< shadowm> vultraz: `const bool with_borders = filter["include_borders"].to_bool(true);`
20150114 20:21:05< shadowm> vultraz: Hopefully you can guess why.
20150114 20:21:12< vultraz> I already got that
20150114 20:22:24< shadowm> vultraz: As Soliton said, this will create the attribute in filter if it doesn't exist already, unless filter is const.
20150114 20:25:13< shadowm> gfgtdf: This is bad, actually. I'm pretty sure there are several places (either in C++ or core Lua or UMC Lua) that rely on the distinction between empty and missing attributes.
20150114 20:26:16< vultraz> shadowm: is there anything wrong with my commits? I tested them thoroughly 
20150114 20:26:25< shadowm> I haven't looked at your commits.
20150114 20:29:11-!- irker800 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150114 20:29:57< gfgtdf> shadowm: what do you mena by empty attributes? note that blank attributes are not the same as empty string
20150114 20:30:15< shadowm> foo=  foo=""
20150114 20:30:36< gfgtdf> shadowm: foo= and foo="" is both empty string
20150114 20:30:44< gfgtdf> afaik.
20150114 20:31:13< shadowm> vultraz: Your latest commit breaks the terrain_filter::get_location() method's intended protocol.
20150114 20:31:24< shadowm> gfgtdf: Then what do you mean by blank?
20150114 20:31:27< vultraz> how so?
20150114 20:31:45< gfgtdf> the boost::blank value of the attribute value
20150114 20:31:47< shadowm> vultraz: The method's signature specifies a bool with_border parameter.
20150114 20:31:59< vultraz> yes
20150114 20:32:08< vultraz> that is still provided
20150114 20:32:23< shadowm> Except its value is no longer used.
20150114 20:32:29< gfgtdf> shadowm: it is
20150114 20:32:50< shadowm> Okay, here's the signature: `void get_locations(std::set<map_location>& locs, bool with_border=false) const;`
20150114 20:32:58-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150114 20:33:03< shadowm> Note that with_border is an optional argument and defaults to `false`.
20150114 20:33:35< shadowm> With your commit, its value (whichever it is) is replaced immediately by the WML attribute's value (or default value) regardless of how the function was called.
20150114 20:33:50< gfgtdf> shadowmbut teh default value is the passed value
20150114 20:34:01< vultraz> ^
20150114 20:34:03< shadowm> This means that the caller is now forced to add the attribute to the WML object if it wants to change the method's behavior.
20150114 20:34:03< vultraz> what he said
20150114 20:34:24< vultraz> and I tested this. it works correctly.
20150114 20:34:54< shadowm> Okay, I didn't notice to_bool()'s argument was with_border. I assumed you copy-pasted your previous code, my bad.
20150114 20:35:11< vultraz> No, I did not copy-paste
20150114 20:35:21< vultraz> Really, I'm not THAT bad
20150114 20:35:44< shadowm> Remember that time you stole my code and I had to give you a hint to fix it?
20150114 20:36:03< vultraz> That was different
20150114 20:36:24< shadowm> It's not that different, in that case you also missed the surrounding context. :p
20150114 20:36:54< vultraz> whatever
20150114 20:37:09< shadowm> Is there any instance where the get_locations() caller might specifically want to specify with_order and not let it be overridden with the WML attribute's value?
20150114 20:37:35-!- cib0 [~cib@p5DD238DD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150114 20:37:54< vultraz> not that I know of
20150114 20:38:05< shadowm> i.e. did you check other callers?
20150114 20:38:15< shadowm> gfgtdf: I don't know what this `boost::blank` thing is.
20150114 20:38:45< shadowm> Is it how we represent attributes that do not exist?
20150114 20:39:04< vultraz> I'm looking at a list of them
20150114 20:39:11< gfgtdf> shadowm: boost blank values are sutomaticly created when you use teh [] operator like in cfg["a"], if no value "a" exists then an blank attribute a is created and returned
20150114 20:39:39< gfgtdf> are creates when the key doesn't exist yet i mean.
20150114 20:39:58< vultraz> nothing besides action wml, really
20150114 20:40:13< vultraz> , even passes a different argument besides false
20150114 20:41:00< vultraz> now, I could have sworn you showed me two cases where this could be of use
20150114 20:41:04< vultraz> I found one in NR
20150114 20:41:08< vultraz> but I can't find the other
20150114 20:41:16< shadowm> gfgtdf: Okay, so there is otherwise no way for WML (the WML parser) to create a 'blank' value, right?
20150114 20:41:37< shadowm> vultraz: I mentioned the other here.
20150114 20:42:29< shadowm> Am I supposed to grep my own logs for you?
20150114 20:43:05< vultraz> I think I can find it
20150114 20:43:22< vultraz> I remember now you mentioned it on uh
20150114 20:43:27< vultraz> when I committed that hasty commit
20150114 20:43:28< shadowm> gfgtdf: Since #23131 purportedly never affected a release, you should close it now that it's marked as fixed.
20150114 20:43:37< shadowm> vultraz: https://github.com/wesnoth/wesnoth/commit/982d868b944482cceeb5d18e2fd42afa916e0a32
20150114 20:44:27< gfgtdf> shadowm: it didnt check teh parser deply but at least i know that sttribute_value::operator= (std::string) will never create a blank attribute
20150114 20:44:29< vultraz> thanks
20150114 20:48:12-!- irker921 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150114 20:48:12< irker921> wesnoth: Charles Dang wesnoth:master 72e67eee93fe / data/core/macros/utils.cfg: Used include_borders=no in SCATTER_UNITS http://git.io/h62FbA
20150114 20:49:24< shadowm> vultraz: Re https://github.com/wesnoth/wesnoth/commit/4e8bdfba405cef75b50bf396670ab33387b5d96a, why didn't you remove `respawn_map` from the CLEAR_VARIABLE list?
20150114 20:49:52< vultraz> missed it
20150114 20:49:59< vultraz> can you or should I?
20150114 20:50:22< shadowm> I suspect you are closer to your clone than I am.
20150114 20:52:44< irker921> wesnoth: Charles Dang wesnoth:master 74ecf9094a0d / data/campaigns/Northern_Rebirth/utils/herodeaths.cfg: Fixup 4e8bdfba405c, forgot to clear the map dimensions variable http://git.io/4kUFTg
20150114 20:57:50< zookeeper> lipkab, still want to attempt revenge? :>
20150114 20:58:09< zookeeper> remember, you can pick both factions if you want
20150114 20:58:37< zookeeper> well... as long as you don't pick khalifate, drakes or loyalists for me :P
20150114 21:00:53-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Ping timeout: 272 seconds]
20150114 21:07:08-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has joined #wesnoth-dev
20150114 21:10:14< gfgtdf> shikadibot: seen mattsc
20150114 21:10:14< shikadibot> gfgtdf: The person with the nick mattsc last spoke 3d 2h ago.  2d 23h ago was here and on the channel #wesnoth-umc-dev with the message: Quit: Hibernating of sorts; will check logs and forum PMs
20150114 21:11:07< gfgtdf> mattsc: you know about the synced_command ai action
20150114 21:11:26< gfgtdf> ?
20150114 21:11:58< gfgtdf> mattsc: hm forget it was not important
20150114 21:19:54-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev
20150114 21:30:18< irker921> wesnoth: Charles Dang wesnoth:master 886a7f005c55 / data/campaigns/tutorial/ (maps/02_Tutorial_part_2.map scenarios/02_Tutorial_part_2.cfg utils/utils.cfg): T S2: revamp/rewrite part 3 http://git.io/udOQhA
20150114 21:33:08-!- Sulfur [~Miranda@p5B009DA6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150114 22:07:31< gfgtdf> vultraz: is there a reason why we check for traits/type to know whether the unit is about to adanv instead of comarting to max_experience?
20150114 22:07:42< gfgtdf> vultraz: in your last commit i mean.
20150114 22:08:02-!- ToBeCloud [uid51591@gateway/web/irccloud.com/x-vhykrwdflxjktatu] has joined #wesnoth-dev
20150114 22:09:15< gfgtdf> about to advance*
20150114 22:10:31-!- cib0 [~cib@p5DD238DD.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
20150114 22:14:29< gfgtdf> comparing*
20150114 22:16:02-!- new_one [~new_one@128.42.75.175] has quit [Quit: WeeChat 1.1]
20150114 22:16:52< shadowm> Since 1.5.x or so max_experience reflects the actual maximum XP for the unit taking all that information into account, so there shouldn't be a need to do all those convoluted checks.
20150114 22:17:36-!- new_one [~new_one@128.42.98.225] has joined #wesnoth-dev
20150114 22:19:26< gfgtdf> shadowm: so the reason is that before it didnt +code beeing very old ?
20150114 22:20:11< shadowm> Yeah, at least IIRC. Our current tutorial dates from 1.1.x.
20150114 22:21:05-!- gfgtdf_ [~chatzilla@d223206.adsl.hansenet.de] has joined #wesnoth-dev
20150114 22:24:11-!- gfgtdf [~chatzilla@e177155110.adsl.alicedsl.de] has quit [Ping timeout: 265 seconds]
20150114 22:24:16-!- gfgtdf_ is now known as gfgtdf
20150114 22:25:01-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150114 22:33:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20150114 22:37:21-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev
20150114 22:40:19-!- Ardonik [~user@adsl-75-28-97-135.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20150114 22:43:15-!- Ard0nik [~user@adsl-75-28-99-19.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 264 seconds]
20150114 22:47:05-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150114 23:03:48-!- localuser- [~none@gateway/tor-sasl/localuser-] has joined #wesnoth-dev
20150114 23:04:00-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev
20150114 23:04:31-!- Pepe_ [~ppjet@anderith.bouah.net] has quit [Quit: leaving]
20150114 23:04:59-!- Pepe_ [~ppjet@anderith.bouah.net] has joined #wesnoth-dev
20150114 23:14:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150114 23:19:00-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150114 23:22:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150114 23:23:19-!- lipkab [~the_new_l@host-91-147-212-169.biatv.hu] has quit [Quit: Sűrű sötét az éj, dühöng a déli szél]
20150114 23:23:19-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150114 23:26:02-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150114 23:26:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20150114 23:34:34-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150114 23:42:51-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev
20150114 23:52:06< irker921> wesnoth: gfgtdf wesnoth:master b67c5fdeecdd / data/campaigns/tutorial/utils/utils.cfg: don't calculate max_experience manually http://git.io/Fpduaw
20150114 23:56:38< gfgtdf> shadowm: i just noticed that in the savefile it is greater_than="$($defender.max_experience-8)" while in the original wml it is greater_than=$(${NAME}.max_experience - 8) is it normal that spaces in the middle are removed?
--- Log closed Thu Jan 15 00:00:00 2015