--- Log opened Wed Jan 28 00:01:01 2015
20150128 00:02:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20150128 00:08:59-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20150128 00:10:40-!- Appleman1234 [~Appleman1@s77.BMT-e1.vectant.ne.jp] has joined #wesnoth-dev
20150128 00:13:35-!- cjhopman [cjhopman@nat/google/x-jwwppgrvcfhnlbke] has joined #wesnoth-dev
20150128 00:22:54-!- skyfaller [~skyfaller@pool-72-76-132-209.nwrknj.fios.verizon.net] has joined #wesnoth-dev
20150128 00:22:54-!- skyfaller [~skyfaller@pool-72-76-132-209.nwrknj.fios.verizon.net] has quit [Changing host]
20150128 00:22:54-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev
20150128 00:25:47-!- mjs-de [~mjs-de@f049145214.adsl.alicedsl.de] has quit [Ping timeout: 256 seconds]
20150128 00:30:33-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit []
20150128 00:35:48-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150128 01:24:11-!- renketsu0 [~renketsu0@2601:4:e80:121:646a:1e4:ef4:733b] has joined #wesnoth-dev
20150128 01:26:42-!- prkc [~prkc@51B7AE0A.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20150128 01:40:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20150128 01:43:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150128 01:49:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds]
20150128 01:55:31-!- Crendgrim_ is now known as Crendgrim
20150128 02:35:06-!- irker246 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150128 02:35:06< irker246> wesnoth: aquileia wesnoth:master a694169330b8 / / (22 files in 9 dirs): Port NR tracks to the AOI bigmap http://git.io/F8hC
20150128 02:35:06< irker246> wesnoth: aquileia wesnoth:master f8bd6789422c / data/campaigns/Northern_Rebirth/ (7 files in 2 dirs): NR: Fix story formatting by using speech macros everywhere http://git.io/F8hW
20150128 02:35:06< irker246> wesnoth: aquileia wesnoth:master 1c822c075f2d / data/campaigns/Northern_Rebirth/scenarios/10a_Stolen_Gold.cfg: NR: Simplify conversation before S10 http://git.io/F8hl
20150128 02:35:07< irker246> wesnoth: aquileia wesnoth:master bc1b5caccc68 / data/campaigns/Legend_of_Wesmere/ (9 files in 4 dirs): LoW: Fix track of chapters 3-5 http://git.io/F8h8
20150128 02:35:08< irker246> wesnoth: aquileia wesnoth:master c67326e0f793 / / (32 files in 13 dirs): Merge pull request #372 from aquileia/bigmap_macro http://git.io/F8h4
20150128 02:56:55-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20150128 03:02:49-!- Ivanovic_ [~ivanovic@frnk-5f750ba6.pool.mediaWays.net] has joined #wesnoth-dev
20150128 03:05:29-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds]
20150128 03:05:38-!- fabi [~quassel@p20030051AA5D9C03BDCF1C1E0F3C7F6C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150128 03:05:38-!- fabi [~quassel@p20030051AA5D9C03BDCF1C1E0F3C7F6C.dip0.t-ipconnect.de] has quit [Changing host]
20150128 03:05:38-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150128 03:06:09-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds]
20150128 03:06:43-!- Ivanovic_ is now known as Ivanovic
20150128 03:10:15-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Quit: Page closed]
20150128 03:13:11-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 276 seconds]
20150128 03:40:54< shadowm> aquileia: No, you understood wrong. The last message should be moved to the hidden forum, not reported.
20150128 03:41:48< shadowm> It makes no difference to me, but the purpose of moving the post is that people can't see it.
20150128 03:46:44-!- renketsu0 [~renketsu0@2601:4:e80:121:646a:1e4:ef4:733b] has quit [Quit: Leaving]
20150128 04:06:45-!- Sulfur [~Miranda@p5B009AE3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150128 04:25:39-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Remote host closed the connection]
20150128 04:26:18-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20150128 04:44:28-!- renketsu0_ [45f63b55@gateway/web/freenode/ip.69.246.59.85] has joined #wesnoth-dev
20150128 04:45:08< renketsu0_> I'm having trouble compiling from linux mint
20150128 04:45:47< renketsu0_> I installed all the dependencies but I can't for the life of me seem to get png and jpg support in sdl_image
20150128 04:46:48< renketsu0_> I've tried the bugfix here http://hg.libsdl.org/SDL_image/rev/2b0ada991468 and compiled it from source
20150128 04:47:11< renketsu0_> I'm not sure I pointed to the libraries correctly though
20150128 04:48:02< renketsu0_> I used sdldir=/usr/local with scons but it still didn't find png or jpg support
20150128 04:48:24< renketsu0_> does anybody have any experience with resolving this problem?
20150128 04:56:36-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Quit: No Ping reply in 180 seconds.]
20150128 04:57:02-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20150128 05:26:00< vultraz> Not that I know of
20150128 05:35:22-!- irker246 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150128 06:19:34< renketsu0_> if anybody has anything that may help jist post it anyway. I'll check the logs later
20150128 06:19:39-!- renketsu0_ [45f63b55@gateway/web/freenode/ip.69.246.59.85] has quit [Quit: Page closed]
20150128 06:36:03-!- oldlaptop [~quassel@50-108-82-79.adr01.mskg.mi.frontiernet.net] has quit [Ping timeout: 264 seconds]
20150128 06:37:54-!- oldlaptop [~quassel@50-108-82-79.adr01.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150128 06:45:22-!- Ivanovic [~ivanovic@frnk-5f750ba6.pool.mediaWays.net] has quit [Changing host]
20150128 06:45:22-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20150128 07:01:21-!- [Relic] [~Relic]@2602:306:33a3:6d30:2111:5107:f4df:7c12] has quit [Quit: Leaving]
20150128 07:35:20-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 246 seconds]
20150128 07:39:23< Rhonda> Hmmm
20150128 07:40:01< Rhonda> About http://bugs.debian.org/775153 - why is wmlxgettext in utils/ and not in the tools directory?
20150128 07:45:02-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150128 07:48:11-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20150128 07:48:11-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Changing host]
20150128 07:48:11-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150128 08:05:46< vultraz> no idea, the former should probably replace the latter
20150128 08:28:31< Rhonda> vultraz: Yes, that's what the later script says, but I thought the tools directory is meant for people working on campaigns and stuff, and now it's mixed into different directories.
20150128 08:38:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150128 09:20:20< vultraz> Rhonda: yeah, it is
20150128 09:21:00< vultraz> I guess it should either be reorganized or merged
20150128 09:28:54< Rhonda> Guess it might not have been intentionally be placed in the wrong directory.
20150128 09:36:31-!- irker962 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150128 09:36:31< irker962> wesnoth: Charles Dang wesnoth:master 8c92d1e62a4c / data/core/macros/objective-utils.cfg: Added several new objective macros http://git.io/FBEh
20150128 09:42:24 * vultraz mentally kicks espreon for deprecating similar macros 5 years ago
20150128 09:43:13< zookeeper> ehh
20150128 09:43:15< zookeeper> why are you adding those?
20150128 09:45:11< vultraz> Why not?
20150128 09:46:15< zookeeper> because you'll get mentally kicked if you start converting mainline objectives to use those :p
20150128 09:46:26< zookeeper> and if you don't, then they serve no purpose except bloat
20150128 09:47:04< Soliton> Sulfur: yes, that's automatically generated. if the unit files don't show some (story related?) reason why one type can't advance as usual then that is not possible to depict there.
20150128 09:52:09< zookeeper> vultraz, macros like that were specifically removed because i/we wanted to get rid of piles of macros that serve no purpose to act as "nice syntactic shortcuts just in case someone wants to use them somewhere"
20150128 09:52:16< zookeeper> +except
20150128 09:53:55< zookeeper> we could add a shortcut macro for every tag there is
20150128 09:55:05< zookeeper> but we shouldn't; UMC authors are perfectly capable of writing and using their own macros if they want to shave off a few lines from their objectives, and in mainline we should minimize macro use because macros make code harder to read and understand, not easier
20150128 09:56:38< Soliton> #define TAG NAME CONTENT  [{NAME}]  {CONTENT}  [/{NAME}]  #enddef
20150128 09:56:45< zookeeper> D:
20150128 09:59:54< vultraz> In which case macros like TRANSFORM_UNIT, QUANTITY, *_MUSIC, MESSAGE (this is a huge offender), should also be removed
20150128 10:00:39< zookeeper> macros should be used mainly for shortening very common and trivial operations (such as VARIABLE) or for non-trivial or hard-to-recall operations (such as TRANSFORM_UNIT) or for things that are established and everyone's already using them (QUANTITY)
20150128 10:01:18< zookeeper> although yes, TRANSFORM_UNIT is simple now that there's a dedicated tag for it
20150128 10:01:33< zookeeper> it used to be a hacky store/unstore thing, IIRC
20150128 10:02:00< vultraz> Yes
20150128 10:02:50< zookeeper> and yes, MESSAGE shouldn't ever be put in
20150128 10:03:18< vultraz> so, should I revert that, and should we deprecate MESSAGE 
20150128 10:03:57< zookeeper> i'd say please revert, but since anonymissimus specifically reverted the commit which deprecated MESSAGE, i'd like to know the reasoning first.
20150128 10:04:34< zookeeper> ...first before deprecating MESSAGE again, that is, not before reverting the objectives stuff
20150128 10:05:23< vultraz> alright.
20150128 10:06:13< zookeeper> most of this stuff dates from i don't even remember when, when someone dumped piles of shortcut macros like that in, and they only got cleaned away much later (mostly by espreon, i think)
20150128 10:06:58< vultraz> heh, looks like sotbe has #{MESSAGE narrator "" "" "New scorpion at: $scorpion_locs[$random].x $scorpion_locs[$random].y"}
20150128 10:07:03< vultraz> commented out, of course
20150128 10:07:39< irker962> wesnoth: Charles Dang wesnoth:master 19826fa564a4 / data/core/macros/objective-utils.cfg: Revert "Added several new objective macros" on request http://git.io/FBKn
20150128 10:07:40< zookeeper> of course espreon then always wanted to actually remove the deprecated macros too soon so i wasn't completely happy with that either :P
20150128 10:08:33< vultraz> weird that anon reverted his own commit
20150128 10:09:13< zookeeper> how's that weird? you do it all the time :>
20150128 10:09:30< vultraz> . . . . . . . . . touche
20150128 10:09:59< zookeeper> thanks, i'll be here all night
20150128 10:11:21< vultraz> speaking of deprecation...why do so many of the campaigns have these        
20150128 10:11:22< vultraz>         # {SCATTER_IMAGE (terrain=Gg) 20 scenery/pine1.png}
20150128 10:11:24< vultraz>         # {SCATTER_IMAGE (terrain=Gs^Fp) 12 scenery/oak-leaning.png}
20150128 10:11:25< vultraz> in prestart
20150128 10:12:09< zookeeper> some esr thing
20150128 10:12:26< vultraz> should it be removed or reinstated
20150128 10:12:32< zookeeper> if you want to do something about then, then remove
20150128 10:12:59< zookeeper> they might have been commented out simply because they didn't look good
20150128 10:16:04< zookeeper> and in some cases because the same map is visited twice and the randomization would end up being different
20150128 10:16:50< vultraz> Hm, there's one case in DiD I think should be put back
20150128 10:16:58< vultraz> {SCATTER_IMAGE (terrain=Gg) 3 scenery/snowbits.png} in S4
20150128 10:19:09< vultraz> I'll have to test that, though
20150128 10:19:13< zookeeper> if it actually looks good, then s... yeah
20150128 10:21:36< zookeeper> but then again i'd rather have that sort of thing be done by the snow actually gradually melting during the scenario :p or by hand-placed bits, not just unreliable random scattering
20150128 10:24:50< vultraz> point taken, they might all end together and look bad
20150128 10:25:11< vultraz> I'll just add a todo about maybe adding them by hand
20150128 10:44:25-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 264 seconds]
20150128 10:48:16-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150128 11:13:49-!- Ard0nik [~user@adsl-75-28-96-122.dsl.irvnca.sbcglobal.net] has joined #wesnoth-dev
20150128 11:17:22-!- Ardonik [~user@adsl-75-28-96-182.dsl.irvnca.sbcglobal.net] has quit [Ping timeout: 255 seconds]
20150128 11:20:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150128 11:25:00< irker962> wesnoth: Charles Dang wesnoth:master e25fafe9496d / data/campaigns/ (48 files in 8 dirs): All campaigns: removed all commented out SCATTER_IMAGE cases http://git.io/FRvM
20150128 11:41:36-!- kex [~kex@77.28.26.247] has joined #wesnoth-dev
20150128 11:48:46< irker962> wesnoth: Charles Dang wesnoth:master 2b5db572e6fd / data/campaigns/ (3 files in 2 dirs): Removed some comments from e25fafe9496d that have been deemed unnecessary http://git.io/FRL8
20150128 11:59:59< irker962> wesnoth: Charles Dang wesnoth:master 788e5d9dbea7 / data/campaigns/Descent_Into_Darkness/maps/ (7 files): DiD: saved all maps in new format http://git.io/FRYY
20150128 12:00:03< irker962> wesnoth: Charles Dang wesnoth:master f7557ede4bff / data/campaigns/The_Hammer_of_Thursagan/maps/ (10 files): THoT: saved all maps in new format http://git.io/FRYO
20150128 12:06:05-!- Sulfur [~Miranda@p5B009AE3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150128 12:07:33< irker962> wesnoth: Charles Dang wesnoth:master 8f55612ff2e5 / data/core/macros/scenario-utils.cfg: Used new map format for NO_MAP_DATA http://git.io/FR3K
20150128 12:09:55-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-98.wireless.uva.nl] has joined #wesnoth-dev
20150128 12:24:04-!- Sulfur [~Miranda@p5B009AE3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150128 12:56:22-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-98.wireless.uva.nl] has quit [Ping timeout: 255 seconds]
20150128 13:01:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150128 13:03:08-!- lipkab [~the_new_l@host-91-147-211-47.biatv.hu] has joined #wesnoth-dev
20150128 13:06:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150128 13:30:23-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-98.wireless.uva.nl] has joined #wesnoth-dev
20150128 13:36:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150128 13:37:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150128 13:57:49-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-98.wireless.uva.nl] has quit [Ping timeout: 256 seconds]
20150128 14:03:01-!- mjs-de [~mjs-de@f049112242.adsl.alicedsl.de] has joined #wesnoth-dev
20150128 14:04:23-!- Kexoth [~kex@77.28.29.245] has joined #wesnoth-dev
20150128 14:06:53-!- kex [~kex@77.28.26.247] has quit [Ping timeout: 256 seconds]
20150128 14:12:53-!- AI0867 [~ai@wesnoth/developer/ai0867] has quit [Remote host closed the connection]
20150128 14:12:53-!- shadowm [~ignacio@wesnoth/developer/shadowm] has quit [Remote host closed the connection]
20150128 14:12:53-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has quit [Remote host closed the connection]
20150128 14:12:53-!- irker962 [~irker@uruz.ai0867.net] has quit [Read error: Connection reset by peer]
20150128 14:13:16-!- shadowm [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150128 14:13:18-!- AI0867 [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev
20150128 14:13:19-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20150128 14:13:52-!- bumbadadabum [~bumbadada@wcw-stud-145-109-10-135.wireless.uva.nl] has joined #wesnoth-dev
20150128 14:21:25-!- lipkab [~the_new_l@host-91-147-211-47.biatv.hu] has quit [Ping timeout: 255 seconds]
20150128 14:29:34-!- prkc [~prkc@51B7AE0A.dsl.pool.telekom.hu] has joined #wesnoth-dev
20150128 14:36:02-!- Sulfur [~Miranda@p5B009AE3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150128 14:49:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150128 14:56:52-!- AI0867_ [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev
20150128 14:57:27-!- AI0867 [~ai@wesnoth/developer/ai0867] has quit [Disconnected by services]
20150128 14:57:34-!- AI0867_ is now known as AI0867
20150128 15:04:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150128 15:10:17-!- lipkab [~the_new_l@host-91-147-211-47.biatv.hu] has joined #wesnoth-dev
20150128 15:11:14-!- Sulfur [~Miranda@p5B009AE3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150128 15:24:41-!- lipkab [~the_new_l@host-91-147-211-47.biatv.hu] has quit [Ping timeout: 246 seconds]
20150128 15:42:00-!- bumbadadabum [~bumbadada@wcw-stud-145-109-10-135.wireless.uva.nl] has quit [Ping timeout: 276 seconds]
20150128 15:54:34-!- [Relic] [~Relic]@2602:306:33a3:6d30:7dc7:d02e:d4c2:1a9a] has joined #wesnoth-dev
20150128 16:12:19-!- ShikadiLord [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150128 16:22:35-!- Sulfur [~Miranda@p5B009AE3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150128 16:24:47-!- ShikadiLord [~ignacio@wesnoth/developer/shadowm] has quit []
20150128 16:35:00-!- shadowm [~ignacio@wesnoth/developer/shadowm] has quit [Remote host closed the connection]
20150128 16:35:58-!- shadowm [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150128 16:39:29-!- Kexoth [~kex@77.28.29.245] has quit [Remote host closed the connection]
20150128 16:40:01-!- kex [~kex@77.28.29.245] has joined #wesnoth-dev
20150128 16:40:35-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20150128 16:44:55-!- kex [~kex@77.28.29.245] has quit [Ping timeout: 252 seconds]
20150128 17:10:01-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 244 seconds]
20150128 17:13:12-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20150128 17:13:23-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 240 seconds]
20150128 17:17:20-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150128 17:17:32-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150128 17:24:36-!- Samual [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev
20150128 17:30:02-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150128 17:53:04-!- lipkab [~the_new_l@host-91-147-211-47.biatv.hu] has joined #wesnoth-dev
20150128 18:20:40-!- gfgtdf [~chatzilla@f054143135.adsl.alicedsl.de] has joined #wesnoth-dev
20150128 18:25:03-!- Sulfur [~Miranda@p5B009AE3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150128 18:41:14-!- kex [~kex@77.28.29.245] has joined #wesnoth-dev
20150128 18:53:02< gfgtdf> zookeeper: currently (1.12, 1.13) needs_select=yes fires the select event twice on the the currently active side so it's a slightly bugged so i'd like to remove it. Also i think your example of needs_select can be done without needs_select=yes because one can easily write a tag [sync_variable] in lua that sets a named variable on all clients to the same value as on the crrently active...
20150128 18:53:03< gfgtdf> ...client. You have an example of needs_select=yes which cannot be handled by using [sync_variable] ?
20150128 19:09:31< zookeeper> nope
20150128 19:10:07< zookeeper> by firing twice, you mean it fires originally when you first select the unit, and then... immediately another time? or when the menu item is used?
20150128 19:10:58< zookeeper> i'd really prefer if it didn't get axed so easily, all this lua stuff is relatively new and probably very few people know how to use it
20150128 19:12:01< gfgtdf> zookeeper: i mean it fires again on all clients when the menu item is used. So it fires 2 times in total on the original client
20150128 19:12:24< zookeeper> right. would that be easy to fix, then?
20150128 19:13:28< gfgtdf> zookeeper: i am not very sure but i don't think so.
20150128 19:13:50< gfgtdf> zookeeper: if people don't know lua we can put [sync_variable] in core.
20150128 19:15:49< zookeeper> well, that's unfortunate
20150128 19:16:57< zookeeper> in any case, being one of the people who doesn't know such a thing is done in lua, i can't really recommend axing the only similar feature i _do_ know about, buggy or not :p
20150128 19:17:05< zookeeper> +how
20150128 19:19:03< Ravana_> is there reason against putting [sync_variable] to core in either case?
20150128 19:19:23< zookeeper> surely not
20150128 19:21:18< gfgtdf> Ravana_: i personally wouldn't put something into core without a usecase for it.
20150128 19:23:53< zookeeper> i'd make an exception for something like that; it'd probably be very commonly used in UMC and it'd be better to have one officially supported simple syncing method that WML authors can rely on
20150128 19:24:28< zookeeper> on a related note, reading the wiki i can't even really figure out wesnoth.synchronize_choice
20150128 19:24:50< zookeeper> that stuff is getting awfully complicated
20150128 19:26:48< gfgtdf> hmm i'll make a pull request about [sync_variable] tga
20150128 19:27:48< gfgtdf> tag*
20150128 19:32:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 244 seconds]
20150128 19:41:25< gfgtdf> and of course ai get a craswh becasue of bug 23188 before i can even test my new tag ..
20150128 19:46:10< gfgtdf> s/ai/i
20150128 19:48:37-!- mjs-de [~mjs-de@f049112242.adsl.alicedsl.de] has quit [Ping timeout: 245 seconds]
20150128 19:52:51-!- new_one [~new_one@128.42.90.201] has joined #wesnoth-dev
20150128 19:54:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150128 19:56:38-!- mjs-de [~mjs-de@f049112242.adsl.alicedsl.de] has joined #wesnoth-dev
20150128 19:59:44-!- Samual [diotecktec@xonotic/core-team/Samual] has quit [Quit: The person who said nothing is impossible obviously never tried to slam a revolving door.]
20150128 20:19:57-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Quit: Ik ga weg]
20150128 20:27:50< gfgtdf> zookeeper, Ravana_: https://github.com/wesnoth/wesnoth/pull/373
20150128 20:28:16-!- Sulfur [~Miranda@p5B009AE3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150128 20:29:56< Ravana_> does it accept object(like unit) variables too?
20150128 20:31:36< gfgtdf> Ravana_: yes but it currently doesnt accept wml arrays, if you use name=unit only the first [unit] wil by synced. But it is possible to add suppot for wml arrays.
20150128 20:32:18< Ravana_> ok, single unit was what I asked about
20150128 20:44:16-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150128 20:48:23< zookeeper> gfgtdf, sooner or later it should have support for arrays too, though. otherwise looks nice, although i'd still like to keep needs_select too.
20150128 20:56:25-!- travis-ci [~travis-ci@ec2-54-81-233-201.compute-1.amazonaws.com] has joined #wesnoth-dev
20150128 20:56:25< travis-ci> gfgtdf/wesnoth-old#416 (sync_variable - 0f71f9b : gfgtdf): The build passed.
20150128 20:56:25< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/48672437
20150128 20:56:25-!- travis-ci [~travis-ci@ec2-54-81-233-201.compute-1.amazonaws.com] has left #wesnoth-dev []
20150128 21:07:41-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has quit [Ping timeout: 246 seconds]
20150128 21:11:52-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20150128 21:14:31-!- lipkab [~the_new_l@host-91-147-211-47.biatv.hu] has quit [Quit: Sűrű sötét az éj, dühöng a déli szél]
20150128 21:17:22-!- new_one [~new_one@128.42.90.201] has quit [Ping timeout: 245 seconds]
20150128 21:31:04-!- Samual [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev
20150128 21:42:08-!- kex [~kex@77.28.29.245] has quit [Remote host closed the connection]
20150128 21:42:42-!- kex [~kex@77.28.29.245] has joined #wesnoth-dev
20150128 21:46:04-!- new_one [~new_one@128.42.90.201] has joined #wesnoth-dev
20150128 21:47:41-!- [Relic] [~Relic]@2602:306:33a3:6d30:7dc7:d02e:d4c2:1a9a] has quit [Quit: Leaving]
20150128 21:47:47-!- kex [~kex@77.28.29.245] has quit [Ping timeout: 265 seconds]
20150128 21:50:57-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20150128 21:50:57< gfgtdf> zookeeper: the pr now supports wml arrays
20150128 21:51:05-!- new_one [~new_one@128.42.90.201] has quit [Ping timeout: 244 seconds]
20150128 21:53:30-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20150128 21:54:35-!- mjs-de [~mjs-de@f049112242.adsl.alicedsl.de] has quit [Remote host closed the connection]
20150128 21:57:56< aquileia> mattsc: In TRoW S15, I get Error: Illegal unary operator: '>'     in function 'get_units'     The_Rise_Of_Wesnoth/ai/ca_aggressive_attack_no_suicide.lua:7: in function <...e_Rise_Of_Wesnoth/ai/ca_aggressive_attack_no_suicide.lua:5>
20150128 21:58:49< aquileia> but why would it consider the > in        formula = '$this_unit.attacks_left > 0'      as unary?
20150128 22:03:14< aquileia> Hmm... might be an issue with my binary as it doesn't happen in the official release
20150128 22:06:23< zookeeper> gfgtdf, [sync_variable] is a good name IMO
20150128 22:11:47-!- new_one [~new_one@nat-168-7-254-173.rice.edu] has joined #wesnoth-dev
20150128 22:13:19< shadowm> aquileia: $this_unit.attacks_left probably resolves to an empty string.
20150128 22:13:44< shadowm> That would be the case if there's no variable named 'this_unit'.
20150128 22:14:55< aquileia> just to be sure whether it's a problem on my end, would you just cl to S15 and hit end turn?
20150128 22:15:07< shadowm> master or 1.12?
20150128 22:15:13< aquileia> on master, that is
20150128 22:15:17< shadowm> Ugh.
20150128 22:15:57< shadowm> It'll be a while.
20150128 22:17:18-!- lipkab [~the_new_l@host-91-147-211-47.biatv.hu] has joined #wesnoth-dev
20150128 22:17:36< aquileia> If it's inconvenient for you, perhaps someone else could? vultraz?
20150128 22:17:44< shadowm> vultraz is probably sleeping.
20150128 22:17:53< shadowm> I got the build now.
20150128 22:18:04< shadowm> Wow, yes, I get a flood of those.
20150128 22:18:32< aquileia> and they don't appear in 1.12 - then it's a regression
20150128 22:19:31< shadowm> The whole thing: http://pastebin.com/D1zVQxni 
20150128 22:20:18< aquileia> pretty much the same thing for me
20150128 22:29:23< gfgtdf> does the same thign happen also in other placed that use this_unit ?
20150128 22:32:44-!- [Relic] [~Relic]@2602:306:33a3:6d30:9d6f:d925:741:250a] has joined #wesnoth-dev
20150128 22:32:45< gfgtdf> aquileia: my thought would be that since the unit_filter.cpp refactor all alltribute values of the filter is read before this_unit is available.
20150128 22:32:48< aquileia> no idea, but the last real change to that scenario is in 1.12 as well, where I encounter no errors
20150128 22:33:27< aquileia> that would indeed explain the behaviour...
20150128 22:34:12-!- irker198 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150128 22:34:12< irker198> wesnoth: aquileia wesnoth:master c1b25aa4fdc7 / data/campaigns/The_Rise_Of_Wesnoth/ (4 files in 3 dirs): TRoW: Autumn Shyde unit for Dionli, sprite by zerovirus http://git.io/FgRR
20150128 22:34:42< gfgtdf> the commit i mean is https://github.com/wesnoth/wesnoth/commit/c9d05ff61bd417ae8da96cb5018709b5573abdf4
20150128 22:34:47< gfgtdf> aquileia: ^
20150128 22:36:22< gfgtdf> aquileia: is there another case where one would want to use this_unit inside unit filter cfg except from formula= ?
20150128 22:37:41< aquileia> I don't know... mattsc would be the one to ask that, I guess
20150128 22:48:22-!- gfgtdf_ [~chatzilla@f054058084.adsl.alicedsl.de] has joined #wesnoth-dev
20150128 22:50:29-!- Samual [diotecktec@xonotic/core-team/Samual] has quit [Ping timeout: 252 seconds]
20150128 22:50:30-!- gfgtdf [~chatzilla@f054143135.adsl.alicedsl.de] has quit [Ping timeout: 244 seconds]
20150128 22:50:31-!- gfgtdf_ is now known as gfgtdf
20150128 22:55:13< aquileia> gfgtdf:  !u.formula_manager().matches_filter(cfg_formula_, loc, u) is passed the unit 'u' itself, right?
20150128 22:55:25< aquileia> Or do I misunderstand that line?
20150128 22:55:40< gfgtdf> aquileia: i think yes
20150128 22:56:06< gfgtdf> yes to your first question
20150128 22:56:18-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150128 22:56:19< aquileia> Then shouldn't the formula manager use u as this_unit ?
20150128 22:56:39< mattsc> aquileia: hi, just here for a couple minutes
20150128 22:57:24< mattsc> I am aware of this problem and iceiceice is also and said that he might have introduced it.
20150128 22:57:35< mattsc> in master, that is
20150128 22:58:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150128 23:00:13< mattsc> aquileia, gfgtdf: just done reading up on your conversation.  So yes, that might be the commit iceiceice was referring to, but I don’t really know.
20150128 23:00:44< mattsc> I know that he said he would look into it, but he doesn’t have time right now, of course.
20150128 23:02:19< mattsc> To answer your other question: the only place I ever use this_unit is in combination with formula= (and even that not any more these days because it is slow), but that does not mean that it might not be useful otherwise.
20150128 23:02:52< mattsc> [modify_unit] supposedly let’s you use this_unit, but I’ve had problems with that (and it might be a different, lua-created one anyway).
20150128 23:03:06< aquileia> I wonder though: matches_filter('$this_unit.attacks_left > 0', loc, u) shouldn't be a problem as you get $this_unit from u
20150128 23:03:55< aquileia> So I don't understand how that commit would break it
20150128 23:04:08< mattsc> I really don’t know any more about this.  After iceiceice said that he might know what this is about, I did not look into it any further.
20150128 23:05:11< mattsc> Anyways, I need to be off again.  I’ll check the log in a couple hours, but I doubt that I can help with it anyway.
20150128 23:06:02-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Not here much atm. Will check logs for my nick and forum PMs.]
20150128 23:06:14< aquileia> bye
20150128 23:08:38-!- lipkab [~the_new_l@host-91-147-211-47.biatv.hu] has quit [Quit: Sűrű sötét az éj, dühöng a déli szél]
20150128 23:13:16< aquileia> gfgtdf: I have no idea why https://github.com/wesnoth/wesnoth/blob/master/src/unit_formula_manager.cpp#L25 wouldn't be able to get $this_unit from the callable_unit
20150128 23:16:02< aquileia> Did anyone check whether it really was that refactor? Honestly, my guess would be that we just don't pass the unit all the way through...
20150128 23:18:40< gfgtdf> aquileia: why should rthat code be related to storing this_unit ?
20150128 23:18:43< gfgtdf> that*
20150128 23:19:23< aquileia> That's the code evaluating the formula expression of a filter
20150128 23:20:35< aquileia> As it's passed the unit, it should get $this_unit from there, I'd say
20150128 23:21:00< gfgtdf> aquileia: wha shoudl it get this_unit form that unit `?
20150128 23:22:12< aquileia> I don't know what the code actually does, but it seems the most logical
20150128 23:22:17< gfgtdf> https://github.com/wesnoth/wesnoth/blob/master/src/unit_filter.cpp#L333
20150128 23:22:48< gfgtdf> https://github.com/wesnoth/wesnoth/search?l=cpp&q=this_unit&utf8=%E2%9C%93
20150128 23:23:54< aquileia> hmm... how would you access the fields of the currently passed unit, then? It has to be passed for a reason, right?
20150128 23:25:10-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150128 23:25:24< gfgtdf> for example liek this: http://forums.wesnoth.org/viewtopic.php?f=21&t=40957&hilit=+formula#p575388
20150128 23:27:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20150128 23:27:59< gfgtdf> aquileia: but one of teh porblme is that teh keys might differ for the formula syntax and teh wml this_unit syntax
20150128 23:28:44< gfgtdf> aquileia: for example what is calles "moves" in wml syntax ias called "movement_left" i formula syntax
20150128 23:28:46< gfgtdf> in*
20150128 23:29:26< aquileia> do you know the equivalent of attacks_left, by coincidence?
20150128 23:29:56< gfgtdf> aquileia: it's the same
20150128 23:30:27-!- gfgtdf [~chatzilla@f054058084.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20150128 23:30:52-!- gfgtdf [~chatzilla@f054058084.adsl.alicedsl.de] has joined #wesnoth-dev
20150128 23:30:55< aquileia> I hoped I could just delete the "$this_unit.", but to no avail
20150128 23:31:06< gfgtdf> aquileia: you can look up teh supported keys here: https://github.com/wesnoth/wesnoth/blob/master/src/callable_objects.cpp#L142
20150128 23:33:11< gfgtdf> i don't know whether there is a wiki page for this
20150128 23:37:23< aquileia> So in 1.12, omitting $this_unit. worked, but on master it didn't
20150128 23:39:25< aquileia> That is: In 1.12 it can resolve $this_unit.attacks_left and attacks_left, on master neither works
20150128 23:40:16< gfgtdf> aquileia: hm what error message so you get when removing it ?
20150128 23:40:23< aquileia> And for "attacks_left" it should evaluate the callable_unit, right?
20150128 23:40:43< gfgtdf> i think yes
20150128 23:41:03< aquileia> gfgtdf: Nothing changes, it still says > is used as a unary operator
20150128 23:42:09< gfgtdf> aquileia: maybe you just didnt refresh the lua/wml ?
20150128 23:42:35< gfgtdf> reload
20150128 23:42:41< aquileia> I did
20150128 23:42:52< gfgtdf> hm ok i'll est too
20150128 23:43:57< gfgtdf> aquileia: in ca_aggressive_attack_no_suicide.lua ?
20150128 23:44:06< aquileia> yes
20150128 23:44:39< aquileia> Just delete the $this_unit. , cl to scenario 15 and hit end turn
20150128 23:45:05< aquileia> on 1.12 it'll work, on master it'll complain
20150128 23:46:02-!- renketsu0 [~renketsu0@2601:4:e80:121:1c01:f4b4:55b1:a383] has joined #wesnoth-dev
20150128 23:47:09< gfgtdf> maybe there is anothjer occurance of this_unit ?
20150128 23:47:17< aquileia> gfgtdf: 'u' is a const unit reference, right?
20150128 23:47:35< gfgtdf> idk, i think that easy to look up
20150128 23:49:21< gfgtdf> aquileia: did you also remove the this_unit in ca_retreat.lua ?
20150128 23:50:02< aquileia> no, let me try that...
20150128 23:50:42< gfgtdf> aquileia: in anyway i think commiting that this_unit removals is good becasue using this_unit requires storing the unit which might b low if done very often
20150128 23:50:48< aquileia> it works! Sorry for overlooking that
20150128 23:51:03< gfgtdf> s/b low/be slow
20150128 23:51:22< aquileia> And I can't think of a usecase where you can't omit $this_unit
20150128 23:52:14< aquileia> I'll commit the fix for that scenario, ok?
20150128 23:52:24< gfgtdf> aquileia: maybe there are some attributes which are not suported by forula, this can especially happen if soneone adds new unit attributes and doesnt know about formula
20150128 23:52:30< gfgtdf> aquileia: ok
20150128 23:52:52< gfgtdf> aquileia: for example i dont know whether recall_cost are accessible via formula
20150128 23:52:53< aquileia> Have to use my new freedom =P
20150128 23:57:35< irker198> wesnoth: aquileia wesnoth:master cc8ec3a934bd / data/campaigns/The_Rise_Of_Wesnoth/ai/ (ca_aggressive_attack_no_suicide.lua ca_retreat.lua): TRoW S15: Fix unit filter used by the AI http://git.io/Fghk
--- Log closed Thu Jan 29 00:00:29 2015