--- Log opened Wed Mar 04 00:00:55 2015
20150304 00:03:51-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20150304 00:07:13-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20150304 00:32:58-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.1.1]
20150304 00:33:35-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20150304 00:33:40-!- new_one [~new_one@50.15.126.83] has quit [Client Quit]
20150304 00:34:00-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20150304 00:38:23-!- localuser- [~none@unaffiliated/localuser-] has quit [Remote host closed the connection]
20150304 00:50:05-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Quit: No Ping reply in 180 seconds.]
20150304 00:50:30-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20150304 01:29:21-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150304 02:03:25-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 255 seconds]
20150304 02:12:01-!- irker047 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150304 02:21:44-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20150304 02:32:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150304 02:32:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20150304 02:34:52-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20150304 02:36:50-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20150304 02:40:35-!- groggy [4b8fb389@gateway/web/freenode/ip.75.143.179.137] has joined #wesnoth-dev
20150304 02:42:18-!- horrowin1 [~Icedove@2a02:810a:8b40:60c8:21b:fcff:fee3:c3ff] has quit [Quit: horrowin1]
20150304 02:44:59-!- un214 [~un214@2602:306:ce78:1159:56a0:50ff:fe57:101d] has joined #wesnoth-dev
20150304 02:57:57-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Remote host closed the connection]
20150304 03:02:54-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150304 03:05:54-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150304 03:07:37-!- un214 [~un214@2602:306:ce78:1159:56a0:50ff:fe57:101d] has quit [Remote host closed the connection]
20150304 03:20:29-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150304 03:22:17-!- Ivanovic_ [~ivanovic@frnk-5f7518ab.pool.mediaWays.net] has joined #wesnoth-dev
20150304 03:25:42-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 245 seconds]
20150304 03:26:11-!- Ivanovic_ is now known as Ivanovic
20150304 03:42:35-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.1.1]
20150304 03:54:37-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20150304 04:10:47-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20150304 04:23:33-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150304 04:53:55-!- Sulfur [~Miranda@p5B0085B1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150304 04:54:33-!- ancientcc [~Administr@140.207.223.190] has joined #wesnoth-dev
20150304 04:58:53-!- ancientcc [~Administr@140.207.223.190] has quit [Client Quit]
20150304 05:00:57-!- ancientcc [~Administr@123.155.155.75] has joined #wesnoth-dev
20150304 05:05:26-!- ancientcc [~Administr@123.155.155.75] has quit [Quit: Leaving]
20150304 05:08:48-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.1.1]
20150304 05:14:23-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev
20150304 05:23:14< ancestral> Forums maintenance is happening?
20150304 05:24:14< ancestral> http://isup.me/forums.wesnoth.org
20150304 06:10:54-!- Sulfur [~Miranda@p5B0085B1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150304 06:44:57-!- Ivanovic [~ivanovic@frnk-5f7518ab.pool.mediaWays.net] has quit [Changing host]
20150304 06:44:57-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20150304 06:50:11-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150304 06:53:15-!- [Relic] [~Relic]@2602:306:33a3:6d30:d838:3554:7542:121e] has quit [Quit: Leaving]
20150304 07:01:13-!- groggy [4b8fb389@gateway/web/freenode/ip.75.143.179.137] has quit [Ping timeout: 246 seconds]
20150304 07:25:35-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 265 seconds]
20150304 07:30:46-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150304 07:59:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150304 08:02:37-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150304 08:14:06-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 252 seconds]
20150304 08:14:23-!- ancientcc [~Administr@123.155.155.184] has joined #wesnoth-dev
20150304 08:17:58-!- ancientcc [~Administr@123.155.155.184] has quit [Quit: Leaving]
20150304 08:21:11-!- mjs-de [~mjs-de@f048007055.adsl.alicedsl.de] has joined #wesnoth-dev
20150304 08:21:17-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20150304 08:30:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150304 08:31:14-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150304 08:42:31< Rhonda> damnit, what IP address was that again
20150304 08:44:46-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 256 seconds]
20150304 08:45:47-!- fabi [~quassel@p20030051AA2BC29418AC031EC38FECCD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150304 08:45:47-!- fabi [~quassel@p20030051AA2BC29418AC031EC38FECCD.dip0.t-ipconnect.de] has quit [Changing host]
20150304 08:45:47-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150304 09:15:39-!- groggy [4b8fb389@gateway/web/freenode/ip.75.143.179.137] has joined #wesnoth-dev
20150304 09:29:12-!- ancientcc [~Administr@211.162.34.200] has joined #wesnoth-dev
20150304 10:15:52-!- horrowin1 [~Icedove@2a02:810a:8b40:60c8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150304 10:43:49-!- groggy [4b8fb389@gateway/web/freenode/ip.75.143.179.137] has quit [Ping timeout: 246 seconds]
20150304 11:18:59-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 245 seconds]
20150304 11:22:56-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150304 11:27:43-!- ancientcc [~Administr@211.162.34.200] has quit [Quit: Leaving]
20150304 11:27:58-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 256 seconds]
20150304 11:30:48-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150304 11:41:13-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 255 seconds]
20150304 11:44:57-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150304 11:50:01-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20150304 11:51:45-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 252 seconds]
20150304 12:09:10-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150304 12:18:26-!- kex [~kex@77.28.1.116] has joined #wesnoth-dev
20150304 12:19:32-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-116.wireless.uva.nl] has joined #wesnoth-dev
20150304 12:38:03-!- Sulfur [~Miranda@p5B009828.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150304 13:07:05-!- markus_ [~mjs-de@f048023025.adsl.alicedsl.de] has joined #wesnoth-dev
20150304 13:10:17-!- mjs-de [~mjs-de@f048007055.adsl.alicedsl.de] has quit [Ping timeout: 245 seconds]
20150304 13:13:57-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-116.wireless.uva.nl] has quit [Quit: Ik ga weg]
20150304 13:15:43-!- kex [~kex@77.28.1.116] has quit []
20150304 13:19:38-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-116.wireless.uva.nl] has joined #wesnoth-dev
20150304 13:21:00-!- kex [~kex@77.28.1.116] has joined #wesnoth-dev
20150304 13:34:02-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-116.wireless.uva.nl] has quit [Ping timeout: 246 seconds]
20150304 13:39:08-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20150304 13:41:41-!- gfgtdf [~chatzilla@f050178135.adsl.alicedsl.de] has joined #wesnoth-dev
20150304 14:06:34-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev
20150304 14:09:59-!- gfgtdf [~chatzilla@f050178135.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 35.0.1/20150122214805]]
20150304 14:10:26-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20150304 14:47:38-!- Necrosporus_ is now known as Necrosporus
20150304 14:48:47< Necrosporus> iceiceice, the most glaring mp bug is probably double carryover one
20150304 14:48:48-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has joined #wesnoth-dev
20150304 14:49:14< Necrosporus> it was not fixed in 1.12.1 and it seem so, it can't be fixed without breaking compatibility
20150304 15:12:40-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20150304 15:17:19-!- higgins [~higgins@105.ip-167-114-152.net] has quit [Ping timeout: 245 seconds]
20150304 15:18:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150304 15:23:03-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150304 15:25:43-!- higgins [~higgins@105.ip-167-114-152.net] has joined #wesnoth-dev
20150304 15:29:07< iceiceice> does it exist in master also?
20150304 15:37:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150304 15:46:15-!- gfgtdf [~chatzilla@f050178135.adsl.alicedsl.de] has joined #wesnoth-dev
20150304 15:46:20< gfgtdf> iceiceice: i think not
20150304 15:47:10< iceiceice> y so, for a bug like this there's not so many places it could be,
20150304 15:47:56< iceiceice> one thing is, i'm not 100% sure what the correct formulas are,
20150304 15:48:02< iceiceice> also i'm not entirely sure what the correct system should be
20150304 15:48:12< iceiceice> it sounds like, the host is applying carryover and the clients are also
20150304 15:48:19< iceiceice> i assume that only the host should be?
20150304 15:50:07< gfgtdf> iceiceice: if i remember currently the host first loads the new scenario  then applies carryover, then sends it to the other cients which then aplly carryover again
20150304 15:50:36< gfgtdf> iceiceice: on 1.13 it is posible to tell from teh savegame file whether carryover was already aplied or not
20150304 15:50:45< gfgtdf> iceiceice: i dont think thats teh case on 1.12
20150304 15:51:18< gfgtdf> iceiceice: so yes only the host applying carryover sounds liek a good plan
20150304 15:52:49< gfgtdf> iceiceice: carryover is aplied here: https://github.com/wesnoth/wesnoth/blob/1.12/src/playcampaign.cpp#L576 and here: https://github.com/wesnoth/wesnoth/blob/1.12/src/playcampaign.cpp#L288
20150304 15:53:46< iceiceice> gfgtdf: maybe this line:
20150304 15:53:47< iceiceice> https://github.com/wesnoth/wesnoth/blob/1.12/src/playcampaign.cpp#L311
20150304 15:54:08< iceiceice> should be only `if (playcontroller.is_host()) ` ?
20150304 15:54:39< gfgtdf> iceiceice: hm i dont now whether currently teh host also aplies carryover twice
20150304 15:54:45< gfgtdf> iceiceice: if yes than it wouldnt fix it
20150304 15:55:16< iceiceice> i think that this line "sides.transfer_from" does involve calculating the carryove
20150304 15:56:36< gfgtdf> iceiceice: yes that possible
20150304 15:57:04< gfgtdf> iceiceice: you mena the line sides.transfer_from(t, carryover_gold); ?
20150304 15:57:09< gfgtdf> meanÜ
20150304 15:57:10< iceiceice> yes
20150304 15:57:32< iceiceice> https://github.com/wesnoth/wesnoth/blob/1.12/src/gamestatus.cpp#L233
20150304 15:57:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150304 15:59:22< gfgtdf> gamestatus.cpp :s. i hoped never having to look at it again.
20150304 15:59:38< iceiceice> hehe
20150304 16:00:51< gfgtdf> iceiceice: yes thats the code that copies units/gold from the gamestate into carryover_sides(start)
20150304 16:02:26< iceiceice> yeah so i guess my theory atm is that
20150304 16:02:28< gfgtdf> iceiceice: this line is also strange: https://github.com/wesnoth/wesnoth/blob/1.12/src/playcampaign.cpp#L538
20150304 16:02:42< gfgtdf> iceiceice: the comment seems ot be untrue.
20150304 16:03:29< gfgtdf> iceiceice: since carryover_sides_start was already applied to  teh config we got from teh server
20150304 16:04:08< iceiceice> its from this commit: https://github.com/wesnoth/wesnoth/commit/569ef65e
20150304 16:07:21< gfgtdf> iceiceice: no teh comment was already there before, the commit just moved it
20150304 16:07:21< iceiceice> oh you're right
20150304 16:12:39< iceiceice> i think its new in this commit...
20150304 16:12:39< iceiceice> https://github.com/wesnoth/wesnoth/commit/f7fa3c59
20150304 16:14:01< gfgtdf> iceiceice: i think the comment was copied in that commit
20150304 16:14:28< iceiceice> hmmmm
20150304 16:14:34-!- markus_ is now known as mjs-de
20150304 16:15:07< gfgtdf> iceiceice: my current idea is to add  a if(io_type == IO_NONE ) { gamestate.carryover_sides_start = config();} at the end of the loop. 
20150304 16:17:02< iceiceice> at line 638 or something?
20150304 16:17:21< iceiceice> and you mean if != IO_NONE, right? or am I confused
20150304 16:17:34< iceiceice> the purpose is to clear the local data so that only the carryover sent by host is used, right?
20150304 16:17:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150304 16:18:51< gfgtdf> iceiceice: yes i meant !=
20150304 16:19:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150304 16:20:00< iceiceice> gfgtdf: i think maybe its this commit? https://github.com/wesnoth/wesnoth/commit/d7a35f90
20150304 16:20:52< iceiceice> no that only introduces one instance of it i think...
20150304 16:24:09-!- [Relic] [~Relic]@2602:306:33a3:6d30:d154:9aa5:a036:f2a7] has joined #wesnoth-dev
20150304 16:24:54< iceiceice> ah my text editor was confused
20150304 16:24:58< iceiceice> i think its from this commit
20150304 16:25:14< gfgtdf> iceiceice: hm yes
20150304 16:26:31< gfgtdf> iceiceice: a mor compilcated problem is that we support carryover data to 'skip' a  scenario that is we have a side with save_id=iceiceice in scenario 1 and scenario 3 but not in scenario 2
20150304 16:26:53< gfgtdf> iceiceice: afair that is what carryover_sides (without _start) is for
20150304 16:27:21< gfgtdf> iceiceice: so if the host get changes during scenario 2
20150304 16:28:03< gfgtdf> iceiceice: th einformation about the side with save_id=iceiceice might be dropped then
20150304 16:28:58< gfgtdf> iceiceice: but at least it won't casue OOS.
20150304 16:29:29< iceiceice> i didn't realize about this
20150304 16:29:42< iceiceice> why is it in a different tag?
20150304 16:30:23< iceiceice> maybe its a bad question haha
20150304 16:36:20< gfgtdf> iceiceice: another bug in 1.12 is this one: https://gna.org/bugs/?23310
20150304 16:37:34< gfgtdf> iceiceice: i think it mostly about init_side_done beeing true but should be false when reloading a 'start turn' replay save.
20150304 16:54:25< vultraz> !seen libkab
20150304 16:54:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20150304 16:54:41< vultraz> er, what was it again
20150304 17:01:07-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 250 seconds]
20150304 17:03:21< iceiceice> gfgtdf: if the carryover problem is that,
20150304 17:03:28< iceiceice> all of the clients are doing it in addition to host,
20150304 17:03:54< iceiceice> that means the host should end up with different gold from the non-hosts?
20150304 17:03:58< iceiceice> or just that they all get double gold
20150304 17:04:08< iceiceice> what i'm observing is that they allg et double gold
20150304 17:04:13< iceiceice> i guess that's kiss' report also
20150304 17:04:17< gfgtdf> iceiceice: afaik all get double gold except observers
20150304 17:04:40< gfgtdf> iceiceice: becaseu they dotn have teh data form teh previous scenario
20150304 17:07:00< gfgtdf> iceiceice: that alsp applies to observers that wewre in the previous scenario since carryover is not calculated for res == OBSERVER_END : https://github.com/wesnoth/wesnoth/blob/1.12/src/playcampaign.cpp#L311
20150304 17:08:22< gfgtdf> afk for an hour
20150304 17:20:03-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150304 17:22:28-!- kex [~kex@77.28.1.116] has quit [Remote host closed the connection]
20150304 17:22:30< iceiceice> gfgtdf: i find that if i comment out line 540, it fixes the gold count for the client (in LoW scenario 2), but not the server
20150304 17:22:34< iceiceice> which is what i expected
20150304 17:24:31-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20150304 17:25:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150304 17:27:46-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20150304 17:35:44-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 256 seconds]
20150304 17:36:51-!- irker380 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150304 17:36:51< irker380> wesnoth: Charles Dang wesnoth:master 01c1ffb8cea1 / data/core/images/help/hp-bars.png: Updated the hp bars help image http://git.io/xS4d
20150304 17:41:25-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150304 18:04:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150304 18:10:24-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150304 18:24:28< gfgtdf> iceiceice: yes tht why i suggested to put a != IO_NONE .. clear carryover_sides_start. to handle the IO_SERVER case aswell.
20150304 18:32:26< iceiceice> i am going to make a test campaign so i can test this at least semi-rigorously...
20150304 18:32:51< iceiceice> i can't find an easy way to test mp campaigns on the add-on server unfortunately
20150304 18:37:01< gfgtdf> iceiceice: you can test it with LoW
20150304 18:37:23< iceiceice> yeah, in that test it works
20150304 18:37:34< iceiceice> id like to try at least one other though
20150304 18:41:24< gfgtdf> iceiceice: why it is a problem to test teh mp campaigns on teh adon server ?
20150304 18:41:41< iceiceice> idk how to easily debug cheat through them
20150304 18:44:01< gfgtdf> iceiceice: i made am mp mod that adds a menu item that gives all human unit good stats that i usually use for mp testing. But i am not 1^00%sure whether that uses 1.13 features or not
20150304 18:44:30< gfgtdf> [modification] i mean
20150304 18:44:51< iceiceice> yeah i tried to add an event to WC II that will effect cheats, but actually i couldn't get it to work, the add-on structure is complicated
20150304 18:45:14-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 245 seconds]
20150304 18:45:27< gfgtdf> iceiceice: afaik WC doesnt work in 1.13 so i never tested it.
20150304 18:49:51< gfgtdf> iceiceice: uploaded addon "make Easy" to addonserver
20150304 18:50:12-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150304 18:50:15< iceiceice> i made a looping test scenario
20150304 18:50:36< iceiceice> i guess i just adapated the old looping test scenario
20150304 18:50:45< iceiceice> it needed to change because of the allow_new_game thing in 1.12
20150304 18:52:55< iceiceice> i think it fixes it...
20150304 18:52:59< iceiceice> i will try your make easy
20150304 18:53:03-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150304 19:08:25< gfgtdf> iceiceice: did you test ?
20150304 19:09:21< iceiceice> it seemed cause a problem in wc 2
20150304 19:09:27< iceiceice> i'm not sure
20150304 19:09:33< iceiceice> im testing again
20150304 19:09:38< gfgtdf> iceiceice: you got OOS ?
20150304 19:10:00< iceiceice> i got that at start of second scenario i lost, apparently because of no sides but im not sure
20150304 19:20:34-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Ping timeout: 256 seconds]
20150304 19:22:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150304 19:27:51-!- Sulfur [~Miranda@p5B009828.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150304 19:42:57< gfgtdf> iceiceice: also i think if we fix it that we we should disable Mp campaigns for 1.12.1 and soon er on the MP server since ti will most likeley casue OOS otherwise
20150304 19:43:54< iceiceice> do you know how we can do that?
20150304 19:44:18< iceiceice> like you want the server to reject games that try to get started or something?
20150304 19:45:29< gfgtdf> iceiceice: yes fai there is not was to tell whether a whether a scenario has a next scenario when it is started so maybe just not allow then to advance to next scenarios
20150304 19:48:35< gfgtdf> iceiceice: since carrover is not applies twice for observer when tehy rejoin, we could ckick all 1.12.1. cleints from a game when it advanced and allow then to join afterwards
20150304 19:49:13< iceiceice> yes that makes sense
20150304 19:50:16< iceiceice> ok i am going to upload patch, i think there is just a bug in WC II on 1.12 or something
20150304 20:05:57< iceiceice> gfgtdf: this is what i am testing
20150304 20:06:01< iceiceice> https://github.com/cbeck88/wesnoth/commit/1627737166e0b52258d7110befab4ad4134de4f2
20150304 20:12:07< iceiceice> hmm
20150304 20:12:31< iceiceice> it seems that the game sometimes has trouble finding mp campaigns,
20150304 20:13:31< iceiceice> i'm not sure what the issue is
20150304 20:24:24-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20150304 20:24:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150304 20:24:57< iceiceice> ok, i'm going to push that to wesnoth 1.12, it seems to work 
20150304 20:25:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150304 20:30:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150304 20:33:19-!- happygrue [~Laptop@2601:6:4380:909:95e8:b16c:8495:2adc] has joined #wesnoth-dev
20150304 20:33:30-!- happygrue [~Laptop@2601:6:4380:909:95e8:b16c:8495:2adc] has quit [Changing host]
20150304 20:33:30-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20150304 20:33:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150304 20:34:28-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20150304 20:34:57-!- ToBeCloud [uid51591@gateway/web/irccloud.com/x-imtnoknckirhgqmk] has joined #wesnoth-dev
20150304 20:37:13-!- irker380 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150304 20:38:06-!- irker412 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150304 20:38:06< irker412> wesnoth: Chris Beck wesnoth:1.12 1627737166e0 / src/playcampaign.cpp: bug #22936: in mp don't retain local carryover when loading scenario http://git.io/x9pm
20150304 20:45:27< gfgtdf> iceiceice: will you implement teh serversided kick for 1.12.1 client on scenario advancing too ?
20150304 20:45:59< iceiceice> not right away
20150304 20:46:07< iceiceice> i'm going to read server code again
20150304 20:46:52< Ravana_> will it break thing without any carryover?
20150304 20:47:27< gfgtdf> Ravana_: i think not
20150304 20:47:46< iceiceice> it should only affect networked games
20150304 20:48:19< Ravana_> yes, some scenarios use advance as startup turn
20150304 20:49:08< irker412> wesnoth: Chris Beck wesnoth:1.12 1c1ea6771071 / changelog: update changelog http://git.io/xHfQ
20150304 20:50:03< gfgtdf> Ravana_: what you mean by that ?
20150304 20:50:42< Ravana_> that first scenario is to set up variables/user settings and then it advances to scenario where game happens
20150304 20:51:08< iceiceice> oh you mean the kicking thing
20150304 20:51:34< Ravana_> yes
20150304 20:51:48< iceiceice> y like rby
20150304 20:56:50< iceiceice> yeah i see what you are saying
20150304 20:56:53< iceiceice> idk how we can fix it
20150304 20:57:50< iceiceice> gfgtdf: if we kick all clients doesnt that mean we have to kick the host also?
20150304 20:57:59< iceiceice> since the host also has the wrong gold
20150304 20:59:14< gfgtdf> iceiceice: yes, but i fear that it could make it a lot more complex.
20150304 21:00:01< iceiceice> maybe we should have a 1.12.2+ server and a 1.12.0, 1.12.1 server
20150304 21:00:55< iceiceice> idk
20150304 21:01:01< iceiceice> i guess that wont really help
20150304 21:01:06< Ravana_> playerbase is even now stretched between 1.10 and 1.12, I think that way would not be good idea
20150304 21:01:25< iceiceice> the fact is this is just a really hideous bug
20150304 21:01:44< iceiceice> we needed to fix it before releasing but we didn't
20150304 21:02:00< gfgtdf> iceiceice: maybe we shoudl just give then a server message that OOS is likeley when 1.12.1 clients advance.
20150304 21:02:09< iceiceice> yes maybe thats enough
20150304 21:03:11< iceiceice> thats probably the easiest thing
20150304 21:15:28< gfgtdf> iceiceice: i tried to play Rushed by Yetis but it gived me a lua Error about related to strict lua 
20150304 21:15:39< gfgtdf> gives*
20150304 21:15:40< iceiceice> lol
20150304 21:15:50< iceiceice> ok i didn't try rby on 1.13 yet
20150304 21:22:13< iceiceice> hmm so does addons.wesnoth.org/1.13 exist?
20150304 21:22:15< iceiceice> or its just 1.12
20150304 21:23:13< gfgtdf> iceiceice: its teh same
20150304 21:23:20< iceiceice> yaeh
20150304 21:23:25< gfgtdf> iceiceice: i uploaded "Make Easy" wthi 1.13
20150304 21:23:28< gfgtdf> with*
20150304 21:23:29< iceiceice> i will make an RBY update at some point soon i think
20150304 21:34:20-!- cib0 [~cib@tmo-096-140.customers.d1-online.com] has joined #wesnoth-dev
20150304 21:40:19< iceiceice> gfgtdf: at this line in master: https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/playcampaign.cpp#L182
20150304 21:40:36< iceiceice> i think maybe it happens when any of those error messages returns?
20150304 21:40:55< iceiceice> i don't think that gui2::show_error_message also results in an exception being thrown again
20150304 21:41:34< gfgtdf> iceiceice: hm yes i think the return value of play_replay is pnly used by replays anyway ?
20150304 21:42:18< iceiceice> it is used in the unit tests,
20150304 21:42:28< iceiceice> it tries to check that it can play the replay to completion without an error message
20150304 21:42:35< iceiceice> but i dont think its used anywhere else
20150304 21:43:49< gfgtdf> iceiceice: maybe we shoudl just make it return a bool 'succes'? It seems like 'defeat' is not really fitting.'
20150304 21:44:02< iceiceice> maybe
20150304 21:44:15< iceiceice> its probably more clear that way
20150304 21:45:45-!- gfgtdf [~chatzilla@f050178135.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20150304 21:46:15-!- gfgtdf [~chatzilla@f050178135.adsl.alicedsl.de] has joined #wesnoth-dev
20150304 21:59:38< irker412> wesnoth: gfgtdf wesnoth:master 487bf6f95076 / src/ (4 files): fix [end_turn] in networked mp http://git.io/xHoh
20150304 22:00:11-!- TooLmaN [~TooLmaN@mail.thomsonplastics.com] has quit [Quit: Off to save the world!]
20150304 22:11:28-!- gfgtdf_ [~chatzilla@d150180.adsl.hansenet.de] has joined #wesnoth-dev
20150304 22:13:23-!- gfgtdf [~chatzilla@f050178135.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20150304 22:13:23-!- gfgtdf_ is now known as gfgtdf
20150304 22:25:53-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150304 22:46:57-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150304 22:51:10-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150304 23:00:57-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20150304 23:06:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20150304 23:11:54-!- SpoOkyMagician [~chatzilla@cpe-74-132-242-221.swo.res.rr.com] has joined #wesnoth-dev
20150304 23:19:42-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 272 seconds]
20150304 23:22:20-!- mjs-de [~mjs-de@f048023025.adsl.alicedsl.de] has quit [Ping timeout: 244 seconds]
20150304 23:32:18-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150304 23:32:33-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20150304 23:39:12-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 252 seconds]
20150304 23:42:50-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150304 23:43:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20150304 23:48:03-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20150304 23:48:03-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20150304 23:48:03-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150304 23:48:52-!- cib0 [~cib@tmo-096-140.customers.d1-online.com] has quit [Ping timeout: 240 seconds]
20150304 23:52:28-!- ToBeCloud [uid51591@gateway/web/irccloud.com/x-imtnoknckirhgqmk] has quit [Quit: Connection closed for inactivity]
20150304 23:52:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150304 23:54:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20150304 23:54:34-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
--- Log closed Thu Mar 05 00:00:13 2015