--- Log opened Fri Mar 06 00:00:23 2015
20150306 00:08:16-!- fabi [~quassel@p20030051AA2BC22754CB3BF93615857A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150306 00:08:16-!- fabi [~quassel@p20030051AA2BC22754CB3BF93615857A.dip0.t-ipconnect.de] has quit [Changing host]
20150306 00:08:16-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150306 00:55:26-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev
20150306 01:00:59< vultraz> shadowm: you're still around and haven't gone MIA?? :O
20150306 01:11:15-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150306 01:11:38< iceiceice> this looks like a big bug to me...
20150306 01:11:39< iceiceice> https://github.com/wesnoth/wesnoth/blob/1.12/src/multiplayer_connect_engine.cpp#L975
20150306 01:11:54< iceiceice> s/"saved_id"/"save_id"  ?
20150306 01:12:37< vultraz> iceiceice: the channel was #frogatto BTW
20150306 01:12:55< vultraz> frogatto/anura's development channel
20150306 01:18:45-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Quit: No Ping reply in 180 seconds.]
20150306 01:19:12-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20150306 01:23:34-!- mjs-de [~mjs-de@g228170238.adsl.alicedsl.de] has quit [Ping timeout: 245 seconds]
20150306 01:25:11< vultraz> iceiceice: also, looks like it
20150306 01:25:23< vultraz> (a bug, that is)
20150306 01:26:26< iceiceice> i hate bugs like that
20150306 01:26:32< iceiceice> just some typo
20150306 01:31:00< vultraz> on the flip side, you should also love bugs like that
20150306 01:31:03< vultraz> very easy to fix
20150306 01:31:27< iceiceice> no b/c usually when i see a bug like that i want to make it so that it can't happen
20150306 01:31:48< iceiceice> by replacing the string constants with static strings, or with macros
20150306 01:31:53< iceiceice> so that the typo would become a compiler time error
20150306 01:32:05< iceiceice> but its a lot of work to change that stuff
20150306 01:32:16< iceiceice> and there is some readability cost
20150306 01:32:21< iceiceice> so theres no really good solution
20150306 01:34:51-!- gfgtdf [~chatzilla@d150180.adsl.hansenet.de] has joined #wesnoth-dev
20150306 01:38:53< iceiceice> gfgtdf: i am looking at this ai name thing,
20150306 01:39:02< iceiceice> i thik you are competely right its because of the controller tweaks on server side
20150306 01:39:06< iceiceice> when they go to host
20150306 01:39:28< iceiceice> i think correct thing is maybe,
20150306 01:39:35< iceiceice> in playturn.cpp,
20150306 01:39:58< iceiceice> if the controller is changing like ai -> ai, then the name should not change
20150306 01:40:00< iceiceice> or something like this
20150306 01:42:01< iceiceice> i got some log info from host side in LoW, after game is starting
20150306 01:42:39< iceiceice> http://pastebin.com/ieBZeart
20150306 01:46:03< gfgtdf> iceiceice: hm i dont know is it possible for a team to change from human to ai or form ai to human ?
20150306 01:46:42< iceiceice> i think probably
20150306 01:46:52< iceiceice> i think if there is an ai side in the game
20150306 01:47:06< iceiceice> and the host types :control 3 player for example
20150306 01:47:14< iceiceice> if 3 is ai it will become controller by a remote player
20150306 01:51:42< iceiceice> i guess alternative is to make the server not send tweaks to host
20150306 01:51:59< iceiceice> at the time i thoguht "it can't really do any harm" but i guess it actually did mess up the names
20150306 01:52:03< iceiceice> and i didn't really think about it
20150306 01:52:32< iceiceice> idk if its simpler to treat all the clients the same or to not send messages back to host
20150306 01:53:37< gfgtdf> iceiceice: currently the other cleints receive teh tweaks earlier (in multiplayer_...) classes while the host reeviecees tehm during teh game
20150306 01:53:55< iceiceice> yeah
20150306 01:53:58< iceiceice> ok
20150306 01:54:06< iceiceice> i think i will change the server so it doesn't send the tweaks back to server
20150306 01:54:10< iceiceice> * the host i mean
20150306 01:54:20< gfgtdf> iceiceice: the other idea is to make teh host 'wait' for teh a starting signal too liek the other players
20150306 01:54:32< iceiceice> hmm
20150306 01:54:48< gfgtdf> iceiceice: im multiplayer_... classes i mean
20150306 01:55:31< gfgtdf> iceiceice: yu know whether there ois somethign taht gets stores to teh replay if play_controller gets destructed ?
20150306 01:56:00< gfgtdf> iceiceice: i want to make  recordser a memeber of play_controller but i keep getting segfaults
20150306 01:56:16< iceiceice> uhmm
20150306 01:56:43< iceiceice> destructor of play_controller destroys alot of things :X
20150306 01:56:52< iceiceice> so... really hard to say with confidence that nothing does or doesn't
20150306 01:57:25< iceiceice> i can't think of anything off the top of my head that would write to replay like that
20150306 01:57:35< iceiceice> first suspect would be like undo stack i think
20150306 01:57:43< iceiceice> i have never really read the code fo the undo stack in detail
20150306 02:03:26< gfgtdf> iceiceice: hmm ok i just playes break pint af every code that uses recorder object but i still dont find it
20150306 02:04:30< iceiceice> maybe there is a dangling reference somewhere?
20150306 02:04:33< iceiceice> idk
20150306 02:06:58< gfgtdf> iceiceice: this is teh commit that gives me segfaults: https://github.com/gfgtdf/wesnoth-old/commit/9e898cd833a11c3d5ab1985517a329820379944e
20150306 02:08:14-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 246 seconds]
20150306 02:10:13< iceiceice> hmm ok
20150306 02:10:23< iceiceice> so in playsingle_controller, it is initializing with *resources::recorder
20150306 02:10:29< iceiceice> in the ctor
20150306 02:10:37< iceiceice> and this resources link is set in the play_controller ctor
20150306 02:10:49< iceiceice> i guess that ctor is executed before hand though?
20150306 02:11:11< iceiceice> imo its simpler to just refer to the member name inside of play_controller objects
20150306 02:11:25< iceiceice> probably its not the source of segfault though...
20150306 02:12:03< gfgtdf> iceiceice: i just replaced all "recorder." with "resources::reocorder->" by my eidtores text replace function
20150306 02:12:41< iceiceice> what was recorder before?
20150306 02:12:43< iceiceice> some extern thing?
20150306 02:13:04< gfgtdf> iceiceice: yes in extern replay rectorder in fiel replay.hpp/cpp
20150306 02:13:42< gfgtdf> iceiceice: usually id say play_constructor gests destructed after playsingle_controller
20150306 02:14:04< gfgtdf> iceiceice: also i thought replay_sender_ is doting nothign a in local game
20150306 02:14:36< iceiceice> y things are usually destructed in reverse order from constructing...
20150306 02:14:48< iceiceice> s/usually/in general have to be
20150306 02:16:10< iceiceice> is it something about replay recorder base?
20150306 02:18:10< iceiceice> what does it mean when play controller is constructing replay with "new replay"
20150306 02:18:16< iceiceice> but it requries replay_controller_base &
20150306 02:18:20< iceiceice> let me read it again...
20150306 02:19:19-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150306 02:19:40< gfgtdf> iceiceice: new replay is just the default boost::scoped_ptr to reduce includes
20150306 02:19:54< gfgtdf> i could aswell have made replay a mamber
20150306 02:20:21< iceiceice> i see
20150306 02:20:28< iceiceice> so saved game holds a replay_recorder_base
20150306 02:20:33< iceiceice> and you are constructing with reference to it
20150306 02:22:00< gfgtdf> iceiceice: yes i want teh replay to direct write into the saved_game object instead of having an own internal buffer
20150306 02:22:33< gfgtdf> iceiceice: sinc eotherwise we would waste time by cpying teh reply data around
20150306 02:22:51< gfgtdf> iceiceice: esp in long scenarios [replay] is often teh biggest part of teh data
20150306 02:23:08< iceiceice> y i think i made a forum thing about this
20150306 02:23:13< iceiceice> i cant remember what stats were
20150306 02:23:35< iceiceice> it depends on how many units you have in your scenario, and if you have a very large number of custom units
20150306 02:24:00< iceiceice> if you are in something like sxrpg, all of the stats of all of those units and their advancement tree will get written in every save
20150306 02:24:12< iceiceice> and that is not a small amount of stuff
20150306 02:24:28< iceiceice> but replay will be like 5x - 10x larger after like 50 turns or osmething
20150306 02:25:29< iceiceice> gfgtdf: if it were me, i would consider to take these lines that have resources::recorder->...
20150306 02:25:37< iceiceice> and put assert(resources::recorder); first
20150306 02:26:51< gfgtdf> iceiceice: i'm just trying moving the replay_ memeber op in the play_controller construction order (and thus down in the destruction order)  still compiling
20150306 02:26:58< gfgtdf> s/op/up
20150306 02:27:04-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.1.1]
20150306 02:27:36< gfgtdf> iceiceice: i think somewhethere in the LotI threads there was  post form someone playing > 1000 turns.
20150306 02:28:22< iceiceice> wow
20150306 02:28:50< vultraz> yeah well
20150306 02:28:53< vultraz> that's loti
20150306 02:36:43-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20150306 02:38:24-!- travis-ci [~travis-ci@ec2-54-198-179-227.compute-1.amazonaws.com] has joined #wesnoth-dev
20150306 02:38:25< travis-ci> gfgtdf/wesnoth-old#429 (replay_save - 9e898cd : gfgtdf): The build failed.
20150306 02:38:25< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/53285718
20150306 02:38:25-!- travis-ci [~travis-ci@ec2-54-198-179-227.compute-1.amazonaws.com] has left #wesnoth-dev []
20150306 02:39:37-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has quit [Remote host closed the connection]
20150306 02:42:50-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150306 02:45:04-!- kex [~kex@78.157.29.160] has quit [Remote host closed the connection]
20150306 02:55:34-!- ancestral_ [~ancestral@65-128-208-249.mpls.qwest.net] has joined #wesnoth-dev
20150306 02:55:56-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has quit [Read error: Connection reset by peer]
20150306 02:55:57-!- ancestral_ is now known as ancestral
20150306 03:19:58-!- Ivanovic_ [~ivanovic@frnk-5f74e6fb.pool.mediaWays.net] has joined #wesnoth-dev
20150306 03:19:59-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150306 03:20:22-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150306 03:21:20-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 246 seconds]
20150306 03:21:52-!- Ivanovic_ is now known as Ivanovic
20150306 03:26:09< mattsc> Hi, All.
20150306 03:26:21< mattsc> Hi ancestral.  Anything I can help with?
20150306 03:26:31-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20150306 03:26:34< ancestral> Hi!
20150306 03:28:31< ancestral> mattsc: Is there anything I should be aware of that is different with 1.13 as far as building goes?
20150306 03:28:37< ancestral> Aside from the 1.13 compile files
20150306 03:28:49< mattsc> ancestral: no, not really.
20150306 03:28:49< gfgtdf> iceiceice: ok im quiet sure this line casaues teh bug: https://github.com/wesnoth/wesnoth/blob/master/src/savegame.cpp#L188
20150306 03:29:36< iceiceice> hmmm
20150306 03:29:37< mattsc> Except that the Xcode project needs to have a file added (due to one of gfgtdf’s, I think, recent changes), but everything other than that it should work just the same.
20150306 03:30:00< mattsc> ancestral: I wrote you a PM this morning with some of the details.
20150306 03:30:12< gfgtdf> iceiceice: you know why you set teh saved game there ?
20150306 03:30:14< ancestral> So you did
20150306 03:30:56< ancestral> That’s great
20150306 03:30:57< gfgtdf> iceiceice: i see this commit: https://github.com/wesnoth/wesnoth/commit/7441a53a17b9582cc14e65b4b10e815c33205315
20150306 03:30:59< gfgtdf> iceiceice: but
20150306 03:31:34< gfgtdf> iceiceice: teh saved_game object gets reset here: https://github.com/wesnoth/wesnoth/blob/master/src/playsingle_controller.cpp#L399
20150306 03:32:36-!- travis-ci [~travis-ci@ec2-54-197-213-58.compute-1.amazonaws.com] has joined #wesnoth-dev
20150306 03:32:37< travis-ci> gfgtdf/wesnoth-old#430 (replay_save - 560a506 : gfgtdf): The build is still failing.
20150306 03:32:37< travis-ci> Build details : http://travis-ci.org/gfgtdf/wesnoth-old/builds/53289786
20150306 03:32:37-!- travis-ci [~travis-ci@ec2-54-197-213-58.compute-1.amazonaws.com] has left #wesnoth-dev []
20150306 03:32:55< gfgtdf> iceiceice: so we now read teh savegame twice ?
20150306 03:34:44< iceiceice> ok
20150306 03:34:49< iceiceice> yes i can tell you what that was about
20150306 03:34:56< iceiceice> so vultraz pointed out this bug which we fixed
20150306 03:35:01< iceiceice> there is a pr assocaited, i could find it...
20150306 03:35:03< iceiceice> its not too long ago
20150306 03:35:16< iceiceice> so it was some minor bad ui behavior,
20150306 03:35:24< iceiceice> the issue is like this
20150306 03:35:28< iceiceice> suppose that i am in the game
20150306 03:35:30< ancestral> mattsc: I’m trying a 1.13 build right now
20150306 03:35:32< iceiceice> and i select to load a save file
20150306 03:35:41< iceiceice> normally what will happen is you will throw a load game exception
20150306 03:35:42< ancestral> I mean, master
20150306 03:35:44< iceiceice> it will fly up the stack
20150306 03:35:47< iceiceice> kill the play controller
20150306 03:35:55< iceiceice> go all the way back to game controller (the back end for main menu)
20150306 03:36:15< iceiceice> then, before the screen has been redrawn, it will try to load the new file
20150306 03:36:21< iceiceice> and then it does version check
20150306 03:36:38< iceiceice> if you say yes i want to load the old save, it will go right into new play controller for that file
20150306 03:36:42< iceiceice> if you say no however,
20150306 03:36:45< iceiceice> it just dumps you back to main menu
20150306 03:36:55< iceiceice> which is not ideal
20150306 03:36:55< gfgtdf> iceiceice: hm i think you can see the version in the load game dialog ?
20150306 03:37:04< iceiceice> i think you have to read the file to do that
20150306 03:37:21< iceiceice> so i guess what should happen here is,
20150306 03:37:35< gfgtdf> iceiceice: afaik teh version is cached inteh save file index thing
20150306 03:37:47< iceiceice> maybe one way to fix it is
20150306 03:37:51< gfgtdf> iceiceice: see teh left panel in teh load game dialog
20150306 03:37:52< iceiceice> to make this function like copy and swap
20150306 03:38:03< iceiceice> so in this function the load game object will make a dummy load game
20150306 03:38:14< iceiceice> and use it to try to load and get this error log thing
20150306 03:38:30< iceiceice> but then if we cancel we do not mess up this current save_game object
20150306 03:38:40< iceiceice> does it make sense?
20150306 03:39:28< mattsc> ancestral: sounds good; Let me know if you encounter any problems.  I’ll stay logged on but will only be around on and off (family duties!).  
20150306 03:39:45< iceiceice> maybe we can also access from save index idk
20150306 03:40:18< ancestral> mattsc: Do you normally have any method to test Wesnoth on older versions of OS X, or do you just trust it will work
20150306 03:40:35< ancestral> OK I got 3 errors
20150306 03:43:02< ancestral> mattsc: https://paste.ee/p/kCy4T
20150306 03:43:08< vultraz> gfgtdf, mattsc: do you knowthe proper way to move ai_algorithm=idle_ai from a side? for some reason when I try,t he side stays idle
20150306 03:44:02< gfgtdf> iceiceice: my current problem is that if we reset teh saved_game_ object before we throw that exception i currently get segfaults from things that use teh saved_game_ maybe even during dome destructor. I think in this case i can fix it otherwise but note that we already got a a similar bug https://gna.org/bugs/?14460 fixed in https://github.com/wesnoth/wesnoth/commit/816b0fd75fbcf3d5cccd24efb3018d
20150306 03:44:04< gfgtdf> d306e2787a so i still tink it better to to reset it there
20150306 03:44:33< gfgtdf> and once again irc cut my message in a link.
20150306 03:45:29< ancestral> gfgtdf: Your last commit might have broken something
20150306 03:45:37< ancestral> https://paste.ee/p/kCy4T
20150306 03:45:46< gfgtdf> iceiceice: and the current implementation loads the savefile twice which is very inefficient
20150306 03:46:00< iceiceice> do you think it will really be noticeable?
20150306 03:46:17< gfgtdf> iceiceice: yes
20150306 03:46:51< iceiceice> i mean ideally there would be like, a scheduler object or something
20150306 03:47:00< iceiceice> and you open a job associated to some file
20150306 03:47:04< gfgtdf> s/better to to/better not to
20150306 03:47:25< iceiceice> then you wont read the file twice for one click
20150306 03:47:35< iceiceice> but the method with load game exception being extremely long range
20150306 03:47:44< iceiceice> makes it quite hard to get the logic right without loading the file twice
20150306 03:47:58< iceiceice> i guess you could like, put a pointer to the loaded file inside the exception :O
20150306 03:48:09< iceiceice> but at some point thats just going to get confusing
20150306 03:48:20< iceiceice> b/c people dont normally think of exception as carrying a massive amount of data
20150306 03:48:21< gfgtdf> iceiceice: afaik teh other things liek fielnname are also just exchanged via global variables
20150306 03:48:45< iceiceice> yeah the load game exception has a bunch of vars like that, i noticed it and had to add another in this Pr
20150306 03:48:59< ancestral> Maybe it’s a compiler thing
20150306 03:49:13< mattsc> ancestral: check out the PM I sent you  :)
20150306 03:49:20< ancestral> Ahhhhhh
20150306 03:49:25< ancestral> Of course
20150306 03:49:35< mattsc> gfgtdf added a file to the build, but he cannot do that for the Xcode builds
20150306 03:49:35< iceiceice> https://github.com/wesnoth/wesnoth/pull/344
20150306 03:49:50< mattsc> so you need to add it now (and then commit the change)
20150306 03:50:24< ancestral> gfgtdf: Ignore what I said, things are fine
20150306 03:50:32< ancestral> Sure
20150306 03:50:35< gfgtdf> iceiceice: maybe just add a saved_game member there and swap it with the real saved_game_ in game launcher class
20150306 03:50:36< ancestral> I get it
20150306 03:50:46< mattsc> ancestral: as for older system, I have an old, barely working laptop with OS X 10.5 on it.  I usually test the releases on that one once I have built them.
20150306 03:51:04-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Ping timeout: 245 seconds]
20150306 03:51:09< iceiceice> are there other places that load game is called? i dont remember now...
20150306 03:51:21< iceiceice> err that the exception is thrown i mean
20150306 03:52:18< mattsc> ancestral: I could tell you how to do it, but if you figure it out yourself, you’ll likely remember it more easily later.  But either way’s fine with me, just let me know.
20150306 03:52:36< ancestral> I got it
20150306 03:52:59< mattsc> vultraz: I believe that’s a bug.  You  cannot remove it druing the scenario.
20150306 03:53:57< vultraz> mattsc: ah...sucks :/
20150306 03:54:27< gfgtdf> iceiceice: here but i cirrently dont know what it does https://github.com/wesnoth/wesnoth/blob/master/src/hotkey_handler.cpp#L226
20150306 03:54:33< mattsc> vultraz: https://gna.org/bugs/?func=detailitem&item_id=16107
20150306 03:54:53< iceiceice> i think thats the autosaves
20150306 03:54:57< iceiceice> gfgtdf: ^
20150306 03:55:20< gfgtdf> iceiceice: no its loading not saving
20150306 03:55:27< iceiceice> y i mean like
20150306 03:55:31< iceiceice> in the main menu
20150306 03:55:46< iceiceice> the gui data file just has some entry with a sentinel like AUTOSAVES or something
20150306 03:55:55< gfgtdf> iceiceice: ah ok
20150306 03:55:57< iceiceice> and the hotkey / playcontroller code is set to automatically expand it
20150306 03:56:01< ancestral> mattsc: So, the build succeeded but the app crashes right away
20150306 03:56:11< ancestral> Once it gets to the main menu
20150306 03:56:33< iceiceice> so that one will load without checking versions or file info i think
20150306 03:56:49< iceiceice> there wont be a directory browser anyways
20150306 03:56:55< vultraz> mattsc: damn :/ and controller=null doesn't generate a leader
20150306 03:57:07< iceiceice> i guess what we could do is make load game exception hold a boost::scoped_ptr to saved_game
20150306 03:57:22< iceiceice> and if it is not null it will be swapped with the real one in game_controller
20150306 03:57:40< mattsc> ancestral: hmm, strange
20150306 03:58:05< mattsc> vultraz: no, it does not, but you can set controller=ai, and the us [modify_side] in the prestart event
20150306 03:58:12< ancestral> mattsc: Let me ask you this
20150306 03:58:35< ancestral> The compile files (headers and libs) do they merge (paste into) the project’s existing ones, or replace them?
20150306 03:58:49< ancestral> (in the Finder)
20150306 04:00:57< mattsc> ancestral: they are copied to the build directory, if that’s what you mean  (sorry for the delay; I had to watch Gonzo and his chickens)
20150306 04:01:05< ancestral> Hehe
20150306 04:01:12< ancestral> That might be my problem then
20150306 04:01:27< mattsc> ancestral: did you try to start if from Xcode or from the command-line or Finder?
20150306 04:01:34< ancestral> I think I just replaced the whole folder. Whoops
20150306 04:01:41< mattsc> starting it from Xcode never works for me.
20150306 04:01:45< ancestral> Right
20150306 04:01:50< ancestral> That’s what I discovered too
20150306 04:01:53< ancestral> From the Finder
20150306 04:02:08< ancestral> in ~/Library/Develeper/
20150306 04:02:10< mattsc> okay, I usually do it from the CL, but I think from Finder should work too.
20150306 04:03:20< mattsc> ancestral: right.  Mine is in ~/Library/Developer/Xcode/DerivedData/Wesnoth-fllovqqyuyuaoaaubwwqvyfsgrnw/Build/Products/Release/Wesnoth.app/Contents/MacOS/
20150306 04:04:06< mattsc> ancestral: I’ll have to be afk for ~20 min, will be back after that, but probably only briefly
20150306 04:04:21< gfgtdf> iceiceice: hm yes that also possible.
20150306 04:04:39< mattsc> ancestral: if you start from the CL, you might be able to get an error message that tells you what’s going on.
20150306 04:04:46< mattsc> anyways, bbl
20150306 04:05:07< ancestral> ok
20150306 04:06:06< gfgtdf> iceiceice: but i personally think if we put some things in the load_game_exception object and some thigns as global variables it just gets more confisung than having every of those loadgame parameters ad global variables.
20150306 04:06:25< iceiceice> yeah its better to do one or the other
20150306 04:06:43< iceiceice> when i said put it in the exception i really just meant in the global vars i think
20150306 04:06:51< iceiceice> idk why we are favoring to use the global vars
20150306 04:06:59< iceiceice> but i didnt think that much about it
20150306 04:12:32< gfgtdf> iceiceice: yu know whether there is a alias in git for teh curently active branch ?
20150306 04:12:44< iceiceice> HEAD is the current commit
20150306 04:12:53< iceiceice> if you are not detached then its the current branch
20150306 04:13:19< iceiceice> i guess, if there is an active branch then HEAD is it
20150306 04:13:32< iceiceice> maybe not for all purposes, i'm not a git expert
20150306 04:14:14< gfgtdf> iceiceice: my curent function to push on master looks like this:
20150306 04:14:16< gfgtdf> git fetch upstream master
20150306 04:14:17< gfgtdf> git rebase upstream/master
20150306 04:14:19< gfgtdf> git push upstream master
20150306 04:14:20< gfgtdf> But i'd like to have to 'git push upstream <current_branch>:master' instead
20150306 04:15:33< iceiceice> i think usually what i do is
20150306 04:15:39< iceiceice> git checkout master
20150306 04:15:45< iceiceice> git pull upstream master
20150306 04:15:53< iceiceice> git merge topic
20150306 04:15:56< iceiceice> git push upstream master
20150306 04:16:24< iceiceice> git branch -d topic
20150306 04:20:21< gfgtdf> iceiceice: hm ok
20150306 04:21:26-!- irker738 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150306 04:21:26< irker738> wesnoth: gfgtdf wesnoth:master bb0ecd14c075 / src/ (30 files in 7 dirs): recorder writes directly into saved_game object http://git.io/xpeo
20150306 04:21:28< irker738> wesnoth: gfgtdf wesnoth:master b9904f655764 / src/synced_context.cpp: dont do replay checkup in set_sconext_synced destructor http://git.io/xpeK
20150306 04:21:46< gfgtdf> iceiceice: git push upsteam HEAD:master worked :)
20150306 04:22:36< gfgtdf> from now on i'll use 'git push upsteam HEAD:master'
20150306 04:22:46< mattsc> ancestral: hehe - gfgtdf made you have to add another file  :)
20150306 04:23:14< mattsc> and off again
20150306 04:24:19-!- gfgtdf [~chatzilla@d150180.adsl.hansenet.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 36.0/20150222232811]]
20150306 04:27:34< mattsc> Hmm, grammar does not appear to be my forte tonight.
20150306 04:28:08< iceiceice> gfgtdf: :)
20150306 04:28:37< mattsc> ancestral: I’ll have to run off; not sure when I’ll be back.  Sorry, I’ll read the logs though, or just write me a PM.
20150306 04:32:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Not here much atm. Will check logs for my nick and forum PMs.]
20150306 04:38:30-!- travis-ci [~travis-ci@ec2-54-198-179-227.compute-1.amazonaws.com] has joined #wesnoth-dev
20150306 04:38:31< travis-ci> wesnoth/wesnoth#5881 (master - b9904f6 : gfgtdf): The build was broken.
20150306 04:38:31< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/53294109
20150306 04:38:31-!- travis-ci [~travis-ci@ec2-54-198-179-227.compute-1.amazonaws.com] has left #wesnoth-dev []
20150306 04:50:48< iceiceice> wow
20150306 04:50:53< iceiceice> github got cofnused somehow i think,
20150306 04:51:07< iceiceice> our little language bar looks very differnet now...
20150306 04:51:20< iceiceice> maybe its just more accurate
20150306 04:51:34< iceiceice> project went from being 80% C++ or something, to 95% gettext catalogue and 3.5% c++
20150306 04:58:12< vultraz> hah!
20150306 05:03:27-!- Jetrel [~Jetrel@c-73-164-34-22.hsd1.mn.comcast.net] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20150306 05:04:20-!- Jetrel [~Jetrel@c-73-164-34-22.hsd1.mn.comcast.net] has joined #wesnoth-dev
20150306 05:15:04-!- groggy [4b8fb389@gateway/web/freenode/ip.75.143.179.137] has joined #wesnoth-dev
20150306 05:18:08< vultraz> so, something I was pondering that doesn't have to do with total engine rewrites is how to improve [object]. 
20150306 05:18:43< vultraz> it seems a bit weird that the gamestate keeps track of object ids, for one
20150306 05:19:28< vultraz> shouldn't that be done somewhere higher up
20150306 05:22:54< vultraz> still looking for how duration is implemented
20150306 05:26:06< iceiceice> shadowm: http://forums.wesnoth.org/viewtopic.php?f=16&t=41701
20150306 05:35:32-!- new_one [~new_one@50.15.126.83] has quit [Quit: WeeChat 1.1.1]
20150306 05:38:26-!- travis-ci [~travis-ci@ec2-54-197-213-58.compute-1.amazonaws.com] has joined #wesnoth-dev
20150306 05:38:27< travis-ci> cbeck88/wesnoth#128 (fixup_server_controller_tweaks_1.12 - 1544538 : Chris Beck): The build passed.
20150306 05:38:27< travis-ci> Build details : http://travis-ci.org/cbeck88/wesnoth/builds/53297443
20150306 05:38:27-!- travis-ci [~travis-ci@ec2-54-197-213-58.compute-1.amazonaws.com] has left #wesnoth-dev []
20150306 05:42:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150306 06:33:12-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Remote host closed the connection]
20150306 06:41:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150306 06:48:01-!- Ivanovic [~ivanovic@frnk-5f74e6fb.pool.mediaWays.net] has quit [Changing host]
20150306 06:48:01-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20150306 07:08:51-!- ancestral [~ancestral@65-128-208-249.mpls.qwest.net] has quit [Quit: End Transmission.]
20150306 07:58:24-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20150306 07:58:24-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Changing host]
20150306 07:58:24-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150306 08:03:50-!- irker738 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150306 08:42:00-!- [Relic] [~Relic]@2602:306:33a3:6d30:c62:b32c:2add:84ab] has quit [Quit: Leaving]
20150306 08:42:15-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150306 08:44:59-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150306 08:45:02-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds]
20150306 08:49:53-!- mjs-de [~mjs-de@g228170238.adsl.alicedsl.de] has joined #wesnoth-dev
20150306 09:13:52-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 264 seconds]
20150306 09:20:08-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150306 09:49:12-!- aquileia [863c36a3@gateway/web/freenode/ip.134.60.54.163] has joined #wesnoth-dev
20150306 09:50:05< vultraz> hey aquileia 
20150306 09:50:12< aquileia> Hi
20150306 09:51:15< aquileia> iceiceice, vultraz: The .po files are indeed enormous... When exactly did the change happen?
20150306 09:53:50< vultraz> no idea
20150306 09:56:56< aquileia> I'm looking at https://github.com/github/linguist/commits/master and the commit I suspect is 21 days old
20150306 09:58:25< aquileia> Of course, we could open a PR for them to exclude /po and /translation directories from language recognition
20150306 09:59:20< aquileia> s/recognition/statistics
20150306 09:59:35< aquileia> https://github.com/github/linguist/blob/master/lib/linguist/vendor.yml is the file
20150306 10:01:17< aquileia> "vendor" because its used mainly for external dependencies, but it has rules for documentation files as well, so translations would be a valid addition I think
20150306 10:03:17< aquileia> the (possibly better, but that'd break statistics for pure translation repositories) alternative would be to reclassify gettext from "markup" to "prose" so that the whole language is ignored
20150306 10:05:06< aquileia> In fact, they classify it as "programming" ? I think that's a bug on their side...
20150306 10:08:58-!- groggy [4b8fb389@gateway/web/freenode/ip.75.143.179.137] has quit [Ping timeout: 246 seconds]
20150306 10:12:02-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 265 seconds]
20150306 10:13:30< aquileia> If we want a workaround, we can add a rule to our .gitattributes file: https://github.com/github/linguist/tree/master#using-gitattributes
20150306 10:14:25< aquileia> vultraz: Do you think we should do that workaround for now?
20150306 10:18:34-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150306 10:28:58< aquileia> Now I can tell you: It happened 13 hours ago, when the commit tht classified gettext as programming was included in their new release
20150306 10:33:52-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20150306 10:34:39< vultraz> aquileia: file a PR or bugfix, or do the rule
20150306 10:36:49< aquileia> The workaround would fix it for us unit their next release, so... how much of an issue is it to us not being classified as a C++ project?
20150306 10:37:02< aquileia> s/unit/until
20150306 10:38:05< vultraz> not really an issue, I guess
20150306 10:38:08< vultraz> but it looks weird
20150306 10:38:13< vultraz> and may be misleading
20150306 10:38:17< aquileia> ok
20150306 10:38:39< aquileia> have to go now, I'll do a PR on their side
20150306 10:38:43< aquileia> bye
20150306 10:41:35-!- aquileia [863c36a3@gateway/web/freenode/ip.134.60.54.163] has quit [Quit: Page closed]
20150306 11:18:22-!- groggy [4b8fb389@gateway/web/freenode/ip.75.143.179.137] has joined #wesnoth-dev
20150306 11:20:36-!- travis-ci [~travis-ci@ec2-54-159-165-40.compute-1.amazonaws.com] has joined #wesnoth-dev
20150306 11:20:37< travis-ci> cbeck88/wesnoth#129 (fixup_server_controller_tweaks - aa375f0 : Chris Beck): The build failed.
20150306 11:20:37< travis-ci> Build details : http://travis-ci.org/cbeck88/wesnoth/builds/53323530
20150306 11:20:37-!- travis-ci [~travis-ci@ec2-54-159-165-40.compute-1.amazonaws.com] has left #wesnoth-dev []
20150306 11:24:08-!- irker048 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150306 11:24:08< irker048> wesnoth: Chris Beck wesnoth:master 95e1f26c5c46 / src/ (replay_recorder_base.cpp replay_recorder_base.hpp): fix compilation http://git.io/xh39
20150306 11:33:05< groggy> The split function in wml-tags.lua will leave trailing whitespace in comma-separated lists. A couple of functions that call it then use trim() to strip the result, but not all.
20150306 11:33:24< groggy> For attributes not defined in lua that take comma-separated values: is there a standard function in src used to parse them, and does it strip trailing whitespace or not? Or are there a hodgepodge of functions used in different places, which may or may not strip right-side whitespace?
20150306 11:34:35-!- travis-ci [~travis-ci@ec2-54-197-213-58.compute-1.amazonaws.com] has joined #wesnoth-dev
20150306 11:34:36< travis-ci> cbeck88/wesnoth#130 (master - b9904f6 : gfgtdf): The build was broken.
20150306 11:34:36< travis-ci> Build details : http://travis-ci.org/cbeck88/wesnoth/builds/53323537
20150306 11:34:36-!- travis-ci [~travis-ci@ec2-54-197-213-58.compute-1.amazonaws.com] has left #wesnoth-dev []
20150306 11:35:18 * vultraz has no idea
20150306 11:36:09< vultraz> looks like utils::split is used
20150306 11:38:47-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150306 11:38:56< iceiceice> groggy: i think for things like unit filters, side filters,
20150306 11:39:04< iceiceice> we use a function utils::split
20150306 11:39:10< iceiceice> in serialization/string_utils
20150306 11:39:22< iceiceice> it has some flags regarding trimming and such
20150306 11:39:44< iceiceice> i think the default is to remove empty elements and trim whitespace
20150306 11:40:03< vultraz>  *                    REMOVE_EMPTY causes empty pieces to be skipped/removed.
20150306 11:40:04< vultraz>  *                    STRIP_SPACES causes the leading and trailing spaces of each piece to be ignored/stripped
20150306 11:40:18< groggy> thanks
20150306 11:40:33-!- horrowin1 [~Icedove@2a02:810a:8b40:60c8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150306 11:45:20< groggy> shadowm: I noticed that a couple of blog posts that used to be on your site are gone. Were they lost in the move, or did you decide to delete them?
20150306 11:47:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150306 11:48:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20150306 11:50:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150306 11:51:07-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20150306 11:51:40-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 264 seconds]
20150306 11:53:49-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 255 seconds]
20150306 11:57:08-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150306 12:05:30-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20150306 12:05:39-!- travis-ci [~travis-ci@ec2-54-197-213-58.compute-1.amazonaws.com] has joined #wesnoth-dev
20150306 12:05:40< travis-ci> wesnoth/wesnoth#5884 (master - 95e1f26 : Chris Beck): The build was fixed.
20150306 12:05:40< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/53325455
20150306 12:05:40-!- travis-ci [~travis-ci@ec2-54-197-213-58.compute-1.amazonaws.com] has left #wesnoth-dev []
20150306 12:06:08< vultraz> how do you upload something to our files on sf?
20150306 12:08:56< aquileia> vultraz: You are no member there I think, so you'll have to send it to one of these: http://sourceforge.net/p/wesnoth/_members/
20150306 12:09:56< vultraz> ah
20150306 12:11:21-!- travis-ci [~travis-ci@ec2-54-197-213-58.compute-1.amazonaws.com] has joined #wesnoth-dev
20150306 12:11:22< travis-ci> cbeck88/wesnoth#131 (xBRZ - a28082c : Chris Beck): The build passed.
20150306 12:11:22< travis-ci> Build details : http://travis-ci.org/cbeck88/wesnoth/builds/53325484
20150306 12:11:22-!- travis-ci [~travis-ci@ec2-54-197-213-58.compute-1.amazonaws.com] has left #wesnoth-dev []
20150306 12:15:08-!- Necrosporus_ is now known as Necrosporus
20150306 12:15:46-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 265 seconds]
20150306 12:18:54-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150306 12:21:19< irker048> wesnoth: aquileia wesnoth:master 84f61dc51ddc / projectfiles/VC9/wesnoth.vcproj: vcproj: Update for bb0ecd14c http://git.io/xhzN
20150306 12:24:06-!- Sulfur [~Miranda@p5B0085CC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150306 12:25:27-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 250 seconds]
20150306 12:26:04-!- kex [~kex@77.28.5.181] has joined #wesnoth-dev
20150306 12:26:09< vultraz> iceiceice: alright if I commit  the png compile support for codeblocks?
20150306 12:26:23< iceiceice> sure why not
20150306 12:27:33< vultraz> I'll have to get someone to upload the updated lib zip soon
20150306 12:28:19-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150306 12:31:28-!- travis-ci [~travis-ci@ec2-54-197-213-58.compute-1.amazonaws.com] has joined #wesnoth-dev
20150306 12:31:29< travis-ci> cbeck88/wesnoth#132 (1.10 - 44cf1d4 : Chris Beck): The build failed.
20150306 12:31:29< travis-ci> Build details : http://travis-ci.org/cbeck88/wesnoth/builds/53325495
20150306 12:31:29-!- travis-ci [~travis-ci@ec2-54-197-213-58.compute-1.amazonaws.com] has left #wesnoth-dev []
20150306 12:31:49< vultraz> 1.10?
20150306 12:36:24< irker048> wesnoth: Charles Dang wesnoth:master 65965e8f6fb9 / projectfiles/CodeBlocks/wesnoth.cbp: Allow compiling with png support in codeblocks http://git.io/xhV5
20150306 12:36:27< irker048> wesnoth: Charles Dang wesnoth:master bb0e67d784d9 / projectfiles/CodeBlocks/wesnoth.cbp: Updated codeblocks projfile for bb0ecd14c http://git.io/xhVd
20150306 12:41:16< irker048> wesnoth: Charles Dang wesnoth:master 571999462f82 / data/core/editor/brushes.cfg: Corrected an incorrect brush name http://git.io/xhrJ
20150306 12:41:50< iceiceice> vultraz: i accidentally pushed every branch to my fork
20150306 12:42:22< iceiceice> vultraz: you shouldn't need to update the lib zip,
20150306 12:42:26< iceiceice> since libpng should already be in there
20150306 12:43:00< iceiceice> gfgtdf: i made a pr here: https://github.com/wesnoth/wesnoth/pull/380
20150306 12:43:22< iceiceice> i thought about what you were saying about making the host wait for start,
20150306 12:43:42< iceiceice> maybe we should do that on master, on 1.12 i guess its best to do this server-sided fix
20150306 12:45:14-!- groggy [4b8fb389@gateway/web/freenode/ip.75.143.179.137] has quit [Quit: Page closed]
20150306 12:46:02< vultraz> iceiceice: it wasn't
20150306 12:46:10< vultraz> 2 dlls were, however, but it was missing the 3rd
20150306 12:46:15< vultraz> and had no libs or includes
20150306 12:46:20< vultraz> or zlib libs
20150306 12:46:39< iceiceice> theres no way you could compile and run the game without libpng and zlib
20150306 12:50:21-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 244 seconds]
20150306 12:50:52< vultraz> look at it yourself
20150306 12:51:53< vultraz> http://sourceforge.net/projects/wesnoth/files/unofficial/Windows%20Compile%20Stuff/CodeBlocksWinSDK_28_11_2014.zip/download
20150306 13:00:05-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150306 13:06:58-!- markus__ [~mjs-de@f049230028.adsl.alicedsl.de] has joined #wesnoth-dev
20150306 13:07:29< aquileia> iceiceice: Doesn't it fall back to bzip if it can't find zlib? Not sure however
20150306 13:10:23-!- mjs-de [~mjs-de@g228170238.adsl.alicedsl.de] has quit [Ping timeout: 252 seconds]
20150306 13:11:42-!- gfgtdf [~chatzilla@d150180.adsl.hansenet.de] has joined #wesnoth-dev
20150306 13:12:07-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 255 seconds]
20150306 13:12:42< gfgtdf> vultraz: you can implement [object] completely in lua.
20150306 13:14:09< gfgtdf> iceiceice: any thx for fixing up my commit
20150306 13:14:16< gfgtdf> s/any/and
20150306 13:15:09-!- travis-ci [~travis-ci@ec2-54-159-165-40.compute-1.amazonaws.com] has joined #wesnoth-dev
20150306 13:15:10< travis-ci> wesnoth/wesnoth#5886 (master - bb0e67d : Charles Dang): The build was broken.
20150306 13:15:10< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/53332482
20150306 13:15:10-!- travis-ci [~travis-ci@ec2-54-159-165-40.compute-1.amazonaws.com] has left #wesnoth-dev []
20150306 13:16:59-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150306 13:19:04-!- travis-ci [~travis-ci@ec2-54-159-165-40.compute-1.amazonaws.com] has joined #wesnoth-dev
20150306 13:19:05< travis-ci> cbeck88/wesnoth#134 (fixup_server_controller_tweaks - 56e685b : Chris Beck): The build was fixed.
20150306 13:19:05< travis-ci> Build details : http://travis-ci.org/cbeck88/wesnoth/builds/53325573
20150306 13:19:05-!- travis-ci [~travis-ci@ec2-54-159-165-40.compute-1.amazonaws.com] has left #wesnoth-dev []
20150306 13:25:42-!- kex [~kex@77.28.5.181] has quit [Read error: Connection reset by peer]
20150306 13:52:42-!- gfgtdf [~chatzilla@d150180.adsl.hansenet.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 35.0.1/20150122214805]]
20150306 14:14:48-!- markus__ is now known as mjs-de
20150306 14:15:04-!- Haudegen [~quassel@85.124.51.57] has quit [Remote host closed the connection]
20150306 14:16:05-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150306 14:26:19-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Quit: Page closed]
20150306 14:28:19-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has joined #wesnoth-dev
20150306 14:44:08-!- happygrue [~Laptop@wesnoth/developer/wintermute] has joined #wesnoth-dev
20150306 14:48:52-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 252 seconds]
20150306 14:56:46-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150306 15:09:12-!- gfgtdf [~chatzilla@d150180.adsl.hansenet.de] has joined #wesnoth-dev
20150306 15:09:20< gfgtdf> iceiceice: online ?
20150306 15:09:44-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 246 seconds]
20150306 15:14:18< vultraz> gfgtdf: N_ makes strings not use translations, right?
20150306 15:14:29< gfgtdf> vultraz: afaik yes
20150306 15:14:34< gfgtdf> vultraz: but
20150306 15:15:06< gfgtdf> vultraz: thats unly becasue that are translated later.
20150306 15:15:09< gfgtdf> only*
20150306 15:15:15< vultraz> I'm looking at this http://forums.wesnoth.org/viewtopic.php?p=580885#p580885 
20150306 15:15:29< vultraz> I think...just remove the N
20150306 15:15:31< vultraz> not sure
20150306 15:15:51< gfgtdf> vultraz: hm yes
20150306 15:15:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150306 15:15:57< gfgtdf> vultraz: that code looks broken
20150306 15:16:14< vultraz> which one?
20150306 15:17:27< gfgtdf> the one that uses "\n "<< N_("somestring") << "otherstring"
20150306 15:17:39< gfgtdf> vultraz: you know what this post is saying: http://forums.wesnoth.org/viewtopic.php?f=6&p=581581#p581581 ?
20150306 15:17:58-!- new_one [~new_one@50.15.126.83] has joined #wesnoth-dev
20150306 15:18:40< vultraz> gfgtdf: he's saying people bitch when someone plays defensive and people want their opponents not to be defensive, only offensive, since it would make the game go faster
20150306 15:18:52-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev
20150306 15:19:06< gfgtdf> vultraz: and aht is he suggesting against it ?
20150306 15:20:58< vultraz> the second post is, i think, suggesting turn limits for MP games
20150306 15:21:07< vultraz> or some form of that
20150306 15:21:09< vultraz> ....not sure
20150306 15:21:49< gfgtdf> vultraz: hm ok, i guess i'll ignore it.
20150306 15:24:43< vultraz> anyway, I just remove the N to fix the second issue in the post I linked?
20150306 15:24:48< vultraz> I dunno about the first one
20150306 15:24:51< vultraz> I get errors if I add _
20150306 15:25:10< vultraz> and I'm trying to figure out the one about brush hotkeys
20150306 15:25:13< gfgtdf> vultraz: what errors?
20150306 15:25:22< gfgtdf> vultraz: in c++ cou ned brackes afte the _
20150306 15:25:28< gfgtdf> vultraz: _("somestring")
20150306 15:25:53< gfgtdf> vultraz: basicly _ is just a bormal function
20150306 15:26:00< gfgtdf> normal*
20150306 15:26:22< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\hotkey\hotkey_preferences_display.cpp|134|error: cannot convert 'std::string' to 'const char*' in initialization|
20150306 15:26:52-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150306 15:26:55< gfgtdf> vultraz: ah yes
20150306 15:27:02< gfgtdf> the _ functionretrns a std::string
20150306 15:28:05< gfgtdf> vultraz: you shoudl try to change teh type of the add_button_text valiable to std::string then
20150306 15:29:48< vultraz> ah, here
20150306 15:29:50< vultraz> static const char* add_button_text;
20150306 15:30:21-!- localuser- [~none@unaffiliated/localuser-] has quit [Read error: Connection reset by peer]
20150306 15:31:15< vultraz> uhh
20150306 15:31:17< vultraz> const std::string   add_text = vgettext(add_button_text, symbols);
20150306 15:31:31< vultraz> apparently vgettext takes a char 
20150306 15:31:32< vultraz> not a string
20150306 15:31:42 * vultraz has no idea what is going on here
20150306 15:32:08< vultraz> what does vgettext do anyway
20150306 15:32:11< gfgtdf> you cna use .c_str() mrethof of std string 
20150306 15:32:21< gfgtdf> vgettext translated
20150306 15:32:29< gfgtdf> translates
20150306 15:32:54< gfgtdf> since vgettext does teh trasnlation add_button_text shoudl be not translated
20150306 15:33:02< gfgtdf> (otherwise it might get tasnlated teice)
20150306 15:33:23< vultraz> I see...
20150306 15:34:12< vultraz> so they aren't untranslatable?
20150306 15:34:22< gfgtdf> vultraz: i think not
20150306 15:34:31< vultraz> ok
20150306 15:34:49< vultraz> but the second issue with the N_ still is a thing, right?
20150306 15:35:41< gfgtdf> vultraz: i'd say yet but i cannot say for sure
20150306 15:36:00< gfgtdf> vultraz: i think the other strings (add_button_text) shoudl also get a N_
20150306 15:36:26< gfgtdf> vultraz: afaik the N_ is basicly  a note that tghos string gets translated later but doest do anything
20150306 15:36:55< AI0867> _ = gettext call (and notify xgettext to extract this string)
20150306 15:37:04< AI0867> N_ = no-op (but still notify xgettext)
20150306 15:37:17< AI0867> vgettext = gettext + symbol interpolation
20150306 15:37:26< AI0867> ngettext = gettext with plural forms
20150306 15:37:41-!- Sulfur [~Miranda@p5B0085CC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150306 15:38:05< AI0867> so you use N_ when this is a translatable string, but you want the original form for now, and pass it through gettext later
20150306 15:38:33< vultraz> as in this furst case?
20150306 15:38:37< vultraz> first*
20150306 15:38:47< AI0867> which first case?
20150306 15:38:58< AI0867> I haven't read the entire convo
20150306 15:39:22< vultraz> http://forums.wesnoth.org/viewtopic.php?p=580885#p580885 here
20150306 15:39:26< gfgtdf> i wonder whether should put new wml features/tags in the RL or not.
20150306 15:40:10< vultraz> that string runs through vgettext later, so should it be marked with N_
20150306 15:41:15< iceiceice> gfgtdf: online now
20150306 15:41:27-!- irker048 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150306 15:41:57< gfgtdf> iceiceice: i originaly wanted to ask you teh same question that i asked vultraz but i dont think its important anympore
20150306 15:42:42< AI0867> I'm not quite sure what's going on in theme.cpp
20150306 15:42:52< AI0867> I'd need a bit more time to look at it, and I'm rather busy right now
20150306 15:44:01< iceiceice> vultraz, aquileia: i think scons will require you to have zlib, i had issues with this when cross compiling
20150306 15:44:07< iceiceice> but maybe other methods do a fallback instead
20150306 15:44:16-!- [Relic] [~Relic]@2602:306:33a3:6d30:4c33:6a76:597b:785a] has joined #wesnoth-dev
20150306 15:44:28< vultraz> I did have the zlib dll, but that's it
20150306 15:45:02< iceiceice> i think usually you have to have boost compiled with zlib support
20150306 15:46:19< iceiceice> and you should have libpng in your sdl, if not externally linked
20150306 15:46:40< iceiceice> i guess maybe loony was statically linking libpng into sdl image or something
20150306 15:47:28< iceiceice> gfgtdf: i think my fix actually wasn't great, it should be "" not <> around config.hpp
20150306 15:47:54< gfgtdf> iceiceice: ah yes
20150306 15:47:57< gfgtdf> iceiceice: i didnt see
20150306 15:49:46-!- irker303 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150306 15:49:46< irker303> wesnoth: Chris Beck wesnoth:master 49fca8620612 / src/playsingle_controller.cpp: refactor a boolean expression for clarity http://git.io/xjAR
20150306 15:49:46< irker303> wesnoth: Chris Beck wesnoth:master 9129ed943ab7 / / (3 files in 3 dirs): Merge branch 'master' of https://github.com/wesnoth/wesnoth http://git.io/xjA0
20150306 15:57:32< gfgtdf> iceiceice: the 1.13 RELEADE_NOTES look broken to be
20150306 15:57:55< gfgtdf> iceiceice: the last [section] tag is not closed
20150306 15:57:58< gfgtdf> release*
20150306 15:58:20< iceiceice> y u are right
20150306 16:17:47-!- Sulfur [~Miranda@p5B0085CC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150306 16:21:11-!- vincent_c [~bip@107.191.117.101] has quit [Ping timeout: 246 seconds]
20150306 16:21:59-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev
20150306 16:27:55-!- [Relic] [~Relic]@2602:306:33a3:6d30:4c33:6a76:597b:785a] has quit [Quit: Leaving]
20150306 16:33:10-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150306 16:40:19< gfgtdf> iceiceice: i just tested tht if i revert https://github.com/wesnoth/wesnoth/commit/7441a53a17b9582cc14e65b4b10e815c33205315 i can speedup loading by more than one second.
20150306 16:41:19< iceiceice> that is really surprising to me
20150306 16:41:33< iceiceice> i understand why parsing the entire game config takes like ~6 seconds or something
20150306 16:42:24< iceiceice> it does not take me 1 second to load a save
20150306 16:42:49< iceiceice> its basically instant on my machine
20150306 16:42:59< iceiceice> i have a solid-state hard drive though
20150306 16:43:23< iceiceice> do you think that it is parsing the save file that is slow?
20150306 16:43:43< iceiceice> are you trying to load the crazy LoTI saves or smth?
20150306 16:43:59< iceiceice> i definitely had a harder time to load SXRPG saves back when i played that
20150306 16:44:03< gfgtdf> iceiceice: i tested with a LotI save from turn 4.
20150306 16:44:10< iceiceice> hmm ok
20150306 16:44:38< gfgtdf> iceiceice: ~1mb compremized. 12mp uncompremized
20150306 16:45:06< gfgtdf> mb*
20150306 16:47:55< gfgtdf> iceiceice: readin eth uncomprelized file takes about teh same time as teh compremized file
20150306 16:48:35< gfgtdf> iceiceice: with your commit 2.6 second without it 1.6 seconds.
20150306 16:49:48< iceiceice> ok
20150306 16:50:49< vultraz> interesting...
20150306 16:51:20< gfgtdf> iceiceice: i mad e abug report
20150306 16:51:26< vultraz> but do we want to lose that functionality :/
20150306 16:52:21< iceiceice> gfgtdf: if you are asking me to solve it, what i would do is do what i said yesterday i think
20150306 16:52:33< iceiceice> with adding a scoped ptr to load_game::
20150306 16:53:07< gfgtdf> vultraz: it i had to choose between the functionalitily of early version checks and 1 seconds when loading a save it'd take the 1 second. But actually it should be possible to have both.
20150306 16:57:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150306 16:59:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150306 17:12:46-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150306 17:24:39-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20150306 17:25:27< irker303> wesnoth: Chris Beck wesnoth:master 31b192f1ed3c / src/replay_recorder_base.hpp: fixup include http://git.io/peH5
20150306 17:25:29< irker303> wesnoth: Chris Beck wesnoth:master 3a200ba8962b / RELEASE_NOTES: fix formatting in RELEASE_NOTES http://git.io/peHd
20150306 17:26:18< iceiceice> gfgtdf: you have opinion abou tthis? https://github.com/wesnoth/wesnoth/pull/379
20150306 17:37:37< gfgtdf> iceiceice:hm for 1.12 i think it's fine
20150306 17:40:35< irker303> wesnoth: gfgtdf wesnoth:master bc12e3ce0079 / RELEASE_NOTES: Update RELEASE_NOTES http://git.io/peAp
20150306 17:41:37-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150306 17:45:10-!- Appleman1234 [~Appleman1@CPE-121-208-6-89.bqzl1.cha.bigpond.net.au] has quit [Read error: Connection reset by peer]
20150306 17:46:01< gfgtdf> iceiceice: i assume you have tested that it fixes it?
20150306 17:50:04< iceiceice> it fixes low
20150306 17:50:19< iceiceice> i haven't tested it enough to merge it yet
20150306 17:51:45< vultraz> I still can't tell the difference between [full_heal] and [heal_unit] amount=full...
20150306 17:51:53< gfgtdf> vultraz: i agree
20150306 17:52:08< gfgtdf> vultraz: i think [full_heal] is a 1.13 feature
20150306 17:52:12< vultraz> yes
20150306 17:52:13< gfgtdf> vultraz: so wecan still remove it
20150306 17:52:17< gfgtdf> we can*
20150306 17:52:29< gfgtdf> vultraz: i think bumbadadabum implemented it ?
20150306 17:52:32< vultraz> I used it in one place in DiD, though, so if you do, please change that
20150306 17:53:29< gfgtdf> bumbadadabum: whats rhe reason for [full_heal] ?
20150306 17:54:20-!- horrowin1 [~Icedove@2a02:810a:8b40:60c8:21b:fcff:fee3:c3ff] has quit [Quit: horrowin1]
20150306 18:06:52< bumbadadabum> gfgtdf: Oh I rewrote the WML macro in lua
20150306 18:07:02< bumbadadabum> I-I didn't know there was a full heal thing
20150306 18:07:15< bumbadadabum> seeing as it wasn't implemented in the macro or documented anywhere
20150306 18:10:31< vultraz> bumbadadabum: plz implement [modify_chance_to_hit]
20150306 18:10:47< bumbadadabum> vultraz: not right now, but maybe in the future
20150306 18:11:11< vultraz> (I have no idea how the CTH forcing works anyway)
20150306 18:12:01< gfgtdf> bumbadadabum: i thought it was implemented in teh wiki
20150306 18:12:11< bumbadadabum> gfgtdf: was it?
20150306 18:12:18< bumbadadabum> I might have missed it
20150306 18:12:20-!- [Relic] [~Relic]@2602:306:33a3:6d30:4c33:6a76:597b:785a] has joined #wesnoth-dev
20150306 18:12:21< bumbadadabum> in which case... fuck
20150306 18:12:25< gfgtdf> bumbadadabum: http://wiki.wesnoth.org/DirectActionsWML#.5Bheal_unit.5D
20150306 18:13:42< gfgtdf> i dont knww hetehr it supports ignore_status though
20150306 18:14:45< bumbadadabum> uhh I might merge the 2 features later
20150306 18:14:48< bumbadadabum> my bad
20150306 18:14:57-!- lipkab [~the_new_l@host-91-147-211-47.biatv.hu] has joined #wesnoth-dev
20150306 18:16:00< gfgtdf> bumbadadabum: afaik [heal_unit] is curently implemented in c++
20150306 18:16:07< bumbadadabum> ah...
20150306 18:16:09< bumbadadabum> well...
20150306 18:16:23< bumbadadabum> I could instead implement heal_unit in lua?
20150306 18:16:44< gfgtdf> I'd appreciate that
20150306 18:17:00< bumbadadabum> currently a bit busy with uni tho
20150306 18:17:05< bumbadadabum> so probably next week
20150306 18:18:07< gfgtdf> bumbadadabum: ok
20150306 18:19:24< Ravana_> bumbadadabum: is http://forums.wesnoth.org/viewtopic.php?f=19&t=38109&p=561549#p561549 still true?
20150306 18:19:53< bumbadadabum> yeah I don't mind anyone adding it to ageless
20150306 18:19:56< bumbadadabum> it's GPL after all
20150306 18:19:57< Ravana_> ok
20150306 18:22:40< bumbadadabum> anyone familiar with C here who can answer a completely unrelated question?
20150306 18:23:14< gfgtdf> bumbadadabum: most of us know c++.
20150306 18:23:27< bumbadadabum> yeah... there's still hope though...
20150306 18:23:42< gfgtdf> c is similar i think
20150306 18:31:43-!- gfgtdf [~chatzilla@d150180.adsl.hansenet.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 36.0.1/20150305021524]]
20150306 18:36:09-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150306 18:37:15< Sulfur> Is there an event that I can use to check if a specific enemy side has been defeated (no leader left, no units left, etc.)?
20150306 18:38:05-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has quit [Remote host closed the connection]
20150306 18:42:18-!- gfgtdf [~chatzilla@d150180.adsl.hansenet.de] has joined #wesnoth-dev
20150306 18:42:41< Ravana_> die event might be convenient
20150306 18:42:45< gfgtdf> Sulfur: there is a 'lost' member of side that is updated when the defeat condistion was czhecked
20150306 18:42:58< gfgtdf> Sulfur: it not an even though
20150306 18:43:00< gfgtdf> event*
20150306 18:43:18< gfgtdf> Sulfur: and i also dont know whether it can be accesed without lua.
20150306 18:43:19-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20150306 18:43:34< gfgtdf> checked*
20150306 18:44:12< gfgtdf> Sulfur: not that the defeat confistion is checked after all events that were involked by that uder action have been fired.
20150306 18:44:15< gfgtdf> note*
20150306 18:44:45< Sulfur> I guess a work-around with a die event and [have_unit] could work
20150306 18:45:15< Ravana_> with [filter_condition]
20150306 18:46:00< Sulfur> Other than that, a 'side X defeated' event might be useful to some guys and I guess it offers some nice new scenario mechanics
20150306 18:46:24< Sulfur> +would
20150306 18:48:24< gfgtdf> Sulfur: feel free to open a feature request (with a usecase)
20150306 18:58:41< iceiceice> Sulfur: it would make it a little confusing,
20150306 18:58:51< iceiceice> what happens if we are checking the defeat conditions
20150306 18:59:01< iceiceice> and a side is defeated, but then an event fires and its not defeated
20150306 18:59:16< iceiceice> and instead a different side is defeated that wasn't defeated before
20150306 18:59:43< gfgtdf> iceiceice: but isnt same true for teh 'enemied defeated' event that we currently have?
20150306 19:00:32< iceiceice> i guess in that one we just dont update any of the checks
20150306 19:01:00< gfgtdf> iceiceice: hm yes
20150306 19:01:17< iceiceice> idk if i had been a developer X many years ago i would not have added that event i think :p
20150306 19:02:00< gfgtdf> iceiceice: well it is used if vicrtory_if_enemied_defeated ?= no i think
20150306 19:03:16-!- noy [~Noy@63.92.248.89] has joined #wesnoth-dev
20150306 19:03:19< iceiceice> this is what i wrote about it: http://wiki.wesnoth.org/ScenarioWML#Scenario_End_Conditions
20150306 19:03:37-!- noy [~Noy@63.92.248.89] has quit [Changing host]
20150306 19:03:37-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150306 19:05:01< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/play_controller.cpp#L889
20150306 19:06:26< iceiceice> i think its like this
20150306 19:06:51< iceiceice> if "victory when enemies defeated" is true
20150306 19:07:02< iceiceice> well, regardless of that flag, the enemies defeated event will be fired
20150306 19:07:32< gfgtdf> iceiceice: hm yes
20150306 19:07:39< iceiceice> i don't think that enemies defeated can change the "victory when enemies defeated" value
20150306 19:07:50< gfgtdf> iceiceice: no faik it cant
20150306 19:07:57< gfgtdf> afaik*
20150306 19:07:58< iceiceice> so if it is true, i think the scenario is going to end when enemies defeated happens
20150306 19:08:05< gfgtdf> iceiceice: yes
20150306 19:08:26< iceiceice> even if enemies defeated somehow tries to change everything so that the sides aren't defeated anymore
20150306 19:08:44< iceiceice> but i don't really mind that
20150306 19:08:56< gfgtdf> iceiceice: but one can for example hva an [end_level] in it, so taht for example it can activate godl bonus if a certainc ondition is true
20150306 19:09:15< iceiceice> yes
20150306 19:09:18< gfgtdf> in enemied defeated event i mean
20150306 19:10:05< iceiceice> i just think that its best if "check_victory" is simple,
20150306 19:10:16< iceiceice> like if i can see the unit map and the team configurations, i know what the outcome should be
20150306 19:10:25< iceiceice> if it involves like recursively firing some series of events
20150306 19:10:39< iceiceice> it just seems potentially very complicated to debug sometimes then
20150306 19:11:00-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150306 19:11:04< iceiceice> it makes more sense to me that, the game has some flags like defeat condition built-in, and beyond that you should use [end_level] tags
20150306 19:12:02< iceiceice> that means that if check_victory is firing many different events, people might be confused because they will say "why did it ignore what my wml did"
20150306 19:12:13< gfgtdf> iceiceice: hm y i see
20150306 19:15:16< iceiceice> i have to go i will be back later
20150306 19:15:17-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150306 19:16:21-!- Appleman1234 [~Appleman1@cpe-123-100-131-18.pivit.net.au] has joined #wesnoth-dev
20150306 19:16:44-!- Sulfur [~Miranda@p5B0085CC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150306 19:21:26-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150306 19:27:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150306 19:28:45-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150306 19:35:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150306 19:36:22-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20150306 19:53:06-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has joined #wesnoth-dev
20150306 20:28:36-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150306 20:29:22-!- Appleman1234 [~Appleman1@cpe-123-100-131-18.pivit.net.au] has quit [Remote host closed the connection]
20150306 20:29:36-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150306 20:29:43-!- noy [~Noy@wesnoth/developer/noy] has left #wesnoth-dev []
20150306 20:40:50-!- irker303 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150306 21:05:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150306 21:09:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150306 21:44:18-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150306 21:44:54< iceiceice> gfgtdf: does this line look bad to you?
20150306 21:44:55< iceiceice> https://github.com/wesnoth/wesnoth/commit/7441a53a17b9582cc14e65b4b10e815c33205315#diff-3146e184b8c11d5b8a291b969f7e9208R186
20150306 21:45:28< iceiceice> i'm looking at the code now, i believe that gamestate_ is actually a reference to the saved_game in play_controller
20150306 21:45:43< iceiceice> im not sure if i realized that when i wrote this
20150306 21:46:02< iceiceice> it seems bad to swap out the saved_game object just before the destructor of play_controller is called...
20150306 21:52:11< gfgtdf> iceiceice: yes that's mor or less what i said.
20150306 21:53:21-!- happygrue [~Laptop@wesnoth/developer/wintermute] has quit [Ping timeout: 265 seconds]
20150306 21:53:27-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150306 21:53:34-!- noy_ [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20150306 21:53:44< iceiceice> i think i thought that was just a private instance of saved_game to the savegame object
20150306 21:53:52< iceiceice> i didn't realize it was an output mechanism :/
20150306 21:56:05-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 246 seconds]
20150306 21:56:26< iceiceice> i think i understand better now...
20150306 21:56:41< iceiceice> i wanted to use the check_version_compatibility function, maybe that's not really possible the way its set up right now
20150306 21:57:35< gfgtdf> iceiceice: since the load game dialog shows the game version the version is mostlikele already read
20150306 21:57:51< iceiceice> yeah i saw that also,
20150306 21:57:55< iceiceice> its available in save indes
20150306 21:57:57< iceiceice> *save_index
20150306 21:58:20< iceiceice> im not entirely sure why check_version_compatibility is the way it is then
20150306 22:02:33< iceiceice> i think the check_version_compatibility stuff should all be done in the gui
20150306 22:02:40< iceiceice> it shouldn't be in this class at all
20150306 22:02:50< iceiceice> but its a bit painful because there are two guis, the gui1 and gui2
20150306 22:06:42< gfgtdf> iceiceice: so teh confimartion dialog is in gui1
20150306 22:06:50< gfgtdf> iceiceice: shouldnt be hard to make it gui2
20150306 22:07:12< gfgtdf> iceiceice: i wonder whether gna.org/bugs/?15763 is still present
20150306 22:07:36-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150306 22:07:46< iceiceice> yes i think it does
20150306 22:07:48< iceiceice> i think it was reported again
20150306 22:08:29< iceiceice> https://gna.org/bugs/index.php?23111
20150306 22:08:31< iceiceice> not exactly the same
20150306 22:09:48-!- gfgtdf_ [~chatzilla@d222203.adsl.hansenet.de] has joined #wesnoth-dev
20150306 22:11:39-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150306 22:12:16-!- gfgtdf [~chatzilla@d150180.adsl.hansenet.de] has quit [Ping timeout: 256 seconds]
20150306 22:12:16-!- gfgtdf_ is now known as gfgtdf
20150306 22:13:36< iceiceice> ok this is what i'm going to do,
20150306 22:13:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20150306 22:13:58< iceiceice> i dont think that my idea from before of passing the saved_game in a pointer through the exception is a good idea,
20150306 22:14:09< iceiceice> because i'm not entirely sure if the game_config can be different when we would reload
20150306 22:14:18< iceiceice> and anyways it makes stuff more complicated
20150306 22:14:41< iceiceice> i'm just going to write a new versino of check_compatibility that is based on save_index
20150306 22:15:03< iceiceice> and also that checks for corrupt using save_index
20150306 22:15:22< gfgtdf> iceiceice: the savefile is usually independent from teh game_config
20150306 22:15:42< gfgtdf> iceiceice: teh readin part i mean
20150306 22:15:53< iceiceice> yeah... i think that's true
20150306 22:16:03< iceiceice> i think most devs won't be sure though
20150306 22:16:13< iceiceice> it could change or something
20150306 22:16:43< iceiceice> the thing i'm not sure is i'm not totally sure what things i can expect to be in save index
20150306 22:28:21-!- irker256 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150306 22:28:21< irker256> wesnoth: Chris Beck wesnoth:master b7a8dba4437b / src/dialogs.hpp: fix a variable name to more accurately describe what it is http://git.io/pJ03
20150306 23:05:49< iceiceice> gfgtdf: https://github.com/wesnoth/wesnoth/pull/381
20150306 23:09:14< gfgtdf> iceiceice: looks fine to me
20150306 23:09:33< iceiceice> y it seems to work
20150306 23:10:07< iceiceice> i think don't really need to worry about save_index being out of date, it looks like it will rebuild itself if there is a file there but no record
20150306 23:10:25< iceiceice> so it might end up to load a file twice, but only if you just dropped it into folder i guess
20150306 23:10:40< iceiceice> maybe the slow part is actually building the saved_game idk
20150306 23:13:29< gfgtdf> iceiceice: im currently testing some commit that migth spüeedup saved_game creation
20150306 23:20:11< gfgtdf> iceiceice: will you merge your pr soon ?
20150306 23:20:21< iceiceice> if it passes on travis i will merge
20150306 23:20:41< iceiceice> vultraz: if you can help test that the loading old saves thing is still working i would appreciate ^
20150306 23:20:42< gfgtdf> iceiceice: ok
20150306 23:25:55-!- lipkab [~the_new_l@host-91-147-211-47.biatv.hu] has quit [Quit: Sűrű sötét az éj, dühöng a déli szél]
20150306 23:38:26-!- travis-ci [~travis-ci@ec2-23-22-228-123.compute-1.amazonaws.com] has joined #wesnoth-dev
20150306 23:38:27< travis-ci> cbeck88/wesnoth#135 (fixup_saves - b007b5a : Chris Beck): The build passed.
20150306 23:38:27< travis-ci> Build details : http://travis-ci.org/cbeck88/wesnoth/builds/53409846
20150306 23:38:27-!- travis-ci [~travis-ci@ec2-23-22-228-123.compute-1.amazonaws.com] has left #wesnoth-dev []
20150306 23:49:00< irker256> wesnoth: Chris Beck wesnoth:master c47c92da22da / src/ (savegame.cpp savegame.hpp): savegame logic: make the version check GUI sequence a static fcn http://git.io/pJNm
20150306 23:49:02< irker256> wesnoth: Chris Beck wesnoth:master b007b5a8d099 / src/savegame.cpp: fix bug #23359: use save index for health, version checks of saves http://git.io/pJNY
20150306 23:49:04< irker256> wesnoth: Chris Beck wesnoth:master 00385f52c645 / src/ (savegame.cpp savegame.hpp): Merge pull request #381 from cbeck88/fixup_saves http://git.io/pJNO
--- Log closed Sat Mar 07 00:00:11 2015