--- Log opened Thu Apr 02 11:58:09 2015 20150402 11:58:17-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev 20150402 11:58:17-!- Topic for #wesnoth-dev: Development version 1.13.0 scheduled for April 12th | Wesnoth Developers Channel | Logs: http://irclogs.wesnoth.org 20150402 11:58:17-!- Topic set by shadowm [~ignacio@wesnoth/developer/shadowm] [Tue Mar 31 19:54:21 2015] 20150402 11:58:17[Users #wesnoth-dev] 20150402 11:58:17[ AI0867 ] [ Frainz ] [ knotwork ] [ Rhonda ] 20150402 11:58:17[ Appleman1234 ] [ Gambit ] [ lobby ] [ Samual ] 20150402 11:58:17[ bumbadadabum ] [ Haudegen ] [ Lohengramm ] [ shadowm ] 20150402 11:58:17[ c74d ] [ heirecka ] [ matthiaskrgr] [ shikadibot] 20150402 11:58:17[ Coffee_irc ] [ higgins ] [ mjs-de ] [ stikonas ] 20150402 11:58:17[ Crendgrim ] [ iceiceice] [ molgrum ] [ timotei_ ] 20150402 11:58:17[ crimson_penguin] [ irker396 ] [ Necrosporus ] [ vifon ] 20150402 11:58:17[ DDR ] [ Ivanovic ] [ noy ] [ vincent_c ] 20150402 11:58:17[ elias ] [ iwaim__ ] [ nurupo ] [ vultraz ] 20150402 11:58:17[ EliDupree ] [ janebot ] [ oldlaptop ] [ yann ] 20150402 11:58:17[ Espreon ] [ Jetrel ] [ prkc ] [ {V} ] 20150402 11:58:17[ esr ] [ kex ] [ Ravana_ ] 20150402 11:58:17-!- Irssi: #wesnoth-dev: Total of 47 nicks [0 ops, 0 halfops, 0 voices, 47 normal] 20150402 11:58:24-!- Channel #wesnoth-dev created Tue Jan 27 05:28:41 2009 20150402 11:58:26-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 246 seconds] 20150402 11:59:19-!- Irssi: Join to #wesnoth-dev was synced in 70 secs 20150402 11:59:39-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev 20150402 12:08:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20150402 12:08:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20150402 12:08:56< vultraz> Yes 20150402 12:09:11< vultraz> also [21:04:04] shadowm I'll preemptively remove the notice from status.w.o since I probably won't be around to update it. 20150402 12:10:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20150402 12:11:43-!- ToBeCloud [uid51591@gateway/web/irccloud.com/x-xskevtuqdskdrygt] has joined #wesnoth-dev 20150402 12:15:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20150402 12:17:17-!- irker396 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20150402 12:25:28-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev 20150402 12:26:26-!- Kwandulin [~Miranda@p5B008567.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150402 12:41:56-!- Appleman1234 [~Appleman1@s108.BMT-e1.vectant.ne.jp] has quit [Ping timeout: 264 seconds] 20150402 12:47:47-!- bumbadadabum [~bumbadada@wcw-stud-145-109-8-127.wireless.uva.nl] has quit [Ping timeout: 246 seconds] 20150402 12:51:36-!- Appleman1234 [~Appleman1@s108.BMT-e1.vectant.ne.jp] has joined #wesnoth-dev 20150402 13:49:05-!- boucman_work [~jrosen@193.56.60.161] has joined #wesnoth-dev 20150402 13:49:05-!- boucman_work [~jrosen@193.56.60.161] has quit [Changing host] 20150402 13:49:05-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20150402 13:52:29-!- gfgtdf [~chatzilla@f054049086.adsl.alicedsl.de] has joined #wesnoth-dev 20150402 13:52:37-!- kex [~kex@78.157.29.160] has quit [Remote host closed the connection] 20150402 13:54:39-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev 20150402 13:56:00-!- kingdom_ [~kingdom@123.155.155.182] has joined #wesnoth-dev 20150402 13:59:30-!- kingdom_ [~kingdom@123.155.155.182] has quit [Max SendQ exceeded] 20150402 14:01:10-!- irker196 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20150402 14:01:10< irker196> wesnoth: Chris Beck wesnoth:master 77a1e15553ec / src/unit_types.cpp: fixup deprecated message format check (make test more rigorous) http://git.io/vev1H 20150402 14:01:10< irker196> wesnoth: Chris Beck wesnoth:master bf915aa77289 / / (32 files in 14 dirs): Merge branch 'master' of https://github.com/wesnoth/wesnoth http://git.io/vev1Q 20150402 14:03:04-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev 20150402 14:08:30-!- kingdom_ [~kingdom@211.162.34.198] has joined #wesnoth-dev 20150402 14:09:25-!- kingdom_ [~kingdom@211.162.34.198] has quit [Max SendQ exceeded] 20150402 14:12:33< gfgtdf> iceiceice: why shoudl there be no spaces between the : and teh start of teh string? i have seen multiple abilitynames that contains spaces 20150402 14:13:18< iceiceice> which ability names have spaces? 20150402 14:13:38< iceiceice> i was trying to fix this: 20150402 14:13:39< iceiceice> 41823 20150402 14:13:42< iceiceice> eh 20150402 14:13:43< iceiceice> bad paste 20150402 14:13:51< iceiceice> http://forums.wesnoth.org/viewtopic.php?f=21&t=41823 20150402 14:14:12< gfgtdf> iceiceice: not in mainline but in umc, and i think its also possible that translation of mainline abilityes contain spaces 20150402 14:14:33< iceiceice> hmm 20150402 14:14:37< iceiceice> i didnt consider translations 20150402 14:14:44< iceiceice> all i'm doing though is suppressing the warning 20150402 14:16:11< gfgtdf> iceiceice: at lest in germal trasnlation "heals +4" contains s aspece before the + 20150402 14:16:32< iceiceice> oh, yeah that is true 20150402 14:17:02< iceiceice> yeah but i think it still might be good 20150402 14:17:14< iceiceice> because its only about whether to show this warning 20150402 14:18:01< iceiceice> probably if they have one with the deprecated format and has spaces, they might ahve other abilities that are also in the deprecated format 20150402 14:18:26< gfgtdf> iceiceice: i think the comment sais "Remove it post-1.12." so whxy we donjust rmoeve it ? 20150402 14:18:35< iceiceice> yeah i was going to backport that also 20150402 14:19:00< iceiceice> i guess on master it should just be removed 20150402 14:19:43< gfgtdf> eating, afk. 20150402 14:21:52-!- kingdom_ [~kingdom@112.65.211.215] has joined #wesnoth-dev 20150402 14:22:19-!- kingdom_ [~kingdom@112.65.211.215] has quit [Max SendQ exceeded] 20150402 14:29:46-!- kex [~kex@78.157.29.160] has quit [Remote host closed the connection] 20150402 14:30:02-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev 20150402 14:44:42-!- cib0 [~cib@132.231.178.136] has joined #wesnoth-dev 20150402 14:46:30-!- Coffee_irc [~david@ppp121-45-36-236.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!] 20150402 14:57:13-!- kingdom_ [~kingdom@112.65.211.215] has joined #wesnoth-dev 20150402 14:57:41-!- kingdom_ [~kingdom@112.65.211.215] has quit [Max SendQ exceeded] 20150402 15:01:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20150402 15:02:31-!- kingdom_ [~kingdom@112.65.211.215] has joined #wesnoth-dev 20150402 15:03:31-!- kingdom_ [~kingdom@112.65.211.215] has quit [Max SendQ exceeded] 20150402 15:03:52-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20150402 15:04:51-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20150402 15:10:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20150402 15:12:16-!- kingdom_ [~kingdom@123.155.155.182] has joined #wesnoth-dev 20150402 15:13:22-!- kingdom_ [~kingdom@123.155.155.182] has quit [Max SendQ exceeded] 20150402 15:15:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20150402 15:17:20-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 264 seconds] 20150402 15:18:53< irker196> wesnoth: mattsc wesnoth:1.12 359592769f0d / data/ai/micro_ais/cas/ca_bottleneck_move.lua: Bottleneck Micro AI: fix indenting http://git.io/vefld 20150402 15:18:55< irker196> wesnoth: mattsc wesnoth:1.12 775a0b04be81 / data/ai/micro_ais/cas/ca_bottleneck_move.lua: Bottleneck MAI: bug fix for when allied units are present http://git.io/veflF 20150402 15:18:57< irker196> wesnoth: mattsc wesnoth:1.12 5ca881b0fb9f / data/ai/micro_ais/ (cas/ca_herding_dog_stopmove.lua micro_ai_wml_tag.lua): Herding Micro AI: bug fix for dogs sometimes having moves left at end http://git.io/veflb 20150402 15:18:59< irker196> wesnoth: mattsc wesnoth:1.12 34d6e539c1c4 / data/ai/micro_ais/cas/ca_forest_animals_move.lua: Forest Animals MAI: bug fix, exclude border hexes for wander terrain http://git.io/veflN 20150402 15:19:01< irker196> wesnoth: mattsc wesnoth:1.12 77b811402fa0 / changelog: Update changelog with Micro AI bug fixes http://git.io/veflA 20150402 15:20:54< irker196> wesnoth: mattsc wesnoth:master 1ea71c1a4d5e / data/ai/micro_ais/cas/ca_bottleneck_move.lua: Bottleneck Micro AI: fix indenting http://git.io/vef8b 20150402 15:22:28-!- [Relic] [~Relic]@2602:306:33a3:6d30:ac22:2d9c:9190:202c] has joined #wesnoth-dev 20150402 15:22:44< irker196> wesnoth: mattsc wesnoth:master 95616c5af9df / data/ai/micro_ais/cas/ca_bottleneck_move.lua: Bottleneck MAI: bug fix for when allied units are present http://git.io/vef46 20150402 15:22:46< irker196> wesnoth: mattsc wesnoth:master 38b089358ab0 / data/ai/micro_ais/ (cas/ca_herding_dog_stopmove.lua micro_ai_wml_tag.lua): Herding Micro AI: bug fix for dogs sometimes having moves left at end http://git.io/vef4i 20150402 15:22:48< irker196> wesnoth: mattsc wesnoth:master b657bbc862e6 / data/ai/micro_ais/cas/ca_forest_animals_move.lua: Forest Animals MAI: bug fix, exclude border hexes for wander terrain http://git.io/vef4P 20150402 15:24:59< irker196> wesnoth: mattsc wesnoth:master b49acf7ef697 / changelog: Update changelog with Micro AI bug fixes http://git.io/vefB7 20150402 15:31:03-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20150402 15:31:07-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev 20150402 15:33:01-!- kingdom_ [~kingdom@112.65.211.215] has joined #wesnoth-dev 20150402 15:33:57-!- kingdom_ [~kingdom@112.65.211.215] has quit [Max SendQ exceeded] 20150402 15:36:15-!- Appleman1234 [~Appleman1@s108.BMT-e1.vectant.ne.jp] has quit [Ping timeout: 256 seconds] 20150402 15:48:34-!- zookeeper [~lmsnie@37.35.27.57] has joined #wesnoth-dev 20150402 15:48:37-!- zookeeper [~lmsnie@37.35.27.57] has quit [Changing host] 20150402 15:48:37-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20150402 16:00:40-!- kex [~kex@78.157.29.160] has quit [Remote host closed the connection] 20150402 16:01:16-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev 20150402 16:05:48-!- kex [~kex@78.157.29.160] has quit [Ping timeout: 250 seconds] 20150402 16:13:13-!- mjs-de [~mjs-de@f048050245.adsl.alicedsl.de] has quit [Remote host closed the connection] 20150402 16:13:55-!- gfgtdf [~chatzilla@f054049086.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 36.0.4/20150320202338]] 20150402 16:28:44-!- cib0 [~cib@132.231.178.136] has quit [Ping timeout: 264 seconds] 20150402 16:29:27< irker196> wesnoth: Charles Dang wesnoth:master b59a679b3b0e / data/campaigns/Eastern_Invasion/utils/character-definitions.cfg: EI: include canrecruit=yes Ravanal's character stats macro http://git.io/vefpP 20150402 16:29:30< irker196> wesnoth: Charles Dang wesnoth:master 3d792e54a4ed / data/campaigns/Eastern_Invasion/scenarios/04c_Mal-Ravanals_Capital.cfg: EI S4c: code cleanup http://git.io/vefpX 20150402 16:29:33< irker196> wesnoth: Charles Dang wesnoth:master 0f1c53570463 / data/campaigns/Eastern_Invasion/scenarios/05_Northern_Outpost.cfg: EI S5: code cleanup http://git.io/vefp1 20150402 16:51:05-!- Kwandulin [~Miranda@p5B008567.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds] 20150402 17:03:08-!- Kwandulin [~Miranda@p5B008567.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150402 17:09:23-!- new_one [~new_one@128.42.94.164] has joined #wesnoth-dev 20150402 17:12:35-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 256 seconds] 20150402 17:17:02< irker196> wesnoth: Bär Halberkamp wesnoth:master 8c5a4a9d6277 / data/campaigns/Eastern_Invasion/lua/bandits.lua: EI: fixed a small oversight in the bandits code http://git.io/veJlR 20150402 17:17:05< irker196> wesnoth: Bär Halberkamp wesnoth:master c14aa41c6014 / data/campaigns/Eastern_Invasion/scenarios/06_Two_Paths.cfg: EI: Updates to S6 http://git.io/veJl0 20150402 17:17:08< irker196> wesnoth: Bär Halberkamp wesnoth:master d9c1d6831de1 / changelog players_changelog: updated changelog http://git.io/veJlE 20150402 17:24:33< irker196> wesnoth: Bär Halberkamp wesnoth:master 6595778aa018 / data/campaigns/Eastern_Invasion/lua/bandits.lua: EI: Added a failsafe in the lua code http://git.io/veJBQ 20150402 17:27:53< irker196> wesnoth: Charles Dang wesnoth:master 43f822bd4555 / data/campaigns/Eastern_Invasion/scenarios/06_Two_Paths.cfg: EI S6: code cleanup http://git.io/veJ0O 20150402 17:40:05-!- cib0 [~cib@p5DC74554.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150402 17:40:22-!- kex [~kex@92.53.39.44] has joined #wesnoth-dev 20150402 17:43:30-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 272 seconds] 20150402 17:54:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20150402 18:01:01-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has quit [Ping timeout: 264 seconds] 20150402 18:02:55-!- Rhonda [~rhonda@anguilla.noreply.org] has joined #wesnoth-dev 20150402 18:03:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20150402 18:12:28-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20150402 18:14:26-!- kex [~kex@92.53.39.44] has quit [Remote host closed the connection] 20150402 18:16:09-!- kex [~kex@92.53.39.44] has joined #wesnoth-dev 20150402 18:16:44-!- kex [~kex@92.53.39.44] has quit [Remote host closed the connection] 20150402 18:21:32-!- mjs-de [~mjs-de@p508C8952.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150402 18:27:16-!- Implementor37 [44b792a3@gateway/web/freenode/ip.68.183.146.163] has joined #wesnoth-dev 20150402 18:42:10-!- iceiceice [~chris@c-73-197-174-173.hsd1.nj.comcast.net] has joined #wesnoth-dev 20150402 18:42:10-!- iceiceice [~chris@c-73-197-174-173.hsd1.nj.comcast.net] has quit [Changing host] 20150402 18:42:10-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20150402 18:48:23-!- molgrum [~molgrum@212.85.89.174] has quit [Quit: Lämnar] 20150402 18:51:15-!- Kwandulin [~Miranda@p5B008567.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20150402 19:10:12-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20150402 19:11:40-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20150402 19:17:10-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20150402 19:20:02-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20150402 19:20:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20150402 19:23:57-!- cjhopman [cjhopman@nat/google/x-fworbartwrcmfiij] has joined #wesnoth-dev 20150402 19:26:07-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20150402 19:35:58-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20150402 19:36:18-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev 20150402 19:40:01-!- cib0 [~cib@p5DC74554.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20150402 19:40:17-!- cib0 [~cib@p5DC74554.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150402 19:49:51-!- cib0 [~cib@p5DC74554.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20150402 19:51:34< iceiceice> idk, what do people think about this? 20150402 19:51:35< iceiceice> http://forums.wesnoth.org/viewtopic.php?f=21&t=41823 20150402 19:51:45< iceiceice> so the way it works right now in 1.12 and master, 20150402 19:52:05< iceiceice> if you have a description of a unit ability, which at any point contains ":" followed by new line 20150402 19:52:13< iceiceice> you got this "deprecated format" warning 20150402 19:52:41< bumbadadabum> just remove the warning 20150402 19:52:50< bumbadadabum> people had all of 1.11 to get used to it 20150402 19:52:54< bumbadadabum> just force the new system now 20150402 19:53:23< vultraz> yeah 20150402 19:53:26< iceiceice> yeah i think i agree with that 20150402 19:59:35< vultraz> iceiceice: I guess we should do that for all the outdated syntax? 20150402 20:00:19< shadowm> HI. 20150402 20:00:30< vultraz> Hello, shadowm 20150402 20:00:32< shadowm> Someone appears to have force-pushed to master at some point. 20150402 20:00:33< vultraz> Nice to see you today 20150402 20:00:39< vultraz> Wasn't me 20150402 20:00:52< shadowm> > error: Ref refs/remotes/origin/master is at 43f822bd45555f1d0ee261f9ee1ef511da9f6b4b but expected 658dd22f3904b16722d820fb6debd6f6e4ee4735 20150402 20:01:06< shadowm> > error: Ref refs/remotes/origin/1.12 is at 77b811402fa0f8814aee9635d63c9d306315c3f9 but expected abee483789d82fec21de92f7544818e557c518c9 20150402 20:01:27< iceiceice> i didnt get any errors 20150402 20:01:29< iceiceice> i pulled just now 20150402 20:01:31< bumbadadabum> me neither 20150402 20:02:04< shadowm> Ah, never mind. 20150402 20:02:13< shadowm> I had two concurrent pulls on the same repository. 20150402 20:06:45< iceiceice> vultraz: dont want to make blanket statements, i mean i guess it depends how long they were deprecated or whatever 20150402 20:06:58< shadowm> 1.11.x only, certainly. 20150402 20:07:04< bumbadadabum> 1.11.3 IIRC 20150402 20:07:12< iceiceice> in this case its like, i kind of dont see any good alternative either 20150402 20:07:25< iceiceice> if the spaces thing isnt' going to work... 20150402 20:07:34< iceiceice> i guess you could try to make some kind of regular expression or something 20150402 20:07:40< iceiceice> but i wouldn't want to commit that to stable 20150402 20:07:44< vultraz> it's not worth it 20150402 20:07:46< iceiceice> yeah 20150402 20:07:49< vultraz> Just remove it 20150402 20:07:54< iceiceice> idk what other outdated stuff there is though 20150402 20:07:58< shadowm> The old argument was deprecating and removing three releases later or so. I don't think anyone is going to mind removing after a development cycle. 20150402 20:07:59< iceiceice> probably all of it can be deleted on master 20150402 20:08:09< bumbadadabum> way too much it's wesnoth 20150402 20:08:32< bumbadadabum> when has there even been no outdated stuff 20150402 20:08:34< vultraz> warnings about [filter_side] in [gold], warnings about duration=level 20150402 20:08:51< bumbadadabum> maybe for 1.13.0 clean all that? 20150402 20:09:00< vultraz> that's what I'm asking 20150402 20:09:05< Implementor37> I don't have a problem with the warning occurring. I'd prefer the addition of http://forums.wesnoth.org/viewtopic.php?f=12&p=582510#p582510 into 1.13---I like the idea of being able to select which orb colors to use, and it appears to be currently functional. 20150402 20:09:30< bumbadadabum> eh 20150402 20:09:39< bumbadadabum> I really prefer having the entire unit tinted 20150402 20:09:43< vultraz> yeah 20150402 20:09:45< vultraz> easier to notice 20150402 20:09:52< bumbadadabum> what's the next step in that 20150402 20:09:59< bumbadadabum> making every status tint the orb? 20150402 20:10:14< Implementor37> Wouldn't that make poison harder to distinguish though? 20150402 20:10:40< bumbadadabum> I like how it is currently 20150402 20:11:48< bumbadadabum> zookeeper: EI S7 is meant to be hard, right? 20150402 20:12:19< vultraz> iceiceice: so if you don't object, we can do some cleaning up of deprecated syntax support 20150402 20:12:52< bumbadadabum> also, EI S6 is odd difficulty-wise 20150402 20:12:58< iceiceice> yeah its a good idea 20150402 20:13:17< iceiceice> imo 20150402 20:13:17< bumbadadabum> it's so much harder on hard 20150402 20:13:18< iceiceice> gfgtdf: ^ 20150402 20:13:19< bumbadadabum> it's crazy 20150402 20:13:35< bumbadadabum> vultraz: seconding that 20150402 20:13:57< irker196> wesnoth: Charles Dang wesnoth:master 7533cc79ae70 / data/lua/wml-tags.lua: Dropped support for [gold][filter_side] http://git.io/veUHA 20150402 20:14:18< bumbadadabum> ^update changelog 20150402 20:14:33< bumbadadabum> these are the important things to put in there 20150402 20:14:56< vultraz> I'll do a batch 20150402 20:15:05< bumbadadabum> ok, just saying 20150402 20:18:11-!- Haudegen [~quassel@85.124.51.57] has quit [Ping timeout: 250 seconds] 20150402 20:23:41-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20150402 20:28:10< zookeeper> bumbadadabum, i don't know how hard it's supposed to be 20150402 20:28:28< bumbadadabum> well, there are enemies from both sides 20150402 20:28:34< bumbadadabum> and there is a lot of water you need to cross 20150402 20:28:39< bumbadadabum> so I assumed it 20150402 20:28:55< bumbadadabum> I'm just curious how sadistic I can b 20150402 20:28:58< bumbadadabum> *be 20150402 20:30:20-!- kex [~kex@78.157.9.170] has joined #wesnoth-dev 20150402 20:30:23< bumbadadabum> zookeeper: http://forums.wesnoth.org/viewtopic.php?f=49&t=10307&start=15 20150402 20:30:26< bumbadadabum> seems it's not very hard 20150402 20:30:31< irker196> wesnoth: Ignacio R. Morelle wesnoth:master a33001341cfe / src/replay.cpp: Demote unsynced context warning to info log level http://git.io/veUxl 20150402 20:30:32< bumbadadabum> but people don't seem to like it very much 20150402 20:30:34< irker196> wesnoth: Ignacio R. Morelle wesnoth:1.12 1cd91103271f / src/replay.cpp: Demote unsynced context warning to info log level http://git.io/veUx8 20150402 20:34:19< zookeeper> bumbadadabum, well, shouldn't be _that_ easy, assuming the review depicts what the scenario actually is like now. 20150402 20:35:12< bumbadadabum> hmm, the reviews for 4b and 4c aren't too useful 20150402 20:35:26< bumbadadabum> it's all "very hard to go east" and "very hard to rescue all the knights" 20150402 20:36:37< irker196> wesnoth: Charles Dang wesnoth:master f36541892bd9 / src/game_events/action_wml.cpp: Dropped support for [modify_ai][filter_side] http://git.io/veUjn 20150402 20:36:40< irker196> wesnoth: Charles Dang wesnoth:master 0f28f8287861 / src/game_events/action_wml.cpp: Dropped deprecation warning regarding [object]duration=level http://git.io/veUjc 20150402 20:37:19< vultraz> If there's still actual handling of duration=level somewhere, I can't find it 20150402 20:38:35-!- SpoOkyMagician [~chatzilla@cpe-74-132-57-45.kya.res.rr.com] has joined #wesnoth-dev 20150402 20:39:50-!- Haudegen [~quassel@85.124.51.57] has joined #wesnoth-dev 20150402 20:43:30< irker196> wesnoth: Charles Dang wesnoth:master fefffa93c44e / src/controller_base.cpp: Dropped support for finding theme by name http://git.io/veTfa 20150402 20:48:33< irker196> wesnoth: Charles Dang wesnoth:master e8df45fe917e / src/theme.cpp: Dropped support for [theme]name= as an id alias http://git.io/veTUg 20150402 20:54:00< vultraz> iceiceice: https://github.com/wesnoth/wesnoth/blob/master/src/game_events/conditional_wml.cpp#L220 can this block be removed? 20150402 20:54:45< iceiceice> whats the date on it? 20150402 20:55:31< vultraz> r18803 which I'm pretty sure was ages ago 20150402 20:56:18< iceiceice> it was pre github? :O 20150402 20:56:51< vultraz> yes 20150402 20:57:17< vultraz> I guess that's what the backwards_compat argument is for 20150402 20:57:22< vultraz> so I wonder if that can go too 20150402 20:58:16< iceiceice> yeah... 20150402 20:58:27< iceiceice> it looks like this backwards compatibility [or] code is like, since 2008 or something 20150402 20:58:32-!- gfgtdf [~chatzilla@f054049086.adsl.alicedsl.de] has joined #wesnoth-dev 20150402 20:58:55< gfgtdf> iceiceice: this is the commit i found: https://github.com/wesnoth/wesnoth/commit/d5f111bf799d8ac57309a9d29c2683cf7f722d2e#diff-6e30aa95cfd80b0bed759ef354f73e75R283 but i think you can do git blame yourself. 20150402 20:58:56< shadowm> I think it's from 2007. 20150402 20:59:23< vultraz> alright, so nix that block and the backwards_compat argument? 20150402 20:59:31< iceiceice> wesnoth 1.3.5 :O 20150402 20:59:33< shadowm> I would be surprised if any add-on nowadays uses the old filter logic syntax. I don't even know what it is. 20150402 20:59:51< iceiceice> gfgtdf: i tried git blame but i kept gettin through refactors 20150402 20:59:53< bumbadadabum> me neither 20150402 21:00:04-!- travis-ci [~travis-ci@ec2-54-162-217-156.compute-1.amazonaws.com] has joined #wesnoth-dev 20150402 21:00:05< travis-ci> wesnoth/wesnoth#6130 (master - 7533cc7 : Charles Dang): The build has errored. 20150402 21:00:05< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/56942100 20150402 21:00:05-!- travis-ci [~travis-ci@ec2-54-162-217-156.compute-1.amazonaws.com] has left #wesnoth-dev [] 20150402 21:00:13< iceiceice> vultraz: 20150402 21:00:15< shadowm> gfgtdf: We wanted to remove something and I told you to give me a list of WML keywords to search for in the add-ons server. What was it again? 20150402 21:00:34< vultraz> iceiceice: yes? 20150402 21:00:37< iceiceice> vultraz: i think i would suggest to write a unit test about how [and] [or] [not] are supposed to work 20150402 21:00:40< iceiceice> if we dont have one already 20150402 21:00:45< iceiceice> then delete stuff 20150402 21:00:52< iceiceice> and hopefully it should all be fine 20150402 21:00:56< vultraz> I'm not sure how to write a unit test :P 20150402 21:01:31< gfgtdf> shadowm: http://forums.wesnoth.org/viewtopic.php?f=8&t=20997 20150402 21:01:40< iceiceice> idk you would just like take a file like this 20150402 21:01:41< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/data/test/scenarios/two_plus_two.cfg 20150402 21:01:43< iceiceice> copy paste it 20150402 21:01:47< shadowm> gfgtdf: Okay, do you know the keywords? 20150402 21:02:00< iceiceice> and replace the two + two stuff with boolean stuff 20150402 21:02:22< shadowm> iceiceice, vultraz: And here's where [true] and [false] come in handy. 20150402 21:02:25< iceiceice> i mean you can just cross your fingers and delete things, but if you break it people will probably be displeased 20150402 21:02:30< shadowm> :p 20150402 21:02:32< gfgtdf> shadowm: accuracy= and parry= in attack. 20150402 21:02:34< gfgtdf> iceiceice: https://github.com/wesnoth/wesnoth/commit/5aaf4e595b508242b625f1b14a44f3d271fc5ac3 20150402 21:02:52< gfgtdf> s/iceiceice/shadowm 20150402 21:05:18< bumbadadabum> what is jamming in [unit_type] 20150402 21:05:23< bumbadadabum> I've never seen that used 20150402 21:05:27< iceiceice> its fabis invention 20150402 21:05:29< iceiceice> i think its not used 20150402 21:05:34< vultraz> bumbadadabum: thing fabi added that no one uses 20150402 21:05:38< gfgtdf> mabye its used by fabi 20150402 21:05:57< gfgtdf> it not documented 20150402 21:06:01< bumbadadabum> yes but what does it DO 20150402 21:06:10< iceiceice> its supposed to be like 20150402 21:06:13< iceiceice> jamming your radar 20150402 21:06:16< iceiceice> :p 20150402 21:06:25< iceiceice> it makes units move more slowly around whatever unit that has jamming 20150402 21:06:31< iceiceice> or... 20150402 21:06:35< iceiceice> i guess it makes their vision worse 20150402 21:06:38< iceiceice> but their movement is not worse 20150402 21:06:40< shadowm> Nah, you all got it wrong. 20150402 21:07:02< shadowm> It grants units the ability to drop jars with random jam in it. 20150402 21:07:18< iceiceice> :D 20150402 21:07:20< bumbadadabum> will we ever know? 20150402 21:07:23< iceiceice> who could possibly be opposed to that 20150402 21:07:36< iceiceice> nobody 20150402 21:08:02< bumbadadabum> (also, I foolishly expected shadowm to be serious and bring us some clarity) 20150402 21:08:35< shadowm> Well, if you want me to be serious, it's about negating their vision points. 20150402 21:08:45< bumbadadabum> but how does it work 20150402 21:08:48< shadowm> If I recall correctly, anyway. 20150402 21:09:01< bumbadadabum> does it make the vision of enemies next to it vision - jamming? 20150402 21:09:23< shadowm> The world becomes jam in their eyes. 20150402 21:09:32< shadowm> Sweet, delicious jam. 20150402 21:09:48< bumbadadabum> what would a black hole's jamming be? 20150402 21:10:00< vultraz> over 9000 20150402 21:10:08< vultraz> and raspberry 20150402 21:10:28< bumbadadabum> jamming=1 is strawberry jam? 20150402 21:10:50< bumbadadabum> which one is blueberry that's my favorite 20150402 21:11:26< vultraz> 2 20150402 21:12:05< bumbadadabum> sucks that jamming isn't shown on the UI anywhere it seems 20150402 21:13:01< iceiceice> i think its not a great feature actually :p 20150402 21:13:23< iceiceice> right so there were some comments on forum about how, you can figure out where the jamming unit is if you stare at the map and where you should have vision and where you dont 20150402 21:13:33< iceiceice> also i think it would be really hard to make the ai use it effectively 20150402 21:13:46< bumbadadabum> tbh fabi has been pretty hit and miss with features sometimes 20150402 21:14:16< iceiceice> you never hit if you dont take a shot :p 20150402 21:14:31< bumbadadabum> or 12 shots in fabi's case 20150402 21:14:57< bumbadadabum> new editor makes up for it though 20150402 21:15:07< iceiceice> tunnels was a good feature 20150402 21:15:10< iceiceice> we just have to fix the implementation 20150402 21:16:43< shadowm> Very encouraging, bumbadadabum. 20150402 21:17:05< bumbadadabum> n-no offense 20150402 21:17:12< bumbadadabum> I have a long list of bad ideas as well 20150402 21:17:25< shadowm> To be fair, he wanted it specifically for a TC he was working on. 20150402 21:18:03< shadowm> It should come as no surprise that if you try to adapt some other existing game to Wesnoth's engine you'll require some outlandish features. 20150402 21:18:25< bumbadadabum> haven't you added features for your add-ons as well 20150402 21:18:58< shadowm> Yes, but that's not what I just said. 20150402 21:19:12< shadowm> "Try to adapt some other existing game to Wesnoth's engine" and "outlandish". 20150402 21:19:30< bumbadadabum> I'm a slow typer 20150402 21:19:46< bumbadadabum> wrote it in reference to To be fair, he wanted it specifically for a TC he was working on. 20150402 21:25:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20150402 21:25:19< shadowm> iceiceice: Last time I checked, tunnels weren't usable by the AI but I *believe* someone fixed that afterwards. Is there some other problem with the feature? 20150402 21:25:44< iceiceice> yeah theres a problem on the bug tracker 20150402 21:25:47< shadowm> I'm asking out of curiosity, since I had tried to use them before but ended up resorting to event-driven teleports due to the aforementioned issue with the AI. 20150402 21:25:57< iceiceice> having to do with unable to undo moves using it or osmething 20150402 21:26:07< iceiceice> i think the AI uses them 20150402 21:26:22< shadowm> gfgtdf: No matches in 1.12, 1.11, 1.9/1.10, or 1.8 using this lazy regex: (accuracy|parry).*= 20150402 21:26:32< iceiceice> so the other thing is i think the implementation is very inefficient 20150402 21:26:55< shadowm> I thought it mostly shared code with the teleport ability. 20150402 21:27:04< iceiceice> no, i dont think so 20150402 21:27:24< shadowm> Maybe that was fabi's intention at some point anyway. 20150402 21:27:33< iceiceice> i think the graphical part of it is sharing code there 20150402 21:27:40< iceiceice> but iirc the way it integrates into pathfinding is like 20150402 21:27:55< iceiceice> in the function(s) that checks if two map locations are adjacent 20150402 21:28:03< iceiceice> also check the entire list of known teleports 20150402 21:28:08< iceiceice> one by one 20150402 21:28:23-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20150402 21:28:29< iceiceice> what it should be is like, 20150402 21:28:45< iceiceice> there's a std::map with double entries or something 20150402 21:28:48< iceiceice> that holds known teleports 20150402 21:28:58< iceiceice> and you just dereference your location in that map 20150402 21:29:15< iceiceice> i think the current code will scale very badly if you add many tunnels 20150402 21:29:29< iceiceice> i guess should profile before critiquing 20150402 21:29:41< iceiceice> but the way it works now if you have N tunnels it should make pathfinding N times slower 20150402 21:31:47< irker196> wesnoth: Charles Dang wesnoth:master 0911b1f4d54f / data/test/scenarios/conditionals.cfg wml_test_schedule: Added some conditional unit tests http://git.io/veT8F 20150402 21:31:57< vultraz> I HOPE I did that right 20150402 21:33:35< shadowm> gfgtdf: I took a look at finding single-line macro substitutions which include either word but I got only false positives since they are obviously generic terms used in custom abilities and stuff. So I'd say the feature is completely unused since 1.8.x. 20150402 21:34:17< gfgtdf> shadowm: so you think we should remove that code ? 20150402 21:34:23< irker196> wesnoth: Charles Dang wesnoth:master 3b6d2a6711af / src/game_events/ (conditional_wml.cpp conditional_wml.hpp): Dropped support for ancient 1.3.x [or] syntax http://git.io/veT46 20150402 21:34:30< shadowm> I could inspect 1.7.x and 1.6.x and 1.5.x but I don't think it's worth it. 20150402 21:34:45< shadowm> Unpacking a load of crap and grepping it while the server is busy trying to recover from the latest accident. 20150402 21:34:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Ping timeout: 256 seconds] 20150402 21:35:26< shadowm> gfgtdf: I can't really comment on its usefulness seeing as how I've never used the feature, so it's up to you. 20150402 21:36:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20150402 21:38:01< shadowm> If it hasn't been brought up in conversation in ages it probably means it's unneeded or someone independently developed a better-maintained alternative (either in the engine or a CABD technique). 20150402 21:38:48-!- [Relic] [~Relic]@2602:306:33a3:6d30:ac22:2d9c:9190:202c] has quit [Ping timeout: 265 seconds] 20150402 21:39:10< iceiceice> vultraz: i think you can delete the "or_count" thing also 20150402 21:39:25< iceiceice> i think that might have been the only part about the backwards compat that was different 20150402 21:40:38< irker196> wesnoth: Charles Dang wesnoth:master ba82be2a8860 / src/image_modifications.cpp: Dropped warning about unsupported 1.6.x RC(a=b) palette switch syntax http://git.io/veTRy 20150402 21:40:50-!- [Relic] [~Relic]@2602:306:33a3:6d30:ac22:2d9c:9190:202c] has joined #wesnoth-dev 20150402 21:42:30< shadowm> I'm taking the wiki down. 20150402 21:42:46< bumbadadabum> how so 20150402 21:44:10< irker196> wesnoth: Charles Dang wesnoth:master ec0f19bf2062 / src/game_events/conditional_wml.cpp: Fixup 3b6d2a6711af, removed additional unnecessary variable http://git.io/veTEn 20150402 21:44:26< shadowm> ETA 15 minutes. 20150402 21:46:10-!- kex [~kex@78.157.9.170] has quit [Remote host closed the connection] 20150402 21:46:33< shadowm> Ugh, make that longer. 20150402 21:47:25< vultraz> *dusts off hands* 20150402 21:47:31-!- kex [~kex@78.157.9.170] has joined #wesnoth-dev 20150402 21:47:52< bumbadadabum> vultraz: I hear you have time to playtest EI more now :) 20150402 21:52:09-!- kex [~kex@78.157.9.170] has quit [Ping timeout: 264 seconds] 20150402 21:54:47-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20150402 21:55:31-!- Implementor37 is now known as Implementor37_De 20150402 21:56:08-!- Implementor37_De [44b792a3@gateway/web/freenode/ip.68.183.146.163] has left #wesnoth-dev [] 20150402 21:56:20-!- mjs-de [~mjs-de@p508C8952.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20150402 21:56:41-!- Implementor37 [44b792a3@gateway/web/freenode/ip.68.183.146.163] has joined #wesnoth-dev 20150402 22:03:29-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev 20150402 22:06:38< shadowm> Wiki back up. 20150402 22:18:20-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20150402 22:25:28-!- kex [~kex@78.157.29.160] has quit [] 20150402 22:32:28-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev 20150402 22:35:41-!- kex [~kex@78.157.29.160] has quit [Client Quit] 20150402 22:39:13-!- kex [~kex@78.157.29.160] has joined #wesnoth-dev 20150402 22:55:02-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20150402 23:02:43-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20150402 23:07:58-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20150402 23:23:36-!- Appleman1234 [~Appleman1@s108.BMT-e1.vectant.ne.jp] has joined #wesnoth-dev 20150402 23:32:45< vultraz> bumbadadabum: yeah, I'll see about playing it 20150402 23:32:52< vultraz> bumbadadabum: can you also deal with the [full_heal] thing 20150402 23:33:00< bumbadadabum> oh, right 20150402 23:33:04< bumbadadabum> I'll do that tomorrow 20150402 23:33:05< bumbadadabum> remind me 20150402 23:33:15< vultraz> ok 20150402 23:35:09< irker196> wesnoth: Charles Dang wesnoth:master f05232b6f67b / changelog: Updated changelog http://git.io/vekeF 20150402 23:39:19< irker196> wesnoth: Charles Dang wesnoth:master 5d494e2b2307 / changelog: Fixed a few scattered typos http://git.io/vekvS 20150402 23:39:22< irker196> wesnoth: Charles Dang wesnoth:master 8e4169d52829 / changelog: Fixup f05232b6f67b. Forgot to mention [object] duration=level http://git.io/vekv9 20150402 23:46:34-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Remote host closed the connection] 20150402 23:56:42< vultraz> welp 20150402 23:56:44< vultraz> crash 20150402 23:56:46< vultraz> D: 20150402 23:57:11< vultraz> "caught return_to_play_side_exception, please report this bug (quitting)" 20150402 23:58:45< gfgtdf> vultraz: how to reproduce ? --- Log closed Fri Apr 03 00:00:02 2015