--- Log opened Wed Jun 17 00:00:21 2015
20150617 00:18:46< gfgtdf> shadowm: which bugs ?
20150617 00:22:57-!- Appleman1234__ [~Appleman1@KD106154015117.au-net.ne.jp] has joined #wesnoth-dev
20150617 00:23:18-!- Appleman1234__ is now known as Appleman1234
20150617 00:25:48-!- Appleman1234_ [~Appleman1@KD106154025019.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20150617 00:40:09< shadowm> gfgtdf: https://mail.gna.org/public/wesnoth-dev/2015-06/msg00000.html
20150617 00:45:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20150617 00:50:02< gfgtdf> shadowm: first is fixes by elvish_hunter
20150617 00:50:13< gfgtdf> shadowm: second is likeley caused by teh first
20150617 00:50:36< gfgtdf> shadowm: 3 is fixed but not in an optimal ways
20150617 00:50:42< gfgtdf> shadowm: 4 is still present
20150617 00:51:10< gfgtdf> shadowm: 5 is most likley fixd
20150617 00:51:15< gfgtdf> shadowm: 6 is still present
20150617 00:57:15-!- ancestral [~ancestral@71-34-1-180.mpls.qwest.net] has joined #wesnoth-dev
20150617 01:23:41-!- gfgtdf [~chatzilla@f054138228.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 38.0.5/20150525141253]]
20150617 01:56:27-!- shadowm changed the topic of #wesnoth-dev to: Wesnoth 1.12.3a ETA: TBD | String freeze ACTIVE on 1.12 branch | Wesnoth Developers Channel | Logs: http://irclogs.wesnoth.org
20150617 01:57:27-!- irker284 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150617 01:57:27< irker284> wesnoth: Ignacio R. Morelle wesnoth:1.12 7bdadf513bbf / src/ (game_preferences.cpp game_preferences.hpp): Explicitly define admin_authentication_reset's ctor out of line http://git.io/vLnKt
20150617 02:04:23< shadowm> gfgtdf: So, the notifications for debug commands show up as transient overlays on the game map.
20150617 02:05:13< shadowm> Someone could wait for me to go afk to cheat unnoticed.
20150617 02:05:38< shadowm> So how about announcing it to the chat instead?
20150617 02:18:42-!- Appleman1234 [~Appleman1@KD106154015117.au-net.ne.jp] has left #wesnoth-dev ["Leaving"]
20150617 02:18:53-!- Appleman1234 [~Appleman1@KD106154015117.au-net.ne.jp] has joined #wesnoth-dev
20150617 02:24:58< irker284> wesnoth: Ignacio R. Morelle wesnoth:master b2738ffb2fdd / changelog players_changelog src/filesystem.cpp src/filesystem_boost.cpp: Use looks_like_pbl() to disallow .pbl file inclusion (bug #23504) http://git.io/vLn1k
20150617 02:25:01< irker284> wesnoth: Ignacio R. Morelle wesnoth:1.10 d20f8015bc36 / changelog players_changelog src/filesystem.cpp: Use looks_like_pbl() to disallow .pbl file inclusion (bug #23504) http://git.io/vLn1L
20150617 02:25:04< irker284> wesnoth: Ignacio R. Morelle wesnoth:1.10 703819335d06 / changelog players_changelog: Update changelogs for bug #23440 http://git.io/vLn1t
20150617 02:25:07< irker284> wesnoth: Ignacio R. Morelle wesnoth:1.12 1f3dbfb08620 / changelog players_changelog src/filesystem.cpp src/filesystem_boost.cpp: Use looks_like_pbl() to disallow .pbl file inclusion (bug #23504) http://git.io/vLn1q
20150617 03:13:38-!- travis-ci [~travis-ci@ec2-54-157-198-50.compute-1.amazonaws.com] has joined #wesnoth-dev
20150617 03:13:39< travis-ci> wesnoth/wesnoth#6640 (1.10 - 7038193 : Ignacio R. Morelle): The build is still failing.
20150617 03:13:39< travis-ci> Build details : http://travis-ci.org/wesnoth/wesnoth/builds/67129997
20150617 03:13:39-!- travis-ci [~travis-ci@ec2-54-157-198-50.compute-1.amazonaws.com] has left #wesnoth-dev []
20150617 03:20:48-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 265 seconds]
20150617 03:22:32-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150617 03:29:17-!- Appleman1234_ [~Appleman1@KD106178173123.au-net.ne.jp] has joined #wesnoth-dev
20150617 03:31:09-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has quit [Remote host closed the connection]
20150617 03:32:18-!- Appleman1234 [~Appleman1@KD106154015117.au-net.ne.jp] has quit [Ping timeout: 272 seconds]
20150617 03:50:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150617 04:18:23-!- Kwandulin [~Miranda@p5B008628.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150617 04:19:42-!- ancestral [~ancestral@71-34-1-180.mpls.qwest.net] has quit [Read error: Connection reset by peer]
20150617 04:30:39-!- Appleman1234_ [~Appleman1@KD106178173123.au-net.ne.jp] has quit [Ping timeout: 276 seconds]
20150617 04:42:47-!- Appleman1234_ [~Appleman1@KD106178173123.au-net.ne.jp] has joined #wesnoth-dev
20150617 05:11:06-!- Appleman1234__ [~Appleman1@KD106178166250.au-net.ne.jp] has joined #wesnoth-dev
20150617 05:11:39-!- Appleman1234__ is now known as Appleman1234
20150617 05:14:23-!- Appleman1234_ [~Appleman1@KD106178173123.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20150617 06:02:03-!- horrowin1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150617 06:06:19-!- irker284 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150617 06:46:45-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150617 06:51:24-!- horrowin1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has quit [Quit: horrowin1]
20150617 07:24:00-!- cib0 [~cib@p5DD22EA7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150617 07:33:19-!- [Relic] [~Relic]@2602:306:33a3:6d30:498c:8b73:bbb8:ca9b] has quit [Quit: I press the magic X and all the weirdos go away!]
20150617 07:55:35-!- mjs-de [~mjs-de@f048203241.adsl.alicedsl.de] has joined #wesnoth-dev
20150617 08:03:55< shadowm> Ravana_: You don't need to waste time moving posts in the moderation queue. Guests and normal users cannot see them.
20150617 08:09:11-!- Kwandulin [~Miranda@p5B008628.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150617 08:34:05-!- cib0 [~cib@p5DD22EA7.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20150617 08:58:43-!- hay207 [~haythamme@41.34.5.153] has joined #wesnoth-dev
20150617 09:05:00< Ravana_> ok
20150617 09:20:28-!- hay207 [~haythamme@41.34.5.153] has quit [Quit: Leaving]
20150617 09:20:53-!- hay207 [~haythamme@41.34.5.153] has joined #wesnoth-dev
20150617 09:23:58-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 255 seconds]
20150617 09:46:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150617 09:49:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150617 09:50:31-!- Appleman1234_ [~Appleman1@KD106178173163.au-net.ne.jp] has joined #wesnoth-dev
20150617 09:52:52-!- Appleman1234 [~Appleman1@KD106178166250.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20150617 09:58:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150617 10:25:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150617 10:36:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150617 10:37:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150617 11:03:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150617 11:06:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150617 11:33:09-!- hay207 [~haythamme@41.34.5.153] has quit [Ping timeout: 245 seconds]
20150617 12:02:50-!- hay207 [~haythamme@41.34.43.124] has joined #wesnoth-dev
20150617 12:07:30-!- horrowind [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150617 12:10:08-!- gfgtdf [~chatzilla@f054170137.adsl.alicedsl.de] has joined #wesnoth-dev
20150617 12:10:58< gfgtdf> shadowm: afaik chat messages vanish too and at those non-player messagey (llike wesnoth.message) also dont appear in the chatlog
20150617 12:14:28< gfgtdf> shadowm: we could implement a message that appears and that you'd have to click away. idk if that would be prefereable
20150617 12:31:37< Ravana_> as EoHS showed it is possible to provide log of such messages
20150617 12:31:50< Ravana_> however chat log inclusion option would be preferable
20150617 12:33:46< Ravana_> (for wesnoth.message at least, [chat] is even now inferior to that)
20150617 12:39:35< gfgtdf> Ravana_: so eohs messages appear in the chatlog ?
20150617 12:39:50< Ravana_> not main chatlog
20150617 12:39:58< Ravana_> it creates its own with lua
20150617 12:40:06< Ravana_> log of eohs messages
20150617 12:43:23< Ravana_> but that log is also accessible to observers so it is about as good as the real thing
20150617 12:43:55< gfgtdf> Ravana_: howdoobserversopen it ?
20150617 12:44:27< Ravana_> I couldnt understand lua enough to find out which code does it
20150617 12:44:43< gfgtdf> Ravana_: no i mean fromthe users orespective
20150617 12:44:46< Ravana_> but observer can open with by moving mouse over certain hexes in correct pattern
20150617 12:45:54< gfgtdf> Ravana_: then its mostlikeley done via wesnoth.theme_items
20150617 12:48:18< Ravana_> seems to be, searching that I found call to update_off_turn_menu_invocation_hack()
20150617 12:49:50< gfgtdf> Ravana_: I still dont think that a seperate chatlog fot our problem. the intention that mesage we talk about is to prevent cheats. And its not that useful if those message only appear ina  chatlog where people would not srach if the dont expect cheats
20150617 12:50:57< Ravana_> yes, as I said chat log inclusion is better, and for wesnoth.message too
20150617 12:55:47< Ravana_> the reason for this chat is about allowing debug commands in mp?
20150617 13:02:39< gfgtdf> Ravana_: yes previous using debug commands caused OOS (in mp and also in replays). Now this was fixed but ofcourse we need tomake sure that the other playres get informed about players using debug commands.
20150617 13:03:39< Ravana_> I couldnt wait for it to be available so I wrote [modification] that allows all debug commands I need as menu items
20150617 13:04:09< Ravana_> for use of debug command something like [print] could be used
20150617 13:07:47< gfgtdf> Ravana_: idk what [print] does. Currently debug commands hsow a message like the "press t to continue" message
20150617 13:08:19< Ravana_> message, usually large, over screen
20150617 13:08:56< gfgtdf> Ravana_: the same as the 'press t to continue' message ?
20150617 13:09:01< Ravana_> with duration though, not clicking
20150617 13:10:21< Ravana_> can look like http://puu.sh/isdov/4b8d525da0.jpg
20150617 13:18:39< gfgtdf> Ravana_: hm ok y i think taht what debug commands currentlyalso use
20150617 13:19:02< gfgtdf> Ravana_: the probelm is that peple coudl miss that if they were afk.
20150617 13:19:50< Ravana_> I know that oos messages get included in chat log, so there is precedent for chat log too
20150617 13:21:19< gfgtdf> Ravana_: you mean OOS messages generated by the server?
20150617 13:21:23< Ravana_> yes
20150617 13:21:42< Ravana_> (along with friend lobby joins)
20150617 13:21:50< gfgtdf> Ravana_: those messages receive the client just liek chat messages b players to itexpected tat they are in teh logs
20150617 13:38:28-!- gfgtdf [~chatzilla@f054170137.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 38.0.5/20150525141253]]
20150617 13:39:09-!- gfgtdf [~chatzilla@f054170137.adsl.alicedsl.de] has joined #wesnoth-dev
20150617 14:29:14-!- Appleman1234_ [~Appleman1@KD106178173163.au-net.ne.jp] has quit [Ping timeout: 244 seconds]
20150617 14:30:03-!- Appleman1234_ [~Appleman1@KD106154025007.au-net.ne.jp] has joined #wesnoth-dev
20150617 14:41:31-!- [Relic] [~Relic]@2602:306:33a3:6d30:3063:676c:c298:72d9] has joined #wesnoth-dev
20150617 14:53:34-!- mjs-de [~mjs-de@f048203241.adsl.alicedsl.de] has quit [Remote host closed the connection]
20150617 14:53:45-!- prkc [~prkc@catv-89-134-173-244.catv.broadband.hu] has joined #wesnoth-dev
20150617 15:56:34-!- Appleman1234__ [~Appleman1@KD106178168025.au-net.ne.jp] has joined #wesnoth-dev
20150617 15:59:00-!- Appleman1234_ [~Appleman1@KD106154025007.au-net.ne.jp] has quit [Ping timeout: 272 seconds]
20150617 16:23:48-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 265 seconds]
20150617 16:43:16-!- oldlaptop_ [~quassel@50-107-82-76.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150617 16:45:14-!- Netsplit *.net <-> *.split quits: oldlaptop
20150617 16:49:06-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150617 17:02:58< gfgtdf> i wonder whether it was wrong/useless to make the hotkeys for wml menu items optional do you know any situation where you'd want to use use_hotkey=no in [set_menu_item] ?
20150617 17:06:43-!- mjs-de [~mjs-de@f048203241.adsl.alicedsl.de] has joined #wesnoth-dev
20150617 17:08:43< zookeeper> gfgtdf, so if a menu item has use_hotkey=yes, then does an entry for it automatically appear in the hotkeys menu?
20150617 17:09:11< gfgtdf> zookeeper: yes
20150617 17:09:13< zookeeper> and what happens if i go to the hotkeys menu before the scenario has added the menu item? it just isn't there?
20150617 17:09:17< gfgtdf> zookeeper: use_hpotkey=yes is teh default
20150617 17:09:28< gfgtdf> zookeeper: yes its not there
20150617 17:09:31< zookeeper> right
20150617 17:10:00< gfgtdf> zookeeper: also when a menu items was removed then teh hotkey entry shoudl diappear for teh hotkey list
20150617 17:10:51< gfgtdf> zookeeper: do you have an opnion on whether to remove use_hotkey and always to allow hotkeys ?
20150617 17:11:00< zookeeper> well, i can't come up with any specific uses for use_hotkey=no, but it seems like a good thing to have
20150617 17:11:37< zookeeper> maybe you just don't want some items (which you think no one would ever use via hotkeys) polluting the hotkeys menu?
20150617 17:12:50< gfgtdf> zookeeper: hm i dont think it would pollute it, It not liek people change the hotkeys preferences regually and also the entry wont be there after teh scenario has ended
20150617 17:13:16< gfgtdf> s/It not liek/It's not like
20150617 17:13:52< gfgtdf> ended like ending campaign  an going to toitlescrren or playing a differnet campaign
20150617 17:14:32< zookeeper> also, you might have some debugging menu items which are deactivated (via [show_if] for instance), and don't want those to appear in the hotkeys list
20150617 17:14:43< zookeeper> that seems like the most plausible usecase
20150617 17:16:21< Ravana_> I don't think I have heard of anyone actually using hotkeys for menu items
20150617 17:16:52< gfgtdf> zookeeper: i think it posssible for those to for example just put the [set_menu_item] into a #ifdef debug or something.
20150617 17:16:55< Ravana_> there doesn't seem reason to force allowing hotkeys for them
20150617 17:16:56< gfgtdf> Ravana_: i use them
20150617 17:17:15< Ravana_> so I think it would be better to continue allowing this
20150617 17:17:39< zookeeper> gfgtdf, of course
20150617 17:17:56-!- Kwandulin [~Miranda@p5B008628.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150617 17:18:03< zookeeper> when was this option introduced anyway?
20150617 17:18:07< Ravana_> gfgtdf: ifdef wouldn't work, as then you could couldnt use them yourself
20150617 17:18:25< gfgtdf> Ravana_: ?
20150617 17:18:39< gfgtdf> Ravana_: the reason it makes teh c++ code mre complcated. currently all menu entries go to teh same path as teh hotkeys except teh wml_menu_items
20150617 17:20:29< gfgtdf> zookeeper: i implemented use_hotkey=yes/no/only when i implemented hotkeys for wml menu items. The reson for implemting use_hotkey=yes is just that i didnt want to change it too much becasue i didnt knew taht much
20150617 17:20:43< gfgtdf> zookeeper: (was my first or second pull request i think)
20150617 17:21:36< Ravana_> I haven't ever used that key, but now it seems useful
20150617 17:21:37< Ravana_> like http://pastebin.com/14w9h3aW , noone else can use those commands without changing sides/reloading, but I have them available in every game I host in case there is need for them
20150617 17:22:55< zookeeper> gfgtdf, okay, well, is there any reason for removing it now?
20150617 17:23:22< zookeeper> i can't imagine it really complicating the codebase
20150617 17:25:05< gfgtdf> Ravana_: but your code gives everyone who looks at teh wml code teh possiblity to cheat.
20150617 17:25:12< gfgtdf> zookeeper: i think it could.
20150617 17:25:16< Ravana_> yes
20150617 17:25:25< Ravana_> but I haven't uploaded the addon
20150617 17:26:14< Ravana_> anyone who knows to look wml can likely write such addon themself
20150617 17:27:47< gfgtdf> Ravana_: hm maybe we need a check for modified era/modification just like we have for [multiplayer]
20150617 17:28:13< zookeeper> gfgtdf, could, but doesn't? :p
20150617 17:29:05< Ravana_> how could you really check for this without restricting used addons to server-side check of developer-approved ones?
20150617 17:29:06< zookeeper> i mean all the code related to use_hotkey looks like it's a handful of lines of generic boilerplate code and then a couple of if's checking for it
20150617 17:29:10-!- horrowind [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20150617 17:31:38< gfgtdf> Ravana_:  teh sme way as we currently do for scenarios: the host sends a hash forteh [multiplayer] and the clients check whether they have a [multiplayer] with that hash localy,
20150617 17:32:09< gfgtdf> Ravana_: afaik thats how the  'Remote scenario' falg is implemented.
20150617 17:32:32< Ravana_> obviously they haven't, unless you plan to globally force require_scenario=yes
20150617 17:32:51< gfgtdf> Ravana_: ?
20150617 17:32:56< Ravana_> and all its equivalents for different types of addons
20150617 17:33:21< Ravana_> often only host has scenario installed
20150617 17:33:35< gfgtdf> Ravana_: they havent what ?
20150617 17:33:54< Ravana_> scenario file
20150617 17:34:06< Ravana_> [multiplayer][/multiplayer]
20150617 17:34:25< gfgtdf> zookeeper: i mean mayly this codes: https://github.com/wesnoth/wesnoth/blob/master/src/hotkey_handler.cpp#L229 and related
20150617 17:35:26< gfgtdf> Ravana_: why they obviously havent? I often see games in mp lobby where i also have the game [multiplayer] locally
20150617 17:36:49< Ravana_> it is quite unlikely that all people have decided to install all scenarios they play
20150617 17:37:40< gfgtdf> Ravana_: so ?
20150617 17:39:34< Ravana_> so often one player has scenario, edited or not, and other player doesn't have any version
20150617 17:39:55< Ravana_> nothing to check against
20150617 17:42:21< Ravana_> like I sometimes play creep war, but as I liked v 0.2.13 (my version, though official 0.2.11.1 was decent too) more than current 0.3.x, I haven't installed it for 1.12 myself
20150617 17:50:41< Ravana_> gfgtdf: sure you check it with hash? I always thought it used scenario/era/modification id. After all, whats the point of addon_min_version= when hash would already make sure it is exact same
20150617 17:51:13< gfgtdf> Ravana_: there are still a lot of cases where this works. I jus tlogged in to mp server and there onyl 2 scenarios flagged as rmeote scenarios from which on is a randomly generated scenario (which are always flagged as remote scenario)
20150617 17:51:25< gfgtdf> Ravana_: addon min version was introduced later
20150617 17:52:13< gfgtdf> Ravana_: afaik adon min version is  1.13 only feature
20150617 17:53:01< Ravana_> yes, something this drastic wouldn't get to 1.12 anyways
20150617 17:53:34< gfgtdf> Ravana_: the main intention of 'remote scenario' is really to detect changed scenarios (possible cheats)
20150617 17:53:43< Ravana_> ohh
20150617 17:53:58< Ravana_> thought it was to detect which addon you were missing
20150617 17:53:58< gfgtdf> Ravana_: where teh reason for addon min version is mmostly to prevent OOS casues by version missmatch
20150617 17:54:24< gfgtdf> Ravana_: caused*
20150617 17:55:09< gfgtdf> ofc you cna still play scenarios even if it is a 'remote scenario'
20150617 17:55:22< gfgtdf> note that there is 'Remote Scenario' and 'Unknown scenario'
20150617 17:56:10< gfgtdf> Ravana_: its just that you should get suspicios of remote scenarios specially if it is a mainline scenario.
20150617 17:56:11< Ravana_> interesting
20150617 17:56:22< Ravana_> this allows me to see who uses old version of orocia without joining and checking objectives
20150617 17:57:58< Ravana_> I have commented out mainline scenarios though
20150617 17:58:11< gfgtdf> Ravana_: what do you mean by commented out ?
20150617 17:59:24< Ravana_> data\multiplayer\_main.cfg line 15
20150617 18:00:00< gfgtdf> Ravana_: so teh minaline scenario hsow for you as unkown scenario?
20150617 18:00:14< gfgtdf> Ravana_: for loading time? I'd think that (maybe except for ANL) the mmainline scenarios loding time shoudl be negleectible specially if you use Ageless.
20150617 18:00:41< Ravana_> loading time doesn't matter, there are just so many of them that I can't find what I want from list
20150617 18:10:51< Ravana_> anyways I wouldn't use my modification for cheating, I don't even host competitive games
20150617 18:12:37< gfgtdf> Ravana_: but someone else could get that idea
20150617 18:13:03< Ravana_> its visible in saves
20150617 18:13:48< Ravana_> both definition and actual uses
20150617 18:14:24< gfgtdf> Ravana_: hm yes but ut i dont think anyone will check teh saves.
20150617 18:14:53< Ravana_> btw, does hash include .lua files?
20150617 18:15:34< gfgtdf> Ravana_: things loded vie wesnoth.require/doafogl are loaded on teh clients so its ok that it ognores them
20150617 18:16:02< gfgtdf> Ravana_: if they are included via macro {../lua/myfile.lua} they will be reatey like nomral wml atributes
20150617 18:16:14< Ravana_> ok
20150617 18:18:59< gfgtdf> shikadibot: seen mattsc
20150617 18:18:59< shikadibot> gfgtdf: The person with the nick mattsc last spoke 4d 16h ago.  4d 16h ago was here and on the channel #wesnoth-umc-dev with the message: Quit: Not here much atm. Will check logs for my nick and forum PMs.
20150617 18:20:12-!- oldlaptop_ is now known as oldlaptop
20150617 18:21:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150617 18:23:52< Ravana_> I mostly misunderstood which is why I fought against this so much
20150617 18:27:34-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150617 18:57:20< gfgtdf> Ravana_, zookeeper: do you know ehther it is posible to pass parameters to wesnoth difile ?
20150617 18:59:41< Ravana_> no idea, haven't used it as it needs download for everyone
20150617 19:00:18-!- Appleman1234_ [~Appleman1@KD106154025087.au-net.ne.jp] has joined #wesnoth-dev
20150617 19:01:56< gfgtdf> Ravana_: for for example for eras with units you need donwload for everyone anyway and it easier to use than inline lua.
20150617 19:03:14-!- Appleman1234__ [~Appleman1@KD106178168025.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20150617 19:05:33< Ravana_> I haven't used that much lua, in era I used it only for getting current terrain def of unit(annoyance to get with pure wml), 4 lines, and for wesnoth.message 1 line, as [chat] is unsuitable
20150617 19:06:24< Ravana_> for orocia I use lua a lot more as wml would be too slow, but there requiring download can't be allowed
20150617 19:08:44< gfgtdf> Ravana_: so you include lua files via {...myfile.lua} syntax ?
20150617 19:08:57< Ravana_> I don't use .lua at all
20150617 19:09:12< Ravana_> only [lua]
20150617 19:10:09< gfgtdf> Ravana_: i actually hate to put lua code inside wml files mostly becasue my editor wont use lua syntax highlichting and indention then.
20150617 19:13:36< Ravana_> http://puu.sh/iszPI/28acf57ff0.png is most complicated piece of lua I technically could put to separate file
20150617 19:13:45< Ravana_> I just don't need syntax highlighting there, and nothing to indent either
20150617 19:15:33< gfgtdf> Ravana_: hm ok
20150617 19:15:46< Ravana_> actually notepad++ allows me to use whatever language syntax highlighting I want
20150617 19:15:58< Ravana_> no matter if its .cfg or something else
20150617 19:16:19< gfgtdf> Ravana_: yes but even if you select lua highlichting it migth be confused by surrounds cwml content
20150617 19:16:28< gfgtdf> Ravana_: esp for ine thindention
20150617 19:16:36< gfgtdf> intention/wrapping
20150617 19:16:44< Ravana_> can be
20150617 19:17:14< Ravana_> if I start to use more complicated lua I will adapt accordingly
20150617 19:17:32< Ravana_> like for releases still [lua], but for creating .lua
20150617 19:19:43< gfgtdf> Ravana_: i personnaly youw use .lua for both but code = {~/.../myfile.lua} for release and code = << wesnoth.dofile "~/.../myfile.lua" >>for creating
20150617 19:19:50< zookeeper> gfgtdf, pass parameters to what?
20150617 19:20:31< gfgtdf> to wesnoth.dofile
20150617 19:21:32< zookeeper> i'm afraid i know nothing
20150617 19:22:04< gfgtdf> zookeeper: i mean [lua] code=<<>> has a ... parameter that cna be passed. and i want soimilar for dofile.
20150617 19:24:58< c74d> gfgtdf: no, other than by (1) having the executed script return a function (which can take arbitrary parameters) that the caller of `wesnoth.dofile` then calls, or (2) setting global variables that the executed script then reads.
20150617 19:25:31< gfgtdf> c74d: thx
20150617 19:50:24-!- horrowin1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150617 19:54:58-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150617 19:55:36< mattsc> gfgtdf: hi — were you going to ask me the dofile() question?
20150617 19:55:54< gfgtdf> mattsc: no it was something differtn but i already ound out
20150617 19:56:54< mattsc> gfgtdf: okay; for the dofile thing, I assume you don’t need that, but here’s an example of the first option c74d was talking about:
20150617 19:56:55< mattsc> https://github.com/mattsc/AI-demos/blob/master/lua/fred.lua
20150617 19:57:03< mattsc> you then call that with
20150617 19:57:28< mattsc> local fred = wesnoth.dofile(fn).init(ai)
20150617 19:57:53< mattsc> Don’t look at the rest of the file, it’s a holy mess at the moment  :P
20150617 20:00:39< gfgtdf> mattsc; ok i coudl also just directly return a function and use wesnoth.dofile('file.lua')('hello') right ?
20150617 20:02:44< mattsc> gfgtdf: yes, I think so  (and you’re right, this isn’t exactly what c74d said; your desription is closer to it; I forgot why I set it up in this way, it was a long way ago and I knew even less what I was doing then than I do now)
20150617 20:09:46< c74d> gfgtdf: yes, you could (also `wesnoth.dofile 'file.lua' 'hello'`, because parentheses aren't required when you're only passing a single literal string as argument).
20150617 20:20:22-!- mjs-de [~mjs-de@f048203241.adsl.alicedsl.de] has quit [Remote host closed the connection]
20150617 20:28:37< shadowm> gfgtdf: They at least remain on the screen for a longer amount of time by default (specifically, the Chat Message Aging value in Preferences → Advanced).
20150617 20:31:42-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150617 20:45:40< gfgtdf> shadowm: so which do you think is best gui->get_chat_manager().add_chat_message, gui2::show_transient_message or gui->announce ?
20150617 21:00:33< shadowm> I don't know what the first an the third do. The second shows a GUI2 message dialog, which monopolizes the event loop.
20150617 21:01:18< shadowm> That means that no game events can be processed while it's shown, which might be undesirable for someone that's afk.
20150617 21:08:26-!- lipkab [~lipkab@host-91-147-210-193.biatv.hu] has joined #wesnoth-dev
20150617 21:08:31< gfgtdf> shadowm: i'd think that if people are afk then they cannot issue any events?
20150617 21:08:49-!- hay207 [~haythamme@41.34.43.124] has quit [Quit: Leaving]
20150617 21:09:33< shadowm> gfgtdf: I don't think you understood the implications.
20150617 21:10:01< shadowm> If a GUI2 (or GUI1, for that matter) dialog is active, the host can't process any incoming network data.
20150617 21:10:46< gfgtdf> shadowm: so that the server might get aconnection timeout ?
20150617 21:10:50< shadowm> I *believe* it won't disconnect since network transfers take place on a separate thread IIRC, but all the data received in the meantime will pile up.
20150617 21:11:28< shadowm> So once the dialog is dismissed, there might be several minutes of game actions to execute, and even more dialogs.
20150617 21:11:56< gfgtdf> shadowm: is that really that bad ? i think there are even people who explicitly want this so that they can replay what happened while they are afk.
20150617 21:12:09-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Not here much atm. Will check logs for my nick and forum PMs.]
20150617 21:12:22< shadowm> They can do this themselves if they want by bringing up the Chat Log or Objectives dialogs before leaving.
20150617 21:12:32< shadowm> I don't see why we should force it on everyone else.
20150617 21:13:35< gfgtdf> shadowm: hm ok
20150617 21:18:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150617 21:19:17< lipkab> gfgtdf: About SP/MP: so, if I read you well, options and modifications is pretty much the only gain in this project.
20150617 21:20:29< lipkab> Options are pretty straightforward at least regarding level initialization, the main issue there is the GUI
20150617 21:20:51-!- Kwandulin [~Miranda@p5B008628.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150617 21:21:34< lipkab> So that leaves modifications only.
20150617 21:21:50< gfgtdf> lipkab: hmm thats what i think, the original autor most likeley thinks diffrent. Also my main point was that that all those bugs that we now have in sp campaigns wont go away if we bring back the original codepath since they will still effect mp campaigns.
20150617 21:22:25-!- horrowin1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has quit [Quit: horrowin1]
20150617 21:23:03< gfgtdf> lipkab: i persoanlly think gui is the hardest part for most of these things so i woudl say say it leaves onyl modifications
20150617 21:23:25< lipkab> At least some of the bugs I saw are about MP settings being inappropriately applied to SP campaigns.
20150617 21:23:52< lipkab> Those definitely should go away by going back.
20150617 21:24:06< gfgtdf> lipkab: yes an my point is they they shoudl not be applied to mp capaigsn eigher.
20150617 21:24:13< lipkab> Or fixed by... well, separating SP and MP codepaths :P
20150617 21:24:54< lipkab> Ok, so you instead of the MP/SP separation we should have scenario/campaign?
20150617 21:25:01< lipkab> *you think
20150617 21:25:37< gfgtdf> lipkab: well for mp campaigsn we need mp connect and stuff to connect to mp server and find players
20150617 21:26:23< gfgtdf> lipkab: if you want to bring back teh old sp path and can add modification options to it im find with that. Then we coudl maybe try to fix those bugs first and think again about mpsp unification.
20150617 21:26:41< gfgtdf> s/find/fine
20150617 21:27:46< gfgtdf> those bugs: changed default for mp campaigns. For example in 1.12 in LoW camapoign it always showed the 'advantage' dialog which is quiet useless there
20150617 21:28:24-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150617 21:28:47< lipkab> Well, MP campaigns are a niche market and has been traditionally buggy.
20150617 21:29:31< lipkab> So even if some of those bugs would still persist, it wouldn't hinder like it does now.
20150617 21:30:54< lipkab> I think unless someone (I don't deal with this stuff, so read someone as 'you') can fix them in a sane timeframe, we should revert.
20150617 21:31:02< gfgtdf> lipkab: i persoanlly think it is annyoing. But sure it is not top priority like fixing sp.
20150617 21:31:06< gfgtdf> lipkab: revert ?
20150617 21:31:25< gfgtdf> lipkab: there are many other changes done in those multiplayer_.. files
20150617 21:31:40< gfgtdf> lipkab: i am not sure whethe rrevert is easily possible.
20150617 21:32:12-!- StandYourGround [~Adium@2602:306:83db:de50:99b1:8ca:cb3d:381d] has joined #wesnoth-dev
20150617 21:32:15< lipkab> Well, go back to the old SP codepath... I don't know if a git revert is technically possible.
20150617 21:33:15< lipkab> Also, I don't want to have the final word on this - as I said before, you're definitely the most experienced in this area, so you should make the decision.
20150617 21:41:05< gfgtdf> lipkab: do you think you can implement [modification]s and [option]s for sp if i revert it ?
20150617 21:45:26< lipkab> gfgtdf: Sure I can - but I don't know when ;)
20150617 21:49:15< lipkab> gfgtdf: I'm going now, will read the logs. Bye.
20150617 21:49:17-!- lipkab [~lipkab@host-91-147-210-193.biatv.hu] has quit [Quit: Távozom]
20150617 21:53:22-!- StandYourGround [~Adium@2602:306:83db:de50:99b1:8ca:cb3d:381d] has quit [Quit: Leaving.]
20150617 22:04:03-!- Appleman1234__ [~Appleman1@KD106178162170.au-net.ne.jp] has joined #wesnoth-dev
20150617 22:06:54-!- Appleman1234_ [~Appleman1@KD106154025087.au-net.ne.jp] has quit [Ping timeout: 276 seconds]
20150617 22:07:34-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150617 22:26:01-!- irker310 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150617 22:26:01< irker310> wesnoth: gfgtdf wesnoth:master 3ffca3067e37 / src/synced_commands.cpp: refactor debug notification http://git.io/vLBOt
20150617 22:26:01< irker310> wesnoth: gfgtdf wesnoth:master 5c99ab7e6901 / src/game_initialization/playcampaign.cpp: remove unused default value http://git.io/vLBOq
20150617 22:26:02< irker310> wesnoth: gfgtdf wesnoth:master 024c56459e56 / src/ (4 files in 2 dirs): option to disable most of spmp patch http://git.io/vLBOm
20150617 22:41:24-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150617 23:04:08< gfgtdf> shadowm: you know whether it is a difference (in loaidng time) whether to use {myfile.cfg} multiple times or to let myfile.cfg defien a macro whcih is then used multiple times ?
20150617 23:05:20-!- Appleman1234__ is now known as Appleman1234
20150617 23:07:05< shadowm> What do you think?
20150617 23:19:21< gfgtdf> My first gues is tahrt every {...mafle.cfg} reads the fiel again but im not sure abaout whether wesnoth or maybe even the OS optimized for that
20150617 23:19:30< gfgtdf> shadowm: ^
20150617 23:20:28-!- Kallikanzarid [~textual@46.181.226.42] has joined #wesnoth-dev
20150617 23:20:31< gfgtdf> for multpile reads of same file i mean
20150617 23:21:18< c74d> Operating systems generally are; I doubt BfW is.
20150617 23:21:21< shadowm> Wesnoth is not (though note that the WML preprocessor cache exists to avoid going through this kind of thing every time).
20150617 23:21:54< gfgtdf> i specially wonder whether https://github.com/wesnoth/wesnoth/blob/master/data/multiplayer/eras.cfg should be opimized by replacing those many {multiplayer/factions/ .. .cfg} inclusions
20150617 23:22:11< shadowm> On Linux, the file will be read into the inode cache and remain there until the cache entry expires.
20150617 23:24:04< shadowm> I suspect Windows has a similar mechanism built in (it does cache disk access in some form) but I don't know for sure.
20150617 23:25:06< shadowm> In this case, it's a small number of files so we can sacrifice a few millisconds for code readability.
20150617 23:50:49-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds]
--- Log closed Thu Jun 18 00:00:23 2015