--- Log opened Sun Jul 12 00:00:18 2015
20150712 00:35:39-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20150712 01:13:47-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-uugvpniwcminqphm] has quit [Ping timeout: 240 seconds]
20150712 01:23:51-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-jqgjokiqofeuryhr] has joined #wesnoth-dev
20150712 01:24:14-!- matthiaskrgr is now known as Guest62264
20150712 01:24:18-!- StandYourGround [~Adium@2602:306:83db:de50:2d13:d09c:f5bb:30a6] has joined #wesnoth-dev
20150712 01:39:36-!- StandYourGround [~Adium@2602:306:83db:de50:2d13:d09c:f5bb:30a6] has left #wesnoth-dev []
20150712 01:39:53-!- StandYourGround [~Adium@2602:306:83db:de50:2d13:d09c:f5bb:30a6] has joined #wesnoth-dev
20150712 01:41:34-!- StandYourGround [~Adium@2602:306:83db:de50:2d13:d09c:f5bb:30a6] has quit [Quit: Leaving.]
20150712 02:07:17-!- irker161 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150712 02:07:17< irker161> wesnoth: Charles Dang wesnoth:master 7397477b6e19 / data/campaigns/Under_the_Burning_Suns/units/elves/Kaleh.cfg: UtBS: cleaned up Kaleh's unit file http://git.io/vqpct
20150712 02:08:52 * vultraz dusts off hands
20150712 02:11:17< pydsigner> vultraz: line 438
20150712 02:11:34< pydsigner> and 452
20150712 02:11:43< pydsigner> and 466
20150712 02:11:57< vultraz> ..?
20150712 02:12:09< vultraz> Oh
20150712 02:12:13< pydsigner> Yeah
20150712 02:12:26< pydsigner> Most of those you caught, but those three got way
20150712 02:12:28< pydsigner> * awaty
20150712 02:12:32< pydsigner> * away
20150712 02:13:32< irker161> wesnoth: Charles Dang wesnoth:master 51f024290303 / data/campaigns/Under_the_Burning_Suns/units/elves/Kaleh.cfg: UtBS: fixup 7397477b6e19, dropped some commented out code http://git.io/vqpcN
20150712 02:13:52< vultraz> thanks
20150712 02:16:15< irker161> wesnoth: Charles Dang wesnoth:master 728d8260d071 / data/campaigns/Under_the_Burning_Suns/scenarios/01_The_Morning_After.cfg: UtBS S1: no need for difficulty-variant gold if it's always 0 http://git.io/vqpCD
20150712 02:17:58< pydsigner> ^ Those always drive me nuts
20150712 02:31:42-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20150712 02:34:06-!- Appleman1234__ [~Appleman1@KD106152042061.au-net.ne.jp] has joined #wesnoth-dev
20150712 02:36:43-!- Appleman1234_ [~Appleman1@KD106152037051.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20150712 02:38:38< irker161> wesnoth: Charles Dang wesnoth:master 5eebd30c330f / data/campaigns/Under_the_Burning_Suns/ (scenarios/13_Epilogue.cfg utils/storytxt.cfg): UtBS: dropped the Epilogue storytext screen http://git.io/vqp4I
20150712 02:45:24-!- travis-ci [~travis-ci@ec2-54-90-203-144.compute-1.amazonaws.com] has joined #wesnoth-dev
20150712 02:45:25< travis-ci> wesnoth/wesnoth#6753 (master - 7397477 : Charles Dang): The build is still failing.
20150712 02:45:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/70572045
20150712 02:45:25-!- travis-ci [~travis-ci@ec2-54-90-203-144.compute-1.amazonaws.com] has left #wesnoth-dev []
20150712 02:53:20< irker161> wesnoth: Charles Dang wesnoth:master 7b5dacbec3c2 / data/campaigns/Under_the_Burning_Suns/ (_main.cfg lua/theme.lua utils/dehydration-utils.cfg): UtBS: unified dehydration and stunned theme status icon checks http://git.io/vqpBX
20150712 03:09:32-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 250 seconds]
20150712 03:10:24-!- travis-ci [~travis-ci@ec2-54-90-203-144.compute-1.amazonaws.com] has joined #wesnoth-dev
20150712 03:10:25< travis-ci> wesnoth/wesnoth#6754 (master - 51f0242 : Charles Dang): The build is still failing.
20150712 03:10:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/70572305
20150712 03:10:25-!- travis-ci [~travis-ci@ec2-54-90-203-144.compute-1.amazonaws.com] has left #wesnoth-dev []
20150712 03:11:31-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150712 03:31:25-!- travis-ci [~travis-ci@ec2-54-196-158-38.compute-1.amazonaws.com] has joined #wesnoth-dev
20150712 03:31:26< travis-ci> wesnoth/wesnoth#6755 (master - 728d826 : Charles Dang): The build is still failing.
20150712 03:31:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/70572434
20150712 03:31:26-!- travis-ci [~travis-ci@ec2-54-196-158-38.compute-1.amazonaws.com] has left #wesnoth-dev []
20150712 03:39:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20150712 03:43:41-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150712 03:59:04-!- travis-ci [~travis-ci@ec2-54-145-109-2.compute-1.amazonaws.com] has joined #wesnoth-dev
20150712 03:59:05< travis-ci> wesnoth/wesnoth#6756 (master - 5eebd30 : Charles Dang): The build is still failing.
20150712 03:59:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/70573684
20150712 03:59:05-!- travis-ci [~travis-ci@ec2-54-145-109-2.compute-1.amazonaws.com] has left #wesnoth-dev []
20150712 04:15:03-!- oldlaptop [~quassel@50-107-124-87.adr02.mskg.mi.frontiernet.net] has quit [Ping timeout: 256 seconds]
20150712 04:20:47-!- travis-ci [~travis-ci@ec2-54-196-158-38.compute-1.amazonaws.com] has joined #wesnoth-dev
20150712 04:20:47< travis-ci> wesnoth/wesnoth#6757 (master - 7b5dacb : Charles Dang): The build is still failing.
20150712 04:20:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/70574372
20150712 04:20:47-!- travis-ci [~travis-ci@ec2-54-196-158-38.compute-1.amazonaws.com] has left #wesnoth-dev []
20150712 04:20:48-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 264 seconds]
20150712 04:40:44-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20150712 05:08:38-!- tomreyn_ [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150712 05:12:24-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Ping timeout: 264 seconds]
20150712 05:12:35-!- oldlaptop [~quassel@50-107-124-87.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150712 05:22:14-!- oldlaptop [~quassel@50-107-124-87.adr02.mskg.mi.frontiernet.net] has quit [Read error: Connection timed out]
20150712 05:24:04-!- oldlaptop [~quassel@50-107-124-87.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150712 05:33:10-!- Appleman1234__ is now known as Appleman1234
20150712 05:36:19-!- Guest62264 [matthiaskr@gateway/shell/panicbnc/x-jqgjokiqofeuryhr] has quit [Changing host]
20150712 05:36:19-!- Guest62264 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20150712 05:36:19-!- Guest62264 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20150712 05:36:19-!- Guest62264 [matthiaskr@gateway/shell/panicbnc/x-jqgjokiqofeuryhr] has joined #wesnoth-dev
20150712 05:36:38-!- Guest62264 is now known as matthiaskrgr
20150712 05:53:48-!- Kwandulin [~Miranda@p5B008A3F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150712 06:09:53-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Remote host closed the connection]
20150712 06:10:42-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150712 06:18:09-!- [Relic] [~Relic]@2602:306:33a3:6d30:9c08:3618:88f8:6a6a] has quit [Quit: I press the magic X and all the weirdos go away!]
20150712 06:32:03< vultraz> any objections? https://dl.dropboxusercontent.com/u/95558676/new%20sandstorm%20icon%20proposal.PNG 
20150712 06:32:07< vultraz> (left to replace right)
20150712 06:56:00< pydsigner> No
20150712 06:57:39-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 252 seconds]
20150712 07:05:48< pydsigner> Something that would be incredibly useful IMO is a better way to handle music
20150712 07:06:18< pydsigner> No-one wants to require 10 UMC Music packs, and so they make their own
20150712 07:07:16< pydsigner> And the best tracks end up 10 times on your computer.
20150712 07:08:12< vultraz> what would you propose?
20150712 07:10:29< irker161> wesnoth: Charles Dang wesnoth:master f4231e52dfc3 / data/campaigns/Under_the_Burning_Suns/images/attacks/sand-storm.png: UtBS: new sandstorm attack icon http://git.io/vqppm
20150712 07:12:44< pydsigner> Having "provides_music" and "requires_music" keys in _server.pbl.
20150712 07:14:44< pydsigner> Then have a toplevel music tag (like campaign or multiplayer) that maps an id to a path.
20150712 07:15:58< pydsigner> This last bit could be done unofficially with Lua, but it'd be rather fail to only go half way.
20150712 07:17:52< pydsigner> Then if you don't have a music track that is required, you are shown a list box of the addons that provides_music for that track.
20150712 07:18:52< pydsigner> What this would hopefully lead to is a music addon type and a bunch of non-conflicting, single track music addons.
20150712 07:19:50< pydsigner> Todays collections could be left as requires_music shims.
20150712 07:19:55< pydsigner> * Today's
20150712 07:34:55-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20150712 07:40:03-!- travis-ci [~travis-ci@ec2-54-145-109-2.compute-1.amazonaws.com] has joined #wesnoth-dev
20150712 07:40:04< travis-ci> wesnoth/wesnoth#6758 (master - f4231e5 : Charles Dang): The build is still failing.
20150712 07:40:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/70586669
20150712 07:40:04-!- travis-ci [~travis-ci@ec2-54-145-109-2.compute-1.amazonaws.com] has left #wesnoth-dev []
20150712 07:40:23< vultraz> GOD DAMMIT TRAVIS
20150712 07:55:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150712 08:44:34-!- Appleman1234_ [~Appleman1@KD106152052046.au-net.ne.jp] has joined #wesnoth-dev
20150712 08:46:36-!- Appleman1234 [~Appleman1@KD106152042061.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20150712 09:14:08-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20150712 09:45:38-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20150712 09:54:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150712 09:58:51< zookeeper> vultraz, you broke it! it's all your fault!
20150712 10:00:28-!- mjs-de [~mjs-de@f049240090.adsl.alicedsl.de] has joined #wesnoth-dev
20150712 10:10:40-!- irker161 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150712 10:33:41-!- Kwandulin_2 [~Miranda@p5B008E03.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150712 10:35:17-!- Kwandulin [~Miranda@p5B008A3F.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
20150712 11:07:24-!- Jetrel__ [~Jetrel@c-73-164-34-22.hsd1.mn.comcast.net] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20150712 11:08:17-!- Jetrel [~Jetrel@c-73-164-34-22.hsd1.mn.comcast.net] has joined #wesnoth-dev
20150712 11:10:40-!- Appleman1234_ is now known as Appleman1234
20150712 11:12:41-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has joined #wesnoth-dev
20150712 11:17:13-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has quit [Ping timeout: 256 seconds]
20150712 11:18:08-!- tomreyn_ is now known as tomreyn
20150712 11:24:25-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has joined #wesnoth-dev
20150712 11:28:13-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has quit [Read error: Connection reset by peer]
20150712 11:33:14-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has joined #wesnoth-dev
20150712 11:34:18-!- horrowin1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150712 11:39:56-!- gfgtdf [~chatzilla@x50abb0bf.dyn.telefonica.de] has joined #wesnoth-dev
20150712 11:42:53< gfgtdf> vultraz: zookeeper is right, you broke the travis build in b30e01422b59700b4292f778ac61dd40ddfc7871.
20150712 11:46:01< gfgtdf> and yes, i saw that that commit only changes UTbS wml files.
20150712 11:47:17-!- gfgtdf [~chatzilla@x50abb0bf.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 39.0/20150630154324]]
20150712 11:55:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150712 11:56:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150712 12:02:11-!- gfgtdf [~chatzilla@x55b17762.dyn.telefonica.de] has joined #wesnoth-dev
20150712 12:02:30< gfgtdf> shadowm: you know why we escape the files here https://github.com/wesnoth/wesnoth/blob/68dfe27bbddd66d56eb160f8f19eb2d0600a4968/src/serialization/preprocessor.cpp#L82 
20150712 12:03:17< gfgtdf> shadowm: i think that also teh eason why the filenames appear escaped in stderr oin config loading errors
20150712 12:11:36-!- Elvish_Hunter [~irssi@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20150712 12:13:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150712 12:14:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150712 12:21:40-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has quit [Remote host closed the connection]
20150712 12:22:20-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has joined #wesnoth-dev
20150712 12:27:04-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has quit [Ping timeout: 256 seconds]
20150712 12:27:23< Elvish_Hunter> Hi all
20150712 12:27:30< gfgtdf> Elvish_Hunter: hi
20150712 12:27:48< Elvish_Hunter> Sorry that I disappeared, but I was really busy these days...
20150712 12:28:03-!- horrowin1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has quit [Quit: horrowin1]
20150712 12:28:27< Elvish_Hunter> zookeeper: about Garak's experience, I attempted to remove his XP limit
20150712 12:29:09< Elvish_Hunter> It turned out that, if no [unit_type] experience= value is supplied, the C++ code automatically assigns a default value of 500 XP
20150712 12:29:32< vultraz> o_O
20150712 12:29:39< vultraz> where did that come from
20150712 12:29:52< vultraz> why isn't it like...32
20150712 12:29:58< Elvish_Hunter> Also, not adding the advances=to= key doesn't work any more for that purpose, because the C++ code checks both for the "null" value and for an empty string
20150712 12:30:22< Elvish_Hunter> So, in PR #416, I was forced to just raise Garak's max XP to 1000
20150712 12:30:39-!- horrowin1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150712 12:31:24< Elvish_Hunter> vultraz: no idea, it looks like 500 is a 'magic number', as it's completely uncommented...
20150712 12:31:37< vultraz> what's so magic about it?
20150712 12:32:21< Elvish_Hunter> 'Magic numbers' are arbirtary values in source code, which are completely unexplained
20150712 12:32:42< vultraz> maybe you should change it
20150712 12:33:10< Elvish_Hunter> Or at least, add a comment
20150712 12:33:32< gfgtdf> i see no reason to change it, but it woudl be good to give an erro message in case no expereince= was spcified
20150712 12:36:05< vultraz> 32 just seems a more sensible default 
20150712 12:38:20< Elvish_Hunter> Why 32? Level 0 units require 25 XP to advance, wile level 1 require 50 XP (of course, I'm speaking for AMLAs)
20150712 12:38:41< Elvish_Hunter> *while, not wile
20150712 12:39:43< gfgtdf> you could also use the level*50 or similar as a default.  but i still dont think its that important
20150712 12:41:39< gfgtdf> Elvish_Hunter: what was the beahviour of no advances_to key in odler wesnoth versions ?
20150712 12:45:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150712 12:45:27< Elvish_Hunter> In older versions (if I remember correctly), units without advances_to= were able to accumulate XP points indefinitely without ever advancing
20150712 12:45:31-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150712 12:46:00< gfgtdf> Elvish_Hunter: and what happens to them now if they have reache the max expereince ?
20150712 12:52:42< Elvish_Hunter> If no max_experience is supplied (either directly, or by [unit_type]), or it's a value that cannot be cast as int, the game sets the max_experience value to 500
20150712 12:57:53< vultraz> 32 because it's a nice low-hanging value of 4 kills
20150712 13:00:11-!- horrowin1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has quit [Quit: horrowin1]
20150712 13:00:21-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 246 seconds]
20150712 13:05:31-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20150712 13:07:01-!- irker533 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150712 13:07:01< irker533> wesnoth: Charles Dang wesnoth:master 95ba1b2206e2 / data/campaigns/Under_the_Burning_Suns/ (scenarios/02_Across_the_Harsh_Sands.cfg utils/dehydration-utils.cfg): UtBS: only include dehydration events via macro in S2 http://git.io/vqjTt
20150712 13:11:59< vultraz> anyone have any objections against merging 417?
20150712 13:17:33-!- Kwandulin_2 [~Miranda@p5B008E03.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150712 13:18:32< gfgtdf> vultraz, zookeeper: i canot say for teh images, but for the c++ part: 
20150712 13:18:54< gfgtdf> in https://github.com/ln-zookeeper/wesnoth/commit/3b5d217feab42b515012c23929244b7271e95ee3#diff-3a8cb38f493df509729ea878cbcf1c30R648 why is there a temporary flag_list  object
20150712 13:19:39< gfgtdf> also the name 'has_flag_' is against our conventions, usualy we use variablenames taht end with _ for memeber variables
20150712 13:20:32-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has joined #wesnoth-dev
20150712 13:21:38< gfgtdf> Also std::set might be better than std::vector for flags becasue you uslala want to use that for loookup.
20150712 13:22:09< gfgtdf> dont know whether that also true fo there are just very few elements
20150712 13:23:44-!- Kexoth [~kex@31-151-58-117.dynamic.upc.nl] has joined #wesnoth-dev
20150712 13:25:09-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has quit [Ping timeout: 255 seconds]
20150712 13:28:02-!- Kexoth [~kex@31-151-58-117.dynamic.upc.nl] has quit [Ping timeout: 244 seconds]
20150712 13:35:55-!- Appleman1234 [~Appleman1@KD106152052046.au-net.ne.jp] has left #wesnoth-dev ["Leaving"]
20150712 13:37:30-!- travis-ci [~travis-ci@ec2-54-196-158-38.compute-1.amazonaws.com] has joined #wesnoth-dev
20150712 13:37:31< travis-ci> wesnoth/wesnoth#6759 (master - 95ba1b2 : Charles Dang): The build has errored.
20150712 13:37:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/70607656
20150712 13:37:31-!- travis-ci [~travis-ci@ec2-54-196-158-38.compute-1.amazonaws.com] has left #wesnoth-dev []
20150712 13:42:48< gfgtdf> vultraz: can you please fix the travis build ?
20150712 13:54:44-!- Kwandulin [~Miranda@p5B008E03.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150712 14:00:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150712 14:00:34-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150712 14:02:55< vultraz> gfgtdf: how?
20150712 14:04:10< vultraz> wml files should have no bearing on the builds anyway
20150712 14:04:26< gfgtdf> vultraz: but on teh unit tests which travis does
20150712 14:04:50< gfgtdf> vultraz: somehere  the trst scenario must include parts of UTbS.
20150712 14:05:08< gfgtdf> vultraz: which got then broken after your commits.
20150712 14:05:11< gfgtdf> vultraz: test*
20150712 14:37:44< zookeeper> gfgtdf, well i imitated existing flag code so that's why it's a vector of strings. and what alternative to flag_list would there be? just assign the split result directly to has_flag?
20150712 14:38:44< zookeeper> i waffled about the underscore for a while, but had to somehow distinguish it from the member variable so i tacked on the underscore after i found one similar existing example
20150712 14:39:12< zookeeper> of course i can rename it if needed
20150712 14:39:46< gfgtdf> zookeeper: yes, assigning teh split result directly to has_flag is better unledd there is a good reason not to do so.
20150712 14:39:56< gfgtdf> zookeeper: whic existing code did you imitate ?
20150712 14:40:42< zookeeper> gfgtdf, the code for [tile] has_flag
20150712 14:40:43< gfgtdf> zookeeper: for exmaple the tod memeber used a std::set
20150712 14:40:53< gfgtdf> zookeeper: ah ok
20150712 14:42:03< zookeeper> and in for example terrain_builder::add_constraints a temp var is used for the split results, _maybe_ to make sure the flags are added to any pre-existing ones
20150712 14:42:09 * zookeeper shrugs
20150712 14:43:46< gfgtdf> zookeeper: yes that seems to be the reason
20150712 14:45:04< gfgtdf> zookeeper: in your case doing assigning diretly is faster and easier to read.
20150712 14:45:30< zookeeper> i can make that change if you want (and are sure about it)
20150712 14:45:41< zookeeper> what should i rename the argument to?
20150712 14:46:34< zookeeper> (i'm not sure if it works if it's named "has_flag", maybe it does)
20150712 14:47:58< gfgtdf> zookeeper: you can rename it to has_flag, but then you must write this->has_flag for the odl has_flag
20150712 14:48:04< gfgtdf> old*
20150712 14:48:51< gfgtdf> so like    this->has_flag = utils::split(has_flag);
20150712 14:49:12< gfgtdf> since the other arguments are named the same way i think thats the best.
20150712 14:50:55-!- [Relic] [~Relic]@2602:306:33a3:6d30:81b0:478e:3022:5b2d] has joined #wesnoth-dev
20150712 14:53:34< Elvish_Hunter> Well, now I have to go. Bye!
20150712 14:53:41< zookeeper> if(!has_flag.empty()) {		this->has_flag = utils::split(has_flag);	}
20150712 14:53:42< zookeeper> got it
20150712 14:53:50-!- Elvish_Hunter [~irssi@wesnoth/developer/elvish-hunter] has left #wesnoth-dev ["Ciao!"]
20150712 14:53:54< zookeeper> well, i'll put that in
20150712 14:57:22< zookeeper> done
20150712 15:12:30-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has joined #wesnoth-dev
20150712 15:17:29-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has quit [Ping timeout: 256 seconds]
20150712 15:26:19< vultraz> is there any way to rebase that merge commit out?
20150712 15:50:47< zookeeper> i'm sure with git most things are possible, but don't expect me to be able to do it
20150712 15:59:34-!- gfgtdf [~chatzilla@x55b17762.dyn.telefonica.de] has quit [Ping timeout: 256 seconds]
20150712 16:07:11-!- irker533 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150712 16:22:20-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has joined #wesnoth-dev
20150712 16:26:55-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has quit [Ping timeout: 246 seconds]
20150712 16:35:23-!- Kallikanzarid [~textual@46.181.226.42] has joined #wesnoth-dev
20150712 16:35:37< Kallikanzarid> hi
20150712 16:36:46< Kallikanzarid> https://github.com/wesnoth/wesnoth/blob/master/src/hotkey_handler.cpp#L106
20150712 16:36:56< Kallikanzarid> what do the magic numbers mean here?
20150712 16:50:10-!- Kallikanzarid [~textual@46.181.226.42] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150712 16:51:38-!- Kallikanzarid [~textual@46.181.226.42] has joined #wesnoth-dev
20150712 17:02:19-!- Kwandulin [~Miranda@p5B008E03.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150712 17:05:12-!- Kallikanzarid [~textual@46.181.226.42] has quit [Quit: Textual IRC Client: www.textualapp.com]
20150712 18:24:58< shadowm> gfgtdf: I remember looking into it before, it was probably something having to do with whitespace in paths.
20150712 18:26:10< shadowm> vultraz: Run wesnoth with -t. 
20150712 18:26:27< shadowm> Then if you can figure out the rest you'll fix travis builds too.
20150712 18:27:11-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150712 18:28:34< pydsigner> shadowm: Did you see my thoughts above on music?
20150712 18:30:35< shadowm> gfgtdf, vultraz, zookeeper: I want to review #417 first.
20150712 18:30:59< zookeeper> please do
20150712 18:31:16< shadowm> It'll take me a day or two though.
20150712 18:31:23< zookeeper> fair enough
20150712 18:32:01< zookeeper> i hope there's no performance problems with it... that'd be my main concern
20150712 18:33:56< shadowm> pydsigner: It sounds way too complicated.
20150712 18:34:41-!- horrowind [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150712 18:36:45< pydsigner> shadowm: The hardest part would be the music_provides key, although it's the most important as well.
20150712 18:37:32< shadowm> No, the hardest part (and it's not actually *hard*, it's just not very conventional) is having a music dictionary.
20150712 18:38:47< shadowm> The new add-on attributes also duplicate functionality for a niche purpose which I'm not sure is that important.
20150712 18:39:17< shadowm> Ultimately, if add-on authors wanted to allow using other add-ons for music, they already have the tools available to do so (#ifhave).
20150712 18:40:30< pydsigner> That isn't the point.
20150712 18:41:30< pydsigner> Authors want to have their scoring work, and so they include all their used music themselves, even though it's almost always already available in another addon.
20150712 18:42:19< shadowm> I've done that before.
20150712 18:42:41< zookeeper> it's not very elegant, but is it a major problem? how many people download such a large number of add-ons that they're wasting hundreds of mb's of diskspace for duplicate music tracks?
20150712 18:44:00< pydsigner> Anyone who has several of the music-including addons
20150712 18:45:13< pydsigner> I have 5 of the split off music addons
20150712 18:47:31< pydsigner> Plus some addons that include music.
20150712 18:47:45< pydsigner> None of the UMC Music or Westlund packs.
20150712 18:48:18-!- gfgtdf [~chatzilla@x55b17762.dyn.telefonica.de] has joined #wesnoth-dev
20150712 18:50:03< pydsigner> Yet I have, 5x Snowfall, 4x Through the Gates, 3x Dark Passage, 3x Gathering Storm, etc.
20150712 18:52:33-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20150712 18:54:54< pydsigner> Possibly more, because people use non-standard names for music as well.
20150712 19:09:24-!- gfgtdf [~chatzilla@x55b17762.dyn.telefonica.de] has quit [Ping timeout: 264 seconds]
20150712 19:44:00-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 265 seconds]
20150712 19:44:22-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150712 19:58:15-!- irker951 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150712 19:58:15< irker951> wesnoth: gfgtdf wesnoth:master 4c75f6cf66d0 / src/persist_var.cpp: make side=global the default for [get/set_global_variable] http://git.io/vmepO
20150712 19:58:17< irker951> wesnoth: gfgtdf wesnoth:master 37293b257698 / src/ (5 files in 2 dirs): Fix unsynced wml menu items http://git.io/vmeps
20150712 19:58:19< irker951> wesnoth: gfgtdf wesnoth:master c449fcbce217 / src/game_events/menu_item.cpp: fix unsynced wml menu items http://git.io/vmepG
20150712 19:58:21< irker951> wesnoth: gfgtdf wesnoth:master e4962c47f826 / src/ (9 files in 4 dirs): refactor set_scontext_(un)synced classes http://git.io/vmepZ
20150712 20:19:00-!- travis-ci [~travis-ci@ec2-54-166-15-42.compute-1.amazonaws.com] has joined #wesnoth-dev
20150712 20:19:01< travis-ci> wesnoth/wesnoth#6761 (master - e4962c4 : gfgtdf): The build failed.
20150712 20:19:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/70644918
20150712 20:19:01-!- travis-ci [~travis-ci@ec2-54-166-15-42.compute-1.amazonaws.com] has left #wesnoth-dev []
20150712 21:01:58-!- Kallikanzarid [~textual@46.181.226.42] has joined #wesnoth-dev
20150712 21:02:32< Kallikanzarid> for a record: whoever thought that using boost::bind OR boost:signal is a good idea clearly didn't now what he or she was doing
20150712 21:02:51< Kallikanzarid> whoever first offered to use BOTH should just fuciking die
20150712 21:03:07< Kallikanzarid> I've never seen less maintainable code in my entire life
20150712 21:03:39< shadowm> Could you try to be less rude when criticizing other people's code?
20150712 21:03:57< Kallikanzarid> I know, I"m sorry
20150712 21:04:25< Kallikanzarid> but I'm trying to hunt down mouse state queries and it's pretty much impossible
20150712 21:05:08< Kallikanzarid> mouse events are pumped in at least three separate loops and then passed down this control flow soup
20150712 21:05:19< Kallikanzarid> it's very frustrating
20150712 21:06:55< shadowm> I know, I was trying to figure out an issue with event propagation the other night and had to give up because I couldn't keep track of all the involved type-based parameters.
20150712 21:08:20< Kallikanzarid> if I saw a setjmp in gui 1 I for one would not be surprosed :))
20150712 21:12:47< Kallikanzarid> I don't know how to proceed from here, I'll try hunting a bit more
20150712 21:13:04< Kallikanzarid> but this whole system needs to die and be replaced by something simple
20150712 21:13:22< Kallikanzarid> although it's easier said than done, of course
20150712 21:18:35-!- Kallikanzarid [~textual@46.181.226.42] has quit [Quit: Textual IRC Client: www.textualapp.com]
20150712 21:18:39< pydsigner> I thought work was going on to fix GUI2 to switch everything there?
20150712 21:40:25< irker951> wesnoth: Charles Dang wesnoth:master 459ce3adc29b / data/scenario-test.cfg: test: add include needed as of b30e01422b59700b4292 http://git.io/vmvCk
20150712 21:40:59< shadowm> It's GUI2's innards I for one can't understand.
20150712 21:41:18< vultraz> let's see if that fixes travis
20150712 21:42:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds]
20150712 21:47:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150712 22:03:53-!- travis-ci [~travis-ci@ec2-54-166-15-42.compute-1.amazonaws.com] has joined #wesnoth-dev
20150712 22:03:54< travis-ci> wesnoth/wesnoth#6762 (master - 459ce3a : Charles Dang): The build is still failing.
20150712 22:03:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/70655274
20150712 22:03:54-!- travis-ci [~travis-ci@ec2-54-166-15-42.compute-1.amazonaws.com] has left #wesnoth-dev []
20150712 22:05:06< vultraz> gggrrrrrr
20150712 22:05:09< vultraz> grrrrrrrrr
20150712 22:05:13< vultraz> GGGRRRRRRRRRR
20150712 22:06:06< matthiaskrgr> :s 
20150712 22:06:32< shadowm> gfgtdf: There's a compiler error there.
20150712 22:07:54< shadowm> gfgtdf: `src/hotkey_handler.cpp:436:18: error: '&&' within '||'`
20150712 22:08:19< shadowm> This appears in both the gcc and clang C++11 builds.
20150712 22:15:42-!- mjs-de [~mjs-de@f049240090.adsl.alicedsl.de] has quit [Ping timeout: 248 seconds]
20150712 22:17:37< matthiaskrgr> hmm, are there per-distro build-requirements/-deps listed somewhere? 
20150712 22:18:34< shadowm> matthiaskrgr: /INSTALL has general distribution/OS-neutral information about our build dependencies.
20150712 22:19:20< matthiaskrgr> mh ok 
20150712 22:22:23< irker951> wesnoth: gfgtdf wesnoth:master dbd9436c72d0 / src/hotkey_handler.cpp: Fix wml menu items http://git.io/vmvEJ
20150712 22:23:00-!- gfgtdf [~chatzilla@f054145175.adsl.alicedsl.de] has joined #wesnoth-dev
20150712 22:23:02< gfgtdf> shadowm: ^
20150712 22:29:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150712 22:34:03-!- horrowind [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20150712 22:38:29-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 265 seconds]
20150712 22:41:33-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150712 22:43:44-!- travis-ci [~travis-ci@ec2-54-159-106-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20150712 22:43:45< travis-ci> shikadilord/wesnoth#6 (staging/travis-container-config - 8cbb090 : Ignacio R. Morelle): The build has errored.
20150712 22:43:45< travis-ci> Build details : https://travis-ci.org/shikadilord/wesnoth/builds/70660873
20150712 22:43:45-!- travis-ci [~travis-ci@ec2-54-159-106-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20150712 22:47:24-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Remote host closed the connection]
20150712 22:49:42-!- travis-ci [~travis-ci@ec2-54-159-106-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20150712 22:49:43< travis-ci> shikadilord/wesnoth#7 (staging/travis-container-config - e7b9069 : Ignacio R. Morelle): The build has errored.
20150712 22:49:43< travis-ci> Build details : https://travis-ci.org/shikadilord/wesnoth/builds/70661387
20150712 22:49:43-!- travis-ci [~travis-ci@ec2-54-159-106-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20150712 22:56:45-!- travis-ci [~travis-ci@ec2-54-167-93-1.compute-1.amazonaws.com] has joined #wesnoth-dev
20150712 22:56:46< travis-ci> wesnoth/wesnoth#6763 (master - dbd9436 : gfgtdf): The build is still failing.
20150712 22:56:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/70659445
20150712 22:56:46-!- travis-ci [~travis-ci@ec2-54-167-93-1.compute-1.amazonaws.com] has left #wesnoth-dev []
20150712 23:11:03-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 255 seconds]
20150712 23:20:54-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150712 23:30:40-!- esr [~esr@wesnoth/developer/esr] has quit [Ping timeout: 250 seconds]
20150712 23:33:15-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20150712 23:33:15-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20150712 23:33:15-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20150712 23:36:49-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Ping timeout: 252 seconds]
20150712 23:36:56-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20150712 23:37:13< irker951> wesnoth: gfgtdf wesnoth:master a94228934af6 / src/game_events/ (menu_item.cpp wmi_container.cpp): fix test_wml_menu_items_1 http://git.io/vmvXx
20150712 23:45:32< zookeeper> eh, if a unit tries to advance to an unknown type, the campaign/scenario is just exited with an "Could not find the unit being advanced to" error...
20150712 23:46:14< zookeeper> that's kind of a dorky thing to do, should just advance to itself in that situation instead of throwing the player out of the game
20150712 23:48:10< Ravana_> same happens in multiplayer
20150712 23:48:25< Ravana_> even when valid advancement is there too
20150712 23:50:44< shadowm> -> bugs.wesnoth.org <-
--- Log closed Mon Jul 13 00:00:27 2015