--- Log opened Wed Jul 15 00:00:18 2015
20150715 00:01:43-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has joined #wesnoth-dev
20150715 00:02:08< irker530> wesnoth: Ignacio R. Morelle wesnoth:master cf8fdc33eac5 / players_changelog: Fix the players_changelog http://git.io/vmZxF
20150715 00:02:11< irker530> wesnoth: Ignacio R. Morelle wesnoth:master bffcad8a8731 / RELEASE_NOTES changelog players_changelog: Update changelogs http://git.io/vmZxb
20150715 00:02:31-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150715 00:05:01-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150715 00:06:01-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has quit [Ping timeout: 244 seconds]
20150715 00:12:30-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has joined #wesnoth-dev
20150715 00:17:01-!- kex [~kex@31-151-58-117.dynamic.upc.nl] has quit [Ping timeout: 256 seconds]
20150715 00:19:37 * shadowm headdesks.
20150715 00:19:58< shadowm> I forgot about virtualstore when writing the log file thing.
20150715 00:24:22-!- gfgtdf [~chatzilla@x50abe391.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 39.0/20150630154324]]
20150715 00:31:53-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150715 00:31:57-!- travis-ci [~travis-ci@ec2-54-146-8-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20150715 00:31:58< travis-ci> wesnoth/wesnoth#6776 (master - ec74ea2 : Ignacio R. Morelle): The build passed.
20150715 00:31:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/71001039
20150715 00:31:58-!- travis-ci [~travis-ci@ec2-54-146-8-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20150715 00:32:09< shadowm> How many people will cry if I drop support for Windows XP? :p
20150715 00:33:24< shadowm> I need to call a core function that's not part of Windows before Vista.
20150715 00:34:13< zookeeper> you need to call it to accomplish what?
20150715 00:35:08< shadowm> I'm taking that as tacit confirmation of using an obsolete and insecure operating system.
20150715 00:36:08 * zookeeper doesn't follow
20150715 00:41:02< vultraz> Yes, let us  drop XP
20150715 00:41:48< shadowm> Sucks that Microsoft decided to make it slightly harder to access the virtualstore on 8.1.
20150715 00:41:53< shadowm> And/or 8.
20150715 00:42:35< shadowm> Also, it looks like the virtualstore doesn't cover *all* user-unwriteable paths. :\
20150715 00:42:51< pydsigner> People will cry
20150715 00:42:53< shadowm> So where is my stderr.txt going ?
20150715 00:43:37< shadowm> Hm.
20150715 00:44:05< pydsigner> I don't know that it's a huge percentage of BfW players, but I'd say it's a decent number.
20150715 00:44:18< zookeeper> the button to open stderr? well can't you just not run that code on XP or something?
20150715 00:44:25< shadowm> You know, I *could* have us recreate stderr.txt elsewhere.
20150715 00:44:55< shadowm> It's just not obvious where since for some retarded reason we still allow the userdata-in-install-path configuration.
20150715 00:45:23< vultraz> should re remove that?
20150715 00:45:33< vultraz> we*
20150715 00:45:48< shadowm> If anything needs to be removed it's the installer option.
20150715 00:46:06< vultraz> I mean the installer iption for ud-i-i-p
20150715 00:46:26< vultraz> option
20150715 00:47:09< shadowm> I could do what zookeeper says but it'd require me to fiddle with Windows' library loading API to get the function address at runtime.
20150715 00:47:29< shadowm> I could also remove the button altogether, which would be far easier.
20150715 00:48:09< shadowm> Either way it's not guaranteed that Windows will let me see the real path to a file in the virtualstore and it appears I have no way to test this but to toss Wesnoth into Program Files.
20150715 00:49:50< shadowm> Belh.
20150715 00:50:12< shadowm> Is there some difference between creating a folder in the browser as opposed to having an installer do it?
20150715 00:50:39-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20150715 00:50:59< shadowm> Still can't see the stderr.txt in the virtualstore.
20150715 00:51:56< shadowm> It looks like Windows won't allow Wesnoth to use the virtualstore if I just drop it into Program Files by hand. God dammit.
20150715 00:58:52-!- travis-ci [~travis-ci@ec2-54-146-8-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20150715 00:58:53< travis-ci> wesnoth/wesnoth#6777 (master - bffcad8 : Ignacio R. Morelle): The build passed.
20150715 00:58:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/71001874
20150715 00:58:53-!- travis-ci [~travis-ci@ec2-54-146-8-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20150715 01:06:17-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Read error: Connection reset by peer]
20150715 01:25:01-!- pydsigner_ [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20150715 01:26:37-!- pydsigner_ is now known as pydsigner
20150715 01:26:44< shadowm> Oh!
20150715 01:27:32< shadowm> It's a side-effect of the new manifest.
20150715 01:28:02< shadowm> Well, since there's no way I'll get all these delusional people to get their act together, I guess I'll just have to delete the trust information from the manifest.
20150715 01:30:09< shadowm> Hm, still no virtualstore files.
20150715 01:30:38< shadowm> ¬_¬ It's probably a side-effect of the version compatibility declarations then.
20150715 01:31:11-!- pyndragon [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20150715 01:31:28-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Quit: Leaving]
20150715 01:31:58-!- pyndragon is now known as pydsigner
20150715 01:33:04< shadowm> Okay, no, it's not the manifest.
20150715 01:46:13< shadowm> I think the simplest solution is to:
20150715 01:46:24< shadowm> 1) Remove the userdata-in-install-dir option from the installer.
20150715 01:46:47< shadowm> 2) Have code run as soon as possible in main() to relocate stdout.txt and stderr.txt to the user data dir.
20150715 01:47:45< shadowm> ((2) would have the added bonus of fixing bug #22897.)
20150715 01:49:14< shadowm> We also need to ensure Wesnoth actually has write access to the user data dir and quit if it doesn't before it causes problems with e.g. installing add-ons.
20150715 01:52:43< Ravana_> I really wouldn't like 1), when installing to custom location it makes sense to have userdata in same custom location
20150715 01:53:42< shadowm> Asdf.
20150715 01:54:35< shadowm> You are right, I don't think the installer can check whether you are installing by a non-admin owned directory and tell you off otherwise if you attempt to use the option.
20150715 01:54:50< shadowm> Or can it? ( loonycyborg )
20150715 01:55:42< shadowm> On the other hand, I wouldn't be surprised if the option no longer worked on Windows 10 with admin-owned paths. Has anyone even tested that?
20150715 01:56:57< shadowm> We are relying on a compatibility measure that's not guaranteed to continue to exist for any given version after Vista. It's only by Microsoft's grace that Wesnoth can still run in such a configuration under 8.1.
20150715 01:58:36< shadowm> Additionally, I believe the manifest that allows us to obtain the real version from GetVersionEx will disable file virtualization and break this configuration anyway.
20150715 02:01:03< shadowm> Of course, I could just revert that and the commit from which we start assuming GetVersionEx doesn't lie, but I'd really rather get rid of the need to tell people every time they need help locating stderr.txt to go into %localappdata% and traverse the directory tree from VirtualStore to find a single freaking file.
20150715 02:07:32< shadowm> So I'll just do (2) and let people deal with a broken Wesnoth with the average userdata-in-install-dir case.
20150715 02:08:23< shadowm> And by broken I mean Wesnoth will refuse to run, period.
20150715 02:08:45< shadowm> There's no point in trying to run while getting access denied errors on every function call that touches user data/config files.
20150715 02:09:46< pydsigner> Sounds good to me
20150715 02:10:00< shadowm> Now, do I want to use an inner-main call, or ditch SDLmain.lib and replace it with our own bootstrap code?
20150715 02:11:06< shadowm> The SDLmain code is relatively simple once stripped of the log redirection code and the Windows CE support blocks.
20150715 02:11:25< shadowm> It can be even simpler if redone in C++.
20150715 03:04:14-!- irker530 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150715 03:21:54< shadowm> Hm.
20150715 03:22:09< shadowm> There's a chicken-and-egg situation here.
20150715 03:22:51< shadowm> We don't know where the user config or data dir are at this point because we haven't properly parsed the command line.
20150715 03:24:09< shadowm> OTOH I guess I can just check later whether we allocated a console or not and open the log files based on that.
20150715 03:32:54-!- Greywhind [~Greywhind@c-50-133-231-228.hsd1.ma.comcast.net] has joined #wesnoth-dev
20150715 03:37:04-!- [Relic] [~Relic]@2602:306:33a3:6d30:89a7:ca5d:2624:d4b3] has quit [Quit: I press the magic X and all the weirdos go away!]
20150715 04:04:36-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 264 seconds]
20150715 04:06:14-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150715 04:16:46-!- oldlaptop [~quassel@50-107-124-87.adr02.mskg.mi.frontiernet.net] has quit [Ping timeout: 248 seconds]
20150715 04:25:07-!- oldlaptop [~quassel@50-107-124-87.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150715 04:29:08-!- Appleman1234_ [~Appleman1@KD106175176064.au-net.ne.jp] has joined #wesnoth-dev
20150715 04:32:31-!- Appleman1234 [~Appleman1@KD106152041061.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20150715 04:39:59-!- sachith500 [~kvirc@124.43.183.22] has joined #wesnoth-dev
20150715 05:50:46-!- mjs-de [~mjs-de@f048072082.adsl.alicedsl.de] has joined #wesnoth-dev
20150715 06:03:33-!- oldlaptop [~quassel@50-107-124-87.adr02.mskg.mi.frontiernet.net] has quit [Ping timeout: 246 seconds]
20150715 06:15:48-!- oldlaptop [~quassel@50-107-124-87.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150715 06:31:38-!- Kwandulin [~Miranda@p5B00825D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150715 07:53:24-!- Appleman1234__ [~Appleman1@KD106152032225.au-net.ne.jp] has joined #wesnoth-dev
20150715 07:55:48-!- Appleman1234_ [~Appleman1@KD106175176064.au-net.ne.jp] has quit [Ping timeout: 264 seconds]
20150715 07:56:49-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150715 07:58:54-!- Appleman1234__ [~Appleman1@KD106152032225.au-net.ne.jp] has quit [Ping timeout: 255 seconds]
20150715 08:10:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150715 08:11:22-!- Appleman1234__ [~Appleman1@KD106152032225.au-net.ne.jp] has joined #wesnoth-dev
20150715 08:37:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150715 08:38:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150715 08:42:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150715 09:07:12< loonycyborg> shadowm: doesn't the cwesnoth stuff make stderr.txt less necessary? You can just tell them to use that shortcut
20150715 09:09:51< loonycyborg> NSIS's multi-user.nsh can handle installs with or without admin rights, but userdata-in-install-location thing isn't part of it
20150715 09:11:50< loonycyborg> it exists ONLY because we support inplace installs
20150715 09:16:30< loonycyborg> I'm really in favor of dropping those shortcut shenanigans for userdata dir with always using a standard dir in appdata or something
20150715 09:17:00< loonycyborg> but we'd need to consider inplace installs too
20150715 09:17:17< loonycyborg> and devise some sort of solution for them
20150715 09:20:22-!- Kwandulin [~Miranda@p5B00825D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150715 09:29:24-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 264 seconds]
20150715 09:34:10-!- gfgtdf [~chatzilla@f054168191.adsl.alicedsl.de] has joined #wesnoth-dev
20150715 09:39:43-!- gfgtdf [~chatzilla@f054168191.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 39.0/20150630154324]]
20150715 09:47:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20150715 09:53:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150715 09:54:45-!- sachith500|2 [~kvirc@124.43.183.22] has joined #wesnoth-dev
20150715 09:58:00-!- sachith500 [~kvirc@124.43.183.22] has quit [Ping timeout: 264 seconds]
20150715 10:01:01-!- Kwandulin [~Miranda@p5B00825D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150715 10:02:49< zookeeper> shadowm, well, the good news is that it's very simple to add variations of the waves which are chosen between with a single scenario-level rule.
20150715 10:03:16< zookeeper> what i don't know yet is whether packing such a large number of extra [variant]s makes terrain rebuild noticeably slower
20150715 10:05:12-!- sachith500|2 [~kvirc@124.43.183.22] has quit [Read error: Connection reset by peer]
20150715 10:06:23-!- sachith500|2 [~kvirc@124.43.183.22] has joined #wesnoth-dev
20150715 10:10:34< zookeeper> ...at least not on my system, it seems
20150715 10:13:06-!- sachith500|2 [~kvirc@124.43.183.22] has quit [Read error: Connection reset by peer]
20150715 10:13:31-!- sachith500|2 [~kvirc@124.43.183.22] has joined #wesnoth-dev
20150715 10:20:09< zookeeper> hrhm, looks like [variant]s are chosen per-frame per-hex, not at rebuild time. which makes sense considering ToD.
20150715 10:23:09-!- sachith500|2 [~kvirc@124.43.183.22] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20150715 10:31:19-!- markus_ [~mjs-de@f049105069.adsl.alicedsl.de] has joined #wesnoth-dev
20150715 10:34:54-!- mjs-de [~mjs-de@f048072082.adsl.alicedsl.de] has quit [Ping timeout: 250 seconds]
20150715 10:42:17-!- irker230 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150715 10:42:17< irker230> wesnoth: loonycyborg wesnoth:master 50d248c1dba3 / packaging/windows/wesnoth.rc: Windows: preliminary addition of VERSIONINFO resource http://git.io/vmCVy
20150715 10:43:44< loonycyborg> shadowm: VERSION define in wesconfig.h is no good for VERSIONINFO. 
20150715 10:43:57< loonycyborg> need a way to get actual parts of those numbers
20150715 10:45:17< loonycyborg> like have a #define for VERSION_MAJOR etc and fuse them into VERSION with ## operator
20150715 11:17:27-!- travis-ci [~travis-ci@ec2-54-89-32-207.compute-1.amazonaws.com] has joined #wesnoth-dev
20150715 11:17:28< travis-ci> wesnoth/wesnoth#6778 (master - 50d248c : loonycyborg): The build has errored.
20150715 11:17:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/71055667
20150715 11:17:28-!- travis-ci [~travis-ci@ec2-54-89-32-207.compute-1.amazonaws.com] has left #wesnoth-dev []
20150715 11:18:28-!- rayblade53 [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20150715 11:18:31-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20150715 11:18:46-!- rayblade53 is now known as vultraz
20150715 11:22:11-!- Appleman1234_ [~Appleman1@KD106175181008.au-net.ne.jp] has joined #wesnoth-dev
20150715 11:25:02-!- Appleman1234__ [~Appleman1@KD106152032225.au-net.ne.jp] has quit [Ping timeout: 248 seconds]
20150715 11:31:17-!- Greywhind [~Greywhind@c-50-133-231-228.hsd1.ma.comcast.net] has quit [Ping timeout: 240 seconds]
20150715 11:31:35-!- EliDupree_ [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20150715 11:37:34-!- EliDupree [~quassel@66-189-34-122.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 250 seconds]
20150715 11:46:26-!- gfgtdf [~chatzilla@f054168191.adsl.alicedsl.de] has joined #wesnoth-dev
20150715 11:46:54< gfgtdf> 20150715 00:47:09< shadowm> I could do what zookeeper says but it'd require me to fiddle with Windows' library loading API to get the function address at runtime.20150715 00:47:09< shadowm> I could do what zookeeper says but it'd require me to fiddle with Windows' library loading API to get the function address at runtime.
20150715 11:48:18< gfgtdf> shadowm: there is already some codes in wesnoth where this is done: https://github.com/wesnoth/wesnoth/blob/master/src/filesystem_boost.cpp#L494
20150715 12:14:18-!- gfgtdf [~chatzilla@f054168191.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 39.0/20150630154324]]
20150715 12:48:01< zookeeper> shadowm, actually neutral directionaless waves don't look quite as bad as in some of my earlier tests, so maybe i'll just do that so there's no need for direction variants. could still easily do stormy/calm variants though, if necessary.
20150715 12:53:43-!- Kwandulin [~Miranda@p5B00825D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150715 13:02:09< vultraz> stormy water would be really nice
20150715 13:14:52-!- hay207 [~haythamme@41.34.47.78] has joined #wesnoth-dev
20150715 13:25:02-!- Greywhind [~Greywhind@c-50-133-231-228.hsd1.ma.comcast.net] has joined #wesnoth-dev
20150715 13:27:02< irker230> wesnoth: aquileia wesnoth:master ca8ea2158f9e / projectfiles/VC9/ (wesnoth.vcproj wesnothlib.vcproj): vcproj: Add build_info, desktop/version, dialogs/game_version http://git.io/vmWwf
20150715 13:58:55-!- prkc [~prkc@catv-89-134-159-162.catv.broadband.hu] has joined #wesnoth-dev
20150715 14:10:24-!- travis-ci [~travis-ci@ec2-54-146-8-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20150715 14:10:25< travis-ci> wesnoth/wesnoth#6779 (master - ca8ea21 : aquileia): The build passed.
20150715 14:10:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/71077347
20150715 14:10:25-!- travis-ci [~travis-ci@ec2-54-146-8-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20150715 14:13:59-!- Appleman1234_ [~Appleman1@KD106175181008.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20150715 14:25:21-!- [Relic] [~Relic]@2602:306:33a3:6d30:c5f8:902b:2730:39cd] has joined #wesnoth-dev
20150715 14:25:46-!- Appleman1234_ [~Appleman1@KD106175181008.au-net.ne.jp] has joined #wesnoth-dev
20150715 14:41:46-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150715 14:58:56-!- Kwandulin [~Miranda@p5B00825D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150715 15:13:58-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150715 15:19:52-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150715 15:34:57< irker230> wesnoth: gfgtdf wesnoth:master 6ae5ea220faa / src/ (5 files in 2 dirs): Automatically show mp_connect if needed between scenarios http://git.io/vmlKu
20150715 15:34:59< irker230> wesnoth: gfgtdf wesnoth:master c405766578f0 / src/game_display.hpp: Fix observer list http://git.io/vmlKz
20150715 15:35:01< irker230> wesnoth: gfgtdf wesnoth:master 3781d1358ca7 / src/ (5 files in 2 dirs): remember connected user when entering mp_connect http://git.io/vmlKg
20150715 15:35:08< irker230> wesnoth: gfgtdf wesnoth:master ebbdb086c00a / src/game_events/menu_item.cpp: fix menu items http://git.io/vmlK2
20150715 15:35:24-!- gfgtdf [~chatzilla@f054168191.adsl.alicedsl.de] has joined #wesnoth-dev
20150715 15:35:44< gfgtdf> shadowm: ^ needs a server rebuild
20150715 16:12:02-!- hay207 [~haythamme@41.34.47.78] has quit [Ping timeout: 250 seconds]
20150715 16:25:53-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150715 16:37:07-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150715 16:41:49 * zookeeper wonders if art such as lordbob's full-body versions of portraits should be displayed in credits screens
20150715 16:53:33< vultraz> that would be cool
20150715 16:58:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150715 16:58:44-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Ping timeout: 265 seconds]
20150715 17:04:06-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev
20150715 17:13:34-!- hay207 [~haythamme@41.34.47.78] has joined #wesnoth-dev
20150715 17:13:48-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150715 17:18:13-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150715 17:20:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150715 17:22:27-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Ping timeout: 244 seconds]
20150715 17:24:43-!- hay207 [~haythamme@41.34.47.78] has quit [Ping timeout: 252 seconds]
20150715 17:40:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150715 17:44:17-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150715 17:45:36-!- ancestral [~ancestral@254.sub-70-197-224.myvzw.com] has joined #wesnoth-dev
20150715 17:46:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150715 17:49:11-!- ancestral [~ancestral@254.sub-70-197-224.myvzw.com] has quit [Read error: Connection reset by peer]
20150715 17:49:52< Ravana_> is it intentional that in game rightclick menu items can be used with right click?
20150715 17:53:56< Ravana_> (both custom ones and default)
20150715 18:05:01< pydsigner> zookeeper: Agreed, that would be quite awesome
20150715 18:06:37-!- markus_ [~mjs-de@f049105069.adsl.alicedsl.de] has quit [Ping timeout: 264 seconds]
20150715 18:07:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150715 18:10:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150715 18:12:57-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Ping timeout: 246 seconds]
20150715 18:17:09-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20150715 18:17:43-!- horrowind [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150715 18:23:08< Ravana_> Is capture event supposed to fire with $owner_side and $side_number as same number?
20150715 18:24:43< Ravana_> also, it is fired when using undo to move away from village, not when moving to village
20150715 18:24:59< Ravana_> should I report this as bug
20150715 18:27:31< gfgtdf> Ravana_	is it intentional that in game rightclick menu items can be used with right click?
20150715 18:27:37< gfgtdf> sry i dont understadn that question
20150715 18:29:20< Ravana_> gfgtdf you open rightclick menu with right click, and when you use right click on items there then it work, unlike most places where you need to left click item in rightclick menu
20150715 18:32:03< gfgtdf> Ravana_: hm ok idk whether thats intentional
20150715 18:35:24-!- irker230 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150715 18:40:40< zookeeper> Ravana_, i don't recall about the variables, but uh, yes they certainly _should_ fire when capturing a village
20150715 18:41:28< Ravana_> it fires during undo move
20150715 18:41:42< Ravana_> not when capturing it first
20150715 18:44:25< Ravana_> the event being http://pastebin.com/qfabAUZa
20150715 18:44:52< Ravana_> when capturing enemy village it doesn't fire, as it is not allied
20150715 18:45:07< Ravana_> but when undoing move it does fire, as side is allied with itself
20150715 18:46:18< zookeeper> i'd defer to whatever behavior 1.12 has
20150715 18:46:31< Ravana_> both 1.12.4 and 1.13.1 do this
20150715 18:46:34< zookeeper> raelly?
20150715 18:46:51-!- kex [~kex@212.158.180.7] has joined #wesnoth-dev
20150715 18:46:52< Ravana_> yes, I am writing bug report currently so I checked
20150715 18:46:56< zookeeper> well then it has to do with your filtering somehow, because if capture events were generally broken, we'd know
20150715 18:47:48< zookeeper> i'm not saying it's not a bug, but the bug has to be something more specific than "capture events don't fire when capturing a village"
20150715 18:48:06< Ravana_> no
20150715 18:48:10< Ravana_> thats not the point of bug
20150715 18:48:24< Ravana_> bug is that capture event fires when using undo
20150715 18:49:28< zookeeper> oh, so it does fire correctly when capturing?
20150715 18:49:30< zookeeper> okay
20150715 18:49:48< Ravana_> yes, then it doesn't fire as filter prevents it, so that is good
20150715 18:50:40< Ravana_> for my use [filter_condition] side_number not_equals $owner_side is suitable workaround
20150715 18:50:55< zookeeper> well, if the event fires when undoing, then i presume that that's by design, so that if you have a bookkeeping capture event, it works correctly even if undo is involved
20150715 18:51:35< zookeeper> i'm not saying there can't be a bug with that, but i don't currently have the brainpower to properly process your example
20150715 18:51:41< Ravana_> wiki has " merely moving into your own villages does not constitute a capture"
20150715 18:51:57< Ravana_> I would think that owner_side and side_number being equal would be case of this
20150715 18:53:14< zookeeper> IIRC owner_side is the side _after_ the capture, but not sure
20150715 18:53:29< Ravana_> " The variable $owner_side contains the previous owner side of the village"
20150715 18:53:33< zookeeper> oh, good
20150715 18:54:44< zookeeper> so, if capturing a village side_number is 1 and owner_side is 2, what are they when undoing that move?
20150715 18:55:01< Ravana_> 1 and 1
20150715 18:55:18< zookeeper> i see
20150715 18:55:37< zookeeper> well, there's a certainly _a_ logic to that
20150715 18:56:01< zookeeper> side_number has to be 1
20150715 18:56:40< Ravana_> not sure it is actual bug.. but it should be documented in some way
20150715 18:56:41< zookeeper> neither 1 or 2 makes perfect sense for owner_side
20150715 18:56:45< zookeeper> sure, agreed
20150715 18:57:36< Ravana_> I suspect the reason that allows this behaviour is [capture_village] in capture event
20150715 18:58:12< Ravana_> eh no
20150715 18:58:19< zookeeper> i'd say 1 makes more sense than 2 because at least it technically makes sense; side 2 is getting the village back from side 1, even if chronologically it's a bit wrong :>
20150715 18:58:23< Ravana_> that part is only what causes the oos
20150715 18:58:48< zookeeper> but yes that's a very unintuitive thing and should definitely be documented
20150715 19:07:52< Ravana_> I wonder if other events also fire again when undoing actions that would cause them, but whose event was not filtered for original action so undo is possible.. will test
20150715 19:25:18< gfgtdf> currently no event should fire on undoing. If they do then i think it's a bug
20150715 19:36:15-!- kex [~kex@212.158.180.7] has quit [Ping timeout: 246 seconds]
20150715 19:39:05-!- Kwandulin [~Miranda@p5B00825D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150715 19:58:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150715 20:01:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150715 20:13:36< Ravana_> reported #23695
20150715 20:29:15< shadowm> gfgtdf: I am aware, I have done it before.
20150715 20:30:36< shadowm> 06:07:12 <loonycyborg> shadowm: doesn't the cwesnoth stuff make stderr.txt less necessary? You can just tell them to use that shortcut
20150715 20:31:29< shadowm> loonycyborg: No, because Windows' console support is extremely clunky and copying parts of the output is not as simple as it should be. There's also a line limit.
20150715 20:31:46-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150715 20:31:50< shadowm> It's something like 500 lines by default, definitely not good for --log-debug=all.
20150715 20:34:47-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 240 seconds]
20150715 20:35:06-!- horrowind [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20150715 20:38:02< gfgtdf> Ravana_: ok
20150715 20:38:26< gfgtdf> shadowm: you saw my message ybout server rebuild ?
20150715 20:38:51< shadowm> Yes, I just restarted the trunk server.
20150715 20:39:01< gfgtdf> shadowm:ok
20150715 20:43:06-!- kex [~kex@212.158.180.7] has joined #wesnoth-dev
20150715 20:44:38-!- kex [~kex@212.158.180.7] has quit [Client Quit]
20150715 20:46:15-!- kex [~kex@212.158.180.7] has joined #wesnoth-dev
20150715 21:08:35-!- markus_ [~mjs-de@f049105069.adsl.alicedsl.de] has joined #wesnoth-dev
20150715 21:13:23-!- kex [~kex@212.158.180.7] has quit [Read error: Connection reset by peer]
20150715 21:14:51-!- markus_ is now known as mjs-de
20150715 21:15:21-!- kex [~kex@212.158.180.7] has joined #wesnoth-dev
20150715 21:41:47-!- kex [~kex@212.158.180.7] has quit [Read error: Connection reset by peer]
20150715 21:42:18-!- kex [~kex@212.158.180.7] has joined #wesnoth-dev
20150715 21:53:10-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150715 21:57:20< gfgtdf> when compining wesnoth i now get a warnng: >C:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\include\string.h(54): warning RC4011: identifier truncated to '_CRT_SECURE_CPP_OVERLOAD_STANDA'
20150715 22:00:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150715 22:01:34-!- mjs-de [~mjs-de@f049105069.adsl.alicedsl.de] has quit [Ping timeout: 246 seconds]
20150715 22:04:43< shadowm> RCxxxx sounds like it's a Resource Compiler warning as opposed to the MSVC++ compiler.
20150715 22:05:41< shadowm> Can't you tell at which step this happens?
20150715 22:06:48< gfgtdf> shadowm: no i cant, all i currently know is that the warning is printed at the end of teh log so its not associated to a specific compilation unit.
20150715 22:07:21< shadowm> It is the Resource Compiler.
20150715 22:08:29< gfgtdf> shadowm: hm so you think it is nothing new and its just appears becasue the resource didnt had to be recompiled in the last year?
20150715 22:08:58< shadowm> It is new and I know the reason since 15 seconds ago.
20150715 22:09:58< gfgtdf> shadowm: this is how the 'about' dialog looks for me: http://i.imgur.com/FR8gYvN.png The scrollbar at the bottom looks bad, also there is an strange row at the bottom without content.
20150715 22:10:09< gfgtdf> shadowm: you think teh warnign can be fixed ?
20150715 22:12:01-!- irker408 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150715 22:12:01< irker408> wesnoth: Ignacio R. Morelle wesnoth:master 055ce30ac8e1 / packaging/windows/wesnoth.rc: Include windows.h instead of winuser.h directly http://git.io/vmBz8
20150715 22:12:01< shadowm> Yes, test this. v
20150715 22:12:04< shadowm> ^
20150715 22:17:23< gfgtdf> shadowm: ok wait
20150715 22:17:33< gfgtdf> shadowm: somehow i curently have a compilation ewrror
20150715 22:17:47< gfgtdf> shadowm: mostlikeley ia hav eaccidently rmove  afile form my projectfiles
20150715 22:18:17< irker408> wesnoth: Ignacio R. Morelle wesnoth:master ff7e909c8bd3 / src/gui/dialogs/game_version.cpp: gui2/tgame_version: Omit entries for missing library dependencies http://git.io/vmB24
20150715 22:18:25< shadowm> This fixes the empty row.
20150715 22:19:09< shadowm> I won't have a fix for the layout issue with long strings this week, though. (Also, I'm curious exactly where you are getting that translation for 'Paths' from. Spanish on 1.12 is at 100% and it doesn't have that string.)
20150715 22:20:20< shadowm> The hell.
20150715 22:20:29< shadowm> There is a horizontal listbox?
20150715 22:24:33-!- Appleman1234 [~Appleman1@KD106175183004.au-net.ne.jp] has joined #wesnoth-dev
20150715 22:25:38< gfgtdf> shadowm: looks like there is one, although i have never tested it
20150715 22:26:53< gfgtdf> shadowm: im getting strange compilation erros about missing version_info:: functions by the linker but i have version.cpp included in my projectfiles
20150715 22:27:26-!- Appleman1234_ [~Appleman1@KD106175181008.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20150715 22:28:43< shadowm> I can't really help you with that.
20150715 22:29:24< shadowm> Just note that there's a src/desktop/version.cpp and a src/version.cpp now.
20150715 22:30:16< shadowm> (And no, I'm not going to change that. No-one's had a problem with the identically-named files in different subdirs of src/gui/ in all these years.)
20150715 22:30:59< gfgtdf> shadowm: also i wouldnt bet on horizontal_listox beeing buigfree, afaik horizontal_listbox uses the same listbox class as the normal listbox which seems to handle x and y differntly in code cases like https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/listbox.cpp#L335
20150715 22:31:30< gfgtdf> shadowm: yes teh same names is most likeley the problem, but i can fi that in my projectfiles
20150715 22:32:33< shadowm> The horizontal listbox works, actually.
20150715 22:32:50-!- ancestral [~ancestral@209.181.254.222] has joined #wesnoth-dev
20150715 22:33:35< shadowm> Far better than expected. The only problem is that the horizontal scrollbar isn't adequate for implementing a tab bar.
20150715 22:36:11< gfgtdf> shadowm: cant you fix this by using a custom toggelpanel definition for the entries ?
20150715 22:36:36< shadowm> That's not going to magically force them to shrink if the run out of space.
20150715 22:37:20< shadowm> In fact, I don't think there's a single widget in existence that's ever willing to shrink below its minimum size.
20150715 22:38:37-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150715 22:38:40< shadowm> So yeah, I'll look at this and vultraz's campaign dialog issue next week.
20150715 22:42:10< gfgtdf> shadowm: ok seems liek teh resource compiler warning is fixed
20150715 22:51:36-!- ancestral [~ancestral@209.181.254.222] has quit [Quit: i go nstuf kthxbai]
20150715 23:07:06-!- gfgtdf [~chatzilla@f054168191.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 39.0/20150630154324]]
20150715 23:14:16-!- kex [~kex@212.158.180.7] has quit [Read error: Connection reset by peer]
20150715 23:54:24< zookeeper> shadowm, if i make the waves splash around in no particular direction, do you still think they need a somewhat calmer variation for caves and such?
20150715 23:54:35< zookeeper> well, maybe hard to say without seeing, but...
20150715 23:56:01< shadowm> Depends. I wouldn't be opposed to having additional water variations.
20150715 23:57:06< zookeeper> okay
20150715 23:57:27< zookeeper> 3 would be the absolute maximum IMO; calm/normal/stormy
20150715 23:57:31< zookeeper> but maybe just 2 could do
--- Log closed Thu Jul 16 00:00:31 2015