--- Log opened Sat Aug 08 00:00:34 2015
20150808 00:08:14< celticminstrel> Unsurprisingly, it failed. I need to add a new source file somewhere. CMakeLists?
20150808 00:08:38< celticminstrel> SConstruct?
20150808 00:08:46< celticminstrel> Looks like the latter...
20150808 00:09:34< celticminstrel> But, might as well do both, I guess.
20150808 00:10:19< celticminstrel> Oh, I don't see a list of sources in CMakeList, so just the other one, then.
20150808 00:10:50< celticminstrel> ...I have no idea what I'm doing. >_>
20150808 00:14:21-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150808 00:19:46< celticminstrel> Maybe someone else will fix it for me.
20150808 00:40:48-!- N4tr0n__ [~N4tr0n@cpe-76-175-70-130.socal.res.rr.com] has quit [Remote host closed the connection]
20150808 00:41:16-!- N4tr0n_ [~N4tr0n@cpe-76-175-70-130.socal.res.rr.com] has joined #wesnoth-dev
20150808 00:45:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150808 00:46:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20150808 01:11:53-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150808 01:12:34< mattsc> celticminstrel: neither do I, and yet they let me package the OS X builds for some reason  :P
20150808 01:15:18< mattsc> I’ve been trying hard to convince people of my incompetence, but to no avail.
20150808 01:16:30< mattsc> Fred’s beating the default AI again though, so I’m happy.  \o/
20150808 01:19:09< celticminstrel> I figured it out with a bit of help from aquileia.
20150808 01:39:54-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150808 01:46:13-!- scorpion [~scorpion@46.166.190.189] has quit [Ping timeout: 252 seconds]
20150808 01:53:53< shadowm> src/tests/gui/test_gui2.cpp(470): error in "test_gui2": check list.size() == 0 failed [1 != 0]
20150808 01:53:53-!- irker501 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150808 01:53:53< irker501> wesnoth: aquileia wesnoth:master 01dfc6783f22 / packaging/windows/Wesnoth.nsi.in: Windows installer: Remove components page http://git.io/vOjpI
20150808 01:53:53< irker501> wesnoth: aquileia wesnoth:master 46af40eb6186 / packaging/windows/ (14 files): Windows Installer: Add GPL translations http://git.io/vOjpL
20150808 01:53:54< irker501> wesnoth: aquileia wesnoth:master 12066d87c5ea / packaging/windows/ (Wesnoth.nsi.in translations.nsh): Windows Installer: Translate 'Battle for Wesnoth' and shortcuts http://git.io/vOjpt
20150808 01:53:55< irker501> wesnoth: aquileia wesnoth:master 1c3fa278ffd0 / packaging/windows/Wesnoth.nsi.in: Windows installer: Cut down on shortcuts http://git.io/vOjpq
20150808 01:53:56< irker501> wesnoth: aquileia wesnoth:master 4a272b301d83 / SConstruct packaging/windows/Wesnoth.nsi.in: Windows installer: Use FILE /oname to avoid copying files http://git.io/vOjpm
20150808 01:53:57< irker501> wesnoth: aquileia wesnoth:master c7ffe8dfd7d1 / packaging/windows/Wesnoth.nsi.in: Windows installer: Update to NSIS 3 http://git.io/vOjpY
20150808 01:53:59< irker501> wesnoth: aquileia wesnoth:master d8b5e7b3c193 / packaging/windows/Wesnoth.nsi.in: Windows installer: Remove userdata dir selection http://git.io/vOjpO
20150808 01:54:04< shadowm> celticminstrel: This is why. You need to add your dialog to that file.
20150808 01:54:30< shadowm> > Window 'label_settings' registered but not tested.
20150808 01:54:48< celticminstrel> Oh.
20150808 01:56:50< celticminstrel> I could squish those last three commits together, if that's preferred... though that means Travis will initiate another build.
20150808 01:58:19< shadowm> Yeah, squash those three. travis can deal with it given enough time and occasionally some manual prodding.
20150808 02:02:46-!- afre [63f401a5@gateway/web/freenode/ip.99.244.1.165] has joined #wesnoth-dev
20150808 02:06:07< celticminstrel> There, and even updated the CodeBlocks and VC9 projects while I was at it.
20150808 02:06:57< celticminstrel> (And CodeLite. I wonder if anyone uses that one.)
20150808 02:16:01< shadowm> Is there a particular reason your Git email address is invalid?
20150808 02:16:33< celticminstrel> I don't feel like putting it in a public place.
20150808 02:17:01< celticminstrel> It's syntactically correct, at least.
20150808 02:18:35< shadowm> In that case I presume you specifically opted to use a pseudonym in the real name field too.
20150808 02:18:47< celticminstrel> Yes...
20150808 02:18:59< shadowm> Okay, fine.
20150808 02:19:00< celticminstrel> I think? Which real name field are we talking about?
20150808 02:19:11< shadowm> https://github.com/CelticMinstrel/wesnoth/commit/af6d3060e246a59c24c78502069109ceac44cc44.patch
20150808 02:19:35< shadowm> Every Git commit has an author name and email attached to it (both are also part of the hash source).
20150808 02:20:16< celticminstrel> That would be intentional, yes.
20150808 02:20:21< shadowm> We don't have a policy for this stuff mainly because the previous RM was too lazy to have any policies at all.
20150808 02:20:29< celticminstrel> Heh.
20150808 02:21:37< irker501> wesnoth: aquileia wesnoth:1.12 8bbeea846cea / packaging/windows/Wesnoth.nsi.in: Windows installer: Remove components page http://git.io/v3efs
20150808 02:21:39< irker501> wesnoth: aquileia wesnoth:1.12 ef9ac0968e89 / packaging/windows/ (14 files): Windows Installer: Add GPL translations http://git.io/v3efG
20150808 02:21:41< irker501> wesnoth: aquileia wesnoth:1.12 5732c0408416 / packaging/windows/ (Wesnoth.nsi.in translations.nsh): Windows Installer: Translate 'Battle for Wesnoth' and shortcuts http://git.io/v3efZ
20150808 02:21:43< irker501> wesnoth: aquileia wesnoth:1.12 dbe397cf202b / SConstruct packaging/windows/Wesnoth.nsi.in: Windows installer: Use FILE /oname to avoid copying files http://git.io/v3efn
20150808 02:21:45< irker501> wesnoth: aquileia wesnoth:1.12 759411a129f2 / packaging/windows/Wesnoth.nsi.in: Windows installer: Update to NSIS 3 http://git.io/v3efc
20150808 02:24:22< irker501> wesnoth: aquileia wesnoth:master 79b7bf1777b8 / packaging/windows/ (wesnoth-icon.ico wesnoth_editor-icon.ico): Windows Installer: Update icons http://git.io/v3efr
20150808 02:48:33< shadowm> celticminstrel: You added yourself to the wrong section.
20150808 02:49:02< shadowm> "New contributors (i.e., those without commit access) should add themselves to the Miscellaneous Contributors section of the credits file" <-- as opposed to Programming at the top.
20150808 02:49:09< celticminstrel> Oh, whoops.
20150808 02:49:23< celticminstrel> You want me to fix it?
20150808 02:49:34< shadowm> Yes.
20150808 02:51:07< celticminstrel> Fixed.
20150808 02:55:09-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150808 02:56:22-!- afre [63f401a5@gateway/web/freenode/ip.99.244.1.165] has quit [Quit: Page closed]
20150808 02:56:52 * shadowm squints at editor_edit_labe.?pp.
20150808 02:57:39< celticminstrel> Something wrong?
20150808 02:57:53< shadowm> Before I forget, for future reference: 1) protected and private variable members of struct and class types should be suffixed with an underscore (making an exception here since whoever wrote this file clearly didn't know this); 2) self-explanatory variable names are better than short names, especially if the short name isn't a standard abbreviation ("labels" instead of "lbls").
20150808 02:58:12< celticminstrel> Okay.
20150808 02:58:34< celticminstrel> I think I did add the underscore suffix in places where it was already clearly present.
20150808 02:58:44< celticminstrel> But might've missed it in other places.
20150808 02:58:46< shadowm> 3) Use braces with if/else blocks (see also that bug that was quite popular with OS X people some time ago).
20150808 02:59:20< celticminstrel> I usually have a tendency to omit braces whenever possible, but I actually tried to avoid it here.
20150808 02:59:31< shadowm> 4) Use const to declare your intentions. (e.g. here: https://github.com/wesnoth/wesnoth/pull/447/files#diff-45ee27448f54d57f550c5de90c288c88R605 )
20150808 03:00:04< celticminstrel> You mean declaring the locals const?
20150808 03:00:19< shadowm> Yes.
20150808 03:00:26< celticminstrel> Weird, but I guess I can manage it.
20150808 03:00:40< shadowm> Just a note for the future, you don't need to correct it right now.
20150808 03:00:44< celticminstrel> Okay.
20150808 03:01:58< shadowm> Is there a particular reason you are using pointers to data members in editor_edit_label.?pp instead of references ot plain pointers? I'm curious.
20150808 03:02:02< shadowm> *or
20150808 03:03:33< celticminstrel> Do you mean the pointer-to-members?
20150808 03:03:45< shadowm> Yes, of course.
20150808 03:05:46< celticminstrel> Well, the alternatives would've been either 1) to have separate load and save callbacks for each colour component or 2) to copy the colour components to temporary int variables and then copy them back afterwards. This method seemed better to me since the components get updated in-place, just like all the other label properties (visible_fog etc).
20150808 03:06:10< celticminstrel> (Option 2 would mean I could use the 3-arg register_integer.)
20150808 03:06:57< shadowm> boost::ref doesn't cut it for the bind function objects?
20150808 03:07:34< celticminstrel> I'm not sure if it would. The issue is that SDL_Color components are Uint8, but the 3-arg register_integer takes only int&.
20150808 03:07:55< celticminstrel> I don't think boost::ref would help there.
20150808 03:08:24< shadowm> You can have a Uint8 reference in the parameter lists for load_color_component and save_color_component.
20150808 03:08:47< celticminstrel> Ah, you have a point there.
20150808 03:08:52< celticminstrel> I guess I just didn't think of that.
20150808 03:08:54< celticminstrel> <_<
20150808 03:09:13< shadowm> The reason I'm asking is basically that it's been 8 years and I'd never stumbled the unwieldy pointer-to-member syntax before, so I almost forgot it existed.
20150808 03:09:26< shadowm> *upon the
20150808 03:12:22-!- Flexfit [~Flexfit@cpe-172-74-101-237.nc.res.rr.com] has quit [Read error: Connection reset by peer]
20150808 03:13:23-!- Flexfit [~Flexfit@cpe-172-74-101-237.nc.res.rr.com] has joined #wesnoth-dev
20150808 03:14:58-!- StandYourGround [~Adium@2602:306:83db:de50:889:f8ff:b5ad:d4c8] has joined #wesnoth-dev
20150808 03:30:47-!- StandYourGround [~Adium@2602:306:83db:de50:889:f8ff:b5ad:d4c8] has left #wesnoth-dev []
20150808 04:00:36-!- Appleman1234 [~Appleman1@KD036009073125.au-net.ne.jp] has quit [Remote host closed the connection]
20150808 04:02:03-!- Appleman1234 [~Appleman1@KD036009073125.au-net.ne.jp] has joined #wesnoth-dev
20150808 04:02:24-!- UnwiseOwl [~Ted@124-169-219-239.dyn.iinet.net.au] has joined #wesnoth-dev
20150808 04:07:39-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection timed out]
20150808 04:09:17-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150808 04:14:59< shadowm> celticminstrel: Okay, looks mergeable to me after some quick testing. Will you change those methods to use references or leave it as is?
20150808 04:15:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150808 04:17:42< shadowm> By which I mean I just did the quick testing in question.
20150808 04:25:43< celticminstrel> I'll change them if you insist.
20150808 04:25:59< celticminstrel> It doesn't seem like it matters that much to me. I suppose references are slightly better.
20150808 04:27:00< shadowm> I can merge it as is then.
20150808 04:28:55-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150808 04:29:18< irker501> wesnoth: Celtic Minstrel wesnoth:master af6d3060e246 / / (18 files in 11 dirs): Add new "category" and "creator" properties to map labels http://git.io/v3eZ3
20150808 04:29:20< irker501> wesnoth: Celtic Minstrel wesnoth:master 1c578590e1e4 / / (4 files in 3 dirs): Add sliders to set colour of label in map editor http://git.io/v3eZs
20150808 04:29:22< irker501> wesnoth: Celtic Minstrel wesnoth:master 819eab2f96f2 / / (23 files in 6 dirs): Add dialog to allow user to customize which label groups are displayed http://git.io/v3eZG
20150808 04:29:24< irker501> wesnoth: Celtic Minstrel wesnoth:master e2a0648a159f / src/gui/dialogs/label_settings.cpp: Use team colors for player label categories http://git.io/v3eZZ
20150808 04:29:26< irker501> wesnoth: Celtic Minstrel wesnoth:master af3eae9d0b51 / src/generators/default_map_generator.cpp: Assign a label category to village names http://git.io/v3eZn
20150808 04:29:28< irker501> wesnoth: Celtic Minstrel wesnoth:master d657c30a5038 / src/game_state.cpp: Labels from players in your ignore list default to hidden http://git.io/v3eZc
20150808 04:29:30< irker501> wesnoth: Celtic Minstrel wesnoth:master e130a960cbe1 / changelog data/core/about.cfg players_changelog: Update credits and changelog http://git.io/v3eZC
20150808 04:29:32< irker501> wesnoth: Celtic Minstrel wesnoth:master f619b4cc6393 / / (6 files in 5 dirs): Update build stuff http://git.io/v3eZW
20150808 04:29:34< irker501> wesnoth: Ignacio R. Morelle wesnoth:master 74a81069b993 / / (48 files in 22 dirs): Merge pull request #447 from CelticMinstrel/master http://git.io/v3eZl
20150808 04:30:22< shadowm> celticminstrel: Thanks!
20150808 04:30:29< celticminstrel> :D
20150808 04:31:52-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20150808 04:55:20-!- oldlaptop [~quassel@50-107-125-36.adr02.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20150808 04:55:56-!- oldlaptop [~quassel@50-107-125-36.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150808 05:00:46-!- genbattle [~genbattle@115-188-147-250.jetstream.xtra.co.nz] has joined #wesnoth-dev
20150808 05:02:56-!- oldlaptop [~quassel@50-107-125-36.adr02.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20150808 05:06:02-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 244 seconds]
20150808 05:07:37-!- oldlaptop [~quassel@50-107-125-36.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150808 05:17:18< UnwiseOwl> Can anyone name a scenario that uses persistent enemies at all? Just want to check that I'm doing this a sensible way.
20150808 05:20:25-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has quit [Ping timeout: 245 seconds]
20150808 05:21:05-!- sailorswift [~sailorswi@185.94.31.100] has joined #wesnoth-dev
20150808 05:25:24< celticminstrel> Persistent enemies?
20150808 05:25:35-!- Kwandulin [~Miranda@p5B008A93.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150808 05:26:36< celticminstrel> UnwiseOwl?
20150808 05:26:59< UnwiseOwl> Ah, sorry. Yes, enemies using the persistent side function.
20150808 05:27:40-!- sailorsw_ [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150808 05:28:09< celticminstrel> It sounds like something some of my scenarios could possibly use, but if it's new in 1.11 or later they wouldn't...
20150808 05:28:16< UnwiseOwl> I would like to have an enemy and his units return from a previous scenario, and there appears to be a tag for it, I just wondered if anyone ever used it.
20150808 05:28:42< celticminstrel> I've had enemies return from previous scenarios.
20150808 05:28:46-!- sailorswift [~sailorswi@185.94.31.100] has quit [Ping timeout: 244 seconds]
20150808 05:28:54< celticminstrel> I don't remember any special tag though.
20150808 05:29:16< UnwiseOwl> Hrmm...ok. I can look anyway, at least it will be doable :)
20150808 05:29:25< UnwiseOwl> What campaign/scenario?
20150808 05:32:16< celticminstrel> DruidSiege / Besieged Druids; orc leader in scenario 4 appears later in scenario 6; also the undead leader in 4 appears in 7 and sometimes 9. I think I did it by storing sides or something, though. They have access to recall lists when they return.
20150808 05:32:28< celticminstrel> Maybe I didn't store sides.
20150808 05:32:49< celticminstrel> Maybe I just let the default recall list behaviour happen.
20150808 05:32:58< celticminstrel> Oh, the macros...
20150808 05:33:25< vultraz> celticminstrel: you mean 1.13 or later?
20150808 05:33:29< celticminstrel> Well, I don't see anything that looks like persistent.
20150808 05:33:51< celticminstrel> vultraz: No, 1.11 or later, because it was made for 1.10. It's on the 1.12 server now, but that doesn't mean it has been updated for new 1.12 stuff in all ways.
20150808 05:38:05-!- sailorsw_ [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150808 05:38:23< vultraz> Weelll... you could use [side] persistent = yes and save_id=something
20150808 05:38:30< vultraz> but I'm not sure if that;s what you want
20150808 05:38:42< celticminstrel> That's what he was asking about, I believe.
20150808 05:38:56< celticminstrel> It looks like I didn't use that, was it new in 1.11 or later?
20150808 05:39:21< vultraz> No
20150808 05:39:33< celticminstrel> Then, I probably had some reason to not use it.
20150808 05:39:37< vultraz> Not that I'm aware
20150808 05:46:07< celticminstrel> But I can't think of a reason, so maybe I didn't use it solely because it worked without it.
20150808 05:49:16-!- travis-ci [~travis-ci@ec2-107-20-66-70.compute-1.amazonaws.com] has joined #wesnoth-dev
20150808 05:49:17< travis-ci> wesnoth/wesnoth#6999 (master - 74a8106 : Ignacio R. Morelle): The build was broken.
20150808 05:49:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/74666618
20150808 05:49:17-!- travis-ci [~travis-ci@ec2-107-20-66-70.compute-1.amazonaws.com] has left #wesnoth-dev []
20150808 05:52:17-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20150808 05:53:57< shadowm> I should've checked that part of the diff/waited for travis to finish.
20150808 06:02:09-!- not-inept [~not-inept@2604:a880:800:10::7f6:1] has quit [Ping timeout: 252 seconds]
20150808 06:02:30-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20150808 06:04:34< UnwiseOwl> Ah, thanks, celticminstrel, I'll take a look.
20150808 06:04:46-!- genbattle [~genbattle@115-188-147-250.jetstream.xtra.co.nz] has quit [Ping timeout: 260 seconds]
20150808 06:08:29-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150808 06:09:47< irker501> wesnoth: Ignacio R. Morelle wesnoth:master 32342a5fc44a / src/tests/gui/test_gui2.cpp: gui2/tlabel_settings: Exclude from GUI2 unit test http://git.io/v3eu0
20150808 06:13:46< shadowm> celticminstrel: ^
20150808 06:16:28-!- not-inept [~not-inept@104.236.89.39] has joined #wesnoth-dev
20150808 06:24:50-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20150808 06:27:48-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 272 seconds]
20150808 06:55:29-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150808 06:56:07-!- travis-ci [~travis-ci@ec2-107-20-66-70.compute-1.amazonaws.com] has joined #wesnoth-dev
20150808 06:56:08< travis-ci> wesnoth/wesnoth#7000 (master - 32342a5 : Ignacio R. Morelle): The build was fixed.
20150808 06:56:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/74671309
20150808 06:56:08-!- travis-ci [~travis-ci@ec2-107-20-66-70.compute-1.amazonaws.com] has left #wesnoth-dev []
20150808 07:01:11-!- horrowin1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150808 07:04:49-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20150808 07:05:21-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20150808 07:21:02-!- [Relic] [~Relic]@2602:306:33a3:6d30:e8a1:145e:a6fb:61c2] has quit [Quit: I press the magic X and all the weirdos go away!]
20150808 07:23:21-!- UnwiseOwl [~Ted@124-169-219-239.dyn.iinet.net.au] has quit [Ping timeout: 265 seconds]
20150808 07:44:33-!- Kwandulin [~Miranda@p5B008A93.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150808 07:49:01-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Ping timeout: 246 seconds]
20150808 07:52:07-!- Smar [smar@freenet/translator/finnish/Smar] has quit [Quit: tyhmät serverit]
20150808 08:13:59-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20150808 08:18:13-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150808 08:20:30-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Ping timeout: 255 seconds]
20150808 08:21:41-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer]
20150808 08:22:16-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150808 08:29:14-!- Kwandulin [~Miranda@p5B008A93.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150808 08:35:18-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150808 08:41:17-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20150808 09:10:02-!- irker501 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150808 09:12:08-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20150808 09:16:39-!- Kwandulin [~Miranda@p5B008A93.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20150808 09:33:46-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20150808 09:46:29-!- Kwandulin [~Miranda@p5B00804C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150808 10:15:05-!- gandaro [~gandaro@wikipedia/Gorlingor] has joined #wesnoth-dev
20150808 10:58:41-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Quit: Bye]
20150808 10:58:56-!- heirecka [~heirecka@j61898.servers.jiffybox.net] has joined #wesnoth-dev
20150808 10:58:56-!- heirecka [~heirecka@j61898.servers.jiffybox.net] has quit [Changing host]
20150808 10:58:56-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20150808 11:32:14-!- prkc [~prkc@catv-89-134-159-162.catv.broadband.hu] has quit [Remote host closed the connection]
20150808 11:36:58-!- prkc [~prkc@catv-89-134-159-162.catv.broadband.hu] has joined #wesnoth-dev
20150808 11:43:46-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150808 11:44:13-!- Kwandulin [~Miranda@p5B00804C.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150808 12:12:51-!- gandaro [~gandaro@wikipedia/Gorlingor] has quit [Quit: Leaving]
20150808 12:28:28-!- genbattle [~genbattle@115-188-147-250.jetstream.xtra.co.nz] has joined #wesnoth-dev
20150808 12:36:34-!- genbattle [~genbattle@115-188-147-250.jetstream.xtra.co.nz] has quit [Ping timeout: 244 seconds]
20150808 13:39:56-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150808 13:50:25-!- Kwandulin [~Miranda@p5B00804C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150808 14:12:24-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 255 seconds]
20150808 14:19:43-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20150808 14:22:28-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150808 14:25:42-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150808 14:32:28-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 246 seconds]
20150808 14:33:51-!- irker716 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150808 14:33:51< irker716> wesnoth: gfgtdf wesnoth:master de1eaa30f76f / / (3 files in 2 dirs): Use listboxs sorting feature in experinemtal gui2 addon_list http://git.io/v3f3G
20150808 14:43:06-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20150808 14:44:15-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20150808 14:44:53-!- [Relic] [~Relic]@2602:306:33a3:6d30:2033:7dc1:115b:dece] has joined #wesnoth-dev
20150808 14:57:06-!- horrowin1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has quit [Quit: horrowin1]
20150808 15:02:43-!- Xara [Yangyf@2001:cc0:2020:4010:944a:1fa7:30e4:54dc] has quit [Read error: Connection reset by peer]
20150808 15:10:47< wedge009> Going through the bug reports - a lot of the old ones seem to be fixed and could probably be closed. I gather one needs to have sufficient privileges in order to do things like close reports, is that right?
20150808 15:18:49< zookeeper> yes
20150808 15:19:22< zookeeper> reports of fixed bugs get closed after a release containing the fix is released
20150808 15:21:27< zookeeper> so there shouldn't be old reports marked fixed, at least as long as by old we mean older than the latest release
20150808 15:28:00-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Remote host closed the connection]
20150808 15:28:09-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20150808 15:30:31-!- avtobiff [~avtobiff@c-503270d5.015-6-73746f28.cust.bredbandsbolaget.se] has quit [Ping timeout: 245 seconds]
20150808 15:30:31-!- avtobiff [~avtobiff@c-503270d5.015-6-73746f28.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20150808 15:40:45< wedge009> Well, I'm looking at old reports that are still open. They aren't explicitly marked as fixed, they just happen to be fixed in later releases (or I simply can't reproduce them). I've been marking the ones I think can be closed by posting comments.
20150808 15:48:08< pydsigner> I think I counted 20 or so open reports that had been marked fixed.
20150808 15:57:03-!- gfgtdf [~chatzilla@f054061092.adsl.alicedsl.de] has joined #wesnoth-dev
20150808 16:12:40-!- gfgtdf_ [~chatzilla@f054061092.adsl.alicedsl.de] has joined #wesnoth-dev
20150808 16:15:22-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 246 seconds]
20150808 16:16:15-!- avtobiff [~avtobiff@c-503270d5.015-6-73746f28.cust.bredbandsbolaget.se] has quit [Ping timeout: 245 seconds]
20150808 16:17:38-!- avtobiff [~avtobiff@c-503270d5.015-6-73746f28.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20150808 16:17:42-!- gfgtdf [~chatzilla@f054061092.adsl.alicedsl.de] has quit [Ping timeout: 260 seconds]
20150808 16:17:42-!- aeonchil1 [enchilado@gateway/shell/blinkenshell.org/session] has joined #wesnoth-dev
20150808 16:17:42-!- aeonchil1 [enchilado@gateway/shell/blinkenshell.org/session] has quit [Changing host]
20150808 16:17:42-!- aeonchil1 [enchilado@gateway/shell/blinkenshell.org/x-lgbofkosdzzqmeja] has joined #wesnoth-dev
20150808 16:17:50-!- gfgtdf_ is now known as gfgtdf
20150808 16:26:20-!- avtobiff [~avtobiff@c-503270d5.015-6-73746f28.cust.bredbandsbolaget.se] has quit [Ping timeout: 245 seconds]
20150808 16:26:50-!- aeonchil1 [enchilado@gateway/shell/blinkenshell.org/x-lgbofkosdzzqmeja] has quit [Ping timeout: 260 seconds]
20150808 16:27:57-!- avtobiff [~avtobiff@c-503270d5.015-6-73746f28.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20150808 16:33:10-!- Kwandulin [~Miranda@p5B00804C.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150808 16:35:25-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20150808 16:42:42 * celticminstrel considers a WML for-loop.
20150808 16:46:40< celticminstrel> mattsc, do you know what ana is and why its files do not exist?
20150808 16:47:48< celticminstrel> (Also, is there any reason for files in the XCode project to remain not sorted by name?)
20150808 16:52:34< celticminstrel> I also don't understand why there's two references to all the libraries.
20150808 16:54:23-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150808 17:03:20-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150808 17:34:07-!- irker716 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150808 17:35:57 * celticminstrel is trying to organize the project file. >_>
20150808 17:36:26< vultraz> I think we removed ana
20150808 17:37:36< zookeeper> celticminstrel, wouldn't hurt to have one. [for] array=<arrayname> iter=<var to hold the index> [do] [/do] [/for] would be my suggestion. unsure whether in addition to iter= it should support another key which would define through which variable to access the current element directly.
20150808 17:38:56< zookeeper> or, in other words, whether inside the loop you'd need to access stuff via arrayvar[$iter].foo or whether someitervar.foo would also be supported.
20150808 17:44:52< gfgtdf> i'd actually drop the [do] and put the actional directly into [for]
20150808 17:45:20< celticminstrel> Having a [do] might increase flexibility a bit, though.
20150808 17:45:33< gfgtdf> celticminstrel: why?
20150808 17:45:39< gfgtdf> celticminstrel: looks just like mor to type for me
20150808 17:46:03< zookeeper> gfgtdf, true, the [do] wouldn't be necessary
20150808 17:46:38< celticminstrel> If you want to allow tags that affect how iteration occurs, for example. It was certainly necessary for [while], I suppose it could be skipped for [for]; but consistency is also good, right?
20150808 17:48:30< gfgtdf> celticminstrel: can you give a conrete example to shat you mean by rtags the effect iteration for [for]/[foreach] ?
20150808 17:48:55-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150808 17:49:24< celticminstrel> The only thing I can think of right now is letting you iterate through something without first assigning it to a variable.
20150808 17:50:59< celticminstrel> For example, [for][range]min=0  max=12  step=2[/range][do]...[/do][/for]
20150808 17:52:11< celticminstrel> ...oh, that would also require a tag giving the variable name, I suppose.
20150808 17:52:20< celticminstrel> Though maybe it could default to i.
20150808 17:52:42< celticminstrel> Mind you, the range could still be supported without a subtag.
20150808 17:52:53< shadowm> celticminstrel: Did you see my message earlier?
20150808 17:53:14< celticminstrel> If it was while I was gone, then no. Do you want me to check the logs?
20150808 17:53:42< shadowm> That's what contributors should do, yes, but here it is:
20150808 17:53:44< shadowm> 03:09:47 <irker501> wesnoth: Ignacio R. Morelle wesnoth:master 32342a5fc44a / src/tests/gui/test_gui2.cpp: gui2/tlabel_settings: Exclude from GUI2 unit test http://git.io/v3eu0
20150808 17:53:49< shadowm> 03:13:45 <shadowm> celticminstrel: ^
20150808 17:53:58< celticminstrel> I did see that commit.
20150808 17:54:42< zookeeper> celticminstrel, on the other hand, when have [if] or [while] ever been extended aside from just adding more generic conditions? seems kinda unlikely.
20150808 17:54:43< zookeeper> besides, the range stuff wouldn't need to be encapsulated in a subtag anyway.
20150808 17:55:14< gfgtdf> shadowm: i updated the gui2 addon_list dialog, maybe it help to move the addon manager to gui2 idk.
20150808 17:55:40< gfgtdf> zookeeper: a alterntive woudl be to simly have different tags like [for_range] and [foreach].
20150808 17:55:50< celticminstrel> The other idea I had for a subtag was something like [for][in] some container object[/in][do]...[/do][/for], but I suppose assigning it to a variable first isn't too much of a hassle.
20150808 17:56:59< celticminstrel> gfgtdf: Yeah, you could do that.
20150808 17:57:26< celticminstrel> Would that be preferred?
20150808 17:58:22< zookeeper> frankly i see no reason whatsoever to try to cater to so many specific usecases. after all the goal is, or should be, to have a better non-macro shortcut for writing a loop than FOREACH. being able to iterate in steps of 2 or not need to store the unit array beforehand would be very niche luxuries.
20150808 17:59:25< celticminstrel> shadowm: Did you just want to draw my attention to the commit or did you want me to do something about it (eg, change how the dialog works somehow so that it can do without a display_context object)?
20150808 18:01:03-!- Kats [5664e753@gateway/web/freenode/ip.86.100.231.83] has joined #wesnoth-dev
20150808 18:03:27 * zookeeper wants a list of all abilities and weapon specials ever implemented or proposed (except the very dumbest ones)
20150808 18:03:44< shadowm> celticminstrel: Just wondering if you had an alternative in mind with code. You don't need to do anything if you don't.
20150808 18:03:49< celticminstrel> That sounds like a lot of work.
20150808 18:04:20< celticminstrel> (That's at zookeeper )
20150808 18:11:22< gfgtdf> zookeeper: there are some reuquests about abilitied in the bugtracker for example : http://gna.org/bugs/?22596 and http://gna.org/bugs/?23063
20150808 18:25:34< loonycyborg> where's that aquileia fellow?
20150808 18:25:44< loonycyborg> I need to talk to him about nsis stuff
20150808 18:26:06< loonycyborg> he merged it to master and it works fine I tested
20150808 18:26:19< loonycyborg> but he also backported it to stable branch
20150808 18:26:26< loonycyborg> not sure if it's such a good idea
20150808 18:38:45-!- Elvish_Hunter [~irssi@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20150808 18:39:17< Elvish_Hunter> Hi all
20150808 18:40:00-!- irker032 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150808 18:40:00< irker032> wesnoth: Elvish_Hunter wesnoth:master b892f764a631 / data/tools/wmlscope: wmlscope: try to make the image size checks more useful http://git.io/v3JWk
20150808 18:40:00< irker032> wesnoth: Elvish_Hunter wesnoth:master de64146e354e / data/tools/ (wesnoth/wmliterator.py wesnoth/wmltools.py wmllint): wmllint, wmltools and wmliterator: more Python 3 compatibility stuff http://git.io/v3JWI
20150808 18:41:13< gfgtdf> Elvish_Hunter: hi
20150808 18:41:31< Elvish_Hunter> celticminstrel: in past, I already tried to implement a [foreach] tag. The discussion is here: http://forums.wesnoth.org/viewtopic.php?f=58&t=32237&start=150#p543109
20150808 18:43:40< zookeeper> oh right, the modifying issue.
20150808 18:48:56< gfgtdf> i also tried to implement a [foreach] tag some time ago, iirc my last thought was like 'All my addons use lua for scripting so why am i doing this?'
20150808 18:48:57-!- chaverma [~Chris@c-67-169-95-15.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150808 18:50:08< gfgtdf> But i o think it oudl be nice to have a tag to replace {FOREACH} (which should still be kept for compability)
20150808 18:51:35< Yaiyan> What progress has there been with the python tools?
20150808 18:52:03< Elvish_Hunter> Yaiyan: I'm working on their Python 3 compatibility
20150808 18:52:20< Yaiyan> Elvish_Hunter, wasn't there a guy who was going to redo them?
20150808 18:52:24-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150808 18:56:07-!- Tracerneo [tracerneo@unaffiliated/tracerneo] has left #wesnoth-dev ["WeeChat 0.4.3"]
20150808 18:56:27-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 250 seconds]
20150808 18:58:31-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20150808 19:00:34< Elvish_Hunter> Yaiyan: yes, but after that I told his plan I didn't hear anything else
20150808 19:00:41< Elvish_Hunter> *he, not I
20150808 19:01:14< Yaiyan> shikadibot, seen tetha
20150808 19:01:14< shikadibot> Yaiyan: The person with the nick tetha last spoke 7d 1h ago.  3d 2h ago they left with the message: Remote host closed the connection
20150808 19:01:19< Yaiyan> I see
20150808 19:01:23< Elvish_Hunter> Besides, I'm convinced that these tools can still be salvaged
20150808 19:01:23< Yaiyan> :\
20150808 19:01:32< Yaiyan> I dunno, they're pretty messy
20150808 19:01:37< Yaiyan> Especially wmllint
20150808 19:02:07< Yaiyan> Years of extensions does that to things ;)
20150808 19:02:08< Elvish_Hunter> Yes. My plan for it is to split it in smaller, more manageable functions and perhaps implement a unit test
20150808 19:02:17< Yaiyan> Yeah, that would be good
20150808 19:04:02< Elvish_Hunter> Luckily, Python has a unittest module exactly for that purpose :-) Also, I found out that Py3 has a new keyword called nonlocal, which allows implementing real closure functions like in Lua
20150808 19:04:14< Elvish_Hunter> That may be useful when splitting wmllint
20150808 19:05:21< Yaiyan> I wouldn't convert it to python 3, personally
20150808 19:05:41< Yaiyan> Not until running python (near) universally will run python 3, and not 2
20150808 19:08:13< celticminstrel> You can specifically request py3, can't you? (something like #!/usr/bin/python3)
20150808 19:08:46< chaverma>  i spoke with tetha last week and i've been progressing on parsing wml into an AST
20150808 19:09:57-!- Kats [5664e753@gateway/web/freenode/ip.86.100.231.83] has quit [Ping timeout: 246 seconds]
20150808 19:10:01< pydsigner> The main issue with parsing wml is macros.
20150808 19:10:03< shadowm> celticminstrel: Yes.
20150808 19:10:10< Elvish_Hunter> celticminstrel: yes, that's what I'm planning to do. But plans are made to be changed at any moment, aren't they? :-P
20150808 19:10:24< chaverma> re: python tools
20150808 19:11:33< Yaiyan> I wonder how many people run python scripts as ./script.py
20150808 19:11:42< Yaiyan> Verse python script.py
20150808 19:11:44< chaverma> for macros i have them parsing as a superset i'm calling "inclusion"
20150808 19:11:46< Yaiyan> versus*
20150808 19:12:12< chaverma> but i haven't dug into the full set of capabilities macros offer
20150808 19:13:33< shadowm> Yaiyan: Most people on Linux and other POSIX platforms, I'd say.
20150808 19:14:13< Yaiyan> Then more people have faith in the script author adding that line than I thought
20150808 19:15:12< pydsigner> If it has the executable bit, use it
20150808 19:15:27< Elvish_Hunter> Well, as the script author it's your responsibility to place the correct shebang
20150808 19:15:45< Elvish_Hunter> In fact, in GUI.pyw I'm using #!/usr/bin/env python2 to force it to run pn Py2
20150808 19:15:56< shadowm> It also helps with syntax highlighters if you choose to not include an extension in the filename.
20150808 19:16:00< Elvish_Hunter> * pn -> on
20150808 19:16:30< Yaiyan> There are people who omit the extension?
20150808 19:16:41< shadowm> ... Yes.
20150808 19:16:51< Elvish_Hunter> Guess what, most of our Python tools don't have an extension... :-/
20150808 19:16:59< Yaiyan> Well then...hmm
20150808 19:17:08< chaverma> generally it's so that people will treat it like an executable
20150808 19:17:10< Yaiyan> Elvish_Hunter, not sure how I forgot that
20150808 19:17:13< chaverma> and not get cute
20150808 19:17:15< shadowm> utils/wesnoth-optipng, utils/wmlxgettext, data/tools/{wmllint,wmlindent,wmlscope}
20150808 19:17:28< shadowm> Perl x 2 and Python x 3 respectively.
20150808 19:21:17< celticminstrel> Elvish_Hunter's [foreach] uses some things I didn't know existed.
20150808 19:21:50< celticminstrel> Also, my knowledge of Lua is still pretty basic.
20150808 19:27:37-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 246 seconds]
20150808 19:27:59-!- shadowm_laptop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150808 19:28:27< celticminstrel> The clear_variable key seems kind of silly.
20150808 19:34:28< celticminstrel> If an array element was added or deleted in WML, would the array returned from helper.get_variable_array reflect the change?
20150808 19:35:56< pydsigner> My two cents on the can't-change-list-waaaaaah issue is that that is standard operating procedure for a for-each construct
20150808 19:36:34< Elvish_Hunter> I remember that it does. But a long time passed since when I last used it, so I may be wrong
20150808 19:36:54< Elvish_Hunter> Also, it's never a good idea to delete stuff from an array while iterating it...
20150808 19:37:09< celticminstrel> It's fine if you know what you're doing.
20150808 19:37:37< celticminstrel> You can iterate backwards (but then you might cover some elements more than once, I think?) or you can decrement the index after deleting.
20150808 19:38:08< pydsigner> In python if you're going to touch the array you have to iterate over a copy.
20150808 19:38:15< celticminstrel> That's not true.
20150808 19:38:30< celticminstrel> The key is that it doesn't work in a proper foreach loop, only a for-range loop over all the indices.
20150808 19:38:54< celticminstrel> So in Python you'd have to do for i in range(0,len(array)):
20150808 19:39:00< pydsigner> .....
20150808 19:39:09< pydsigner> That isn't a for-each loop.
20150808 19:39:12< pydsigner> Seriously.
20150808 19:39:30< celticminstrel> It's how the {FOREACH{ macro works.
20150808 19:39:36< celticminstrel> {FOREACH}
20150808 19:39:48< pydsigner> I know, but it isn't a true for-each either.
20150808 19:41:18< celticminstrel> I'd say if we're going to have a [foreach] it should probably be based on Elvish_Hunter's version.
20150808 19:41:52< Elvish_Hunter> Feel free to improve it :-)
20150808 19:42:31< celticminstrel> I don't really get the point of the clear_variable key.
20150808 19:43:32< celticminstrel> I wrote a quick version that's basically exactly the same as the macro: http://pastebin.com/Hi41TJ5P
20150808 19:44:05< celticminstrel> I'm not suggesting we use that, though. It's just for... demonstration?
20150808 19:44:10< celticminstrel> I think it's exactly the same, anyway.
20150808 19:45:35< celticminstrel> Apparently the [while] tag will accept multiple [do] subtags and execute them in order on each iteration.
20150808 19:46:24< Elvish_Hunter> Yes, that's a thing that I missed at the time
20150808 19:47:41< celticminstrel> The {FOREACH} macro does support insertions and deletions while iterating.
20150808 19:48:00< celticminstrel> So we should as well, probably.
20150808 19:48:03< pydsigner> Because it's a specialized for-loop rather than a for-each
20150808 19:48:06< pydsigner> No.
20150808 19:48:18< pydsigner> The FOREACH macro should be left.
20150808 19:48:20< celticminstrel> Though we could do it by adding separate [for] and [foreach], I suppose.
20150808 19:48:43< celticminstrel> Why should the FOREACH macro be left indefinitely?
20150808 19:58:18-!- gfgtdf [~chatzilla@f054061092.adsl.alicedsl.de] has quit [Ping timeout: 250 seconds]
20150808 20:03:23-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20150808 20:03:38< aquileia> 18:25:34< loonycyborg> where's that aquileia fellow?
20150808 20:03:48< aquileia> loonycyborg: Here I am!
20150808 20:06:15< loonycyborg> well, I installed nsis 3 and master worked with it
20150808 20:06:51< loonycyborg> so much packaging process is updated
20150808 20:07:13< loonycyborg> *my
20150808 20:07:40< aquileia> shadowm requested that I leave the userdata location page intact in 1.12, and that the new icons are reserved for 1.13. The rest is basically bugfixing the translation, so I thought I'd backport it
20150808 20:09:43< aquileia> loonycyborg: Great - I tested the NSIS script extensively (I de- and reinstalled Wesnoth about 80 times) but wasn't 100% sure it'd work with Scons, which I couldn't get to accept my MSVC build of wesnoth.exe / wesnothd.exe
20150808 20:10:18< loonycyborg> ok
20150808 20:11:50< aquileia> For a time, I had French, Rusian and Portuguese start menu shortcuts (and quite a few ????????? entries due to ANSI/UTF16 conflicts, but these are solved)
20150808 20:12:52< celticminstrel> Since {FOREACH} isn't a proper foreach loop, maybe it's better to add [for] rather than [foreach]? http://pastebin.com/94NdejW2
20150808 20:13:46< celticminstrel> Of course, [foreach] could also be added later (probably from Elvish_Hunter) once people figure out just how it should work.
20150808 20:13:55< mattsc> celticminstrel: hi - did you get answers to your questions?  (I just got back and saw that you pinged me, but haven’t had time to read the logs yet)
20150808 20:14:17< celticminstrel> mattsc: I did not.
20150808 20:14:23< aquileia> I'm currently trying to get Scons to parse the output of git diff --name-status so that I can generate a list of files to be included in the patch
20150808 20:14:52< mattsc> Rats, I hope you had since I don’t really know the answers either ...
20150808 20:15:00< mattsc> *had hoped
20150808 20:15:03< celticminstrel> I discovered there are several source files in the src directory that aren't in the XCode project (unless they're nested in another group somewhere).
20150808 20:15:05< celticminstrel> Ah.
20150808 20:15:31< celticminstrel> Well, vultraz did say he things ana was removed.
20150808 20:15:41< celticminstrel> You don't know if there's a reason for the files to be unsorted?
20150808 20:15:45< celticminstrel> ^thinks
20150808 20:15:50< shadowm> Ana was removed, this is a fact.
20150808 20:16:15< celticminstrel> I'm curious what it was, but I suppose it doesn't matter that much.
20150808 20:16:19< shadowm> 1.13.0 changelog:    * Removed abandoned libana network API implementation.
20150808 20:16:21< mattsc> celticminstrel: no, I have no idea why they are in the order in which they are.
20150808 20:16:30-!- trewe [~trewe@2001:8a0:d13b:9901:626c:66ff:fe92:9b7c] has joined #wesnoth-dev
20150808 20:16:32< pydsigner> celticminstrel: Better to add both
20150808 20:16:39< celticminstrel> Would you be opposed to them being sorted?
20150808 20:16:39< mattsc> I assume that they are just in whatever order they were put in, and that nobody ever cared to change that
20150808 20:16:52< celticminstrel> pydsigner: Sure, but the don't have to both be added at the same time, right?
20150808 20:16:54< celticminstrel> ^they
20150808 20:16:57< mattsc> No, not at all (as long as it doesn’t break anything, which I assume it won’t)
20150808 20:17:15< shadowm> It was an ill-fated attempt at building an Asio-based network API for Wesnoth's clients and servers.
20150808 20:18:28< celticminstrel> Okay, so far I have 1) sorted everything, 2) deleted references to ana, and 3) added a lot of headers that were not referenced. (Since they're headers, the absence of course does not affect the build, but I think it does affect XCode operation; for example, I think they wouldn't be searched.)
20150808 20:19:52< mattsc> celticminstrel: sounds good to me 
20150808 20:20:17< mattsc> (as far as I can tell, which does not mean much at all)
20150808 20:20:42< aquileia> shadowm: BTW, now we only have to wait for the addition of SDL mixer in apt-package-whitelist, then I can move travis to container based builds
20150808 20:20:44< celticminstrel> For the record, the game does still build and run without errors. In case you were wondering..
20150808 20:21:35< shadowm> aquileia: Is that all? I remember missing more packages.
20150808 20:21:51< mattsc> celticminstrel: I wasn’t wondering.  I figured that you had checked that.  :)
20150808 20:21:52< aquileia> Already added 
20150808 20:22:18< celticminstrel> build_info.cpp appears to be excluded from the XCode build.
20150808 20:22:23< aquileia> SDL mixer takes longer because it didn't pass their automated checks
20150808 20:22:36< shadowm> celticminstrel: It was added after 1.13.1 was released.
20150808 20:22:56< shadowm> Most missing files will be missing for the same reason.
20150808 20:23:08< celticminstrel> So, it should be included?
20150808 20:23:17< shadowm> Yes, otherwise the build will fail.
20150808 20:23:25< celticminstrel> But the build doesn't fail. Hmm.
20150808 20:23:35< shadowm> The build *must* fail.
20150808 20:24:02< shadowm> The file includes the implementation of functions required by wesnoth.o and src/gui/dialogs/game_version.o.
20150808 20:26:05< mattsc> celticminstrel: as a side note, you clearly know more about Xcode and C++ than I do, so no objections at all if you want to clean up the Xcode project files and directories.
20150808 20:26:09< celticminstrel> Oh, it is included somewhere.
20150808 20:26:22< celticminstrel> I can see it in the XCode project file in a text editor.
20150808 20:48:04< celticminstrel> There are two different fonts.conf
20150808 20:49:17< celticminstrel> fonts/fonts.conf and projectfiles/XCode/Resources/fonts.conf
20150808 20:49:50< celticminstrel> Well, I suppose this makes sense.
20150808 20:52:01< shadowm> Wait wha
20150808 20:53:01-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150808 20:53:24< shadowm> What's the second file for?
20150808 20:53:30< shadowm> mattsc: ^
20150808 20:54:24< celticminstrel> Looks like Mac-specific stuff?
20150808 20:55:01< shadowm> It's a fontconfig config file.
20150808 20:55:23< shadowm> I guess fontconfig is provided by the app bundle and not the OS in OS X?
20150808 20:55:41< celticminstrel> Looks like it, yes.
20150808 20:55:53< mattsc> yes, that is correct
20150808 20:56:01< shadowm> Anyway, it shouldn't interfere with the private fontconfig config I added in 1.13.1, bar bugs.
20150808 20:58:57< aquileia> Just a guess, but... might that file reference the system fonts Wesnoth uses on OS X?
20150808 20:59:48< celticminstrel> It doesn't actually reference any specific fonts.
20150808 21:00:15< celticminstrel> It does specify some search directories for fonts though.
20150808 21:00:35 * aquileia wonders whether deleting the one in Resources might fix that bug...
20150808 21:00:48< celticminstrel> What bug?
20150808 21:01:47< aquileia> IIRC XCode builds don't use the font we ship with the game (might already be ad acta, though)
20150808 21:02:01< shadowm> https://gna.org/bugs/index.php?23560
20150808 21:02:11< shadowm> I doubt it will.
20150808 21:04:54-!- chaverma [~Chris@c-67-169-95-15.hsd1.ca.comcast.net] has quit [Quit: Leaving.]
20150808 21:08:29-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150808 21:12:38< celticminstrel> filesystem.cpp is not included.
20150808 21:12:47< celticminstrel> It looks like it might be obsolete though.
20150808 21:15:48< shadowm> It is, use filesystem_boost.cpp instead.
20150808 21:16:31< celticminstrel> There's also filesystem_common.
20150808 21:19:51< celticminstrel> What about gettext.?pp? Also obsolete?
20150808 21:20:01< celticminstrel> Or just the cpp is obsolete?
20150808 21:20:44-!- chaverma [~Adium@204.102.74.245] has joined #wesnoth-dev
20150808 21:25:02< shadowm> celticminstrel: filesystem_common.cpp and filesystem_boost.cpp are what you should use.
20150808 21:25:13< shadowm> Also gettext_boost.cpp.
20150808 21:25:32< shadowm> The .hpp files are not obsolete for obvious reasons.
20150808 21:33:07< chaverma> some wml parsing, visualized https://www.dropbox.com/s/kmfmqupe0gal26i/wesnoth-example.png?dl=0
20150808 21:33:31< chaverma> source was:
20150808 21:33:31< chaverma> #textdomain wesnoth
20150808 21:33:31< chaverma> {tools/exploder/models/castle.cfg}
20150808 21:33:31< chaverma> [part]
20150808 21:33:32< chaverma> name=castle-concave-nw
20150808 21:33:32< chaverma> pos=36,36
20150808 21:33:33< chaverma> [/part]
20150808 21:35:35< celticminstrel> What about x,y=3,4?
20150808 21:36:39< celticminstrel> Also, do you really need to keep all the newlines?
20150808 21:37:03< chaverma> no
20150808 21:37:09< chaverma> but this is a work in progress
20150808 21:37:19< celticminstrel> Well, it looks good so far.
20150808 21:38:06< chaverma> i want to get more granular into those leaves
20150808 21:38:20< celticminstrel> savepng.hpp is never used anywhere, so I guess I'll leave that one out.
20150808 21:38:24< chaverma> but the ebnf parser is a little finicky
20150808 21:38:29< celticminstrel> I see.
20150808 21:39:19< shadowm> celticminstrel: The stuff in src/SDL_SavePNG is required for PNG screenshot support along with -DHAVE_LIBPNG.
20150808 21:39:22< aquileia> shadowm: https://github.com/wescamp/build-system/blob/master/init-build-sys.sh
20150808 21:39:40< aquileia> should be what AI0867 was using
20150808 21:39:56< celticminstrel> But git grep 'savepng.hpp' yields nothing.
20150808 21:40:22< celticminstrel> savepng.h is used though.
20150808 21:40:58< celticminstrel> ...now I don't see a savepng.hpp. Did I just imagine it? o.O
20150808 21:41:30-!- irker032 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150808 21:41:32< shadowm> It doesn't exist here, so.
20150808 21:41:36< aquileia> I hope you have your own lbundle-check.py though, the linked version is quite old and doesn't support multiline language lists (had to edit my local copy of l10n-spec)
20150808 21:44:25< celticminstrel> tracer.cpp is excluded.
20150808 21:56:27-!- Elvish_Hunter [~irssi@wesnoth/developer/elvish-hunter] has quit [Quit: Ciao!]
20150808 22:02:53< zookeeper> iceiceice, btw, the auto-generated "portraits" from sprites (in the unit help pages, for units without portraits) aren't TC'd. also the scaling options don't seem to apply there, neither for the scaled-up sprite nor the pseudo-portraits.
20150808 22:03:50< aquileia> chaverma, Yaiyan: In Python, if I want to add only unique elements to a list, is it better to use a) if AMD-name[2] not in FAlist: FAlist += AMD-name[2]      or b) FAset |= set(AMD-name[2])
20150808 22:04:24< shadowm> zookeeper: I thought that was a vultraz change.
20150808 22:04:44< shadowm> Or maybe he was trying to fix it, hm.
20150808 22:04:47< celticminstrel> "not in" would go through all the elements to make sure it's not there.
20150808 22:04:54< pydsigner> aquileia: Usually the set is better
20150808 22:04:58< celticminstrel> If order isn't important, I'd use the set.
20150808 22:05:00< chaverma> aquileia:  99% sure sets will be faster and provide an easier api
20150808 22:05:04< vultraz> zookeeper: I could have sworn they're TCed...
20150808 22:05:10< pydsigner> Depending upon whether or not you need order
20150808 22:05:14< vultraz> zookeeper: I'll look into it after I watch this dota
20150808 22:05:20< aquileia> ok, thanks, pydsigner, celticminstrel & chaverma
20150808 22:12:58< vultraz> zookeeper: ah, I see what this is
20150808 22:13:00< vultraz> will fix later
20150808 22:22:25< zookeeper> vultraz, oh, good
20150808 22:23:27< zookeeper> shadowm, right, i didn't remember who did it and deduced that from a forum search, but i guess he didn't do that specific thing then
20150808 22:26:14< aquileia> loonycyborg: When building the installer you'll always be on the branch you built against, right? I'd like to use 'HEAD' as the state relative to which patches are generated
20150808 22:26:36< aquileia> *you built the Wesnoth release against
20150808 22:28:22< loonycyborg> I checkout tags for releases
20150808 22:28:28< zookeeper> wedge009, the item layering glitch is of course of very low priority, but it's still something that should IMO be kept open in case it's possible to (easily) fix one day.
20150808 22:29:31< aquileia> ok
20150808 22:30:42-!- Xara [Yangyf@2001:cc0:2020:4010:c4e3:65ef:b2c9:65e2] has joined #wesnoth-dev
20150808 22:32:03< aquileia> In that case it'll always iterate over one last empty file (comparing the tag with HEAD), but it's safer not to assume the tag is checked out (e.g. you might want to apply a Windows specific patch after tagging)
20150808 22:32:10< loonycyborg> aquileia: git diff 1.12.1 1.12.2 or something like that
20150808 22:32:46-!- jcnewjersey [~jcnewjers@pool-108-35-38-39.nwrknj.fios.verizon.net] has quit [Read error: Connection reset by peer]
20150808 22:33:08< aquileia> loonycyborg: I'm using git diff --name-status 1.12.rev HEAD        with rev counting up
20150808 22:33:32< loonycyborg> no need to involve HEAD
20150808 22:33:41< loonycyborg> when git can just compute differences for you
20150808 22:41:35-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 244 seconds]
20150808 22:43:45< celticminstrel> Almost done reorganizing the XCode project.
20150808 22:55:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20150808 23:00:19< celticminstrel> Doing a clean build to make sure I didn't break anything.
20150808 23:01:47-!- afre [63f401a5@gateway/web/freenode/ip.99.244.1.165] has joined #wesnoth-dev
20150808 23:01:56-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150808 23:07:32-!- iamshansen [~iamshanse@me.shansen.me] has left #wesnoth-dev ["Textual IRC Client: www.textualapp.com"]
20150808 23:17:20< afre> Can I say something about the title screen map?
20150808 23:19:45< zookeeper> you can
20150808 23:22:23< afre> I've been looking at it since it was committed. It didn't look right then but I thought I could get used to it. It doesn't match the angle of the table/wood.
20150808 23:23:08< afre> It feels like an invisible hand is holding the bottom part of it upward.
20150808 23:24:02-!- Appleman1234_ [~Appleman1@KD106179124036.au-net.ne.jp] has joined #wesnoth-dev
20150808 23:24:20< zookeeper> you mean it seem too tapered like this? /__\
20150808 23:24:58< afre> Yes, whereas the table isn't. I measured the width of the planks just to make sure.
20150808 23:26:12< afre> It looks like it's both hanging on a wall and resting on a table.
20150808 23:26:38-!- Appleman1234 [~Appleman1@KD036009073125.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20150808 23:27:36< zookeeper> hmhmhm
20150808 23:28:13-!- chaverma [~Adium@204.102.74.245] has quit [Quit: Leaving.]
20150808 23:29:55< zookeeper> i don't recall, but yes, it's entirely possible that the wood lacks proper perspective, that the upper planks don't become smaller
20150808 23:30:10< zookeeper> although they weren't exactly the same width to begin with
20150808 23:31:17< wedge009> zookeeper: Sure, I'm trying to go through all the bug reports, high or low priority, and adding whatever additional information I can find.
20150808 23:40:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150808 23:40:37< afre> My desk is wood textured btw; perhaps that's why I'm so bothered - haha. Different widths is understandable. Maybe it's because the middle two planks are the same width. Maybe it's the textures and blurring.
20150808 23:43:17-!- Appleman1234__ [~Appleman1@KD036009082065.au-net.ne.jp] has joined #wesnoth-dev
20150808 23:43:37< afre> In any case, the tapering could be less to suit the background, or vice versa. Also, the map could be larger against the screen. Currently, it feels small - not a strategic map sprawled across my medieval table.
20150808 23:45:25-!- trewe [~trewe@2001:8a0:d13b:9901:626c:66ff:fe92:9b7c] has quit [Quit: quit]
20150808 23:46:28-!- Appleman1234_ [~Appleman1@KD106179124036.au-net.ne.jp] has quit [Ping timeout: 272 seconds]
20150808 23:49:48< zookeeper> afre, i totally agree that the wood is not really ideal. i should have made it higher resolution in the first place, for starters.
20150808 23:50:22< zookeeper> luckily at least it's separately replaceable
20150808 23:50:54< shadowm> And without hurting translations!
20150808 23:51:06< zookeeper> that too
20150808 23:59:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
--- Log closed Sun Aug 09 00:00:08 2015