--- Log opened Wed Aug 12 00:00:29 2015
20150812 00:00:35-!- gandaro [~gandaro@wikipedia/Gorlingor] has quit [Quit: Leaving]
20150812 00:01:12-!- aitsu [8d465188@gateway/web/freenode/ip.141.70.81.136] has quit [Ping timeout: 246 seconds]
20150812 00:33:50-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Read error: Connection reset by peer]
20150812 00:42:47-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20150812 00:49:45-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150812 00:54:19-!- joet [~joet@host86-163-217-190.range86-163.btcentralplus.com] has quit [Quit: Leaving]
20150812 01:19:23-!- N4tr0n_ [~N4tr0n@162.255.34.90] has quit [Ping timeout: 256 seconds]
20150812 01:20:57-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150812 01:30:29-!- irker188 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150812 01:46:52-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150812 01:48:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150812 01:48:14-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has quit [Client Quit]
20150812 01:50:13-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150812 01:54:02-!- genbattle_ [~genbattle@115-188-147-250.jetstream.xtra.co.nz] has joined #wesnoth-dev
20150812 01:56:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150812 01:59:06-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150812 01:59:55-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150812 02:00:29-!- genbattle_ [~genbattle@115-188-147-250.jetstream.xtra.co.nz] has quit [Ping timeout: 252 seconds]
20150812 02:06:39-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150812 02:19:24-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150812 02:19:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150812 02:21:44-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150812 02:23:10-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Client Quit]
20150812 02:39:09-!- Portaljacker [~Portaljac@modemcable081.139-178-173.mc.videotron.ca] has quit [Quit: Leaving]
20150812 03:03:44-!- N4tr0n_ [~N4tr0n@cpe-76-175-70-130.socal.res.rr.com] has joined #wesnoth-dev
20150812 03:06:57-!- skemper [~skemper@8.37.96.39] has joined #wesnoth-dev
20150812 03:09:51-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20150812 03:11:38-!- N4tr0n_ [~N4tr0n@cpe-76-175-70-130.socal.res.rr.com] has quit [Ping timeout: 272 seconds]
20150812 03:25:39-!- vincent_c [~bip@vcheng.org] has quit [Ping timeout: 246 seconds]
20150812 03:26:25-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev
20150812 03:28:08-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20150812 03:30:02-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150812 03:44:57-!- asdasd [7a944b09@gateway/web/freenode/ip.122.148.75.9] has joined #wesnoth-dev
20150812 03:51:30-!- asdasd [7a944b09@gateway/web/freenode/ip.122.148.75.9] has quit [Quit: Page closed]
20150812 04:01:49-!- kinow [~kinow@apache/committer/kinow] has quit [Quit: Leaving]
20150812 04:11:25-!- iwaim_ [~iwaim@rasteenie.alib.jp] has quit [Remote host closed the connection]
20150812 04:12:11-!- iwaim [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20150812 04:18:42-!- oldlaptop [~quassel@50-107-125-36.adr02.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20150812 04:26:34-!- oldlaptop [~quassel@50-107-125-36.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150812 04:35:25< aeth> Shouldn't it say OK/Close in the add-on server dialog instead of OK/Cancel because it doesn't Cancel what you downloaded if you downloaded something, and you need to "Cancel" to exit?
20150812 04:35:55< celticminstrel> The add-on server dialog also has the issue that it redownloads the list after installing an addon.
20150812 04:36:17< celticminstrel> I agree with your statement, anyway.
20150812 04:36:26< aeth> yeah but this is an issue of replacing one already-translated string with another already-translated string
20150812 04:36:30< celticminstrel> Actually, OK should probably be Install.
20150812 04:36:32< aeth> literally the most trivial thing
20150812 04:37:05< vultraz> shadowm has the final say on addon server interface matters
20150812 04:37:22< shadowm> Patches welcome.
20150812 04:38:13< aeth> Is Install an already-translated string?
20150812 04:38:35< celticminstrel> I can't think of anywhere it's used, so probably not.
20150812 04:38:59< vultraz> Either way, it's a trivial addition 
20150812 04:39:53< shadowm> The only reason the buttons don't have better strings is because 1) at the time I didn't figure out how to change the GUI1 stock dialog's button labels per-instance; 2) the strings need either be generic or change depending on the current item selected, and the latter is a decidedly non-trivial task.
20150812 04:40:34< shadowm> Or. Hm. Actually, I believe someone did 1 without doing 2 before so I reverted it during the 1.11.x refactoring.
20150812 04:40:53< celticminstrel> And there's a GUI2 addons dialog in progress too, so maybe it's not worth fixing?
20150812 04:41:12< shadowm> I wouldn't have used Close because the convention is that Close is only used where there are no distinct OK and Cancel actions.
20150812 04:41:20< shadowm> celticminstrel: It's been in progress since 2008. Don't look at it.
20150812 04:41:56< celticminstrel> Ah.
20150812 04:43:12-!- N4tr0n_ [~N4tr0n@cpe-76-175-70-130.socal.res.rr.com] has joined #wesnoth-dev
20150812 04:43:36< vultraz> The introduction of sortable gui2 listboxes a few days ago finally brought it a TAD closer to usability :P
20150812 04:44:16< shadowm> I've not looked at it but the last time I checked (in 2011 or so) it also seemed to suffer from severe rendering inefficiencies.
20150812 04:44:41< shadowm> Plus if mordante decided the current listbox implementation wasn't up for the task he must've had a good reason.
20150812 04:45:04-!- afre [63f401a5@gateway/web/freenode/ip.99.244.1.165] has joined #wesnoth-dev
20150812 04:46:16< afre> Read the logs: what are orcish nightblades?
20150812 04:46:34< shadowm> L3 advancement to the Orcish Slayer that's only enabled on-demand by campaigns.
20150812 04:46:52< vultraz> Someone should suggest LB do a generic for it
20150812 04:47:09< shadowm> Someone who is actually interested in the unit you mean.
20150812 04:47:12< shadowm> :p
20150812 04:47:13< vultraz> After the wose and yeti
20150812 04:47:16< celticminstrel> Is Nightblade in 1.12?
20150812 04:47:19< vultraz> No
20150812 04:47:25< afre> I found it.
20150812 04:47:34< afre> http://units.wesnoth.org/trunk/mainline/en_US/mainline.html
20150812 04:47:38< shadowm> It's usable in 1.12 if you take the file and resources anyway.
20150812 04:48:07< celticminstrel> ...Arcanister?
20150812 04:49:07< celticminstrel> There are several L4 units there that don't attach to any unit line.
20150812 04:49:40< afre> vultraz: I don't get the last part of the description starting from "practice makes perfect".
20150812 04:50:36< vultraz> afre: it means there aren't many other orcs that can rival them in skill since they have killed so many - way more than the 10 you could count on your fingers
20150812 04:51:59-!- Kwandulin [~Miranda@p5B008386.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150812 04:54:45< afre> I see. I made an attempt at the description, while respecting your entry. Do you want to see?
20150812 04:59:38-!- oldlaptop [~quassel@50-107-125-36.adr02.mskg.mi.frontiernet.net] has quit [Ping timeout: 244 seconds]
20150812 05:01:59-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 252 seconds]
20150812 05:02:30-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20150812 05:03:33-!- scorpion [~scorpion@46.166.188.206] has quit [K-Lined]
20150812 05:09:06-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds]
20150812 05:10:03-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20150812 05:10:50-!- oldlaptop [~quassel@50-107-125-36.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150812 05:17:20-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20150812 05:19:59-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150812 05:21:04-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 260 seconds]
20150812 05:33:08-!- irker065 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150812 05:33:08< irker065> wesnoth: Charles Dang wesnoth:master 6b78073b49bc / src/ (game_events/action_wml.cpp map.cpp): Don't pass border_size and usage to gamemap::read http://git.io/v30kc
20150812 05:33:11< irker065> wesnoth: Charles Dang wesnoth:master 2f650419dad9 / src/ (4 files in 3 dirs): Cleaned up old code related to border_size, usage, and map header http://git.io/v30kC
20150812 05:36:04< vultraz> Masks work again :D
20150812 05:38:02< afre> vultraz: Let me try: "A blade in the dark, dripping with [poison | venom | bane] — the last thing an Orcish Sovereign sees. Orcish Nightblades specialize in resolving “internal conflicts”. They are expensive to hire and so are rarely seen on the battlefield. [Efficient | ?] in their craft, only a few Orcs can rival them in [victims | kills], though that's debatable since most can only count up to their 10 fingers."
20150812 05:38:24< vultraz> Hm, maybe I should have assigned border_size_ to gamemap::default_border
20150812 05:39:19< vultraz> afre: good, but I don't think it's an improvement
20150812 05:40:41< afre> np, is the Nightblade used anywhere currently?
20150812 05:40:57< vultraz> Possibly UtBS, not sure
20150812 05:42:54< afre> Just checked. No, but the sprite is used.
20150812 05:44:25< afre> Description looks good though: "The Dark Assassin appears and disappears at a moment’s notice. No one knows where he came from or why he acts the way he does, but the trail of death he leaves in his wake is unmistakeable."
20150812 05:45:10< vultraz> Ah, that must have been what the unit type was based on
20150812 05:48:59< irker065> wesnoth: Charles Dang wesnoth:master 730453cf01c2 / data/campaigns/Legend_of_Wesmere/scenarios/chapter1/03_Kalian_under_Attack.cfg: LoW S3: fixed pesky comment line preventing wmlindent from affecting file http://git.io/v30tv
20150812 05:49:40-!- afre [63f401a5@gateway/web/freenode/ip.99.244.1.165] has quit [Quit: Page closed]
20150812 06:08:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150812 06:09:10-!- N4tr0n_ [~N4tr0n@cpe-76-175-70-130.socal.res.rr.com] has quit [Ping timeout: 240 seconds]
20150812 06:10:02-!- travis-ci [~travis-ci@ec2-54-161-38-62.compute-1.amazonaws.com] has joined #wesnoth-dev
20150812 06:10:03< travis-ci> wesnoth/wesnoth#7020 (master - 2f65041 : Charles Dang): The build was broken.
20150812 06:10:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/75211114
20150812 06:10:03-!- travis-ci [~travis-ci@ec2-54-161-38-62.compute-1.amazonaws.com] has left #wesnoth-dev []
20150812 06:10:41< irker065> wesnoth: Charles Dang wesnoth:master 17d1212a0e10 / data/ (3 files in 2 dirs): General wmlindent run http://git.io/v30YV
20150812 06:45:00-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150812 06:45:34-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150812 06:46:49-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20150812 06:47:30-!- travis-ci [~travis-ci@ec2-50-19-202-248.compute-1.amazonaws.com] has joined #wesnoth-dev
20150812 06:47:31< travis-ci> wesnoth/wesnoth#7021 (master - 730453c : Charles Dang): The build was broken.
20150812 06:47:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/75212362
20150812 06:47:31-!- travis-ci [~travis-ci@ec2-50-19-202-248.compute-1.amazonaws.com] has left #wesnoth-dev []
20150812 06:48:04-!- skemper [~skemper@8.37.96.39] has quit []
20150812 06:49:35< vultraz> build y u fail D:
20150812 07:06:41-!- boucman_work [~jrosen@193.56.60.161] has joined #wesnoth-dev
20150812 07:06:41-!- boucman_work [~jrosen@193.56.60.161] has quit [Changing host]
20150812 07:06:41-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150812 07:11:06-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150812 07:12:11-!- [Relic] [~Relic]@2602:306:33a3:6d30:5092:a2cb:6583:8797] has quit [Quit: I press the magic X and all the weirdos go away!]
20150812 07:12:43-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150812 07:30:53-!- travis-ci [~travis-ci@ec2-54-160-151-165.compute-1.amazonaws.com] has joined #wesnoth-dev
20150812 07:30:54< travis-ci> wesnoth/wesnoth#7022 (master - 17d1212 : Charles Dang): The build is still failing.
20150812 07:30:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/75214498
20150812 07:30:54-!- travis-ci [~travis-ci@ec2-54-160-151-165.compute-1.amazonaws.com] has left #wesnoth-dev []
20150812 07:41:12-!- sailorswift [~sailorswi@c-24-5-126-97.hsd1.ca.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150812 07:56:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150812 08:07:18-!- Xara [~Yangyf@2401:de00:1:6:478:71b8:fe48:a227] has joined #wesnoth-dev
20150812 08:28:13-!- joet [~joet@host86-163-217-190.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150812 08:37:50-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150812 08:54:17< vultraz> fail test: feeding :/
20150812 08:54:19< vultraz> but why
20150812 08:55:54-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20150812 09:19:05-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150812 09:34:27-!- genbattle_ [~genbattle@115-188-147-250.jetstream.xtra.co.nz] has joined #wesnoth-dev
20150812 09:38:31-!- irker065 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150812 09:59:59-!- Kwandulin [~Miranda@p5B008386.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150812 10:02:53-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 250 seconds]
20150812 10:37:01-!- genbattle_ [~genbattle@115-188-147-250.jetstream.xtra.co.nz] has quit [Ping timeout: 244 seconds]
20150812 10:41:51-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20150812 10:47:18-!- Kwandulin [~Miranda@p5B008386.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150812 10:49:06-!- mjs-de [~mjs-de@p508C9CB6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150812 11:25:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150812 11:26:53-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has joined #wesnoth-dev
20150812 11:58:36-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150812 12:01:38-!- prkc [~prkc@4E5CC75C.dsl.pool.telekom.hu] has joined #wesnoth-dev
20150812 12:09:09-!- Kwandulin [~Miranda@p5B008386.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150812 12:10:57-!- GGeneral [~GGeneral@nat3.opti.net.ua] has joined #wesnoth-dev
20150812 12:13:56-!- GGeneral [~GGeneral@nat3.opti.net.ua] has quit [Client Quit]
20150812 12:15:45-!- prkc [~prkc@4E5CC75C.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20150812 12:25:52-!- Jodoc [548b560c@gateway/web/freenode/ip.84.139.86.12] has joined #wesnoth-dev
20150812 12:26:08-!- Jodoc [548b560c@gateway/web/freenode/ip.84.139.86.12] has quit [Client Quit]
20150812 12:43:55-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20150812 12:48:12< aquileia> vultraz: Actually, sleepwalker created the nightblade because he didn't like that slayers are XP graves in SP. UtBS profited from it, but it wasn't his target
20150812 12:48:29< vultraz> Ah, I see
20150812 12:52:15-!- joet [~joet@host86-163-217-190.range86-163.btcentralplus.com] has quit [Remote host closed the connection]
20150812 12:57:29< aquileia> vultraz: https://github.com/wesnoth/wesnoth/blob/master/data/test/scenarios/feeding.cfg uses [terrain_mask], and you recently boasted about fixing masks
20150812 12:57:43< vultraz> I noticed. 
20150812 12:57:58< vultraz> Thing is, I did fix an issue with offset masks :/
20150812 12:58:20< vultraz> But something must have broken
20150812 13:02:31< aquileia> My money would be on [terrain_mask] x,y and [destination] x,y no longer matching (off by one due to different handling of the map border)
20150812 13:04:26< vultraz> Hmmm
20150812 13:05:27< vultraz> cfg_to_loc subs one from each location
20150812 13:06:03< vultraz> But it can't be that
20150812 13:09:05-!- Xara [~Yangyf@2401:de00:1:6:478:71b8:fe48:a227] has quit [Read error: Connection reset by peer]
20150812 13:13:25< vultraz> weird...
20150812 13:14:04< vultraz> That single hex mask block doesn't seem to work in a scenario :/
20150812 13:15:05-!- Kwandulin [~Miranda@p5B008386.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150812 13:23:46-!- joet [~joet@host86-163-217-190.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150812 13:45:40-!- mjs-de [~mjs-de@p508C9CB6.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20150812 14:09:18< wedge009> Oh dear, think I found a bug while testing something unrelated: attempting to add Ctrl-Enter (both for main keyboard or keypad) as a hotkey is detected as Ctrl-J, which results in an override warning as Ctrl-J is already used for Display Objectives by default.
20150812 14:12:43< wedge009> Shift-Enter and Alt-Enter are fine. Only Ctrl-Enter is detected incorrectly.
20150812 14:13:14-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has quit [Ping timeout: 250 seconds]
20150812 14:14:52-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150812 14:16:11-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150812 14:16:34< pydsigner> wedge009: That's... unusual
20150812 14:16:38-!- prkc [~prkc@4E5CC75C.dsl.pool.telekom.hu] has joined #wesnoth-dev
20150812 14:17:06< wedge009> I'll try to investigate it later.
20150812 14:17:27< wedge009> If I can't resolve it myself I'll make a proper bug report.
20150812 14:18:11< wedge009> If anyone else would like to confirm it, that'd be helpful. So I know it's not just something wrong with my build. (:
20150812 14:19:00-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 264 seconds]
20150812 14:20:33< pydsigner> wedge009: WUT
20150812 14:20:41< pydsigner> This is bizarre
20150812 14:21:05< pydsigner> What happens if you close Wesnoth and try again?
20150812 14:22:31< pydsigner> Hmm no that does nothing
20150812 14:22:47< pydsigner> wedge009: Ctrl-Enter becomes Ctrl-M for me
20150812 14:26:06-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150812 14:29:28-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150812 14:36:10-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150812 14:43:52-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has joined #wesnoth-dev
20150812 14:46:48-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150812 14:49:06< pydsigner> wedge009: So IDK what madness is going on with that
20150812 14:52:44-!- Appleman1234 [~Appleman1@KD106179122170.au-net.ne.jp] has joined #wesnoth-dev
20150812 14:53:03< Soliton> ctrl-m is CR or \r and ctrl-j is LF or \n, that's how ASCII is defined. probably depends on the OS whether enter is producing \r or \n. since either form already contains ctrl the ctrl from ctrl-enter is lost it seems.
20150812 14:56:36-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has quit [Ping timeout: 265 seconds]
20150812 14:59:02 * pydsigner just switched his keyboard to Dvorak cold-turkey
20150812 14:59:31-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150812 14:59:32< pydsigner> That last line took me 8-9 minutes to type ><
20150812 14:59:42< pydsigner> Soliton: You are brilliant
20150812 15:01:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20150812 15:06:02< pydsigner> Although I am on Linux so it's odd that I'm the one getting the CR
20150812 15:19:21-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20150812 15:23:19-!- Kwandulin [~Miranda@p5B008386.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150812 15:28:45-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150812 15:31:04< aquileia> loonycyborg: I'd like to use 7zip 15.06 for the update packages because it includes a bug fix, but the Unix port p7zip only has version 9.38 available... would that be a problem? I can easily work around that bug, so it's no big issue, but it doesn't hurt to ask
20150812 15:33:13< loonycyborg> hmm what does it have to do with unix port of 7z?
20150812 15:33:59< loonycyborg> I make the installer from my windows xp partition atm
20150812 15:34:14< aquileia> ah, ok
20150812 15:34:43< aquileia> I though you cross compile on Linux, that's why I asked
20150812 15:35:01< aquileia> *thought
20150812 15:37:41-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has joined #wesnoth-dev
20150812 15:42:12-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has quit [Ping timeout: 252 seconds]
20150812 15:45:30-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Ping timeout: 246 seconds]
20150812 15:56:46< loonycyborg> even on linux I doubt that nsis uses system p7zip
20150812 16:06:15-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 255 seconds]
20150812 16:10:43-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150812 16:11:05-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20150812 16:20:30-!- [Relic] [~Relic]@2602:306:33a3:6d30:ddd0:524:6799:3674] has joined #wesnoth-dev
20150812 16:28:59-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150812 16:29:47-!- Limabean [32f7e8e9@gateway/web/freenode/ip.50.247.232.233] has joined #wesnoth-dev
20150812 16:36:53-!- Limabean [32f7e8e9@gateway/web/freenode/ip.50.247.232.233] has quit [Quit: Page closed]
20150812 16:47:50-!- Appleman1234 [~Appleman1@KD106179122170.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20150812 16:57:53-!- afre [63f401a5@gateway/web/freenode/ip.99.244.1.165] has joined #wesnoth-dev
20150812 16:59:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150812 17:00:18-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has joined #wesnoth-dev
20150812 17:00:38< afre> In mp, my leader is named "Anonymous player 2". Shouldn't it be the player name?
20150812 17:00:53< afre> Not sure what I did.
20150812 17:01:15< Ravana_> that means when starting game you chose local player
20150812 17:01:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150812 17:05:38< zookeeper> boucman, you still alive? :p
20150812 17:05:46< boucman> hey
20150812 17:05:56< boucman> what's up ?
20150812 17:07:00< zookeeper> cool. in unit_animation.cpp, what's the point of the built-in default "poisoned" animation (in unit_animation::fill_initial_animations())? it doesn't seem like it ever gets played in any situation. or at least the sound doesn't.
20150812 17:07:19< boucman> old stuff :P
20150812 17:07:34< boucman> default animations are here to provide an animation when the animator doesn't
20150812 17:07:59< boucman> so the one for poison would be responsible for the green tint, I guess...
20150812 17:08:20< boucman> could you pastebin the relevant code (the one that builds up the animation)
20150812 17:09:06< afre> Ravana_: player isn't "local player".
20150812 17:09:21< zookeeper> https://github.com/wesnoth/wesnoth/blob/master/src/unit_animation.cpp#L592
20150812 17:09:48< Ravana_> afre: just like http://puu.sh/jyZKI/2de229ba2b.jpg
20150812 17:10:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150812 17:10:30< afre> Yes. But Ravana_ becomes Anonymous player #.
20150812 17:11:16< Ravana_> doesn't happen to me
20150812 17:11:20< zookeeper> boucman, the stuff on line 700 is related but i think not relevant
20150812 17:12:33< boucman> ok, so this creates a bunch of new animations, it basically add a variant of all animations with a green blinking effect
20150812 17:12:51< zookeeper> boucman, yeah but what about the sound? it never plays
20150812 17:13:06< boucman> so the animation is not to color green poisoned unit, it's to make units blink green when the "poisoned" event is triggered
20150812 17:13:13< boucman> so when they are split
20150812 17:13:14-!- Kwandulin [~Miranda@p5B008386.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150812 17:14:28< boucman> and I have no idea why it isn't played. however I note that line 594 is suspect
20150812 17:14:50< boucman> because the heal animations don't have the particle() call (it's around line 589)
20150812 17:15:02< boucman> I don't remember exactly what particle() does....
20150812 17:15:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150812 17:15:26< zookeeper> well, it's identical to how death anims are done around line 560, and they work
20150812 17:15:34< boucman> hmm
20150812 17:15:45< boucman> does the blink work ? does the sound file exist ?
20150812 17:16:24< zookeeper> the unit blinks, dunno if it's _that_ blink though, and yes, the sound file exists
20150812 17:16:37< boucman> if it blinks green then it's that blink
20150812 17:16:47< zookeeper> lines 593 and 561 have slightly different form though
20150812 17:17:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150812 17:17:56< boucman> I dunno, sorry
20150812 17:18:25< zookeeper> okay
20150812 17:21:59< zookeeper> anyway... what i'm trying to do is to finally allow the [slow] and [poison] etc specials to define their own sounds, and have them play at the right time. everything else is all nice and easy, but the animations play so independently from all other logic that passing that kind of information from the "unit gets hit" logic at attack.cpp to the animation system is very awkward.
20150812 17:24:36< afre> Ravana_: I deleted userdata but it's still the same. Oh well, it isn't a big deal - maybe an obscure bug.
20150812 17:24:44< zookeeper> i can easily play the sounds directly from attack::perform_hit(), but then they get played when the attack begins, not when it hits. and only the animation system knows when it hits, so... urgh
20150812 17:27:58< zookeeper> boucman, ah, that poisoned animation is surely for when the unit takes damage from poison at turn start
20150812 17:28:04< zookeeper> dunno why i didn't realize that
20150812 17:28:38< boucman> aaaah makes sense
20150812 17:29:37< zookeeper> and yeah, i checked, it's for that
20150812 17:29:38< boucman> zookeeper: got to go, but what you try to do is a specific case of attack animation when a unit is hit, not a new animation
20150812 17:29:45< boucman> ttyl
20150812 17:32:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150812 17:37:46-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 240 seconds]
20150812 17:38:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150812 17:38:20-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150812 17:45:12-!- afre [63f401a5@gateway/web/freenode/ip.99.244.1.165] has quit [Quit: Page closed]
20150812 17:51:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150812 17:54:32-!- N4tr0n_ [~N4tr0n@cpe-76-175-70-130.socal.res.rr.com] has joined #wesnoth-dev
20150812 17:58:56-!- N4tr0n_ [~N4tr0n@cpe-76-175-70-130.socal.res.rr.com] has quit [Ping timeout: 260 seconds]
20150812 18:00:33-!- Appleman1234 [~Appleman1@KD106179122170.au-net.ne.jp] has joined #wesnoth-dev
20150812 18:20:42-!- N4tr0n_ [~N4tr0n@162.255.34.90] has joined #wesnoth-dev
20150812 18:34:07< wedge009> pydsigner: Soliton: Good work, thanks for that. It makes sense to me. Now at least I know what to look for even if I'm not sure how to work around it just yet.
20150812 18:41:10< celticminstrel> The Quit to Desktop option in the editor needs a new shortcut.
20150812 18:41:22< celticminstrel> It's currently Shift-Cmd-Q, which the OS uses as "Log Out".
20150812 18:41:34< celticminstrel> (New default shortcut, I guess.)
20150812 18:43:31-!- Kwandulin [~Miranda@p5B008386.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150812 18:45:59< vultraz> What would you propose?
20150812 18:49:30< celticminstrel> Well, I just changed mine to Alt-Cmd-Q.
20150812 18:50:34< celticminstrel> Though Cmd-Q is best, but that's not possible at this time, I guess.
20150812 18:51:04< vultraz> Right, since that's just for Quit
20150812 18:52:22< pydsigner> Eh.
20150812 18:53:13< pydsigner> Quit needs to change.
20150812 18:53:38< vultraz> Wait, derp
20150812 18:53:51< vultraz> Esc does the same thing as Ctrl Q in-game
20150812 18:54:20< vultraz> For some reason, Ctrl Q is not shown as mapped to quit in the editor, yet works
20150812 18:54:26< vultraz> And Esc does not
20150812 18:54:40< vultraz> What is this wierdness
20150812 18:56:04< pydsigner> Quit needs to be renamed Exit to Game/Wesnoth
20150812 18:56:14< celticminstrel> Exit to Title?
20150812 18:56:23< celticminstrel> Maybe Quit to Title is fine.
20150812 18:57:30< pydsigner> Ah yes, that's much better
20150812 18:58:01-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20150812 19:00:19< vultraz> hotkey/command_executor.cpp:520 seems to handle the quit dialog in-game.
20150812 19:01:43< vultraz> editor/controller/editor_controller.cpp:202 handles it for the editor
20150812 19:02:32< vultraz> And there's something at hotkey/command_executor.cpp:695...
20150812 19:06:13< vultraz> celticminstrel, pydsigner: so, Quit Game -> Quit to Title?
20150812 19:10:37< pydsigner> Yes
20150812 19:11:50< vultraz> What about Quit to Menu
20150812 19:15:36< pydsigner> No
20150812 19:17:18< pydsigner> You could do Menu Screen/Titlescreen
20150812 19:20:37< vultraz> Quit to Titlescreen?
20150812 19:22:36-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 264 seconds]
20150812 19:23:02< pydsigner> Yeah
20150812 19:24:12 * vultraz wonders if that is standard industry terminology
20150812 19:27:52-!- iwaim [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20150812 19:28:20-!- c74d is now known as Guest91301
20150812 19:28:35-!- Guest91301 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20150812 19:28:45< pydsigner> Appears to possibly be
20150812 19:29:27-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150812 19:31:08< vultraz> What about Quit Editor
20150812 19:31:10< vultraz> Same treatment?
20150812 19:34:32< pydsigner> Ugh please don't do that
20150812 19:42:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150812 19:44:06< vultraz> pydsigner: no change to Quit Editor, then?
20150812 19:46:11< pydsigner> ...I think I got confused at some point here
20150812 19:47:20-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20150812 19:48:53< vultraz> pydsigner: I was asking whether both the Quit Game and Quit Editor menu items should be changed to Quit to Titlescreen
20150812 19:49:58-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150812 19:52:52< pydsigner> Oh. Yes.
20150812 19:52:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20150812 19:52:57-!- wedge010 is now known as wedge009
20150812 19:54:35< celticminstrel> Oh, yeah. Makes sense.
20150812 19:57:38-!- framling [~user@c-50-186-43-50.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20150812 20:00:56-!- irker508 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150812 20:00:56< irker508> wesnoth: Charles Dang wesnoth:master c35fb63472ba / data/themes/editor.cfg src/hotkey/hotkey_command.cpp: Rename Quit Game/Quit Editor menu items Quit to Titlescreen http://git.io/v324v
20150812 20:01:47< vultraz> Now to see if I can make Esc bring up the quit dialog in the editor too
20150812 20:01:55< vultraz> But I'll do that tomorrow
20150812 20:02:26< celticminstrel> I feel like there's a conflict in the editor between right-click-draw and right-click-context-menu.
20150812 20:12:57-!- ancestral [~ancestral@160.sub-70-197-201.myvzw.com] has joined #wesnoth-dev
20150812 20:14:28< irker508> wesnoth: Charles Dang wesnoth:master f2334507ae7e / src/editor/controller/editor_controller.cpp: Fixed Help browser not opening to correct section when accessed from editor http://git.io/v32uj
20150812 20:17:44-!- ancestral [~ancestral@160.sub-70-197-201.myvzw.com] has quit [Client Quit]
20150812 20:19:13-!- ancestral [~ancestral@173-8-126-226-Minnesota.hfc.comcastbusiness.net] has joined #wesnoth-dev
20150812 20:21:04-!- ancestral [~ancestral@173-8-126-226-Minnesota.hfc.comcastbusiness.net] has quit [Client Quit]
20150812 20:34:30-!- ancestral [~ancestral@209-253-20-121.ip.mcleodusa.net] has joined #wesnoth-dev
20150812 20:39:27-!- ancestral [~ancestral@209-253-20-121.ip.mcleodusa.net] has quit [Quit: i go nstuf kthxbai]
20150812 20:45:33< celticminstrel> Suggestion: Move handle_event_commands() from wml-tags.lua into the helper.lua library. It seems like it could be useful for people who want to implement custom WML tags.
20150812 20:49:02-!- travis-ci [~travis-ci@ec2-54-211-143-254.compute-1.amazonaws.com] has joined #wesnoth-dev
20150812 20:49:03< travis-ci> wesnoth/wesnoth#7023 (master - c35fb63 : Charles Dang): The build is still failing.
20150812 20:49:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/75331128
20150812 20:49:03-!- travis-ci [~travis-ci@ec2-54-211-143-254.compute-1.amazonaws.com] has left #wesnoth-dev []
20150812 20:49:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150812 20:52:12< celticminstrel> I now have a working [for] range-iteration tag with extra "sugar" for iterating through an array. It's not a foreach loop, but it can substitute for the FOREACH and REPEAT macros without any change to the code within the loop. (A true foreach would probably require some change to the code within the loop.)
20150812 20:52:34-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150812 20:53:22< celticminstrel> It's [for]array,variable=my_array,i or [for]count,variable=12,i (goes from 1 to 12) or [for]start,end,step,variable=0,10,2,i
20150812 20:55:07< celticminstrel> Oh wait, there's a [repeat] tag? I guess I can remove the count= form then.
20150812 20:55:23< celticminstrel> Or did I put that there?
20150812 20:55:28 * celticminstrel checks git diff.
20150812 20:56:14< celticminstrel> Well, I could however do the [repeat] tag instead of the count= form of [for], if that's preferred.
20150812 20:56:26< celticminstrel> Anyway, should I submit a pull request for this?
20150812 20:56:36< celticminstrel> (By the way, where's ancestral gotten to?)
20150812 20:58:47< celticminstrel> I mean, is this something that people would want?
20150812 20:59:41< celticminstrel> It doesn't preclude the possibility of adding a real foreach loop later.
20150812 21:12:35< zookeeper> yeah, i'd certainly not suggest mixing two different kinds of looping in the same tag
20150812 21:13:05< celticminstrel> So you'd prefer separate [for] and [repeat]?
20150812 21:13:35< zookeeper> yes
20150812 21:13:52< celticminstrel> The [for]array=thing notation is just a shorthand for [for]start,end=0,$($array.length-1).
20150812 21:14:00< zookeeper> so can you remove an element from the array in [for]?
20150812 21:14:11< celticminstrel> Yes.
20150812 21:14:24< celticminstrel> With all the expected dangers, side-effects, etc.
20150812 21:14:27< zookeeper> oh? that's good
20150812 21:14:37< zookeeper> oh and it should definitely be called [foreach], IMO
20150812 21:15:00< celticminstrel> It's intended to be a for-range, not a foreach.
20150812 21:15:05-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20150812 21:15:28< celticminstrel> In lua terms, it's "for i = start, finish" rather than "for i in iterator".
20150812 21:15:30< zookeeper> well [for]array,variable=my_array,i is certainly a foreach
20150812 21:15:53< celticminstrel> Only sort of.
20150812 21:16:45< celticminstrel> The index variable can be changed in the loop, and it will continue from that point.
20150812 21:17:14< celticminstrel> And you have to access the array by index; you don't have a variable that contains the actual element.
20150812 21:22:08< pydsigner> We still need a real for-each
20150812 21:22:38< celticminstrel> That's pretty much why I didn't call this foreach.
20150812 21:23:12< celticminstrel> I think Elvish_Hunter's foreach is probably a good starting point, but maybe it needs some improvement..
20150812 21:27:12< Aginor> lipkab: hello
20150812 21:37:44< lipkab> Aginor: Hi.
20150812 21:40:31< Aginor> lipkab: got time for a sdl-related chat?
20150812 21:40:45< lipkab> Yep.
20150812 21:41:17< Aginor> sweet
20150812 21:43:33< Aginor> I had a look at a number of the compile warnings in the SDL2 codepath
20150812 21:44:14< Aginor> and noticed that there's a lot of size_t used in the gui2 code
20150812 21:44:38< Aginor> would it be acceptable to go and replace these with ints?
20150812 21:45:37-!- afre [63f401a5@gateway/web/freenode/ip.99.244.1.165] has joined #wesnoth-dev
20150812 21:46:12< celticminstrel> The campaign server IP address seems to be outdated in the FAQ. It should be the same as I get from pinging addons.wesnoth.org, right?
20150812 21:47:34< lipkab> This question is a bit too broad for a decisive answer.
20150812 21:47:47< celticminstrel> Aginor: No.
20150812 21:47:56< celticminstrel> size_t is unsigned, int is signed.
20150812 21:48:04< Aginor> celticminstrel: yes...
20150812 21:48:24< celticminstrel> Also, I believe size_t is typically unsigned long.
20150812 21:48:33< Aginor> celticminstrel: size_t is also architecture dependant
20150812 21:48:36< celticminstrel> But why would you want to replace them?
20150812 21:48:52< celticminstrel> int is also architecture dependent.
20150812 21:49:04< celticminstrel> And unsigned int.
20150812 21:49:06< Aginor> it is, I'm not disputing that
20150812 21:49:31< celticminstrel> So why do you want to replace them?
20150812 21:49:43< Aginor> anyhow, SDL uses ints for all graphics stuff
20150812 21:49:43-!- louis94 [~louis@91.178.51.139] has joined #wesnoth-dev
20150812 21:49:48-!- louis94 [~louis@91.178.51.139] has quit [Quit: Konversation terminated!]
20150812 21:49:59< celticminstrel> And?
20150812 21:50:10< Aginor> gui2 usies unsigned ints for some coordinate stuff
20150812 21:50:11< lipkab> GUI2 was written by mordante and he definitely knows his craft so I'm inclined to think that he used size_t for a reason.
20150812 21:50:53< celticminstrel> Oh, so I suppose the issue is that you're getting warnings about converting from unsigned to signed?
20150812 21:51:13< Aginor> celticminstrel: that's the reason I started to look at it
20150812 21:51:21-!- louis94 [~louis@91.178.51.139] has joined #wesnoth-dev
20150812 21:51:39< Aginor> but it seems that what's happening is that ints are converted to unsigned, then back to ints
20150812 21:51:40< celticminstrel> Do you have a reason not to use casts?
20150812 21:51:46< celticminstrel> Oh.
20150812 21:51:52< celticminstrel> Interesting.
20150812 21:52:11< Aginor> SDL->GUI2->SDL
20150812 21:52:14< celticminstrel> I think that's a lossless conversion path though.
20150812 21:53:00< celticminstrel> Also seems kind of silly, because then SDL and GU2 can interpret the same values differently.
20150812 21:53:00< lipkab> If it's indeed the case, then sure, it makes sense to replace size_t.
20150812 21:53:14< afre> zookeeper: I just reinstalled Wesnoth 1.13.1. The title screen map on wood looks good on 1024x768 (4:3), so I think it only looks awkward in perspective when the map doesn't fill the window / fullscreen. Btw I noticed that wesnoth (win7) keeps different settings for windowed and fullscreen res. Is that supposed to be the case?
20150812 21:53:41< Aginor> celticminstrel: it is, I see it as a place where bugs can happen
20150812 21:53:58 * celticminstrel nods.
20150812 21:54:23< shadowm> celticminstrel: It's not always lossless on x86_64.
20150812 21:54:49< shadowm> sizeof(int) < sizeof(size_t).
20150812 21:54:52< lipkab> IIRC some stuff changed from unsigned to signed and vice versa in SDL2, so that might be the reason for the warnings.
20150812 21:54:53< Aginor> which is why I am inclined to replace it
20150812 21:54:53< celticminstrel> It is if it's int -> unsigned int -> unt, but yeah, not for size_t in place of unsigned int.
20150812 21:55:29< celticminstrel> Maybe use SDL's fixed-width types if applicable (eg Uint32).
20150812 21:55:48< celticminstrel> Wait, without the U - Int32.
20150812 21:56:08< celticminstrel> I think that exists? My SDL is rusty.
20150812 21:56:40< zookeeper> afre, umm, i don't know.
20150812 21:57:04< Aginor> celticminstrel: I think it makes the most sense with ints, wesnoth doesn't need the extra space for coordinates
20150812 21:57:22< celticminstrel>  I meant more using the same spelling for the type that SDL uses.
20150812 21:57:27< Aginor> incidentially, it also stops gui2 from doing partial off-screen rendering
20150812 21:58:00< lipkab> Yeah, apparently SDL_Rect's w and h went Uint16 -> int.
20150812 21:58:55< lipkab> Aginor: Conclusively, it's okay with me just check if you don't break SDL1.2 stuff in the process.
20150812 21:58:57< Aginor> and using ints instead would e safe
20150812 21:59:12< Aginor> lipkab: of course ;)
20150812 21:59:18< Aginor> celticminstrel: and you?
20150812 21:59:49< celticminstrel> I have no problem with it?
20150812 22:00:00-!- Appleman1234 [~Appleman1@KD106179122170.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20150812 22:01:15< Aginor> good
20150812 22:01:48< Aginor> just wanted to make sure you were happy as well as you had concerns
20150812 22:02:50< Aginor> I'm assuming modante isn't around so I can chat to him?
20150812 22:03:02< shadowm> He's MIA.
20150812 22:03:14< afre> zookeeper: Just didn't expect that behaviour when Ctrl+F-ing. I recall Wesnoth automatically selecting the highest res on fullscreen after fresh install.
20150812 22:03:19< Aginor> fair enough
20150812 22:07:07< Aginor> lipkab: did you notice any scrolling related issues with SDL2?
20150812 22:09:57< lipkab> Aginor: Yes. I actually spent days investigating that bug last summer... with no success.
20150812 22:10:41< lipkab> It's freaking mysterious how it only affects scrolling in certain direction.
20150812 22:10:56< lipkab> *in a
20150812 22:11:02< celticminstrel> Which direction?
20150812 22:11:06< Aginor> lipkab: ok, I think that also answers my follow-on question
20150812 22:11:09< Aginor> celticminstrel: up
20150812 22:11:11< lipkab> Up
20150812 22:12:04< Aginor> lipkab: I suspect there's an issue with the calculations
20150812 22:12:46< lipkab> My assumption was that that Wesnoth tries to draw off the screen limits and SDL2 doesn't tolerate that like SDL1.2.
20150812 22:12:55< lipkab> But that was confirmed wrong.
20150812 22:13:15< Aginor> I'll start looking at it in the next few days, I'm recovering from surgery at the moment so I haven't been able to sit at my workstation
20150812 22:16:01< lipkab> Okay, get healthy :) (or whatever English speakers say to sick people)
20150812 22:16:23< Aginor> "get well" is what I keep hearing :)
20150812 22:16:41< Aginor> not that I'm a native speaker myself
20150812 22:17:15< afre> Get well soon.
20150812 22:17:30< Aginor> thanks
20150812 22:18:21< lipkab> Meh, I'll just say 'jobbulást'. Google will translate it for you :P
20150812 22:18:52< Aginor> thanks
20150812 22:19:03< Aginor> you're from Hungary?
20150812 22:19:20< lipkab> Yes.
20150812 22:19:27< afre> Google says "betterment".
20150812 22:19:38< Aginor> fair enough
20150812 22:19:49< Aginor> I live in New Zealand myself
20150812 22:20:01< celticminstrel> "get well" is normal.
20150812 22:20:29< celticminstrel> I seem to be missing something to get a multiplayer scenario from showing in the list.
20150812 22:21:19< afre> Is --log-debug= the best way to report crashes? Is there a reference for such commands?
20150812 22:22:47-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150812 22:23:21< lipkab> Aginor: Is there anything else you want to talk about?
20150812 22:23:53< Aginor> lipkab: no, I primarily wanted to hear you opinions about the size_t in gui2
20150812 22:23:56< Aginor> thank you
20150812 22:24:10< lipkab> Ok, then I'm off. Bye all.
20150812 22:24:12-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has quit [Quit: Leaving]
20150812 22:29:18< afre> I loaded an ai from an old (1.11) add-on and Wesnoth crashed.
20150812 22:29:39< celticminstrel> Heh.
20150812 22:38:54< Aginor> shadowm: has anyone thought about including a cross-platform crash reporter like google-crashpad into wesnoth?
20150812 22:39:10< Aginor> google-breakpad even
20150812 22:40:48< celticminstrel> :inspect shows advances_to="Elvish Druid Elvish Sorceress" instead of advances_to="Elvish Druid,Elvish Sorceress".
20150812 22:41:12< celticminstrel> (In 1.13, this has changed from 1.12.)
20150812 22:43:21< Ravana_> looks correct to me, however font seems strange
20150812 22:43:38< celticminstrel> It shows with a comma for you?
20150812 22:43:45< Ravana_> yes
20150812 22:43:47< celticminstrel> Huh.
20150812 22:43:56< celticminstrel> Font is a bit big, yes.
20150812 22:45:24< Ravana_> new font is improvement still, just need to get used to it
20150812 22:45:39< vultraz> 1.13 inspect uses monospace
20150812 22:45:52< celticminstrel> That's a good thing.
20150812 22:47:47< celticminstrel> Oh, I just noticed the zoom bar was removed altogether.
20150812 22:48:33< celticminstrel> There's definitely a missing comma in :inspect in my build, but I guess it's just a display bug.
20150812 22:48:55< celticminstrel> Maybe the glyph is missing.
20150812 22:49:47< celticminstrel> Anyway, I have just confirmed that my [effect]apply_to=advances_to works.
20150812 22:49:53< Ravana_> 1.13 sidebar is so narrow
20150812 22:51:27-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150812 22:52:07< shadowm> Aginor: Not really.
20150812 22:52:09< celticminstrel> I can't use the Lua console.
20150812 22:52:20< celticminstrel> It's so slow that it drops keystrokes sometimes.
20150812 22:52:26< shadowm> What do you mean, where did the zoom bar go?
20150812 22:52:40< vultraz> The zoom bar is still here
20150812 22:52:57< celticminstrel> I don't see it?
20150812 22:52:57< vultraz> Unless you have a lower resolution than an arbitrary number I can't recall
20150812 22:53:03< vultraz> Then I believe it goes away
20150812 22:53:07< shadowm> The window has to be 768 px tall or more.
20150812 22:53:11< celticminstrel> I'm using whatever the default is.
20150812 22:53:13< shadowm> SAme as in 1.12.
20150812 22:53:14< celticminstrel> Maybe that's why.
20150812 22:53:23< vultraz> You don't maximize?
20150812 22:53:34< celticminstrel> In 1.12 I enlarged it, but I didn't bother (yet) in 1.13.
20150812 22:54:25< Aginor> shadowm: it would facilitate collecting crash logs when they happen, wich in turn would (eventually) lead to stability improvements
20150812 22:54:28< shadowm> I don't maximize either, I just run with a 1440x768 window.
20150812 22:55:06 * vultraz runs maximized at 1600x837
20150812 22:55:21< shadowm> I usually want to at least keep my IRC client visible.
20150812 22:55:34< vultraz> And tab over to IRC
20150812 22:55:37< shadowm> Often the console too.
20150812 22:56:14< Ravana_> 1110x769 has no zoom bar at least
20150812 22:56:34< shadowm> Your window decoration must be taking up space.
20150812 22:58:34< Ravana_> 1159x798 hasnt either, and with 1.12 with 1157x793 it has
20150812 23:00:03< shadowm> http://i.imgur.com/39TC8o3.jpg
20150812 23:00:58< Ravana_> ah I see
20150812 23:01:02< Ravana_> it was different theme
20150812 23:02:27< afre> shadowm: so what can I do when wesnoth crashes? I'm trying out the Nightmares_of_Meloen add-on (from 1.11) I talked about earlier. When I load it's custom ai, it crashes.
20150812 23:05:22< shadowm> You should file a bug report specifying the add-on and scenario that causes the crash. Bonus points if you can isolate the offending code.
20150812 23:06:02< shadowm> You can use either the Technical Support forum or (preferably so it doesn't get forgotten) bugs.wesnoth.org .
20150812 23:08:16< afre> shadowm: Makes sense. It's currently unmaintained so will anyone provide support?
20150812 23:09:44< afre> shadowm: so gna bug reporting also accepts non-mainline stuff like add-ons?
20150812 23:10:01< shadowm> afre: We can't fix the add-on, no, but we can make Wesnoth stop crashing.
20150812 23:10:59< shadowm> WML in general should never be able to crash Wesnoth. If the game crashes then it's a bug in the game no matter whether it's add-on or mainline content.
20150812 23:11:21< Ravana_> does formula= fall under wml?
20150812 23:11:30< celticminstrel> Why wouldn't it?
20150812 23:11:45< shadowm> WML, Lua, etc., doesn't matter.
20150812 23:11:50< celticminstrel> Or you mean the evaluation of the formula?
20150812 23:12:09< Ravana_> formula= is just most reliable way I know to make wesnoth crash
20150812 23:12:28-!- Appleman1234 [~Appleman1@KD106179118044.au-net.ne.jp] has joined #wesnoth-dev
20150812 23:14:09< Ravana_> however from what I have heard it is not really maintained anymore, so drawing too much attention to it might just make it removed, and despite error->crash it is nevertheless quite useful
20150812 23:14:38< shadowm> I'd not approve its removal.
20150812 23:14:41-!- irker508 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150812 23:15:58< shadowm> Formula AI's removal? Yes, but not the formula engine or vconfig formula evaluation. Furthermore, GUI2 also makes use of the formula engine.
20150812 23:15:58< afre> shadowm: thanks for teaching me stuff.
20150812 23:17:23-!- prkc [~prkc@4E5CC75C.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20150812 23:17:33< celticminstrel> Speaking of vconfig formula evaluation, I wonder if it can be made to be smarter in the event of + so that it doesn't need to be quoted.
20150812 23:18:09< shadowm> Not really, because it's the preprocessor that's getting in the way.
20150812 23:19:05< shadowm> s/preprocessor/parser/
20150812 23:19:28< celticminstrel> Hmm.
20150812 23:19:39< celticminstrel> So the parser just blindly splits on +?
20150812 23:19:50< celticminstrel> And I suppose there's not really any reason to make the parser aware of $().
20150812 23:19:59< celticminstrel> Since it's only valid in ActionWML, right?
20150812 23:20:08< shadowm> + has a very specific meaning to the parser, concatenating strings.
20150812 23:20:10< celticminstrel> Oh, that's not true, it's valid in some other places too.
20150812 23:20:23< celticminstrel> Like abilities.
20150812 23:20:59< celticminstrel> The point is that the vconfig isn't a part of the basic WML syntax, but rather an aspect of how the engine uses the data.
20150812 23:21:12< shadowm> Exactly.
20150812 23:21:27< celticminstrel> I suppose the only good way to fix it would be to make the parser use something else instead of +.
20150812 23:21:31< celticminstrel> Which would break everything.
20150812 23:21:38< celticminstrel> So probably won't happen.
20150812 23:22:32< shadowm> Or it could handle $() as a *hint* to treat + specially, although academics would consider that bad form (insert generic rant of how WML should be replaced with something else here).
20150812 23:30:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20150812 23:40:53-!- louis94 [~louis@91.178.51.139] has quit [Quit: Konversation terminated!]
20150812 23:44:56< afre> shadowm: my first bug report. Wasn't so hard :) - let me know if it's ok or I need to do something different. https://gna.org/bugs/index.php?23780
20150812 23:46:43< Ravana_> you can include its stderr too, I got http://pastebin.com/hnNELJM4 with that
20150812 23:49:08< Ravana_> though it might be better to get 1.11 addon work with 1.12 before looking for 1.13...
20150812 23:49:14-!- Appleman1234 [~Appleman1@KD106179118044.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20150812 23:55:39< vultraz> I highly recommend not trying to target 1.13 at the moment
20150812 23:56:25< vultraz> It's a bit of a mess
--- Log closed Thu Aug 13 00:00:58 2015