--- Log opened Thu Aug 20 00:00:25 2015
--- Day changed Thu Aug 20 2015
20150820 00:00:25< shadowm> Aginor: You mean remove_if?
20150820 00:01:34< Aginor> shadowm: yes
20150820 00:02:26< shadowm> That's not how that's usually used IIRC.
20150820 00:02:51< Aginor> shadowm: could you please elaborate?
20150820 00:03:48-!- gandaro [~gandaro@wikipedia/Gorlingor] has quit [Quit: Leaving]
20150820 00:04:05< shadowm> That'll delete the elements from the beginning of myvector until the end of the deleted elements range.
20150820 00:04:19< shadowm> The end of the removed elements range, I mean.
20150820 00:04:26< Aginor> yes
20150820 00:04:38< Aginor> it's backwards from what I expect as well
20150820 00:05:15< Aginor> http://stackoverflow.com/questions/7958216/c-remove-if-on-a-vector-of-objects
20150820 00:05:51< shadowm> Uh, the start of the removed elements range I mean.
20150820 00:06:11< Aginor> I follow :)
20150820 00:06:24< shadowm> As in [begin(), first_removed_element) rather than [first_removed_element, end()) which is what you usually want.
20150820 00:06:32< celticminstrel> In other words, the elements you don't want removed.
20150820 00:06:58< Aginor> I was erasing from myvec.begin() to remove_if_it, and that deleted everything I wanted to keep
20150820 00:07:25< Aginor> it's backwards from what I expect, and I don't quite understand why
20150820 00:08:23< celticminstrel> myvector.erase(std::remove_if(myvector.begin(), myvector.end(), predicate), myvector.end()
20150820 00:08:38< Aginor> that ate all my elements
20150820 00:08:53< celticminstrel> Missed a );
20150820 00:08:58-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150820 00:09:15< shadowm> It shouldn't unless the predicate is wrong.
20150820 00:09:42< celticminstrel> Based on the documentation, that's the correct usage.
20150820 00:10:05< Aginor> I've verified my predicate as well
20150820 00:10:24< Aginor> which is why I'm a bit surprised
20150820 00:12:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 252 seconds]
20150820 00:13:00-!- wedge010 is now known as wedge009
20150820 00:18:27< shadowm> Aginor: http://pastebin.com/fybu3t3s
20150820 00:19:00< Aginor> thanks
20150820 00:19:06< Aginor> I've done similar things
20150820 00:19:53 * Aginor hmmms
20150820 00:21:13< Aginor> 	hotkeys_.erase(std::remove_if(
20150820 00:21:14< Aginor> 					hotkeys_.begin(), hotkeys_.end(),
20150820 00:21:14< Aginor> 					predicate(item)
20150820 00:21:14< Aginor> 				//	boost::bind(&hotkey_base::bindings_equal, _1, (item))
20150820 00:21:14< Aginor> 			), hotkeys_.end()
20150820 00:21:16< Aginor> 	);
20150820 00:21:51< Aginor> predicate is a class that I've added extra debugging into, but it ultimately invokes bindings_equal
20150820 00:25:32-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150820 00:25:45< Aginor> anyhow, that's working now
20150820 00:26:59< Aginor> it is however weening out duplicates too well, I need to take contexts into account
20150820 00:27:31< shadowm> I can't find that bindings_equal in the current source.
20150820 00:28:07< Aginor> it might be new
20150820 00:28:26< shadowm> You should know that. :p
20150820 00:28:40< Aginor> I might have defined a hotkey_base, hotkey_keyboard, hotkey_mouse class
20150820 00:29:06< Aginor> added a design pattern or two into the code
20150820 00:31:22< Aginor> anyhow, I should be able to get a version ready for review today
20150820 00:50:44-!- Appleman1234 [~Appleman1@KD036012029140.au-net.ne.jp] has quit [Ping timeout: 272 seconds]
20150820 00:52:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150820 01:00:32< Aginor> right, everything seems to be working
20150820 01:02:14< Aginor> now to tidy up and make a PR
20150820 01:03:59-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20150820 01:10:48-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150820 01:15:54< Aginor> shadowm: doxygen is the preffered documentation format?
20150820 01:20:38< shadowm> Aginor: Yes.
20150820 01:20:55< Aginor> sweet, thanks
20150820 01:27:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20150820 01:27:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20150820 01:35:01-!- diriel [~diriel@74.197.206.4] has joined #wesnoth-dev
20150820 01:42:47-!- diriel [~diriel@74.197.206.4] has quit [Quit: Leaving]
20150820 01:45:54< vultraz> shadowm: if we move to text dynamically overlaid over logo, won't we need to drop the titlescreen logo prograssbar hack?
20150820 01:47:15< shadowm> The shield can become static while the text becomes the progress bar.
20150820 01:47:52-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20150820 01:47:55-!- Appleman1234 [~Appleman1@KD036012013047.au-net.ne.jp] has joined #wesnoth-dev
20150820 01:48:16-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20150820 01:48:49< vultraz> Ok
20150820 01:55:08< vultraz> Hmmm
20150820 01:55:18< vultraz> The logo canvas should not be bigger than 440
20150820 01:55:22< vultraz> I'm guessing
20150820 02:07:39-!- louis94 [~~louis94@91.178.27.233] has quit [Quit: Konversation terminated!]
20150820 02:10:14-!- sailorswift [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150820 02:11:40-!- midzer [~quassel@p4FFCE1F9.dip0.t-ipconnect.de] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
20150820 02:14:35-!- Portaljacker [~Portaljac@modemcable081.139-178-173.mc.videotron.ca] has joined #wesnoth-dev
20150820 02:14:49-!- Portaljacker [~Portaljac@modemcable081.139-178-173.mc.videotron.ca] has quit [Remote host closed the connection]
20150820 02:22:25-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 252 seconds]
20150820 02:22:32< vultraz> ughh
20150820 02:22:39< vultraz> first I get the text on the top of the screen
20150820 02:22:45< vultraz> now it's in the middle of the screen
20150820 02:22:49< vultraz> damn you gui2 ._.
20150820 02:32:52-!- chaverma [~Adium@208.66.31.146] has joined #wesnoth-dev
20150820 02:43:20< vultraz> got it
20150820 02:45:10-!- chaverma [~Adium@208.66.31.146] has quit [Quit: Leaving.]
20150820 02:46:01< vultraz> Now to deal with the loadscreen
20150820 02:48:03< vultraz> yay for ~BLIT
20150820 02:51:17< Aginor> hmm
20150820 02:51:27< Aginor> keybindings are working perfectly
20150820 02:51:31< vultraz> :D
20150820 02:51:32< Aginor> documentation is half done
20150820 02:51:42< Aginor> but I can't seem to select and move units :D
20150820 02:52:11< Aginor> so one more bug to squish before there can be a PR
20150820 02:59:23< irker106> wesnoth: Charles Dang wesnoth:master 9f6935da3f13 / data/core/images/misc/logo.png: Removed unused copy of logo from core http://git.io/vsZk1
20150820 02:59:26< irker106> wesnoth: Charles Dang wesnoth:master f1256049fdab / images/misc/ (logo-bg.png logo.png): New style logo text by Sgt. groovy (English) http://git.io/vsZkM
20150820 02:59:29< irker106> wesnoth: Charles Dang wesnoth:master f7f497566f8b / data/core/help.cfg data/gui/default/window/title_screen.cfg src/loadscreen.cpp: Update API to work with the new two layer logo http://git.io/vsZkD
20150820 03:00:52< vultraz> The art train is really rolling through today
20150820 03:01:03< Aginor> woot, woot
20150820 03:04:21< pydsigner> Yay
20150820 03:08:05< celticminstrel> New logo is nice.
20150820 03:08:34< vultraz> ikr
20150820 03:15:01< irker106> wesnoth: Charles Dang wesnoth:master bb8fcc8d4990 / src/addon/manager_ui.cpp: Be less polite in invalid-image-on-upload warning http://git.io/vsZLN
20150820 03:31:11-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150820 03:35:28-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 246 seconds]
20150820 03:35:43-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20150820 03:36:28-!- framling [~user@c-50-186-43-50.hsd1.or.comcast.net] has joined #wesnoth-dev
20150820 03:39:05-!- chaverma [~Adium@208.66.31.146] has joined #wesnoth-dev
20150820 03:39:34-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20150820 03:41:19-!- chaverma1 [~Adium@208.66.31.146] has joined #wesnoth-dev
20150820 03:41:50-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150820 03:43:45-!- chaverma [~Adium@208.66.31.146] has quit [Ping timeout: 255 seconds]
20150820 03:46:37-!- chaverma1 [~Adium@208.66.31.146] has quit [Quit: Leaving.]
20150820 03:51:45< shadowm> vultraz: What API?
20150820 03:52:22< vultraz> What should I have said instead
20150820 03:52:53< shadowm> vultraz: What API?
20150820 03:53:08< shadowm> Answer that question and then I can decide whether yours applies or not.
20150820 03:53:19< vultraz> The logo drawing.
20150820 03:53:29< shadowm> We have a logo drawing API?
20150820 03:53:50< vultraz> I guess not, since it's done differently in three places
20150820 03:54:35< shadowm> You should have said something else instead then.
20150820 04:00:32-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 246 seconds]
20150820 04:02:19< vultraz> Well, anyway, the text really does look great
20150820 04:02:49-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150820 04:03:13< vultraz> I wrote to LB to ask him about the small-size portrait
20150820 04:03:15< vultraz> er
20150820 04:03:17< vultraz> storyscreen
20150820 04:16:25< irker106> wesnoth: Charles Dang wesnoth:master 0103c40c8408 / data/core/images/misc/l10n/ (14 files in 14 dirs): Removed orphaned (as of 9f6935da3f13) logo translations from core http://git.io/vsZCB
20150820 04:16:31-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 260 seconds]
20150820 04:21:01-!- oldlaptop [~quassel@50-107-94-87.adr02.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20150820 04:41:57-!- Kwandulin [~Miranda@p5B008916.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150820 04:49:04-!- oldlaptop [~quassel@50-107-94-87.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150820 04:58:08-!- Shackra [~Jorge@186.177.2.148] has quit [Remote host closed the connection]
20150820 05:04:12-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150820 05:08:09-!- genbattle [~genbattle@182.16.153.90] has quit [Ping timeout: 252 seconds]
20150820 05:20:34-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150820 05:37:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20150820 05:38:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20150820 05:41:05-!- Shackra [~Jorge@186.177.2.148] has quit [Remote host closed the connection]
20150820 05:55:31-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20150820 06:08:59-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 260 seconds]
20150820 06:14:40-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150820 06:24:02-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150820 06:27:49-!- [Relic] [~Relic]@2602:306:33a3:6d30:f589:5a37:4719:9337] has quit [Quit: I press the magic X and all the weirdos go away!]
20150820 06:33:56-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150820 06:44:00-!- Kwandulin [~Miranda@p5B008916.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150820 07:00:17-!- Appleman1234 [~Appleman1@KD036012013047.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20150820 07:24:22-!- mjs-de [~mjs-de@x4db6aa95.dyn.telefonica.de] has joined #wesnoth-dev
20150820 07:45:12-!- jcnewjersey [~jcnewjers@pool-108-35-38-39.nwrknj.fios.verizon.net] has quit [Read error: Connection reset by peer]
20150820 07:57:11-!- Appleman1234 [~Appleman1@KD036012012215.au-net.ne.jp] has joined #wesnoth-dev
20150820 07:59:01< wedge009> Aginor: Progress sounds good. Even if there are issues it must surely be better than the mess we currently have with SDL 1.2 (and even more so with SDL 2.0!).
20150820 08:00:28-!- Kwandulin [~Miranda@p5B008916.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150820 08:00:36< wedge009> Aginor: Regarding the Windows tray notification issue, I've documented the details in my PR. But the short version is that the tray icon will not disappear if there are two or more notifications that come together. I think it's a relatively minor problem but it's still a regression from the regular SDL 1.2 build.
20150820 08:00:55< vultraz> Hmmm... Groovy recommended a 600w canvas for the logos not 440 but 600 causes a crash on the titlescreen 
20150820 08:01:59< shadowm> That means you are not adjusting the layout accordingly.
20150820 08:02:04-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150820 08:02:37< Aginor> hmm
20150820 08:02:39< shadowm> Whatever you do, remember you must test on 800x480, 800x600, and 1024x768.
20150820 08:02:45< Aginor> I really need to get windows developement set up
20150820 08:04:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150820 08:11:30-!- sailorswift [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has quit [Ping timeout: 255 seconds]
20150820 08:26:56< shadowm> http://i.imgur.com/XEnCMta.png
20150820 08:27:58< shadowm> http://i.imgur.com/jRgPK76.png
20150820 08:29:03< vultraz> so I found the game will not crash with a logo canvas of 600 if you change the progress bar to a image
20150820 08:29:06< vultraz> Hmm.
20150820 08:29:42< vultraz> Weird
20150820 08:30:55< vultraz> ahhh got it
20150820 08:31:11< vultraz> the special progress bar definition params 
20150820 08:40:33< irker106> wesnoth: Charles Dang wesnoth:master f808f3d737db / data/gui/default/widget/progress_bar_title_screen.cfg: Increased width params of titlescreen progress bar definition to 600 http://git.io/vsn3Z
20150820 08:40:35< irker106> wesnoth: Charles Dang wesnoth:master 6e0af4f77ed4 / images/misc/ (logo-bg.png logo.png): Increased canvas size of English logo and logo bg to 600 (was 440) http://git.io/vsn3n
20150820 08:41:41< vultraz> All is good
20150820 08:42:59-!- gandaro [~gandaro@wikipedia/Gorlingor] has joined #wesnoth-dev
20150820 09:03:52-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20150820 09:04:50< aquileia> Aginor: If you want to use MSVC, the instructions are here: http://wiki.wesnoth.org/CompilingWesnothOnWindows#Visual_Studio
20150820 09:05:22< Aginor> thanks aquileia 
20150820 09:06:03< Aginor> some of it is just pure inertia :)
20150820 09:06:32< aquileia> Which reminds me that I should update the dependencies & project file for the SDL2 configuration... "Debug (SDL2)" and "Release (SDL2)" should be enough, right?
20150820 09:06:40< irker106> wesnoth: Ignacio R. Morelle wesnoth:master 636cc6315fcf / changelog src/gui/dialogs/gamestate_inspector.cpp: gui2/tgamestate_inspector: Add views for event and menu item handlers http://git.io/vsnWb
20150820 09:07:00< Aginor> aquileia: yes, you obviously need the SDL2 version of the SDL* libraries too
20150820 09:07:44 * Aginor is writing up the pull request for the hokey rewrite
20150820 09:07:53-!- Kwandulin [~Miranda@p5B008916.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150820 09:09:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150820 09:10:05-!- zookeeper_ [~lmsnie@37.35.26.74] has joined #wesnoth-dev
20150820 09:10:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Disconnected by services]
20150820 09:10:14-!- zookeeper_ is now known as zookeeper
20150820 09:10:16-!- zookeeper [~lmsnie@37.35.26.74] has quit [Changing host]
20150820 09:10:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150820 09:17:59-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 250 seconds]
20150820 09:20:07-!- travis-ci [~travis-ci@ec2-54-227-15-154.compute-1.amazonaws.com] has joined #wesnoth-dev
20150820 09:20:08< travis-ci> wesnoth/wesnoth#7132 (master - 6e0af4f : Charles Dang): The build has errored.
20150820 09:20:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/76422435
20150820 09:20:08-!- travis-ci [~travis-ci@ec2-54-227-15-154.compute-1.amazonaws.com] has left #wesnoth-dev []
20150820 09:20:51-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20150820 09:36:48-!- Kwandulin [~Miranda@p5B008916.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150820 09:43:02< zookeeper> celticminstrel, what could [effect]apply_to=attacks_left possibly be used for?
20150820 09:52:37-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150820 09:53:59-!- haha [c5d3dc2a@gateway/web/freenode/ip.197.211.220.42] has joined #wesnoth-dev
20150820 09:54:22-!- haha is now known as Guest39381
20150820 09:55:10-!- Guest39381 [c5d3dc2a@gateway/web/freenode/ip.197.211.220.42] has quit [Client Quit]
20150820 09:59:28-!- travis-ci [~travis-ci@ec2-54-234-198-234.compute-1.amazonaws.com] has joined #wesnoth-dev
20150820 09:59:29< travis-ci> wesnoth/wesnoth#7133 (master - 636cc63 : Ignacio R. Morelle): The build was broken.
20150820 09:59:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/76425405
20150820 09:59:29-!- travis-ci [~travis-ci@ec2-54-234-198-234.compute-1.amazonaws.com] has left #wesnoth-dev []
20150820 10:05:43-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 246 seconds]
20150820 10:14:17-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Quit: Page closed]
20150820 10:22:17< Aginor> https://github.com/wesnoth/wesnoth/pull/466 <-- I'm soliciting both code review and testing!
20150820 10:26:18< Aginor> shadowm, wedge009" ^
20150820 10:38:45< vultraz> so much code :O
20150820 10:40:51-!- louis94 [~~louis94@91.178.27.233] has joined #wesnoth-dev
20150820 10:41:48< zookeeper> "This commit also changes the hotkey ":" and "+" to ";" respective "=" becausse ":" and "+" are not valid keycodes."
20150820 10:41:53< zookeeper> O.o
20150820 10:44:17< zookeeper> does that mean what it sounds like it means, as in that : and + would no longer be the keys for prompt and zoom?
20150820 10:46:13< zookeeper> and/or not usable for anything at all anymore? if so, what other keys would that apply to? what could possibly justify a program not being able to handle certain keys?
20150820 10:47:03-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150820 10:56:30< Aginor> zookeeper: : and + are not actual keys, I have remapped them to the actual keys in the same position
20150820 10:56:42< Aginor> : is shift+;
20150820 10:56:50-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 272 seconds]
20150820 10:56:52< Aginor> + is shift++
20150820 10:57:46< Aginor> vultraz: I had to include (small) bits of SDL2 to provide a compatible set of hotkeys across both SDL1 and SDL2
20150820 10:58:11< zookeeper> Aginor, ok, so... the PR doesn't involve any user-facing change in behavior?
20150820 10:58:48< Aginor> there's the two hotkeys
20150820 10:59:01< Aginor> need to be tested and verified to be the same on a non-US keyboard
20150820 10:59:36< Aginor> the underlying technical reason is https://wiki.libsdl.org/SDL_Keycode , we can't express the "virtual keys" at the end of the table
20150820 11:00:10< Aginor> they will have worked with SDL1.2 (although that was broken in all other kinds of subtle ways) because they were decoded into characters instead
20150820 11:01:53-!- Kwandulin [~Miranda@p5B008916.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150820 11:04:54< zookeeper> i assume "there's the two hotkeys" means that : and + won't work for prompt and zoom
20150820 11:05:09< Aginor> yes
20150820 11:05:33< zookeeper> using : is a pretty reflexive action, and not having + for zoom in is pretty... well, you know
20150820 11:05:41< Aginor> I have rebound them to the same keys  (minus shift)
20150820 11:06:18< Aginor> zookeeper: I can change it to be shift+; and shift+= instead
20150820 11:07:08< zookeeper> shift+; doesn't even make sense because i type ; with shift in the first place :p
20150820 11:07:08< vultraz> Shift+; is what it is now, so it's kinda reflexive, but I wouldn't be opposed to no shift
20150820 11:07:37< Aginor> zookeeper: but does it make sense to have '-' be zoom out and shift+= is zoom in
20150820 11:07:51< zookeeper> Aginor, of course not, who says so?
20150820 11:08:10< Aginor> zookeeper and vultraz, as you see, you have different perceptions on hotkeys based on your locale
20150820 11:08:18< Aginor> (and keyboard layout)
20150820 11:08:26< Aginor> vultraz: are you on en-US?
20150820 11:08:34< vultraz> yes
20150820 11:08:36< Aginor> zookeeper: which keyboard layout do you use?
20150820 11:08:41< zookeeper> finnish
20150820 11:09:51< Aginor> zookeeper and vultraz: so both of your keyboard layouts are different with regards to some special characters, : and + are two examples of these
20150820 11:10:17< Aginor> zookeeper: you will probably have issues with åäö too
20150820 11:11:11< zookeeper> yeah, can't bind those ït seems. nor can i actually re-bind + and -
20150820 11:11:32< zookeeper> they zoom keys are + and - by default and work fine, but i can't bind + and - to anything
20150820 11:11:39< Aginor> in fact, my ":" is shift+.
20150820 11:11:46< zookeeper> mine too
20150820 11:11:54-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150820 11:11:54< Aginor> zookeeper: you can still rebind them
20150820 11:12:29 * Aginor ponders if it would be better to use scancode for certain things
20150820 11:12:39< Aginor> scancode are keyboard layout independant
20150820 11:12:42< zookeeper> now, if we could actually get all this working exactly as it should work, then _that_ would be great.
20150820 11:12:58< Aginor> zookeeper: localised hotkeys for different languages
20150820 11:14:11< zookeeper> then it'd be dependant on the language setting (and require per-language customization anyway)
20150820 11:14:31-!- louis94 [~~louis94@91.178.27.233] has quit [Ping timeout: 265 seconds]
20150820 11:15:11< Aginor> yes...
20150820 11:15:33< Aginor> that's the current state as well
20150820 11:15:52< zookeeper> i don't know much about keyboard/text handling. how _do_ all the countless programs which handle text/keyboard input/output correctly on all keyboards/languages/etc do it?
20150820 11:16:03< zookeeper> well, i assume they are countless
20150820 11:16:13< zookeeper> although most games have always had a problem with it
20150820 11:16:28< Aginor> many ignore anything that's not en-US
20150820 11:16:41< Aginor> and you get to deal with it yourself
20150820 11:16:54< zookeeper> yeah, that's the usual problem. it's often a nightmare
20150820 11:17:11< Aginor> some use scancodes, which means that they are fixed to physical buttons, not characters
20150820 11:18:05< Aginor> I could trivially change my pull request to use scancodes instead
20150820 11:18:33< Aginor> and then : would turn into shift+ö for you
20150820 11:19:40< zookeeper> but aren't there any one-size-fits-all libraries or whatnot one can easily use? especially in a non-realtime game where you don't need to catch individual keypresses quickly?
20150820 11:20:11< Aginor> at which point the default hotkeys would be language independant
20150820 11:20:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150820 11:20:31-!- louis94 [~~louis94@91.178.27.233] has joined #wesnoth-dev
20150820 11:21:15< Aginor> zookeeper: that's what SDL tries to provide with keycodes. Keycodes is a middle path between trying to figure out the current characters (broken for all multi-char languages) and keycodes
20150820 11:21:31< Aginor> z and y would be remapped on the german keyboard for example
20150820 11:22:32< Aginor> zookeeper: would you be able to test the behaviour of my patch on your system with your finnish keyboard layout?
20150820 11:23:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150820 11:23:36< zookeeper> maybe... not right now though. keep asking me daily :P
20150820 11:26:58< Aginor> zookeeper: fair enough
20150820 11:32:00< wedge009> Hoo boy, the locale-specific keyboards issue we've been running into has returned.
20150820 11:33:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150820 11:34:21< wedge009> Is hokey actually meant to be different from hotkey or is that just a typo?
20150820 11:43:05-!- Xara [Yangyf@2001:cc0:2020:4010:c4ef:157e:de00:689] has joined #wesnoth-dev
20150820 11:43:10< Aginor> wedge009: they never quite went away
20150820 11:43:19< wedge009> I know.
20150820 11:43:38< Aginor> and the workaround introduced won't work with sdl2
20150820 11:43:54< Aginor> that's a typo
20150820 11:44:30< wedge009> BTW, I realise English is not necessarily everyone's first language, but I should point out that (in)dependent is the adjective and dependant is the noun (eg a child is a dependant of the parent). Sorry. :p
20150820 11:45:06< Aginor> thanks
20150820 11:45:53< wedge009> What won't work with SDL2?
20150820 11:46:00< wedge009> Your PR?
20150820 11:47:04< wedge009> I just realised how much code there is. x.x
20150820 11:47:47< Aginor> wedge009: I might have rewritten the hotkey system to be the same for both sdl1.2 and 2
20150820 11:47:57< Aginor> and be consistent across both
20150820 11:48:16< Aginor> but I also had to include some bits of sdl2's key->string code
20150820 11:49:39< wedge009> Directly include it?
20150820 11:50:03< Aginor> yes
20150820 11:50:17< Aginor> that's where the vast majority of the PR comes from
20150820 11:50:23< wedge009> Ah.
20150820 11:50:44< Aginor> I discussed it with shadowm yesterday, it'll be removed once SDL2 is the only supported version
20150820 11:51:29< wedge009> Fair enough. I'll try to test it, but probably not tonight... well, it's night for me, I know might not be for you.
20150820 11:53:20< Aginor> wedge009: I think you're a couple of timezones behind me actually
20150820 11:53:26-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 250 seconds]
20150820 11:53:29< Aginor> it's just about midnight here
20150820 11:53:47< wedge009> Yeah, I had the impression you're NZ... is that right?
20150820 11:53:58< Aginor> wedge009: indeed
20150820 11:54:10< Aginor> wedge009: and I think you're from Australia :)
20150820 11:54:14< wedge009> Cool. And yes, two hours behind.
20150820 11:54:31< wedge009> Yeah, been here long enough to say I'm from it.
20150820 11:54:45< Aginor> cool ;)
20150820 11:54:53< Aginor> how long is that, if I may ask?
20150820 11:55:33< wedge009> Twenty-five years and eighteen days. Yes, I still remember the day we landed. (:
20150820 11:56:43< Aginor> that's a long time
20150820 11:57:35< Aginor> zookeeper: no need to test, I wrote a simple SDL app in windows... it's not ideal
20150820 11:58:40< Aginor> I think I will need to change my PR to use scancode instead
20150820 11:59:00< Aginor> that will fix locale dependant codes
20150820 11:59:13< wedge009> What behaviour do commercial games allowing keyboard customisation exhibit when a non-US keyboard is used?
20150820 11:59:40< Aginor> wedge009: you get the US layout normally, and then you can (usually nowadays) rebind it
20150820 12:01:03< Aginor> if I change it to scancodes, I could always bind the same physichal button to a hotkey command
20150820 12:01:48< Aginor> so user command could be ; or ö or whatever it might be in various keyboard layouts
20150820 12:03:09< Aginor> it will probably require me to remap all hotkeys to make sure that the string representation of the scancods is correct, and woe is anyone who tries to edit them manually
20150820 12:04:22< Aginor> anyway
20150820 12:04:28< Aginor> I shall go to bed, it is late
20150820 12:04:37< zookeeper> it doesn't really matter which physical key something is bound to... what matter is that the string which the app represents that key with matches the physical key. i guess that's likely the same thing, though.
20150820 12:04:47< Aginor> provide feedback on the PR is you have any
20150820 12:04:50< wedge009> Just wondering if those games bind according to (US) key position or character, that should influence the final decision.
20150820 12:04:54< wedge009> Sure, go to bed.
20150820 12:04:55< Aginor> zookeeper: that's not a problem
20150820 12:05:01< wedge009> I'll need do the same. x.x
20150820 12:05:08< Aginor> wedge009: position normally
20150820 12:05:17< wedge009> Makes sense.
20150820 12:06:44-!- irker106 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150820 12:08:07< Soliton> maybe a workable approach would be to use the current handling for ascii chars/keys and the scancode/keycode or whatever for the remaining keys.
20150820 12:08:33< Soliton> at least the way it currently works is exactly to fix the issues with hotkeys like :.
20150820 12:09:31< Aginor> Soliton: that's not going to work with SDL2, the current handling relies on SDL1.2's (broken) implementation of key to unicode translation. They removed it for SDL2
20150820 12:10:08< wedge009> It's also part of what's causing the mess with non-letter key detection in the first place, I believe.
20150820 12:10:19< wedge009> (~psst~ Go to bed! ;))
20150820 12:10:21< Aginor> The more I think about it, the more I feel that the correct solution is to use scancodes and translate them into localised strings
20150820 12:10:46< wedge009> On a high-level, that was what I was thinking too, but don't know enough about the technical details.
20150820 12:11:06< wedge009> Others were suggesting some sort of locale conversion, I think.
20150820 12:11:09< Aginor> That's actually very simple to change in my current PR
20150820 12:11:48< wedge009> Well, when you think you have it in a state ready to test, let us know and I'll try to give it a go.
20150820 12:12:24< Aginor> probably around 20 lines of code, which is mostly about renaming a field, then I need to invoke different SDL methods
20150820 12:12:43< Aginor> and investigate whether SDL1.2 and SDL2 scancodes are compatible (should be)
20150820 12:13:05< Aginor> wedge009: I think it's ready to test now for the overall functionality
20150820 12:13:29< Aginor> but I will make a modification based on the feedback I've received
20150820 12:14:12-!- midzer [~quassel@p4FFCE1F9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150820 12:14:56-!- prkc [~prkc@4E5CCDCF.dsl.pool.telekom.hu] has joined #wesnoth-dev
20150820 12:15:05< wedge009> Okay, till tomorrow (or later today), then.
20150820 12:15:22-!- Kwandulin [~Miranda@p5B008916.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150820 12:16:55< Aginor> anyhow
20150820 12:16:57< Aginor> *poff*
20150820 12:19:33< wedge009> Where'd he go?
20150820 12:20:17< wedge009> The bronze on the new logo looks quite saturated. The flame pattern on the shield is really noticeable too. Oh well, that's the artists' choice, I suppose.
20150820 12:49:30-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20150820 12:49:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20150820 12:49:55-!- gandaro [~gandaro@wikipedia/Gorlingor] has quit [Quit: Leaving]
20150820 12:58:31-!- mjs-de [~mjs-de@x4db6aa95.dyn.telefonica.de] has quit [Remote host closed the connection]
20150820 13:00:23-!- smoyer [~smoyer1@2610:8:6800:d:194e:af47:d39e:f194] has joined #wesnoth-dev
20150820 13:04:13-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150820 13:10:54-!- Appleman1234 [~Appleman1@KD036012012215.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20150820 13:20:50-!- Kwandulin [~Miranda@p5B008916.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150820 13:27:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20150820 13:27:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20150820 13:28:01-!- louis94 [~~louis94@91.178.27.233] has quit [Ping timeout: 246 seconds]
20150820 13:31:29-!- louis94 [~~louis94@91.178.27.233] has joined #wesnoth-dev
20150820 13:50:54< zookeeper> well that new logo sure is... bright
20150820 13:54:01< jxanthony> I like it
20150820 13:54:28-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150820 14:08:33-!- Appleman1234 [~Appleman1@KD036010156089.au-net.ne.jp] has joined #wesnoth-dev
20150820 14:21:48-!- Kwandulin [~Miranda@p5B008916.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150820 14:24:25< wedge009> I had another go at https://github.com/wesnoth/wesnoth/pull/454. I found the problem is due to a missing event, but I don't have a complete work-around for the issue. I've put in the best I can manage, though it's hardly ideal. If anyone knows more about tray notification events, please help. (:
20150820 14:29:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150820 14:34:18-!- [Relic] [~Relic]@2602:306:33a3:6d30:cdf4:828e:ded7:cbb4] has joined #wesnoth-dev
20150820 14:34:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150820 14:42:51-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20150820 14:44:26-!- Appleman1234 [~Appleman1@KD036010156089.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20150820 14:50:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150820 14:55:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150820 15:02:17-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150820 15:27:29-!- horrowin1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150820 15:37:22-!- Xara [Yangyf@2001:cc0:2020:4010:c4ef:157e:de00:689] has quit [Read error: Connection reset by peer]
20150820 15:37:56-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20150820 15:41:05-!- Appleman1234 [~Appleman1@KD036010151175.au-net.ne.jp] has joined #wesnoth-dev
20150820 15:44:19-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150820 15:57:56-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20150820 16:06:56-!- subliun_ [~quassel@139.216.140.254] has joined #wesnoth-dev
20150820 16:07:07-!- subliun [~quassel@139.216.140.254] has quit [Ping timeout: 256 seconds]
20150820 16:12:08-!- Kwandulin [~Miranda@p5B008916.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150820 16:13:50-!- louis94 [~~louis94@91.178.27.233] has quit [Ping timeout: 240 seconds]
20150820 16:17:30-!- Appleman1234 [~Appleman1@KD036010151175.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20150820 16:32:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds]
20150820 16:43:57-!- horrowin1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has quit [Quit: horrowin1]
20150820 16:44:09-!- Guest20238 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150820 16:48:58-!- Guest20238 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 272 seconds]
20150820 17:04:37-!- TC01_ [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150820 17:14:21-!- Appleman1234 [~Appleman1@KD106180016244.au-net.ne.jp] has joined #wesnoth-dev
20150820 17:20:59-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20150820 17:34:13-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20150820 17:44:13-!- chaverma [~Adium@209.63.146.244] has joined #wesnoth-dev
20150820 17:51:05-!- Appleman1234 [~Appleman1@KD106180016244.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20150820 18:02:45-!- chaverma1 [~Adium@209.63.146.244] has joined #wesnoth-dev
20150820 18:02:59-!- chaverma1 [~Adium@209.63.146.244] has quit [Client Quit]
20150820 18:04:52-!- chaverma [~Adium@209.63.146.244] has quit [Ping timeout: 265 seconds]
20150820 18:11:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150820 18:43:56-!- ancestral [~ancestral@6.sub-70-197-232.myvzw.com] has joined #wesnoth-dev
20150820 18:48:59-!- Appleman1234 [~Appleman1@KD106180017230.au-net.ne.jp] has joined #wesnoth-dev
20150820 19:00:16-!- ancestral [~ancestral@6.sub-70-197-232.myvzw.com] has quit [Read error: Connection reset by peer]
20150820 19:06:46-!- TC01_ [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 240 seconds]
20150820 19:26:03-!- Appleman1234 [~Appleman1@KD106180017230.au-net.ne.jp] has quit [Ping timeout: 255 seconds]
20150820 19:27:47-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-jknmividjmhmeofd] has quit [Ping timeout: 244 seconds]
20150820 19:28:18-!- smoyer [~smoyer1@2610:8:6800:d:194e:af47:d39e:f194] has quit [Ping timeout: 244 seconds]
20150820 19:28:49-!- [Relic] [~Relic]@2602:306:33a3:6d30:cdf4:828e:ded7:cbb4] has quit [Ping timeout: 244 seconds]
20150820 19:30:15-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-gqkbvhidkfgyuwvs] has joined #wesnoth-dev
20150820 19:43:08-!- [Relic] [~Relic]@2602:306:33a3:6d30:cdf4:828e:ded7:cbb4] has joined #wesnoth-dev
20150820 19:43:46-!- smoyer [~smoyer1@2610:8:6800:d:194e:af47:d39e:f194] has joined #wesnoth-dev
20150820 19:45:39-!- Elvish_Hunter [~irssi@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20150820 19:53:37-!- irker507 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150820 19:53:37< irker507> wesnoth: Elvish_Hunter wesnoth:master 512c7adb98aa / data/tools/wmllint-1.4: wmllint 1.4: used print function http://git.io/vslF3
20150820 20:03:19-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150820 20:06:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 245 seconds]
20150820 20:06:40-!- wedge010 is now known as wedge009
20150820 20:11:22-!- genbattle [~genbattle@182.16.153.90] has joined #wesnoth-dev
20150820 20:22:46-!- Appleman1234 [~Appleman1@KD036010147079.au-net.ne.jp] has joined #wesnoth-dev
20150820 20:26:00-!- genbattle [~genbattle@182.16.153.90] has quit [Read error: Connection reset by peer]
20150820 20:31:24-!- smoyer [~smoyer1@2610:8:6800:d:194e:af47:d39e:f194] has quit [Quit: Leaving.]
20150820 20:34:30-!- travis-ci [~travis-ci@ec2-54-158-32-61.compute-1.amazonaws.com] has joined #wesnoth-dev
20150820 20:34:31< travis-ci> wesnoth/wesnoth#7136 (master - 512c7ad : Elvish_Hunter): The build is still failing.
20150820 20:34:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/76520874
20150820 20:34:31-!- travis-ci [~travis-ci@ec2-54-158-32-61.compute-1.amazonaws.com] has left #wesnoth-dev []
20150820 20:45:13-!- gandaro [~gandaro@wikipedia/Gorlingor] has joined #wesnoth-dev
20150820 20:59:02-!- Appleman1234 [~Appleman1@KD036010147079.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20150820 21:16:34-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150820 21:21:18-!- louis94 [~~louis94@91.178.27.233] has joined #wesnoth-dev
20150820 21:32:56-!- midzer [~quassel@p4FFCE1F9.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20150820 21:47:25-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20150820 21:47:30-!- midzer [~quassel@p4FFCE1F9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150820 21:50:59-!- travis-ci [~travis-ci@ec2-54-196-236-215.compute-1.amazonaws.com] has joined #wesnoth-dev
20150820 21:51:00< travis-ci> wesnoth/wesnoth#7136 (master - 512c7ad : Elvish_Hunter): The build was fixed.
20150820 21:51:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/76520874
20150820 21:51:00-!- travis-ci [~travis-ci@ec2-54-196-236-215.compute-1.amazonaws.com] has left #wesnoth-dev []
20150820 21:51:13 * Aginor high fives Elvish_Hunter 
20150820 21:54:21< Elvish_Hunter> Uh... I didn't do anything to fix the build...
20150820 21:54:31< Aginor> magic!
20150820 21:54:53< Aginor> or something that times out
20150820 21:55:36-!- Appleman1234 [~Appleman1@KD106180017048.au-net.ne.jp] has joined #wesnoth-dev
20150820 22:03:14-!- Elvish_Hunter [~irssi@wesnoth/developer/elvish-hunter] has quit [Quit: Ciao!]
20150820 22:14:10< shadowm> He didn't fix the build, I restarted the failed job.
20150820 22:25:48-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150820 22:54:07-!- irker507 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150820 23:12:12-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150820 23:19:21< celticminstrel> 'kay, the only thing left to PR now is [for].
20150820 23:19:59< celticminstrel> Ooh, I think I like 636cc63.
20150820 23:20:02< vultraz> so many hotkey-related pRs
20150820 23:20:15< celticminstrel> Sorry? >_>
20150820 23:20:30< Aginor> I thought mine was the only one?
20150820 23:20:42< celticminstrel> There was also wedge009's and then mine just now.
20150820 23:20:52< celticminstrel> Though mine has no interaction with the hotkey system.
20150820 23:20:54-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150820 23:21:15< Aginor> wedge009 did something that's been put into 1.12, but I've removed in master/1.13
20150820 23:21:22 * Aginor goes to look at celticminstrel's PR
20150820 23:21:32< celticminstrel> Mine is mainly for OSX.
20150820 23:21:43< Aginor> mine is cross platform :)
20150820 23:21:43< celticminstrel> Though the change should affect all OSes.
20150820 23:21:58< celticminstrel> It's just that it's probably only really a problem on OSX.
20150820 23:22:20< celticminstrel> It's really easy to hit Cmd-Q when you were aiming for Cmd-W or Cmd-A or occasionally even Cmd-S.
20150820 23:23:01< Aginor> I have no problem with celticminstrel PR, although it may conflict with mine
20150820 23:23:19< celticminstrel> Even though I don't touch the hotkey handling system at all?
20150820 23:23:24< celticminstrel> It's a lot harder to accidentally hit Alt-F4 or accidentally click the close button.
20150820 23:24:02< celticminstrel> I haven't gotten enough feedback on [for]. Should I try opening a forum thread or something?
20150820 23:24:17< Aginor> I have celticminstrel I think it's safe, I'm just putting it out there
20150820 23:24:38< Aginor> celticminstrel: my changes go into some of the event handling too, mostly changing signatures
20150820 23:24:45< celticminstrel> Ahh.
20150820 23:24:56< celticminstrel> I did touch event handling.
20150820 23:25:02< Aginor> pass SDL_Event instead of SDL_KeyboardEvent and so on
20150820 23:25:18< celticminstrel> So I guess there's a potential for conflicts, but probably not hard-to-resolve ones.
20150820 23:25:25< Aginor> no
20150820 23:25:33< Aginor> it should be trivial
20150820 23:26:50-!- new_one [~new_one@2604:a880:1:20::22e:d001] has quit [K-Lined]
20150820 23:27:40< celticminstrel> I'm not sure where I'd open a thread about this though. Coder's Corner? Lua Labs?
20150820 23:27:52< celticminstrel> ("this" = [for] tag)
20150820 23:30:59< vultraz> CodersCorner I would say
20150820 23:35:54 * Aginor swears over the different scancode implementation in SDL1 and SDL2
20150820 23:49:25-!- gandaro [~gandaro@wikipedia/Gorlingor] has quit [Quit: Leaving]
--- Log closed Fri Aug 21 00:00:20 2015