--- Log opened Sat Aug 22 00:00:24 2015
20150822 00:00:44-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150822 00:29:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150822 00:32:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150822 00:37:28-!- gandaro [~gandaro@wikipedia/Gorlingor] has quit [Quit: Leaving]
20150822 00:39:10-!- danl-ndi [a0212b0f@gateway/web/freenode/ip.160.33.43.15] has joined #wesnoth-dev
20150822 00:39:39-!- danl-ndi [a0212b0f@gateway/web/freenode/ip.160.33.43.15] has quit [Client Quit]
20150822 00:59:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150822 01:13:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150822 01:54:11-!- Portaljacker [~Portaljac@modemcable081.139-178-173.mc.videotron.ca] has quit [Quit: Leaving]
20150822 03:09:09-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150822 03:17:11-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150822 03:17:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150822 03:22:13< Aginor> wedge009: I can confirm that the problem exists on Linux too, I must have broken it after I did all of my testing. I'll fix and update the PR
20150822 03:23:19-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150822 03:23:35-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150822 03:43:12-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 244 seconds]
20150822 03:45:02-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150822 03:47:25-!- Appleman1234 [~Appleman1@KD106180017213.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20150822 03:52:53-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20150822 03:52:54-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20150822 03:52:54-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150822 03:58:09-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150822 04:05:32-!- Kwandulin [~Miranda@p5B0086E6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150822 04:14:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150822 04:24:31-!- louis94 [~~louis94@91.178.27.233] has quit [Quit: Konversation terminated!]
20150822 04:36:36-!- irker932 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150822 04:43:51-!- Appleman1234 [~Appleman1@KD106180031220.au-net.ne.jp] has joined #wesnoth-dev
20150822 04:52:36-!- Appleman1234 [~Appleman1@KD106180031220.au-net.ne.jp] has quit [Ping timeout: 255 seconds]
20150822 04:52:36-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150822 05:13:18-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150822 05:32:56-!- irker601 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150822 05:32:56< irker601> wesnoth: John Anthony wesnoth:master e50ee3db41f8 / data/core/about.cfg src/campaign_server/campaign_server.cpp: Added password hashing to campaignd http://git.io/vsg9B
20150822 05:32:58< irker601> wesnoth: Ignacio R. Morelle wesnoth:master 2278219348e8 / data/core/about.cfg src/campaign_server/campaign_server.cpp: Merge branch 'master' of https://github.com/JohnAnthony/wesnoth into staging/pr- http://git.io/vsg9R
20150822 05:33:01< irker601> wesnoth: Ignacio R. Morelle wesnoth:master e399258b4420 / src/campaign_server/campaign_server.cpp: campaignd: Record the hashed passphrase for new uploads http://git.io/vsg90
20150822 05:33:04< irker601> wesnoth: Ignacio R. Morelle wesnoth:master f852044d4cc8 / data/core/about.cfg src/campaign_server/campaign_server.cpp: Merge branch 'staging/pr-449-4' http://git.io/vsg9E
20150822 05:38:22< shadowm> wedge009: Re https://github.com/Wedge009/wesnoth/blob/SDL2_windows_tray/src/video.cpp#L539
20150822 05:38:50< shadowm> Firstly, that sounds like a bug in SDL 2.
20150822 05:39:19< shadowm> Secondly, I really believe we should pass SDL_WINDOWPOS_UNDEFINED as x and y to SDL_CreateWindow().
20150822 05:39:46< shadowm> (Paging Aginor too in case he has an opinion about this.)
20150822 05:41:25-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 240 seconds]
20150822 05:47:26< shadowm> shikadibot: seen lipkab
20150822 05:47:26< shikadibot> shadowm: The person with the nick lipkab last spoke 6d 19h ago.  16h 9m ago they left with the message: Ping timeout: 246 seconds
20150822 05:47:40< shadowm> lipkab: So, are we going to drop SDL_gpu?
20150822 05:49:48< shadowm> celticminstrel: Is mattsc in charge of #464?
20150822 05:49:57< shadowm> Link: https://github.com/wesnoth/wesnoth/pull/464
20150822 05:52:04< shadowm> celticminstrel: Are you familiar with git rebase operations?
20150822 05:53:32< shadowm> This line needs the `// xgettext:no-c-format` comment: https://github.com/CelticMinstrel/wesnoth/commit/c88a1be20efc0588015d4e797945ee2d44c26698#diff-0bcdc1d5fc9ca6f1eefe788ab95bc8caR282
20150822 06:03:44< shadowm> celticminstrel: Has zookeeper reviewed the WML API changes in #468 and #463?
20150822 06:04:47-!- Appleman1234 [~Appleman1@KD106180031220.au-net.ne.jp] has joined #wesnoth-dev
20150822 06:08:45< Aginor> shadowm: I don't have a firm opinion on SDL_gpu myself yet, that's touching more on the rendering path that I haven't been investigating so far.
20150822 06:09:19-!- [Relic] [~Relic]@2602:306:33a3:6d30:1812:3f32:fac1:38cb] has quit [Quit: I press the magic X and all the weirdos go away!]
20150822 06:10:29< mattsc> shadowm: I can be in charge of it, but the next action is on celticminstrel  (replacing ditto with rsync)
20150822 06:11:08< shadowm> mattsc: I want to know who to assign the PR to and who to poll for the PR's mergeability status (and/or let them take care of that by themselves).
20150822 06:11:24< shadowm> You know, assigning developers to individual pull requests is a thing that can be done.
20150822 06:11:34< Aginor> shadowm: doubt this is a windows bug, I rather suspect it's wesnoth doing something silly, I agree that SDL_WINDOWPOS_UNDEFINED sounds like the most reasonable thing to do
20150822 06:11:36< shadowm> I encourage you people to do it more often (that includes Elvish_Hunter).
20150822 06:11:55< mattsc> I do.  I thought I was assigned to that one already, but I think what I am remebering was a different one.
20150822 06:12:00< shadowm> Aginor: I had a quick look and AFAICT we just pass the parameter as it is to SDL_CreateWindow.
20150822 06:12:08< shadowm> Parameters, plural.
20150822 06:12:19< Aginor> ok
20150822 06:12:26< shadowm> Wesnoth can't and shouldn't have to know about the window decoration size to adjust the coordinate.
20150822 06:12:37< Aginor> no, I agree fully
20150822 06:13:24< Aginor> I also do not think Wesnoth should specify the window position explicitly, that's up to the window manager
20150822 06:21:52-!- Kwandulin [~Miranda@p5B0086E6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150822 06:23:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150822 06:24:15-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150822 06:27:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20150822 06:29:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150822 06:31:26-!- shadowm_desktop is now known as Admiral_Obvious
20150822 06:32:38-!- pydsigner is now known as Yumi
20150822 06:33:02-!- Yumi is now known as pydsigner
20150822 06:34:17-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20150822 06:34:36-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150822 06:37:56< Aginor> wedge009: the hotkey binding bugs that you reported earlier have been resolved and the PR is updated
20150822 06:38:34< Aginor> I still need to investigate whether ctrl modifies the scancodes reported or not, I certainly don't see that here
20150822 06:40:36< Aginor> shadowm: is there someone I can talk to about gui2 stuff?
20150822 06:41:40< shadowm> Depends on what kind of GUI2 stuff we're talking about. I don't understand the internals very well and, in fact, they are far beyond my ability to understand C++.
20150822 06:41:52< shadowm> (Esp. everything about the event handling code.)
20150822 06:42:11< Aginor> I've been looking at the event handling code and there's a few things there that I'd like to modify
20150822 06:42:47< shadowm> Yeah, no-one but mordante understands that and he's AWOL.
20150822 06:43:14< Aginor> I wonder about the feasability to decouple the implementation of the event handling from the behaviour of certain widgets
20150822 06:43:25< Aginor> especially around text imput
20150822 06:43:30< Aginor> input even
20150822 06:43:46< Aginor> the current behaviour won't work very well with sdl2
20150822 06:46:39< Aginor> src/textbox.cpp:443 (handle_event)
20150822 06:47:23< shadowm> Uh.
20150822 06:47:39< shadowm> You mean some other path.
20150822 06:50:56< Aginor> src/widgets/textbox.cpp
20150822 06:50:59< Aginor> sorry
20150822 06:51:10< shadowm> That's GUI1.
20150822 06:52:11< Aginor> ah
20150822 06:52:24< Aginor> ok, GUI1 is broken, not GUI2
20150822 06:53:14< Aginor> does map labels use GUI2 for the text input?
20150822 06:53:44< shadowm> Yes.
20150822 06:53:49< Aginor> ok
20150822 06:53:59< Aginor> GUI2 does the right thing then and works
20150822 06:54:44< Aginor> my proposal would be to change the offending components that rely on GUI1 textboxes to GUI2, but I guess that's not very easy or it would have been done already
20150822 06:54:50< Aginor> is this assumption correct?
20150822 06:55:52< shadowm> GUI2 and GUI1 are completely incompatible with regards to event handling and ownership control,  so yes, correct.
20150822 06:56:35< Aginor> in other words, GUI1 needs to be fixed too for now
20150822 06:56:58< Aginor> is there any active effort ongoing in replacing GUI1 with GUI2?
20150822 06:58:24< shadowm> Since 2008, but without mordante that's kind of stalled since GUI2 is denser than a white dwarf code-wise.
20150822 06:59:18< shadowm> All dialogs that use GUI1 use it because GUI2 does not provide the required functionality yet or is buggy or unusable.
20150822 06:59:32< Aginor> ah
20150822 06:59:47< Aginor> I might look into that later
20150822 07:00:03< shadowm> For example, Load Game: GUI2's listbox filtering implementation is very bare-bones, and also GUI2 listboxes suffer from severe performance issues in general.
20150822 07:00:06< Aginor> but I want to get SDL2 up and running relatively well first :)
20150822 07:00:50< shadowm> Same thing applies to Add-ons Manager. mordante was developing his own implementation in GUI2 and this required him to add an alternate GUI2 listbox implementation that was never finished, so I worked on improving what we had in GUI1 for 1.12.x.
20150822 07:01:10< shadowm> MP lobby: long, ugly story. The bottomline is that GUI2 is not ready to implement the lobby.
20150822 07:01:21< Aginor> hardly an ideal situation
20150822 07:01:52< shadowm> Preferences: I was misled to believe that it wasn't doable in GUI2. This changed only after 1.13.1 when I discovered that it is, in fact, doable in GUI2.
20150822 07:02:27< shadowm> It's a lot of work, so I don't expect it to have it before 1.13.3 or so.
20150822 07:02:41< Aginor> yup
20150822 07:03:15< shadowm> But the underpinnings are already there and I wrote the version info dialog basically as a live test of the required API additions.
20150822 07:03:46< Aginor> it seems that all GUI stuff are hard... Has anyone investigated using something like Qt instead?
20150822 07:04:13< shadowm> Yes, someone started his own attempt at integrating Qt into Wesnoth and then went AWOL too.
20150822 07:04:14< Aginor> (why roll your own if you can avoid it)
20150822 07:04:27< Aginor> sounds frustrating
20150822 07:04:37< shadowm> I personally feel Qt is the wrong answer to this problem.
20150822 07:04:47< pydsigner> GUI is hard period.
20150822 07:05:03< Aginor> pydsigner: yes, but there's hard and then there's really hard
20150822 07:05:33< Aginor> shadowm: may I ask for the reasons? - I haven't investigated so I'm mainly curious
20150822 07:05:49< shadowm> Soemone suggested this to me but I don't have the time or expertise to look into it: http://cegui.org.uk/
20150822 07:06:41< shadowm> Aginor: Qt tends to roll with its own everything: coding style, generic containers and algorithms, etc.
20150822 07:07:15-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150822 07:07:25< shadowm> I have used Qt in the past and I don't feel it's worth our time to make Wesnoth work with it.
20150822 07:07:54< shadowm> I'm not saying Qt is *bad*, I actually like it. It's just too different from Wesnoth's current design.
20150822 07:09:03< shadowm> And then there are people who believe we should be looking at using HTML and CSS instead.
20150822 07:09:31< Aginor> I have done things in Qt in the past, which is why I was asking, but I agree that it comes with a kitchen sink.
20150822 07:10:32< pydsigner> JS pwns0r all
20150822 07:10:44< pydsigner> (or not)
20150822 07:11:38< Aginor> shadowm: I think HTML and CSS might not be ideal :)
20150822 07:13:24< pydsigner> That's a good way of putting it....
20150822 07:13:34< shadowm> In principle they'd be. CSS would be really great for implementing a themeable UI.
20150822 07:14:03< shadowm> But objectively speaking, implementing HTML and CSS right is... uh...
20150822 07:14:13< Aginor> there's no well known projects using cegui and there's not been a release coming out for over a year. I'd be careful
20150822 07:14:18< shadowm> "Not very easy", to put it lightly.
20150822 07:14:42< Aginor> shadowm: that's why I don't think HTML and CSS is a good idea :). You'd need to incorporate someone elses rendering engine
20150822 07:15:18< Aginor> the idea is nice, but even so I think you might be better off with something like gtk's xml
20150822 07:15:29< shadowm> And, CSS is abysmally bad for grid layout (which GUI2 uses extensively), unless your implementation can handle CSS Grid Layout and CSS Flexible Box.
20150822 07:15:43< Aginor> https://glade.gnome.org/
20150822 07:15:44< pydsigner> And you can't just run in any browser
20150822 07:16:08< Aginor> pydsigner: compile it all with emscripten!
20150822 07:16:13< Aginor> turn it into JS
20150822 07:16:26< shadowm> And that's two additional layers of complexity on top of a specification that was designed for topdown flow layouts from the get-go.
20150822 07:16:33< pydsigner> shadowm: If that's all that's that's holding you back
20150822 07:16:59< pydsigner> You should be rewriting for NodeJS
20150822 07:17:05< shadowm> -.-
20150822 07:17:25< shadowm> What has Javascript to do with anything at all here?
20150822 07:17:53< shadowm> For scripting we have Lua and hardcoded behavior in C++. THere would be no need to look at anything else.
20150822 07:17:56-!- Shackra [~Jorge@186.177.2.148] has quit [Read error: Connection reset by peer]
20150822 07:18:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150822 07:18:47< Aginor> shadowm: I think pydesigner was trying to make humorous remarks about rewriting the game in JS
20150822 07:20:01< Aginor> shadowm: the reason I was asking about GUI toolkits was to try to avoid some of the complexity of maintaining internal ones, adding a HTML+CSS parser and rendering engine on top of another toolkit would most likely increase the maintenance burden further
20150822 07:21:20< shadowm> The thing is, there are far too many more important things to do right now before we can even consider spending our limited energy and time on moving to *another* UI framework.
20150822 07:22:38< shadowm> And I say moving because the implied hypothetical scenario in question -- GUI1 and GUI2 and a Qt GUI coexisting -- would be a waste of everyone's time, especially the packagers'.
20150822 07:23:26< shadowm> Mostly when you realize that GUI2 is inextricably tied to the Pango/Cairo font rendering pipeline, and so are a large number of Wesnoth add-ons.
20150822 07:24:00< shadowm> (At least in the absence of a Pango markup-to-whatever translation layer.)
20150822 07:24:07< Aginor> fair enough
20150822 07:24:16< pydsigner> You wouldn't have to write your own HTML+CSS parser/renderer is my only point
20150822 07:24:36< Aginor> I'm not actually proposing doing anything at this stage, I was asking to try to understand the current situation better
20150822 07:25:17< shadowm> Sure, it's good to ask questions.
20150822 07:25:46< Aginor> speaking of questions;
20150822 07:25:57< shadowm> Especially when most of this stuff isn't properly documented anywhere (partly because the status quo is so ridiculous).
20150822 07:26:51< Aginor> shadowm: can I ask you to review https://github.com/wesnoth/wesnoth/pull/466 at some point?
20150822 07:26:58< shadowm> Also note that this is what happens when a whole project's technological progress becomes a single person's burden.
20150822 07:27:25< Aginor> well, I'm trying to help :)
20150822 07:27:55< shadowm> mordante apparently thought he could get GUI2 feature-complete in two years time when he started it, back in 2008. It's 2015 now and he sort-of-but-not left and had to rewrite some parts multiple times (the listbox code being the lastest example of this disease).
20150822 07:28:39< shadowm> From then up to this day we started redirecting all UI bugs to him (and he started doing this as well, so it's not like we forced additional work on him).
20150822 07:29:21< shadowm> Anyway...
20150822 07:29:39< Aginor> gui frameworks are very complex, by their very nature
20150822 07:30:48< Aginor> shadowm: who are the active developers who touch the core code?
20150822 07:31:12< shadowm> From this list: http://forums.wesnoth.org/viewtopic.php?t=42911 ?
20150822 07:31:38< shadowm> shadowm, gfgtdf, Elvish_Hunter.
20150822 07:32:04< shadowm> Well, at the time lipkab seemed inactive so I'm not quite sure in which category he fits in anymore.
20150822 07:33:03< shadowm> The thing is is that none of us knows everything. :p
20150822 07:33:28< shadowm> For example, I don't know the hotkeys code (the last person to touch it as again one of the AWOL people) .
20150822 07:33:38< Aginor> it's a large project and it's changed hands lots, it's sadly to be expected
20150822 07:33:53 * Aginor is quite comfortable with both the old and the new hotkeys code now
20150822 07:34:02< Aginor> or input handling in general
20150822 07:34:06< Aginor> and event handling
20150822 07:34:30< Aginor> I'm also getting a handle on the rendering pipeliune, but that's not complete
20150822 07:34:39< shadowm> So yeah, I wanted to know if lipkab could take a look at your code first before me. (Hi lipkab.)
20150822 07:34:53< Aginor> fair enough
20150822 07:35:29< shadowm> That said, a style thing I can already see: please always use braces for control blocks (if/else, do/while, for, etc.).
20150822 07:36:14< Aginor> shadowm: there's potentially user facing changes there. Keyboard shortcuts will move for end users because they are now tied to specific buttons on the keyboard as opposed to specific characters
20150822 07:36:19< shadowm> Even if it seems okay right now, you never know when someone in the future might change something in the surrounding context and cause the whole thing to execute differently.
20150822 07:36:47< Aginor> shadowm: I'll fix that. I've been doing a lot of kernel coding lately and they frown on curly braces for just the one statement
20150822 07:36:59< shadowm> (See also Apple's "goto fail" bug.)
20150822 07:37:02< Aginor> apart from that, is it looking sensible style-wise?
20150822 07:38:13< Aginor> I'm not convinced the code is ready to be merged yet, wedge009 found two bugs in it and I would like him to help me to retest when he's available
20150822 07:40:50< shadowm> There's a few container size zero comparisons.
20150822 07:41:47< shadowm> With anything that provides an empty() method it's preferable to check that instead of comparing size() or length() to zero. Where it's not because of implementation efficiency concerns (e.g. C++03 std::list), it's a matter of conciseness.
20150822 07:43:02< Aginor> I've changed that already
20150822 07:43:17< wedge009> Aginor: I'll get on PR 466 shortly. I didn't mention it before, but I'm only testing it on SDL2, I haven't checked it on SDL1.2 (yet).
20150822 07:43:26< wedge009> shadowm: Likewise, I'll retest the twindow creation in a bit. I didn't know what the suitable constants were, I just put in whatever made it work for me (since not being able to access the title bar was really annoying).
20150822 07:43:28< shadowm> There's some inconsistent spacing between tokens here and there too (e.g. https://github.com/wesnoth/wesnoth/pull/466/files#diff-3fc882bf3849712b34916c637ad4285cR227 ).
20150822 07:44:04< shadowm> Aginor: Other than that, I can't see anything that warrants attention right now. Maybe I'll discover more stuff when I get to actually reading the code.
20150822 07:44:31< shadowm> Oh yeah, class/struct/enum opening braces on the next line please. :p
20150822 07:45:04< wedge009> Also, I vote no to HTML/CSS. (: I've helped with browser game development before and while I'm pleasantly surprised at what can be accomplished with modern browsers, I think it's very hard to guarantee a consistent experience for everyone, even with modern standards-compliant browsers.
20150822 07:45:05< Aginor> wedge009: what you tested was broken in both. I had inadvertedly dropped the keyboard modifiers when creating new hotkeys
20150822 07:45:33< Aginor> shadowm: ok
20150822 07:45:41< shadowm> And as with celticminstrel, if you feel comfortable with using git rebase I'd rather see style fixes become part of their parent commit(s).
20150822 07:46:03 * Aginor updates the source formatter in eclipse
20150822 07:46:14< wedge009> Aginor: All right, I'll check SDL1.2 as well, just in case. Did some work on it last night so will see if it covers what I found as well.
20150822 07:46:17< shadowm> But if you aren't used to git rebase it doesn't matter -- I'd rather have the extra commits than contributors accidentally destroying their PR's history.
20150822 07:46:19< Aginor> if someone has a defined style already, I'd be keen
20150822 07:46:55< Aginor> shadowm: I'm comfortable rebasing, but I'd prefer not to now when it's a public PR
20150822 07:47:11< Aginor> in fact, the original PR commit is 16 rebased commits :)
20150822 07:47:21< shadowm> In general, we don't have a single style, although GUI2 *attempted* to establish a style.
20150822 07:47:38< Aginor> shadowm: that's making it harder to fit in
20150822 07:47:56< Aginor> I'm tempted to say: pick a style and run a formatter on the source tree :)
20150822 07:48:02< shadowm> GUI2's style is also kind of bad and counterproductive in some respects (for example, don't copy tGUI2's tsilly ttype tnaming tconventions).
20150822 07:48:19< Aginor> no, I wouldn't do that
20150822 07:48:24< wedge009> I've tried to follow the existing style, but I find it hard to read sometimes. I prefer the extra spacing when it aids in reading (spacing between function calls and parameter lists, braces bounding functions, if statements, etc, on separate lines...). But I will stick to what's there.
20150822 07:48:52< shadowm> There's even a script for use with clang-format in src/.clang-format that uses GUI2's conventions (sans naming style, I hope).
20150822 07:49:00< wedge009> I keep mentally saying twindow as twin-do, instead of t-window. XD
20150822 07:49:13< Aginor> ok, my dinner's done
20150822 07:49:14< Aginor> bbl
20150822 07:49:18< wedge009> Om nom nom.
20150822 07:49:21< wedge009> Enjoy.
20150822 07:50:38< shadowm> wedge009: The goal of this hypothetical "project" wouldn't be to run Wesnoth on a browser, though.
20150822 07:51:25< shadowm> Rather, Wesnoth would implement some subset of a browser's functionality.
20150822 07:52:11< pydsigner> http://tutorialzine.com/2015/01/your-first-node-webkit-app/
20150822 07:52:19< wedge009> Oh sure, one might just use the layout engine, but I still feel uncomfortable at the thought. That may just be my inexperience and unfamiliarity with such things, though.
20150822 07:52:23< pydsigner> ^ No you wouldn't
20150822 07:53:26< pydsigner> Unless you're speaking of using HTML in SDL..............
20150822 07:53:47< shadowm> Yes.
20150822 07:57:39-!- Kwandulin [~Miranda@p5B0086E6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150822 08:11:05< shadowm> wedge009: #454's code looks sane to me -- at least in the overall diff.
20150822 08:11:27< shadowm> The commit history is a little more questionable.
20150822 08:12:41< shadowm> Mostly that "Use actual SDL_Window object in Windows Tray code" should be merged into its direct ancestor commit ("SDL2 Update for Windows Tray Notification").
20150822 08:13:59< wedge009> I'm still new to a lot of what's in git. How do I rewrite history? Considering I messed the start of it all, maybe I should make a fresh branch?
20150822 08:15:08< shadowm> Do you use the command-line vanilla Git client, or some GUI front-end?
20150822 08:16:19< wedge009> I'm using TortoiseGit, but I can use the command-line when I know how.
20150822 08:16:51< wedge009> I'm using command line on Linux, but not doing anything fancy there, most of my Wesnoth work is on Windows.
20150822 08:17:00< shadowm> Hm.
20150822 08:17:37< vultraz> I know how to use TortoiseGit
20150822 08:17:39< vultraz> If you need help
20150822 08:17:40< shadowm> Starting a new branch is always an option, and if anything it can serve as a backup for your current branch.
20150822 08:17:41< vultraz> It's what I use
20150822 08:18:28< shadowm> Essentially, you'll want to rebase your branch on top of current master (which requires you to have an up to date master branch), so that the first two extraneous commits disappear.
20150822 08:18:41< shadowm> That is, the Ctrl+Return/Enter fix and subsequent merge.
20150822 08:18:57< wedge009> Yep, I didn't know back then to keep things in their own branch.
20150822 08:19:15< shadowm> The rest is a matter of using `git rebase --interactive` to squash "Use actual SDL_Window object in Windows Tray code" into the previous commit.
20150822 08:19:24< shadowm> I don't know if TGit has an equivalent option.
20150822 08:19:47< wedge009> I've played with rebase in Tortoise but haven't actually committed anything with it. I'll check on it later.
20150822 08:21:45< shadowm> And as I said, starting a new branch from your current branch allows you to make a backup in case you delete or otherwise mess up commits by mistake.
20150822 08:26:49< vultraz> wedge009: if you use  TGit for the rebase, you need to check the Force Rebase option, then go to where it says Pick, click on that next to the windows tray commit, and select Squash. Then do the same for any commits you want to get rid of and select Skip
20150822 08:29:18-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20150822 08:30:50-!- mjs-de [~mjs-de@x4db5afa9.dyn.telefonica.de] has joined #wesnoth-dev
20150822 08:31:03< wedge009> So Squash is supposed to smush it back into the 'base'?
20150822 08:31:23< Aginor> no, it squioshes it together with the previous one
20150822 08:31:30< vultraz> wedge009: Squash merges that commit with the one *directly below* it
20150822 08:33:28-!- irker601 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150822 08:40:26-!- Admiral_Obvious [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20150822 08:42:22-!- Appleman1234 [~Appleman1@KD106180031220.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20150822 08:45:42< wedge009> Okay, thanks.
20150822 08:47:54< vultraz> If you want to squash two commits not next to each other, use the Up an Down buttons to move the relevant commits next to each other
20150822 08:55:55< Aginor> ok, formatting has bene fixed and pushed (rebased to previous non-formatting commit"
20150822 08:56:35< Aginor> wedge009: thank you for helping me to test the hotkey changes and for helping out with SDL2 in windows, I appreciate it
20150822 08:56:54< Aginor> wedge009: I'll buy you a beer if I ever end up in your part of the world
20150822 09:16:56< wedge009> Aginor: Oh, you're doing most of the hard work. I'm just using this as an excuse to learn stuff while I help one of my favourite (if not the favourite) FOSS projects. And ha ha, I'll pass on the drinks, but pub food always go down well with me. (: Anyway, looks like it's finished compiling...
20150822 09:30:44< wedge009> Aginor: I presume you've tested this all on Linux side so I won't re-test there. On Windows, with SDL 1.2, it looks like you've matched what I got with my PR 470. But even better than that, I seem to have the same experience with SDL 2.0, which is great. I do notice sometimes my key combinations don't get picked up (maybe I let go of it too quickly) and only one key is read, but if I do it slowly there's no problem.
20150822 09:32:10< wedge009> With both SDL 1.2 and SDL 2.0 I notice the same problem as with my PR 470: Ctrl+Pause gets mis-read as Ctrl+Scroll Lock (Ctrl+Scroll Lock is okay) and Ctrl+Num Lock gets mis-read as Ctrl+Pause. But I suspect this may be a problem with Windows, my specific keyboard, with SDL or some combination thereof.
20150822 09:34:48< wedge009> Since the experience seems consistent in SDL 1.2 and 2.0, and is mostly correct, I vote in favour of PR 466. If it goes ahead you can kill off my PR 470 afterwards, it'll be redundant.
20150822 09:39:09< wedge009> Now... to see if this works okay on OS X! x.x
20150822 09:39:39< wedge009> Will the direct inclusion of SDL code be a problem?
20150822 09:54:11-!- Appleman1234 [~Appleman1@KD106180031220.au-net.ne.jp] has joined #wesnoth-dev
20150822 10:03:54< wedge009> Well, how about that. Using SDL_WINDOWPOS_UNDEFINED causes SDL to centre the window in the display. Very nice.
20150822 10:04:36< wedge009> shadowm: ^
20150822 10:05:42< vultraz> Have you guys fixed the hotkeys being listed multiple times sometimes?
20150822 10:05:44< vultraz> Just wondering
20150822 10:05:58< vultraz> (the bindings, I mean)
20150822 10:06:05< wedge009> When does that happen?
20150822 10:06:36< wedge009> If the default config has duplicates, I suspect there will still be duplicates listed.
20150822 10:07:46< wedge009> I don't think there will be duplicate hot-keys possible with PR 466, unless the user hacks the preferences file to duplicate entries him/herself.
20150822 10:07:58< vultraz> In current master, I can launch a new game, go to Menu, and see 'ctrl+j,'ctrl+j,'ctrl+j,'ctrl+j' as bindings for Scenario Objectives
20150822 10:08:17< wedge009> Oh, like that.
20150822 10:08:19< vultraz> er,  'ctrl+j,ctrl+j,ctrl+j,ctrl+j'
20150822 10:08:20< Aginor> vultraz: yes, I have
20150822 10:08:27< vultraz> ah, ok :)
20150822 10:08:29< Aginor> it's fixed in my PR
20150822 10:08:37< Aginor> (by virtue of rewrite)
20150822 10:08:48< wedge009> In my testing on PR 466 I couldn't duplicate repeating hot-keys that way.
20150822 10:08:49< wedge009> Either.
20150822 10:09:01 * vultraz pulls up a list of the open PRs atm
20150822 10:09:50< wedge009> Hmm, I couldn't duplicate that behaviour in master either, but oh well. ~shrugs~
20150822 10:10:25< Aginor> wedge009: thank you for doing the testing and reporting back
20150822 10:10:56< wedge009> No worries! Hope celticminstrel's (or others') testing on OS X goes just as smoothly.
20150822 10:11:00< vultraz> Ok so.. what PRs are ready for merging?
20150822 10:11:13< Aginor> I think that num lock might be one of those special keys where lots of interesting things can happen
20150822 10:11:50< wedge009> Aginor: It's the key code value - I think SDL just picks it up incorrectly. Caps Lock and Scroll Lock are okay.
20150822 10:11:51< Aginor> vultraz: 466 should preferably see a bit more review and testing before being merged, it's not been tested on OSX yet
20150822 10:12:04< Aginor> wedge009: sounds like upstream then
20150822 10:12:29< Aginor> wedge009: did you see ctrl+a being registered as ctrl+d any more?
20150822 10:13:35< wedge009> vultraz: I'll fix mine soon. I think shadowm is thinking about the SDL_gpu branch for my PR 455 and I need to add in the SDL_WINDOWPOS_UNDEFINED for PR 454.
20150822 10:14:12< wedge009> Aginor: Possibly. And no no, sorry to confuse you but the Ctrl+a/d thing was what I observed on straight SDL2 compilation from master (ie without your PR 466 rewrite).
20150822 10:14:25< Aginor> ah, yeah
20150822 10:14:39< Aginor> that's all flavours of broken
20150822 10:14:52< wedge009> Tasty and delicious, but you'll regret it later.
20150822 10:15:09< Aginor> I'm not even sure about that
20150822 10:16:29< Aginor> vultraz: https://github.com/wesnoth/wesnoth/pull/469 is mergable, but I will most likely depcreate the PR in a few days with a more proper rewrite of the offending code
20150822 10:17:08< Aginor> it gives gui1 textbox widget (some) support for proper input handling under SDL2
20150822 10:17:14< Aginor> but it has limitations
20150822 10:17:34< Aginor> it should be rewritten to use proper SDL_TextInputEvent under SDL2
20150822 10:17:58< vultraz> Ok I'll let you guys deal with all this then
20150822 10:18:05< vultraz> This is way over my head xD
20150822 10:18:08< Aginor> but that's a larger change and I am planning to do that after I've reviewed all GUI1 text input
20150822 10:18:36< Aginor> vultraz: if I had commit access I'd committed #469 as a quick nasty fix already
20150822 10:18:54< Aginor> it allows user hotkey and multiplayer chat to somewhat function under SDL2
20150822 10:19:05< Aginor> without it it's completely broken
20150822 10:19:29< vultraz> Want me to merge it?
20150822 10:19:44< Aginor> yes please :)
20150822 10:19:51< Aginor> as you can see, it's a 1-liner
20150822 10:20:18-!- irker197 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150822 10:20:18< irker197> wesnoth: Andreas Löf wesnoth:master 8a7cb4094490 / src/widgets/textbox.cpp: Quck fix for textbox input under SDL2 http://git.io/vs2zz
20150822 10:20:18< irker197> wesnoth: Charles Dang wesnoth:master a3e8ee38f5e7 / src/widgets/textbox.cpp: Merge pull request #469 from aginor/sdl2 http://git.io/vs2zg
20150822 10:20:32< Aginor> thank you
20150822 10:20:51< Aginor> hmm
20150822 10:21:20< Aginor> time to see how long it takes to compile wesnoth on my osx laptop
20150822 10:24:42-!- Appleman1234 [~Appleman1@KD106180031220.au-net.ne.jp] has quit [Ping timeout: 255 seconds]
20150822 10:25:10< Aginor> wedge009: what are you using when compiling wesnoth under windows?
20150822 10:27:47< wedge009> vultraz: Don't worry, it's mostly over mine too. x.x
20150822 10:28:22< wedge009> Aginor: Hot-key was okay without it for me, but floating boxes like debug command line needed it.
20150822 10:29:21< wedge009> Aginor: Originally I was using VC9/2008, but switched to VC14/2015 a few weeks ago (mainly to get rid of the crash on start-up of Map Editor). I also got all the dependencies myself (before I knew about the Wesnoth external library), (re)compiled some where necessary.
20150822 10:29:45< Aginor> wedge009: thanks
20150822 10:29:56< wedge009> I didn't say anything on dev channel till a week after the call for help because it took me that long just to get a working compilation! x.x
20150822 10:29:58< Aginor> I need to replicate that at some point
20150822 10:30:19< wedge009> It's probably easier to use the external library, but this way I'm able to play around with SDL2 myself.
20150822 10:30:27< Aginor> yeah
20150822 10:30:49< wedge009> I just duplicated the build configurations and set them to point to SDL2 instead of SDL1.2.
20150822 10:30:55< Aginor> I tried to compile SDL2 in VS2013 the other day, I was getting a include error for some direct x header
20150822 10:31:00< wedge009> o.O
20150822 10:31:08< wedge009> Don't recall that one...
20150822 10:31:09< vultraz> say what
20150822 10:31:14< Aginor> I should probably try to grab the latest one
20150822 10:31:39< Aginor> SDL2 itself, not wasnoth linked to SDL2 :)
20150822 10:31:50< vultraz> Oh
20150822 10:31:52< vultraz> Derp
20150822 10:31:52< wedge009> Sorry, I had to laugh at wasnoth. (:
20150822 10:31:57< wedge009> Indeed.
20150822 10:32:27< Aginor> I was trying to verify my assumptions about key handling in windows
20150822 10:32:53< Aginor> wedge009: I'm very grateful for your help with validating the hotkeys in windows
20150822 10:33:20< Aginor> wedge009: and windows testing and fixing in general
20150822 10:33:41< wedge009> Well, they did ask for more Windows developers/testers, right? :D
20150822 10:33:48< wedge009> But seriously, no worries!
20150822 10:34:04 * vultraz is on windows himself but is a c++ n00b
20150822 10:34:22< Aginor> vultraz: I've been on sick leave from work in the past two weeks so I've spent some of my time to get to know parts wesnoth
20150822 10:34:34< wedge009> <-- is still a relative Git newbie.
20150822 10:34:48< Aginor> vultraz: this is my largest foray in C++ for many years, I have spent the last few years doing C and Java and Python
20150822 10:34:56< wedge009> Oh, so that's why you were writing yesterday (Friday).
20150822 10:35:40< Aginor> wedge009: yeah, I will have less time available again next week
20150822 10:36:01< Aginor> and I'll be completely out of touch while away in Europe
20150822 10:36:16< Aginor> vultraz: have you done other OO languages in the past?
20150822 10:36:28< wedge009> I'm no expert myself. My first (what I would consider real) job was predominantly in C++ and I'd say I'm intermediate to moderately advanced at it, but my current job is Java and not too advanced at that either.
20150822 10:36:31< vultraz> No, I haven't
20150822 10:36:34< vultraz> I'm still in highschool
20150822 10:36:46< Aginor> ah ;)
20150822 10:36:47< wedge009> Oh. Well, it's good that you can learn it even then.
20150822 10:36:47< vultraz> Wesnoth was basically my introduction to programming
20150822 10:36:55< wedge009> Best place to start, I reckon!
20150822 10:37:00< Aginor> vultraz: excellent!
20150822 10:37:11< wedge009> Real code, reasonably big project.
20150822 10:37:21< Aginor> vultraz: if you ever need help/want to bounce ideas and the like, feel free to ask
20150822 10:37:26< vultraz> So I now have rudimentary C++ skills and a some reasonable lua skills
20150822 10:37:30< wedge009> Aginor: Glad you're feeling better and safe travels.
20150822 10:37:36< Aginor> wedge009: thanks
20150822 10:37:39< wedge009> You know more about Lua than I do, then.
20150822 10:38:29< vultraz> Heh
20150822 10:38:42< vultraz> Aginor: will do :)
20150822 10:39:04< Aginor> vultraz: I'm not an expert, but I will help if I can
20150822 10:40:16< Aginor> wedge009: what kind of java? java EE?
20150822 10:40:48-!- gandaro [~gandaro@wikipedia/Gorlingor] has joined #wesnoth-dev
20150822 10:42:07< wedge009> Just the standard stuff. I don't even deal with it directly. It's a financial services company, so we use a proprietary business tool that spits out Java code. But we do various other things as well, not just straight Java development. And some the team's internal tools are developed in Java.
20150822 10:42:27< Aginor> fair enough
20150822 10:43:21< wedge009> I did enjoy the previous job more in terms of software development, it was a tiny machine vision systems company so I got to learn and play around with industrial camera and hardware, lighting and other fun things while tying it all together in C++, PHP and MySQL.
20150822 10:43:31< wedge009> But this job is more stable.
20150822 10:43:37< Aginor> that sounds fun
20150822 10:44:23 * Aginor has dabbled with computer vision for fun in the past
20150822 10:44:50< Aginor> but yeah, steady money and steady work is good
20150822 10:49:57< wedge009> Glad you know what it is. It was actually the company of one of my former lecturers, since it was R&D the work was running out and he supported me in getting this current job.
20150822 10:50:10< wedge009> Newbie question: What does pick mean in rebase?
20150822 10:50:41< Aginor> wedge009: include the commit without any changes
20150822 10:50:47< Aginor> https://help.github.com/articles/about-git-rebase/
20150822 10:51:00< wedge009> 'RTM'. Thanks! (:
20150822 10:51:16< Aginor> :D
20150822 10:51:27< Aginor> I was trying to be nice about it :)
20150822 10:55:07< wedge009> It's okay. I normally try to find things myself, but since we were already talking about it here.
20150822 10:55:09< wedge009> ...
20150822 10:55:30< Aginor> but I also thought it could be useful going forward :)
20150822 10:55:42-!- prkc [~prkc@4E5CCDCF.dsl.pool.telekom.hu] has joined #wesnoth-dev
20150822 10:55:52< wedge009> Does rebasing take a long time normally?
20150822 10:56:17< wedge009> It's not a big and complex branch.
20150822 10:56:32< wedge009> Seems stuck on the Squash.
20150822 10:57:07< wedge009> Ah, I'll worry about it when I return. Haven't eaten yet. x.x
20150822 11:00:29< irker197> wesnoth: Nils Kneuper wesnoth:master 9a752aa3d9a4 / / (6 files in 5 dirs): updated French translation http://git.io/vs2Kc
20150822 11:00:31< irker197> wesnoth: Nils Kneuper wesnoth:1.12 981dc8f62317 / / (6 files in 5 dirs): updated French translation http://git.io/vs2KB
20150822 11:01:26< Aginor> wedge009: I've never used tortoisegit, but I'm happy to help if I can
20150822 11:01:41< Aginor> enjoy dinner
20150822 11:18:13< celticminstrel> shadowm: Are you saying I should not have removed this xgettext comment? https://github.com/CelticMinstrel/wesnoth/commit/c88a1be20efc0588015d4e797945ee2d44c26698#diff-0bcdc1d5fc9ca6f1eefe788ab95bc8caR282
20150822 11:19:26< celticminstrel> And do you want everything in that commit to be rebased into other commits? Or just the extra braces?
20150822 11:19:31< vultraz> wedge009: once you edit the commit message in the box, you have to click the Commit button in the bottom right of the window
20150822 11:20:03< vultraz> Else it will just sit there waiting for you
20150822 11:20:22< celticminstrel> As for PR 468/463, I have no idea if zookeeper has seen them.
20150822 11:20:46< celticminstrel> Ah, he has now.
20150822 11:20:54< zookeeper> yep
20150822 11:21:46-!- Appleman1234 [~Appleman1@KD036010156065.au-net.ne.jp] has joined #wesnoth-dev
20150822 11:24:55< Aginor> zookeeper: zookeeper have you had a chance to test https://github.com/wesnoth/wesnoth/pull/466 yet?
20150822 11:25:26< zookeeper> no, not yet
20150822 11:26:11< celticminstrel> And shadowm, what about the braces I added to existing code that was already missing them? Should I remove those, rebase them into some commit, or leave them in a separate commit?
20150822 11:37:17< wedge009> vultraz: Ah, that makes sense! Thanks.
20150822 11:37:25< celticminstrel> zookeeper: Do you want me to remove apply_to=attacks_left or leave it in?
20150822 11:38:11< zookeeper> celticminstrel, better to remove it
20150822 11:38:18< zookeeper> at least unless you can present some kind of usecase for it :p
20150822 11:41:18< celticminstrel> The only usecase I can imagine is the one I mentioned the last time we talked about, and it can already be done as an event anyway.
20150822 11:41:29< celticminstrel> ^about this
20150822 11:42:39< zookeeper> right
20150822 11:43:04< zookeeper> yeah, i don't think it's warranted. otherwise we could have a similar one for every direct-modifiable attribute, and that'd be silly
20150822 11:45:45-!- ypnos [~ypnos@lme51.informatik.uni-erlangen.de] has quit [Ping timeout: 244 seconds]
20150822 11:47:55< celticminstrel> Now I need to wait for shadowm before I rebase it...
20150822 11:53:28< celticminstrel> I can rebase the amla branch now though.
20150822 12:14:27-!- louis94 [~~louis94@109.129.243.95] has joined #wesnoth-dev
20150822 12:16:07-!- louis94 [~~louis94@109.129.243.95] has quit [Client Quit]
20150822 12:38:23< wedge009> vultraz and shadowm: Please have another look at https://github.com/wesnoth/wesnoth/pull/454, the commit history is all tidy now.
20150822 12:38:40< wedge009> And is ready for merging.
20150822 12:39:56< celticminstrel> Anyone know where GUI1 event handling is?
20150822 12:40:36< celticminstrel> ...oh.
20150822 12:40:47< celticminstrel> My initial guess turned out to be right.
20150822 12:41:52< Aginor> lots of compile errors
20150822 12:41:56< Aginor> celticminstrel: yes :)
20150822 12:42:04< celticminstrel> Class widget.
20150822 12:42:17< Aginor> it's distributed across many of them
20150822 12:42:32< Aginor> they each have their own
20150822 12:42:43< celticminstrel> Why does sdl_handler have so many subclasses.
20150822 12:43:07< celticminstrel> What the heck is the point of an escape_handler.
20150822 12:43:22< Aginor> someone probably thought it was a good idea
20150822 12:43:24< celticminstrel> Or a basic_handler for that matter.
20150822 12:43:47< celticminstrel> Okay so widget::handle_event.
20150822 12:44:09< celticminstrel> ...which... does nothing. :(
20150822 12:44:09< Aginor> and subclasses of widget
20150822 12:44:22< Aginor> they each override handle_event
20150822 12:45:50< celticminstrel> No, I'm not adding an explicit quit handler to every widget. That's just dumb.
20150822 12:46:33< Aginor> yeah
20150822 12:46:48< Aginor> I was making some comments about this yesterday about rewriting some of the event handling
20150822 12:47:09< Aginor> I'm not convinced that's a good idea either though
20150822 12:47:23-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20150822 12:47:37< celticminstrel> It could be a good idea to push more stuff up into the sdl_handler superclass though, maybe?
20150822 12:48:13< Aginor> only if it's actually onviked
20150822 12:48:17< Aginor> invoked
20150822 12:49:28 * celticminstrel is now adding widget::handle_event(event); to the first line of every subclassed handle_event.
20150822 12:49:35< Aginor> and it also depends on how the various functionality is delegated
20150822 12:49:47< Aginor> that's an antipattern :/
20150822 12:50:03< celticminstrel> Eh, it's GUI1, they're planning to get rid of it anyway. >_>
20150822 12:50:08< celticminstrel> Eventually.
20150822 12:50:15< Aginor> it's not going to happen anytime soon
20150822 12:50:20< celticminstrel> True. Still.
20150822 12:50:31< Aginor> look in the chat history for shadowm, pydsigner and me earlier
20150822 12:50:50< celticminstrel> I scanned through the history, but didn't read it in detail.
20150822 12:51:05< Aginor> I think there's a better way
20150822 12:51:22< pydsigner> celticminstrel: Probably a good thing
20150822 12:51:22< celticminstrel> Heh, the menu class already does it that way.
20150822 12:51:23< Aginor> but I will need to look at the code, which is not in front of me at the moment
20150822 12:51:35< celticminstrel> Because menu extends scrollarea.
20150822 12:53:36< celticminstrel> I wonder why file_menu is a separate class.
20150822 13:16:26< wedge009> vultraz and shadowm: Tidied https://github.com/wesnoth/wesnoth/pull/455 as well. It's not just about the SDL_gpu branch now.
20150822 13:27:54< celticminstrel> If there was some sort of global "need confirmation to quit" setting that's set to true when in a game or the editor and false otherwise...
20150822 13:34:27-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150822 13:46:35-!- jcnewjersey [~jcnewjers@pool-108-35-38-39.nwrknj.fios.verizon.net] has joined #wesnoth-dev
20150822 14:01:04-!- irker197 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150822 14:07:34-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150822 14:11:12-!- Yaiyan [~Yaiyan@46.101.48.31] has quit [Ping timeout: 240 seconds]
20150822 14:11:14-!- mjs-de [~mjs-de@x4db5afa9.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20150822 14:11:15-!- Soliton [~Soliton@wesnoth/developer/soliton] has quit [Ping timeout: 240 seconds]
20150822 14:11:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20150822 14:11:16-!- wedge010 is now known as wedge009
20150822 14:11:33-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20150822 14:11:40-!- mjs-de [~mjs-de@x4db5afa9.dyn.telefonica.de] has joined #wesnoth-dev
20150822 14:13:44-!- Yaiyan [~Yaiyan@46.101.48.31] has joined #wesnoth-dev
20150822 14:14:33-!- jcnewjersey [~jcnewjers@pool-108-35-38-39.nwrknj.fios.verizon.net] has quit [Ping timeout: 244 seconds]
20150822 14:18:53-!- jcnewjersey [~jcnewjers@pool-108-35-38-39.nwrknj.fios.verizon.net] has joined #wesnoth-dev
20150822 14:22:02-!- Kwandulin [~Miranda@p5B0086E6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150822 14:25:42< vultraz> celticminstrel: if we could get some people working on it as ardently as on this hotkey stuff, it could be removed in 1.13, probably 
20150822 14:26:00< vultraz> Fingers crosses
20150822 14:43:32< vultraz> Hmm...
20150822 14:43:39< vultraz> Who was... Johann
20150822 14:46:19-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20150822 14:46:19-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20150822 14:46:19-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150822 14:55:18-!- irker443 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150822 14:55:18< irker443> wesnoth: loonycyborg wesnoth:asio_wesnothd 6c7f907d4980 / src/server/ (server.cpp server.hpp): Port game join http://git.io/vsaRD
20150822 14:59:22< wedge009> Aginor: A question about your SDL2 build - when you see a sorted list, like the list of Actions and Bindings in the Hot-Key Preferences, is the heading of the sorted column washed out white or is the same as in SDL 1.2?
20150822 15:00:15-!- [Relic] [~Relic]@2602:306:33a3:6d30:55dd:ca61:52b5:798b] has joined #wesnoth-dev
20150822 15:07:20-!- Kwandulin [~Miranda@p5B0086E6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150822 15:09:04-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150822 15:09:36-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150822 15:13:38-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150822 15:14:11-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Max SendQ exceeded]
20150822 15:15:08-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150822 15:15:55< irker443> wesnoth: Charles Dang wesnoth:master e80952edbcea / data/campaigns/Heir_To_The_Throne/ (4 files in 2 dirs): HttT: removed very old story images that now look incredibly out of place http://git.io/vsa2R
20150822 15:20:07< wedge009> Wish we had replacements for those. The story and imagery was what drew me into Wesnoth in the first place.
20150822 15:21:22< vultraz> Well, the ones you see in the intro are still there. 
20150822 15:21:28< vultraz> wouldn't touch those
20150822 15:24:02< celticminstrel> Story9 makes me think of Isle of the Damned.
20150822 15:24:40< vultraz> Used to be used there
20150822 15:24:48< vultraz> Not now, but sometime in the past
20150822 15:24:58< celticminstrel> Is there now a new one there?
20150822 15:25:34< vultraz> No
20150822 15:25:56< vultraz> We don't have the art funds to commission enough storyart :(
20150822 15:26:02< celticminstrel> Aw.
20150822 15:28:50< vultraz> It would require somewhere upwards of $5k or more by a rough estimate to give every campaign some storyart
20150822 15:30:15-!- Kwandulin [~Miranda@p5B0086E6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150822 15:33:56< wedge009> I don't remember seeing this one before: http://lordbobofwesnoth.deviantart.com/art/The-Rise-of-Wesnoth-into-the-storm-517047831
20150822 15:34:36< wedge009> Actually, he's done a lot of story panels that I don't remember, looking at his gallery.
20150822 15:36:13< vultraz> I committed 12 generic storyscreens by him about 2 days ago
20150822 15:36:36< vultraz> But indeed, I don't remember that one..
20150822 15:36:43< vultraz> I'm trying to find the TRoW storyart thread
20150822 15:36:49< vultraz> Since we might as well do something with that as well
20150822 15:41:06< vultraz> gahh it's impossible to find stuff on the forums >_>
20150822 15:44:43< vultraz> Oh it's right under my nose >_>
20150822 15:58:51-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150822 16:03:35-!- travis-ci [~travis-ci@ec2-54-157-2-43.compute-1.amazonaws.com] has joined #wesnoth-dev
20150822 16:03:36< travis-ci> wesnoth/wesnoth#7160 (asio_wesnothd - 6c7f907 : loonycyborg): The build has errored.
20150822 16:03:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/76770746
20150822 16:03:36-!- travis-ci [~travis-ci@ec2-54-157-2-43.compute-1.amazonaws.com] has left #wesnoth-dev []
20150822 16:10:44-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150822 16:37:25-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20150822 16:40:57-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 265 seconds]
20150822 16:47:10-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150822 16:52:04-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150822 16:56:40-!- Octalot [~noct@91.141.1.25.wireless.dyn.drei.com] has joined #wesnoth-dev
20150822 17:05:22-!- Appleman1234 [~Appleman1@KD036010156065.au-net.ne.jp] has quit [Quit: Leaving]
20150822 17:06:07-!- Appleman1234 [~Appleman1@KD036010156065.au-net.ne.jp] has joined #wesnoth-dev
20150822 17:18:25-!- Octalot [~noct@91.141.1.25.wireless.dyn.drei.com] has quit []
20150822 17:42:18-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150822 18:16:36-!- irker443 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150822 18:32:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20150822 18:32:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20150822 18:34:31-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150822 18:36:00-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150822 18:37:10-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20150822 18:37:10-!- wedge010 is now known as wedge009
20150822 18:45:36-!- Elvish_Hunter [~irssi@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20150822 19:26:17< mattsc> In case anybody cares, I just added a few entires to the AI section of the EasyCoding wiki page.
20150822 19:26:40< mattsc> celticminstrel: do we agree that we should use rsync instead of ditto in PR646?
20150822 19:27:00< mattsc> If so, why don’t you change it and I’ll give it one more quick test and then merge it.
20150822 19:27:31-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Ping timeout: 256 seconds]
20150822 19:32:33-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150822 19:38:03-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150822 19:46:40< celticminstrel> I don't know anything about rsync, mattsc.
20150822 19:49:47< ancestral> What’s PR646?
20150822 19:57:11< Elvish_Hunter> celticminstrel: http://forums.wesnoth.org/viewtopic.php?f=10&t=43047&p=588754#p588754
20150822 20:04:47< Elvish_Hunter> shikadibot: seen gfgtdf
20150822 20:04:47< shikadibot> Elvish_Hunter: The person with the nick gfgtdf last spoke 13d ago.  12d 22h ago they left with the message: Ping timeout: 256 seconds
20150822 20:09:46< mattsc> celticminstrel: okay, let me say this then: from what I read about ditto, I don’t think it’s the ideal tool, while rsync does
20150822 20:10:22< mattsc> … the job correctly the way how I think it should be done  (although I could be wrong)
20150822 20:10:33< mattsc> (sorry, premature <return>)
20150822 20:11:06< mattsc> ancestral: I mistyped: https://github.com/wesnoth/wesnoth/pull/464
20150822 20:11:11< celticminstrel> That's why I set my client to require numpad enter to send. >_>
20150822 20:11:24< mattsc> :)
20150822 20:11:57-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 255 seconds]
20150822 20:12:02< ancestral> mattsc: ditto is basically just like cp, except it handles extended atrributes (and things like resource forks)
20150822 20:12:21< ancestral> It also skips over files that have read/write errors, helpful for recovering files from failing drives
20150822 20:13:01< celticminstrel> And we don't need to care about extended attributes or named forks here.
20150822 20:13:58< celticminstrel> I used it because of its behaviour when copying a folder to a folder - ditto copies the contents of the source folder into the destination folder, while cp copies the source folder itself into the destination folder, unless the destination folder doesn't already exist, in which case it copies the source folder to the path of the destination folder.
20150822 20:14:13< ancestral> Yes, that’s the other main difference
20150822 20:14:21< ancestral> It does a better job merging iirc
20150822 20:15:23< mattsc> ancestral: but we don’t want merging; that’s in particular one of the features I think is bad for this
20150822 20:15:43 * celticminstrel points Elvish_Hunter at forum response.
20150822 20:16:18< ancestral> So rm and mv?
20150822 20:16:18< mattsc> Let’s assume the name of a file in the source folder got changed, then we’ll end up with both versions in the new folder
20150822 20:16:33< celticminstrel> That destroys the source!
20150822 20:16:45< celticminstrel> Also it recopies everything even if nothing has changed.
20150822 20:16:54< ancestral> I see what you’re saying
20150822 20:16:54< celticminstrel> Which ditto might do too. I'm not sure.
20150822 20:17:08< ancestral> When/how often do you see people running this?
20150822 20:17:34< mattsc> `rsync -r —delete’ or `rsync -rv —delete’ does the job for you, nothing else needed
20150822 20:17:54< mattsc> ugh, stupid character autoreplacement!
20150822 20:17:59< celticminstrel> ancestral: Every time Wesnoth is built, if the translation directory exists (ie, if translations have already been built).
20150822 20:18:06< celticminstrel> vffcgvcfdxrfdeytdeswkj
20150822 20:18:20< celticminstrel> ...gah, accidentally hit enter after trying to clean my keyboard.
20150822 20:18:33< mattsc> hehe
20150822 20:19:10< ancestral> mattsc: Yeah, if you want, you can right-click in the text field and choose Substitutions > Smart Dashes
20150822 20:19:51< ancestral> (That is, to turn it off)
20150822 20:20:02< mattsc> right ---- that’s where it is
20150822 20:20:08< mattsc> thanks for the reminder
20150822 20:20:32< celticminstrel> You can also disable it globally in System Preferences, right?
20150822 20:20:45< ancestral> Yes, under the text substitutions
20150822 20:21:04< ancestral> Actually
20150822 20:21:09< ancestral> I’m not sure it’s there
20150822 20:21:26< mattsc> anyways, back to the topic, I suggest we use rsync, because it does the job “right” (the way how I understand it) with nothing else requires.
20150822 20:21:42< ancestral> Great
20150822 20:21:57< mattsc> The question I have is whether my understanding of “right” is correct
20150822 20:21:57< celticminstrel> Okay.
20150822 20:23:24< mattsc> celticminstrel: the only thing to be careful about is that, I think, you need to pass it the parent directory of translations/ at the destination, not translations/ itself
20150822 20:23:33< mattsc> but that’s very easily tested
20150822 20:24:09< celticminstrel> Are you still asking me to do it?
20150822 20:25:00< mattsc> Well, it’s your PR and this is a very minor change, so it would make sense to me that you do it.  But it’s up to you.
20150822 20:25:23< celticminstrel> 'kay
20150822 20:25:30< mattsc> Thanks.
20150822 20:25:33< mattsc> In any case, I need to go on a bicycle ride to get ice cream now  :)
20150822 20:25:37< mattsc> I’ll be back later.
20150822 20:29:14< celticminstrel> Yum.
20150822 20:31:30-!- gfgtdf [~chatzilla@f054053077.adsl.alicedsl.de] has joined #wesnoth-dev
20150822 20:32:00< gfgtdf> Elvish_Hunter, vultraz you had a a question ?
20150822 20:32:30< Elvish_Hunter> gfgtdf: not really, I just noticed that you were missing for a bit of time :)
20150822 20:32:43< gfgtdf> ok
20150822 20:38:26-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20150822 20:39:51-!- BeoXTC_ [3eb2b12a@gateway/web/cgi-irc/kiwiirc.com/ip.62.178.177.42] has joined #wesnoth-dev
20150822 20:40:49-!- lv92 [~lvlz@net-93-71-241-91.cust.vodafonedsl.it] has joined #wesnoth-dev
20150822 20:56:39< ancestral> We should totally close this thread: http://r.wesnoth.org/t41820
20150822 20:58:24< pydsigner> Yes\
20150822 20:59:06< pydsigner> But doing so would not be strictly justifiable
20150822 20:59:48-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150822 20:59:55< ancestral> It was an April Fool’s joke
20150822 20:59:58-!- gfgtdf [~chatzilla@f054053077.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.91.1 [Firefox 40.0.2/20150812163655]]
20150822 21:03:42< lv92> hi i'm new in this channel, is it normal that if i open bfw in a screen with a size (w,h) and i move it in another screen with (w1,h1) , any event (like press button) won't work beacuse their capture area has been moved? ( the only way to resolve it is press ctrl+f that puts the game in fullscreen mode )
20150822 21:04:16< Elvish_Hunter> Well, now I have to go. Bye!
20150822 21:04:23< lv92> i have bfw v.1.12.4 
20150822 21:04:40-!- Elvish_Hunter [~irssi@wesnoth/developer/elvish-hunter] has quit [Quit: Ciao!]
20150822 21:05:59< ancestral> lv92: What OS?
20150822 21:06:07< lv92> Archlinux
20150822 21:09:52< pydsigner> ancestral: I can't tell if it's actually an AFJ
20150822 21:10:27< ancestral> Hmmmm
20150822 21:10:32< ancestral> Maybe it’s not
20150822 21:10:34< pydsigner> Since Dugi updated it weeks after the original post
20150822 21:10:37< ancestral> The ultimate fool
20150822 21:11:07< ancestral> In that case, let it be
20150822 21:15:07< Ravana_> middle of page 1 says its joke
20150822 21:15:17< Ivanovic> shadowm: i finally created and uploaded the pandora binary for 1.12.4...
20150822 21:19:58< celticminstrel> So is zookeeper the only one who prefers [for] / [foreach] without [do]?
20150822 21:25:14-!- mjs-de [~mjs-de@x4db5afa9.dyn.telefonica.de] has quit [Remote host closed the connection]
20150822 21:34:31-!- pydsigner is now known as the-dark
20150822 21:35:04-!- the-dark is now known as pydsigner
20150822 21:44:23< lv92> i'm sorry if the question is easy.. i would like to start understanding wesnoth code, but i don't know where is the main entry point file (there are a plenty of files). some knows?
20150822 21:44:34< shadowm> src/wesnoth.cpp.
20150822 21:46:19< shadowm> IMHO if you really want to understand a particular piece of Wesnoth you should start by locating the code in charge of it, rather than attempt to walk through the jungle that starts at main().
20150822 21:48:50< shadowm> wedge009: I believe (the documentation doesn't specify) SDL_WINDOWPOS_UNDEFINED causes SDL to not do anything and let the window manager decide. There is another magic constant for centering, SDL_WINDOWPOS_CENTERED.
20150822 21:49:14< shadowm> ( https://wiki.libsdl.org/SDL_CreateWindow )
20150822 21:56:57< shadowm> celticminstrel: I'm saying that the line did not have a % before and now it does, hence the need for the comment.
20150822 21:57:28< lv92> thx,  i wanna understand more about the graphic components like button listbox ecc..
20150822 21:57:34< shadowm> I'm not entirely sure about how strong the need is, but if it'll cause problems we'll only find out after the next pot-update and I don't want to do one yet.
20150822 21:58:18< shadowm> lv92: Oh, that's great... :p We have two UI toolkits implementing (mostly) the same stuff and looking about exactly the same to an untrained eye.
20150822 21:58:56< celticminstrel> shadowm: I don't see a %?
20150822 21:59:09< shadowm> celticminstrel: "% accuracy".
20150822 21:59:10< celticminstrel> Ohh, line 282?
20150822 21:59:25< shadowm> Yes.
20150822 21:59:42< lv92> well is it inside src/gui/widgets?
20150822 21:59:55-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Remote host closed the connection]
20150822 22:01:20< shadowm> lv92: That would be GUI2, which is used to implement *most* new and existing UI dialogs. The alternative is GUI1, which is implemented by src/*dialog*.?pp and src/widget/*.?pp and is really only on life support, but is still in use by a few major UI components such as the (default) MP lobby, the Load Game dialog, the Preferences dialog, and the Add-ons Manager.
20150822 22:02:04< shadowm> celticminstrel: I didn't notice you added braces to preexisting code. Just leave them in a separate commit.
20150822 22:05:10-!- irker850 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150822 22:05:10< irker850> wesnoth: Wedge009 wesnoth:master 8610a67b87aa / src/desktop/windows_tray_notification.cpp: SDL2 Update for Windows Tray Notification http://git.io/vswIU
20150822 22:05:10< irker850> wesnoth: Wedge009 wesnoth:master 438e28df853e / data/core/about.cfg: Adding self to contributors as requested http://git.io/vswIT
20150822 22:05:10< irker850> wesnoth: Wedge009 wesnoth:master 7c67c1154072 / src/desktop/windows_tray_notification.cpp: Attempt to work-around persistent tray icon issue http://git.io/vswIk
20150822 22:05:11< irker850> wesnoth: Wedge009 wesnoth:master 4ade508a347b / src/video.cpp: Avoid inaccessible window title bar. http://git.io/vswII
20150822 22:05:12< irker850> wesnoth: Ignacio R. Morelle wesnoth:master f862f6964d67 / data/core/about.cfg src/desktop/windows_tray_notification.cpp src/video.cpp: Merge pull request #454 from Wedge009/SDL2_windows_tray http://git.io/vswIL
20150822 22:05:20< lv92> i got it, what about the graphic style? is it defined also by that component?
20150822 22:05:30< lv92> widget*
20150822 22:05:44-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20150822 22:05:44-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20150822 22:05:44-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150822 22:06:20< shadowm> lv92: In GUI2's case, it's all defined by WML in data/gui/default (in particular, data/gui/default/widget/button*.cfg). In GUI1's, it's all hardcoded into the C++.
20150822 22:06:57< celticminstrel> Whee.
20150822 22:07:16< celticminstrel> rebase -i, edit "Style and Plurals", reset HEAD^ ...
20150822 22:07:59< celticminstrel> It's probably easier if I merge the plurals bit into the existing commit as well as the braces.
20150822 22:09:10< celticminstrel> Is that acceptable?
20150822 22:09:36< irker850> wesnoth: Wedge009 wesnoth:master 0bc874626f27 / src/SDL_gpu/SDL_gpu/SDL_gpu.h: Use static inline in Visual C++. http://git.io/vswIS
20150822 22:09:38< irker850> wesnoth: Wedge009 wesnoth:master c4c2eaa25706 / .gitignore: Ignore WindowsTimeout http://git.io/vswI9
20150822 22:09:40< irker850> wesnoth: Wedge009 wesnoth:master a88e777e0534 / src/SDL_gpu/SDL_gpu/SDL_gpu.h: Check for _MSC_VER definition first http://git.io/vswIH
20150822 22:09:42< irker850> wesnoth: Wedge009 wesnoth:master bec01d798af6 / src/SDL_gpu/SDL_gpu/GL_common/ (SDL_gpu_GL_common.inl SDL_gpu_GL_matrix.c): Use static inline in Visual C++. http://git.io/vswIQ
20150822 22:09:44< irker850> wesnoth: Wedge009 wesnoth:master ce9104fbe17d / src/gui/dialogs/label_settings.cpp: Resolve compiler warning about conversion from unsigned int to bool. http://git.io/vswI7
20150822 22:09:46< irker850> wesnoth: Ignacio R. Morelle wesnoth:master 0d94262d9e44 / / (5 files in 4 dirs): Merge pull request #455 from Wedge009/Windows_updates http://git.io/vswI5
20150822 22:10:36< shadowm> celticminstrel: Sure...
20150822 22:11:06< lv92> oh i got it. tomorrow i'll continue to explore in deep thanks for now shadowm bb
20150822 22:11:21< shadowm> Okay.
20150822 22:11:44-!- lv92 [~lvlz@net-93-71-241-91.cust.vodafonedsl.it] has quit [Quit: Leaving.]
20150822 22:12:46< shadowm> zookeeper: So, how do you feel about renaming [advance] (the acquired AMLA description tag) to [advancement]?
20150822 22:13:11-!- Shackra [~Jorge@186.177.2.148] has quit [Read error: Connection reset by peer]
20150822 22:13:31< zookeeper> shadowm, i guess i don't mind? i'm not sure if i'm thinking of all implications that might have
20150822 22:14:26< shadowm> The only concrete implication I can think of right now is updating a bit of code in my campaign that copies modifications.advance[].
20150822 22:15:38< shadowm> There's no precedent for this stuff other than e.g. [resistance]/[defense]/[movement_costs] having the exact same name both in an [effect] and in the real thing ([movetype], [unit_type], [unit]).
20150822 22:16:22< celticminstrel> There's [trait] having the same name in [race], [unit_type], [modifications]... but unlike AMLAs, traits don't exist toplevel in [unit].
20150822 22:17:23< celticminstrel> I think consistency is good to increase macro reusability.
20150822 22:18:20< zookeeper> well didn't you say it's backwards-compatible anyway? to me that implies existing WML will still work
20150822 22:18:27< celticminstrel> Yeah.
20150822 22:18:37< celticminstrel> And existing wesnoth.add_modification() calls.
20150822 22:18:51< celticminstrel> I think what shadowm described would still need updating though.
20150822 22:19:01< zookeeper> i see
20150822 22:19:06< shadowm> There's [set_menu_item] vs. [menu_item] though.
20150822 22:19:44< shadowm> Though that's arguably a different situation because the former is a command and the latter is kind of not (it's an implementation detail of the events manager' serialization routine).
20150822 22:21:48< shadowm> celticminstrel: Shouldn't src/scripting/game_lua_kernel.cpp:328 include a warning about deprecated WML?
20150822 22:21:48< zookeeper> well, direct poking of gained advancements is probably exceedingly rare, so i don't mind
20150822 22:22:00< celticminstrel> shadowm: Good point.
20150822 22:22:25< celticminstrel> I'm not sure how to do that from the C++ side.
20150822 22:22:39< celticminstrel> helper.wml_error() would work if it was implemented in Lua.
20150822 22:22:39< shadowm> No idea how hard it'd ebe to do the same with [modifications][advance] in the hopefully extremely rare case that someone actually uses it directly.
20150822 22:22:55< zookeeper> on a completely unrelated note, i wonder what doofus means with the closing of his SoF PR... incidentally i was playtesting it today
20150822 22:25:24< shadowm> celticminstrel: Commit 4e6fd8a467c8a34d85bf50e92581b4970e6f4f64 seems to be the only precedent for visible Lua API deprecations I can find.
20150822 22:25:53< shadowm> Even though I'm fairly sure there was another case... Hm.
20150822 22:28:58-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150822 22:29:37< celticminstrel> Rebase complete.
20150822 22:30:06< shadowm> Anyway, the bottomline is I don't particularly care about [advance] vs. [advancement].
20150822 22:44:50-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150822 22:53:39-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150822 22:59:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20150822 23:05:01< shadowm> celticminstrel: The label settings dialogs displays empty entries when used on the tutorial (scenario 1).
20150822 23:06:02< shadowm> I guess it's because they leave user_team_name unspecified?
20150822 23:06:24< celticminstrel> That would seem a likely cause.
20150822 23:10:42-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150822 23:16:04-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150822 23:17:48-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 264 seconds]
20150822 23:20:57-!- prkc [~prkc@4E5CCDCF.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20150822 23:24:53< celticminstrel> ...wait, no.
20150822 23:26:02< celticminstrel> The string currently displayed there is team_info::name.
20150822 23:26:31< celticminstrel> I guess perhaps that wasn't a good choice. I wanted something unique, though.
20150822 23:26:40-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150822 23:26:48< celticminstrel> But current_player and user_team_name aren't unique...
20150822 23:30:22< celticminstrel> A third alternative would be the name of the team's leader, but again, that's not guaranteed to be unique.
20150822 23:30:49< Aginor> wedge009: it's washd out white. I thought it was just ugly by design, but it sounds like not :)
20150822 23:31:08< celticminstrel> Anyone have any suggestions>
20150822 23:31:11< celticminstrel> ^?
20150822 23:38:30< vultraz> celticminstrel: what are you trying to do?
20150822 23:40:48< irker850> wesnoth: Charles Dang wesnoth:master 9c2c079a3ab5 / projectfiles/CodeBlocks/wesnoth.cbp: Dropped HAVE_PYTHON and USE_GZIP defines http://git.io/vswne
20150822 23:45:37< Aginor> so many unused parameter compile warnings when compiling on OSX
20150822 23:46:10< Aginor> mattsc: do you see this as well or is my setup funky?
20150822 23:51:53-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150822 23:53:03< mattsc> Aginor: no, I don’t.  I have strict compiling enabled, so any warning would give me an error and cause compiling to be aborted.
20150822 23:53:13< Aginor> odd
20150822 23:53:34< mattsc> What OS X version?
20150822 23:53:42< mattsc> And you’re talking master, right?
20150822 23:53:49< Aginor> master, yes
20150822 23:53:52< mattsc> Are you doing Debug or Release builds?
20150822 23:53:58< Aginor> 10.10.5
20150822 23:54:04-!- rayblade53 [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20150822 23:54:10< Aginor> I'm compiling it with scons
20150822 23:54:24< Aginor> so same as if I were to build it with homebrew
20150822 23:54:50-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20150822 23:55:00-!- rayblade53 is now known as vultraz
20150822 23:55:03< mattsc> Aginor, I have the same OS X version, but am building Debug builds with Xcode 6.4
20150822 23:55:10< mattsc> No warnings for that at all.
20150822 23:55:37< Aginor> ok, I'll try the xcode project
20150822 23:55:47< mattsc> Well, other than that it complains that the Xcode project settings should be updated, but that’s a separate issue
20150822 23:55:54< Aginor> all my warnings seem to be unused parameters related to boost
20150822 23:56:10< mattsc> Ah, okay, that might be so.
20150822 23:56:24< mattsc> That’s not the case for the libs we’re using with Xcode.
20150822 23:56:31-!- gandaro [~gandaro@wikipedia/Gorlingor] has left #wesnoth-dev ["Leaving"]
20150822 23:56:37< mattsc> Make sure you download the ‘Mac compile stuff’ for that though.
20150822 23:57:08 * vultraz also gets a hell of a lot of unused boost param warnings
20150822 23:57:12< vultraz> Windows, though
20150822 23:57:30< Aginor> mattsc: the "mac compile stuff?"
--- Log closed Sun Aug 23 00:00:54 2015