--- Log opened Tue Aug 25 00:00:56 2015
20150825 00:02:10-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 246 seconds]
20150825 00:03:58-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150825 00:05:21-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150825 00:20:58-!- sailorswift [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150825 00:22:03-!- Appleman1234 [~Appleman1@KD119104007150.au-net.ne.jp] has quit [Ping timeout: 244 seconds]
20150825 00:23:36-!- sailorswift [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150825 00:33:06-!- sailorswift [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150825 00:39:31-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150825 00:40:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150825 00:44:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds]
20150825 00:46:56-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150825 00:55:30-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20150825 00:55:30-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20150825 00:55:30-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150825 01:19:12-!- Appleman1234 [~Appleman1@KD119104011009.au-net.ne.jp] has joined #wesnoth-dev
20150825 01:19:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150825 01:27:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20150825 01:27:40-!- irker088 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150825 01:27:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20150825 01:36:11-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20150825 02:49:54-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150825 02:52:36-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20150825 02:52:36-!- wedge010 is now known as wedge009
20150825 02:57:15-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20150825 03:34:36-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 264 seconds]
20150825 03:36:16-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150825 03:44:05-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150825 03:50:30< celticminstrel> When I show the GUI2 quit confirmation dialog over the GUI1 recall dialog, the No button does not work. ><
20150825 04:10:19-!- oldlaptop [~quassel@50-107-94-87.adr02.mskg.mi.frontiernet.net] has quit [Ping timeout: 246 seconds]
20150825 04:11:27-!- oldlaptop [~quassel@50-107-94-87.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150825 05:05:26-!- irker293 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150825 05:05:26< irker293> wesnoth: Charles Dang wesnoth:1.12 8c629d3ac45d / projectfiles/CodeBlocks/ (wesnoth.cbp wesnothd.cbp): Updated cb projectfile for use with boost 1.58 from latest SDK archive http://git.io/vsSfN
20150825 05:05:29< irker293> wesnoth: Charles Dang wesnoth:1.12 5cf2cd80d8d6 / projectfiles/CodeBlocks/wesnoth.cbp: Dropped unused search directories from cb projfile http://git.io/vsSfA
20150825 05:05:32< irker293> wesnoth: Charles Dang wesnoth:1.12 f3e8f2537513 / projectfiles/CodeBlocks/wesnoth.cbp: Dropped HAVE_PYTHON and USE_GZIP defines from cb projfile http://git.io/vsSfx
20150825 05:06:45< shadowm> Hm.
20150825 05:07:05< shadowm> The stone chasm bridge appears to be missing a unit elevation shift.
20150825 05:07:20< vultraz> Wesnoth stable should now build against the provided SDK
20150825 05:07:31< vultraz> in codeblocks
20150825 05:08:00< shadowm> http://i.imgur.com/stEQrp9.jpg
20150825 05:09:24< vultraz> You're right
20150825 05:09:55< shadowm> I believe the classic cave bridge does this right.
20150825 05:10:59< vultraz> I think you need unit_height_adjust=22
20150825 05:12:12< celticminstrel> Does it need the same adjust as the other cave bridge?
20150825 05:13:07< shadowm> Hard to tell before testing.
20150825 05:13:55< shadowm> The old cave bridge's elevation is 22.
20150825 05:14:39< shadowm> Someone botched up the addition of these to mainline.
20150825 05:14:59< shadowm> We already had the simple name/verbose editor_name convention, and these only have a verbose name.
20150825 05:16:16< shadowm> 22 seems to work nicely.
20150825 05:17:33-!- Kwandulin [~Miranda@p5B009470.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150825 05:18:30< shadowm> The plank bridge needs fixing too.
20150825 05:20:30-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150825 05:20:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150825 05:28:43-!- Kwandulin [~Miranda@p5B009470.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20150825 05:29:13-!- Shackra [~Jorge@186.177.2.148] has quit [Read error: Connection reset by peer]
20150825 05:31:57< irker293> wesnoth: Ignacio R. Morelle wesnoth:master 1e32ae69f524 / changelog data/core/terrain.cfg: Fix hanging, chasm stone, and plank bridge elevations http://git.io/vsSkL
20150825 05:32:00< irker293> wesnoth: Ignacio R. Morelle wesnoth:master a55bc9863088 / changelog data/core/terrain.cfg: Make hanging, chasm stone, and plank bridges conform to naming conventions http://git.io/vsSkt
20150825 05:32:03< irker293> wesnoth: Ignacio R. Morelle wesnoth:1.12 43ddf82e317f / changelog data/core/terrain.cfg: Fix hanging, chasm stone, and plank bridge elevations http://git.io/vsSkq
20150825 05:32:06< irker293> wesnoth: Ignacio R. Morelle wesnoth:1.12 417b5acff2f0 / changelog data/core/terrain.cfg: Make hanging, chasm stone, and plank bridges conform to naming conventions http://git.io/vsSkm
20150825 05:42:36-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20150825 05:43:44-!- Kwandulin [~Miranda@p5B00850F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150825 06:47:44-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150825 06:51:26-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has joined #wesnoth-dev
20150825 06:52:16-!- Xara [~Yangyf@2401:de00:1:6:90b0:1b96:cbcd:3951] has joined #wesnoth-dev
20150825 06:52:25-!- sailorswift [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150825 06:56:57-!- sailorswift [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds]
20150825 06:58:32-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has quit [Ping timeout: 246 seconds]
20150825 07:02:40-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has joined #wesnoth-dev
20150825 07:06:36-!- [Relic] [~Relic]@2602:306:33a3:6d30:c8cb:ec49:728c:912d] has quit [Quit: I press the magic X and all the weirdos go away!]
20150825 07:15:25-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has quit [Quit: Leaving]
20150825 07:23:59-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150825 07:24:26-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Client Quit]
20150825 07:40:52-!- sailorswift [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150825 07:41:00-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150825 07:50:28-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150825 07:54:53-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 246 seconds]
20150825 08:08:33-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150825 08:21:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150825 08:39:56-!- shouldIbequiet [b00aeb13@gateway/web/freenode/ip.176.10.235.19] has joined #wesnoth-dev
20150825 09:06:19< shouldIbequiet> Since dev resources are limited, is there any focus on creating some generic "sdl game engine for hex-based games" ? That could be used by many other projects and others could contribute to the generic core?
20150825 09:06:28-!- joet [~joet@host86-163-217-248.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150825 09:08:47-!- sailorswift [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150825 09:09:04-!- Durin_ [4d587c13@gateway/web/freenode/ip.77.88.124.19] has joined #wesnoth-dev
20150825 09:14:57-!- Durin_ [4d587c13@gateway/web/freenode/ip.77.88.124.19] has quit [Quit: Page closed]
20150825 09:18:18-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150825 09:21:45< vultraz_iOS> No there has not been focus on that
20150825 09:21:50< vultraz_iOS> It's an idea
20150825 09:22:21< Aginor> there's a number of frameworks that lend themselves in that direction if you want to explore it though
20150825 09:22:33< vultraz_iOS> But that ^
20150825 09:22:45< Aginor> but it's frameworks for making your game engine
20150825 09:30:11-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 252 seconds]
20150825 09:32:52-!- Appleman1234 [~Appleman1@KD119104011009.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20150825 09:45:01-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150825 09:45:14-!- Appleman1234 [~Appleman1@KD119104007168.au-net.ne.jp] has joined #wesnoth-dev
20150825 09:50:04-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150825 10:03:24-!- shouldIbequiet [b00aeb13@gateway/web/freenode/ip.176.10.235.19] has quit [Quit: Page closed]
20150825 10:12:21< wedge009> shadowm: Yes, that's my account that I made more than six years ago. What's it for, the groups? Also, I pushed colour cursors in SDL 1.2 with a manual preferences change. I don't know how to employ native colour cursors in SDL 2.0. And a shame it doesn't help in Linux but did it make any difference at all, good or bad? It definitely resolves the issue in Windows.
20150825 10:13:38-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has joined #wesnoth-dev
20150825 10:23:09-!- mjs-de [~mjs-de@f049247222.adsl.alicedsl.de] has joined #wesnoth-dev
20150825 10:26:55< vultraz> https://wiki.libsdl.org/SDL_CreateColorCursor ?
20150825 10:32:43< vultraz> wedge009: ^
20150825 11:16:33-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has quit [Ping timeout: 250 seconds]
20150825 11:21:05-!- subliun is now known as subliunhasareall
20150825 11:21:24-!- subliunhasareall is now known as subliun
20150825 11:25:05-!- horrowind [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150825 11:25:34-!- prkc [~prkc@51B77E5A.dsl.pool.telekom.hu] has joined #wesnoth-dev
20150825 11:29:20-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20150825 11:50:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150825 11:58:08-!- pydsigner is now known as pydsigner-work
20150825 12:08:31-!- Elvish_Hunter [~irssi@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20150825 12:11:16< irker293> wesnoth: Elvish_Hunter wesnoth:master def724816f8c / data/tools/wesnoth/wmltools.py: wmllint: fixed an error when trying to check if a file is a savegame http://git.io/vs99P
20150825 12:14:34-!- Kwandulin [~Miranda@p5B00850F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150825 12:37:31-!- Appleman1234 [~Appleman1@KD119104007168.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20150825 12:55:48-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20150825 12:55:48-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20150825 12:55:48-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150825 13:14:57-!- zhen [~zhen@1.58.62.20] has joined #wesnoth-dev
20150825 13:33:54-!- Appleman1234 [~Appleman1@KD119104016051.au-net.ne.jp] has joined #wesnoth-dev
20150825 13:34:59-!- Kwandulin [~Miranda@p5B00850F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150825 13:39:04-!- prkc [~prkc@51B77E5A.dsl.pool.telekom.hu] has quit [Ping timeout: 246 seconds]
20150825 13:39:15-!- Elvish_Hunter [~irssi@wesnoth/developer/elvish-hunter] has quit [Quit: Ciao!]
20150825 13:40:18-!- jcnewjersey [~jcnewjers@pool-108-35-38-39.nwrknj.fios.verizon.net] has quit [Ping timeout: 244 seconds]
20150825 13:41:04-!- prkc [~prkc@51B77E5A.dsl.pool.telekom.hu] has joined #wesnoth-dev
20150825 13:46:26-!- Xara [~Yangyf@2401:de00:1:6:90b0:1b96:cbcd:3951] has quit [Read error: Connection reset by peer]
20150825 13:58:39-!- roberpot [~roberpot@84.122.80.203.dyn.user.ono.com] has joined #wesnoth-dev
20150825 14:10:22-!- Appleman1234 [~Appleman1@KD119104016051.au-net.ne.jp] has quit [Ping timeout: 272 seconds]
20150825 14:14:39-!- horrowind [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20150825 14:32:00-!- horrowind1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150825 14:44:25-!- jcnewjersey [~jcnewjers@pool-108-35-38-39.nwrknj.fios.verizon.net] has joined #wesnoth-dev
20150825 14:45:16-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150825 14:50:26-!- gfgtdf [~chatzilla@x50abb10a.dyn.telefonica.de] has joined #wesnoth-dev
20150825 14:52:20-!- horrowind1 [~Icedove@2a02:810a:8b00:5298:21b:fcff:fee3:c3ff] has quit [Quit: horrowind1]
20150825 14:56:39-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20150825 14:59:36-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20150825 14:59:54-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20150825 15:01:36< irker293> wesnoth: gfgtdf wesnoth:master 9ba49ddf0ee6 / src/savegame.cpp: savegame compability code for era_blank change. http://git.io/vsQI7
20150825 15:03:09< gfgtdf> wedge009: you should alos add some compability code for the [advance] -> [advancement] change.
20150825 15:05:35< irker293> wesnoth: gfgtdf wesnoth:master 6270e0a6207f / src/savegame.cpp: remove outcommented code. http://git.io/vsQtP
20150825 15:07:01-!- Appleman1234 [~Appleman1@KD119104014234.au-net.ne.jp] has joined #wesnoth-dev
20150825 15:08:27-!- zhen [~zhen@1.58.62.20] has quit []
20150825 15:27:18-!- [Relic] [~Relic]@2602:306:33a3:6d30:65c2:c1ad:67b3:bc91] has joined #wesnoth-dev
20150825 15:30:16< gfgtdf> does anyone ubnderstand what tis code does: https://github.com/wesnoth/wesnoth/blob/d87b8457ed943e526932f70173f4bfaf9cc3d04a/src/gui/widgets/control.cpp#L494  ?
20150825 15:37:57< celticminstrel> Eh? What?
20150825 15:39:11< gfgtdf> ?
20150825 15:39:35< celticminstrel> What has wedge got to do with [advance] -> [advancement]?
20150825 15:41:41< gfgtdf> celticminstrel: hm i think got the names wrong
20150825 15:42:03< gfgtdf> let me look up who did that patch
20150825 15:42:11< celticminstrel> That was me.
20150825 15:42:36< celticminstrel> I included compatibility code, did I miss something important?
20150825 15:43:55< gfgtdf> celticminstrel: it would be nice to have some code to convert old savegames automatically when loading them, that code usually goes here https://github.com/wesnoth/wesnoth/blob/master/src/savegame.cpp#L866
20150825 15:44:55< celticminstrel> Old saves will still work, but I suppose it would be good to convert them. They might produce WML warnings otherwise.
20150825 15:45:06< gfgtdf> celticminstrel: specially for start-of-scenario saves since those usually have the highest changes to work after a esnoth update.
20150825 15:47:06-!- Kwandulin [~Miranda@p5B00850F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150825 15:47:48< celticminstrel> My quit confirmation thing isn't working very well. :/
20150825 15:47:53< gfgtdf> celticminstrel: hmm yes, i also think its easier for wml devs to have it converted automatically so they dont have to add compability code in their scenarios.
20150825 15:47:58< gfgtdf> celticminstrel: hmm why?
20150825 15:48:03< gfgtdf> celticminstrel: what does not work?
20150825 15:48:40< celticminstrel> Well, I tried to add a GUI2 confirmation if you try to quit while a GUI1 window is up, and for some reason the No button doesn't work.
20150825 15:49:10< gfgtdf> celticminstrel: but teh yes button works ?
20150825 15:49:13< celticminstrel> Yes.
20150825 15:49:31< celticminstrel> Plus I have no idea how to detect if you're in the editor so I can put up a confirmation then, and from GUI2's event handling code I'm not sure how to decide whether a confirmation is needed.
20150825 15:50:08< gfgtdf> celticminstrel: you use gui2::show_message or a custom dialog ?
20150825 15:50:13< celticminstrel> show_message
20150825 15:50:32< celticminstrel> Exactly the same as the existing confirmation when you press Esc.
20150825 15:51:23< gfgtdf> celticminstrel: maybe you could just add some new global variable so store whether you currently need save confirmation.
20150825 15:51:33< celticminstrel> Maybe. :/
20150825 15:52:51< gfgtdf> celticminstrel: when you click no just nothing happens ?
20150825 15:53:12< celticminstrel> Yes.
20150825 15:54:25< gfgtdf> celticminstrel: maybe its just that sdl just kepeps sending sdl_quit adain and again or something so that while it looks like nothing happens the dialod just pop up again and again ?
20150825 15:54:30< gfgtdf> celticminstrel: did you use a debugger?
20150825 15:54:51< celticminstrel> I didn't try debugging that point, no.
20150825 15:55:57< gfgtdf> celticminstrel: so does the show_message  call returns when you press No?
20150825 15:56:20< celticminstrel> I'll tell you in a minute.
20150825 16:10:00-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 264 seconds]
20150825 16:13:44-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150825 16:32:22-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150825 16:33:35< celticminstrel> Oh huh, it does.
20150825 16:35:04< celticminstrel> Oh! I think it's because every widget in a GUI1 dialog is separately registered as an event handler, so the message is going to appear that many times.
20150825 16:35:49< celticminstrel> So if I keep clicking No, it should eventually disappear.
20150825 16:36:00< celticminstrel> Yup, worked.
20150825 16:36:14< celticminstrel> Then I just need to somehow figure out how to make sure it only appears once.
20150825 16:36:37< gfgtdf> celticminstrel: i wonder why you putted the confirmation check into the gui1 wodet code insted of teh events.cpp code where teh throw quit previously was
20150825 16:37:25< celticminstrel> ...that would probably be a good place to put it, yeah. Maybe I'll start over and try it that way.
20150825 16:37:43< celticminstrel> I'd still want to find a way to detect being in the editor though.
20150825 16:37:57-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150825 16:38:48< gfgtdf> celticminstrel: hm my first try woudl beh having a global bool variable that is et to tu in controller_bases constructor and to falso in its destructor.
20150825 16:38:52-!- gfgtdf [~chatzilla@x50abb10a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 40.0.2/20150812163655]]
20150825 16:39:39< celticminstrel> Ah, if I do it that way, it could be a static member of controller_base and thus not quite so Evil.
20150825 16:43:31-!- gfgtdf [~chatzilla@x50abb10a.dyn.telefonica.de] has joined #wesnoth-dev
20150825 16:48:57-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150825 16:49:04< gfgtdf> celticminstrel: hmm having it in controller_base would make us need access the controler_base form events.cpp or similar
20150825 16:49:31< celticminstrel> True.
20150825 16:49:36< gfgtdf> celticminstrel: also it wouldne allow us to hae other dilaogs that bock quit, idk where there are some
20150825 16:49:59< celticminstrel> I assume you mean "block quit".
20150825 16:50:16< gfgtdf> yes
20150825 16:50:17< celticminstrel> There was actually one other thing I was going to consider.
20150825 16:50:32< gfgtdf> celticminstrel: but i curently cannot think of one
20150825 16:50:49< gfgtdf> celticminstrel: maybe if you already joined a game which havend staed yet or something
20150825 16:51:21< celticminstrel> Ah? So the controller isn't yet instantiated in the lobby?
20150825 16:51:32< celticminstrel> I was thinking the lobby should have a confirmation.
20150825 16:52:11< gfgtdf> celticminstrel: no controller is (roughly) when hexes are shown
20150825 16:52:42< celticminstrel> ...but before prestart, surely?
20150825 16:52:58< gfgtdf> celticminstrel: yes
20150825 16:53:58< gfgtdf> celticminstrel: but after teh mp lobby/mp connect
20150825 16:54:24< celticminstrel> Single-player does also have a lobby.
20150825 16:54:42< celticminstrel> Well, you click the Multiplayer button for it though, so I guess technically it's still multiplayer.
20150825 16:55:27< gfgtdf> celticminstrel: afaik you cannot pülay sp campaign with the multiplayer button by default
20150825 16:56:09< celticminstrel> No, you can't.
20150825 16:56:37< celticminstrel> I was referring to the last option after you click Multiplayer.
20150825 16:58:27< celticminstrel> Hmm.
20150825 16:58:54< celticminstrel> Since the main point here is Cmd+Q, I think I might be able to fix it in a MacOS-specific way.
20150825 16:59:18< celticminstrel> Cmd+Q invokes the menuitem with invokes the terminate method.
20150825 16:59:24< celticminstrel> ^which invokes
20150825 17:02:07-!- Kwandulin [~Miranda@p5B00850F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150825 17:05:16< gfgtdf> celticminstrel: hmm but tha wouldn wokr in dialogs i think ?
20150825 17:05:45< celticminstrel> I'm referring to the Wesnoth menu on the Mac menubar.
20150825 17:06:00< celticminstrel> It does work in dialogs. It doesn't know anything about Wesnoth's dialogs.
20150825 17:06:09< gfgtdf> celticminstrel: also i'd be happy if it woudl also be fixed for windows (http://gna.org/bugs/?22891)
20150825 17:06:57< celticminstrel> Eh? It doesn't close on Alt-F4?
20150825 17:08:03< gfgtdf> celticminstrel: yes
20150825 17:08:05< celticminstrel> Up until now I thought that Alt+F4 had the same behaviour I was getting with Cmd+Q.
20150825 17:08:15< celticminstrel> Which is, instantly quit no matter where you are, no confirmation.
20150825 17:08:17< gfgtdf> celticminstrel: yes thats how it shoudl be
20150825 17:08:23< celticminstrel> Shouldn't Alt+F4 trigger a quit event?
20150825 17:09:29< gfgtdf> celticminstrel: i think it doesnt idk if its a SDL bug, but there are also other sdl user who noticed that
20150825 17:10:09< celticminstrel> Well, like that bug said, it shouldn't be hard to patch a Windows-specific default into the hotkeys system.
20150825 17:10:31< celticminstrel> What I was thinking of trying is making Cmd+Q actually go through the hotkeys system instead of triggering an SDL quit event.
20150825 17:11:41< gfgtdf> celticminstrel: but im not shure how teh hotkey system works during dialogs
20150825 17:12:41< gfgtdf> celticminstrel: also teh quit hotkey only sends you back to main menu it doesnt close teh application
20150825 17:13:26< celticminstrel> I think that's a mistake.
20150825 17:13:57< celticminstrel> The map editor is the only place that, in my opinion, does it right - it has separate Quit to Titlescreen and Quit to Desktop.
20150825 17:14:14-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150825 17:14:35< gfgtdf> celticminstrel: i actuyll dont think its  mistake, at least i'd say its intended that the quit button in the menu takes you to teh titlescreen instead of closing teh application
20150825 17:14:58< celticminstrel> Cmd+Q should always be "Quit to Desktop". Cmd+W makes more sense to me for "Quit to Titlescreen" when in-game, though in the map editor, it makes more sense for "Close Map".
20150825 17:15:10-!- Appleman1234 [~Appleman1@KD119104014234.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20150825 17:15:30< celticminstrel> There's no reason why the game can't also have a Quit to Desktop option, is there?
20150825 17:15:40< gfgtdf> celticminstrel: i dont see a reason
20150825 17:16:17< celticminstrel> Almost finished building, now I'll find out whether clicking the close button also invokes the terminate method.
20150825 17:17:47< gfgtdf> celticminstrel: also note that closing a game in mp talkes you back to mp lobby and not to titlescreen
20150825 17:17:55< celticminstrel> True.
20150825 17:18:32< celticminstrel> Maybe vultraz's "Quit to Titlescreen" thing should be changed again to better reflect that...
20150825 17:18:52< gfgtdf> celticminstrel: y but i woundt know how t call it
20150825 17:19:06< celticminstrel> Okay.
20150825 17:20:45-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150825 17:24:10< celticminstrel> Cmd+Q is now captureable. Now to generalize the Quit to Desktop hotkey.
20150825 17:24:30-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20150825 17:24:31-!- wedge010 is now known as wedge009
20150825 17:26:34< celticminstrel> Pushing a keydown/keyup pair into the event queue though is a bit hackish... especially since I don't know what the scancode is or which command key was held.
20150825 17:34:53< celticminstrel> Why is Ctrl+Q assigned to "Quit to Titlescreen"...
20150825 17:35:12< celticminstrel> Well, whatever. I won't change that, at least for now.
20150825 17:35:32 * celticminstrel is looking at hotkeys.cfg.
20150825 17:35:56< celticminstrel> By the way, there's a lot of ifdef APPLE there, is ifdef WINDOWS also available?
20150825 17:37:28< celticminstrel> And why is Esc specially handled?
20150825 17:38:38< gfgtdf> celticminstrel: i think idefwindows is available but im not sure
20150825 17:38:47< gfgtdf> celticminstrel: idk why esc is handles specially
20150825 17:39:10< celticminstrel> I'm going to see if it works when I comment out that code and add it to hotkeys.cfg.
20150825 17:39:20< celticminstrel> Though I suppose I would need to delete my preferences for that to take effect.
20150825 17:39:48< celticminstrel> Or maybe not.
20150825 17:40:28< celticminstrel> Does Esc normally quit from titlescreen, or is that something I did?
20150825 17:41:49< celticminstrel> Does it normally do nothing at game creation screen?
20150825 17:41:57< gfgtdf> idk
20150825 17:42:39< celticminstrel> Well, when in-game and in the editor, this still looks like the exact same behabiour.
20150825 17:44:17< celticminstrel> It didn't quit from titlescreen before.
20150825 17:44:40< celticminstrel> But it did do nothing at game creation screen.
20150825 17:46:11< celticminstrel> (Actually I think it didn't do anything in the editor before, either, but I recall vultraz asking to figure out how to make that happen.)
20150825 17:53:11< celticminstrel> Clicking the close button still lacks confirmation now, but Cmd+Q works perfectly in-game and in the editor. Next: Make it work at the titlescreen and make sure it can be handled in some way from dialogs.
20150825 17:54:54< celticminstrel> I would like to know though if there's a better way to push a "fake" key event onto the SDL queue.
20150825 17:55:10< celticminstrel> Because I've currently set the scancode to -1 (aka 255).
20150825 17:57:52-!- gfgtdf [~chatzilla@x50abb10a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 40.0.2/20150812163655]]
20150825 18:03:54< celticminstrel> Well, I'll push what I have and see if mattsc, ancestral, or other OSX people (Aginor maybe?) have anything to say about it.
20150825 18:04:49< celticminstrel> It does affect non-OSX too though, for the Esc stuff.
20150825 18:05:42-!- irker293 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150825 18:12:29-!- Appleman1234 [~Appleman1@KD119104016023.au-net.ne.jp] has joined #wesnoth-dev
20150825 18:26:46-!- SpoOkyMagician [~chatzilla@cpe-74-136-81-20.kya.res.rr.com] has joined #wesnoth-dev
20150825 18:32:49-!- SpoOkyMagician [~chatzilla@cpe-74-136-81-20.kya.res.rr.com] has quit [Quit: thats all i needed to know. later]
20150825 18:59:36-!- joet [~joet@host86-163-217-248.range86-163.btcentralplus.com] has quit [Ping timeout: 244 seconds]
20150825 19:10:48-!- Elvish_Hunter [~irssi@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20150825 19:11:24< Elvish_Hunter> Hi all
20150825 19:13:33-!- irker205 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150825 19:13:33< irker205> wesnoth: Elvish_Hunter wesnoth:master b3a42b4c9bcb / data/tools/wmlscope: wmlscope: removed dependency from Pillow library http://git.io/vs58M
20150825 19:18:46< Elvish_Hunter> It looks like I wrote more comments than actual code in this one... but it was needed.
20150825 19:40:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150825 19:49:56-!- trewe [~trewe@2001:8a0:d127:d501:626c:66ff:fe92:9b7c] has joined #wesnoth-dev
20150825 20:05:47 * celticminstrel creates new pull request.
20150825 20:14:09< vultraz> Is 467 still valid then?
20150825 20:14:11< vultraz> or not
20150825 20:16:54< celticminstrel> Probably not.
20150825 20:17:16< celticminstrel> I'd hold off closing it until the new one is merged, personally.
20150825 20:19:29-!- Kwandulin [~Miranda@p5B00850F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150825 20:28:25-!- Elvish_Hunter [~irssi@wesnoth/developer/elvish-hunter] has quit [Quit: Ciao!]
20150825 20:39:36< celticminstrel> I have no idea how to find a child in a config and change the key it's associated to.
20150825 20:41:24< vultraz> a subtag?
20150825 20:41:34< celticminstrel> Yes.
20150825 20:41:37< celticminstrel> Not an attribute.
20150825 20:42:16< celticminstrel> I can certainly remove it and add it back with the new key, but I'd kinda prefer to make the change in-place if possible.
20150825 20:44:11< vultraz> config.has_child?
20150825 20:44:39-!- BeoXTC_ [3eb2b12a@gateway/web/cgi-irc/kiwiirc.com/ip.62.178.177.42] has joined #wesnoth-dev
20150825 20:44:59< celticminstrel> That tests if it's there, yes.
20150825 20:53:54-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150825 20:59:44< shadowm> 14:17:48 <gfgtdf> celticminstrel: also note that closing a game in mp talkes you back to mp lobby and not to titlescreen
20150825 21:00:00< shadowm> vultraz: You saw this, right?
20150825 21:00:35< vultraz> Did not see that
20150825 21:01:07< shadowm> "Quit to Titlescreen" does not do that in MP for obvious reasons.
20150825 21:01:55< vultraz> Hm
20150825 21:02:05< vultraz> I wonder if we can set it to Quit to Lobby there
20150825 21:02:24< vultraz> But not for a local mp game, since that *does* quit to titlescreen
20150825 21:02:29< vultraz> Or should that also drop to lobby
20150825 21:02:40< celticminstrel> There's no lobby to drop to in that case.
20150825 21:02:54< shadowm> Not really, the local game workflow is completely different from networked games.
20150825 21:03:23< shadowm> You should be able to detect whether you are in a networked game, though.
20150825 21:04:00< celticminstrel> The name is defined in the hotkey definition though, right?
20150825 21:05:51< vultraz> Yes
20150825 21:15:28-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150825 21:24:58-!- joet [~joet@host86-163-217-248.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150825 21:46:50-!- joet [~joet@host86-163-217-248.range86-163.btcentralplus.com] has quit [Ping timeout: 246 seconds]
20150825 21:47:03< aeth> Why is controller=number deprecated in 1.13? I use that feature.
20150825 21:52:41-!- Appleman1234 [~Appleman1@KD119104016023.au-net.ne.jp] has quit [Ping timeout: 244 seconds]
20150825 21:58:13-!- trewe [~trewe@2001:8a0:d127:d501:626c:66ff:fe92:9b7c] has quit [Quit: quit]
20150825 22:08:07-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Remote host closed the connection]
20150825 22:08:39-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150825 22:10:47-!- gfgtdf [~chatzilla@f054063252.adsl.alicedsl.de] has joined #wesnoth-dev
20150825 22:12:04< gfgtdf> aeth: i imeplemted previous_save_id= for mp campaigns which shoudl cover all usecases for controller=number so i deprecated the other thing
20150825 22:12:54< aeth> It doesn't cover my very niche use case of giving one player two sides (needed so the player can be both friendly and hostile, depending on the units)
20150825 22:13:05-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150825 22:13:19< aeth> Technically until I found that option I just manually gave myself sides 1 and 6 each time but it doesn't really make the intent clear if I ever publish it
20150825 22:13:53< gfgtdf> aeth: and why doe giving both sides teh same previous_save_id= not work for you ?
20150825 22:14:14< aeth> previous_save_id is settable? It's not in http://wiki.wesnoth.org/SideWML
20150825 22:14:34< gfgtdf> aeth: yes its a attribute of [side]
20150825 22:14:36-!- irker205 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150825 22:14:58< aeth> oh, so it's just an undocumented feature, then
20150825 22:15:02< gfgtdf> aeth: maybe i forgot to put it there
20150825 22:20:11< gfgtdf> aeth: edited the wiki page
20150825 22:30:30-!- prkc [~prkc@51B77E5A.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20150825 22:34:24-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150825 22:39:46-!- mjs-de [~mjs-de@f049247222.adsl.alicedsl.de] has quit [Remote host closed the connection]
20150825 22:41:05< celticminstrel> So does previous_save_id work for aeth?
20150825 22:43:45< gfgtdf> celticminstrel: since in 1.13.1 controller=<number> works internally by setting previous_syve_id i'd say yes.
20150825 22:44:41< celticminstrel> This situation is somehow confusing.
20150825 22:45:15< gfgtdf> celticminstrel: why?
20150825 22:45:34< celticminstrel> When you start an MP scenario, save_id is set to...
20150825 22:45:45< celticminstrel> The unit ID of the side's leader, right?
20150825 22:45:59< celticminstrel> And that ID defaults to something based on the unit's type, if I recall correctly.
20150825 22:46:17< celticminstrel> And then previous_save_id defaults to save_id.
20150825 22:46:39< gfgtdf> celticminstrel	: hmm yes but the id defaults to type happend very late
20150825 22:47:33< celticminstrel> So, previous_save_id is supposed to assign the side to the player who played that side in the previous scenario.
20150825 22:47:42< celticminstrel> But what if there wasn't a previous scenario?
20150825 22:48:01< celticminstrel> How does it decide which player receives which side?
20150825 22:48:19< gfgtdf> celticminstrel: player who join get teh next free slot
20150825 22:48:31< gfgtdf> celticminstrel: just liek it is in 1.12 and 1.10
20150825 22:49:04< celticminstrel> And then if there's another side with the same previous_save_id, they'll be assigned that side too?
20150825 22:49:17< gfgtdf> celticminstrel: you can give multi sides teh same previus_save_id= ina  first scenario of a mp campaign this then casues sides who take on of teh sides also to take the other sides with that previous_save_id
20150825 22:49:24-!- Appleman1234 [~Appleman1@KD119104014020.au-net.ne.jp] has joined #wesnoth-dev
20150825 22:49:27< gfgtdf> celticminstrel: yes
20150825 22:51:58< celticminstrel> gfgtdf: Acceptable? http://wiki.wesnoth.org/index.php?title=SideWML&diff=56719&oldid=56718
20150825 22:52:19< celticminstrel> I think it's worth being explicit about that.
20150825 22:52:26< gfgtdf> celticminstrel: yes
20150825 22:52:32< celticminstrel> 'kay
20150825 23:04:10-!- irker650 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150825 23:04:10< irker650> wesnoth: gfgtdf wesnoth:master 7cdeafd1e069 / src/savegame.cpp: Add savegame compability for [advancement]->[advance] patch http://git.io/vsdDR
20150825 23:04:26< gfgtdf> celticminstrel: i made a patch for savegame converrsion but its not tested^
20150825 23:05:42< gfgtdf> wait i think i made it the wrong way
20150825 23:06:02< gfgtdf> now it converts all [advancement] to [advance] :/
20150825 23:08:41-!- roberpot [~roberpot@84.122.80.203.dyn.user.ono.com] has quit [Quit: • IRcap • 8.72 •]
20150825 23:09:28< gfgtdf> hmmi tried to change those 3 lines bug githubs diff tells me that i changes teh whole file ...
20150825 23:11:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20150825 23:14:56< aeth> celticminstrel: I didn't test it yet because it's complicated e.g. because I use the same macro to define all scenarios in the campaign (the first scenario's different by one line)
20150825 23:15:19< aeth> And because no one does 1.13 MP no reason to spend time testing stuff on 1.13 right now
20150825 23:15:33< aeth> especially since that means I won't be able to do a test game today if I do
20150825 23:17:40-!- gfgtdf [~chatzilla@f054063252.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 40.0.2/20150812163655]]
20150825 23:18:04-!- gfgtdf [~chatzilla@f054063252.adsl.alicedsl.de] has joined #wesnoth-dev
20150825 23:20:31-!- pydsigner-work is now known as pydsigner
20150825 23:20:50< shadowm> gfgtdf: It looks fine to me though?
20150825 23:21:02< gfgtdf> shadowm: what do you mean ?
20150825 23:21:15< shadowm> 7cdeafd1e069's diff.
20150825 23:21:27< vultraz> Likewise
20150825 23:21:36< shadowm> Wait, are you trying to edit files using the GitHub web interface?
20150825 23:21:45-!- sfan786 [~sfan786@c-98-239-230-28.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150825 23:22:07< gfgtdf> shadowm: yes its just an easy string change.
20150825 23:22:18< shadowm> Don't use the GitHub web interface to edit files.
20150825 23:22:54< celticminstrel> gfgtdf: Thanks, I was trying my hand at that but had no idea how to do it.
20150825 23:23:32< celticminstrel> Maybe you changed tabs->spaces or newlines->CRLF?
20150825 23:24:35< celticminstrel> I've used the Github web interface, uh... I think twice. (Not in Wesnoth, of course. Either Waterbear or BoE.)
20150825 23:24:46< celticminstrel> (Probably)
20150825 23:25:56< gfgtdf> celticminstrel: i also used it aerlier for commits but it worked then
20150825 23:26:11< celticminstrel> I dunno.
20150825 23:26:30< celticminstrel> Well, I guess I'll delete the AMLA branch then, since you're doing the savefile conversion.
20150825 23:27:22-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150825 23:27:28< celticminstrel> Hi mattsc 
20150825 23:27:42< mattsc> Hey
20150825 23:28:23< celticminstrel> What about that translations thing?
20150825 23:31:23< celticminstrel> Oh hey, I discovered a nice easy way to delete all those irrelevant branches. "git push --all --prune".
20150825 23:31:54< celticminstrel> It still floods my activity feed though. Oh well.
20150825 23:32:37-!- Shackra_ [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150825 23:32:48-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 264 seconds]
20150825 23:35:39< mattsc> celticminstrel: I thought you were going to switch it over to rsync?
20150825 23:38:35-!- Shackra_ [~Jorge@186.177.2.148] has quit [Ping timeout: 265 seconds]
20150825 23:38:48-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150825 23:41:33-!- sfan786 [~sfan786@c-98-239-230-28.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150825 23:42:36-!- travis-ci [~travis-ci@ec2-54-87-115-76.compute-1.amazonaws.com] has joined #wesnoth-dev
20150825 23:42:37< travis-ci> wesnoth/wesnoth#7209 (master - 7cdeafd : gfgtdf): The build was broken.
20150825 23:42:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/77242666
20150825 23:42:37-!- travis-ci [~travis-ci@ec2-54-87-115-76.compute-1.amazonaws.com] has left #wesnoth-dev []
20150825 23:43:53< gfgtdf> ^ Just some random timouts on some tests.
20150825 23:44:07< gfgtdf> i think i'll do the savegame fix tomorrow
20150825 23:52:29-!- gfgtdf [~chatzilla@f054063252.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 40.0.2/20150812163655]]
20150825 23:59:23-!- framling [~user@c-50-186-43-50.hsd1.or.comcast.net] has quit [Read error: Connection reset by peer]
--- Log closed Wed Aug 26 00:00:00 2015