--- Log opened Mon Aug 31 00:00:18 2015
20150831 00:15:06-!- jinblack [~jinblack@ip184-189-234-229.sb.sd.cox.net] has quit [Remote host closed the connection]
20150831 00:38:49< aquileia> If any Finnish / Polish speakers are around, is it correct if I translate "user data" (referring to the userdata directory) with "Käyttäjän tietojen" / "Dane użytkownika"?
20150831 00:40:04-!- [Relic] [~Relic]@2602:306:33a3:6d30:7540:6140:a58e:3290] has quit [Quit: I press the magic X and all the weirdos go away!]
20150831 00:43:21< aquileia> On the other hand, thanks to all the translators who already translated the "User data:" string in wesnoth-lib
20150831 00:47:26-!- [Relic] [~Relic]@2602:306:33a3:6d30:cc74:8634:2116:123] has joined #wesnoth-dev
20150831 00:51:39< aquileia> I'm unsure whether the genitive suffix '-jen' is correct in this context or whether it should be "Käyttäjän tieto"
20150831 00:54:18< aquileia> "Käyttäjän tiedot" seems to be widely used for login data, so it's a mismatch, I guess... but I still don't know whether to keep or drop the -jen
20150831 01:02:23-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150831 01:07:08-!- new_one [~new_one@2604:a880:1:20::22e:d001] has quit [K-Lined]
20150831 01:07:10-!- EliDupree [~quassel@2604:a880:800:10::99a:2001] has quit [K-Lined]
20150831 01:07:10-!- legoktm [~quassel@wikipedia/Legoktm] has quit [K-Lined]
20150831 01:16:02-!- irker734 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150831 01:16:02< irker734> wesnoth: aquileia wesnoth:master 10023c9290de / / (5 files in 2 dirs): Windows uninstaller: Add option to delete userdata dir http://git.io/vG83m
20150831 01:17:34< aquileia> shadowm: Do I need to backport this to 1.12 (with detection where the userdata dir actually is) ?
20150831 01:17:55< shadowm> Do you want to do it?
20150831 01:18:55< aquileia> Not really, but I guess the user requesting it (http://forum.wesnoth.org/viewtopic.php?f=4&t=43075) probably wanted it for 1.12
20150831 01:21:29-!- gfgtdf_ [~chatzilla@f054060016.adsl.alicedsl.de] has joined #wesnoth-dev
20150831 01:24:10-!- gfgtdf [~chatzilla@f054174118.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20150831 01:24:24-!- gfgtdf_ is now known as gfgtdf
20150831 01:37:15-!- irker734 [~irker@uruz.ai0867.net] has quit [Ping timeout: 240 seconds]
20150831 01:37:15-!- {V} [~V@105-70-ftth.on.nl] has quit [Ping timeout: 240 seconds]
20150831 01:37:36-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 264 seconds]
20150831 01:37:45-!- {V} [~V@105-70-ftth.on.nl] has joined #wesnoth-dev
20150831 01:39:37-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150831 01:42:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20150831 01:42:21-!- wedge010 is now known as wedge009
20150831 01:46:06-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150831 01:51:00< shadowm> gfgtdf: :\
20150831 01:58:55-!- jinblack [~jinblack@ip184-187-174-106.sb.sd.cox.net] has joined #wesnoth-dev
20150831 01:59:00-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Ping timeout: 246 seconds]
20150831 02:02:58-!- Guni [~chatzilla@71-36-190-61.phnx.qwest.net] has joined #wesnoth-dev
20150831 02:03:23< Guni> Hi!
20150831 02:03:32-!- jinblack [~jinblack@ip184-187-174-106.sb.sd.cox.net] has quit [Ping timeout: 244 seconds]
20150831 02:03:38< shadowm> Hi there.
20150831 02:09:48< Guni> I'm interested in contributing.
20150831 02:11:44-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20150831 02:11:44-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20150831 02:11:44-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150831 02:12:53< shadowm> Guni: Have you looked at your starting guide topic yet? Is there anything in particular that you are interested in doing? (Also, have you obtained and compiled the repo version yet?)
20150831 02:15:59-!- gfgtdf [~chatzilla@f054060016.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 40.0.3/20150826023504]]
20150831 02:17:11< Guni> I don't have a great understanding of C++ so I was looking into Python. I'm very much an amateur. If by starting guide you mean the compiling guide I'm looking at that right now.
20150831 02:17:31< shadowm> I mean this post: http://forums.wesnoth.org/viewtopic.php?t=42911
20150831 02:18:46< Guni> Oh I see.
20150831 02:20:26-!- [Relic] [~Relic]@2602:306:33a3:6d30:cc74:8634:2116:123] has quit [Quit: I press the magic X and all the weirdos go away!]
20150831 02:23:12< Guni> I'll do some reading and get back to you.
20150831 02:27:50-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Quit: leaving]
20150831 02:28:47-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20150831 02:29:12-!- enchilado is now known as aeonchild
20150831 02:57:21-!- jinblack [~jinblack@ip184-187-174-107.sb.sd.cox.net] has joined #wesnoth-dev
20150831 03:07:00-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 250 seconds]
20150831 03:10:34-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150831 03:22:24-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 272 seconds]
20150831 03:24:03-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150831 03:58:32-!- legoktm [~quassel@2604:a880:800:10::1c2:b001] has joined #wesnoth-dev
20150831 03:58:34-!- legoktm [~quassel@2604:a880:800:10::1c2:b001] has quit [Changing host]
20150831 03:58:34-!- legoktm [~quassel@wikipedia/Legoktm] has joined #wesnoth-dev
20150831 04:15:37-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 268 seconds]
20150831 04:17:19-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150831 04:19:11< iceiceice> shadowm: there?
20150831 04:19:33< shadowm> Yes.
20150831 04:19:57< shadowm> Probably. My connection is antagonizing me again.
20150831 04:35:32< iceiceice> sorry, i didnt see that you responded
20150831 04:35:46< iceiceice> you're the last person to take a good look at preprocessor code, right?
20150831 04:35:53< iceiceice> do you know what's going on in these lines?
20150831 04:35:53< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/serialization/preprocessor.cpp#L570
20150831 04:36:06< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/serialization/preprocessor.cpp#L1111
20150831 04:36:19< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/serialization/preprocessor.cpp#L1122
20150831 04:36:29< iceiceice> where its just newing things and not storing the pointers that are returned by new?
20150831 04:36:36< iceiceice> aren't those all memory leaks?
20150831 04:38:47< shadowm> I was explained this ages ago I think.
20150831 04:39:57< iceiceice> i see
20150831 04:40:03< iceiceice> so i guess ownership is transferred here or something? https://github.com/wesnoth/wesnoth/blob/master/src/serialization/preprocessor.cpp#L383
20150831 04:40:47< iceiceice> man that sure makes for squirrelly looking code O.o
20150831 04:41:42< shadowm> silene was probably the only person left by 2009 who ever understood the whole thing enough to document and rewrite parts of it.
20150831 04:42:20< shadowm> Unfortunately it doesn't seem like he documented the ownership policy used here.
20150831 04:44:19-!- travis-ci [~travis-ci@ec2-54-167-2-118.compute-1.amazonaws.com] has joined #wesnoth-dev
20150831 04:44:20< travis-ci> aquileia/wesnoth#22 (travis-9000 - dadbc65 : aquileia): The build has errored.
20150831 04:44:20< travis-ci> Build details : https://travis-ci.org/aquileia/wesnoth/builds/77984753
20150831 04:44:20-!- travis-ci [~travis-ci@ec2-54-167-2-118.compute-1.amazonaws.com] has left #wesnoth-dev []
20150831 04:55:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150831 04:57:42< zookeeper> aquileia, out of those three, "Käyttäjän tiedot" is by far the most appropriate one
20150831 04:58:15< shadowm> Argh I give up, I can't find the conversation.
20150831 05:04:15< shadowm> Fun out of context quote: 20100804 19:46:32< silene> the preprocessor is designed so that it doesn't use any memory
20150831 05:05:16< zookeeper> O.o
20150831 05:05:28< shadowm> What he really means is that it's designed to give you the data you need by treating it as a stream and not keep any intermediate data around.
20150831 05:11:27-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 252 seconds]
20150831 05:12:02-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20150831 05:12:51-!- irker189 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150831 05:12:51< irker189> wesnoth: Quentin Pradet wesnoth:master f71784a05bbf / src/filesystem_boost.cpp: Fix get_exe_dir on OS X http://git.io/vG89v
20150831 05:12:51< irker189> wesnoth: Ignacio R. Morelle wesnoth:master 385cd4221593 / src/filesystem_boost.cpp: Merge pull request #440 from pquentin/master http://git.io/vG89f
20150831 05:24:17< shadowm> zookeeper: Re https://github.com/ln-zookeeper/wesnoth/commit/95bab79eab497204d015ff4488a19860fbd5ba37
20150831 05:24:53< shadowm> Is unit_attack *ever* called with a NULL pointer for the extra_hit_sounds argument after this commit?
20150831 05:25:50< zookeeper> doesn't look like it
20150831 05:25:50< shadowm> I could only find one call to this function and it's changed in commit https://github.com/ln-zookeeper/wesnoth/commit/9f27fb73f44bf1c84f3d23bdcd1f81f901ef3a53 .
20150831 05:26:09< shadowm> So I'm unsure there's any point to this argument being a pointer and optional.
20150831 05:27:39< shadowm> Although the function's signature already sucks before that commit.
20150831 05:28:43< shadowm> Um.
20150831 05:28:59< shadowm> Oh, I'm looking at 1.12.
20150831 05:29:15< shadowm> Why did it become sucky post-1.12? :\
20150831 05:29:42< shadowm> Whatever, I'm not about to question or clean up the display code.
20150831 05:32:52< shadowm> zookeeper: The code looks fine to me. I'm not sure why this has to be in [game_config] as opposed to be part of the weapon specials themselves, though.
20150831 05:33:19< shadowm> This covers those three specials just fine. What if I want something different for a custom special?
20150831 05:34:00< zookeeper> basically because it'd have been awkward to pass the special-specific sound info all the way to that part of the code, going through IIRC at least one function where everything is passed as arguments, making a huge mess
20150831 05:34:17< shadowm> There's always the old-fashioned way of playing sounds in animations directly, sure, but privileging core specials over the rest seems like a step backwards with regards to game customization.
20150831 05:37:28< shadowm> zookeeper: One additional argument would make a huge mess?
20150831 05:37:51< zookeeper> one additional argument for each special type
20150831 05:38:16< shadowm> String table argument?
20150831 05:38:29< shadowm> The key can be the special id and the value the sound filename.
20150831 05:38:55< shadowm> Assuming special ids are still known at that point, of course.
20150831 05:40:37< zookeeper> i don't recall the specifics anymore, really
20150831 05:45:23< irker189> wesnoth: Quentin Pradet wesnoth:1.12 5ca8d2b6e5c7 / src/ (filesystem.cpp filesystem_boost.cpp): Fix get_exe_dir on OS X http://git.io/vG85Y
20150831 05:49:07< shadowm> zookeeper: Have you reviewed #477 WML API-wise?
20150831 05:53:03< zookeeper> shadowm, maybe it'd be possible to have a vector of sounds in attack.*pp:battle_context_unit_stats, but... i dunno, i don't have any specific ideas about how to do it
20150831 06:05:08< zookeeper> shadowm, i've... looked at it
20150831 06:05:48< shadowm> Is it a 'yay' or 'nay' on your part?
20150831 06:08:04< zookeeper> it's... uh... i don't know, really.
20150831 06:08:52< zookeeper> i mean, sure the functionality is nice even if very rarely needed and even then only in UMC-land, but i can't say much about the code
20150831 06:10:14< shadowm> Well, if yo don't have an opinion on the matter of syntax, then I suppose it's up to me to try it out and decide.
20150831 06:10:17< shadowm> *you
20150831 06:10:50< celticminstrel> I'm also open to alternate syntaxes, if that's the only issue.
20150831 06:20:08-!- Kwandulin [~Miranda@p5B008308.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150831 06:35:41-!- ancestral [~ancestral@108-249-32-209.lightspeed.mdsnwi.sbcglobal.net] has joined #wesnoth-dev
20150831 07:02:42-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 244 seconds]
20150831 07:03:18-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150831 07:10:28-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20150831 07:22:26< shadowm> ancestral: Just to be on the safe side, can you confirm that Wesnoth from the 1.12 branch still runs on OS X (both as an .app and otherwise) after commit 5ca8d2b6e5c7 (pushed earlier) as soon as you have some time?
20150831 07:22:53-!- Shackra [~Jorge@186.177.2.148] has quit [Remote host closed the connection]
20150831 07:23:00< ancestral> shadowm: On the road, going to bed, I’ll test tomorrow
20150831 07:23:21-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 255 seconds]
20150831 07:26:21< shadowm> Okay.
20150831 07:28:13-!- ancestral [~ancestral@108-249-32-209.lightspeed.mdsnwi.sbcglobal.net] has quit [Quit: End Transmission.]
20150831 07:39:05-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has joined #wesnoth-dev
20150831 07:47:06-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 260 seconds]
20150831 07:55:00-!- jinblack [~jinblack@ip184-187-174-107.sb.sd.cox.net] has quit [Ping timeout: 264 seconds]
20150831 08:01:15-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Disconnected by services]
20150831 08:01:40-!- Ravana__ [~Ravana@53-113-190-90.dyn.estpak.ee] has joined #wesnoth-dev
20150831 08:03:28-!- Ravana__ is now known as Ravana_
20150831 08:03:45-!- Ravana_ [~Ravana@53-113-190-90.dyn.estpak.ee] has quit [Changing host]
20150831 08:03:45-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20150831 08:05:25-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev
20150831 08:11:03-!- travis-ci [~travis-ci@ec2-54-167-2-118.compute-1.amazonaws.com] has joined #wesnoth-dev
20150831 08:11:04< travis-ci> aquileia/wesnoth#23 (travis-9000 - e2a952a : aquileia): The build failed.
20150831 08:11:04< travis-ci> Build details : https://travis-ci.org/aquileia/wesnoth/builds/78000760
20150831 08:11:04-!- travis-ci [~travis-ci@ec2-54-167-2-118.compute-1.amazonaws.com] has left #wesnoth-dev []
20150831 08:40:55-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150831 08:41:43-!- Guni [~chatzilla@71-36-190-61.phnx.qwest.net] has quit [Remote host closed the connection]
20150831 08:42:35-!- kahootbird [~kahootbir@50.147.13.77] has joined #wesnoth-dev
20150831 08:48:46-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150831 08:55:19-!- mjs-de [~mjs-de@f049164238.adsl.alicedsl.de] has joined #wesnoth-dev
20150831 09:25:24-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20150831 10:03:34< Soliton> zookeeper: https://github.com/ln-zookeeper/wesnoth/commit/212ef61fff529fafc6b2955b9ce49dfd5df768ca as visible there unit_animation.cpp already has code to play poison sound. does that just not work since you're extra hit sounds also take poison into account?
20150831 10:04:10-!- Kwandulin [~Miranda@p5B008308.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150831 10:28:55< zookeeper> Soliton, no, that's the animation for taking damage from poison at turn start
20150831 10:29:12-!- emlai [emil@melkki.cs.helsinki.fi] has left #wesnoth-dev []
20150831 10:32:16< zookeeper> that is, completely unrelated to the poisonING sounds, except i just removed the hardcodedness
20150831 10:46:31< irker189> wesnoth: aquileia wesnoth:master f986fe7063e6 / packaging/windows/translations.nsh po/wesnoth-lib/fi.po: Fixup Finnish translation in 10023c9290de http://git.io/vGBZD
20150831 11:01:50< Soliton> ah, ok.
20150831 11:06:47< Soliton> zookeeper: another stupid question: doing the sounds as a regular animation in WML is not possible since it depends on how the fight goes?
20150831 11:16:00< zookeeper> no, it depends on the animation system architecture somehow... can't do several separate conditionals (like hit and miss sounds + possible poison sound) without creating several versions of the animation
20150831 11:16:52< Soliton> ah, so possible but clumsy?
20150831 11:17:07< zookeeper> yeah. but, of course, if you for example have an item which gives your melee weapon poison, then you couldn't have the sound play at all
20150831 11:17:15< zookeeper> because you'd still use the old animation
20150831 11:17:38< zookeeper> which is actually the more relevant issue IMO
20150831 11:17:52< Soliton> surely you could also update the animations with said item? :-P
20150831 11:19:26< zookeeper> well i don't we can give every unit in the game alternative animations for every kind of poison/slow item they may get
20150831 11:19:44< zookeeper> +think
20150831 11:20:18< zookeeper> or, rather, make the item grant every animation on every unit it could conceivably have to affect :p
20150831 11:20:27-!- aquileia [863ca5d4@gateway/web/freenode/ip.134.60.165.212] has joined #wesnoth-dev
20150831 11:20:36< Soliton> yeah ok. just wanted to make sure that "doing it properly" is not easy at all.
20150831 11:21:55-!- prkc [~prkc@51B77E5A.dsl.pool.telekom.hu] has joined #wesnoth-dev
20150831 11:22:07< aquileia> shadowm: The PR for the Trusty beta is ready (as stated in the description, we might only want to merge the first commit for now)
20150831 11:22:09< zookeeper> sadly, it's not
20150831 11:22:48< Soliton> zookeeper: just one small technical note the extra_hit_sounds variable should be defined in the smallest scope possible so in the if (hits).
20150831 11:24:31< aquileia> Feel free to write to their support about the OS X and Trusty beta programs (adding a OS X job would be trivial, getting it to compile is another matter, but we can allow fails for single configurations)
20150831 11:25:04-!- travis-ci [~travis-ci@ec2-54-167-2-118.compute-1.amazonaws.com] has joined #wesnoth-dev
20150831 11:25:05< travis-ci> aquileia/wesnoth#24 (travis-9000 - 6a75f23 : aquileia): The build has errored.
20150831 11:25:05< travis-ci> Build details : https://travis-ci.org/aquileia/wesnoth/builds/78022708
20150831 11:25:05-!- travis-ci [~travis-ci@ec2-54-167-2-118.compute-1.amazonaws.com] has left #wesnoth-dev []
20150831 11:25:14< zookeeper> Soliton, in if (update_display_), but yeah, true
20150831 11:25:37< Soliton> right.
20150831 11:25:46< aquileia> zookeeper: Thanks for the Finnish fix
20150831 11:26:42< Soliton> zookeeper: apart from what shadowm mentioned about the new argument being optional and a pointer instead of mandatory and a const reference, i think that PR is good to go then.
20150831 11:30:12-!- aquileia [863ca5d4@gateway/web/freenode/ip.134.60.165.212] has quit [Ping timeout: 246 seconds]
20150831 11:32:45< zookeeper> yeah i can do those
20150831 11:33:27 * zookeeper would find it very handy if github had a way to merge/edit commits individually
20150831 11:33:28-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has quit [Ping timeout: 268 seconds]
20150831 11:34:20< Soliton> git rebase -i
20150831 11:35:26< Soliton> you could indeed make the commit history of your PR nicer but you'd need to know git then. :-P
20150831 11:36:47< zookeeper> it's not a coincidence that i said github, not git
20150831 11:40:23< zookeeper> umm. changing the function argument to const reference should just be this, right?
20150831 11:40:26< zookeeper> -const std::vector<std::string>* extra_hit_sounds
20150831 11:40:29< zookeeper> +const std::vector<std::string>& extra_hit_sounds
20150831 11:40:53< Soliton> and changing the code that uses extra_hit_sounds.
20150831 11:41:07< Soliton> and the function call of course.
20150831 11:41:49< zookeeper> when i do that, extra_hit_sounds != NULL fails
20150831 11:42:02< Soliton> you don't need that check anymore.
20150831 11:43:03< zookeeper> yeah, but if someone needs to call that without that argument, they have to create a dummy empty vector for it? or should i just omit that check, and trust that if someone passes NULL, the BOOST_FOREACH will deal with it?
20150831 11:43:46< Soliton> well, that's the question indeed. if you change it the parameter becomes mandatory. no one can call it with NULL.
20150831 11:44:18< Soliton> if you really want the argument to stay optional then everything is fine as it is.
20150831 11:45:02< Soliton> just something to think about whether the added complexity of an optional argument is useful when currently every caller provides it.
20150831 11:47:33< Soliton> (if in the future someone needs to call the function without that argument he can make it optional then.)
20150831 11:47:40< zookeeper> if someone ends up needing to create a dummy vector to call it, then i'm sure that'll be done in less than a microsecond so it's not exactly a performance issue, but it just feels weird to do it that way.
20150831 11:48:24< Soliton> it's more a semantic question. i guess in your opinion the argument is inherently optional even if in current cide it really isn't.
20150831 11:48:32< Soliton> code*
20150831 11:48:46< zookeeper> plus i feel like having it optional and the usage wrapped in a NULL check makes it ever so slightly more self-documenting
20150831 11:49:21< Soliton> it nicely documents it as optional, yes.
20150831 11:50:55-!- Appleman1234 [~Appleman1@KD111239030236.au-net.ne.jp] has joined #wesnoth-dev
20150831 11:53:00-!- louis94 [~~louis94@109.129.243.95] has joined #wesnoth-dev
20150831 11:53:15< zookeeper> and yeah i think it's inherently optional considering how it's essentially a workaround. the only reason it's not NULL in the original code if no poison/slow/petrify sounds are pushed to it is because it'd have taken several lines more code to do it that way :p
20150831 11:53:46-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 1.0.1]
20150831 11:54:28-!- Kwandulin [~Miranda@p5B008308.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150831 11:57:12< Soliton> i think in the current system it's not a workaround. or it's as much a workaround as every other code that handles our hardcoded weapon specials.
20150831 11:58:21-!- travis-ci [~travis-ci@ec2-54-87-25-251.compute-1.amazonaws.com] has joined #wesnoth-dev
20150831 11:58:22< travis-ci> aquileia/wesnoth#25 (travis-9000 - d4c62b5 : aquileia): The build was fixed.
20150831 11:58:22< travis-ci> Build details : https://travis-ci.org/aquileia/wesnoth/builds/78024960
20150831 11:58:22-!- travis-ci [~travis-ci@ec2-54-87-25-251.compute-1.amazonaws.com] has left #wesnoth-dev []
20150831 12:02:41-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20150831 12:02:41-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20150831 12:02:41-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20150831 12:12:56-!- louis94 [~~louis94@109.129.243.95] has quit [Ping timeout: 268 seconds]
20150831 12:23:41-!- louis94 [~~louis94@109.129.243.95] has joined #wesnoth-dev
20150831 12:39:22-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20150831 12:39:24-!- louis94 [~~louis94@109.129.243.95] has quit [Quit: Konversation terminated!]
20150831 12:40:06-!- louis94 [~~louis94@109.129.243.95] has joined #wesnoth-dev
20150831 12:46:26-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20150831 12:49:54< vultraz> TFW an issue that was bothering you turns out to have an insanely trivial fix :|
20150831 12:51:29< irker189> wesnoth: Charles Dang wesnoth:master 50aeac6e3074 / src/help/help_impl.cpp: Prefix help topic sections with bullets as well http://git.io/vGRfU
20150831 13:05:12-!- raoniff [~raoni@labs-gw.ic.unicamp.br] has quit [Ping timeout: 264 seconds]
20150831 13:05:39-!- louis94 [~~louis94@109.129.243.95] has quit [Quit: Konversation terminated!]
20150831 13:23:27-!- raoniff [~raoni@labs-gw.ic.unicamp.br] has joined #wesnoth-dev
20150831 13:25:56< celticminstrel> So what about PR475?
20150831 13:32:14-!- travis-ci [~travis-ci@ec2-54-162-25-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20150831 13:32:15< travis-ci> wesnoth/wesnoth#7243 (master - 50aeac6 : Charles Dang): The build was broken.
20150831 13:32:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/78037544
20150831 13:32:15-!- travis-ci [~travis-ci@ec2-54-162-25-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20150831 13:39:41-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150831 13:42:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 256 seconds]
20150831 13:42:06-!- wedge010 is now known as wedge009
20150831 14:28:17-!- gfgtdf [~chatzilla@f054060016.adsl.alicedsl.de] has joined #wesnoth-dev
20150831 14:29:01< gfgtdf> shadowm: i added wesnoth.random to the list of functions
20150831 14:40:22-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20150831 14:40:22-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20150831 14:40:22-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150831 14:54:00-!- Kwandulin [~Miranda@p5B008308.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150831 14:58:18-!- [Relic] [~Relic]@2602:306:33a3:6d30:da8:2e9d:d5b4:64f1] has joined #wesnoth-dev
20150831 14:59:04< zookeeper> celticminstrel, are the damage overrides limited to the format "(<existing damage type> <operator> <value>)" (or something similar?) or do they accept any formula?
20150831 14:59:32< celticminstrel> Any formula.
20150831 14:59:54< zookeeper> huh, okay. how does it recognize a damage type name?
20150831 15:00:34< celticminstrel> It assumes any variable is a damage type name and substitutes a default value if the movetype being modified doesn't already have an entry for that damage type.
20150831 15:01:20< celticminstrel> (That's because some movetypes don't have an entry for all default base terrains, so simply getting a list of valid variables from the movetype won't work.)
20150831 15:30:28< zookeeper> aside from possibly renaming the tags and/or possibly wrapping them all inside a single [movement_type_override] tag or similar, i can't really think of any changes
20150831 15:31:55< zookeeper> the latter i thought about simply because it'd make it a bit more clear what that strange WML you're looking at is for
20150831 15:34:08< celticminstrel> Did you see Elvish_Hunter's comment?
20150831 15:34:51< zookeeper> yes
20150831 15:35:28< celticminstrel> So, not in favour of moving part of it into [terrain_type]?
20150831 15:36:51< zookeeper> i don't know, on one hand it'd make more sense there, but then it'd be separate from the damage type stuff... but then again i'm not sure if they need to be associated with each other in any way
20150831 15:40:41< zookeeper> yeah i guess i'd be slightly inclined to put it in [terrain_type] instead, if the defense/movement/etc tags are given more descriptive names or wrapped in an extra container
20150831 15:42:10< zookeeper> the damage type thing can live in [units] with a similar rename... might be better to use s/damage/resistance too, since technically damage types don't have any features, it's only units which have resistances
20150831 15:48:54-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150831 15:51:38-!- irker189 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150831 15:58:49-!- Appleman1234 [~Appleman1@KD111239030236.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20150831 16:02:34-!- jinblack [~jinblack@ip184-187-174-107.sb.sd.cox.net] has joined #wesnoth-dev
20150831 16:39:34-!- sfan786 [~sfan786@c-24-131-93-155.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150831 16:40:51-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20150831 17:05:50-!- Appleman1234 [~Appleman1@KD111239019015.au-net.ne.jp] has joined #wesnoth-dev
20150831 17:10:16-!- sfan786 [~sfan786@c-24-131-93-155.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150831 17:12:04-!- jinblack [~jinblack@ip184-187-174-107.sb.sd.cox.net] has quit [Remote host closed the connection]
20150831 17:16:05-!- Limabean [32f7e8e9@gateway/web/freenode/ip.50.247.232.233] has joined #wesnoth-dev
20150831 17:26:24-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150831 17:40:00-!- mjs-de [~mjs-de@f049164238.adsl.alicedsl.de] has quit [Remote host closed the connection]
20150831 17:43:03-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 1.0.1]
20150831 17:45:07-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20150831 18:06:57-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150831 18:18:38-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150831 18:21:06-!- jinblack [~jinblack@128.111.48.6] has joined #wesnoth-dev
20150831 18:33:30-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20150831 18:37:26-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150831 18:43:20-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150831 18:43:29-!- gfgtdf [~chatzilla@f054060016.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 40.0.3/20150826023504]]
20150831 19:02:55-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150831 19:34:25-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20150831 19:34:51-!- gfgtdf [~chatzilla@f054060016.adsl.alicedsl.de] has joined #wesnoth-dev
20150831 19:35:09< gfgtdf> celticminstrel: online ?
20150831 19:39:17-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150831 19:59:51< celticminstrel> Yes.
20150831 20:02:01< gfgtdf> celticminstrel: what was teh reason to move teh sdl_quit handler out of events.cpp ?
20150831 20:02:34< celticminstrel> Uh, so that it could be handled?
20150831 20:03:37-!- shadowm_desktop [ignacio@181.43.74.78] has joined #wesnoth-dev
20150831 20:03:46-!- shadowm_desktop [ignacio@181.43.74.78] has quit [Changing host]
20150831 20:03:46-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150831 20:03:59< gfgtdf> celticminstrel: hmm
20150831 20:05:19< celticminstrel> I don't think it can be handled in a single unified way in events.cpp, barring what was already there which is what I'm trying to change.
20150831 20:05:24< shadowm> gfgtdf: Okay, thanks!
20150831 20:06:00< gfgtdf> celticminstrel: i tried to implement teh quit handler in events.cpp and it worked (more or less) (currently waiting  for upload)
20150831 20:06:14< celticminstrel> How'd you do that?
20150831 20:06:30< celticminstrel> Global variables?
20150831 20:06:50< gfgtdf> celticminstrel: y
20150831 20:06:52< gfgtdf> celticminstrel: celticminstrel: i tried to implement teh quit confirmation check directly in there and it worked (more or less)
20150831 20:06:57-!- irker197 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150831 20:06:57< irker197> wesnoth: Elvish_Hunter wesnoth:master 8db92e9af30f / data/tools/wmllint-1.4: wmllint-1.4: replaced backticks with repr() http://git.io/vGunk
20150831 20:07:08< celticminstrel> Does it put a quit confirmation if you quit from titlescreen?
20150831 20:08:27< shadowm> zookeeper: http://forums.wesnoth.org/viewtopic.php?p=589043#p589043 -- You think the incorrect textdomain name/missing path causes it? I tried doing the same to my campaign and nothing special happens.
20150831 20:08:49< gfgtdf> celticminstrel: no it doesnt
20150831 20:09:03< gfgtdf> celticminstrel: here: https://github.com/gfgtdf/wesnoth-old/commit/abb06398059c5ea0a5c1814c2ac93ed15bc6bdde
20150831 20:09:05< celticminstrel> But it does require a global variable.
20150831 20:09:19< gfgtdf> celticminstrel: sry had teh wrong think ic prelipard in the message before
20150831 20:09:53< gfgtdf> celticminstrel: in the "celticminstrel: celticminstrel: " message i ment
20150831 20:10:23< zookeeper> shadowm, the missing linebreak causes it? i got the error, and fixing the linebreak fixed it
20150831 20:10:53< shadowm> The missing line break translates to what I said and as I said it does nothing special for me if I introduce the same bug to my campaign.
20150831 20:11:52< zookeeper> all i know is that the problem reproduced for me when i downloaded via the web interface, and adding a proper linebreak made it go away
20150831 20:12:07< shadowm> I guess I'll test on Windows to be sure, since the OP says that he couldn't reproduce on OS X either.
20150831 20:12:15< zookeeper> i don't know if it's a missing linebreak or a wrong kind of linebreak or something
20150831 20:12:23< gfgtdf> celticminstrel: y
20150831 20:12:30< celticminstrel> Hmm.
20150831 20:13:33< celticminstrel> Well, it's better than it initially sounded, I guess. I really don't understand why you're so adamant about having a quit confirmation while a dialog is open (it makes perfect sense to me to be unable to quit when there's a modal dialog up), but I don't see any issues with your implementation.
20150831 20:15:15< gfgtdf> celticminstrel: well the ain reason is what i said in teh pr: the [message]s, right click menus and similar are implmeented as dialogs
20150831 20:15:36< gfgtdf> celticminstrel: also note that addons (wml) can whow custom dialog using wesnoth.show_dialog()
20150831 20:15:56< gfgtdf> s/ain/main
20150831 20:16:02< celticminstrel> It make sense to me for dialogs shown via wesnoth.show_dialog() to block quit (at least, generally; some specific ones might not).
20150831 20:16:05< celticminstrel> ^makes
20150831 20:16:40< celticminstrel> The changes to title_screen.cpp in my implementation show what you'd need to do to make quitting possible in an individual dialog. I dunno if there's Lua API to that.
20150831 20:17:37< celticminstrel> What's your FIXME comment about?
20150831 20:18:25< gfgtdf> celticminstrel: another issue is that for example if wesnoth is minimized with a dialog open (something that isnt even possible with other programms dialogs) it will require you to open the programm before beeing able to close it
20150831 20:18:53< gfgtdf> celticminstrel: i have already fixed that fix me locally.
20150831 20:18:58< celticminstrel> "open the program" means something completely different from "maximize" the program... I don't understand why that's an issue...
20150831 20:20:38< gfgtdf> celticminstrel: when i have many porgramms open and i really dont want to open(un-minimize) each  of them and close then seperateley.
20150831 20:20:45< celticminstrel> So gfgtdf, does what does that do if a menu is open?
20150831 20:21:24< gfgtdf> celticminstrel: which menu do you mean?
20150831 20:21:32< celticminstrel> Right-click menu, file menu, etc.
20150831 20:21:57< celticminstrel> Ignore the first "does".
20150831 20:24:29< gfgtdf> it shows the quit confirmation popup (if needed)
20150831 20:24:38< gfgtdf> otherwise it closed directly
20150831 20:24:42< celticminstrel> "if needed" should be "always" though...
20150831 20:24:59< celticminstrel> I don't know of any places where menus are used but a quit confirmation is not needed.
20150831 20:25:30< gfgtdf> for example in main manu->load game it closes directly, if load game was used form a game it ask for comfirmation if teh application is closed
20150831 20:25:45 * Elvish_Hunter should add a close confirmation dialog to GUI.pyw...
20150831 20:25:56< celticminstrel> Those aren't menus though, are they?
20150831 20:26:08< celticminstrel> That's a dialog, not a menu.
20150831 20:27:05< gfgtdf> i thought thats what you meant by 'file menu'
20150831 20:27:38< celticminstrel> Right-click anywhere on the map, press Cmd+Q / Alt+F4.
20150831 20:27:41< celticminstrel> For example.
20150831 20:27:53< gfgtdf> celticminstrel: then it asks for a confirmation
20150831 20:28:36< celticminstrel> I guess that works.
20150831 20:36:10< celticminstrel> Pushing a couple things now, but assuming your version gets accepted, I'll be rebasing my PR around your version to include just the stuff related to Escape and display.
20150831 20:40:15< gfgtdf> celticminstrel: wait a little
20150831 20:40:30< gfgtdf> celticminstrel: i'll have to rebase my commit agin to fix teh commit message
20150831 20:51:21< shadowm> zookeeper: Okay, it's Windows-specific. Interesting.
20150831 20:51:53< shadowm> Elvish_Hunter: Why? Does it keep any state that one would possibly lose by quitting?
20150831 20:53:57< gfgtdf> shadowm: do you know wehther there is a way to make gui2 label to ellipse when they are too long?
20150831 20:54:21< celticminstrel> shadowm: What's your opinion on gfgtdf vs my quit confirmations?
20150831 20:54:36< shadowm> gfgtdf: Yes, but it doesn't work.
20150831 20:55:15< gfgtdf> shadowm: you know how it shouold work?
20150831 20:55:26< Elvish_Hunter> shadowm: yes, the output of the Python tools
20150831 20:56:10< shadowm> gfgtdf: I know how it should work, since it's my patch, but it doesn't work.
20150831 20:56:20< shadowm> I've not pushed it upstream for that reason.
20150831 20:56:35< shadowm> Elvish_Hunter: You can obtain the same output by rerunning it, though?
20150831 20:56:44< gfgtdf> shadowm: you have it on your fork ?
20150831 20:56:53< gfgtdf> shadowm: you know why id doesnt work ?
20150831 20:56:54< shadowm> I have it in a stash.
20150831 20:57:03< gfgtdf> it*
20150831 20:57:14< gfgtdf> shadowm: i dotn know how stashs work
20150831 20:57:29< shadowm> You've never used git stash? :p
20150831 20:57:30< Elvish_Hunter> shadowm: usually, yes. But with Tkinter it's so easy to add it, that in fact I almost finished writing the patch
20150831 20:57:31-!- travis-ci [~travis-ci@ec2-54-167-2-118.compute-1.amazonaws.com] has joined #wesnoth-dev
20150831 20:57:32< travis-ci> wesnoth/wesnoth#7244 (master - 8db92e9 : Elvish_Hunter): The build was fixed.
20150831 20:57:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/78108803
20150831 20:57:32-!- travis-ci [~travis-ci@ec2-54-167-2-118.compute-1.amazonaws.com] has left #wesnoth-dev []
20150831 20:57:53< gfgtdf> shadowm: no, never
20150831 20:57:55< shadowm> Elvish_Hunter: Elvish_Hunter Yeah, you know what my opinion on the matter is. Just because you can do it doesn't mean you should. :p
20150831 20:59:09< shadowm> For example, it'd be trivial to drop NR.
20150831 21:00:42-!- Limabean [32f7e8e9@gateway/web/freenode/ip.50.247.232.233] has quit [Ping timeout: 246 seconds]
20150831 21:00:43< shadowm> gfgtdf: git stash lets you save uncommitted local changes to reapply them at a later time.
20150831 21:01:25< gfgtdf> shadowm: so each stash has a name? or is 6there only one stach per branch?
20150831 21:01:45< shadowm> This is useful when you need to switch branches or perform some other Git operation that could destroy your local changes.
20150831 21:02:10< shadowm> gfgtdf: There's an unlimited number of stash entries (as many as you create, really) and they are not associated to a specific branch.
20150831 21:03:10< shadowm> So it's basically a quick and dirty alternative to committing local changes to a dummy branch. Individual stashes are essentially pseudo-commits anyway.
20150831 21:04:16< gfgtdf> shadowm: sounds useful
20150831 21:04:24< celticminstrel> You can give stashes a name but I have no idea how.
20150831 21:04:31< celticminstrel> With commandline at least.
20150831 21:05:31< gfgtdf> shadowm: you know why your labels don't work ?
20150831 21:05:45-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150831 21:05:56< shadowm> Anyway the point is that I haven't committed my addition yet because I couldn't get it to work, presumably because I couldn't force labels to shrink.
20150831 21:06:33< shadowm> I.e. to not grow their cell to the minimum size needed to display the full text (and thus gain a horizontal scroll bar somewhere).
20150831 21:09:13< gfgtdf> shadowm: you wanted that for a specific listbox ?
20150831 21:09:35< shadowm> I wanted it for the game version dialog, to deal with the tab labels overflow issue.
20150831 21:10:02< shadowm> That was before switching it to use horizontal_listbox though. I haven't tested the patch since then.
20150831 21:10:34< gfgtdf> shadowm: hm ok
20150831 21:10:37< shadowm> Even then, I don't think making it a listbox would help in regards to placing constraints on the label sizes, more like the contrary.
20150831 21:10:57< shadowm> 17:54:22 <celticminstrel> shadowm: What's your opinion on gfgtdf vs my quit confirmations?
20150831 21:11:08< shadowm> What's the gist of both imp[Dlementations?
20150831 21:11:15< celticminstrel> Uh.
20150831 21:12:36< celticminstrel> I've made it possible for event handlers to receive the quit event and react however they want, which means that you can't quit while a dialog is onscreen (though I did install a signal handler so that SIGTERM instantly quits).
20150831 21:12:42-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150831 21:13:01< gfgtdf> shadowm: you what tcontrol::text_maximum_width_  does?
20150831 21:13:08< celticminstrel> It might be better if gfgtdf describes his own.
20150831 21:13:28< shadowm> gfgtdf: Do I know? No, not really.
20150831 21:13:33< irker197> wesnoth: Elvish_Hunter wesnoth:master b23e93a82338 / data/tools/GUI.pyw: GUI.pyw: added exit confirmation dialog http://git.io/vGu9h
20150831 21:13:49< Elvish_Hunter> vultraz: ^^
20150831 21:14:45-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Max SendQ exceeded]
20150831 21:15:06< celticminstrel> Basically he just changed the handling of SDL_QUIT in events::pump().
20150831 21:15:19< gfgtdf> shadowm: there are prs for both pacthes,  the main difference (for the user) is that in my patch it is possible to close the game while a dialog is open, in his prs desciption i say why i want this to be possible.
20150831 21:15:45< gfgtdf> shadowm: i think my patch is a little simpler but i used a global variable whihc i think is ok here.
20150831 21:16:23-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150831 21:17:05-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Client Quit]
20150831 21:24:10-!- travis-ci [~travis-ci@ec2-54-167-2-118.compute-1.amazonaws.com] has joined #wesnoth-dev
20150831 21:24:11< travis-ci> gfgtdf/wesnoth-old#521 (quit_confirmation - 2bfbeb1 : gfgtdf): The build has errored.
20150831 21:24:11< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/78115209
20150831 21:24:11-!- travis-ci [~travis-ci@ec2-54-167-2-118.compute-1.amazonaws.com] has left #wesnoth-dev []
20150831 21:26:42< shadowm> gfgtdf: Do you want to take a look at https://gna.org/bugs/index.php?23839 or shall I?
20150831 21:28:32< gfgtdf> shadowm: you can do it
20150831 21:28:52< shadowm> Okay.
20150831 21:29:09-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150831 21:29:39< gfgtdf> shadowm: so you know what this code does: https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/control.cpp#L498 ?
20150831 21:31:22< shadowm> Not really, but I'll take that into account for retesting my patch.
20150831 21:31:52< shadowm> It looks like there is a way to specify a maximum size somewhere after all.
20150831 21:32:46< shadowm> Although it might be in the widget definition rather than instantiation...
20150831 21:33:30< shadowm> tcontrol::config_'s description points to the definition, yes. :|
20150831 21:34:02< shadowm> This reminds me that there is another attribute that I didn't account for in my testing.
20150831 21:34:31< shadowm> http://wiki.wesnoth.org/GUIWidgetInstanceWML#Label -- characters_per_line
20150831 21:35:20< shadowm> Probably won't help me much since it enables line wrapping and ellipsization requires line wrapping to be disabled.
20150831 21:36:32< gfgtdf> shadowm: but with characters per line the acrual with depends very much on the actual cracters i'd guesss. So im not convinced that is useful
20150831 21:37:18< shadowm> The description does say it's approximate due to varying character widths.
20150831 21:37:39< shadowm> I assume it internally uses a fixed measurement like ems or ens in CSS.
20150831 21:38:03< shadowm> *context-defined relative measurement
20150831 21:38:30 * shadowm goes to read those PRs.
20150831 21:39:53< gfgtdf> shadowm: y, it uses pango_font_metrics_get_approximate_char_width * characters_per_line internally
20150831 21:40:44< gfgtdf> shadowm: maybre removing the characters_per_line => can_wrap implementation is already enough
20150831 21:48:29-!- gfgtdf [~chatzilla@f054060016.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 40.0.3/20150826023504]]
20150831 21:58:35-!- travis-ci [~travis-ci@ec2-54-161-188-237.compute-1.amazonaws.com] has joined #wesnoth-dev
20150831 21:58:36< travis-ci> gfgtdf/wesnoth-old#522 (quit_confirmation - 0abde38 : gfgtdf): The build passed.
20150831 21:58:36< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/78115624
20150831 21:58:36-!- travis-ci [~travis-ci@ec2-54-161-188-237.compute-1.amazonaws.com] has left #wesnoth-dev []
20150831 21:58:55-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has left #wesnoth-dev ["Ciao!"]
20150831 21:59:52< shadowm> gfgtdf: Your PR results in this when bringing up the quit dialog with the Objectives (GUI2) dialog active:
20150831 21:59:55< shadowm> 20150831 18:59:21 warning gui/event: Unhandled event 12.
20150831 22:01:02< shadowm> celticminstrel: Your code ought to use sigaction() instead of signal().
20150831 22:01:22< shadowm> http://stackoverflow.com/questions/231912/what-is-the-difference-between-sigaction-and-signal
20150831 22:02:06< shadowm> I personally believe gfgtdf's approach is much simpler, even if it lacks special treatment for process signals.
20150831 22:02:24< shadowm> (It still allows you to quit immediately by sending a signal twice.)
20150831 22:04:31< shadowm> gfgtdf: The red cross in the corner is normally called the window's close button btw. :p
20150831 22:05:44-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20150831 22:07:47-!- gfgtdf [~chatzilla@f050181223.adsl.alicedsl.de] has joined #wesnoth-dev
20150831 22:08:12< gfgtdf> shadowm: simply removing teh character_max -> can_wrap impluication worked quiet well for me: http://i.imgur.com/4XIQ6OB.jpg
20150831 22:08:41< shadowm> It ellipsizes automatically without modifications?
20150831 22:09:05< shadowm> Well, I guess I knew this already.
20150831 22:09:26< shadowm>     variant(can_wrap() ? PANGO_ELLIPSIZE_NONE : PANGO_ELLIPSIZE_END));
20150831 22:09:43< gfgtdf> shadowm: so wanted some custom ellipses ?
20150831 22:09:48< shadowm> My addition really revolved around allowing us to select alternate ellipsization modes. Yes.
20150831 22:10:12< gfgtdf> shadowm: how shoudl they look then ?
20150831 22:10:58< shadowm> Eh, I didn't have an immediate use in mind for the start/middle ellipsization modes, but I thought it could come in handy for, say, file dialogs (ellipsizing paths at the middle or start is a common thing to do).
20150831 22:11:35< shadowm> But more to the point, the char count thing doesn't scale well across the board.
20150831 22:12:33< shadowm> For example, if I were to limit the tab labels' char count in the version dialog, that requires me to know exactly how many tab labels there will be in a row, and also whether they share space with other widgets, and how much room will be left for them.
20150831 22:12:48< shadowm> So the char count becomes an opaque magic number.
20150831 22:13:25< shadowm> Ideally I should just be able to tell a label widget to stop trying to grow its cell and just deal with the space limitations imposed by the context.
20150831 22:13:59< shadowm> I.e. ellipsize before forcing the cell to grow.
20150831 22:18:53-!- louis94 [~~louis94@109.133.211.155] has joined #wesnoth-dev
20150831 22:19:31< celticminstrel> Well, if that's the case I'll wait until gfgtdf's is accepted and then update my PR for just the Escape stuff.
20150831 22:21:34-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 246 seconds]
20150831 22:24:43-!- Shackra [~Jorge@186.177.2.148] has quit [Remote host closed the connection]
20150831 22:24:44< shadowm> gfgtdf: quit_confirmation.hpp needs include guards instead of #pragma once (yes, I know most compilers support the latter by now but let's stick to convention for the time being) and also the standard copyright header (also the .cpp).
20150831 22:25:14< shadowm> quit_confirmation::count_ looks like it should be unsigned rather than signed.
20150831 22:26:02< shadowm> Not that it's particularly important either way since this will never go above 2 or 3 if I understand correctly.
20150831 22:26:28-!- Sapient [~sapient@wesnoth/developer/sapient] has joined #wesnoth-dev
20150831 22:26:34< Sapient> hi
20150831 22:26:45< shadowm> Hello.
20150831 22:26:55< shadowm> Long time no see. :p
20150831 22:27:05< Sapient> yeah, what did I miss? :p
20150831 22:27:32< Sapient> I just read the "Wesnoth Needs Your Help!" announcement
20150831 22:27:52< Sapient> So I thought I would pop in here and see who's still alive lol
20150831 22:28:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds]
20150831 22:29:11< shadowm> Outside the people named in the starting guide (and lipkab and Jetrel), no-one else really.
20150831 22:29:49< Sapient> For the moment, I'm no longer employed as a programmer. I'm going to be traveling to the Philippines in a month to work as a volunteer
20150831 22:30:23< Sapient> You may read about my exploits here http://bit.do/PatrickParkerFunRun
20150831 22:30:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150831 22:31:10< Sapient> hi boucman
20150831 22:32:31< boucman> hey
20150831 22:33:33< gfgtdf> shadowm: yes count_ is aways an unsigned number. at first i had an explicit assert >= 0 in the code that why i needed it to be signed.
20150831 22:34:30< gfgtdf> shadowm: i think i'll put the assert back in
20150831 22:37:59-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 250 seconds]
20150831 22:38:49< Sapient> shadowm: thanks. I'm going to be considering ways to freshen up my programming knowledge during my downtime in the Phils. Whether that will involve Wesnoth or not, remains to be seen
20150831 22:39:23< Sapient> have fun, cya later!
20150831 22:39:26-!- Sapient [~sapient@wesnoth/developer/sapient] has quit [Quit: cya later. have fun]
20150831 22:40:23-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20150831 22:41:48-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150831 22:53:38-!- Limabean [32f7e8e9@gateway/web/freenode/ip.50.247.232.233] has joined #wesnoth-dev
20150831 23:01:23-!- gfgtdf [~chatzilla@f050181223.adsl.alicedsl.de] has quit [Ping timeout: 264 seconds]
20150831 23:02:05-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150831 23:03:39< Limabean> Is anyone able to help me figure out how the editor palettes work? Specifically I'm looking at setup() and draw_item() in terrain_palettes.cpp, which seem to do a lot of the heavy lifting for terrains. However I can't seem to find the code that actually adds the palette buttons to the ui
20150831 23:09:06< shadowm> Since fabi disappeared, the editor is unmaintained I'm afraid.
20150831 23:14:14< Limabean> hrm, that's unfortunate. Any other documentation I might check out besides this? http://devdocs.wesnoth.org/
20150831 23:15:27< shadowm> The actual code is the only other option. :p
20150831 23:19:22-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20150831 23:19:33< Limabean> ok, I'll keep experimenting then
20150831 23:20:01-!- prkc [~prkc@51B77E5A.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20150831 23:23:58-!- mjs-de [~mjs-de@f049164238.adsl.alicedsl.de] has joined #wesnoth-dev
20150831 23:37:19-!- Limabean [32f7e8e9@gateway/web/freenode/ip.50.247.232.233] has quit [Quit: Page closed]
--- Log closed Tue Sep 01 00:00:30 2015