--- Log opened Tue Sep 01 00:00:30 2015
20150901 00:13:54-!- irker197 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150901 00:21:30-!- Shackra [~Jorge@186.177.2.148] has quit [Quit: No Ping reply in 180 seconds.]
20150901 00:22:37-!- irker281 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150901 00:22:37< irker281> wesnoth: Ignacio R. Morelle wesnoth:master 185aa1a2f0c7 / src/ (gettext.hpp gettext_boost.cpp): i18n: Fix typo http://git.io/vGzXp
20150901 00:22:56-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150901 00:34:38-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Remote host closed the connection]
20150901 00:40:41-!- mjs-de [~mjs-de@f049164238.adsl.alicedsl.de] has quit [Remote host closed the connection]
20150901 01:02:24< irker281> wesnoth: Ignacio R. Morelle wesnoth:1.12 2b9ca340d34b / src/ (gettext.hpp gettext_boost.cpp): i18n: Fix typo http://git.io/vGz55
20150901 01:02:27< irker281> wesnoth: Ignacio R. Morelle wesnoth:1.12 28df1449e887 / src/gettext.cpp: i18n/legacy: Fix typo http://git.io/vGz5d
20150901 01:02:30< irker281> wesnoth: Ignacio R. Morelle wesnoth:1.12 352a432171a4 / changelog players_changelog src/gettext.cpp src/gettext_boost.cpp: i18n: Skip and warn about textdomain names with a slash (bug #23839) http://git.io/vGz5F
20150901 01:02:33< irker281> wesnoth: Ignacio R. Morelle wesnoth:1.12 cedd277da18a / src/gettext_boost.cpp: i18n: Fix typo in log message http://git.io/vGz5b
20150901 01:02:36< irker281> wesnoth: Ignacio R. Morelle wesnoth:master 1bd91e75f513 / src/gettext.cpp: i18n/legacy: Fix typo http://git.io/vGz5N
20150901 01:02:39< irker281> wesnoth: Ignacio R. Morelle wesnoth:master 85cf364ea0c8 / changelog players_changelog src/gettext.cpp src/gettext_boost.cpp: i18n: Skip and warn about textdomain names with a slash (bug #23839) http://git.io/vGz5A
20150901 01:02:42< irker281> wesnoth: Ignacio R. Morelle wesnoth:master 2971916edb0e / src/gettext_boost.cpp: i18n: Fix typo in log message http://git.io/vGz5x
20150901 01:19:59-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150901 01:39:41-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150901 01:42:10-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20150901 01:42:10-!- wedge010 is now known as wedge009
20150901 02:34:38-!- jinblack [~jinblack@128.111.48.6] has quit [Remote host closed the connection]
20150901 02:35:27-!- new_one [~new_one@2604:a880:1:20::22e:d001] has joined #wesnoth-dev
20150901 02:52:07-!- sailorswift [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150901 03:07:14-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150901 03:14:22-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 272 seconds]
20150901 03:16:09-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150901 03:30:58-!- louis94 [~~louis94@109.133.211.155] has quit [Quit: Konversation terminated!]
20150901 03:39:43-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150901 03:56:45-!- sailorsw_ [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150901 04:00:14< shadowm> aquileia: I don't understand what you mean with the cherry-picking suggestsions at the end of #479's description. The build seems to have succeeded as-is?
20150901 04:00:24-!- sailorswift [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds]
20150901 04:01:17< shadowm> aquileia: You didn't specify, so I'm assuming that you had to contact them to enable trusty for your fork?
20150901 04:02:04< shadowm> If so, did they ask for any specific information I should be aware of in advance, or is it just a matter of telling them we want to test the trusty infrastructure?
20150901 04:05:37< celticminstrel> Should I move defense/movement into [terrain_type] or leave it under [units]?
20150901 04:06:30< celticminstrel> Both gfgtdf and zookeeper commented on that possibility, but it didn't seem like they had a strong preference.
20150901 04:07:01< shadowm> [terrain_type] defines a terrain. This normally is only done once per terrain.
20150901 04:07:35< shadowm> If I understand your feature correctly, it's tied to the concept of movement types, which is a [units] thing.
20150901 04:07:50< celticminstrel> Yes, it patches the movement types to support custom terrains.
20150901 04:07:52-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has joined #wesnoth-dev
20150901 04:08:00< celticminstrel> So it's tied to both movement types and to terrain types.
20150901 04:08:07< ancestral> shadowm: Master builds just fine for me
20150901 04:08:16< shadowm> I'd go with [units].
20150901 04:08:27< shadowm> ancestral: Both bundle and non-bundle?
20150901 04:08:32< ancestral> And executes fine
20150901 04:08:38< ancestral> I only tested through Xcode
20150901 04:09:02< ancestral> I can do Homebrew later
20150901 04:09:02< shadowm> Which one is that? I don't know anything about OS X, you see. :\
20150901 04:09:12< ancestral> Xcode is as a bundle
20150901 04:09:15< celticminstrel> Possible tag names: [damage_type], [damage_type_resistance], [damage_resistance]... if no-one has a preference I'll pick the one I like bese.
20150901 04:09:23< celticminstrel> ^best
20150901 04:09:25< ancestral> At least, I think, when you say “bundle”
20150901 04:09:43< shadowm> .app vs. not .app.
20150901 04:09:50< ancestral> (It’s an app you double-click on)
20150901 04:09:53< ancestral> Yes, .app
20150901 04:09:54< shadowm> At least that's my understanding of things.
20150901 04:10:06< celticminstrel> A .app is an application bundle.
20150901 04:10:17< shadowm> An .app is a directory with magic files in it, including the app's resources and stuff, right?
20150901 04:10:39< celticminstrel> So testing non-bundle would be "cd path/to/Wesnoth.app; ./Wesnoth.app/Contents/MacOS/wesnoth"
20150901 04:10:47< shadowm> As well as some sort of manifest that tells the OS "hey this is an application and it's called foo and it has the following properties", I imagine.
20150901 04:10:49< celticminstrel> Or something along those lines.
20150901 04:10:59< celticminstrel> But it might also involve a different resource layout, I dunno.
20150901 04:11:18< celticminstrel> Yes shadowm, that's the Info.plist.
20150901 04:11:47< celticminstrel> And yes a .app is a magic directory/
20150901 04:11:49< celticminstrel> ^.
20150901 04:11:56< shadowm> ancestral: Anyway, if the .app works then I'd expect non-.app builds to work as well since the author of the patch was clearly doing the latter.
20150901 04:12:13< shadowm> So thanks for testing.
20150901 04:12:23< ancestral> No problem
20150901 04:12:34< ancestral> shadowm: Any rough idea on when 1.13.2 is slated?
20150901 04:12:38< ancestral> Or maybe not
20150901 04:12:58< shadowm> Haven't decided yet.
20150901 04:14:01< celticminstrel> For the other tag... [terrain_defense} belies the fact that it also covers movement costs and such.
20150901 04:14:04< shadowm> In good part it depends on Aginor's work, but also there's some meta work I want to get done before resuming normal releases, including deciding on a release schedule for 1.14.
20150901 04:14:04< celticminstrel> Any other ideas?
20150901 04:14:22< celticminstrel> Also, do you want the subtags [defense] etc to be renamed too?
20150901 04:14:30< shadowm> Which will also require me to get some stuff sorted out with legal.
20150901 04:14:53< celticminstrel> Some of them are the same name as subtags of [movetype]; they specify the same kind of information but in a different format.
20150901 04:15:16< celticminstrel> I think I'll go with [terrain_costs] if no-one has a better suggestion.
20150901 04:15:39< shadowm> My Internet hates me tonight and doesn't want me to use GitHub.
20150901 04:17:36 * celticminstrel tries to think of different names for the subtags...
20150901 04:18:47< celticminstrel> Oh, I never updated the changelog either for this one, did I.
20150901 04:21:08< shadowm> Actually, I think I misunderstood a crucial bit
20150901 04:21:52< shadowm> So the [terrain] example in the PR description could presumably be part of [terrain_type].
20150901 04:21:55-!- oldlaptop [~quassel@50-107-94-87.adr02.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20150901 04:22:35< celticminstrel> Yes, it could go under [terrain_type], provided it's guaranteed that movetypes are initialized before terrains (they seem to be based on cursory inspection with the debugger).
20150901 04:22:44< shadowm> The other tag can be [damage_type] I guess? Does it also serve to define new damage types?
20150901 04:22:56 * celticminstrel should put a comma after "seem to be".
20150901 04:23:26< celticminstrel> It doesn't define new damage types; damage types are defined implicitly by just using them, and then you also need to add a key in [language] to make them translateable.
20150901 04:24:09< shadowm> Right, that's what I remembered, and I guess this syntax doesn't remove the need for the language node?
20150901 04:24:09< celticminstrel> I used [resist_damage], but I can change it to [damage_type].
20150901 04:24:18< celticminstrel> No, it doesn't touch that.
20150901 04:24:34< celticminstrel> It just modifies existing movetypes to add resistance to the damage type.
20150901 04:24:59< celticminstrel> I thought about letting it also mod specific units, but if you want to do that it's already pretty easy using [base_unit].
20150901 04:25:26-!- Kwandulin [~Miranda@p5B009DB6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150901 04:25:49< shadowm> The thing is, most details about the order in which root tags are processed (except perhaps [lua]) are unspecified and subject to change if someone decides to refactor code, at least unless someone adds relevant comments to the code explaining our API contract clauses.
20150901 04:26:49< celticminstrel> And terrains appear to be initialized the first time they're needed, which means if someone adds something that needs them earlier than the construction of movetypes, that could be problematic for what I'm doing.
20150901 04:26:58< shadowm> So in a way by introducing this stuff you are making yourself responsible for pointing people in the right direction if your code depends on certain conditions.
20150901 04:27:24-!- oldlaptop [~quassel@50-107-94-87.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150901 04:27:34< celticminstrel> I just thought of names for the subtags though - what about [default_movement], [default_defense], etc? It makes even more sense if they're under [terrain_type].
20150901 04:27:48< celticminstrel> Okay.
20150901 04:28:05< celticminstrel> So you're saying you do prefer it in [terrain_type]?
20150901 04:28:07< shadowm> default_* sounds good, it's more descriptive of the tags' purpose.
20150901 04:28:52-!- irker281 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150901 04:29:27< celticminstrel> I guess that means I need to move my template function into a header somewhere...
20150901 04:29:33< shadowm> I don't have a strong preference either way, really. Also, the fact that I'm not particularly good at API design is what's prevented me from mainlining many WML tags I've written since 2011.
20150901 04:30:16< shadowm> An alternative suggestion, keeping everything under [units]: [damage_defaults] and [terrain_defaults].
20150901 04:30:39< celticminstrel> And then the subtags of terrain_defaults are still default_*?
20150901 04:30:54< shadowm> No, [defense]/[movement]/[jamming]/[vision] would be unprefixed under that scheme.
20150901 04:31:15< celticminstrel> Mmkay... and in this case it's not a problem that defence/jamming/vision are used in [movetype] as well?
20150901 04:31:50< shadowm> Ugh, right, that's a thing.
20150901 04:32:18< celticminstrel> I keep spelling defence with a C.
20150901 04:33:14 * shadowm frowns in zookeeper's general direction for leaving this to me.
20150901 04:35:21< shadowm> [movement] and [vision] aren't shared with [movetype].
20150901 04:35:32< celticminstrel> Ah, right, just defense then.
20150901 04:35:41< celticminstrel> jamming is jamming_costs in movetype.
20150901 04:35:43< shadowm> [movetype]'s versions of the same tags are [movement_costs] and [vision_costs].
20150901 04:35:49 * celticminstrel nods.
20150901 04:35:59< celticminstrel> I knew movement wasn't shared, got confused with the other two.
20150901 04:36:17< celticminstrel> I'm going to try to get an idea of how difficult it would be to enforce that terrain types are constructed after movetypes.
20150901 04:36:32-!- ancestral [~ancestral@75-161-229-81.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150901 04:37:07< celticminstrel> Hmm.
20150901 04:37:10< shadowm> I think we can make an exception with the names since the [*defaults] and [movetype] tags have more or less a shared purpose (define or modify movement ypes).
20150901 04:37:19< celticminstrel> Okay.
20150901 04:37:39< shadowm> But it's at this point as it seems like the whole thing could be reworded in terms of individual movetypes rather than features of them.
20150901 04:37:55< celticminstrel> Huh?
20150901 04:38:16< shadowm> Like, [edit_movetype] name=smallfoot [movement_costs] mynewterraintype=3 [/edit_movetype] or so.
20150901 04:38:57< shadowm> But perhaps it's best to not pay too much aattention to this idea for the sake of getting it done.
20150901 04:39:30-!- Yaiyan [~Yaiyan@46.101.48.31] has quit [Ping timeout: 240 seconds]
20150901 04:39:36< celticminstrel> Ah, yeah, most of it could be done that way.
20150901 04:40:00< shadowm> After all, such an alternate syntax could prove too cumbersome for what is supposed to be a niche use case (introducing new damage or base terrain types).
20150901 04:40:10< celticminstrel> The only thing that might not quite make sense that way is the "default=" attribute which sets a value applied to all movetypes that don't have an explicit value given.
20150901 04:41:40-!- Yaiyan [~Yaiyan@46.101.48.31] has joined #wesnoth-dev
20150901 04:44:10< shadowm> celticminstrel: Re this variable and the template function following it: https://github.com/wesnoth/wesnoth/pull/477/files#diff-5c3015c1ec6963a9da9a75fff346f390R1006
20150901 04:44:21< shadowm> Immediately above them is an anonymous namespace.
20150901 04:44:59< shadowm> Declarations in an anonymous namespace by default have internal linkage, same as static storage.
20150901 04:46:15< celticminstrel> I personally prefer static since it doesn't introduce an indentation level (and XCode is really annoying about trying to force you to use the indentation it thinks is applicable), but I'll change it. Should I meld that change into the commit that introduced the function?
20150901 04:47:21< shadowm> It's mostly an observation, you don't need to change it if you prefer it this way.
20150901 04:47:38< celticminstrel> Eh, the anonymous namespace is right there, it would seem silly not to. >_>
20150901 04:47:53-!- jinblack [~jinblack@ip184-187-174-107.sb.sd.cox.net] has joined #wesnoth-dev
20150901 04:49:12< shadowm> If so then yes, merge it into the original commit.
20150901 04:50:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20150901 04:50:11< shadowm> Also, why is the new_key parameter to the template function passed by value?
20150901 04:51:05< shadowm> Anyway, that's all.
20150901 04:51:48< celticminstrel> I have no idea why it's passed by value.
20150901 04:52:16< shadowm> Best make it a const reference then, since it doesn't seem like the function does anything other than read from it.
20150901 04:52:21< celticminstrel> Already did.
20150901 05:31:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20150901 05:31:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20150901 05:33:05-!- sailorsw_ [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
20150901 05:45:00-!- [Relic] [~Relic]@2602:306:33a3:6d30:da8:2e9d:d5b4:64f1] has quit [Quit: I press the magic X and all the weirdos go away!]
20150901 06:01:31-!- oldlaptop [~quassel@50-107-94-87.adr02.mskg.mi.frontiernet.net] has quit [Ping timeout: 240 seconds]
20150901 06:03:52-!- oldlaptop [~quassel@50-107-94-87.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20150901 06:27:41-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20150901 06:28:47< aquileia> shadowm: a) the second commit will no longer work if they fix that bug before merging my PR, whereas the first alone will work just fine in that case
20150901 06:31:17< shadowm> But will the first one work *before* they fix it?
20150901 06:31:42< aquileia> b) no, anyone can switch to trusty by changing the .travis.yml, no activation was needed.
20150901 06:32:35< aquileia> The first commit doesn't use the apt addon and thus works in both cases
20150901 06:32:57< shadowm> (sb emd
20150901 06:33:00< shadowm> Oops.
20150901 06:33:19< shadowm> Okay, then I don't understand why the second commit exists at all.
20150901 06:33:41< shadowm> Also: 08:24:32 <aquileia> Feel free to write to their support about the OS X and Trusty beta programs -- so I don't need to write to them? :p
20150901 06:33:59< shadowm> How did you even come across this information? Did you just take a look at a repository that was built on trusty?
20150901 06:35:34< aquileia> The hint about docker based builds using trusty led me to it, and yes, I found the 'sudo: 9000' command in one of travis' own repos which is built on trusty
20150901 06:36:43< aquileia> shadowm: You don't need to write them, but they might write you if we just force our way in ;)
20150901 06:36:57< shadowm> Yeah I'll write to them and ask about the sudo option then.
20150901 06:38:06< aquileia> BTW, "sudo: 9000" is equivalent to "sudo: required" + "services: docker"
20150901 06:55:18-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20150901 06:59:22-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20150901 07:03:45< shadowm> aquileia: Email sent.
20150901 07:03:56< aquileia> ok
20150901 07:06:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150901 07:08:03-!- jinblack [~jinblack@ip184-187-174-107.sb.sd.cox.net] has quit [Ping timeout: 264 seconds]
20150901 07:12:10-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has joined #wesnoth-dev
20150901 07:16:07-!- Shackra [~Jorge@186.177.2.148] has quit [Read error: Connection reset by peer]
20150901 07:23:23-!- mjs-de [~mjs-de@f049180050.adsl.alicedsl.de] has joined #wesnoth-dev
20150901 07:32:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150901 07:45:42< shadowm> zookeeper: Anything to add regarding the convo earlier with celticminstrel?
20150901 07:45:49 * zookeeper is typing
20150901 07:47:12< zookeeper> shadowm, celticminstrel, conceptually i think the main purpose is to be able to set defaults for how units behave WRT a custom terrain or damage type, not to "edit movetypes". although arguably you could use it to change existing movetypes as well, which you couldn't if the former was tied to a terrain.
20150901 07:47:47< zookeeper> so maybe for the sake of versatility it should remain decoupled from terrains, even if that'd be the most common usecase
20150901 08:02:30-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Quit: Page closed]
20150901 08:09:27-!- joet [~joet@host86-163-217-248.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150901 08:11:06< shadowm> Right, that makes sense.
20150901 08:12:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150901 08:18:07-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150901 08:18:26-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150901 08:47:17 * vultraz waits for celticmisntral to return
20150901 09:18:56-!- sailorswift [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has joined #wesnoth-dev
20150901 09:21:24-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 264 seconds]
20150901 09:28:40-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has quit [Ping timeout: 246 seconds]
20150901 10:04:37-!- sailorswift [~sailorswi@c-50-156-105-171.hsd1.ca.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150901 10:29:45-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has joined #wesnoth-dev
20150901 10:39:44-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20150901 10:40:48-!- danni [~quassel@adsl-mel-4-147.ozonline.com.au] has joined #wesnoth-dev
20150901 10:57:33-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20150901 11:00:32-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150901 11:20:57-!- Kwandulin [~Miranda@p5B009DB6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150901 11:23:56-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has quit [Ping timeout: 272 seconds]
20150901 11:43:38-!- irker982 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150901 11:43:38< irker982> wesnoth: gfgtdf wesnoth:master 0abde389dc1a / src/ (7 files): show confirmation dialog when quitting http://git.io/vGaLX
20150901 11:43:38< irker982> wesnoth: gfgtdf wesnoth:master a247fae572cf / src/quit_confirmation.hpp: add comments http://git.io/vGaL1
20150901 11:43:38< irker982> wesnoth: gfgtdf wesnoth:master e5920a124086 / src/ (events.cpp quit_confirmation.cpp quit_confirmation.hpp): fix warning http://git.io/vGaLM
20150901 11:43:39< irker982> wesnoth: gfgtdf wesnoth:master 1748d78e138e / src/ (7 files): Merge pull request #480 from gfgtdf/quit_confirmation http://git.io/vGaLD
20150901 11:43:56-!- gfgtdf [~chatzilla@f054156157.adsl.alicedsl.de] has joined #wesnoth-dev
20150901 11:44:10< gfgtdf> celticminstrel: i merged my pr^
20150901 11:45:05-!- louis94 [~~louis94@109.133.211.155] has joined #wesnoth-dev
20150901 11:48:17-!- Kwandulin [~Miranda@p5B009DB6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150901 11:56:37< irker982> wesnoth: Charles Dang wesnoth:master 6c333d8278bb / projectfiles/CodeBlocks/wesnoth.cbp: Updated cb projectfile for 0abde389dc1a http://git.io/vGaOF
20150901 12:22:18-!- Kwandulin [~Miranda@p5B009DB6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150901 12:28:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150901 12:29:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150901 12:36:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150901 12:55:34-!- Kwandulin [~Miranda@p5B009DB6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150901 12:59:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150901 13:13:35-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150901 13:16:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150901 13:19:11-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150901 13:22:38-!- louis94 [~~louis94@109.133.211.155] has quit [Quit: Konversation terminated!]
20150901 13:23:28-!- boucman_work [~jrosen@80-15.80-90.static-ip.oleane.fr] has joined #wesnoth-dev
20150901 13:23:28-!- boucman_work [~jrosen@80-15.80-90.static-ip.oleane.fr] has quit [Changing host]
20150901 13:23:28-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150901 13:51:14-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20150901 14:03:23-!- louis94 [~~louis94@109.133.211.155] has joined #wesnoth-dev
20150901 14:07:57-!- louis94 [~~louis94@109.133.211.155] has quit [Client Quit]
20150901 14:30:12-!- danni [~quassel@adsl-mel-4-147.ozonline.com.au] has quit [Remote host closed the connection]
20150901 14:32:02-!- danni [~quassel@adsl-mel-4-147.ozonline.com.au] has joined #wesnoth-dev
20150901 14:51:47-!- [Relic] [~Relic]@2602:306:33a3:6d30:d0b7:2aa4:38de:ba06] has joined #wesnoth-dev
20150901 14:58:51-!- irker982 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150901 15:29:34-!- [Relic] [~Relic]@2602:306:33a3:6d30:d0b7:2aa4:38de:ba06] has quit [Quit: I press the magic X and all the weirdos go away!]
20150901 15:44:02 * vultraz pings celticminstrel
20150901 15:44:11 * celticminstrel pongs.
20150901 15:45:54< vultraz> celticminstrel: have a suggestion for a feature since you've been working on the advancements. [advancement] [show_if] and [command]
20150901 15:46:19< vultraz> (latter might be dispatched in favor of firing a specified post_advance event)
20150901 15:46:46< celticminstrel> I think I thought about show_if at some point...
20150901 15:49:29< zookeeper> [show_if] sounds like a confusing choice because those should be actual limitations (as in, apply to the AI or random advancements as well), not just "don't show this"
20150901 15:49:58< celticminstrel> I'm not sure about [command] though...
20150901 15:50:26< celticminstrel> Logically, I feel like a [command] in an [advancement] would need to be run when the advancement is applied.
20150901 15:50:29< zookeeper> maybe rather s/[command]/[then] similar to [object]
20150901 15:50:44< celticminstrel> That might end up causing it to run at unexpected times.
20150901 15:52:11< celticminstrel> Drawing a correlation to [object] probably isn't a good idea, since it's both an ActionWML tag and a [modifications] subtag.
20150901 15:52:27< celticminstrel> And the ActionWML version supports more things than the [modifications] version.
20150901 15:52:53 * vultraz thinks the whole way we deal with objects is incredibly confusing
20150901 15:53:25< celticminstrel> Then maybe we should deprecate [object] and replace it with something like [add_modification]?
20150901 15:54:05< celticminstrel> With almost the exact same syntax, but with some of it in a nested [object[.
20150901 15:54:11< celticminstrel> ^[object]
20150901 15:55:51< celticminstrel> I just suddenly thought of an interesting use for [effect]apply_to=new_advancement (though I'm not sure if it's currently possible) - give the unit an AMLA which can be chosen at any level and grants a temporary bonus until the end of the scenario.
20150901 15:56:23< celticminstrel> (I'm not sure if [advancement] supports the duration key, but durations are part of the advancement system rather than being specific to the [object] action.)
20150901 15:58:50-!- Appleman1234 [~Appleman1@KD111239019015.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20150901 16:02:38-!- Kwandulin [~Miranda@p5B009DB6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150901 16:10:23-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev
20150901 16:12:47-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150901 16:19:00-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has joined #wesnoth-dev
20150901 16:22:02-!- jinblack [~jinblack@ip184-187-174-106.sb.sd.cox.net] has joined #wesnoth-dev
20150901 16:45:41-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20150901 16:46:45-!- jinblack [~jinblack@ip184-187-174-106.sb.sd.cox.net] has quit [Ping timeout: 255 seconds]
20150901 16:50:42-!- joets [~joet@host86-163-222-106.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150901 16:52:54-!- joet [~joet@host86-163-217-248.range86-163.btcentralplus.com] has quit [Ping timeout: 250 seconds]
20150901 16:57:04< gfgtdf> celticminstrel: i actually think putting actionwml in [advance] or object that runs whever teh advancement is applied is a bad idea.
20150901 16:57:30< gfgtdf> celticminstrel: the problem is, that, when modifying units with wml you'll almost certainly use [unstore_unit]
20150901 16:57:34< celticminstrel> It's completely different from [then] in [object].
20150901 16:58:00< celticminstrel> Because, as I understand, the [then] is simply something that the action tag calls if a modification was applied.
20150901 16:58:08< celticminstrel> It's not a part of the actual modification.
20150901 16:58:11< gfgtdf> celticminstrel: yes i know.
20150901 16:58:25< gfgtdf> celticminstrel: and [unstore_unit] will itself casue the advancemnt to be applied again to we get an inifinitel loop
20150901 16:58:33< celticminstrel> I think show_if is a good idea though.
20150901 16:58:40< celticminstrel> (Probably with a different name.)
20150901 16:59:51< gfgtdf> celticminstrel: y i think we curently only allow "require_amla" as a filter which is not very powerful
20150901 17:00:09< celticminstrel> And I added exclude_amla.
20150901 17:00:17-!- Appleman1234 [~Appleman1@KD111239031098.au-net.ne.jp] has joined #wesnoth-dev
20150901 17:00:38< celticminstrel> Still only allows filtering based on advancements they already have, though.
20150901 17:01:00< gfgtdf> celticminstrel: it is in 1.13 possible to modify the advancement list of the possible advancements directly in the pre_advance event though.
20150901 17:01:00< celticminstrel> BTW, do you have any suggestions for a tag to replace the ActionWML [object]?
20150901 17:01:27< celticminstrel> I'm thinking of actually doing that.
20150901 17:01:48< gfgtdf> celticminstrel: hmm we already have [modify_unit] which is also able to apply advancements, object and trait to units
20150901 17:02:24-!- BeoXTC_ [3eb2b12a@gateway/web/cgi-irc/kiwiirc.com/ip.62.178.177.42] has joined #wesnoth-dev
20150901 17:02:26< celticminstrel> Actually, that's not true. I just looked at it just now, and it does not apply advancements.
20150901 17:02:31< celticminstrel> Only traits and objects.
20150901 17:03:12< celticminstrel> gfgtdf: Basically the idea is to make it clear that the ActionWML isn't quite the same as [object] under [modifications].
20150901 17:04:01< gfgtdf> celticminstrel: hm cant we easily add [advancement] to [modify_unit] ?
20150901 17:04:18< celticminstrel> Yeah, that'd be an easy quick-fix (maybe vultraz will do it).
20150901 17:04:35< celticminstrel> It's on lin 714 of wml-tags.lua in my copy.
20150901 17:04:37< celticminstrel> ^line
20150901 17:04:39< BeoXTC_> hi
20150901 17:05:08< celticminstrel> It just doesn't treat [advancement] specially like it does with [trait] and [object].
20150901 17:05:08< vultraz> I've always been confused as to whether there's a reason to use unstore_unit over modify_unit
20150901 17:05:10< vultraz> gfgtdf: 
20150901 17:05:21< BeoXTC_> is there any plan to move serialization from boost serialization to Google protocol buffers?
20150901 17:05:29< celticminstrel> vultraz: I believe [modify_unit] cannot delete things?
20150901 17:05:31< gfgtdf> vultraz: i want to remoing you to add no_write also to wesnoth.add_modification maybe as a third parameter
20150901 17:05:49< gfgtdf> remind*
20150901 17:06:06< vultraz> Ok
20150901 17:06:09< gfgtdf> BeoXTC_: not that i know of
20150901 17:06:20< gfgtdf> vultraz: you had  aquestion ?
20150901 17:06:26< celticminstrel> I have no idea what BeoXTC_ is talking about...
20150901 17:06:26< vultraz> [04:05:06]	vultraz	I've always been confused as to whether there's a reason to use unstore_unit over modify_unit
20150901 17:06:34-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20150901 17:07:09-!- joets [~joet@host86-163-222-106.range86-163.btcentralplus.com] has quit [Ping timeout: 244 seconds]
20150901 17:07:10< BeoXTC_> celticminstrel: ;) I  feel the same with most of the talk here
20150901 17:07:31< celticminstrel> I didn't think Boost serialization was used anywhere either.
20150901 17:08:06< gfgtdf> vultraz: i dont know the implementation details of [modify_unit] but:
20150901 17:08:24< gfgtdf> vultraz: 1) i think [unstore_unit] was older so there might be some people usign it simply for taht reason
20150901 17:08:48-!- [Relic] [~Relic]@2602:306:33a3:6d30:e17e:115a:2d9:1617] has joined #wesnoth-dev
20150901 17:09:08< vultraz> Sometimes I use it to preform a large number of changes at once but besides that I think they're the same
20150901 17:09:19< vultraz> Not sure tho
20150901 17:09:20< gfgtdf> vultraz: 2) also i think if you want to apply many modificaion to a unit, it better to use unstore_unit: you can simply store the unit apply ll changes to teh variables and then unstore teh unitvultraz: 2) also i think if you want to apply many modificaion to a unit, it better to use unstore_unit: you can simply store the unit apply ll changes to teh variables and then unstore teh unit
20150901 17:09:54< celticminstrel> I suspect [modify_unit] would work just as well for that actually.
20150901 17:10:30< celticminstrel> However I'm pretty sure [modify_unit] can only add and overwrite. It has no allowance for deleting thigns as far as I can see.
20150901 17:10:58< celticminstrel> Also its syntax for dealing with arrays is cumbersome.
20150901 17:11:16< gfgtdf> celticminstrel: y
20150901 17:11:21< vultraz> tru
20150901 17:11:49< celticminstrel> And inflexible.
20150901 17:11:54< gfgtdf> vultraz: actualy i dont think i have ever used [modify_unit] and iirc i also removed all [untore_unit] from my addons recently.
20150901 17:12:05< celticminstrel> The only thing you can do with arrays is "merge this with element i of the array".
20150901 17:12:12< celticminstrel> You can't move items around, delete items, etc.
20150901 17:14:08< celticminstrel> You could support deleting via magic attributes (to delete a container) or values (to delete an attribute), but I don't think you could easily support insertion or rearranging an array very easily, and I think the magic attributes/values wouldn't be much better than using store/unstore.
20150901 17:14:18< gfgtdf> you have an opinion about http://gna.org/bugs/?23841 ?
20150901 17:15:40< celticminstrel> Sounds pretty similar to functions, but with no allowance for parameters or return values.
20150901 17:16:15< gfgtdf> celticminstrel: it has parameters (the content of teh tag when you use it)
20150901 17:16:33< celticminstrel> Yeah, I realized that a bit after I said it.
20150901 17:16:34< gfgtdf> celticminstrel: and return values just like any other tag: by storing variables.
20150901 17:16:41 * celticminstrel nods.
20150901 17:17:25< celticminstrel> I think it could benefit from a slightly more standardized approach to return values, and maybe a different name, but overall I think it seems good.
20150901 17:22:06< celticminstrel> Also, maybe it should support delayed_variable_substitution=no.
20150901 17:22:17< celticminstrel> As written it's kind of dangerous.
20150901 17:22:33< celticminstrel> You can blindly overwrite any preset WML tags, including [make_tag] itself.
20150901 17:27:13< celticminstrel> Oh, whoops, I forgot to sign my comment.
20150901 17:46:22-!- Kwandulin [~Miranda@p5B009DB6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150901 17:47:28< BeoXTC_> what data encoding do we use?
20150901 17:49:54-!- danni [~quassel@adsl-mel-4-147.ozonline.com.au] has quit [Remote host closed the connection]
20150901 18:04:38< gfgtdf> BeoXTC_: the savefiles are usually gz files.
20150901 18:08:34< celticminstrel> Speaking of which, I think it'd make sense if they had their own file extension.
20150901 18:08:41-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150901 18:09:19< celticminstrel> Regardless of whether or not they are compressed.
20150901 18:12:36-!- jinblack [~jinblack@128.111.48.6] has joined #wesnoth-dev
20150901 18:18:57-!- louis94 [~~louis94@109.133.211.155] has joined #wesnoth-dev
20150901 18:23:01< BeoXTC_> I see. thx
20150901 18:30:09-!- joets [~joet@host86-163-222-106.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150901 18:33:04-!- framling [~user@c-50-186-43-50.hsd1.or.comcast.net] has quit [Read error: Connection reset by peer]
20150901 18:39:06-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150901 18:41:06< celticminstrel> BeoXTC_: The save files are also WML.
20150901 18:41:10-!- Kwandulin [~Miranda@p5B009DB6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150901 18:44:39-!- joets [~joet@host86-163-222-106.range86-163.btcentralplus.com] has quit [Ping timeout: 255 seconds]
20150901 18:52:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150901 18:54:37< BeoXTC_> how can I turn on debug output on wesnothd?
20150901 18:54:47-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Ping timeout: 256 seconds]
20150901 18:56:20-!- c74d [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150901 19:09:18-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150901 19:15:57-!- gfgtdf [~chatzilla@f054156157.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 40.0.3/20150826023504]]
20150901 19:34:10-!- Netsplit *.net <-> *.split quits: Samual, ypnos, {V}, higgins
20150901 19:34:52-!- Netsplit over, joins: higgins
20150901 19:35:02-!- Netsplit over, joins: {V}, ypnos, Samual
20150901 19:36:43< shadowm> BeoXTC_: Pass -v in the command line.
20150901 19:37:25< shadowm> You can also do it for specific log domains using --log-debug=<doman list>, like with the game.
20150901 19:38:19-!- irker790 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150901 19:38:19< irker790> wesnoth: Ignacio R. Morelle wesnoth:master b68686eb45db / src/quit_confirmation.hpp: Add include guards http://git.io/vGrok
20150901 19:41:29-!- BeoXTC_ [3eb2b12a@gateway/web/cgi-irc/kiwiirc.com/ip.62.178.177.42] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
20150901 19:42:00-!- BeoXTC_ [3eb2b12a@gateway/web/cgi-irc/kiwiirc.com/ip.62.178.177.42] has joined #wesnoth-dev
20150901 19:42:15< shadowm> aquileia: They didn't mention sudo: 9000, instead they told me to use sudo: required and services: - docker.
20150901 19:47:59-!- Netsplit *.net <-> *.split quits: Samual, {V}, ypnos
20150901 19:52:40-!- Netsplit over, joins: {V}, ypnos, Samual
20150901 19:59:44-!- BeoXTC_ [3eb2b12a@gateway/web/cgi-irc/kiwiirc.com/ip.62.178.177.42] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
20150901 20:02:13-!- joets [~joet@host86-163-222-106.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150901 20:18:22-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150901 20:18:48-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150901 20:20:31-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 246 seconds]
20150901 20:20:32-!- wedge010 is now known as wedge009
20150901 20:35:41-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev
20150901 20:43:09-!- joets [~joet@host86-163-222-106.range86-163.btcentralplus.com] has quit [Remote host closed the connection]
20150901 21:00:09-!- louis94 [~~louis94@109.133.211.155] has quit [Quit: Konversation terminated!]
20150901 21:56:48-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150901 21:57:22-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev
20150901 22:04:56-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150901 22:25:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150901 22:26:40-!- mjs-de [~mjs-de@f049180050.adsl.alicedsl.de] has quit [Remote host closed the connection]
20150901 22:28:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds]
20150901 22:38:49-!- irker790 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150901 22:44:22-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150901 23:11:44-!- legoktm is now known as egoktm
20150901 23:14:39-!- egoktm is now known as legoktm
20150901 23:23:49-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20150901 23:25:10-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20150901 23:34:00-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Ping timeout: 264 seconds]
20150901 23:56:03-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 1.0.1]
20150901 23:57:39-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
--- Log closed Wed Sep 02 00:00:49 2015