--- Log opened Fri Sep 18 00:00:07 2015
--- Day changed Fri Sep 18 2015
20150918 00:00:07< celticminstrel> Will fix momentarily.
20150918 00:00:38< celticminstrel> shadowm: Is there a gna bug for that?
20150918 00:01:45-!- [Relic] [~Relic]@2602:306:33a3:6d30:9dfb:2dbb:e91a:b980] has joined #wesnoth-dev
20150918 00:06:47-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Disconnected by services]
20150918 00:08:10-!- gfgtdf [~chatzilla@f054136178.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 40.0.3/20150826023504]]
20150918 00:10:20-!- oldlaptop [~quassel@192.183.51.75] has joined #wesnoth-dev
20150918 00:12:46-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150918 00:17:26< shadowm> No idea.
20150918 00:18:01< shadowm> I vaguely remember seeing or filing a bug ages ago but I don't remember seeing it again, so the earlier memory might not be accurate or real.
20150918 00:19:49< shadowm> For all I know it may be even be from a dream.
20150918 00:20:58-!- Jozrael [Jozrael@cpe-23-243-167-222.socal.res.rr.com] has joined #wesnoth-dev
20150918 00:21:18< shadowm> There are ways to search the bug tracker, though, if you feel so inclined. It's mostly a matter of finding the right keywords (which unfortunately requires you to take every possible misspelling into account) and mess with the advanced filter form (the search page is pretty much unusable).
20150918 00:21:40< celticminstrel> I tried a little, didn't find anything.
20150918 00:21:57< shadowm> (Yes, not too long ago I tried to find a report for a bug I fixed and failed because I didn't think of intentionally misspelling the keyword).
20150918 00:22:05< celticminstrel> What's the proper way to report this kind of error? FAIL()? VALIDATE()? Something else?
20150918 00:22:24< shadowm> (So if you see a misspelled bug report subject you might want to go and do everyone a favor by fixing it.)
20150918 00:22:34< celticminstrel> I'll keep that in mind.
20150918 00:23:01< shadowm> I've never heard of FAIL and VALIDATE throws an exception that takes you back to the title screen. That might not be desirable.
20150918 00:23:18< celticminstrel> They both throw the same exception.
20150918 00:23:19< celticminstrel> Hmm.
20150918 00:23:30< shadowm> Just aborting the particular command requested and writing an error to stderr would do IMO.
20150918 00:24:19< shadowm> And if it breaks someone's add-on, that's their problem and I wouldn't even bother with warning them about it in R_N.
20150918 00:25:06< shadowm> But again, the problem is not quite specific to [set_variable].
20150918 00:25:47< celticminstrel> I started writing it as a function in config::attribute_value that returns the ID if valid and throws an exception otherwise, but I guess something that returns a bool is probably better.
20150918 00:26:04< shadowm> [insert_tag] might be used to generate illegal WML too, and any command that generates left-hand-side WML from RHS values.
20150918 00:26:13< shadowm> (Or Lua.)
20150918 00:27:35< celticminstrel> Tag names and attribute names both must satisfy [a-zA-Z_][a-zA-Z0-9_]+, right?
20150918 00:27:37< shadowm> Although it really should be config's mission to guarantee that every object can be serialized as legal WML, we use config everywhere.
20150918 00:28:09< shadowm> That means that in the interest of not degrading performance (esp. copy operations) the config writer should be the final frontier instead.
20150918 00:28:31< shadowm> I.e. the code in charge of serializing config to text in serialization/parser.cpp.
20150918 00:29:04< shadowm> That file also happens to contain the WML parser itself (duh), and I'd use its implementation as a reference point for validation since anything else is really just guesswork.
20150918 00:29:32-!- Guest16999 [~Gambot@grickit.us] has quit [Remote host closed the connection]
20150918 00:30:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20150918 00:31:42< celticminstrel> So you're saying I should check there to see what's actually valid?
20150918 00:31:43< shadowm> For example, that regex is wrong.
20150918 00:31:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150918 00:32:13< shadowm> It's the most obvious guess, but reality is actually simpler than that.
20150918 00:32:35< shadowm> Case in point: http://pastebin.com/vBAhy4Zm
20150918 00:32:54< celticminstrel> Okay.
20150918 00:33:13< shadowm> This can actually be parsed and passed to [set_variables].
20150918 00:34:21< shadowm> Why anyone would want numeric tag names is beyond me, but that's the way things are and there isn't a compelling reason to change it.
20150918 00:35:36< shadowm> (Similarly, macro symbol names probably accept every single character sequence in existence that isn't part of the preprocessor syntax (i.e. whitespace, (, ), {, }, <<, >>, "), and perhaps even a few of those.)
20150918 00:35:46 * celticminstrel is looking at serialization/tokenizer.cpp and wondering what <> is for.
20150918 00:36:10< celticminstrel> Yeah, I've noticed several mainline macros use : in the name.
20150918 00:38:01< shadowm> < and > are part of the parser verbatim string syntax.
20150918 00:38:08< celticminstrel> Ohh, right.
20150918 00:38:11< shadowm> foo=<< verbatim string >>
20150918 00:38:13< celticminstrel> I forgot about that syntax.
20150918 00:38:31< shadowm> The preprocessor has to be aware of verbatim strings too since the whole point is that no preprocessor directives are handled inside them.
20150918 00:39:01< celticminstrel> Because the whole point of verbatim strings is that they can contain Lua code, which needs {} to represent tables.
20150918 00:39:13< celticminstrel> Or something like that.
20150918 00:39:46-!- joet [~joet@host86-163-221-131.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150918 00:40:04< shadowm> Yes, the syntax exists primarily because of that, but also because it's way too awkward to escape quotes in WML.
20150918 00:40:41< shadowm> "foo ""deeeply """nested""" quotes"" bar".
20150918 00:40:41< celticminstrel> Which log stream should errors about invalid keys be written to when saving?
20150918 00:40:46< shadowm> Or so IIRC. At least the first level is certainly two quotes.
20150918 00:40:53< shadowm> ERR_CFG ?
20150918 00:41:15< shadowm> Defined there as ERR_CF, same thing.
20150918 00:44:27-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150918 00:46:44-!- Shackra_ [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150918 00:47:19< celticminstrel> I can't seem to find the implementation of [set_variables]
20150918 00:47:36-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150918 00:48:27< celticminstrel> Oh wait.
20150918 00:48:57< celticminstrel> I was looking at the implementation for wesnoth.set_variable, not the implementation of the WML tags.
20150918 00:49:34-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 272 seconds]
20150918 00:50:32-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds]
20150918 00:52:37-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20150918 00:52:37-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20150918 00:52:37-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150918 01:20:47-!- joet [~joet@host86-163-221-131.range86-163.btcentralplus.com] has quit [Ping timeout: 246 seconds]
20150918 01:26:49< celticminstrel> Is it correct that wesnoth.set_variable("foo[$i].bar","baz") fails? I'm guessing yes, but just checking.
20150918 01:28:16< celticminstrel> Also, there's already some sanity checks for variable name validity (making sure it's a valid x.y[7].z type thing), is it fine to add one more check that the x's, y's, and z's are valid?
20150918 01:28:34< celticminstrel> Since shadowm mentioned something about performance.
20150918 01:33:17-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150918 01:42:12< celticminstrel> First question seems to be confirmed.
20150918 01:43:20< celticminstrel> Variable/key/tag names are usually fairly short, so I guess it probably won't be a problem.
20150918 01:44:51-!- irker542 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150918 01:44:51< irker542> wesnoth: Celtic Minstrel wesnoth:master af2e16f842b6 / src/ (config.cpp config.hpp serialization/parser.cpp variable_info.cpp): Add sanity-checking for WML attribute/tag/variable names to prevent invalid save http://git.io/vnk35
20150918 01:46:22< celticminstrel> Oh, forgot changelog.
20150918 01:51:07< celticminstrel> Only problem with that commit is that nearly every file needs to be recompiled, probably due to touching config.hpp. :/
20150918 01:51:30< shadowm> We are in 2015, it's hardly a problem. ;)
20150918 01:51:54< celticminstrel> The compile time?
20150918 01:51:59-!- Jozrael [Jozrael@cpe-23-243-167-222.socal.res.rr.com] has quit [Ping timeout: 250 seconds]
20150918 01:51:59< celticminstrel> It's a problem for me. >_>
20150918 01:52:38< celticminstrel> Do you have time to look over PR492?
20150918 01:52:56< shadowm> Sort of.
20150918 01:53:32-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 272 seconds]
20150918 02:03:39-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20150918 02:03:45-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20150918 02:03:45-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150918 02:07:36-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150918 02:11:13-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 256 seconds]
20150918 02:11:13-!- wedge010 is now known as wedge009
20150918 02:13:49-!- programmerboy [bd46f13a@gateway/web/freenode/ip.189.70.241.58] has joined #wesnoth-dev
20150918 03:14:52-!- jinblack [~jinblack@128.111.48.6] has quit [Remote host closed the connection]
20150918 03:16:32-!- programmerboy [bd46f13a@gateway/web/freenode/ip.189.70.241.58] has quit [Quit: Page closed]
20150918 03:49:52-!- Jozrael [~Jozrael@cpe-23-243-167-222.socal.res.rr.com] has joined #wesnoth-dev
20150918 04:12:39< shadowm> Of course I had to go afk immediately afterwards.
20150918 04:19:06-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev
20150918 04:29:42< irker542> wesnoth: Celtic Minstrel wesnoth:master 2fd07684f2af / changelog players_changelog: Update changelog http://git.io/vnkiO
20150918 04:33:30-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 244 seconds]
20150918 04:35:10-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150918 04:40:36-!- Jozrael [~Jozrael@cpe-23-243-167-222.socal.res.rr.com] has quit [Read error: Connection reset by peer]
20150918 04:40:48-!- Jozrael [~Jozrael@cpe-23-243-167-222.socal.res.rr.com] has joined #wesnoth-dev
20150918 04:45:05-!- Jozrael [~Jozrael@cpe-23-243-167-222.socal.res.rr.com] has quit [Ping timeout: 240 seconds]
20150918 04:46:52< celticminstrel> Given a direction (eg "ne"), what's a good way to say "the direction to the left of that"?
20150918 04:47:05< celticminstrel> Similar to how "-ne" means "the direction opposite that".
20150918 04:48:44< celticminstrel> (The use-cases is if "ne" is actually given by a variable, so for example "-$facing" always gives you the opposite direction.).)
20150918 04:54:29< irker542> wesnoth: Celtic Minstrel wesnoth:master 617fb262387d / changelog src/synced_commands.cpp: Add debug command :unit status=list,of,statuses,to,add,or,-remove http://git.io/vnkMq
20150918 05:00:02-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150918 05:02:18-!- oldlaptop [~quassel@192.183.51.75] has quit [Quit: No Ping reply in 180 seconds.]
20150918 05:32:00-!- oldlaptop [~quassel@192.183.51.75] has joined #wesnoth-dev
20150918 05:35:12-!- tomreyn_ [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150918 05:38:48-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Ping timeout: 264 seconds]
20150918 05:45:22< shadowm> I think that's a question for mattsc or other mathematically-oriented minds.
20150918 05:46:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150918 05:46:43< shadowm> The reason being that the definition of "left" or "right" in this case is tied to the column's parity.
20150918 05:46:59< shadowm> (Spatial definition.)
20150918 05:50:24-!- Shackra_ [~Jorge@186.177.2.148] has quit [Ping timeout: 272 seconds]
20150918 05:51:48< vultraz> celticminstrel: so if you have ne you want to find n?
20150918 05:51:51< vultraz> or do you want sw
20150918 05:52:12< celticminstrel> Either n or se
20150918 05:54:27< shadowm> Okay I don't follow that anymore.
20150918 05:54:42< vultraz> Oh, I see
20150918 05:55:01-!- oldlaptop [~quassel@192.183.51.75] has quit [Ping timeout: 240 seconds]
20150918 05:57:08< vultraz> Some of mattsc's hex as Cartesian logic might work
20150918 05:57:31< shadowm> Given S = (16, 8) the starting point, to the left of the NE adjacent hex T = (17, 8) there are two hexes, U = (16, 7) @ NW, and S @ SW.
20150918 05:58:18< shadowm> If S = (15, 8), T = (16, 7), U = (15, 7).
20150918 05:59:01< shadowm> So you can see there how column parity affects the result maths-wise.
20150918 05:59:48< shadowm> Now, given any hex A with B @ NW and C @ SW, which one would you consider to be "to the left" of A if you had to choose a single one?
20150918 06:00:46< shadowm> The one with identical ordinate, or the one with differing ordinate?
20150918 06:01:26< shadowm> Either answer means that the real relative direction varies.
20150918 06:11:34-!- Kwandulin [~Miranda@p5B0093B8.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150918 06:12:07< shadowm> (Also, sorry, I won't be able to take a look at #492 right now without it sounding like Chinese to me. I'll hopefully get to it within the next 24 hours.)
20150918 06:17:27-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150918 06:19:50< celticminstrel> I think I wasn't clear.
20150918 06:20:21< celticminstrel> The functionality I want is already in the API (as map_location::rotate_right), what I want is an "operator" representing it.
20150918 06:21:30< celticminstrel> Just like how - is currently an operator meaning "take the opposite direction".
20150918 06:33:04< vultraz> Ohh
20150918 06:34:21< celticminstrel> Sorry.
20150918 06:35:02< celticminstrel> So eg if you chose -- and ++ (probably not a good choice), then ne-- might be the same as n.
20150918 06:40:09< celticminstrel> Well, I've implemented my new idea relating to backstab - an auto-stored $other_unit for [filter_adjacent], plus the aforementioned operators (still open to alternate ideas for the operator though, currently using ".cw" and ".ccw").
20150918 06:40:58< celticminstrel> Testing will happen after sleep.
20150918 06:41:06-!- celticminstrel is now known as celmin|sleep
20150918 06:41:35< celmin|sleep> ($other_unit is also available to [filter_self/opponent/attacker/defender] in weapon specials.)
20150918 06:41:49-!- [Relic] [~Relic]@2602:306:33a3:6d30:9dfb:2dbb:e91a:b980] has quit [Quit: I press the magic X and all the weirdos go away!]
20150918 06:41:56< celmin|sleep> (If there's anywhere else I should add it, please tell.)
20150918 06:42:45< Ravana_> abilities, like leadership
20150918 06:43:21< celmin|sleep> Maybe? Not quite as obvious how it'd apply there, but I'll take a look.
20150918 06:43:47< Ravana_> it would allow single [leadership] block deal with all level combinations
20150918 06:44:07< celmin|sleep> Hmm, would it? I thought that also needed some sort of formula support to work.
20150918 06:44:28< Ravana_> I thought other_unit gives it
20150918 06:44:38< celmin|sleep> Maybe.
20150918 06:44:46< celmin|sleep> Haven't tried it out yet.
20150918 06:45:03< celmin|sleep> I'll investigate tomorrow.
20150918 06:56:11-!- jinblack [~jinblack@ip184-187-174-107.sb.sd.cox.net] has joined #wesnoth-dev
20150918 07:00:51-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150918 07:00:58-!- jinblack [~jinblack@ip184-187-174-107.sb.sd.cox.net] has quit [Ping timeout: 260 seconds]
20150918 07:01:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150918 07:06:37-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150918 07:08:22-!- tomreyn_ is now known as tomreyn
20150918 07:09:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150918 07:12:54-!- jinblack [~jinblack@jinblack.it] has joined #wesnoth-dev
20150918 07:18:58-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind1]
20150918 07:29:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150918 07:32:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150918 07:51:25< Aginor> more hours of banging my head against the alpha blending...
20150918 07:51:40< Aginor> it's non-trivial and there's plenty of graphics code to figure out in the process
20150918 07:54:44-!- irker542 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150918 08:00:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150918 08:01:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150918 08:08:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150918 08:10:05-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150918 08:15:41-!- mjs-de [~mjs-de@x5ce331c0.dyn.telefonica.de] has joined #wesnoth-dev
20150918 08:16:46-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150918 08:19:35-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Client Quit]
20150918 08:26:47-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150918 08:31:10-!- jinblack [~jinblack@jinblack.it] has quit [Ping timeout: 244 seconds]
20150918 08:39:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150918 08:48:25-!- Appleman1234 [~Appleman1@KD118156250060.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20150918 08:54:08-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150918 08:55:25-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20150918 08:56:39-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 252 seconds]
20150918 09:31:42-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20150918 09:46:59-!- joet [~joet@host86-163-221-131.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150918 09:51:23-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150918 09:57:32-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20150918 10:01:03-!- Appleman1234 [~Appleman1@118.156.250.60] has joined #wesnoth-dev
20150918 10:20:30< wedge009> Aginor: Perhaps if the problem could be isolated and reproduced on more than one machine? If I can reproduce the problem I can try to help... though I find debugging graphical stuff difficult too.
20150918 10:52:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150918 11:03:09< Aginor> wedge009: it is sadly reproducible on more than one machine, it's shadowm who found it first
20150918 11:03:32< Aginor> I am just fortunate enough that I can reproduce it on my old macbook
20150918 11:04:04< Aginor> it seems to be tied to nvidia graphics, but I am not sure what is different in your nvidia setup from ours
20150918 11:05:36 * Aginor ponders going out and buying a cheapie nvidia card to puts in his workstation
20150918 11:17:00< wedge009> Aginor: So of the two instances where the problem arises (yours and shadowm's) the common factor so far is an NVIDIA GPU. One is on Linux, one is on OS X. Is that right? Are proprietary drivers used on both, or is the Linux one using nouveau?
20150918 11:19:36< Aginor> proprietary drivers are used in both as far as I know
20150918 11:20:04< Aginor> I'm currently replacing the renderer with a dedicated software renderer as a trial on osx
20150918 11:20:27< Aginor> it's just a very slow and old laptop :)
20150918 11:20:35< wedge009> Aww.
20150918 11:20:53< Aginor> wedge009: are you using OSS or closed source driver?
20150918 11:23:32< wedge009> I don't have any working Linux machines with NV GPU at the moment, though I'm trying to rebuild one at the moment. For all the flak AMD gets - justified or otherwise - over its driver quality, NVIDIA's drivers in Linux drives me nuts, especially when it comes to OpenCL support.
20150918 11:25:33< Aginor> I do approve of AMD's commitment to OSS
20150918 11:25:39< Aginor> but they could be faster :D
20150918 11:25:40< wedge009> Out of curiosity, I wonder if the problem is still there with nouveau drivers. I was using the open-source radeon driver on my Linux laptop and it didn't exhibit any blending issues.
20150918 11:25:50< wedge009> Lack of money, I fear.
20150918 11:25:57< Aginor> yeah
20150918 11:28:12< Aginor> ok, software renderer thing is not quite enough
20150918 11:32:29< vultraz> aren't proprietary drivers almost always better than oss ones?
20150918 11:39:12< Aginor> vultraz: that's debatable for some things
20150918 11:39:35< Aginor> but the main reason is that vendors aren't too keen on releasing the documentation needed to write good drivers
20150918 11:39:53< Aginor> ok, got proper software rendering going in SDL2
20150918 11:39:58< Aginor> same problem
20150918 11:42:01< Aginor> vultraz: in the test scenario, which is the widget for the vision test?
20150918 11:49:50< Aginor> +used
20150918 11:55:32< wedge009> vultraz: Creative's attempt at X-Fi drivers on Linux were atrocious, from what I've read. But even looking at the graphics domain, some older hardware have much better support with the open source drivers, especially if the focus from the vendor is on newer hardware and the older hardware have just been neglected.
20150918 11:58:45-!- joet [~joet@host86-163-221-131.range86-163.btcentralplus.com] has quit [Ping timeout: 255 seconds]
20150918 11:58:48< vultraz> Aginor: widget?
20150918 12:01:45< Aginor> vultraz: I think it might be a gui1 textbox with some transparency
20150918 12:01:54< Aginor> (gui widget)
20150918 12:09:34 * Aginor disappears
20150918 12:17:40-!- joet [~joet@host86-163-221-131.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150918 12:17:51-!- Kwandulin [~Miranda@p5B0093B8.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150918 12:19:13< vultraz> really not sure
20150918 13:06:32-!- Kwandulin [~Miranda@p5B0093B8.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150918 13:23:35-!- joet [~joet@host86-163-221-131.range86-163.btcentralplus.com] has quit [Ping timeout: 250 seconds]
20150918 13:38:52-!- joet [~joet@host86-163-221-131.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150918 14:20:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20150918 14:21:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150918 14:44:30-!- joet [~joet@host86-163-221-131.range86-163.btcentralplus.com] has quit [Ping timeout: 240 seconds]
20150918 14:46:06-!- joet [~joet@host86-163-220-130.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150918 14:46:50-!- Appleman1234 [~Appleman1@118.156.250.60] has quit [Ping timeout: 272 seconds]
20150918 14:56:20-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150918 15:00:46-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150918 15:13:47-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150918 15:18:19-!- joet [~joet@host86-163-220-130.range86-163.btcentralplus.com] has quit [Ping timeout: 240 seconds]
20150918 15:21:53-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev
20150918 15:24:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 272 seconds]
20150918 15:32:07-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150918 15:37:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150918 15:37:40-!- oldlaptop [~quassel@192.183.51.75] has joined #wesnoth-dev
20150918 15:51:47-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 250 seconds]
20150918 15:55:23-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150918 15:56:41-!- joet [~joet@host86-163-217-219.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150918 16:01:49-!- celmin|sleep is now known as celtiminstrel
20150918 16:04:22-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150918 16:08:43-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150918 16:11:33-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has quit [Quit: Leaving]
20150918 16:16:15-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150918 16:16:48< celtiminstrel> Should I deprecate [filter_adjacent] and [filter_adjacent_location] within abilities and weapon specials? Nesting them within other filters, and is more powerful as well (supporting count= and is_enemy=).
20150918 16:17:35-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 264 seconds]
20150918 16:17:49< celtiminstrel> They're undocumented in abilities, actually.
20150918 16:18:17< celtiminstrel> I guess they'd be equivalent to [affect_adjacent][filter] and [affect_adjacent][filter][filter_location].
20150918 16:19:15< celtiminstrel> In weapon specials they're equivalent to [filter_self][filter_adjacent] and [filter_self][filter_location][filter_adjacent_location], I believe.
20150918 16:20:39< celtiminstrel> Actually, no, I think in abilities they'd be equivalent to the same as I said for weapon specials. Which has a completely different meaning (the ability only affects the unit itself and is only active if some other unit is next to it).
20150918 16:23:34-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20150918 16:24:11-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev
20150918 16:26:43< celtiminstrel> So... adding $other_unit to [affect_adjacent][filter] should satisfy Ravana_'s request.
20150918 16:31:38-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150918 16:36:39-!- joet [~joet@host86-163-217-219.range86-163.btcentralplus.com] has quit [Ping timeout: 240 seconds]
20150918 16:38:29-!- Kwandulin [~Miranda@p5B0093B8.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150918 16:46:23-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150918 16:55:56-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150918 17:00:49-!- louis94 [~~louis94@109.129.229.117] has joined #wesnoth-dev
20150918 17:04:30-!- [Relic] [~Relic]@2602:306:33a3:6d30:3dc0:8552:1a83:7c5] has joined #wesnoth-dev
20150918 17:18:55-!- ancestral [~ancestral@76.sub-70-197-208.myvzw.com] has joined #wesnoth-dev
20150918 17:32:52-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150918 17:39:24-!- ancestral [~ancestral@76.sub-70-197-208.myvzw.com] has quit [Read error: Connection reset by peer]
20150918 17:39:59-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 256 seconds]
20150918 17:55:56-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150918 17:57:58-!- louis94 [~~louis94@109.129.229.117] has quit [Ping timeout: 240 seconds]
20150918 17:58:30-!- Kwandulin [~Miranda@p5B0093B8.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150918 18:00:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150918 18:01:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150918 18:04:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20150918 18:22:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150918 18:32:13< celtiminstrel> Thinking about it again, I think that might not allow [leadership] to be done with a single tag, but I think it would allow it to be done with a single macro.
20150918 18:32:50< celtiminstrel> Given a level cap of 5, which admittedly isn't the case.
20150918 18:33:00< celtiminstrel> It's a start, though.
20150918 18:56:45< celtiminstrel> Okay, my scoped variable appears not to work, for some reason...
20150918 18:58:20< celtiminstrel> Wait...
20150918 18:59:28< celtiminstrel> It's because special keys in [filter_adjacent] are processed at contruct time, not at match time.
20150918 19:04:22< celtiminstrel> Is it safe to copy a vconfig?
20150918 19:04:36-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 264 seconds]
20150918 19:05:04< celtiminstrel> I guess its copy constructor is defaulted, so it likely is...
20150918 19:05:59-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20150918 19:19:46< celtiminstrel> Works! :D
20150918 19:20:42-!- jinblack [~jinblack@128.111.48.6] has joined #wesnoth-dev
20150918 19:20:44< celtiminstrel> Well, mostly.
20150918 19:21:24< celtiminstrel> Oh wait, that mostly seems to be an error in my ability definition.
20150918 19:23:04< celtiminstrel> ...I think there's still a minor issue to work out, though.
20150918 19:24:11< celtiminstrel> Need to set facing before the attack starts.
20150918 19:27:10< celtiminstrel> I have a setup with a thief and a goblin to his north and a fighter "between" them to the west. The thief starts out facing southwest, and the fighter is southwest of the goblin, so backstab is shown to be active, and the first hit does 8 damage, but subsequent hits are 4 damage.
20150918 19:30:46-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150918 19:33:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20150918 19:33:24-!- wedge010 is now known as wedge009
20150918 19:35:11< celtiminstrel> Everything is const.
20150918 20:09:01< celtiminstrel> Weird. The defender's direction is set twice, to the same value, on lines 601 and 602 of unit_display.cpp.
20150918 20:14:13< celtiminstrel> Okay, now I have a weird thing where it shows in the attack window only if it's inactive (but its effect is shown correctly).
20150918 20:14:39< celtiminstrel> ie, the thief's attack is shown either as "4-3 backstab" or as "8-3".
20150918 20:15:40< celtiminstrel> It fixed itself somehow. Maybe after attacking once.
20150918 20:27:58-!- Kwandulin [~Miranda@p5B0093B8.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150918 20:35:03< celtiminstrel> For some reason my debugger isn't letting me step into battle_context::battle_context.
20150918 20:38:34< celtiminstrel> Maybe because it's declared only in a source file?
20150918 20:38:51< celtiminstrel> Whatever the reason, it makes this hard to debug. :|
20150918 20:57:58< celtiminstrel> I was wrong, it's declared in attack.hpp.
20150918 21:01:02< celtiminstrel> All this attack-simulating stuff is confusing me. All I want to do is make sure that the unit is facing its opponent when calculating any ability or weapon special filters.
20150918 21:01:27< celtiminstrel> Maybe not ability filters.
20150918 21:12:53-!- jinblack [~jinblack@128.111.48.6] has quit [Ping timeout: 252 seconds]
20150918 21:13:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150918 21:18:06< shadowm> wedge009, Aginor: Yes, proprietary here.
20150918 21:18:13-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 268 seconds]
20150918 21:20:51< Aginor> shadowm: thanks
20150918 21:21:36< Aginor> shadowm: would you be able to tell me what the little popup-widget is that's used in the vision test in the test scenario? - I'd like to trace through it's render path
20150918 21:22:14-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150918 21:22:15-!- jinblack [~jinblack@128.111.48.6] has joined #wesnoth-dev
20150918 21:26:33< shadowm> Vision test? Hm...
20150918 21:27:20< shadowm> Aginor: It's a tooltip, not a widget. AFAIK tooltips are not widgets atm (other than the not-used-by-default GUI2 tooltip widget).
20150918 21:27:50< shadowm> Tooltips share a code path with the chat lines display on the top left IIRC.
20150918 21:28:07< Aginor> shadowm: ah, that would explain why I was struggling to find it
20150918 21:28:27< Aginor> would you be able to point me at the implementation?
20150918 21:28:28< shadowm> It's completely unaware of everything else and thus tends to cause problems (esp. with GUI2 dialog event handling).
20150918 21:28:45< shadowm> Yes, in an hour or so. I must leave right now.
20150918 21:28:53< celtiminstrel> Aw.
20150918 21:29:21< Aginor> nevermind, tooltips.cpp looks like a good starting place
20150918 21:29:23< Aginor> thanks :)
20150918 21:30:54-!- mjs-de [~mjs-de@x5ce331c0.dyn.telefonica.de] has quit [Remote host closed the connection]
20150918 21:31:14-!- trewe [~trewe@2001:8a0:d124:b801:626c:66ff:fe92:9b7c] has joined #wesnoth-dev
20150918 21:31:54-!- trewe [~trewe@2001:8a0:d124:b801:626c:66ff:fe92:9b7c] has quit [Max SendQ exceeded]
20150918 21:32:25-!- trewe [~trewe@2001:8a0:d124:b801:626c:66ff:fe92:9b7c] has joined #wesnoth-dev
20150918 21:33:28-!- trewe [~trewe@2001:8a0:d124:b801:626c:66ff:fe92:9b7c] has quit [Max SendQ exceeded]
20150918 21:34:02-!- trewe [~trewe@2001:8a0:d124:b801:626c:66ff:fe92:9b7c] has joined #wesnoth-dev
20150918 21:34:58-!- trewe [~trewe@2001:8a0:d124:b801:626c:66ff:fe92:9b7c] has quit [Max SendQ exceeded]
20150918 21:44:30-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150918 21:49:43-!- louis94 [~~louis94@109.129.229.117] has joined #wesnoth-dev
20150918 21:56:09-!- noy_ [~Noy@50.255.13.67] has joined #wesnoth-dev
20150918 21:56:09-!- noy_ [~Noy@50.255.13.67] has quit [Changing host]
20150918 21:56:09-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150918 21:57:57-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 250 seconds]
20150918 21:57:57-!- noy_ is now known as noy
20150918 22:38:56-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150918 22:39:15-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150918 22:45:59-!- Jozrael [~Jozrael@rrcs-72-43-14-98.nys.biz.rr.com] has joined #wesnoth-dev
20150918 22:53:35-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150918 22:55:21< celtiminstrel> Seems like it might possibly still not quite work for the AI... not sure though.
20150918 22:55:48< celtiminstrel> First time, it didn't take advantage of backstab. Second time, it did. (Second unit already in place.)
20150918 22:58:39-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150918 22:59:02< celtiminstrel> My alternate single-macro leadership implementation doesn't work though.
20150918 23:16:10-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20150918 23:18:52-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150918 23:31:29-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20150918 23:56:26-!- Jozrael [~Jozrael@rrcs-72-43-14-98.nys.biz.rr.com] has quit [Read error: Connection reset by peer]
20150918 23:56:39< celtiminstrel> ...wait.
20150918 23:56:53< celtiminstrel> Does $this_unit even work in Standard Unit Filters?
20150918 23:57:11-!- Jozrael [~Jozrael@72.43.14.98] has joined #wesnoth-dev
--- Log closed Sat Sep 19 00:00:43 2015