--- Log opened Sun Sep 20 00:00:28 2015 --- Day changed Sun Sep 20 2015 20150920 00:00:28< celticminstrel> There were two other main choices: 1) Make break and continue unable to break out of a message/object subscope. 2) Modify the C++ WML tag registration API so that WML tags can return a value. 20150920 00:00:39< celticminstrel> Might've been other choices too. 20150920 00:01:30< shadowm> 1 wouldn't have been such a great loss either. 20150920 00:09:12< celticminstrel> I suppose, but I think it makes more sense if they do work. 20150920 00:15:36-!- travis-ci [~travis-ci@ec2-54-163-116-246.compute-1.amazonaws.com] has joined #wesnoth-dev 20150920 00:15:37< travis-ci> wesnoth/wesnoth#7421 (master - 9ea9c88 : Charles Dang): The build was broken. 20150920 00:15:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/81211434 20150920 00:15:37-!- travis-ci [~travis-ci@ec2-54-163-116-246.compute-1.amazonaws.com] has left #wesnoth-dev [] 20150920 00:20:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20150920 00:34:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20150920 00:36:00-!- Appleman1234 [~Appleman1@KD118156254118.au-net.ne.jp] has quit [Read error: Connection reset by peer] 20150920 00:37:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20150920 00:43:08-!- Appleman1234 [~Appleman1@KD118156254118.au-net.ne.jp] has joined #wesnoth-dev 20150920 00:47:13-!- [Relic] [~Relic]@2602:306:33a3:6d30:dc3b:1259:8783:ca89] has joined #wesnoth-dev 20150920 00:55:52-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection timed out] 20150920 00:57:49-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20150920 01:32:03-!- jinblack [~jinblack@128.111.48.6] has quit [Ping timeout: 244 seconds] 20150920 01:45:04-!- jinblack [~jinblack@128.111.48.6] has joined #wesnoth-dev 20150920 01:57:59-!- jinblack [~jinblack@128.111.48.6] has quit [Ping timeout: 256 seconds] 20150920 02:05:54-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20150920 02:11:10-!- jinblack [~jinblack@jinblack.it] has joined #wesnoth-dev 20150920 02:31:30-!- Kazmor [5e104c68@gateway/web/freenode/ip.94.16.76.104] has joined #wesnoth-dev 20150920 02:45:26-!- Kazmor [5e104c68@gateway/web/freenode/ip.94.16.76.104] has quit [Quit: Page closed] 20150920 02:53:35-!- louis94 [~~louis94@109.129.229.117] has quit [Quit: Konversation terminated!] 20150920 02:54:29< celticminstrel> Does this sound too confusing? "Within [filter_adjacent], the special variable $other_unit refers to the filtered unit from the enclosing filter, while $this_unit refers (as with all StandardUnitFilters) to the unit being filtered on." 20150920 02:55:52-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20150920 03:07:59-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 265 seconds] 20150920 03:08:04< celticminstrel> Anyone? 20150920 03:08:21-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20150920 03:08:28-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit] 20150920 03:10:43< elias> sounds pretty clear to me, but I'm not someone who would write any WML 20150920 03:11:12< celticminstrel> Okay, I guess I'll go with that, at least for now. 20150920 03:11:33-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20150920 03:12:04-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 246 seconds] 20150920 03:17:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20150920 03:27:13-!- kahootiebird [~kahootbir@c-50-147-13-77.hsd1.tn.comcast.net] has quit [Quit: Leaving] 20150920 03:43:13< celticminstrel> Well, updated AbilitiesWML with [filter_adjacent] and $other_unit. Hope it's not too confusing. 20150920 03:50:23-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20150920 04:19:38-!- irker392 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20150920 04:30:17-!- jinblack [~jinblack@jinblack.it] has quit [Ping timeout: 240 seconds] 20150920 04:47:24-!- jinblack [~jinblack@169-231-96-46.wireless.ucsb.edu] has joined #wesnoth-dev 20150920 05:06:49-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has joined #wesnoth-dev 20150920 05:13:31-!- jinblack [~jinblack@169-231-96-46.wireless.ucsb.edu] has quit [Ping timeout: 246 seconds] 20150920 05:15:36< celticminstrel> Well, I can't see anything more to add to PR493. 20150920 05:15:48< celticminstrel> ...oh right. Changelog. 20150920 05:27:08-!- jinblack [~jinblack@128.111.48.6] has joined #wesnoth-dev 20150920 05:32:06-!- shadowm_desktop is now known as shadowm_tty 20150920 05:44:50-!- shikadibot is now known as shikadib1t 20150920 05:44:53-!- shikadib1t is now known as shikadibot_ 20150920 05:44:56-!- shikadibot_ is now known as shikadibot__ 20150920 05:45:08-!- shikadibot__ is now known as shikadibot___ 20150920 05:45:13-!- shikadibot___ is now known as shikadibot 20150920 05:46:13-!- You're now known as lobby_ 20150920 05:46:16-!- You're now known as lobby 20150920 05:48:18-!- oldlaptop [~quassel@50.36.238.180] has quit [Ping timeout: 240 seconds] 20150920 05:51:40-!- shadowm_tty [ignacio@wesnoth/developer/shadowm] has quit [] 20150920 05:52:35-!- shadowm_tty [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20150920 05:54:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20150920 06:06:18-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has quit [Ping timeout: 240 seconds] 20150920 06:10:52-!- shadowm_tty [ignacio@wesnoth/developer/shadowm] has quit [Quit: rebooting] 20150920 06:11:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20150920 06:12:14-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20150920 06:17:13-!- Kwandulin [~Miranda@p5B0087F6.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150920 06:22:31-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Read error: Connection reset by peer] 20150920 06:23:31-!- jinblack [~jinblack@128.111.48.6] has quit [Ping timeout: 252 seconds] 20150920 06:24:37-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev 20150920 06:26:15-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20150920 06:31:41< Aginor> shadowm: step 1: take copy of screen contents. 2: draw something in the space that was copied. 3: overwrite the drawed space with the copy to restore the original 20150920 06:31:59< Aginor> unless of course things were invalidated 20150920 06:32:42< Aginor> this is, in my experience, a slightly unusual way of doing things 20150920 06:33:06< celticminstrel> Unusual, sure, but why would it cause alpha blending problems? 20150920 06:33:31< Aginor> and I'm not sure that's how we'd like to do things in a hardware accelerated environement where we actually work with textures 20150920 06:33:58< celticminstrel> Well, yeah, in a hardware accelerate environment you'd probably just redraw the whole thing. 20150920 06:34:13< celticminstrel> +d 20150920 06:34:15< celticminstrel> I think. 20150920 06:34:45< celticminstrel> ...hmm. I wonder if I should use get_variable_proxy_array instead of get_variable_array for the foreach loop. 20150920 06:34:57< Aginor> celticminstrel: I still don't know that. The better question is: why does it blend in black on some channel on only nvidia hardware, not on intel or amd/ati 20150920 06:35:47< Aginor> celticminstrel: I want to move it towards the hardware accelerated way of doing things, simply invalidate the part of the screen to cause a redraw after deleting the component 20150920 06:36:49< Aginor> there will be a few more blits, but it'll decrease the effort needed to moving to a hardware accelerated environemtn 20150920 06:37:25-!- jinblack [~jinblack@jinblack.it] has joined #wesnoth-dev 20150920 06:38:38-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Read error: Connection reset by peer] 20150920 06:38:50< Aginor> it basically comes down to: is it worth me spending heaps of effort into fixing something that needs to be changed anyway? 20150920 06:39:16< celticminstrel> Does it make the game unplayable, or is it just a little glitchy? 20150920 06:39:23-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20150920 06:40:29< Aginor> celticminstrel: it makes it _very_ ugly on nvidia hardware 20150920 06:40:40< Aginor> sufficiently bad to be a complete blocker 20150920 06:41:09< celticminstrel> I actually have nvidia hardware. 20150920 06:41:19< celticminstrel> On both computers, even. 20150920 06:41:25< celticminstrel> So maybe it'd affect me too. 20150920 06:41:37< Aginor> most likely it would 20150920 06:42:00< Aginor> I can only see it on my old macbook 20150920 06:42:12< Aginor> doesn't show up on the gruntier desktop 20150920 06:43:48< Aginor> if you want to try, run the game with SDL2 and look at the test scenario 20150920 06:44:09< Aginor> scroll down a bit to see the ring of units and the fireplace to the left of the ring 20150920 06:44:40< celticminstrel> I'm a bit reluctant to switch to the SDL2 branch since it means recompiling almost everything, which takes forever. 20150920 06:44:58< celticminstrel> But I'll keep that in mind, maybe I'll try it at some point. 20150920 06:45:18< Aginor> celticminstrel: you can do it on mainline too, the bug is there as well :) 20150920 06:45:27< Aginor> but you'll still need to recompile 20150920 06:46:43< Aginor> celticminstrel: you may also want to investigate getting ccache to play with macports if you do a lot of full rebuilds 20150920 06:46:52< Aginor> s/macports/xcode/ 20150920 06:46:53< celticminstrel> Huh? 20150920 06:47:02-!- mjs-de [~mjs-de@x4db6b9b0.dyn.telefonica.de] has joined #wesnoth-dev 20150920 06:47:13< Aginor> sorry, I'm tired, it's been a full on day with a lot of activity 20150920 06:47:21< celticminstrel> What's ccache? 20150920 06:47:37< Aginor> https://en.wikipedia.org/wiki/Ccache 20150920 06:47:55< shadowm> Aginor: I'm not entirely sure why step 3 would cause problems? It *is* a copy, isn't it? 20150920 06:48:23< shadowm> Or is it a *reference*? 20150920 06:48:24< celticminstrel> How is that different from normal compiler behaviour? 20150920 06:48:44< Aginor> shadowm: it's a copy onto a newly allocated surface that the screen has been blitted onto 20150920 06:48:50< shadowm> The reason I'm asking is that surface foo; /* ... */ surface bar = foo; is not a copy, it's a reference. 20150920 06:49:13< Aginor> shadowm: I still don't understand why it's happening, it shouldn't be. 20150920 06:49:31< Aginor> although there could be something going on in the draw/undraw cycle I've missed 20150920 06:49:45< shadowm> Blitting an actual pixel-by-pixel copy can't possibly cause problems unless there's something about the respective pixel formats being incompatible or something. 20150920 06:49:53< Aginor> shadowm: create_surface_from(blah) 20150920 06:50:22< Aginor> sdl_blit(screen, rect, blah_surf, outrect) 20150920 06:50:52< Aginor> shadowm: there's a lot of funky things going on in blitting when you have alpha channels 20150920 06:51:09< Aginor> I've tried to play around with those too and it's not going much better 20150920 06:51:16< shadowm> I just did a big upgrade and my desktop environment is kind of unusable, so I can't comfortably look at create_surface_from()'s implementation atm. 20150920 06:52:16< Aginor> surface s = SDL_CreateRGBSurface(SDL_SWSURFACE, width, height, surf->format->BitsPerPixel, surf->format->Rmask, surf->format->Gmask, surf->format->Bmask, surf->format->Amask); 20150920 06:52:27< ancestral> celticminstrel: ccache, with regards to homebrew? 20150920 06:52:32< Aginor> relevant function: create_compatible_surface() 20150920 06:52:47< shadowm> ancestral, why is your message text black? :p 20150920 06:52:47< celticminstrel> ancestral: ? 20150920 06:52:55< shadowm> I can barely see it. 20150920 06:53:19< ancestral> Good question 20150920 06:53:27< Aginor> still black :) 20150920 06:54:44< ancestral> How about now? 20150920 06:54:50< shadowm> Still black. 20150920 06:55:14-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Remote host closed the connection] 20150920 06:55:41-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev 20150920 06:55:54< ancestral> I relaunched, any better? 20150920 06:55:59< shadowm> Yes. 20150920 06:56:48< ancestral> celticminstrel: ccache is 20150920 06:57:25< ancestral> It allows for building with files previously download Ed the last time you ran a set of commands 20150920 06:58:18< ancestral> So you can rebuild packages without having to redownload the entire source 20150920 06:58:20< Aginor> ancestral, celticminstrel: it can also be used overall, outside macports 20150920 06:58:39-!- celticminstrel is now known as celmin|sleep 20150920 06:58:41< ancestral> and Homebrew 20150920 06:58:48< Aginor> it caches the comp[ilation result of files, if your file is unchanged from last compile it'll use the cached balue 20150920 06:59:12< celmin|sleep> Thinking of adding a bunch of methods to the Lua proxy unit type. 20150920 07:00:01< celmin|sleep> Anyway, XCode already recompiles files only if they or a header they included has changed. 20150920 07:00:11< celmin|sleep> The latter is really the problem. 20150920 07:00:42< celmin|sleep> Change one header, and twenty files suddenly need to be recompiled. Or, maybe it'll be a hundred files. If it's config.hpp, it might even be every file. 20150920 07:02:13-!- [Relic] [~Relic]@2602:306:33a3:6d30:dc3b:1259:8783:ca89] has quit [Quit: I press the magic X and all the weirdos go away!] 20150920 07:03:21< celmin|sleep> helper.modify_unit seems far less powerful than [modify_unit]. 20150920 07:04:14-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20150920 07:06:08-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Quit: Smell ya later] 20150920 07:29:50-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Read error: Connection reset by peer] 20150920 07:32:20-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20150920 07:40:31-!- jinblack [~jinblack@jinblack.it] has quit [Ping timeout: 246 seconds] 20150920 07:44:38-!- Shackra_ [~Jorge@186.177.2.148] has quit [Read error: Connection reset by peer] 20150920 07:53:44< Aginor> celmin|sleep: yes, ccache can cache both old header version and new header version... 20150920 07:56:21< Aginor> shadowm: so do you have any thoughts on my ideas for dealing with the alpha blending issue (by removing the symptom) 20150920 07:57:17< shadowm> It's an area I've never really understood, unfortunately. 20150920 07:57:36-!- jinblack [~jinblack@128.111.48.6] has joined #wesnoth-dev 20150920 07:57:52< Aginor> fair enough 20150920 07:58:21< Aginor> my view is that it's work that will need to be done anyway to be able to do proper hardware acceleration 20150920 07:58:45< Aginor> although I guess it's possible to try to preserve the current way of doing things but it'd be hard 20150920 07:59:31< shadowm> What would the proper way be again? 20150920 08:00:03< Aginor> invalidate that portion of the screen and have the draw cycle redraw what shuold go on it 20150920 08:00:39< shadowm> Isn't that what we do anyway? I thought the problem was that the blit source was a copy of the screen framebuffer. 20150920 08:00:44< Aginor> that way the responsiblity of the drawing is moved into the redraw cycle and you don't have components/widgets/things trying to undraw themself 20150920 08:01:19< Aginor> shadowm: there's no invalidation happening, they simply try to undraw themselves every time, then draw themselves again 20150920 08:01:41< Aginor> undraw is the operation I described above 20150920 08:01:58< shadowm> Doesn't 'invalidation' just entail notifying SDL that the given rectangle needs to be updated on the screen? 20150920 08:02:10< Aginor> I mean invalidate in the game engine 20150920 08:02:28< Aginor> telling it that these hexes/buttons/whatever need to be redrawn 20150920 08:03:06< Aginor> so it then can go and re-blit things onto the screen 20150920 08:07:09-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev 20150920 08:07:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20150920 08:08:46-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has joined #wesnoth-dev 20150920 08:09:59< zookeeper> celmin|sleep, yes it's sufficiently clear that way IMO. all that's missing, i think, is a mention in http://wiki.wesnoth.org/SyntaxWML#Automatically_Stored_Variables 20150920 08:22:41< Aginor> wedge009: great news! 20150920 08:22:56< wedge009> Aginor: Yep, I can test your change when your ready. 20150920 08:23:46< Aginor> wedge009: it will probably be a few more days 20150920 08:23:48-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20150920 08:23:54< wedge009> That's fine. 20150920 08:24:02< Aginor> if you look in the scrollback you can see what I'm pondering doing 20150920 08:26:15< wedge009> celmin|sleep: Thanks for taking the time to review everything in detail. I agree some changes are questionable - the more I got into the review, the more aggressive I was about some things. (There were more I have preferred to do, but I tried to keep it to only changes that I was sure would be a problem otherwise.) 20150920 08:26:36-!- shadowm_desktop2 [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20150920 08:26:39< wedge009> Aginor: Maybe later. Unfortunately I don't have much time right now. 20150920 08:27:11-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 264 seconds] 20150920 08:28:34< Aginor> fair enough 20150920 08:29:18< wedge009> celmin|sleep: I do question 'unguessable', as it's derived from colloquial styling predominant in American English, though now that I think about it more, it's probably acceptable. In the context of narration, though, I baulk at its presence and I'm glad vultraz seems to agree that 'unknown' - in this case at least - sets a better tone. 20150920 08:30:59< wedge009> celmin|sleep: Regarding compound words, some of the probably are becoming increasingly accepted - again, due to the predominance and influence of American English. But as vultraz pointed out, this was for the en_GB version of the manual, which may well be auto-generated anyway, but I'm not sure. 20150920 08:33:56< wedge009> celmin|sleep: As for dexterous vs dextrous - that one got me as well, but my spell-checker was marking dextrous as incorrect, so I thought this was a case of British vs American. After having a further look Internet consensus seems to be that both forms are acceptable, though I do see Oxford and Merriam-Webster listing dextrous as the alternative and dexterous as the primary. 20150920 08:35:41< wedge009> celmin|sleep: Regardless, the forms were inconsistently used in the language files and since taking over the British English localisation, I've used dexterous (following from my predecessors) in all places where dextrous is used. (So no, dexterous is not a mis-spelling.) 20150920 08:36:07< wedge009> celmin|sleep: I'll answer your GitHub comments later. Thanks again for your efforts. 20150920 08:36:12-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev 20150920 08:37:46< Elvish_Hunter> Hi all 20150920 08:39:20-!- irker809 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20150920 08:39:20< irker809> wesnoth: Elvish_Hunter wesnoth:master e39f6376c8ad / data/tools/wmllint-1.4: wmllint-1.4: use string formatting or interpolation instead of concatenation http://git.io/vnng8 20150920 08:42:32< Elvish_Hunter> OK, now I just need to finish moving the main tools to Python3, then I'll start working on trackplacer 20150920 08:44:15< Elvish_Hunter> celmin|sleep: I found a bug in [object]. At line 22, there's "contxt.x" instead of "context.x" 20150920 08:52:43-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: No route to host] 20150920 08:52:48-!- rayblade53 [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20150920 08:53:06-!- rayblade53 is now known as vultraz 20150920 09:00:10< wedge009> celmin|sleep: That reminds me. There's a bug (I think) in lua_gui2.cpp, line 280. It should be && instead of and. 20150920 09:01:26< Elvish_Hunter> AFAIK, C++ supports and, or and not as aliases for &&, || and ! 20150920 09:01:45< wedge009> Huh. Well, VC obviously doesn't, hence it broke. ): 20150920 09:02:41< shadowm> It does if you include a header file whose name I forgot, but there really is no reason to use and/or/not instead of &&/||/! in this project. 20150920 09:03:44< wedge009> Can we stick to && for compatibility's sake then, please? Otherwise, whether changing the and or adding the header file I'll have to make a local modification. 20150920 09:04:31< shadowm> Yes, that's what I just said. 20150920 09:06:03< shadowm> , btw. 20150920 09:09:29< Elvish_Hunter> However, according to http://www.cplusplus.com/reference/ciso646/, these keywords are directly supported in C++, and including the header is needed only in C programs 20150920 09:10:32< shadowm> Yes but you know Microsoft is weird. 20150920 09:11:05< Elvish_Hunter> Heh, that's true :P 20150920 09:11:57< Aginor> when was it introduced? It could be hat they haven't had time to get on the program yet 20150920 09:12:33< shadowm> In C++98. 20150920 09:12:53< irker809> wesnoth: Ignacio R. Morelle wesnoth:master 48def4ff0a8b / src/scripting/lua_gui2.cpp: Replace alphanumeric and operator spelling http://git.io/vnnrC 20150920 09:13:10< shadowm> wedge009: ^ 20150920 09:13:24< Aginor> the should be on the program then :) 20150920 09:13:37< shadowm> Generally from what I gather Microsoft isn't too keen on implementing superfluous fluff like that. 20150920 09:13:56< shadowm> That's also why they pushed back some C++11 features in favor of C++14 support IIRC. 20150920 09:14:02< wedge009> Thanks, and I was just trying to find out about it as well. Looks like MSVC just doesn't want to comply. Wouldn't be the first time. 20150920 09:14:30< wedge009> Although, honestly, I've never used and/or/not keywords in C++ before. o.o 20150920 09:14:47< shadowm> OTOH it's well-known that their notion of essential stuff isn't well-aligned with everyone else's (C99 for example was still largely unsupported a few years ago). 20150920 09:14:59< shadowm> (And C11 was already published.) 20150920 09:32:27< wedge009> Aginor: I don't know much about graphics processing, but moving towards what's suitable for hardware acceleration seems sensible to me. I was going to ask if we knew why the blending issues only occur on NV hardware (so far as we know) and not other instances, but turns out you already said we don't know. 20150920 09:33:05< wedge009> Also a particular subset of NV hardware, too. 20150920 09:34:46< wedge009> Testing on Windows, I was using GCN and Kelper GPUs, neither had the issue. Testing on Linux I was using TeraScale and Fermi GPUs. So I don't know if it's particular to Linux vs Windows or AMD vs NV. 20150920 09:35:45< wedge009> Darn it, now I'm curious. Think I'll roll back to nouveau just to see if the blending issues are specific to Fermi and older GPUs or maybe it's Linux driver-specific. 20150920 09:38:31-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has quit [Ping timeout: 265 seconds] 20150920 09:47:13< Aginor> wedge009: that could end poorly for you :) 20150920 09:47:58< wedge009> Why poorly? 20150920 09:48:12< Aginor> it's always a hassle mucking about with the graphics drivers 20150920 09:48:24< Aginor> I don't know how many times I've killed my X config 20150920 09:48:34< Aginor> s/config// 20150920 09:48:36< Aginor> when poking drivers 20150920 09:48:45< wedge009> I know, but I've had enough practice recently getting the machine set-up to use nvidia. 20150920 09:49:03< Aginor> fair enough 20150920 09:49:05< wedge009> In this case I'll just uninstall the nvidia drivers and X reverts to nouveau just fine. 20150920 09:49:18< Aginor> excellent 20150920 09:49:27< Aginor> I just poked the code a bit more 20150920 09:49:31< wedge009> I just hope I'll still have OpenCL when I put nvidia back! XD 20150920 09:49:53< Aginor> sdl/util.cpp:blit_surface needs to be disappeared too 20150920 09:50:15< Aginor> wedge009: I'll cross my fingers for yuo 20150920 09:50:53< Aginor> it's a partial software re-implementation of some of the blitting functions, but it won't work in an accelerated context since we won't use surfaces 20150920 09:51:24< wedge009> Not sure if it's related but sdl_blit() in sdl/utils.cpp causes epic crashes in at least two situations I've found. 20150920 09:51:37< shadowm> Hope nouveau doesn't brick your GPU. :p 20150920 09:51:53< wedge009> nouveau is the default driver. o.O 20150920 09:51:58< shadowm> (Not that I've ever heard of such a thing happening. radeon, however...) 20150920 09:52:02< wedge009> For NV GPUs. 20150920 09:52:26< wedge009> Haven't had problems with radeon either. o.o Only proprietary drivers give me grief in Linux. Maybe I'm just lucky? 20150920 09:52:43< wedge009> Or unlucky, depending on your point of view. 20150920 09:53:22< shadowm> The only thing from nouveau I miss, personally, is KMS consoles. 20150920 09:53:56-!- Octalot [~noct@91.141.2.58.wireless.dyn.drei.com] has joined #wesnoth-dev 20150920 09:54:00< shadowm> "Miss" -- not counting my rescue system I've only used it for about 30 minutes. 20150920 09:54:03< Aginor> wedge009: I'm curious about that, those epic crashes will be happening in SDL 20150920 09:57:15< Aginor> wedge009: and the most likely cause of that happening would be wesnoth passing some dodgy surfaces 20150920 09:59:40< wedge009> Aginor: I haven't reported it formally just yet, but the two I found were resizing windows (arbitrary mouse-dragging on the window frame, not via preferences) and trying to join a multi-player game while using the experimental lobby (and possibly the default one as well). 20150920 10:00:00< Aginor> ah 20150920 10:00:11< Aginor> right, I do really need to test some multiplayer games 20150920 10:00:29< wedge009> The window resizing should be easier to reproduce. ;) 20150920 10:01:31-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has left #wesnoth-dev ["Ciao!"] 20150920 10:05:31< Aginor> it should 20150920 10:05:53< Aginor> by the way, I approve of your Brittish English campaign :) 20150920 10:06:26 * Aginor is on the dexterous side 20150920 10:10:05< wedge009> High five! (: 20150920 10:15:02-!- shadowm_desktop2 [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 246 seconds] 20150920 10:19:00-!- jinblack [~jinblack@128.111.48.6] has quit [Remote host closed the connection] 20150920 10:31:44-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has joined #wesnoth-dev 20150920 10:43:36-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has quit [Ping timeout: 255 seconds] 20150920 10:46:41-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 256 seconds] 20150920 10:49:20 * Aginor also approves of go to mode 20150920 10:49:52-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev 20150920 11:05:08-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!] 20150920 11:19:23< wedge009> celmin|sleep, Aginor: Made PR #495 to account for celtic's comments/suggestions/objections. I've also answered celtic's remarks in http://git.io/vnZvG 20150920 11:25:24-!- louis94 [~~louis94@109.129.229.117] has joined #wesnoth-dev 20150920 11:43:33< wedge009> Well, that was interesting! 20150920 11:44:09< wedge009> Aginor, shadowm: nouveau does not exhibit the blending issue. So it does appear to be specific to the Linux nvidia driver. 20150920 11:48:19-!- subliun [~quassel@unaffiliated/subliun] has quit [Ping timeout: 246 seconds] 20150920 11:49:30-!- subliun [~quassel@unaffiliated/subliun] has joined #wesnoth-dev 20150920 11:51:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20150920 11:56:57-!- louis94 [~~louis94@109.129.229.117] has quit [Ping timeout: 255 seconds] 20150920 11:57:37-!- Kwandulin [~Miranda@p5B0087F6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20150920 11:59:39-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has quit [Ping timeout: 255 seconds] 20150920 12:11:20-!- Turuk [~Turuk@cpe-174-97-3-219.cinci.res.rr.com] has joined #wesnoth-dev 20150920 12:11:39-!- Turuk [~Turuk@cpe-174-97-3-219.cinci.res.rr.com] has quit [Changing host] 20150920 12:11:39-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has joined #wesnoth-dev 20150920 12:15:34-!- oldlaptop [~quassel@50.36.238.180] has joined #wesnoth-dev 20150920 12:30:05-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host] 20150920 12:30:05-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20150920 12:52:36< vultraz> celmin|sleep: fixed the typo EH pointed out but irker isn't reporting 20150920 13:04:08-!- Kwandulin [~Miranda@p5B0087F6.dip0.t-ipconnect.de] has joined #wesnoth-dev 20150920 13:07:05-!- Turuk [~Turuk@wesnoth/forum-moderator/turuk] has quit [Ping timeout: 240 seconds] 20150920 13:08:14< vultraz> wedge009: left a comment on 495 20150920 13:15:18< wedge009> vultraz, celmin|sleep: That's a good point, I forgot who the speaker was for that one. celtic, with that in mind, what do you think? A regal tone should be formal in nature. 20150920 13:18:14< wedge009> Although the sentence itself is a bit of a laugh because he's momentarily forgotten than he's dead. 20150920 13:18:23< wedge009> that* 20150920 13:26:22< irker809> wesnoth: Charles Dang wesnoth:master 00d96b3016c1 / data/lua/wml/object.lua: Fixed a variable typo pointed out by Elvish_Hunter http://git.io/vnc8b 20150920 13:38:34-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20150920 13:46:15< elias> hm, should I run wesnoth_addon_manager through 2to3? 20150920 14:49:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20150920 14:53:30< vultraz> elias: I think elvish hunter will probably get to that 20150920 14:55:35-!- Octalot [~noct@91.141.2.58.wireless.dyn.drei.com] has quit [Ping timeout: 265 seconds] 20150920 15:02:54< elias> seen evlish hunter 20150920 15:03:07< elias> !seen elvish hunter 20150920 15:03:10< elias> hm 20150920 15:03:16< elias> i forgot how that works :P 20150920 15:04:30< vultraz> I thinkhe reads logs 20150920 15:04:45< vultraz> He just left a few hours ago 20150920 15:05:20< elias> ah, yes, and talking about Python3 20150920 15:05:53< elias> wonder which timezone he's in 20150920 15:08:46-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20150920 15:13:00-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds] 20150920 15:13:01-!- wedge010 is now known as wedge009 20150920 15:24:13< celmin|sleep> Whoops, that "and" instead of && was probably a result of getting C++ and Lua confused. >_> 20150920 15:24:44< celmin|sleep> wedge009: I actually have no idea who the speakers are, so if Vultraz says one of them should be more formal, he's probably right. 20150920 15:28:51-!- [Relic] [~Relic]@2602:306:33a3:6d30:503c:f9cd:5866:c2a4] has joined #wesnoth-dev 20150920 15:32:34-!- celmin|sleep is now known as celticminstrel 20150920 15:33:53-!- louis94 [~~louis94@109.129.229.117] has joined #wesnoth-dev 20150920 15:39:39-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev 20150920 15:59:00< vultraz> I only know who Abhai is 20150920 15:59:07< vultraz> I can check the others 20150920 16:18:33-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20150920 16:27:02-!- irker809 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20150920 16:29:49-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20150920 16:42:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20150920 16:59:47-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev 20150920 17:06:00< vultraz> celticminstrel: yeah the other two can be informal 20150920 17:06:05< vultraz> but Abhai's should be formal 20150920 17:10:01< celticminstrel> My clang version doesn't understand -Wno-unused-local-typedefs :/ 20150920 17:10:13< celticminstrel> I guess it's bearable though, the left sidebar only shows it once. 20150920 17:44:12-!- BeoXTC_ [3eb2b12a@gateway/web/cgi-irc/kiwiirc.com/ip.62.178.177.42] has joined #wesnoth-dev 20150920 17:54:46-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20150920 18:09:57-!- [Relic] [~Relic]@2602:306:33a3:6d30:503c:f9cd:5866:c2a4] has quit [Quit: I press the magic X and all the weirdos go away!] 20150920 18:35:04-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20150920 18:38:46< wedge009> vultraz, celticminstrel: Dropped reversion on Abhai , left the others as per celtic's recommendations. 20150920 18:39:06< celticminstrel> Saw that. 20150920 18:41:08-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20150920 18:53:18-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev 20150920 18:53:26-!- Kwandulin [~Miranda@p5B0087F6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20150920 18:54:13-!- irker264 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20150920 18:54:13< irker264> wesnoth: Elias Pschernig wesnoth:master 4c034d770576 / data/tools/ (unit_tree/helpers.py wesnoth/wmlparser3.py wmlunits): Clean up wmlparser3.py a bit, fix json and xml output. http://git.io/vnC6Z 20150920 18:56:43-!- louis94 [~~louis94@109.129.229.117] has quit [Ping timeout: 246 seconds] 20150920 19:03:07-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev 20150920 19:11:38-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20150920 19:13:08-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [] 20150920 19:14:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20150920 19:21:41-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20150920 19:30:51-!- Shackra [~Jorge@186.177.2.148] has quit [Read error: Connection reset by peer] 20150920 19:31:57-!- louis94 [~~louis94@109.129.229.117] has joined #wesnoth-dev 20150920 19:34:46-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20150920 19:37:05-!- Appleman1234 [~Appleman1@KD118156254118.au-net.ne.jp] has quit [Ping timeout: 240 seconds] 20150920 19:54:28-!- louis94 [~~louis94@109.129.229.117] has quit [Ping timeout: 246 seconds] 20150920 20:11:10-!- travis-ci [~travis-ci@ec2-54-197-91-171.compute-1.amazonaws.com] has joined #wesnoth-dev 20150920 20:11:11< travis-ci> gfgtdf/wesnoth-old#542 (sync_choice_split - 6148c73 : gfgtdf): The build has errored. 20150920 20:11:11< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/81284630 20150920 20:11:11-!- travis-ci [~travis-ci@ec2-54-197-91-171.compute-1.amazonaws.com] has left #wesnoth-dev [] 20150920 20:30:54-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20150920 20:33:32< irker264> wesnoth: gfgtdf wesnoth:master 9c9f8f5a6e12 / src/scripting/ (game_lua_kernel.cpp game_lua_kernel.hpp push_check.hpp): split wesnoth.synchronize_choice function http://git.io/vnCAI 20150920 20:33:34< irker264> wesnoth: gfgtdf wesnoth:master cce53d5aa990 / src/scripting/lua_gui2.cpp: fix a compiler warning http://git.io/vnCAL 20150920 20:33:36< irker264> wesnoth: gfgtdf wesnoth:master 663db4f70fb2 / src/ (actions/attack.cpp persist_var.cpp replay.cpp replay.hpp): show notification when waiting for remote choices. http://git.io/vnCAt 20150920 20:33:38< irker264> wesnoth: gfgtdf wesnoth:master 3c11aa63f89c / src/ (13 files in 4 dirs): move get_user_choice function to a new file http://git.io/vnCAq 20150920 20:33:40< irker264> wesnoth: gfgtdf wesnoth:master de3db534477c / src/ (synced_context.cpp synced_user_choice.cpp synced_user_choice.hpp): refactor get_user_choice http://git.io/vnCAm 20150920 20:33:42< irker264> wesnoth: gfgtdf wesnoth:master 3ed4eed9fcf4 / / (7 files in 4 dirs): wait dialog for user choices during prestart events http://git.io/vnCAY 20150920 20:33:42-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 260 seconds] 20150920 20:33:44< irker264> wesnoth: gfgtdf wesnoth:master 61fabacd36a4 / src/scripting/game_lua_kernel.cpp: fix compiler warnings. http://git.io/vnCAO 20150920 20:33:46< irker264> wesnoth: gfgtdf wesnoth:master c7c1b750fc38 / src/synced_user_choice.cpp: fix compiler wanring. http://git.io/vnCA3 20150920 20:33:48< irker264> wesnoth: gfgtdf wesnoth:master fd2e513dc99b / src/synced_user_choice.cpp: simplify user_choice_notifer_ingame http://git.io/vnCAs 20150920 20:34:00< celticminstrel> Ah, that has been merged, huh? 20150920 20:34:34-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20150920 20:34:36-!- travis-ci [~travis-ci@ec2-54-197-91-171.compute-1.amazonaws.com] has joined #wesnoth-dev 20150920 20:34:37< travis-ci> gfgtdf/wesnoth-old#543 (sync_choice_split - 0bd4ef7 : gfgtdf): The build was broken. 20150920 20:34:37< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/81285915 20150920 20:34:37-!- travis-ci [~travis-ci@ec2-54-197-91-171.compute-1.amazonaws.com] has left #wesnoth-dev [] 20150920 20:34:54-!- gfgtdf [~chatzilla@f054152196.adsl.alicedsl.de] has joined #wesnoth-dev 20150920 20:35:11< gfgtdf> celticminstrel: y im still not 100% happy with that lua interface, might change it again 20150920 20:35:40< gfgtdf> celticminstrel: specially i want a 'desription' parameter for the lua interface 20150920 20:35:55< celticminstrel> Description? 20150920 20:36:04< celticminstrel> What was the interface again? 20150920 20:36:20< gfgtdf> celticminstrel: by the interface i meant the lua api 20150920 20:36:26< celticminstrel> wesnoth.synchronize_choice[s]([string], function, [sides])? 20150920 20:37:05< gfgtdf> celticminstrel: yes but it's currently 2 function, one nesesary and one optional, 20150920 20:37:14< irker264> wesnoth: Wedge009 wesnoth:master 040351949108 / data/campaigns/ (2 files in 2 dirs): Reverting 'x and I' to 'me and x' http://git.io/vnCAX 20150920 20:37:16< irker264> wesnoth: Wedge009 wesnoth:master eb05d043e037 / doc/manual/manual.en_GB.html: Reverting some hyphenation. http://git.io/vnCA1 20150920 20:37:18< irker264> wesnoth: Charles Dang wesnoth:master e3c47bf4821f / / (3 files in 3 dirs): Merge pull request #495 from Wedge009/Spelling_Corrections http://git.io/vnCAM 20150920 20:37:47< gfgtdf> celticminstrel: the desription is for teh playewrs that wait while that side executed that local choice 20150920 20:38:33< gfgtdf> celticminstrel: i made it so that they get a message "Waiting for from side " if they wait longer than 2 seconds for a remote user choice (liek an advamcenent choice) 20150920 20:39:14< gfgtdf> celticminstrel: currently for luas snyc_choice it always shows as "input" 20150920 20:39:32< gfgtdf> celticminstrel: i think it woudl be nice if that was a little more concrete 20150920 20:39:41-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev 20150920 20:39:41-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host] 20150920 20:39:41-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20150920 20:40:03< gfgtdf> celticminstrel: maybe we coudl even let the user of [message] specyfy that description 20150920 20:42:03< celticminstrel> gfgtdf: Yes, two functions, hence "synchronize_choice[s]". 20150920 20:42:03-!- Appleman1234 [~Appleman1@KD118156245026.au-net.ne.jp] has joined #wesnoth-dev 20150920 20:42:17< gfgtdf> celticminstrel: no thats not what i meant 20150920 20:42:22< celticminstrel> That initial string, what's it for? 20150920 20:42:44< gfgtdf> celticminstrel: tha interface is currently wesnoth.synchronize_choice[s]([string], function, [function], [sides])? 20150920 20:42:46< celticminstrel> Is it different from the description? 20150920 20:42:55< celticminstrel> Ah right, two functions. 20150920 20:43:05< celticminstrel> Forgot about that, though I thought I was missing an argument. 20150920 20:43:29< celticminstrel> So is the initial string the same as the description? 20150920 20:44:09< gfgtdf> celticminstrel: hmm no the initial string is used internally for mpsync it shoudl also be desriptive, but it shodul for example not be translated 20150920 20:44:41< celticminstrel> If it's only used internally, why does the user need to be able to specify it? 20150920 20:45:58< gfgtdf> celticminstrel: mainly for its descriptive value in replays, but you are right maybe there is no need to that when we also have desiption(whcih was added later) 20150920 20:46:40< celticminstrel> Yeah, I think I'd suggest using that string for description instead. 20150920 20:49:26< celticminstrel> Also, what about a userdata parameter? 20150920 20:49:35< celticminstrel> (Not in the Lua sense.) 20150920 20:50:52< celticminstrel> So... wesnoth.synchronize_choice[s]([description,] [userdata,] function, [ai_function,] [sides]) 20150920 20:51:29< gfgtdf> celticminstrel: what shodul teh userdata parameter do ? 20150920 20:51:33< celticminstrel> And it calls function(userdata) or ai_function(userdata) to get the result. 20150920 20:52:00< irker264> wesnoth: Charles Dang wesnoth:master a4fe9c0474a5 / projectfiles/CodeBlocks/wesnoth.cbp: Updated codeblocks projectfile http://git.io/vnCpQ 20150920 20:52:02-!- louis94 [~~louis94@109.129.229.117] has joined #wesnoth-dev 20150920 20:52:06< celticminstrel> Just a simpler way of passing in data. I realize a closure works, but it's added complexity. 20150920 20:54:09< gfgtdf> celticminstrel: i think cloasures are quite simple. and adding more optional parametersisnt really simply, for exameplif your usadata is a string the game engine cannot knwo if its meant as desiption or as userdata 20150920 20:54:56< gfgtdf> celticminstrel: i still winder whether i shodul put the description parameter to teh end or to teh beginning 20150920 20:55:04< celticminstrel> The userdata would be a table, unless there's also a description. 20150920 20:56:52< celticminstrel> So basically, it would go like this: If first parameter is string, it's description; if it's function, move on. Otherwise it's userdata. 20150920 20:59:16< celticminstrel> To be honest, I think a much better interface would be to take one argument which us a table holding all the other arguments. 20150920 20:59:21< celticminstrel> ^which is 20150920 21:00:33-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev 20150920 21:01:50-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 20150920 21:02:49-!- louis94 [~~louis94@109.129.229.117] has quit [Ping timeout: 244 seconds] 20150920 21:03:17< gfgtdf> celticminstrel: hmm i also had that idea, but the problem is that 1) it wouldn't be backwards compatible, 2) it's prone to user mistyping the parameternames. 20150920 21:03:53< celticminstrel> Backwards compatibility would be possible, though admittedly nontrivial. 20150920 21:24:53-!- louis94 [~~louis94@109.129.229.117] has joined #wesnoth-dev 20150920 21:33:43< gfgtdf> celticminstrel: i updated the wiki page 20150920 21:34:04< celticminstrel> Yay 20150920 21:36:19-!- sfan786 [~sfan786@c-98-239-230-28.hsd1.pa.comcast.net] has joined #wesnoth-dev 20150920 21:47:46-!- mattsc_ [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20150920 21:48:47-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 264 seconds] 20150920 21:48:47-!- mattsc_ is now known as mattsc 20150920 21:48:50-!- mjs-de [~mjs-de@x4db6b9b0.dyn.telefonica.de] has quit [Ping timeout: 260 seconds] 20150920 21:52:06< vultraz> Is there any reason we haven't merged $402? 20150920 21:52:08< vultraz> er 20150920 21:52:11< vultraz> #402 20150920 21:53:20< celticminstrel> No idea! 20150920 21:53:36< celticminstrel> Based on description alone, it looks good to me (don't have time to review it right now). 20150920 21:54:04-!- travis-ci [~travis-ci@ec2-54-80-42-162.compute-1.amazonaws.com] has joined #wesnoth-dev 20150920 21:54:05< travis-ci> wesnoth/wesnoth#7440 (master - e3c47bf : Charles Dang): The build was broken. 20150920 21:54:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/81291725 20150920 21:54:06-!- travis-ci [~travis-ci@ec2-54-80-42-162.compute-1.amazonaws.com] has left #wesnoth-dev [] 20150920 21:54:15< vultraz> I'm testing it to make sure 20150920 21:54:34< vultraz> Looks good 20150920 21:55:12< vultraz> I'm going to push the commits 20150920 21:59:52-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn] 20150920 22:00:51-!- sfan786 [~sfan786@c-98-239-230-28.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…] 20150920 22:14:37< irker264> wesnoth: gfgtdf wesnoth:master c20a807a87bf / src/synced_user_choice.cpp: fix assertion failure in wesnoth.synchronize_choice(s) http://git.io/vnWtp 20150920 22:14:39< irker264> wesnoth: gfgtdf wesnoth:master 2c245afdc2ab / src/scripting/game_lua_kernel.cpp: add description parameter to wesnoth.synchronize_choice(s) http://git.io/vnWth 20150920 22:21:58< irker264> wesnoth: Randypk wesnoth:master 5a584381f371 / data/themes/default.cfg: Bug Fix#23060: unit status tooltips do not show. http://git.io/vnWmJ 20150920 22:22:00< irker264> wesnoth: Randypk wesnoth:master 504cdb69d1cb / changelog: Updated changelog for bug 23060. http://git.io/vnWmU 20150920 22:22:14< vultraz> Ok, pushed 20150920 22:23:29< shadowm> vultraz: Yes, there is a reason. 20150920 22:23:43< shadowm> The reason I didn't merge it is that I couldn't reproduce the bug it purportedly fixes. 20150920 22:24:09< vultraz> Well, I just did so before I tested the fix 20150920 22:24:31< shadowm> In that case, isn't it a candidate for 1.12? 20150920 22:24:44< vultraz> I will check 20150920 22:25:04< shadowm> Although the bug report says the bug wasn't in 1.12.0. 20150920 22:25:50< shadowm> It seems really odd, I'm not really aware of any changes in that area since 1.12.x in master but I could've missed something. 20150920 22:26:38< vultraz> Does not affect 1.12 20150920 22:28:56-!- travis-ci [~travis-ci@ec2-54-167-228-112.compute-1.amazonaws.com] has joined #wesnoth-dev 20150920 22:28:57< travis-ci> wesnoth/wesnoth#7441 (master - a4fe9c0 : Charles Dang): The build was broken. 20150920 22:28:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/81293599 20150920 22:28:57-!- travis-ci [~travis-ci@ec2-54-167-228-112.compute-1.amazonaws.com] has left #wesnoth-dev [] 20150920 22:30:54< shadowm> gfgtdf: Looks like one of your commits broke one or more WML unit tests? 20150920 22:31:22< shadowm> This seems to be the first failed job: https://travis-ci.org/wesnoth/wesnoth/jobs/81291312 20150920 22:31:51< shadowm> https://travis-ci.org/wesnoth/wesnoth/jobs/81291312#L2621 20150920 22:32:17< shadowm> https://travis-ci.org/wesnoth/wesnoth/jobs/81291312#L2424 20150920 22:32:25< shadowm> Several others. 20150920 22:33:29< shadowm> Oh, I didn't see c20a807a87bf above, I guess that's supposed to fix it. 20150920 22:39:55-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 250 seconds] 20150920 22:41:51-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20150920 22:46:27< gfgtdf> shadowm: the travis buidl doesnt say what exactly went wrong so i dont know whether that fixes it 20150920 22:49:29< BeoXTC_> hi 20150920 22:49:58< BeoXTC_> how can I access wesnoth replays else except http? e.g.: http://replays.wesnoth.org/1.12 20150920 22:50:23< vultraz> welp...bg 20150920 22:50:25< vultraz> bug D: 20150920 22:50:38< gfgtdf> shadowm: hm ok i think i found ot what is wrong and its something different 20150920 22:51:09-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20150920 22:51:36< vultraz> celticminstrel: message [option] is broken 20150920 22:51:50< shadowm> gfgtdf: You *can* run the WML unit tests there, right? 20150920 22:52:51< gfgtdf> shadowm: yes, i just have to create a shortcut and add the -u thing. 20150920 22:52:57< vultraz> celticminstrel: http://pastebin.com/RG995fw9 20150920 22:53:12< shadowm> gfgtdf: Why not use the command prompt directly? :\ 20150920 22:53:19< vultraz> this might be related to gfgtdf's recent changes but I'm not sure 20150920 22:53:45< shadowm> If I had to create shortcuts every time I needed to run Wesnoth with a different command line I'd have ripped my hair and set my computer on fire ages ago. 20150920 22:53:46< Aginor> gfgtdf: do you have any opinions on how the rendering path is handled, and in which order things are done in? 20150920 22:54:04< gfgtdf> Aginor: no i dont really know anythign about that 20150920 22:54:15< Aginor> gfgtdf: ok, fair enough 20150920 22:54:31< Aginor> I'll just bumble along and do what I think is right then 20150920 22:54:39< shadowm> BeoXTC_: That is the only way to access public server replays (other than your client creating its own of course). 20150920 22:54:49< gfgtdf> shadowm: well i think case i already had ashortcut for that specific unit rtes so i just had to doubleclick on it 20150920 22:55:01< BeoXTC_> thx for the info 20150920 22:55:05< gfgtdf> s/i think/in this 20150920 22:56:04< gfgtdf> shadowm: also using teh other was i woudl need to open a console and navigate to the folder where wesnoth.exe is. 20150920 22:56:29< shadowm> On Windows 8 and later you can shift-right click the folder to see the Open command prompt here option. 20150920 22:56:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds] 20150920 22:56:45< shadowm> (There is a way to get that in Windows 7 too but I don't remember what it was.) 20150920 22:57:44< BeoXTC_> it's shift+right-click too 20150920 22:57:52< celticminstrel> vultraz: That error doesn't make sense to me - argument 1 is supposed to be userdata. 20150920 22:57:54< BeoXTC_> you have to choose "open command prompt" 20150920 22:58:18< celticminstrel> Maybe it is related to gfgtdf's changes, but I didn't think he touched show_message_dialog. 20150920 22:58:29< celticminstrel> Where's the [message] that failed? 20150920 23:00:05< vultraz> 2nd utbs scenario, line 478 20150920 23:01:11< gfgtdf> celticminstrel: i think its the options parameter which is of type array of strings 20150920 23:01:23< gfgtdf> celticminstrel: maybe you shodul change it to vector 20150920 23:01:33< gfgtdf> t_string* 20150920 23:05:25< celticminstrel> It said parameter 1, but I suppose that could be a typo in the source... 20150920 23:05:33< celticminstrel> Checking. 20150920 23:06:58< vultraz> It said -1 20150920 23:07:00< vultraz> which is weird 20150920 23:07:06< celticminstrel> Eh? 20150920 23:07:06< vultraz> not 1, -1 20150920 23:07:25< celticminstrel> Ah... you're right... 20150920 23:08:17-!- gfgtdf_ [~chatzilla@f054152196.adsl.alicedsl.de] has joined #wesnoth-dev 20150920 23:08:37-!- [Relic] [~Relic]@2602:306:33a3:6d30:b9c2:3b68:3d17:28ed] has joined #wesnoth-dev 20150920 23:08:48< irker264> wesnoth: gfgtdf wesnoth:master 167199bd164c / src/ (synced_user_choice.cpp synced_user_choice.hpp): attempt to fix replays http://git.io/vnWG0 20150920 23:09:30< gfgtdf_> vultraz: whie reacding teh array parameter it pushes the elements on the stack and tehn reads them at position -1 20150920 23:09:33< gfgtdf_> reading* 20150920 23:09:38-!- travis-ci [~travis-ci@ec2-54-80-42-162.compute-1.amazonaws.com] has joined #wesnoth-dev 20150920 23:09:39< travis-ci> wesnoth/wesnoth#7442 (master - 2c245af : gfgtdf): The build is still failing. 20150920 23:09:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/81302981 20150920 23:09:39-!- travis-ci [~travis-ci@ec2-54-80-42-162.compute-1.amazonaws.com] has left #wesnoth-dev [] 20150920 23:10:38< vultraz> oh ok 20150920 23:11:29-!- gfgtdf [~chatzilla@f054152196.adsl.alicedsl.de] has quit [Ping timeout: 265 seconds] 20150920 23:11:42-!- gfgtdf_ is now known as gfgtdf 20150920 23:14:27< celticminstrel> So then there's an issue in the implementation of lua_check. 20150920 23:15:33< gfgtdf> celticminstrel: you mean that teh wrong number is displayed? 20150920 23:17:21< celticminstrel> Yes. 20150920 23:21:57< celticminstrel> gfgtdf: Your synchronized thing generates a link error. 20150920 23:22:07< celticminstrel> Did you add a new source file? 20150920 23:22:12< gfgtdf> celticminstrel: ? i think travis coudl build it 20150920 23:22:17< gfgtdf> celticminstrel: yes i added 2 new files 20150920 23:22:38< Aginor> did you add them to scons and cmake? 20150920 23:22:43< gfgtdf> yes 20150920 23:23:14< celticminstrel> What files? 20150920 23:23:51< gfgtdf> https://github.com/wesnoth/wesnoth/commits/master/src/SConscript 20150920 23:31:07-!- louis94 [~~louis94@109.129.229.117] has quit [Ping timeout: 240 seconds] 20150920 23:33:19< irker264> wesnoth: Celtic Minstrel wesnoth:master 6a09ef61e76d / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project file http://git.io/vnWCc 20150920 23:33:21< irker264> wesnoth: Celtic Minstrel wesnoth:master 7f7f0f48d5b1 / src/scripting/lua_gui2.cpp: Lua API: show_message_dialog now assumes options are translatable http://git.io/vnWCC 20150920 23:34:43< celticminstrel> vultraz: Does that fix it? 20150920 23:34:51< vultraz> will try 20150920 23:37:42< irker264> wesnoth: Celtic Minstrel wesnoth:master a3e3f5e719d8 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project file http://git.io/vnWCD 20150920 23:40:05< celticminstrel> Sorry, missed that there were four files. >_> 20150920 23:44:42-!- travis-ci [~travis-ci@ec2-54-167-228-112.compute-1.amazonaws.com] has joined #wesnoth-dev 20150920 23:44:43< travis-ci> wesnoth/wesnoth#7443 (master - 504cdb6 : Randypk): The build is still failing. 20150920 23:44:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/81303521 20150920 23:44:43-!- travis-ci [~travis-ci@ec2-54-167-228-112.compute-1.amazonaws.com] has left #wesnoth-dev [] 20150920 23:45:52< vultraz> celticminstrel: yes 20150920 23:47:58< irker264> wesnoth: Charles Dang wesnoth:master acdc67fe56b6 / data/lua/wml/object.lua: [object] don't show unit reach when highlighting unit http://git.io/vnWW1 --- Log closed Mon Sep 21 00:00:15 2015