--- Log opened Thu Sep 24 00:00:28 2015
20150924 00:12:26-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20150924 00:23:08-!- louis94 [~~louis94@222.110-66-87.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20150924 00:28:21< Aginor> shadowm: I might just have cracked the alpha blending
20150924 00:29:58< Aginor> celticminstrel: that hotkey thing you wrote about earlier, which branch was that?
20150924 00:30:33< shadowm> The infinitely multiplying hotkeys thing happens on 1.12, for the record.
20150924 00:30:46< shadowm> IIRC master doesn't fare any better in that regard.
20150924 00:32:48-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150924 00:36:09-!- [Relic] [~Relic]@2602:306:33a3:6d30:4a4:a0db:7437:eeca] has quit [Quit: I press the magic X and all the weirdos go away!]
20150924 00:38:24< Aginor> shadowm: sdl2 ought to fix it on master when it's merged
20150924 00:38:46< Aginor> but 1.12.4 will need proper fixing
20150924 00:39:24< Aginor> when it occurs, does the local settings file have a bunch of duplicate entries in it?
20150924 00:43:32< shadowm> Only two entries for objectives.
20150924 00:43:52< shadowm> Both ctrl+j.
20150924 00:44:05< shadowm> On the menu I see three -- one of them is probably the default binding.
20150924 00:45:28< shadowm> I suspect that the game always appends the user entries to the default bindings. How there are two identical user entries for the same command is beyond me.
20150924 00:46:16< celticminstrel> It shouldn't always append - you can remove default bindings, right?
20150924 00:46:34< shadowm> It just dawned upon me that my preferences file is 1909 lines long.
20150924 00:46:48< shadowm> Hotkeys start at line 155.
20150924 00:48:25< shadowm> This is amazing (bear in mind that tooltip font size scales down as needed to try to fit everything on a single line): http://i.imgur.com/YBbm6ry.png
20150924 00:49:57< Aginor> celticminstrel: it'll actually re-add default bindings unless they've been overridden
20150924 00:50:00-!- [Relic] [~Relic]@2602:306:33a3:6d30:f459:39b8:544d:3146] has joined #wesnoth-dev
20150924 00:50:38< shadowm> I believe it's a known, reported bug. The infinite multiplication, not so sure.
20150924 00:50:46< Aginor> I'm not sure if that's a bug or a feature :D
20150924 00:51:05< Aginor> infinite multiplication is because it's buggy :)
20150924 00:51:11< shadowm> 1.12.4 RA: "It’s not possible to clear some default hotkeys with the Clear Hotkey option (bug #21983). This will not be fixed in 1.12.x."
20150924 00:51:39< Aginor> does that imply I ought to fix that in 1.13.x?
20150924 00:52:06< shadowm> I mean that I'm not sure if the infinitely growing hotkey list is a reported bug.
20150924 00:52:25-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 256 seconds]
20150924 00:52:33< Aginor> ah
20150924 00:52:58< shadowm> If it's still a thing after your changes then please do fix it, you made yourself the de facto maintainer of the hotkeys mess in master after all. :p
20150924 00:53:26< Aginor> I carefully kept the current behaviour, even if I thought it was silly :D
20150924 00:53:40< Aginor> except for the infinite bug thing, that struck me as too silly
20150924 00:54:10< Aginor> but I did keep the "cleared hotkeys don't persist" feature/bug
20150924 00:54:11< shadowm> https://gna.org/bugs/index.php?21969 <- infinite hotkeys bug, diet flavor.
20150924 00:54:33-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20150924 00:55:37-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20150924 00:55:39< Aginor> mmm
20150924 00:56:12< Aginor> you want me to try to fix that on 1.12? :/
20150924 00:56:31< shadowm> If you find a way to reproduce it, then sure.
20150924 00:57:06< celticminstrel> ...80,000 lines? o.O
20150924 00:57:17< Aginor> the real problem will be how to deal with the corrupted config files...
20150924 00:57:34< shadowm> Just ask people to clear their hotkeys after fixing.
20150924 00:57:51< Aginor> after they're full of junk it's hard to tell if the junk is valid or not
20150924 00:57:58< celticminstrel> But if there's a hotkey with a null command I'd say it should be automatically deleted, surely?
20150924 00:58:11< shadowm> It surely doesn't happen for *all* reassigned commands. For example, one of the first things I do is reassign End Turn to Alt+Space. Currently, I have both Ctrl+Space (the default, thanks to #21983) and Alt+Space. Both appear only once and there's no constant multiplication going on AFAICT.
20150924 00:58:30< celticminstrel> Huh? It's alt+space by default for me.
20150924 00:58:54< shadowm> Yes because you are on OS X.
20150924 00:59:09< celticminstrel> Oh wait. Alt+Space is "System Menu" on Windows, right.
20150924 00:59:28< shadowm> And we kind of don't want different bindings for Windows and Linux.
20150924 00:59:46< celticminstrel> Why's that? Not that I have a problem with it or anything.
20150924 01:00:07< shadowm> Documentation.
20150924 01:00:18< celticminstrel> Ah, yeah, that makes sense.
20150924 01:00:27< shadowm> As long as there's no need, don't complicate things for people.
20150924 01:01:11< shadowm> In this case there's no need because Windows and Linux are generally on par with each other, after all, most Linux applications are modelled after a Windows analogue.
20150924 01:01:23-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 264 seconds]
20150924 01:01:37< shadowm> (Also, remind me to remove that stupid APPLE preprocessor define from add-on contexts at some point.)
20150924 01:02:09< shadowm> (Or better yet, remove it altogether and make the hotkeys config use real WML as it should.)
20150924 01:02:12< celticminstrel> ...it's visible to add-ons?
20150924 01:02:26< celticminstrel> ...huh? The hotkeys config is not real WML?
20150924 01:02:39< shadowm> Real WML as opposed to preprocessor hackery.
20150924 01:02:59< Aginor> right...
20150924 01:03:01< celticminstrel> There's only a little preprocessor hackery, right?
20150924 01:03:04< Aginor> I'm out of coffee
20150924 01:03:08< shadowm> #ifdef APPLE is preprocessor hackery.
20150924 01:03:15< celticminstrel> Well yes.
20150924 01:03:23< Aginor> this is an emergency of great proportions and I will not be back until it's resolved
20150924 01:03:42< shadowm> Incidentally, I won't be available for the next 3 weeks.
20150924 01:03:47< celticminstrel> Oh, there is all that IF_APPLE_CMD_ELSE_CTRL stuff.
20150924 01:04:10< Aginor> shadowm: when will you start to become unavailable?
20150924 01:04:38< shadowm> -2 weeks from now. (Yes, that's a minus sign. It should be obvious I haven't been available for dev stuff as of late.)
20150924 01:05:01< Aginor> fair enough
20150924 01:05:13< celticminstrel> So how do you propose getting rid of the preprocessor hackery?
20150924 01:05:19< shadowm> I'll still be around to answer questions but don't expect me to produce code, or releases.
20150924 01:05:31< Aginor> I'll fix things in the sdl2 branch and then we can talk about tests and merges when you get back
20150924 01:05:55< celticminstrel> Okay, so sdl2 branch could be merged by the end of October?
20150924 01:05:59< celticminstrel> Potentially.
20150924 01:06:45< Aginor> celticminstrel: I'm aiming to have it mergeable by end of September :)
20150924 01:07:00< celticminstrel> Fair, but mergeable != merged. :P
20150924 01:07:05< shadowm> celticminstrel: Redesign the [hotkey] tag in a way that allows expressing OS X patches in some way. I don't really know.
20150924 01:07:41< Aginor> shadowm: there's hackery going on inside the code for OSX too
20150924 01:07:58< shadowm> You can check yourself if APPLE is exposed to add-ons by dropping a Foo_Bar/_main.cfg file in your add-ons dir with `#error Hi` in it.
20150924 01:08:01< Aginor> ctrl is replaced with cmd when loading all hotkeys
20150924 01:08:17< shadowm> If Wesnoth says Hi on startup, then it is exposed to add-ons. If it doesn't, it means I misread something.
20150924 01:08:47< celticminstrel> Aginor: That's not quite enough though.
20150924 01:08:49< shadowm> `#ifdef APPLE #error Hi #endif` I mean, kind of obvious though.
20150924 01:09:27< Aginor> celticminstrel: no, ideally it shouldn't happen at all
20150924 01:09:34< celticminstrel> Aginor: There are several shortcuts which are completely different in order to match OSX expectations.
20150924 01:09:37< Aginor> it's flaky and prone to breakage
20150924 01:09:43< celticminstrel> For example, Cmd+, for preferences.
20150924 01:09:48< Aginor> celticminstrel: I know :)
20150924 01:10:11< shadowm> Cmd+, ? What a funny platform.
20150924 01:12:33-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150924 01:13:30< celticminstrel> I dunno why it's Cmd+, but I'm used to it now.
20150924 01:13:33< Aginor> yes, I do indeed have a fix for the alpha-blending issue
20150924 01:13:43< celticminstrel> Yay!
20150924 01:13:57< celticminstrel> Would you like me to look at the colour cursors thing?
20150924 01:14:00< Aginor> I should have a tidied up version committed in a few hours
20150924 01:14:25< Aginor> celticminstrel: I reviewed the code for colour cursors earlier today
20150924 01:14:36< Aginor> there's plenty of scope for improvements, so go for it if you want
20150924 01:15:08< Aginor> I should be able to fix the ghosting wedge009 has reported with my blend fix though
20150924 01:15:11< celticminstrel> Once I finish fixing the tests that I broke in my Lua branch.
20150924 01:15:24< Aginor> fair enough
20150924 01:16:37< Aginor> anyway, I need to go and buy coffee, and new cleaning equipment for my coffee roaster so I won't end up in this terrible situation again
20150924 01:16:48< Aginor> s/neeed/want/ :)
20150924 01:17:07< Aginor> then I'll try to make a real fix that I can commit
20150924 01:17:22< celticminstrel> Heh.
20150924 01:18:06< Aginor> laters
20150924 01:21:30-!- mjs-de [~mjs-de@x4db59439.dyn.telefonica.de] has quit [Remote host closed the connection]
20150924 01:26:05-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20150924 01:41:42-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150924 01:54:19-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 246 seconds]
20150924 01:55:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150924 02:22:00-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 250 seconds]
20150924 02:42:59-!- irker891 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150924 02:42:59< irker891> wesnoth: Celtic Minstrel wesnoth:sdl2 c68fc094d7a0 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: XCode: Fix unresolved merge conflict http://git.io/vn11G
20150924 02:57:15-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev
20150924 03:06:25-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 265 seconds]
20150924 03:07:48-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150924 03:10:21-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150924 03:11:32-!- [Relic] [~Relic]@2602:306:33a3:6d30:f459:39b8:544d:3146] has quit [Quit: I press the magic X and all the weirdos go away!]
20150924 03:13:12-!- [Relic] [~Relic]@2602:306:33a3:6d30:55cd:b4a4:dcd4:5f77] has joined #wesnoth-dev
20150924 03:14:00< Aginor> celticminstrel: thanks, I thought I'd gotten them all but I hadn't tested
20150924 03:14:22< Aginor> it's a bit ironic, I do this bit of work on the mac but I use eclipse and cmake
20150924 03:27:25< irker891> wesnoth: Celtic Minstrel wesnoth:sdl2 f0a837227824 / projectfiles/Xcode/Mac Sources/SDLMain.m: OSX: Remove SDLApplication class as SDL2 also implements it http://git.io/vn15r
20150924 03:29:55< Aginor> ummm
20150924 03:30:12< celticminstrel> Fixes a runtime warning (as the full message explains).
20150924 03:31:29< celticminstrel> On an unrelated note, I've noticed that the changelog window pops up momentarily when I quit.
20150924 03:31:48< Aginor> isn't that stuff required for SDL 1.2 though?
20150924 03:32:09< Aginor> wouldn't it be better to put the SDL_VERSION_ATLEAST(2,0,0) around that code?
20150924 03:32:23< celticminstrel> Ah, maybe. The sdl2 branch is still supposed to support SDL1.2, then?
20150924 03:32:27< Aginor> especially since the SDL1.2 support isn't supposed to be dropped in that branch
20150924 03:32:41< celticminstrel> Right, sorry.
20150924 03:32:44< Aginor> SDL2 is the default, full support isn't to be dropped
20150924 03:34:28< celticminstrel> Whoops.
20150924 03:35:32< celticminstrel> The colour cursors (old way) aren't slow at the main menu but do cause various artifacts.
20150924 03:35:41< celticminstrel> Maybe they're slow in-game.
20150924 03:36:01< vultraz> 1.2 will be dropped in master post-merge?
20150924 03:36:34< celticminstrel> Now that I think about it, I believe the goal was to drop 1.2 after the release of 1.13.2.
20150924 03:39:17< irker891> wesnoth: Celtic Minstrel wesnoth:sdl2 eebe3cfb758e / projectfiles/Xcode/Mac Sources/SDLMain.m: Revert f0a837227824a055362296b7db423bcdc7354c38 for SDL1.2 only http://git.io/vn1bs
20150924 03:48:44< Aginor> vultraz: 1.2 will be retained until 13.3
20150924 03:48:50< Aginor> then it'll be dropped from master
20150924 03:49:10< Aginor> i.e, let's have a release with a fallback in case everything goes horribly
20150924 03:49:55< celticminstrel> I guess dropping 1.2 support is about as simple as searching for all the SDL_VERSION_ATLEAST uses.
20150924 03:50:09< Aginor> yes
20150924 03:50:53< vultraz> Aginor: what about SDL_GPU?
20150924 03:51:07< celticminstrel> ...heh, I was just wondering that now.
20150924 03:51:12< Aginor> vultraz: good question, I haven't gotten that far yet
20150924 03:51:30-!- travis-ci [~travis-ci@ec2-54-157-202-179.compute-1.amazonaws.com] has joined #wesnoth-dev
20150924 03:51:31< travis-ci> wesnoth/wesnoth#7470 (sdl2 - c68fc09 : Celtic Minstrel): The build is still failing.
20150924 03:51:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/81894949
20150924 03:51:31-!- travis-ci [~travis-ci@ec2-54-157-202-179.compute-1.amazonaws.com] has left #wesnoth-dev []
20150924 03:51:32< Aginor> strictly speaking, there's no need unless we want HW support
20150924 03:51:47< Aginor> I should do another merge with master I guess
20150924 03:51:48< vultraz> HW?
20150924 03:51:53< Aginor> hardware
20150924 03:52:01< vultraz> I thought we did
20150924 03:52:04< celticminstrel> Okay, at least that fail isn't my fault, seemingly.
20150924 03:52:41< Aginor> celticminstrel: I think it's because of a failure on main and I haven't merged changes over that fixes the problem
20150924 03:53:05 * celticminstrel nods.
20150924 03:53:05< Aginor> vultraz: indeed
20150924 03:53:33< Aginor> vultraz: I haven't looked at all of the SDL_GPU stuff, but it seems to be awefully complicated
20150924 03:53:49< Aginor> for something that should be rather straightforward :)
20150924 03:54:10< Aginor> take bitmap, turn into texture, throw into rendering pipeline, done
20150924 03:54:13< vultraz> What are the alternatives?
20150924 03:54:17< Aginor> then there's optimisation
20150924 03:54:21< Aginor> just rely on SDL2
20150924 03:54:45< Aginor> but I haven't researched the options carefully, and there are probably reasons I don't understand yet for the usage of SDL_GPU
20150924 03:54:55< vultraz> SDL2 provides HW support?
20150924 03:55:05< Aginor> vultraz: yes.
20150924 03:55:08< celticminstrel> I thinks so, yeah.
20150924 03:55:12< vultraz> Hm
20150924 03:55:16< Aginor> by default it does hardware
20150924 03:55:25< vultraz> oh?
20150924 03:55:33< vultraz> are you going to leave it that way?
20150924 03:55:37< Aginor> wesnoth is explicitly telling it to use software
20150924 03:55:37< celticminstrel> But I think Wesnoth does need some other changes to fully make use of hardware support.
20150924 03:55:49< celticminstrel> Also that, sure.
20150924 03:56:15< vultraz> I have no idea about any of this, but it seems to me if it uses hardware we shouldn't make it use software
20150924 03:56:31< vultraz> Unless we have some code that explicitly requires software 
20150924 03:56:55< celticminstrel> Wesnoth is not designed a way that makes it easy to leverage software.
20150924 03:57:10< celticminstrel> If I understand correctly, it keeps too many surfaces around for that.
20150924 03:57:45< Aginor> there is software implementations inside wesnoth for certain operations, including a modified blit operation
20150924 03:57:59< Aginor> those things requires workarounds
20150924 03:58:17< Aginor> number of surfaces isn't that much of a problem actually, or at least I think so
20150924 03:58:43-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev
20150924 03:59:07< vultraz> workarounds for hw use, or it uses workarounds for soft rendering?
20150924 03:59:07< Aginor> most of the code in sdl/utils.cpp needs to be rewritten/modified to make it easy to transition to hardware acceleration
20150924 03:59:23< Aginor> vultraz: workarounds for software rendering
20150924 03:59:35< vultraz> ah
20150924 04:07:52< Aginor> https://github.com/wesnoth/wesnoth/pull/500
20150924 04:08:04< Aginor> I need to test more and tidy up
20150924 04:08:12< Aginor> and see if I've missed something
20150924 04:08:34< Aginor> that may also have a positive effect on colour cursors
20150924 04:10:29< vultraz> I thought color cursors needed to be dealt with separately with SDL_SetColorCursor or whatsitcalled
20150924 04:10:47< Aginor> vultraz: it's debatable
20150924 04:11:03< Aginor> I suspect that if we use that API we'll also be using HW cursors
20150924 04:11:23< Aginor> celticminstrel has probably looked more at it than I at this point :)
20150924 04:13:28 * Aginor starts a full rebuild on the old tired osx laptop
20150924 04:17:59< shadowm> While cleaning up my email folders, I came across an out-of-office email notification from 2012 to forums@wesnoth.org from some Matthias Schoeck.
20150924 04:18:08< shadowm> Shame on you, past mattsc.
20150924 04:18:16< Aginor> heh
20150924 04:18:42< celticminstrel> Huh?
20150924 04:20:10< shadowm> I receive messages sent to forums@w.o, including silly automated replies to forum notifications.
20150924 04:20:30 * shadowm is not quite sure what was the question but hopes that's the correct answer.
20150924 04:20:37< Aginor> is there ever anything worthwhile there?
20150924 04:20:43< shadowm> Yes.
20150924 04:20:56< Aginor> that surpises me :)
20150924 04:22:32< shadowm> This is my personal favorite: https://dl.dropboxusercontent.com/u/21371130/screenshots/BUNNED.png
20150924 04:22:48-!- travis-ci [~travis-ci@ec2-54-157-224-110.compute-1.amazonaws.com] has joined #wesnoth-dev
20150924 04:22:49< travis-ci> wesnoth/wesnoth#7471 (sdl2 - f0a8372 : Celtic Minstrel): The build is still failing.
20150924 04:22:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/81899060
20150924 04:22:49-!- travis-ci [~travis-ci@ec2-54-157-224-110.compute-1.amazonaws.com] has left #wesnoth-dev []
20150924 04:23:29-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150924 04:23:31< celticminstrel> Uhh
20150924 04:24:12< Aginor> ummm
20150924 04:24:24-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150924 04:24:35< Aginor> compile failures?
20150924 04:25:54< Aginor> why have I not been seeing those
20150924 04:26:13< Aginor> celticminstrel: I can deal with it, it looks like I'm the cause
20150924 04:27:48 * celticminstrel notes that my uhh was at shadowm 
20150924 04:28:55< Aginor> ok :)
20150924 04:29:10< celticminstrel> Today I learned that you can move units by drag-and-drop.
20150924 04:29:13< shadowm> You've never received death threats in your PM inbox?
20150924 04:29:25< celticminstrel> Was that a death threat?
20150924 04:29:34< shadowm> No.
20150924 04:29:42< Aginor> not yet
20150924 04:30:29< Aginor> shadowm: do you get them often?
20150924 04:30:31< shadowm> If you ever find yourself in a position where you can choose to _not_ moderate/admin a forum, I advise you do so.
20150924 04:30:39< shadowm> Nah, only once.
20150924 04:31:17< Aginor> I'm still sorry to hear that you have received them
20150924 04:31:18< shadowm> Also, I think I'm still supposed to give someone their money back.
20150924 04:31:29 * shadowm glances at another angry email.
20150924 04:31:46< Aginor> for the free game?
20150924 04:31:52< shadowm> iOS port.
20150924 04:32:20< shadowm> The older, unmaintained and unsupported 1.6 iOS port, to be specific.
20150924 04:34:37< shadowm> In all seriousness, 97% of the mail I get via forums@w.o is either spam (because SOMEONE went MIA before fixing our mailer) or support requests about forum account credentials.
20150924 04:36:13< shadowm> The remaining 3% is either misplaced replies (I wanted to switch the forums to a noreply address but found a problem with that, can't remember what), ban appeals from ages ago, or SQL error messages from whenever the database server decides to go out for lunch.
20150924 04:37:15< Aginor> https://github.com/wesnoth/wesnoth/pull/500 is looking good, but there's stuff missing
20150924 04:37:24< Aginor> lightbeam attack still causes issues
20150924 04:38:48< shadowm> (Ah, yes, the problem is that the support address' discoverability is extremely low unless you are banned or the forums are taking a dump.)
20150924 04:41:20< Aginor> celticminstrel: the code you want to delete in PR501 should be left in but have the SDL_VERSION stuff around it instead :/
20150924 04:41:37< celticminstrel> Oh right. Sigh.
20150924 04:42:22< Aginor> shadowm: do you know which class drives attack animations?
20150924 04:44:19< Aginor> shadowm: the forum administration doesn't sound like fun :/
20150924 04:44:55< shadowm> It wasn't very fun for the past few years, no, but as of late it's kind of meh because absolutely nothing happens.
20150924 04:45:14< shadowm> But no news is good news, I guess.
20150924 04:46:50< shadowm> Aginor: To answer your question, no, but most of the graphics logic is in src/unit_animation.?pp and src/unit_display.?pp (IIRC), with the entry points/higher-level logic in src/actions/.
20150924 04:47:13< shadowm> src/unit_animation*.?pp
20150924 04:47:18< Aginor> thank you, that should be enough for me to find the problem
20150924 04:48:01< shadowm> By graphics logic I mean that this code is told what units are involved, what the gamemap is, what the unit locations are, etc. by the high-level logic in src/actions/.
20150924 04:49:28< shadowm> src/actions/ contains primarily code that drives the actual gameplay.
20150924 04:50:51< shadowm> I guess the fact that most of the codebase is everything but gameplay is a testament to the game rules' simplicity and WML/Lua-driven contextualization.
20150924 04:52:05< shadowm> If only that were enough to make a full game engine, we wouldn't need more than two people to maintain it all. :p
20150924 04:53:01< Aginor> as the saying goes; the devil is in the details
20150924 04:55:37-!- travis-ci [~travis-ci@ec2-54-157-202-179.compute-1.amazonaws.com] has joined #wesnoth-dev
20150924 04:55:38< travis-ci> wesnoth/wesnoth#7472 (sdl2 - eebe3cf : Celtic Minstrel): The build is still failing.
20150924 04:55:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/81900263
20150924 04:55:38-!- travis-ci [~travis-ci@ec2-54-157-202-179.compute-1.amazonaws.com] has left #wesnoth-dev []
20150924 04:59:39-!- oldlaptop [~quassel@50.36.238.180] has quit [Ping timeout: 240 seconds]
20150924 05:04:02-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev
20150924 05:05:46< Aginor> there we go, I think I've got all alpha stuff fixed
20150924 05:08:25< celticminstrel> Fixed, sorry.
20150924 05:11:20< celticminstrel> If/when mattsc shows up I'd like to know which files had issues before -Wno-unused-local-typedefs ... I think it was Boost stuff, so it might be quite a lot, though...
20150924 05:11:41< Aginor> very many :/
20150924 05:11:49< Aginor> it's still showing up when you compile with cmake
20150924 05:12:00< Aginor> I can give you a full build log if you want
20150924 05:12:05< celticminstrel> Hmm.
20150924 05:12:08< celticminstrel> If you want.
20150924 05:12:22< celticminstrel> I'm not quite sure if it would help.
20150924 05:12:33< celticminstrel> If the issue is Boost, then the solution might be a bit different than you'd expect.
20150924 05:12:44< Aginor> yeah...
20150924 05:13:41< celticminstrel> You're compiling with clang, right?
20150924 05:14:08< celticminstrel> My clang doesn't even issue (or support) those warnings because it's so old.
20150924 05:16:27< Aginor> on osx, yes
20150924 05:17:58-!- Shackra [~Jorge@186.177.2.148] has quit [Remote host closed the connection]
20150924 05:19:23-!- oldlaptop [~quassel@50.36.238.180] has joined #wesnoth-dev
20150924 05:21:58< Aginor> on linux I rely on gcc
20150924 05:22:25< celticminstrel> I suspect the problem is that the folder containing boost is specified with -I instead of -isystem
20150924 05:22:37< celticminstrel> Do you have any idea how to change that in CMake?
20150924 05:23:02< Aginor> it shouldn't be too hard to find out
20150924 05:23:14< celticminstrel> I've changed it in XCode and am testing to make sure it still builds.
20150924 05:23:21< Aginor> the better question is why those warnings are only present on osx
20150924 05:23:34< celticminstrel> (I removed cairo and glib from the include paths, so I might need to add those back.)
20150924 05:23:53< celticminstrel> I would guess clang is the only compiler that issues them? I dunno for sure though.
20150924 05:24:50< Aginor> it could be compiler differences, but gcc also wanrs about unused variables in theory
20150924 05:24:55< Aginor> practise too :)
20150924 05:25:12< celticminstrel> This isn't unused variables. This is unused typedefs.
20150924 05:28:17< Aginor> ah, good point
20150924 05:30:01< Aginor> I shall try it out later when I've closed the alpha blending issue
20150924 05:30:12< Aginor> I'm in the middle of testing what I hope is the last iteration
20150924 05:30:34< celticminstrel> I'll make a pull request and probably assign it to mattsc, unless you want to try it in XCode?
20150924 05:31:01< Aginor> I don't have xcode set up for compiling so it may be easier to give it to mattsc
20150924 05:31:03< celticminstrel> Oh wait, I suppose you meant you'd try it out in CMake.
20150924 05:31:08< celticminstrel> Well, whatever!
20150924 05:31:21< Aginor> I'd try it in cmake
20150924 05:31:30< Aginor> it needs to be fixed there and in scons too :)
20150924 05:31:45< celticminstrel> It's affecting scons too? I don't recall seeing it on the travis.
20150924 05:32:38< Aginor> I haven't tried scons on osx, but it may
20150924 05:32:54< Aginor> travis builds on linux so it'll use gcc
20150924 05:33:04< celticminstrel> It uses clang too.
20150924 05:33:13< Aginor> hmm
20150924 05:33:18< Aginor> versions perhaps
20150924 05:33:29< celticminstrel> It runs the entire build six or seven times with different options.
20150924 05:33:30< Aginor> or slightly different build configuration
20150924 05:33:43< Aginor> that much I had noticed :)
20150924 05:35:54< ancestral> Apparently, the forums are scary
20150924 05:36:03< ancestral> “Can I ask for some help in this? Normally, I'd ask around the forum there but I'm very scared. :o”
20150924 05:36:39< celticminstrel> Heh, that was kinda amusing, yeah.
20150924 05:36:41< Aginor> I can't really see any fault in that reasoning, it usually takes a lot to bring me into a forum :D
20150924 05:36:43< ancestral> Stop scaring everyone! Moar bunnies and rainbows!
20150924 05:36:52< vultraz> celticminstrel: I get -Wunused_variables warnings on boost, do you get those?
20150924 05:36:56 * celticminstrel summons the bunnies.
20150924 05:37:01< celticminstrel> vultraz: No, I don't.
20150924 05:37:09< vultraz> Weird
20150924 05:37:17< vultraz> you get unused typedefs?
20150924 05:37:22< celticminstrel> No, mattsc does.
20150924 05:37:28< celticminstrel> I don't, my clang is too old.
20150924 05:37:34< ancestral> A free griffin plushie to everyone who contributes!
20150924 05:37:37-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150924 05:39:38-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 265 seconds]
20150924 05:49:53< vultraz> That would be incentive 
20150924 05:51:28-!- celticminstrel is now known as celmin|sleep
20150924 05:53:19-!- Ivanovic [~ivanovic@p4FC536BE.dip0.t-ipconnect.de] has quit [Changing host]
20150924 05:53:19-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20150924 06:12:06-!- Kwandulin [~Miranda@p5B009CBC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150924 06:19:32< Aginor> wedge009 and celmin|sleep, would either one of you care to validate https://github.com/wesnoth/wesnoth/pull/500?
20150924 06:33:42-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150924 06:56:42-!- [Relic] [~Relic]@2602:306:33a3:6d30:55cd:b4a4:dcd4:5f77] has quit [Quit: I press the magic X and all the weirdos go away!]
20150924 07:04:04-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150924 07:33:45-!- Rhonda [~rhonda@anguilla.noreply.org] has quit [Changing host]
20150924 07:33:45-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev
20150924 08:55:08-!- mjs-de [~mjs-de@x4db5aa49.dyn.telefonica.de] has joined #wesnoth-dev
20150924 09:15:24-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 255 seconds]
20150924 09:30:54-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20150924 09:35:31-!- mjs-de [~mjs-de@x4db5aa49.dyn.telefonica.de] has quit [Remote host closed the connection]
20150924 09:41:36-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20150924 09:41:43< Elvish_Hunter> Hi all
20150924 09:41:59< Aginor> hi Elvish_Hunter 
20150924 09:42:25< irker891> wesnoth: Elvish_Hunter wesnoth:master 53b5d031e93d / data/tools/wesnoth/ (wmliterator3.py wmltools3.py): Added Python 3 versions of wmltools and wmliterator http://git.io/vnDBR
20150924 09:42:27< irker891> wesnoth: Elvish_Hunter wesnoth:master a04bc6f45d84 / data/tools/wmllint: Converted wmllint to Python 3 http://git.io/vnDB0
20150924 09:42:30< irker891> wesnoth: Elvish_Hunter wesnoth:master 1f5d713ee1bf / data/tools/wmlscope: Converted wmlscope to Python 3 http://git.io/vnDBE
20150924 09:42:31< irker891> wesnoth: Elvish_Hunter wesnoth:master 526d745dfb19 / data/tools/wmlindent: Converted wmlindent to Python 3 http://git.io/vnDBu
20150924 09:42:34< irker891> wesnoth: Elvish_Hunter wesnoth:master 21a6bc583150 / data/tools/GUI.pyw: Converted GUI.pyw to Python 3 http://git.io/vnDBz
20150924 09:42:36< irker891> wesnoth: Elvish_Hunter wesnoth:master 6e4ecbb408ce / data/tools/wmllint-1.4: Converted wmllint-1.4 to Python 3 http://git.io/vnDBg
20150924 09:45:41< irker891> wesnoth: Elvish_Hunter wesnoth:master 3e89cd49327d / changelog: changelog entry http://git.io/vnDRK
20150924 09:46:30< Elvish_Hunter> So, now I'll have to start rewriting trackplacer...
20150924 09:46:46< Aginor> good job though
20150924 09:47:30< Elvish_Hunter> It win't be easy, because I'll have to discard all the GUI code (which is something like 90% of the code), and I'll be able to keep only the parsing code
20150924 09:47:35< Elvish_Hunter> *won't
20150924 09:49:04< Elvish_Hunter> Also, if you try to run wmllint with Python 3.4 and PyEnchant 1.6.5, you'll see that PyEnchant prints an exception.
20150924 09:49:36< Elvish_Hunter> This is a known bug, and the solution is to use PyEnchant 1.6.6
20150924 09:52:27< Elvish_Hunter> Aginor: thanks :)
20150924 10:17:28< Elvish_Hunter> With "discard the GUI code", I mean that obviously I won't be able to recycle it when moving from PyGTK to Tkinter.
20150924 10:19:29< Elvish_Hunter> Then again, probably I could learn PyGObject 3 and do only the required fixes, but do we really want to ask users to download a 100 MB installer just to draw dots on a map? I don't think so.
20150924 10:26:15< Elvish_Hunter> Correction: the installer is now 207 MB :/
20150924 10:31:16-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has left #wesnoth-dev ["Ciao!"]
20150924 10:52:50-!- gfgtdf [~chatzilla@f054129203.adsl.alicedsl.de] has joined #wesnoth-dev
20150924 10:55:18-!- Kwandulin [~Miranda@p5B009CBC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150924 11:08:27-!- Appleman1234 [~Appleman1@KD111239030173.au-net.ne.jp] has quit [Remote host closed the connection]
20150924 11:27:17-!- Appleman1234 [~Appleman1@KD111239030173.au-net.ne.jp] has joined #wesnoth-dev
20150924 11:45:55-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150924 11:48:55-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20150924 11:48:55-!- wedge010 is now known as wedge009
20150924 11:58:37-!- Kwandulin [~Miranda@p5B009CBC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150924 12:00:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150924 12:04:20-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has joined #wesnoth-dev
20150924 12:04:27-!- louis94 [~~louis94@189.107-66-87.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20150924 12:09:24-!- louis94 [~~louis94@189.107-66-87.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 264 seconds]
20150924 12:33:08-!- louis94 [~~louis94@91.178.60.192] has joined #wesnoth-dev
20150924 12:45:52-!- irker891 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150924 12:53:38-!- jpalider [~jpa@cardhu.semihalf.com] has joined #wesnoth-dev
20150924 12:54:09-!- jpalider [~jpa@cardhu.semihalf.com] has quit [Quit: Leaving]
20150924 12:55:31< Aginor> thanks wedge009 
20150924 12:56:20-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20150924 12:56:33< Aginor> I'll tae that as independant confirmation that my changes are good
20150924 12:57:43< wedge009> celmin|sleep, Aginor: Tested PR #500 and #501, but not simultaneously (doesn't look like there will be any collision or conflict though).
20150924 12:57:53< wedge009> Yes, the changes make sense to me.
20150924 12:57:59< wedge009> Aginor: ^
20150924 12:58:52< wedge009> I'd like to see both PRs merged with the sdl2 branch at some point, will be nice to test everything together.
20150924 13:00:55-!- danni [~quassel@adsl-au-4-115.ozonline.com.au] has joined #wesnoth-dev
20150924 13:02:31< Aginor> wedge009: that'll probably happen tomorrow
20150924 13:02:48< Aginor> I had one question for celmin|sleep, once that's answered I'll merge the PR
20150924 13:04:20-!- irker745 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150924 13:04:20< irker745> wesnoth: Andreas Löf wesnoth:sdl2 171963739be5 / src/ (cursor.cpp floating_label.cpp halo.cpp sdl/utils.cpp sdl/utils.hpp): Fix Alpha Blending issues in SDL2 http://git.io/vny8r
20150924 13:04:20< irker745> wesnoth: Andreas wesnoth:sdl2 c5bd5c96b7d0 / src/ (cursor.cpp floating_label.cpp halo.cpp sdl/utils.cpp sdl/utils.hpp): Merge pull request #500 from aginor/experimental-alpha-fix http://git.io/vny8o
20150924 13:04:52< Aginor> there we go
20150924 13:06:55 * wedge009 claps
20150924 13:07:35< Aginor> so much effort for so few lines of code :)
20150924 13:07:49< Aginor> I have read _a lot_ of the SDL code by now
20150924 13:08:55< wedge009> Yeah, I was wondering if it was really that simple (in terms of code changes), but often that's all that's needed.
20150924 13:10:03< Aginor> it's still a bit of a workaround, but anything more proper requires substantial changes to the to the entire rendering path
20150924 13:10:21< Aginor> that'll come later with hardware acceleration :)
20150924 13:10:24< wedge009> Yep. Decided to put that aside for now?
20150924 13:12:56< Aginor> I'm still persuing Step 1. "Get everything working"
20150924 13:13:45< Aginor> but it certainly seems to be getting there :)
20150924 13:14:06< wedge009> Yes, that's reasonable.
20150924 13:14:07-!- celmin|sleep is now known as celticminstrel
20150924 13:14:23 * vultraz reminds self to speak to our main artist about new color cursor graphics
20150924 13:14:29< Aginor> good morning celticminstrel :)
20150924 13:14:33< vultraz> if we're going to support them better, they should look better
20150924 13:15:03< wedge009> They don't look too bad. But any improvement is welcome.
20150924 13:15:18< vultraz> the design of some of them sucks :P
20150924 13:15:39< vultraz> What the hell does a cornucopia have to do with selection xD
20150924 13:17:38< Aginor> celticminstrel: I had one question on your PR, if you think I'm wrong I'll go ahead and merge now
20150924 13:22:36< celticminstrel> Answered.
20150924 13:23:12< Aginor> thanks
20150924 13:23:17< Aginor> I'll go and merge now
20150924 13:23:43< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 a4a8936972da / / (5 files in 3 dirs): Use native colour cursors http://git.io/vnyzU
20150924 13:23:45< irker745> wesnoth: Andreas wesnoth:sdl2 aa175ec0c8db / / (5 files in 3 dirs): Merge pull request #501 from CelticMinstrel/colour-cursors http://git.io/vnyzT
20150924 13:24:10< Aginor> celticminstrel: thanks for the help with the colour cursors :)
20150924 13:24:20< celticminstrel> :)
20150924 13:25:15< Aginor> I think the SDL2 branch is almost there now
20150924 13:26:37< celticminstrel> Yay!
20150924 13:27:07< Aginor> I need to fix the text input in gui1, but that should be rather easy and straightforward
20150924 13:27:38< Aginor> apart from the fact that I probably just jinxed it :)
20150924 13:28:14< celticminstrel> Heh.
20150924 13:29:11< wedge009> There's still the crash on window resizing, isn't there? Plus toggle-fullscreen feature.
20150924 13:30:01< Aginor> right...
20150924 13:30:12< Aginor> I should raise bugs for that so I don't forget again
20150924 13:35:33-!- ancestral [~ancestral@97-116-185-165.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150924 13:36:47-!- mjs-de [~mjs-de@p508C9C58.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150924 13:39:15-!- jcnewjersey [~jcnewjers@pool-108-35-38-39.nwrknj.fios.verizon.net] has joined #wesnoth-dev
20150924 13:40:18< Aginor> I am sorry for what I am about to do. I'm trying to fix some of the failing travis issues
20150924 13:40:26< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 f5bd414b690b / data/lua/wml-tags.lua: New WML tags to replace macro loop constructs http://git.io/vnrBF
20150924 13:40:29< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 6c5cf1eb88a7 / data/lua/wml-tags.lua: Implement [foreach] tag, based on Elvish_Hunter's implementation http://git.io/vnrBb
20150924 13:40:30< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 65263bfc3289 / data/lua/wml-tags.lua: Propagate modifications to item_var back into the array http://git.io/vnrBN
20150924 13:40:33< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 d895b1865978 / data/lua/wml-tags.lua: [foreach] now raises error if array length changes during iteration http://git.io/vnrBA
20150924 13:40:35< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 bda61536b0b7 / data/lua/wml-tags.lua: Use [do] subtags with [repeat] http://git.io/vnrBx
20150924 13:40:37< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 3c329408ce9f / / (6 files in 4 dirs): Implement [break], [continue], [return] tags (they take no arguments) http://git.io/vnrBp
20150924 13:40:39< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 aec99429c458 / / (6 files in 4 dirs): Merge branch 'break-continue' into foreach http://git.io/vnrBh
20150924 13:40:41< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 0ffda44b2781 / data/lua/wml-tags.lua: Add break/continue support to the new loops http://git.io/vnrBj
20150924 13:40:43< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 2fec74a6ac42 / data/lua/wml-utils.lua: Add default scope_type to handle_event_commands http://git.io/vnrRe
20150924 13:40:45< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 d527ea4740e5 / data/lua/wml-tags.lua: Fix up loop implementations to reflect recent changes http://git.io/vnrRv
20150924 13:40:47< irker745> wesnoth: gfgtdf wesnoth:sdl2 4c3e00b3bbb2 / data/lua/wml/message.lua: readd side_for parameter for [message] with input http://git.io/vn4wF
20150924 13:40:49< irker745> wesnoth: gfgtdf wesnoth:sdl2 58512935d405 / data/lua/wml/message.lua: add [message] wait_description= http://git.io/vn4wb
20150924 13:40:51< irker745> wesnoth: gfgtdf wesnoth:sdl2 4e775dd82438 / src/ (formula_string_utils.hpp synced_user_choice.cpp): mark waiting message as translatable. http://git.io/vn4wN
20150924 13:40:53< irker745> wesnoth: gfgtdf wesnoth:sdl2 52558d0d7c39 / src/formula_string_utils.hpp: attempt to fix compilation on travis. http://git.io/vn4jr
20150924 13:40:55< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 d5eea2abbf3d / data/lua/wml/message.lua: Fix [show_if] in [message][option] http://git.io/vnahT
20150924 13:40:57< irker745> wesnoth: Elias Pschernig wesnoth:sdl2 900c84657b9d / data/tools/ (4 files in 3 dirs): Upgraded wesnoth_addon_manager to Python 3 http://git.io/vnVem
20150924 13:40:59< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 56879d1f7d9b / src/formula_string_utils.hpp: attempt to fix travis build http://git.io/vnVEr
20150924 13:41:01< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 010d3ff35cd8 / src/formula_string_utils.hpp: attempt to fix travis build http://git.io/vnV7P
20150924 13:41:03< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 33a43990adc3 / data/lua/wml-tags.lua: Add an explanatory comment to [foreach] http://git.io/vnrRf
20150924 13:41:05< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 c3d51a343892 / changelog: Update changelog http://git.io/vnrRJ
20150924 13:41:07< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 0d49eeeb3933 / data/test/ (22 files in 2 dirs): Add SUCCEED/FAIL macros for WML test cases http://git.io/vnrRU
20150924 13:41:09< irker745> wesnoth: Celtic Minstrel wesnoth:sdl2 7e26e090615b / / (4 files in 3 dirs): Fix erroneous handling of [break]/[continue] in [elseif] http://git.io/vnrRT
20150924 13:41:11< irker745> wesnoth: CelticMinstrel wesnoth:sdl2 f07e463882b9 / / (29 files in 5 dirs): Merge pull request #493 from CelticMinstrel/foreach http://git.io/vnrRk
20150924 13:41:13< irker745> wesnoth: Elvish_Hunter wesnoth:sdl2 53b5d031e93d / data/tools/wesnoth/ (wmliterator3.py wmltools3.py): Added Python 3 versions of wmltools and wmliterator http://git.io/vnDBR
20150924 13:41:15< irker745> wesnoth: Elvish_Hunter wesnoth:sdl2 a04bc6f45d84 / data/tools/wmllint: Converted wmllint to Python 3 http://git.io/vnDB0
20150924 13:41:17< irker745> wesnoth: Elvish_Hunter wesnoth:sdl2 1f5d713ee1bf / data/tools/wmlscope: Converted wmlscope to Python 3 http://git.io/vnDBE
20150924 13:41:19< irker745> wesnoth: Elvish_Hunter wesnoth:sdl2 526d745dfb19 / data/tools/wmlindent: Converted wmlindent to Python 3 http://git.io/vnDBu
20150924 13:41:21< irker745> wesnoth: Elvish_Hunter wesnoth:sdl2 21a6bc583150 / data/tools/GUI.pyw: Converted GUI.pyw to Python 3 http://git.io/vnDBz
20150924 13:41:23< irker745> wesnoth: Elvish_Hunter wesnoth:sdl2 6e4ecbb408ce / data/tools/wmllint-1.4: Converted wmllint-1.4 to Python 3 http://git.io/vnDBg
20150924 13:41:25< irker745> wesnoth: Elvish_Hunter wesnoth:sdl2 3e89cd49327d / changelog: changelog entry http://git.io/vnDRK
20150924 13:41:27< irker745> wesnoth: Andreas Löf wesnoth:sdl2 1d7e52c38788 / / (42 files in 9 dirs): Merge branch 'master' into sdl2 http://git.io/vnyr8
20150924 13:44:34-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150924 13:46:39-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Max SendQ exceeded]
20150924 13:47:23-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150924 13:49:44-!- travis-ci [~travis-ci@ec2-54-81-35-112.compute-1.amazonaws.com] has joined #wesnoth-dev
20150924 13:49:45< travis-ci> wesnoth/wesnoth#7481 (sdl2 - c5bd5c9 : Andreas): The build is still failing.
20150924 13:49:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/81961337
20150924 13:49:45-!- travis-ci [~travis-ci@ec2-54-81-35-112.compute-1.amazonaws.com] has left #wesnoth-dev []
20150924 13:49:58-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Max SendQ exceeded]
20150924 13:50:48-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150924 13:52:32 * Aginor looks displeased
20150924 13:52:47< celticminstrel> That's not your merge.
20150924 13:52:48< Aginor> I need to investigate why there's a bunch of failing tests
20150924 13:53:06< celticminstrel> That's just the alpha blending fix.
20150924 13:53:24< celticminstrel> There's two more builds to go before you can see if merging master helped.
20150924 13:53:37< Aginor> good point, thanks
20150924 13:54:12< Aginor> maybe I should go to bed and come back in the morning instead
20150924 13:54:19< Aginor> maybe I'd not miss small things like that
20150924 13:56:42< matthiaskrgr> is it possible to compile wesnoth with -flto ?
20150924 13:57:28< celticminstrel> Explanation?
20150924 13:57:36< matthiaskrgr> link time optimization
20150924 13:57:44< celticminstrel> Dunno.
20150924 13:57:51< matthiaskrgr> https://gcc.gnu.org/wiki/LinkTimeOptimization 
20150924 13:59:01-!- ancestral [~ancestral@4.sub-70-197-234.myvzw.com] has joined #wesnoth-dev
20150924 13:59:08-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150924 13:59:11-!- Kwandulin [~Miranda@p5B009CBC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150924 13:59:17< matthiaskrgr> well, I'll give it a shot
20150924 14:00:31-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150924 14:03:51-!- ancestral [~ancestral@4.sub-70-197-234.myvzw.com] has quit [Read error: Connection reset by peer]
20150924 14:03:57< irker745> wesnoth: Andreas Löf wesnoth:sdl2 54d9965950c1 / src/ (display.cpp display.hpp): Fix compile warning in clang http://git.io/vnyDs
20150924 14:04:03-!- jcnewjersey [~jcnewjers@pool-108-35-38-39.nwrknj.fios.verizon.net] has quit [Read error: Connection reset by peer]
20150924 14:04:21< Aginor> celticminstrel: 3 builds to go :)
20150924 14:04:59< celticminstrel> Three?
20150924 14:06:05< Aginor> There are 3 things that are hard in computer science. Naming things and off-by-one errors
20150924 14:12:09-!- travis-ci [~travis-ci@ec2-54-159-227-190.compute-1.amazonaws.com] has joined #wesnoth-dev
20150924 14:12:10< travis-ci> wesnoth/wesnoth#7482 (sdl2 - aa175ec : Andreas): The build is still failing.
20150924 14:12:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/81964353
20150924 14:12:10-!- travis-ci [~travis-ci@ec2-54-159-227-190.compute-1.amazonaws.com] has left #wesnoth-dev []
20150924 14:12:42-!- ancestral [~ancestral@178.sub-70-197-208.myvzw.com] has joined #wesnoth-dev
20150924 14:15:02-!- ancestral [~ancestral@178.sub-70-197-208.myvzw.com] has quit [Client Quit]
20150924 14:29:59< matthiaskrgr> yeh, linking fails with flto :L 
20150924 14:30:13< matthiaskrgr> I'm not sure if I applied the cflags correctly though 
20150924 14:30:20-!- Kwandulin [~Miranda@p5B009CBC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150924 14:30:30< matthiaskrgr> CFLAGS="-flto" CXXFLAGS="-flto" VERBOSE=1 make   
20150924 14:48:38-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 240 seconds]
20150924 14:51:26-!- travis-ci [~travis-ci@ec2-54-159-227-190.compute-1.amazonaws.com] has joined #wesnoth-dev
20150924 14:51:28< travis-ci> wesnoth/wesnoth#7483 (sdl2 - 1d7e52c : Andreas Löf): The build is still failing.
20150924 14:51:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/81967046
20150924 14:51:28-!- travis-ci [~travis-ci@ec2-54-159-227-190.compute-1.amazonaws.com] has left #wesnoth-dev []
20150924 14:52:02 * Aginor goes back to looking displeased
20150924 14:52:07< celticminstrel> Alright then.
20150924 14:53:33< Aginor> I should have fixed the clang issue though
20150924 14:53:41< celticminstrel> Looks like you need to delete a private field in arrow.hpp.
20150924 14:53:52< Aginor> that was the commit earlier
20150924 14:54:00< celticminstrel> I assume the WML test failures are the result of a missing binary.
20150924 14:54:09< celticminstrel> Ah, the commit earlier.
20150924 14:54:18< celticminstrel> That commit has yet to be built, I think.
20150924 14:54:23< Aginor> indeed
20150924 14:54:41< Aginor> but I would expect the gcc bulds to pass since they're not reporting that error
20150924 14:56:11< celticminstrel> First two test failures could have been a fluke.
20150924 14:56:30< celticminstrel> The others though... no idea.
20150924 14:56:33< Aginor> it's a bit too consistent though
20150924 14:56:40< Aginor> I need to investigatet his more
20150924 14:56:53< Aginor> I'm a bit confused as to why they're failing though
20150924 14:56:54< celticminstrel> Consistent?
20150924 14:58:00< Aginor> they've been having the same failures across moltiple commits
20150924 14:58:10< Aginor> multiple even
20150924 14:58:25< celticminstrel> Ah.
20150924 14:58:49< celticminstrel> If you run the tests on your computer you should be able to see the errors.log.
20150924 15:01:56< Aginor> hmm
20150924 15:02:01< Aginor> Error (strict mode, strict_level = 1): wesnoth reported on channel error engine
20150924 15:02:04< Aginor> 20150925 02:58:54 error engine: unit at 13,4tried to advance more than 20 times. Advancing was aborted
20150924 15:02:19< celticminstrel> Uhh.
20150924 15:02:23< Aginor> from the alice_kills_bob_levelup test
20150924 15:02:32< celticminstrel> That's... kind of weird?
20150924 15:02:37< Aginor> yeah
20150924 15:02:50< Aginor> let me buid master and compare...
20150924 15:06:12-!- [Relic] [~Relic]@2602:306:33a3:6d30:e10f:acfe:840c:2c05] has joined #wesnoth-dev
20150924 15:08:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150924 15:08:23< Aginor> hmm
20150924 15:08:30< Aginor> same error
20150924 15:08:38< Aginor> 20150925 03:08:10 error engine: unit at 13,4tried to advance more than 20 times. Advancing was aborted
20150924 15:08:51< celticminstrel> ...huh.
20150924 15:09:11< celticminstrel> I was running tests pretty recently and didn't get that error.
20150924 15:10:58< celticminstrel> That was after my foreach branch was merged.
20150924 15:12:10< Aginor> tip of master looks good in travis
20150924 15:12:20< Aginor> something odd is going on
20150924 15:15:56-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 250 seconds]
20150924 15:27:31-!- travis-ci [~travis-ci@ec2-54-159-227-190.compute-1.amazonaws.com] has joined #wesnoth-dev
20150924 15:27:32< travis-ci> wesnoth/wesnoth#7484 (sdl2 - 54d9965 : Andreas Löf): The build is still failing.
20150924 15:27:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/81971004
20150924 15:27:32-!- travis-ci [~travis-ci@ec2-54-159-227-190.compute-1.amazonaws.com] has left #wesnoth-dev []
20150924 15:28:45-!- mjs-de [~mjs-de@p508C9C58.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20150924 15:30:41-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150924 15:32:44< celticminstrel> A comment in helper.lua states that ipairs() does not work on a vconfig, is this true? Also, does pairs() work?
20150924 15:37:01-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20150924 15:38:26-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20150924 15:42:19< celticminstrel> Okay, so if I understand correctly, vconfigs are userdata but normal configs are mapped directly to Lua tables.
20150924 15:46:34-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20150924 15:57:08-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150924 15:58:05< gfgtdf> celticminstrel: afaik lua can cotuomize the pairs method via mettables so it could be possible to implement paits for vconfig properly
20150924 15:58:16< celticminstrel> Yeah, I'm looking into that now.
20150924 15:58:32< celticminstrel> Well, actually I'm looking into ipairs right now, but close enough.
20150924 16:01:03< gfgtdf> celticminstrel: hmm maybe you'd need a lua wrapper for the vconfig::all_children_iterator class
20150924 16:01:21< celticminstrel> I'm trying to do it in C first.
20150924 16:01:29< celticminstrel> Using upvalues.
20150924 16:01:47-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20150924 16:02:28-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20150924 16:02:28-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20150924 16:02:28-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150924 16:06:12-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 250 seconds]
20150924 16:24:21-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 244 seconds]
20150924 16:24:27-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20150924 16:25:50< celticminstrel> Gasp! It actually worked! :D
20150924 16:30:22< celticminstrel> vconfig (C++ API) has no way to iterate over all attributes.
20150924 16:30:41< celticminstrel> I can either add it, or iterate over the underlying config instead (but return values from the vconfig).
20150924 16:31:02< celticminstrel> Going to try the latter for now.
20150924 17:03:05< celticminstrel> Works.
20150924 17:04:46-!- irker745 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150924 17:05:16< celticminstrel> Actually I should probably change the ipairs method to match how it'd work for configs...
20150924 17:11:55< celticminstrel> mattsc said he'd be away, right?
20150924 17:12:06< gfgtdf> hmm but vconfige are more complcated that vconfig specially when they have a [insert_tag] variable=v in it and you change $v  during iteration
20150924 17:12:12< gfgtdf> than config*
20150924 17:12:39< celticminstrel> I'm fairly sure it'll still work if you do that.
20150924 17:12:40< gfgtdf> celticminstrel: so the indexes of teh children might change during iteration
20150924 17:12:49< celticminstrel> But yeah, that might happen.
20150924 17:13:16< gfgtdf> celticminstrel: does you implementaio use vconfig::all_children_iterator?
20150924 17:13:22< celticminstrel> But, that's the same sort of thing you need to worry about when inserting or removing elements in an array during iteration. :P
20150924 17:13:24< celticminstrel> Yes it does.
20150924 17:14:05< celticminstrel> It stores the iterator in a private storage iterator so that it doesn't need to regain its location every time (as vcg[i] does in Lua).
20150924 17:14:18< celticminstrel> ^private storage location
20150924 17:15:11< gfgtdf> celticminstrel: hmm ok what exactly did you mean by "the ipairs method to match how it'd work for configs" ?
20150924 17:15:50< celticminstrel> Initially I implemented it so you'd do "for i, tag, contents = ipairs(vcfg)"
20150924 17:16:16< celticminstrel> in not =
20150924 17:16:51< celticminstrel> For a normal config you'd do "for i, elem in ipairs(cfg) tag, contents = elem[1], elem[2]" to get that effect.
20150924 17:17:03< celticminstrel> So I just changed to match that.
20150924 17:18:10< celticminstrel> https://github.com/CelticMinstrel/wesnoth/tree/lua-vconfig - last and third-last commit if you're interested in details
20150924 17:22:18< gfgtdf> celticminstrel: hmm but then calling (i)pairs() many times and breaking form the loop will spam your ipairs_iter_closures struct ?
20150924 17:23:30< celticminstrel> Possibly.
20150924 17:23:34< celticminstrel> Good point.
20150924 17:23:53< gfgtdf> celticminstrel: i think it woudl be better to store teh iterator directly in lua, teh same way as we store teh vconfig in lua
20150924 17:24:09< celticminstrel> I could partially get around that by changing the index from int to char. Then at least it'd overwrite old ones sooner.
20150924 17:24:37< celticminstrel> The iterator could be stored as a userdata, but that seemed silly for something that's never ever accessible to the user.
20150924 17:24:50< celticminstrel> ie, something that's stored in an upvalue and nowhere else.
20150924 17:24:56< gfgtdf> celticminstrel: i dont think its silly.
20150924 17:25:14< celticminstrel> Well, it depends on how much work it is to get it as a userdata.
20150924 17:25:52< gfgtdf> celticminstrel: the register_vconfig_metatable function is ~15 line + 5 loner for teh colledct function
20150924 17:26:07< celticminstrel> Huh?
20150924 17:26:51< gfgtdf> celticminstrel: what i was trying to say was it should be more work than ~20 copied lines.
20150924 17:27:03< celticminstrel> Glancing through the docs, it appears that making it userdata is simpler than I thought, so maybe I'll do that.
20150924 17:27:10< celticminstrel> What should be more work?
20150924 17:27:17< celticminstrel> Making it userdata?
20150924 17:27:20-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150924 17:28:23< gfgtdf> celticminstrel: that was an answer to "Well, it depends on how much work it is to get it as a userdata"
20150924 17:33:58< celticminstrel> I don't understand how it follows as an answer to that.
20150924 17:37:15< gfgtdf> celticminstrel: hmm your sentance can be interpretes as "How much work is it to implement it as a userdata" and i then said "The vconfig userdata is implemented in just 20 lines"
20150924 17:37:42< celticminstrel> Ah.
20150924 17:38:24-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20150924 17:43:20-!- gfgtdf [~chatzilla@f054129203.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0/20150917150946]]
20150924 18:04:29-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20150924 18:05:14-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Client Quit]
20150924 18:07:04-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20150924 18:14:59-!- louis94 [~~louis94@91.178.60.192] has quit [Ping timeout: 240 seconds]
20150924 18:16:17-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20150924 18:16:35-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150924 18:31:04-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150924 18:40:02-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150924 18:43:54-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150924 18:44:17< mattsc> 20150924 17:11:55< celticminstrel> mattsc said he'd be away, right?
20150924 18:44:22< mattsc> Yes, he did.
20150924 18:44:34< celticminstrel> Oh hi.
20150924 18:44:41< mattsc> Very quick hello from Europe.
20150924 18:44:46< celticminstrel> Ah.
20150924 18:44:51< celticminstrel> So not really available, then.
20150924 18:44:52-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150924 18:45:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 265 seconds]
20150924 18:45:23< mattsc> I might have a chance to test you assigned to me tomorrow, but can’t guarantee it.
20150924 18:45:33< mattsc> *test the PR you assigned
20150924 18:45:33< celticminstrel> 'kay
20150924 18:45:48< mattsc> If that doesn’t work, it’s going to be about Oct 15, I’m afraid.
20150924 18:45:53< celticminstrel> Okay.
20150924 18:47:04< mattsc> Sorry, I’m traveling without more than rudimentary Internet access most of the time.  I can check the logs and forums, but most of the time can’t do more than that.
20150924 18:48:10 * celticminstrel nods.
20150924 18:48:12< mattsc> And with that, talk to you later.
20150924 18:48:16< celticminstrel> Bye.
20150924 18:48:29< mattsc> Thanks for doing that, btw.
20150924 18:48:32< mattsc> Bye.
20150924 18:48:49-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20150924 18:53:47-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150924 19:01:25-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150924 19:07:18-!- louis94 [~~louis94@91.178.60.192] has joined #wesnoth-dev
20150924 19:13:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150924 19:13:50-!- louis94 [~~louis94@91.178.60.192] has quit [Ping timeout: 250 seconds]
20150924 19:21:11-!- alalazo [d537b0dc@gateway/web/freenode/ip.213.55.176.220] has joined #wesnoth-dev
20150924 19:37:47-!- Appleman1234 [~Appleman1@KD111239030173.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20150924 19:43:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150924 19:58:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150924 20:04:22-!- louis94 [~~louis94@91.178.60.192] has joined #wesnoth-dev
20150924 20:11:37-!- Kwandulin [~Miranda@p5B009CBC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150924 20:34:18-!- Appleman1234 [~Appleman1@KD111239023081.au-net.ne.jp] has joined #wesnoth-dev
20150924 20:42:40-!- alalazo [d537b0dc@gateway/web/freenode/ip.213.55.176.220] has quit [Quit: Page closed]
20150924 20:52:50-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150924 20:54:38-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150924 20:54:58-!- rayblade53 [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20150924 20:55:22-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20150924 20:55:26-!- rayblade53 is now known as vultraz
20150924 21:05:41-!- louis94 [~~louis94@91.178.60.192] has quit [Ping timeout: 240 seconds]
20150924 21:07:25-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has left #wesnoth-dev ["Ciao!"]
20150924 21:08:11-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20150924 21:08:11-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150924 21:28:42-!- louis94 [~~louis94@91.178.60.192] has joined #wesnoth-dev
20150924 21:34:46-!- mjs-de [~mjs-de@p508C9840.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150924 21:50:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20150924 21:50:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20150924 21:51:51-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20150924 21:56:28-!- mjs-de [~mjs-de@p508C9840.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20150924 21:59:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150924 22:17:43-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Remote host closed the connection]
20150924 22:26:07-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20150924 22:26:07-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20150924 22:26:07-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150924 22:33:59-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150924 22:38:40-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150924 22:49:36-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150924 22:58:54-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20150924 23:01:55-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20150924 23:03:51-!- louis94 [~~louis94@91.178.60.192] has quit [Quit: Konversation terminated!]
20150924 23:04:17-!- Appleman1234 [~Appleman1@KD111239023081.au-net.ne.jp] has quit [Remote host closed the connection]
20150924 23:05:14-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20150924 23:05:14-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20150924 23:05:14-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150924 23:05:31< Aginor> so... why are wml tests passing on tip of master in travis but failing for me?
20150924 23:05:41-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150924 23:08:21< celticminstrel> I have no idea. Try git bisect?
20150924 23:08:35< celticminstrel> (But don't use the man-page to figure out how that works, google it.)
20150924 23:08:55< Aginor> yeah, it certainly is leaning in that direction
20150924 23:15:30-!- gfgtdf [~chatzilla@f054129203.adsl.alicedsl.de] has joined #wesnoth-dev
20150924 23:15:35< gfgtdf> Aginor: i assume you read the travis error message ?
20150924 23:16:23< Aginor> gfgtdf: yes
20150924 23:16:27< Aginor> hmmm
20150924 23:16:42< gfgtdf> Aginor: also since travis keeps its errologs it migth b easier to look at the travis page when teh error appears that bisectin (i personally found bisecting rather hard to do becasue my compiler is ratehr slow)
20150924 23:16:43< Aginor> cpp tests fail with an assertion error in sdl2, that needs fixing
20150924 23:16:53-!- Appleman1234 [~Appleman1@KD111239023081.au-net.ne.jp] has joined #wesnoth-dev
20150924 23:17:18< celticminstrel> That reminds me, I should get the unit tests working in XCode.
20150924 23:19:04< Aginor> ok, so tests fail in SDL2 but pass in SDL1 on master
20150924 23:19:46< gfgtdf> Aginor: the wml unti test unfortulateley dont git a stacktrace on travis, but its quiet ewasy to run them locally using -u commandline flag
20150924 23:20:00< celticminstrel> No, not using -u
20150924 23:20:06< celticminstrel> That only runs a single test.
20150924 23:20:10< Aginor> gfgtdf: that's what I'm doing
20150924 23:20:19< celticminstrel> Well, you can do it that way if you really want, of course.
20150924 23:20:22< Aginor> I'm focusing on a single test at a time
20150924 23:20:26< celticminstrel> Fair enough.
20150924 23:20:40< Aginor> that way I can actually run it through a debugger :)
20150924 23:20:50< celticminstrel> Ah.
20150924 23:44:49< celticminstrel> I think it's working. O_O
20150924 23:45:24< gfgtdf> celticminstrel: what exactly is working ?
20150924 23:45:34< celticminstrel> Compilation of unit tests/
20150924 23:45:36< celticminstrel> ^.
20150924 23:45:39< celticminstrel> In XCode.
20150924 23:45:50-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150924 23:46:00< celticminstrel> How are the unit tests run?
20150924 23:46:09< celticminstrel> Just ./unit_tests or something a bit more complex?
20150924 23:47:32< gfgtdf> celticminstrel: i really don't know
20150924 23:49:18-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20150924 23:49:19-!- wedge010 is now known as wedge009
20150924 23:49:26< celticminstrel> Whooooa, hundreds of link errors. O_O
20150924 23:56:26-!- Grayken [814af2eb@gateway/web/freenode/ip.129.74.242.235] has joined #wesnoth-dev
20150924 23:57:07-!- Grayken [814af2eb@gateway/web/freenode/ip.129.74.242.235] has quit [Client Quit]
20150924 23:57:17-!- [Relic] [~Relic]@2602:306:33a3:6d30:e10f:acfe:840c:2c05] has quit [Ping timeout: 240 seconds]
20150924 23:57:18-!- legoktm [~quassel@wikipedia/Legoktm] has quit [Ping timeout: 240 seconds]
20150924 23:58:03-!- legoktm [~quassel@2604:a880:800:10::1c2:b001] has joined #wesnoth-dev
20150924 23:58:26-!- legoktm is now known as Guest18895
20150924 23:59:08-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
--- Log closed Fri Sep 25 00:00:04 2015