--- Log opened Sat Sep 26 00:00:39 2015
20150926 00:07:01-!- genbattle_ is now known as genbattle
20150926 00:58:33-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150926 00:59:03-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20150926 00:59:33-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150926 00:59:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20150926 01:00:07-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150926 01:00:34-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20150926 01:01:04-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150926 01:01:11-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20150926 01:01:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150926 01:11:37-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150926 01:11:53-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150926 01:11:54< irker110> wesnoth: gfgtdf wesnoth:1.12 b1b1b613616a / RELEASE_NOTES: Update RELEASE_NOTES http://git.io/vnxVU
20150926 01:11:57-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20150926 01:12:45-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150926 01:15:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20150926 01:17:28< irker110> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 00068c55b09b / src/actions/undo.cpp: backport sighted events fix http://git.io/vnxwc
20150926 01:20:59< irker110> wesnoth: gfgtdf wesnoth:gfgtdf-patch-2 7bdb417cf264 / src/synced_commands.cpp: ignore [allow_undo] in wml menu handlers since it casues OOS http://git.io/vnxwS
20150926 01:26:22< celticminstrel> Was it allowed before?
20150926 01:32:16-!- gfgtdf [~chatzilla@f054153148.adsl.alicedsl.de] has joined #wesnoth-dev
20150926 01:41:33-!- gfgtdf_ [~chatzilla@f054153127.adsl.alicedsl.de] has joined #wesnoth-dev
20150926 01:43:25-!- gfgtdf [~chatzilla@f054153148.adsl.alicedsl.de] has quit [Ping timeout: 246 seconds]
20150926 01:43:28-!- gfgtdf_ is now known as gfgtdf
20150926 01:44:39< irker110> wesnoth: gfgtdf wesnoth:1.12 7fc972abcd1f / RELEASE_NOTES: Update RELEASE_NOTES http://git.io/vnxox
20150926 01:45:23-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150926 01:46:03< celticminstrel> gfgtdf: Did you see my comments?
20150926 01:46:16< gfgtdf> celticminstrel: y
20150926 01:46:20< celticminstrel> 'kay.
20150926 01:48:18-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 265 seconds]
20150926 01:48:18-!- wedge010 is now known as wedge009
20150926 01:49:23-!- travis-ci [~travis-ci@ec2-54-166-56-118.compute-1.amazonaws.com] has joined #wesnoth-dev
20150926 01:49:24< travis-ci> wesnoth/wesnoth#7497 (gfgtdf-patch-2 - 7bdb417 : gfgtdf): The build passed.
20150926 01:49:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/82258362
20150926 01:49:24-!- travis-ci [~travis-ci@ec2-54-166-56-118.compute-1.amazonaws.com] has left #wesnoth-dev []
20150926 01:52:16< gfgtdf> do you mnow what the travis/pr and travis /push in on github poull requests mean ?
20150926 01:52:35< celticminstrel> Huh?
20150926 01:53:00< gfgtdf> celticminstrel: nevermind i think i found out
20150926 01:55:10< celticminstrel> I don't even know what you're referring to. :P
20150926 01:56:24< gfgtdf> celticminstrel: in this pr: https://github.com/wesnoth/wesnoth/pull/504 there are 2 travis test, the 'push' buidl and teh 'pr' build.
20150926 01:57:13< celticminstrel> Ah.
20150926 01:57:24< celticminstrel> I can guess what they mean, but not entirely certain.
20150926 01:57:25-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20150926 01:58:36< irker110> wesnoth: gfgtdf wesnoth:gfgtdf-patch-3 603bd834ddbd / src/actions/move.cpp: prepare to backport https://github.com/wesnoth/wesnoth/commit/db54a8dce543af9224 http://git.io/vnx6R
20150926 01:58:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150926 02:03:05< irker110> wesnoth: gfgtdf wesnoth:gfgtdf-patch-3 d9f96b4e3760 / src/actions/move.cpp: prepare to backport 'Fix capture event fired when undoing ' http://git.io/vnxiT
20150926 02:03:49< gfgtdf> sry for this spam i'm  trying to backport that commit using the github webpage.
20150926 02:05:46< gfgtdf> celticminstrel: you know whether its possible to have multiple declarations for teh same function some with defaults parmeters defined and some without ?
20150926 02:06:08< celticminstrel> Example?
20150926 02:07:08< gfgtdf> int aaaa(int a = 9 ); int aaaa(int a); int aaaa(int a) { return a; }
20150926 02:07:36< celticminstrel> Ah, yeah. In fact the defaults mustn't appear in more than one declaration.
20150926 02:08:17< gfgtdf> celticminstrel: so int aaaa(int a = 9 ); int aaaa(int a = 9); int aaaa(int a) { return a; } wouold be wrong ? :o
20150926 02:08:39< celticminstrel> Yeah,
20150926 02:09:39< iceiceice> gfgtdf: yeah CM is right
20150926 02:09:39< iceiceice> http://coliru.stacked-crooked.com/a/fb978d5d983ba183
20150926 02:10:02< iceiceice> but its ok without the second default
20150926 02:11:22< irker110> wesnoth: gfgtdf wesnoth:gfgtdf-patch-3 56992c24b8ba / src/actions/move.hpp: prepare to backport 'Fix capture event fired when undoing' http://git.io/vnxiM
20150926 02:12:41< irker110> wesnoth: gfgtdf wesnoth:gfgtdf-patch-3 1721711a33fd / src/actions/move.cpp: prepare to backport 'Fix capture event fired when undoing' http://git.io/vnxPe
20150926 02:14:51< irker110> wesnoth: gfgtdf wesnoth:gfgtdf-patch-3 72e62a6e37d4 / src/actions/undo.cpp: final step of backporting 'Fix capture event fired when undoing' http://git.io/vnxPI
20150926 02:17:30-!- travis-ci [~travis-ci@ec2-54-204-146-224.compute-1.amazonaws.com] has joined #wesnoth-dev
20150926 02:17:31< travis-ci> wesnoth/wesnoth#7500 (gfgtdf-patch-3 - 603bd83 : gfgtdf): The build passed.
20150926 02:17:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/82260226
20150926 02:17:31-!- travis-ci [~travis-ci@ec2-54-204-146-224.compute-1.amazonaws.com] has left #wesnoth-dev []
20150926 02:17:46-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Ping timeout: 240 seconds]
20150926 02:18:47-!- gfgtdf [~chatzilla@f054153127.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0/20150917150946]]
20150926 02:22:02-!- travis-ci [~travis-ci@ec2-54-160-172-219.compute-1.amazonaws.com] has joined #wesnoth-dev
20150926 02:22:03< travis-ci> wesnoth/wesnoth#7503 (gfgtdf-patch-3 - 56992c2 : gfgtdf): The build failed.
20150926 02:22:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/82260936
20150926 02:22:04-!- travis-ci [~travis-ci@ec2-54-160-172-219.compute-1.amazonaws.com] has left #wesnoth-dev []
20150926 02:22:36-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150926 02:24:27-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Excess Flood]
20150926 02:25:57-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150926 02:28:15-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Excess Flood]
20150926 02:29:28-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150926 02:30:51-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Excess Flood]
20150926 02:32:16-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150926 02:34:00-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 255 seconds]
20150926 02:36:19-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150926 02:37:28-!- travis-ci [~travis-ci@ec2-54-166-56-118.compute-1.amazonaws.com] has joined #wesnoth-dev
20150926 02:37:29< travis-ci> wesnoth/wesnoth#7502 (gfgtdf-patch-3 - d9f96b4 : gfgtdf): The build passed.
20150926 02:37:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/82260549
20150926 02:37:29-!- travis-ci [~travis-ci@ec2-54-166-56-118.compute-1.amazonaws.com] has left #wesnoth-dev []
20150926 02:38:16-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Excess Flood]
20150926 02:38:53-!- travis-ci [~travis-ci@ec2-54-166-56-118.compute-1.amazonaws.com] has joined #wesnoth-dev
20150926 02:38:54< travis-ci> wesnoth/wesnoth#7504 (gfgtdf-patch-3 - 1721711 : gfgtdf): The build passed.
20150926 02:38:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/82260979
20150926 02:38:55-!- travis-ci [~travis-ci@ec2-54-166-56-118.compute-1.amazonaws.com] has left #wesnoth-dev []
20150926 02:40:16-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150926 02:41:01-!- louis94 [~~louis94@109.133.201.27] has quit [Quit: Konversation terminated!]
20150926 02:41:36-!- travis-ci [~travis-ci@ec2-54-160-172-219.compute-1.amazonaws.com] has joined #wesnoth-dev
20150926 02:41:37< travis-ci> wesnoth/wesnoth#7505 (gfgtdf-patch-3 - 72e62a6 : gfgtdf): The build passed.
20150926 02:41:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/82261150
20150926 02:41:38-!- travis-ci [~travis-ci@ec2-54-160-172-219.compute-1.amazonaws.com] has left #wesnoth-dev []
20150926 02:42:07-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Excess Flood]
20150926 02:43:21-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150926 02:43:57-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Excess Flood]
20150926 02:53:26-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150926 02:59:46-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150926 03:04:39-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 240 seconds]
20150926 03:10:12-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150926 03:15:11-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 252 seconds]
20150926 03:22:01-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150926 03:25:30-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Excess Flood]
20150926 03:34:43-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150926 03:38:13< vultraz> celticminstrel: since you seen good at simplifying syntax, just throwing this out there since I'm considering working on it today... Instead of [campaign] difficulty= and difficulty_description=, a [difficulty] subtag with an id, description, and image keys
20150926 03:38:15-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Excess Flood]
20150926 03:38:20< vultraz> opinions?
20150926 03:39:36< celticminstrel> If you drop the image key, then [difficulty]description= and [option]description= have the exact same syntax. I think.
20150926 03:40:01< celticminstrel> I'm not quite sure where it's parsed, maybe [option]description= also supports the semicolons.
20150926 03:40:20< celticminstrel> (If it does, it probably shouldn't.)
20150926 03:40:28< vultraz> gui/auxiliary/old_markup.*pp
20150926 03:40:48 * celticminstrel wouldn't be surprised if difficulty_description= uses utils::split(blah, ';') and then uses the same parser.
20150926 03:41:37< vultraz> 		std::vector<std::string> difficulty_opts =
20150926 03:41:38< vultraz> 			utils::split(current_level().data()["difficulty_descriptions"], ';');
20150926 03:41:53< celticminstrel> right.
20150926 03:41:57< celticminstrel> ^R
20150926 03:42:56< vultraz> According to a comment in old_markup.hpp, that syntax was supposed to be rewritten anyway
20150926 03:42:58< vultraz> "	 * @todo This syntax looks like a bad hack, it would be nice to write
20150926 03:43:00< vultraz> 	 * a new syntax which doesn't use those hacks (also avoids the problem
20150926 03:43:01< vultraz> 	 * with special meanings for certain characters."
20150926 03:43:48< vultraz> I don't know if we can totally get rid of it
20150926 03:44:57< vultraz> Because of MENU_IMAGE_TXT and MENU_IMAGE_TXT2
20150926 03:45:08< celticminstrel> Okay, so.
20150926 03:45:09< vultraz> But I figure at least phasing it out for difficulties simplifies some stuff
20150926 03:45:16< celticminstrel> The full syntax seems to be:
20150926 03:45:57< celticminstrel> [ * ] [ & <image-path> = ] <first-column> [ = <second-column> ]
20150926 03:46:33-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150926 03:46:37< celticminstrel> As far as I can see, it only supports three columns at most, and if you have three then the leftmost must be an image.
20150926 03:47:18< celticminstrel> Is it used anywhere else besides in difficulty_description= and [option]description= ?
20150926 03:48:20 * celticminstrel git grep tlegacy_menu_item
20150926 03:48:23< vultraz> MENU_IMG_TXT
20150926 03:48:26< vultraz> MENU_IMG_TXT2
20150926 03:48:41< celticminstrel> But those macros can also be deprecated.
20150926 03:48:57< vultraz> They're heavily used in UMC
20150926 03:48:59< vultraz> Sadly
20150926 03:49:05< vultraz> But we could always provide an alternative
20150926 03:49:38< celticminstrel> game_initialization/multiplayer_lobby.cpp:549, gui/dialogs/campaign_difficulty.cpp:73, gui/dialogs/campaign_difficulty.hpp:45, gui/dialogs/wml_message.cpp:109
20150926 03:49:45< celticminstrel> So ... one other place?
20150926 03:49:47< vultraz> They're used in [message], BTW
20150926 03:50:02-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Excess Flood]
20150926 03:50:36< vultraz> And, well, the difficulty descriptions
20150926 03:50:41< celticminstrel> Yes, [message][option]description=
20150926 03:51:28< celticminstrel> Oh yeah, if we want to remove it then we'll have to update the Lua API - helper.get_user_choice and wesnoth.show_message_dialog.
20150926 03:51:46< vultraz> I'd leave that part to you :P
20150926 03:52:11< vultraz> But the question foremost is what to replace it with
20150926 03:52:23< celticminstrel> Well, I think mostly it would just mean changing documentation.
20150926 03:52:24< vultraz> I figured, for difficulties, just a [difficulty] tag
20150926 03:53:06< celticminstrel> Ah, looks like the multiplayer_lobby reference is also related to difficulty_descriptions=
20150926 03:53:18< celticminstrel> So really, just the two places.
20150926 03:53:21< vultraz> The only complication is handling the three columns.
20150926 03:53:49< vultraz> I mean, you could have an image= description= and description2= key or something, but that's hacky
20150926 03:54:06< vultraz> Hm
20150926 03:54:08< vultraz> Actually
20150926 03:54:10< celticminstrel> You could have image= followed by two [column] tags or something similar.
20150926 03:54:19< celticminstrel> Or, any series of [image] and [text] tags.
20150926 03:54:37< vultraz> You could just have a single string with pango markup in a macro 
20150926 03:55:01< celticminstrel> Huh?
20150926 03:55:28< vultraz> Wait, nvm
20150926 03:55:35< vultraz> Ignore that
20150926 03:55:42< celticminstrel> Okay sure.
20150926 03:55:57< vultraz> Ok, I have an idea
20150926 03:56:22< vultraz> id=NORMAL, image=foo.png, description= _ "Foo"
20150926 03:56:35< vultraz> the id becomes the preprocessor symbol
20150926 03:56:45< vultraz> then you have the three columns
20150926 03:56:52< celticminstrel> Uh.
20150926 03:57:02< celticminstrel> That's only two columns.
20150926 03:57:06< celticminstrel> Isn't it?
20150926 03:57:26< vultraz> the image, the description, and then in parentheses, the id name shown in lowercase (first character capitalized, ofc)
20150926 03:58:13< celticminstrel> You need to be able to separately specify the preprocessor symbol and the prettified display name for it.
20150926 03:58:25< celticminstrel> Because the latter is translatable and the former is not.
20150926 03:58:32< vultraz> Damn
20150926 03:59:25< vultraz> I guess then it would have to be symbol, name, image, and description 
20150926 03:59:30< celticminstrel> Is "series of [image] and [text]" too generic? Maybe "image= followed by one or more [text]"?
20150926 04:00:00< celticminstrel> You're only thinking in terms of the difficulty; it'd be good to still have the same syntax for [message][option].
20150926 04:00:14< vultraz> What about text="",""
20150926 04:00:43< vultraz> First value col 1 (or 2 if there's an image), second value col 2/3
20150926 04:00:50< celticminstrel> Hmm. Not sure if that can work well when translatable strings are involved.
20150926 04:01:19< vultraz> why not?
20150926 04:01:41< celticminstrel> I'm not sure _"",_"" is legal WML syntax.
20150926 04:02:17< celticminstrel> tlegacy_menu_item calls them "label" and "description", we could just go with that?
20150926 04:02:35< celticminstrel> Or like I said we could make something more general that can support more columns.
20150926 04:02:37< vultraz> two keys?
20150926 04:02:41< celticminstrel> Yeah.
20150926 04:02:45-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150926 04:02:47< vultraz> well, three
20150926 04:02:48< celticminstrel> I'm not sure there's a need for more columns though.
20150926 04:02:50< vultraz> since we need image
20150926 04:02:55< celticminstrel> Yes.
20150926 04:03:15< vultraz> the reason for two columns is so that the values of the two line up with each other for consistent spacing
20150926 04:03:17< vultraz> ie
20150926 04:03:20< vultraz> foo     foo
20150926 04:03:27< celticminstrel> Yeah, I know.
20150926 04:03:30< vultraz> barrr   bar
20150926 04:03:36< celticminstrel> But why two columns and not three?
20150926 04:03:53< vultraz> It is three if you have the image
20150926 04:04:14< celticminstrel> ^text columns
20150926 04:04:24< vultraz> Dunno
20150926 04:04:53< vultraz> Guess 2 is a pretty good catch-all number
20150926 04:05:00< celticminstrel> If all we want is a cleaner syntax with the exact same functionality, then [difficulty] with define= image= label= description= should work fine.
20150926 04:05:21< celticminstrel> (And [option] would likewise support image= label= in addition to description= )
20150926 04:05:45< celticminstrel> Where is tlegacy_menu_item actually used?
20150926 04:05:55< celticminstrel> Oh wait, right.
20150926 04:07:22< vultraz> If we support x number of columns, it gets harder to make sure they'll fit in the window
20150926 04:07:45< celticminstrel> Looks like the campaign difficulty dialog is specifically set up with three columns.
20150926 04:07:50< vultraz> Yes
20150926 04:08:05< celticminstrel> Guessing WML message is the same way.
20150926 04:08:44< vultraz> Then we can stick with 3
20150926 04:09:15< vultraz> We could also just rewrite MENU_IMG_TXT with the new keys if we want
20150926 04:09:26< celticminstrel> Yeah, probably easiest to stick with three.
20150926 04:09:33< celticminstrel> How is MENU_IMG_TXT used, again?
20150926 04:10:26< vultraz> {MENU_IMG_TXT image.png _"bar")}
20150926 04:10:50-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 240 seconds]
20150926 04:10:52< celticminstrel> But really it's description={MENU_IMG_TXT image.png _"bar"} isn't it?
20150926 04:10:53< vultraz> the other is {MENU_IMG_TXT2 image.png _"bar" _"bat")}
20150926 04:11:00< vultraz> well yes
20150926 04:11:05< celticminstrel> So we can't rewrite them.
20150926 04:11:11< vultraz> Damn :/
20150926 04:11:19< vultraz> New macro it is, then
20150926 04:11:19< celticminstrel> ...I think...
20150926 04:11:49< celticminstrel> Yeah, new macro is probably better. Though I dunno if it would even be needed.
20150926 04:12:24< celticminstrel> Okay, so...
20150926 04:13:01< celticminstrel> It would be [difficulty] with the following tags: default,define,image,label,description?
20150926 04:13:13< celticminstrel> And same for [option] except excluding define=
20150926 04:13:27-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150926 04:13:52< vultraz> yea
20150926 04:14:54< celticminstrel> You going to do it?
20150926 04:17:40-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Read error: Connection reset by peer]
20150926 04:18:12< vultraz> Hopefully
20150926 04:20:30< vultraz> My C++ is very very mediocre :P
20150926 04:20:34< vultraz> So I might request help
20150926 04:20:42< celticminstrel> Alright.
20150926 04:28:30< vultraz> Ok, so this is what it would look like in usage, using HtTT http://pastebin.com/0rWyrx6V
20150926 04:28:45-!- Kwandulin [~Miranda@p5B0092B1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150926 04:29:58< vultraz> Any difficulty tags without define will throw an error
20150926 04:31:03 * vultraz looks for the c++ equivalent of helper.child_range
20150926 04:31:12< celticminstrel> It's cfg.child_range
20150926 04:31:27< celticminstrel> Conveniently named the same. :P 
20150926 04:31:46< celticminstrel> Yeah, that example looks good to me.
20150926 04:42:45< celticminstrel> Might want to shunt description into label if label is empty.
20150926 04:42:59< celticminstrel> Well. That's assuming you use the same tlegacy_menu_item structure though.
20150926 04:43:20< celticminstrel> On the other hand, maybe that's not a good idea.
20150926 04:43:23< vultraz> I was not going to use that class
20150926 04:43:43< celticminstrel> I suppose you could have several options where some have label and others have description. It would be weird, but...
20150926 04:44:09< vultraz> Instead, parse the difficulty tags in the difficulty dialog
20150926 04:44:24< celticminstrel> Don't forget the wml_message dialog.
20150926 04:44:41< vultraz> If I can figure out how to pass the config to the dialog
20150926 04:44:58< vultraz> Classes be confusing, yo
20150926 04:46:01-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 244 seconds]
20150926 04:46:04< celticminstrel> Maybe make it take and store a vector of configs rather than a vector of strings? I dunno/
20150926 04:46:18< celticminstrel> Getting a vector of configs is a little hard, I think.
20150926 04:46:45< vultraz> Uh...
20150926 04:47:11< vultraz> I just need to pass the [campaign] config to the ... dialog
20150926 04:47:34< celticminstrel> Why not pass the child_range instead? Since that's all it needs to know about.
20150926 04:48:15< vultraz> Create a vector(?) with child_range and pass it?
20150926 04:49:08< celticminstrel> No, just pass it as is; you'll probably be using BOOST_FOREACH on it anyway, right?
20150926 04:49:33< vultraz> Er
20150926 04:49:34< vultraz> Yes
20150926 04:50:34< vultraz> I can set the dialog values in the loop, yes
20150926 04:51:03< vultraz> But it's a  totally different class
20150926 04:51:09< vultraz> Right now it's called from create_engine::select_campaign_difficulty
20150926 04:53:01< vultraz> I guess you mean create an object from the tcampaign_difficulty class
20150926 04:53:12< celticminstrel> Isn't it already doing that?
20150926 04:53:16< vultraz> and then pass....stuff to that in the...loop?
20150926 04:53:18< vultraz> yes
20150926 04:53:20< vultraz> it is
20150926 04:53:29< vultraz> But after it assembles the values
20150926 04:53:37< vultraz> 		gui2::tcampaign_difficulty dlg(difficulty_options);
20150926 04:53:46< celticminstrel> Line number?
20150926 04:54:14< vultraz> function is at game_initialization/create_engine.cpp:584
20150926 04:55:08-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20150926 04:57:09< celticminstrel> Ah.
20150926 04:57:42< vultraz> which is why I said aren't we supposed to create a vector/table and then pass it to the object?
20150926 04:58:47< vultraz> except
20150926 04:58:56< celticminstrel> What that's doing is determining whether you've completed the campaign at each individual difficulty level and passing that information in along with the list of menuitems.
20150926 04:59:01< vultraz> how do you create a vector from a group of tags
20150926 04:59:35< celticminstrel> BOOST_FOREACH
20150926 04:59:40< celticminstrel> But.
20150926 04:59:46 * vultraz so confused
20150926 05:00:40< celticminstrel> The contents of that vector is eg {{"&img=label=desc", false}, {"*&img=label=desc", true}, {"&img=label=desc"}}
20150926 05:01:25< celticminstrel> So no matter how you go about it you probably need a new constructor in tcampaign_difficulty.
20150926 05:01:44< vultraz> Ok, so uhhhh...
20150926 05:01:52< vultraz> What would that be
20150926 05:01:54< vultraz> :|
20150926 05:02:13< vultraz> I mean what would be in the constructor
20150926 05:02:21< vultraz> I know what a constructor is
20150926 05:03:21< celticminstrel> Well, you'd need to pass in two bits of information - the tag iterator pair (from child_range), and a list of bools (indicating whether the campaign was completed at each difficulty). The latter involves iterating over the former.
20150926 05:03:40< celticminstrel> Because it'll need to get the define= key from each one, I think.
20150926 05:05:10< vultraz> tag iterator pair?
20150926 05:05:24< celticminstrel> Implementation detail. It's what you get back from child_range.
20150926 05:05:35< vultraz> Oh, I see
20150926 05:06:36< vultraz> I thought child range was an iterator though
20150926 05:07:38< celticminstrel> It's a pair of iterators.
20150926 05:07:58< celticminstrel> One pointing to the first tag, and one pointing to the last tag. (Well, one after the last, but close enough.)
20150926 05:10:29< celticminstrel> The second is needed so the iteration knows when to stop.
20150926 05:11:05< vultraz> But how do you pass that to the constructor of tcampaign_difficulty
20150926 05:11:43< celticminstrel> You look up the definition of child_range and copy its return type?
20150926 05:11:52< celticminstrel> And define a new constructor taking that type.
20150926 05:12:13< celticminstrel> I think it might be const_child_itors, but not sure. That might be for all children rather than children of a specific tag.
20150926 05:12:36< vultraz> return child_itors(child_iterator(p->begin()), child_iterator(p->end()));
20150926 05:13:14< celticminstrel> Return type, not return statement/
20150926 05:13:22< celticminstrel> Just before the name child_range.
20150926 05:13:30< celticminstrel> But it's probably child_itors.
20150926 05:20:51-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150926 05:21:17< vultraz> Oh, yes
20150926 05:21:38-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20150926 05:22:44< celticminstrel> 'lo mattsc 
20150926 05:23:18-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150926 05:23:23< mattsc> celticminstrel: hi, I’m hust here for a couple minutes.
20150926 05:23:46< mattsc> I tested your Xcode PR and the unused typedef warnings are back, unfortunately
20150926 05:24:08< celticminstrel> Hmm, okay.
20150926 05:24:37< mattsc> Also, on the u:erase, personally I don’t really care much one way or the other as long as the method with put_unit still works.
20150926 05:24:41< celticminstrel> Can you give me one example location?
20150926 05:24:54< celticminstrel> For an unused typedef warning.
20150926 05:26:25< mattsc> This is the first one:  http://pastebin.com/ufZ9LByU
20150926 05:27:22< celticminstrel> Ahhh, okay. I guess it's not a case of not being system headers after all.
20150926 05:28:11-!- Anonymous__ [7ab32022@gateway/web/freenode/ip.122.179.32.34] has joined #wesnoth-dev
20150926 05:28:15< celticminstrel> I guess I'll put back the -Wno-unused-local-typedef.
20150926 05:28:30< celticminstrel> I also got the unit tests to mostly build, maybe I'll push that into the same PR.
20150926 05:28:32< mattsc> celticminstrel: I have to go again, just wanted to say that quickly.  I might be able to come online once more in about 12 hours, after that, I’ll probably not be here for the next two weeks (although I might be able to check the logs occasionally, not sure yet)
20150926 05:28:39 * celticminstrel nods.
20150926 05:29:27< mattsc> TTYL, sorry for not being available for this more, but then, there’s not really a hurry, I guess.
20150926 05:29:36< celticminstrel> Yeah, no hurry.
20150926 05:29:46< mattsc> Okay, good.
20150926 05:29:54< mattsc> Thanks for trying to figure it out!
20150926 05:30:04< mattsc> Bye for now.
20150926 05:30:14< celticminstrel> Updating Boost might fix it, I dunno. Bye.
20150926 05:30:31< mattsc> Might; but I really can’t do that now.  :)
20150926 05:30:38< celticminstrel> Yeah.
20150926 05:30:45< mattsc> Cheers.
20150926 05:30:49< celticminstrel> Bye.
20150926 05:30:53-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20150926 05:31:11-!- Anonymous__ [7ab32022@gateway/web/freenode/ip.122.179.32.34] has quit [Client Quit]
20150926 05:36:56-!- oldlaptop [~quassel@50.36.238.180] has quit [Ping timeout: 240 seconds]
20150926 05:56:19< vultraz> celticminstrel: could I maybe insert completed status into the difficulty config?
20150926 05:56:38< vultraz> so internally thee config would have a completed = true key?
20150926 05:56:51< vultraz> and I wouldn't have to pass a table with the completed status?
20150926 05:57:10< celticminstrel> That's not the way I would do it, but it would work.
20150926 05:57:51< celticminstrel> It's not like completed= needs to mean anything special already in [difficulty], now or in the future.
20150926 06:01:45-!- [Relic] [~Relic]@2602:306:33a3:6d30:dd3b:55c8:506e:5e08] has quit [Quit: I press the magic X and all the weirdos go away!]
20150926 06:03:45< vultraz> I don't understand tables in C++, which is why I'd like to avoid them :P
20150926 06:08:07< celticminstrel> "tables"
20150926 06:08:17< celticminstrel> There's no such thing. :P
20150926 06:10:23< vultraz> ;_;
20150926 06:10:25< vultraz> vectors?
20150926 06:10:28< vultraz> arrays?
20150926 06:10:32< vultraz> lists?
20150926 06:10:55< vultraz> I mean
20150926 06:11:07< vultraz> by your method, it seems to me thay you would need a *thing* like..
20150926 06:11:17< vultraz> completed[i] true
20150926 06:11:20< vultraz> or...
20150926 06:11:27< vultraz> completed = { true true false }
20150926 06:11:40< vultraz> where [i] is the index of the difficulty tag
20150926 06:11:44< vultraz> or am I thinking too lua here
20150926 06:12:54< celticminstrel> That was one of the ways I was thinking about.
20150926 06:13:46< vultraz> what it seems to now is make_pair (whatever that does) with each dofficulty
20150926 06:14:07< vultraz> I guess that's to populate std::vector<std::pair<tlegacy_menu_item, bool> > items_;
20150926 06:14:31< celticminstrel> In Lua that'd be kinda like table.insert(difficulty_options, {option_string, is_completed})
20150926 06:14:55< celticminstrel> make_pair creates an object that's basically a list of two items.
20150926 06:15:14< celticminstrel> (Well, in Lua I guess you'd better describe it as {first = option_string, second = is_completed})
20150926 06:15:30< celticminstrel> A list of two items of possibly different types.
20150926 06:16:19< celticminstrel> (Whereas std::vector and similar are homogeneous containers.)
20150926 06:21:11-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150926 06:27:30< vultraz> but you can't do that if you're passing an iterator 
20150926 06:27:35< vultraz> since an iterator is a pair
20150926 06:27:50< celticminstrel> No, an iterator is not a pair, you're just passing a pair of iterators.
20150926 06:28:26< celticminstrel> A pair of iterators which together form a range.
20150926 06:37:54< vultraz> so could you use make_pair with an itor at the first... thing?
20150926 06:40:51< vultraz> hm.. actually
20150926 06:41:24< vultraz> celticminstrel: what about not passing an array/whatever at all, and simply pasing the iterator, and then checking for completion inside the loop in tcampaign_difficulty::preshow()?
20150926 06:41:27< celticminstrel> You can use make_pair with any two things you want, including another pair.
20150926 06:41:50< celticminstrel> You could do that. It might men another include in the tcampaign_difficulty file.
20150926 06:41:53< celticminstrel> ^mean
20150926 06:43:54< vultraz> Ok
20150926 06:47:19-!- genbattle [~genbattle@122-57-91-5.jetstream.xtra.co.nz] has quit [Ping timeout: 240 seconds]
20150926 06:51:49-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150926 06:58:29-!- celticminstrel is now known as celmin|sleep
20150926 06:58:47 * celmin|sleep also just submitted the Lua vconfig PR as well.
20150926 08:31:42-!- Kwandulin [~Miranda@p5B0092B1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150926 09:20:59-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150926 09:30:21-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20150926 09:53:09-!- irker110 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150926 10:00:04-!- Kwandulin [~Miranda@p5B0092B1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150926 10:16:06-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20150926 10:18:59< aquileia> wedge009: Excluding akihara/recruitment.cpp, default/ai.cpp, composite/ai.cpp, formula/ai.cpp gets VC9 to compile (of course it can't link the executable without them)
20150926 10:20:09< aquileia> So my guess is that the actual issue is how the contents of contexts.cpp are used in these files
20150926 10:27:38< aquileia> Yep, it's the "rca_context &context" in recruitment::recruitment
20150926 10:31:09 * vultraz is really confused on how to pass an iterator
20150926 10:45:29< vultraz> const child_itors difficulties;
20150926 10:45:36< vultraz> in the constructor
20150926 10:45:41< vultraz> so then... I could...
20150926 10:45:49< vultraz> BOOST_FOREACH(const config &d, difficulties)
20150926 10:45:55< vultraz> >
20150926 10:45:56< vultraz> ?
20150926 10:55:40-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Quit: Page closed]
20150926 11:52:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150926 12:13:46-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 246 seconds]
20150926 12:23:18-!- gfgtdf [~chatzilla@f054153127.adsl.alicedsl.de] has joined #wesnoth-dev
20150926 12:30:23-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20150926 12:33:57-!- irker760 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150926 12:33:57< irker760> wesnoth: gfgtdf wesnoth:1.12 00068c55b09b / src/actions/undo.cpp: backport sighted events fix http://git.io/vnxwc
20150926 12:33:57< irker760> wesnoth: gfgtdf wesnoth:1.12 bab936449d61 / src/actions/undo.cpp: Merge pull request #504 from wesnoth/gfgtdf-patch-1 http://git.io/vnpHn
20150926 12:34:00< irker760> wesnoth: gfgtdf wesnoth:1.12 7bdb417cf264 / src/synced_commands.cpp: ignore [allow_undo] in wml menu handlers since it casues OOS http://git.io/vnxwS
20150926 12:34:02< irker760> wesnoth: gfgtdf wesnoth:1.12 1685d6ed6759 / src/synced_commands.cpp: Merge pull request #505 from wesnoth/gfgtdf-patch-2 http://git.io/vnpH4
20150926 12:34:53-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150926 12:35:55< gfgtdf> is someone currently working on 1.12.x brtanch ?
20150926 12:40:26< vultraz> not me
20150926 12:58:37-!- louis94 [~~louis94@109.133.201.27] has joined #wesnoth-dev
20150926 13:01:12-!- Kwandulin [~Miranda@p5B0092B1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150926 13:08:07-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150926 13:08:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150926 13:58:31-!- Kwandulin [~Miranda@p5B0092B1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150926 14:25:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150926 15:05:38-!- travis-ci [~travis-ci@ec2-54-147-182-221.compute-1.amazonaws.com] has joined #wesnoth-dev
20150926 15:05:39< travis-ci> wesnoth/wesnoth#7509 (1.12 - 1685d6e : gfgtdf): The build has errored.
20150926 15:05:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/82296265
20150926 15:05:39-!- travis-ci [~travis-ci@ec2-54-147-182-221.compute-1.amazonaws.com] has left #wesnoth-dev []
20150926 15:25:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150926 15:32:17-!- [Relic] [~Relic]@2602:306:33a3:6d30:51d9:ff9d:2e19:b2ba] has joined #wesnoth-dev
20150926 15:34:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150926 15:34:08-!- irker760 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150926 15:40:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150926 15:44:06-!- Kwandulin [~Miranda@p5B0092B1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150926 15:48:04-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150926 15:48:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20150926 15:48:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150926 15:52:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150926 15:53:01-!- oldlaptop [~quassel@50.36.238.180] has joined #wesnoth-dev
20150926 16:01:35-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150926 16:01:53-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150926 16:02:23< celmin|sleep> That's right vultraz.
20150926 16:14:37-!- alalazo [d537b084@gateway/web/freenode/ip.213.55.176.132] has joined #wesnoth-dev
20150926 16:20:07-!- Kwandulin [~Miranda@p5B0092B1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150926 16:24:50-!- Appleman1234 [~Appleman1@KD111239000197.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20150926 16:28:28< wedge009> aquileia: I don't know what's happened, but my guess is the contexts.hpp inclusion is interacting with something that's changed in the last month or so in one of those files that it's been included in.
20150926 16:39:06-!- alalazo [d537b084@gateway/web/freenode/ip.213.55.176.132] has quit [Ping timeout: 246 seconds]
20150926 16:41:16-!- [Relic] [~Relic]@2602:306:33a3:6d30:51d9:ff9d:2e19:b2ba] has quit [Quit: I press the magic X and all the weirdos go away!]
20150926 16:44:36-!- [Relic] [~Relic]@2602:306:33a3:6d30:a94c:2a72:12c0:4577] has joined #wesnoth-dev
20150926 16:53:24-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150926 16:54:09< wedge009> aquileia: Compiling the master in VC9 seems problematic (for other reasons) as well. I was hoping to find a state where VC9 does compile and try to make a comparison. Do many people still use VC9?
20150926 16:55:07 * celmin|sleep hopes that not many people do.
20150926 17:02:01-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 246 seconds]
20150926 17:06:01-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 246 seconds]
20150926 17:15:53-!- iceiceice [~chris@c-73-197-174-173.hsd1.nj.comcast.net] has joined #wesnoth-dev
20150926 17:15:53-!- iceiceice [~chris@c-73-197-174-173.hsd1.nj.comcast.net] has quit [Changing host]
20150926 17:15:53-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150926 17:22:37-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Quit: No Ping reply in 180 seconds.]
20150926 17:24:01-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150926 17:28:38-!- louis94 [~~louis94@109.133.201.27] has quit [Ping timeout: 240 seconds]
20150926 17:30:32-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20150926 17:30:47-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 264 seconds]
20150926 17:31:36 * aquileia wonders whether shikadibot has something akin to 'seen', but for being mentioned
20150926 17:34:28< aquileia> wedge009: master builds fine on VC9 (apart from two warnings), so it has to be a SDL interaction - I actually wonder whether SDL might redefine some std types or something like that
20150926 17:36:46-!- Appleman1234 [~Appleman1@KD111239000197.au-net.ne.jp] has joined #wesnoth-dev
20150926 17:37:12< gfgtdf> aquileia: what are teh problems on vc9 ?
20150926 17:37:12< aquileia> AFAIK anonymissimus is our only VC9 user, I don't know how active he is these days (I took over maintaining vcproj and external from him)
20150926 17:39:05< aquileia> ai/akihara/recruitment.cpp (and the ai.cpp files) uses contexts.cpp, but SDL2 somehow injects syntax that isn't compatible
20150926 17:40:27< gfgtdf> aquileia: you get an errormessage when cpompiling ?
20150926 17:41:58< aquileia> compiling contexts.cpp itself doesn't yield any errors, but as soon as you try to pass 'current_team' or an 'rca_context' is errors
20150926 17:42:33< aquileia> I have a few hundred error messages because it can't recover from the syntax issues...
20150926 17:42:49< gfgtdf> aquileia: this is on the sdl3 branch only ?
20150926 17:42:58< aquileia> Yes, sdl2 only
20150926 17:43:15< celmin|sleep> SDL3? gfgtdf, are you from the future? :P
20150926 17:43:27-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20150926 17:43:27-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20150926 17:43:27-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150926 17:43:28-!- celmin|sleep is now known as celticminstrel
20150926 17:43:29< gfgtdf> sry, i mistyped
20150926 17:44:18< aquileia> gfgtdf: http://pastebin.com/LUx5k32W
20150926 17:46:26< gfgtdf> aquileia: and this doesnt happen on later msvc versions ?
20150926 17:46:48< aquileia> It definitely doesn't happen on VC12 or VC14
20150926 17:48:24< gfgtdf> aquileia: maybe SDL redefined TYPE somehow ? My try woudl be to put a #undef TYPE at the top of the ai/default/contexts.hpp file
20150926 17:50:46 * celticminstrel takes a look.
20150926 17:52:55< gfgtdf> aquileia: my next try woudl be putting #undef EXPLICIT at the top of that file
20150926 17:53:05< celticminstrel> Hmm.
20150926 17:54:14< gfgtdf> aquileia: or even betteR: outting an undef for all those enum values
20150926 17:54:29< gfgtdf> aquileia: can you please try that ?
20150926 17:54:49< gfgtdf> (compiling the recruitment.cpp file)
20150926 17:54:55< aquileia> I'm at it
20150926 17:55:02< celticminstrel> Grepping SDL2 headers does not appear to yield any instances of TYPE or EXPLICIT.
20150926 17:56:04< gfgtdf> celticminstrel: hmm but it also possible that sdl headers include some windows header which define those macros
20150926 17:57:06< celticminstrel> Ah, true.
20150926 17:57:08< aquileia> gfgtdf: I think you fixed it... recruitment.cpp itself compiles now. I'll build the entire solution to be sure
20150926 17:57:39< celticminstrel> Windows.h defines a lot of unprefixed macros.
20150926 17:57:52< wedge009> aquileia: Yes, I just realised I was still using SDL2 to build. It's nonsensical, but does sdl2 branch build okay with SDL1.2?
20150926 17:58:55< aquileia> wedge009: I don't know, but it's definitely worth testing before we merge - do you want to do that?
20150926 17:59:45< aquileia> gfgtdf: It even passes the WML tests, so the binary runs correctly! Thanks!
20150926 18:00:48-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Quit: No Ping reply in 180 seconds.]
20150926 18:00:58< aquileia> And the culprit: dvec.h @ l.50    #define EXPLICIT explicit
20150926 18:01:18< wedge009> aquileia: Not really. :p But I have it running now.
20150926 18:01:43< wedge009> Just for the record, I'm not usually functional at this hour. It's 4 am for me but I fell asleep at 6 pm last night.
20150926 18:02:12-!- fabi [~quassel@176.6.71.229] has joined #wesnoth-dev
20150926 18:02:12-!- fabi [~quassel@176.6.71.229] has quit [Changing host]
20150926 18:02:12-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150926 18:10:01-!- irker377 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150926 18:10:01< irker377> wesnoth: gfgtdf wesnoth:1.12 263f6668d247 / RELEASE_NOTES: Update RELEASE_NOTES http://git.io/vnhFK
20150926 18:11:30-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Quit: No Ping reply in 180 seconds.]
20150926 18:12:57-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150926 18:19:06-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Read error: Connection reset by peer]
20150926 18:19:28-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20150926 18:19:28-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20150926 18:19:28-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150926 18:19:41-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Read error: Connection reset by peer]
20150926 18:19:59-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20150926 18:19:59-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20150926 18:19:59-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150926 18:27:14-!- Kwandulin [~Miranda@p5B0092B1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150926 18:29:55-!- travis-ci [~travis-ci@ec2-54-159-2-160.compute-1.amazonaws.com] has joined #wesnoth-dev
20150926 18:29:56< travis-ci> wesnoth/wesnoth#7511 (1.12 - 263f666 : gfgtdf): The build passed.
20150926 18:29:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/82326012
20150926 18:29:56-!- travis-ci [~travis-ci@ec2-54-159-2-160.compute-1.amazonaws.com] has left #wesnoth-dev []
20150926 18:30:15-!- louis94 [~~louis94@109.133.201.27] has joined #wesnoth-dev
20150926 19:07:40-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Quit: No Ping reply in 180 seconds.]
20150926 19:09:06-!- fabi [~quassel@176.6.71.229] has joined #wesnoth-dev
20150926 19:09:06-!- fabi [~quassel@176.6.71.229] has quit [Changing host]
20150926 19:09:06-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150926 19:13:26-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150926 19:16:34-!- _laco [~laco@static.95.25.4.46.clients.your-server.de] has quit [Remote host closed the connection]
20150926 19:16:54< aquileia> wedge009: BTW, if you have multiple MSVC versions installed as well - if you click the VC9 wesnoth.sln file, with which version does it open it? For me the 'Version Selector' chooses VC12 although VC9 is installed. I read that's related to the UTF-8 BOM, and our project files are in fact mixed - some have a BOM, others don't
20150926 19:23:12< wedge009> aquileia: I manually open it with VC9. The git copy of the solution file opens with VC14 by default. My locally modified copy opens with VC9 by default. I have seen the Version Selector before with other projects. I have VC7.1, 9, and 14 installed.
20150926 19:26:31< aquileia> OK, thanks. I'll try to get the version in the repo to open correctly by saving manually, then. One of the changes I did with a text editor seems to conflict with version recognition, then.
20150926 19:31:16< wedge009> If it makes any difference, I'm using VC9 Express.
20150926 19:33:05-!- louis94 [~~louis94@109.133.201.27] has quit [Ping timeout: 256 seconds]
20150926 19:33:10< wedge009> aquileia: The VC9 full rebuild of the sdl2 branch using SDL1.2 is incredibly slow, but it does appear to be going okay. It seems SDL2 was interacting with compilation in a strange way indeed.
20150926 19:36:42< wedge009> aquileia, Aginor: Oh, it just finished. It doesn't have the contexts.hpp error any more, but it still fails - I forgot that the hot-key rewrite depends on a bit of code from SDL2.
20150926 19:37:04< aquileia> wedge009: Using the express version as well. Had to delete the 'registration' registry subkey and remove all write permissions to it though as the registration link was broken
20150926 19:37:43< wedge009> aquileia, Aginor: It still demonstrates that there's something VC9 doesn't like about SDL2. I suppose it's not a big deal (unless you're a VC9 user) since there are other compilers that can handle SDL2 okay.
20150926 19:38:12-!- Appleman1234 [~Appleman1@KD111239000197.au-net.ne.jp] has quit [Ping timeout: 255 seconds]
20150926 19:39:50< aquileia> wedge009: VC9 now compiles master with SDL 1.2 and sdl2 with SDL 2 for me (I didn't push the fix for the sdl2 branch yet, though)
20150926 19:42:52< wedge009> aquileia: What did you do to get sdl2 branch to compile with SDL2?
20150926 19:43:07< celticminstrel> The #undefs, right?
20150926 19:43:26< celticminstrel> #undef TYPE and/or #undef EXPLICIT
20150926 19:43:32< celticminstrel> I think it was more the latter?
20150926 19:43:37< aquileia> #if _MSC_VER < 1600 #undef EXPLICIT
20150926 19:44:22< celticminstrel> You could use #ifdef EXPLICIT instead.
20150926 19:44:23< aquileia> inside the existing #ifdef _MSC_VER of course (undefined = 0)
20150926 19:45:10< wedge009> Ah, no wonder.
20150926 19:45:33< wedge009> I'll leave it for you to sort out, then, and take it off my 'to do' list. (:
20150926 19:45:40< aquileia> Well, _MSC_VER indicates that that code can be deprecated when we stop supporting that version
20150926 19:47:04< aquileia> wedge009: Have the commit ready already, just trying to fix the 'Version Selection' issue on master first so that the commits can't conflict later on
20150926 19:47:53< wedge009> aquileia: As you said, that might be specific to the local PC. Registry entries, etc.
20150926 19:55:27< aquileia> You're kidding me... wedge009, if I replace the comment "# Visual Studio 2008" (second line) with "# Visual C++ Express 2008" it opens...
20150926 20:01:12< wedge009> aquileia: Yeah, that seems to be the same change I had... o.O
20150926 20:01:32< wedge009> Wasn't sure if there was something more to it.
20150926 20:02:03< wedge009> Probably triggers something internal to Microsoft's version selection.
20150926 20:02:38< aquileia> VC9 itself also added an empty line at the start + the UTF-8 BOM, but these aren't necessary (and seem to conflict with VC10, according to a post I read)
20150926 20:03:04-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150926 20:03:30< aquileia> I'll replace that comment and unify the BOMs
20150926 20:14:38-!- louis94 [~~louis94@109.133.201.27] has joined #wesnoth-dev
20150926 20:15:34-!- fendrin [~quassel@176.6.3.35] has joined #wesnoth-dev
20150926 20:15:34-!- fendrin [~quassel@176.6.3.35] has quit [Changing host]
20150926 20:15:34-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150926 20:17:35-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 264 seconds]
20150926 20:21:52-!- Nobun [~nobun@5.170.84.104] has joined #wesnoth-dev
20150926 20:25:59-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20150926 20:32:10< Elvish_Hunter> Hi
20150926 20:32:22< Elvish_Hunter> 20150926 04:01:41< celticminstrel> I'm not sure _"",_"" is legal WML syntax.
20150926 20:32:45< Elvish_Hunter> It's legal, but wmlxgettext can't handle it.
20150926 20:33:25< celticminstrel> Are you sure? I thought it would have to be _"" + "," + _""
20150926 20:34:12< celticminstrel> Regardless, I think the method vultraz and I ended up with is better than a comma-separated list.
20150926 20:35:36< Elvish_Hunter> Yeah, the [difficulty] tag looks good. For me, the main problem will be coming up with a decent wmllint rule, though.
20150926 20:37:51< celticminstrel> ...I can imagine. It might be impossible to do automated conversion for all possible cases (MENU_IMG_TXT, literal version, custom macros, ...)
20150926 20:45:19 * vultraz is still trying to code it
20150926 20:45:27< vultraz> it keeps saying I'm giving the constructor an int
20150926 20:45:29< vultraz> :|
20150926 20:47:13< celticminstrel> Maybe you are?
20150926 20:47:19< celticminstrel> What are you passing in?
20150926 20:50:06< Elvish_Hunter> Also, did you know that MENU_IMG_TXT and MENU_IMG_TEXT2 can be used in [option]? The message= key supports them.
20150926 20:50:15-!- Appleman1234 [~Appleman1@KD111239005133.au-net.ne.jp] has joined #wesnoth-dev
20150926 20:51:04< celticminstrel> Yes, I knew that.
20150926 20:51:12< vultraz> tcampaign_difficulty(const &child_itors difficulties);
20150926 20:51:37< celticminstrel> The & needs to come at the end of the type name: const child_itors&
20150926 20:51:39< vultraz> (header)
20150926 20:51:45< vultraz> oh
20150926 20:51:54< vultraz> but then it says it doesn't name a type :|
20150926 20:52:19< celticminstrel> It probably thought you were trying to declare a parameter named child_itors of type const int&
20150926 20:52:25< celticminstrel> config::child_itors?
20150926 20:54:49< vultraz> that alleviates some of my errors 
20150926 20:55:02< vultraz> now it says... description not declared in this scope 
20150926 20:55:10< vultraz> er
20150926 20:55:12< vultraz> difficulties
20150926 20:55:28< celticminstrel> Sounds pretty self-explanatory.
20150926 20:56:01< vultraz> That's what I initialize in the constructor... do I it somewhere else too?
20150926 20:56:47< celticminstrel> Not sure what you mean.
20150926 20:58:38< vultraz> tcampaign_difficulty::tcampaign_difficulty(const config::child_itors& difficulties) : index_(-1) {} is where I declare difficulties
20150926 20:58:56< vultraz> is that incorrect?
20150926 21:00:36< celticminstrel> If you only want to use difficulties in the constructor, then that's fine.
20150926 21:01:33< celticminstrel> ie, if you want to use it within that {} at the end there.
20150926 21:02:53< vultraz> ohhhh
20150926 21:03:05< vultraz> well, no
20150926 21:03:10< vultraz> I want to use it in preshow
20150926 21:04:11< celticminstrel> How are you planning to handle the original single-string format?
20150926 21:05:40< vultraz> Is immediately dropping it an option? :P
20150926 21:06:01< celticminstrel> Probably not a good idea. :P
20150926 21:06:48< celticminstrel> You probably need to copy the const child_itors from your parameter into a class variable declared into the private section of the class, something like:
20150926 21:07:10< celticminstrel> tcampaign_difficulty::tcampaign_difficulty(const config::child_itors& difficulties) : index_(-1), difficulties_(difficulties) {}
20150926 21:09:30< vultraz> yayyit builds
20150926 21:09:36< vultraz> but does it work
20150926 21:09:54< vultraz> no :P
20150926 21:10:04< celticminstrel> You could probably convert the string format into the config format in the constructor. (Different constructor.)
20150926 21:10:09-!- irker377 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150926 21:10:16< celticminstrel> Using tlegacy_menu_item.
20150926 21:11:00< celticminstrel> Oh wait, that wouldn't be as easy as I thought, not when you're only storing iterators.
20150926 21:11:19< celticminstrel> Well, you could convert it to config format before passing it on to the constructor.
20150926 21:12:11< vultraz> Let's get the new format working before dealing with legacy code 
20150926 21:12:24< gfgtdf> celticminstrel: what could be the problem with iterators ?
20150926 21:14:31< vultraz> hm, so the dialog just doesnt come up at all
20150926 21:14:36< vultraz> wonder why..
20150926 21:16:50< vultraz> gui2::tcampaign_difficulty dlg(current_level().data().child_range("difficulties"));
20150926 21:17:38< vultraz> ok, so that's a config
20150926 21:17:42< vultraz> so I can use child_range
20150926 21:17:53-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Quit: Page closed]
20150926 21:18:14< vultraz> ohh
20150926 21:18:15< vultraz> difficulty
20150926 21:18:19< vultraz> not difficulties 
20150926 21:18:24< vultraz> herp derp
20150926 21:23:33< Ivanovic> wedge009: was your update for master only or also for stable?
20150926 21:24:37-!- irker050 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150926 21:24:37< irker050> wesnoth: Nils Kneuper wesnoth:master 39a2791f3ff7 / po/ (6 files in 6 dirs): updated British English translation http://git.io/vnjrL
20150926 21:27:27< vultraz> blah, still not showing
20150926 21:39:51-!- Nobun [~nobun@5.170.84.104] has quit [Quit: Salve a tutti]
20150926 21:47:53< celticminstrel> gfgtdf: Because iterators are basically pointers into an existing config, so if you don't have an existing config, you can't get the iterators.
20150926 21:49:24< celticminstrel> gfgtdf: And that also means that you can't store iterators to a local config declared in the constructor, because they'll become invalid once the constructor exits.
20150926 21:50:06< celticminstrel> vultraz: Maybe something to do with how you're using the iterator pair?
20150926 21:51:12-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has left #wesnoth-dev ["Ciao!"]
20150926 21:54:59< vultraz> http://pastebin.com/JqkhmUa9 is what I'm doing
20150926 21:55:17< vultraz> the widget setting is the same as before
20150926 21:57:15< celticminstrel> Good way of setting index_
20150926 21:57:32< celticminstrel> Though I'm not sure, it might be off by one.
20150926 21:57:41< celticminstrel> But you can figure that out once the main stuff works.
20150926 21:57:53< celticminstrel> Anyway.
20150926 21:57:57< gfgtdf> celticminstrel: i'd by surprised if the campaigns config is alocal thing, i'd think it's just  part of teh game config?
20150926 21:58:31< celticminstrel> gfgtdf: What I mean is that you can't have a constructor that takes a string, converts it into a config, and sets the iterator pair from that local config.
20150926 21:58:58< celticminstrel> gfgtdf: I was talking about handling legacy difficulty_descriptions=
20150926 22:00:09< celticminstrel> vultraz: That code looks good. Maybe verify that the iterator pair is non-empty? ie, check std::distance(difficulties_.first, difficulties_.second) > 0
20150926 22:00:30< celticminstrel> Print a warning message to the log if it's not, or something.
20150926 22:00:35< celticminstrel> If it's empty I mean.
20150926 22:02:14< celticminstrel> vultraz: You are calling dlg.show(), right?
20150926 22:02:48< vultraz> yes
20150926 22:02:50< vultraz> 		dlg.show(disp_.video());
20150926 22:03:11< vultraz> and dlg is gui2::tcampaign_difficulty dlg(current_level().data().child_range("difficulty"));
20150926 22:03:42< celticminstrel> First thing I'd wonder is whether current_level().data().has_child("difficulty")
20150926 22:04:20< celticminstrel> (Which amounts to the same check as the std::distance thing, just in a different place.)
20150926 22:04:26< vultraz> hm
20150926 22:04:35< vultraz> maybe the campaign config only serializes specifc keys
20150926 22:04:37< vultraz> specific
20150926 22:04:52< celticminstrel> What do you mean?
20150926 22:06:35< vultraz> er, subtags
20150926 22:07:59< celticminstrel> That would seem unlikely, but who knows.
20150926 22:08:37< gfgtdf> vultraz: it would be easier for us to check the code if we can see all of it, for example if you push it to a branch in your wesnoth fork.
20150926 22:09:26< celticminstrel> ^
20150926 22:10:04< vultraz> ok
20150926 22:10:07< vultraz> will do
20150926 22:15:49< vultraz> https://github.com/Vultraz/wesnoth/commit/041436b3e7494107b3c8eac12bfdbc12bd1c286e
20150926 22:16:46< vultraz> use of campaign difficulty in savegame.cpp is commented out for now
20150926 22:18:01< gfgtdf> vultraz: maybe it's the if(difficulties.empty()) return ""; line?
20150926 22:18:58< celticminstrel> Where?
20150926 22:19:17< vultraz> hmm
20150926 22:19:19< gfgtdf> celticminstrel: at the beginning of create_engine::select_campaign_difficulty
20150926 22:19:56< vultraz> Ok, the dialog shows now :D
20150926 22:20:05< celticminstrel> Yay!
20150926 22:20:12< vultraz> Only problem is the image is the same for all three
20150926 22:20:31< vultraz> Oh
20150926 22:20:33< vultraz> that's my WML
20150926 22:20:34< vultraz> derp
20150926 22:20:36< vultraz> xD
20150926 22:21:52< vultraz> Ok, next we need to deal with difficulty completion
20150926 22:25:26-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20150926 22:25:29< vultraz> Hmm
20150926 22:25:33< vultraz> how do I get... campaign id
20150926 22:25:46< gfgtdf> vultraz: why do you need it ?
20150926 22:26:00< vultraz> if (widget && !preferences::is_campaign_completed(campaign_id, d["define"])) {
20150926 22:26:27< vultraz> I guess I can just pass it as another argument to tcampaign_difficulty
20150926 22:36:43< vultraz> heh, I accidentally reversed the label and description order
20150926 22:37:59< vultraz> er
20150926 22:38:37< vultraz> ah, wml mixup again
20150926 22:40:33< vultraz> bleh, completion status doesn't work :(
20150926 22:50:34< vultraz> gah, default doesn't work either :(
20150926 22:53:28-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Read error: Connection reset by peer]
20150926 22:53:51< vultraz> oh, just realized something
20150926 22:54:02< vultraz> instead of index, we can just have the dialog return the define
20150926 22:54:11-!- iceiceice [~chris@pool-72-82-175-208.cmdnnj.east.verizon.net] has joined #wesnoth-dev
20150926 22:54:11-!- iceiceice [~chris@pool-72-82-175-208.cmdnnj.east.verizon.net] has quit [Changing host]
20150926 22:54:11-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150926 22:59:12-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 264 seconds]
20150926 23:01:55-!- gfgtdf [~chatzilla@f054153127.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20150926 23:10:50-!- iceiceice [~chris@static-108-24-119-15.cmdnnj.east.verizon.net] has joined #wesnoth-dev
20150926 23:10:50-!- iceiceice [~chris@static-108-24-119-15.cmdnnj.east.verizon.net] has quit [Changing host]
20150926 23:10:50-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150926 23:11:13< wedge009> Ivanovic: Only for master. Thanks for that.
20150926 23:12:49< vultraz> yess default is working
20150926 23:12:54< vultraz> someone kick me for forgetting to_bool
20150926 23:14:07 * wedge009 kicks vultraz (gently)
20150926 23:17:07-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Read error: Connection reset by peer]
20150926 23:18:41< wedge009> Ivanovic: Did I forget to include po/wesnoth/en_GB.po? There's one change for that one too.
20150926 23:24:16< wedge009> Ivanovic: Looks like I forgot to send it to you. Sent it just now. No need to update right away.
20150926 23:32:53-!- genbattle [~genbattle@122-57-90-134.jetstream.xtra.co.nz] has joined #wesnoth-dev
20150926 23:34:11< vultraz> ok, problem is the id is not passed correctly
20150926 23:36:09< vultraz> gui2::tcampaign_difficulty dlg(current_level().data().child_range("difficulty"), current_level().data()["id"]);
20150926 23:36:10< vultraz> hmmm
20150926 23:36:27< vultraz> one would think this would work
20150926 23:36:30< vultraz> apparently not
20150926 23:36:53< vultraz> celticminstrel: unless that is not how to pass multiple objects to the constructor?
20150926 23:36:57< vultraz> er
20150926 23:36:59< vultraz> arguments?
20150926 23:37:01< vultraz> things?
20150926 23:37:32< celticminstrel> Arguments yes.
20150926 23:37:41< celticminstrel> Looks fine to me.
20150926 23:38:20-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 268 seconds]
20150926 23:39:23< vultraz> yet for some reason it's null
20150926 23:39:24< vultraz> :/
20150926 23:39:29< vultraz> guess I better push code again
20150926 23:39:35< celticminstrel> Aha.
20150926 23:39:46< celticminstrel> Is there something like current_level().id()?
20150926 23:42:32< vultraz> that compiles but it doesn't work :/
20150926 23:43:22< celticminstrel> ...eh?
20150926 23:44:32< vultraz> current_level().id() passes the compiler but the dialog still doesn't show the wreaths 
20150926 23:44:58< celticminstrel> I assume you've at least edited your preferences or something so that they are considered completed.
20150926 23:46:56< vultraz> I cl-ed through a campaign
20150926 23:47:15< celticminstrel> Ah.
20150926 23:47:19< celticminstrel> Presumably that should do it.
20150926 23:47:59< vultraz> Yes, because the campaign gets marked as completed
20150926 23:48:03< vultraz> just not the difficulty
20150926 23:48:43< vultraz> pushed to my branch, bt
20150926 23:48:45< vultraz> w
20150926 23:49:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150926 23:49:15-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150926 23:49:59< vultraz> also, realized I probably need a local table after all
20150926 23:50:05< vultraz> so I can return defines[row]
20150926 23:50:10< celticminstrel> ?
20150926 23:50:23< vultraz> separate issue
20150926 23:50:25< vultraz> sorry
20150926 23:50:37< vultraz> I'm going to try returning the value of define= directly
20150926 23:50:48< celticminstrel> Lemme see if the iterator is random-access.
20150926 23:51:17< vultraz> And I don't think you can access a specific index of an interator
20150926 23:51:30< celticminstrel> Okay, it is, so you should be able to do something like difficulties_.first[row]["define"].
20150926 23:51:37< celticminstrel> You can access a specific index of some iterators.
20150926 23:51:52< celticminstrel> And the child iterator appears to be such an iterator.
20150926 23:52:06< vultraz> hmm
20150926 23:52:08< celticminstrel> A C++ iterator is very different from a Lua iterator.
20150926 23:52:08< vultraz> so like
20150926 23:52:29< celticminstrel> It's kind of an abstraction of pointers to make them safer.
20150926 23:52:40< vultraz> return difficulties_.first[list.get_selected_row()]["define"]?
20150926 23:52:59< celticminstrel> I think that should work. Might need something extra between ][.
20150926 23:53:21< celticminstrel> Hmm, no, probably not, operator[] returns config.
20150926 23:53:27< celticminstrel> Well, config&
20150926 23:54:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds]
20150926 23:55:52< celticminstrel> Anyway, looking at your code now.
20150926 23:58:29< celticminstrel> It doesn't work either with .id() or with .data()["id"], right?
20150926 23:59:37< vultraz> No
--- Log closed Sun Sep 27 00:00:24 2015