--- Log opened Sun Sep 27 00:00:24 2015
--- Day changed Sun Sep 27 2015
20150927 00:00:24< celticminstrel> Is that "No it doesn't work" or "No you're wrong"?
20150927 00:00:34< vultraz> No, it doesn't work
20150927 00:01:46< celticminstrel> If you log the ID, is it the value you expected?
20150927 00:05:04< celticminstrel> Or set a breakpoint and examine it in the debugger, either way.
20150927 00:06:26-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20150927 00:06:26-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20150927 00:06:26-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150927 00:08:17< vultraz> breakpoint?
20150927 00:08:43-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Connection reset by peer]
20150927 00:08:59-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20150927 00:10:03< celticminstrel> I can help you with breakpoints and debugging only if you're using either MSVC or command-line POSIX tools (probably MinGW if on Windows).
20150927 00:11:46< vultraz> Ah..
20150927 00:12:03< vultraz> oh, I think I know what you mean
20150927 00:23:46< irker050> wesnoth: gfgtdf wesnoth:1.12 0f6584780a6f / src/actions/ (move.cpp move.hpp): add optional fire_event parameter to get_village http://git.io/vnjjW
20150927 00:23:48< irker050> wesnoth: gfgtdf wesnoth:1.12 df6a293edd58 / src/actions/ (move.cpp move.hpp): Merge pull request #510 from gfgtdf/1.12 http://git.io/vnjjl
20150927 00:40:49-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150927 00:41:07< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\dialogs\campaign_difficulty.cpp|126|error: ambiguous overload for 'operator=' (operand types are 'std::__cxx11::string {aka std::__cxx11::basic_string<char>}' and 'config::attribute_value')|
20150927 00:41:09< vultraz> wat
20150927 00:41:26< celticminstrel> Use .str()
20150927 00:42:59< vultraz> ah
20150927 00:44:47< vultraz> gah, assertion failure 
20150927 00:44:51< celticminstrel> I think that error is related to the fact that config::attribute_value is implicitly convertible to std::string.
20150927 00:45:02< celticminstrel> What assertion failed?
20150927 00:46:15< vultraz> gui/widgets/generator_private.hpp:651
20150927 00:46:17< vultraz> o_o
20150927 00:53:49-!- fendrin [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 246 seconds]
20150927 00:55:10< celticminstrel> Guessing that means the default index didn't exist for some reason.
20150927 00:57:16< vultraz> well, I did remove the index_ variable
20150927 00:57:18< vultraz> but..
20150927 00:57:56< celticminstrel> I mean, there are 5 items and you're trying to access item #5, for example.
20150927 00:58:44< vultraz> Ah, ok
20150927 00:58:47< vultraz> found it
20150927 00:58:53-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Remote host closed the connection]
20150927 00:58:55< vultraz> list.select_row(list.get_item_count()); does not work
20150927 00:59:10< celticminstrel> Yeah, subtract one.
20150927 00:59:11< vultraz> I guess I'll create a local index variable then
20150927 00:59:14< vultraz> or
20150927 00:59:16< vultraz> ok that
20150927 00:59:31< celticminstrel> C++ is 0-indexed like WML, not 1-indexed like Lua.
20150927 01:00:12< vultraz> er..
20150927 01:00:15< vultraz> hm that doesn't work :/
20150927 01:00:24< vultraz> I mean it works, but the wrong one is selected
20150927 01:00:46< vultraz> hang on
20150927 01:00:56< celticminstrel> Do you need to subtract 1 somewhere else maybe?
20150927 01:01:02< vultraz> that works
20150927 01:01:12< vultraz> I moved the block down after adding a new row
20150927 01:03:01< vultraz> So you can;t use get_item_count() before adding a row if you use it inside the loop
20150927 01:03:07< celticminstrel> Eh?
20150927 01:03:20< celticminstrel> You should be able to, if you can't I'd call that a bug.
20150927 01:04:31< vultraz> Possibly
20150927 01:04:54< vultraz> If you set a variable line index_ to thje value of get_item_count() and select the row outside the loop it works fine
20150927 01:05:04< vultraz> But I don't want to delve into gui2 to fix it
20150927 01:05:06< vultraz> :P
20150927 01:05:51< vultraz> ok, dialog showing normally again
20150927 01:07:01< vultraz> And I can launch a campaign and have difficulty-dependent values work :D
20150927 01:07:18< vultraz> whoot whoot!
20150927 01:08:32< vultraz> Now only the completed difficulty issue
20150927 01:11:24< celticminstrel> And doing the same for [message][option]
20150927 01:11:32< vultraz> oh
20150927 01:11:34< vultraz> right
20150927 01:11:45< vultraz> celticminstrel: do you think I should include the color tinting for description=?
20150927 01:11:56< celticminstrel> Did it do that before?
20150927 01:12:02< vultraz> No
20150927 01:12:08< celticminstrel> Does it look better?
20150927 01:13:07< vultraz> ehh
20150927 01:13:15< vultraz> It's subjective
20150927 01:13:22< celticminstrel> In your opinion?
20150927 01:13:46< vultraz> I'm leaning towards no
20150927 01:13:55< celticminstrel> Then I'd say, don't bother.
20150927 01:14:07< celticminstrel> They can use Pango markup if they want to customize the colours themselves.
20150927 01:22:59< vultraz> celticminstrel: fixed the completed thing
20150927 01:23:09< vultraz> celticminstrel: I was initializing campaign_id_ as null in the constructor
20150927 01:23:11< vultraz> >_>
20150927 01:23:37< celticminstrel> Heh.
20150927 01:25:27< vultraz> new difficulty syntax is now fully working :D
20150927 01:26:40-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150927 01:35:54-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20150927 01:42:49< vultraz> celticminstrel: ok, so, how do you recommend I deal with the old syntax
20150927 01:49:41< celticminstrel> I think I'd recommend converting it into a local config before passing it into tcampaign_difficulty.
20150927 01:50:03< celticminstrel> Using cfg.add_child("difficulty", dcfg) and stuff.
20150927 01:50:18< celticminstrel> I guess you'd need two local configs, one in the loop and one outside.
20150927 01:57:07< vultraz> hm
20150927 01:57:25< vultraz> so loop through each of difficulties=
20150927 01:57:43< vultraz> add each to a config with its description
20150927 01:57:53< vultraz> then pass the iterator 
20150927 01:57:54< vultraz> ok
20150927 01:59:46< vultraz> I wonder if I should make a DIFFICULTY macro that basically has the same arguments as MENU_IMG_TXT
20150927 01:59:52< vultraz> to make conversion easier
20150927 02:00:06< vultraz> CAMPAIGN_DIFFICILTY
20150927 02:00:08< vultraz> I mean
20150927 02:19:34< celticminstrel> Probably best to use a for-loop instead of BOOST_FOREACH since you have two separate arrays to deal with.
20150927 02:19:49< celticminstrel> difficulties= and difficulty_descriptions=
20150927 02:20:16< celticminstrel> A CAMPAIGN_DIFFICULTY sounds like a reasonable idea, but it'd need one extra argument.
20150927 02:20:36< celticminstrel> And that wouldn't account for default selection.
20150927 02:21:37< vultraz> oh, right
20150927 02:29:06-!- louis94 [~~louis94@109.133.201.27] has quit [Quit: Konversation terminated!]
20150927 02:33:39-!- fabi [~quassel@176.6.79.116] has joined #wesnoth-dev
20150927 02:33:45-!- fabi [~quassel@176.6.79.116] has quit [Changing host]
20150927 02:33:45-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150927 02:34:01-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20150927 03:12:57-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20150927 03:12:57-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20150927 03:12:57-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150927 03:24:46-!- irker050 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150927 03:27:30< vultraz> hm
20150927 03:28:26< vultraz> what's the standard wml message log function?
20150927 03:34:15< celticminstrel> I think it's lg::wml_error() << message
20150927 03:34:21< celticminstrel> Maybe without the parentheses.
20150927 03:34:32< celticminstrel> Don't forget to end the message with a \n
20150927 03:36:35< vultraz> thanks
20150927 03:51:50-!- [Relic] [~Relic]@2602:306:33a3:6d30:a94c:2a72:12c0:4577] has quit [Quit: I press the magic X and all the weirdos go away!]
20150927 03:53:36-!- [Relic] [~Relic]@2602:306:33a3:6d30:791d:976d:6e5d:f552] has joined #wesnoth-dev
20150927 04:01:51-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150927 04:03:46-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20150927 04:03:46-!- wedge010 is now known as wedge009
20150927 04:09:02-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150927 04:26:26-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 240 seconds]
20150927 04:58:27-!- ancestral [~ancestral@71.220.62.196] has joined #wesnoth-dev
20150927 05:16:30-!- Appleman1234 [~Appleman1@KD111239005133.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20150927 05:27:54-!- genbattle [~genbattle@122-57-90-134.jetstream.xtra.co.nz] has quit [Ping timeout: 260 seconds]
20150927 05:33:48-!- Kwandulin [~Miranda@p5B008F18.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150927 06:04:44-!- [Relic] [~Relic]@2602:306:33a3:6d30:791d:976d:6e5d:f552] has quit [Quit: I press the magic X and all the weirdos go away!]
20150927 06:13:35-!- Appleman1234 [~Appleman1@KD106161088159.au-net.ne.jp] has joined #wesnoth-dev
20150927 06:14:59-!- _laco [~laco@static.95.25.4.46.clients.your-server.de] has joined #wesnoth-dev
20150927 06:24:43-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 268 seconds]
20150927 06:29:45-!- ancestral [~ancestral@71.220.62.196] has quit [Quit: i go nstuf kthxbai]
20150927 06:34:00-!- Appleman1234 [~Appleman1@KD106161088159.au-net.ne.jp] has quit [Ping timeout: 264 seconds]
20150927 06:48:37-!- boucman [~rosen@2a02-8428-034f-f800-45e2-6021-7a90-9e66.rev.sfr.net] has joined #wesnoth-dev
20150927 06:48:44-!- boucman [~rosen@2a02-8428-034f-f800-45e2-6021-7a90-9e66.rev.sfr.net] has quit [Changing host]
20150927 06:48:44-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150927 06:58:33-!- celticminstrel is now known as celmin|sleep
20150927 07:23:08-!- genbattle [~genbattle@122-57-90-134.jetstream.xtra.co.nz] has joined #wesnoth-dev
20150927 07:31:08-!- Appleman1234 [~Appleman1@KD111239012133.au-net.ne.jp] has joined #wesnoth-dev
20150927 07:37:59-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 264 seconds]
20150927 07:38:47-!- genbattle [~genbattle@122-57-90-134.jetstream.xtra.co.nz] has quit [Ping timeout: 250 seconds]
20150927 07:55:47< Aginor> .n
20150927 07:56:56< Aginor> reading up on the backlog it looks like I need to have a chat with aquileia and wedge009 about VC9 support in the SDL2 branch, and presumably need to getup and running myself.
20150927 08:02:53< vultraz> Question
20150927 08:02:59< vultraz> Why do we support all the VCs back to 9?
20150927 08:03:01< vultraz> I mean
20150927 08:03:03< vultraz> Why not only the latest
20150927 08:03:11< vultraz> Or at least, the last two or maybe 3
20150927 08:06:13-!- Appleman1234 [~Appleman1@KD111239012133.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20150927 08:07:54< Aginor> vultraz: that's one of the things I want to find out :)
20150927 08:08:16< Aginor> also what the actual errors are that he/she is seeing
20150927 08:12:59-!- Kwandulin [~Miranda@p5B008F18.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150927 08:13:26-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150927 08:57:39< wedge009> Aginor: I think aquileia worked it out, something to do with type definitions. Has a solution in place, just hasn't pushed it to sdl2 branch yet.
20150927 08:59:46-!- Kwandulin [~Miranda@p5B008F18.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150927 09:02:51-!- Appleman1234 [~Appleman1@KD106161085188.au-net.ne.jp] has joined #wesnoth-dev
20150927 09:02:57< Aginor> ok
20150927 09:03:29< Aginor> (I was afk all of yesterday and the majority of today)
20150927 09:07:06-!- Appleman1234 [~Appleman1@KD106161085188.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20150927 09:12:20-!- irker175 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150927 09:12:20< irker175> wesnoth: Nils Kneuper wesnoth:master 8ce06b36cf06 / po/wesnoth/en_GB.po: updated British English translation http://git.io/vcvDl
20150927 09:15:39-!- Kwandulin [~Miranda@p5B008F18.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150927 10:13:27-!- Kwandulin [~Miranda@p5B008F18.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150927 10:20:05-!- Appleman1234 [~Appleman1@KD118156251005.au-net.ne.jp] has joined #wesnoth-dev
20150927 10:22:38-!- alalazo [d537b0fc@gateway/web/freenode/ip.213.55.176.252] has joined #wesnoth-dev
20150927 11:38:43-!- trewe [~trewe@2001:8a0:d10e:5f01:626c:66ff:fe92:9b7c] has joined #wesnoth-dev
20150927 11:47:04-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20150927 11:58:09-!- Kwandulin [~Miranda@p5B008F18.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150927 11:58:55-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20150927 12:12:29-!- irker175 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150927 12:21:00-!- irker169 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150927 12:21:00< irker169> wesnoth: aquileia wesnoth:master 45c1872777b9 / projectfiles/VC9/ (5 files): vcproj: Improve formatting http://git.io/vcf3D
20150927 12:23:28< irker169> wesnoth: aquileia wesnoth:sdl2 02563ac17678 / projectfiles/VC9/wesnoth.vcproj: vcproj: Update for 3c11aa6 & 3ed4eed http://git.io/vcfss
20150927 12:23:30< irker169> wesnoth: aquileia wesnoth:sdl2 eb55fe772f3e / projectfiles/VC9/ (schema_generator.vcproj wesnoth.vcproj wesnothd.vcproj): vcproj: SDL2 update http://git.io/vcfsG
20150927 12:23:32< irker169> wesnoth: aquileia wesnoth:sdl2 acc9afe9a9cb / src/ai/default/contexts.hpp: Fix VC9 compilation http://git.io/vcfsZ
20150927 12:26:44-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20150927 12:30:55< aquileia> Aginor, wedge009, gfgtdf: Pushed the vcproj fixes to the sdl2 branch and created a temporary aquileia/external/VC9-SDL2 branch for the replaced dependency files (you can cherry-pick the relevant commit for other VC versions)
20150927 12:32:39< aquileia> I'll cherry-pick it to aquileia/external/VC[9, 10, 12, 14] as soon as wesnoth/wesnoth/sdl2 is merged into master
20150927 12:57:58-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Quit: Page closed]
20150927 12:58:29-!- Kwandulin [~Miranda@91.0.143.24] has joined #wesnoth-dev
20150927 13:01:30-!- gfgtdf [~chatzilla@f054170011.adsl.alicedsl.de] has joined #wesnoth-dev
20150927 13:02:11< gfgtdf> aquileia: are you currently working on teh automatic updater ?
20150927 13:04:27< irker169> wesnoth: gfgtdf wesnoth:1.12 7c958621ee30 / src/actions/undo.cpp: Backport 'Fix capture event fired when undoing' http://git.io/vcfln
20150927 13:05:11< irker169> wesnoth: gfgtdf wesnoth:1.12 8db68ed2a325 / RELEASE_NOTES: Update RELEASE_NOTES http://git.io/vcflB
20150927 13:16:03-!- louis94 [~~louis94@109.133.201.27] has joined #wesnoth-dev
20150927 13:20:03< irker169> wesnoth: gfgtdf wesnoth:master e902417d49e5 / src/unit_id.hpp: fix unit_id comparision http://git.io/vcfBa
20150927 13:59:41-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20150927 13:59:41-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20150927 13:59:41-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150927 14:02:20-!- Appleman1234 [~Appleman1@KD118156251005.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20150927 14:05:54-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20150927 14:11:39-!- alalazo [d537b0fc@gateway/web/freenode/ip.213.55.176.252] has quit [Ping timeout: 246 seconds]
20150927 14:27:06-!- Kwandulin [~Miranda@91.0.143.24] has quit [Read error: Connection reset by peer]
20150927 14:47:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150927 14:49:49-!- [Relic] [~Relic]@2602:306:33a3:6d30:48c4:8864:830d:c5f3] has joined #wesnoth-dev
20150927 14:51:09-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20150927 15:13:50-!- Appleman1234 [~Appleman1@KD111239023207.au-net.ne.jp] has joined #wesnoth-dev
20150927 15:18:26-!- Appleman1234 [~Appleman1@KD111239023207.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20150927 15:20:12-!- celmin|sleep is now known as celticminstrel
20150927 15:22:36< celticminstrel> So has anyone besides gfgtdf looked at my two Lua PRs?
20150927 15:34:13-!- louis94 [~~louis94@109.133.201.27] has quit [Ping timeout: 246 seconds]
20150927 15:34:36-!- louis94 [~~louis94@109.133.201.27] has joined #wesnoth-dev
20150927 15:38:14 * celticminstrel comments on vultraz's difficulty syntax commit.
20150927 15:40:55-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150927 15:59:06-!- Kwandulin [~Miranda@p5B008F18.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150927 16:01:54-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150927 16:04:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20150927 16:04:06-!- wedge010 is now known as wedge009
20150927 16:20:20-!- irker169 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150927 16:26:09-!- louis94 [~~louis94@109.133.201.27] has quit [Ping timeout: 250 seconds]
20150927 16:38:40-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has joined #wesnoth-dev
20150927 16:49:37-!- sad [6c44607d@gateway/web/freenode/ip.108.68.96.125] has joined #wesnoth-dev
20150927 16:55:48-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150927 16:57:54-!- sad [6c44607d@gateway/web/freenode/ip.108.68.96.125] has quit [Ping timeout: 246 seconds]
20150927 17:01:38-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has quit [Remote host closed the connection]
20150927 17:05:50-!- louis94 [~~louis94@109.133.201.27] has joined #wesnoth-dev
20150927 17:11:13-!- lipkab [~the_new_l@host-91-147-210-193.biatv.hu] has quit [Quit: Leaving]
20150927 17:34:45-!- Kwandulin [~Miranda@p5B008F18.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150927 17:35:55-!- mjs-de [~mjs-de@x4db53600.dyn.telefonica.de] has joined #wesnoth-dev
20150927 17:44:03-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has joined #wesnoth-dev
20150927 17:53:27-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20150927 17:54:19-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150927 17:54:27-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150927 17:55:28-!- louis94 [~~louis94@109.133.201.27] has quit [Ping timeout: 246 seconds]
20150927 18:02:40-!- [Relic] [~Relic]@2602:306:33a3:6d30:48c4:8864:830d:c5f3] has quit [Quit: I press the magic X and all the weirdos go away!]
20150927 18:04:26-!- [Relic] [~Relic]@2602:306:33a3:6d30:adaa:b6c6:27e7:dce0] has joined #wesnoth-dev
20150927 18:20:57-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150927 18:24:40-!- framling [~user@c-50-186-43-50.hsd1.or.comcast.net] has joined #wesnoth-dev
20150927 18:31:20-!- louis94 [~~louis94@109.133.201.27] has joined #wesnoth-dev
20150927 18:31:22-!- ndi [bec24380@gateway/web/freenode/ip.190.194.67.128] has joined #wesnoth-dev
20150927 18:41:25-!- louis94 [~~louis94@109.133.201.27] has quit [Ping timeout: 240 seconds]
20150927 18:55:14-!- mjs-de [~mjs-de@x4db53600.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20150927 18:58:09-!- mjs-de [~mjs-de@x4db6b126.dyn.telefonica.de] has joined #wesnoth-dev
20150927 19:19:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20150927 19:19:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20150927 19:32:03-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 244 seconds]
20150927 19:46:08-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150927 19:50:42-!- ndi [bec24380@gateway/web/freenode/ip.190.194.67.128] has quit [Quit: Page closed]
20150927 19:53:37-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Quit: No Ping reply in 180 seconds.]
20150927 19:55:04-!- fabi [~quassel@176.4.8.1] has joined #wesnoth-dev
20150927 19:55:04-!- fabi [~quassel@176.4.8.1] has quit [Changing host]
20150927 19:55:04-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150927 19:56:43-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 246 seconds]
20150927 20:16:25-!- mjs-de [~mjs-de@x4db6b126.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20150927 20:41:48< gfgtdf> somehow this line: "2":match("%d") is not valid lua error but i dotn know how, i thought that how teh : syntax works ? 
20150927 20:41:51< gfgtdf> celticminstrel: ^
20150927 20:42:01< gfgtdf> know why*
20150927 20:42:55< celticminstrel> I'm not sure why that doesn't work, but I believe ("2"):match("%d") does.
20150927 20:43:06< gfgtdf> celticminstrel: ok i'll try that
20150927 20:43:35< gfgtdf> celticminstrel: y that works, ty
20150927 21:03:46-!- shadowm [~ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 246 seconds]
20150927 21:04:17-!- shadowm [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150927 21:16:36< Aginor> aquileia: Thanks :)
20150927 21:23:00-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150927 21:26:13-!- Guest41323 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150927 21:31:04-!- Guest41323 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 246 seconds]
20150927 21:31:31-!- louis94 [~~louis94@109.133.201.27] has joined #wesnoth-dev
20150927 21:40:56-!- TC01_ [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150927 21:50:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds]
20150927 21:52:58-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150927 22:01:53-!- [Relic] [~Relic]@2602:306:33a3:6d30:adaa:b6c6:27e7:dce0] has quit [Quit: I press the magic X and all the weirdos go away!]
20150927 22:03:48-!- [Relic] [~Relic]@2602:306:33a3:6d30:4d8:8ec2:caed:c7ae] has joined #wesnoth-dev
20150927 22:24:42-!- AgentE382 [17196525@gateway/web/freenode/ip.23.25.101.37] has joined #wesnoth-dev
20150927 22:30:34< vultraz> celticminstrel: did you mean something like this? http://pastebin.com/kdsM5uc0
20150927 22:34:55-!- AgentE382 [17196525@gateway/web/freenode/ip.23.25.101.37] has quit [Quit: Page closed]
20150927 22:36:31< celticminstrel> Timing!
20150927 22:36:36-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 265 seconds]
20150927 22:36:38< celticminstrel> Just as I started looking at your replies.
20150927 22:36:58< celticminstrel> That is exactly what I meant, yes.
20150927 22:37:22< celticminstrel> Because that code block just below needs to know the list of available difficulties.
20150927 22:37:30-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20150927 22:37:55< celticminstrel> Regardless of whether they're given in the old or new format.
20150927 22:39:20< celticminstrel> Did you see all the comments or just that first one?
20150927 22:40:37< vultraz> I'm trying to figure out what you mean by "Suggestion: Go through all this (from difficulty_opts to here) only if current_level().data().child_range("difficulty").first == current_level().data().child_range("difficulty").second"
20150927 22:41:11< celticminstrel> That's about supporting the legacy format.
20150927 22:41:35< celticminstrel> That code there has nothing to do with the new format, so there's no point using it if you know the difficulties are in the old format.
20150927 22:42:13< celticminstrel> Actually though, instead of that equals check, it'd be better to do current_level().data().has_child("difficulty")
20150927 22:42:27< vultraz> All the code related to difficulty_opts, you mean?
20150927 22:42:44< celticminstrel> Yeah, because difficulty_opts is the difficulty_descriptions=
20150927 22:42:49< vultraz> ok
20150927 22:43:07< vultraz> but we should still perform the 	if (set_value != -1) check even with the new difficulty?
20150927 22:44:04< celticminstrel> That check is for people who want to start a campaign from the command-line and skip the difficulty dialog.
20150927 22:44:15< celticminstrel> So yes, it should be kept for the new difficulties.
20150927 22:45:08< vultraz> ok
20150927 22:54:04< vultraz> I wonder if I should create a local reference to current_level().data()
20150927 22:54:26< celticminstrel> If you want.
20150927 22:55:32-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150927 22:56:53< vultraz> hm
20150927 22:57:06< vultraz> I just realized I need to handle the return value differently for new format vs old format
20150927 22:57:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150927 22:57:21< celticminstrel> You do?
20150927 22:57:22< vultraz> new returns the difficulty define directly
20150927 22:57:30< vultraz> old returns it via a table
20150927 22:57:39< vultraz> array*
20150927 22:57:48< celticminstrel> Can't you just return it directly with the old format?
20150927 22:57:56< vultraz> so new is return dlg.selected_difficulty(); and old is return difficulties[difficulty];
20150927 22:58:23< celticminstrel> That's the same, right?
20150927 23:00:06< vultraz> er... hm
20150927 23:00:33< vultraz> Oh
20150927 23:00:45< vultraz> Er
20150927 23:01:03< vultraz> I was going to say I can use the former either way, but the old format still doesn't have the appropriate keys
20150927 23:01:07< vultraz> format*
20150927 23:01:19< vultraz> ie, it's not translated to a config
20150927 23:01:24< celticminstrel> That's why I said convert the old format into a new config.
20150927 23:01:29< celticminstrel> ^local config
20150927 23:08:52< vultraz> you said use a FOR loop, right?
20150927 23:09:59< celticminstrel> I don't remember, where are we talking about?
20150927 23:10:12< celticminstrel> I do recall saying something like that somewhere...
20150927 23:11:18< vultraz> creating a config 
20150927 23:12:00< celticminstrel> Oh, right. You could use a foreach loop, but you need to iterate through both the difficulties array and the difficulty_opts (or difficulty_options) arrays at the same time, which is nontrivial with a foreach loop. So yeah, for-loop is probably easier here.
20150927 23:12:37< celticminstrel> And use add_child so that you can then call child_range("difficulty") on that config to get the converted values.
20150927 23:13:22< vultraz> oh, and I guess it also needs to be passed through uh... the legacy format class
20150927 23:13:34< vultraz> so something like...
20150927 23:13:36< celticminstrel> Yeah.
20150927 23:13:39 * vultraz looks up syntax for FOR loops
20150927 23:14:18< celticminstrel> It's a bit weird in C-like languages, because they're really a while loop in disguise.
20150927 23:18:01< vultraz> for ( init; condition; increment )
20150927 23:18:03< vultraz> ok... so..
20150927 23:18:04< vultraz> uhhh
20150927 23:18:15< celticminstrel> for(int i = 0; i < length; i++)
20150927 23:18:51< celticminstrel> In this case I think length is a .size(), so maybe size_t instead of int.
20150927 23:19:16< vultraz> difficulty_opts = tlegacy_menu_item(difficulty_opts), and then loop over difficulties
20150927 23:19:49< vultraz> or uh...
20150927 23:19:52< celticminstrel> Well no, the call to tlegacy_muenu_item needs to be in the loop too.
20150927 23:19:53< vultraz> wait no, then loop over difficulty_opts
20150927 23:19:57< vultraz> oh?
20150927 23:19:59< vultraz> ok
20150927 23:20:07< celticminstrel> Yes, loop over difficulty_opts.
20150927 23:20:22< celticminstrel> Or loop over difficulties.
20150927 23:20:48< celticminstrel> You're really looping over both at the same time, but I guess using difficulties as the key might be a bit better.
20150927 23:21:23< celticminstrel> But only if difficulty_opts is nonempty.
20150927 23:21:33< celticminstrel> Eh.
20150927 23:21:37< celticminstrel> I dunno.
20150927 23:21:46< vultraz> they're the same
20150927 23:21:49< vultraz> since
20150927 23:21:51< vultraz> 		if(difficulty_opts.size() != difficulties.size()) {
20150927 23:21:52< vultraz> 			difficulty_opts = difficulties;
20150927 23:21:54< vultraz> 		}
20150927 23:22:14< celticminstrel> That seems a bit silly.
20150927 23:22:22< celticminstrel> But okay, they're the same by this point.
20150927 23:22:30< celticminstrel> So then loop over difficulty_opts.
20150927 23:23:04< vultraz> the local config should be inside the loop?
20150927 23:23:24< celticminstrel> You need one inside the loop and one outside the loop.
20150927 23:23:36< celticminstrel> The one inside the loop is to insert as a child into the one outside the loop.
20150927 23:23:54< celticminstrel> You could get that one via methods on the other one.
20150927 23:23:58< vultraz> oh, I thought we were going to add it to current_level().data()
20150927 23:24:08< celticminstrel> Something like cfg.child_or_add.
20150927 23:24:16< celticminstrel> Well, you could add it to current_level().data(), I suppose.
20150927 23:24:19< celticminstrel> I didn't think of that.
20150927 23:25:53-!- framling [~user@c-50-186-43-50.hsd1.or.comcast.net] has quit [Quit: ERC Version 5.3 (IRC client for Emacs)]
20150927 23:26:21< celticminstrel> Provided it's not const.
20150927 23:31:21-!- gfgtdf [~chatzilla@f054170011.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0/20150917150946]]
20150927 23:35:21< vultraz> damn, code does not compile
20150927 23:36:35< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\game_initialization\create_engine.cpp|593|error: no matching function for call to 'std::vector<std::__cxx11::basic_string<char> >::push_back(const config&)'|
20150927 23:42:00< vultraz> ah, ok, so that's fixed
20150927 23:44:50< vultraz> one error left
20150927 23:44:54-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has quit [Quit: :wq]
20150927 23:44:59< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\game_initialization\create_engine.cpp|629|error: conversion from 'std::__cxx11::basic_string<char>' to non-scalar type 'gui2::tlegacy_menu_item' requested|
20150927 23:50:48-!- Appleman1234 [~Appleman1@KD106161082218.au-net.ne.jp] has joined #wesnoth-dev
20150927 23:51:18< vultraz> blagh, I do not understand this
20150927 23:52:46< vultraz> ahh
20150927 23:53:02< vultraz> fixed it
20150927 23:53:04< vultraz> somehow
20150927 23:53:24< vultraz> apparently gui2::tlegacy_menu_item parsed = difficulty_opts[i]; was invalid and I needed gui2::tlegacy_menu_item parsed(difficulty_opts[i]);
20150927 23:56:43< vultraz> ermeghard it werks
20150927 23:57:34< vultraz> Two small issues, but they're hopefully minor
--- Log closed Mon Sep 28 00:00:09 2015