--- Log opened Mon Sep 28 00:00:09 2015
20150928 00:01:13< vultraz> One down
20150928 00:02:11< vultraz> annnnd the other
20150928 00:02:16< vultraz> celticminstrel: fully working :D
20150928 00:07:31< vultraz> Now just to get the savegames working 
20150928 00:10:17-!- aeonchild is now known as enchilado
20150928 00:10:27-!- enchilado is now known as aeonchild
20150928 00:24:25-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: No route to host]
20150928 00:24:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150928 00:29:08-!- Appleman1234 [~Appleman1@KD106161082218.au-net.ne.jp] has quit [Ping timeout: 244 seconds]
20150928 00:29:37< celticminstrel> Sorry, was eating.
20150928 00:29:48< celticminstrel> vultraz: Aren't you also forgetting [option]?
20150928 00:35:00-!- louis94 [~~louis94@109.133.201.27] has quit [Quit: Konversation terminated!]
20150928 00:39:53< vultraz> celticminstrel: well, technically the old syntax will still work for them, so I might not handle those right now
20150928 00:40:10< celticminstrel> Well, okay then.
20150928 00:40:27< vultraz> The options code looks complicated 
20150928 00:40:38< celticminstrel> I haven't actually looked at it yet.
20150928 00:42:15< vultraz> Do you see any issues with what I just pushed?
20150928 00:42:21< vultraz> ( https://github.com/Vultraz/wesnoth/commit/7125b9b8c91ed174dc146fdf6a541265b2184169 )
20150928 00:51:13< celticminstrel> vultraz: Looks good to me.
20150928 00:51:42< celticminstrel> My only complaint is something completely unrelated to your changes, so I won't voice it now. :P
20150928 01:05:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20150928 01:05:57-!- trewe [~trewe@2001:8a0:d10e:5f01:626c:66ff:fe92:9b7c] has quit [Quit: quit]
20150928 01:13:26-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20150928 01:16:15-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150928 01:33:14-!- quentinp_ [~quentin@ns363174.ip-91-121-196.eu] has joined #wesnoth-dev
20150928 01:34:16-!- iwaim_ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20150928 01:34:51-!- louis94 [~~louis94@109.133.201.27] has joined #wesnoth-dev
20150928 01:35:35-!- c74d3a [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150928 01:38:44-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 250 seconds]
20150928 01:38:47-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has quit [Ping timeout: 250 seconds]
20150928 01:38:48-!- quentinp [~quentin@ns363174.ip-91-121-196.eu] has quit [Ping timeout: 250 seconds]
20150928 01:38:49-!- c74d3 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Ping timeout: 250 seconds]
20150928 01:38:50-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Ping timeout: 250 seconds]
20150928 01:38:50-!- {V} [~V@105-70-ftth.on.nl] has quit [Ping timeout: 250 seconds]
20150928 01:39:12-!- {V} [~V@105-70-ftth.on.nl] has joined #wesnoth-dev
20150928 01:40:29-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20150928 01:40:58-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20150928 01:44:18-!- TC01_ [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 240 seconds]
20150928 01:47:56-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev
20150928 01:48:05-!- louis94 [~~louis94@109.133.201.27] has quit [Quit: Konversation terminated!]
20150928 01:57:12-!- Guest60443 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150928 02:01:33< vultraz> Ok, savegame almost done..
20150928 02:01:46-!- Guest60443 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 260 seconds]
20150928 02:02:15< celticminstrel> Yay.
20150928 02:02:31 * Aginor applauds
20150928 02:02:40< vultraz> good god it builds on the first try
20150928 02:05:25< vultraz> celticminstral: ot, but im thinking maybe the message skipped because user not interested message should be demoted to log level
20150928 02:05:29< vultraz> instead of debug
20150928 02:05:45< vultraz> or perhaps not logged at all
20150928 02:05:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150928 02:05:53< vultraz> it fills up stderr
20150928 02:06:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150928 02:06:12< celticminstrel> I think you can demote it to info.
20150928 02:10:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 272 seconds]
20150928 02:11:40< vultraz> bleh, savegame diff change not working :(
20150928 02:12:34< vultraz> dialog just not showing
20150928 02:15:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150928 02:17:36< vultraz> blegh, tab completion not working
20150928 02:17:42-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Quit: ChatZilla 0.9.92-rdmsoft [XULRunner 35.0.1/20150122214805]]
20150928 02:17:54-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150928 02:19:02< vultraz> celticminstrel: there's no reason continue shouldn't work in BOOST_FOREACH, is there?
20150928 02:19:25< celticminstrel> BOOST_FOREACH is probably a for-loop under the hood.
20150928 02:19:32< celticminstrel> So yeah, use continue/break all you want.
20150928 02:20:10< vultraz> hm...
20150928 02:20:20< Aginor> indeed
20150928 02:27:27< vultraz> ... you know something's wrong with your code when you can
20150928 02:27:38< vultraz> t make it throw a syntax error on compile when if you try o_O
20150928 02:27:51< celticminstrel> ...uh?
20150928 02:28:39< vultraz> I noticed that this file is building for some reason even if I have errors o_O
20150928 02:29:39< vultraz> gonna try a rebuild
20150928 02:31:47< vultraz> My laptop's clock got screwey, so maybe there's some cache problem or something
20150928 02:31:59< vultraz> (it got set 1 month ahead somehow)
20150928 02:33:17< celticminstrel> It wouldn't rebuild even if you added a random space or something trivial?
20150928 02:33:38< vultraz> it would go through the linker, at least
20150928 02:33:57< vultraz> but even if I threw random gibberish into the file like eklfioejriofniofjiojoi^^<<<nullprt it would still pass
20150928 02:34:10< celticminstrel> Weird.
20150928 02:43:32-!- [Relic] [~Relic]@2602:306:33a3:6d30:4d8:8ec2:caed:c7ae] has quit [Quit: I press the magic X and all the weirdos go away!]
20150928 02:45:35< vultraz> celticminstrel: finally, i get errors again
20150928 02:45:51< celticminstrel> Yay.
20150928 02:48:42< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\savegame.cpp|178|error: passing 'const config' as 'this' argument discards qualifiers [-fpermissive]|
20150928 02:48:54< vultraz> oh, can't be const
20150928 02:48:55< vultraz> ok
20150928 02:50:00< vultraz> (not sure what the 'this' means)
20150928 02:50:28< celticminstrel> In cfg.blah(), 'this' refers to cfg
20150928 02:52:57< vultraz> hm...
20150928 02:53:41< vultraz> C:\Users\Charles\Documents\wesnoth-git\projectfiles\CodeBlocks\cb\include_tdm_gcc\boost\foreach.hpp|1040|error: binding 'const config' to reference of type 'config&' discards qualifiers|
20150928 02:53:55< vultraz> so seems there's some const problem with how im doing this loop
20150928 02:54:31< vultraz> 	BOOST_FOREACH(config &campaign, game_config_.child_range("campaign"))
20150928 02:54:35< celticminstrel> Sounds like your config is declared const but you're trying to do something that changes the config.
20150928 02:54:47< celticminstrel> Oh. It's not declared const.
20150928 02:54:53< celticminstrel> That would be the cause of that error.
20150928 02:55:05< celticminstrel> But I'm guessing if it's const you get the other error.
20150928 02:55:20< vultraz> It used to be 	const config::child_itors &campaigns = game_config_.child_range("campaign");
20150928 02:55:22< vultraz> 	BOOST_FOREACH(config &campaign, campaigns)
20150928 02:55:27< vultraz> but that was causing a whole slew of other errors
20150928 02:55:53< vultraz> so I simply moved the iterator into the loop but now I get the aforementioned error..
20150928 02:55:55< vultraz> hm...
20150928 02:56:09< vultraz> maybe game_config_ is const
20150928 02:56:28< vultraz> ah, yes it is
20150928 02:56:37< vultraz> loadgame::loadgame(display& gui, const config& game_config, saved_game& gamestate)
20150928 02:57:12< celticminstrel> Yeah, I thought so.
20150928 02:57:59< vultraz> I wonder if it would be ok to make that non-const
20150928 02:58:19< celticminstrel> There's likely a good reason for it to be const, but I would have no idea what that is.
20150928 02:58:22< vultraz> I guess I have to if I want to write back to the config
20150928 02:58:53< celticminstrel> Do you need to write back to the config?
20150928 02:59:34< vultraz> Well, that's what I'm doing when I convert the old syntax to new
20150928 02:59:51< vultraz> write it back to the campaign config so I can pass an iterator to the difficulty dialog
20150928 03:00:11< vultraz> er..
20150928 03:00:29-!- Guest95329 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150928 03:00:38< vultraz> ok uh... removing that const causes errors in create::process_event_impl
20150928 03:00:43< vultraz> perhaps not a good idea, then
20150928 03:01:26< celticminstrel> You could write it to a temporary local config instead.
20150928 03:05:20-!- Guest95329 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 265 seconds]
20150928 03:12:03-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 252 seconds]
20150928 03:12:13< vultraz> lemme push what I have'
20150928 03:12:48-!- TC01_ [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150928 03:15:18< vultraz> celticminstrel: https://github.com/Vultraz/wesnoth/commit/a0f4e923e65a1ec82e8d9449a991569d8b832ca7
20150928 03:17:35-!- TC01_ [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 264 seconds]
20150928 03:18:30< celticminstrel> "const config::child_itors" is a child iterator that always can never change to point into a different config or to a diferent part of a config, etc.
20150928 03:18:51-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150928 03:18:54< celticminstrel> "config::const_child_itors" is a child iterator that can do the above, but cannot change the config it's addressing.
20150928 03:19:34< celticminstrel> In pointer terms, the former is "char* const" and the latter is "const char*".
20150928 03:19:55< celticminstrel> Anyway vultraz, are you getting errors in what you pushed?
20150928 03:20:41< vultraz> yesh, just the |error: binding 'const config' to reference of type 'config&' discards qualifiers|
20150928 03:20:45< vultraz> thing
20150928 03:20:59< vultraz> you said I should try copying the config?
20150928 03:22:30< celticminstrel> BTW, there's no need to quote your true.
20150928 03:22:37< celticminstrel> temp["old_markup"] = true;
20150928 03:22:42< celticminstrel> That should work.
20150928 03:25:10< celticminstrel> I commented on the commit.
20150928 03:25:54-!- [Relic] [~Relic]@2602:306:33a3:6d30:8dfb:e277:b4ae:cd45] has joined #wesnoth-dev
20150928 03:32:38< vultraz> celticminstrel: ok, so difficulty_tags is what will be passed to the dialog?
20150928 03:32:44< celticminstrel> Yes.
20150928 03:35:59< vultraz> errors D:
20150928 03:41:26-!- TC01_ [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150928 03:45:59-!- TC01_ [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 256 seconds]
20150928 03:51:21-!- TC01_ [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20150928 04:32:18< celticminstrel> vultraz: Solved the errors yet?
20150928 04:35:20-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20150928 04:35:20-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20150928 04:35:20-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150928 04:42:54-!- c74d3a [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20150928 04:44:37-!- c74d3a [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20150928 04:47:51-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 268 seconds]
20150928 04:57:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20150928 04:57:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20150928 04:58:57-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20150928 04:58:57-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20150928 04:58:57-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150928 04:59:23< vultraz> celticminstrel: no
20150928 04:59:26< vultraz> still getting const issues
20150928 05:01:37< vultraz> celticminstrel: http://pastebin.com/LfrHj8QP
20150928 05:02:21< celticminstrel> First error: That config must be declared as const.
20150928 05:02:32< vultraz> I pushed what I have
20150928 05:03:00-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 272 seconds]
20150928 05:03:18-!- oldlaptop [~quassel@50.36.238.180] has quit [Ping timeout: 240 seconds]
20150928 05:03:43< celticminstrel> Second and third errors... uh... that's annoying.
20150928 05:04:07< celticminstrel> I think I ran into that in the lua-vconfig branch, too.
20150928 05:04:43< vultraz> I need to go, I'll be back later
20150928 05:13:03< celticminstrel> One solution would be pointers, though I don't really recommend this in general...
20150928 05:13:27-!- oldlaptop [~quassel@50.36.238.180] has joined #wesnoth-dev
20150928 05:14:00< celticminstrel> I wonder, why are the various config iterators not default-constructible?
20150928 05:15:42< celticminstrel> Is it an oversight, or by design?
20150928 05:17:22< celticminstrel> The underlying vector/map/whatever iterators are default-constructible.
20150928 05:18:05-!- Kwandulin [~Miranda@91.0.159.110] has joined #wesnoth-dev
20150928 05:21:02-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20150928 05:39:14< celticminstrel> Another possibility would be to drop the difficulty_tags variable and, if the campaign uses the new format, just copy all the tags into the temp_cfg.
20150928 05:39:30< celticminstrel> I think there might even be a function that exactly does that.
20150928 06:32:31-!- [Relic] [~Relic]@2602:306:33a3:6d30:8dfb:e277:b4ae:cd45] has quit [Quit: I press the magic X and all the weirdos go away!]
20150928 06:41:35-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 264 seconds]
20150928 06:46:18-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20150928 06:52:42-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150928 07:05:53-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150928 07:35:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20150928 07:49:01-!- genbattle [~genbattle@122-57-90-134.jetstream.xtra.co.nz] has joined #wesnoth-dev
20150928 08:06:11-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 264 seconds]
20150928 08:07:53-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20150928 08:26:57-!- irker966 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20150928 08:26:57< irker966> wesnoth: Wedge009 wesnoth:master 6d45a26ee2ab / data/campaigns/Northern_Rebirth/scenarios/05a_01_The_Pursuit.cfg: affect/effect correction http://git.io/vckUt
20150928 08:26:57< irker966> wesnoth: Wedge009 wesnoth:master e0b3e63b02ee / data/campaigns/Sceptre_of_Fire/scenarios/6_Towards_the_Caves.cfg: Added another missing apostrophe http://git.io/vckUq
20150928 08:26:58< irker966> wesnoth: Wedge009 wesnoth:master 865280367568 / data/campaigns/The_Hammer_of_Thursagan/scenarios/07_Mages_and_Drakes.cfg: Correcting a presumed copy-paste error http://git.io/vckUm
20150928 08:26:59< irker966> wesnoth: Wedge009 wesnoth:master 69202648e773 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: Correction mis-spelling of plus http://git.io/vckUY
20150928 08:27:00< irker966> wesnoth: Charles Dang wesnoth:master cf49e2407001 / data/campaigns/ (4 files in 4 dirs): Merge pull request #511 from Wedge009/Spelling_corrections http://git.io/vckUO
20150928 08:27:16< wedge009> Thanks, that was quick.
20150928 08:29:25< vultraz> You didn't fix the issue in ThoT S8, though
20150928 08:30:52< wedge009> I know, not sure about that one. Does the #if EASY... etc need to wrap around the entire [message] block, or can it be done on a per-line basis?
20150928 08:30:57< wedge009> Feel free to fix it. (:
20150928 08:32:31< vultraz> you can put preprocessor defines around anything
20150928 08:35:41< wedge009> I didn't know if it's a WML construct or using general preprocessor directives. The example I saw in scenario 8 wrapped it around the whole message block.
20150928 08:38:56-!- mjs-de [~mjs-de@x4db6b126.dyn.telefonica.de] has joined #wesnoth-dev
20150928 08:39:20-!- Kwandulin [~Miranda@91.0.159.110] has quit [Read error: Connection reset by peer]
20150928 08:57:09< vultraz> that's usually the standard, yed
20150928 08:57:21< vultraz> I'll fix it later
20150928 08:57:29< vultraz> right now I have all my difficulty syntax commits on master :P
20150928 08:58:56< wedge009> Okay.
20150928 09:00:34< wedge009> Aginor and anyone else interested in SDL2 development: I'
20150928 09:00:38< wedge009> Argh.
20150928 09:00:48< wedge009> Stupid apostrophe + enter fumble.
20150928 09:02:49< wedge009> Aginor and anyone else interested in SDL2 development: I've finished documenting the lingering SDL2 bugs I've encountered: https://gna.org/bugs/?23908, https://gna.org/bugs/?23909, https://gna.org/bugs/?23910. If the first one can be solved, I think we could be close to a release state.
20150928 09:18:14-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 272 seconds]
20150928 09:21:14-!- Kwandulin [~Miranda@p5B009F6E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150928 09:30:06-!- joet [~joet@host86-163-222-10.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150928 09:36:23-!- travis-ci [~travis-ci@ec2-54-158-171-82.compute-1.amazonaws.com] has joined #wesnoth-dev
20150928 09:36:24< travis-ci> wesnoth/wesnoth#7523 (master - cf49e24 : Charles Dang): The build has errored.
20150928 09:36:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/82512709
20150928 09:36:24-!- travis-ci [~travis-ci@ec2-54-158-171-82.compute-1.amazonaws.com] has left #wesnoth-dev []
20150928 09:38:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20150928 09:38:53-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150928 09:48:19-!- genbattle [~genbattle@122-57-90-134.jetstream.xtra.co.nz] has quit [Ping timeout: 246 seconds]
20150928 09:49:51-!- Appleman1234 [~Appleman1@KD111239005185.au-net.ne.jp] has joined #wesnoth-dev
20150928 10:04:44-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20150928 10:07:37< aquileia> wedge009, Aginor: Shouldn't we be using packaging/windows/wesnoth-icon.ico for the system icon on Windows? It contains the hand-crafted 16x16 logo by LordBob
20150928 10:08:51< vultraz> Are you sure it's a good idea to use that?
20150928 10:08:56< vultraz> The scaled 16x16 looks just as good
20150928 10:10:37< vultraz> But if you are going with that, then yeah, the ico file should be used
20150928 10:11:08< aquileia> We don't have to use it, but it'd be more consistent
20150928 10:12:45< aquileia> If http://stackoverflow.com/questions/19311609 is correct, Windows would be using the icon resource automatically if SDL wasn't overwriting it...
20150928 10:13:34-!- Appleman1234 [~Appleman1@KD111239005185.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20150928 10:13:58< aquileia> But well, it's not a problem either way - most people probably use fullscreen anyhow and never notice
20150928 10:16:25-!- Kwandulin [~Miranda@p5B009F6E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150928 10:19:47< vultraz> code y u nooo compilleee
20150928 10:19:57-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Quit: Page closed]
20150928 10:20:27-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150928 10:21:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150928 10:21:38-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20150928 10:22:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20150928 10:23:00-!- wedge010 is now known as wedge009
20150928 10:24:16< aquileia> shadowm: BTW, your version info dialog is a bit tight to accomodate for translations... a horizontal scrollbar appears e.g. for the German localization. Can GUI 2 grow the dialog size itself, or only the widgets inside?
20150928 10:28:23-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Quit: Page closed]
20150928 10:58:12< vultraz> I'm really stumped with this const thing
20150928 10:58:35< vultraz> Aginor: perhaps you have some ideas?
20150928 11:10:34-!- Appleman1234 [~Appleman1@KD111239029224.au-net.ne.jp] has joined #wesnoth-dev
20150928 11:18:02< Aginor> aquileia: I still havent set up a build environment in Windows so I can test. wedge009 would you be able to test what happens when SDL_SetWindowIcon() isn't called?
20150928 11:18:25< Aginor> vultraz: for the const thing?
20150928 11:18:31< vultraz> Yes
20150928 11:18:38 * Aginor reads more backlog
20150928 11:18:58< vultraz> http://pastebin.com/LfrHj8QP
20150928 11:19:19< vultraz> https://github.com/wesnoth/wesnoth/compare/master...Vultraz:master
20150928 11:21:35< Aginor> ummm
20150928 11:23:58< Aginor> looks slightly annoying
20150928 11:24:06< Aginor> and I am on my way to bed :)
20150928 11:24:32< Aginor> wedge009 summoned me by poking me about bugs via email (and gna)
20150928 11:25:23< Aginor> vultraz: ok, I think that the iterator for your config is returning const campaigns
20150928 11:25:55< Aginor> hence, you are discarding that in your loop variable, saying that "I'm going to modify this campaign instance"
20150928 11:26:47< Aginor> in other words, make it a const config &campaign
20150928 11:27:12< Aginor> I'd have to open the code to be able to say for 100% sure though
20150928 11:27:32-!- irker966 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20150928 11:29:42< vultraz> Aginor: but you can't add a child to campaign then
20150928 11:33:06< Aginor> that's true
20150928 11:33:23< Aginor> if you want to modify it you'll have to cast it to a non-const
20150928 11:34:38< Aginor> I hope that points you in the right direction, I really need to go to bed, I have to get up early tomorrow and it's rather late
20150928 11:34:58< Aginor> I'm happy to try to do some pair programming tomorrow if you are still having issues :)
20150928 11:35:50< vultraz> Ok
20150928 11:35:52< vultraz> thanks
20150928 11:36:47< wedge009> Aginor:  Sorry, it wasn't my intention to 'summon' you, just leaving messages for when you were next available. Sleep well.
20150928 11:37:11< wedge009> Aginor: Disabling SDL_SetWindowIcon() seems to result in no Wesnoth icon, only the generic Windows executable one.
20150928 11:37:53< wedge009> aquileia: Happens in French, too, and I'm sure lots of other languages.
20150928 11:37:58< Aginor> wedge009: no worries, I ust figured I'd close the bug before I forgot about it again
20150928 11:38:15< Aginor> wedge009: thanks for raisingand chaising bugs
20150928 11:39:18< Aginor> wedge009: thanks for trying that. Could you also try using a different icon so see if it makes a difference? - Preferably borrowing a known-good one so we can rule out an issue with wesnoth's icon
20150928 11:39:35< wedge009> Aginor: Okay. Now go to bed!
20150928 11:39:38 * Aginor disappears
20150928 11:39:49< Aginor> wedge009: thanks for your help and raising the bugs :)
20150928 11:41:00-!- gfgtdf [~chatzilla@f054164173.adsl.alicedsl.de] has joined #wesnoth-dev
20150928 11:46:09-!- Appleman1234 [~Appleman1@KD111239029224.au-net.ne.jp] has quit [Ping timeout: 255 seconds]
20150928 11:59:02< gfgtdf> vultraz: i think it might be easier to just pass the capaign config& to the difficulcy dialogs and do the backwards compability there, so that you dont have to do it in all codes that use that dialog. In the worst case you can have a config cfg_; member in tcpaigndifficulcy to which the capagn tag is then copied
20150928 11:59:38-!- gfgtdf [~chatzilla@f054164173.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 40.0.3/20150826023504]]
20150928 12:22:10< wedge009> Aginor: I tried the wesnoth-icon.ico that aquileia mentioned, but it seems the image loader cannot handle ico format. I tried icon-editor.png and got the same results. It's starting to look like another timing issue, as many non-deterministic bugs are. Running in debug mode seems to always produce the system icon. Adding SDL_Delay() helps but does not guarantee the appearance of the icon.
20150928 12:22:49< wedge009> I see a comment at line 401 of game_launcher.cpp where what looks like the SDL 1.2 version of the set-icon function is called, which seems to suggest some sort of timing issue.
20150928 12:37:24-!- Kwandulin [~Miranda@p5B009F6E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150928 12:43:00-!- louis94 [~~louis94@91.178.60.14] has joined #wesnoth-dev
20150928 12:43:33-!- Appleman1234 [~Appleman1@KD106161093069.au-net.ne.jp] has joined #wesnoth-dev
20150928 12:56:29< vultraz> hmmm
20150928 12:56:35< vultraz> that might have merit...
20150928 12:57:27< vultraz> It would reduce soem code duplication
20150928 13:02:46< shadowm> aquileia: It can do the former but I don't want it to do that, hence the maximum dimensions set in the config. The horizontal scrollbar is a symptom of a number of architectural framework limitations that we want to solve in the short term.
20150928 13:05:03< shadowm> wedge009: It's not about timing with SDL 1.2, it's about 1) having SDL initialize any internal structures needed for the call; 2) not create a window until th call is done because of shenanigans.
20150928 13:06:53< shadowm> The official documentation only lists 2 as a requirement. No idea if 1 is just a Wesnoth developer's guess, an older limitation that was lifted at some point, or an undocumented quirk. https://www.libsdl.org/release/SDL-1.2.15/docs/html/sdlwmseticon.html
20150928 13:08:28< shadowm> Also, since it's 1.2 and not 2.0, this stuff may no longer be relevant. Architecturally-wise on Windows (and pretty sure X11 as well) there's nothing to prevent you from changing an existing window's icon, as anyone who's used Windows Explorer before can tell.
20150928 13:10:50-!- louis94 [~~louis94@91.178.60.14] has quit [Quit: Konversation terminated!]
20150928 13:13:48< vultraz> Ok, I'm going to go with something a little different...
20150928 13:14:12< vultraz> Going to see if I can pass a config to the constructor and then initialize certain private variables from it
20150928 13:14:18< vultraz> I think that's valid
20150928 13:23:51-!- louis94 [~~louis94@91.178.60.14] has joined #wesnoth-dev
20150928 13:28:18-!- louis94 [~~louis94@91.178.60.14] has quit [Client Quit]
20150928 13:41:25< vultraz> BLAGH
20150928 13:41:39< vultraz> t(-_-t) iterators
20150928 13:43:08-!- mjs-de [~mjs-de@x4db6b126.dyn.telefonica.de] has quit [Remote host closed the connection]
20150928 13:48:02-!- Kwandulin [~Miranda@p5B009F6E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150928 13:50:36-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20150928 13:56:33< vultraz> can't you refer to a specific index in a config? D:
20150928 13:59:39-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20150928 14:05:21< vultraz> I see no reason why you couldn't refer to the nth child of a config
20150928 14:08:41< iceiceice> vultraz: how do you want to do it? like `cfg[n]` ?
20150928 14:09:06< iceiceice> vultraz: this exists:
20150928 14:09:06< iceiceice> const config &operator[](Itor::difference_type n) const { return *i_[n]; }
20150928 14:09:51< vultraz> I don't know how to read that
20150928 14:11:45< iceiceice> vultraz: that says that, if you have a `child_iterator` and you use `[]` syntax with it, and pass it `Itor::difference_type) in the braces, you get a reference to `*i_[n]` which is the `n`'th child
20150928 14:11:59< iceiceice> have to look up `Itor::difference_type tobe sure what it is, but probably it's int or something`
20150928 14:12:24< vultraz> Only from an iterator?
20150928 14:12:59< iceiceice> yeah its actually a bit strange syntax
20150928 14:13:09< iceiceice> also the `all_children` iterator doesn't support this
20150928 14:13:19< iceiceice> not sure ifthat's an oversight or what
20150928 14:14:32< iceiceice> vultraz: i guess what i would do to get nth child is like
20150928 14:15:03< iceiceice> auto range = cfg.child_range("key");
20150928 14:15:15< vultraz> earlier celmin showed me selected_difficulty_ = difficulties_.first[list.get_selected_row()]["define"].str();
20150928 14:15:30< iceiceice> const auto & nth_child = *(range.first + n);
20150928 14:16:56< iceiceice> yeah i dont know
20150928 14:17:06< iceiceice> vultraz: its not terribly common that you need to get n'th child of some kind i guess
20150928 14:17:06-!- [Relic] [~Relic]@2602:306:33a3:6d30:4021:3c1a:787:e9d] has joined #wesnoth-dev
20150928 14:17:19< iceiceice> the config class is probably a bit over-engineered
20150928 14:18:25< vultraz> im changing some code around, and difficulties_ is now a config instead of a config::child_itor
20150928 14:21:38< vultraz> and I can't cast a config as an iterator :/
20150928 14:27:53< vultraz> ok, I did this
20150928 14:27:56< vultraz> 	const config::child_itors di = difficulties_.child_range("difficulty");
20150928 14:27:58< vultraz> 	selected_difficulty_ = di.first[list.get_selected_row()]["define"].str();
20150928 14:28:44-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20150928 14:28:57-!- gfgtdf [~chatzilla@x55b1133a.dyn.telefonica.de] has joined #wesnoth-dev
20150928 14:29:04< vultraz> for some reason const config::child_itors di = difficulties_.all_children_range(); doesn't work
20150928 14:29:07< vultraz> me shrugs
20150928 14:29:33< gfgtdf> vultraz: why do you want all child range ? 
20150928 14:29:36-!- ancestral [~ancestral@63.92.240.233] has quit [Client Quit]
20150928 14:30:38< vultraz> gfgtdf: since the config is all [difficulty] children
20150928 14:31:19< gfgtdf> vultraz: you shouldnt assume that. Also even if thats teh case there is no reason to use all_children_range() over child_Range("difficulcy")
20150928 14:31:24< vultraz> ok
20150928 14:31:49< vultraz> anyway I took your advice and moved some of the code to tcampaign_difficulty
20150928 14:32:07< gfgtdf> vultraz: also rmeember that in current master [campaign] alo suppoets [event]s childs, any it isnt unlikeley that in some future more chuilds are added,
20150928 14:32:36< vultraz> gfgtdf: it's a local class config
20150928 14:32:40< vultraz> difficulties_.append_children(campaign, "difficulty");
20150928 14:32:45< gfgtdf> vultraz: ah ok
20150928 14:33:55< gfgtdf> vultraz: to get a specif chidl you can just write difficulties_.child("difficulty", <number>)
20150928 14:34:20< vultraz> number is index?
20150928 14:34:28< gfgtdf> vultraz: yes
20150928 14:36:56< vultraz> can you get a specific key from that also?
20150928 14:38:47< gfgtdf> vultraz: uhm yes sure it returns a config you can just use .child("asdad", 467567)["mykey"]
20150928 14:38:54< vultraz> oh ok
20150928 14:38:55< vultraz> thanks
20150928 14:44:07< vultraz> ok, everything builds
20150928 14:44:18< vultraz> an issue with the old-style parsing for some reason, though
20150928 14:44:23< vultraz> only first row gets parsed...
20150928 14:51:39-!- Appleman1234 [~Appleman1@KD106161093069.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20150928 14:52:38-!- Kwandulin [~Miranda@p5B009F6E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20150928 14:53:09< vultraz> pushed what I have to my branch, will try to fix that tomorrow
20150928 15:39:20-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20150928 15:48:53-!- Appleman1234 [~Appleman1@KD118156240088.au-net.ne.jp] has joined #wesnoth-dev
20150928 15:57:56-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20150928 16:00:10-!- fabi [~quassel@176.4.8.1] has joined #wesnoth-dev
20150928 16:00:10-!- fabi [~quassel@176.4.8.1] has quit [Changing host]
20150928 16:00:10-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150928 16:07:15-!- mjs-de [~mjs-de@vpn03025.itmc.tu-dortmund.de] has joined #wesnoth-dev
20150928 16:24:33-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20150928 16:30:30-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20150928 16:40:32< celticminstrel> vultraz: Moving it to the tcampaign_difficulty constructor still won't prevent code duplication. You're forgetting about [message][option] again.
20150928 16:47:34-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20150928 16:54:01-!- Jozrael [~Jozrael@192.91.144.16] has joined #wesnoth-dev
20150928 17:04:16< gfgtdf> celticminstrel: what do you want to change about [message][option]?
20150928 17:05:15< gfgtdf> celticminstrel: indpendent i'd think that compability code about mjessage would go to lua anyway so i dont think hed have to write that code a second time in c++.
20150928 17:07:52-!- gfgtdf [~chatzilla@x55b1133a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0/20150917150946]]
20150928 17:10:51-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150928 17:11:09-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20150928 17:11:10-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20150928 17:11:10-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150928 17:11:26< celticminstrel> gfgtdf: Whether written in Lua or C++, it'll still have to be very similar code.
20150928 17:47:48-!- Appleman1234 [~Appleman1@KD118156240088.au-net.ne.jp] has quit [Ping timeout: 264 seconds]
20150928 17:52:13-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150928 17:54:52-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20150928 17:59:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20150928 18:01:52-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20150928 18:05:35-!- mjs-de [~mjs-de@vpn03025.itmc.tu-dortmund.de] has quit [Ping timeout: 264 seconds]
20150928 18:08:26-!- gfgtdf [~chatzilla@x55b1133a.dyn.telefonica.de] has joined #wesnoth-dev
20150928 18:10:10< gfgtdf> celticminstrel: yes but my point was that is not possible to remove this duplication completeley, and my moving thiis code to the constructor you still save code. Even if you would somehow have a c++ code for this compability and expose that to lua that's mostlikley more work than rewriting that code in lua,.
20150928 18:10:59-!- joet [~joet@host86-163-222-10.range86-163.btcentralplus.com] has quit [Ping timeout: 264 seconds]
20150928 18:16:22< celticminstrel> True, moving it there does reduce the duplication even if it doesn't eliminate it.
20150928 18:30:38-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20150928 18:39:31-!- Netsplit *.net <-> *.split quits: AI0867, matthiaskrgr
20150928 18:39:33-!- Netsplit over, joins: AI0867
20150928 18:40:05-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-rbcpswwhkixpwevt] has joined #wesnoth-dev
20150928 18:40:28-!- matthiaskrgr is now known as Guest38326
20150928 18:40:43-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20150928 18:43:55-!- ancestral [~ancestral@206.104.135.28] has joined #wesnoth-dev
20150928 18:44:52-!- Appleman1234 [~Appleman1@KD111239020182.au-net.ne.jp] has joined #wesnoth-dev
20150928 18:45:46-!- Kwandulin [~Miranda@p5B009F6E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20150928 18:49:54-!- Guest38326 [matthiaskr@gateway/shell/panicbnc/x-rbcpswwhkixpwevt] has quit [Changing host]
20150928 18:49:54-!- Guest38326 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20150928 18:49:54-!- Guest38326 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20150928 18:49:54-!- Guest38326 [matthiaskr@gateway/shell/panicbnc/x-rbcpswwhkixpwevt] has joined #wesnoth-dev
20150928 18:51:06-!- Guest38326 is now known as matth1askrgr
20150928 19:00:46-!- ancestral [~ancestral@206.104.135.28] has quit [Quit: i go nstuf kthxbai]
20150928 19:07:25-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Quit: No Ping reply in 180 seconds.]
20150928 19:08:50-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20150928 19:15:47-!- Appleman1234 [~Appleman1@KD111239020182.au-net.ne.jp] has quit [Ping timeout: 264 seconds]
20150928 19:16:59< gfgtdf> celticminstrel: you have an opinion about https://gna.org/bugs/?23901 ?
20150928 19:18:44< celticminstrel> Hm, so if that were added and someone pressed escape, would wesnoth.show_message_dialog() return 0 or -2?
20150928 19:20:19< celticminstrel> Alternate idea: Add escape= key to [option] so that pressing escape is equivalent to selecting that option.
20150928 19:21:07< celticminstrel> On the other hand, what about when there's a text input? Both with options and without options.
20150928 19:21:17< gfgtdf> celticminstrel: y i thought of that too note sure which one is the better option though.
20150928 19:21:51< gfgtdf> celticminstrel: (that was an answer to your seconds comment)
20150928 19:21:56< celticminstrel> I don't think an [escape] tag would need a [command] subtag.
20150928 19:22:20< celticminstrel> But maybe for consistency it's good?
20150928 19:23:10< celticminstrel> Another possibility for [option]escape= is for it to not add an option to the list, and just handle the escape key.
20150928 19:27:12< celticminstrel> There's also the question of how this is passed into show_message_dialog.
20150928 19:27:33< celticminstrel> escape=yes key in the options list?
20150928 19:28:02< celticminstrel> Or escape=index for the second version.
20150928 19:28:19< celticminstrel> Or just nothing, but return -2.
20150928 19:28:37< gfgtdf> celticminstrel: in currently in favour of escape=index  for teh secidns version
20150928 19:28:45< gfgtdf> celticminstrel: not sure thozgh
20150928 19:28:53< celticminstrel> Wait no, there can't be nothing. There at least has to be an indication that escaping is allowed.
20150928 19:34:13< gfgtdf> celticminstrel: i think the question is whether there are usecases how having options only accesible by pressing escape.
20150928 19:49:07-!- joet [~joet@host86-163-222-10.range86-163.btcentralplus.com] has joined #wesnoth-dev
20150928 19:50:24-!- joet [~joet@host86-163-222-10.range86-163.btcentralplus.com] has quit [Client Quit]
20150928 20:12:08-!- Appleman1234 [~Appleman1@KD106161093116.au-net.ne.jp] has joined #wesnoth-dev
20150928 20:22:35< vultraz> celticminstrel: if anything, it reduces it between the create engine and the savegames
20150928 20:22:50 * celticminstrel nods.
20150928 20:25:46< vultraz> Plus, it circumvents all those iterator problems :D
20150928 20:26:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150928 20:31:49-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20150928 20:32:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20150928 20:34:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20150928 20:34:18< vultraz> everything seems working :D
20150928 20:36:57< gfgtdf> vultraz: you'll make a pr ?
20150928 20:37:04< vultraz> yes
20150928 20:37:24< vultraz> I need to rebase everything first and also convert mainline campaigns to the new syntax
20150928 20:39:24< gfgtdf> vultraz: i wonder why we have the 'Akip Animation' option only in replays, i think tghis woudl also be quiet useful in sp or mp games
20150928 20:39:54< gfgtdf> (actually i typed the vultraz: there accidently that was a meessage for everyone)
20150928 20:40:07< gfgtdf> any opinions anyone ?
20150928 20:43:36< celticminstrel> Eh.
20150928 20:45:52< gfgtdf> i meant 'Skip Animatoins' 
20150928 20:45:58< celticminstrel> I know.
20150928 20:46:44< celticminstrel> I think skipping animations would make it really hard to figure out what's going on.
20150928 20:48:10< gfgtdf> celticminstrel: It's of course a optional feature like it is on replays.
20150928 20:48:43< celticminstrel> It's less important to know what's going on in replays.
20150928 20:51:22< gfgtdf> celticminstrel: Still you sometimes want to skip over moves, for example when the ai does verymuch moves or when i am observing a mp game.
20150928 20:52:05< celticminstrel> Why would you want to do that?
20150928 20:52:19< gfgtdf> celticminstrel: to make it faster ?
20150928 20:52:35< celticminstrel> Accelerated speed does that without obfuscating what's actually happening.
20150928 20:53:05< celticminstrel> Though neither way would help when you're observing an MP game.
20150928 20:53:12< celticminstrel> Because there the speed is limited by the player.
20150928 20:53:16< gfgtdf> celticminstrel:Skop replays is still faster, also sko p replays also automacically skips messages
20150928 20:53:39< celticminstrel> Skip replays isn't the same as skip animations, is it?
20150928 20:53:49< gfgtdf> celticminstrel: i think its teh same
20150928 20:55:19< celticminstrel> Then I'm against it.
20150928 20:55:35< celticminstrel> Skipping replays indicates you don't care what happened before, you just want to see what's happening now.
20150928 20:57:46< gfgtdf> celticminstrel: why?
20150928 21:06:23-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20150928 21:17:14< vultraz> zookeeper: is it alright if we have a macro like this? http://pastebin.com/9F6uMujM I know we've been transitioning away from that 'all arguments' style
20150928 21:18:15< celticminstrel> What style?
20150928 21:19:00< celticminstrel> Also: #defined CAMPAIGN_DEFAULT_DIFFICULTY [+difficulty]default=yes[/difficulty] #enddef
20150928 21:19:05< celticminstrel> ^-d
20150928 21:19:14< celticminstrel> (Or something like that.)
20150928 21:19:51< vultraz> celticminstrel: a macro that's solely a tag you provide all arguments for with no hardcoded values
20150928 21:22:31< vultraz> however I think in this case as a syntax shortcut and easier transition it might be ok
20150928 21:22:35< vultraz> just asking zookeeper tho
20150928 21:25:03< celticminstrel> Don't forget a way to set default= though
20150928 21:26:36< vultraz> I was thinking exactly what you proposed
20150928 21:27:04-!- louis94 [~~louis94@91.178.60.14] has joined #wesnoth-dev
20150928 21:28:27-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has quit [Ping timeout: 255 seconds]
20150928 21:29:15< zookeeper> vultraz, sure, seems ok. why are we doing that whole thing in the first place? i recall seeing someone discuss it, but i don't know the details.
20150928 21:33:20< vultraz> zookeeper: the old syntax is very confusing 
20150928 21:36:26-!- yo [d80e0d74@gateway/web/freenode/ip.216.14.13.116] has joined #wesnoth-dev
20150928 21:36:50-!- yo is now known as Guest60681
20150928 21:37:06-!- Guest60681 [d80e0d74@gateway/web/freenode/ip.216.14.13.116] has quit [Client Quit]
20150928 21:40:34-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has joined #wesnoth-dev
20150928 22:14:05< vultraz> celticminstrel: PR 512 open :D
20150928 22:15:08< celticminstrel> 'kay
20150928 22:15:18< celticminstrel> You going to look at my PRs too?
20150928 22:16:31< vultraz> 507?
20150928 22:16:55< celticminstrel> I think that and 501? Something like that.
20150928 22:17:19< vultraz> I don't understand enough what 507 does to comment
20150928 22:18:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds]
20150928 22:19:14< vultraz> as for 501...
20150928 22:19:45< vultraz> so we'd now be able to say unit:put()? instead of wesnoth.put_unit(unit)?
20150928 22:20:07< celticminstrel> Yeah.
20150928 22:20:25< vultraz> No problem with that
20150928 22:20:28-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20150928 22:20:35< celticminstrel> 7 means we can do for i,cfg in ipairs(cfg)
20150928 22:20:39< celticminstrel> ^507
20150928 22:21:22< celticminstrel> And for k,v in pairs(cfg)
20150928 22:21:27< celticminstrel> Even when cfg is a vconfig.
20150928 22:21:56< vultraz> Only issue I might see with 501 is if someone relied on something being passed to put_unit being either populated or null
20150928 22:22:03 * celticminstrel somehow got a ^C in that line leading to the 50 being interpreted as a colour code. :/
20150928 22:22:13< celticminstrel> Populated or null?
20150928 22:23:15< celticminstrel> So, they have a variable which may be nil, and pass it to put_unit expecting it to add/delete?
20150928 22:23:30-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20150928 22:23:30-!- wedge010 is now known as wedge009
20150928 22:23:46< vultraz> Yes
20150928 22:24:12< celticminstrel> Well, I haven't removed anything. so that'll still work for now (just give a deprecated message).
20150928 22:24:36< vultraz> Ok
20150928 22:25:16< vultraz> In which case I don't have any objections
20150928 22:32:16 * vultraz pings shadowm in case he wants to review my PR too
20150928 22:45:19-!- gfgtdf [~chatzilla@x55b1133a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0/20150917150946]]
20150928 22:48:15-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20150928 23:11:28-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20150928 23:16:49-!- louis94 [~~louis94@91.178.60.14] has quit [Quit: Konversation terminated!]
--- Log closed Tue Sep 29 00:00:46 2015