--- Log opened Sat Oct 03 00:00:16 2015
20151003 00:29:36-!- Appleman1234 [~Appleman1@KD111239019068.au-net.ne.jp] has joined #wesnoth-dev
20151003 00:38:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20151003 00:43:12-!- MotorMe [~MotorMe@27.189.16.46] has joined #wesnoth-dev
20151003 00:46:36-!- louis94 [~~louis94@109.129.205.202] has quit [Quit: Konversation terminated!]
20151003 00:47:18-!- MotorMe [~MotorMe@27.189.16.46] has quit [Ping timeout: 240 seconds]
20151003 00:47:45-!- jinblack_ [~jinblack@128.111.48.6] has joined #wesnoth-dev
20151003 01:01:23-!- Appleman1234 [~Appleman1@KD111239019068.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20151003 01:34:24-!- gfgtdf [~chatzilla@f054063163.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0.1/20150929144111]]
20151003 01:58:17-!- Appleman1234 [~Appleman1@KD106161085209.au-net.ne.jp] has joined #wesnoth-dev
20151003 02:01:26-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Read error: Connection reset by peer]
20151003 02:01:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20151003 02:19:07-!- [Relic] [~Relic]@2602:306:33a3:6d30:9433:16c8:84a9:c6bf] has quit [Quit: I press the magic X and all the weirdos go away!]
20151003 02:57:49-!- Appleman1234 [~Appleman1@KD106161085209.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20151003 03:02:00-!- genbattle [~genbattle@122-57-89-170.jetstream.xtra.co.nz] has quit [Ping timeout: 250 seconds]
20151003 03:03:13< shadowm> I would like to clarify that my prolonged absence is not a consequence of any recent natural disasters.
20151003 03:03:56< celticminstrel> Heh.
20151003 03:04:01< celticminstrel> Good to know.
20151003 03:18:35< vultraz> Indeed
20151003 04:11:11-!- Appleman1234 [~Appleman1@KD111239009160.au-net.ne.jp] has joined #wesnoth-dev
20151003 04:36:26-!- Appleman1234 [~Appleman1@KD111239009160.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20151003 05:14:10-!- jinblack_ [~jinblack@128.111.48.6] has quit [Remote host closed the connection]
20151003 05:24:01-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20151003 05:24:18-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151003 05:33:53-!- Appleman1234 [~Appleman1@KD118156243039.au-net.ne.jp] has joined #wesnoth-dev
20151003 06:08:46-!- Appleman1234 [~Appleman1@KD118156243039.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20151003 06:19:10-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20151003 06:21:34< zookeeper> Elvish_Hunter, why would wmllint need to handle it? it's not like we have any reason to drop support for difficulty_descriptions as far as i know.
20151003 06:24:46-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20151003 06:25:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151003 06:26:45< celticminstrel> I'd suggest doing it eventually.
20151003 06:27:01< celticminstrel> But certainly not for 1.14.
20151003 06:30:04< vultraz> should we add a deprecation warning?
20151003 06:30:32< celticminstrel> I dunno. I did add one for [option].
20151003 06:30:55< vultraz> as I mentioned in my pr i don't know how to display one
20151003 06:31:02< vultraz> since it's before the game
20151003 06:32:11< vultraz> it's used*
20151003 06:35:03< zookeeper> i'd not add even deprecation warnings until 1.15
20151003 06:35:21< vultraz> oh?
20151003 06:36:04< vultraz> but why
20151003 06:36:16< zookeeper> no
20151003 06:36:25< zookeeper> why do you want to break the old syntax for no reason?
20151003 06:37:07< vultraz> since the todo notes said a new syntax would be better
20151003 06:37:13< vultraz> plus it's less confusing
20151003 06:38:32< zookeeper> i think it's a lot less confusing when your code just works as it has always worked before
20151003 06:50:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 252 seconds]
20151003 06:51:55-!- Kwandulin [~Miranda@p5B0099FC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151003 06:52:35-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151003 06:53:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20151003 06:53:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151003 06:56:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20151003 06:59:02-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151003 07:05:16-!- Appleman1234 [~Appleman1@KD118156243229.au-net.ne.jp] has joined #wesnoth-dev
20151003 07:05:34-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20151003 07:32:40-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151003 07:37:05-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151003 07:44:32-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: Smell ya later]
20151003 08:23:31-!- Appleman1234 [~Appleman1@KD118156243229.au-net.ne.jp] has quit [Ping timeout: 272 seconds]
20151003 08:45:59-!- markus_ [~mjs-de@f049099102.adsl.alicedsl.de] has joined #wesnoth-dev
20151003 09:03:36-!- markus_ is now known as mjs-de
20151003 09:12:35-!- celticminstrel is now known as celmin|sleep
20151003 09:19:28-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20151003 09:36:16-!- Appleman1234 [~Appleman1@KD118156243229.au-net.ne.jp] has joined #wesnoth-dev
20151003 09:47:25< vultraz> zookeeper: 1.13 is a release that's going to change a *lot* of stuff. It might as well be done with everything else as opposed to later
20151003 09:47:28< vultraz> er
20151003 09:47:29< vultraz> 1.14*
20151003 09:48:19< zookeeper> have we ever had a stable series about which you wouldn't have said the same? :>
20151003 09:55:47-!- Kwandulin [~Miranda@p5B0099FC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151003 10:04:36-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Disconnecting from stoned server.]
20151003 10:04:52-!- Ivanovic [~ivanovic@p4FC536BE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151003 10:26:25-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20151003 10:31:48< Aginor> just a quick update: I have a fix for the SDL2 resize crash, but I'm trying to figure out the proper way to handle resize events for both SDL2 AND sdl1.2. Wesnoth is doing something funny there that I'm struggling to fix properly.
20151003 11:05:10-!- oldlaptop [~quassel@50.36.238.180] has quit [Remote host closed the connection]
20151003 11:07:16-!- oldlaptop [~quassel@50.36.238.180] has joined #wesnoth-dev
20151003 11:25:14-!- Ivanovic [~ivanovic@p4FC536BE.dip0.t-ipconnect.de] has quit [Changing host]
20151003 11:25:14-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20151003 11:26:41< vultraz> zookeeper: eh, touche :P
20151003 11:46:44-!- gfgtdf [~chatzilla@f054054087.adsl.alicedsl.de] has joined #wesnoth-dev
20151003 11:47:37< gfgtdf> i think we should add a deprecation warning for difficulcydescription at leastin stderr
20151003 11:48:19-!- Kwandulin [~Miranda@p5B0099FC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151003 11:48:24< gfgtdf> does anone hereknow why boost::variant needs itstypes to be copy constructable?
20151003 11:49:21< gfgtdf> i'd like to use boost::variant but since it needs it types to be copy cosructable i fear that is does a lof of useless copies of its values :/
20151003 11:52:30-!- louis94 [~~louis94@109.129.205.202] has joined #wesnoth-dev
20151003 12:07:49-!- gfgtdf [~chatzilla@f054054087.adsl.alicedsl.de] has quit [Ping timeout: 246 seconds]
20151003 12:08:58-!- gfgtdf [~chatzilla@f054054087.adsl.alicedsl.de] has joined #wesnoth-dev
20151003 12:09:46-!- gfgtdf [~chatzilla@f054054087.adsl.alicedsl.de] has quit [Client Quit]
20151003 12:16:00-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151003 12:34:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 12:36:02-!- louis94 [~~louis94@109.129.205.202] has quit [Quit: Konversation terminated!]
20151003 12:54:55-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20151003 12:58:09-!- timotei__ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 255 seconds]
20151003 13:00:11-!- ideuler [~textual@a89-153-66-239.cpe.netcabo.pt] has joined #wesnoth-dev
20151003 13:04:00-!- Kwandulin [~Miranda@p5B0099FC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151003 13:05:08-!- ideuler [~textual@a89-153-66-239.cpe.netcabo.pt] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20151003 13:20:46-!- gfgtdf [~chatzilla@f054054087.adsl.alicedsl.de] has joined #wesnoth-dev
20151003 13:22:00-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 255 seconds]
20151003 13:22:01< gfgtdf> zookeeper: you know whether it is in wml possible to specify default values when getting values? someting like name = "$(first_or_second($name_var|, 'name1'))" ?
20151003 13:22:22-!- ideuler [~textual@a89-153-66-239.cpe.netcabo.pt] has joined #wesnoth-dev
20151003 13:22:50< zookeeper> gfgtdf, no, not possible
20151003 13:23:56-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20151003 13:24:13< gfgtdf> zookeeper: hmm i think it should be possible, you have an idea how a syntax for that coudl look like ?
20151003 13:24:51< Ravana_> formula= function that returns 1/0 depending on if argument exists
20151003 13:26:02< gfgtdf> Ravana_: that was an answer on my first or my seond comment ?
20151003 13:26:13< Ravana_> second
20151003 13:27:06< Ravana_> I really missed such function, I knew wesnoth would crash with some values and there was nothing I could do to prevent it
20151003 13:27:56< gfgtdf> Ravana_: so how would the query form my first comment then look like ?
20151003 13:28:51< Ravana_> "if(variable_exists($var_name1),$var_name1,$var_name2)"
20151003 13:32:00< Ravana_> not even variable_exists, more general value_exists
20151003 13:32:11< gfgtdf> Ravana_: hmm ok i think thats a possible option.
20151003 13:34:30< zookeeper> yeah formulas seem like the only sane way
20151003 13:35:54< gfgtdf> hmm the disadvantage is that $var_name1 would need to be evaluated twice
20151003 13:37:39< Ravana_> something like http://vgy.me/h8RwvM.png might be possible too
20151003 13:38:45< gfgtdf> Ravana_: the problem is that "" (empty string) is not the same as nothing usually.
20151003 13:39:41< gfgtdf> is there anywhere a documentation for existing formula functions ?
20151003 13:40:16< zookeeper> are you sure it's not? i mean, maybe there's an internal difference, but i think the usual "does this variable exist or not" check ([if][variable]name,equals=foo,$empty) works the same both on non-existent and empty variables
20151003 13:40:19< Ravana_> http://wiki.wesnoth.org/FormulaAI_Functions
20151003 13:40:57< zookeeper> i guess i'm not completely sure
20151003 13:41:21< gfgtdf> Ravana_: ty
20151003 13:44:54< pydsigner> MFW I get highlighted because someone accidentally typed a a project's name
20151003 13:45:04< vultraz> say what?
20151003 13:45:23< pydsigner> "lof" highlighted be
20151003 13:45:26< pydsigner> ...
20151003 13:45:33< pydsigner> s/a a/a/
20151003 13:45:37< pydsigner> * me
20151003 13:47:08< gfgtdf> zookeeper: y but teh problme is the $( sin($myvar)) gets substituted to $( sin()) regardless of whether $myvar is empty or whether its not existent
20151003 13:47:44< zookeeper> right
20151003 13:48:02< Ravana_> that new function would need to accept no arguments correctly, without crashing
20151003 13:48:44< zookeeper> and you can't just wrap it in an if check of some kind?
20151003 13:49:06< Ravana_> any check checks if the value exists, and since it doesn't, it crashes wesnoth
20151003 13:50:05< zookeeper> right, and that's not something that can just be fixed easily?
20151003 13:51:25< Ravana_> I haven't found any workarounds still
20151003 13:52:00< Ravana_> there is one special case though
20151003 13:52:17< Ravana_> http://forums.wesnoth.org/viewtopic.php?f=21&t=33633&p=576065&hilit=formula#p576065
20151003 13:52:30< Ravana_> when the expected value is number then it can be done
20151003 13:54:30< Ravana_> since - is both unary and binary operator there
20151003 13:57:09< gfgtdf> Ravana_: ok i currently have a nargs formula function that basically returns teh number of arguments oit was called with
20151003 13:57:21< celmin|sleep> gfgtdf: Regarding boost::variant, I'm guessing it requires its types to be copy-constructible so that it can itself be copy-constructible.
20151003 13:58:13< Ravana_> that would be good, as long as it works with no arguments
20151003 13:58:16< gfgtdf> celmin|sleep: hmm but it also has features like 'it is asignable if of its types are asignable' why shodul it be differnt to copy construtable
20151003 13:59:06< celmin|sleep> I don't think it's going to be randomly making copies.
20151003 13:59:46< celmin|sleep> I don't know the exact reasons, but a cursory googling suggests it's something to do with assigning a different type than is currently held.
20151003 14:03:40< gfgtdf> celmin|sleep: hmm im not convinded :s
20151003 14:03:46-!- louis94 [~~louis94@109.129.205.202] has joined #wesnoth-dev
20151003 14:03:47-!- Appleman1234 [~Appleman1@KD118156243229.au-net.ne.jp] has quit [Ping timeout: 268 seconds]
20151003 14:04:24< celmin|sleep> The compiler would likely optimize out any unnecessary copies as well.
20151003 14:07:06< celmin|sleep> boost::variant is basically a safe union.
20151003 14:07:27< celmin|sleep> So it needs to be able to copy-construct the value into its internal memory.
20151003 14:07:37< celmin|sleep> (Presumably using placement new.)
20151003 14:08:35< gfgtdf> Ravana_: wouldn't "if(variable_exists($var_name1),$var_name1,$var_name2)" still fail if var_name1 is empty becase it simply gived an empty expression at the secodns parmater if if teh parmeter is nt used ?
20151003 14:09:22< Ravana_> not sure, needs testing
20151003 14:09:51< gfgtdf> celmin|sleep: if ai have "struct a { a(int){} }" and a "variant<a> b(1);" then id expect that b's inner state is construct in-place using the integer 1 without involing the copy constructor
20151003 14:10:21< celmin|sleep> Um, gfgtdf, that is copy-construction.
20151003 14:10:43< celmin|sleep> Oh wait, I see what you mean.
20151003 14:11:06< celmin|sleep> But I don't think it's possible to guarantee something like that.
20151003 14:11:19< celmin|sleep> The compiler would probably be able to optimize it to that in that specific case.
20151003 14:11:26< Ravana_> fails indeed... needs some other way
20151003 14:11:47< celmin|sleep> Maybe in the case of initial construction it's possible for boost::variant to guarantee it.
20151003 14:11:55< celmin|sleep> Though that might require C++11 features.
20151003 14:13:27-!- roberpot [~roberpot@84.122.85.148.dyn.user.ono.com] has joined #wesnoth-dev
20151003 14:13:38< celmin|sleep> Still, in your example, I'm pretty sure the standard states that first a temporary struct a will be constructed to be passed to the constructor of boost::variant<a>, because boost::variant<a> has a constructor that takes struct a but does not have a constructor that takes int.
20151003 14:14:08< celmin|sleep> I don't think you need to worry about this so much though. Compilers are good at optimizing.
20151003 14:15:34< gfgtdf> Ravana_, zookeeper: maybe we shodul make it directly part of variable subsitution, something like name = "$D(name_var, name1)" ?
20151003 14:15:46< gfgtdf> (d for default her)
20151003 14:18:56< Ravana_> it might look strange, and require reserving certain keyword D from WML variable names, but it would be usable in formulas too, so it could work
20151003 14:20:21-!- celmin|sleep is now known as celticminstrel
20151003 14:22:55-!- Kwandulin [~Miranda@p5B0099FC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151003 14:26:48-!- louis94 [~~louis94@109.129.205.202] has quit [Ping timeout: 264 seconds]
20151003 14:28:34-!- ideuler [~textual@a89-153-66-239.cpe.netcabo.pt] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20151003 14:28:58-!- ideuler [~textual@a89-153-66-239.cpe.netcabo.pt] has joined #wesnoth-dev
20151003 14:35:44< zookeeper> gfgtdf, yeah, something like that could work if the feature is really needed. or a special symbol in variable substitution like $name_var?name1 or something.
20151003 14:36:39< gfgtdf> zookeeper: y that looks een easier
20151003 14:38:44< gfgtdf> even*
20151003 14:46:57< celticminstrel> Just don't use : as the special symbol.
20151003 14:47:15< celticminstrel> Because I already used that for the direction operators specifically because it didn't have a special meaning in variables.
20151003 14:47:50< celticminstrel> zookeeper, gfgtdf: Or $name_var?name1|
20151003 14:48:05< celticminstrel> I think perhaps the | should be required when a default is included.
20151003 14:48:38-!- ideuler [~textual@a89-153-66-239.cpe.netcabo.pt] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20151003 14:48:43< zookeeper> to allow spaces in the default value?
20151003 14:48:56< celticminstrel> Spaces or other special characters, yes.
20151003 14:49:04< zookeeper> sounds reasonable
20151003 14:49:19-!- ideuler [~textual@a89-153-66-239.cpe.netcabo.pt] has joined #wesnoth-dev
20151003 14:49:35-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 14:49:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20151003 14:53:08-!- louis94 [~~louis94@109.129.205.202] has joined #wesnoth-dev
20151003 15:01:42-!- Appleman1234 [~Appleman1@KD118156255109.au-net.ne.jp] has joined #wesnoth-dev
20151003 15:15:16-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20151003 15:23:20-!- fr4ncidir [5d279ec4@gateway/web/freenode/ip.93.39.158.196] has joined #wesnoth-dev
20151003 15:26:43-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Quit: Textual IRC Client: www.textualapp.com]
20151003 15:29:24-!- prkc [~prkc@563BDAA9.dsl.pool.telekom.hu] has joined #wesnoth-dev
20151003 15:31:30-!- fr4ncidir [5d279ec4@gateway/web/freenode/ip.93.39.158.196] has quit [Quit: Page closed]
20151003 15:33:18-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20151003 15:35:01-!- gfgtdf [~chatzilla@f054054087.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0.1/20150929144111]]
20151003 15:35:34-!- Appleman1234 [~Appleman1@KD118156255109.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20151003 15:44:55-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151003 16:09:59-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 252 seconds]
20151003 16:12:47-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20151003 16:27:30-!- irker021 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151003 16:27:30< irker021> wesnoth: Ignacio R. Morelle wesnoth:1.10 055bceaa235d / CMakeLists.txt changelog: cmake: Disable strict compilation by default http://git.io/vcKzn
20151003 16:29:03-!- louis94 [~~louis94@109.129.205.202] has quit [Quit: Konversation terminated!]
20151003 16:29:20-!- louis94 [~~louis94@109.129.205.202] has joined #wesnoth-dev
20151003 16:31:09-!- Kwandulin [~Miranda@p5B0099FC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151003 16:33:18-!- Appleman1234 [~Appleman1@KD111239006171.au-net.ne.jp] has joined #wesnoth-dev
20151003 16:44:10< irker021> wesnoth: Mark de Wever wesnoth:1.8 5925ff0d6e9c / src/gui/auxiliary/event/dispatcher_private.hpp: Fix some parameter shadowing. http://git.io/vcKwr
20151003 16:44:12< irker021> wesnoth: Ignacio R. Morelle wesnoth:1.8 d518e3899d53 / CMakeLists.txt changelog: cmake: Disable strict compilation by default http://git.io/vcKwo
20151003 16:44:15< irker021> wesnoth: Ignacio R. Morelle wesnoth:1.8 ea3f81fa8a4b / src/ (137 files in 20 dirs): Use BOOST_FOREACH instead of foreach http://git.io/vcKwK
20151003 16:44:18< irker021> wesnoth: Ignacio R. Morelle wesnoth:1.8 38e1a48e2cb6 / changelog: Update changelog http://git.io/vcKwi
20151003 16:48:12-!- travis-ci [~travis-ci@ec2-54-167-239-99.compute-1.amazonaws.com] has joined #wesnoth-dev
20151003 16:48:13< travis-ci> wesnoth/wesnoth#7554 (1.10 - 055bcea : Ignacio R. Morelle): The build is still failing.
20151003 16:48:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/83465846
20151003 16:48:13-!- travis-ci [~travis-ci@ec2-54-167-239-99.compute-1.amazonaws.com] has left #wesnoth-dev []
20151003 17:12:43-!- gfgtdf [~chatzilla@x55b19130.dyn.telefonica.de] has joined #wesnoth-dev
20151003 17:13:38< gfgtdf> shadowm: why do you update 1.8?
20151003 17:15:15< gfgtdf> zookeeper: you hava an opinion about http://gna.org/bugs/?23917 ?
20151003 17:19:08< vultraz> gfgtdf: so, persistent events?
20151003 17:19:35< gfgtdf> vultraz: no, events that arent stored twice in savefiles.
20151003 17:22:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 17:23:01-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20151003 17:26:45< zookeeper> gfgtdf, well it's not a bad idea for reducing savefile size
20151003 17:27:19< zookeeper> i don't have anything against that
20151003 17:29:09< celticminstrel> A better idea for reducing savefile size would be to take a prototypal approach to units.
20151003 17:29:24< celticminstrel> Basically have units only store the parts that differ from the base unit type.
20151003 17:30:57< irker021> wesnoth: Charles Dang wesnoth:master fd098e4b629b / data/core/macros/interface-utils.cfg: Simplify HIGHLIGHT_IMAGE using the new [repeat] tag http://git.io/vcKDX
20151003 17:31:34< zookeeper> celticminstrel, sure
20151003 17:32:10-!- Appleman1234 [~Appleman1@KD111239006171.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20151003 17:34:06< shadowm> gfgtdf: Because.
20151003 17:34:06-!- roberpot [~roberpot@84.122.85.148.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
20151003 17:35:11-!- roberpot [~roberpot@84.122.85.148.dyn.user.ono.com] has joined #wesnoth-dev
20151003 17:35:24< vultraz> RE this report: https://gna.org/bugs/?23832 I'm wondering if we should removed any of the right click menus we have currently as suggested
20151003 17:36:00< vultraz> He makes a point for End Turn at least
20151003 17:36:04< zookeeper> vultraz, if we can do submenus, then definitely
20151003 17:36:31< vultraz> I don't think we can :(
20151003 17:36:46< zookeeper> oh... well, then i'll go with "probably"
20151003 17:36:53< vultraz> Plus, a game with sub-context menus is kinda... bleh..
20151003 17:37:52< gfgtdf> vultrazi think speak and end turn can be removed for teh reasons mentioned in tee report
20151003 17:37:56< zookeeper> why is the : option even there? it's not context-aware so it could just be in the actions menu
20151003 17:38:16< vultraz> No idea
20151003 17:38:26< vultraz> someone added it for some reason recently but I can't recall why
20151003 17:38:33< gfgtdf> zookeeper: i think it was a feature request some times ago
20151003 17:38:40< zookeeper> if we had submenus then all the label-related ones could just go inside a "labels" submenu
20151003 17:38:57< gfgtdf> zookeeper: http://wiki.wesnoth.org/EasyCoding#Make_a_context_menu_option_for_command_mode
20151003 17:39:18< gfgtdf> zookeeper: but i don't really think it makes senes
20151003 17:39:19< zookeeper> i see
20151003 17:39:58< zookeeper> it'd be nice if only context-aware items had been put to the right-click menu, and all the general ones (speak, :, planning mode, etc) had gone only to the actions menu.
20151003 17:40:13< gfgtdf> zookeeper: i agree
20151003 17:40:23< zookeeper> now we can still change that, but people will be annoyed because those are the kind of things that you have muscle memory for
20151003 17:40:24< vultraz> I think it's just our lack of explanation that : is just our console key
20151003 17:42:30 * celticminstrel wonders whether vultraz has set core.autocrlf
20151003 17:42:43< vultraz> ?
20151003 17:42:49< celticminstrel> git setting
20151003 17:43:04< celticminstrel> Though I'm not sure if you're actually on Windows.
20151003 17:43:18< vultraz> I'm on windows 10
20151003 17:43:25< vultraz> why?
20151003 17:43:53< celticminstrel> I just notice you use a lot of blank lines, but maybe you just like blank lines.
20151003 17:44:17< vultraz> I like to insert blank lines for readability 
20151003 17:44:36< vultraz> code without blank lines just blurs into a giant block
20151003 17:45:35< celticminstrel> Add Label and Add Team Label could be conflated.
20151003 17:45:45< celticminstrel> The box that pops up has a checkbox to set whether it's a team label.
20151003 17:46:33< celticminstrel> I do agree that general ones should probably be removed, as well.
20151003 17:47:15< vultraz> Terrain Description too
20151003 17:47:19< vultraz> who ever uses that
20151003 17:48:00< celticminstrel> Delete Label could also be conflated with the other two labels if a delete button was added to that dialog.
20151003 17:48:13< celticminstrel> No, Terrain Description should stay. It's context-sensitive.
20151003 17:48:31< celticminstrel> I think Unit Description is there too, so that list is actually incomplete?
20151003 17:49:23< vultraz> yes UD is there
20151003 17:49:52< vultraz> I would also remove Recruit and Recall from the Actions menu since they're literally useless there
20151003 17:50:00< vultraz> (not the context menu, ofc)
20151003 17:50:57-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20151003 17:51:11< zookeeper> terrain description is rarely used but it can't be anywhere else
20151003 17:52:34< vultraz> ok
20151003 17:52:35< celticminstrel> They're not literally useless in the Actions menu.
20151003 17:52:42< vultraz> celticminstrel: it's an extra click
20151003 17:52:51< vultraz> plus redundant
20151003 17:53:10< celticminstrel> If you invoke them from the Actions menu, a default recruit location is chosen.
20151003 17:53:18< celticminstrel> Which is less useful, but not useless.
20151003 17:54:26< vultraz> The same thing is done by recruiting from your leader hex
20151003 17:55:31-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 17:55:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 265 seconds]
20151003 17:55:57< vultraz> zookeeper: Speak is also in Actions, apparently
20151003 17:56:07< vultraz> would you say remove it from context?
20151003 17:56:27< celticminstrel> vultraz: Ah, that's true.
20151003 17:56:40< celticminstrel> Yeah, I'd say remove Speak from context.
20151003 17:56:54< celticminstrel> That might give the misleading impression that individual units can be made to speak.
20151003 17:57:31< vultraz> The only use it might be there is telling people what hotkey to use, though
20151003 17:58:18< celticminstrel> Doesn't the Actions menu show hotkeys too?
20151003 17:58:19< zookeeper> well, you do see the hotkeys in the actions menu too. if you happen to open it, which i imagine most people don't really do often at all.
20151003 17:58:44< vultraz> clunky interface is clunky :P
20151003 17:58:44< celticminstrel> I would imagine people trying to figure out how to do something would open the Actions menu.
20151003 17:58:59< zookeeper> vultraz, but yes, speak is contextless so it should be removed too if the others are
20151003 17:59:06< vultraz> Ok
20151003 17:59:35< vultraz> I'll also remove Set Team Label since as celticminstrel said, there's a checkbok
20151003 17:59:37< vultraz> box
20151003 17:59:54< celticminstrel> Recruit and Recall don't require any particular hex to be selected.
20151003 18:00:02< celticminstrel> Which is probably why they're in Actions.
20151003 18:00:13< zookeeper> yes, recruit and recall should be in both
20151003 18:00:20< vultraz> Uh...
20151003 18:00:29< vultraz> That really seems redundant 
20151003 18:00:55< vultraz> But ok
20151003 18:01:18< zookeeper> if we had submenus we could just have the whole actions menu in a submenu of the right-click menu...
20151003 18:01:42< celticminstrel> ...why?
20151003 18:02:00< celticminstrel> Though, we do have submenus, don't we? The "Back To..." option has a submenu.
20151003 18:02:29< zookeeper> because it is slightly uncomfortable to have to use two spatially distant menus, especially when it's not immediately obvious why some items are in one but not the other
20151003 18:02:53< vultraz> celticminstrel: I think zookeeper wants submenus that can be open concurrently 
20151003 18:03:09< vultraz> back to is hackyy
20151003 18:03:10< celticminstrel> Ah, true, that submenu is a little weird.
20151003 18:03:24< zookeeper> true
20151003 18:03:54< zookeeper> if you could access everything via the right-click menu only, that'd be nice because then you wouldn't need to juggle between two separate menus, you could just use one
20151003 18:05:44-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20151003 18:06:34< celticminstrel> Seems a bit much.
20151003 18:06:42< celticminstrel> The right-click menu would become massive.
20151003 18:07:26< vultraz> gah, the context menu also has all the bloody whiteboard stuff
20151003 18:07:45< celticminstrel> Some of that probably needs to be there.
20151003 18:07:51< celticminstrel> In fact, I imagine most of it does.
20151003 18:07:55< vultraz> Yeah
20151003 18:07:59< vultraz> It does
20151003 18:08:04< vultraz> zookeeper: what about Next Unit?
20151003 18:08:09< celticminstrel> Just how many whiteboard options are there?
20151003 18:08:17< celticminstrel> I think Next Unit could be removed.
20151003 18:08:41< vultraz> 5 wb actions
20151003 18:09:07< vultraz> wb toggle is in both context and actions
20151003 18:09:23< celticminstrel> Hmm. I wonder if it would be acceptable to completely replace the context menu with a whiteboard-specific one when planning mode is active...
20151003 18:10:09< celticminstrel> Recruit and recall wouldn't be necessary, unless they behave differently in whiteboard mode (which is possible). Descriptions would have to stay. Label could stay or go. I dunno...
20151003 18:10:22< celticminstrel> Maybe it wouldn't even help that much.
20151003 18:17:01< gfgtdf> shoudl re also remove 'enable planning mode' from right click meu? its not location specific
20151003 18:18:18< vultraz> Probably
20151003 18:20:17< vultraz> ... ok
20151003 18:20:19< vultraz> so uh...
20151003 18:20:27< vultraz> there's a WB action in Actions not on context
20151003 18:20:41< vultraz> 3 in context but no on actions
20151003 18:20:46< vultraz> not in Actions*
20151003 18:21:02< vultraz> celticminstrel: what say you to do
20151003 18:21:53< celticminstrel> I dunno, what are they?
20151003 18:21:59< vultraz> Actions has
20151003 18:22:10< vultraz> wbexecuteallactions,wbexecuteaction,wbdeleteaction,wbtoggle
20151003 18:22:13< vultraz> Context has
20151003 18:22:24< vultraz> wbexecuteaction,wbdeleteaction,wbbumpupaction,wbbumpdownaction,wbsupposedead,wbtoggle
20151003 18:23:34< celticminstrel> How does Execute Action even work from the Actions menu?
20151003 18:23:57< celticminstrel> Apart form that and Toggle, those all look like they're in the right place.
20151003 18:24:08< celticminstrel> Oh, Delete Action.
20151003 18:24:13< celticminstrel> Shouldn't that be contextual too?
20151003 18:24:20< celticminstrel> I don't know much about the whiteboard system, though.
20151003 18:24:25< vultraz> Me neither
20151003 18:24:30< vultraz> Since I never use it :P
20151003 18:24:36< vultraz> it's kinda a gimmick tbh
20151003 18:24:36< celticminstrel> Maybe it's something like "Delete Last Action" and "Execute First Action"
20151003 18:25:29< vultraz> it just says Execute Action and Delete Action
20151003 18:26:33< vultraz> I guess I'll leave those alone
20151003 18:28:23-!- Appleman1234 [~Appleman1@KD111239008025.au-net.ne.jp] has joined #wesnoth-dev
20151003 18:29:40< vultraz> Ok, I moved Enter Command and Planning Mode to Actions only
20151003 18:29:56< vultraz> Should I PR this or just commit it?
20151003 18:30:03< vultraz> (these bunch of changes, that is)
20151003 18:31:38-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20151003 18:33:00< vultraz> eh... on second thought maybe wbtoggle should stay in context
20151003 18:34:39< gfgtdf> vultraz: why ?
20151003 18:34:40-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 18:34:44< vultraz> Or.. ok, you know what, let's remove it
20151003 18:35:00< vultraz> If someone sends feedback when we release 1.13.2 asking for it back we can restore it
20151003 18:35:45< gfgtdf> vultraz: i alos still think speak shoudl be removed from right click menau
20151003 18:35:48< gfgtdf> also*
20151003 18:35:52< vultraz> gfgtdf: I did
20151003 18:36:07< gfgtdf> vultraz: ok
20151003 18:40:03-!- jinblack_ [~jinblack@ip184-187-174-107.sb.sd.cox.net] has joined #wesnoth-dev
20151003 18:40:48-!- pydsigner is now known as ^_^
20151003 18:40:57-!- ^_^ is now known as pydsigner
20151003 18:42:07-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20151003 18:43:40-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 18:47:03-!- ideuler [~textual@a89-153-66-239.cpe.netcabo.pt] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20151003 18:49:00-!- ideuler [~textual@a89-153-66-239.cpe.netcabo.pt] has joined #wesnoth-dev
20151003 18:51:10-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20151003 18:51:24-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 18:51:46< irker021> wesnoth: Charles Dang wesnoth:master b037fc7074ae / data/themes/default.cfg src/hotkey/hotkey_preferences_display.cpp: Cleaned up and reorganized the Actions and Context menus a bit http://git.io/vc6fO
20151003 18:51:49< irker021> wesnoth: Charles Dang wesnoth:master 55ab4463ae54 / src/hotkey/hotkey_preferences_display.cpp: Fixed incorrect scope being highlighted in hotkey prefs dialog http://git.io/vc6f3
20151003 18:52:04< vultraz> Oops
20151003 18:52:18< vultraz> Accidentally put part of commit 2 in commit 1 :|
20151003 18:52:37< vultraz> Commit 2 still fixes an issue from before commit 1, however
20151003 18:52:56< vultraz> So just ignore the stray file in commit 1
20151003 18:55:29-!- ideuler [~textual@a89-153-66-239.cpe.netcabo.pt] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20151003 18:57:17-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151003 18:58:32-!- markus_ [~mjs-de@x4db642b9.dyn.telefonica.de] has joined #wesnoth-dev
20151003 18:59:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 252 seconds]
20151003 18:59:46-!- wedge010 is now known as wedge009
20151003 19:02:52-!- mjs-de [~mjs-de@f049099102.adsl.alicedsl.de] has quit [Ping timeout: 268 seconds]
20151003 19:03:03-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20151003 19:03:58-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 19:21:09< gfgtdf> shikadibot: seen iceicei e
20151003 19:21:12< gfgtdf> shikadibot: seen iceiceie
20151003 19:21:12< shikadibot> gfgtdf: Sorry, I don't know of iceiceie.
20151003 19:21:16< gfgtdf> shikadibot: seen iceiceice
20151003 19:21:16< shikadibot> gfgtdf: The person with the nick iceiceice last spoke 2d 1h ago.  3h 36m ago they left with the message: Quit: Leaving
20151003 19:32:02-!- ideuler [~textual@a89-153-66-239.cpe.netcabo.pt] has joined #wesnoth-dev
20151003 19:34:35< gfgtdf> celticminstrel: are you waiting for something in https://github.com/wesnoth/wesnoth/pull/499 ?
20151003 19:34:55< celticminstrel> Not particularly, except maybe shadowm's opinion.
20151003 19:35:15< gfgtdf> celticminstrel: you think you can merge it today?
20151003 19:37:46< celticminstrel> Sure, I guess I could.
20151003 19:39:59< gfgtdf> celticminstrel: the problem is that the longer the wait with your pull request the more likeley is that it cannot be merged due to merging conflicts.
20151003 19:40:18< celticminstrel> True.
20151003 19:55:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20151003 19:55:52-!- ideuler [~textual@a89-153-66-239.cpe.netcabo.pt] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20151003 19:56:43< gfgtdf> celticminstrel: you know why our lua_unit class holds units ids instead of unit pointers ?
20151003 19:57:07< celticminstrel> No.
20151003 19:57:32< celticminstrel> I don't think it's a problem though.
20151003 19:59:12< gfgtdf> celticminstrel: you know why our unit pointers are instrusive_ptr instead of shared_ptr ?
20151003 19:59:27< celticminstrel> No. I don't even know what an intrusive_ptr is.
20151003 20:01:16< gfgtdf> celticminstrel: it stored teh refcount in teh unto object and is not threadsafe
20151003 20:03:33-!- iceiceice [~chris@23.31.228.41] has joined #wesnoth-dev
20151003 20:03:33-!- iceiceice [~chris@23.31.228.41] has quit [Changing host]
20151003 20:03:33-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151003 20:06:38< gfgtdf> iceiceice: hi
20151003 20:07:07< gfgtdf> iceiceice: you know why addon_min_version is stored in each [era].. instead of in teh addon metadata ?
20151003 20:07:18-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 20:09:21-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151003 20:09:33-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151003 20:13:25-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20151003 20:13:36-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 264 seconds]
20151003 20:14:19-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 240 seconds]
20151003 20:14:25-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151003 20:15:53-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 20:16:29-!- iceiceice [~chris@23.31.228.41] has joined #wesnoth-dev
20151003 20:16:29-!- iceiceice [~chris@23.31.228.41] has quit [Changing host]
20151003 20:16:29-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151003 20:26:44-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151003 20:34:59-!- ideuler [~textual@a89-153-66-239.cpe.netcabo.pt] has joined #wesnoth-dev
20151003 20:37:32-!- Appleman1234 [~Appleman1@KD111239008025.au-net.ne.jp] has quit [Ping timeout: 272 seconds]
20151003 21:28:42-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20151003 21:31:36-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20151003 21:33:40-!- Appleman1234 [~Appleman1@KD106161089008.au-net.ne.jp] has joined #wesnoth-dev
20151003 21:37:39-!- markus_ [~mjs-de@x4db642b9.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20151003 21:40:43-!- louis94 [~~louis94@109.129.205.202] has quit [Ping timeout: 252 seconds]
20151003 21:44:13-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 21:54:27-!- irker021 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151003 21:57:51-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20151003 22:05:35-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20151003 22:20:01-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 22:20:27-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20151003 22:24:29-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 22:24:35-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20151003 22:28:52-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 22:37:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 22:38:11-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds]
20151003 22:40:59-!- roberpot [~roberpot@84.122.85.148.dyn.user.ono.com] has quit [Quit: • IRcap • 8.72 •]
20151003 22:42:41-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151003 22:44:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20151003 22:45:23-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151003 22:45:35-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151003 22:48:35-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20151003 22:55:02-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151003 23:08:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds]
20151003 23:09:50-!- gfgtdf [~chatzilla@x55b19130.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0.1/20150929144111]]
20151003 23:38:11-!- prkc [~prkc@563BDAA9.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20151003 23:38:42-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20151003 23:41:53-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 250 seconds]
20151003 23:42:46-!- Appleman1234 [~Appleman1@KD106161089008.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20151003 23:49:10-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151003 23:51:11-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
--- Log closed Sun Oct 04 00:00:39 2015