--- Log opened Tue Oct 06 00:00:33 2015
20151006 00:03:44-!- kinow [~kinow@apache/committer/kinow] has joined #wesnoth-dev
20151006 00:20:45-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 00:23:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20151006 00:23:06-!- wedge010 is now known as wedge009
20151006 00:31:54-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 00:33:32-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20151006 00:35:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20151006 00:37:00-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 01:04:50-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20151006 01:19:07-!- irker456 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151006 01:24:12-!- guest [cfa10c49@gateway/web/freenode/ip.207.161.12.73] has joined #wesnoth-dev
20151006 01:24:22-!- guest [cfa10c49@gateway/web/freenode/ip.207.161.12.73] has quit [Client Quit]
20151006 01:32:38-!- mjs-de [~mjs-de@x4db6bf80.dyn.telefonica.de] has quit [Remote host closed the connection]
20151006 01:41:20-!- matgro [ba9e8a80@gateway/web/freenode/ip.186.158.138.128] has joined #wesnoth-dev
20151006 01:41:26< matgro> any spanish?
20151006 01:42:32< shadowm> Do you need help with something in particular?
20151006 01:42:57< matgro> I am an analyst and programmer, UTN (National technological univesidad) Argentina
20151006 01:43:17< matgro> queria participar ayudando al proyecto si todavia necesitan
20151006 01:43:33< matgro> I wanted to participate in helping the project if still needed(traslate google)
20151006 01:44:19< shadowm> While any and all help is appreciated, the project's language for all official dev-related communication is English.
20151006 01:49:48-!- matgro [ba9e8a80@gateway/web/freenode/ip.186.158.138.128] has quit [Ping timeout: 246 seconds]
20151006 01:52:47-!- shadowm_desktopW [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 252 seconds]
20151006 02:06:02-!- shadowm_desktopW [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151006 02:10:08< Aginor> SDL is thinking about dropping OS X 10.5 support: https://bugzilla.libsdl.org/show_bug.cgi?id=3137
20151006 02:11:55< vultraz> We also dropped 10.5 support so we shouldn't worry.
20151006 02:12:17< celticminstrel> I think the XCode readme needs to be updated to reflect that, though.
20151006 02:12:43< Aginor> it looks like 10.6 support will follow not too long after though
20151006 02:12:59< Aginor> at least that looks like how the wind is blowing
20151006 02:13:37< vultraz> Well for master at least, we only support 10.8 onwards
20151006 02:13:38< vultraz> anyway
20151006 02:13:47< vultraz> Or was it 10.9 and 10.10
20151006 02:13:56 * Aginor shrugs
20151006 02:13:58< vultraz> Or 10.8 had a build and wasn't tested on 10.9
20151006 02:14:06< celticminstrel> I think it's 10.6 onwards.
20151006 02:14:08< vultraz> Either way, we shouldn't worry about 10.5/6
20151006 02:14:17< celticminstrel> mattsc was worrying about 10.6, at least.
20151006 02:14:20< Aginor> I've weighted in on the issue now, saying that 10.5 is fine but I care about 10.6
20151006 02:14:38< celticminstrel> And I'm on 10.7, by the way.
20151006 02:16:12< vultraz> Why 10.6?
20151006 02:16:39< Aginor> yeah, but it boils down to which versions we want to support
20151006 02:16:52< shadowm> Whichever versions our packagers can support.
20151006 02:16:56< vultraz> ^
20151006 02:16:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20151006 02:17:06< Aginor> anyhow, 10.6 should be around according to peeps in #SDL
20151006 02:17:22< vultraz> If mattsc cannot get a working build for pre 10.8 or whatever without significant effort, we should stop supporting it
20151006 02:17:33< celticminstrel> I could theoretically support 10.6, but rebooting is too much effort.
20151006 02:17:52< celticminstrel> The effort for 10.7 isn't too bad right now, I think.
20151006 02:18:34< celticminstrel> Whenever Boost.Test (and SDL2) gets added to the libs package, I might test if they work on 10.7 without the tweaking I had to do before.
20151006 02:19:12< celticminstrel> ...speaking of mattsc, isn't he supposed to be back soon?
20151006 02:19:19< celticminstrel> I think he said Oct 5.
20151006 02:19:51< Aginor> it might take him a few days to decompress from his travels
20151006 02:19:56-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151006 02:20:01< celticminstrel> Yeah.
20151006 02:33:32< celticminstrel> Hmm... thinking about gfgtdf's variable default implementation... I think it could be improved...
20151006 03:13:07-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20151006 03:13:31-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20151006 03:18:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20151006 03:18:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 03:25:08-!- MotorMe [~MotorMe@27.189.45.163] has joined #wesnoth-dev
20151006 03:32:09-!- MotorMe [~MotorMe@27.189.45.163] has quit [Ping timeout: 256 seconds]
20151006 03:48:11-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 264 seconds]
20151006 04:12:57-!- c74d3a [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20151006 04:16:31-!- c74d3a [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20151006 05:03:39-!- shadowm_desktopW [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 246 seconds]
20151006 05:05:00-!- shadowm_desktopW [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151006 05:10:17-!- celticminstrel is now known as celmin|sleep
20151006 05:34:47-!- jinblack_ [~jinblack@128.111.48.6] has quit [Remote host closed the connection]
20151006 05:41:00-!- danni [~quassel@adsl-au-4-145.ozonline.com.au] has quit [Quit: No Ping reply in 180 seconds.]
20151006 05:42:14-!- kinow [~kinow@apache/committer/kinow] has quit [Ping timeout: 250 seconds]
20151006 05:42:16-!- danni [~quassel@adsl-au-4-145.ozonline.com.au] has joined #wesnoth-dev
20151006 05:44:49-!- kinow [~kinow@apache/committer/kinow] has joined #wesnoth-dev
20151006 06:11:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20151006 06:26:16-!- Kwandulin [~Miranda@p5B0080FC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151006 06:29:25-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 240 seconds]
20151006 06:29:30-!- shadowm_desktopW [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20151006 06:31:22-!- shadowm_desktopW [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151006 06:38:31-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20151006 06:43:17-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20151006 07:17:09-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20151006 07:17:22-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 07:24:31-!- genbattle [~genbattle@122-57-89-170.jetstream.xtra.co.nz] has joined #wesnoth-dev
20151006 07:25:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20151006 07:25:52-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 07:31:26-!- Appleman1234 [~Appleman1@KD111239000165.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20151006 07:34:10-!- Rh0nda is now known as Rhonda
20151006 07:34:18-!- Rhonda [~rhonda@anguilla.noreply.org] has quit [Changing host]
20151006 07:34:18-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev
20151006 07:36:23< vultraz> gfgtdf: PR 516
20151006 07:37:07-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20151006 07:37:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 07:38:12< shadowm> gfgtdf: Don't merge it.
20151006 07:43:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20151006 07:44:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 07:53:48-!- boucman_work [~jrosen@178.251.23.59] has joined #wesnoth-dev
20151006 07:53:48-!- boucman_work [~jrosen@178.251.23.59] has quit [Changing host]
20151006 07:53:48-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151006 07:54:28-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20151006 07:54:46-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 07:56:15-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20151006 08:04:09-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 08:05:10-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20151006 08:09:51-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 08:11:22-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20151006 08:11:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 08:16:00-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has quit [Remote host closed the connection]
20151006 08:17:04-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20151006 08:17:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 08:28:52-!- Appleman1234 [~Appleman1@KD106161091200.au-net.ne.jp] has joined #wesnoth-dev
20151006 08:29:12-!- MotorMe [~MotorMe@27.189.1.90] has joined #wesnoth-dev
20151006 08:33:54-!- MotorMe [~MotorMe@27.189.1.90] has quit [Ping timeout: 260 seconds]
20151006 08:38:36-!- Appleman1234 [~Appleman1@KD106161091200.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20151006 08:52:14-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has joined #wesnoth-dev
20151006 09:09:53-!- genbattle [~genbattle@122-57-89-170.jetstream.xtra.co.nz] has quit [Ping timeout: 256 seconds]
20151006 09:15:04-!- MotorMe [~MotorMe@27.189.34.250] has joined #wesnoth-dev
20151006 09:23:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151006 09:27:14-!- ypnos [~ypnos@boron.physiol.uni-freiburg.de] has joined #wesnoth-dev
20151006 09:34:25-!- shadowm_desktopW [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 252 seconds]
20151006 09:34:54-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20151006 09:35:58-!- Appleman1234 [~Appleman1@KD118156253075.au-net.ne.jp] has joined #wesnoth-dev
20151006 09:37:32-!- MotorMe [~MotorMe@27.189.34.250] has quit [Ping timeout: 250 seconds]
20151006 09:41:20-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20151006 09:41:33-!- danni [~quassel@adsl-au-4-145.ozonline.com.au] has quit [Read error: Connection reset by peer]
20151006 09:57:33-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20151006 10:00:51-!- MotorMe [~MotorMe@27.189.34.250] has joined #wesnoth-dev
20151006 10:07:19-!- MotorMe [~MotorMe@27.189.34.250] has quit [Ping timeout: 240 seconds]
20151006 10:10:30-!- ypnos [~ypnos@boron.physiol.uni-freiburg.de] has quit [Ping timeout: 260 seconds]
20151006 10:25:26-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has quit [Ping timeout: 240 seconds]
20151006 10:28:16-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has joined #wesnoth-dev
20151006 10:37:06-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has quit [Ping timeout: 272 seconds]
20151006 10:39:07-!- ypnos [~ypnos@boron.physiol.uni-freiburg.de] has joined #wesnoth-dev
20151006 10:40:23-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 264 seconds]
20151006 10:40:51-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151006 10:45:59-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds]
20151006 10:49:26-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has joined #wesnoth-dev
20151006 10:52:22-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20151006 10:52:28-!- MotorMe [~MotorMe@27.189.34.250] has joined #wesnoth-dev
20151006 10:58:25-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has quit [Ping timeout: 240 seconds]
20151006 11:01:21-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has joined #wesnoth-dev
20151006 11:27:02-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151006 11:32:59-!- Appleman1234 [~Appleman1@KD118156253075.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20151006 11:37:54-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151006 11:41:35-!- MotorMe [~MotorMe@27.189.34.250] has quit [Ping timeout: 264 seconds]
20151006 11:42:00-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151006 11:45:01-!- Kwandulin [~Miranda@p5B0080FC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151006 11:59:12-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 255 seconds]
20151006 12:06:40-!- MotorMe [~MotorMe@27.189.34.250] has joined #wesnoth-dev
20151006 12:06:59-!- gfgtdf [~chatzilla@f054145180.adsl.alicedsl.de] has joined #wesnoth-dev
20151006 12:07:12< gfgtdf> anyone motivated to implement https://gna.org/bugs/?23922 ?
20151006 12:19:34-!- boucman_work [~jrosen@89.225.200.101] has joined #wesnoth-dev
20151006 12:19:34-!- boucman_work [~jrosen@89.225.200.101] has quit [Changing host]
20151006 12:19:34-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151006 12:26:18-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Quit: No Ping reply in 180 seconds.]
20151006 12:27:47-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151006 12:31:21-!- Appleman1234 [~Appleman1@KD118156253118.au-net.ne.jp] has joined #wesnoth-dev
20151006 12:43:08-!- Greywhind [~Greywhind@50.133.231.228] has quit [Ping timeout: 272 seconds]
20151006 13:01:59-!- mjs-de [~mjs-de@x4db6bf80.dyn.telefonica.de] has joined #wesnoth-dev
20151006 13:03:34-!- Kwandulin [~Miranda@p5B0080FC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151006 13:26:12-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has quit [Ping timeout: 264 seconds]
20151006 13:30:08< celticminstrel> gfgtdf: I think that shouldn't be changed.
20151006 13:30:17< gfgtdf> celticminstrel: why?
20151006 13:30:19< celticminstrel> ...what happend to my nick?
20151006 13:30:25< gfgtdf> ??
20151006 13:30:37< vultraz> it makes sense imo
20151006 13:30:37< gfgtdf> celticminstrel: is something dfiffernt with your nick?
20151006 13:30:49 * celticminstrel was sleeping and changed it to celmin|sleep
20151006 13:30:51< vultraz> gfgtdf: 'el' vs 'al' I think
20151006 13:30:56< vultraz> oh
20151006 13:30:58< celticminstrel> I guess I disconnected overnight.
20151006 13:31:00< vultraz> nvm
20151006 13:31:02< celticminstrel> Anyway.
20151006 13:31:19< gfgtdf> celticminstral: ?
20151006 13:31:40< celticminstrel> I don't think [insert_tag] is (always) an array operation.
20151006 13:32:00< celticminstrel> The behaviour requested by that poster is useful, but I think the original behaviour can also be useful.
20151006 13:32:17< gfgtdf> celticminstrel: well just name one place where it can be useful
20151006 13:33:32< gfgtdf> celticminstrel: accorind to this thread: http://forums.wesnoth.org/viewtopic.php?f=12&p=589890 tekelili will donate $200 if you can just name one serious case where the current [insert_tag] makes sense
20151006 13:33:41< celticminstrel> XD
20151006 13:34:38< celticminstrel> Also, [insert_tag] is not specifically intended for dynamic code generation.
20151006 13:35:54< celticminstrel> BTW gfgtdf, I think your default implementation could be improved.
20151006 13:36:02< vultraz> gfgtdf: BTW, speaking of confusing things, [map] is also supported in [replace_map]. IIRC this is also undocumented after fabi reverted that change early in 1.11
20151006 13:36:23< gfgtdf> celticminstral: so you have a case where the previous [nsert_tag] is better ?
20151006 13:36:28< celticminstrel> Thinking.
20151006 13:36:33< gfgtdf> celticminstrel: what exactly coudl be imnproved?
20151006 13:37:00< celticminstrel> Currently it continues either to the end of the string or until a closing | is found.
20151006 13:37:04< vultraz> gfgtdf: should we remove [map] support?
20151006 13:37:27< gfgtdf> vultraz: i think yes
20151006 13:37:36< celticminstrel> Can you use variable substitution within the default value?
20151006 13:37:44< gfgtdf> vultraz: afaik we currently dont even supprt diffeent border_sides
20151006 13:37:53< gfgtdf> celticminstrel: yes you can
20151006 13:38:00< celticminstrel> You tested that?
20151006 13:38:14< gfgtdf> celticminstrel: uhm no but why shoudl it be impossible ?
20151006 13:38:39< vultraz> gfgtdf: we're not supposed to, but there's a bug in terrain_mask that makes it so you need different ones 
20151006 13:39:09< gfgtdf> vultraz: i dont really understang
20151006 13:39:10< celticminstrel> gfgtdf: From the code I don't see how it would be possible, but I could be missing something.
20151006 13:39:56< vultraz> gfgtdf: basically, terrain_mask passes 0 as border_size, which causes current maps to be overlayed with an offset (see LoW). But if you pass it as 1, certain terrain masks will be broken (such as single-hex masks) because of an incorrect index access issue
20151006 13:40:10< gfgtdf> celticminstrel:" $a?b||" -> "$a?B|" -> "B"assuming that b is B and a is empty
20151006 13:40:19< celticminstrel> I also think that if there's no closing | that it should be taken as normal variable substitution with no default, but that might be hard with the way you've implemented it.
20151006 13:41:26< gfgtdf> celticminstrel: y that might be better but i thought that was a minor since you can just inset a '|' before the '?' so i didnt bother to implement it.
20151006 13:42:04< gfgtdf> s/" $a?b||"/" $a?$b||"
20151006 13:42:04< celticminstrel> That's true.
20151006 13:42:19< vultraz> gfgtdf: basically, terrain_mask is currently broken
20151006 13:42:23< celticminstrel> I think at least if the ? is the last character in the string that it should be taken as a literal.
20151006 13:42:57< celticminstrel> It's quite likely that the way it's currently implemented will break people's strings.
20151006 13:44:33< gfgtdf> celticminstrel: hmm but there are sure currently also srting where teh strings doesnt end with ? if the ? is afgter a variable substitution
20151006 13:44:53< gfgtdf> celticminstrel: i think only handeling teh case where ? is teh last character migth be more consufung tghenhaloing.
20151006 13:44:54< celticminstrel> Probably.
20151006 13:45:03< gfgtdf> then helping*
20151006 13:45:27< celticminstrel> The probably was at the first line, but I suppose you're also right about it being confusing.
20151006 13:46:41< vultraz> gfgtdf: if you'd like to help me fix it it would be appreciated.
20151006 13:46:52< celticminstrel> Sorry to keep jumping around, but do either of you see any problem with these three commits?
20151006 13:46:54< celticminstrel> https://github.com/CelticMinstrel/wesnoth/commits/fix-for
20151006 13:47:20 * celticminstrel is about to PR them probably, because that's somehow easier for merging them.
20151006 13:47:20< gfgtdf> celticminstrel: i think only interprting the ? as default value if ended by a | is a good idea but im not sure whether i'll implement it
20151006 13:47:39< celticminstrel> gfgtdf: Okay.
20151006 13:48:14< celticminstrel> More important in my opinion is ensuring that variable substitution works.
20151006 13:48:32< gfgtdf> celticminstrel: i see no reason why it shouldnt work
20151006 13:49:03< celticminstrel> As for [insert_tag], so far the only things I've thought of are [unit][abilities] and [unit][modifications] which would still work with the change made.
20151006 13:49:04< vultraz> celticminstrel: don't understand everything you're doing there but it looks fine
20151006 13:52:18< celticminstrel> gfgtdf: Typo alert https://github.com/wesnoth/wesnoth/commit/f74d89d166ef40f6c152987c9ccfec80f9860176#diff-cbc1ee771a060a08f4e069e6049ce7acR381
20151006 13:53:16-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20151006 13:53:19< celticminstrel> Or did you already fix that?
20151006 13:54:06< gfgtdf> celticminstrel: what wrong ?
20151006 13:54:22< celticminstrel> set_can_recurit -> set_can_recruit
20151006 13:55:00< Ravana_> gfgtdf: about " $a?b||" and " $a?$b||", are both working?
20151006 13:55:40< gfgtdf> celticminstrel: well thats the name of teh c++ function if i woudl spell it set_can_recruit then it wouldnt compile
20151006 13:55:54< celticminstrel> Ah, okay.
20151006 13:56:02< gfgtdf> Ravana_: no only the later (well actualy both would work but they mean differnt things)
20151006 13:56:15< Ravana_> yes, they should mean different things
20151006 13:56:18< Ravana_> thats what I asked
20151006 13:56:23< celticminstrel> gfgtdf: Were you going to look at the commits I linked?
20151006 13:56:45< gfgtdf> Ravana_: the scond does variable subtutution on the 'b'
20151006 13:56:50< Ravana_> yes
20151006 13:56:57< celticminstrel> While the first has a literal |
20151006 13:58:01< celticminstrel> gfgtdf: Why is [event]enable_if an attribute rather than a container of WML conditionals?
20151006 13:58:30< gfgtdf> celticminstrel: what do you mena by wml conditionals ?
20151006 13:58:42< celticminstrel> [variable] for example.
20151006 13:59:32< gfgtdf> celticminstrel: well implenting [variable] woudl be more complicated while on teh other sides i dont really see advantages
20151006 13:59:49-!- Appleman1234 [~Appleman1@KD118156253118.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20151006 13:59:54< celticminstrel> It wouldn't be more complicated, assuming the game_lua_kernel is available.
20151006 14:00:11< gfgtdf> celticminstrel: it snot available
20151006 14:00:21< celticminstrel> Ah, okay. That right there is a good reason, then.
20151006 14:00:23< gfgtdf> celticminstrel: no resources:: are available
20151006 14:01:24< celticminstrel> Only minor complaint about wesnoth.effects is that the preset ones are not included in it (allowing default effects to be changed), but I suppose that can be added separately.
20151006 14:01:57< celticminstrel> If you have nothing to say about PR517 then I'll go ahead and merge it.
20151006 14:02:33< gfgtdf> celticminstrel: you shoudl wait for the travis build
20151006 14:02:39< celticminstrel> Ah, good point.
20151006 14:02:46< celticminstrel> Though I doubt that'll be an issue.
20151006 14:03:31< gfgtdf> celticminstrel: what does get_for_step(last - first) ~= get_for_step(step) do?
20151006 14:03:45-!- roberpot [~roberpot@84.122.85.148.dyn.user.ono.com] has joined #wesnoth-dev
20151006 14:04:04< celticminstrel> get_for_step(n) is sgn(n) if n is non-zero, and 1 if n is zero.
20151006 14:04:31< gfgtdf> celticminstrel: so get_for_step(last - first) ~= get_for_step(step) will be teh case for start,end,step=0,0,-1 ?
20151006 14:04:37< celticminstrel> (Where sgn(n) = {-1 if n < 0, 0 if n = 0, 1 if n > 0}.)
20151006 14:04:58< celticminstrel> gfgtdf: I was about to say no, but actually it would be. :(
20151006 14:05:10< gfgtdf> celticminstrel: another issue: i think get_for_step() could be simplified to "if n > 0 return 1 else return -1 end"
20151006 14:05:56< gfgtdf> >= 0 i mean
20151006 14:06:33< celticminstrel> The current implementation is a relic of it going through two revisions - originally it was just sgn.
20151006 14:07:09 * vultraz wonders what sgn is
20151006 14:07:20< celticminstrel> I just said a few lines up.
20151006 14:07:31< celticminstrel> It's a mathematical function to get the sign of a number.
20151006 14:07:51< vultraz> oh
20151006 14:07:52< vultraz> ok
20151006 14:09:25< celticminstrel> This is getting annoying. :/
20151006 14:10:56< celticminstrel> Let me list some edge cases... start,end,step=0,0,0   start,end,step=0,0,1   start,end,step=0,0,-1   start,end,step=0,1,-1   start,end,step=0,1,1    start,end,step=0,1,0   Any more?
20151006 14:14:03< vultraz> do we need step at all?
20151006 14:14:06< vultraz> just wondering
20151006 14:15:14< celticminstrel> In my opinion, yes.
20151006 14:19:36-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 264 seconds]
20151006 14:23:10 * celticminstrel is writing up some unit tests right now.
20151006 14:28:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20151006 14:28:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20151006 14:35:09-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has quit [Ping timeout: 256 seconds]
20151006 14:36:11-!- MotorMe [~MotorMe@27.189.34.250] has quit [Ping timeout: 264 seconds]
20151006 14:37:04-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20151006 14:37:14-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has joined #wesnoth-dev
20151006 14:37:33< celticminstrel> I'm getting "Unexpected characters at line start" :|
20151006 14:39:39-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Max SendQ exceeded]
20151006 14:40:28-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20151006 14:42:04-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Client Quit]
20151006 14:43:11< celticminstrel> Oh! There was a random character somewhere that I didn't even notice, partly because the line number was off by one. :/
20151006 14:44:03-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151006 14:44:56< celticminstrel> Now the scenario isn't found...
20151006 14:45:12< celticminstrel> ...oh. Macro fail.
20151006 14:48:06< vultraz> gfgtdf: travis passes for 516
20151006 14:50:31-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has quit [Remote host closed the connection]
20151006 14:50:36-!- irker175 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151006 14:50:36< irker175> wesnoth: ln-zookeeper wesnoth:master 0fd627178d5a / data/core/ (about.cfg sounds/mace-miss.ogg sounds/mace.ogg): New mace sounds, from material by leorock116 http://git.io/vcFce
20151006 14:53:07< vultraz> gfgtdf: do you want me to name the key map_file?
20151006 14:53:51-!- MotorMe [~MotorMe@27.189.34.250] has joined #wesnoth-dev
20151006 14:56:31< gfgtdf> i dont really know, i think some consitency to [scenario] would be good but i dont know how complicated that would be
20151006 15:01:54< irker175> wesnoth: gfgtdf wesnoth:master 6ff6b76aa67b / RELEASE_NOTES: Update RELEASE_NOTES http://git.io/vcF8c
20151006 15:08:39< vultraz> gfgtdf: also about default vars, what happens with spaces? like $foo ? bar |
20151006 15:09:40< celticminstrel> The first space should prevent it from being recognized as a default.
20151006 15:09:51< celticminstrel> The others should be used as part of the default value.
20151006 15:15:05< celticminstrel> My tests seem to show that [for] does not work at all right now.
20151006 15:24:28-!- Kwandulin [~Miranda@p5B0080FC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151006 15:45:28< vultraz> :(
20151006 15:45:39< gfgtdf> ?
20151006 15:47:24< celticminstrel> (That may or may not be a result of my attempted fixes. It doesn't necessarily reflect the state of master.)
20151006 15:48:00< celticminstrel> Does wesnoth.wml_conditionals.or exist?
20151006 15:48:04-!- ypnos [~ypnos@boron.physiol.uni-freiburg.de] has quit [Ping timeout: 252 seconds]
20151006 15:50:32-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20151006 15:50:39< celticminstrel> I suppose it doesn't really matter, actually...
20151006 15:51:11< vultraz> I don't think so
20151006 15:51:37< vultraz> Conditional actions are for some reason bundled up in internal_conditional_passed
20151006 15:52:02< vultraz> no idea why
20151006 15:53:13< celticminstrel> I don't suppose there's a way to pretty-print a block of WML from Lua?
20151006 15:56:49-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20151006 16:00:03< gfgtdf> celticminstrel: i don't think so
20151006 16:01:20< vultraz> 		static const boost::container::flat_set<std::string> hard_coded = boost::assign::list_of("true")("false")("have_unit")("have_location")("variable")
20151006 16:01:22< vultraz> 		("then")("else")("elseif")("not")("and")("or")("do").convert_to_container<boost::container::flat_set<std::string> >();
20151006 16:01:23< vultraz> yeah, hardcoded
20151006 16:01:56< celticminstrel> So have_unit, have_location, and variable all don't exist in wesnoth.wml_conditionals?
20151006 16:02:33< vultraz> I would say not but I'd have to test
20151006 16:03:00< vultraz> gfgtdf would know since he implemented the table
20151006 16:03:08< gfgtdf> vultraz: i didnt
20151006 16:03:09< vultraz> or was it iceiceice?
20151006 16:03:11< vultraz> oneof those...
20151006 16:03:40< gfgtdf> vultraz: you know whether there is a fully transparent image in wesnoth data ?
20151006 16:03:42< celticminstrel> Well, I ended up using wesnoth.eval_conditional{tag, contents} so it probably doesn't matter.
20151006 16:04:04< celticminstrel> Sorry, double braces there.
20151006 16:04:21< vultraz> gfgtdf: misc/empty.png I think
20151006 16:04:41-!- joet [~joet@host86-163-222-44.range86-163.btcentralplus.com] has joined #wesnoth-dev
20151006 16:04:55< vultraz> gfgtdf: also misc/blank-hex.png
20151006 16:06:20< gfgtdf> vultraz: ty :) i'll try to use one of these 
20151006 16:06:29< vultraz> what are you doing?
20151006 16:07:50< gfgtdf> vultraz: currently m addon 'PYR no preperation turn' uses it own image tpixel.png (a 1x1 translarent image) which is the only image it has and it would be better if it woudl work without so that oither players woudln't have to download it
20151006 16:09:45< zookeeper> core/images/misc/blank-hex.png
20151006 16:09:52< zookeeper> oh wait, too late
20151006 16:11:29-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151006 16:11:46< celticminstrel> I'm adding an [explain] tag which takes a conditional argument and explains why it fails. Should I put it in wm-tags.lua or just in the generic WML unit test scenario?
20151006 16:11:54< celticminstrel> ^wml-tags
20151006 16:12:26< gfgtdf> celticminstrel: maybe you coudl call it [assert]?
20151006 16:12:54< celticminstrel> It only logs a message saying why it fails. It doesn't actually ensure that it passes.
20151006 16:13:22< gfgtdf> celticminstrel: assert also doesnt ensure that it passes
20151006 16:13:23< celticminstrel> But I made the {ASSERT} macro in the unit tests use it.
20151006 16:13:32< celticminstrel> And the {RETURN} macro as well.
20151006 16:13:55< gfgtdf> wait hmm i think i see what you mean
20151006 16:18:49< vultraz> gfgtdf: so it seems there isn't a toplevel map= attribute, it's a [map] tag that's supported
20151006 16:19:01< vultraz> 	const config& map_child = level.child_or_empty("map");
20151006 16:19:03< vultraz> 	if (map_child.empty()) {
20151006 16:19:05< vultraz> 		const std::string& map_data = level["map_data"];
20151006 16:19:32< gfgtdf> vultraz: where did you read that ?
20151006 16:19:57< gfgtdf> vultraz: or did you test it ?
20151006 16:20:14< vultraz> gamemap constructor (map.cpp:142)
20151006 16:21:00< celticminstrel> Still can't think of a use for current [insert_tag] behaviour, not that I've thought all that hard about it.
20151006 16:22:02< gfgtdf> vultraz: te code that i meant is saved_game.cpp:369
20151006 16:22:09< celticminstrel> Although someone (was it vultraz?) mentioned empty ActionWML, it'd be really weird if you used [insert_tag] to insert those, because there's nothing to customize inside (I think?) and you wouldn't want several of them in a row (I think?).
20151006 16:22:56< gfgtdf> vultraz: note that the game map constructor is created on the client so reading teh file there woudl casue OOS in mp
20151006 16:25:57< gfgtdf> i now get errors found invalid closing tag [/while] for tag [for]
20151006 16:26:49< gfgtdf> hmm i think its casued by other addons using {FOREACH ..} with a manual [/while] so nevermind
20151006 16:27:16-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20151006 16:29:23-!- travis-ci [~travis-ci@ec2-54-161-0-73.compute-1.amazonaws.com] has joined #wesnoth-dev
20151006 16:29:24< travis-ci> wesnoth/wesnoth#7569 (master - 6ff6b76 : gfgtdf): The build has errored.
20151006 16:29:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/83909402
20151006 16:29:24-!- travis-ci [~travis-ci@ec2-54-161-0-73.compute-1.amazonaws.com] has left #wesnoth-dev []
20151006 16:30:20-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 265 seconds]
20151006 16:31:03< celticminstrel> ...why would you do that? Doesn't it kind of defeat the point of using {FOREACH}?
20151006 16:31:29< celticminstrel> The opposite (using {NEXT} to close a custom macro) sort of makes sense.
20151006 16:35:53< vultraz> AtS uses NEXT to close a custom FOR macro
20151006 16:36:12< vultraz> I had to submit a PR for it to redefine FOR using [for] instead of [while] to match the closer
20151006 16:37:52< vultraz> gfgtdf: hmmmm... that's certainly undocumented then
20151006 16:38:23< vultraz> gfgtdf: best suggestion for compatibility I can offer is renaming that to map_file and doing the same for file in [replace_map]
20151006 16:38:47-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20151006 16:39:44-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20151006 16:41:57< vultraz> gfgtdf: I think it should be renamed in any case since in replace_map map= is an include but in scenario it's a file path
20151006 16:43:54< celticminstrel> gfgtdf: Are all your recent changes in the changelog yet?
20151006 16:44:11< gfgtdf> celticminstrel: no
20151006 16:44:36< celticminstrel> Are you planning to add them in the next hour or so?
20151006 16:44:52< gfgtdf> celticminstrel: i dont have such plans yet why do you ask ?
20151006 16:44:55< celticminstrel> By the way, I updated PR517.
20151006 16:45:06< celticminstrel> I ask because I plan to update the changelog with my recent changes.
20151006 16:48:23< gfgtdf> hmm i got an assertion failue in synced_context.cpp .. have to fix it
20151006 16:57:12< celticminstrel> gfgtdf: Why did you add them to release notes but not to the changelog?
20151006 16:57:47< gfgtdf> celticminstrel: idk, coudl have also added them to the changelog first
20151006 16:58:15< celticminstrel> Since I'm updating the changelog anyway, is there anything I should add besides default variables and wesnoth.effects?
20151006 17:00:05-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 250 seconds]
20151006 17:00:57< gfgtdf> celticminstrel: hmm i think its better if i do tegh changelog entried for my commits myself, otherwise i might get confused about whcih commits already have changelog entried and which not
20151006 17:01:09< celticminstrel> Well, okay then.
20151006 17:01:24< vultraz> gfgtdf: do you think gamemap::read should throw and error if allow_invalid isn't true and map data is empty?
20151006 17:01:38< vultraz> right now it returns if allow_invalid is true
20151006 17:01:45< vultraz> but just continues if it's false..
20151006 17:01:52< gfgtdf> vultraz: i don rlly know how the gamemap class works
20151006 17:02:09-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151006 17:02:09< gfgtdf> vultraz: or what its functions do
20151006 17:10:07< celticminstrel> vultraz, gfgtdf: I'm probably going to merge PR517 as soon as the travis test passes (assuming it does), unless you have any objections.
20151006 17:12:37< celticminstrel> Well, one version failed...
20151006 17:13:21-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151006 17:13:31< celticminstrel> Oh.
20151006 17:14:08< celticminstrel> I forgot I was testing with strict mode disabled, but travis doesn't do that.
20151006 17:15:22-!- MotorMe [~MotorMe@27.189.34.250] has quit [Ping timeout: 246 seconds]
20151006 17:19:04< gfgtdf> celticminstrel: i wonder why yoou use goto exit instead of return ?
20151006 17:19:25< celticminstrel> A very, very good question. What on earth was I thinking? o.o
20151006 17:19:32< gfgtdf> celticminstrel: and whats that change in extra_opts+=" $OPTARG" ?
20151006 17:20:33< celticminstrel> If you passed -a--data-dir=some/path -a--showgui to run_wml_tests, Wesnoth would receive --data-dir=some/path--showgui and of course fail, rather than receiving --data-dir=some/path --showgui
20151006 17:21:14< vultraz> gfgtdf: updated 516
20151006 17:21:23< celticminstrel> In [explain], should I skip the explanation if it finds [true]/[false]?
20151006 17:21:46< celticminstrel> You probably wouldn't use those in conjunction with an/or/not anyway, right?
20151006 17:22:35< vultraz> celticminstrel: also, couldn't you use return instead of goto exit in [while]?
20151006 17:22:47-!- fabi [~quassel@176.6.10.9] has joined #wesnoth-dev
20151006 17:22:47-!- fabi [~quassel@176.6.10.9] has quit [Changing host]
20151006 17:22:47-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151006 17:24:06< celticminstrel> gfgtdf: What do you think about my question about [explain]?
20151006 17:24:27< celticminstrel> (It's the reason the travis build is failing.)
20151006 17:33:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20151006 17:45:20-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151006 17:48:05< gfgtdf> celticminstrel: actually i dont really see how [explain] works
20151006 17:48:20< celticminstrel> What do you mean?
20151006 17:48:53< gfgtdf> celticminstrel: specually how "or"/"not"/"and" are handelled
20151006 17:49:12< celticminstrel> I had a logic error regarding not.
20151006 17:49:37< celticminstrel> Do I need to change something with and?
20151006 17:49:44 * celticminstrel checks the code.
20151006 17:50:13< celticminstrel> No, it doesn't look like logical operations short-circuit, so my current fix should be fine.
20151006 17:51:11-!- joet [~joet@host86-163-222-44.range86-163.btcentralplus.com] has quit [Ping timeout: 264 seconds]
20151006 17:52:02< celticminstrel> gfgtdf: I just pushed an updated version.
20151006 17:55:18< Necrosporus> I have found a small bug(?). In certain languages, like in Russian, certain constructions like "I thought" or "I'm sure" would have different translation depending of gender of speaker. I found that a female unit used male variant of phrase in a duologue 
20151006 17:56:33< celticminstrel> Ideally there'd be elseif blocks for tag == "have_unit" and tag == "have_location", but I'm not sure how to explain those ones.
20151006 17:57:08< celticminstrel> Necrosporus: I'm guessing that this issue only occurs with dialog by generic units?
20151006 17:57:24< celticminstrel> Rather then dialog specifically tailored for a single unit.
20151006 17:57:29< celticminstrel> ^than
20151006 17:58:37< Necrosporus> yes
20151006 17:58:53< Necrosporus> not sure about specific units, didn't test
20151006 17:59:21< celticminstrel> Because the translator cannot know the gender of the speaker when the unit speaking is selected dynamically.+
20151006 17:59:41< celticminstrel> But if it's a specific unit, usually they'll know the unit's gender.
20151006 18:00:41< Necrosporus> celticminstrel, it's possible to have two or more variants of translations
20151006 18:01:30< celticminstrel> I don't think that's currently possible with [message], but I'd recommend keeping a list of specific cases where this happens in mainline campaigns so that, if it becomes fixable, people will know what parts of the mainline campaigns need to be updated.
20151006 18:01:37< celticminstrel> ^becomes possible
20151006 18:02:05< celticminstrel> Well, okay, you could do it currently with some kind of involved if/then structure, I guess.
20151006 18:02:31< Necrosporus> celticminstrel, doesn't it work with unit traits for example?
20151006 18:02:48< Necrosporus> I guess, there are already "female^something" tags
20151006 18:03:27< celticminstrel> It's not the female^ thing that does it - that's just a hint to the translator.
20151006 18:03:35< celticminstrel> Traits have separate name= and female_name=
20151006 18:05:09< Necrosporus> aren't names and female names always same in English?
20151006 18:05:44< celticminstrel> In English, yes, they're often the same (not always - for example sorcerer vs sorceress). I think that's why the female^ hint is present.
20151006 18:06:13< celticminstrel> (For the traits I think they're always the same, because those are adjectives.)
20151006 18:14:41< gfgtdf> vultraz: i posted in your pr
20151006 18:15:03< gfgtdf> vultraz: do you know why there is currently no read_file function ?
20151006 18:15:11< celticminstrel> In Lua?
20151006 18:15:15< vultraz> gfgtdf: I don't
20151006 18:15:19< gfgtdf> celticminstrel: yes in lua (or in wml)
20151006 18:15:35< celticminstrel> Maybe because file access is inherently unsafe?
20151006 18:16:01< vultraz> gfgtdf: plus a read_file function here would remove the entire point of the feature
20151006 18:16:11< celticminstrel> Though it might be alright if restricted to the file's directory (same as wesnoth.do_file and wesnoth.require).
20151006 18:16:19< gfgtdf> vultraz: why?
20151006 18:16:23< celticminstrel> ^to the addons directory. Dun=h.
20151006 18:16:25< vultraz> gfgtdf: the reason I added this is for umc authors to reduce savefile bloat by saving big maps everywhere
20151006 18:16:25< celticminstrel> ^Duh
20151006 18:16:31< gfgtdf> vultraz: so?
20151006 18:16:35< vultraz> if you write to a variable it still gets written to the savefile
20151006 18:16:44< vultraz> so in the end it defeats the purpose
20151006 18:16:53< gfgtdf> vultraz: you can clear the variable afterwards -,-
20151006 18:17:06< celticminstrel> I still think that the one major way to reduce savefile bloat is the prototypal approach to units.
20151006 18:17:32< vultraz> celticminstrel: but how do we implement that
20151006 18:17:42< gfgtdf> vultraz: clearing variables ?
20151006 18:17:47< celticminstrel> Well, it would be a major rewrite of the unit class.
20151006 18:18:04< vultraz> gfgtdf: prototypical unit handling 
20151006 18:18:33< celticminstrel> Maybe removing 90% of the member variables (which I suppose could hurt performance a little by way of requiring more string-to-number coercions).
20151006 18:18:57< vultraz> gfgtdf: is it possible to issue a warning if an author uses map_file in mp mode?
20151006 18:19:35< gfgtdf> vultraz: thats not  solution that i'd like
20151006 18:20:04< vultraz> I think it comes down to how much we want to safeguard this
20151006 18:20:24< celticminstrel> gfgtdf: Any further comments on PR517?
20151006 18:20:30< celticminstrel> Or vultraz 
20151006 18:22:19< vultraz> celticminstrel: so explain takes a condition and if it fails, spits out an error as to why?
20151006 18:22:29< celticminstrel> Yup.
20151006 18:22:34< celticminstrel> Basically.
20151006 18:22:43< vultraz> Maybe you could call it [evaluate_condition]
20151006 18:22:51< vultraz> since [explain] is kinda... vague
20151006 18:23:00< celticminstrel> How about [explain_condition]?
20151006 18:23:08< celticminstrel> Because evaluate doesn't seem right to me.
20151006 18:23:36< vultraz> [test_condition]?
20151006 18:23:57< celticminstrel> Hmm. I suppose that's not as bad as evaluate. Maybe.
20151006 18:24:51< celticminstrel> The main point of it is for the WML unit tests - normally unit test assertions print out the condition that was tested and the associated values, but currently assertions in the WML unit tests don't do that.
20151006 18:25:04< celticminstrel> (On failure, I mean.)
20151006 18:25:32< celticminstrel> I guess I can change it to test_condition.
20151006 18:28:26< vultraz> or even just [test] if you want to keep it simple
20151006 18:28:54< celticminstrel> Well, it's not like it's something that'll be used a lot (outside of unit tests).
20151006 18:34:52< vultraz> Mostly for debugging while writing wml I should think
20151006 18:34:59< celticminstrel> Yeah.
20151006 18:35:07< celticminstrel> Similar to [wml_message]
20151006 18:35:14< celticminstrel> (In fact it uses that internally)
20151006 18:35:23-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20151006 18:35:55< celticminstrel> Travis test is still going...
20151006 18:36:05< celticminstrel> Oh wait, one of them just failed. :|
20151006 18:37:27< celticminstrel> The test_wml_menu_items_2 test failed.
20151006 18:37:42< celticminstrel> Or rather, timed out.
20151006 18:37:50< celticminstrel> Which probably indicates a Lua error or something/
20151006 18:37:52< celticminstrel> ^.
20151006 18:39:51< celticminstrel> Everything else worked though. so I'll merge it and then push a fix if needed.
20151006 18:41:09< celticminstrel> string.format can't handle booleans. ><
20151006 18:43:25< irker175> wesnoth: Celtic Minstrel wesnoth:master fd34675dd98b / data/lua/wml-tags.lua data/test/macros/wml_unit_test_macros.cfg run_wml_tests: Add an [explain] WML tag http://git.io/vcbQ3
20151006 18:43:27< irker175> wesnoth: Celtic Minstrel wesnoth:master aa2e24d1b72f / data/lua/wml-tags.lua data/test/scenarios/for-loops.cfg wml_test_schedule: Finally fix all the [for] issues. Probably. http://git.io/vcbQs
20151006 18:43:29< irker175> wesnoth: Celtic Minstrel wesnoth:master 5353dfb43943 / data/lua/wml-tags.lua: Use return instead of goto in [while] http://git.io/vcbQG
20151006 18:43:31< irker175> wesnoth: Celtic Minstrel wesnoth:master 2018732284d3 / changelog: Update changelog http://git.io/vcbQZ
20151006 18:43:33< irker175> wesnoth: CelticMinstrel wesnoth:master 0957b562e21c / / (6 files in 4 dirs): Merge pull request #517 from CelticMinstrel/fix-for http://git.io/vcbQn
20151006 18:45:46< irker175> wesnoth: Celtic Minstrel wesnoth:master 9724d98d4493 / data/lua/wml-tags.lua: string.format blows up on booleans http://git.io/vcb7N
20151006 18:45:47< irker175> wesnoth: Celtic Minstrel wesnoth:master f8e897e8dd9c / changelog data/lua/wml-tags.lua data/test/macros/wml_unit_test_macros.cfg: Change [explain] to [test_condition] http://git.io/vcb7x
20151006 18:46:16< celticminstrel> Should get a travis failure followed by a travis success. Hopefully.
20151006 18:47:01< celticminstrel> And if anyone has any ideas for making [test_condition] handle have_unit, have_location, or custom conditionals, please tell me (or go implement it!)
20151006 18:49:52-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20151006 18:58:51-!- markus_ [~mjs-de@x4db52b06.dyn.telefonica.de] has joined #wesnoth-dev
20151006 18:58:51-!- mjs-de [~mjs-de@x4db6bf80.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20151006 18:59:02-!- jinblack_ [~jinblack@128.111.48.6] has joined #wesnoth-dev
20151006 19:04:13< irker175> wesnoth: Celtic Minstrel wesnoth:master 8a7f71578dfd / data/lua/wml/message.lua: Add (male|female)_message to [message] http://git.io/vcbpk
20151006 19:04:14< celticminstrel> Necrosporus: ^
20151006 19:07:01< Necrosporus> celticminstrel, that's cool but I assume it's not going into 1.12
20151006 19:13:14-!- gfgtdf [~chatzilla@f054145180.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0.1/20150929144111]]
20151006 19:13:18-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151006 19:13:30< celticminstrel> Yeah, I doubt it would.
20151006 19:13:57< celticminstrel> Still would be useful to build up a list of places it's needed.
20151006 19:22:36-!- shadowm_desktopW [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151006 19:29:51-!- travis-ci [~travis-ci@ec2-54-167-91-127.compute-1.amazonaws.com] has joined #wesnoth-dev
20151006 19:29:52< travis-ci> wesnoth/wesnoth#7573 (master - 0957b56 : CelticMinstrel): The build failed.
20151006 19:29:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/83950411
20151006 19:29:53-!- travis-ci [~travis-ci@ec2-54-167-91-127.compute-1.amazonaws.com] has left #wesnoth-dev []
20151006 19:31:47< celticminstrel> Next one should succeed. Hopefully.
20151006 19:31:57< celticminstrel> Unless there was more than one thing broken.
20151006 19:36:07< irker175> wesnoth: gfgtdf wesnoth:master 0cc3c812590e / src/synced_user_choice.cpp: fixed assertion failure in synced_context.cpp http://git.io/vcNLB
20151006 19:36:09< irker175> wesnoth: gfgtdf wesnoth:master e30e7bcc9d32 / src/game_initialization/playcampaign.cpp: fixed local mp games http://git.io/vcNLR
20151006 19:39:28< irker175> wesnoth: gfgtdf wesnoth:master 4167530c373c / changelog: Update changelog http://git.io/vcNtN
20151006 19:42:46< celticminstrel> gfgtdf: Mind if I move your max_experience to be together with all the other [effect] stuff?
20151006 19:43:41< celticminstrel> gfgtdf: Also, I think using a space instead of an underscore is better in the $varname?default_value|
20151006 19:43:50-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20151006 19:44:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151006 19:46:13-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20151006 19:59:56-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151006 20:06:25-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151006 20:08:05-!- travis-ci [~travis-ci@ec2-184-72-153-75.compute-1.amazonaws.com] has joined #wesnoth-dev
20151006 20:08:07< travis-ci> wesnoth/wesnoth#7574 (master - f8e897e : Celtic Minstrel): The build failed.
20151006 20:08:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/83950968
20151006 20:08:07-!- travis-ci [~travis-ci@ec2-184-72-153-75.compute-1.amazonaws.com] has left #wesnoth-dev []
20151006 20:08:19< celticminstrel> Argh.
20151006 20:09:21< celticminstrel> Hmm.
20151006 20:09:51-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Quit: Leaving]
20151006 20:12:43< celticminstrel> Oh, I know why they failed. It's because of strict mode.
20151006 20:12:53< celticminstrel> Or... not.
20151006 20:13:08< celticminstrel> Stack overflow? o.o
20151006 20:13:45< celticminstrel> ...oh. Stupid mistake. :/
20151006 20:14:43-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20151006 20:15:05-!- joet [~joet@host86-163-222-44.range86-163.btcentralplus.com] has joined #wesnoth-dev
20151006 20:17:00-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151006 20:24:16< irker175> wesnoth: Celtic Minstrel wesnoth:master 9d3f1e5c9d57 / data/lua/wml-tags.lua: Fix some issues with [test_condition] http://git.io/vcNRY
20151006 20:24:38< celticminstrel> In fact, two stupid mistakes.
20151006 20:39:07-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20151006 20:43:49-!- Netsplit *.net <-> *.split quits: celticminstrel, aeth, irker175
20151006 20:46:11-!- Netsplit over, joins: irker175, celticminstrel, aeth
20151006 20:47:09-!- ideuler [~textual@a89-153-77-183.cpe.netcabo.pt] has joined #wesnoth-dev
20151006 20:47:54-!- c74d3a [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20151006 20:48:05-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20151006 20:48:40-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151006 20:49:52-!- c74d3a [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20151006 20:57:25-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20151006 20:58:48-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151006 20:59:36-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20151006 20:59:36-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20151006 20:59:36-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20151006 21:00:58-!- travis-ci [~travis-ci@ec2-54-167-91-127.compute-1.amazonaws.com] has joined #wesnoth-dev
20151006 21:00:59< travis-ci> wesnoth/wesnoth#7575 (master - 8a7f715 : Celtic Minstrel): The build failed.
20151006 21:00:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/83954229
20151006 21:00:59-!- travis-ci [~travis-ci@ec2-54-167-91-127.compute-1.amazonaws.com] has left #wesnoth-dev []
20151006 21:02:40< celticminstrel> Should be one more failed build (from gfgtdf), then a success. Hopefully.
20151006 21:18:24-!- roberpot [~roberpot@84.122.85.148.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
20151006 21:18:38-!- roberpot [~roberpot@84.122.85.148.dyn.user.ono.com] has joined #wesnoth-dev
20151006 21:27:22-!- markus_ [~mjs-de@x4db52b06.dyn.telefonica.de] has quit [Remote host closed the connection]
20151006 21:29:21-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20151006 21:43:29-!- iceiceice [~chris@static-151-204-19-2.pskn.east.verizon.net] has joined #wesnoth-dev
20151006 21:43:29-!- iceiceice [~chris@static-151-204-19-2.pskn.east.verizon.net] has quit [Changing host]
20151006 21:43:29-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151006 21:47:21-!- joet [~joet@host86-163-222-44.range86-163.btcentralplus.com] has quit [Ping timeout: 268 seconds]
20151006 21:47:31-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Client Quit]
20151006 22:02:26-!- jinblack_ [~jinblack@128.111.48.6] has quit [Ping timeout: 250 seconds]
20151006 22:04:05-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20151006 22:04:05-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20151006 22:04:05-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151006 22:08:36-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151006 22:12:11-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151006 22:13:42-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Read error: Connection reset by peer]
20151006 22:14:00-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151006 22:20:00-!- jinblack_ [~jinblack@169-231-98-142.wireless.ucsb.edu] has joined #wesnoth-dev
20151006 22:22:31-!- flowerhack [sid6775@gateway/web/irccloud.com/x-cfbxfsoekyfiozul] has quit [Read error: Connection reset by peer]
20151006 22:23:49-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151006 22:25:35-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151006 22:31:30-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151006 22:33:15-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20151006 22:38:16-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20151006 22:38:57-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20151006 22:39:23-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has quit [Ping timeout: 250 seconds]
20151006 22:47:26-!- roberpot [~roberpot@84.122.85.148.dyn.user.ono.com] has quit [Quit: • IRcap • 8.72 •]
20151006 23:06:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151006 23:12:21-!- Appleman1234 [~Appleman1@KD106161091082.au-net.ne.jp] has joined #wesnoth-dev
20151006 23:21:36-!- flowerhack [sid6775@gateway/web/irccloud.com/x-qxsnstmkplzjcsec] has joined #wesnoth-dev
20151006 23:32:04-!- joet [~joet@host86-163-222-44.range86-163.btcentralplus.com] has joined #wesnoth-dev
20151006 23:35:35-!- jinblack_ [~jinblack@169-231-98-142.wireless.ucsb.edu] has quit [Ping timeout: 264 seconds]
20151006 23:42:29-!- jinblack_ [~jinblack@169-231-98-142.wireless.ucsb.edu] has joined #wesnoth-dev
20151006 23:43:35-!- sfan786 [~sfan786@c-98-239-230-28.hsd1.pa.comcast.net] has joined #wesnoth-dev
20151006 23:45:58-!- joet [~joet@host86-163-222-44.range86-163.btcentralplus.com] has quit [Ping timeout: 240 seconds]
20151006 23:54:24-!- sfan786 [~sfan786@c-98-239-230-28.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20151006 23:54:50-!- jinblack_ [~jinblack@169-231-98-142.wireless.ucsb.edu] has quit [Ping timeout: 240 seconds]
20151006 23:59:50-!- sfan786 [~sfan786@c-98-239-230-28.hsd1.pa.comcast.net] has joined #wesnoth-dev
20151006 23:59:51-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has quit [Remote host closed the connection]
--- Log closed Wed Oct 07 00:00:38 2015