--- Log opened Thu Oct 08 00:00:25 2015
20151008 00:00:33< celticminstrel> Oh. The terrain masks are actually not working right. Maybe that's why they're sometimes timing out.
20151008 00:00:44< celticminstrel> Without the terrain masks, the units can miss.
20151008 00:00:58< gfgtdf> also bob_kills_alice fails :/
20151008 00:01:01-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has quit [Read error: No route to host]
20151008 00:01:08< gfgtdf> i actually thought that was  arather simnple test
20151008 00:01:15-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20151008 00:02:40< gfgtdf> vultraz: you fixed your code ?
20151008 00:09:43< vultraz> no it's still failing :(
20151008 00:10:21-!- irker710 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151008 00:10:21< irker710> wesnoth: Celtic Minstrel wesnoth:master f224e2a0735d / data/test/scenarios/test_victory_attacks.cfg: Fix WML unit tests http://git.io/vCvhJ
20151008 00:56:40< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\dialogs\editor\editor_edit_side.cpp|91|note:   cannot convert 'HUMAN' (type 'team::CONTROLLER::type') to type 'team::CONTROLLER&'|
20151008 00:56:43< vultraz> gaaah
20151008 00:58:29< gfgtdf> vultraz: you shouldnt pass that parameter by reference
20151008 00:58:31< celticminstrel> Try removing & in the parameter declaration?
20151008 00:58:49< celticminstrel> (Adding const would work too.)
20151008 00:58:53< celticminstrel> (Either way.)
20151008 00:59:29< vultraz> didn't gfgtdf say neither shouldbe const
20151008 00:59:43< vultraz> oh look it builds now :O
20151008 00:59:54< celticminstrel> Sure.
20151008 01:00:08< celticminstrel> Just, if it's not const, it mustn't be & either.
20151008 01:00:20< celticminstrel> In this situation.
20151008 01:01:03-!- neverEnough [~nEnough@host73-2-dynamic.117-80-r.retail.telecomitalia.it] has joined #wesnoth-dev
20151008 01:01:44-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has quit [Read error: No route to host]
20151008 01:01:58-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20151008 01:02:07< vultraz> ok, now I just need... one more argument
20151008 01:02:10< vultraz> for the vector
20151008 01:02:20-!- gfgtdf_ [~chatzilla@f054146228.adsl.alicedsl.de] has joined #wesnoth-dev
20151008 01:03:34< celticminstrel> Should be fairly easy.
20151008 01:04:36< neverEnough> hi
20151008 01:05:10< neverEnough> from the topic's link: Wesnoth’s source code documentation is most certainly incomplete, in large part due to an over-abundance of undocumented legacy code from retired developers which no-one has ever fully understood nor wanted to examine and document.
20151008 01:05:23-!- gfgtdf [~chatzilla@f054134217.adsl.alicedsl.de] has quit [Ping timeout: 250 seconds]
20151008 01:05:29-!- gfgtdf_ is now known as gfgtdf
20151008 01:05:49< neverEnough> just 10 mins before i cloned repository and noticed wesnoth is about 400.000 lines of code.
20151008 01:06:01< neverEnough> Was wondering how big did that beast grow ^^
20151008 01:06:12< celticminstrel> It's huge, yeah.
20151008 01:06:24< vultraz> could be smaller :P
20151008 01:06:25< celticminstrel> I wonder if that might be partly why XCode's indexing keeps breaking.
20151008 01:07:00-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Ping timeout: 264 seconds]
20151008 01:08:39< vultraz> celticminstrel: can you use templates for vectors?
20151008 01:08:58< celticminstrel> Uh. Sure?
20151008 01:09:24< celticminstrel> You can use std::vector<ttoggle_button*, T> or something.
20151008 01:09:29< neverEnough> if i was about peeking the code to *maybe* add a feature, should i work on stable or latest?
20151008 01:09:36< celticminstrel> Latest.
20151008 01:09:40< neverEnough> thx
20151008 01:14:03-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20151008 01:14:47< vultraz> celticminstrel: do I need template <typename T> again, then?
20151008 01:14:59< celticminstrel> No, because it's the same T as before.
20151008 01:15:06< vultraz> oh, I see
20151008 01:15:21< celticminstrel> If it was a different T you'd add another typename to the existing template<>
20151008 01:16:03< celticminstrel> You can think of the template as a function that produces a function. <> are the arguments to the template, () is the arguments to the resulting function.
20151008 01:16:54< vultraz> er...hm
20151008 01:17:13< vultraz> I realized even if I use a template it's still pushed to the same vector
20151008 01:18:20< celticminstrel> You probably need two separate vectors.
20151008 01:18:39< celticminstrel> That's why you pass the vector as an argument, right?
20151008 01:18:58< vultraz> yeah 
20151008 01:22:28< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\dialogs\editor\editor_edit_side.cpp|91|note:   cannot convert '((gui2::teditor_edit_side*)this)->gui2::teditor_edit_side::controller_tgroup_' (type 'std::vector<std::pair<gui2::ttoggle_button*, team::CONTROLLER> >') to type 'int&'|
20151008 01:22:31< vultraz> whattt
20151008 01:22:53< vultraz> last arg is a vector not a T
20151008 01:23:39< celticminstrel> Looks like it either things the last argument is int& or thinks you're using it as int&
20151008 01:24:44< vultraz> last arg is std::vector& dst
20151008 01:25:07< celticminstrel> There's no such type as std::vector
20151008 01:25:12< celticminstrel> std::vector is a template.
20151008 01:25:19< celticminstrel> It needs tempate arguments <>
20151008 01:25:29< vultraz> vector is a template?
20151008 01:25:40< vultraz> well, that would explain the <>...
20151008 01:26:12< vultraz> so if I want to pass the name of a vector, how would I do it
20151008 01:26:14< vultraz> a string?
20151008 01:26:19< celticminstrel> No.
20151008 01:27:15< celticminstrel> I think I said a little while ago.
20151008 01:40:37< vultraz> gahh
20151008 01:45:53< vultraz> trying const std::vector<T*>& dst but that's not working either
20151008 01:47:05< vultraz> or
20151008 01:47:07< vultraz> hm wait
20151008 01:47:12< vultraz> T is the enums
20151008 01:47:15< vultraz> so... uh...
20151008 01:47:34< celticminstrel> Look at the declaration of the vector in the header file.
20151008 01:47:42< celticminstrel> Use that, but replace the team::CONTROLLER with T.
20151008 01:48:39< celticminstrel> Which also means replace conroller_toggle with its definition from the line above.
20151008 01:48:45< celticminstrel> ^controller_toggle
20151008 01:49:23-!- Appleman1234 [~Appleman1@KD106161095058.au-net.ne.jp] has quit [Ping timeout: 264 seconds]
20151008 01:49:43< vultraz> yes, ofc
20151008 01:51:43< vultraz> FINALLY builds
20151008 01:53:26-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 1.0.1]
20151008 01:54:40-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20151008 01:54:40-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20151008 01:54:40-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20151008 01:56:21< vultraz> now just to deal with passing either vector to the last function
20151008 01:58:19-!- MotorMe [~MotorMe@111.203.197.141] has joined #wesnoth-dev
20151008 02:00:20-!- gfgtdf_ [~chatzilla@f054144161.adsl.alicedsl.de] has joined #wesnoth-dev
20151008 02:01:21-!- rayblade53 [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20151008 02:01:52-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20151008 02:02:09-!- gfgtdf [~chatzilla@f054146228.adsl.alicedsl.de] has quit [Ping timeout: 250 seconds]
20151008 02:02:15-!- gfgtdf_ is now known as gfgtdf
20151008 02:02:16-!- rayblade53 is now known as vultraz
20151008 02:02:26-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has quit [Read error: No route to host]
20151008 02:02:42-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20151008 02:02:42-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151008 02:02:42-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20151008 02:02:54< vultraz> hm... might not be so easy... since I'm actually trying to bind a function with variable arguments
20151008 02:02:58< neverEnough> without bash scripting it's impossible to find a start place in that mess ^^ (regarding the weight of the sources)
20151008 02:03:22< celticminstrel> How are you trying to bind a function with variable arguments?
20151008 02:03:42< celticminstrel> Oh, you mean the template.
20151008 02:03:59< celticminstrel> You just need to instantiate the template like normal, using <>
20151008 02:04:02< celticminstrel> I think.
20151008 02:05:11< vultraz> uuuhhh....
20151008 02:07:13-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151008 02:07:54< celticminstrel> Well, I say "like normal", but for template functions it's usually implicit...
20151008 02:08:13< vultraz> this is confusing :(
20151008 02:08:27< vultraz> I just want to say 'use this vector' in this function you're binding 
20151008 02:09:28< celticminstrel> I might be a bit confused about where you are in the code right now...
20151008 02:10:02< vultraz> toggle_controller_callback
20151008 02:10:55< vultraz> it gets bound to the buttons
20151008 02:11:07< vultraz> but I want to say 'use this vector' when bound to this button
20151008 02:11:25< celticminstrel> Where's the difficulty?
20151008 02:12:20-!- neverEnough [~nEnough@host73-2-dynamic.117-80-r.retail.telecomitalia.it] has quit [Quit: found!]
20151008 02:12:32< vultraz> errrr.....
20151008 02:12:34< vultraz> actually hang on
20151008 02:12:42< pydsigner> Now to figure out why I got highlighted here....
20151008 02:12:53< vultraz> pydsigner: t'was me
20151008 02:13:16< vultraz> celticminstrel: actually, nvm, the function references more than the just the value-specific vector
20151008 02:13:23< vultraz> I guess I need to... dupe it
20151008 02:13:48 * celticminstrel looks.
20151008 02:14:03< pydsigner> Ah, so I see
20151008 02:14:21< celticminstrel> Why do you need to duplicate it? If you make it a template, it should work, right?
20151008 02:14:21< pydsigner> Yeah that mask code was a little confusing
20151008 02:15:11< vultraz> another template?
20151008 02:16:07< celticminstrel> Yeah.
20151008 02:17:05< vultraz> and pass the vector like before?
20151008 02:17:25< celticminstrel> Pretty much.
20151008 02:17:38< vultraz> this better work
20151008 02:17:57< vultraz> I thought this task would be simple.. >_>
20151008 02:21:14-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20151008 02:23:41< vultraz> ..\..\src\gui\dialogs\editor\editor_edit_side.hpp|92|error: extra qualification 'gui2::teditor_edit_side::' on member 'toggle_radio_callback' [-fpermissive]|
20151008 02:24:00< celticminstrel> Qualifications probably means const.
20151008 02:24:06-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 255 seconds]
20151008 02:24:08< celticminstrel> Oh wait duh.
20151008 02:24:24< vultraz> but none of my arguments are const
20151008 02:24:29< celticminstrel> Try just removing the bit it quotes.
20151008 02:24:35< celticminstrel> No, I was wrong, sorry.
20151008 02:24:53< vultraz> oh, derp
20151008 02:25:58< vultraz> ah great, boost::bind fuckery :(
20151008 02:27:29< vultraz> no matching function for call to 'bind(<unresolved overloaded function type>, gui2::teditor_edit_side*, std::vector<std::pair<gui2::ttoggle_button*, team::CONTROLLER> >&, team::CONTROLLER&, gui2::ttoggle_button*&)'|
20151008 02:27:46< celticminstrel> You need <> on the function now that it's a template.
20151008 02:28:02< celticminstrel> That's what it means by "unresolved overloaded function type", I think.
20151008 02:28:17< celticminstrel> If <> doesn't fix it, a cast might be required.
20151008 02:28:25< celticminstrel> Hopefully not though.
20151008 02:28:37< celticminstrel> Casting to a function type is very ugly.
20151008 02:28:54< vultraz> D:
20151008 02:29:18< celticminstrel> Just adding <T> might be enough.
20151008 02:30:08< celticminstrel> Casting to a member function type is uglier still.
20151008 02:30:57< vultraz> whewww it builds
20151008 02:31:03< celticminstrel> Yay!
20151008 02:34:26< vultraz> bleh, doesn't 100% work :( If I select option 2 while option 1 is selected, option 1 is deselected, etc, but not the other way around,
20151008 02:35:02< celticminstrel> Uh... for that, I dunno. :|
20151008 02:36:34< vultraz> Should probably push what I have to my fork anyway for now
20151008 02:36:39< celticminstrel> Sure.
20151008 02:36:55< celticminstrel> Can't look it over right now, suppertime happened suddenly.
20151008 02:41:36< vultraz> https://github.com/Vultraz/wesnoth/commit/e1cfdbbe3139697f761e35a4d0719a7f848e980e
20151008 02:44:33< vultraz> besides the issue with the buttons and the fact that share_vision doesn't actually get written to the savefile, it's working :P
20151008 02:46:58-!- Appleman1234 [~Appleman1@KD111239004026.au-net.ne.jp] has joined #wesnoth-dev
20151008 02:49:52< gfgtdf> vultraz: maybe changing the vec and value parameter of toggle_radio_callback to poiners helps, boost::bind sometimes behaves unexpected with referecnce parmaeters,
20151008 02:55:08-!- gfgtdf [~chatzilla@f054144161.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0.1/20150929144111]]
20151008 02:58:34< celticminstrel> No, the proper way to fix that is to wrap the reference in boost::ref.
20151008 03:00:46< celticminstrel> I'd say declare the vector parameter const.
20151008 03:01:02< celticminstrel> And use boost::ref to wrap the enum.
20151008 03:01:56< celticminstrel> That would be int register_radio_toggle, I think?
20151008 03:02:09< celticminstrel> ^in
20151008 03:02:28< celticminstrel> Ah, so boost::ref(current_value)
20151008 03:03:06< celticminstrel> Took me a few minutes to figure out which parameter needed wrapping.
20151008 03:03:18-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has quit [Read error: Connection reset by peer]
20151008 03:03:25< celticminstrel> vultraz:  ^
20151008 03:04:10-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20151008 03:05:14-!- travis-ci [~travis-ci@ec2-54-146-130-155.compute-1.amazonaws.com] has joined #wesnoth-dev
20151008 03:05:15< travis-ci> wesnoth/wesnoth#7592 (master - 9859091 : Celtic Minstrel): The build was broken.
20151008 03:05:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/84153206
20151008 03:05:15-!- travis-ci [~travis-ci@ec2-54-146-130-155.compute-1.amazonaws.com] has left #wesnoth-dev []
20151008 03:05:21< celticminstrel> ...
20151008 03:05:46-!- shadowm_desktopW [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20151008 03:06:51< celticminstrel> ...wait, that's not the commit that fixed it though.
20151008 03:07:29< celticminstrel> Still three more builds which'll fail, then.
20151008 03:07:52-!- shadowm_desktopW [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151008 03:08:32< celticminstrel> It's kind of annoying how slow the travis builds are.
20151008 03:08:42< celticminstrel> But I guess it can't be helped, mostly.
20151008 03:10:28-!- irker710 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151008 03:12:10-!- MotorMe [~MotorMe@111.203.197.141] has quit [Ping timeout: 240 seconds]
20151008 03:39:06-!- MotorMe [~MotorMe@111.203.197.141] has joined #wesnoth-dev
20151008 04:00:30-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 240 seconds]
20151008 04:03:52-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20151008 04:04:07-!- Coffee_irc [~david@ppp118-210-17-216.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20151008 04:05:06-!- MotorMe [~MotorMe@111.203.197.141] has quit [Ping timeout: 250 seconds]
20151008 04:06:32-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 268 seconds]
20151008 04:06:55-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20151008 04:07:48< vultraz> celticminstrel: that builds but doesn't fix my issues :/
20151008 04:09:40-!- aeonchild [~enchilado@gateway/shell/blinkenshell.org/x-dhilnncwnayrttub] has joined #wesnoth-dev
20151008 04:10:50-!- alalazo [d537b0be@gateway/web/freenode/ip.213.55.176.190] has joined #wesnoth-dev
20151008 04:16:11< celticminstrel> :/
20151008 04:39:50-!- aeonchild [~enchilado@gateway/shell/blinkenshell.org/x-dhilnncwnayrttub] has quit [Ping timeout: 240 seconds]
20151008 04:40:51-!- aeonchild [enchilado@gateway/shell/blinkenshell.org/x-kbzzmkmioqysilxl] has joined #wesnoth-dev
20151008 04:41:56-!- MotorMe [~MotorMe@111.203.197.141] has joined #wesnoth-dev
20151008 04:48:11< celticminstrel> vultraz: Two comments on https://github.com/Vultraz/wesnoth/commit/e1cfdbbe3139697f761e35a4d0719a7f848e980e
20151008 04:48:47< celticminstrel> Oh wait. I got confused, deleted one of them.
20151008 04:49:02< celticminstrel> Still, there's a typo you might want to fix... 
20151008 04:50:14< vultraz> thanks
20151008 04:50:37< celticminstrel> I thought I'd located a possible cause of your issue, but I was confusing deleted and added lines. :/
20151008 04:51:31< celticminstrel> Heh, I see you responded to that even though I deleted it.
20151008 04:51:55< vultraz> :P
20151008 04:52:41< celticminstrel> Currently trying to wrap my head around toggle_radio_callback.
20151008 04:53:19< celticminstrel> I think the "active" variable refers to the button that was just clicked?
20151008 04:53:59< celticminstrel> So perhaps if you merge the two b == active statements, that might fix it?
20151008 04:54:31< celticminstrel> Probably don't even need the null check, but it doesn't hurt I guess.
20151008 04:54:57< celticminstrel> Well, I guess it's always a good idea to make sure your pointers are not null before using them, just in case.
20151008 04:55:49< vultraz> agh. I got share_vision to write to config but it doesn't respect choice :(
20151008 04:55:59< celticminstrel> Eh?
20151008 04:56:46< vultraz> it's always controller=human and share_vision=all in the written scenario file no matter what;s chosen in the dialog
20151008 04:57:09< celticminstrel> There's probably a post_show, right?
20151008 04:57:13< celticminstrel> Maybe you need to edit that.
20151008 04:57:46< celticminstrel> Or, wait.
20151008 04:58:05< celticminstrel> I guess it's all that stuff in the constructor...
20151008 04:58:12< vultraz> it uses the execute function
20151008 04:58:30< celticminstrel> You removed the register calls for share_view and share_maps but didn't replace them with anything.
20151008 05:00:56< vultraz> https://github.com/Vultraz/wesnoth/commit/a90bd055be214241924130bab58e10fd8768a14e few small fixes
20151008 05:04:18< celticminstrel> Might need the four-argument form of register_integer...
20151008 05:04:50< vultraz> the what what?
20151008 05:04:50< celticminstrel> But wait, did controller also not work before?
20151008 05:05:50< vultraz> No idea, actually
20151008 05:06:37< celticminstrel> Okay, as far as I can see, what you have should work.
20151008 05:07:14< vultraz> Wonder if I should add handle_legacy_share_vision back
20151008 05:07:57< celticminstrel> What?
20151008 05:08:11< celticminstrel> Okay, I'm building your code now.
20151008 05:13:31-!- jinblack_ [~jinblack@128.111.48.6] has quit [Remote host closed the connection]
20151008 05:13:45-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 255 seconds]
20151008 05:29:31-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20151008 05:31:43-!- mjs-de [~mjs-de@f048001133.adsl.alicedsl.de] has joined #wesnoth-dev
20151008 05:31:58-!- Necrosporus_ is now known as Necrosporus
20151008 05:32:32< vultraz> celticminstrel: builds fine?
20151008 05:32:59< celticminstrel> Of course.
20151008 05:33:09< celticminstrel> You did say it builds.
20151008 05:34:43< vultraz> ah
20151008 05:34:47< vultraz> no magic insights?
20151008 05:34:58< celticminstrel> Not yet, I've got a ton of breakpoints set though.
20151008 05:35:23< vultraz> ah
20151008 05:35:26< vultraz> breakpoints, yes
20151008 05:35:49< celticminstrel> Unrelated (probably): I'm getting preprocessor warnings for redefining ERA_DEFAULT and ERA_HEROES.
20151008 05:36:06< vultraz> yeah, that's unrelated
20151008 05:37:06-!- alalazo [d537b0be@gateway/web/freenode/ip.213.55.176.190] has quit [Ping timeout: 246 seconds]
20151008 05:37:53-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151008 05:40:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20151008 05:40:07-!- wedge010 is now known as wedge009
20151008 05:42:53< celticminstrel> The stack is pretty ridiculous for GUI2...
20151008 05:43:49< celticminstrel> Well, I see one problem.
20151008 05:43:56< celticminstrel> For whatever reason, the vector only has one element.
20151008 05:44:06< celticminstrel> Both vectors.
20151008 05:45:04< vultraz> eh?
20151008 05:45:23< vultraz> but how
20151008 05:45:29< celticminstrel> Good question!
20151008 05:45:38< celticminstrel> Ooh.
20151008 05:45:43< celticminstrel> boost:;ref(dst)
20151008 05:45:47< celticminstrel> Wait no.
20151008 05:45:53< celticminstrel> That shouldn't be needed. Hmm.
20151008 05:45:57< celticminstrel> Well. It couldn't hurt though...
20151008 05:46:44< celticminstrel> Shouldn't be needed because toggle_radio_callback doesn't need to alter the vector (which is also why I suggested adding a const to the function declaration).
20151008 05:46:55< celticminstrel> Hmmm.
20151008 05:47:32< vultraz> const void?
20151008 05:47:38< celticminstrel> const std::vector
20151008 05:48:53< celticminstrel> Hmm, was I wrong? Now it looks like the vector correctly has three elements...
20151008 05:49:18< vultraz> O_O
20151008 05:49:27-!- jinblack_ [~jinblack@ip184-187-174-107.sb.sd.cox.net] has joined #wesnoth-dev
20151008 05:49:47< vultraz> can't be const
20151008 05:49:49< celticminstrel> Ah... it has three... but somehow... the reference in toggle_radio_callback only has one... o.O
20151008 05:49:52< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\dialogs\editor\editor_edit_side.cpp|111|error: passing 'const std::vector<std::pair<gui2::ttoggle_button*, team::CONTROLLER> >' as 'this' argument discards qualifiers [-fpermissive]|
20151008 05:50:10< celticminstrel> Where did you put the const?
20151008 05:50:23< vultraz> OH
20151008 05:50:24< vultraz> derp
20151008 05:50:24< celticminstrel> Line 115, right before std::vector?
20151008 05:50:26< vultraz> wrong function!
20151008 05:50:30< celticminstrel> Okay.
20151008 05:50:54< celticminstrel> Try adding wrapping dst in boost::ref too, on line 109.
20151008 05:51:14< celticminstrel> I don't think it'll help, but it won't hurt.
20151008 05:52:30< vultraz> celticminstrel: that fixes the toggle issue
20151008 05:52:37< vultraz> celticminstrel: still not writing back to the scenario file, though
20151008 05:52:46< celticminstrel> Huh, okay. I didn't think it would. Guess I was wrong.
20151008 05:53:56< vultraz> celticminstrel: ah, wait
20151008 05:54:00< vultraz> I've fixed the other issue too
20151008 05:54:06< celticminstrel> Oh?
20151008 05:54:11< vultraz> I had tried combining the two active checks like you said
20151008 05:54:18< celticminstrel> Oh.
20151008 05:54:20< vultraz> I reverted that
20151008 05:54:23< vultraz> and it fixed
20151008 05:54:30< celticminstrel> Ah.
20151008 05:54:38< celticminstrel> So the two issues were linked.
20151008 05:54:49< celticminstrel> Didn't expect that.
20151008 05:55:09< celticminstrel> If you click cancel, what happens when you go back into the dialog?
20151008 05:55:34< celticminstrel> I have a feeling that clicking cancel might save controller and vision anyway.
20151008 05:55:45< vultraz> previous values
20151008 05:55:48< vultraz> no change
20151008 05:55:52< celticminstrel> Okay, good.
20151008 05:56:25< celticminstrel> Oh, of course, that's handled in the context manager, alright then.
20151008 05:56:30< vultraz> Ok, now only thing left is to... uh... restore the handling of the legacy keys
20151008 05:57:00< celticminstrel> Which would be done when initializing the side, probably.
20151008 05:57:01-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 250 seconds]
20151008 05:57:28< vultraz> ?
20151008 05:57:31< vultraz> In the editor?
20151008 05:57:39< celticminstrel> Eh?
20151008 05:57:58< vultraz> https://github.com/Vultraz/wesnoth/commit/e1cfdbbe3139697f761e35a4d0719a7f848e980e#diff-830c5a08c7e557eb99acd65de593b145R214
20151008 05:58:05< vultraz> I'm wondering if I should restore this
20151008 05:58:23< vultraz> for map files from 1.12 using those values
20151008 05:58:27< vultraz> not that anyone is probably using this :P
20151008 05:58:31-!- mjs-de [~mjs-de@f048001133.adsl.alicedsl.de] has quit [Remote host closed the connection]
20151008 05:58:32< vultraz> but anyway
20151008 05:58:52< celticminstrel> BTW this seems a little out of hand: https://travis-ci.org/wesnoth/wesnoth/builds/84151315
20151008 05:59:33< vultraz> wat
20151008 05:59:39< celticminstrel> 11+ hours
20151008 06:00:04< vultraz> I saw
20151008 06:00:06< vultraz> O_O
20151008 06:01:01< celticminstrel> Regarding that commented bit, yes, I think you should restore it.
20151008 06:01:17< celticminstrel> Though...
20151008 06:01:33< celticminstrel> That's probably not the correct place for it.
20151008 06:02:37< celticminstrel> Try team.cpp, line 120.
20151008 06:02:46< celticminstrel> The read function should be able to handle it.
20151008 06:03:17< celticminstrel> Surprisingly, it looks like it doesn't already... unless I missed it...
20151008 06:03:22< celticminstrel> Maybe it does...
20151008 06:03:38< celticminstrel> Ah yes, it does, okay, so then you probably don't need to worry about it?
20151008 06:04:34< vultraz> so, don't restore it?
20151008 06:04:44< celticminstrel> Well, you have to have something there.
20151008 06:05:00< celticminstrel> To set the vision to the requested value.
20151008 06:05:11< celticminstrel> But you shouldn't need handle_legacy_share_vision.
20151008 06:05:15< celticminstrel> I think.
20151008 06:05:24< vultraz> I do have something there
20151008 06:05:39< celticminstrel> Eh?
20151008 06:05:43< vultraz> https://github.com/Vultraz/wesnoth/commit/a90bd055be214241924130bab58e10fd8768a14e#diff-830c5a08c7e557eb99acd65de593b145R215
20151008 06:06:50< celticminstrel> That's in a completely different function from where I was looking...
20151008 06:07:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20151008 06:07:36< celticminstrel> Oh, wait.
20151008 06:07:39< vultraz> ....eh?
20151008 06:07:52< celticminstrel> Gah.
20151008 06:07:56< celticminstrel> Never mind.
20151008 06:07:58< celticminstrel> I see it now.
20151008 06:08:46< vultraz> in that case, PR incoming
20151008 06:12:15< vultraz> 519 open
20151008 06:14:14< vultraz> thanks again for helping :)
20151008 06:14:45< vultraz> I've had this sitting around for months
20151008 06:19:50-!- MotorMe_ [~MotorMe@111.203.197.141] has joined #wesnoth-dev
20151008 06:20:05-!- MotorMe [~MotorMe@111.203.197.141] has quit [Ping timeout: 240 seconds]
20151008 06:31:42-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20151008 06:44:05-!- MotorMe [~MotorMe@111.203.197.141] has joined #wesnoth-dev
20151008 06:44:58-!- Appleman1234 [~Appleman1@KD111239004026.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20151008 06:46:20-!- MotorMe_ [~MotorMe@111.203.197.141] has quit [Ping timeout: 272 seconds]
20151008 06:55:54-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151008 07:03:53-!- aeonchild [enchilado@gateway/shell/blinkenshell.org/x-kbzzmkmioqysilxl] has quit [Changing host]
20151008 07:03:54-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20151008 07:04:54-!- ayylmao [6bb845e1@gateway/web/freenode/ip.107.184.69.225] has joined #wesnoth-dev
20151008 07:05:16-!- ayylmao [6bb845e1@gateway/web/freenode/ip.107.184.69.225] has quit [Client Quit]
20151008 07:14:53-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151008 07:42:43-!- jinblack_ [~jinblack@ip184-187-174-107.sb.sd.cox.net] has quit [Ping timeout: 265 seconds]
20151008 07:44:20-!- genbattle [~genbattle@122-57-89-170.jetstream.xtra.co.nz] has joined #wesnoth-dev
20151008 07:57:47-!- Appleman1234 [~Appleman1@KD111239004026.au-net.ne.jp] has joined #wesnoth-dev
20151008 08:05:58-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: Smell ya later]
20151008 08:06:58-!- ypnos [~ypnos@boron.physiol.uni-freiburg.de] has joined #wesnoth-dev
20151008 08:15:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151008 09:12:38-!- shadowm_desktopW [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20151008 09:48:06-!- genbattle [~genbattle@122-57-89-170.jetstream.xtra.co.nz] has quit [Ping timeout: 272 seconds]
20151008 10:04:28-!- MotorMe_ [~MotorMe@111.203.197.141] has joined #wesnoth-dev
20151008 10:05:14-!- ypnos [~ypnos@boron.physiol.uni-freiburg.de] has quit [Ping timeout: 244 seconds]
20151008 10:05:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20151008 10:05:22-!- MotorMe [~MotorMe@111.203.197.141] has quit [Ping timeout: 246 seconds]
20151008 10:09:00-!- MotorMe_ [~MotorMe@111.203.197.141] has quit [Ping timeout: 272 seconds]
20151008 10:12:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151008 10:36:56-!- ypnos [~ypnos@boron.physiol.uni-freiburg.de] has joined #wesnoth-dev
20151008 10:42:13< vultraz> god dammit
20151008 10:42:18< vultraz> going on 16 hours on that travis test
20151008 10:42:24< vultraz> what the hell
20151008 11:11:32-!- MotorMe [~MotorMe@111.203.197.141] has joined #wesnoth-dev
20151008 11:20:34-!- MotorMe [~MotorMe@111.203.197.141] has quit [Ping timeout: 272 seconds]
20151008 11:24:27-!- MotorMe [~MotorMe@111.203.197.141] has joined #wesnoth-dev
20151008 11:25:52< vultraz> "The system is going down for power off NOW!"
20151008 11:25:59< vultraz> so....it left the test hanging?
20151008 11:29:26-!- MotorMe [~MotorMe@111.203.197.141] has quit [Ping timeout: 272 seconds]
20151008 11:57:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20151008 11:59:12-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection timed out]
20151008 12:28:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20151008 12:28:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20151008 12:31:07-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151008 12:53:12-!- watt [47383a32@gateway/web/freenode/ip.71.56.58.50] has quit [Ping timeout: 246 seconds]
20151008 12:55:43-!- pe_em [53183a6e@gateway/web/freenode/ip.83.24.58.110] has joined #wesnoth-dev
20151008 12:57:08-!- pe_em [53183a6e@gateway/web/freenode/ip.83.24.58.110] has left #wesnoth-dev []
20151008 13:05:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151008 13:23:44-!- Kwandulin [~Miranda@p5B0085FE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151008 13:59:47-!- Appleman1234 [~Appleman1@KD111239004026.au-net.ne.jp] has quit [Ping timeout: 268 seconds]
20151008 14:05:32-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Read error: Connection reset by peer]
20151008 14:20:43< vultraz> shadowm: can you do something about this
20151008 14:28:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20151008 14:38:01-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151008 14:38:14-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20151008 14:47:10-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20151008 14:59:19-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20151008 15:19:06-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20151008 15:31:33-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20151008 16:08:11-!- Kwandulin [~Miranda@p5B0085FE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151008 16:15:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20151008 16:16:21-!- travis-ci [~travis-ci@ec2-174-129-87-1.compute-1.amazonaws.com] has joined #wesnoth-dev
20151008 16:16:23< travis-ci> wesnoth/wesnoth#7593 (master - 57c79de : CelticMinstrel): The build was broken.
20151008 16:16:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/84153223
20151008 16:16:23-!- travis-ci [~travis-ci@ec2-174-129-87-1.compute-1.amazonaws.com] has left #wesnoth-dev []
20151008 16:19:52-!- joet [~joet@host86-163-222-44.range86-163.btcentralplus.com] has quit [Ping timeout: 246 seconds]
20151008 16:22:06-!- joet [~joet@host86-163-218-92.range86-163.btcentralplus.com] has joined #wesnoth-dev
20151008 16:22:19-!- ypnos [~ypnos@boron.physiol.uni-freiburg.de] has quit [Ping timeout: 252 seconds]
20151008 16:48:24-!- roberpot [~roberpot@84.122.85.148.dyn.user.ono.com] has joined #wesnoth-dev
20151008 16:49:17-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20151008 16:49:35-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151008 17:02:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20151008 17:02:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20151008 17:02:56-!- Shackra [~Jorge@186.177.2.148] has quit [Read error: Connection reset by peer]
20151008 17:17:55-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20151008 17:28:03< celticminstrel> Trying to think how the Lua interface to unit variables could be improved.
20151008 17:28:30< celticminstrel> I could add iterators so that you can use eg helper.child_range(), but I'd kinda like to be able to use helper.get_variable_array()...
20151008 17:29:25< celticminstrel> Thoufg I guess that might be weird...
20151008 17:29:34< celticminstrel> ^Though
20151008 17:34:12-!- gfgtdf [~chatzilla@f054144161.adsl.alicedsl.de] has joined #wesnoth-dev
20151008 17:35:21< gfgtdf> celticminstrel: coud change the implementation of the __index and __newindex to use teh variable_info class list wesnoth.get_variable does then it coudl also handle table values
20151008 17:36:26< gfgtdf> celticminstrel: it would also be able to acces subvariables but the syntax woudl be rather strange (unit.variables["varname1[7].keyname2"])
20151008 17:37:27< gfgtdf> able/possible
20151008 17:40:17< celticminstrel> Hmm.
20151008 17:41:13< celticminstrel> Incidentally, you can already get table values from the __cfg, but I think that might be read-only (haven't checked though).
20151008 17:42:03< gfgtdf> celticminstrel: it is read only, also __cfg might be slower becare it stores the whole unit (instreda of just teh parts that you need)
20151008 17:42:17< celticminstrel> No. I mean unit.variables.__cfg
20151008 17:42:36< gfgtdf> celticminstrel: hmm didnt know we have that
20151008 17:42:43< celticminstrel> :)
20151008 17:42:58< gfgtdf> celticminstrel: still i think its readonly
20151008 17:43:04< celticminstrel> Why can't you mix [value] and [literal] in [set_variables]?
20151008 17:43:28< celticminstrel> That seems like something that could be easily changed.
20151008 17:43:33< gfgtdf> celticminstrel: why shoudl yuou want that ?
20151008 17:43:54< celticminstrel> If you want to build an array where variable substitution is only disabled in one element.
20151008 17:45:10-!- Appleman1234 [~Appleman1@KD111239013003.au-net.ne.jp] has joined #wesnoth-dev
20151008 17:46:09-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151008 17:47:22< gfgtdf> celticminstrel: i never needed that so i dont really care
20151008 17:48:56< celticminstrel> Looks like it'd be really easy to allow it.
20151008 17:49:06< celticminstrel> In fact I could even allow mixing in [split] with [value] and [literal].
20151008 17:49:44< celticminstrel> Looking at the implementation of [set_variable], it seems that it checks every possible key and uses it, meaning that only one key actually has an effect and it's not entirely predictable which one.
20151008 17:49:47< gfgtdf> celticminstrel: [split] ia a actionswml tag or is it part of [ser_variables] ?
20151008 17:49:57< celticminstrel> It's part of [set_variables]
20151008 17:56:20-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20151008 17:56:54< celticminstrel> ...so...if I'm not mistaken... if $var contains 7 and you do [set_variable]name,add,sub,multiply,divide=var,10,3,2,7[set_variable], then $var will end up as 4. And the same if you change the order of add/sub/etc.
20151008 17:57:17< celticminstrel> Wouldn't it make more sense to enforce having just one of those?
20151008 17:58:35< gfgtdf> celticminstrel: what do you mean by enforce?
20151008 17:58:52< gfgtdf> celticminstrel: also people usuallyus eteh VARIABLE_OP marcso which only support one other key than name
20151008 17:58:56< gfgtdf> marco
20151008 17:59:02< celticminstrel> Give an error if there are multiple.
20151008 17:59:15< celticminstrel> Yeah, {VARIABLE_OP} is handy.
20151008 18:01:09< gfgtdf> celticminstrel: so are you going to change teh interface of lua unit variables ?
20151008 18:01:26< celticminstrel> Likely.
20151008 18:04:04< vultraz> celticminstrel: I discovered a random benefit of the new [message] implementation: consecutive messages by the same speaker do not close and then reopen the dialog
20151008 18:04:22< celticminstrel> ...eh? How?
20151008 18:04:29< vultraz> the text simply changes
20151008 18:04:43< celticminstrel> How is this even possible?
20151008 18:04:49< vultraz> I have no idea
20151008 18:04:55< vultraz> I just observed it
20151008 18:05:13< gfgtdf> was the mouse route not cleared after message bug alread fixed ?
20151008 18:08:02< vultraz> the what?
20151008 18:11:35-!- Appleman1234 [~Appleman1@KD111239013003.au-net.ne.jp] has quit [Ping timeout: 264 seconds]
20151008 18:13:38< celticminstrel> gfgtdf: What was this variable_info you were talking about?
20151008 18:14:19< gfgtdf> celticminstrel: the variable_info class defined in variable_info.cpp but i can also do that if you want
20151008 18:19:15< vultraz> gfgtdf: do you have any comment on 519
20151008 18:20:37-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 246 seconds]
20151008 18:24:10< gfgtdf> vultraz: no i dont see prblems, does it work ?
20151008 18:24:16< vultraz> yes
20151008 18:24:58< celticminstrel> gfgtdf: Regarding the [insert_tag] thing, I can't think of any reason not to implement it. Maybe add a keep_if_empty key that defaults to false, just in case anyone relied on the old behaviour.
20151008 18:25:10-!- joet [~joet@host86-163-218-92.range86-163.btcentralplus.com] has quit [Remote host closed the connection]
20151008 18:25:26< celticminstrel> Note that [insert_tag] is handled in the Lua code as well, in handle_event_commands.
20151008 18:26:01< gfgtdf> celticminstrel	. i actually wouldnt liek to ass such attributes if i am not sure that they are useful
20151008 18:26:42 * celticminstrel shrugs.
20151008 18:27:20< celticminstrel> There aren't many places where having an empty tag is different from having no tag.
20151008 18:27:34< celticminstrel> ActionWML, ConditionalWML...
20151008 18:27:52< celticminstrel> Well, anywhere that iterates over all children, I guess.
20151008 18:28:05< celticminstrel> Rather than iterating over a child_range for a specific tag.
20151008 18:28:15< celticminstrel> Or just getting the first child of a specific tag.
20151008 18:29:02< celticminstrel> But, in ActionWML, I don't think the ability to insert empty tags is very useful? How many tags are there that a) would be empty and b) would make sense to insert from a variable?
20151008 18:29:23< celticminstrel> [redraw], [break], [continue], [return] all don't seem like they'd be used that way.
20151008 18:29:29< celticminstrel> I think there are others though?
20151008 18:30:29< vultraz> show_objectives 
20151008 18:30:33< vultraz> exists
20151008 18:30:46< vultraz> but again, no need to be generated
20151008 18:31:15< celticminstrel> [redraw] does have some optional keys, but I don't think there'd be any need to generate it maybe with optional keys.
20151008 18:31:42< celticminstrel> Because the optional keys only restrict what it does.
20151008 18:31:55< vultraz> yeah
20151008 18:31:59< vultraz> I think just implement it
20151008 18:32:09< vultraz> You don't even need an optional key
20151008 18:32:19< celticminstrel> According to the forum thread, zookeeper also supports it.
20151008 18:33:37< vultraz> so, do we get $200?
20151008 18:34:11< celticminstrel> Dunno. :P
20151008 18:34:17< zookeeper> well whether there are empty ActionWML tags or not shouldn't matter, because it's not like you use [insert_tag] to place a tag like that. what you might do is place a tag containing those tags.
20151008 18:34:27< celticminstrel> I guess not.
20151008 18:34:33< celticminstrel> Yeah.
20151008 18:38:20-!- mjs-de [~mjs-de@f048001133.adsl.alicedsl.de] has joined #wesnoth-dev
20151008 18:39:29-!- jinblack_ [~jinblack@128.111.48.6] has joined #wesnoth-dev
20151008 18:39:59< gfgtdf> celticminstrel: here i implemented the unit.varibles thing: https://github.com/gfgtdf/wesnoth-old/commit/5d8a3a97779cd9a802bcec1ff3218fb0889b22f9 will merge when the travis has finished.
20151008 18:40:17< celticminstrel> I was working on it. :/
20151008 18:41:00< gfgtdf> celticminstrel: :/ i said i can also do that
20151008 18:41:37< celticminstrel> Hmm. Well, it's not quite what I did, but the effect is basically the same, I guess.
20151008 18:41:52< celticminstrel> I also think it needs more work (since as you said, the syntax is strange) but, it's a start.
20151008 18:43:22 * vultraz is also waiting for travis
20151008 18:43:53< celticminstrel> I also like how you added new luaW functions for variables. :)
20151008 18:45:09< gfgtdf> vultraz: you can enable travis checks for your work, that way you dont have to wait for the original travis to have time
20151008 18:45:18< vultraz> oh?
20151008 18:45:20< vultraz> how?
20151008 18:45:22< gfgtdf> fork*
20151008 18:45:55< gfgtdf> vultraz: don't remember exactly but if i rmember correctly you can login in teh travis page with your github account andenable it in teh travis settings
20151008 18:46:03< vultraz> hmm
20151008 18:56:40-!- ancestral [~ancestral@173-8-126-226-Minnesota.hfc.comcastbusiness.net] has joined #wesnoth-dev
20151008 18:59:04-!- markus_ [~mjs-de@x4db604a3.dyn.telefonica.de] has joined #wesnoth-dev
20151008 18:59:49< celticminstrel> About to test my [set_variables] change, will then push unless someone has issue with it. In particular, zookeeper. (The change is that all [value], [literal], [split] are now parsed in order of appearance.)
20151008 19:02:12-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20151008 19:02:46-!- mjs-de [~mjs-de@f048001133.adsl.alicedsl.de] has quit [Ping timeout: 260 seconds]
20151008 19:08:24-!- Appleman1234 [~Appleman1@KD111239024014.au-net.ne.jp] has joined #wesnoth-dev
20151008 19:12:07-!- pe_em [531f7421@gateway/web/freenode/ip.83.31.116.33] has joined #wesnoth-dev
20151008 19:12:31-!- pe_em [531f7421@gateway/web/freenode/ip.83.31.116.33] has quit [Client Quit]
20151008 19:28:48-!- ancestral [~ancestral@173-8-126-226-Minnesota.hfc.comcastbusiness.net] has quit [Quit: i go nstuf kthxbai]
20151008 19:31:09-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20151008 19:32:28-!- Nobun [~nobun@5.170.1.240] has joined #wesnoth-dev
20151008 19:36:56-!- travis-ci [~travis-ci@ec2-54-82-66-103.compute-1.amazonaws.com] has joined #wesnoth-dev
20151008 19:36:57< travis-ci> gfgtdf/wesnoth-old#554 (lua_carryover - 5d8a3a9 : gfgtdf): The build passed.
20151008 19:36:57< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/84362488
20151008 19:36:57-!- travis-ci [~travis-ci@ec2-54-82-66-103.compute-1.amazonaws.com] has left #wesnoth-dev []
20151008 19:37:56-!- irker403 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151008 19:37:56< irker403> wesnoth: gfgtdf wesnoth:master a77fada7845f / src/scripting/ (game_lua_kernel.cpp lua_common.cpp lua_common.hpp): add access to tables via unit.variables http://git.io/vCIYB
20151008 19:38:42-!- Appleman1234 [~Appleman1@KD111239024014.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20151008 19:42:00< irker403> wesnoth: Celtic Minstrel wesnoth:master 285f8c80e232 / src/ (game_events/action_wml.cpp variable.hpp): Allow mixing [literal], [value], and even [split] in [set_variables] http://git.io/vCI3Y
20151008 19:44:42-!- c74d3a [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20151008 19:45:39< celticminstrel> When 1.12 came out, did someone have to go through and manually remove all calls to the {{DevFeature1.11}} template, or is there something that automates that?
20151008 19:45:49< vultraz> Former
20151008 19:46:06< celticminstrel> Probably best that way, even if it's rather a lot of work...
20151008 19:46:21< celticminstrel> Sometimes things would need to be rewritten a little, right?
20151008 19:47:00< vultraz> Yes
20151008 19:47:22< vultraz> I believe I didn't get to dealing with removing the wesnoth.register_wml_action documentation 
20151008 19:47:43< celticminstrel> I fixed an example that was using it.
20151008 19:54:04-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 246 seconds]
20151008 20:13:26-!- shadowm_desktopW [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151008 20:24:28-!- jinblack_ [~jinblack@128.111.48.6] has quit [Quit: Leaving]
20151008 20:24:52-!- jinblack_ [~jinblack@128.111.48.6] has joined #wesnoth-dev
20151008 20:30:07-!- jinblack_ [~jinblack@128.111.48.6] has quit [Ping timeout: 246 seconds]
20151008 20:31:06-!- jinblack_ [~jinblack@jinblack.it] has joined #wesnoth-dev
20151008 20:31:54-!- roberpot [~roberpot@84.122.85.148.dyn.user.ono.com] has left #wesnoth-dev []
20151008 20:37:18-!- Appleman1234 [~Appleman1@KD111239001094.au-net.ne.jp] has joined #wesnoth-dev
20151008 20:37:45-!- jinblack_ [~jinblack@jinblack.it] has quit [Quit: Leaving]
20151008 20:42:49-!- jinblack [~jinblack@jinblack.it] has joined #wesnoth-dev
20151008 20:46:10-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20151008 21:00:22-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20151008 21:02:26-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 244 seconds]
20151008 21:05:13-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20151008 21:06:51-!- Appleman1234 [~Appleman1@KD111239001094.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20151008 21:29:35-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20151008 21:35:14-!- markus_ [~mjs-de@x4db604a3.dyn.telefonica.de] has quit [Remote host closed the connection]
20151008 21:53:52< celticminstrel> I think builds 7594 and 7595 should probably be cancelled too.
20151008 21:55:39-!- ideuler [~textual@a89-153-77-183.cpe.netcabo.pt] has joined #wesnoth-dev
20151008 22:04:13-!- Appleman1234 [~Appleman1@KD118156240228.au-net.ne.jp] has joined #wesnoth-dev
20151008 22:05:41-!- travis-ci [~travis-ci@ec2-54-163-50-211.compute-1.amazonaws.com] has joined #wesnoth-dev
20151008 22:05:42< travis-ci> wesnoth/wesnoth#7596 (master - f224e2a : Celtic Minstrel): The build was fixed.
20151008 22:05:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/84211026
20151008 22:05:42-!- travis-ci [~travis-ci@ec2-54-163-50-211.compute-1.amazonaws.com] has left #wesnoth-dev []
20151008 22:05:54-!- jinblack [~jinblack@jinblack.it] has left #wesnoth-dev ["Leaving"]
20151008 22:13:29-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Quit: Leaving]
20151008 22:26:22-!- Nobun [~nobun@5.170.1.240] has quit [Quit: Salve a tutti]
20151008 22:32:05-!- o11c [~ben@unaffiliated/o11c] has joined #wesnoth-dev
20151008 22:32:41< o11c> I just hit an interesting bug with Wesnoth 1.12 under KWin5
20151008 22:33:04< o11c> Incidentally, what's the status on porting 1.13 to SDL2?
20151008 22:34:02< celticminstrel> Going pretty well, I think. Ask Aginor for more details.
20151008 22:34:16< o11c> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800747
20151008 22:36:44< o11c> actually, this looks pretty similar to an old report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=743528
20151008 22:37:08< o11c> the SDL2 thing is unrelated to the bug itself, but related to why I don't start wesnoth in fullscreen mode in the first place
20151008 22:42:11-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151008 22:42:14-!- irker403 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151008 22:42:46< Aginor> o11c: there's one unfixed bug in SDL2 with regards to window resize that I still need to fix
20151008 22:43:22< Aginor> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=743528 is probably fixed on the SDL2 branch
20151008 22:44:42< Aginor> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800747 looks completely unrelated to any SDL related activity
20151008 22:45:02< o11c> Aginor: if you need any help with the SDL2 port I do have some experience with that.
20151008 22:45:49< o11c> but incidentally, I am very disappointed by what the forum thread said about "draw the whole frame every time"
20151008 22:45:57< o11c> that is a great way to make my laptop's CPU overheat and halt
20151008 22:46:33< o11c> even if the GPU uses a diff at the end, all the logic *getting* there hurts the CPU
20151008 22:46:44< Aginor> o11c: step one is to get SDL2 going, step2 is to optimize the rendering path to something slightly more sensible
20151008 22:47:11< o11c> "draw the whole frame" is only sensible where you can't reasonably expect most of the frame to stay the same
20151008 22:47:20< o11c> for wesnoth, damage-based is the way to go
20151008 22:47:34< celticminstrel> Well, to be fair, there is a good change that the whole frame will change.
20151008 22:47:39< celticminstrel> ^chance that
20151008 22:47:54< celticminstrel> Every time scrolling happens, for example.
20151008 22:47:58< Aginor> o11c: are you familiar with the resize event handling and X/SDL2 event handling in general?
20151008 22:48:22-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 246 seconds]
20151008 22:48:24< Aginor> I'm seeing issues with dropped events, and I haven't been able to figure out why the events are dropped in the first place
20151008 22:48:53< Aginor> the reason the events are dropped is because a full screen redraw takes too long, making the interval between the event pumping too long
20151008 22:49:28< Aginor> the result of this is that X/VM and SDL disagrees about the window size
20151008 22:49:56< Aginor> also, a lot of the drawing does not redraw the entire screen, bot only the changed rectangle(s)
20151008 22:49:56-!- iceiceice [~chris@23.31.228.41] has joined #wesnoth-dev
20151008 22:49:56-!- iceiceice [~chris@23.31.228.41] has quit [Changing host]
20151008 22:49:56-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151008 22:50:09< o11c> right, currently it does that, which is good
20151008 22:50:26< o11c> I'm fairly familiar with the client side, but not the WM side
20151008 22:50:53< Aginor> I've debugged my way through wesnoth, SDL2 and I need to move into xlib
20151008 22:50:57< o11c> I tried testing some SDL2 stuff in wayland but wayland is still pretty buggy
20151008 22:51:12< o11c> or maybe just the SDL2 integration
20151008 22:51:24< Aginor> I don't think we have official wayland support yet :)
20151008 22:55:04-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 244 seconds]
20151008 22:55:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20151008 22:56:20< Aginor> o11c: so do you think you might be able to help? :)
20151008 22:57:06-!- iceiceice [~chris@23.31.228.41] has joined #wesnoth-dev
20151008 22:57:06-!- iceiceice [~chris@23.31.228.41] has quit [Changing host]
20151008 22:57:06-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151008 23:03:22< o11c> possibly
20151008 23:03:40< o11c> obviously not with wayland until even a minimal example works
20151008 23:06:09< o11c> 3 gigabytes is a lot to clone
20151008 23:06:27< o11c> really wish historical wesnoth devs hadn't crushed their PNGs all the time
20151008 23:06:36< o11c> that sort of thing *kills* git
20151008 23:21:07< Aginor> o11c: so only clone the top commit
20151008 23:30:57-!- Appleman1234 [~Appleman1@KD118156240228.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20151008 23:41:48-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151008 23:56:37-!- louis94 [~~louis94@42.133-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
--- Log closed Fri Oct 09 00:00:08 2015