--- Log opened Sun Oct 18 00:00:40 2015
20151018 00:35:09-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 250 seconds]
20151018 00:35:15-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151018 00:37:14-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20151018 00:41:14-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151018 00:43:58-!- framlinqp [~user@104.200.154.63] has joined #wesnoth-dev
20151018 00:45:34-!- framling [~user@104.200.154.63] has quit [Ping timeout: 260 seconds]
20151018 00:48:35-!- framling [~user@c-50-186-43-50.hsd1.or.comcast.net] has joined #wesnoth-dev
20151018 00:49:02-!- framlinqp [~user@104.200.154.63] has quit [Ping timeout: 246 seconds]
20151018 00:49:17-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20151018 00:50:56-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20151018 01:03:48< shadowm> http://i.imgur.com/y7JUdZg.png
20151018 01:04:31< shadowm> Something I've noticed is that this seems to be a side-effect of pressing F5 to reload WML from the titlescreen.
20151018 01:09:09-!- gfgtdf_ [~chatzilla@f054137159.adsl.alicedsl.de] has joined #wesnoth-dev
20151018 01:11:14-!- gfgtdf [~chatzilla@x55b17686.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20151018 01:11:19-!- gfgtdf_ is now known as gfgtdf
20151018 01:29:16< vultraz> shadowm: still waiting for groovy. He had replied to me and said not too many left.
20151018 01:34:45-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind1]
20151018 01:39:09-!- MrMaemo [4b44307e@gateway/web/freenode/ip.75.68.48.126] has quit [Ping timeout: 246 seconds]
20151018 01:39:44-!- MrMaemo [4b44307e@gateway/web/freenode/ip.75.68.48.126] has joined #wesnoth-dev
20151018 01:45:40-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20151018 01:52:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20151018 01:59:51-!- irker049 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151018 02:21:28-!- gfgtdf [~chatzilla@f054137159.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0.2/20151014143721]]
20151018 03:04:49-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151018 03:06:23-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 250 seconds]
20151018 03:08:16-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151018 03:30:06-!- midzer [~quassel@p4FFCE1F9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151018 03:53:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20151018 03:53:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20151018 04:01:39-!- oldlaptop [~quassel@50.36.238.180] has quit [Ping timeout: 240 seconds]
20151018 04:14:39-!- oldlaptop [~quassel@50.36.238.180] has joined #wesnoth-dev
20151018 04:19:23-!- oldlaptop [~quassel@50.36.238.180] has quit [Read error: Connection reset by peer]
20151018 04:54:51-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20151018 04:57:36-!- Rh0nda [~rhonda@anguilla.noreply.org] has joined #wesnoth-dev
20151018 04:58:27-!- aeth_ [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20151018 05:03:01-!- Netsplit *.net <-> *.split quits: Rhonda, raoniff, aeth, janebot, crimson_penguin
20151018 05:03:05-!- crimson_pingvin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev
20151018 05:03:25-!- crimson_pingvin is now known as crimson_penguin
20151018 05:03:34-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host]
20151018 05:03:34-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20151018 05:09:40-!- Netsplit over, joins: raoniff
20151018 05:26:56-!- Kwandulin [~Miranda@p5B0092F4.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151018 05:44:45-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 240 seconds]
20151018 06:56:52-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has joined #wesnoth-dev
20151018 06:57:47-!- framling [~user@c-50-186-43-50.hsd1.or.comcast.net] has quit [Ping timeout: 264 seconds]
20151018 07:04:08-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151018 07:06:46-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20151018 07:06:46-!- wedge010 is now known as wedge009
20151018 07:12:12-!- irker578 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151018 07:12:12< irker578> wesnoth: Charles Dang wesnoth:master 2f88db8b9f4a / src/gui/widgets/list.cpp: tlist: remove ancient foreach.hpp include and use BOOST_FOREACH instead http://git.io/vCNGF
20151018 07:12:15< irker578> wesnoth: Charles Dang wesnoth:master 6f83bdebb473 / src/gui/widgets/list.cpp: tlist: add missing includes for find_widget and REGISTER_WIDGET http://git.io/vCNGN
20151018 07:12:18< irker578> wesnoth: Charles Dang wesnoth:master c2f469ee8572 / src/gui/widgets/list.cpp: tlist: update calls to set_dirty to set_is_dirty http://git.io/vCNGA
20151018 07:12:21< irker578> wesnoth: Charles Dang wesnoth:master 741b23300701 / src/gui/dialogs/ (campaign_settings.cpp depcheck_select_new.cpp label_settings.cpp): Use experimental listbox when defined in all cases http://git.io/vCNGx
20151018 07:12:24< irker578> wesnoth: Charles Dang wesnoth:master a137a62170aa / src/gui/dialogs/game_version.hpp: tgame_version: use tlist class when experimental listbox is enabled http://git.io/vCNGp
20151018 07:19:02-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151018 07:19:47-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151018 07:21:08-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Client Quit]
20151018 07:22:41-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 252 seconds]
20151018 07:25:05-!- abc123 [959fd883@gateway/web/freenode/ip.149.159.216.131] has joined #wesnoth-dev
20151018 07:25:13-!- abc123 [959fd883@gateway/web/freenode/ip.149.159.216.131] has quit [Client Quit]
20151018 07:25:58-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151018 07:25:58-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20151018 07:29:48-!- mjs-de [~mjs-de@x4db523d9.dyn.telefonica.de] has joined #wesnoth-dev
20151018 07:30:21-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151018 07:30:32< celticminstrel> Wait, FOREACH() was actually an older thing?
20151018 07:30:52< celticminstrel> I thought it was newer.
20151018 07:30:57< vultraz> foreach
20151018 07:31:11< vultraz> apparently it was a BOOST_FOREACH alias 
20151018 07:31:16< celticminstrel> Seemed to be trying to emulate C++11 range-for more closely.
20151018 07:31:16< vultraz> the file doesn't exist anymore
20151018 07:31:29< celticminstrel> Hmm.
20151018 07:31:38< celticminstrel> Ohh.
20151018 07:31:49< celticminstrel> I'm thinking of something different.
20151018 07:31:53< celticminstrel> Never mind then.
20151018 07:33:10< vultraz> Sadly, I can't even get the experimental listbox to show up to test if it handles scrollbars differently
20151018 07:33:41< vultraz> plus, it's still missing a ton of functions :(
20151018 07:36:58-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20151018 07:49:47-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151018 07:59:33-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: Smell ya later]
20151018 08:00:05-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151018 08:12:03-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20151018 08:16:06< shadowm> wedge009: 5bd79efa8b615e020ed6adc6abd036133cc739e7 breaks the : command box hotkey for me on 1.12 (note that : on my keyboard is shift+.).
20151018 08:16:13< shadowm> Not good. :p
20151018 08:17:17< shadowm> While I can enter the hotkey in preferences and it displays correctly there, it has no effect in-game.
20151018 08:20:40< vultraz> Ok, so RE the experimental listbox, it's totally broken and whatnot, but in any case barring missing functions that would need to be commented out, you can build it
20151018 08:29:58-!- ancestral_ [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151018 08:30:05-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has quit [Ping timeout: 250 seconds]
20151018 08:32:08-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: Smell ya later]
20151018 08:32:08-!- ancestral_ is now known as ancestral
20151018 08:46:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20151018 08:49:08< zookeeper> Jetrel_bot, so, got anything yet?
20151018 08:49:24< Jetrel_bot> Nope; I'm working on those animations tonight.
20151018 08:49:49< zookeeper> what animations?
20151018 08:49:54< Jetrel_bot> I will get to it this weekend, but saturday's been blocked off for a work marathon.
20151018 08:50:06< Jetrel_bot> zookeeper:  frogatto's swimming animations
20151018 08:50:10< zookeeper> oh, right
20151018 08:57:19-!- travis-ci [~travis-ci@ec2-54-161-54-184.compute-1.amazonaws.com] has joined #wesnoth-dev
20151018 08:57:20< travis-ci> wesnoth/wesnoth#7659 (master - a137a62 : Charles Dang): The build is still failing.
20151018 08:57:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/85999857
20151018 08:57:20-!- travis-ci [~travis-ci@ec2-54-161-54-184.compute-1.amazonaws.com] has left #wesnoth-dev []
20151018 09:06:26-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20151018 09:16:48-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151018 09:25:59< irker578> wesnoth: Charles Dang wesnoth:master a599a3338e8e / data/gui/default/widget/listbox_default.cfg: Revert "Experimental fix for GUI2 listbox headers outside vertical scroll area" http://git.io/vCNzb
20151018 09:41:16-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151018 09:51:14-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151018 09:53:31-!- Kwandulin [~Miranda@p5B0092F4.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151018 10:12:30-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev
20151018 10:19:50< Aginor> wedge009: I'll look into your PR when I'm back at a more sensible computer
20151018 10:20:01< Aginor> or if I find myself with a lot of downtime
20151018 10:26:38-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20151018 10:27:50-!- travis-ci [~travis-ci@ec2-54-144-214-57.compute-1.amazonaws.com] has joined #wesnoth-dev
20151018 10:27:50< travis-ci> wesnoth/wesnoth#7660 (master - a599a33 : Charles Dang): The build was fixed.
20151018 10:27:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/86008296
20151018 10:27:51-!- travis-ci [~travis-ci@ec2-54-144-214-57.compute-1.amazonaws.com] has left #wesnoth-dev []
20151018 10:40:13-!- ideuler [~textual@a95-95-121-183.cpe.netcabo.pt] has joined #wesnoth-dev
20151018 10:46:40-!- Kwandulin [~Miranda@p5B009F94.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151018 10:53:07-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151018 11:16:21-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has joined #wesnoth-dev
20151018 11:34:32-!- julian [~quassel@x5d873058.dyn.telefonica.de] has joined #wesnoth-dev
20151018 11:34:51-!- julian is now known as Guest96358
20151018 11:44:34-!- ideuler [~textual@a95-95-121-183.cpe.netcabo.pt] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20151018 11:51:38< Jetrel_bot> zookeeper:  so yeah, later this calendar day I'll have a look at what you needed.  Can you give me a quick recap on what you want?
20151018 11:51:55-!- ideuler [~textual@a95-95-121-183.cpe.netcabo.pt] has joined #wesnoth-dev
20151018 11:52:16< zookeeper> Jetrel_bot, lots of potential names for the beast? :P
20151018 11:53:04< Jetrel_bot> Okay.  I've been mulling over angles for that; but no specifics
20151018 11:54:34< zookeeper> unit names in general, too, but those are less of an immediate concern, although i'd like there to be more-or-less final naming in place when i post the unit tree on the forums, for sake of first impressions
20151018 11:56:27< zookeeper> everything i have so far is in https://github.com/ln-zookeeper/wesnoth/tree/quenoth
20151018 11:59:22-!- oldlaptop [~quassel@50.36.238.180] has joined #wesnoth-dev
20151018 12:01:27< irker578> wesnoth: ln-zookeeper wesnoth:master 3a5f25b999cf / / (6 files in 4 dirs): New ink sounds http://git.io/vCNb8
20151018 12:02:15< irker578> wesnoth: Lari Nieminen resources:master 6fa24cd0ab24 / sounds-wav/ (ink-miss.wav ink.wav): Lossless copies of new ink sounds http://git.io/vCNb2
20151018 12:06:40-!- Kwandulin [~Miranda@p5B009F94.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151018 12:22:47-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20151018 12:25:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151018 12:28:54-!- ideuler [~textual@a95-95-121-183.cpe.netcabo.pt] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20151018 12:29:39-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has quit [Ping timeout: 240 seconds]
20151018 13:12:19-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Ping timeout: 268 seconds]
20151018 13:20:42-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has joined #wesnoth-dev
20151018 13:22:40-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151018 13:23:29-!- gfgtdf [~chatzilla@f054137159.adsl.alicedsl.de] has joined #wesnoth-dev
20151018 13:32:42 * vultraz tries adding sorting the Unit Create dialog
20151018 13:32:45< vultraz> dis hard 
20151018 13:38:15< vultraz> ok, got type sorting 
20151018 13:41:41-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind1]
20151018 13:51:11-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151018 13:57:39-!- Appleman1234 [~Appleman1@KD111239014084.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20151018 14:06:32< vultraz> whoot whoot!
20151018 14:11:06< gfgtdf> vultraz: ß
20151018 14:11:08< gfgtdf> ß
20151018 14:11:12< vultraz> ?
20151018 14:11:20< gfgtdf> vultraz: ?
20151018 14:11:37< vultraz> Why ß
20151018 14:11:47< gfgtdf> vultraz: s/ß/?
20151018 14:11:54< vultraz> what?
20151018 14:12:05< vultraz> you posted a funny-looking 'B'
20151018 14:12:21< gfgtdf> vultraz: y accidently i wantd to type '?' but i got caps lock
20151018 14:12:28< vultraz> ohh
20151018 14:12:39< vultraz> I got sorting working on the gui2 Unit Create dialog
20151018 14:13:22< gfgtdf> vultraz: it works teh sam way as in the gui2 loadgame dialog ?
20151018 14:13:34< vultraz> basically yeah I copied that code
20151018 14:13:50< gfgtdf> vultraz: hmm ok
20151018 14:13:57< vultraz> except in this case I use a vector of pairs
20151018 14:13:59< vultraz> for type and race
20151018 14:14:17< vultraz> so I just sort .first and .second
20151018 14:14:47< gfgtdf> vultraz: iirc the problme lef with the gui2 unit creation dialog is the preview pane ?
20151018 14:15:01< vultraz> There is no preview pane right now
20151018 14:15:08< gfgtdf> vultraz: yes
20151018 14:16:02< gfgtdf> vultraz: i think a unit preview wigetd woudl be quiet useful it coudl then also be used in the lua gui2 unit create and recall dialog
20151018 14:16:06< gfgtdf> widget
20151018 14:16:46< vultraz> hmm
20151018 14:16:50< vultraz> how would that be designed?
20151018 14:17:37< wedge009> shadowm: It's been a long time since I looked at this, but I think I made the mistake of assuming that non-alpha characters would have a key code attached to them (in get_key()). Not sure if it's worth fixing this since sdl2 branch works much more nicely. I'll still look into this but may as well revert, even if it means dropping the other improvements.
20151018 14:17:49< wedge009> Aginor: Switch off the computer and enjoy your holiday.
20151018 14:18:35< gfgtdf> vultraz: i think teh gui2 unit preview widger shoudl look similar to the current gui1 unit preview.
20151018 14:19:29< gfgtdf> vultraz: i actualyl don't know exactly how you create customn wodgets
20151018 14:19:45< gfgtdf> vultraz: maybe just copying the code it good enough too
20151018 14:19:56< vultraz> you design them in data/gui/default/widgets
20151018 14:20:01< vultraz> with wml
20151018 14:20:11< gfgtdf> vultraz: yes but i dont know teh syntax exactly
20151018 14:20:17-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20151018 14:20:24< vultraz> I generally do
20151018 14:20:31< vultraz> it's the C++ that would stump me
20151018 14:20:43< celticminstrel> ?
20151018 14:22:40< vultraz> celticminstrel: discussing a 'unit preview' gui2 widget
20151018 14:24:53-!- Kwandulin [~Miranda@p5B009F94.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151018 14:25:54< vultraz> celticminstrel: quick unrelated q...if you had a vector of pairs, how would you say 'first pair value of the furthest vector index'?
20151018 14:26:44< celticminstrel> Furthest vector index? As in, last index?
20151018 14:27:09< vultraz> yeah
20151018 14:27:21< celticminstrel> Normally I would use vector.back().first, but I think back() might be c++11.
20151018 14:27:38< celticminstrel> .back() would return the same as [.size() - 1] though.
20151018 14:28:35< celticminstrel> ie vector.back() -> vector[vector.size() - 1]
20151018 14:29:03< celticminstrel> ...where vector is the variable name. That's legal but confusing, so I don't recommend it.
20151018 14:29:24< vultraz> back works
20151018 14:29:33< celticminstrel> Yay.
20151018 14:36:26< vultraz> hm.. I wonder if it's possible to make the list start out sorted by race (ie, column 1)
20151018 14:38:00< gfgtdf> vultraz: i sure this is possible
20151018 14:38:24< gfgtdf> i'm*
20151018 14:41:28< vultraz> hm
20151018 14:41:47< vultraz> list.order_by kinda does it but the first option by type name still gets selected :|
20151018 14:44:08< vultraz> i'll deal with this later
20151018 14:48:58< irker578> wesnoth: Charles Dang wesnoth:master 2de99cad7407 / / (3 files in 2 dirs): tunit_create: add sort functionality http://git.io/vCA4r
20151018 14:50:30-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151018 14:52:17< vultraz> ok soo... unit info
20151018 14:54:05-!- Appleman1234 [~Appleman1@KD111239014114.au-net.ne.jp] has joined #wesnoth-dev
20151018 14:54:32< vultraz> lot of into needed here
20151018 14:54:51< vultraz> so I'm thinking we can just have three widgets (or subwidgets if we make this its own widget)
20151018 14:55:03< vultraz> one image, one profile button, and one...
20151018 14:55:07< vultraz> label 
20151018 14:59:08-!- ancestral [~ancestral@105.sub-70-197-226.myvzw.com] has joined #wesnoth-dev
20151018 15:09:45< vultraz> gonna try to get a basic prototype working 
20151018 15:16:46-!- ancestral [~ancestral@105.sub-70-197-226.myvzw.com] has quit [Quit: i go nstuf kthxbai]
20151018 15:17:26< vultraz> wonder if I should use a multiplage widget  to house them or just a regular grid
20151018 15:19:29-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151018 15:19:46< gfgtdf> vultraz: what would be the advantage of a multiplage widget?
20151018 15:20:28< gfgtdf> vultraz: so are your trying to adda an extra unit preview widget ?
20151018 15:24:07-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20151018 15:26:37-!- Appleman1234 [~Appleman1@KD111239014114.au-net.ne.jp] has quit [Ping timeout: 244 seconds]
20151018 15:28:13-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151018 15:28:16< vultraz> gfgtdf: multipages mean size is calculated for all possible pages and the best size is given
20151018 15:28:40< vultraz> im cosidering using it for the loadgame dialog too
20151018 15:28:41< vultraz> considering
20151018 15:28:42-!- Kwandulin [~Miranda@p5B009F94.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151018 15:28:42< gfgtdf> vultraz: i dont think you can use it in teh loadgame dialog
20151018 15:28:42< vultraz> gfgtdf: im not sure yet, since id have to look at the c++ involved
20151018 15:29:10< gfgtdf> vultraz: the problme is that you dont know the content of teh savefile unless you read it
20151018 15:29:10< gfgtdf> vultraz: which happens if you select it
20151018 15:29:39< gfgtdf> vultraz: for the unit debug dialog i think it woudl make sense though
20151018 15:29:41< shadowm> vultraz: https://en.wikipedia.org/wiki/%C3%9F
20151018 15:29:52< vultraz> gfgtdf: hmm ok
20151018 15:29:54< vultraz> good point
20151018 15:30:21< vultraz> gfgtdf: I'd wouldn't need to keep all the unit type info around then either
20151018 15:30:26< vultraz> since all pages are generated in preshow
20151018 15:30:36< vultraz> and i just save the type and race in a seperate vector
20151018 15:30:39< vultraz> separate 
20151018 15:31:54< shadowm> I believe that'll bump the offscreen surface count far too high.
20151018 15:32:21-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151018 15:32:25-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20151018 15:32:29< celticminstrel> Does each page have its own surface?
20151018 15:33:41< vultraz> ...easy surface counts as 'on screen'?
20151018 15:33:45< vultraz> page surface*
20151018 15:33:47< vultraz> wow
20151018 15:33:52< vultraz> s/easy/each
20151018 15:34:00< shadowm> As I recall the whole point of multipage is that all required grids (and their layouts) are known in advance, and to determine their layouts you need to draw a lot offscreen. What I don't remember (and this is the crucial part) is whether this would mean that their canvases are kept around or not.
20151018 15:34:06< celticminstrel> He said offscreen surfaces, vultraz/
20151018 15:34:07< celticminstrel> ^.
20151018 15:34:15-!- fendrin [~quassel@wesnoth/developer/fendrin] has quit [Quit: No Ping reply in 180 seconds.]
20151018 15:34:20< vultraz> oh
20151018 15:35:44-!- fabi [~quassel@176.0.138.246] has joined #wesnoth-dev
20151018 15:35:44-!- fabi [~quassel@176.0.138.246] has quit [Changing host]
20151018 15:35:44-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151018 15:38:00< shadowm> wedge009: It's either fix that or revert the patch on 1.12, I'm afraid.
20151018 15:47:16-!- Guest96358 [~quassel@x5d873058.dyn.telefonica.de] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
20151018 15:48:02-!- juman [~quassel@x5d873058.dyn.telefonica.de] has joined #wesnoth-dev
20151018 15:51:30-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has quit [Ping timeout: 260 seconds]
20151018 16:05:19< vultraz> well, if I don't use the multipage, I have to keep all the info about each unit type around for the entire duration of the dialog
20151018 16:05:26< vultraz> so, not sure how much of a tradeoff it is either way
20151018 16:06:14< gfgtdf> vultraz: which info do you mean? i'd think you just need unit_type& ?
20151018 16:06:25< gfgtdf> or unit_type*
20151018 16:06:37< vultraz> uh....hm...
20151018 16:06:51< gfgtdf> but 
20151018 16:07:03< irker578> wesnoth: ln-zookeeper wesnoth:master 4deeef797d58 / / (9 files in 4 dirs): New attack sounds for mudcrawlers http://git.io/vCAiO
20151018 16:07:19< shadowm> Yes, you don't actually need to keep it yourself, the game already has it.
20151018 16:07:20< gfgtdf> i think that it definites should not  have teh resize-on-select but that teh loadgame dialog has
20151018 16:07:54< vultraz> yeah, no
20151018 16:07:56< gfgtdf> actuall does your fix for loadgame works nor preoerly
20151018 16:08:01< gfgtdf> now*
20151018 16:08:01< vultraz> hm?
20151018 16:08:17< vultraz> not fully...
20151018 16:08:33< vultraz> even with wrap keys I can't get the details name to show up fully
20151018 16:08:45< vultraz> so... I dunno :|
20151018 16:09:44-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has quit [Ping timeout: 250 seconds]
20151018 16:10:44< vultraz> I think it's a weird thing with GUI2 that widgets placed more to the right or lower down will be the ones resized to take up space
20151018 16:10:57< gfgtdf> vultraz: i actually think the right-side panel of teh gui2 loadgame dialog shoudl rather have afixed width than depending on teh first entry
20151018 16:11:13< vultraz> yes
20151018 16:11:21< vultraz> but then there might not be enough space for subsequent entries
20151018 16:11:43< gfgtdf> ?
20151018 16:11:49< vultraz> which is why I suggested a multipage (but you said we can't use that) or wrap labels (which I can't get to work)
20151018 16:12:05< vultraz> oh
20151018 16:12:11< gfgtdf> vultraz: i think wrap labels is teh best option
20151018 16:12:12< vultraz> wait, nvm, I misread
20151018 16:12:22< vultraz> I'm not sure how to set a fixed width
20151018 16:12:31< vultraz> I tried using a spacer hack but that did not work
20151018 16:12:37< gfgtdf> vultraz: i also dont know i dont evn think its currently possible
20151018 16:12:44< vultraz> yeah...
20151018 16:12:45< vultraz> :(
20151018 16:12:50< irker578> wesnoth: Lari Nieminen resources:master 24658e782ea0 / sounds-wav/ (mud-fist-miss.wav mud-fist.wav mud-glob-miss.wav mud-glob.wav): Lossless copies of new mudcrawler attack sounds http://git.io/vCAPY
20151018 16:13:13-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 250 seconds]
20151018 16:13:57< vultraz> w or width aren't valid in [grid]
20151018 16:15:18-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151018 16:16:47< vultraz> hm
20151018 16:16:59< vultraz> characters_per_line DOES cause that label to wrap 
20151018 16:17:30< vultraz> well.....
20151018 16:17:32< vultraz> kinda
20151018 16:22:52-!- shadowm [~ignacio@wesnoth/developer/shadowm] has quit []
20151018 16:23:57-!- shadowm [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151018 16:24:21-!- Appleman1234 [~Appleman1@KD111239024142.au-net.ne.jp] has joined #wesnoth-dev
20151018 16:27:49< vultraz> ok this just seems to be a case of columns not being given enough room to grow
20151018 16:30:50-!- mode/#wesnoth-dev [+o shadowm] by ChanServ
20151018 16:30:59-!- mode/#wesnoth-dev [+b *!*@wesnoth/umc-dev/bot/shikadibot] by shadowm
20151018 16:31:19-!- shikadibot_ [~shikadi@wesnoth/umc-dev/bot/shikadibot] has left #wesnoth-dev []
20151018 16:32:36-!- fabi [~quassel@wesnoth/developer/fendrin] has left #wesnoth-dev [requested by shadowm (fabi)]
20151018 16:32:40-!- mode/#wesnoth-dev [-bb+b-o *!*@wesnoth/umc-dev/bot/shikadibot *!*@wesnoth/developer/fendrin *!*@wesnoth/developer/fendrin shadowm] by shadowm
20151018 16:32:49-!- shikadibot_ [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20151018 16:32:54-!- shikadibot_ is now known as shikadibot
20151018 16:39:35-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151018 16:49:50-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 240 seconds]
20151018 16:50:13-!- iwaim [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20151018 16:50:31-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has joined #wesnoth-dev
20151018 16:52:01< shadowm> wedge009: Oh, I didn't see the part where you suggested reverting. What about the other patch, though, was it safe, or does it too have potential for regressions like this?
20151018 16:52:36< shadowm> !commit c98f3e029d243a4bd47c33df74be02f03141215c
20151018 16:52:38< shikadibot> shadowm: Revision c98f3e029d24 (Wedge009) on Thu Aug 13 14:27:08 2015:
20151018 16:52:41< shikadibot> shadowm: Correct handling of Ctrl+Return/Enter hot-key.
20151018 16:52:44< shikadibot> shadowm:  
20151018 16:52:46< shikadibot> shadowm: Added special handling for j and m characters, where their respective key codes do not match the j and m buttons on the keyboard.
20151018 16:52:49< shikadibot> shadowm: (+3 discarded lines)
20151018 16:52:52< shikadibot> shadowm: Web interface URL: https://github.com/wesnoth/wesnoth/commit/c98f3e029d24
20151018 16:53:12< shadowm> I've been using it ever since and haven't really come across any issues myself.
20151018 16:59:30-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has quit [Ping timeout: 240 seconds]
20151018 17:04:47-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has joined #wesnoth-dev
20151018 17:05:55-!- joet [~joet@82-71-48-162.dsl.in-addr.zen.co.uk] has quit [Remote host closed the connection]
20151018 17:19:19-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20151018 17:19:25-!- janebot_ [~Gambot@grickit.us] has joined #wesnoth-dev
20151018 17:23:20< vultraz> gfgtdf: can you use unit_types.types() with an index?
20151018 17:23:59< gfgtdf> vultraz: idk which function exactly oyu mean
20151018 17:24:49< vultraz> im trying to figure out how to get unit type info for a specific row
20151018 17:25:00< vultraz> if I'm going to add a unit panel to create unit I need all theinfo
20151018 17:25:10< vultraz> you said I can ise unit_type
20151018 17:25:14< vultraz> use
20151018 17:25:53< gfgtdf> vultraz: hmm no you cant do that with an index
20151018 17:25:59-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20151018 17:26:09< gfgtdf> vultraz: i thing you need a provae std::vector<unit_type*>
20151018 17:26:14< gfgtdf> private*
20151018 17:33:48< vultraz> pointer not reference?
20151018 17:35:46< shadowm> You can't store references in a vector, that's why it's a pointer.
20151018 17:36:18< vultraz> ok
20151018 17:36:38< shadowm> (As for why, remember that the address a reference points to cannot be re-assigned.)
20151018 17:37:38< celticminstrel> The way I think of it is that X& is like X*const.
20151018 17:37:50< celticminstrel> But that might be confusing for new people.
20151018 17:38:09< celticminstrel> I mean, for people less familiar with the language.
20151018 17:38:34< shadowm> Yes, I don't think we are really supposed to insist on the fact that references are actually pointers by another name.
20151018 17:39:10-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20151018 17:40:48< vultraz> pointers... so I need the arrow not the point 
20151018 17:40:58< celticminstrel> Yes.
20151018 17:41:54< shadowm> . accesses members, -> dereferences and accesses members.
20151018 17:42:52< shadowm> The whole point is that pointers (and not references) ever need to be dereferenced by the coder to access the data they contain.
20151018 17:43:39< shadowm> *only pointers
20151018 17:44:06-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has joined #wesnoth-dev
20151018 17:46:26< vultraz> nice, I made wesnoth crash :(
20151018 17:49:32-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 272 seconds]
20151018 17:51:51< vultraz> 	last_chosen_type_id = choice_ = units[static_cast<size_t>(selected_row)]->type_name();
20151018 17:52:05< vultraz> doesn't like this :/
20151018 17:52:28< shadowm> Did you make sure selected_row is within bounds?
20151018 17:53:05< shadowm> That is, not < 0 (if it's signed, otherwise the cast will yield an absurdly big value), and also < units.size().
20151018 17:54:20< vultraz> can I use units.at for that?
20151018 17:54:48< shadowm> It's a possibility, but then you have to catch std::out_of_range.
20151018 17:55:24< shadowm> Most of the time you can just use assertions unless you actually expect out of range values to happen in production.
20151018 17:56:30< shadowm> (The rule of thumb is that assertions are meant to catch programming errors, exceptions and exception-throwing code paths are for catching intended exceptional behavior and situations.)
20151018 17:56:50< vultraz> Caught general exception: vector::_M_range_check: __n (which is 8) >= this->size() (which is 0) HHMmmmmmm
20151018 17:57:02< shadowm> Yes because you did not catch the exception, ugh.
20151018 17:57:58< celticminstrel> You're using v.at() instead of v[]?
20151018 17:58:06< celticminstrel> Or are you using MSVC?
20151018 17:58:22< vultraz> still on codeblocks and I'm testing this out with v.at()
20151018 17:58:35< vultraz> want to get this vector working before I start on the panel 
20151018 17:58:36< shadowm> vultraz, did you read what I just said? -.-
20151018 17:58:57< vultraz> yes
20151018 17:59:23< shadowm> Then why do you insist on std::vector::at()?
20151018 17:59:27< celticminstrel> If you do use assertions you can do something like assert(condition || "Explanation") when the condition isn't self-explanatory.
20151018 17:59:36< celticminstrel> Though I guess here it is.
20151018 17:59:55< celticminstrel> I would say assertions are good, but it sounds like the index really was out of range.
20151018 18:00:06< celticminstrel> Why is it out of range?
20151018 18:00:44< shadowm> 14:56:51 <vultraz> Caught general exception: vector::_M_range_check: __n (which is 8) >= this->size() (which is 0) HHMmmmmmm
20151018 18:00:53< shadowm> Because 8 >= 0, apparently.
20151018 18:00:59< celticminstrel> So the vector is empty.
20151018 18:01:24< celticminstrel> Then, why is the vector empty?
20151018 18:09:50-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20151018 18:10:09< vultraz> uh... I assume I need to populate it somehow. Somehow I thought since it's a reference it would just reference back to the unit type list
20151018 18:11:19-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has quit [Ping timeout: 252 seconds]
20151018 18:11:52< celticminstrel> Uh. What?
20151018 18:12:04< celticminstrel> What's it a reference to?
20151018 18:15:10< vultraz> unit_type*
20151018 18:15:14< vultraz> which I see now is a class :|
20151018 18:15:16< vultraz> ugh
20151018 18:15:49< celticminstrel> Uh.
20151018 18:15:54< celticminstrel> That's impossible.
20151018 18:16:01< vultraz> um...
20151018 18:16:02< celticminstrel> For a vector to reference a unit_type.
20151018 18:16:36< vultraz> I just have std::vector<unit_type*> units; 
20151018 18:16:43< celticminstrel> I really don't know what you're doing, but it sounds like you're misunderstanding something basic.
20151018 18:16:52< vultraz> probably
20151018 18:17:06< celticminstrel> Okay, so then units is not a reference.
20151018 18:17:15-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 250 seconds]
20151018 18:17:15< celticminstrel> If it was a reference there would be an & in the type.
20151018 18:17:23< vultraz> oh, sorry
20151018 18:17:27< celticminstrel> An & outside of the <>
20151018 18:17:31< vultraz> I was using reference to mean point 
20151018 18:17:38< celticminstrel> Ah.
20151018 18:17:49< celticminstrel> But it's the contents of the vector that are pointers.
20151018 18:18:01< celticminstrel> The vector itself still needs to be filled with pointers to the correct unit types.
20151018 18:18:26< celticminstrel> By the way, why is it a vector of unit types?
20151018 18:19:07-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151018 18:19:09< celticminstrel> You were making a unit preview widget, right?
20151018 18:19:58< vultraz> no, i'm going to try to get it working just as a standard dialog component before trying to widget-izing it
20151018 18:20:08< vultraz> so I'm working with the Unit Create dialog
20151018 18:20:16< vultraz> if you look at the code now (src/gui/dialogs/unit_create.cpp), it basically builds all the units one by one and pushes race and type to a local vector of pairs
20151018 18:20:24< celticminstrel> I see. You mean the debug mode dialog?
20151018 18:20:31< vultraz> yes
20151018 18:20:41< celticminstrel> What do you mean by "builds the units"?
20151018 18:20:57< celticminstrel> ...I suppose I should look instead of asking.
20151018 18:21:15-!- Guest58751 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20151018 18:21:30< vultraz> anyway, if we want a unit preview section, even if it's a widget, it makes more sense just to have a pointer vector to all of the unit types
20151018 18:21:40< vultraz> so we can dispose of any local vectors
20151018 18:22:02< celticminstrel> If it's a widget, that won't work.
20151018 18:22:25< vultraz> what, you can't pass values to it?
20151018 18:22:33< celticminstrel> If you're doing it as a widget, you'll most likely need a vector<unit>, otherwise you won't be able to use it for the attack dialog or the recall dialog.
20151018 18:22:45< celticminstrel> You could maybe template it.
20151018 18:22:58< celticminstrel> Depending on how compatible the unit and unit_type classes are.
20151018 18:23:15< vultraz> one would think they would be 
20151018 18:23:17< vultraz> :|
20151018 18:23:28< celticminstrel> I would think so too, but I don't really know.
20151018 18:23:28< vultraz> shouldn't one just be an instance of the other?
20151018 18:23:40< celticminstrel> I don't believe unit extends unit_type.
20151018 18:23:51< celticminstrel> It merely references a unit_type.
20151018 18:23:52-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151018 18:23:58< vultraz> I see
20151018 18:24:13< vultraz> but still, the type vector is for this dialog specifically
20151018 18:24:22< celticminstrel> Fair enough.
20151018 18:24:25< vultraz> if I have to pass a unit of that type to the widget... 
20151018 18:24:29< vultraz> ugh, this would get complicated
20151018 18:24:34< vultraz> which is why I'm taking this in steps :P
20151018 18:25:03-!- Guest58751 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20151018 18:25:18< celticminstrel> Ah, so basically by "builds the units" you just mean it's making sure the unit type has been initialized properly.
20151018 18:25:58< vultraz> yes
20151018 18:26:29< vultraz> I don't exactly understand the handling of the type in that loop
20151018 18:26:38< vultraz> like, why is i.first the type id
20151018 18:27:00< vultraz> an id/metadata pair?
20151018 18:27:02< vultraz> or something?
20151018 18:27:35< celticminstrel> Presumably, unit_types.types() returns a vector of pairs (or some similar iterable of pairs).
20151018 18:27:48< celticminstrel> (Such as a map.)
20151018 18:27:59< celticminstrel> (Actually, a map is actually the most likely.)
20151018 18:28:16< celticminstrel> So that means that i.first is the key, and i.second is the value (the unit_type).
20151018 18:28:25-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151018 18:28:49-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has joined #wesnoth-dev
20151018 18:30:27< vultraz> I see
20151018 18:31:04< vultraz> ok so, what I'm trying to do here is instead have a class member vector that's just a pointer to the game's list of unit types
20151018 18:31:32< vultraz> (and yes, I know I'm undoing a bunch of my work from 5 hours ago but whatever :P )
20151018 18:31:37< celticminstrel> Right, so you're replaced type_info_ with units_.
20151018 18:31:48< celticminstrel> And what you need to push back is simply &i.second.
20151018 18:32:05< celticminstrel> ^you've
20151018 18:32:23< celticminstrel> Of course, that means the comment there is no longer relevant.
20151018 18:32:24< vultraz> should I do that in the constructor?
20151018 18:33:04< celticminstrel> Well, the current code does it in the pre_show, so there isn't really any point in moving it to the constructor, is there?
20151018 18:34:03< vultraz> I guess functionality wise, no, since that's always called first
20151018 18:34:11< vultraz> I just thought it might be good practice 
20151018 18:34:26< vultraz> to populate class member vars int he constructor
20151018 18:34:34< shadowm> The theory is that you can construct a GUI2 dialog once and display it as many times as you wish in completely different contexts.
20151018 18:35:03< celticminstrel> The reason I'm saying don't move it is to minimize the diff, actually.
20151018 18:35:17< shadowm> Given that, populating the unit type list in the constructor can either be good (you don't need to do it multiple times) or bad (the list might become outdated).
20151018 18:35:22-!- juman [~quassel@x5d873058.dyn.telefonica.de] has quit [Remote host closed the connection]
20151018 18:35:27< celticminstrel> But I guess there's also what shadowm is saying.
20151018 18:35:30< shadowm> In practice, this is irrelevant because GUI2 dialogs are never used more than once after construction.
20151018 18:36:00< shadowm> (Except possibly in unit tests, I guess.)
20151018 18:40:06< vultraz> celticminstrel: ok, so, I don't need a & outside the <> when declaring units_, do I?
20151018 18:40:25< vultraz> I seem to recall reading something about needed both symbols to ensure it doesn't copy/create a new instance
20151018 18:40:31< celticminstrel> Not unless there's some other vector somewhere that you want to reference (which I'd assume not).
20151018 18:41:09< vultraz> ok
20151018 18:41:21< vultraz> but I still need the arrowas
20151018 18:41:26< vultraz> aerow
20151018 18:41:28< vultraz> arrow
20151018 18:41:28< celticminstrel> What you recall reading applies only to function parameters. (If used on a class variable it means that variable must be initialized in the constructor.)
20151018 18:41:29< vultraz> >_>
20151018 18:42:02-!- framling [~user@104.200.154.63] has joined #wesnoth-dev
20151018 18:42:08< celticminstrel> You need arrows for accessing the elements of the vector, yes. (ie, you don't need to do things lie v->at() :P )
20151018 18:42:08< vultraz> oh, I see
20151018 18:42:19< vultraz> obv
20151018 18:43:45< vultraz> C:\TDM-GCC-32-5.1.0\lib\gcc\mingw32\5.1.0\include\c++\bits\stl_vector.h|913|note:   no known conversion for argument 1 from 'const unit_type' to 'unit_type* const&'|
20151018 18:43:47< vultraz> uhhh
20151018 18:43:55< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\dialogs\unit_create.cpp|127|error: no matching function for call to 'std::vector<unit_type*>::push_back(const unit_type&)'|
20151018 18:43:57< vultraz> wat?
20151018 18:45:08< celticminstrel> What are you pushing back? Did you forget the address-of operator?
20151018 18:45:34< celticminstrel> Do you have a const in your declaration of units_?
20151018 18:45:48< vultraz> oh you said &i.second
20151018 18:45:52< vultraz> not .second
20151018 18:45:59< vultraz> i.second i mean
20151018 18:46:21< vultraz> this is really territory that I have a hard time with, sorry
20151018 18:46:44< vultraz> celticminstrel: also, no const
20151018 18:47:00< celticminstrel> If it still doesn't work, you might need one.
20151018 18:47:41< vultraz> as in, const std::vector?
20151018 18:47:58< vultraz> or const unit_type*? or units_ const;
20151018 18:48:33< celticminstrel> #2
20151018 18:49:14< celticminstrel> There's actually another possibility you missed, but it's not what you want and rarely would be.
20151018 18:49:24< celticminstrel> #2 is what I meant.
20151018 18:49:37< vultraz> yay that builds
20151018 18:49:37< celticminstrel> (Wouldn't hurt it do it even if it's not necessary, in fact.)
20151018 18:49:45< vultraz> it was necessary
20151018 18:50:06< vultraz> andddd it works :D
20151018 18:50:11< vultraz> unit type vector is go
20151018 18:50:33< vultraz> now I'm going to snag a little more sleep since I have classes tomorrow
20151018 18:50:38< vultraz> and no, not C++ classes 
20151018 18:50:43< celticminstrel> Ooh classes.
20151018 18:51:04< vultraz> neither the class class but school class class not on classes though
20151018 18:51:51-!- ancestral [~ancestral@207.250.184.217] has joined #wesnoth-dev
20151018 18:52:22-!- ancestral [~ancestral@207.250.184.217] has quit [Client Quit]
20151018 18:53:02< celticminstrel> Uh.
20151018 18:53:35< vultraz> i mean I have school classes not anything to deal with c++ classes and the school classes are not on c++ classes 
20151018 18:54:05< celticminstrel> XD
20151018 19:00:52-!- ancestral [~ancestral@207.250.184.217] has joined #wesnoth-dev
20151018 19:04:07-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151018 19:07:22-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20151018 19:07:23-!- wedge010 is now known as wedge009
20151018 19:07:26-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151018 19:12:06-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 255 seconds]
20151018 19:13:29-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151018 19:29:46-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has quit [Ping timeout: 260 seconds]
20151018 19:31:46-!- ancestral [~ancestral@207.250.184.217] has quit [Quit: i go nstuf kthxbai]
20151018 19:32:05-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has joined #wesnoth-dev
20151018 19:56:21-!- fabi [~quassel@176.2.104.108] has joined #wesnoth-dev
20151018 19:56:21-!- fabi [~quassel@176.2.104.108] has quit [Changing host]
20151018 19:56:21-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151018 20:00:17-!- ideuler [~textual@a89-153-66-133.cpe.netcabo.pt] has joined #wesnoth-dev
20151018 20:03:18-!- ideuler [~textual@a89-153-66-133.cpe.netcabo.pt] has quit [Client Quit]
20151018 20:24:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20151018 20:29:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151018 20:36:45-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 240 seconds]
20151018 20:45:58-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20151018 20:47:24< mattsc> celticminstrel: hi
20151018 20:47:56< mattsc> Remind me please of the things we need to talk about.
20151018 20:52:52< wedge009> shadowm: The original should be fine, it was tested by others across the three main desktop OSs. Yourself included, I think. This change was supposed to fix a number of contrived combinations mentioned during testing as well as address some concerns people had of the special-case nature of the original patch.
20151018 20:53:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20151018 20:55:25< shadowm> wedge009: I did test it, just like the latest patch, but it never occurred to me that the preferences dialog and the actual game UI could display different behavior like this.
20151018 20:56:09< shadowm> Meaning that while I did test the latest patch with the preferences dialog, it took me until today to discover (by chance) that it broke the game UI.
20151018 21:07:02-!- iceiceice [~chris@23.31.228.41] has joined #wesnoth-dev
20151018 21:07:02-!- iceiceice [~chris@23.31.228.41] has quit [Changing host]
20151018 21:07:02-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151018 21:10:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151018 21:13:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20151018 21:14:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151018 21:14:14-!- ideuler [~textual@a89-153-66-133.cpe.netcabo.pt] has joined #wesnoth-dev
20151018 21:14:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20151018 21:20:47-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind1]
20151018 21:21:15-!- mjs-de [~mjs-de@x4db523d9.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20151018 21:23:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151018 21:32:35< celticminstrel> mattsc: The unit tests.
20151018 21:33:16< celticminstrel> See PR502.
20151018 21:39:31< mattsc> celticminstrel: okay — I forgot what needs to be done.  I got some fails that you didn’t get or something.
20151018 21:39:42< celticminstrel> Hm?
20151018 21:39:48< celticminstrel> So you tried PR502?
20151018 21:40:15< celticminstrel> One thing that needs to be done is including Boost's unit test framework in the downloadable library pack.
20151018 21:40:20< mattsc> I don’t think so, but you had me try some things just before I left 4 weeks or so ago.
20151018 21:40:33< celticminstrel> Ah, that's what you're talking about.
20151018 21:40:39< mattsc> It’s been so long though, I forgot the details.
20151018 21:40:42< celticminstrel> This is (mostly) different.
20151018 21:40:50< mattsc> Ah, ok.
20151018 21:41:29< mattsc> I’ll check that out then (not right now though)
20151018 21:41:52< celticminstrel> What you tried was in fact PR502, but it didn't have the unit tests bit at that time.
20151018 21:42:04< vultraz> you've been gone 4 weeks?
20151018 21:42:06< vultraz> o_O
20151018 21:42:24< mattsc> just over 3 weeks, yes
20151018 21:42:36< celticminstrel> Basically, all that should be needed to get unit tests working is to add the Boost unit testing framework and (I think) also include the test/main.cpp file in the unit tests build.
20151018 21:43:32< mattsc> okay
20151018 21:44:16< mattsc> celticminstrel: have you had a chance to try out the 10.6/10.7 installation script?
20151018 21:44:21< celticminstrel> Unless there's failures in the tests themselves.
20151018 21:44:30< celticminstrel> No, actually I forgot about it, sorry. >_>
20151018 21:45:03< mattsc> No worries; it’s not like I wwould have been around to do something about it anyway  ;)
20151018 21:46:08< mattsc> And no rush; it doesn’t look like anyone is trying to use it; given that the qiki lies about it being included in the downloadable library pack
20151018 21:46:21< mattsc> … and the fact that nobody has complained about that yet
20151018 21:50:57-!- subliun [~quassel@unaffiliated/subliun] has quit [Ping timeout: 252 seconds]
20151018 21:52:34-!- joet [~joet@host86-163-223-158.range86-163.btcentralplus.com] has joined #wesnoth-dev
20151018 21:52:35-!- subliun [~quassel@unaffiliated/subliun] has joined #wesnoth-dev
20151018 21:53:16< vultraz> bleh, game_display is not the same a display
20151018 21:58:37< shadowm> vultraz: It is a display, though.
20151018 22:01:06-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 260 seconds]
20151018 22:01:32< shadowm> By which I mean that it is a subclass of display.
20151018 22:02:04< shadowm> vultraz: Not sure if that fact would help you, because I don't really know what you are trying to do with it.
20151018 22:07:09-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20151018 22:18:48-!- Coffee_irc [~david@ppp121-45-95-142.lns20.adl6.internode.on.net] has quit [Remote host closed the connection]
20151018 22:32:56-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151018 22:35:30-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 260 seconds]
20151018 22:37:27-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20151018 22:38:35-!- joet [~joet@host86-163-223-158.range86-163.btcentralplus.com] has quit [Ping timeout: 264 seconds]
20151018 22:47:26-!- irker578 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151018 22:49:13-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 256 seconds]
20151018 22:49:29-!- Luguna008 [4b4ccc4c@gateway/web/freenode/ip.75.76.204.76] has joined #wesnoth-dev
20151018 22:56:02-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20151018 23:08:24-!- joet [~joet@host86-163-223-158.range86-163.btcentralplus.com] has joined #wesnoth-dev
20151018 23:09:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds]
20151018 23:19:19-!- Luguna008 [4b4ccc4c@gateway/web/freenode/ip.75.76.204.76] has quit [Quit: Page closed]
20151018 23:19:26-!- Appleman1234 [~Appleman1@KD111239024142.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20151018 23:31:27-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20151018 23:40:43-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 268 seconds]
--- Log closed Mon Oct 19 00:00:13 2015