--- Log opened Mon Oct 19 00:00:13 2015
20151019 00:01:45-!- framling [~user@104.200.154.63] has quit [Ping timeout: 256 seconds]
20151019 00:02:21-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151019 00:12:26-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Read error: Connection reset by peer]
20151019 00:13:04-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20151019 00:13:04-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20151019 00:13:04-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151019 00:15:03< shadowm> aquileia: I got sidetracked looking at bugs and forgot to include in my email a query about the status of the Windows updater for 1.12.5. So, status?
20151019 00:17:17-!- Appleman1234 [~Appleman1@KD106161084017.au-net.ne.jp] has joined #wesnoth-dev
20151019 00:18:52-!- irker918 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151019 00:18:52< irker918> wesnoth: Ignacio R. Morelle wesnoth:1.12 4534767b372c / src/hotkey/hotkey_item.cpp: Revert "More corrections for hot-key detection in SDL1.2" http://git.io/vCxxy
20151019 00:20:15< shadowm> gfgtdf: Opnions re #22774 / #23922? (Also see my email.)
20151019 00:27:23< gfgtdf> shadowm: i think it makes sense to change [insert_tag] to the proposed behviour (in 1.13 of course). But im currently not very motivated to do it, specially since i don't use [insert_tag] in my addons.
20151019 00:27:39< gfgtdf> shadowm: i think the email is unrelated?
20151019 00:29:26< gfgtdf> shadowm: about 23310: i think that i fixed that in 1.13 during my refactor of replay_controller
20151019 00:29:54< shadowm> gfgtdf: Yes, it's unrelated since we can't change possibly this in 1.12, that was just a reminder.
20151019 00:30:14< shadowm> I words in reverse order are today it seems.
20151019 00:30:25< shadowm> *possibly change this
20151019 00:31:58< shadowm> gfgtdf: I guess I will reopen #22774 then and leave it unsolved again in case someone else wants to pick it up.
20151019 00:34:53< gfgtdf> shadowm: y if people post in that report anyway that makes sense
20151019 00:35:29-!- legoktm is now known as legoktm[NE]
20151019 00:36:46< shadowm> Um, is it even possible to legitimately construct an empty but existent WML array variable?
20151019 00:37:21< shadowm> Tried `lua wesnoth.set_variable("foo.bar", "baz")`, then `lua wesnoth.set_variable("foo.bar", nil)`, foo[0] was deleted entirely.
20151019 00:37:38< shadowm> Insofar as it doesn't come up in :inspect anyway.
20151019 00:39:29< gfgtdf> shadowm: i think its also possible taht :inspectjust skips entmy tables
20151019 00:39:43< gfgtdf> shadowm: iirc i have also seems wml tables with entried beginnign with 3 
20151019 00:39:47< gfgtdf> seen*
20151019 00:39:53< gfgtdf> entries*
20151019 00:40:00< gfgtdf> in :inspect i mean
20151019 00:40:23< gfgtdf> shadowm: so my guess was teh teh first 3 entried were skipped becasue they were empty
20151019 00:40:32< gfgtdf> entries*
20151019 00:43:10< shadowm> Yes, you are right, I found [foo][/foo] in the save game.
20151019 00:53:54-!- framling [~user@104.200.154.63] has joined #wesnoth-dev
20151019 00:55:29-!- ideuler [~textual@a89-153-66-133.cpe.netcabo.pt] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20151019 00:57:15-!- ideuler [~textual@a89-153-66-133.cpe.netcabo.pt] has joined #wesnoth-dev
20151019 01:07:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20151019 01:08:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151019 01:08:47-!- gfgtdf_ [~chatzilla@f050179070.adsl.alicedsl.de] has joined #wesnoth-dev
20151019 01:10:26-!- gfgtdf [~chatzilla@f054137159.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20151019 01:10:27-!- gfgtdf_ is now known as gfgtdf
20151019 01:11:27< irker918> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 8f770ba95b89 / src/replay_controller.cpp: attempt to fix saves from replay http://git.io/vCpJG
20151019 01:12:09-!- ancestral [~ancestral@105.sub-70-197-226.myvzw.com] has joined #wesnoth-dev
20151019 01:12:12< gfgtdf> shadowm: made a pr about teh bug in teh report: https://github.com/wesnoth/wesnoth/pull/532
20151019 01:12:33-!- aeth_ is now known as aeth
20151019 01:22:17< shadowm> k.
20151019 01:27:19-!- Appleman1234 [~Appleman1@KD106161084017.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20151019 01:28:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151019 01:30:00-!- travis-ci [~travis-ci@ec2-174-129-85-124.compute-1.amazonaws.com] has joined #wesnoth-dev
20151019 01:30:01< travis-ci> wesnoth/wesnoth#7665 (gfgtdf-patch-1 - 8f770ba : gfgtdf): The build passed.
20151019 01:30:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/86106354
20151019 01:30:01-!- travis-ci [~travis-ci@ec2-174-129-85-124.compute-1.amazonaws.com] has left #wesnoth-dev []
20151019 01:30:24-!- gfgtdf [~chatzilla@f050179070.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0.2/20151014143721]]
20151019 01:30:57< shadowm> Hm, I can't find an obvious reason for the inspector not displaying empty array entries.
20151019 01:31:05-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20151019 01:31:13-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20151019 01:31:13-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20151019 01:31:13-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151019 01:31:20-!- ideuler [~textual@a89-153-66-133.cpe.netcabo.pt] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20151019 01:31:34< celticminstrel> Less clutter maybe? I dunno.
20151019 01:31:43< shadowm> I meant code reason.
20151019 01:31:52-!- joet [~joet@host86-163-223-158.range86-163.btcentralplus.com] has quit [Remote host closed the connection]
20151019 01:31:58< shadowm> Actually, I think I just found it.
20151019 01:32:07< celticminstrel> Oh, you mean you couldn't see anything that indicates they would be skipped.
20151019 01:32:10< shadowm> unsigned int num_pages = model_.get_num_page(config_to_string(c.cfg)); for (unsigned int i = 0; i < num_pages; i++) {
20151019 01:32:16< shadowm> 0 < 0 -> false
20151019 01:33:00< celticminstrel> I'm not even sure what that's doing.
20151019 01:33:28< shadowm> I can understand myself. :p
20151019 01:34:43-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20151019 01:36:57-!- ancestral [~ancestral@105.sub-70-197-226.myvzw.com] has quit [Quit: i go nstuf kthxbai]
20151019 01:37:24< aquileia> Jetrel, Jetrel_bot, zookeeper: Even though http://r.wesnoth.org/p586360 never received the finishing touch by Amorphous, it's far superior to our current swordsman... would you mind if I commit it?
20151019 01:38:27< shadowm> Maybe someone should split Mechanical's tangent away. :p
20151019 01:41:01< shadowm> Because I don't feel like walking that extra mile right now, I'm going to commit a barely-tested change and hope people test it.
20151019 01:41:47< aquileia> As to the Windows patches / updates, my main problem is the Scons script - I basically wrote a snippet in Python but don't really know how to wire it in (it doesn't help that I can't test it as our Scons script doesn't support VC)
20151019 01:42:15< shadowm> Asked loonycyborg about it?
20151019 01:42:31< aquileia> Not yet
20151019 01:42:39< shadowm> (I'm afraid I can't be of much help since I don't grok scons and my Python skills are nearly nonexistent.)
20151019 01:43:01< irker918> wesnoth: Ignacio R. Morelle wesnoth:master 019d829b4145 / changelog src/gui/dialogs/gamestate_inspector.cpp: gui2/tgamestate_inspector: Don't skip pages with empty contents http://git.io/vCpIk
20151019 01:43:03< shadowm> gfgtdf: ^
20151019 01:43:10< celticminstrel> Why doesn't the scons support VC?
20151019 01:45:18< aquileia> For one, it can't find the prerequisites
20151019 01:45:35< shadowm> vultraz: How badly in need of shipping the GUI2 Load Game dialog are we?
20151019 01:45:46< shadowm> Oh look, it doesn't do unit TC yet.
20151019 01:46:48< shadowm> Really just asking to decide whether to figure out an ugly hack for the column header margins in advance or not.
20151019 01:48:11< celticminstrel> aquileia: As in, the libraries it depends on? Where are they installed?
20151019 01:50:17-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151019 01:50:31< aquileia> Disclaimer: I never used scons, so it might be an issue on my side
20151019 01:50:51< celticminstrel> I see.
20151019 01:51:02< aquileia> celticminstrel: They're in ../external/lib
20151019 01:51:19< shadowm> ancestral: Hi, did you see my email? Does my proposal align with your schedule or would you prefer a different date?
20151019 01:51:42< celticminstrel> That's relative to what, the VC project directory?
20151019 01:52:05< ancestral> That’s fine
20151019 01:52:15< aquileia> no, to the 'wesnoth' directory from which I invoke scons
20151019 01:52:24< celticminstrel> So relative to the source root then.
20151019 01:52:37< celticminstrel> Is that where the VC project finds them?
20151019 01:53:06< aquileia> yes
20151019 01:53:21< celticminstrel> That's kinda weird, but okay.
20151019 01:53:51< shadowm> ancestral: So I'm guessing weekends in general work best for you?
20151019 01:53:56< celticminstrel> I think the scons script could be fairly easily tweaked set up to search there for them.
20151019 01:53:59< aquileia> The reason is that the Windows dependencies are manages as a separate git repo
20151019 01:55:19< celticminstrel> if 'msvc' in env['TOOLS']: env.Append(LIBPATH="../external/lib")
20151019 01:56:16< celticminstrel> Or it might need to have a # in front of the path, not sure.
20151019 01:57:07< ancestral> shadowm: My schedule is unpredictable… though I will have 10/31 off
20151019 01:57:58< ancestral> I will simply do my best to align with the needs of others
20151019 01:58:22< shadowm> 10/30 is the string-freeze for translators, tag on 11/6.
20151019 01:59:13< ancestral> The only set day off I have is Tuesdays; everything else is random
20151019 01:59:22< shadowm> Technically, I could push both back by one week if no-one has any immediate objections.
20151019 01:59:42< ancestral> Anyway, I don’t have any vacations or any such thing going on
20151019 02:00:30< shadowm> Tuesdays, interesting.
20151019 02:00:51< ancestral> I spend it mostly with my girlfriend, who also has Tuesdays
20151019 02:01:50< shadowm> Anyway the thing is, I kind of don't want to spend the last weekend of October doing the release. :p
20151019 02:02:04< shadowm> Probably won't be around much either.
20151019 02:02:20< ancestral> shadowm: I have no objections, no requests, I am flexible
20151019 02:02:24< shadowm> That weekend I mean. I'm mostly back.
20151019 02:02:32< ancestral> Sure
20151019 02:03:12< shadowm> Okay, I'll stick to the dates from my email unless anyone needs more time then. :)
20151019 02:07:03-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Ping timeout: 246 seconds]
20151019 02:18:02< vultraz> shadowm: it's not 100% necessary, but I don't really see why not to. The column headers aren't a blocker
20151019 02:18:29< shadowm> Not for you. :p
20151019 02:18:52< vultraz> Can you do the unit TC?
20151019 02:19:11< shadowm> They are for me because they look very off after I added the hover effect, because it makes it evident that the margin is exterior instead of interior.
20151019 02:19:53< shadowm> vultraz: Potentially, but is there a particular reason you want me to do it instead of you?
20151019 02:20:18< vultraz> I'm hard at work at the unit create dialog
20151019 02:20:24< vultraz> and I could use it there too
20151019 02:20:34< vultraz> so I'm trying to outsource it
20151019 02:20:58< shadowm> Whatever I do in the Load Game dialog will most likely be of no use to you.
20151019 02:21:55< shadowm> For Unit Create and a prospective replacement for the Attack Unit dialog we should be looking at writing a generic unit preview pane widget like the one we use in GUI1. Load Game does not need such a thing because it only displays the unit sprite.
20151019 02:22:30< vultraz> Right
20151019 02:22:33< shadowm> And, for Load Game it should really be a simple matter of determining the current side using the same logic as the GUI1 version of the dialog, and... doing... stuff.
20151019 02:23:01< vultraz> I'll need help for the preview pane widget
20151019 02:23:03< shadowm> I think the GUI1 version used a simple heuristic that goes wrong for any scenario with multiple player-controlled sides.
20151019 02:23:08< celticminstrel> You're not forgetting about recruit/recall, are you?
20151019 02:23:28< shadowm> celticminstrel: Hm, no, I just meant those two as examples.
20151019 02:23:34< celticminstrel> Ah okay.
20151019 02:23:45< shadowm> And also because Attack Unit suffers the most UX issues atm.
20151019 02:24:02< celticminstrel> Hm, maybe. It does need to show two units at a time, too.
20151019 02:24:06< shadowm> Text overflowing all over the place, etc.
20151019 02:24:53-!- Appleman1234 [~Appleman1@KD111239001076.au-net.ne.jp] has joined #wesnoth-dev
20151019 02:25:04-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20151019 02:25:13< aquileia> sorry, was disconnected for a while
20151019 02:26:30< aquileia> Setting our scons script  up to use might be a bit more complicated... we currently have if env["PLATFORM"] == "win32": env.Tool("mingw") so I guess MSVC was deliberately left out
20151019 02:29:03< wedge009> shadowm: I made PR #533 to fix the mistakes in #470. I'm much more confident with the state of this one. Problem before, I think, was that I focused on the set_hotkey() end and so the mistakes are in the get_hotkey() side.
20151019 02:31:57 * vultraz cannot figure out how to pass the display to this function
20151019 02:32:14< celticminstrel> Ahh.
20151019 02:32:38< celticminstrel> I think it would be a good thing to do though.
20151019 02:32:43< celticminstrel> ^ aquileia 
20151019 02:32:43< shadowm> vultraz: You have a game_display and it wants a display, or the other way around?
20151019 02:32:57< vultraz> yes 
20151019 02:33:01< shadowm> wedge009: Okay, I'll look at it and test it locally for a while.
20151019 02:33:15< shadowm> vultraz: Don't give me the mathematician's answer please. :p
20151019 02:33:51< shadowm> I asked whether it was one way or the other.
20151019 02:34:13< vultraz> menu_events.cpp deals primarily with game_display. But i need to pass a display to the Unit Create dialog in order to open the Help dialog
20151019 02:34:33< shadowm> A game_display is a display, so it can be implicitly converted.
20151019 02:35:20< shadowm> Does the compiler throw an error at you anyway? What is it?
20151019 02:37:41< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\menu_events.cpp|932|error: no matching function for call to 'gui2::tunit_create::tunit_create(game_display&)'| C:\Users\Charles\Documents\wesnoth-git\src\gui\dialogs\unit_create.hpp|33|note: candidate: gui2::tunit_create::tunit_create(display*)|
20151019 02:38:07< celticminstrel> Address-of operator.
20151019 02:38:16< shadowm> Yeah, you can't implicitly convert pointers to references. What celticminstrel said.
20151019 02:38:33< shadowm> References to pointers in this case.
20151019 02:38:54< celticminstrel> Right, for pointer-to-reference it'd be indirection operator. :P
20151019 02:39:06< shadowm> (Not to be confused to references to pointer types, like T*&, which you won't normally encounter unless you're working with template types.)
20151019 02:40:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20151019 02:40:49< vultraz> what's an indirection operator?
20151019 02:41:06< celticminstrel> The prefix * operator is called the indirection operator.
20151019 02:41:10< shadowm> *foo.
20151019 02:41:15< celticminstrel> Yeah, that.
20151019 02:41:39< shadowm> "Dereference this", basically.
20151019 02:48:14< aquileia> celticminstrel, shadowm: I actually wondered whether one of the Python people the call for help brought in might know scons well enough to update it... it's not necessarily in the best state (help output is missing targets, certain targets are split into their own file while others are clustered into the source one, ...)
20151019 02:48:54< celticminstrel> I only recently started working with it (not on this project though) so I wouldn't say I know it very well.
20151019 02:49:10< shadowm> They've not stuck around as far as I can tell (Elvish_Hunter should be able to confirm).
20151019 02:49:44< shadowm> What targets is the scons recipe help missing, though?
20151019 02:50:32< shadowm> Also, considering that the last time we discussed build systems people were almost trying to persuade me to drop CMake in favor of SCons.
20151019 02:51:15< vultraz> Ok, I've gotten the unit image and profile button working
20151019 02:51:21< aquileia> windows-installer (to be found in packaging/windows/Sconscript)
20151019 02:51:30< celticminstrel> Provided they can both be kept up-to-date, I don't think it's bad to keep both systems around.
20151019 02:51:39< vultraz> now just need to write out the metadata in a stringsream
20151019 02:53:18< shadowm> Yeah, I definitely want both around myself. I simply can't be bothered with CMake for development, but I need it for releasing and our Debian/Ubuntu packagers do as well.
20151019 02:59:59-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151019 03:00:17-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20151019 03:00:17-!- wedge010 is now known as wedge009
20151019 03:03:45-!- Appleman1234 [~Appleman1@KD111239001076.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20151019 03:08:12-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151019 03:09:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20151019 03:17:10-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 268 seconds]
20151019 03:18:34-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151019 03:19:17-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151019 03:19:54-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151019 03:37:16-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Quit: Page closed]
20151019 03:59:08-!- legoktm[NE] is now known as legoktm
20151019 04:01:29-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151019 04:01:31-!- Appleman1234 [~Appleman1@KD106161090253.au-net.ne.jp] has joined #wesnoth-dev
20151019 04:09:44-!- Appleman1234 [~Appleman1@KD106161090253.au-net.ne.jp] has quit [Ping timeout: 244 seconds]
20151019 04:14:06-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Ping timeout: 240 seconds]
20151019 04:16:45-!- framling [~user@104.200.154.63] has quit [Ping timeout: 256 seconds]
20151019 04:16:53-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev
20151019 04:23:33-!- framling [~user@104.200.154.63] has joined #wesnoth-dev
20151019 04:28:14< vultraz> is it possible to create a reference to a single vector index?
20151019 04:28:17< vultraz> er, pointer
20151019 04:28:26< celticminstrel> Of course.
20151019 04:28:49< celticminstrel> Address-of has lower precedence than indexing.
20151019 04:29:05< celticminstrel> Thus. &v[12] is a pointer to the 13th element of the vector.
20151019 04:29:13< celticminstrel> ^Thus,
20151019 04:29:21< celticminstrel> I hate how comma and period are right next to each other.
20151019 04:30:41-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Read error: Connection reset by peer]
20151019 04:30:49< vultraz> so, say const unit = &units_[static_cast<size_t>(selected_row)];?
20151019 04:31:00< celticminstrel> Yes.
20151019 04:31:06< celticminstrel> Why is the static_cast necessary>
20151019 04:31:09< celticminstrel> ^?
20151019 04:31:10< vultraz> (I'm not even sure why all this static_casting is here)
20151019 04:31:18< celticminstrel> Oh, you don't know.
20151019 04:31:48< vultraz> selected_row is an int, but i guess it's somehow a safeguard against .... large...indexes? 
20151019 04:33:18< celticminstrel> Well, it means that if selected_row somehow ends up being -1, then you attempt to reference the ~4 billionth index rather than the area of memory just before the array.
20151019 04:33:44< celticminstrel> Which means you'll definitely get a segfault rather than junk data.
20151019 04:33:53< celticminstrel> (The area of memory just before the array is probably valid, after all.)
20151019 04:34:03< celticminstrel> (Since the runtime needs to store the length of the array there.)
20151019 04:34:48-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20151019 04:34:56< celticminstrel> Unless you want to guarantee a segfault on negative indexes, it's pretty pointless.
20151019 04:35:01< celticminstrel> I think.
20151019 04:35:57< celticminstrel> It might be possible that someone did it to suppress warnings about converting unsigned to signed.
20151019 04:38:27< vultraz> is an int unsigned?
20151019 04:38:34< celticminstrel> No.
20151019 04:38:50< celticminstrel> char, short, int, long, long long are all signed types.
20151019 04:39:30< celticminstrel> (In fact, that's all the basic signed types... well except signed char, which is confusingly a different type from char.)
20151019 04:42:40< celticminstrel> I said that backwards before.
20151019 04:42:46< celticminstrel> ^converting signed to unsigned
20151019 04:42:51< celticminstrel> Sorry for the confusion.
20151019 04:52:42< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\dialogs\unit_create.cpp|226|error: expected unqualified-id before '=' token|
20151019 04:52:44< vultraz> bleh
20151019 04:53:03< vultraz> (same const unit line I pasted above)
20151019 04:53:29< celticminstrel> You forgot to name your variable.
20151019 04:53:40< shadowm> `const unit = &units_[static_cast<size_t>(selected_row)];`
20151019 04:53:49< celticminstrel> There's no name there.
20151019 04:53:51< shadowm> You probably want it to be `const unit* foo`, too.
20151019 04:53:55< vultraz> oh. the name was supposed to be unit >_>
20151019 04:54:01< celticminstrel> Ah?
20151019 04:54:19< celticminstrel> I was going to suggest that you could also interpret it as having the type missing.
20151019 04:54:27< shadowm> Or unit_type* or whatever.
20151019 04:54:30< celticminstrel> I guess that was the right interpretation after all.
20151019 04:55:34< celticminstrel> The compiler probably knows that unit is a type though (assuming that header is included? Not sure if it would be though), so if that's the case it would complain about a missing name.
20151019 04:56:08< vultraz> uhhh...
20151019 04:56:55< vultraz> I'm trying to create a local variable called 'unit' that will point to the current row index of units_.
20151019 04:57:01< vultraz> not a variable of type_unit
20151019 04:57:03< vultraz> er
20151019 04:57:05< vultraz> type unit
20151019 04:57:09< celticminstrel> Yeah, so listen to what shadowm said.
20151019 04:57:29< shadowm> Don't name variables after types btw, it's a recipe for confusion.
20151019 04:57:44< celticminstrel> I forget if it's legal in this sort of situation...
20151019 04:57:59< celticminstrel> I mean, I don't remember if "T T;" is legal when T is a type.
20151019 04:58:23< celticminstrel> Might have to be "struct/class/enum T T;" if you really wanted that, but really, don't do it.
20151019 04:59:36< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\dialogs\unit_create.cpp|226|error: cannot convert 'const unit_type**' to 'const unit_type*' in initialization|
20151019 04:59:38< vultraz> O_O
20151019 05:00:53< shadowm> Yeah, if units_ is a std::vector<unit_type*>, &units[foo] gets you the address of a pointer.
20151019 05:00:59< celticminstrel> Well, your problem is that you didn't understand what you actually wanted. :)
20151019 05:01:27< celticminstrel> You asked how to get the address of the nth element, so we told you how to do that; but in fact you only needed the value of the nth element.
20151019 05:01:41< celticminstrel> Because the nth element is already an address.
20151019 05:03:15< vultraz> so I don't use the address-of operator 
20151019 05:04:34< celticminstrel> Yes.
20151019 05:15:10-!- tMynd [~tMynd@c-73-32-7-22.hsd1.tx.comcast.net] has left #wesnoth-dev ["Leaving"]
20151019 05:20:55-!- mjs-de [~mjs-de@x4db523d9.dyn.telefonica.de] has joined #wesnoth-dev
20151019 05:21:54-!- Appleman1234 [~Appleman1@KD111239027126.au-net.ne.jp] has joined #wesnoth-dev
20151019 05:24:46-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151019 05:27:19-!- louis94 [~~louis94@109.129.245.154] has quit [Client Quit]
20151019 05:32:56-!- Guest58751 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Read error: Connection reset by peer]
20151019 05:34:20-!- Guest58751 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20151019 05:42:13-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20151019 05:45:48-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151019 05:47:55< vultraz> Progress so far https://www.dropbox.com/s/h3kuq4upql9fiah/wesnothGUI2Create_Unit.PNG?dl=0
20151019 05:48:53< vultraz> Unit details very rough
20151019 05:48:57< vultraz> but it shows what I'm aiming for
20151019 05:51:57< shadowm> Why is it at the bottom instead of on the left?
20151019 05:59:54< vultraz> I thought it could look better
20151019 05:59:57< vultraz> do you want it on the left?
20151019 06:00:26< shadowm> The thing is, vertical space is more precious nowadays than horizontal space.
20151019 06:02:41-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151019 06:04:30< vultraz> Alright
20151019 06:05:54< vultraz> I'll move it
20151019 06:15:23-!- irker918 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151019 06:26:58< shadowm> Also, while you are at it, we now have the radio button variant for toggle buttons.
20151019 06:27:31< shadowm> It's just a graphical variant and you're still expected to make the magic happen in the dialog implementation, but it's an important thing to have.
20151019 06:29:07-!- Kwandulin [~Miranda@p5B0094FD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151019 06:34:33-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 252 seconds]
20151019 06:46:17< vultraz> shadowm: https://www.dropbox.com/s/czaok6ebgyxvmzt/wesnothGUI2Create_Unit2.PNG?dl=0
20151019 06:49:26-!- boucman_work [~jrosen@193.56.60.161] has joined #wesnoth-dev
20151019 06:49:26-!- boucman_work [~jrosen@193.56.60.161] has quit [Changing host]
20151019 06:49:26-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151019 06:54:27-!- janebot_ [~Gambot@grickit.us] has quit [Remote host closed the connection]
20151019 06:54:33-!- janebot_ [~Gambot@grickit.us] has joined #wesnoth-dev
20151019 06:56:51-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151019 07:17:56-!- kinow [~kinow@apache/committer/kinow] has joined #wesnoth-dev
20151019 07:18:13< shadowm> vultraz: Uh, so it looks like you committed the feature that adds the current open map's name to the window title?
20151019 07:18:56< shadowm> Ugh I hate Dropbox.
20151019 07:19:33< shadowm> Every time you link images like that I have to download them to see them at 100% correctly because the pointless image view UI they add is buggy and tends to distort the image.
20151019 07:21:40-!- markus_ [~mjs-de@f049235163.adsl.alicedsl.de] has joined #wesnoth-dev
20151019 07:23:02-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20151019 07:24:10< vultraz> shadowm: yes, I committed that feature
20151019 07:24:27< shadowm> Okay, now bring back the version number.
20151019 07:25:18-!- mjs-de [~mjs-de@x4db523d9.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20151019 07:25:27< vultraz> so Bft - Version - filename?
20151019 07:25:29< vultraz> TfW*
20151019 07:25:31< vultraz> BFW
20151019 07:25:34< vultraz> >_<
20151019 07:25:41< shadowm> If you are concerned about the title becoming too long, place the filename before the branding and version.
20151019 07:26:07< shadowm> That way if the WM has to truncate it for whatever reason, the most essential information (the filename) is guaranteed to be at least mostly visible.
20151019 07:26:50< shadowm> In other words, "<filename> - <branding> - <revision>".
20151019 07:28:21< shadowm> Wow, I'm looking at your commit and what happened to my instruction of capturing the previous title instead of setting your own at the end?
20151019 07:29:04< shadowm> Your approach results in duplicated responsibilities (why does the editor need to know the format of the previous title on exit).
20151019 07:29:30< shadowm> Also, you really need to get into the habit of using `const`.
20151019 07:29:52< vultraz> capturing the previous title?
20151019 07:30:06< shadowm> +               map_name = get_map_context().is_pure_map() ? "New Map" : "New Scenario";
20151019 07:30:09< shadowm> This is not translatable.
20151019 07:30:46< shadowm> "New Map" and "New Scenario" already are translatable strings. Use them.
20151019 07:31:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20151019 07:31:07< vultraz> vgettext?
20151019 07:31:20< shadowm> vultraz: <shadowm> SDL_WM_GetCaption
20151019 07:31:32< shadowm> I mentioned that in our conversation.
20151019 07:31:47< shadowm> vultraz: No, vgettext is for interpolated strings.
20151019 07:31:54< shadowm> +       std::string wm_title_string = _("The Battle for Wesnoth");
20151019 07:32:08< shadowm> I think you can guess what the _ function does.
20151019 07:32:57< shadowm> So to recap: bring the revision back, capture the old title and restore it on exit instead of rolling out your own version of it, use more const for constants, and use translatable strings.
20151019 07:34:32< shadowm> Re vgettext, it would be useful if we actually wanted to use interpolation here (e.g. "$filename - $title - $revision"), but personally I don't see the need since these are all supposed to be mutually freestanding strings.
20151019 07:34:59< shadowm> Plus I kind of don't feel it is right to put translators in control of something as large as visible like this if there is no actual need to do so.
20151019 07:35:07< shadowm> Large and visible.
20151019 07:38:03-!- kinow [~kinow@apache/committer/kinow] has quit [Quit: Leaving]
20151019 07:38:20< Jetrel_bot> zookeeper:  so I rolled a few names around.  http://pastebin.com/x3MSmmA0  Can roll some more if these aren't up to snuff, but I'm off to bed at the moment.
20151019 07:39:22< zookeeper> tauroc jumps out as a good one
20151019 07:40:39< Jetrel_bot> aye
20151019 07:49:27< vultraz> I didn't know SDL_WM_GetCaption was a thing
20151019 08:01:18-!- framling [~user@104.200.154.63] has quit [Read error: Connection reset by peer]
20151019 08:01:47-!- Rh0nda is now known as Rhonda
20151019 08:01:53-!- framlinqp [~user@104.200.154.63] has joined #wesnoth-dev
20151019 08:01:56-!- Rhonda [~rhonda@anguilla.noreply.org] has quit [Changing host]
20151019 08:01:56-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev
20151019 08:02:04-!- framlinqp [~user@104.200.154.63] has quit [Read error: Connection reset by peer]
20151019 08:37:46-!- joet [~joet@host86-163-223-158.range86-163.btcentralplus.com] has joined #wesnoth-dev
20151019 09:10:27-!- Kwandulin [~Miranda@p5B0094FD.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151019 09:15:16-!- Guest58751 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Remote host closed the connection]
20151019 09:16:35-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Read error: Connection reset by peer]
20151019 09:16:51-!- Guest58751 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has joined #wesnoth-dev
20151019 09:18:45-!- boucman_2 [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20151019 09:22:18-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 260 seconds]
20151019 09:22:58-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Ping timeout: 240 seconds]
20151019 09:26:26-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20151019 10:04:10-!- Appleman1234 [~Appleman1@KD111239027126.au-net.ne.jp] has quit [Ping timeout: 268 seconds]
20151019 10:21:09-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20151019 10:35:10-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151019 10:39:00-!- louis94 [~~louis94@109.129.245.154] has quit [Client Quit]
20151019 10:59:00-!- zookeeper_ [~lmsnie@37.35.27.57] has joined #wesnoth-dev
20151019 11:00:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20151019 11:00:50-!- Appleman1234 [~Appleman1@KD118156248003.au-net.ne.jp] has joined #wesnoth-dev
20151019 11:01:53-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151019 11:06:39-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 240 seconds]
20151019 11:08:17-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20151019 11:11:41-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151019 11:29:24-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20151019 11:41:57-!- gfgtdf [~chatzilla@f050179070.adsl.alicedsl.de] has joined #wesnoth-dev
20151019 11:44:22< gfgtdf> shadowm: i personaly never needed the see the empty wml containers so i don't care. What i think would be useful though is to replace the list that shows the toplevel children with a treeview which makes it possible to also show sub containeras.
20151019 11:44:51< zookeeper_> wow. i got a PM reply from TreizeCouleurs after... two and a half years.
20151019 11:45:12< gfgtdf> shadowm: for example there are afaik addons which store all their data in one toplevel tag (addon_name. ...) to prevent naming conlicts with other addons
20151019 11:46:43< zookeeper_> shadowm, any objections to replacing frantic.ogg (if not the file for some reason, then all its mainline uses) with http://forums.wesnoth.org/viewtopic.php?p=518075#p518075 ?
20151019 11:46:48-!- zookeeper_ is now known as zookeeper
20151019 11:46:50-!- zookeeper [~lmsnie@37.35.27.57] has quit [Changing host]
20151019 11:46:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20151019 11:46:52< gfgtdf> vultraz: if you need a game_display or display you can usually use resources::screen
20151019 11:48:10< gfgtdf> 20151019 04:33:18< celticminstrel> Well, it means that if selected_row somehow ends up being -1, then you attempt to reference the ~4 billionth index rather than the area of memory just before the array.
20151019 11:48:19< gfgtdf> celticminstrel: no this is wrong
20151019 11:48:48< gfgtdf> celticminstrel: the static_cast has simply no effect, even if you pass an int will will just be cases to an ize_t anyway
20151019 11:49:02< gfgtdf> cast*
20151019 11:59:50-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20151019 12:06:23-!- boucman_2 [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 252 seconds]
20151019 12:06:32-!- Appleman1234 [~Appleman1@KD118156248003.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20151019 12:13:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151019 12:14:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20151019 12:16:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151019 12:19:19-!- cib0 [~cib@p5DD23725.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151019 12:21:53-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151019 13:03:31-!- cib0 [~cib@p5DD23725.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151019 13:03:46-!- cib0 [~cib@p5DD23725.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151019 13:08:11-!- Appleman1234 [~Appleman1@KD118156248003.au-net.ne.jp] has joined #wesnoth-dev
20151019 13:08:21-!- boucman_2 [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20151019 13:11:46-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds]
20151019 13:18:08-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151019 13:18:36-!- markus_ is now known as mjs-de
20151019 13:25:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds]
20151019 13:26:30-!- Appleman1234 [~Appleman1@KD118156248003.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20151019 13:28:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151019 13:29:06-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151019 13:31:14-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20151019 13:37:31-!- mjs-de [~mjs-de@f049235163.adsl.alicedsl.de] has quit [Remote host closed the connection]
20151019 13:38:53-!- joet [~joet@host86-163-223-158.range86-163.btcentralplus.com] has quit [Ping timeout: 256 seconds]
20151019 13:41:17-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20151019 13:41:41-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 244 seconds]
20151019 13:44:57-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151019 13:48:40-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Excess Flood]
20151019 13:48:51-!- heirecka [~heirecka@j61898.servers.jiffybox.net] has joined #wesnoth-dev
20151019 13:48:51-!- heirecka [~heirecka@j61898.servers.jiffybox.net] has quit [Changing host]
20151019 13:48:51-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20151019 13:51:17-!- joet [~joet@host86-163-218-88.range86-163.btcentralplus.com] has joined #wesnoth-dev
20151019 14:11:27-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind1]
20151019 14:12:11-!- not-a-robot [b8aa7007@gateway/web/freenode/ip.184.170.112.7] has joined #wesnoth-dev
20151019 14:15:31-!- not-a-robot [b8aa7007@gateway/web/freenode/ip.184.170.112.7] has quit [Client Quit]
20151019 14:19:41-!- joet [~joet@host86-163-218-88.range86-163.btcentralplus.com] has quit [Quit: Leaving]
20151019 14:23:12-!- {V} [~V@105-70-ftth.on.nl] has quit [Ping timeout: 255 seconds]
20151019 14:24:08-!- {V} [~V@105-70-ftth.on.nl] has joined #wesnoth-dev
20151019 14:25:48-!- joet [~joet@host86-163-218-88.range86-163.btcentralplus.com] has joined #wesnoth-dev
20151019 14:32:53< vultraz> gfgtdf: so the static_cast is unnecessary? 
20151019 14:34:25-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151019 14:38:51< gfgtdf> vultraz: where exactly ?
20151019 14:40:00-!- Appleman1234 [~Appleman1@KD118156248003.au-net.ne.jp] has joined #wesnoth-dev
20151019 14:45:26-!- Appleman1234 [~Appleman1@KD118156248003.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20151019 14:56:10< vultraz> gfgtdf: in a lot of the gui2 dialogs, where it has const int selected_row = list.selected_row(); and it uses that variable it casts it as size_t
20151019 14:56:46< gfgtdf> vultraz: hmm maybe there exists some copiler which gives a warning about that implcit tize_t cast?
20151019 14:59:10-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151019 14:59:47< gfgtdf> vultraz: i dont know why one woudl place those static_cast there otherwise
20151019 15:00:38-!- boucman_2 [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 260 seconds]
20151019 15:02:48< vultraz> gfgtdf: it only uses the static cast when accessing vector indexes btw
20151019 15:03:02< vultraz> are indexes always size_t?
20151019 15:03:19-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 265 seconds]
20151019 15:03:19-!- wedge010 is now known as wedge009
20151019 15:04:17-!- gfgtdf [~chatzilla@f050179070.adsl.alicedsl.de] has quit [Ping timeout: 265 seconds]
20151019 15:07:27-!- cib0 [~cib@p5DD23725.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds]
20151019 15:14:48-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151019 15:15:47-!- cib0 [~cib@p5DD23725.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151019 15:17:06-!- gfgtdf [~chatzilla@x55b196a9.dyn.telefonica.de] has joined #wesnoth-dev
20151019 15:17:15-!- boucman_2 [~jrosen@193.56.60.161] has joined #wesnoth-dev
20151019 15:23:12< vultraz> gah, the column size problem arises again
20151019 15:23:26< vultraz> I need to be able to set a width for this column
20151019 15:23:31< vultraz> or else longer unit names are cut off
20151019 15:23:35< vultraz> as are bigger images
20151019 15:23:37< vultraz> fuck
20151019 15:23:42< vultraz> not sure wat 2 do
20151019 15:35:49-!- Saro [2302b51c@gateway/web/freenode/ip.35.2.181.28] has joined #wesnoth-dev
20151019 15:40:06-!- Saro [2302b51c@gateway/web/freenode/ip.35.2.181.28] has quit [Ping timeout: 246 seconds]
20151019 15:55:32-!- boucman_2 [~jrosen@193.56.60.161] has quit [Remote host closed the connection]
20151019 15:58:59-!- Appleman1234 [~Appleman1@KD111239009024.au-net.ne.jp] has joined #wesnoth-dev
20151019 16:00:59< gfgtdf> vultraz: the images are variabl in size ?
20151019 16:01:09< vultraz> yes for example the fire dragon
20151019 16:01:42< gfgtdf> vultraz: can't we handle it teh same was as we handle it in teh image in teh right side panel so that they always fit?
20151019 16:01:57< vultraz> I'm not sure how we do that
20151019 16:02:05< vultraz> also, there's still the name getting cut off
20151019 16:02:27< gfgtdf> vultraz: wait are you working on the debug unti creaton or teh loadgame dialog ?
20151019 16:02:36< vultraz> debug unit creation
20151019 16:02:45< vultraz> but the problem of the column size also affects load game
20151019 16:04:11-!- Appleman1234 [~Appleman1@KD111239009024.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20151019 16:07:13< vultraz> I *could* use a multipage but shadowm said he doesn't know if every page surface is stored
20151019 16:07:20< vultraz> every offscren
20151019 16:07:22< vultraz> *
20151019 16:08:33< gfgtdf> vultraz: well you could just trry it and check whether it preforms ok even with a lot of available units (multiplayer)
20151019 16:08:59< gfgtdf> vultraz: the other plan woudol be to fix teh savgame thing and teh unti creating thing together
20151019 16:09:21< vultraz> I would like to get both working well, yes
20151019 16:10:34< gfgtdf> vultraz: then i think you'd need to implement a 'fixes with panel' or something
20151019 16:11:04< gfgtdf> width*
20151019 16:14:00< vultraz> god dammit I keep accidentally hitting Rebuild instead of Build :(
20151019 16:17:33-!- mjs-de [~mjs-de@vpn19209.itmc.tu-dortmund.de] has joined #wesnoth-dev
20151019 16:23:13-!- mjs-de [~mjs-de@vpn19209.itmc.tu-dortmund.de] has quit [Ping timeout: 256 seconds]
20151019 16:25:21-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20151019 16:27:09 * vultraz waves at celticminstrel
20151019 16:28:59-!- joet [~joet@host86-163-218-88.range86-163.btcentralplus.com] has quit [Ping timeout: 264 seconds]
20151019 16:29:37-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has quit [Ping timeout: 264 seconds]
20151019 16:29:37-!- avtobiff [~avtobiff@c-503270d5.015-6-73746f28.cust.bredbandsbolaget.se] has quit [Ping timeout: 264 seconds]
20151019 16:31:46-!- mjs-de [~mjs-de@vpn19209.itmc.tu-dortmund.de] has joined #wesnoth-dev
20151019 16:33:25< celticminstrel> Hi
20151019 16:34:09< vultraz> does MSVC put the Rebuild button right next to Build
20151019 16:34:12-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has joined #wesnoth-dev
20151019 16:35:22-!- juman [~quassel@x5d854b9f.dyn.telefonica.de] has joined #wesnoth-dev
20151019 16:51:23< celticminstrel> Uh. Does it?
20151019 16:51:28< celticminstrel> I use the menus for that.
20151019 16:51:40< vultraz> I'm asking bc I keep hitting Rebuild in codeblocks
20151019 16:51:46< vultraz> wondering if msvc would prevent that
20151019 16:53:05< celticminstrel> Does CodeBlocks not let you customize your toolbars?
20151019 16:54:44< vultraz> i use the menus :P
20151019 17:01:31-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151019 17:06:43-!- Appleman1234 [~Appleman1@KD111239009024.au-net.ne.jp] has joined #wesnoth-dev
20151019 17:11:47-!- Kwandulin [~Miranda@p200300760F6848F1751330A3B9EAF398.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151019 17:18:34-!- cib0 [~cib@p5DD23725.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151019 17:18:36-!- cib0 [~cib@p5DD23725.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151019 17:27:25-!- Appleman1234 [~Appleman1@KD111239009024.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20151019 17:31:31-!- avtobiff [~avtobiff@c-503270d5.015-6-73746f28.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20151019 17:34:42-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 244 seconds]
20151019 17:36:44< iceiceice> vultraz: when i used an ms ide 15 years ago i think 'f5' was the build button :p
20151019 17:38:18-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151019 17:39:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20151019 17:42:41< juman> hello everyone, I am currently trying to understand the wesnoth code and structure and I am wondering: You define the layout of your menus in your "theme" wml file. you can name certain menu items e.g. "endturn". In  the class menu_events you have the method "end_turn()". How does the "conversion" work? I mean I could kinda understand the parser of the WML files but I dont get it yet where the interface to the actual methods within the 
20151019 17:42:41< juman> games control are hidden. I hope that makes sense :P 
20151019 17:43:11-!- mjs-de [~mjs-de@vpn19209.itmc.tu-dortmund.de] has quit [Remote host closed the connection]
20151019 17:45:03< celticminstrel> Not quite sure if this is what you're looking for, but try ... I think it's just hotkey.?pp.
20151019 17:45:13< celticminstrel> Possibly plural.
20151019 17:46:53-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has joined #wesnoth-dev
20151019 17:48:38-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20151019 17:49:16< aquileia> vultraz, iceiceice: In MSVC, F5 is 'Run with Debugger' whereas Ctrl+Shift+B is 'Build Solution'
20151019 17:49:44< juman> celticminstrel: oh yes thanks, I think that should be it
20151019 17:49:59< aquileia> The buttons are next to each other though, so no advantage there
20151019 17:54:42-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20151019 17:58:25-!- aquileia [95acd0d3@gateway/web/freenode/ip.149.172.208.211] has quit [Quit: Page closed]
20151019 18:03:59-!- Kwandulin [~Miranda@p200300760F6848F1751330A3B9EAF398.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20151019 18:07:53-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20151019 18:10:31-!- Kwandulin [~Miranda@p200300760F2AB1CFB59C9152DA6CCE15.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151019 18:18:21-!- juman_ [~quassel@x5d854b9f.dyn.telefonica.de] has joined #wesnoth-dev
20151019 18:18:21-!- juman [~quassel@x5d854b9f.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20151019 18:22:08< zookeeper> Jetrel_bot, on a not-so-serious note, i'm tempted by "tauntaur"
20151019 18:24:13-!- Appleman1234 [~Appleman1@KD118156254168.au-net.ne.jp] has joined #wesnoth-dev
20151019 18:24:23< celticminstrel> ...tauntaur?
20151019 18:24:58< zookeeper> we're trying to come up with a name for the new desert elf mount species
20151019 18:25:05< celticminstrel> Ah.
20151019 18:27:32-!- fabi [~quassel@176.2.104.108] has joined #wesnoth-dev
20151019 18:27:32-!- fabi [~quassel@176.2.104.108] has quit [Changing host]
20151019 18:27:32-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151019 18:28:35< gfgtdf> junan: it wors with the hotkey exectur code here is hwteher that string is defined: https://github.com/wesnoth/wesnoth/blob/master/src/hotkey/hotkey_command.cpp#L74
20151019 18:36:50-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 260 seconds]
20151019 18:41:36< vultraz> zookeeper: no alot? :(
20151019 18:41:48< zookeeper> alotaur?
20151019 18:41:50< zookeeper> hmmm
20151019 18:42:17< vultraz> why not
20151019 18:42:21< vultraz> sounds good
20151019 18:44:01< celticminstrel> Why taur?
20151019 18:44:09< celticminstrel> Just wondering.
20151019 18:44:15< celticminstrel> It makes me think of centaurs.
20151019 18:44:19< celticminstrel> Or minotaurs.
20151019 18:44:22-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20151019 18:46:15-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20151019 18:49:34-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151019 18:49:36-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 250 seconds]
20151019 18:52:57< zookeeper> well, because of etymology?
20151019 18:54:16< celticminstrel> tauros = bull ... though I think "centaur" might not be derived from that.
20151019 18:54:36< celticminstrel> Based on what I've seen of these beasts, I think I could see that connection.
20151019 18:55:22< zookeeper> the name doesn't need to be derived from tauros, but it should be at least lightly derived from something associated with that kind of animals
20151019 18:55:45-!- ancestral [~ancestral@63.92.240.233] has quit [Ping timeout: 268 seconds]
20151019 18:55:54< celticminstrel> The beasts also seem a bit camel-like, with the humps, though they're very different from camels in other ways.
20151019 18:56:21-!- ancestral [~ancestral@85.sub-70-197-225.myvzw.com] has joined #wesnoth-dev
20151019 18:56:44< zookeeper> yeah they could just as well be camelotaurolopes, but that's not a good word :J
20151019 18:57:07< celticminstrel> Too long. :P
20151019 18:57:34-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20151019 18:57:38-!- ancestral [~ancestral@85.sub-70-197-225.myvzw.com] has quit [Client Quit]
20151019 18:57:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151019 18:58:04< celticminstrel> They're not very antelopy.
20151019 18:59:53< celticminstrel> LordBob's drawings mostly invoke things like ox, bison, yak, etc. Bovines, basically.
20151019 19:00:14< vultraz> yes, but they could be designed differently
20151019 19:00:25< celticminstrel> Sure.
20151019 19:00:38< celticminstrel> ^evoke
20151019 19:02:08< vultraz> "cannot call function without objects" hm...
20151019 19:02:20< celticminstrel> Uh?
20151019 19:04:12< vultraz> fixed it
20151019 19:04:55< vultraz> long code is long
20151019 19:05:03< vultraz> const std::string tc = "~RC(" + units_[static_cast<size_t>(selected_row)]->flag_rgb() + ">" + team::get_side_color_index(resources::controller->play_controller::current_side()) + ")";
20151019 19:05:04< vultraz> heh
20151019 19:05:29< celticminstrel> Bleh.
20151019 19:05:41< vultraz> it works though :P
20151019 19:07:21< vultraz> I always wonder how much string-based functionality to rely on
20151019 19:07:30< celticminstrel> Hmm?
20151019 19:07:31< vultraz> like this pieces together an IPF string for the image
20151019 19:07:47< vultraz> I wonder if there's a get_tced_sprite function or something
20151019 19:07:53< vultraz> which I'm supposed to use
20151019 19:08:00< celticminstrel> I dunno.
20151019 19:08:31< celticminstrel> You do need to be careful using + on strings.
20151019 19:08:37-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20151019 19:08:49< celticminstrel> "abc" + "def" will most likely produce a segfault.
20151019 19:09:10< celticminstrel> Though, in that specific case it's easily fixed by just omitting the + altogether.
20151019 19:09:11< vultraz> or for this stuff for formatting in general. is it better to use hardcoded string appends and let the engine translate it (ie, mixing lowerlevel with higherlevel functionality) or to call functions
20151019 19:10:07< celticminstrel> I don't know.
20151019 19:11:33< vultraz> in this case at least, that line is looongg and looks hacky :P
20151019 19:11:54< celticminstrel> You could break it up.
20151019 19:11:59< celticminstrel> Using += or ostringstream.
20151019 19:12:38< vultraz> shadowm would know the best method, probably
20151019 19:12:56< celticminstrel> Did you write that line yourself?
20151019 19:13:42< celticminstrel> Another reason + on strings can be dangerous is because "abcdef" + 3 produces "def", not "abcdef3".
20151019 19:13:45< vultraz> the second half of it
20151019 19:13:58< celticminstrel> What type does get_side_color_index return?
20151019 19:14:15< vultraz> I'm picking out code from the old gui1 dialogs and translating it to my needs
20151019 19:14:20< celticminstrel> Because I have a feeling that you might've hit the thing I just mentioned.
20151019 19:15:29< vultraz> 	static std::string get_side_color_index(int side);
20151019 19:15:29< celticminstrel> Though actually... + is left-associative, so if flag_rgb() returns a string (which it probably does) and get_side_color_index() returns an integer, I don't think it would compile...
20151019 19:15:39< celticminstrel> Ah, okay, that's fine then.
20151019 19:15:43< vultraz> it builds and works, so don't worry
20151019 19:15:48 * celticminstrel nods.
20151019 19:16:23< vultraz> I'm going to commit what I have so far. It's not much but the basic functionality is there
20151019 19:22:19-!- cib0 [~cib@p5DD23725.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20151019 19:27:09< vultraz> eh, maybe should hold off
20151019 19:27:28-!- Kwandulin [~Miranda@p200300760F2AB1CFB59C9152DA6CCE15.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151019 19:28:13< celticminstrel> Nah, don't hold off. Just commit to a branch/fork instead of master.
20151019 19:28:25< celticminstrel> If you think you have something ready to commit, then commit it.
20151019 19:28:45-!- cib0 [~cib@p5DD23725.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151019 19:29:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20151019 19:29:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151019 19:48:29-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20151019 19:52:59-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Read error: Connection reset by peer]
20151019 19:56:05-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 252 seconds]
20151019 19:58:36-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20151019 19:58:41-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151019 20:04:09 * vultraz ponders designs for alignment icons
20151019 20:05:50< vultraz> Sun, moon.... half half and.... i dunno for liminal 
20151019 20:07:10< celticminstrel> Liminal could be stars or sunset or something... neutral though, I have no idea.
20151019 20:08:46< vultraz> (if you're wondering why, it's because I'm putting icons to use for this dialog)
20151019 20:08:51< vultraz> instead of all text
20151019 20:26:01< vultraz> I'll ask LB to do some proper ones
20151019 20:30:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20151019 20:32:43-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151019 20:33:17-!- Appleman1234 [~Appleman1@KD118156254168.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20151019 20:34:20-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20151019 20:35:46< vultraz> celticminstrel, shadowm: https://www.dropbox.com/s/wlc4w7hhkh59dp5/wesnothGUI2Create_Unit3.PNG?dl=0
20151019 20:41:10-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151019 20:43:53< celticminstrel> Dropbox is fail.
20151019 20:44:24< celticminstrel> I can't see that image. Guessing it requires cookies or something stupid like that.
20151019 20:48:58-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 272 seconds]
20151019 20:49:22-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 260 seconds]
20151019 20:50:05< shadowm> gfgtdf: Hm, yeah that might be a good idea.
20151019 20:50:38< shadowm> (The inspector tree view, I mean.)
20151019 20:51:36< shadowm> vultraz: Vector indexes for a given instantiation std::vector<T> are std::vector<T>::size_type (in practice this is always a type equivalent to size_t).
20151019 20:53:21-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151019 20:53:37-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20151019 20:53:54< vultraz> I see
20151019 20:56:29< shadowm> Now, do us a favor and upload that somewhere we both can see it. :p
20151019 20:56:46< shadowm> (And where I can see it without having to fight Dropbox's broken UI.)
20151019 21:00:42-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20151019 21:05:14< vultraz> shadowm, celticminstrel: https://drive.google.com/open?id=0B-mR9s8FduLLQVVOVnNLTGFVVjQ
20151019 21:08:52< celticminstrel> I think you missed a step,
20151019 21:09:02< celticminstrel> I don't have access to that.
20151019 21:09:40< vultraz> blaghh
20151019 21:10:06< vultraz> https://drive.google.com/file/d/0B-mR9s8FduLLQVVOVnNLTGFVVjQ/view?usp=sharing
20151019 21:10:11< vultraz> celticminstrel, shadowm ^
20151019 21:10:29< celticminstrel> What's the skull even mean.
20151019 21:10:33< celticminstrel> Oh, race?
20151019 21:10:47< celticminstrel> Would the name be shown on mouseover, at least?
20151019 21:11:06< celticminstrel> Gender is missing an option (random).
20151019 21:11:23< Aginor> what's the moon supposed to be?
20151019 21:11:25< celticminstrel> Otherwise it seems okay to me.
20151019 21:11:34< celticminstrel> I think it's supposed to mean chaotic, Aginor.
20151019 21:12:08< vultraz> yes, the left icon is race and the right is alignment
20151019 21:12:18< vultraz> tooltips tell you what they are on mouseover
20151019 21:12:22-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind1]
20151019 21:12:29< vultraz> I wish we had tooltips at mouse position but mehhh :(
20151019 21:12:46< celticminstrel> Ah, it uses the ones at the bottom of the screen?
20151019 21:12:53< vultraz> yes'
20151019 21:13:00< vultraz> maybe someone could implement them at mouse position
20151019 21:13:01< celticminstrel> Well, better than nothing I guess...
20151019 21:13:21< Aginor> I think the alignment term should be scrapped and lawful/chaotic/neutral renamed
20151019 21:13:31< vultraz> eh?
20151019 21:14:14< Aginor> it's not like it's got anything to do with the tradtional alignments, but it uses the same names
20151019 21:14:20< celticminstrel> I think it would make a lot of sense to rename lawful/chaotic to diurnal/nocturnal. Not sure about neutral though.
20151019 21:14:35< celticminstrel> I also can't think of any better term than "alignment".
20151019 21:14:54< celticminstrel> Renaming to diurnal/nocturnal does also fit better with the term liminal, I think?
20151019 21:15:56< vultraz> I wouldn't particularly mind
20151019 21:15:59< celticminstrel> Anyway, by renaming them to diurnal/nocturnal, the names become completely self-explanatory.
20151019 21:16:26< Aginor> indeed
20151019 21:16:51< celticminstrel> I think most people know what "nocturnal" means, and even if they haven't encountered the term "diurnal" before, it's not that hard to figure out by analogy, I think.
20151019 21:17:33< vultraz> celticminstrel: as long as the old alignment names would alias to the new ones I think it could be done
20151019 21:17:38 * Aginor fully agrees
20151019 21:18:11< celticminstrel> By alias you mean you could still use alignment=lawful in the WML, right? Of course that would be the case for compatibility (though it could be eventually removed).
20151019 21:18:26< Aginor> http://pets.stackexchange.com/questions/5806/diurnal-crepuscular-nocturnal-matutinal-vespertine-what-do-these-mean-and-h
20151019 21:18:27< celticminstrel> Hmm, I guess I was wrong about "liminal", at least according to Wiktionary. It doesn't seem to have anything directly to do with twilight.
20151019 21:18:58< Aginor> crepuscular!
20151019 21:19:11 * celticminstrel nods.
20151019 21:19:20< shadowm> I thought alignment names were one of those flavor things that were intentionally done in a certain way at the beginning of Wesnoth's development.
20151019 21:19:21< vultraz> now that's... a bit odd
20151019 21:19:44< celticminstrel> Crepuscular isn't obvious at all though.
20151019 21:20:01< Aginor> and it's not sounding that good to people who don't know what it is
20151019 21:21:38< celticminstrel> That page even lists a term for "neutral", but I think it's even worse: cathemeral.
20151019 21:21:49< celticminstrel> (It's in the second answer.)
20151019 21:21:52< Aginor> so maybe this is a bad idea
20151019 21:21:56< celticminstrel> Maybe!
20151019 21:23:46-!- gfgtdf [~chatzilla@x55b196a9.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20151019 21:25:58-!- ancestral [~ancestral@207.250.184.217] has joined #wesnoth-dev
20151019 21:28:11< Jetrel_bot> personally I've always been of a mind that our "joined at the hip" treatment of 'moral alignment' with 'time-of-day' alignment was a bad idea.
20151019 21:28:53-!- cib_ [~cib@p5DD23725.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151019 21:28:53-!- cib_ [~cib@p5DD23725.dip0.t-ipconnect.de] has quit [Client Quit]
20151019 21:28:53-!- cib0 [~cib@p5DD23725.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151019 21:29:00< celticminstrel> I'm not sure if I agree with calling lawful/chaotic "moral" alignment...
20151019 21:29:12< Jetrel_bot> celticminstrel:  it's pretty standard D&D usage
20151019 21:30:06< celticminstrel> I know of the D&D alignment system, yes; but when hearing "moral" alignment it makes me think more of the other axis of good/evil.
20151019 21:30:06< Jetrel_bot> celticminstrel:  whether you're evil or good, it represents how you adhere to your moral code;  do you do so wildly, and chaotically, like a classic "trickster" figure, or do you do so 'by the book', in a procedural, 'lawful' way
20151019 21:30:41< Jetrel_bot> celticminstrel:  yeah, basically we agree on this, really
20151019 21:30:55-!- Appleman1234 [~Appleman1@KD118156248161.au-net.ne.jp] has joined #wesnoth-dev
20151019 21:31:19-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151019 21:31:34< celticminstrel> Oh okay.
20151019 21:31:45< Jetrel_bot> I've seen the argument provided for our existing naming system, back in the day - the idea being to convey an idea about our setting; that this is a wild, savage fantasy world, and it's legitimately scary and dangerous when the sun goes down.  That you hunker down in your homes because the goblins and bogeymen come out.
20151019 21:32:07< celticminstrel> I don't think I really have a strong preference regarding whether the alignment terms should be changed though.
20151019 21:32:57< Jetrel_bot> The problem is we're really not a "wild-fantasy" setting; we're a much more tame, "settled" fantasy, with a largely empty, mundane world.
20151019 21:33:15< celticminstrel> Eh?
20151019 21:34:08< Jetrel_bot> celticminstrel:  we're a predictable world where goblins are flesh-and-blood creatures that you can drive out of your lands with soldiers and stuff
20151019 21:34:58< celticminstrel> Ah, I see what you mean.
20151019 21:35:17< Jetrel_bot> celticminstrel:  as opposed to a wilder, more magical setting where the primary antagonistic forces are supernatural creatures - hobgoblins, bogeymen, and spooks, that materialize out of the growing shadows when the sun comes down
20151019 21:35:22< celticminstrel> The dangers in the world of Wesnoth are closer to "bandits" than "demonic hordes".
20151019 21:35:45< Jetrel_bot> Where there are brownies hiding in your garden.
20151019 21:35:49 * celticminstrel nods.
20151019 21:35:56< celticminstrel> Or under the sink. :P
20151019 21:36:00< Jetrel_bot> heh
20151019 21:36:03< Jetrel_bot> Yeah.
20151019 21:36:53< vultraz> It's unfortunate we can't tap into that type of supernatural lore
20151019 21:36:57< vultraz> even with our Undead
20151019 21:36:59< Jetrel_bot> I think the big thing is - during the very early days wesnoth was totally "up in the air" about what the setting was going to be like, and I think "headcanon" in a few of the original creators leaned much more towards wild fantasy type stuff.
20151019 21:37:06< celticminstrel> What, vultraz?
20151019 21:37:09< Jetrel_bot> vultraz:  it's very hard to do well
20151019 21:37:31< Jetrel_bot> very very hard, because causality becomes a lot harder to juggle.
20151019 21:37:33< vultraz> celticminstrel: as jet is saying, our Undead are very practical and you can drive them our with soldiers :P
20151019 21:37:56< celticminstrel> Honestly, aside from ghosts/spirits I think that makes perfect sense.
20151019 21:39:34< Jetrel_bot> vultraz:  part and parcel, too, videogames deal in numbers and stuff, so it's much tougher to have a fantasy game where you're given a feeling of inscrutable malice because the undead are something you can procedurally surround and whittle down just like you'd do to an army of orcs.
20151019 21:39:42-!- irker446 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151019 21:39:42< irker446> wesnoth: Charles Dang wesnoth:master 701229d69da7 / images/icons/alignments/ (4 files): Added a set of Alignment icons http://git.io/vWfFS
20151019 21:40:05< celticminstrel> I can't see them. :(
20151019 21:40:27< vultraz> they're white :P
20151019 21:40:31< celticminstrel> Exactly.
20151019 21:40:39< celticminstrel> If I click Raw I can see a bit better.
20151019 21:41:03< Jetrel_bot> To give them a very different feeling, you'd need to break the Big Rules, like death, recruitment, etc.
20151019 21:41:16< celticminstrel> Yeah.
20151019 21:41:40< Jetrel_bot> I.e. a crazy way to handle undead would be making them completely unkillable - you can beat them up and they collapse for a couple turns, but then the skeleton reforms.
20151019 21:41:45< celticminstrel> The liminal icon is somehow weird, but neutral actually seems rather good.
20151019 21:42:25< Jetrel_bot> Etc, etc.
20151019 21:42:43< vultraz> Jetrel_bot: that's the kind of idea that would have been rejected by the early dev team. Maybe that's why something like that never happened
20151019 21:43:16< Jetrel_bot> vultraz:  this was early enough that folks probably would have been more apt to try it.
20151019 21:43:54< Jetrel_bot> Anyways - this is the sort of idea that I don't think has a place in "wesnoth the current game", but it'd be a great idea for a different game built off wesnoth's resources.
20151019 21:44:25< Jetrel_bot> I'd love to do something like that in years to come.
20151019 21:44:46< vultraz> So would I
20151019 21:45:51< irker446> wesnoth: Charles Dang wesnoth:master 21391f903913 / / (3 files in 2 dirs): tunit_create: added minimal unit preview section and filter box (non-functional) http://git.io/vWfN1
20151019 21:49:24-!- ancestral [~ancestral@207.250.184.217] has quit [Quit: i go nstuf kthxbai]
20151019 21:50:04< celticminstrel> Without a filter box, that dialog is almost completely useless.
20151019 21:50:12< vultraz> I'm working on it
20151019 21:50:24-!- chris__ [~chris@23.31.228.41] has joined #wesnoth-dev
20151019 21:50:35< vultraz> just need to port the functionality from Load Game
20151019 21:52:20< zookeeper> vultraz, umm, what purpose would those icons serve and where? we'd still display the text whenever possible, and i can't think of any places where there's too little space for text but enough for icons.
20151019 21:52:33< zookeeper> unless you mean these for like an alternative theme or something
20151019 21:52:56< vultraz> zookeeper: https://drive.google.com/file/d/0B-mR9s8FduLLQVVOVnNLTGFVVjQ/view?usp=sharing
20151019 21:55:23-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20151019 21:55:41< zookeeper> vultraz, yeah, but you're not making icons for use in the debug create unit dialog only
20151019 21:56:14< vultraz> for now they're just used there
20151019 21:56:25< vultraz> I might use the design in Recall/Recruit
20151019 21:58:18< zookeeper> if you replace race/alignment with an icon anywhere, it needs to be done pretty much everywhere then
20151019 21:58:29< zookeeper> replace or add the icon next to the text, that is
20151019 21:59:55< zookeeper> you can't have one part of the game represent race/alignment with text and some other part with an icon, it needs to be the same everywhere whenever possible
20151019 22:01:27< vultraz> right
20151019 22:01:43< vultraz> I don't mind doing so
20151019 22:03:32< zookeeper> yeah, i dunno, icons are pretty much infinitely harder to learn if they're not accompanied by text, and if you have text the icon becomes redundant
20151019 22:04:00< zookeeper> i'd consider it only if there really isn't space for the text in very important parts of the UI
20151019 22:04:15< zookeeper> anyways, i was heading off ->
20151019 22:07:46-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 260 seconds]
20151019 22:09:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds]
20151019 22:12:42-!- chris__ [~chris@23.31.228.41] has quit [Quit: Leaving]
20151019 22:20:12-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20151019 22:27:41-!- chris__ [~chris@50.245.222.235] has joined #wesnoth-dev
20151019 22:29:12-!- Shackra [~Jorge@186.177.2.148] has quit [Ping timeout: 255 seconds]
20151019 22:29:29-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20151019 22:33:27-!- chris__ [~chris@50.245.222.235] has quit [Remote host closed the connection]
20151019 22:42:28-!- juman_ [~quassel@x5d854b9f.dyn.telefonica.de] has quit [Remote host closed the connection]
20151019 22:53:45-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20151019 22:55:20-!- clavii is now known as clavi
20151019 22:55:58-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151019 23:03:30-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20151019 23:03:33-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20151019 23:03:33-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151019 23:04:12-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Remote host closed the connection]
20151019 23:04:29-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20151019 23:04:29-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20151019 23:04:29-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151019 23:09:29-!- janebot_ [~Gambot@grickit.us] has quit [Remote host closed the connection]
20151019 23:09:36-!- janebot_ [~Gambot@grickit.us] has joined #wesnoth-dev
20151019 23:11:02-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20151019 23:11:21-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151019 23:23:53-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20151019 23:26:06-!- travis-ci [~travis-ci@ec2-54-91-82-211.compute-1.amazonaws.com] has joined #wesnoth-dev
20151019 23:26:07< travis-ci> wesnoth/wesnoth#7669 (master - 21391f9 : Charles Dang): The build was broken.
20151019 23:26:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/86282765
20151019 23:26:07-!- travis-ci [~travis-ci@ec2-54-91-82-211.compute-1.amazonaws.com] has left #wesnoth-dev []
20151019 23:37:55-!- Appleman1234 [~Appleman1@KD118156248161.au-net.ne.jp] has quit [Ping timeout: 244 seconds]
20151019 23:40:49-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20151019 23:47:33-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Remote host closed the connection]
20151019 23:52:16-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
--- Log closed Tue Oct 20 00:00:16 2015