--- Log opened Wed Oct 21 00:00:27 2015
20151021 00:05:50-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151021 00:11:54-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20151021 00:33:18-!- joet [~joet@host86-163-218-88.range86-163.btcentralplus.com] has quit [Quit: Leaving]
20151021 01:08:14-!- IlMago [~IlMago@2602:306:c51d:a6a0:2583:61f1:9a55:151f] has joined #wesnoth-dev
20151021 01:22:45< shadowm> Sometimes I understand people who refuse spell "Microsoft". Sigh this is frustrating.
20151021 01:36:16-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20151021 01:36:16-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20151021 01:36:16-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151021 01:38:56-!- IlMago [~IlMago@2602:306:c51d:a6a0:2583:61f1:9a55:151f] has left #wesnoth-dev ["Leaving"]
20151021 01:39:19-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151021 01:41:12-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151021 01:44:41-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20151021 01:56:35-!- Appleman1234 [~Appleman1@KD106161083237.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20151021 02:02:54-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 250 seconds]
20151021 02:15:32-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151021 02:15:48 * shadowm prepares for the inevitable wave of questions that's about to follow.
20151021 02:18:03-!- irker681 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151021 02:18:03< irker681> wesnoth: Ignacio R. Morelle wesnoth:master 1fe5134e73cd / src/filesystem_boost.cpp: fs: Clean up Windows-specific code in set_user_data_dir() http://git.io/vWqOS
20151021 02:18:04< irker681> wesnoth: Ignacio R. Morelle wesnoth:master 795dd8c4200c / src/filesystem_boost.cpp: fs: Default to Documents for user config/data on Windows http://git.io/vWqO9
20151021 02:18:05< irker681> wesnoth: Ignacio R. Morelle wesnoth:master bc22ec91760d / src/filesystem_boost.cpp: fs: Treat . and .. in userdata/config paths relative to cwd on Windows http://git.io/vWqOH
20151021 02:18:07< irker681> wesnoth: Ignacio R. Morelle wesnoth:master 8f8fde43bad8 / src/filesystem_boost.cpp: fs: Use SHGetFolderPath() instead of SHGetSpecialFolderPath() http://git.io/vWqOQ
20151021 02:18:09< irker681> wesnoth: Ignacio R. Morelle wesnoth:master 80af2f7cdd2d / RELEASE_NOTES changelog players_changelog: Update changelogs and release notes for bug #23573 http://git.io/vWqO7
20151021 02:18:12< irker681> wesnoth: Ignacio R. Morelle wesnoth:master 2aab35bcf7e2 / RELEASE_NOTES changelog players_changelog src/filesystem_boost.cpp: Merge branch 'bug/23753' http://git.io/vWqO5
20151021 02:31:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20151021 02:31:23-!- mjs-de [~mjs-de@f049068080.adsl.alicedsl.de] has quit [Remote host closed the connection]
20151021 02:41:13< vultraz> I have an unrelated question: the unit create dialog is copyrighted by you. Should I leave it that way, claim copyright, or copyright it to the project?
20151021 02:54:05-!- Appleman1234 [~Appleman1@KD111239026140.au-net.ne.jp] has joined #wesnoth-dev
20151021 02:56:20-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20151021 02:57:07-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20151021 02:57:12-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20151021 02:58:23-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 252 seconds]
20151021 02:58:24-!- noy_ is now known as noy
20151021 02:59:10-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151021 03:01:39-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20151021 03:01:39-!- wedge010 is now known as wedge009
20151021 03:09:18< shadowm> vultraz: Leave it as is.
20151021 03:10:09< shadowm> I asked you a question too, still waiting for the answer.
20151021 03:10:20 * vultraz checks logs
20151021 03:11:08< vultraz> shadowm: yes
20151021 03:12:00-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20151021 03:13:22< vultraz> bleh. C:\Users\Charles\Documents\wesnoth-git\src\filesystem_boost.cpp|517|error: 'SHGFP_TYPE_CURRENT' was not declared in this scope|
20151021 03:16:51< vultraz> am I supposed to have _WIN32_IE  defined
20151021 03:17:00< vultraz> or something
20151021 03:18:52-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20151021 03:22:24< shadowm> -D_WIN32_WINNT=0x0501
20151021 03:23:02< vultraz> yes, I have that
20151021 03:23:05< shadowm> vultraz: Commit b756c19dd382ed60939558fa0f853ab660867fb2 .
20151021 03:23:11< shadowm> Are you sure?
20151021 03:24:21< vultraz> it's right here under defines. _WIN32_WINNT=0x0501
20151021 03:26:55-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151021 03:27:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20151021 03:27:23< shadowm> There appears to be a spurious DWINVER=0x0501 in the project.
20151021 03:27:32< shadowm> *define in
20151021 03:27:47< shadowm> Not related, but I thought I'd mention anyway.
20151021 03:27:50-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 250 seconds]
20151021 03:30:01-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151021 03:31:08-!- EliDupree [~quassel@idupree.com] has quit [Remote host closed the connection]
20151021 03:31:15-!- EliDupree [~quassel@idupree.com] has joined #wesnoth-dev
20151021 03:36:17< shadowm> vultraz: The Windows headers supplied by your compiler are buggy, so:
20151021 03:36:45< shadowm> #if (_WIN32_IE >= 0x0500)
20151021 03:36:48< shadowm> Define that.
20151021 03:37:00< shadowm> I mean not literally that, define _WIN32_IE=0x0501.
20151021 03:38:27< vultraz> that works
20151021 03:39:15< vultraz> so DWINVER is not necessary?
20151021 03:40:46< shadowm> Shouldn't be, I've never heard of it and it sounds like someone somehow came up with that by misparsing -DWINVER=0x0501.
20151021 03:41:01< shadowm> (-DFOO defines FOO, not DFOO.)
20151021 03:44:29< irker681> wesnoth: Charles Dang wesnoth:master c7aa47443d20 / projectfiles/CodeBlocks/wesnoth.cbp: CB Project: replaced DWINVER with _WIN32_IE http://git.io/vWq0w
20151021 03:48:04< vultraz> Ok, now, about the unit preview pane: yes. the design in the Unit Create dialog should optimally be reused for the other relevant dialogs as one, once the layout issue gets sorted out
20151021 03:48:10< vultraz> I also need your approval on the design
20151021 03:48:16< shadowm> Test it on 800x480.
20151021 03:48:28 * shadowm ← too lazy to upload the screenshot.
20151021 03:48:55-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20151021 03:49:02< shadowm> Yeah, I don't like the design, but I haven't commented on it because I need to put an actual critique together.
20151021 03:49:03< vultraz> We need to decide whether to widgetize it
20151021 03:49:24< vultraz> And if so, I need your help
20151021 03:51:46-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151021 03:56:30-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20151021 03:56:50-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20151021 04:07:46-!- janebot_ [~Gambot@grickit.us] has quit [Remote host closed the connection]
20151021 04:07:52-!- janebot_ [~Gambot@grickit.us] has joined #wesnoth-dev
20151021 04:09:32-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151021 04:20:42-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 250 seconds]
20151021 04:20:52-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Remote host closed the connection]
20151021 04:33:55-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 244 seconds]
20151021 04:36:04-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151021 04:47:28-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20151021 05:02:31-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151021 05:16:08-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20151021 05:26:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20151021 05:26:54-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20151021 05:27:29-!- Shackra [~Jorge@186.177.2.148] has quit [Read error: Connection reset by peer]
20151021 05:28:29-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151021 05:38:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20151021 05:41:30-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151021 05:49:32-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151021 06:14:59-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 260 seconds]
20151021 06:27:31-!- Kwandulin [~Miranda@p200300760F18C0BB8DB64487C5E79975.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151021 06:33:41-!- Appleman1234 [~Appleman1@KD111239026140.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20151021 06:56:24-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151021 07:00:45-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20151021 07:01:33-!- danni [~quassel@202.173.192.192] has joined #wesnoth-dev
20151021 07:18:27-!- Guest58751 [~c74d3a4eb@2002:4404:712c:0:76de:2bff:fed4:2766] has quit [Ping timeout: 256 seconds]
20151021 07:27:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20151021 07:31:03-!- Appleman1234 [~Appleman1@KD118156250212.au-net.ne.jp] has joined #wesnoth-dev
20151021 07:34:05-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Quit: ChatZilla 0.9.92-rdmsoft [XULRunner 35.0.1/20150122214805]]
20151021 07:48:34< wedge009> Oh, I was wondering what happened to my preferences. Bug #23753 (despite the conflicting commit log messages).
20151021 07:51:28< shadowm> Conflicting?
20151021 07:52:40-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151021 07:53:10< wedge009> shadowm: 80af2f7cdd2dca1f89a9c6cf044c25d79536cbed says it's for #23573.
20151021 07:53:40< shadowm> Okay, that's the only place where I typoed it.
20151021 07:53:56 * shadowm hates numbers.
20151021 07:55:30< shadowm> I did send an email to the devs ML as well earlier.
20151021 07:56:21-!- boucman_work [~jrosen@lns-bzn-47f-62-147-140-162.adsl.proxad.net] has joined #wesnoth-dev
20151021 07:56:21-!- boucman_work [~jrosen@lns-bzn-47f-62-147-140-162.adsl.proxad.net] has quit [Changing host]
20151021 07:56:21-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151021 07:56:23< Rhonda> Yep, hatred for numbers is definitely a plus for working in this field ;)
20151021 07:57:15< wedge009> Should I need to register for that? I thought this dev channel is the primary communication method.
20151021 07:57:18< shadowm> Also love how I somehow got the info in 8f8fde4 backwards.
20151021 07:57:59< shadowm> It's supposed to be *latter* (formerly used) and *former* (newly used), not the other way around.
20151021 07:59:22-!- boucman_2 [~jrosen@lns-bzn-47f-62-147-140-162.adsl.proxad.net] has joined #wesnoth-dev
20151021 07:59:33-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Client Quit]
20151021 07:59:40< shadowm> wedge009: We don't _discuss_ things there very often nowadays, but some important messages (like the prefs dir breakage warning and the low level code freeze on master notice for the SDL 2 port) get posted there when needed to ensure they reach everybody regardless of their presence on IRC.
20151021 07:59:43-!- boucman_2 is now known as boucman_work
20151021 07:59:58-!- boucman_work [~jrosen@lns-bzn-47f-62-147-140-162.adsl.proxad.net] has quit [Changing host]
20151021 07:59:58-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151021 08:00:37< shadowm> There's also the string freeze/feature freeze/stable release/development release notices and occasional discussion of dependency changes.
20151021 08:01:07< wedge009> Fair enough, thanks.
20151021 08:02:57-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev
20151021 08:12:57< shadowm> Oh hey, it looks like I found a code injection bug in Savane. :p
20151021 08:13:07< shadowm> Well, not really code injection, hopefully.
20151021 08:14:17< shadowm> This thing doesn't have a bug tracker itself, seriously?
20151021 08:15:11-!- genbattle [~genbattle@122-57-89-170.jetstream.xtra.co.nz] has joined #wesnoth-dev
20151021 08:28:17< shadowm> wedge009: Defense values are usually defined by movetypes, which are in turn defined in data/core/units.cfg. Note that rails having 0% defense by default is not actually a problem because the terrains as defined in terrain.cfg are actually aliased to both the base terrain and the rails virtual terrain for defense considerations (and flat virtual + rails virtual for movement), with a positive bias (the engine uses the stats of ...
20151021 08:28:24< shadowm> ... whichever aliased terrain favors the unit the most).
20151021 08:29:19< shadowm> So as it is it just happens that no units or movetypes in mainline offer custom defense or move costs on rails.
20151021 08:30:49< shadowm> Also, most of the time rails get used on cave terrains, so the move cost candidates would be rails virtual and cave virtual.
20151021 08:31:45< shadowm> (Virtual terrains are those defined on line 2252 onwards; they never come up in maps and aren't displayed in the editor palettes.)
20151021 08:33:29< shadowm> Either GNU's servers are ludicrously slow or...
20151021 08:39:05< shadowm> Meh, it's not a syntax injection issue, just a liberal use of a stripping function that doesn't make sense in context.
20151021 08:40:41< shadowm> # <one line to give a brief idea of what this does.>
20151021 08:40:55< shadowm> Yeah I can see there was a lot of effort put into maintainability here.
20151021 08:41:41< shadowm> The nonsensical indentation style makes the code look like a jenga tower. Yuck.
20151021 08:42:52< shadowm> Can't wait for it to crumble down so we're left without a working bug tracker and are forced to start from scratch.
20151021 08:52:50< loonycyborg> shadowm: it seems shortcut the installer makes still would pass --config-dir option, with WesnothX.Y as argument.
20151021 08:53:20< loonycyborg> Am I right to think that it's redundant now?
20151021 08:53:32< shadowm> Yes.
20151021 08:53:42< loonycyborg> ok
20151021 09:15:45-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 256 seconds]
20151021 09:17:38-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151021 09:25:45-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 255 seconds]
20151021 09:26:12< vultraz> yay, I can remove that :D
20151021 09:26:17< vultraz> (from my shortcut)
20151021 09:31:05-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151021 09:34:45-!- genbattle [~genbattle@122-57-89-170.jetstream.xtra.co.nz] has quit [Ping timeout: 240 seconds]
20151021 09:36:05-!- subliun [~quassel@unaffiliated/subliun] has quit [Read error: Connection reset by peer]
20151021 09:37:33-!- subliun [~quassel@unaffiliated/subliun] has joined #wesnoth-dev
20151021 09:38:10-!- Appleman1234 [~Appleman1@KD118156250212.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20151021 09:55:19-!- Kwandulin [~Miranda@p200300760F18C0BB8DB64487C5E79975.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151021 10:07:42-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 240 seconds]
20151021 10:11:14< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\editor\map\context_manager.cpp|157|error: cannot convert 'const char*' to 'char**' for argument '1' to 'void SDL_WM_GetCaption(char**, char**)'|
20151021 10:11:15-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151021 10:11:15< vultraz> hmmmm
20151021 10:11:26< vultraz> not sure what ** does
20151021 10:15:14< vultraz> hm... it sets...pointers
20151021 10:22:30-!- aquileia [863cae5e@gateway/web/freenode/ip.134.60.174.94] has joined #wesnoth-dev
20151021 10:25:25< loonycyborg> char** is pointer to a pointer :P
20151021 10:26:11< aquileia> loonycyborg: Who of us should remove UserdataFlags from line 28, 149, 150, 156 of wesnoth.nsi.in, then?
20151021 10:26:44< loonycyborg> I can do it on next release
20151021 10:26:47< vultraz> so, pointer to a pointer, does that mean I need to pass a double pointer?
20151021 10:27:18< aquileia> loonycyborg, shadowm: Great, not having to provide patches between dev and stable releases saves me a lot of trickery in both scripts
20151021 10:27:57< loonycyborg> if you have variable of char* type, say foo then you you need to provide &foo
20151021 10:29:30< aquileia> gfgtdf: The current syntax I plan for the auto-update call is "wesnoth-update.exe /i=1.12.4 /o=1.12.5 /MD5=[MD5sum]", but feel free to rename those parametres as you like.
20151021 10:30:41< vultraz> ah, thanks
20151021 10:31:19< aquileia> loonycyborg: The NSIS patcher script will depend on a few non-default NSIS plugins, I hope you don't mind
20151021 10:31:44< loonycyborg> as long as they're easily installable I don't mind
20151021 10:31:57< aquileia> e.g. the InetC plugin is more robust comparred to the default NSISdl plugin (which e.g. doesn't support https)
20151021 10:32:47< aquileia> It's a simple matter of downloading and extracting them to your NSIS installation
20151021 10:33:20< loonycyborg> ok then, be sure to include links to them in comments or something
20151021 10:34:13-!- irker681 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151021 10:34:54-!- Appleman1234 [~Appleman1@KD111239006229.au-net.ne.jp] has joined #wesnoth-dev
20151021 10:39:07-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds]
20151021 10:43:00< vultraz> blagh
20151021 10:43:18< vultraz> I'm probably misinterpreting how GetCaption works
20151021 10:51:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151021 10:59:24< wedge009> shadowm: Thanks for the explanation. I only had a vague understanding of the defence mechanisms based on what I had played previously. I suppose the question is whether Rails should be included in the Help listing at all, or if we should put something like N/A instead of the misleading 0%.
20151021 11:00:14< aquileia> BTW, it should be simple enough to use binary patches in the future should the need arise - the VPatch plugin even is part of the default NSIS installation
20151021 11:02:43< aquileia> The only hassle is that it only patches one file at a time, so we'd need to iterate over patch.txt instead of just bundling all the files in an archive
20151021 11:23:19-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151021 11:24:06-!- Kwandulin [~Miranda@p200300760F18C0BB144CE4D6F8C890C9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151021 11:26:43-!- irker975 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151021 11:26:43< irker975> wesnoth: aquileia wesnoth:master e22555a107fb / packaging/windows/Wesnoth.nsi.in: Windows Installer: Remove --config-dir from shortcuts http://git.io/vWmpG
20151021 11:28:09< wedge009> shadowm: Ah, it was in units.cfg. Previously I was looking at the individual cfg files inside the units directory. If Rails is the only terrain type without explicit defence values assigned, perhaps it's simplest just to suppress the Rails entry in a unit's Help page? I'll check on it more tomorrow (Thursday) - I suppose the main question is what can/should be done about the issue.
20151021 11:39:43-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151021 12:16:33-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20151021 12:22:26< vultraz> bleh
20151021 12:22:30 * vultraz waits for celticminstral
20151021 12:36:22-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20151021 12:43:35 * aquileia muses whether to include our installer strings (packaging/windows/translations.nsh) in one of the textdomains...
20151021 12:46:12< aquileia> the patch installer will require a few additional translations, e.g. we probably don't have 'patch' and 'Download failed, aborting.'
20151021 12:47:08< aquileia> I may have to resort to a generic 'An error occurred' message (NSIS probably has one)
20151021 13:07:26-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151021 13:10:27-!- mjs-de [~mjs-de@f048194251.adsl.alicedsl.de] has joined #wesnoth-dev
20151021 13:14:28-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20151021 13:15:00-!- aquileia [863cae5e@gateway/web/freenode/ip.134.60.174.94] has quit [Ping timeout: 246 seconds]
20151021 13:24:28-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151021 13:25:03-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20151021 13:27:11-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Client Quit]
20151021 13:28:36 * vultraz waves celticminstrel down
20151021 13:32:37< celticminstrel> 'lo
20151021 13:33:32< vultraz> I have a probably less-complicated than I'm making it question related to pointers
20151021 13:34:06< vultraz> so I'm trying to use void SDL_WM_GetCaption(char **title, char **icon);
20151021 13:34:12< vultraz> er
20151021 13:34:21< vultraz> I;m trying to use that, and that's what the function takes
20151021 13:34:44< vultraz> and I'm trying to get a string that's the current title
20151021 13:35:29< vultraz> so I did char *main_window_title; SDL_WM_GetCaption(&main_window_title, NULL); window_title_ = main_window_title; (window_title_ is a string)
20151021 13:35:32< vultraz> but I just got 'T'
20151021 13:35:33< vultraz> :|
20151021 13:36:52< vultraz> so then I tried std::string *main_window_title; SDL_WM_GetCaption(&main_window_title->c_str(), NULL); but I get context_manager.cpp|158|error: lvalue required as unary '&' operand|
20151021 13:41:42-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151021 13:41:59< celticminstrel> Why are you even using SDL_WM_GetCaption?
20151021 13:42:23< celticminstrel> Shouldn't that just return "Wesnoth"?
20151021 13:43:40< elias> c_str() is const so you can't assign to it
20151021 13:43:49< celticminstrel> The first way you tried was closer.
20151021 13:44:14< vultraz> so I don't have to make a copy of the regular window title'
20151021 13:44:20< celticminstrel> But you need to declare main_window_title in one of these ways:
20151021 13:44:31< celticminstrel> char main_window_title[100];
20151021 13:45:06< celticminstrel> char* main_window_title = new char[100];
20151021 13:45:11< celticminstrel> The first is preferable.
20151021 13:45:17< celticminstrel> 100 is just an arbitrary number.
20151021 13:46:00< celticminstrel> I guess SDL_SW_GetCaption is unsafe.
20151021 13:46:14< celticminstrel> That's annoying, but, oh well...
20151021 13:49:52< vultraz> first method doesn't compile, second does
20151021 13:50:04< vultraz> (first gives error: cannot convert 'char (*)[100]' to 'char**' for argument '1' to 'void SDL_WM_GetCaption(char**, char**)'|)
20151021 13:50:55< elias> SDL might allocate the string for you
20151021 13:51:03< elias> their documentation doesn't really tell
20151021 13:51:19< celticminstrel> That's true...
20151021 13:51:44< elias> in that case your first method would be correct, except maybe there's an encoding problem
20151021 13:51:53< celticminstrel> Ah, hmm.
20151021 13:52:06< celticminstrel> elias has a good point.
20151021 13:52:17< celticminstrel> Maybe the first way you tried was right after all.
20151021 13:52:31< vultraz> but I just get 'T'
20151021 13:52:33< vultraz> :/
20151021 13:52:38< celticminstrel> ...but... why would there be an encoding problem... C has wchar_t doesn't it?
20151021 13:52:43< vultraz> as in, the first character of the title
20151021 13:52:56< elias> maybe it uses UTF16
20151021 13:52:59< celticminstrel> ^
20151021 13:53:07< celticminstrel> That's what I was trying to say, yes.
20151021 13:53:19< celticminstrel> What's the length function for that? wcslen?
20151021 13:53:59< celticminstrel> And C++ has a re-encoder in its library, something like codecvt?
20151021 13:54:20< celticminstrel> It's just weird that it'd be UTF-16 when the type is char.
20151021 13:54:25< celticminstrel> ...actually...
20151021 13:54:45 * vultraz blinks
20151021 13:54:49< celticminstrel> Windows does use UTF-16 for lots of things, so maybe SDL didn't bother converting it.
20151021 13:55:07< celticminstrel> Well, if you don't care about handling Unicode characters, you can just do this:
20151021 13:55:46< celticminstrel> std::copy(main_window_title, main_window_title + wcslen(main_window_title), std::back_inserter(main_window_title2));
20151021 13:55:53< vultraz> o-O
20151021 13:55:55< celticminstrel> Where main_window_title2 is a std::string.
20151021 13:56:12< celticminstrel> Something wrong? :P
20151021 13:56:18< vultraz> so complex
20151021 13:56:23< celticminstrel> Not really?
20151021 13:56:36< celticminstrel> Actually you might have to cast to wchar_t* for wcslen.
20151021 13:57:08< celticminstrel> Also that's assuming it really is UTF-16.
20151021 13:57:22< celticminstrel> It's not the right way of doing it, but it should work as long as it's really only ASCII characters/
20151021 13:57:48< vultraz> so should I use that over the char* main_window_title = new char[100]; method?
20151021 13:58:24< celticminstrel> Sorry, I made a mistake with that.
20151021 13:58:40< vultraz> it does work
20151021 13:58:46< celticminstrel> What does?
20151021 13:58:47< elias> can you look at main_window_title in a debugger, just after the SDL_WM_GetCaption call returns?
20151021 13:58:57< celticminstrel> Oh, using new does.
20151021 13:59:01< elias> oh
20151021 13:59:11< celticminstrel> Wait...
20151021 13:59:23< celticminstrel> Using new works? :S
20151021 13:59:47< celticminstrel> I mean you get the whole title?
20151021 14:00:28< vultraz> yes
20151021 14:00:29< vultraz> this is the commit https://github.com/Vultraz/wesnoth/commit/ac87446519315bc2cf89810624ab0acf65b74e2e
20151021 14:00:34< vultraz> s/this/here
20151021 14:01:19< celticminstrel> :|
20151021 14:03:00< vultraz> hm?
20151021 14:03:56< elias> you leak memory now :P
20151021 14:04:59< vultraz> D:
20151021 14:05:01< vultraz> nuu
20151021 14:05:07< elias> SDL2 has GetWindowTitle it seems
20151021 14:05:38< vultraz> yes but Aginor hasn't finished transitioning to sdl2
20151021 14:05:49< vultraz> so I have to use SDL1.2 still :|
20151021 14:06:00< vultraz> (I hope SDL2 has a nicer interface for this)
20151021 14:07:08< elias> anyway, does it work with char main_window_title[100]; instead of the new? then the memory gets freed...
20151021 14:08:51< vultraz> [00:49:59]	vultraz	(first gives error: cannot convert 'char (*)[100]' to 'char**' for argument '1' to 'void SDL_WM_GetCaption(char**, char**)'|)
20151021 14:09:08< elias> ah, yes
20151021 14:13:01< vultraz> can't I manually free the memory?
20151021 14:14:24< celticminstrel> You could try.
20151021 14:14:32< celticminstrel> delete[] main_window_title
20151021 14:14:43< celticminstrel> But I don't know if that'll really free it.
20151021 14:15:12< celticminstrel> Because it's entirely possible that SDL will make your pointer point to a completely different block of memory that contains the string.
20151021 14:16:04< vultraz> D:
20151021 14:20:17-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151021 14:20:42-!- gfgtdf [~chatzilla@f054157239.adsl.alicedsl.de] has joined #wesnoth-dev
20151021 14:24:43< gfgtdf> vultraz: why do you even need the new? Wouldnt "char* main_window_title;" just work?
20151021 14:25:03< vultraz> Without the size it just returns 'T'
20151021 14:25:07< vultraz> with the size it errors
20151021 14:25:28-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind1]
20151021 14:25:35-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151021 14:25:46-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151021 14:26:03< gfgtdf> vultraz: hmm y i cannot really find a documentation of SDL_WM_GetCaption so i dont really know how it works
20151021 14:26:37< celticminstrel> I wouldn't be surprised if it's just returning a pointer that it got back from WinAPI, which honestly is a stupid thing to do.
20151021 14:26:51< vultraz> :(
20151021 14:26:52< celticminstrel> vultraz: Since this is SDL1.2, I suggest just giving up on it.
20151021 14:26:58< vultraz> yeah
20151021 14:27:02< vultraz> we're switching soon anyway
20151021 14:27:07-!- irker975 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151021 14:27:08< vultraz> shadowm: abandoning effort
20151021 14:28:59< vultraz> shadowm: unless you can find a better way to do this
20151021 14:29:04< vultraz> this = https://github.com/Vultraz/wesnoth/commit/ac87446519315bc2cf89810624ab0acf65b74e2e
20151021 14:29:14-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Client Quit]
20151021 14:29:19-!- Kwandulin [~Miranda@p200300760F18C0BB144CE4D6F8C890C9.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20151021 14:29:32-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151021 14:30:30< celticminstrel> I think it might actually count as a bug in SDL.
20151021 14:31:52< celticminstrel> Hmm. Actually, vultraz, I don't think you need to "save" the window title at all.
20151021 14:32:00< gfgtdf> celticminstrel: so whats the error in that current code ?
20151021 14:32:39-!- Kwandulin [~Miranda@p200300760F18C08E144CE4D6F8C890C9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151021 14:32:41< celticminstrel> Because the title before entering the editor is fixed.
20151021 14:33:06< celticminstrel> It will always be "Battle for Wesnoth" or something similar.
20151021 14:34:25< vultraz> celticminstrel: shadowm said I should avoid that
20151021 14:34:31 * vultraz shrugs
20151021 14:35:08< celticminstrel> I see.
20151021 14:35:31< celticminstrel> Well, if I were to do it, I'd have a function somewhere that returns the standard window title.
20151021 14:38:49< vultraz> yeah, that'd be simple
20151021 14:39:00-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20151021 14:39:00-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20151021 14:39:00-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151021 14:39:05< vultraz> maybe in display::?
20151021 14:39:07< vultraz> or something
20151021 14:39:17< vultraz> i dunno, it's not really a function that needs to be in a namespace
20151021 14:39:22< vultraz> or class
20151021 14:40:05< gfgtdf> vultraz: are yout still wokring on https://github.com/wesnoth/wesnoth/pull/525 ?
20151021 14:40:51< vultraz> gfgtdf: oh, I forgot to readd the exception code
20151021 14:41:00< vultraz> gfgtdf: but then shadowm has to review it
20151021 14:41:15< vultraz> he said he wants to test thoroughly 
20151021 14:46:47-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Remote host closed the connection]
20151021 14:53:56-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151021 14:56:53-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind1]
20151021 15:01:19-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has quit [Ping timeout: 240 seconds]
20151021 15:22:15-!- prkc [~prkc@catv-89-134-159-103.catv.broadband.hu] has joined #wesnoth-dev
20151021 16:00:00-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151021 16:08:42-!- juiniy [05fe9084@gateway/web/freenode/ip.5.254.144.132] has joined #wesnoth-dev
20151021 16:10:39-!- juiniy [05fe9084@gateway/web/freenode/ip.5.254.144.132] has quit [Client Quit]
20151021 17:15:02-!- Kwandulin [~Miranda@p200300760F18C08E144CE4D6F8C890C9.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20151021 17:16:53-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev
20151021 17:26:13-!- Kwandulin [~Miranda@p200300760F18C08E144CE4D6F8C890C9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151021 17:26:29-!- Polsaker [~Polsaker@wikimedia/botters.Polsaker] has quit [Ping timeout: 240 seconds]
20151021 17:27:57-!- Polsaker [~Polsaker@wikimedia/botters.Polsaker] has joined #wesnoth-dev
20151021 17:32:11-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151021 17:40:15-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151021 17:44:42-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 268 seconds]
20151021 17:44:43-!- wedge010 is now known as wedge009
20151021 17:45:58-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has quit [Ping timeout: 244 seconds]
20151021 17:46:06-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20151021 17:47:03-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151021 17:49:04-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151021 17:52:23-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20151021 17:58:21-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20151021 18:03:52-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151021 18:03:52-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151021 18:04:37-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151021 18:17:44-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind1]
20151021 18:18:23-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 246 seconds]
20151021 18:38:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20151021 18:50:21-!- Appleman1234 [~Appleman1@KD111239006229.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20151021 18:55:54-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151021 19:05:27-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151021 19:19:58-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 240 seconds]
20151021 19:35:09-!- danni [~quassel@202.173.192.192] has quit [Ping timeout: 250 seconds]
20151021 19:36:57-!- danni [~quassel@202.173.192.192] has joined #wesnoth-dev
20151021 19:48:03-!- Appleman1234 [~Appleman1@KD118156244075.au-net.ne.jp] has joined #wesnoth-dev
20151021 19:54:50-!- oldlaptop [~quassel@50.36.238.180] has quit [Ping timeout: 240 seconds]
20151021 19:58:41-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20151021 20:03:10-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151021 20:26:18-!- janebot_ [~Gambot@grickit.us] has quit [Remote host closed the connection]
20151021 20:26:24-!- janebot_ [~Gambot@grickit.us] has joined #wesnoth-dev
20151021 20:33:18-!- oldlaptop [~quassel@50-107-101-165.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20151021 20:46:07-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20151021 20:46:07-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20151021 20:46:07-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151021 20:51:08-!- janebot_ [~Gambot@grickit.us] has quit [Remote host closed the connection]
20151021 20:51:14-!- janebot_ [~Gambot@grickit.us] has joined #wesnoth-dev
20151021 20:52:57-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Remote host closed the connection]
20151021 21:13:20-!- Kwandulin [~Miranda@p200300760F18C08E144CE4D6F8C890C9.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151021 21:22:43-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151021 21:33:25-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Remote host closed the connection]
20151021 21:34:31-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 265 seconds]
20151021 21:39:02-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151021 21:51:45-!- mjs-de [~mjs-de@f048194251.adsl.alicedsl.de] has quit [Remote host closed the connection]
20151021 21:57:59-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20151021 22:08:47-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev
20151021 22:13:33-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151021 22:27:24-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 255 seconds]
20151021 22:44:23-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151021 22:48:10-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20151021 23:02:48-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Quit: tomreyn]
20151021 23:09:37-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151021 23:11:04-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Remote host closed the connection]
20151021 23:11:46-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20151021 23:11:46-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20151021 23:11:46-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151021 23:15:11-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Read error: Connection reset by peer]
20151021 23:40:58-!- gfgtdf [~chatzilla@f054157239.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0.2/20151014143721]]
20151021 23:44:56-!- danni [~quassel@202.173.192.192] has quit [Ping timeout: 246 seconds]
20151021 23:46:51-!- danni [~quassel@202.173.192.192] has joined #wesnoth-dev
20151021 23:49:50-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Remote host closed the connection]
20151021 23:53:09-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151021 23:59:26-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
--- Log closed Thu Oct 22 00:00:45 2015