--- Log opened Mon Oct 26 00:00:25 2015 20151026 00:08:33-!- irker234 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20151026 00:14:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20151026 00:15:46-!- EliDupree [~quassel@idupree.com] has quit [Remote host closed the connection] 20151026 00:15:53-!- EliDupree [~quassel@idupree.com] has joined #wesnoth-dev 20151026 00:16:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20151026 00:24:58-!- EliDupree [~quassel@idupree.com] has quit [Remote host closed the connection] 20151026 00:25:05-!- EliDupree [~quassel@idupree.com] has joined #wesnoth-dev 20151026 00:35:51-!- trewe [~trewe@2001:8a0:d111:ae01:626c:66ff:fe92:9b7c] has quit [Quit: quit] 20151026 00:36:10-!- EliDupree [~quassel@idupree.com] has quit [Remote host closed the connection] 20151026 00:36:17-!- EliDupree [~quassel@idupree.com] has joined #wesnoth-dev 20151026 00:37:36-!- EliDupree [~quassel@idupree.com] has quit [Remote host closed the connection] 20151026 00:37:43-!- EliDupree [~quassel@idupree.com] has joined #wesnoth-dev 20151026 00:47:52-!- EliDupree [~quassel@idupree.com] has quit [Remote host closed the connection] 20151026 00:47:59-!- EliDupree [~quassel@idupree.com] has joined #wesnoth-dev 20151026 00:52:07-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!] 20151026 01:10:04-!- EliDupree [~quassel@idupree.com] has quit [Remote host closed the connection] 20151026 01:10:11-!- EliDupree [~quassel@idupree.com] has joined #wesnoth-dev 20151026 01:14:17-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev 20151026 01:14:47-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20151026 01:18:22< vultraz> gfgtdf: the change does not break existing scenarios. the team_name/user_team_name configuration just gets converted to team_id/team_name if it appears 20151026 01:19:01< celticminstrel> Actually, it could break existing scenarios. 20151026 01:19:24< celticminstrel> How does it know whether team_name is the ID or the display name? 20151026 01:20:56< vultraz> guess I need an extra condition 20151026 01:21:15< celticminstrel> Are you going to answer the question? 20151026 01:21:42< vultraz> team_id = cfg["team_name"].empty() ? && !cfg["user_team_name"] ? cfg["team_id"].str() : cfg["team_name"]; 20151026 01:21:59< vultraz> that sound make sure it knows whether to use legacy or new 20151026 01:22:05< celticminstrel> ...... 20151026 01:22:16< celticminstrel> There's not way that could possibly ever work. 20151026 01:22:19< celticminstrel> ^no way 20151026 01:23:03 * vultraz needs coffee (metaphorically) 20151026 01:23:03< celticminstrel> Oh wait, let me read it again. 20151026 01:23:16< celticminstrel> Ah... 20151026 01:23:21< celticminstrel> That's not valid C++. 20151026 01:23:36< celticminstrel> There's two ?'s but only one : 20151026 01:23:44< vultraz> oh remove the first ? 20151026 01:23:45< vultraz> sorry 20151026 01:23:50< celticminstrel> Okay. 20151026 01:24:16< celticminstrel> That firat ? was a large reason for my initial reaction, so now I have to re-evaluate it... 20151026 01:24:50< celticminstrel> ^first 20151026 01:25:06< celticminstrel> So, if team_name is empty or unspecified, and user_team_name is... hmm. 20151026 01:25:16< celticminstrel> Does operator! call blank() or to_bool()? 20151026 01:25:37< vultraz> probably should specify one I guess 20151026 01:26:17< celticminstrel> So it looks like if both team_name and user_team_name are unspecified, then it uses team_id... yeah, okay, it's still not gonna work. 20151026 01:27:00< celticminstrel> In other words, with that logic, it's impossible to specify a display name using the new syntax. 20151026 01:27:28< vultraz> ugh, I had this logic worked out in my head last night >_> 20151026 01:27:31< celticminstrel> And I don't think there's any way you can write it that guarantees no scenario is broken. 20151026 01:28:29< celticminstrel> The logic I recommend is, if user_team_name is present, use old style; if team_id is present, use new style. 20151026 01:28:35< celticminstrel> However, what if neither are present? 20151026 01:29:30< celticminstrel> Hmm, actually, I think I have a solution for that case. If only team_name is present, then set both team_name and team_id to that value. I think that should avoid breaking old scenarios, though it'll slightly change their behaviour. 20151026 01:29:42< celticminstrel> (But the scenarios broken will probably be few, anyway.) 20151026 01:30:10< celticminstrel> When I say "present", I mean you test blank() 20151026 01:30:15< vultraz> the thing is I did test with the old syntax and it gets translated to the new syntax correctly 20151026 01:30:17< celticminstrel> Not empty() 20151026 01:30:43< celticminstrel> Yeah, the problem with your logic is that the new syntax won't work. :P 20151026 01:32:54< vultraz> ah, I see. apparently I was too focused on keeping compatibility that I broke the new syntax xD 20151026 01:34:48< vultraz> what about this 20151026 01:34:50< vultraz> team_id = cfg["user_team_name"].empty() ? cfg["team_id"].str() : cfg["team_name"]; 20151026 01:35:06< celticminstrel> blank, not empty 20151026 01:35:23< celticminstrel> Otherwise, yes, that looks fine, I think. 20151026 01:36:07< vultraz> should i also use blank() for the team_name check? 20151026 01:37:26< celticminstrel> Yes. 20151026 01:37:32< celticminstrel> blank() means it doesn't exist 20151026 01:37:47< celticminstrel> empty() means either it doesn't exist or it was set to an empty string 20151026 01:38:28< vultraz> aaahhhhhh 20151026 01:38:34-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20151026 01:38:37< vultraz> good to know for future reference 20151026 01:38:48< celticminstrel> I just hope I didn't get them backwards. >_> 20151026 01:38:53< celticminstrel> Pretty sure that's right though. 20151026 01:39:20< vultraz> yes that works 20151026 01:40:59 * celticminstrel suggests testing it in five different ways - just one key (team_id, team_name, user_team_name), both keys old way, both keys new way. 20151026 01:46:50< vultraz> behavior seems as expected 20151026 01:47:53-!- irker128 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20151026 01:47:53< irker128> wesnoth: Charles Dang wesnoth:master 1215f65eb875 / src/team.cpp: Fixed team_id/team_name not being set correctly in new format http://git.io/vWwZF 20151026 01:47:54< irker128> wesnoth: Charles Dang wesnoth:master 545253ec2b11 / src/team.cpp: Don't warn that user_team_name is unrecognized (yet) http://git.io/vWwZN 20151026 02:00:21< vultraz> I'd like to add a deprecation warning but zookeeper might not approve... 20151026 02:00:55< celticminstrel> Why wouldn't he... 20151026 02:02:18< vultraz> he dislikes deprecating minor things like this 20151026 02:03:09< celticminstrel> Well, there's the whole "don't fix what's not broken" thing that you've violated. 20151026 02:03:21-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-rbcpswwhkixpwevt] has quit [Ping timeout: 268 seconds] 20151026 02:03:28< vultraz> indeed :P 20151026 02:03:31< celticminstrel> I think it's not so bad in this case as it might've been in the attacks case. 20151026 02:03:43< vultraz> but it's definitely a reasonable change 20151026 02:03:44< celticminstrel> Because attacks are something that's more likely to be directly referenced by WML code, I think. 20151026 02:03:56< celticminstrel> Mind you, this could also be directly referenced by WML code. 20151026 02:04:08< celticminstrel> There is [store_side], after all. 20151026 02:09:08-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-ljkfymqkbsexjhlg] has joined #wesnoth-dev 20151026 02:09:32-!- matthiaskrgr is now known as Guest87606 20151026 02:11:52< vultraz> eh, true 20151026 02:12:10< vultraz> I suppose I *could* have added team_id as another key but I think it would have just confused things 20151026 02:12:24< celticminstrel> I think it's fine now that it's been done. 20151026 02:12:30< vultraz> because team_name would have had to mean different things 20151026 02:12:34< vultraz> so yeah 20151026 02:12:52< vultraz> anyway I figure we might as well go nuts with the syntax changes now as opposed to later in 1.13 or in 1.15 20151026 02:13:02< vultraz> (which probably won't happen) 20151026 02:13:29< vultraz> we've already done a good bunch 20151026 02:13:55< vultraz> any others you can think of? 20151026 02:14:01< celticminstrel> But when it's literally just changing the name of a key, I think there's usually no point. 20151026 02:14:16< celticminstrel> I can't think of any right now. 20151026 02:30:14-!- travis-ci [~travis-ci@ec2-54-224-159-140.compute-1.amazonaws.com] has joined #wesnoth-dev 20151026 02:30:15< travis-ci> wesnoth/wesnoth#7710 (master - 545253e : Charles Dang): The build was broken. 20151026 02:30:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/87385276 20151026 02:30:15-!- travis-ci [~travis-ci@ec2-54-224-159-140.compute-1.amazonaws.com] has left #wesnoth-dev [] 20151026 02:30:45< celticminstrel> Ah? Is that your fault? 20151026 02:31:57< vultraz> dfhwefuiwcnioejdcwjheciohnwec 20151026 02:32:28< vultraz> it's annoying because travis functions with different parameters than my compiler 20151026 02:32:43< vultraz> so I have no idea if something that builds for me will break for it 20151026 02:32:53< celticminstrel> It was a compiler error? 20151026 02:33:40< celticminstrel> It wasn't a compile error. 20151026 02:33:40< vultraz> trying to find... 20151026 02:34:03< vultraz> (it still applies anyway since for example, it runs the unit tests) 20151026 02:34:19< celticminstrel> And you don't run them, correct? 20151026 02:34:23< vultraz> right 20151026 02:36:21< vultraz> ok, some tests failed 20151026 02:37:57< vultraz> but why have they failed.. 20151026 02:40:00< vultraz> lemme try updating the keys 20151026 02:40:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20151026 02:41:11< irker128> wesnoth: Charles Dang wesnoth:master e948df342465 / data/test/ (6 files in 2 dirs): Updated unit tests to use new team id/name syntax http://git.io/vWwEo 20151026 03:08:56-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 244 seconds] 20151026 03:11:01-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20151026 03:18:38-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20151026 03:21:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds] 20151026 03:21:06-!- wedge010 is now known as wedge009 20151026 03:23:32-!- travis-ci [~travis-ci@ec2-54-227-106-132.compute-1.amazonaws.com] has joined #wesnoth-dev 20151026 03:23:33< travis-ci> wesnoth/wesnoth#7711 (master - e948df3 : Charles Dang): The build was fixed. 20151026 03:23:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/87388777 20151026 03:23:33-!- travis-ci [~travis-ci@ec2-54-227-106-132.compute-1.amazonaws.com] has left #wesnoth-dev [] 20151026 03:40:24-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20151026 04:07:46-!- iceiceice [~chris@nat-tvwna-outside-visitornet2-a-160.princeton.org] has joined #wesnoth-dev 20151026 04:07:46-!- iceiceice [~chris@nat-tvwna-outside-visitornet2-a-160.princeton.org] has quit [Changing host] 20151026 04:07:46-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20151026 04:13:25< wedge009> vultraz: shadowm: What's going on with the hot-key/1.12 business? 20151026 04:13:46< wedge009> Also, Aginor is in NZ, which is currently UTC+1300. Yes, 13, not 12. 20151026 04:14:09< shadowm> The backport breaks the hotkey defaults for Load Game. 20151026 04:14:11< celticminstrel> Heh. 20151026 04:15:03< wedge009> Which one are we talking about, letting Load Game work in the title screen? 20151026 04:15:18< shadowm> Yes. 20151026 04:16:16-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20151026 04:45:10-!- Appleman1234 [~Appleman1@KD111239001011.au-net.ne.jp] has quit [Ping timeout: 246 seconds] 20151026 05:14:34-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20151026 05:23:44-!- janebot_ [~Gambot@grickit.us] has quit [Remote host closed the connection] 20151026 05:23:50-!- janebot_ [~Gambot@grickit.us] has joined #wesnoth-dev 20151026 05:30:52-!- Kwandulin [~Miranda@p200300760F18C0CDED45D79BA070FD0B.dip0.t-ipconnect.de] has joined #wesnoth-dev 20151026 05:41:54-!- Appleman1234 [~Appleman1@KD111239028050.au-net.ne.jp] has joined #wesnoth-dev 20151026 05:42:07-!- irker128 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20151026 05:51:18< wedge009> shadowm: I didn't look at 1.12 previously - I didn't know it had been rewritten for 1.13. From what I can tell from the code and your earlier discussion, it looks like 1.12 cannot include more than one scope. Do we want to make the effort of adding this to 1.12? 20151026 05:53:57-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20151026 05:54:25< Aginor> hi all, as wedge009, I'm currently GMT+13 20151026 05:54:33< vultraz> oh wow 20151026 05:54:36< vultraz> I'm GMT+11 20151026 05:54:38< vultraz> :D 20151026 05:55:06< Aginor> I'm usually around at some points during my evenings, when exactly depends on how much other things I have on at the time 20151026 05:55:21< Aginor> but 21:00 around my time is usually a safe bet 20151026 05:58:12< Aginor> can someone do me the favour of muting the commit-bit a bit? - I'm about to merge so I can get hotkey changes into the sdl2 branch 20151026 05:58:55< shadowm> wedge009: Probably not. If there isn't an easy fix then we might as well revert it on 1.12. 20151026 05:59:11< Aginor> shadowm: can you mute the bot please? 20151026 06:00:01-!- mode/#wesnoth-dev [+q irker*!*@*] by ChanServ 20151026 06:00:02< shadowm> Aginor: Done. 20151026 06:00:13-!- mode/#wesnoth-dev [+o shadowm] by ChanServ 20151026 06:00:16-!- mode/#wesnoth-dev [+z] by shadowm 20151026 06:00:40-!- irker612 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20151026 06:01:10< Aginor> shadowm, wedge009, gfgtdf, vultraz: I think it would be useful if you tested and did changes against the sdl2 branch as opposed to master for 1.13.x. 20151026 06:01:26< Aginor> shadowm, wedge009, gfgtdf, vultraz: I think it would be useful if you tested and did changes against the sdl2 branch as opposed to master for hotkeys on 1.13.x. 20151026 06:01:45< wedge009> shadowm: I don't see it in 1.12, actually. :S 20151026 06:02:55< wedge009> Aginor: I've put hot-key changes against sdl2 unless they aren't affected by your rewrite. The one in question relates to hot-key scope - for Load Game, to be specific - and I believe this is independent of the sdl2 rewrite. 20151026 06:03:17< vultraz> wedge009: I'd say revert for 1.12 20151026 06:03:33< wedge009> Sure, go ahead. 20151026 06:03:41< wedge009> As long as it's in there eventually. (: 20151026 06:04:10< vultraz> merge is done 20151026 06:04:11< Aginor> wedge009: yes, I agree with your specific commit being rewrite agnostic, but I was making a general statement to make sure that testing is done on the right branch :) 20151026 06:04:16< vultraz> unquiet the bot! 20151026 06:04:53 * wedge009 prepared to be steamrollered by bot messages 20151026 06:07:34< Aginor> shadowm: thank you :) 20151026 06:07:49 * Aginor is nor reviewing PR539 20151026 06:07:53< Aginor> now even 20151026 06:10:38-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev 20151026 06:12:13-!- Shackra_ [~Jorge@186.177.2.148] has quit [Ping timeout: 252 seconds] 20151026 06:16:42<@shadowm> Sorry, had to go check on some noise. 20151026 06:17:27-!- mode/#wesnoth-dev [-qbzo irker*!*@* *!*@wesnoth/developer/fendrin shadowm] by shadowm 20151026 06:18:04< shadowm> wedge009: I t is in 1.12. 20151026 06:18:36< shadowm> wedge009: https://github.com/wesnoth/wesnoth/commit/ae9d4687fd4c0c08d9622317c45b43fe05461f5a 20151026 06:18:59< shadowm> vultraz: By the way, don't do that "manual backport" thing, at least use `git commit -C` to reuse the commit message and authorship if you won't use cherry-pick. 20151026 06:19:24< wedge009> shadowm: Yeah, I just realised I was looking at wedge009/1.12 again. x.x 20151026 06:19:32< vultraz> git commit -C? 20151026 06:19:46< shadowm> vultraz: Yes, I said that. 20151026 06:20:28< vultraz> I don't know how to commit -C with TGit 20151026 06:20:37< shadowm> Step 1: Don't use TGit. 20151026 06:20:43< wedge009> shadowm: vultraz: Yep, looks like it's not worth it for 1.12. 20151026 06:20:46< wedge009> Hey! :p 20151026 06:21:02< wedge009> I use as well, but fall back to the command-line when necessary. 20151026 06:21:06< shadowm> Okay leaving the revert to vultraz. 20151026 06:21:42< Aginor> I'm happy with PR#539 and I'll merge if nobody objects 20151026 06:21:48< wedge009> Given what you said about it being confused about the Ctrl+o combination being in both game and main menu. 20151026 06:22:54< shadowm> wedge009: Yeah, that's a secondary thing. The primary regression is the fact that it no longer has a default binding on 1.12 for some weird reason. 20151026 06:23:10< irker612> wesnoth: Charles Dang wesnoth:1.12 cd326abaede4 / src/hotkey/hotkey_command.cpp: Revert "Manual backport of 4d8bcf6a5841 from master" http://git.io/vWwpI 20151026 06:23:10< shadowm> It might well be related to the same secondary thing for all I know. 20151026 06:23:10< Aginor> from a usability point of view I think that it's confusing as well, but I think that has more with how to do with how it's presented in the dialog 20151026 06:25:27< wedge009> I just read the description for #539. I don't understand... doesn't Ctrl+o already work for both Load Game and Load Map? (In their respective game and editor contexts) 20151026 06:25:57< wedge009> I just tested that yesterday when I added the scope for Ctrl+o to be available in main menu as well. 20151026 06:26:11 * Aginor tests without PR539 20151026 06:27:37-!- travis-ci [~travis-ci@ec2-54-166-88-226.compute-1.amazonaws.com] has joined #wesnoth-dev 20151026 06:27:38< travis-ci> wesnoth/wesnoth#7712 (sdl2 - 1890e94 : Andreas Löf): The build was broken. 20151026 06:27:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/87400698 20151026 06:27:38-!- travis-ci [~travis-ci@ec2-54-166-88-226.compute-1.amazonaws.com] has left #wesnoth-dev [] 20151026 06:27:47< Aginor> without the PR I cannot have them both manually assigned to both. Steps to reproduce: 1. clear both hotkeys 2. assign hotkey #1, 3. Attempt to assign hotkey #2 20151026 06:28:10< wedge009> Oh, okay. But by default, don't they both have Ctrl+o? 20151026 06:28:27< Aginor> yes 20151026 06:28:33< wedge009> Ah, so that's why it worked. 20151026 06:28:39< wedge009> Then sure, go ahead and merge if it fixes that. 20151026 06:29:08 * wedge009 looks pointedly at travis whingeing again. 20151026 06:29:18< Aginor> yeah 20151026 06:29:28< wedge009> What happened? Somebody set up us the bomb? 20151026 06:29:28< Aginor> I am displeased 20151026 06:29:49< Aginor> src/editor/map/context_manager.cpp:1028:21: error: unused variable ‘wm_title_string’ [-Werror=unused-variable] 20151026 06:29:52< Aginor> const std::string& wm_title_string = map_name + " - " + default_window_title_; 20151026 06:30:05-!- daMark [5439aa5b@gateway/web/freenode/ip.84.57.170.91] has joined #wesnoth-dev 20151026 06:32:06< Aginor> I need to look into my build settings, my compile isn't picking up on that 20151026 06:45:52-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20151026 06:56:43< Aginor> vultraz: https://github.com/wesnoth/wesnoth/commit/b8a9017aaa478c0bb69d4e14f047917dece95d56 broke SDL2 20151026 06:57:17< vultraz> how? 20151026 06:57:31< Aginor> src/editor/map/context_manager.cpp 20151026 06:57:51< Aginor> changes on line 1028, turning the variable unused in SDL2 20151026 06:58:02< Aginor> resulting in a compile failure 20151026 06:58:19< vultraz> blagh 20151026 06:58:22< vultraz> what do you advise 20151026 06:58:29< vultraz> adding sdl2's setter? 20151026 06:58:51< Aginor> yeah, call window->set_title() 20151026 06:59:04< Aginor> but I doubt that class has a reference to twindow 20151026 06:59:29< vultraz> twindow? 20151026 06:59:58 * Aginor boots eclipse 20151026 07:00:06-!- cib0 [~cib@p508BC25E.dip0.t-ipconnect.de] has joined #wesnoth-dev 20151026 07:01:00< Aginor> vultraz: src/sdl/window.?pp 20151026 07:01:10< Aginor> the twindow class 20151026 07:01:19< vultraz> ah 20151026 07:01:36< vultraz> and this different from the display class 20151026 07:01:43< Aginor> yes 20151026 07:02:51 * vultraz is not sure how to initialize a class reference 20151026 07:03:51< Aginor> vultraz: video has the set_window_title function that will do the right thing 20151026 07:04:01< Aginor> you can access that from editor_display 20151026 07:04:11< Aginor> or just display 20151026 07:04:28< Aginor> in SDL > 2 20151026 07:04:45< vultraz> ok, so... the editor display is gui_ there 20151026 07:04:51< Aginor> yes 20151026 07:05:05< vultraz> so gui_->set_window_title(wm_title_string.c_str()); ? 20151026 07:05:36< Aginor> gui_.video(set_window_title(wm_title_string.c_str())); 20151026 07:05:44< vultraz> oh 20151026 07:05:45< vultraz> ok 20151026 07:05:57< Aginor> inside a big #else for the SDL2 check 20151026 07:06:05< vultraz> should I commit to the sdl2 branch? 20151026 07:06:24< Aginor> compile and test first, then you're welcome to 20151026 07:06:37-!- daMark [5439aa5b@gateway/web/freenode/ip.84.57.170.91] has left #wesnoth-dev [] 20151026 07:06:47< vultraz> i don't have a working sdl2 build 20151026 07:06:56< vultraz> i'm waiting for the merge to deal with that... :P 20151026 07:07:12< Aginor> there's no time like the present 20151026 07:07:26< vultraz> im a little busy right now 20151026 07:07:38< vultraz> i can deal with it later this evening, hopefully 20151026 07:07:50< Aginor> fair enough 20151026 07:09:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20151026 07:10:35< vultraz> also have to remember to upgrade to boost 59 20151026 07:10:43< vultraz> 1.59* 20151026 07:10:50< vultraz> current building against 1.58 20151026 07:14:39-!- Kwandulin_2 [~Miranda@p200300760F18C0CD34E2287B4262D62F.dip0.t-ipconnect.de] has joined #wesnoth-dev 20151026 07:14:58-!- Kwandulin [~Miranda@p200300760F18C0CDED45D79BA070FD0B.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 20151026 07:16:55< wedge009> Aginor: Strange, I don't seem to be running into problems with my sdl2 branch build. Windows or Linux. O.O 20151026 07:31:12-!- Guest87606 [matthiaskr@gateway/shell/panicbnc/x-ljkfymqkbsexjhlg] has quit [Changing host] 20151026 07:31:12-!- Guest87606 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20151026 07:31:12-!- Guest87606 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host] 20151026 07:31:12-!- Guest87606 [matthiaskr@gateway/shell/panicbnc/x-ljkfymqkbsexjhlg] has joined #wesnoth-dev 20151026 07:31:23-!- Guest87606 is now known as matthiaskrgr 20151026 07:33:16< Aginor> wedge009: neither am I, it's only caught by travis 20151026 07:33:26< Aginor> it's annoying me 20151026 07:33:35< wedge009> Oh okay. Well. That's even more strange then. 20151026 07:35:06-!- cib0 [~cib@p508BC25E.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds] 20151026 07:36:03< Aginor> even when re-running the same command from travis 20151026 07:47:35< vultraz> Aginor: travis is set to catch warnings as errors 20151026 07:47:52< vultraz> unused variables are warnings 20151026 07:47:54< vultraz> so it errors out 20151026 07:50:16-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20151026 07:50:27< Aginor> vultraz: I'm not getting the warnings locally. 20151026 07:50:37< Aginor> that's what concerns me 20151026 07:54:52< vultraz> do you have the unused variable compiler flag? 20151026 07:56:16-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20151026 07:57:08< Aginor> vultraz: I'd expect scons to provide me with that as a part of running the same command line as travis 20151026 07:57:29< Aginor> (where I've copy-pasted the arguments from travis) 20151026 07:57:59< Aginor> g++ -o build/release/actions/undo_recruit_action.o -c -std=c++98 -pthread -W -Wall -Werror -Wno-unused-local-typedefs -O2 -O0 20151026 07:58:02< Aginor> so yes. 20151026 08:02:27< vultraz> huh 20151026 08:07:23< Aginor> I suspect this is coming down to gcc versions or something silly like that 20151026 08:13:53< Aginor> even compiling the file manually doesn't give me the warning 20151026 08:14:07< Aginor> although enabling -pedantic is... interesting 20151026 08:29:08< irker612> wesnoth: Andreas Löf wesnoth:sdl2 c89f1620e185 / src/editor/map/context_manager.cpp: Update window title for the editor under SDL2 too http://git.io/vWrs1 20151026 08:29:30< Aginor> vultraz: ^ 20151026 08:29:34< Aginor> fixed it 20151026 08:29:49< irker612> wesnoth: gfgtdf wesnoth:master 63f3f552e747 / src/hotkey/hotkey_preferences_display.cpp: fix preferences dialog for loadgame hotkey http://git.io/vWVo2 20151026 08:29:50< vultraz> CVideo, eh 20151026 08:29:51< irker612> wesnoth: Andreas wesnoth:master 9acd9bfebdc1 / src/hotkey/hotkey_preferences_display.cpp: Merge pull request #539 from wesnoth/gfgtdf-patch-2 http://git.io/vWrsF 20151026 08:30:08< Aginor> I realised it was not tied to an instance 20151026 08:33:10-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev 20151026 08:33:22-!- cib0 [~cib@132.231.178.10] has joined #wesnoth-dev 20151026 08:35:06< vultraz> Aginor: thanks for working on that 20151026 08:45:03< Aginor> vultraz: easy fix 20151026 08:45:21< Aginor> I am still confused as to why I'm not seeing the warning myself though 20151026 08:52:34-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev 20151026 09:11:03-!- travis-ci [~travis-ci@ec2-54-227-106-132.compute-1.amazonaws.com] has joined #wesnoth-dev 20151026 09:11:04< travis-ci> wesnoth/wesnoth#7714 (sdl2 - c89f162 : Andreas Löf): The build was fixed. 20151026 09:11:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/87412745 20151026 09:11:04-!- travis-ci [~travis-ci@ec2-54-227-106-132.compute-1.amazonaws.com] has left #wesnoth-dev [] 20151026 09:13:48-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 268 seconds] 20151026 09:21:19-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev 20151026 09:24:19-!- joet [~joet@host86-191-22-102.range86-191.btcentralplus.com] has joined #wesnoth-dev 20151026 09:24:29-!- mjs-de [~mjs-de@x4db6a2f9.dyn.telefonica.de] has joined #wesnoth-dev 20151026 09:33:35< Aginor> does anyone know where the code that deals with the minimap that's shown when joining a MP game is located? 20151026 09:33:42< Aginor> in the select faction screen 20151026 09:36:22-!- cib0 [~cib@132.231.178.10] has quit [Ping timeout: 246 seconds] 20151026 09:45:34-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20151026 09:45:36< wedge009> There's a mini-map shown? I don't remember that. 20151026 09:45:50< wedge009> Sorry, I've been busy with a migration for work, that's why I've been quiet. 20151026 09:46:00< Aginor> wedge009: no need to apologise 20151026 09:46:50< Aginor> wedge009: there's a map preview that's looking suspiciously broken under SDL2, almost like it's full of buggy data 20151026 09:47:58< wedge009> Did you manage to get as far as the choose faction screen? 20151026 09:50:40< Aginor> yes, that's where it's crashing 20151026 09:50:50< Aginor> usually in the first go, unless I stop rendering text 20151026 09:51:01< Aginor> then the minimap data is looking awefully corrupt 20151026 09:51:06-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind1] 20151026 09:51:17< Aginor> I wonder if the network code is broken and there's a buffer overflow happening 20151026 09:51:38< Aginor> but I would have expected valgrind to catch that 20151026 09:55:58-!- cib0 [~cib@132.231.178.144] has joined #wesnoth-dev 20151026 10:01:41-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev 20151026 10:03:43< wedge009> Oh, so you're disabling the text somehow? The display data is still getting corrupted, I thought. 20151026 10:03:57< wedge009> Oh no, hope it's not an overflow. 20151026 10:04:25< Aginor> wedge009: by commenting out the text-rendering code :) 20151026 10:04:36< wedge009> But from what little I've seen of the MP code it's mainly text that gets thrown around. Everything seems to be constructed on the individual client from the text that gets passed around. 20151026 10:04:41< wedge009> I see. 20151026 10:04:48< Aginor> I really want to find the piece of code that generates the minimap 20151026 10:05:27< wedge009> Might be faster to ask the others when they're awake/on. 20151026 10:06:15-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 255 seconds] 20151026 10:06:47< Aginor> yeah, I think that's what I'll do 20151026 10:07:05< Aginor> I need to go to bed soon, new job starting tomorrow and I better look awake on my first day :) 20151026 10:07:39< wedge009> Ooh, new job straight after the holiday. 20151026 10:07:48< wedge009> Good time to do so. 20151026 10:07:53< wedge009> Sleep, I mean. 20151026 10:08:15-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev 20151026 10:09:05< Aginor> wedge009: yup, although at the moment I feel like more time off would have been nice :D 20151026 10:09:34< wedge009> Probably best to get back into it before you get too used to the rest. Now get to sleep! 20151026 10:13:25-!- Kwandulin_2 [~Miranda@p200300760F18C0CD34E2287B4262D62F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20151026 10:19:17-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20151026 10:28:26< Aginor> see you all later 20151026 10:29:40< wedge009> Shoo! :p 20151026 10:34:07-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!] 20151026 10:34:28< irker612> wesnoth: Wedge009 wesnoth:master f1ed8af6968a / changelog players_changelog: Adding log entries for changes already in master. http://git.io/vWrH2 20151026 10:34:31< irker612> wesnoth: Charles Dang wesnoth:master b876247051ea / changelog players_changelog: Merge pull request #540 from Wedge009/wedge009_changes_master http://git.io/vWrHa 20151026 10:35:02< wedge009> You're too quick for me. I'm making another one for 1.12, then I can go about cleaning up my mess in the still-standing PRs. 20151026 10:35:11< wedge009> But thanks! 20151026 10:35:44< vultraz> you need push access :P 20151026 10:36:52< wedge009> Oh wait, never mind. Looks like shadowm or whoever already added it to the log. 20151026 10:36:55< wedge009> That's good. 20151026 10:54:58< irker612> wesnoth: loonycyborg wesnoth:asio_wesnothd 19f3ff9b6d85 / src/server/ (room_manager.cpp rooms.hpp server.cpp server.hpp): Move lobby handling into separate function http://git.io/vWrFb 20151026 10:55:00< irker612> wesnoth: loonycyborg wesnoth:asio_wesnothd 9ef2d1a1034b / src/server/ (rooms.cpp rooms.hpp server.cpp server.hpp): Ported handling of players in game http://git.io/vWrFN 20151026 11:06:03< wedge009> vultraz: BTW, any further contact from Mr Logo Artist (forgot the name)? 20151026 11:06:12< vultraz> Sgt. Groovy 20151026 11:06:13< vultraz> and no 20151026 11:06:20< vultraz> aquelia PMed him a day or two ago 20151026 11:12:44< wedge009> Okay, thanks. 20151026 11:28:18-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind] 20151026 11:44:53< Soliton> zookeeper: for single player having different alignments available should be fine. usually in a campaign you want/have to push all the time, there is not the back and forth like in a balanced mp game, so having different aligned units to rotate should be nice. 20151026 11:45:39-!- daMark [5439aa5b@gateway/web/freenode/ip.84.57.170.91] has joined #wesnoth-dev 20151026 11:48:36< zookeeper> Soliton, hrhm, maybe so 20151026 11:49:18-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20151026 11:59:56-!- prkc [~prkc@51B78F27.dsl.pool.telekom.hu] has joined #wesnoth-dev 20151026 12:14:39-!- daMark [5439aa5b@gateway/web/freenode/ip.84.57.170.91] has left #wesnoth-dev [] 20151026 12:22:26-!- travis-ci [~travis-ci@ec2-54-227-106-132.compute-1.amazonaws.com] has joined #wesnoth-dev 20151026 12:22:27-!- travis-ci [~travis-ci@ec2-54-227-106-132.compute-1.amazonaws.com] has quit [Client Quit] 20151026 12:39:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20151026 13:05:08-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 20151026 13:05:29-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 13:11:22-!- cib0 [~cib@132.231.178.144] has quit [Ping timeout: 244 seconds] 20151026 13:48:12-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 20151026 13:48:34-!- fabi [~quassel@176.4.102.166] has joined #wesnoth-dev 20151026 13:48:34-!- fabi [~quassel@176.4.102.166] has quit [Changing host] 20151026 13:48:34-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 13:49:11-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20151026 13:49:42-!- fabi [~quassel@176.4.102.166] has joined #wesnoth-dev 20151026 13:49:42-!- fabi [~quassel@176.4.102.166] has quit [Changing host] 20151026 13:49:42-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 13:55:10-!- irker612 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20151026 13:59:58-!- Appleman1234 [~Appleman1@KD111239028050.au-net.ne.jp] has quit [Ping timeout: 272 seconds] 20151026 14:07:37-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Read error: Connection reset by peer] 20151026 14:08:00-!- fabi [~quassel@176.4.102.166] has joined #wesnoth-dev 20151026 14:08:00-!- fabi [~quassel@176.4.102.166] has quit [Changing host] 20151026 14:08:00-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 14:10:49-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20151026 14:11:15-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 14:17:25-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Read error: Connection reset by peer] 20151026 14:17:46-!- fabi [~quassel@176.4.102.166] has joined #wesnoth-dev 20151026 14:17:46-!- fabi [~quassel@176.4.102.166] has quit [Changing host] 20151026 14:17:46-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 14:19:06-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20151026 14:19:16-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Read error: Connection reset by peer] 20151026 14:19:28-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 14:20:31-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has joined #wesnoth-dev 20151026 14:20:54-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has quit [Changing host] 20151026 14:20:54-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev 20151026 14:27:12-!- joet [~joet@host86-191-22-102.range86-191.btcentralplus.com] has quit [Ping timeout: 272 seconds] 20151026 14:44:59-!- ideuler [~textual@dhcp-33.uminho.pt] has joined #wesnoth-dev 20151026 14:46:26-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Ping timeout: 240 seconds] 20151026 14:53:57-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has joined #wesnoth-dev 20151026 14:53:57-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has quit [Changing host] 20151026 14:53:57-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev 20151026 14:56:02-!- ideuler [~textual@dhcp-33.uminho.pt] has quit [Excess Flood] 20151026 14:56:24-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Read error: Connection reset by peer] 20151026 14:56:45-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has joined #wesnoth-dev 20151026 14:57:08-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has quit [Changing host] 20151026 14:57:08-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev 20151026 14:57:18-!- Appleman1234 [~Appleman1@KD111239012242.au-net.ne.jp] has joined #wesnoth-dev 20151026 14:57:26-!- ideuler [~textual@dhcp-33.uminho.pt] has joined #wesnoth-dev 20151026 15:02:56-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev 20151026 15:09:25-!- ideuler [~textual@dhcp-33.uminho.pt] has quit [Ping timeout: 256 seconds] 20151026 15:18:05-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20151026 15:18:36-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20151026 15:21:10-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds] 20151026 15:21:10-!- wedge010 is now known as wedge009 20151026 15:24:51-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Read error: Connection reset by peer] 20151026 15:25:43-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has joined #wesnoth-dev 20151026 15:26:05-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has quit [Changing host] 20151026 15:26:05-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev 20151026 15:29:46-!- prkc_ [~prkc@51B78F27.dsl.pool.telekom.hu] has joined #wesnoth-dev 20151026 15:29:59-!- prkc_ [~prkc@51B78F27.dsl.pool.telekom.hu] has quit [Client Quit] 20151026 15:37:45-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 15:40:49-!- fendrin [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20151026 15:41:17-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 15:42:18-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 268 seconds] 20151026 15:42:28-!- fendrin [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20151026 15:42:51-!- fabi [~quassel@176.2.102.190] has joined #wesnoth-dev 20151026 15:42:51-!- fabi [~quassel@176.2.102.190] has quit [Changing host] 20151026 15:42:51-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 15:46:22-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20151026 15:49:43-!- boucman_work [~jrosen@193.56.60.161] has joined #wesnoth-dev 20151026 15:49:43-!- boucman_work [~jrosen@193.56.60.161] has quit [Changing host] 20151026 15:49:43-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20151026 16:01:28-!- joet [~joet@host86-191-22-102.range86-191.btcentralplus.com] has joined #wesnoth-dev 20151026 16:03:32-!- ypnos_ is now known as ypnos 20151026 16:12:11-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Read error: Connection reset by peer] 20151026 16:12:19-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has joined #wesnoth-dev 20151026 16:12:41-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has quit [Changing host] 20151026 16:12:41-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev 20151026 16:40:14-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Ping timeout: 250 seconds] 20151026 16:44:25-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20151026 16:51:10-!- Appleman1234 [~Appleman1@KD111239012242.au-net.ne.jp] has quit [Ping timeout: 240 seconds] 20151026 16:57:13-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving] 20151026 17:02:57-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has joined #wesnoth-dev 20151026 17:06:51-!- ancestral [~ancestral@71-220-62-196.mpls.qwest.net] has quit [Client Quit] 20151026 17:07:58-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20151026 17:18:28-!- rjframe [2d34e82a@gateway/web/freenode/ip.45.52.232.42] has joined #wesnoth-dev 20151026 17:20:33-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Read error: Connection reset by peer] 20151026 17:21:51-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has joined #wesnoth-dev 20151026 17:22:13-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has quit [Changing host] 20151026 17:22:13-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev 20151026 17:23:56-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Read error: Connection reset by peer] 20151026 17:24:22-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has joined #wesnoth-dev 20151026 17:24:42-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has quit [Changing host] 20151026 17:24:42-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev 20151026 17:28:53-!- mjs-de [~mjs-de@x4db6a2f9.dyn.telefonica.de] has quit [Ping timeout: 250 seconds] 20151026 17:28:57-!- gfgtdf [~chatzilla@f054150025.adsl.alicedsl.de] has joined #wesnoth-dev 20151026 17:29:15< gfgtdf> celticminstrel: are you goining to backport the variable name chack to 1.12 ? 20151026 17:31:06-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev 20151026 17:31:19< celticminstrel> I hadn't planned to. 20151026 17:32:30-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20151026 17:34:16< gfgtdf> celticminstrel: i think it would be useful to do so, for example this here http://forums.wesnoth.org/viewtopic.php?f=21&p=590342 seems likeley to be caused by invalid variablenames. 20151026 17:35:17< gfgtdf> celticminstrel: another issue: you varible name check uses isalnum which, accurding to the documentation, is dependent on teh current locale doesnt this mean that some variable names will only be allowed on some clients but not on others? 20151026 17:35:37-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 256 seconds] 20151026 17:35:38< celticminstrel> Eh... 20151026 17:36:35< celticminstrel> Locales are really troublesome. :/ 20151026 17:38:50< celticminstrel> It would be best if we could force use of the default C locale, honestly. 20151026 17:40:32< mattsc> celticminstrel: I can confirm that unit tests compile with PR502 except for the boost linking error 20151026 17:40:41< celticminstrel> Yay! 20151026 17:41:04< gfgtdf> celticminstrel: maybe it would be best to do the check manually? (c >= 'a' && c <= 'z' && c >= 'A' && c <= 'Z' &&c >= '0' && c <= '9') 20151026 17:41:19< celticminstrel> It would be more reliable. :/ 20151026 17:41:24< mattsc> I’ll recompile boost tonight (don’t have the libs on this computer) 20151026 17:42:31< gfgtdf> celticminstrel: i mean (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z') || (c >= '0' && c <= '9') 20151026 17:46:37-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20151026 17:47:31< celticminstrel> I guess the actual problem with locales is that they implicitly alter how your code works. If you had to call a function to say "use the system locale instead of default locale", it would be a lot less troublesome. 20151026 17:51:24-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving] 20151026 18:01:54-!- prkc [~prkc@51B78F27.dsl.pool.telekom.hu] has quit [Ping timeout: 255 seconds] 20151026 18:02:41-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 250 seconds] 20151026 18:04:37-!- Appleman1234 [~Appleman1@KD111239009223.au-net.ne.jp] has joined #wesnoth-dev 20151026 18:19:59-!- joet [~joet@host86-191-22-102.range86-191.btcentralplus.com] has left #wesnoth-dev ["Leaving"] 20151026 18:25:07-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Quit: ZNC - 1.6.0 - http://znc.in] 20151026 18:25:45-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has joined #wesnoth-dev 20151026 18:25:45-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has quit [Changing host] 20151026 18:25:45-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev 20151026 18:33:48-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev 20151026 19:04:27-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev 20151026 19:05:38-!- gfgtdf [~chatzilla@f054150025.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 41.0.2/20151014143721]] 20151026 19:08:16-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 19:39:25-!- prkc [~prkc@51B78F27.dsl.pool.telekom.hu] has joined #wesnoth-dev 20151026 19:39:33-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Quit: ZNC - 1.6.0 - http://znc.in] 20151026 19:42:27-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has joined #wesnoth-dev 20151026 19:42:27-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has quit [Changing host] 20151026 19:42:27-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev 20151026 19:42:45-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev 20151026 19:45:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20151026 19:45:49-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Read error: Connection reset by peer] 20151026 19:45:59-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has joined #wesnoth-dev 20151026 19:45:59-!- molgrum [~molgrum@h-94-103.a230.priv.bahnhof.se] has quit [Changing host] 20151026 19:45:59-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev 20151026 19:47:17-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev 20151026 19:53:46-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 246 seconds] 20151026 19:57:01-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai] 20151026 19:57:10-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 272 seconds] 20151026 20:05:04-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev 20151026 20:15:47-!- {V} [~V@105-70-ftth.on.nl] has quit [Ping timeout: 264 seconds] 20151026 20:15:55-!- {V} [~V@105-70-ftth.on.nl] has joined #wesnoth-dev 20151026 20:19:20-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20151026 20:19:42-!- fabi [~quassel@176.2.102.190] has joined #wesnoth-dev 20151026 20:19:42-!- fabi [~quassel@176.2.102.190] has quit [Changing host] 20151026 20:19:42-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 20:32:08-!- prkc [~prkc@51B78F27.dsl.pool.telekom.hu] has quit [Ping timeout: 268 seconds] 20151026 20:33:46-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20151026 20:35:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20151026 20:38:10-!- fabi [~quassel@176.2.102.190] has joined #wesnoth-dev 20151026 20:38:10-!- fabi [~quassel@176.2.102.190] has quit [Changing host] 20151026 20:38:10-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 20:42:24-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20151026 20:47:12-!- fabi [~quassel@176.2.102.190] has joined #wesnoth-dev 20151026 20:47:12-!- fabi [~quassel@176.2.102.190] has quit [Changing host] 20151026 20:47:12-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 20:50:22-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev 20151026 20:52:12-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20151026 20:52:40-!- fabi [~quassel@176.2.102.190] has joined #wesnoth-dev 20151026 20:52:40-!- fabi [~quassel@176.2.102.190] has quit [Changing host] 20151026 20:52:40-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20151026 20:56:33-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev 20151026 21:10:44-!- TheJJ [~rofl@ipbcc36ea9.dynamic.kabel-deutschland.de] has quit [Quit: løl] 20151026 21:11:00-!- TheJJ [~rofl@ipbcc36ea9.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20151026 21:15:19-!- iceiceice [~chris@23.31.228.41] has joined #wesnoth-dev 20151026 21:15:19-!- iceiceice [~chris@23.31.228.41] has quit [Changing host] 20151026 21:15:19-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20151026 21:21:41-!- prkc [~prkc@51B78F27.dsl.pool.telekom.hu] has joined #wesnoth-dev 20151026 21:31:27-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds] 20151026 21:43:39-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009] 20151026 21:43:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20151026 21:44:03-!- horrowind1 [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind1] 20151026 21:45:14-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 260 seconds] 20151026 22:04:00-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev 20151026 22:08:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20151026 22:22:41-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!] 20151026 22:28:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds] 20151026 22:28:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20151026 22:33:18-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20151026 22:33:18-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20151026 22:37:34-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev 20151026 22:40:02-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20151026 22:51:11-!- prkc [~prkc@51B78F27.dsl.pool.telekom.hu] has quit [Ping timeout: 264 seconds] 20151026 23:03:12-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!] 20151026 23:04:47-!- prkc [~prkc@51B78F27.dsl.pool.telekom.hu] has joined #wesnoth-dev 20151026 23:14:13-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev 20151026 23:18:36-!- oldlaptop [~quassel@192.183.50.87] has quit [Ping timeout: 240 seconds] 20151026 23:19:10-!- oldlaptop [~quassel@192.183.50.87] has joined #wesnoth-dev 20151026 23:20:30-!- Appleman1234 [~Appleman1@KD111239009223.au-net.ne.jp] has quit [Ping timeout: 255 seconds] 20151026 23:26:53-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Remote host closed the connection] 20151026 23:28:08-!- iceiceice [~chris@23.31.228.41] has joined #wesnoth-dev 20151026 23:28:08-!- iceiceice [~chris@23.31.228.41] has quit [Changing host] 20151026 23:28:08-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev 20151026 23:29:22-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai] 20151026 23:39:11-!- janebot_ [~Gambot@grickit.us] has quit [Ping timeout: 264 seconds] 20151026 23:39:21-!- Shackra [~Jorge@186.177.2.148] has quit [Quit: No Ping reply in 180 seconds.] 20151026 23:39:30-!- janebot_ [~Gambot@grickit.us] has joined #wesnoth-dev 20151026 23:40:38-!- Shackra [~Jorge@186.177.2.148] has joined #wesnoth-dev 20151026 23:55:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds] --- Log closed Tue Oct 27 00:00:50 2015