--- Log opened Thu Dec 10 00:00:24 2015
20151210 00:03:31-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151210 00:13:29< gfgtdf> celticminstrel: did you put the change to ABILITY_LEADERSHIP_LEVEL_X macros in the RN? I think you should  since it will break some scenarios that relied on the previously ABILITY_LEADERSHIP_LEVEL_X implementations, to for example give ABILITY_LEADERSHIP_LEVEL_4 to a level 3 unit to make its leadership better.
20151210 00:13:38-!- iceiceice [~chris@23.31.228.41] has joined #wesnoth-dev
20151210 00:13:38-!- iceiceice [~chris@23.31.228.41] has quit [Changing host]
20151210 00:13:38-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151210 00:17:53< celticminstrel> I haven't touched the release notes ever. I see what you mean, though.
20151210 00:19:02< celticminstrel> I don't think it's a problem to break such things, mind you - (I think it would confuse people if a unit's leadership also worked on units of the same level when the description (I think?) says otherwise.
20151210 00:19:37< celticminstrel> gfgtdf: I can add it to the release notes, or if you want, you could add it.
20151210 00:26:06< celticminstrel> I still don't quite get how the release notes works, so it might be better if you do it, but I could still try if you prefer not to.
20151210 00:27:16 * celticminstrel sees the "custom effects" entry and suddenly remembers that the built-in effects are (I think?) not exposed to Lua... something to think about later...
20151210 00:27:23-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151210 00:28:07< celticminstrel> By the way, gfgtdf, are custom effects undoable?
20151210 00:28:37< celticminstrel> Ah, wait, never mind.
20151210 00:28:58< celticminstrel> Undoing an effect is implemented by removing it and then rebuilding the unit, so anything is automatically undoable.
20151210 00:29:00< celticminstrel> Duh.
20151210 00:29:55-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20151210 00:29:56-!- wedge010 is now known as wedge009
20151210 00:32:57-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20151210 00:34:55-!- mjs-de [~mjs-de@x4db596a9.dyn.telefonica.de] has quit [Remote host closed the connection]
20151210 00:40:54< shadowm> vultraz: For the last time, WE ARE NOT DROPPING SUPPORT FOR WINDOWS XP.
20151210 00:41:15< shadowm> Not unless it's absolutely necessary for some purpose that actually is important.
20151210 00:41:43< shadowm> celticminstrel: What change to the leadership macros?
20151210 00:41:57< celticminstrel> They're now implemented by a single macro instead of five separate ones.
20151210 00:42:18< celticminstrel> The macro uses the new $other_unit variable to automatically detect the correct leadership level.
20151210 00:42:22< celticminstrel> Something like that.
20151210 00:42:49< shadowm> Did you update wmllint to handle this?
20151210 00:43:16< celticminstrel> Uhh... I can't remember, but I did include dummy macros that simply redirect to the new one.
20151210 00:43:20< celticminstrel> I'll check wmllint.
20151210 00:43:39< shadowm> Okay, that's good enough but you should either add a new substitution rule to wmllint or file a FR for Elvish_Hunter.
20151210 00:44:11< shadowm> The old syntax is still supported, though?
20151210 00:44:24< shadowm> For custom macros that implement similar abilities, I mean.
20151210 00:44:32< irker878> wesnoth: gfgtdf wesnoth:master ab1a4629a96b / data/ (7 files in 6 dirs): rename [filter] -> [filter_location] in [random_placement] http://git.io/vRx27
20151210 00:44:41< celticminstrel> It should be, yeah.
20151210 00:44:53< celticminstrel> But I think it would be beneficial for people to migrate from that to the new syntax.
20151210 00:45:25 * shadowm sighs in zookeeper's general direction.
20151210 00:45:41< celticminstrel> Looks like I did add a wmllint rule - lines 632-6.
20151210 00:45:46< shadowm> Oh well, I suppose the track is still unique enough in context since it's only used after like 57 scenarios.
20151210 00:47:37< gfgtdf> if i have in variables [a] [sometags].. [/a][a] [sometags]..  [someothertags].. [/a] is it possible in wml (without lua) to merge them into one  a tag so that the rsult woudl be [a] [sometags].. [sometags]..  [someothertags].. [/a]
20151210 00:48:02< celticminstrel> Use [+a] instead of [a]?
20151210 00:48:19< celticminstrel> Oh wait, "in variables"... what does that mean?
20151210 00:48:26< gfgtdf> those are given wml variabels
20151210 00:48:37< gfgtdf> with [set_varriable(s)] or similar
20151210 00:48:59< celticminstrel> So you mean you have a WML container variable with two (or more) elements and you want to merge those into a single container variable?
20151210 00:49:08< gfgtdf> yes
20151210 00:49:19< celticminstrel> Hmm. I don't know of any way to do that.
20151210 00:51:20< celticminstrel> I think there are C++ API functions for it, but no Lua API functions.
20151210 00:51:49< celticminstrel> Something like cfg.merge_children()? I can't quite remember.
20151210 00:53:14< celticminstrel> Ooh.
20151210 00:53:28< celticminstrel> gfgtdf: There's [set_variables]mode=merge - that might do what you want.
20151210 00:53:42< celticminstrel> I'm not certain though.
20151210 00:55:37< gfgtdf> celticminstrel: ok ty, i looked at the c++ code and it seems to do what i want
20151210 01:03:32< celticminstrel> gfgtdf, anyone else who cares: How's this sound for a RELEASE_NOTES entry?
20151210 01:03:59< celticminstrel> "A new $other_unit variable is accessible in some unit filters. This can be used in filter_adjacent and similar contexts to create filters that are relative to the main unit. The backstab and leadership abilities have been rewritten to take advantage of this feature, which allows leadership to be implemented by a single macro, {ABILITY_LEADERSHIP}. Although the old {ABILITY_LEADERSHIP_LEVEL_3} etc macros are still available, they me
20151210 01:04:00< celticminstrel> point to the new one. As a result, anyone who used a leadership level not matching the unit's level (for example, level 4 leadership on a level 3 unit) will find that this no longer works as expected."
20151210 01:04:13< celticminstrel> Is it too verbose?
20151210 01:05:11< celticminstrel> Or not clear enough?
20151210 01:05:59< celticminstrel> Should I do a "Short version"/"Long version" think like with the new files location?
20151210 01:06:02< celticminstrel> ^thing
20151210 01:29:24< shadowm> Don't copy me, I only did that because even developers have problems trying to understand my changes.
20151210 01:30:09< shadowm> That entry sounds okay.
20151210 01:30:14-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 272 seconds]
20151210 01:30:40< shadowm> It's always nice when people take the time to document potentially negative side-effects.
20151210 01:31:01-!- iceiceice [~chris@23.31.228.41] has joined #wesnoth-dev
20151210 01:31:01-!- iceiceice [~chris@23.31.228.41] has quit [Changing host]
20151210 01:31:01-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151210 01:32:32< celticminstrel> ...heh, "Describe how awesome the new game version dialog is".
20151210 01:34:46< irker878> wesnoth: CelticMinstrel wesnoth:master 5204f3d1c9dc / RELEASE_NOTES: Update RELEASE_NOTES http://git.io/vRxMV
20151210 01:54:12-!- flowerhack [sid6775@gateway/web/irccloud.com/x-eneiynhladtyarjv] has quit [Ping timeout: 264 seconds]
20151210 01:54:41-!- flowerhack [sid6775@gateway/web/irccloud.com/x-gpzolulvjkiealsj] has joined #wesnoth-dev
20151210 01:56:38< irker878> wesnoth: Charles Dang wesnoth:master 9b39d1e7015d / changelog: Mention new logo in changelog http://git.io/vRxHr
20151210 02:08:38-!- gfgtdf [~chatzilla@f054163069.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 42.0/20151029151421]]
20151210 02:15:46-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 240 seconds]
20151210 02:16:49-!- iceiceice [~chris@23.31.228.41] has joined #wesnoth-dev
20151210 02:16:51-!- iceiceice [~chris@23.31.228.41] has quit [Changing host]
20151210 02:16:51-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151210 02:26:01-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151210 02:29:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20151210 03:04:55-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20151210 03:34:25< celticminstrel> Some of the music tracks seem to be written with certain races or factions in mind, but not every race/faction is represented.
20151210 03:42:51< vultraz> This is true
20151210 03:43:34-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20151210 04:56:55-!- irker878 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151210 05:02:16-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20151210 05:02:16-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20151210 05:02:16-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151210 05:07:07< shadowm> gfgtdf: I hope you made sure all your changes are in the changelog this time.
20151210 05:21:32< celticminstrel> I should probably double-check too, though in my case if I forgot something it's probably wiki stuff, not changelog...
20151210 05:23:06< celticminstrel> Hm, might've missed 285f8c8 in the changelog...
20151210 05:23:49< celticminstrel> Is the map format change (removal of header) in there yet?
20151210 05:28:22< celticminstrel> I don't see it.
20151210 05:32:34-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 256 seconds]
20151210 05:32:37-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151210 05:37:46-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20151210 05:41:20< celticminstrel> It looks like commit af2e16f is not mentioned in the changelog...
20151210 05:41:37< celticminstrel> Unless it's under bugfixes, which admittedly is probably where it belongs...
20151210 05:41:52< celticminstrel> Ah, yeah, it's under bugfixes.
20151210 05:58:07< celticminstrel> gfgtdf's new tag needs to support [return], I think...
20151210 05:58:19< celticminstrel> The [random_placement] tag.
20151210 05:58:31< celticminstrel> Actually, there might be one or two others too, like [on_undo].
20151210 05:59:09< celticminstrel> Although... they probably call wesnoth.wml_actions.command... so maybe it's actually fine... but I should double-check...
20151210 06:11:11-!- irker925 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151210 06:11:11< irker925> wesnoth: CelticMinstrel wesnoth:master fc72ae8431e2 / changelog: Update changelog http://git.io/vRpab
20151210 06:11:21< celticminstrel> I did miss a few things after all.
20151210 06:12:21< celticminstrel> I think mention of the map format change (the removal of the header containing usage and border_size) is still missing, unless it was mentioned in the changelogs for 1.13.1 already, but in that case there should still be something in bugfixes relating to commit 1b22a97.
20151210 06:13:51< celticminstrel> Maybe that should be included in RELEASE_NOTES too, since it'll affect most add-ons.
20151210 06:14:09< celticminstrel> Assuming it wasn't already mentioned in 1.13.1.
20151210 06:23:04-!- Samual [~Samual@73.236.192.60] has joined #wesnoth-dev
20151210 06:23:04-!- Samual [~Samual@73.236.192.60] has quit [Changing host]
20151210 06:23:04-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20151210 06:36:05-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20151210 07:21:37< vultraz> ya know
20151210 07:21:47< vultraz> why do we use red= blue= green= keys
20151210 07:21:57< vultraz> instead of a single color= key?
20151210 07:24:02< vultraz> hmm
20151210 07:24:09< vultraz> looks like it might have to do with sdl_color...
20151210 07:26:04< vultraz> ah, I see...
20151210 07:26:11< vultraz> sdl_color objects takes 4 arguments
20151210 07:26:15< vultraz> take*
20151210 07:26:52< vultraz> I guess c++ doesn't have meta ... arguments (ie, a value that evaluates to a comma-separated list string counting as 4 arguments)
20151210 07:27:08< fabi> well
20151210 07:28:02< fabi> I think the wml syntax is just like it is because the author who wrote the code liked it so.
20151210 07:28:22< fabi> And is not connected to how sdl works on the c++ side.
20151210 07:28:36< vultraz> fabi: so how could it be made to work with a single color= key?
20151210 07:29:06< fabi> rgb=255,155,0
20151210 07:29:32< fabi> color_rgb=
20151210 07:30:34< vultraz> yes, but if we need to pass that to an sdl_color object, would you have to split the string
20151210 07:30:43< fabi> sure
20151210 07:30:51< fabi> but that happens all the time when wml is parsed
20151210 07:31:01< fabi> thus you have helper functions for it
20151210 07:31:32< vultraz> hm
20151210 07:31:39< fabi> utils:join
20151210 07:31:44< fabi> utils:split
20151210 07:31:55< fabi> are the ones covering your issue
20151210 07:31:57< vultraz> yes
20151210 07:32:31< vultraz> I know about split
20151210 07:32:42< vultraz> I'm just trying to visualize how the code could be written
20151210 07:32:51< vultraz> since I don;t think you can have a cumulative color
20151210 07:33:00< vultraz> ie, set the r, then set the g, then set the b, then set the a
20151210 07:33:16< vultraz> so you'd need local variables...
20151210 07:34:01< vultraz> I wonder if I could do an std::map
20151210 07:34:23< fabi> rgb_list= split(cfg.rgb); sdl_color(rgb_list[0], rgb_list[1], rgb_list[2])
20151210 07:34:38< vultraz> oh
20151210 07:34:42< vultraz> ... that simple??
20151210 07:34:55< fabi> iirc split produces a list
20151210 07:35:07< vultraz> I though it was an iterator 
20151210 07:35:09< fabi> but you should check the length
20151210 07:35:25< fabi> well iterator is fine as well
20151210 07:35:44< fabi> and maybe you need a conversion into int
20151210 07:36:14< fabi> I guess the rgb_list is a vector over string
20151210 07:36:30< vultraz> we have to_int() 
20151210 07:37:35< fabi> Well, my point is:
20151210 07:38:06< fabi> API should be consistent in itself. And not follow how some backend code is written.
20151210 07:38:24< fabi> What if the next engine Wesnoth runs with is written in haskell?
20151210 07:38:35< vultraz> ok so split can be used with vectors
20151210 07:38:45< fabi> no
20151210 07:38:50< fabi> split produces vectors
20151210 07:38:58< fabi> join can be used with vectors
20151210 07:39:28< vultraz> so I guess I can just do const std::vector<int> color_rgb = utils::split(cfg["color"].to_int()); 
20151210 07:39:41< fabi> no
20151210 07:39:44< vultraz> no?
20151210 07:39:45< fabi> to_int
20151210 07:40:02< fabi> will try to make an int from "255,155,0"
20151210 07:40:04< fabi> And that will fail
20151210 07:40:08< vultraz> oh, ok
20151210 07:40:11< vultraz> so without that
20151210 07:40:12< fabi> it needs to be splitted
20151210 07:40:15< fabi> and then cast to int
20151210 07:40:25< fabi> maybe that happens by autoboxing
20151210 07:40:28< vultraz> wouldn't it be int since it's a vector of ints?
20151210 07:40:32< fabi> yes
20151210 07:40:39< fabi> that is what I mean with autoboxing
20151210 07:40:52< fabi> implicit cast
20151210 07:41:05< vultraz> I did not know the term 
20151210 07:41:12< vultraz> ok, let me try this
20151210 07:44:20< vultraz> should probably put this into some util function 
20151210 07:46:29< fabi> is it working?
20151210 07:52:25-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20151210 07:52:25-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Changing host]
20151210 07:52:25-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151210 07:52:52< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\scripting\game_lua_kernel.cpp|2259|error: conversion from 'std::vector<std::__cxx11::basic_string<char> >' to non-scalar type 'const std::vector<int>' requested|
20151210 07:52:54< vultraz> :(
20151210 07:53:50< fabi> hmm
20151210 07:53:58< fabi> maybe there is a way around that
20151210 07:54:22< fabi> but I would use a vector<string> and do the converstion afterwards
20151210 07:54:47< fabi> iceiceice: ^
20151210 07:55:49< fabi> since you only have 3 values
20151210 07:56:05< fabi> it is okay to do the cast for everyone of them 
20151210 07:56:15< vultraz> either 3 or 4
20151210 07:56:19< vultraz> er
20151210 07:56:21< fabi> yeah
20151210 07:56:25< vultraz> we actually the wml never handles alpha
20151210 07:56:31< fabi> still it is a low number
20151210 07:57:25< fabi> if your vector would be large then creating a new vector by using some sort of map like constructor.
20151210 07:57:47< fabi> looks I am to lazy to finish sentences properly
20151210 08:05:45< vultraz> yeah I'll wait for iceiceice 
20151210 08:09:31< fabi> vultraz: Or you ask google. I mean, those are minor syntax issues. Learn how to inform yourself about them.
20151210 08:15:30< vultraz> wait a min
20151210 08:15:37< vultraz> create_color is a util function that takes chars
20151210 08:15:37< fabi> And I don't understand why you don't just call the 
20151210 08:15:39< vultraz> not its
20151210 08:15:41< vultraz> ints*
20151210 08:15:47< fabi> fine
20151210 08:16:18< vultraz> derp
20151210 08:17:48< vultraz> Ok I think I know what I should do
20151210 08:19:19< fabi> I think c++ is not a good start for learning how to code anyway.
20151210 08:41:04-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20151210 08:46:58< zookeeper> shadowm, you told me to just do what i think is best :|
20151210 08:48:09< zookeeper> gfgtdf, no, i can't really see what the gold variable is used for. why?
20151210 08:48:23< zookeeper> (that whole scenario should be re-written from scratch)
20151210 09:33:57< vultraz> ok, this is going well
20151210 09:34:20< vultraz> now I just need to find that thing I can never find: the standard deprecation message function 
20151210 09:36:00-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 272 seconds]
20151210 09:37:38-!- fabi is now known as fendrin
20151210 09:38:04-!- aquileia [~chatzilla@eduroam174-172.wlan.uni-ulm.de] has joined #wesnoth-dev
20151210 09:41:52< aquileia> celticminstrel: We may want to port your leadership simplification for the THoT inspire ability (leadership+1)
20151210 09:42:58< aquileia> shikadibot: seen celticminstrel
20151210 09:43:24< vultraz> aquileia: he left ~3 hours ago
20151210 09:44:26< aquileia> I know - I wanted to use the auto-ping shikadibot used to provide for someone who was asked for
20151210 09:45:07-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20151210 09:48:38< aquileia> celtticminstrel: You may be interested in http://r.wesnoth.org/t39685 for musical inspiration - basically a motif brainstorming thread
20151210 10:04:41-!- aquileia [~chatzilla@eduroam174-172.wlan.uni-ulm.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 42.0/20151029151421]]
20151210 10:16:12< wedge009> I like the new Frantic track, the booming war drums give a sinister vibe. Surprisingly slow compared with the original Frantic, but I think it still serves the same purpose as a replacement.
20151210 10:50:14< vultraz> blegh
20151210 11:07:54< irker925> wesnoth: Charles Dang wesnoth:master dcb265ae701d / src/ (help/help_text_area.cpp sdl/utils.cpp sdl/utils.hpp): Added util function for converting an RGB string to color http://git.io/vRjUx
20151210 11:07:57< irker925> wesnoth: Charles Dang wesnoth:master 8f35c4bfcfd3 / src/ (6 files in 3 dirs): Pass color value directly to game_display::float_label http://git.io/vRjUp
20151210 11:08:00< irker925> wesnoth: Charles Dang wesnoth:master 956e5f932259 / src/scripting/game_lua_kernel.cpp: Enable [print] color= and deprecate red,green,blue= keys http://git.io/vRjUh
20151210 11:08:05< vultraz> Still have to work on color_adjust and time
20151210 11:08:15< vultraz> former relies on the latter which is a bit complicated
20151210 11:10:31< irker925> wesnoth: Charles Dang wesnoth:master 0d8c00801899 / src/sdl/utils.cpp: Small indent fixup for dcb265ae701d (spaces to tabs) http://git.io/vRjT5
20151210 11:11:04< vultraz> fendrin: ^
20151210 11:14:42< vultraz> now to figure out the tod_color struct thingy..
20151210 11:19:00< vultraz> I'll wait for celticminstral to return for rubber duck duty 
20151210 11:29:37-!- fendrin [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20151210 11:33:24-!- fabi [~quassel@176.0.34.213] has joined #wesnoth-dev
20151210 11:33:24-!- fabi [~quassel@176.0.34.213] has quit [Changing host]
20151210 11:33:25-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151210 11:33:58< fabi> vultraz: What happens if split is not able to produce a vector with 3 or 4 items in it?
20151210 11:35:12< vultraz> er
20151210 11:35:13< vultraz> hm
20151210 11:35:27< vultraz> I guess I should add a loop to set null values to 0
20151210 11:36:39< vultraz> or wait
20151210 11:36:51< vultraz> i could just assign default values to create_color's arguments in the header
20151210 11:36:53< vultraz> couldn't I?
20151210 11:37:46< fabi> the problem is the vector access
20151210 11:38:09< vultraz> oh, pointers to a null value?
20151210 11:38:18< fabi> iirc vector does not moan about out of bounce access nor does it provide some null value
20151210 11:38:52< fabi> so the access will just give you random values
20151210 11:43:04< vultraz> hm
20151210 11:43:09< vultraz> well that's a problem
20151210 11:43:15< fabi> yes
20151210 11:43:22< fabi> but there is the "at" method
20151210 11:43:30< vultraz> "at" method?
20151210 11:43:31< fabi> it provides access with boundary check
20151210 11:44:09< fabi> http://en.cppreference.com/w/cpp/container/vector/at
20151210 11:44:50< fabi> it will throw an exception 
20151210 11:44:54< fabi> you need to catch it
20151210 11:46:30< fabi> I would prefer to just check the size of the vector myself
20151210 11:47:27< vultraz> the at syntax would be like... c.at(i) = 255? 
20151210 11:48:40-!- travis-ci [~travis-ci@ec2-54-161-132-221.compute-1.amazonaws.com] has joined #wesnoth-dev
20151210 11:48:40< fabi> yes
20151210 11:48:41< travis-ci> wesnoth/wesnoth#7903 (master - 956e5f9 : Charles Dang): The build was broken.
20151210 11:48:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/96006192
20151210 11:48:41-!- travis-ci [~travis-ci@ec2-54-161-132-221.compute-1.amazonaws.com] has left #wesnoth-dev []
20151210 11:51:15< vultraz> will I still be able to access the .c_str() member?
20151210 11:52:10< fabi> why shouldn't you?
20151210 11:53:53 * vultraz takes a look at the travis log
20151210 11:53:56< vultraz> welll fuck
20151210 12:17:46-!- travis-ci [~travis-ci@54.161.132.221] has joined #wesnoth-dev
20151210 12:17:47< travis-ci> wesnoth/wesnoth#7904 (master - 0d8c008 : Charles Dang): The build was broken.
20151210 12:17:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/96006581
20151210 12:17:47-!- travis-ci [~travis-ci@54.161.132.221] has left #wesnoth-dev []
20151210 12:19:08< vultraz> but how do I reproduce that :|
20151210 12:27:23-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151210 12:31:26-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 272 seconds]
20151210 12:31:27-!- wedge010 is now known as wedge009
20151210 12:47:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151210 12:48:35-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20151210 12:52:39-!- aquileia [~chatzilla@eduroam174-172.wlan.uni-ulm.de] has joined #wesnoth-dev
20151210 12:57:33< aquileia> zookeeper: Out of interest, wouldn't it make sense if a sun/moon shaman can only heal units during the favorable TOD? That would also prevent them from being OP compared to the druid line
20151210 12:58:26< zookeeper> aquileia, yeah, possibly. i've been trying to think up different ways to handle that tree.
20151210 12:58:30< aquileia> It might unnecessarily complicate things, though
20151210 12:58:40-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20151210 13:00:40< aquileia> Oh, I just noticed the 1.13.2 deadline is 0:00, not 23:59... damn, one day less
20151210 13:26:59-!- Kwandulin [~Miranda@p200300760F250ADE24F63D7EE18BB58B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151210 13:35:08-!- fendrin [~quassel@176.6.16.11] has joined #wesnoth-dev
20151210 13:35:08-!- fendrin [~quassel@176.6.16.11] has quit [Changing host]
20151210 13:35:08-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151210 13:35:24-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 272 seconds]
20151210 13:42:29-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 246 seconds]
20151210 13:45:14-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20151210 13:48:27-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20151210 13:58:03-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 260 seconds]
20151210 14:00:16-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20151210 14:11:15-!- irker925 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151210 14:18:34-!- aquileia [~chatzilla@eduroam174-172.wlan.uni-ulm.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 42.0/20151029151421]]
20151210 14:18:34-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151210 14:35:45-!- gfgtdf [~chatzilla@f054170249.adsl.alicedsl.de] has joined #wesnoth-dev
20151210 14:36:50< gfgtdf> vultraz: do you know whyt your string_to_color function does ?
20151210 14:40:59-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 245 seconds]
20151210 14:54:56< gfgtdf> vultraz: please dont so such experients, specially not shortly before a release.
20151210 14:58:43-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20151210 14:59:40-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151210 15:00:14-!- louis94 [~~louis94@109.129.245.154] has quit [Client Quit]
20151210 15:01:42-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151210 15:01:51-!- louis94 [~~louis94@109.129.245.154] has quit [Client Quit]
20151210 15:02:42-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151210 15:09:46-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 272 seconds]
20151210 15:11:25-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151210 15:22:52-!- mjs-de [~mjs-de@77.182.143.101] has joined #wesnoth-dev
20151210 16:11:15-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20151210 16:15:55-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151210 16:24:34-!- twospeed [43ad07c6@gateway/web/freenode/ip.67.173.7.198] has joined #wesnoth-dev
20151210 16:37:28-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20151210 16:37:28-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20151210 16:37:28-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151210 16:46:21-!- irker131 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151210 16:46:21< irker131> wesnoth: gfgtdf wesnoth:master 667d6910bedb / changelog: Update changelog http://git.io/v0v6Y
20151210 17:12:06-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds]
20151210 17:17:42-!- fendrin [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 272 seconds]
20151210 17:19:35-!- Kwandulin [~Miranda@p200300760F250ADE24F63D7EE18BB58B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151210 17:24:28-!- travis-ci [~travis-ci@ec2-54-80-58-45.compute-1.amazonaws.com] has joined #wesnoth-dev
20151210 17:24:29< travis-ci> wesnoth/wesnoth#7905 (master - 667d691 : gfgtdf): The build is still failing.
20151210 17:24:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/96071862
20151210 17:24:29-!- travis-ci [~travis-ci@ec2-54-80-58-45.compute-1.amazonaws.com] has left #wesnoth-dev []
20151210 17:25:48-!- fabi [~quassel@176.6.16.11] has joined #wesnoth-dev
20151210 17:25:48-!- fabi [~quassel@176.6.16.11] has quit [Changing host]
20151210 17:25:48-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151210 17:27:42-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 256 seconds]
20151210 17:51:23-!- Kwandulin [~Miranda@p200300760F250ADE792C4427CF454436.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151210 18:36:47-!- kidneb [kidneb@not.allthetime.xyz] has quit [Max SendQ exceeded]
20151210 18:36:59-!- kidneb [~kidneb@not.allthetime.xyz] has joined #wesnoth-dev
20151210 18:46:20-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20151210 18:56:56-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151210 18:57:11-!- louis94 [~~louis94@109.129.245.154] has quit [Remote host closed the connection]
20151210 19:09:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 272 seconds]
20151210 19:41:38-!- JordiGH [~jordi@octave/developer/JordiGH] has joined #wesnoth-dev
20151210 19:42:11< JordiGH> So, is the ship still sinking? http://forums.wesnoth.org/viewtopic.php?t=42912
20151210 19:46:30-!- irker131 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151210 19:47:23-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151210 20:00:21< celticminstrel> Dunno.
20151210 20:00:37< celticminstrel> I do know that there are several new people working on it though, so maybe not.
20151210 20:04:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151210 20:41:46< gfgtdf> so 1.13.2 will be in 2 hours?
20151210 20:53:32< celticminstrel> I guess you did go through all your commits and make sure they're in the changelog, then.
20151210 20:54:15< celticminstrel> It looks like vultraz forgot to include his last-minute [print] thing in the changelog though.
20151210 20:54:29< gfgtdf> celticminstrel: that was a question
20151210 20:54:42< gfgtdf> celticminstrel: i'll rever the print change since it has may bugs
20151210 20:54:44< gfgtdf> revert
20151210 20:54:50< celticminstrel> It does?
20151210 20:55:13< gfgtdf> celticminstrel: look at the code: https://github.com/wesnoth/wesnoth/commit/dcb265ae701d14fecdc66097d7ee26cd05abb080
20151210 20:55:59< celticminstrel> ...I guess it could crash if you don't have four values, eh.
20151210 20:56:10< gfgtdf> celticminstrel: yes that one of the bugs
20151210 20:56:28< gfgtdf> that*s
20151210 20:56:31< gfgtdf> that's
20151210 20:56:44< celticminstrel> Probably should've been a PR instead of being pushed directly to master.
20151210 20:57:25< celticminstrel> It's sort of one of those pointless changes, but (bugs aside) does add the possibility of transparency.
20151210 20:57:43< celticminstrel> Though transparency could just as easily be added with a new alpha= key.
20151210 20:59:52< celticminstrel> (Or an opacity= key, which might be a bit easier for some non-programmers to understand.)
20151210 21:00:48< zookeeper> eh, what part of the WML API does that even affect?
20151210 21:01:12< celticminstrel> The [print] tag. I dunno what that does.
20151210 21:01:33< zookeeper> oh, okay. it's the rarely-used text which appears in the middle of the screen.
20151210 21:01:41< celticminstrel> Ah.
20151210 21:01:59< celticminstrel> I think I remember seeing that in the tutorial scenario.
20151210 21:02:11< zookeeper> but yeah, of course the alpha component should default to opaque in those kind of things.
20151210 21:02:19< celticminstrel> Of course.
20151210 21:03:37< celticminstrel> With those commits it looks like the alpha component will be read from out-of-bounds memory.
20151210 21:04:57< celticminstrel> Though of course, it's safe as long as you don't actually use the color= key.
20151210 21:11:48< shadowm> celticminstrel: How can you not know if you are a developer? :p
20151210 21:12:11< shadowm> I'd certainly say yes it's still sinking seeing as how I can't even get people to respond to a simple question in the mailing list.
20151210 21:12:32-!- irker951 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151210 21:12:32< irker951> wesnoth: gfgtdf wesnoth:master d7acb178d28b / src/ (9 files in 5 dirs): Revert "Added util function for converting an RGB string to color" http://git.io/v0JuR
20151210 21:12:32< irker951> wesnoth: gfgtdf wesnoth:master 7f13156c289d / / (43 files in 14 dirs): Revert "Rename team_name/user_team_name to team_id/team_name (old syntax still v http://git.io/v0Ju0
20151210 21:12:41-!- JordiGH [~jordi@octave/developer/JordiGH] has left #wesnoth-dev ["Leaving"]
20151210 21:13:14< celticminstrel> Some people did respond in IRC, didn't they?
20151210 21:13:33< shadowm> Only about the first section.
20151210 21:15:16< shadowm> gfgtdf: Thanks for those reverts.
20151210 21:28:17-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151210 21:30:05< vultraz> gfgtdf: what do you mean do I know what it does?  
20151210 21:30:11-!- Kwandulin [~Miranda@p200300760F250ADE792C4427CF454436.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151210 21:31:14< celticminstrel> Huh?
20151210 21:31:43< vultraz> celticminstrel: hm?
20151210 21:32:00< fabi> öm
20151210 21:32:12< vultraz> :| 
20151210 21:32:13< gfgtdf> vultraz: forget it, i reverted it. At first i didnt see what string_to_color was supposed to do
20151210 21:33:18< vultraz> alright
20151210 21:33:25< vultraz> I'll try again after the release 
20151210 21:33:43< vultraz> since I have absolutely no idea why it caused the tests to segfault
20151210 21:34:00< celticminstrel> It was pretty obvious why.
20151210 21:34:06< fabi> I told you.
20151210 21:34:14< celticminstrel> Or at least, one possible reason why it could segfault was obvious.
20151210 21:34:15< fabi> out of boundary thingy 
20151210 21:34:28< celticminstrel> By the way, what was the goal in doing that?
20151210 21:35:05< gfgtdf> vultraz: the other issue is, that: *str.c_str() is not a good way to parse a string to a number.
20151210 21:35:13< vultraz> celticminstrel: allow color="255,255,255" instead of red,green,blue="255,255,255"
20151210 21:35:44< celticminstrel> That's not even parsing. It'll get you the first digit's ASCII code.
20151210 21:35:47< celticminstrel> vultraz: Why?
20151210 21:36:57< fabi> celticminstrel: Parsing means building a tree structure out of a linear one. I guess you meant "That is not even lexing?"
20151210 21:38:05< vultraz> celticminstrel: I thought it could be a small simplification 
20151210 21:38:27< vultraz> since I never understood why it was split into three keys
20151210 21:38:39< vultraz> gfgtdf: what would be a better way, then?
20151210 21:38:41< celticminstrel> vultraz: It's really a case of fixing something that's not broken.
20151210 21:38:54< fabi> depends on
20151210 21:38:55< vultraz> celticminstrel: as you know, I like to do that :P
20151210 21:39:23< fabi> if there are more colors with different syntaxes out there.
20151210 21:39:42< fabi> Then I would unifying their syntax call a fix.
20151210 21:39:43< celticminstrel> fabi: I'm going to stick to my phrasing.
20151210 21:40:18< shadowm> We might want to allow HSL or HSV colors in some places later so how about you leave it as-is?
20151210 21:40:25< celticminstrel> If we supported specifying colours by cmyk or hsv or hsb or whatever, then perhaps it would be better to have a single color key.
20151210 21:40:46< celticminstrel> However, when only rgb colours are supported, there is literally no advantage in using a color key.
20151210 21:41:02< vultraz> I considered that
20151210 21:41:04< celticminstrel> There was one minor improvement which from the sounds of it was just an accident, and that's support for opacity.
20151210 21:41:26< celticminstrel> (Wait, is HSV and HSB the same thing?)
20151210 21:41:38< vultraz> But ok
20151210 21:41:47< vultraz> It was a bad experiment  
20151210 21:41:51< shadowm> shikadibot: part
20151210 21:41:51-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has left #wesnoth-dev []
20151210 21:42:06< celticminstrel> But support for opacity is easily added by just using a new key for it.
20151210 21:42:09< vultraz> How could i have done it better 
20151210 21:43:32< gfgtdf> vultraz: you coudl for example find out how [label] parses the color attribute
20151210 21:43:39< gfgtdf> vultraz: and copy that
20151210 21:43:53< fabi> celticminstrel: Well, then I hope the others recognize that you used the term wrongly.
20151210 21:47:36< vultraz> hm, yes... [label] does use a single color=key
20151210 21:47:36-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151210 21:48:05< celticminstrel> Parsing and lexing are closely related. I think the usage was reasonable... especially since I was saying what it's not, and if it's not lexing then surely it's not parsing either. Plus lexing is generally followed by parsing anyway, and not all parsers are preceded by a lexer, so lexing is often like a component in the larger process of parsing.
20151210 21:48:46< fabi> And there we have multiple syntaxes for the same issue. 
20151210 21:49:06< celticminstrel> vultraz: Actually, that in itself is a good reason to do this change. Keep things consistent. Of course... it would be an equally good reason to change [label] to user red,green,blue.
20151210 21:49:17< celticminstrel> By the way, aren't there also places that use r,g,b keys for colours?
20151210 21:49:43< fabi> celticminstrel: So using a function which takes only one char is not even parsing, while using a function which would have read more than one care would have been parsing? Especially in that context...
20151210 21:49:45< celticminstrel> ^use not user
20151210 21:50:02< fabi> s/care/char
20151210 21:50:13< vultraz> There might be but I'm not 100% sure
20151210 21:50:19< celticminstrel> Animations maybe?
20151210 21:50:25< celticminstrel> Or certain ActionWML tags.
20151210 21:50:38< celticminstrel> Those related to animations or text.
20151210 21:51:14< celticminstrel> Actually I guess only those related to text, but some of those are also related to animations since floating text is a component of the animation system. (So, [animate_unit] or [unstore_unit].)
20151210 21:51:41-!- travis-ci [~travis-ci@ec2-54-80-58-45.compute-1.amazonaws.com] has joined #wesnoth-dev
20151210 21:51:41< shadowm> Ugh why does CMake compile translations while running the install target as root. Stupid piece of crap.
20151210 21:51:42< travis-ci> wesnoth/wesnoth#7906 (master - 7f13156 : gfgtdf): The build was fixed.
20151210 21:51:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/96132113
20151210 21:51:42-!- travis-ci [~travis-ci@ec2-54-80-58-45.compute-1.amazonaws.com] has left #wesnoth-dev []
20151210 21:51:48< celticminstrel> Oh right, maybe some things related to images... though I think those are generally handled with IPF instead.
20151210 21:52:36< shadowm> And it had _already_ compiled them, this  is beyond ridiculous.
20151210 21:54:32< vultraz> ok, so map labels have their own separate handling of color=
20151210 21:55:14< gfgtdf> vultraz: so ?
20151210 21:56:10< vultraz> so it's both a reference and a case for unifying handling 
20151210 21:56:21< vultraz> (after the release)
20151210 21:58:32-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20151210 21:58:32-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20151210 21:58:32-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151210 21:58:53< fabi> hi iceiceice
20151210 21:59:01< iceiceice> hi fabi
20151210 22:00:34< fabi> It is release time. Even after 7 years that is somehow exiting every time it happens. The channel gets even more angry than usual, when you are no longer part of it, it is fun to watch.
20151210 22:01:02< vultraz> Hah
20151210 22:01:24 * iceiceice checks logs
20151210 22:01:49 * iceiceice makes popcorn
20151210 22:02:03< irker951> wesnoth: Ignacio R. Morelle wesnoth:master 7c5fbd2d750f / doc/man/wesnoth.6: man: Update documentation relevant to bug #23753 http://git.io/v0J9I
20151210 22:03:06< celticminstrel> Whoa manpages.
20151210 22:07:46-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 272 seconds]
20151210 22:08:09< irker951> wesnoth: Ignacio R. Morelle wesnoth:master eb0195835fad / / (1501 files in 51 dirs): pot and documentation update http://git.io/v0JQH
20151210 22:08:37-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151210 22:11:12< irker951> wesnoth: gfgtdf wesnoth:master 1fbf596be176 / RELEASE_NOTES: Update RELEASE_NOTES http://git.io/v0J79
20151210 22:12:20< shadowm> gfgtdf: Is it documented on the wiki yet?
20151210 22:13:29< gfgtdf> shadowm. i think its not
20151210 22:13:49< shadowm> Well, you know what to do then. :p
20151210 22:19:10< shadowm> I keep getting this with some (not all) campaigns: 20151210 19:18:54 warning unit: Unknown attribute 'no_recruit' discarded.
20151210 22:19:19< shadowm> Mainline, of course.
20151210 22:20:33< shadowm> 20151210 19:20:19 error preprocessor: Preprocessor symbol 'CLEAR_VARIABLE' defined at core/macros/utils.cfg:194 expects 1 arguments, but has 3 arguments
20151210 22:20:37< shadowm> at campaigns/The_Rise_Of_Wesnoth/scenarios/22_The_Rise_of_Wesnoth.cfg:1542
20151210 22:21:11< shadowm> gfgtdf: Commit 2a0c24e12f74bdbc710c71089f49c9a6e607650b introduces this probably.
20151210 22:21:31< shadowm> Well, not probably, it's pretty obvious it's the right commit really:
20151210 22:21:32< shadowm> +        {CLEAR_VARIABLE skele_loc, skele_from, skele_type}
20151210 22:22:05< celticminstrel> I've been wondering about the no_recruit message for awhile now but never got around to mentioning it.
20151210 22:22:16< vultraz> I always see the no_recruit thing too
20151210 22:22:20< shadowm> Aaaand Wesnoth quit to desktop after showing the preprocessor errors, instead of returning to the title screen.
20151210 22:22:34< shadowm> The only thing I know is that the exit status is 1, so it wasn't a signal.
20151210 22:22:45< celticminstrel> I think it was happening in the MP scenario that I used for testing various things.
20151210 22:24:16< irker951> wesnoth: gfgtdf wesnoth:master 612f0960a3cc / data/campaigns/The_Rise_Of_Wesnoth/scenarios/22_The_Rise_of_Wesnoth.cfg: attempt to fix wml parsing error in TRoW scenario 22 http://git.io/v0JNf
20151210 22:24:48< shadowm> UtBS, DM, Liberty, and LoW cause the warning.
20151210 22:24:59< zookeeper> parentheses aren't needed (but don't hurt either)
20151210 22:25:13< celticminstrel> Yeah, removing the spaces would've been sufficient.
20151210 22:25:19< gfgtdf> shadowm: the mp connect engne adds no_recruit to [side]s i dont know exactly why
20151210 22:25:29< gfgtdf> celticminstrel: i wanted to be sure :)
20151210 22:25:39< shadowm> Oh, so it's more SP/MP "unification" fall-out.
20151210 22:25:45< zookeeper> gfgtdf, btw why did you want to know about the dark forecast gold variable?
20151210 22:26:02< gfgtdf> zookeeper: becasue i tried to understand what dark forcast does
20151210 22:26:19< gfgtdf> celticminstrel: i never uses that marco in my addons.
20151210 22:26:42< zookeeper> gfgtdf, okay. well, as i said, i don't exactly know :p it's obscure
20151210 22:27:03< gfgtdf> shadowm: well the errormessage is also there in 1.12 in mp
20151210 22:27:20< shadowm> In general, specifying macro arguments in parentheses (or quotes) is used to solve the same whitespace problem.
20151210 22:27:26< gfgtdf> shadowm: actually oyu can mostlikeley easiyl fix it by adding no_rectuit to the list of ignored attributes in [side]
20151210 22:27:38< shadowm> But if the arugment doesn't contain any whitespace then the parentheses become redundant.
20151210 22:27:52< gfgtdf> shadowm: i wanted to be sure :)
20151210 22:28:42< shadowm> Okay, so no_recruit isn't in wiki.wesnoth.org/SideWML , I wonder what it's actually supposed to do and where.
20151210 22:28:57< celticminstrel> I haven't the slightest clue either.
20151210 22:29:06< shadowm> It's used in exactly two places in the engine.
20151210 22:29:15< gfgtdf> shadowm: well yes liek i said before its used internally in the connect engine
20151210 22:29:54< shadowm> So it's not supposed to be a public-facing thing?
20151210 22:30:34< gfgtdf> shadowm: afaik its not.
20151210 22:30:40< gfgtdf> shadowm: but i didnt write that code
20151210 22:31:47< shadowm> So if there's a list of ingored attributes we can add it to, let's do that after 1.13.2 in case that somehow breaks things.
20151210 22:31:55< vultraz> if it doesn't do anything, why not just remove it?
20151210 22:32:20< shadowm> "it's used in exactly two places" -> it does something.
20151210 22:32:33-!- gfgtdf [~chatzilla@f054170249.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20151210 22:32:59< shadowm> It's just not clear whether it's actually needed since I don't know how the MP game setup logic works in detail.
20151210 22:34:40-!- gfgtdf [~chatzilla@f054170249.adsl.alicedsl.de] has joined #wesnoth-dev
20151210 22:34:53< gfgtdf> shadowm: i'm 100% sure that it won't break things
20151210 22:41:32-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151210 22:41:32-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20151210 22:42:32-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151210 22:44:24-!- gfgtdf [~chatzilla@f054170249.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 42.0/20151029151421]]
20151210 23:01:19< shadowm> !time utc
20151210 23:01:25< shadowm> Oh right, I made her quit.
20151210 23:04:07< shadowm> Oh ahahaha, I was thinking in CLT (RIP), not CLST.
20151210 23:04:18< shadowm> You have 55 more minutes.
20151210 23:12:37< zookeeper> btw i wasn't sure if the frantic update is worth mentioning in release notes so i didn't, but don't take that as a reason not to, if you feel like it should be :p
20151210 23:13:10< shadowm> Add it to the changelog.
20151210 23:13:46< shadowm> I'll probably mention it in R_N anyway, like the other myriad of changes that you people don't mention but I end up adding to the post anyway.
20151210 23:14:50< shadowm> R_N really works best in cases where 1) I'm not in the mood for reading the huge changelog; or 2) the change does require a lot more explanation (like most WML syntax changes/additions, the Windows paths thing, etc.) than we can normally afford in the changelog.
20151210 23:18:17< zookeeper> it's in the changelogs, of course
20151210 23:50:41< celticminstrel> Hmm, so maybe I should've added some of my WML things in release notes...
20151210 23:52:49-!- aquileia [~chatzilla@HSI-KBW-078-042-007-104.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20151210 23:58:32< zookeeper> have fun tagging/releasing or whatever all it is that you'll do
--- Log closed Fri Dec 11 00:00:35 2015