--- Log opened Sat Dec 19 00:00:08 2015
20151219 00:02:55-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20151219 00:05:01-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151219 00:09:56-!- Appleman1234 [~Appleman1@KD119104018171.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20151219 00:27:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds]
20151219 00:29:26-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 240 seconds]
20151219 00:29:48-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151219 00:42:01< Aginor> and back
20151219 00:42:06< Aginor> travis is still going
20151219 00:53:03< neverEnough> the "The Hitchhiker's Guide to the Galaxy" explains it will run for thousands generations. The answer will be 42.
20151219 00:55:14< neverEnough> uhm or 42 was the falling whale.. not sure what was the supercomputer answer
20151219 00:55:31< Aginor> the answer to everything was 42
20151219 00:55:52< Aginor> https://github.com/wesnoth/wesnoth/commit/3f9d9ca3399a26aee4a72a223d234c81f5103b13
20151219 00:55:55< Aginor> it is done
20151219 00:56:12< Aginor> shadowm: please feel free to unmute the bot when it suits you
20151219 00:56:30< neverEnough> dumb travis, i thought u built the supercomputer for THE answer
20151219 00:56:49 * Aginor does small happy dance
20151219 01:00:02< neverEnough> yay well done!
20151219 01:00:54< neverEnough> now the code rely on sdl2.0 only?
20151219 01:01:58-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has joined #wesnoth-dev
20151219 01:05:28-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151219 01:05:29< Aginor> neverEnough: SDL1.2 will be kept for 1 release, then we're ripping it out
20151219 01:05:35< Aginor> but yes
20151219 01:06:26-!- Appleman1234 [~Appleman1@KD119104012064.au-net.ne.jp] has joined #wesnoth-dev
20151219 01:07:56<@shadowm> WE HAVE LIFT-OFF
20151219 01:08:25 * Aginor is currently double-checking everything
20151219 01:08:29< Aginor> well
20151219 01:08:35<@shadowm> Aginor: Do you have words for the developers ML perhaps?
20151219 01:08:36< Aginor> more like tripple or quadruple or something
20151219 01:08:53< Aginor> shadowm: I do, I shall send something out in a bit
20151219 01:09:02-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151219 01:09:11< Aginor> I probably need to do a post in the forum too
20151219 01:09:22< Aginor> meaning I need to find my credentials again
20151219 01:09:35-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has joined #wesnoth-dev
20151219 01:20:57-!- mode/#wesnoth-dev [-zqo *!*@uruz.ai0867.net shadowm] by shadowm
20151219 01:27:30< Aginor> does anyone have lipkab's email address?
20151219 01:27:40< Aginor> I've found one at http://wiki.wesnoth.org/Soc2014_lipkab_sdl2
20151219 01:28:52< Aginor> shadowm: do you know of a more current address?
20151219 01:30:38< shadowm> That's his forum account's address, so it's probably goo.d.
20151219 01:30:45< Aginor> thanks
20151219 01:32:13< Aginor> now to make a forum post and update the wiki
20151219 01:50:46-!- Appleman1234 [~Appleman1@KD119104012064.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20151219 01:51:20-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20151219 01:53:24< Aginor> there we go
20151219 01:53:31< Aginor> announcements have been announced
20151219 01:53:39 * Aginor smugly sits back and feels smug
20151219 01:59:15-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151219 01:59:47< Aginor> vultraz: it is done
20151219 02:00:35< vultraz> I just saw :D
20151219 02:01:17< vultraz> now I just need sdl2 libs...
20151219 02:01:48< Aginor> www.libsdl.org
20151219 02:02:06< Aginor> https://www.libsdl.org/projects/SDL_net/
20151219 02:02:18< Aginor> https://www.libsdl.org/projects/SDL_ttf/
20151219 02:02:30< Aginor> https://www.libsdl.org/projects/SDL_mixer/
20151219 02:03:00< Aginor> you will need to recompile the official 2.0.3 if you use VS2015
20151219 02:03:09< vultraz> shadowm: you said mingw64 is needed now, right? 
20151219 02:03:25< vultraz> though I did install VS2015, so I wonder if I should just switch to using that
20151219 02:03:52< Aginor> on a side note, we should submit the missing dependencies to nuget and update our projects to rely on that, especially if we want to move to VS2015
20151219 02:05:57< Aginor> vultraz: mingw64 is needed
20151219 02:06:19< celticminstrel> From the sounds of it, it's easier to use MinGW than VS2015, vultraz.
20151219 02:07:10< vultraz> heh
20151219 02:13:51< vultraz> shadowm: is your dependency package available?
20151219 02:21:31< Aginor> Who is looking after the ios port? And is the money from it going into the project itself?
20151219 02:21:44< Aginor> http://forums.wesnoth.org/viewtopic.php?f=6&t=37879&start=375#p590990
20151219 02:22:03< celticminstrel> I thought the iOS port was abandoned.
20151219 02:22:13< Aginor> it's supposedly still sold
20151219 02:22:25< celticminstrel> That doesn't mean it's not abandoned.
20151219 02:22:35< Aginor> https://itunes.apple.com/us/app/battle-for-wesnoth/id575239775?mt=8
20151219 02:23:27< Aginor> https://itunes.apple.com/us/app/battle-for-wesnoth-hd/id575852062?mt=8
20151219 02:23:55< celticminstrel> So yeah, looks abandoned to me.
20151219 02:24:02< Aginor> it's still for sale though
20151219 02:24:16< celticminstrel> Obviously.
20151219 02:24:16< Aginor> so not that abandoned :)
20151219 02:24:29< celticminstrel> No, look at the "Updated" date.
20151219 02:24:39< Aginor> that's a difference though
20151219 02:24:50< celticminstrel> ?
20151219 02:25:30< Aginor> maybe nobody is maintaining it any longer (ie, abandoned in that sense), but it someone still selling it and taking the profits?
20151219 02:25:48< celticminstrel> That's a very good question.
20151219 02:26:44< vultraz> It provides money to the project
20151219 02:27:10< celticminstrel> You're sure about that?
20151219 02:27:14< Aginor> if we use it to provide money to the project, should we also try to support it?
20151219 02:33:21-!- gfgtdf_ [~chatzilla@f054138070.adsl.alicedsl.de] has joined #wesnoth-dev
20151219 02:34:52-!- gfgtdf [~chatzilla@f050182218.adsl.alicedsl.de] has quit [Ping timeout: 256 seconds]
20151219 02:34:58-!- gfgtdf_ is now known as gfgtdf
20151219 02:36:21< vultraz> Aginor: we don't have anyone who can maintain a port, let alone do the necessary things to truly support mobile platforms (like adding 3D touch support and making the UI better touch-compatible) 
20151219 02:37:48< vultraz> who can also maintain it on a regular basis along with the standard release cycle
20151219 02:38:01< vultraz> and test it on every new iOS release 
20151219 02:38:02< Aginor> given that, should we try to update the page on the apple app store to reflect that?
20151219 02:38:30< loonycyborg> there's also android port, and it's updated in timely manner
20151219 02:39:15< Aginor> loonycyborg: sorry, I just realised I forgot to add you in my acknowledgements for the SDL2 work earlier
20151219 02:39:38< Aginor> loonycyborg: I appreciate the help you've given
20151219 02:39:47< loonycyborg> np
20151219 02:40:13< loonycyborg> though would be really nice if wesnoth hd proper touch support too
20151219 02:40:20< loonycyborg> *hd
20151219 02:40:26< loonycyborg> *had
20151219 02:40:30< Aginor> loonycyborg: it's in the realm of possibility now
20151219 02:40:46< Aginor> we're getting the events, or would be, they're just not handled
20151219 02:40:49< loonycyborg> the hardest part would be to adapt the gui
20151219 02:40:52< Aginor> yes
20151219 02:41:08< Aginor> maybe
20151219 02:41:09< loonycyborg> because buttons are too small to catch with finger :P
20151219 02:41:26< vultraz> I honestly have no idea how people play wesnoth on an iphone
20151219 02:41:31< Aginor> if we ignore dragging/gestures it might be reasonable
20151219 02:41:33< vultraz> An ipad, mayyybe
20151219 02:41:39< vultraz> and ipad pro, certainly 
20151219 02:44:20< vultraz> Aginor: but couldn't dragging be used to move units
20151219 02:44:36< vultraz> and don't gestures need to be used to scroll
20151219 02:47:41-!- Appleman1234 [~Appleman1@KD119104013100.au-net.ne.jp] has joined #wesnoth-dev
20151219 02:52:11< ancestral> Aginor: Building master with SDL2! :-D
20151219 02:52:52< ancestral> vultraz: In SDL1 I couldn’t scroll around with a trackpad
20151219 02:52:58< ancestral> I think maybe SDL2 will let me?
20151219 02:53:05< ancestral> I remember looking this up ages ago
20151219 02:54:49< ancestral> http://r.wesnoth.org/t24070
20151219 02:56:27< ancestral> So, I might be able to horizontally scroll without holding down a modifier key!
20151219 02:58:55< ancestral> Okay, got an error
20151219 02:59:32< ancestral> Undefined symbols for architecture x86_64:   "_OBJC_CLASS_$_SDLApplication", referenced from:       objc-class-ref in SDLMain.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation
20151219 03:01:07< ancestral> Ohhhhh
20151219 03:01:19< ancestral> Maybe I need a new SDLMain file?
20151219 03:08:04< ancestral> Oof, looks like it has two lines commented out, presumably for SDL2, which uses a deprecated method from 10 years ago
20151219 03:08:10-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20151219 03:08:36< mattsc> ancestral: hi — just checking in for a couple minutes
20151219 03:08:43< ancestral> Hi!
20151219 03:09:08< mattsc> You probably also need to replace the 5 SDL frameworks, I think
20151219 03:09:25< ancestral> I fif that
20151219 03:09:27< ancestral> *did
20151219 03:09:36< mattsc> Oh, ok.  Cool.
20151219 03:09:45< ancestral> Building worked great, up until the end and my error from 10 minutes ago
20151219 03:09:58< ancestral> I think it’s talking about SDLMain
20151219 03:10:12< ancestral> which is a maccompilestuff thing
20151219 03:10:30< mattsc> I’m just here to say that I do search the logs for my nick at least every other day, but I don’t always have time to read them all.  And I probably won’t be around regularly a lot until ...
20151219 03:10:40< mattsc> June, maybe.  Or 2024 …  Or something
20151219 03:11:00< ancestral> That’s fine
20151219 03:11:09< ancestral> Or Tuesday
20151219 03:11:10< ancestral> I get it
20151219 03:11:11< ancestral> ;-)
20151219 03:11:20< mattsc> exactly  :)
20151219 03:11:40< mattsc> But as I said, I do search for my nick and am happy to come online when I can.
20151219 03:12:27< mattsc> Anyways, just wanted to say this since I had been gone for 2 weeks straight, I think.
20151219 03:13:01< ancestral> Well I made a hi-res icon from vultraz/Sgt. Groovy’s work
20151219 03:14:15< mattsc> I did see and download that.  :)
20151219 03:15:08< ancestral> and this sexy thing: http://i.imgur.com/hsFTbzm.png
20151219 03:16:17< ancestral> mattsc: I installed MacPorts recently and I am going to try building pango. Hopefully fix the pango issues we were running into
20151219 03:16:39< ancestral> But I need to get SDL2 running first, now that it’s merged
20151219 03:16:56< ancestral> *get Wesnoth running with
20151219 03:17:37< shadowm> vultraz: My what now?
20151219 03:18:08< vultraz> shadowm: you were building with sdl2 using cb and I wondered if you had an archive of the assembled libs
20151219 03:18:54< shadowm> I can make one if you don't want to hunt them down yourself.
20151219 03:18:56< ancestral> Aginor: Some people know more, but there are/were two iOS ports. One was abandoned, the other “superseded” it
20151219 03:19:41< shadowm> I'm just not very available tonight.
20151219 03:20:22< vultraz> That'd be helpful
20151219 03:20:32< vultraz> I have some already, but it'd be easier to use what works
20151219 03:22:14< shadowm> Also, my connection is being liquid **** and I can't find a more appropriate location for catching some waves.
20151219 03:22:43< shadowm> So I'd rather get that sorted out before attempting to upload anything.
20151219 03:23:00-!- Appleman1234 [~Appleman1@KD119104013100.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20151219 03:25:24< Aginor> ancestral: did you get past that error?
20151219 03:25:43< ancestral> Not yet
20151219 03:26:30< Aginor> you're building with xcode?
20151219 03:26:35< ancestral> Yes
20151219 03:26:42< ancestral> I suppose I could try homebrew
20151219 03:27:27< Aginor> that'll work, but it'll require code changes
20151219 03:27:36< Aginor> (it's how I've been testing)
20151219 03:27:56< Aginor> we did get it going with xcode as well though, it might be that someone's broken something since
20151219 03:28:03< ancestral> Aginor: If you’re curious, the error: https://paste.ee/p/41HPZ
20151219 03:28:17< ancestral> And SDLMain.m: https://paste.ee/p/zHhuN
20151219 03:29:13< celticminstrel> Eh...
20151219 03:29:23< Aginor> umm
20151219 03:29:39< celticminstrel> Well I guess if you remove the second #if SDL_VERSION_ATLEAST and the matching #endif
20151219 03:29:42< Aginor> line 80 is proof that I've been there and mucked about with it, with celticminstrel if memory serves
20151219 03:29:51< celticminstrel> Those were there because I got some kind of warning about duplicate classes.
20151219 03:30:46< celticminstrel> I don't know why I got that warning, but I guess getting the warning (if it wasn't something related to partial recompilation) is better than failing to compile on some systems.
20151219 03:30:51< Aginor> ancestral: if it tries to use SDL_Main it implies it's got an SDL1 header
20151219 03:30:52< ancestral> I can tell you this
20151219 03:31:07< ancestral> poseAsClass is deprecated
20151219 03:31:12< ancestral> But that line is commented out
20151219 03:31:32< ancestral> Hmm
20151219 03:31:38< celticminstrel> You see how the implementation of SDLApplication is omitted by #ifdefs?
20151219 03:31:54< celticminstrel> I suppose that'd be the cause of the error.
20151219 03:32:24< ancestral> Ah
20151219 03:32:27< ancestral> Okay
20151219 03:35:14< ancestral> So line 19
20151219 03:35:17< ancestral> I took out the !
20151219 03:35:53< Aginor> works?
20151219 03:36:08< ancestral> And that works
20151219 03:36:18< ancestral> And it looks beautiful
20151219 03:37:01< Aginor> excellent
20151219 03:37:13< Aginor> I say: take out that entire #ifdef and commit
20151219 03:37:30< Aginor> (might be worth testing with SDL1 too though :) )
20151219 03:37:39< celticminstrel> ^
20151219 03:37:46< celticminstrel> Take out the whole #ifdef
20151219 03:38:06< celticminstrel> Otherwise it won't compile with SDL1.
20151219 03:38:14< celticminstrel> (Giving the same error.)
20151219 03:38:18< mattsc> ancestral: great  :)
20151219 03:38:32< ancestral> \o/
20151219 03:38:44< Aginor> nice job!
20151219 03:38:45< mattsc> indeed
20151219 03:39:32< mattsc> ancestral: I need to go again, just one quick question
20151219 03:40:02< mattsc> are you going to update the repository and/or Mac compile stuff archive as needed?
20151219 03:40:15< ancestral> mattsc: Yes, I will most certainly
20151219 03:40:28< ancestral> With the new SDL2 libs
20151219 03:40:42< ancestral> And hopefully a functional, multi-version compatible pango lib
20151219 03:40:45< mattsc> ancestral: great, thanks.  Ping me here if you want me to do or test something.
20151219 03:40:53< celticminstrel> And Boost unit tests?
20151219 03:40:55< ancestral> mattsc: I will when I get there, thanks
20151219 03:41:02< ancestral> celticminstrel: That’s right! Yes
20151219 03:41:04< mattsc> As I said, I almost always see that within 48 hours, even with my current crazy travel schedule.
20151219 03:41:17< ancestral> Thanks for your lurkiness
20151219 03:41:24< ancestral> Ha! Two-finger scrolling works
20151219 03:41:38< mattsc> As you might or might not know, my campaign features as lurker unit  ;)
20151219 03:41:50< ancestral> !
20151219 03:41:51< ancestral> fitting
20151219 03:42:41< mattsc> Okay, got to go again.  Cheers (for now), everybody.
20151219 03:43:06< ancestral> See ya!
20151219 03:43:28-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20151219 04:02:06-!- gfgtdf [~chatzilla@f054138070.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 42.0/20151029151421]]
20151219 04:05:32-!- irker665 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151219 04:20:19-!- Appleman1234 [~Appleman1@KD119104018244.au-net.ne.jp] has joined #wesnoth-dev
20151219 04:25:21-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 265 seconds]
20151219 04:25:39< Aginor> ancestral: close the bug for two finger scrolling if there is one :)
20151219 04:39:09< ancestral> One thing I’m failing to figure out
20151219 04:39:17< ancestral> And I feel bad because I’ve asked this before
20151219 04:39:28< ancestral> But IIRC it was “wait until SDL2”
20151219 04:39:50< Aginor> hmm?
20151219 04:40:00< ancestral> Okay, now I remember. Fontconfig
20151219 04:40:10-!- wedge009 [~Thunderbi@60.241.236.92] has joined #wesnoth-dev
20151219 04:40:16< ancestral> Most elements in the game are not drawn with DejaVu
20151219 04:40:21< ancestral> Text, I mean
20151219 04:40:40< ancestral> The loading screen, MP, HP and similar labels are drawn in DejaVU
20151219 04:41:01< ancestral> The rest of the game text, most of the buttons, dialogs etc. are all drawn in a system font
20151219 04:41:19< Aginor> label drawing has 2 or 3 implementations :/
20151219 04:41:51< Aginor> it's followed from the gui2 efforts
20151219 04:42:45< ancestral> All of the game text, too?
20151219 04:43:05< ancestral> Like, unit dialog stuff at the bottom
20151219 04:43:11< Aginor> I think most of it comes from the gui 1 labels
20151219 04:43:23< ancestral> Okay, so that hasn’t been converted yet
20151219 04:43:52< Aginor> not sure about that, I haven't had the reason to read that code yet :)
20151219 04:44:38< ancestral> So what I did was replace DejaVuSans.ttf with DejaVuSerif.ttf
20151219 04:45:42< ancestral> And much of the rest of the game still renders in sans-serif. In Helvetica, not DejaVu
20151219 04:46:18< ancestral> Anyway, I remembered there used to be a .cfg file that allowed the game to choose a default font that superseded the system default for text
20151219 04:48:29< ancestral> I should check with 1.12
20151219 04:49:03< Aginor> I don't know, sorry
20151219 04:49:41< ancestral> No problem
20151219 04:50:38-!- celticminstrel is now known as celmin|sleep
20151219 04:55:11-!- Appleman1234 [~Appleman1@KD119104018244.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20151219 05:40:21-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151219 05:42:11-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has joined #wesnoth-dev
20151219 05:52:04-!- Appleman1234 [~Appleman1@KD119104016095.au-net.ne.jp] has joined #wesnoth-dev
20151219 06:21:01-!- Kwandulin [~Miranda@p200300760F250AFC4C642A1CAB5F4F76.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151219 06:54:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151219 06:57:46-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151219 07:02:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20151219 07:03:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151219 07:07:15-!- Kwandulin [~Miranda@p200300760F250AFC4C642A1CAB5F4F76.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20151219 07:35:10-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has joined #wesnoth-dev
20151219 07:40:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20151219 07:40:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20151219 07:40:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20151219 07:41:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151219 07:50:47-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20151219 07:51:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151219 07:59:26-!- Appleman1234 [~Appleman1@KD119104016095.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20151219 08:00:50-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20151219 08:01:05-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151219 08:12:47-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151219 08:12:48-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20151219 08:13:42-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151219 08:23:43< shadowm> vultraz: https://dl.dropboxusercontent.com/u/21371130/junk/sdl2-i686-w64-mingw32.tar.gz
20151219 08:25:34< shadowm> I'd like to remind you people that today Saturday will be my last day of guaranteed availability, so if you need me for something you'd better get my attention now or wait till after January 12th.
20151219 08:26:02< shadowm> (With that said, I'm on my way out right now, so, later I guess.)
20151219 08:26:37< vultraz> I can't think of anything else
20151219 08:26:39< vultraz> Thanks
20151219 08:31:59-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20151219 08:33:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151219 08:45:32-!- Kwandulin [~Miranda@p200300760F250ABEE0646F7017869946.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151219 08:45:58< Aginor> shadowm: enjoy your time off and take care of yourself
20151219 08:51:34-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151219 08:57:18-!- Appleman1234 [~Appleman1@KD119104003227.au-net.ne.jp] has joined #wesnoth-dev
20151219 09:11:46-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20151219 09:13:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151219 09:14:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20151219 09:17:25-!- Jabbers [~Rualirr@c-24-21-217-33.hsd1.or.comcast.net] has joined #wesnoth-dev
20151219 09:17:41-!- Jabbers [~Rualirr@c-24-21-217-33.hsd1.or.comcast.net] has left #wesnoth-dev []
20151219 09:23:59-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 255 seconds]
20151219 09:29:03-!- prkc [~prkc@54008B14.dsl.pool.telekom.hu] has joined #wesnoth-dev
20151219 09:30:59-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20151219 09:31:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151219 09:32:06-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 272 seconds]
20151219 09:34:23-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20151219 09:34:46-!- Kwandulin [~Miranda@p200300760F250ABEE0646F7017869946.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151219 09:34:48-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151219 09:49:36-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151219 09:53:20-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds]
20151219 10:12:27< vultraz> gfgtdf: shouldn't [terrain_mask] be included in 811aeeffad643f49a08eea1a16af2acdd23e4180?
20151219 10:37:22-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20151219 10:37:27-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20151219 10:37:46-!- VultCave is now known as vultraz
20151219 10:58:18-!- prkc [~prkc@54008B14.dsl.pool.telekom.hu] has quit [Ping timeout: 265 seconds]
20151219 11:05:21-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151219 11:13:41-!- prkc [~prkc@54008B14.dsl.pool.telekom.hu] has joined #wesnoth-dev
20151219 11:14:52-!- mjs-de [~mjs-de@f049170040.adsl.alicedsl.de] has joined #wesnoth-dev
20151219 11:24:36-!- markus_ [~mjs-de@x4db53874.dyn.telefonica.de] has joined #wesnoth-dev
20151219 11:26:12-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20151219 11:26:12-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151219 11:28:06-!- mjs-de [~mjs-de@f049170040.adsl.alicedsl.de] has quit [Ping timeout: 256 seconds]
20151219 12:35:32-!- Appleman1234 [~Appleman1@KD119104003227.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20151219 13:07:24-!- Kwandulin [~Miranda@p200300760F250ABEB8A0B7DBF394DB83.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151219 13:13:18< Rhonda> shadowm: I wonder if that could be done inside a vhost - then I'll add it right now to www, forum and the likes.
20151219 13:23:57-!- fendrin is now known as fabi
20151219 13:25:22-!- nurupo_ [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20151219 13:25:28< Rhonda> Hmm, the header doesn't seem to get sent …
20151219 13:27:47-!- nurupo_ is now known as nurupo
20151219 13:28:45< Rhonda> Googled, seems to be "always set" instead of "add".
20151219 13:29:10< Rhonda> I see the response in the headers now I get from the server, but my webbrowser doesn't switch to https?
20151219 13:31:46< Rhonda> Ha, we are A+ now because of HSTS.  :D
20151219 13:33:34-!- Appleman1234 [~Appleman1@KD119104004241.au-net.ne.jp] has joined #wesnoth-dev
20151219 13:50:35< vultraz> time to get my SDL2 build up and running
20151219 13:59:14< vultraz> so far so good...
20151219 14:00:55-!- markus_ is now known as mjs-de
20151219 14:22:29< vultraz> gah
20151219 14:27:09< vultraz> some reason it can't find any of the libs...
20151219 14:34:09< vultraz> well this is frustrating 
20151219 14:38:34< vultraz> I'm stumped :|
20151219 14:39:17< vultraz> oh
20151219 14:40:00< vultraz> "skipping incompatible"
20151219 14:40:03< vultraz> but why
20151219 14:40:11< celmin|sleep> Huh?
20151219 14:40:55< vultraz> trying to get my wesnoth sdl2 build up and running
20151219 14:41:06< vultraz> linker is failing
20151219 14:41:22< vultraz> er
20151219 14:41:25< vultraz> wait, hm
20151219 14:41:37< vultraz> does mingw64 mean tdm gcc64 is needed?
20151219 14:44:09< vultraz> ok im confused..
20151219 14:46:33< vultraz> ok let's try this
20151219 15:00:02-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20151219 15:04:33< vultraz> ok this is better
20151219 15:04:39< vultraz> just some undefined references now...
20151219 15:05:16< vultraz> SDL_SetAlpha, SDL_LinkedVerison, and SDL_GetAppState
20151219 15:07:22< vultraz> Aginor: are these sdl1 or 2?
20151219 15:07:41< vultraz> (maybe celmin|sleep knows? )
20151219 15:08:02-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has joined #wesnoth-dev
20151219 15:08:22< vultraz> (or uh.. ancestral? )
20151219 15:08:29< vultraz> ancestral: you got your sdl2 build working right?
20151219 15:08:34< ancestral> Yes
20151219 15:08:53-!- gfgtdf [~chatzilla@f054138070.adsl.alicedsl.de] has joined #wesnoth-dev
20151219 15:09:18< gfgtdf> vultraz: < tha shoudla lso applay_tpo_terrina mask
20151219 15:09:49< vultraz> ancestral: did you get undefined references to SDL_SetAlpha, SDL_LinkedVerison, and/or SDL_GetAppState?
20151219 15:09:59< gfgtdf> vultraz: which compilre are you using?
20151219 15:10:05< vultraz> not sure if im missing a file in my compiler list or i forgot to remove one
20151219 15:10:12< vultraz> gfgtdf: tdm gcc 5.1
20151219 15:11:13< ancestral> No, I didn’t
20151219 15:13:15< gfgtdf> vultraz: from hwere did you get an aeeor about 'SDL_LinkedVerison'
20151219 15:13:28< gfgtdf> vultraz: that function doesnt seems to exist in any sdl version
20151219 15:13:51< gfgtdf> vultraz: 0 matches on google for 'SDL_LinkedVerison'
20151219 15:14:57-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 265 seconds]
20151219 15:20:37< gfgtdf> i thinkwe shoudl unify all event names to eigher use all spaces or all to use underscrores
20151219 15:20:53< gfgtdf> the filter for event] name= treats them the same
20151219 15:21:05< gfgtdf> but afaik on_event does not by deault
20151219 15:21:31< gfgtdf> any opionipn on whether to use underscrored or spaces there ?
20151219 15:22:26-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151219 15:34:01< celmin|sleep> If on_event doesn't treat them the same, we should change that.
20151219 15:34:36< celmin|sleep> Though I suppose if there's an issue with on_event it's more of which representation to present it as.
20151219 15:35:00< vultraz> gahh
20151219 15:35:18< vultraz> for some reason it's not seeing the compat version of setalpha et al
20151219 15:35:46< celmin|sleep> Still, you could do something weird like passing it as a userdata which compares equal both to spaced versions and underscored versions (and even mixed versions).
20151219 15:36:08< celmin|sleep> vultraz: Maybe one file isn't getting compiled?
20151219 15:36:31< vultraz> it's in the file list...
20151219 15:37:48< celmin|sleep> Did you do a clean build?
20151219 15:37:59< vultraz> yes
20151219 15:38:21< vultraz> ... SDL_Linked_Version shouldn't even be seen.. it's behind and ifdef
20151219 15:38:30< vultraz> I'm going to try building again one more time..
20151219 15:38:35< celmin|sleep> ifdef what?
20151219 15:39:44-!- Appleman1234 [~Appleman1@KD119104004241.au-net.ne.jp] has quit [Ping timeout: 255 seconds]
20151219 15:40:23< vultraz> er, not an ifdef
20151219 15:40:32< vultraz> just the standard #if SDL_VERSION_ATLEAST(2,0,0)
20151219 15:40:51< gfgtdf> celmin|sleep: you you think [fire_event] "a_b" and [fire_event] "a b" shoudl result int the same string paees to on_event?
20151219 15:41:06< celmin|sleep> Ideally, yes.
20151219 15:41:37< celmin|sleep> vultraz: That implies it should be seen when compiling with SDL2, unless you missed a ! in there.
20151219 15:41:57< vultraz> ugh i can't talk
20151219 15:42:01< vultraz> celmin|sleep: it's in the else block
20151219 15:42:08< celmin|sleep> Ah.
20151219 15:42:21< vultraz> so it shouldn't be reached
20151219 15:42:33< celmin|sleep> You're sure it's compiling with SDL2?
20151219 15:42:57< vultraz> pretty sure...
20151219 15:43:00< celmin|sleep> If it's reaching a point with !SDL_VERSION_ATLEAST(2,0,0) then the logical explanation is that it's using SDL1 headers.
20151219 15:43:17< celmin|sleep> And if you're getting a link error, then it's trying to link the result with SDL2 libs.
20151219 15:43:37< celmin|sleep> In other words, compiling with SDL1 but then linking with SDL2.
20151219 15:44:07< vultraz> do I need a define or something
20151219 15:44:21< celmin|sleep> You're using CodeBlocks?
20151219 15:44:24< vultraz> yes
20151219 15:44:40< celmin|sleep> It's probably something in project settings somewhere. I don't remember CodeBlocks very well though.
20151219 15:44:51< celmin|sleep> I've not used it much.
20151219 15:45:05< vultraz> i'll see after it rebuilds
20151219 15:45:52< celmin|sleep> If there's anyone else here who uses CodeBlocks they'd probably be better to ask.
20151219 15:46:16< vultraz> shadowm, but he's away
20151219 15:46:29< celmin|sleep> When I was using it I actually found it easier to edit the project file with a text editor than to use the project settings dialog. >_>
20151219 15:56:15< gfgtdf> celmin|sleep: which ide do you use?
20151219 15:57:38< celmin|sleep> XCode on Mac, VS2013 on Windows (but I haven't checked out Wesnoth on Windows)
20151219 15:58:55-!- Kwandulin [~Miranda@p200300760F250ABEB8A0B7DBF394DB83.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151219 15:58:58< vultraz> ok, same errors
20151219 16:00:50< vultraz> the two GetAppState calls aren't guarded by #if's but they're supposed to alias to something on sdl2
20151219 16:01:00< vultraz> so i think celmin is right, somehow im not compiling sdl2...
20151219 16:05:22< vultraz> there doesn't seem to be a switch or anything
20151219 16:09:39< gfgtdf> ok i someere added an opion to make my uild use sdl2 but now i cannot find it
20151219 16:11:16< gfgtdf> somewere*
20151219 16:12:55< vultraz> hm I think I might have found the problem
20151219 16:12:59< vultraz> lemme try rebuilding
20151219 16:32:35-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151219 16:34:38< vultraz> dammit!
20151219 16:34:40< vultraz> didn;t work
20151219 16:35:39-!- Kwandulin [~Miranda@p200300760F250ABE2162D8000B68806D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151219 16:36:55-!- Appleman1234 [~Appleman1@119.104.19.113] has joined #wesnoth-dev
20151219 16:39:36< vultraz> i don't know what's wrong here
20151219 16:45:02< vultraz> ahhh I think I got it finally
20151219 16:45:09< vultraz> i had a search path set for my stable branch
20151219 16:45:24< vultraz> and my sdl2 libs in include/sdl2
20151219 16:45:34< vultraz> so it looked to include files in include/
20151219 16:45:38< vultraz> and found them in the stable branch
20151219 16:45:55< vultraz> except now I can't find winapifamily.h
20151219 16:45:57< vultraz> fuuu
20151219 16:47:19< vultraz> ah, stackoverflow provides an answer
20151219 17:02:32< vultraz> GAAAAH
20151219 17:03:14< vultraz> now errors in SDL_SavePNG_RW
20151219 17:06:26< vultraz> stuff about 'free' and 'malloc' not being declared
20151219 17:08:18< gfgtdf> vultraz: you are building sdl yourself ?
20151219 17:08:28< vultraz> no
20151219 17:09:00< vultraz> src/SDL_SavePNG/savepng.cpp
20151219 17:09:52< gfgtdf> vultraz: hmm you shuld try adding an include for malloc in that file
20151219 17:12:10< vultraz> but this was never a problem before
20151219 17:12:17< gfgtdf> Aginor: i still have the problem that the screen becoms black if in minimize the windows while its maximized
20151219 17:12:21< vultraz> what even is the include for malloc/free?
20151219 17:12:45< gfgtdf> vultraz: maybe previously the SDL header included that header
20151219 17:12:51< vultraz> hm
20151219 17:12:52< vultraz> maybe
20151219 17:17:04< vultraz> Ok I added a <stdlib.h> include
20151219 17:17:53< vultraz> ugghh
20151219 17:17:55< vultraz> ..\..\src\buffered_istream.hpp|64|error: 'EOF' was not declared in this scope|
20151219 17:18:35< vultraz> how have you people avoided this stuff :|
20151219 17:19:48 * vultraz adds #include <stdio.h>
20151219 17:21:48< gfgtdf> celmin|sleep: i think it coudl be you that broke http://gna.org/bugs/?24202.
20151219 17:22:10< gfgtdf> celmin|sleep: no of course i meant http://gna.org/bugs/?24200
20151219 17:22:56< vultraz> gfgtdf: I think the scenario might just need a border key in terrain_mask
20151219 17:23:14< vultraz> OH FOR THE FFS
20151219 17:23:16< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\server\game.cpp|173|error: 'snprintf' was not declared in this scope|
20151219 17:23:19< gfgtdf> vultraz: y thst whjat i thought aswell
20151219 17:23:50< gfgtdf> vultraz: i thought it migth be this commit https://github.com/wesnoth/wesnoth/commit/1b22a974c212bbed7ec06e7c5924d37dd352011f that's why i asked him.
20151219 17:24:31< vultraz> gfgtdf: btw are you going to make terrain_mask use the mp sync thing you added?
20151219 17:25:02< gfgtdf> vultraz: Which headers in clude which other headers might be different on different compilers. But im aczualyl uprose by teh erros you get
20151219 17:25:07< gfgtdf> vultraz: i think yes
20151219 17:26:07< gfgtdf> vultraz: but i also think it woudl be better to remove map_file and instead giv the user the ability to load teh map at runtine into a variable, that way the user can decide whether h wants it to by sanced or not
20151219 17:26:07< vultraz> WHOOT
20151219 17:26:11< vultraz> got my build working
20151219 17:26:21-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151219 17:26:37< vultraz> had to add another stdio.h include
20151219 17:28:43< vultraz> shadowm: did you have to add includes to get your build working?
20151219 17:29:47< vultraz> I had to add an include to stdlib.h in SDL_SavePNG/savepng.cpp and includes to stdio.h in buffered_istream.hpp and server/game.cpp
20151219 17:29:48< shadowm> No.
20151219 17:30:08< shadowm> Use <cstdlib> and <cstdio> instead.
20151219 17:31:04-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151219 17:31:57< vultraz> "No such file or directory"
20151219 17:32:31< shadowm> That's impossible.
20151219 17:32:49-!- wedge009 [~Thunderbi@60.241.236.92] has quit [Ping timeout: 272 seconds]
20151219 17:32:49-!- wedge010 is now known as wedge009
20151219 17:33:27< vultraz> wait, no, im stupid
20151219 17:33:28-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 272 seconds]
20151219 17:33:28< vultraz> nvm
20151219 17:33:44-!- fabi [~quassel@176.2.139.111] has joined #wesnoth-dev
20151219 17:33:44-!- fabi [~quassel@176.2.139.111] has quit [Changing host]
20151219 17:33:44-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151219 17:33:47< vultraz> I left the header prefix
20151219 17:33:51< vultraz> suffix
20151219 17:34:06-!- {V} [~V@105-70-ftth.on.nl] has quit [Ping timeout: 272 seconds]
20151219 17:35:03-!- {V} [~V@105-70-ftth.on.nl] has joined #wesnoth-dev
20151219 17:35:36-!- prkc [~prkc@54008B14.dsl.pool.telekom.hu] has quit [Ping timeout: 265 seconds]
20151219 17:37:32-!- prkc [~prkc@54008B14.dsl.pool.telekom.hu] has joined #wesnoth-dev
20151219 17:37:57< vultraz> hello, a crash
20151219 17:38:34< vultraz> "caught general exception: basic_string::_M_replace_aux"
20151219 17:41:12< vultraz> call stack so helpful, much wow
20151219 17:42:01< gfgtdf> what is teh callstack ?
20151219 17:44:21< vultraz> #0 00E2BD70	__cxa_throw () (??:??)
20151219 17:44:22< vultraz> #1 00E2B2E9	std::__throw_length_error(char const*) () (??:??)
20151219 17:44:24< vultraz> #2 011F18B6	std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_replace_aux(unsigned int, unsigned int, unsigned int, char) () (??:??)
20151219 17:44:25< vultraz> #3 ??	?? () (??:??)
20151219 17:46:13< gfgtdf> the error is mostlikeley in ' ??	?? () (??:??)' :)
20151219 17:47:22< vultraz> guess I need a debug build :|
20151219 17:52:57-!- gfgtdf [~chatzilla@f054138070.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20151219 18:00:53-!- Kwandulin [~Miranda@p200300760F250ABE2162D8000B68806D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151219 18:18:28< vultraz> nice, the only additional thing I get is 
20151219 18:18:29< vultraz> #3 765077A5	msvcrt!free() (C:\WINDOWS\SYSTEM32\msvcrt.dll:??)
20151219 18:18:36< vultraz> much useful
20151219 18:22:52< vultraz> Aginor: ok so I'm getting a weird crash when trying to get to certain dialogs like Load Map and Apply Mask in the editor... is it just me?
20151219 18:30:08-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20151219 18:30:08-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Client Quit]
20151219 18:31:47< vultraz> lol
20151219 18:32:43-!- prkc [~prkc@54008B14.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20151219 18:46:35-!- irker807 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151219 18:46:35< irker807> wesnoth: Charles Dang wesnoth:master 0e8784766945 / src/ (SDL_SavePNG/savepng.cpp buffered_istream.hpp server/game.cpp): Added some includes I needed to build with SDL2 http://git.io/vEvRP
20151219 19:18:12< irker807> wesnoth: Charles Dang wesnoth:master 0f77464e3641 / src/game_launcher.cpp: Start Wesnoth maximized http://git.io/vEvVa
20151219 19:20:19< shadowm> vultraz: Don't do that.
20151219 19:29:54< shadowm> That code doesn't even do what you think it does.
20151219 19:35:39< vultraz> Then what does it do?
20151219 19:37:51< shadowm> Read your addition in pseudocode.
20151219 19:44:03< vultraz> I still don't get it
20151219 19:45:17< shadowm> vultraz: Your code removes the flag if it's set, sets if it's not set.
20151219 19:45:41< shadowm> It also does this unconditionally, which makes no sense.
20151219 19:48:12< vultraz> Ok, no, that's not what I wanted. I wanted to append the flag
20151219 19:49:00< shadowm> I know you just copy-pasted code without really understanding it, yes.
20151219 19:49:00< vultraz> (<<=?)
20151219 19:49:07< shadowm> That's not how programming works.
20151219 19:51:21< shadowm> ^: bitwise XOR   |: bitwise OR   &: bitwise AND   <<: bitwise left shift    >>: bitwise right shift   ~:   bitwise NOT/complement
20151219 19:52:01< shadowm> `a ^= b` is equivalent to `a = a ^ b` and so on.
20151219 19:54:55< vultraz> what's the difference between XOR and OR
20151219 19:55:02< shadowm> But more importantly, we shouldn't get a maximized window if it wasn't like that last time we ran Wesnoth.
20151219 19:55:10< shadowm> Exclusive OR vs. inclusive OR.
20151219 19:56:12< shadowm> Given two binary values A and B, A XOR B only yields true if they are not the same, whereas A OR B yields true as long as either of them is true.
20151219 19:57:31-!- gfgtdf [~chatzilla@f054138070.adsl.alicedsl.de] has joined #wesnoth-dev
20151219 19:57:55< shadowm> This probably won't make sense to you if you don't contextualize it correctly.
20151219 19:59:04-!- prkc [~prkc@84.0.139.20] has joined #wesnoth-dev
20151219 19:59:16< vultraz> So you mean a xor b would yield false if a equaled b?
20151219 19:59:32< shadowm> Yes.
20151219 19:59:42< shadowm> Anyawy, you have to picture numbers as sets of binary values and apply these operations to them in a bitwise fashion.
20151219 19:59:58< shadowm> When you have a bit field, flags represent positions in it.
20151219 20:00:38< shadowm> Because flags are numbers, ergo sets of binary values.
20151219 20:01:27< shadowm> A bitwise operation between two integers N and M is applied on the entire set of values they represent.
20151219 20:02:26< shadowm> If you have 2 ^ 3 what you are really doing is 10 ^ 11 or 1. ^ 1. and .0 ^ .1.
20151219 20:02:49< shadowm> The result is the resulting set.
20151219 20:04:01< shadowm> In this case, the result is 0. and .1, therefore 01 (1).
20151219 20:06:25< shadowm> From this stuff (basic logic, not even programming) you get a few basic C idioms for bitwise operations:
20151219 20:07:03< shadowm> * `a | b` can be parsed as the result of setting the flag or flagset b on a
20151219 20:07:14< shadowm> * `a ^ b` can be parsed as the result of toggling the flag or flagset b on a
20151219 20:07:33< shadowm> * `a & b` can be parsed as the result of matching the flag or flagset b on a (masking)
20151219 20:08:53< shadowm> * `a & ~b` can be parsed as the result of unsetting the flag or flagset b on a (mask a on the complement of b)
20151219 20:23:04< vultraz> I'm still confused as to the correct function, then, since << doesn't work
20151219 20:23:37< shadowm> Okay, I give up.
20151219 20:23:45< vultraz> As to why I made it conditionless, I feel the game would look better presented if it didn't start at the currently default resolution and instead started maximized. 
20151219 20:23:56< shadowm> You are absolutely incredible.
20151219 20:24:04< shadowm> And not in a good way.
20151219 20:24:22< vultraz> Look, if this is supposed to be obvious, I'm not seeing it and I haven't had any sleep
20151219 20:24:31 * vultraz out
20151219 20:24:34< vultraz> I will return later
20151219 20:24:37< vultraz> with sleep
20151219 20:24:40< vultraz> and puzzle this out
20151219 20:24:46< shadowm> Then go to sleep and reread the list above. The answer is right there in plain sight and in plain language.
20151219 20:25:05< shadowm> I feel I'd be insulting everyone's intelligence if I made it any more obvious.
20151219 20:25:39< vultraz> Ok wait, I got it
20151219 20:25:45< vultraz> It's |
20151219 20:30:11-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Read error: Connection reset by peer]
20151219 20:33:38-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20151219 20:51:35< gfgtdf> vultraz: ok i juset tested your segfault and it gives me segfault too
20151219 20:51:55< gfgtdf> vultraz: idk why it gave you such a strnage stacktrace
20151219 20:53:53< irker807> wesnoth: gfgtdf wesnoth:master c7a73cd3a48f / src/widgets/file_menu.cpp: add an assert. http://git.io/vEvNO
20151219 20:54:00< gfgtdf> vultraz: try this ^
20151219 20:54:13< gfgtdf> vultraz: it doesnt fix the issue but it shoudl give a better error message
20151219 20:55:42< gfgtdf> vultraz: maybe this issue can be foxed by porting the editor load map dialog to gui2
20151219 20:55:45< gfgtdf> fixed*
20151219 21:16:12-!- prkc [~prkc@84.0.139.20] has quit [Remote host closed the connection]
20151219 21:21:06-!- kidneb [kidneb@not.allthetime.xyz] has quit [Quit: Oh no]
20151219 21:21:23-!- kidneb [kidneb@not.allthetime.xyz] has joined #wesnoth-dev
20151219 21:40:04-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Ping timeout: 250 seconds]
20151219 21:46:41-!- prkc [~prkc@54008B14.dsl.pool.telekom.hu] has joined #wesnoth-dev
20151219 21:52:03< Aginor> gfgtdf: that's why I asked you to raise bugs, so they wouldn't be forgotten about :/
20151219 21:53:59< Aginor> gfgtdf: please check https://gna.org/bugs/index.php?24209 and see if it's correct
20151219 21:57:14< Aginor> gfgtdf/vultraz: could you please instruct me how to reproduce that crash you're seeing?
20151219 22:00:37< gfgtdf> Aginor: y its correct
20151219 22:00:46< gfgtdf> Aginor: open the load_map dialog inte editor
20151219 22:01:04< gfgtdf> Aginor: i added a assert spo it now gives an assertion failure
20151219 22:10:06< Aginor> bah
20151219 22:10:15< Aginor> I can't even compile it any longer, vultraz broke it
20151219 22:11:47< Aginor> https://github.com/wesnoth/wesnoth/commit/0f77464e3641ce8fca567903f8be95fbca012624
20151219 22:14:34< irker807> wesnoth: Andreas Löf wesnoth:master 77b39190ba76 / src/game_launcher.cpp: Revert "Start Wesnoth maximized" http://git.io/vEfYL
20151219 22:14:59< Aginor> vultraz: I reverted your commit because it was causing compilation errors (and did the wrong thing)
20151219 22:15:16< Aginor> vultraz: please feel free to re-submit a corrected version :)
20151219 22:25:09< Aginor> fun
20151219 22:25:16< Aginor> that crash is present in SDL 1.2 too
20151219 22:28:21< gfgtdf> Aginor: which carash ?
20151219 22:28:30< Aginor> the assert failure
20151219 22:28:42< gfgtdf> Aginor: did you test it with 1.13.2 ?
20151219 22:28:50< gfgtdf> Aginor: or with 1.12.5
20151219 22:28:55< Aginor> I'll do some bisecting in a bit
20151219 22:31:20-!- prkc [~prkc@54008B14.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20151219 22:35:43< celmin|sleep> vultraz: I think the XCode built excludes savepng.cpp, so it might not even be needed. gfgtdf: I doubt I could've broken 424202 and not sure how I could've broken 24200 (but it might be possible).
20151219 22:36:24< gfgtdf> celmin|sleep: i meant http://gna.org/bugs/?24200
20151219 22:36:26< celmin|sleep> vultraz: x << b can be thought of as "append b number of 0's to the right side of x, and drop the left b digits".
20151219 22:36:35< celmin|sleep> And x >> b is the opposite.
20151219 22:36:39< gfgtdf> celmin|sleep: and i gave a link to the commit which i think broke it 2 lines after
20151219 22:36:50< celmin|sleep> Oh, I guess I missed the commit link.
20151219 22:37:45< celmin|sleep> Hmm. Well, it's quite probably that the bug is caused by that commit, then.
20151219 22:38:15< celmin|sleep> I'm not certain it can be fixed by altering the code there, though. It might be better to instead alter the code in Dark Forecast.
20151219 22:40:38-!- celmin|sleep is now known as celticminstrel
20151219 22:44:38< Aginor> I know what goes wrong in that file menu, but not why
20151219 22:45:25< Aginor> we hit gfgtdf's new assertion because we keep shrinking the string until it's empty, because the width of the string in pixels is always larger than the GUI component's width (which is 0)
20151219 22:52:02< gfgtdf> celticminstrel: y maybe it shoudl be fixed yb changing Dark Forcasts code
20151219 22:52:45< gfgtdf> Aginor: i think its related to commits oin the sdl branch which were not inside an #ifdef sdl version
20151219 22:53:11< gfgtdf> celticminstrel: but then we shodul also add it to the list of compability breakes in the RN
20151219 22:53:39< celticminstrel> Yeah, probably. Do you know if it breaks other scenarios that use terrain masks?
20151219 22:53:58< gfgtdf> celticminstrel: you mean in mainline ?
20151219 22:54:02< celticminstrel> I'm guessing it doesn't break all of them. It probably depends on the border setting in the terrain mask.
20151219 22:54:06< celticminstrel> And yeah I mean in mainline.
20151219 22:54:36< Aginor> gfgtdf: the only ones I can think of are either around hotkeys or of keeping copies of the framebuffer surface instead of references
20151219 22:54:42< gfgtdf> celticminstrel: i actualyl don't know exactly what theat commit changes
20151219 22:55:29< gfgtdf> celticminstrel: and i also didnt test mainline campaigsn recelty
20151219 22:55:40< gfgtdf> celticminstrel: so no i dont know which other scenarios coudl be broken
20151219 22:55:53< celticminstrel> This just reminded me of something that probably should've been included in the release notes. (It might've been already, though?)
20151219 22:56:10< celticminstrel> Map files no longer have the header with usage and border_size.
20151219 22:56:10-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 260 seconds]
20151219 22:56:24< celticminstrel> Or, was that already the case in the previous release?
20151219 22:56:50< celticminstrel> Anyway, I think the commit was related to fixing a crash in the terrain mask code or something.
20151219 22:56:57< celticminstrel> Maybe vultraz remembers better.
20151219 22:56:58< gfgtdf> Aginor: i meant this one: https://github.com/wesnoth/wesnoth/commit/afde826f226aeb30d0eb677a83c465f1f5f7d243
20151219 22:57:26< Aginor> hmmm
20151219 22:58:09< Aginor> I'd rather fix what relies on the previously broken behaviour though
20151219 22:58:26< Aginor> having it in #ifdefs won't help
20151219 22:58:41< gfgtdf> Aginor: i never usggested to put it into ifdefs
20151219 22:59:07< gfgtdf> Aginor: i just said that the bug is not casues by code inisde ifdefs becasue it appears on sdl1 and sdl2 builds
20151219 22:59:19< Aginor> yes
20151219 22:59:47< Aginor> I took it as in you thought it should have been inside #ifdefs
20151219 23:01:55< gfgtdf> Aginor: no that was just a hint about where to look for the 'bad' code.
20151219 23:02:38< Aginor> fair enough
20151219 23:07:41 * Aginor facepalms
20151219 23:07:51< gfgtdf> Aginor: if we don't want to fix this that way we can also port the dialog to gui2
20151219 23:08:30< Aginor> max_width et al gets the value -1, which previously will have been 0xffffffe
20151219 23:09:19< Aginor> although there is something else odd happening
20151219 23:10:32< gfgtdf> hm we coudl try replacing -1 with 100000000 or something
20151219 23:11:10< Aginor> nah
20151219 23:11:15< celticminstrel> max_width should probably be unsigned.
20151219 23:11:18< Aginor> it's all not fixing the root cause
20151219 23:11:41< Aginor> celticminstrel: better to toss out gui1 instead ;)
20151219 23:11:59< celticminstrel> Though, that won't fix the root cause either since -1 will implicitly convert to the max value of an unsigned variable.
20151219 23:12:39< Aginor> I think I was wrong to be honest
20151219 23:12:47< gfgtdf> i think relaing on -1 inlicitly converting to 2^32-1 is rather hard to read code
20151219 23:12:56< gfgtdf> actualyl that afaik what teh code did before that commit
20151219 23:12:58< gfgtdf> thats
20151219 23:13:02< Aginor> I don't I've changed that ones to signed
20151219 23:13:05< celticminstrel> It might be hard to read code, gfgtdf, but it's pretty much consistent.
20151219 23:13:24< gfgtdf> celticminstrel: i see no advantages over using 100000000
20151219 23:13:34< celticminstrel> I think the C++ standard doesn't specify it, mind you, so if there was a machine that didn't use 2's complement representation for negative numbers then you might get different results.
20151219 23:14:34< gfgtdf> celticminstrel: i dont really care what the c++ standart specify as longs as its true on all hardware/compilers that i know.
20151219 23:15:10< gfgtdf> celticminstrel: there are multiple places on the code where we use non-stadart c++
20151219 23:15:16< gfgtdf> celticminstrel: mostly hiddne inside boost
20151219 23:18:52< celticminstrel> gfgtdf: Yeah, I won't disagree with that.
20151219 23:18:56< Aginor> aren't there constants defined for these kind of numbers?
20151219 23:19:13< Aginor> that will be architecture appropriate?
20151219 23:19:29< celticminstrel> In my opinion, non-standard C++ hidden in Boost doesn't count since they usually have all sorts of ifdefs in case compilers don't support it.
20151219 23:19:55< celticminstrel> Aginor: There are constants, yes, so when possible it's better to use those.
20151219 23:20:02< celticminstrel> Though the constants are in the C specification.
20151219 23:20:13< celticminstrel> The C++ way is to use std::numeric_limits.
20151219 23:21:45< Aginor> same difference :)
20151219 23:22:17< celticminstrel> Same end result, certainly.
20151219 23:22:38< celticminstrel> numeric_limits is a template, so it could be extended for custom numeric types as well.
20151219 23:26:59< Aginor> ok...
20151219 23:27:08< Aginor> I believe I've found the problem
20151219 23:27:13< celticminstrel> Yay.
20151219 23:27:17< Aginor> 		while(static_cast<unsigned int>(
20151219 23:27:18< Aginor> 				font::line_width(*it, menu_font_size)) > width() - 30 - 25) {
20151219 23:27:32< Aginor> with returns an unsigned, with the value of 0
20151219 23:27:36< Aginor> width() returns an unsigned, with the value of 0
20151219 23:27:49< Aginor> see the problem? :D
20151219 23:28:34< Aginor> now, is the correct fix to fix gui1 or to fix the comparison?
20151219 23:28:52< gfgtdf> Aginor: or port the dialog to gui2
20151219 23:28:59< Aginor> or doing that
20151219 23:29:06< Aginor> everywhere it's used :)
20151219 23:29:15< celticminstrel> Which dialog is it?
20151219 23:29:43< gfgtdf> Aginor: i think its onyl 1 or 2 dialogs that use it
20151219 23:30:12< gfgtdf> Aginor: i forgot how it shoudl look so im not sure whether porting to gui2 is easy or hard
20151219 23:33:58< gfgtdf> celticminstrel: the generic 'choose file' dialog
20151219 23:34:06< gfgtdf> celticminstrel: used for exampel for open map in mpa editor
20151219 23:34:10< celticminstrel> Ah.
20151219 23:34:51< celticminstrel> I don't know of anything that would make it hard to port to GUI2... except maybe the map preview area? Not sure about that.
20151219 23:35:33< gfgtdf> celticminstrel: didint know it has a preview area
20151219 23:35:41-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 265 seconds]
20151219 23:37:38< celticminstrel> I thought it did, but I might be misremembering. Even if it doesn't, it could stand to gain one.
20151219 23:37:54< celticminstrel> (I might be partially confusing it with the Load Game dialog.)
20151219 23:38:44< gfgtdf> the load game diaog is already ported to gui2
20151219 23:39:04< celticminstrel> Given that, I think it probably wouldn't be too difficult to port the other load dialog.
20151219 23:48:14< Aginor> so what's required to do that?
20151219 23:49:39< Aginor> the load window doesn't have a preview
20151219 23:50:05< Aginor> also, I have "fixed" it by checking if max_width is set or left at -1
20151219 23:50:28< Aginor> if (get_max_width() != -1) { while(font::line_width(*it, menu_font_size) > width() - 30 - 25) {
20151219 23:50:37< Aginor> there's a newline that got eaten
20151219 23:50:44< Aginor> do we like that as a workaround?
20151219 23:52:42< Aginor> gfgtdf, celticminstrel: thoughts?
20151219 23:54:19< celticminstrel> That seems okay. I would maybe do it slightly differently, but that way would also violate Wesnoth's style conventions, so I won't describe it. I'd also check >= 0 instead of != -1, just to cover all possible bases.
20151219 23:54:36< celticminstrel> In fact, you could check >= 55.
20151219 23:54:50< Aginor> -1 is used as a magic number, which is why I'm explicitly checking against it
20151219 23:55:01< celticminstrel> Fair enough.
20151219 23:55:08< celticminstrel> Speaking of 55, why is it split up there?
20151219 23:55:29< Aginor> because someone, in the most ancient of times, thought it was a good idea, for reasons
20151219 23:55:43< Aginor> this is the comment above that clause
20151219 23:55:44< Aginor> 		// Make sure that all lines fit.
20151219 23:55:44< Aginor> 		// Guess the width of the scrollbar to be 30 since it is not accessible from here.
20151219 23:55:47< Aginor> 		// -25 to compensate for the picture column.
20151219 23:56:05< celticminstrel> I guess that makes sense.
20151219 23:56:38< Aginor> I disagree, I think it's all fundamentally wrong :)
20151219 23:56:52< celticminstrel> It can make sense and still be wrong. >_>
20151219 23:57:21< Aginor> I'll just quietly commit instead of arguing :D
20151219 23:57:54< Aginor> but we should move the editor to gui2
20151219 23:57:59< celticminstrel> I also commented on the Dark Forecast issue. I'm hoping someone will fix it for me. >_>
20151219 23:58:04< Aginor> and improve the performance in gui2
20151219 23:58:13< gfgtdf> Aginor: moving the editor as a whole to gui2 is hard
20151219 23:58:19< celticminstrel> GUI2 is annoyingly obtuse.
20151219 23:58:27 * Aginor goes to read the backlog to find out about the dark forecast issue
20151219 23:58:39< celticminstrel> Issue 24200.
20151219 23:58:43< gfgtdf> Aginor: but porting all dialogs to gui2 is less hard
20151219 23:58:48< Aginor> The alternative is to introduce gui3 :)
20151219 23:59:01< gfgtdf> gui10
20151219 23:59:46< celticminstrel> Introducing GUI3 is either 1) An inordinate amount of work that will take months or even years or 2) A huge (but lesser) amount of work in building a system that can read the same WML definitions and the build the GUI in some other, already existing GUI system.
--- Log closed Sun Dec 20 00:00:12 2015