--- Log opened Sun Dec 20 00:00:12 2015
--- Day changed Sun Dec 20 2015
20151220 00:00:12< celticminstrel> Someone recommended FlatGUI for option 2. I have no idea if it's actually any good for Wesnoth's purposes since I haven't really looked at it.
20151220 00:00:18< Aginor> celticminstrel: yup. But something needs to be done :)
20151220 00:00:35< Aginor> I'll get a move on with opengl acceleration now
20151220 00:00:54< celticminstrel> Yes, something needs to be done, and ideally something that doesn't require rewriting every dialog.
20151220 00:01:04< celticminstrel> Sounds good!
20151220 00:01:26< gfgtdf> celticminstrel: cant you add the border=no yourself?
20151220 00:01:54< celticminstrel> gfgtdf: I won't say I can't, but I'm not even certain that's the correct fix.
20151220 00:02:20< gfgtdf> celticminstrel: well you can do it makr the bug as 'ready to test'
20151220 00:02:41< celticminstrel> I'd rather not commit something that I'm uncertain will work.
20151220 00:02:52< celticminstrel> Mind you, I've probably done it a few times, but still. >_>
20151220 00:02:54< gfgtdf> celticminstrel: i mean if you who made that commit don't know if its the correct fix why shoudl anyone else know?
20151220 00:03:06< celticminstrel> By trying it out and seeing if it fixes it?
20151220 00:03:48< celticminstrel> I wish github had a way to reach descendants of the commit being shown.
20151220 00:04:08< celticminstrel> There might've already been a commit that added border=no to Dark Forecast.
20151220 00:04:45-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151220 00:05:01< celticminstrel> I'd open a ticket, but when I looked I couldn't find a github repo for github.
20151220 00:07:35< irker807> wesnoth: Andreas Löf wesnoth:master 96534c523dd9 / src/widgets/ (file_menu.cpp menu.hpp): Work around crash/assertion caused by shortening filenames in gui1 http://git.io/vEfry
20151220 00:07:43< Aginor> there you go
20151220 00:22:13-!- mjs-de [~mjs-de@x4db53874.dyn.telefonica.de] has quit [Remote host closed the connection]
20151220 00:57:51-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151220 01:04:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20151220 01:22:10-!- gfgtdf [~chatzilla@f054138070.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.1/20151216175450]]
20151220 01:47:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20151220 01:47:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20151220 01:52:55-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151220 01:58:10< vultraz> celticminstrel: map file headers were dropped in 1.13.0 I think
20151220 01:58:42< vultraz> celticminstrel: and btw, the editor's Apply Mask feature seems to suffer from the same offset issue
20151220 01:59:07< vultraz> I think I knowhow to fix that, but I can't test until the crash is fixed
20151220 02:00:24< celticminstrel> Ah.
20151220 02:14:52< vultraz> oh wait
20151220 02:14:54< vultraz> he did commit a fix
20151220 02:15:51< vultraz> this is why is pays to check your commit logs after you pull 
20151220 02:20:16< vultraz> Aginor: thanks for fixing :)
20151220 02:23:28< irker807> wesnoth: Charles Dang wesnoth:master d84445f4aa6d / src/editor/action/action.cpp: Editor: don't use border when applying mask http://git.io/vEfFN
20151220 02:23:46< vultraz> celticminstrel: ^ that fixes the offset when applying mask in the editor 
20151220 02:24:19< vultraz> so I think Dark Forecast just need a similar fix 
20151220 02:26:50< vultraz> needs*
20151220 02:33:23< vultraz> well damn
20151220 02:33:28< vultraz> that doesn't seem to be the case
20151220 03:05:22-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 256 seconds]
20151220 03:07:31-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20151220 03:12:28< vultraz> hmmmmmmmmmmmmmmmmmm
20151220 03:12:34< vultraz> ok so actually
20151220 03:12:48< vultraz> that fix might be the wrong fix
20151220 03:13:09< vultraz> i just noticed it partly overlays the map wrong. 
20151220 03:13:11< vultraz> hmmm
20151220 03:13:41< vultraz> also, in order to get the in-scenario mask to overlay "right", I have to use x,y,border=2,1,yes
20151220 03:15:40< vultraz> what is this weirdness
20151220 03:16:05 * Aginor lurks briefly
20151220 03:16:20< celticminstrel> What was x,y before?
20151220 03:16:28< Aginor> vultraz: you did see that I also reverted your fullscreen attempt?
20151220 03:16:37< vultraz> Aginor: yes
20151220 03:16:55< vultraz> Aginor: I was supposed to use |=, I think, not ^=
20151220 03:17:13< Aginor> vultraz: I got a compile failure on the flag altogether so I grumpily reverted :)
20151220 03:17:21< vultraz> ....huh
20151220 03:17:28< vultraz> weird...
20151220 03:17:45< Aginor> yeah
20151220 03:17:47< vultraz> it worked for me
20151220 03:17:56< vultraz> and I was looking at the flag list on https://wiki.libsdl.org/SDL_CreateWindow
20151220 03:18:00< Aginor> I also notied that travis didn't run
20151220 03:18:11< Aginor> you were probably not including a header
20151220 03:18:26< Aginor> might have been that you got it for free with some settings for your windows build
20151220 03:19:05< vultraz> celticminstrel: 1,1 no border key 
20151220 03:19:37< vultraz> celticminstrel: I can't remember what we concluded about the necessity of border= :|
20151220 03:19:59< Aginor> I will look into general wesnothy stuff in an hour or so, I have a deck to waterblast first
20151220 03:20:18< Aginor> I just finished washing the walls of the house and need to do the rest too
20151220 03:20:28< celticminstrel> I forgot what border's default used to be.
20151220 03:20:31< Aginor> making sure it's nice in time for summer :)
20151220 03:21:00< celticminstrel> I think we concluded it was necessary to keep border= because some masks are designed to be borderless while others are not.
20151220 03:22:57< vultraz> celticminstrel: yeah... it's a problem, because the editor is impartial - it has to either do borders or not and it doesn't know what masks need it
20151220 03:23:10< vultraz> so it might work with border true for some and not others 
20151220 03:23:15< vultraz> same with terrain mask
20151220 03:23:20< vultraz> im not sure what to do here
20151220 03:27:49< celticminstrel> It doesn't have to be impartial.
20151220 03:31:43< vultraz> maybe certain masks could be resaved 
20151220 03:34:46< vultraz> manually
20151220 03:34:59< vultraz> i think maybe there's a problem with layout differences...
20151220 03:58:32-!- Appleman1234 [~Appleman1@119.104.19.113] has quit [Ping timeout: 272 seconds]
20151220 04:14:01< vultraz> Aginor: the window flags seem to be in SDL_video.h which is already included in game_launcher.cpp
20151220 04:14:03< vultraz> :/
20151220 04:19:02< shadowm> Don't reapply that commit, it worked for me but it made Wesnoth always start maximized, breaking the -r and -w switches.
20151220 04:19:42< shadowm> Figure out a different and and better thought-out solution for your problem.
20151220 04:20:27< vultraz> -w?
20151220 04:20:38< shadowm> -w
20151220 04:20:45< vultraz> what does that do again?
20151220 04:20:57< shadowm> I think you can find out with `--wconsole --help`.
20151220 04:22:13< vultraz> i know what wconsole does
20151220 04:22:27< vultraz> it directs output to a console instance 
20151220 04:22:43< shadowm> Exactly, which is why it's ideal for using --help.
20151220 04:23:04< shadowm> (No, -w is not a shorthand for --wconsole.)
20151220 04:24:43< shadowm> Okay, disregard that, I forgot -w/-f have nothing to do with the window state.
20151220 04:24:52< shadowm> Nevertheless, it breaks -r.
20151220 04:24:55< vultraz> Ok
20151220 04:25:03< vultraz> I'll make -r take precedence 
20151220 04:25:15< shadowm> And I'm pretty sure it also breaks the game's preferences.
20151220 04:25:54< shadowm> The game is supposed to start with the last used resolution or a "sane" platform default (which wasn't actually sane with SDL 1.2 most of the time I think).
20151220 04:27:02< vultraz> hm... I just realized we handle resolution differently than other games like dota. it's actual window size in our case
20151220 04:27:09< shadowm> With your commit the game just insists on starting maximized no matter what.
20151220 04:27:12< vultraz> so you can't have a maximized window with a lowe resolution than native
20151220 04:27:49< shadowm> SO here's how I would fix it:
20151220 04:28:17< shadowm> * Figure out how to check the window's current maximized state (either using SDL 2, or, as a last resort, platform APIs (Xlib, Win32, whatever OS X has)).
20151220 04:28:35< shadowm> * Do that in the same places that deal with tracking the current resolution for saving to preferences
20151220 04:28:48< shadowm> * Store the maximized state then and restore it on startup
20151220 04:29:40< shadowm> Yes, the first step is probably going to be "work" for you, but that's part of our contract.
20151220 04:35:12< vultraz> ok, so your proposal is to only maximize if it was maximized before?
20151220 04:35:18< vultraz> do I understand you correctly?
20151220 04:35:37< shadowm> Yes.
20151220 04:35:52< shadowm> Honestly, I can't understand why SDL 2/Windows doesn't do the right thing by itself.
20151220 04:36:35< vultraz> So a clean install will still open at what, 800x600?
20151220 04:36:50< vultraz> er
20151220 04:36:51< vultraz> wait no
20151220 04:36:53< vultraz> uh
20151220 04:36:55< vultraz> 1024x800
20151220 04:37:06< shadowm> If you have a window the size of the screen-ish (the window frame and taskbar take up space even while maximized) you should just maximize it.
20151220 04:37:15< shadowm> Not you, I mean our providers.
20151220 04:37:56< shadowm> Huh, turns out that master (and not 1.12) is suffering from window size amnesia anyway.
20151220 04:38:25< shadowm> It's using the last -r value I used (1280x768) instead of remembering the last resolution from each session.
20151220 04:38:40< shadowm> Aginor: Would you know anything about this? Perhaps a change in the resize handling code caused this.
20151220 04:40:28< shadowm> Start with -r 1280x768, maximize on the title screen, click Quit, start without parameters, you get 1280x768 back instead of the maximized size.
20151220 04:40:40< shadowm> Again, not in 1.12, which remembers the maximized size just fine.
20151220 04:41:34< vultraz> hm. ok, so there's SDL_GetWindowFlags()
20151220 04:41:59< vultraz> So there should be a flag there if the user manually maximizes the window (hopefully)
20151220 04:43:15< shadowm> Yeah, I can't help you with that, I'm afraid. I'm on my way out now.
20151220 04:43:41< vultraz> For your hiatus?
20151220 04:45:28< Aginor> hi
20151220 04:45:41< Aginor> I have finally returned from washing outsides of houses
20151220 04:45:55< vultraz> fun :)
20151220 04:45:57< Aginor> shadowm: enjoy your time off, make the best of it
20151220 04:46:35< Aginor> I think the -r flag has always overridden and stopped window settings from being applied
20151220 04:47:02< Aginor> vultraz: to make things work we should query the window for its size and flags on quit
20151220 04:47:08< Aginor> and save them in the settings
20151220 04:47:26< vultraz> Aginor: I think his point is that the window uses the value passed to -r on next launch even if not using -r
20151220 04:47:50< vultraz> and even if the window size changed
20151220 04:48:09< Aginor> we are maximizing to the native desktop resolution, it's possible to change it to maximize it to lower resolutions but why would you want to?
20151220 04:48:18< Aginor> vultraz: I think it's always been like that
20151220 04:48:33< vultraz> [15:40:40]	shadowm	Again, not in 1.12, which remembers the maximized size just fine.
20151220 04:48:50< vultraz> Aginor: I agree, you wouldn't want to
20151220 04:49:23< shadowm> I said I'll be sporadically around until the 25th but I won't do Wesnoth work other than respond to critical stuff that might come up (esp regarding the server). Everything else is postponed until mid January.
20151220 04:49:39< vultraz> Alright
20151220 04:49:54< shadowm> I may keep this session around and look at it from time to time but if you start piling up highlights I'm killing it to protect my health.
20151220 04:50:03< Aginor> vultraz: I was talking about master
20151220 04:50:06< shadowm> (I mean, work-related highlights.)
20151220 04:50:18< vultraz> Good luck and merry preemptive christmas/happy new year :)
20151220 04:50:20< Aginor> but if you think I broke it, check the commit before merging sdl2 :)
20151220 04:50:24< vultraz> Aginor: ah, ok
20151220 04:51:22< Aginor> shadowm: just kill it, potentially give a few select people an alternative way to reach you and make sure to take time off properly
20151220 04:51:30< Aginor> otherwise you might be tempted to cheat :)
20151220 04:51:33< Aginor> I know I would
20151220 04:52:05< shadowm> Nah.
20151220 04:55:00-!- Appleman1234 [~Appleman1@KD119104012012.au-net.ne.jp] has joined #wesnoth-dev
20151220 04:55:55-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has quit [Quit: shadowm_desktop]
20151220 04:57:07< Aginor> right vultraz 
20151220 04:57:18< Aginor> want to go and help me tidy up the event handlign code? :D
20151220 04:58:53< vultraz> to be done, what needs to be?
20151220 05:00:05< Aginor> take the three kinds of event handling, unify them into one (preferably GUI2 style)
20151220 05:00:33< vultraz> we have three kinds of event handling?
20151220 05:00:38< Aginor> input events will be straighforward but window handling stuff more annoying
20151220 05:00:53< Aginor> as a part of that we should also kill the limited event loops in a few different places
20151220 05:01:03< Aginor> they should instead mute other handlers
20151220 05:01:12< Aginor> vultraz: yes
20151220 05:01:50< Aginor> I think someone wanted a new way of doing things but decided they couldn't be bothered to fix old stuff
20151220 05:01:56< Aginor> repeatedly
20151220 05:02:00< vultraz> :/
20151220 05:02:37< Aginor> I should make a branch for it
20151220 05:02:50< Aginor> because there's plenty of skope of breaking stuff
20151220 05:02:57< Aginor> scope even
20151220 05:33:13< vultraz> Aginor: i take it this will be complicated
20151220 06:06:56-!- Kwandulin [~Miranda@p200300760F250ABE9C74F561D4BDE5F9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151220 06:21:19-!- irker807 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151220 06:25:18< Aginor> vultraz: quite so
20151220 06:25:38< Aginor> some parts will be easier than others
20151220 07:02:08< vultraz> Aginor: well first I'd like to deal with this window flag business 
20151220 07:02:21< vultraz> Aginor: could you point me to the game exit point?
20151220 07:04:22< vultraz> I'm thinking on exit we should check for 2 flags: SDL_WINDOW_MAXIMIZED and SDL_WINDOW_FULLSCREEN
20151220 07:04:49< vultraz> (I don't know if we should handle SDL_WINDOW_FULLSCREEN_DESKTOP)
20151220 07:05:08< vultraz> and if neither of those match, then save the current resolution
20151220 07:06:00< Aginor> SDL_WINDOW_FULLSCREEN_DESKTOP is what's used
20151220 07:06:20< Aginor> if SDL_WINDOW_FULLSCREEN ever get set (unlikely) we should save resolution and set the flag again next time
20151220 07:06:55-!- Kwandulin [~Miranda@p200300760F250ABE9C74F561D4BDE5F9.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20151220 07:08:29< vultraz> oh, ok
20151220 07:08:38< Aginor> hmm
20151220 07:08:45< Aginor> I just tried fullscreen
20151220 07:08:52< Aginor> it changed resolution on me...
20151220 07:08:58 * Aginor is confused
20151220 07:09:03< Aginor> and displeased
20151220 07:09:10< Aginor> my dual monitors just turned into mirror more
20151220 07:09:11< Aginor> mode
20151220 07:09:59< Aginor> running the game again after having exited it in fullscreen works for me (as in, it restores fullscreen)
20151220 07:11:03< vultraz> hm... what's the difference between preferences::set_fullscreen() and twindow::full_screen()
20151220 07:11:18< Aginor> changing resolution through the preferences has no effect until game is restarted
20151220 07:11:33< Aginor> vultraz: twindow::full_screen does it immediately
20151220 07:11:44< Aginor> the other one goes through and mucks about with preferences
20151220 07:12:00< Aginor> I may have broken that when I tried to fix other biths
20151220 07:12:04< Aginor> bits
20151220 07:12:33< vultraz> ""The video mode could not be changed. Your window manager must be set to 16 bits per pixel to run the game in windowed mode. Your display must support 1024x768x16 to run the game full screen." really? we do this?
20151220 07:12:38< vultraz> I had no idea..
20151220 07:12:48< Aginor> it's old legacy code
20151220 07:13:18< Aginor> this project has been around for a long time and you're now touching code that has been dormant for a long time
20151220 07:13:43< Aginor> vultraz: what exactly is it that's broken with fullscreen?
20151220 07:14:10< vultraz> ugh, dammit, the game is ignoring my mouse input again
20151220 07:14:26< Aginor> umm, whut?
20151220 07:15:05< Aginor> right...
20151220 07:15:06< vultraz> Aginor: off topic for a sec, but it seems if you minimize wesnoth and alt+tab back in it will ignore mouse input
20151220 07:15:12< Aginor> so I was using an SDL1 build by mistake
20151220 07:15:33 * Aginor swears at the event handling code
20151220 07:15:48< Aginor> vultraz: would you mind raising a bug and assigning to me so it won't be forgotten?
20151220 07:15:55< vultraz> will do
20151220 07:16:02< Aginor> thanks
20151220 07:16:15< Aginor> to many people tell me things in passing and then I forget about them
20151220 07:19:13< vultraz> ok, wow, it also affects menu item handling :(
20151220 07:19:27< Aginor> hmm?
20151220 07:20:13< vultraz> you can restore focus by forcing a maximize. however, if you "clicked' a menu item before that, once you do and you mouse over the area the menu should have drawn, you get disembodies menu items drawing under the mouse
20151220 07:20:49< vultraz> also it seems after doing that, buttons can get stuck in the 'pressed' position :(
20151220 07:21:24< Aginor> I suspect that events.cpp:300 is causing your grief
20151220 07:21:48< Aginor> I never understood the need for that code
20151220 07:21:52< vultraz> (seems also just moving the window restores focus)
20151220 07:24:13-!- Kwandulin [~Miranda@p200300760F250A669C74F561D4BDE5F9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151220 07:25:13< Aginor> vultraz: fullscreen is working as expected for me
20151220 07:25:22< Aginor> I just re-tried with sdl2 enabled
20151220 07:25:36< Aginor> can you please tell me what's broken? :)
20151220 07:26:20< Aginor> hmm
20151220 07:26:32< vultraz> Aginor: I'm not sure anything is broken with fullscreen besides https://gna.org/bugs/?23857
20151220 07:26:35< Aginor> changing resolution with -r seems to forever leave it stuck in tat resolution
20151220 07:27:02< vultraz> I was just intending to move window flag handling to game exit to have it all in one place
20151220 07:27:11< Aginor> vultraz: so what was it you were trying to fix earlier?
20151220 07:28:06< vultraz> Aginor: with the commit you reverted?
20151220 07:28:11< Aginor> yes
20151220 07:28:16< vultraz> basically, the game starts 'filling the screen'
20151220 07:28:22< vultraz> but not actually maximized 
20151220 07:28:50< vultraz> It's a window the size of the display and positioned to fill it but not technically maximized 
20151220 07:29:02< Aginor> so not fullscreen?
20151220 07:29:07< Aginor> maximized != fullscreen
20151220 07:29:23< vultraz> no, not fullscreen
20151220 07:29:34< Aginor> right...
20151220 07:29:38< vultraz> though I just toggled fullscreen and the preferences dialog isn't rendering right!
20151220 07:29:39< vultraz> ugh!
20151220 07:30:36< Aginor> it is for me?
20151220 07:30:52 * vultraz prepares to file a third bug
20151220 07:31:11 * Aginor swears
20151220 07:31:26< Aginor> after I used the -r flag it never EVER saves the resolution again
20151220 07:31:32< vultraz> ok woah, wesnoth just.... went crazy
20151220 07:31:43< vultraz> complete gray screen and I had to sigterm it :|
20151220 07:32:36< vultraz> Ok, this I can reproduce 
20151220 07:33:49< Aginor> https://gna.org/bugs/?24212 works for me
20151220 07:33:59< Aginor> (in linux)
20151220 07:35:17< vultraz> third bug submitted
20151220 07:35:24-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151220 07:35:25< Aginor> I'm reading
20151220 07:35:25-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151220 07:35:36< vultraz> I suspect these all have a similar underlying cause
20151220 07:35:43< Aginor> I am currently trying to verify their presence under sdl1 too
20151220 07:36:02< Aginor> because I'm getting a lot of complaints of stuff that was previously broken
20151220 07:37:28< vultraz> For the fullscreen one, I'm guessing it has to do with the dialog being redrawn before the screen
20151220 07:37:50< Aginor> yup
20151220 07:41:52< vultraz> some glitch in the GUI1 event handing, since gui2 dialogs handle window position/size changes fine (well, not entirely fine. it's slow and has a few issues, but much better than the gui1 handling)
20151220 07:42:16< vultraz> I guess this is why you wanted to standardize them :P
20151220 07:42:20< Aginor> yes...
20151220 07:42:24< Aginor> and draw order
20151220 07:42:48< Aginor> bah
20151220 07:42:59< Aginor> SDL1 window events is as broken as always for me
20151220 07:43:08< Aginor> it's not even registering the resize events
20151220 07:46:10< vultraz> :(
20151220 07:46:38< vultraz> hopefully I haven't given you too much extra work
20151220 07:46:59< Aginor> no, it's good
20151220 07:47:17< Aginor> most of it falls under the "window handling is broken, and has been for a long time" category
20151220 07:49:53< Aginor> vultraz: I can't reproduce your "ignore input issue"
20151220 07:50:08< Aginor> do you still see it if you take out line 300-311 in events.cpp?
20151220 07:59:09< vultraz> will test
20151220 08:02:34< vultraz> Yes, I still see it
20151220 08:03:11< vultraz> ...hm...it seems the 'clicked' sound does still play if you click on things like menues 
20151220 08:03:16< vultraz> menus 
20151220 08:12:36< Aginor> that's because they run in their own little event handling and event loop
20151220 08:13:00< Aginor> you can guess what I want to do about that :)
20151220 08:14:02< vultraz> sounds run in their own event loop? o-O
20151220 08:14:36< Aginor> no, some gui1 stuff
20151220 08:14:48< vultraz> ah
20151220 08:14:58< Aginor> hmm
20151220 08:15:02< Aginor> I thought
20151220 08:15:11< vultraz> well I'll let you work on that, meanwhile I'll work on this window flag stuff
20151220 08:15:19< vultraz> I'm still looking for an on-exit function or something
20151220 08:15:32< Aginor> maybe I have gotten myself confused and is venting untoward frustration on it
20151220 08:15:36< Aginor> hah
20151220 08:15:40< Aginor> good luck :D
20151220 08:15:56< vultraz> wonder if we should save an is_maximized value in preferences... 
20151220 08:16:05< Aginor> quit_confirmation::quit(); is your best bed
20151220 08:16:07< Aginor> met
20151220 08:16:28< Aginor> bet
20151220 08:16:37< Aginor> CVideo::quit(); is the last thing invoked
20151220 08:16:46< Aginor> which will percolate back up into wesnoth_main
20151220 08:17:04< vultraz> Aginor:  I'm kinda considering dumping the whole resolution list and just having a Fullscreen/Windowed toggle
20151220 08:17:17< Aginor> that'll break sdl1
20151220 08:17:34< Aginor> which we don't want to do yet
20151220 08:17:42< vultraz> hm
20151220 08:17:53< vultraz> ok, then for now I'll focus on just getting window flags at exit
20151220 08:18:52 * vultraz looks for how preferences handles its fullscreen flag
20151220 08:20:10< Aginor> you're touching on a problem area though :/
20151220 08:20:17< vultraz> oh?
20151220 08:20:25< Aginor> the preferences set size is also invoked from gui2 on a resize event
20151220 08:20:30< Aginor> that's the wrong behaviour
20151220 08:20:56< Aginor> because set size (or resolution or whatever) also tries to resize the window
20151220 08:21:00< vultraz> is nothing simple in this codebase :|
20151220 08:21:02< Aginor> it's all intermingled :/
20151220 08:21:21< Aginor> it's caused me a lot of headaches with resize events
20151220 08:22:13< Aginor> so much that I will in fact abandon the computer for now and go off and play some music and have a some time with a book before it's bed time
20151220 08:22:18< Aginor> have a good evening
20151220 08:22:22 * vultraz will be happy when we can stop worrying about sdl1
20151220 08:22:28< vultraz> you enjoy :)
20151220 08:22:33< Aginor> and if you find more bugs, raise them as issues so I don't forget about them :)
20151220 08:22:42< Aginor> thanks :)
20151220 08:22:51< Aginor> you have a good evening/afternoon
20151220 08:23:03< Aginor> evening
20151220 08:32:41-!- celticminstrel is now known as celmin|sleep
20151220 08:59:56-!- Kwandulin [~Miranda@p200300760F250A669C74F561D4BDE5F9.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151220 09:39:21-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20151220 10:29:59-!- Kwandulin [~Miranda@p200300760F250A6688911DDEB4EE6E73.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151220 10:41:16-!- Shin_ [b0042225@gateway/web/freenode/ip.176.4.34.37] has joined #wesnoth-dev
20151220 10:42:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20151220 11:03:52-!- Shin_ [b0042225@gateway/web/freenode/ip.176.4.34.37] has quit [Quit: Page closed]
20151220 12:05:08-!- prkc [~prkc@54008B14.dsl.pool.telekom.hu] has joined #wesnoth-dev
20151220 12:05:36-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has joined #wesnoth-dev
20151220 12:33:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20151220 12:39:07-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151220 12:52:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20151220 13:09:55-!- Appleman1234 [~Appleman1@KD119104012012.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20151220 13:25:08-!- trewe [~trewe@bl20-5-61.dsl.telepac.pt] has joined #wesnoth-dev
20151220 13:28:36-!- Kwandulin [~Miranda@p200300760F250A6688911DDEB4EE6E73.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151220 14:07:05-!- Appleman1234 [~Appleman1@KD119104008249.au-net.ne.jp] has joined #wesnoth-dev
20151220 14:14:32-!- mjs-de [~mjs-de@f048162249.adsl.alicedsl.de] has joined #wesnoth-dev
20151220 14:19:55-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 240 seconds]
20151220 14:20:56-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20151220 14:31:35-!- Kwandulin [~Miranda@p200300760F250A665DF52EFA1615A836.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151220 14:42:30< vultraz>  this resolution handling stuff is so complicated :|
20151220 14:54:09< vultraz> Aginor: what's all this "bpp" stuff?
20151220 14:54:24< vultraz> I can't figure out what it's for
20151220 14:54:41< vultraz> Looking at the code it seems preferences::detect_video_settings doesn't do anything important in SDL2
20151220 14:55:12< vultraz> That function then has a DefaultBpp variable (set to 24) which is  passed to CVideo::modePossible
20151220 14:55:45-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151220 14:55:47< vultraz> However, in SDL2 that function just returns the third argument which is bits_per_pixel (and in this case, DefaultBpp)
20151220 14:56:27< vultraz> and then detect_video_settings returns whether bpp != 0 (which it always is in SDL2 I think)
20151220 14:57:01< zookeeper> bpp == bits per pixel
20151220 14:57:05< zookeeper> in case that's what you meant
20151220 14:57:17< zookeeper> but, i guess not, after all
20151220 14:57:37< vultraz> yes, I've figured out what the variable stands for
20151220 14:57:51< vultraz> I'm trying to figure out what purpose it serves in SDL2
20151220 14:58:26< vultraz> game_launcher::init_video() has a found_matching variable which calls detect_video_settings which given the parameters above, will, I think, always be true
20151220 14:59:09< vultraz> And a local bpp variable (set to 0 this time) is passed to that call
20151220 15:03:10-!- gfgtdf [~chatzilla@x50abde55.dyn.telefonica.de] has joined #wesnoth-dev
20151220 15:27:24-!- Kwandulin [~Miranda@p200300760F250A665DF52EFA1615A836.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151220 16:07:08-!- Kwandulin [~Miranda@p200300760F250A66D08D62E6A87547CA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151220 16:23:06-!- gfgtdf [~chatzilla@x50abde55.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.1/20151216175450]]
20151220 16:34:54-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151220 17:25:43-!- ancestral [~ancestral@97.116.163.129] has joined #wesnoth-dev
20151220 17:25:57-!- neverEnough_ [~nE@host7-235-dynamic.50-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20151220 17:26:02-!- neverEnough [~nE@host57-232-dynamic.50-79-r.retail.telecomitalia.it] has quit [Ping timeout: 272 seconds]
20151220 17:30:18-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151220 17:50:03-!- Kwandulin [~Miranda@p200300760F250A66D08D62E6A87547CA.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151220 18:12:13-!- ancestral [~ancestral@97.116.163.129] has quit [Quit: i go nstuf kthxbai]
20151220 18:19:12-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has joined #wesnoth-dev
20151220 18:31:56-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151220 18:33:03-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has joined #wesnoth-dev
20151220 18:35:26-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20151220 18:48:44-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has quit [Ping timeout: 255 seconds]
20151220 18:49:39-!- horrowind [~Icedove@2a02:810a:8b00:1c54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20151220 19:13:49-!- MrMaemo [4b442c98@gateway/web/freenode/ip.75.68.44.152] has joined #wesnoth-dev
20151220 19:39:20-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20151220 19:39:34< Elvish_Hunter> Hi all
20151220 19:45:15-!- trewe [~trewe@bl20-5-61.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
20151220 19:50:33< vultraz> hey Elvish_Hunter 
20151220 19:53:42< Elvish_Hunter> Hi vultraz
20151220 19:54:28< Elvish_Hunter> Anything new about the team_id change?
20151220 19:56:15< vultraz> no
20151220 19:57:42< celmin|sleep> Well, it got reverted for the release and hasn't been unreverted.
20151220 19:57:48-!- celmin|sleep is now known as celticminstrel
20151220 19:58:00< celticminstrel> Whoops, forgot to nick-change.
20151220 19:58:50-!- trewe [~trewe@bl20-7-61.dsl.telepac.pt] has joined #wesnoth-dev
20151220 19:58:56< Elvish_Hunter> I was asking, because I received an email from Gna, informing me that http://gna.org/bugs/?23977 is now marked as Won't Fix.
20151220 19:59:12< Elvish_Hunter> I guess that I can close PR #550 then, right?
20151220 19:59:57< celticminstrel> I... guess?
20151220 20:00:27< vultraz> Yes
20151220 20:00:39< vultraz> if I reapply the change it will be to two completely different keys
20151220 20:00:59< celticminstrel> BTW, are you going to revert the small-profile thing?
20151220 20:01:36< celticminstrel> Where's the option to show all units in help?
20151220 20:01:56< vultraz> in advanced prefs
20151220 20:02:10< vultraz> celticminstrel: what, the using the big profiles in help thing?
20151220 20:02:28< celticminstrel> Yeah. I was going to take a look at it, but I think overall it was probably a bad idea.
20151220 20:02:41< celticminstrel> I'll take a look first and see if it affects my opinion though.
20151220 20:15:32-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151220 20:31:38-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151220 20:39:46-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 240 seconds]
20151220 20:45:05-!- gfgtdf [~chatzilla@x50abde55.dyn.telefonica.de] has joined #wesnoth-dev
20151220 20:47:41-!- irker575 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151220 20:47:41< irker575> wesnoth: Elvish_Hunter wesnoth:master 9b1262acc630 / data/tools/imgcheck: Converted imgcheck to Python 3 http://git.io/vEkBA
20151220 20:48:18< Elvish_Hunter> Here we go. Another script now uses Py3.
20151220 20:48:21< gfgtdf> vultraz: you shouldn't put whitespace fixes in commits that are unrelated to that lines that have the trailing whitespaces even if they the commits are in the same file. The problem is that 1) It makes reverting of these commits harder, 2) It makes using git blame harder (you see that line was last changed in a commit which seems quite unrelated to that line, then and look at the commit just...
20151220 20:48:22< gfgtdf> ...to fnd out that its not really related.)
20151220 20:49:13< vultraz> ah, sorry
20151220 20:49:29< vultraz> codeblocks automatically fixes whitespace in edited files
20151220 20:50:07< irker575> wesnoth: Elvish_Hunter wesnoth:master 5d390d4de13a / changelog: changelog entry http://git.io/vEkRK
20151220 20:50:17< gfgtdf> vultraz: hmm maybe we shodul just have a commit that fixes all trailign whitespaces int the c++ files sometimes.
20151220 20:50:40< gfgtdf> vultraz: shoudl be hard to make a to fix all trailign whitespaces wih a regex replace.
20151220 20:50:44< gfgtdf> shouldn't
20151220 20:51:17-!- Appleman1234 [~Appleman1@KD119104008249.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20151220 20:59:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20151220 20:59:16< vultraz> optimally someone with linux should do that
20151220 20:59:21< vultraz> since they have sed
20151220 20:59:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20151220 21:00:33< gfgtdf> vultraz: what is sed  ?
20151220 21:03:13< Elvish_Hunter> gfgtdf: sed is a command line text processing tool.
20151220 21:04:03< Elvish_Hunter> I never used it so far, but it's available in any Linux distro; I suppose that you can install it in WIndows too, with Cygwin or similar tools.
20151220 21:04:41< celticminstrel> Macs have it too of course.
20151220 21:05:23< gfgtdf> hmm i dont see why that shoudl be better than using a regx replace tool of an ide.
20151220 21:05:44< Elvish_Hunter> For example, you can use it in Bash scripts.
20151220 21:08:42< gfgtdf> yes that is an advantage, but my question was more why it is preferable in the specific case.
20151220 21:10:48< gfgtdf> this*
20151220 21:11:57< irker575> wesnoth: gfgtdf wesnoth:master 7199146978b2 / src/ (4 files in 3 dirs): replace all '_' with spaces in event names http://git.io/vEkgI
20151220 21:11:59< irker575> wesnoth: gfgtdf wesnoth:master d02f76e3c0e4 / src/gui/dialogs/game_load.cpp: disable show replay for start-of-scenario saves http://git.io/vEkgL
20151220 21:12:01< irker575> wesnoth: gfgtdf wesnoth:master ad424f8c0342 / src/unit.cpp: remove duration='turn_end' ('turn end' still works) http://git.io/vEkgt
20151220 21:12:54< celticminstrel> So we're deprecating underscores in event names?
20151220 21:13:10< gfgtdf> celticminstrel: hmm no
20151220 21:13:40< gfgtdf> celticminstrel: im still not sure which is better to pass to wesnoth.on_event
20151220 21:14:03< gfgtdf> celticminstrel: the advantage of spaces is thats this is what most things used before
20151220 21:14:04< gfgtdf> celticminstrel: but
20151220 21:14:11< celticminstrel> Neither is better.
20151220 21:14:17< celticminstrel> Just pick one.
20151220 21:14:50< gfgtdf> celticminstrel: undersrored are leass likeley to cause issues in speicific cases, for exampl undersrored cannot be used as variable names
20151220 21:15:08< gfgtdf> whitespaces cannot*
20151220 21:15:17< celticminstrel> Event names don't need to be valid variable names.
20151220 21:15:53< celticminstrel> Though if the Lua event hook worked a bit differently, underscores would certainly be preferable.
20151220 21:16:00< gfgtdf> hmm you never know what cryzy things wml authors migth do :p
20151220 21:16:08< gfgtdf> celticminstrel: what do you mean?
20151220 21:16:40< celticminstrel> If it used a separate hook for each event type.
20151220 21:17:09< celticminstrel> For example, the game could call wesnoth.game_events.on_event[event_name] rather than wesnoth.game_events.on_event(event_name).
20151220 21:18:21< gfgtdf> celticminstrel: hmm i think the current version is better
20151220 21:18:35< gfgtdf> celticminstrel: oeiple coudl easiyl implement the second one via using the curent version
20151220 21:18:38< gfgtdf> people*
20151220 21:18:59-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151220 21:19:28< gfgtdf> celticminstrel: but that still doesnt break the undrlaying reason for underscrored
20151220 21:23:00-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151220 21:23:10< celticminstrel> True, the on_event could easily be written to simply call a function from a table.
20151220 21:26:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 256 seconds]
20151220 21:26:24-!- wedge010 is now known as wedge009
20151220 21:30:11-!- ancestral [~ancestral@97-116-163-129.mpls.qwest.net] has joined #wesnoth-dev
20151220 21:48:00-!- Appleman1234 [~Appleman1@KD119104010246.au-net.ne.jp] has joined #wesnoth-dev
20151220 21:49:50< gfgtdf> hmm ok i just installed clang-format addon for visual studio, and i cannot furegue out how to configure it to indent iniailizer lists with tabs, doe anyone know ?
20151220 22:15:33< gfgtdf> hmm semes liek thi is not possible
20151220 22:37:30< celticminstrel> Initializer lists are annoying in XCode.
20151220 22:38:14< celticminstrel> Well, XCode indenting is annoying in general though. On a scale of 1 to 10 the customization options are 2 or maaaybe 3.
20151220 22:40:35-!- travis-ci [~travis-ci@ec2-54-196-156-183.compute-1.amazonaws.com] has joined #wesnoth-dev
20151220 22:40:36< travis-ci> wesnoth/wesnoth#7981 (master - ad424f8 : gfgtdf): The build has errored.
20151220 22:40:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/98012148
20151220 22:40:36-!- travis-ci [~travis-ci@ec2-54-196-156-183.compute-1.amazonaws.com] has left #wesnoth-dev []
20151220 22:44:52-!- prkc [~prkc@54008B14.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20151220 22:49:08-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151220 22:53:40< Elvish_Hunter> Now I have to go. Bye!
20151220 22:53:46-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has left #wesnoth-dev ["Ciao!"]
20151220 22:54:03-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151220 23:14:14-!- trewe [~trewe@bl20-7-61.dsl.telepac.pt] has quit [Quit: quit]
20151220 23:15:52-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151220 23:33:10-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20151220 23:52:06-!- mjs-de [~mjs-de@f048162249.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20151220 23:59:46-!- gfgtdf [~chatzilla@x50abde55.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.1/20151216175450]]
--- Log closed Mon Dec 21 00:00:37 2015