--- Log opened Wed Dec 30 00:00:12 2015
--- Day changed Wed Dec 30 2015
20151230 00:00:12 * vultraz is around now
20151230 00:00:35< Aginor> hi vultraz 
20151230 00:01:02< Aginor> good morning :)
20151230 00:02:14< vultraz> morning 
20151230 00:03:37< Aginor> gfgtdf: 99416763f8c95d4bf475035b0625782857db345a broke master. utils/foreach.tpp is unknown
20151230 00:03:55< vultraz> maybe I will have a fresh perspective on the window issues now
20151230 00:04:29< vultraz> Aginor: ok, so, firstly, do you have any input
20151230 00:04:51< Aginor> vultraz: I did some thinking about it yesterday
20151230 00:05:15< Aginor> and this morning :)
20151230 00:05:34< Aginor> one of my thoughts was whether we should make a new branch for the refactoring and focus solely on that behaviour
20151230 00:05:45-!- travis-ci [~travis-ci@ec2-54-145-234-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 00:05:45< travis-ci> gfgtdf/wesnoth-old#572 (master - 86461b1 : gfgtdf): The build has errored.
20151230 00:05:45< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/99341897
20151230 00:05:46-!- travis-ci [~travis-ci@ec2-54-145-234-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 00:05:48< Aginor> as opposed to messing about with resolutions and the like
20151230 00:06:50< vultraz> Which behavior?
20151230 00:09:14< Aginor> refactoring out the fullscreen/maximised/etc behaviour from preferences and adding it in the video class
20151230 00:09:31< vultraz> I've done that, though
20151230 00:11:28< Aginor> so we can make that a PR without any of the other stuff?
20151230 00:11:41< Aginor> it should be easy enough to bring those parts of your diff over
20151230 00:12:56< vultraz> uuummmmmm
20151230 00:13:05-!- gfgtdf [~chatzilla@f054173017.adsl.alicedsl.de] has joined #wesnoth-dev
20151230 00:13:15< gfgtdf> loonycyborg: you know what dummy_video does in wesnothd ?
20151230 00:13:19< vultraz> Actually moving the stuff wasn't that big of a deal, actually - just updating some calls.
20151230 00:13:33< Aginor> gfgtdf: 99416763f8c95d4bf475035b0625782857db345a broke master. utils/foreach.tpp is unknown
20151230 00:14:11< loonycyborg> gfgtdf: in wesnothd in particular?
20151230 00:14:32< gfgtdf> Aginor: you sure? i thought i already fixred that
20151230 00:14:35< gfgtdf> loonycyborg: yes
20151230 00:14:37< vultraz> Aginor: most everything related to that is here https://github.com/wesnoth/wesnoth/commit/fba7634861a1779308aa20f4712656162d4c0097
20151230 00:14:46< gfgtdf> loonycyborg: does anyelse also use it ?
20151230 00:14:54< Aginor> let me fetch again and see if I simply had poor timing
20151230 00:14:59< loonycyborg> there are some callbacks to video code in wml parser and dummy video provides alternative video class for console only apps
20151230 00:15:23< vultraz> But there's also some cleanup that came before that
20151230 00:15:31< loonycyborg> so all users of wml parser would need it I think
20151230 00:15:52< gfgtdf> loonycyborg: and what does  loadscreen_empty.cpp ?
20151230 00:16:04< loonycyborg> the same
20151230 00:16:59< loonycyborg> something in parser or serialization has calls to loadscreen to update progress or so
20151230 00:17:09< Aginor> gfgtdf: ok, I had bad timing with pulling it seems. Still broken though
20151230 00:17:11< Aginor> http://pastebin.com/vsYr6JzA
20151230 00:17:12< gfgtdf> loonycyborg: hmm will try to remove it
20151230 00:17:29< vultraz> Aginor: TBH, it would be kinda difficult for me to split that bit off. I can try if you think it's really the optimal course 
20151230 00:17:35-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20151230 00:18:33< Aginor> I want to make changes that build on those changes you've made, but I'm concerned that your current PR has broken a bunch of SDL 1 related stuff
20151230 00:19:04< irker874> wesnoth: gfgtdf wesnoth:master d20cd899db80 / src/server/game.cpp: fix unused variable http://git.io/vEFqh
20151230 00:19:17< gfgtdf> Aginor: ^
20151230 00:19:25< gfgtdf> Aginor: it was just a raning no error
20151230 00:19:33< Aginor> gfgtdf: your #error commit from earlier is also breaking things :D
20151230 00:19:41< gfgtdf> Aginor: really?
20151230 00:19:44< gfgtdf> Aginor: :)
20151230 00:19:50< Aginor> /home/andreas/projects/wesnoth/src/font.cpp:57:13: error: missing terminating ' character [-Werror] #error Coudn't find floading tools.
20151230 00:20:11< gfgtdf> Aginor: i dotn uderstand that error
20151230 00:20:55< Aginor> gfgtdf: that pastebin had 2 unused variables and 1 compile error :)
20151230 00:21:17< Aginor> gfgtdf: this commit is the source of the error: https://github.com/wesnoth/wesnoth/commit/20dc698d0efcf85a14b2e231f5e59254edc8ac4b
20151230 00:21:42< irker874> wesnoth: gfgtdf wesnoth:master 256069f26f91 / src/font.cpp: fix spelling http://git.io/vEFmh
20151230 00:21:52< gfgtdf> Aginor: try that ^
20151230 00:22:15< Aginor> I'll still hit your #error though
20151230 00:22:49< vultraz> Aginor: hm... so you want to test that part of the refactor under SDL1?
20151230 00:23:13< gfgtdf> Aginor: y i woinder whetehr there it was an error in parsing #ifdef or whether it actualyl hitz that #error
20151230 00:23:30< Aginor> vultraz: it ALL still has to work with SDL1 still
20151230 00:23:42< gfgtdf> Aginor: i could've removed it  but i wanted to find out
20151230 00:23:43< Aginor> gfgtdf: not hitting the #error this time
20151230 00:23:45< Aginor> gfgtdf: /home/andreas/projects/wesnoth/src/playturn.cpp:355:25: error: unused variable ‘cfg_host_transfer’ [-Werror=unused-variable] else if (const config &cfg_host_transfer = cfg.child("host_transfer")){
20151230 00:24:00-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20151230 00:24:38< gfgtdf> Aginor: so it found an error ina  cpode that was inside a deactivedd #if ?
20151230 00:26:05-!- travis-ci [~travis-ci@ec2-54-159-6-59.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 00:26:06< travis-ci> wesnoth/wesnoth#8022 (master - 9e2b2a2 : gfgtdf): The build was canceled.
20151230 00:26:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99343978
20151230 00:26:06-!- travis-ci [~travis-ci@ec2-54-159-6-59.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 00:26:42< Aginor> gfgtdf: playturn.cpp:355 isn't deactivated
20151230 00:26:50< Aginor>  < Aginor> gfgtdf: not hitting the #error this time
20151230 00:26:53< gfgtdf> Aginor: yes i meant the other one
20151230 00:26:58-!- travis-ci [~travis-ci@ec2-54-205-125-171.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 00:26:59< travis-ci> wesnoth/wesnoth#8023 (master - b9e13d2 : gfgtdf): The build was canceled.
20151230 00:26:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99345744
20151230 00:26:59-!- travis-ci [~travis-ci@ec2-54-205-125-171.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 00:27:14< Aginor> I'm not sure why I hit it the first time
20151230 00:27:43-!- travis-ci [~travis-ci@ec2-54-145-234-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 00:27:44< travis-ci> wesnoth/wesnoth#8021 (master - da949dd : gfgtdf): The build has errored.
20151230 00:27:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99343467
20151230 00:27:44-!- travis-ci [~travis-ci@ec2-54-145-234-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 00:28:48< Aginor> vultraz: it's annoying to keep SDL1 working, but we need it as the fallback option in case we don't manage to fix all the other bugs
20151230 00:29:07-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20151230 00:29:20< vultraz> I sincerely hope that doesn't happen 
20151230 00:29:38< Aginor> me too :)
20151230 00:31:31-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20151230 00:38:29< vultraz> An option would be to put off merging this until after 1.13.3
20151230 00:42:58-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20151230 00:44:53< Aginor> it certainly is
20151230 00:45:10< Aginor> I will need to re-create of of this functionality in the meanwhile though
20151230 00:45:25< vultraz> All of it D:
20151230 00:45:27< vultraz> ?*
20151230 00:45:40< Aginor> +some
20151230 00:45:48< gfgtdf> i realy think remembering windowsize, and specialyl whether its maximized is a usefulfeature to hav for 1.13.3
20151230 00:46:18< gfgtdf> but more important is teh blackscreen issue in gui1 dialogs
20151230 00:46:31< Aginor> gfgtdf: something I'm working on at the moment
20151230 00:46:48< Aginor> although compiler errors/warnings that cause my build to fail is a bit of a blocker :D
20151230 00:47:24< vultraz> Aginor: ok, uhh... if I split off the 'code move' part of my PR into another one, would that save you work
20151230 00:47:32< gfgtdf> Aginor: im currently waitign gfor the travis buidl to know ehterh that wanrong is all i have to do or whether there is more.
20151230 00:47:50< gfgtdf> Aginor: cant you disable 'treat warniongs as errors' in your compiler?
20151230 00:48:00< vultraz> (i just did a rebase to merge a bunch of small/fixups, so I think it'd manageable now)
20151230 00:48:11-!- travis-ci [~travis-ci@ec2-54-205-125-171.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 00:48:12< travis-ci> wesnoth/wesnoth#8028 (master - 256069f : gfgtdf): The build was broken.
20151230 00:48:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99358518
20151230 00:48:12-!- travis-ci [~travis-ci@ec2-54-205-125-171.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 00:48:17< gfgtdf> ah it passed
20151230 00:48:55< vultraz> plus gfgtdf said some stuff should go directly to master
20151230 00:49:21< irker874> wesnoth: gfgtdf wesnoth:master feb78d8f9ce9 / src/playturn.cpp: fix unused variable http://git.io/vEFGz
20151230 00:49:33< gfgtdf> vultraz: only ver simpplest stuff
20151230 00:49:41< vultraz> ya
20151230 00:49:42< gfgtdf> vultraz: basiablly teh 2 commits i mentioned
20151230 00:50:20< vultraz> alright lemme push those
20151230 00:52:04-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20151230 00:53:08< Aginor> gfgtdf: that last commit looks good :)
20151230 00:53:23< irker874> wesnoth: Charles Dang wesnoth:master a929397cc02d / src/ (game_launcher.cpp preferences_display.cpp video.cpp video.hpp): Removed an additional macro alias for fullscreen http://git.io/vEFZT
20151230 00:53:26< irker874> wesnoth: Charles Dang wesnoth:master 9be88c88a479 / src/game_preferences.hpp: Removed orphaned function declaration http://git.io/vEFZk
20151230 00:53:30< vultraz> gfgtdf: ^
20151230 00:54:28< vultraz> ok, let me get the other stuff split into a PR for Aginor and then I have to go to lunch
20151230 00:57:26-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20151230 00:58:11-!- Greg-Boggs [~greg_bogg@2601:1c2:901:5227:b109:6a60:82ea:1a3b] has joined #wesnoth-dev
20151230 00:59:35< vultraz> gfgtdf: can this go into master? https://github.com/wesnoth/wesnoth/commit/223b33f9609cad9606908706ced39c4b228f160f
20151230 00:59:38< vultraz> it's not related to my stuff
20151230 01:00:42< Aginor> if it's still compiling I'd say so :)
20151230 01:00:43< gfgtdf> sure,
20151230 01:01:01< gfgtdf> i didnt look into it that muhc and assumes that its related to your stuff
20151230 01:01:06< gfgtdf> assumed
20151230 01:01:17< gfgtdf> but if you say it isnt than it can sure go into master
20151230 01:01:58< gfgtdf> vultraz: i noticed that your pr uses disp.get_singleton()
20151230 01:02:06< gfgtdf> vultraz: disp.get_singleton() is known to be broken afaik
20151230 01:02:06< vultraz> is that bad?
20151230 01:03:14< gfgtdf> vultraz: unless Aginor has already fixed this i'D say it is
20151230 01:03:26-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20151230 01:03:41-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20151230 01:04:32< gfgtdf> vultraz: see this commit https://github.com/wesnoth/wesnoth/commit/36456df46f6e4e1507ef3f99ad953c1d26fe3eb9 and related bugreports
20151230 01:04:55< vultraz> Aginor: https://github.com/wesnoth/wesnoth/pull/568
20151230 01:05:01< gfgtdf> vultraz: i think what we shoudl think about is what how twindow and cvideo relate to each other
20151230 01:05:03< Aginor> thanks vultraz 
20151230 01:05:32< vultraz> Aginor: let me know if I included too much/too little
20151230 01:06:14< gfgtdf> i thouight Cvideo represtents a 'window' but now i saw that we also have the twindow class
20151230 01:06:24< Aginor> gfgtdf: it used to
20151230 01:06:39< Aginor> we have the option to do multiple windows now, but the game isn't designed for it
20151230 01:06:51< gfgtdf> Aginor: so what does cvideo now ?
20151230 01:07:48< Aginor> it will mostly be a facade over twindow, but it also provides additional helper function that is more in the purview of the rendering pipeline
20151230 01:08:09< Aginor> they should not be folded together
20151230 01:09:01< gfgtdf> Aginor: i just saw that cvideo stores most if its variables as static variables, see for example here: https://github.com/wesnoth/wesnoth/blob/master/src/video.cpp#L239
20151230 01:09:13< gfgtdf> Aginor: specialyl it sotres its twindow as a static varable
20151230 01:09:27< gfgtdf> Aginor: wouldnt it make much more sense to have all its methods static then?
20151230 01:10:41< Aginor> I'd rather not have it in a static variable
20151230 01:11:09< Aginor> rewriting the video class is a lot les urgent than fixing a bunch of other stuff
20151230 01:11:24< Aginor> the video class is supposedly one of the oldest pieces of code around
20151230 01:11:29< Aginor> video and display
20151230 01:11:57< Aginor> I think it'd be better to rather closely examine how much they overlap and what additional functionality they have that are outside their scope
20151230 01:12:59< gfgtdf> Aginor: the 'display' classes shoudl handle the game display that is the screen that show teh map the sidebar.. what uis defined by themewml
20151230 01:16:38< Aginor> it does quite a bit other than that at the moment, and it could probably do with a rename to something more suitable than "display" maybe "gameview" or something similar
20151230 01:18:23< gfgtdf> Aginor: i dont think it does  much more, maybe 1 or 2 methods
20151230 01:18:45< vultraz> gfgtdf: your commit to check floating point rounding is throwing a lot of errors for me :|
20151230 01:18:53< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\wesnoth.cpp|523|error: '_controlfp_s' was not declared in this scope|
20151230 01:18:57< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\wesnoth.cpp|525|error: '_MCW_RC' was not declared in this scope|
20151230 01:18:59< vultraz> etc
20151230 01:19:00< gfgtdf> vultraz: at runtime or at somciletime?
20151230 01:19:05< gfgtdf> vultraz: hmm
20151230 01:19:08< vultraz> compile
20151230 01:19:12< gfgtdf> vultraz: at latest master?
20151230 01:19:33< vultraz> im building one of my branches but i just rebased
20151230 01:19:34< gfgtdf> vultraz: wait, you get these error on windows?
20151230 01:19:37< vultraz> from master
20151230 01:19:39< vultraz> yes
20151230 01:19:40< vultraz> windows 10
20151230 01:20:08< gfgtdf> vultraz: hmm that code is oina  #ifndef _WIN32
20151230 01:20:11< gfgtdf> in a
20151230 01:20:22< vultraz> no it's a #ifdef _WIN32
20151230 01:20:26< gfgtdf> your cimpiler shouldnt use it
20151230 01:20:35< gfgtdf> vultraz: ahh right
20151230 01:20:44< ancestral> Okay, I’m going to stash drop everything and pull down
20151230 01:20:46< ancestral> Scray moment
20151230 01:20:58< ancestral> “scray”
20151230 01:21:07< gfgtdf> vultraz: someone else recently git a similar error in the #else part so i thought it wa steh same error
20151230 01:21:19< gfgtdf> vultraz: mostlikeley an additional include is needed
20151230 01:22:00< vultraz> yeah, probably
20151230 01:22:25< gfgtdf> vultraz: try adding a #include <float.h> in a #ifdef _WIN32
20151230 01:22:30< gfgtdf> vultraz: it it works commit it
20151230 01:24:54< gfgtdf> Aginor: i'll try moving all those variables to memeber s of cvideo
20151230 01:26:20< vultraz> gfgtdf: I have to go but ill try when i get back
20151230 01:36:25< irker874> wesnoth: ancestral wesnoth:ancestral_new_icon b7595d4a2c56 / changelog projectfiles/Xcode/Resources/icon.icns: New hi-res icon using new logo for OS X http://git.io/vEF8E
20151230 01:37:00< ancestral> Any objections to me just pushing the request through?
20151230 01:37:35-!- Greg-Boggs [~greg_bogg@2601:1c2:901:5227:b109:6a60:82ea:1a3b] has quit [Remote host closed the connection]
20151230 01:38:08< Aginor> none from me
20151230 01:38:14< Aginor> thanks for fixing my typo :)
20151230 01:39:32< ancestral> So minor
20151230 01:39:39< ancestral> Barely a typo
20151230 01:39:54< irker874> wesnoth: ancestral wesnoth:master b7595d4a2c56 / changelog projectfiles/Xcode/Resources/icon.icns: New hi-res icon using new logo for OS X http://git.io/vEF8E
20151230 01:39:56< irker874> wesnoth: Martin Proud wesnoth:master 3da4f81ad60f / changelog projectfiles/Xcode/Resources/icon.icns: Merge pull request #569 from wesnoth/ancestral_new_icon http://git.io/vEF8A
20151230 01:46:50-!- Greg-Boggs [~greg_bogg@2601:1c2:901:5227:b109:6a60:82ea:1a3b] has joined #wesnoth-dev
20151230 01:47:52< Aginor> hmm
20151230 01:48:01< Aginor> resizing just turned a lot less laggy :)
20151230 02:01:04-!- travis-ci [~travis-ci@ec2-54-92-208-68.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 02:01:05< travis-ci> wesnoth/wesnoth#8031 (master - feb78d8 : gfgtdf): The build is still failing.
20151230 02:01:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99361274
20151230 02:01:05-!- travis-ci [~travis-ci@ec2-54-92-208-68.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 02:17:21< irker874> wesnoth: gfgtdf wesnoth:master c101c0ca81dc / src/make_enum.hpp: fix enum.parse(const char*) in MAKE_ENUM. http://git.io/vEFuq
20151230 02:17:37< gfgtdf> Aginor: what did you do ?
20151230 02:22:57< Aginor> gfgtdf: I'm adding event filtering after a resize event during a timeout. The intent is to draw a black rectangle in the window for <TIMEOUT> after a resize event before telling the game to update all screen layouts and redraw
20151230 02:23:24< Aginor> that would read better in two sentences, let me try again
20151230 02:24:07< Aginor> gfgtdf: I'm adding event filtering after a resize event during a timeout. The intent is to draw a black rectangle in the window for <TIMEOUT> after a resize event. Once the <TIMEOUT> has expired no more filtering will take place and the game  will be told to update all screen layouts and redraw
20151230 02:25:48< gfgtdf> y that mkae sense
20151230 02:27:16< Aginor> it does require a whole bunch of changes to how window events are processed. It will fix quite a few of the resize related problems though, and make resizes better than they ever were
20151230 02:27:26-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Ping timeout: 272 seconds]
20151230 02:27:33< Aginor> a full redraw for us is incredibly costly though, about 400ms for me
20151230 02:27:43< Aginor> that's not even funny
20151230 02:30:16-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20151230 02:30:16-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20151230 02:30:35-!- VultCave is now known as vultraz
20151230 02:32:33< gfgtdf> during the game or during a dialog/tilescreen?
20151230 02:34:25-!- gfgtdf [~chatzilla@f054173017.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.2/20151221130713]]
20151230 02:35:49< Aginor> titlescreen
20151230 02:49:21-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151230 03:19:10-!- travis-ci [~travis-ci@ec2-54-145-234-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 03:19:11< travis-ci> wesnoth/wesnoth#8032 (master - 9be88c8 : Charles Dang): The build is still failing.
20151230 03:19:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99361696
20151230 03:19:11-!- travis-ci [~travis-ci@ec2-54-145-234-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 03:39:31-!- Greg-Boggs [~greg_bogg@2601:1c2:901:5227:b109:6a60:82ea:1a3b] has quit [Remote host closed the connection]
20151230 03:45:42-!- travis-ci [~travis-ci@ec2-54-145-234-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 03:45:43< travis-ci> wesnoth/wesnoth#8035 (ancestral_new_icon - 9be88c8 : Charles Dang): The build has errored.
20151230 03:45:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99365000
20151230 03:45:43-!- travis-ci [~travis-ci@ec2-54-145-234-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 03:47:50-!- travis-ci [~travis-ci@ec2-54-205-125-171.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 03:47:51< travis-ci> wesnoth/wesnoth#8036 (ancestral_new_icon - b7595d4 : ancestral): The build has errored.
20151230 03:47:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99365642
20151230 03:47:51-!- travis-ci [~travis-ci@ec2-54-205-125-171.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 03:55:02-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20151230 03:55:43< vultraz> Aginor: you're improving resize events? :D
20151230 03:55:51< vultraz> Aginor: that might have some bearing on my issues
20151230 03:56:45-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20151230 03:56:45-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20151230 03:57:35< vultraz> gfgtdf: including float.h doesn't fix the issue
20151230 04:00:38< vultraz> hmmm
20151230 04:00:39< vultraz> https://stackoverflow.com/questions/29134150/variable-not-declared-in-this-scope-mingw-w64
20151230 04:00:52< vultraz> except im using 32
20151230 04:01:30< vultraz> Aginor: have you changed handling of GUI2's resize events?
20151230 04:01:58< vultraz> ie, twindow::signal_handler_sdl_video_resize() and thandler::video_resize()
20151230 04:02:15-!- Greg-Boggs [~greg_bogg@2601:1c2:901:5227:b109:6a60:82ea:1a3b] has joined #wesnoth-dev
20151230 04:04:04< vultraz> Aginor: it seems weird to me that GUI2 handles its own resize events. Shouldn't there be a 'global' event handler?
20151230 04:05:58< vultraz> Aginor: also, if you're refactoring resize events, perhaps it will solve the issue i was having with window dimensions being changed twice under certain conditions
20151230 04:07:33-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20151230 04:07:33-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20151230 04:07:33-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20151230 04:07:59< Aginor> vultraz: give me a moment and I'll push my first set of changes to github
20151230 04:08:03< vultraz> :D 
20151230 04:08:05< vultraz> changes!
20151230 04:08:37< vultraz> I hope my PR was useful to you
20151230 04:08:47< Aginor> it comes next ;)
20151230 04:09:52< Aginor> but yes, it is
20151230 04:17:18-!- Greg-Boggs [~greg_bogg@2601:1c2:901:5227:b109:6a60:82ea:1a3b] has quit [Remote host closed the connection]
20151230 04:19:01< Aginor> vultraz: https://github.com/wesnoth/wesnoth/pull/570
20151230 04:19:39< Aginor> I believe that fixes a number of historical bugs too :)
20151230 04:19:55< Aginor> next up is to incorporate your PR and build on it
20151230 04:20:28< vultraz> Ok, what do you need me to do
20151230 04:20:52< Aginor> I'm not sure
20151230 04:20:57< Aginor> what do you want to do? :D
20151230 04:21:04< celticminstrel> Gah, I broke forloops altogether.
20151230 04:21:14< vultraz> Whatever is needed to make wesnoth work :P
20151230 04:21:26< Aginor> vultraz: you're on windows, right?
20151230 04:21:31< vultraz> 10, yes
20151230 04:21:43< Aginor> vultraz: is the window icon behaving for you?
20151230 04:21:44< vultraz> sadly, gfgtdf's commit is still giving me grief >_>
20151230 04:21:50< celticminstrel> Wait, no, there's something else wrong here.
20151230 04:21:57< vultraz> Aginor: as far as I've been seeing, yes
20151230 04:22:02< vultraz> perfectly.
20151230 04:22:04< vultraz> why?
20151230 04:22:37< Aginor> I've have been racking my brains to find out what might cause https://gna.org/bugs/index.php?23910
20151230 04:23:16< vultraz> I have never seen that
20151230 04:23:18< vultraz> Ever
20151230 04:23:24< celticminstrel> Oh, that was just me passing the wrong parameter.
20151230 04:23:40< vultraz> then again, I think I always use debug mode
20151230 04:24:24< vultraz> but even when i don't, I've never observed such a thing
20151230 04:24:55< Aginor> that's a shame, I'd like help with that one because it's a windows bug as far as I can tell
20151230 04:25:08< celticminstrel> Sigh. The tests were failing because of invalid keys in my preferences file.
20151230 04:25:16< celticminstrel> Strict mode can be annoying.
20151230 04:25:19< vultraz> well... if I see it I'll report 
20151230 04:25:41< Aginor> hmm
20151230 04:25:51< Aginor> I need to review and then merge your PR a bit more
20151230 04:26:05< Aginor> incorporate those changes into my work-branch
20151230 04:26:14< Aginor> then try to fix GUI1 resize problems
20151230 04:26:17< vultraz> 568 or 566?
20151230 04:26:30< Aginor> 568 firstly I'd say
20151230 04:26:39< Aginor> it's a lot cleaner :)
20151230 04:26:41< vultraz> Ok, then I'll remove those commits from 566
20151230 04:26:49< vultraz> if I can get a working build again...
20151230 04:27:56< celticminstrel> "Repeated [endlevel] execution, ignoring"
20151230 04:28:09< vultraz> celticminstrel: wat you doing?
20151230 04:28:20< celticminstrel> That happened in one of my test cases.
20151230 04:28:46< celticminstrel> What's the command-line arg to set the data dir?
20151230 04:28:50< celticminstrel> --data-dir=blah?
20151230 04:29:01< vultraz> not sure
20151230 04:29:03< vultraz> check --help
20151230 04:29:24< celticminstrel> If my guess is wrong, then I will.
20151230 04:30:15< vultraz> celticminstrel: BTW, quick C++ question: which is preferred: anon namespace or static?
20151230 04:30:22< celticminstrel> I'm running the test cases for [for] after attempting to fix the issue Pentarctagon found.
20151230 04:30:30< celticminstrel> Sorry, your question is unanswerable.
20151230 04:31:08< vultraz> so, it doesn't matter?
20151230 04:31:15< celticminstrel> It's a question of the style guide if anything.
20151230 04:31:22< vultraz> ok
20151230 04:31:36< vultraz> because I saw some stuff on SO saying static was deprecated or something..
20151230 04:31:41< vultraz> and some people saying that was reverted...
20151230 04:31:50< celticminstrel> If it were my call I'd say use static if there's just one thing and an anon namespace if you have a lot of stuff.
20151230 04:31:55< celticminstrel> But it's not my call.
20151230 04:32:32< celticminstrel> Static was definitely deprecated in uh... C++03 I think? I dunno if that was reversed.
20151230 04:33:41< Aginor> vultraz: PR568 is broken with SDL1.2, I cannot merge it as it stands :/
20151230 04:33:51< vultraz> DAMMIT
20151230 04:33:57< vultraz> Aginor: what's the problem
20151230 04:34:05< Aginor> I'm also concerned about commit https://github.com/Vultraz/wesnoth/commit/63c14819acb16d90278b9139a2acdb4c8267227b
20151230 04:34:24< vultraz> oh?
20151230 04:34:36< Aginor> http://pastebin.com/V8i7kSDN
20151230 04:34:55< Aginor> that commit looks like it might break stuff for SDL1
20151230 04:35:07< vultraz> uhhhh....
20151230 04:35:27< Aginor> maybe
20151230 04:35:29< vultraz> line 5 dosn't make sense
20151230 04:35:35< vultraz> the function should be in the file
20151230 04:35:44< Aginor> but I haven't checked that carefully yet
20151230 04:36:02< vultraz> likewise with line 8
20151230 04:36:14< vultraz> oh, the double arrow is me
20151230 04:36:25 * Aginor is checking master just to be safe
20151230 04:37:03< vultraz> i'll force-push a fix for that ->->
20151230 04:37:15< vultraz> god dammit, master still not building for me
20151230 04:37:25< vultraz> mingw t(-_-t)
20151230 04:37:34< Aginor> raise a bug, assign it to whoever broke it :D
20151230 04:37:53< vultraz> no no, it's a compiler issue, i think
20151230 04:39:33< celticminstrel> Okay, the tests passed, now I'd like someone to review this commit.
20151230 04:39:36< vultraz> Aginor: I pushed a fix for the ->->
20151230 04:40:13< vultraz> Aginor: does it build now?
20151230 04:40:40< Aginor> I'm still checking master :D
20151230 04:40:55< Aginor> just to make sure I didn't break that in the past without realising
20151230 04:42:33< Aginor> vultraz: still broken
20151230 04:42:41< vultraz> master or 568?
20151230 04:42:45< Aginor> 568
20151230 04:42:48< Aginor> master is fine
20151230 04:42:51< vultraz> fuck
20151230 04:43:06< vultraz> same errors?
20151230 04:43:22< Aginor> apart from the double ->, yes
20151230 04:43:24< celticminstrel> https://github.com/CelticMinstrel/wesnoth/commit/64ddd50895b0e91a29d6d3ede4152faea0924e71
20151230 04:44:44< vultraz> I don't understand it
20151230 04:44:49< vultraz> set_resolution is right there in the file
20151230 04:44:51< vultraz> :|
20151230 04:44:58< vultraz> maybe it wants CVideo::?
20151230 04:45:42< celticminstrel> Oh, you force-pushed and lost most of the comments.
20151230 04:46:00< vultraz> celticminstrel: comments are still in 566
20151230 04:46:05< vultraz> hmm
20151230 04:46:21< celticminstrel> I can't see them though. Whatever.
20151230 04:46:40< celticminstrel> All the comments attached to specific commits.
20151230 04:46:57< celticminstrel> Maybe they're still there if you look at the individual commits.
20151230 04:49:50< vultraz> Aginor: can you try again now? (forcepushed)
20151230 04:53:57< Aginor> /home/andreas/projects/wesnoth-master/src/video.cpp:54:40: error: ‘set_resolution’ was not declared in this scope
20151230 04:54:10< Aginor> is because you don't have a reference to the video object
20151230 04:54:45< vultraz> oh
20151230 04:54:53< vultraz> I thought calling the class would fix that
20151230 04:55:01< Aginor> nope, it's not static
20151230 04:55:16< vultraz> ah
20151230 04:55:36< vultraz> what would be the proper way to fix that, then?
20151230 04:55:41< vultraz> initialize a CVideo object?
20151230 04:56:00< Aginor> yuck, no
20151230 04:56:06< vultraz> thought not
20151230 04:57:04< Aginor> hacky fix is to ask the display singleton for its cvideo object
20151230 04:57:16< Aginor> the proper fix would be to de-concolute that entire call-chain
20151230 04:57:25< Aginor> de-convolute even
20151230 04:57:42< vultraz> de-convolute?
20151230 04:57:59< vultraz> I don't follow
20151230 04:58:08< Aginor> there's a number of calls back and forth between cvideo and display in for that event, it can be simplified
20151230 04:59:57 * vultraz is still unsure how
20151230 05:00:44< Aginor> CVideo::set_resolution(const std::pair<int,int>& resolution gets the display singleton and checks if it's non-null
20151230 05:01:04< vultraz> right
20151230 05:01:05< Aginor> then invokes CVideo::set_resolution(const unsigned width, const unsigned height)
20151230 05:01:26< vultraz> I kinda want to merge those two functions eventually
20151230 05:01:42< vultraz> but that's not relevant I guess
20151230 05:02:07< Aginor> that would be a part of de-convoluting it :)
20151230 05:02:26< Aginor> the calling path there is as crooked as a windy old road :D
20151230 05:03:16< vultraz> One function still relies on the bool version
20151230 05:03:23< Aginor> bool CVideo::set_resolution(const unsigned width, const unsigned height) doesn't actually do anything either
20151230 05:03:31< Aginor> more than saving the preferences
20151230 05:03:32< vultraz> well
20151230 05:03:34< vultraz> two
20151230 05:03:36< Aginor> setMode is commented out
20151230 05:03:54< vultraz> signal_handler_sdl_video_resize
20151230 05:04:12< vultraz> Aginor: yes, in 566 setmode is uncommented
20151230 05:04:16< vultraz> so it actually sets the res
20151230 05:04:33< vultraz> should I move that to 568?
20151230 05:05:10< Aginor> I don't follow
20151230 05:05:26< vultraz> I'm actually not sure how sdl1 changed resolution
20151230 05:05:39< vultraz> in my 566 PR i uncommented that setMode call in bool set_resolution
20151230 05:05:49< vultraz> in order to actually affect the window when it's called
20151230 05:05:52< Aginor> int CVideo::setMode( int x, int y, int bits_per_pixel, int flags )
20151230 05:06:12< vultraz> O'm asking if I should move the commit from 566 that uncomments that to 568
20151230 05:06:24< Aginor> ah, yes
20151230 05:06:43< Aginor> maybe just call display::get_singleton() for now
20151230 05:06:47< Aginor> remember the null check
20151230 05:08:30< vultraz> display::get_singleton().video->set_resolution(info.resize_dimensions); right?
20151230 05:08:32< vultraz> or is it video()
20151230 05:10:34< Aginor> video()
20151230 05:10:52< Aginor> but you need to check that display::get_singleton() doesn't return null
20151230 05:11:03< vultraz> yes
20151230 05:13:49-!- travis-ci [~travis-ci@54.145.234.145] has joined #wesnoth-dev
20151230 05:13:50< travis-ci> wesnoth/wesnoth#8038 (master - 3da4f81 : Martin Proud): The build is still failing.
20151230 05:13:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99365901
20151230 05:13:50-!- travis-ci [~travis-ci@54.145.234.145] has left #wesnoth-dev []
20151230 05:15:18< vultraz> Aginor: mk, try again
20151230 05:18:00-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20151230 05:18:18-!- irker874 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151230 05:23:04-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 245 seconds]
20151230 05:23:34-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20151230 05:25:05-!- oldlaptop [~quassel@50-37-38-205.mskg.mi.frontiernet.net] has quit [Ping timeout: 276 seconds]
20151230 05:29:25< vultraz> OK i think I found my compiler problem
20151230 05:29:35< vultraz> both mingw and gcc include float.h
20151230 05:29:38< vultraz> the former is found first
20151230 05:29:43< vultraz> doesn't include the necessary defines
20151230 05:29:48< vultraz> so i replaced the former with the latter
20151230 05:29:57< vultraz> hopefully it will work
20151230 05:30:52< vultraz> Aginor: 568 build now?
20151230 05:35:35-!- oldlaptop [~quassel@50-37-38-205.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20151230 05:35:42< vultraz> dammit, master still notbuilding
20151230 05:39:20-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has joined #wesnoth-dev
20151230 05:39:59< ancestral> Remind me, is SDL1 being deprecated at 13.3.4, or 14.x?
20151230 05:40:09< celticminstrel> The former.
20151230 05:40:16< ancestral> So right away, basically
20151230 05:40:17< ancestral> Okay
20151230 05:40:35< celticminstrel> There'll be only one minor version that officially supports both, yes.
20151230 05:44:29< ancestral> I get it, sort of bridge the gap/make sure SDL2 works fully
20151230 05:50:25< ancestral> Hmm, the question mark in “my kind”? should be inside the last end quote
20151230 05:50:42< celticminstrel> That depends.
20151230 05:50:42< ancestral> (Happens to be in my screenshot: http://mproud.com/wesnoth/gameplay-fonts.png)
20151230 05:51:04-!- oldlaptop [~quassel@50-37-38-205.mskg.mi.frontiernet.net] has quit [Ping timeout: 276 seconds]
20151230 05:51:21< celticminstrel> By British style guides, outside the quotes is definitely correct.
20151230 05:51:23< ancestral> I thought it was well established by Chicago Manual of Style, AP and others
20151230 05:51:40< celticminstrel> Not sure.
20151230 05:51:52-!- d4nf [~d4nf@ool-182ee6a9.dyn.optonline.net] has joined #wesnoth-dev
20151230 05:52:01< celticminstrel> I know they say that of periods and commas, but question/exclamation marks might not follow the same rules.
20151230 05:52:24< celticminstrel> In my personal opinion, putting the question mark inside the quote in that particular example would be incredibly illogical.
20151230 05:52:55< ancestral> http://www.thepunctuationguide.com/british-versus-american-style.html
20151230 05:53:06< ancestral> Looks like it’s an American vs. British English style choice
20151230 05:53:35< celticminstrel> That link doesn't seem to help.
20151230 05:53:43< ancestral> celticminstrel: I hear you on logical reasoning. I think its done stylistically.
20151230 05:53:56< ancestral> celticminstrel: Go to the bottom
20151230 05:54:13< celticminstrel> Ohhh, right.
20151230 05:54:20< ancestral> Stylistically, meaning it may seem “cleaner” to have everything inside the quotes.
20151230 05:54:23< celticminstrel> So the current way is correct even by American style guides.
20151230 05:54:29< ancestral> Umm
20151230 05:54:31< ancestral> No
20151230 05:54:41< celticminstrel> "For all other punctuation, the British and American styles are in agreement: unless the punctuation is part of the quoted material, it goes outside the quotation marks."
20151230 05:55:07< celticminstrel> Punctuation other than commas and periods, that is.
20151230 05:55:23< ancestral> For all other
20151230 05:55:26< celticminstrel> You said "go to the bottom". That's literally the last sentence on the page. :P
20151230 05:55:32< ancestral> This fits in the above example
20151230 05:55:44< ancestral> Okay, “last visible page’s worth”
20151230 05:55:49< celticminstrel> Yes, so the example in the screenshot is correct by both British and American style guides.
20151230 05:55:59< ancestral> No
20151230 05:56:06< celticminstrel> That's what your link says!
20151230 05:56:07< ancestral> It’s correct in British style
20151230 05:56:16< ancestral> Start at “Quotations” section
20151230 05:56:19< celticminstrel> Your link says it's also correct in American style.
20151230 05:56:22< ancestral> In that page
20151230 05:56:32< ancestral> Hang on
20151230 05:56:34< celticminstrel> I read it already.
20151230 05:56:46< vultraz> dammit, gcc's float.h doesn't work either
20151230 05:56:49< vultraz> WTF is going on here!
20151230 05:56:50< ancestral> “The above examples also show that the American style places commas and periods inside the quotation marks, even if they are not in the original material.”
20151230 05:57:06< celticminstrel> Correct. That only applies to commas and periods, not to question marks.
20151230 05:57:12< celticminstrel> As the final sentence makes clear.
20151230 05:57:45< ancestral> Let’s try this
20151230 05:57:45< ancestral> http://www.thepunctuationguide.com/terminal-points.html
20151230 05:58:27< vultraz> ancestral: what's that a screenshot of?
20151230 05:58:48< celticminstrel> vultraz: It's a screenshot showing where Wesnoth is using the wrong fonts.
20151230 05:58:51< ancestral> vultraz: The South Guard, I think; the very first scenario.
20151230 05:58:56< celticminstrel> Oh yeah, it's TSG.
20151230 05:59:07< ancestral> vultraz: Red is fonts not rendered correctly
20151230 05:59:19< ancestral> :-\
20151230 05:59:24< celticminstrel> ancestral: That link also supports that the screenshot does it correctly.
20151230 05:59:27< vultraz> ancestral: interestingly enough, the red looks better than the green :P
20151230 06:00:14< ancestral> vultraz: The red is offset needlessly up and it’s wayyy smaller than it should be
20151230 06:00:25< celticminstrel> Do the green parts have anything in common?
20151230 06:00:31< ancestral> celticminstrel: “Quotation ending with a question mark” x “Sentence is a question”
20151230 06:00:51< celticminstrel> ancestral: The quotation doesn't end with a question mark.
20151230 06:01:19< celticminstrel> It's not quoting from the start of that dialogue. It would be quoting something from the previous dialogue segment (but it's quoting it twice, really).
20151230 06:01:39< Aginor> vultraz: no
20151230 06:01:45< vultraz> ;_;
20151230 06:02:04-!- oldlaptop [~quassel@50-37-38-205.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20151230 06:02:12< ancestral> What do you mean, my kind?
20151230 06:02:21< ancestral> Did you just ask, Why me?
20151230 06:02:52< ancestral> Seems they are the same types of phrases
20151230 06:02:59< celticminstrel> Maybe...
20151230 06:03:01< ancestral> (Perhaps “my” should be capitalized in “my kind”)
20151230 06:03:17< vultraz> Aginor: what's the error?
20151230 06:03:21< ancestral> Of course, this page is only citing Chicago Manual of Style
20151230 06:03:43< ancestral> I don’t know/remember/super much care what Wesnoth’s using
20151230 06:03:52< ancestral> But I feel like it’s in the wiki somewhere
20151230 06:04:26< celticminstrel> I'm pretty sure it's not using any manual of style.
20151230 06:04:32< ancestral> I’m just a little happy we’ve got curly quotes now
20151230 06:04:45< celticminstrel> Considering how that one guy came in and made a lot of bad corrections to conform to some manual of style.
20151230 06:05:03< ancestral> Pretty sure Espreon carried the lexical torch for a while 
20151230 06:05:06< Aginor> vultraz: change line 55 of video.cpp to this:
20151230 06:05:15< Aginor> display::get_singleton()->video().set_resolution(info.resize_dimensions);
20151230 06:05:24< celticminstrel> Style manuals are not well-suited to informal writing, though some aspects of them (like punctuation) can still be followed.
20151230 06:05:38< ancestral> http://wiki.wesnoth.org/Typography_Style_Guide
20151230 06:05:57< celticminstrel> ancestral: "You’ll never take this village! I’ve seen your kind kill too many townsmen, and I’ll defend them to the death!" // "My kind? I am a soldier of Wesnoth, a messenger of King Haldric, and the new commander of the South Guard! What do you mean, <i>“my kind”</i>?"
20151230 06:06:02< celticminstrel> It's not even a direct quote.
20151230 06:06:05< ancestral> “This is as distinct from the US 'traditional punctuation' style, where full stops and commas tend to appear inside the quotation marks even if they are not part of the quote.”
20151230 06:06:06< ancestral> Alright
20151230 06:06:18< ancestral> Hmm
20151230 06:06:28< celticminstrel> "my kind" twice referencing back to where the previous speaker said "your kind".
20151230 06:11:19< ancestral> I’d be curious what shadowm thought, but there are bigger fish to try
20151230 06:11:21< ancestral> *fry
20151230 06:12:02< ancestral> Try the fish after they’ve been fried. Because fish is best when fried.
20151230 06:16:57< celticminstrel> That wiki page states that Wesnoth prefers the periods and commas to adhere to British style..
20151230 06:17:24< vultraz> crap
20151230 06:17:27< ancestral> vultraz: Part of the reason the green might look bad is because I actually swapped the font out
20151230 06:18:43< ancestral> Anyway, I’m nervous this might not get resolved before 1.14
20151230 06:18:48< celticminstrel> It also says that two exclamation marks are acceptable, but not three. Interesting.
20151230 06:19:01< ancestral> Two of the same just seems tacky to me
20151230 06:19:11 * celticminstrel personally prefers to use one or three, but never more than three and generally not two.
20151230 06:19:55-!- irker176 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151230 06:19:55< irker176> wesnoth: Charles Dang wesnoth:master f888dc659157 / src/preferences_display.cpp: Cleaned up some includes http://git.io/vEbUz
20151230 06:20:15< ancestral> At least we have em dashes and actual hyphens, and curly quotes.
20151230 06:20:45< celticminstrel> Sure.
20151230 06:20:48< vultraz> Aginor: ok done
20151230 06:21:06< ancestral> That’s more attention given than most AAA companies
20151230 06:21:46< ancestral> But yeah, it’s getting very hard to read stats on the units with the big monitors today
20151230 06:22:02< vultraz> gfgtdf: that commit dealing with floatingpoint stuff is really causing me problems. seems there's something weird about tdmgcc's32 copy of float.h and i can't fix it no matter where I replace it rom >_>
20151230 06:22:06< ancestral> (I will absolutely create a new theme to help, but this has got to be fixed first)
20151230 06:22:26 * ancestral goes back to digging through code
20151230 06:23:38< celticminstrel> If the fonts are referenced by family name rather than being directly loaded from a file, then maybe it's not searching in the correct place. (Something in fontconfig?)
20151230 06:24:00< ancestral> Hmm, I got a crash
20151230 06:24:18< celticminstrel> Or the fonts are actually missing from where they should be...
20151230 06:25:07< ancestral> I have the audio off. I wonder if it’s an audio thing.
20151230 06:25:28< ancestral> celticminstrel: Well, I seem to have the correct paths
20151230 06:25:40< ancestral> And the font is being used by some of the elemetns
20151230 06:25:42< ancestral> *elements
20151230 06:25:56< celticminstrel> Ah, it's the same font that's already used in the green areas?
20151230 06:26:10< celticminstrel> The inspect window also looks really bad BTW.
20151230 06:26:12< ancestral> I swapped out DejaVuSans with DejaVuSerif
20151230 06:26:18< ancestral> Just to make it visibly clear
20151230 06:26:22< celticminstrel> Ah.
20151230 06:26:37< ancestral> Deja Vu Sans and Helvetica, to the layman, would apear almost identical
20151230 06:26:42< ancestral> *appear
20151230 06:26:58< ancestral> However, how they are drawn effects many things, most importantly, the size and positioning
20151230 06:27:15< ancestral> celticminstrel: One sec
20151230 06:29:08< ancestral> (Also keep in mind this is like being zoomed in to 200% as it’s a retina shot)
20151230 06:29:42< celticminstrel> ^affects
20151230 06:30:02< ancestral> Yes, affects
20151230 06:30:03< ancestral> :)
20151230 06:30:13< ancestral> celticminstrel (vultraz if you’re curious): http://mproud.com/wesnoth/gameplay-fonts-original.png
20151230 06:31:14< ancestral> Basically, the buttons are in Deja Vu and the HP/XP/MP text labels are also
20151230 06:31:23< ancestral> Everything else is going to a system default
20151230 06:37:29-!- d4nf [~d4nf@ool-182ee6a9.dyn.optonline.net] has quit [Ping timeout: 255 seconds]
20151230 06:38:04-!- d4nf [~d4nf@ool-182ee6a9.dyn.optonline.net] has joined #wesnoth-dev
20151230 06:38:25< Aginor> vultraz: you need to have null-checks whenever you use display::get_singletron
20151230 06:38:32< Aginor> singleton even
20151230 06:39:36< Aginor> vultraz: I can crash your PR by going going into a campaign, exiting to title screen and then changing the resolution through preferences
20151230 06:40:06 * Aginor wonders about making Cvideo a singleton
20151230 06:41:30 * Aginor facepalms
20151230 06:42:07< Aginor> the entire undraw "pattern" that's used is completely broken if there's a resize in the meanwhile
20151230 06:42:47-!- d4nf [~d4nf@ool-182ee6a9.dyn.optonline.net] has quit [Ping timeout: 264 seconds]
20151230 06:49:20< ancestral> Okay. that was unexpected
20151230 06:49:34< ancestral> Crashes after new objective hmm
20151230 06:50:38< ancestral> Now it crashed at end of turn
20151230 06:51:02< vultraz>  Aginor shouldn't get_singleton do that itself?
20151230 06:52:01< vultraz> just a thought
20151230 06:52:40< Aginor> vultraz: and do what if it's null?
20151230 06:52:48< Aginor> have a look at the code
20151230 06:52:57< Aginor> it's broken by design
20151230 06:53:18< Aginor> dependnig on use-order you will end up setting the singleton to null
20151230 06:53:37< vultraz> oh, I see
20151230 06:53:42< celticminstrel> The CVideo is currently owned by the display subclass, right?
20151230 06:54:05< Aginor> yes
20151230 06:54:12< Aginor> I think it should be changed
20151230 06:54:36< celticminstrel> If that's changed, then the dummy display class would probably not be needed.
20151230 06:54:36< Aginor> ancestral / celticminstrel: https://wiki.libsdl.org/SDL_WindowFlags
20151230 06:54:47< Aginor> we may want to "On Apple's OS X you must set the NSHighResolutionCapable Info.plist property to YES, otherwise you will not receive a High DPI OpenGL canvas. "
20151230 06:55:36< celticminstrel> That can be done without editing the XCode project file.
20151230 06:55:46< Aginor> yes
20151230 06:55:52< vultraz> gfgtdf: by applying a small patch to my compiler's gcc float.h I managed to get it down to error: '_controlfp_s' was not declared in this scope|
20151230 06:55:56< Aginor> which is why I'm brinding it to your attention
20151230 06:56:16< celticminstrel> I'm saying anyone could do it, even without access to a Mac.
20151230 06:56:21< Aginor> ah
20151230 06:56:32< Aginor> I'm not sure what the implications are though :)
20151230 06:56:48< ancestral> Aginor: The Old Guard was adament (probably from my emphatic bug report of https://gna.org/bugs/index.php?20332) that they turn off, disable and otherwise not touch high dpi things
20151230 06:56:57< celticminstrel> Fair enough.
20151230 06:56:59< ancestral> Of course, that was SDL1 too
20151230 06:57:04< celticminstrel> The file is projectfiles/XCode/Info.plist
20151230 06:57:56< Aginor> yup
20151230 06:58:07< Aginor> I don't have access to anything with retina display to test
20151230 06:58:11< ancestral> I do
20151230 06:58:18< Aginor> but I would imagine it Should Just Work with SDL2 :)
20151230 06:58:20< celticminstrel> I don't either.
20151230 06:58:33< vultraz> gfgtdf: tdmgcc32 doesn't even seem to have that variable
20151230 06:58:39< ancestral> I will be your guinea pig if you like
20151230 06:59:11< vultraz> gfgtdf: instead it has _control87
20151230 06:59:19< vultraz> gfgtdf: should we use that?
20151230 07:00:08< vultraz> gfgtdf: there's also _controlfp
20151230 07:01:04< celticminstrel> SetWindowGrab could help with the problem where I sometimes click just outside the window after scrolling.
20151230 07:01:13< celticminstrel> On the other hand, it sounds like it'd be annoying too.
20151230 07:01:46< celticminstrel> vultraz: Which is the one it doesn't have?
20151230 07:02:00< vultraz> celticminstrel: _controlfp_s
20151230 07:02:11< celticminstrel> Eh?
20151230 07:02:30< celticminstrel> Wait, you're using MinGW, right?
20151230 07:02:43< vultraz> tdmgcc which uses mingw
20151230 07:02:53< vultraz> _controlfp_s appears to be in my tdmgcc64 install...
20151230 07:02:54< celticminstrel> Shouldn't the MinGW build use the Standard C routines rather than the MSVC routines?
20151230 07:03:04< vultraz> I don;t know
20151230 07:03:05< celticminstrel> I guess it doesn't matter that much, but...
20151230 07:03:36< vultraz> I was getting a whole lot more errors until I tried this https://gcc.gnu.org/ml/gcc-patches/2010-06/msg00387.html
20151230 07:03:45< vultraz> (only the changes to the first file)
20151230 07:04:08< celticminstrel> Where's the commit that caused this?
20151230 07:04:11< vultraz> but _controlfp_s doesn't exist at all in my tdmgcc32 installation
20151230 07:05:00< vultraz> celticminstrel: https://github.com/wesnoth/wesnoth/commit/4924082687275631477fc021c57e5d5269f40c30
20151230 07:05:05< celticminstrel> Okay.
20151230 07:05:39< celticminstrel> Okay, so...
20151230 07:06:04< celticminstrel> That #ifdef that the commit added checks for _WIN32
20151230 07:06:12< ancestral> Aginor: The titlebar is rendered more nicely. If that page says it must be turned on, it’s probably worthwhile doing it now.
20151230 07:06:13< celticminstrel> Does it work for you if you change it to check for MSVC?
20151230 07:06:22-!- Kwandulin [~Miranda@p200300760F250AA8712ED33A9A20DE58.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151230 07:06:23< celticminstrel> Lemme look up the right define quickly.
20151230 07:06:37< celticminstrel> _MSC_VER
20151230 07:06:53< celticminstrel> vultraz: ^
20151230 07:06:57< Aginor> ancestral: in the future we will probably want it, but it's not a requirement yet
20151230 07:07:23< celticminstrel> It's line 517 in that diff.
20151230 07:07:39< vultraz> celticminstrel: that drops me down to the else block
20151230 07:07:47< celticminstrel> That's the point.
20151230 07:08:06< celticminstrel> The else block should work with any version of GCC that supports C99, I think.
20151230 07:08:32< ancestral> Can anyone with a current build of master test something for me?
20151230 07:08:38< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\wesnoth.cpp|558|error: 'fegetround' was not declared in this scope|
20151230 07:08:42< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\wesnoth.cpp|559|error: 'FE_TONEAREST' was not declared in this scope|
20151230 07:08:43< vultraz> etc etc
20151230 07:08:44< ancestral> I can’t get to the second player’s turn in Aethermaw
20151230 07:08:57< celticminstrel> vultraz: #include <fenv.h> I think
20151230 07:09:05< celticminstrel> It's likely already there somewhere.
20151230 07:09:26< celticminstrel> Hmm. maybe not though.
20151230 07:09:34< vultraz> it is
20151230 07:09:39< vultraz> but only if not on windows
20151230 07:09:42 * vultraz moves it
20151230 07:09:57< celticminstrel> Move it to "if not on MSVC", basically.
20151230 07:10:12< celticminstrel> ie #ifndef _MSC_VER
20151230 07:11:09< celticminstrel> It sounds like MinGW does provide the MSVC functions, but, if the standard C way works, you might as well go with that instead.
20151230 07:11:22< vultraz> BUILDS!
20151230 07:11:26< celticminstrel> \o/
20151230 07:12:10 * Aginor swears
20151230 07:12:17< celticminstrel> ?
20151230 07:12:24< Aginor> to fix things really properly I need to fix UI1
20151230 07:12:28< Aginor> +G
20151230 07:12:36< vultraz> celticminstrel: ok, here's my local changes http://pastebin.com/6H7WVWnf
20151230 07:12:39< vultraz> should I commit this?
20151230 07:13:36< celticminstrel> vultraz: Put the <fenv.h> include inside an #ifndef _MSC_VER block
20151230 07:13:53< vultraz> yes i did
20151230 07:14:00< vultraz> check the paste again I turned on diff synhilighting
20151230 07:14:27< celticminstrel> Yeah I noticed after I said it that you did do that.
20151230 07:15:01< celticminstrel> Is the <float.h> necessary?
20151230 07:15:07< celticminstrel> I suppose it doesn't hurt.
20151230 07:15:35< celticminstrel> What's with the null changes on the std::cerr lines?
20151230 07:15:35< vultraz> not if i'm using the else block
20151230 07:15:45< vultraz> space strip
20151230 07:15:58< celticminstrel> Ah, trailing spaces.
20151230 07:16:12< celticminstrel> Well whatever. To me it seems fine to commit.
20151230 07:17:07< vultraz> ty for help
20151230 07:17:14< irker176> wesnoth: Charles Dang wesnoth:master 4eb9e09e7325 / src/wesnoth.cpp: Fixup Window compilation for 49240826872756314 http://git.io/vEb3I
20151230 07:17:25< vultraz> Windows*, bleh
20151230 07:17:27< vultraz> :P
20151230 07:17:37< celticminstrel> Should've said MinGW, not Windows. :P
20151230 07:17:59-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has quit [Read error: Connection reset by peer]
20151230 07:18:29-!- celticminstrel is now known as celmin|sleep
20151230 07:18:38< vultraz> gfgtdf ^ fixed
20151230 07:18:47-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has joined #wesnoth-dev
20151230 07:18:58 * celmin|sleep wouldn't be surprised if, on Windows, those standard C99 functions just call the other ones internally.
20151230 07:23:54< ancestral> Ugh. I need to report my never-ending freezes.
20151230 07:24:17< ancestral> Hardware, not software I mean
20151230 07:24:33< ancestral> (Sorry, irrelevant to the discussion.)
20151230 07:24:54< celmin|sleep> What discussion. >_>
20151230 07:25:11< ancestral> Heh
20151230 07:25:28< ancestral> My computer likes to freeze and shut off.
20151230 07:25:44< ancestral> Logic board has been replaced three times, so it’s not that.
20151230 07:25:59< ancestral> Fans, top case, display
20151230 07:26:14< ancestral> Basically eveyrthing except the SSD
20151230 07:26:30< ancestral> But the shutdown code suggests a power-related function
20151230 07:32:38< ancestral> There’s a chance something today broke Wesnoth for me
20151230 07:32:49< ancestral> I can’t get to the blue player in a local game
20151230 07:37:17< vultraz> Aginor: 568 working now?
20151230 07:37:52< ancestral> Can anyone get to the next player in a local multplayer game?
20151230 07:37:58< ancestral> in master?
20151230 07:39:07< vultraz> ancestral: nope
20151230 07:39:21< ancestral> Someone broke something
20151230 07:39:31< Aginor> vultraz: have you made changes?
20151230 07:40:11< ancestral> I’m building 26bdf74, we’ll see if that works
20151230 07:41:20< Aginor> vultraz: I'm still finding 2 bugs in your PR
20151230 07:41:35< Aginor> I've commented in github now instead of telling you here
20151230 07:42:01< ancestral> gfgtdf had several side-related commits today
20151230 07:42:14< ancestral> Like https://github.com/wesnoth/wesnoth/commit/4d144821594f2d85dec091796b288249d84784e4
20151230 07:43:38< ancestral> Okay, 26bdf74 wokrs
20151230 07:43:40< ancestral> *works
20151230 07:50:28-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20151230 07:53:35< vultraz> Aginor: fixed 
20151230 07:54:07< ancestral> 12b72bf works
20151230 07:57:21-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20151230 07:58:19< ancestral> Yep
20151230 07:58:37< ancestral> 4d14482 is the culprit
20151230 08:02:39< ancestral> gfgtdf: Can you revert or fix https://github.com/wesnoth/wesnoth/commit/4d144821594f2d85dec091796b288249d84784e4 for us?
20151230 08:03:20< ancestral> vultraz: BTW… isn’t it best practice for devs to work in their own branches?
20151230 08:03:50< ancestral> Just curious
20151230 08:04:32< vultraz> ancestral: I am working in my own branch
20151230 08:04:47 * ancestral nods
20151230 08:05:05< vultraz> Aginor: would you mind if I merged this into master https://github.com/Vultraz/wesnoth/commit/1eea37cfb334242ac8e54d92ce15fca89d34e966
20151230 08:05:06< ancestral> I didn’t mean you (or necessarily any one) specifically
20151230 08:06:19< vultraz> ancestral: I don't know if using forks is the "best practice" as opposed to branches of the main repo, but most of us do it
20151230 08:06:37< Aginor> vultraz: no, that looks fine... It could potentially break something in SDL1, but I don't think that's very likely
20151230 08:06:43< ancestral> branches/forks, what-have-you, right
20151230 08:07:20< vultraz> ancestral: thing about forks is we can force-push to our hearts' content :P
20151230 08:07:30< Aginor> ancestral: most of us do try to keep master sane
20151230 08:07:39< vultraz> that too ^
20151230 08:07:53< Aginor> ancestral: and using forks/branches is an important part of that
20151230 08:09:17< Aginor> hmm
20151230 08:09:47< Aginor> I'm really not sure that adding resize handling code to GUI1 is the way to go, but it needs fixing :/
20151230 08:10:22< irker176> wesnoth: Charles Dang wesnoth:master c15e2403f771 / src/ (commandline_options.cpp commandline_options.hpp game_launcher.cpp): Remove option to manually set bpp from command line http://git.io/vEbWh
20151230 08:11:11< ancestral> Well, just to be sure it doesn’t go unnoticed, I’ll submit a bug
20151230 08:11:52< zookeeper> celmin|sleep, i don't have a problem with it re-evaluating all three values on every iteration, it could allow some neat tricks. although i don't know why exactly that's the only alternative. no particular opinion on the start,end=0,0 thing.
20151230 08:14:55-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 08:19:38< Aginor> hey wedge009 
20151230 08:22:04-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 08:22:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 272 seconds]
20151230 08:22:06-!- wedge010 is now known as wedge009
20151230 08:23:36< ancestral> Alright, bug report submitted and CC-ed
20151230 08:23:42< ancestral> Time for bed
20151230 08:26:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 256 seconds]
20151230 08:28:26< ancestral> Looks like blocker #23203 was resolved long ago
20151230 08:30:51< Aginor> I wish we had tie-in between our SCM and our bug tracker on occasion :/
20151230 08:31:07< Aginor> then we could see the actual commits against the bug
20151230 08:31:10< vultraz> Yeah...
20151230 08:31:20< vultraz> Hopefully GH's bugtracker will become more featured soon
20151230 08:31:23< vultraz> Then we can switch
20151230 08:31:25-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20151230 08:32:18< Aginor> we might be able to simply get a jira instance
20151230 08:32:33< ancestral> There’s another blocker that’s probably resolved now too: #20193
20151230 08:32:34< Aginor> I think they sponsor OSS projects
20151230 08:34:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 08:37:34-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit []
20151230 08:38:02< vultraz> Aginor: ok, i'm off for a bit. last question: do you plan to merge 568 to master or merge it with one of your branches, or what. it kinda determines how I should handle 566
20151230 08:39:22< vultraz> basically I can really work on 566 anymore until I know everything 568 is fixed/done
20151230 08:42:58-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 08:56:01< Aginor> vultraz: I'd like to merge 568 with master ASAP :)
20151230 08:56:24< Aginor> I'd also like it to be free of regressions before merging though
20151230 08:56:45< Aginor> is anyone familiar with a way to redraw a gui1 dialog?
20151230 09:00:16-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20151230 09:57:47< vultraz> I don't recall seeing anything to do with redraw...
20151230 10:02:54< vultraz> Aginor: ah, I think it's set_dirty() (widgets/widget.hpp:59)
20151230 10:06:08< Aginor> mmm
20151230 10:06:22< Aginor> I've been adding generic event handling to all of GUI1
20151230 10:06:30< Aginor> to process window events
20151230 10:06:39< Aginor> and to dialogs
20151230 10:06:56< Aginor> at the moment I'm fighting with map labels redrawing on top of my dialogs
20151230 10:07:11< Aginor> then I can go and fix up the help window
20151230 10:07:28< Aginor> then I think most window handling bugs will be fixed
20151230 10:15:39< vultraz> :D
20151230 10:19:47< Aginor> it'd be neat to convert all dialogs to GUI2
20151230 10:20:01< Aginor> how much of that comes from WML at the moment?
20151230 10:21:19< vultraz> GUI2?
20151230 10:21:23< vultraz> dialog layouts
20151230 10:24:24< Aginor> constuct_dialog.cpp et al
20151230 10:24:50< Aginor> the dialogs it creates are vaguely related to GUI1, but they also do their own thing quite a bit
20151230 10:28:49< vultraz> I'm hoping to get all the remaining main game dialogs coverted to gui2 for 1.14
20151230 10:28:51< vultraz> converted*
20151230 10:29:00< vultraz> I need help creating a unit preview pane widget
20151230 10:29:02< vultraz> though
20151230 10:29:52 * Aginor nods
20151230 10:29:58< Aginor> that'd be a worthwhile endevour
20151230 10:30:02< iceiceice> vultraz: do you plan to add the missing features to gui 2 though/
20151230 10:30:23< vultraz> iceiceice: if someone helps me :P
20151230 10:30:29< iceiceice> i mean, as i understand gui2 listboxes are pretty broken
20151230 10:30:38< iceiceice> also you cannot have menu bars in gui2
20151230 10:30:48< iceiceice> because it doesn't really do "focused" dialog elements
20151230 10:30:54< iceiceice> also why you can't have modal dialogs
20151230 10:31:21< iceiceice> it might be better to try to rewrite gui2 first to fix that stuff
20151230 10:32:12< iceiceice> or back out of it and try to convert dialogs away from it
20151230 10:32:42< vultraz> if I could use a third party toolkit I would!
20151230 10:32:47< vultraz> just someone give us one!
20151230 10:33:05< vultraz> flatui looked good but you said it's not working! (plus it'd need wesnoth 2 for that so blah)
20151230 10:35:26< iceiceice> well
20151230 10:35:36< iceiceice> i wonder how  bad it is though if you convert dialogs to gui2
20151230 10:35:43< iceiceice> because its all kind of templated nicely anyways
20151230 10:36:16< iceiceice> so maybe with appropriate definitions, could make something else those gui dialog classes can derive from
20151230 10:36:24< iceiceice> without having to totally rewrite them
20151230 10:36:44 * iceiceice strokes whiskers
20151230 10:39:27-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20151230 10:40:52< Aginor> gaaaah
20151230 10:41:05< Aginor> what is causing map labels to sometimes not be drawn
20151230 10:41:13< Aginor> they are disabled when a menu comes up
20151230 10:41:24< Aginor> but I have no idea what piece of code disables them
20151230 10:44:36< vultraz> map_labels::enable()?
20151230 10:46:38< Aginor> which part of any of the gui1 handling code calls it though?
20151230 10:48:15-!- Kwandulin [~Miranda@p200300760F250AA8712ED33A9A20DE58.dip0.t-ipconnect.de] has quit [Quit: Kwandulin]
20151230 10:48:53< Aginor> no part :/
20151230 10:48:59-!- Kwandulin [~Miranda@p200300760F250AA8712ED33A9A20DE58.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151230 10:49:21< vultraz> ughh
20151230 10:49:33-!- travis-ci [~travis-ci@ec2-54-145-234-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 10:49:34< travis-ci> wesnoth/wesnoth#8049 (master - c15e240 : Charles Dang): The build was broken.
20151230 10:49:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99395887
20151230 10:49:34-!- travis-ci [~travis-ci@ec2-54-145-234-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 10:52:11< vultraz> Aginor: display::flip()?
20151230 10:52:28< vultraz> surface& frameBuffer = get_video_surface();
20151230 10:52:30< vultraz> font::draw_floating_labels(frameBuffer);
20151230 10:54:36< Aginor> those aren't map labels
20151230 10:57:26< Aginor> at least that's what I thought...
20151230 10:58:46< vultraz> I think they are
20151230 10:59:15< Aginor> it would appear so
20151230 11:09:13-!- d4nf [~d4nf@ool-182ee6a9.dyn.optonline.net] has joined #wesnoth-dev
20151230 11:10:38-!- irker176 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151230 11:13:53< Aginor> vultraz: https://gna.org/bugs/index.php?20193
20151230 11:15:43< vultraz> Aginor: I'll test 
20151230 11:22:43< Aginor> I suspect we're about to fix that too .)
20151230 11:23:06< Aginor> thanks for your help, I managed to get labels tidied up
20151230 11:26:19< vultraz> Aginor: bug doesn't happen, since we use FULLSCREEN_DESKTOP
20151230 11:27:26< Aginor> that's what I was expecting :)
20151230 11:29:09< vultraz> should I mark as fixed?
20151230 11:29:20< Aginor> that's a good question
20151230 11:29:40< Aginor> and I'd say no, not without adding it to the changelog
20151230 11:29:54< Aginor> I'll assign it to me if you don't mind
20151230 11:30:04< vultraz> Sure
20151230 11:31:25-!- Kwandulin [~Miranda@p200300760F250AA8712ED33A9A20DE58.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151230 11:31:45< Aginor> vultraz: do you feel like taking https://github.com/wesnoth/wesnoth/pull/570 out for a spin?
20151230 11:31:52< Aginor> I'd like to know how it fares in windows
20151230 11:32:02< Aginor> I also expect it to fix a number of your bugs
20151230 11:32:18< Aginor> it's not complete yet though, I still need to fix the help screen too
20151230 11:32:47< Aginor> and make it SDL1.2 compatible :)
20151230 11:34:08< vultraz> testing now
20151230 11:36:56< vultraz> we've really made a lot of progess
20151230 11:37:06< vultraz> looking at the amount of code that's changed 
20151230 11:37:09< vultraz> over these PRs
20151230 11:37:19< Aginor> yup
20151230 11:37:41< Aginor> we're even doing better that feature parity .)
20151230 11:38:13< Aginor> including fixing who knows how old bugs
20151230 11:38:25< vultraz> SDL2 is awesome 
20151230 11:39:25< Aginor> we've had a failing unit test for over a year :/
20151230 11:39:28< Aginor> https://gna.org/bugs/index.php?22855
20151230 11:40:04< vultraz> someone would have to test with GCC5
20151230 11:40:16< Aginor> it's broken
20151230 11:40:20< Aginor> I'm using GVV5
20151230 11:40:24< Aginor> GVV5 even
20151230 11:40:36< vultraz> GCC even :P
20151230 11:40:51< Aginor> yes
20151230 11:40:57< Aginor> it's clearly time for me to go to bed
20151230 11:42:27< vultraz> ok, your PR builds on top of my changes
20151230 11:42:28< vultraz> time to test
20151230 11:43:02< vultraz> prefs dialog now remains drawn...
20151230 11:43:06< vultraz> good, good
20151230 11:43:11< vultraz> bit off-center but who cares
20151230 11:43:23< vultraz> hm... 
20151230 11:43:25< Aginor> that's because the code doesn't support resize in the slightest
20151230 11:43:43< Aginor> I am not keen to re-do the layout code to support resizing :D
20151230 11:44:05< vultraz> starting game with fullscreen and toggling it off still results in a little less than optimal behavior (should go to windowed size or maximized : ( )
20151230 11:44:28< vultraz> hmmmm
20151230 11:44:35< vultraz> it also disables maximizing 
20151230 11:44:42< vultraz> the maximize button, even
20151230 11:44:49< vultraz> that might be my changes, though
20151230 11:45:00< Aginor> I think it would be
20151230 11:45:23< Aginor> I haven't introduced your changes here, so I'm not surprised those bits are still broken
20151230 11:45:25< vultraz> yes, I seem to have some problem with my state recording
20151230 11:45:41< Aginor> I'm waiting for you to fix the bugs before I'll merge the PR :D
20151230 11:46:09< vultraz> I'm waiting for 568 to be merged so I can rebase 566 over the changes :P
20151230 11:46:33< vultraz> Aginor: toggling fs from prefs in the editor results in an undrawn window
20151230 11:46:46< Aginor> yeah
20151230 11:47:08< Aginor> that's probably yet another dialog that has it's completely independant implementation from everything else
20151230 11:47:23< Aginor> I've just worried about the normal dialogs so far
20151230 11:47:47< vultraz> prefs in the editor is the same prefs dialog as anywhere 
20151230 11:47:52< Aginor> hmm
20151230 11:48:40< Aginor> completely not shown?
20151230 11:48:52< vultraz> just the bg
20151230 11:48:53< Aginor> because I "only" lose the background
20151230 11:48:58< Aginor> yup
20151230 11:49:03< Aginor> it's still flaky
20151230 11:49:52< vultraz> i'm going to retest my changes without your changes
20151230 11:50:04< Aginor> do so
20151230 11:50:19< Aginor> steps in right direction?
20151230 11:50:25< Aginor> and kind of worked in windows?
20151230 11:50:57< vultraz> what kind of worked?
20151230 11:51:17< Aginor> resizing, minimizing, et al.
20151230 11:51:37< vultraz> i need to do more testing
20151230 11:51:50< vultraz> just doing a quick test to see if I screwed something up with my code
20151230 11:53:46< Aginor> hmm
20151230 11:54:00< Aginor> so many bugs to grab
20151230 11:59:19 * vultraz wishes he had ccache
20151230 11:59:28< Aginor> it's nice :D
20151230 12:00:42< vultraz> ok, it's something in my code that was causing the problem
20151230 12:00:44< Aginor> preferences screen definitively needs a bit more TLC
20151230 12:01:26< Aginor> I've just grabbed ~10 bugs of the tracker that I think I'm about to fix
20151230 12:03:36< vultraz> ...at once? O_O
20151230 12:04:36< Aginor> yup
20151230 12:04:54< Aginor> or have fixed in these two commits
20151230 12:07:51< vultraz> woww
20151230 12:11:30< Aginor> it's easy when there's bugs that have piled up over years :D
20151230 12:11:49-!- d4nf [~d4nf@ool-182ee6a9.dyn.optonline.net] has quit [Ping timeout: 245 seconds]
20151230 12:12:29< vultraz> huh, so for some reason my code suddenly stopped working :|
20151230 12:21:53< vultraz> GEE maybe that happens when you accidentally comment out your code
20151230 12:23:43-!- Kwandulin [~Miranda@p200300760F250AA8443402CDB2AD700D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151230 12:25:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 265 seconds]
20151230 12:26:04-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 12:26:11< Aginor> maybe
20151230 12:26:21< Aginor> vultraz: background flickering is fixed
20151230 12:26:36< Aginor> I've found another annoying bug when repeatedly swiotching between tabs though
20151230 12:32:09< Aginor> and another bug fixed
20151230 12:32:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20151230 12:32:28< Aginor> tomorrow I'll tidy it up and squash commits
20151230 12:34:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 255 seconds]
20151230 12:53:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 12:54:07-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 12:54:32-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Client Quit]
20151230 12:55:14-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 13:00:20-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 13:04:47-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151230 13:23:35-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds]
20151230 13:25:59-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 13:33:11-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20151230 13:33:39-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 13:38:49< vultraz> fixed a bug
20151230 13:58:10-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 260 seconds]
20151230 13:59:23-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 246 seconds]
20151230 14:00:19-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 265 seconds]
20151230 14:34:55-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Ping timeout: 260 seconds]
20151230 14:59:39-!- celmin|sleep is now known as celticminstrel
20151230 15:02:32-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 15:03:35-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20151230 15:03:37-!- wedge010 is now known as wedge009
20151230 15:09:57-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151230 15:31:14-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20151230 15:38:34-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151230 15:44:44-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 246 seconds]
20151230 15:46:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 245 seconds]
20151230 15:51:56-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds]
20151230 15:56:04-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151230 16:03:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 16:04:13-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 16:07:35-!- Kwandulin [~Miranda@p200300760F250AA8443402CDB2AD700D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151230 16:12:44-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20151230 16:15:04-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 16:19:20-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20151230 16:21:11-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 264 seconds]
20151230 16:29:55-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 240 seconds]
20151230 16:32:52-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 16:35:44-!- fabi [~quassel@176.0.62.106] has joined #wesnoth-dev
20151230 16:35:44-!- fabi [~quassel@176.0.62.106] has quit [Changing host]
20151230 16:35:44-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20151230 16:37:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20151230 16:42:11-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20151230 16:43:28-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 16:45:19-!- Kwandulin [~Miranda@p200300760F250AA818ABD5D789C52176.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151230 16:47:41-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20151230 16:50:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20151230 16:51:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20151230 16:55:09-!- gfgtdf [~chatzilla@f054163239.adsl.alicedsl.de] has joined #wesnoth-dev
20151230 16:57:18< vultraz> ugh
20151230 16:57:23< vultraz> window flag handling is screwed up...
20151230 16:59:15< gfgtdf> vultraz: well i prefer to the the windows-only code over the gcc-only code for mingw becasue the windown-only code checks for rounding and precision while the gcc-only code only checks for rozunding mode
20151230 16:59:25-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 16:59:49< gfgtdf> vultraz: specially becasue there is a known bug on windows that can change teh precision mode and breaking lua.
20151230 17:00:10< vultraz> gfgtdf: if I did the fixup commit wrong please feel free to revert
20151230 17:00:18< vultraz> gfgtdf: but there needs to be a fix of some kind
20151230 17:00:32< gfgtdf> loonycyborg: did you also hvae the problem that vultraz had?
20151230 17:00:45< vultraz> i think he uses MSVC
20151230 17:01:00< loonycyborg> I'm using tdm-mingw
20151230 17:01:14< loonycyborg> I didn't do any builds with it recently
20151230 17:01:18< vultraz> oh
20151230 17:01:29< gfgtdf> loonycyborg: coudl you pease check if it biuld for wout without cultraz commit and see it it build for you?
20151230 17:01:32< loonycyborg> generally I work on it during releases
20151230 17:01:46< loonycyborg> is that commit in master?
20151230 17:01:58< gfgtdf> loonycyborg: yes its on master
20151230 17:02:28< gfgtdf> loonycyborg: basicall i'm asking you whther it build for you at comit https://github.com/wesnoth/wesnoth/commit/f888dc659157548f894b27a3d9e6b995ae3de7be
20151230 17:02:34< loonycyborg> I'll try cross build, using native would require rebooting to win partition
20151230 17:02:58< gfgtdf> loonycyborg: do you also cross bu8ld for ffical releases ?
20151230 17:03:05< loonycyborg> no
20151230 17:03:10< loonycyborg> I boot to winxp for them
20151230 17:03:27< gfgtdf> loonycyborg: but the jenkins do cross builds ?
20151230 17:03:33< loonycyborg> yes
20151230 17:04:07< gfgtdf> loonycyborg: ok i think crossbuil is fine
20151230 17:04:20-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20151230 17:04:23< gfgtdf> loonycyborg: ah waitz
20151230 17:04:42< gfgtdf> loonycyborg: i think you shoudl add the #include <float.h> in wesnoth.cpp before building
20151230 17:04:57< loonycyborg> got error with commit I'm at currently
20151230 17:05:07< gfgtdf> loonycyborg: i can make you a branch for taht if you want.
20151230 17:05:12< loonycyborg> void check_fpu()
20151230 17:05:16< loonycyborg> about this
20151230 17:05:30< loonycyborg> will try master
20151230 17:08:45< gfgtdf> loonycyborg: does mingw support the _FPU_GETCW function(macro ?
20151230 17:09:47-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20151230 17:13:11-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20151230 17:14:30< loonycyborg> gfgtdf: how would I check that and why did you decide to use them in the first place?
20151230 17:15:19< gfgtdf> loonycyborg: to use which?
20151230 17:15:37< loonycyborg> FPU_GETCW
20151230 17:17:52< gfgtdf> loonycyborg: ddi dintt decide to usw that yet, but i want to a check for fpu precision at runtime for our offical windows builds, and the normal way to do it on windows (_controlfp_s) is broken on mingw according to vultraz and also accoring to mutiple bugreports i saw online
20151230 17:18:24< gfgtdf> loonycyborg: and the next function i foudn that coudl do that is _FPU_GETCW, whcih seems to be agcc specific macro
20151230 17:18:25< loonycyborg> why do you need to check fpu precision?
20151230 17:18:56< loonycyborg> you could compose a test program and I could cross-build it here and run result with wine
20151230 17:20:04< loonycyborg> cross-build results in error: src/ai/composite/../lua/../../lua/luaconf.h:561:2: error: #error IEEE754 Support is required to play build wesnoth
20151230 17:20:32< gfgtdf> loonycyborg: there is a known issue that diectx (direct3d) progamms sometimes change the fpu precision, afaik we currently dont use direct3d but i still wan tto guard against that
20151230 17:20:49< gfgtdf> loonycyborg: at latest master that error ?
20151230 17:20:54< loonycyborg> I guess sdl could pull d3d in..
20151230 17:20:57< loonycyborg> yes
20151230 17:22:47< gfgtdf> loonycyborg: this means that __STRICT_ANSI__ is defined but __STDC_IEC_559__ is not, so the programms assumes that IEEE754 is not guaranteed.
20151230 17:24:01< loonycyborg> -std=c++98 implies strict ansi maybe?
20151230 17:24:11< gfgtdf> loonycyborg: y that likeley
20151230 17:25:38< gfgtdf> loonycyborg: i personalyl dont know what __STRICT_ANDI__ does specially , but if you know that you configuation supports IEEE754 you shodul edit luaconf.h and add the configuration to support it.
20151230 17:26:05< loonycyborg> that's rather risky idea
20151230 17:26:11< gfgtdf> loonycyborg: why?
20151230 17:26:17< loonycyborg> we support a lot of cpu architectures
20151230 17:26:19-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 17:26:45< gfgtdf> loonycyborg: to play mpwithout OOs you need same fup calculations on all clintzs and tht means IEEE754
20151230 17:26:47< gfgtdf> that*
20151230 17:27:19< loonycyborg> better look for another solution unless you want to get swamped by bugreports from all those debian-ppc and debian-hurd :P
20151230 17:29:20< gfgtdf> loonycyborg: they dont support IEEE754 ?
20151230 17:29:34< loonycyborg> hmm there's no reason mingw wouldn't support ieee754
20151230 17:29:55-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20151230 17:29:58-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 17:30:00< gfgtdf> the debian things i meant
20151230 17:30:16< loonycyborg> so your method is probably unreliable and might fail on less used platforms
20151230 17:30:37< loonycyborg> whitelisting approach isn't best idea thusly because there's a buttload of them
20151230 17:31:26< gfgtdf> then i shodul make just remove teh __STRICT_ANSI__check form luaconf
20151230 17:32:22-!- wedge010 is now known as wedge009
20151230 17:33:43< gfgtdf> loonycyborg: i added a boost unit test for this issue. You think that enogght guard for that
20151230 17:34:04< gfgtdf> loonycyborg: meansing do non-devs linux users also run boost units test at installation?
20151230 17:34:07< gfgtdf> meaning
20151230 17:34:35< loonycyborg> https://groups.google.com/forum/#!topic/gnu.gcc.help/P4vx6fnqDGg
20151230 17:34:42< loonycyborg> test program from here
20151230 17:34:55< loonycyborg> it reports symbol is defined with native compiler
20151230 17:34:57< loonycyborg> while
20151230 17:35:12< loonycyborg> with mingw cross-compiler it's not defined
20151230 17:35:36< loonycyborg> makes sense I guess
20151230 17:35:50< loonycyborg> since that mail says that libc is responsible for this
20151230 17:36:39< loonycyborg> and for mingw provides its own equivalent
20151230 17:37:42< loonycyborg> gfgtdf: I can test any way to check for it if you make test programs for me to compile and run
20151230 17:39:43-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 17:41:15-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20151230 17:41:16-!- wedge010 is now known as wedge009
20151230 17:44:43-!- irker911 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20151230 17:44:43< irker911> wesnoth: gfgtdf wesnoth:master 676dd75b6204 / src/lua/luaconf.h: don't check __STRICT_ANSI__ in luaconf.h http://git.io/vEApl
20151230 17:44:49< gfgtdf> loonycyborg: ^
20151230 17:45:33-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 265 seconds]
20151230 17:46:36< loonycyborg> building
20151230 17:51:04-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 17:52:10< loonycyborg> gfgtdf: I don't know how many people run unit tests on other platforms
20151230 17:52:29< loonycyborg> wouldn't be surprised if they only bothered with main build
20151230 17:53:10< gfgtdf> loonycyborg: i'd think they do whats teh default on the scons/make document.
20151230 17:53:18< gfgtdf> loonycyborg: does it also run the unittests ?
20151230 17:55:41< loonycyborg> default target doesn't include building and running test
20151230 17:56:38< loonycyborg> I can say that for example gentoo has own separate step for running unit tests for all packages
20151230 17:56:49< loonycyborg> but it's not run by default for most users
20151230 17:56:59< loonycyborg> iirc you need to enable it with FEATURE
20151230 17:57:10< loonycyborg> I expect the same is true wrt debian
20151230 17:57:39-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 245 seconds]
20151230 18:02:16-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20151230 18:08:50-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds]
20151230 18:18:52< loonycyborg> gfgtdf: this time it built without errors
20151230 18:25:30< gfgtdf> loonycyborg: ok
20151230 18:36:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20151230 18:36:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20151230 18:44:03-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 18:45:47-!- travis-ci [~travis-ci@ec2-54-92-208-68.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 18:45:48< travis-ci> wesnoth/wesnoth#8056 (master - 676dd75 : gfgtdf): The build is still failing.
20151230 18:45:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99471462
20151230 18:45:48-!- travis-ci [~travis-ci@ec2-54-92-208-68.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 18:48:40-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20151230 18:53:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20151230 18:56:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20151230 19:01:12-!- gfgtdf [~chatzilla@f054163239.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.2/20151221130713]]
20151230 19:11:37-!- travis-ci [~travis-ci@ec2-54-80-98-84.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 19:11:38< travis-ci> gfgtdf/wesnoth-old#574 (master - 09fda6a : gfgtdf): The build has errored.
20151230 19:11:38< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/99483923
20151230 19:11:38-!- travis-ci [~travis-ci@ec2-54-80-98-84.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 19:23:55-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 19:31:21< Aginor> vultraz: you broke the build yesterday when you removed bpp from the command line options
20151230 19:31:23-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds]
20151230 19:31:30< Aginor> vultraz: https://travis-ci.org/wesnoth/wesnoth/jobs/99471463
20151230 19:36:38< vultraz> ah, didn't update the tests
20151230 19:42:12< irker911> wesnoth: Charles Dang wesnoth:master b19e9f8dce4b / src/tests/test_commandline_options.cpp: Remove bpp command line option from unit tests (removed in c15e2403f771) http://git.io/vExK1
20151230 19:47:53-!- travis-ci [~travis-ci@ec2-54-92-208-68.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 19:47:54< travis-ci> gfgtdf/wesnoth-old#575 (master - dbd9a96 : gfgtdf): The build is still failing.
20151230 19:47:54< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/99484051
20151230 19:47:54-!- travis-ci [~travis-ci@ec2-54-92-208-68.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 19:53:37-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151230 19:55:58< vultraz> Aginor: testing our your PR again. dunno what you did but titlescreen resizes are now much snappier 
20151230 19:56:36< Aginor> vultraz: it's not just titlescreen, it's everywhere ;)
20151230 19:56:45< Aginor> vultraz: it's the first commit
20151230 20:01:32< vultraz> as for minimizing (https://gna.org/bugs/index.php?24212) or freezing (https://gna.org/bugs/index.php?24214), I can still reproduce them (and only the last bit of the latter), but under indeterminate circumstances
20151230 20:01:45< vultraz> ie, not the same as in the reports
20151230 20:01:48< vultraz> so, progress
20151230 20:02:01< vultraz> in 99% of cases, switching is handled fine
20151230 20:02:36< vultraz> window icon appears correctly
20151230 20:06:10< vultraz> Aginor: ok, so I can reproduce the last bit of the second one, now... but it's weird. Maximize the window, then set a resolution, set fullscreen, then alt+tab out and back :|
20151230 20:06:22< vultraz> and yes, in that order
20151230 20:06:30< vultraz> might have something to do with me...
20151230 20:06:33< vultraz> not sure :|
20151230 20:07:21< Aginor> even with my fixes?
20151230 20:07:31< vultraz> yes
20151230 20:08:21< vultraz> hm... unrelated, but it seems that animated terrain caching issue delays screen redraw events 
20151230 20:08:34< vultraz> for a few seconds while it sorts itself out
20151230 20:09:06< Aginor> I have most of the screen go black using your sequence of events, but the preferences window is still visible
20151230 20:09:11< Aginor> is that the same for you_
20151230 20:09:17-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 20:09:42< Aginor> oooh
20151230 20:09:45< vultraz> Aginor: I use the fullscreen hotkey
20151230 20:09:51< Aginor> I did just break something :)
20151230 20:10:00< Aginor> set game to fullscreen, change virtual desktop
20151230 20:10:02< Aginor> change back
20151230 20:10:19< Aginor> I think I need to trigger a full redraw on more than just resize
20151230 20:10:39< vultraz> Aginor: changing virtual desktops while wesnoth is fullscreen doesn't cause problems for me :P
20151230 20:10:58< vultraz> probably some OS handling difference, thoug
20151230 20:11:13< Aginor> yup
20151230 20:12:05< Aginor> what's the fullscreen hotkey?
20151230 20:12:49< vultraz> ctrl f
20151230 20:14:04< Aginor> ok, yup, I'll have that fixed in a few minutes
20151230 20:14:15-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20151230 20:17:27< irker911> wesnoth: gfgtdf wesnoth:master 6cf73ad76e82 / src/ (video.cpp video.hpp): move unused variables into their ifdefs http://git.io/vExQh
20151230 20:17:28< irker911> wesnoth: gfgtdf wesnoth:master ca8690876adb / src/menu_events.cpp: fix :controller command http://git.io/vExQj
20151230 20:17:31< irker911> wesnoth: gfgtdf wesnoth:master 632a663e0e16 / src/game_initialization/connect_engine.cpp: fix local mp games http://git.io/vEx7e
20151230 20:17:33< irker911> wesnoth: gfgtdf wesnoth:master b4a34b282b4f / src/ (8 files in 5 dirs): twml_exception::show only needs CVideo http://git.io/vEx7v
20151230 20:21:42-!- Ivanovic [~ivanovic@p579FB451.dip0.t-ipconnect.de] has joined #wesnoth-dev
20151230 20:22:17-!- Ivanovic [~ivanovic@p579FB451.dip0.t-ipconnect.de] has quit [Changing host]
20151230 20:22:17-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20151230 20:27:10< Aginor> vultraz: pushed yet another update
20151230 20:28:12-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 250 seconds]
20151230 20:33:15< vultraz> sadly, still seeing the issue :/
20151230 20:33:55< vultraz> hm, yes...
20151230 20:35:04< vultraz> simpler way to reproduce: alt-tabbing out and back with an opens prefs dialog toggling fullscreen 
20151230 20:35:48< Aginor> I haven't fixed that issue yet
20151230 20:36:01< vultraz> oh
20151230 20:36:05< vultraz> then what did you fix
20151230 20:36:24< Aginor> I just finished all resizing in dialogs/help screens in gui1
20151230 20:36:40< Aginor> because there's a bunch of copy-paste floating around I had to go and fix it all
20151230 20:37:00< Aginor> now I've pushed it too
20151230 20:37:22-!- travis-ci [~travis-ci@ec2-54-92-208-68.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 20:37:23< travis-ci> wesnoth/wesnoth#8057 (master - b19e9f8 : Charles Dang): The build has errored.
20151230 20:37:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99489033
20151230 20:37:23-!- travis-ci [~travis-ci@ec2-54-92-208-68.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 20:41:17< Aginor> vultraz: pushed a fix now
20151230 20:41:26< Aginor> please try again
20151230 20:41:42< Aginor> you should probably sleep too at some point :)
20151230 20:42:01< vultraz> I'm making myself stay awake to deal with this
20151230 20:42:08< vultraz> So then you can deal with cleanup while I'm away
20151230 20:43:06< Aginor> I have a bunch of social commitments today (being new years eve) that will take a bunch of my time
20151230 20:43:17< vultraz> indeed
20151230 20:43:53< vultraz> ok, nope, the gray screen still happens :(
20151230 20:44:20< Aginor> what are you exact steps?
20151230 20:45:29< vultraz> Open wesnoth -> maximize window -> open prefs and toggle fullscreen -> alt tab out *before* closing dialog -> alt tab back in, window is completely gray and weird
20151230 20:46:14< Aginor> with window fullscreened?
20151230 20:46:29< vultraz> this, BTW, is what it looks like for me on return https://www.dropbox.com/s/374xu5k0hrpj71t/Screenshot%20%289%29.png?dl=0
20151230 20:46:31< vultraz> yes
20151230 20:47:54< Aginor> that is very grey
20151230 20:48:10< Aginor> hmm
20151230 20:48:29< Aginor> the window that is created when fullscreen is on (in my branch) isn't resizable
20151230 20:49:17< vultraz> Aginor: I think that's what I fixed here https://github.com/Vultraz/wesnoth/commit/360a7b5203deea6c294389cffe9d6b1b743b0772
20151230 20:50:11-!- Kwandulin [~Miranda@p200300760F250AA818ABD5D789C52176.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20151230 20:50:23< Aginor> yup
20151230 20:51:22< Aginor> no, it's still broken in your PR
20151230 20:51:33< Aginor> oh, wait
20151230 20:51:41< Aginor> I'm checking the wrong things
20151230 20:52:25-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 20:53:26< Aginor> vultraz: I'm happy to merge PR 568 after you've resolved the conflict
20151230 20:53:36< Aginor> sorry, I should've seen that youd fixed it earlier
20151230 20:54:57-!- gfgtdf [~chatzilla@f054163239.adsl.alicedsl.de] has joined #wesnoth-dev
20151230 20:55:06< vultraz> Aginor: alright, but I'll deal with it later
20151230 20:55:19< vultraz> I'm really too exhausted to deal with sorting it out now
20151230 20:56:10< Aginor> yeah
20151230 20:56:14< Aginor> just merge it when ready
20151230 20:56:15< gfgtdf> Aginor: you shoudl defeine the RESIZE_TIMEOUT constant teh c++ way that is const in resize_timout = 100;
20151230 20:56:17-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 20:56:19< Aginor> and go to bed :)
20151230 20:56:35-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 246 seconds]
20151230 20:56:36-!- wedge010 is now known as wedge009
20151230 20:57:29< vultraz> ugh, I'm so sleepy I'm thinkign 568 is 566
20151230 20:57:32 * vultraz -> out
20151230 21:00:13< Aginor> sleep well
20151230 21:00:42< Aginor> I will now tidy up this and merge, it fixes a lot of the issues around resize
20151230 21:00:52< Aginor> (not saying all)
20151230 21:01:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20151230 21:02:58-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 21:05:32-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20151230 21:05:54-!- travis-ci [~travis-ci@ec2-54-92-208-68.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 21:05:55< travis-ci> wesnoth/wesnoth#8058 (master - b4a34b2 : gfgtdf): The build was fixed.
20151230 21:05:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99494414
20151230 21:05:55-!- travis-ci [~travis-ci@ec2-54-92-208-68.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 21:10:13-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 21:12:11-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20151230 21:12:13-!- wedge010 is now known as wedge009
20151230 21:12:13-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 21:15:01-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20151230 21:15:23-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 21:17:28-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20151230 21:19:44-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 21:19:55-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20151230 21:19:56-!- wedge010 is now known as wedge009
20151230 21:20:39-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20151230 21:31:04-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 21:32:28-!- travis-ci [~travis-ci@ec2-54-80-98-84.compute-1.amazonaws.com] has joined #wesnoth-dev
20151230 21:32:29< travis-ci> gfgtdf/wesnoth-old#576 (master - 1d84bf0 : gfgtdf): The build was fixed.
20151230 21:32:29< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/99496439
20151230 21:32:30-!- travis-ci [~travis-ci@ec2-54-80-98-84.compute-1.amazonaws.com] has left #wesnoth-dev []
20151230 21:32:39-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 245 seconds]
20151230 21:32:40-!- wedge010 is now known as wedge009
20151230 21:39:11-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20151230 21:42:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 21:43:20-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20151230 21:44:17< loonycyborg> hmm it seems there's some warning about deprecated headers from boost 1.60.
20151230 21:45:08< loonycyborg> /home/sergey/src/boost_1_60_0/boost/type_traits/detail/bool_trait_def.hpp:18:79: замечание: #pragma message: NOTE: Use of this header (bool_trait_def.hpp) is deprecated
20151230 21:46:22-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 256 seconds]
20151230 21:50:29-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20151230 21:56:20< Aginor> loonycyborg: feel like raising a bug?
20151230 21:57:20< loonycyborg> I think I'm capable of fixing it myself unless someone who cares does it before me
20151230 21:57:37< loonycyborg> I need time to compile and stuff :P
20151230 22:04:24-!- Necrosporus_ is now known as Necrosporus
20151230 22:08:39-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20151230 22:13:24< Aginor> I'd appreciate it if people can test and review https://github.com/wesnoth/wesnoth/pull/570
20151230 22:15:15-!- kidneb [kidneb@not.allthetime.xyz] has quit [Ping timeout: 240 seconds]
20151230 22:21:33-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20151230 22:24:57-!- kidneb [kidneb@not.allthetime.xyz] has joined #wesnoth-dev
20151230 22:25:47< gfgtdf> Aginor: the blackscreen on tresizr issue was also observed with gui2 (titltescreen), and the pr seems only to change gui1 code.
20151230 22:27:59< Aginor> gfgtdf: that's what the changes in event.cpp is for
20151230 22:28:43< gfgtdf> Aginor: hmm i always thought doisplay class is gui1
20151230 22:28:49< gfgtdf> display*
20151230 22:29:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 22:33:29-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 245 seconds]
20151230 22:35:11-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20151230 22:35:47< gfgtdf> Aginor: are you sure that SDL_WINDOWEVENT_EXPOSED is fired when the event is unminimized?
20151230 22:36:18-!- Roniga [~androirc@161.79.69.111.dynamic.snap.net.nz] has joined #wesnoth-dev
20151230 22:38:30< gfgtdf> Aginor: also rmemeber teh display::get_singleton doesnt work correctly
20151230 22:38:52< Roniga> Which is why there are null checks
20151230 22:39:14< Roniga> I raised the bug, if you remember 😁
20151230 22:39:26-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20151230 22:40:09< gfgtdf> Aginor: y it wont crash, but it also won'r fix teh bug get_singleton returns null
20151230 22:41:35< Roniga> Fixing the single ton isn't the intent of these changes
20151230 22:41:48< gfgtdf> Aginor: I just thought you had some 'reverse order' unicode chracter in your name, but you just spelled your name different.
20151230 22:42:46< Roniga> It's a second client
20151230 22:47:01< loonycyborg> interesting. It seems that #pragma message doesn't break strict compilation..
20151230 22:47:11< loonycyborg> with -Werror that is
20151230 22:47:44< loonycyborg> guess it makes sense
20151230 22:48:02< loonycyborg> it's message, not warning :P
20151230 22:49:23-!- kidneb [kidneb@not.allthetime.xyz] has quit [Ping timeout: 264 seconds]
20151230 22:51:27-!- kidneb [kidneb@not.allthetime.xyz] has joined #wesnoth-dev
20151230 22:55:52-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20151230 22:56:55-!- Coffee_irc [~david@121.45.0.213] has joined #wesnoth-dev
20151230 23:17:34-!- irker911 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20151230 23:22:55< loonycyborg> aww it's boost internal
20151230 23:22:59< loonycyborg> https://svn.boost.org/trac/boost/ticket/11860
20151230 23:23:06< loonycyborg> guess I can't do anything
20151230 23:24:27< celticminstrel> Aren't warnings supposed to be suppressed in system headers?
20151230 23:28:11< loonycyborg> it's a #pragma message, besides, boost-1.60 isn't system header in my builds
20151230 23:28:51< celticminstrel> Why not?
20151230 23:30:47-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151230 23:43:04< loonycyborg> because -I flags are used for it and it's in home dir
20151230 23:45:26-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20151230 23:46:00-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20151230 23:47:36< Roniga> That may be a shortcoming in the scons script
20151230 23:52:27< loonycyborg> well, CPPPATH add -I flags and changing it in truely portable way would be hard
20151230 23:52:47< loonycyborg> is there a way to mark a dir as system without explicitly including it?
20151230 23:53:36< Aginor> I don't think so, but I'm not sure
20151230 23:53:57< Aginor> 11:35 < gfgtdf> Aginor: are you sure that SDL_WINDOWEVENT_EXPOSED is fired when  the event is unminimized?
20151230 23:54:08< loonycyborg> would probably need changes in scons upstream
20151230 23:54:12< Aginor> gfgtdf: no, it's not. SDL_WINDOWEVENT_RESTORED is fired
20151230 23:54:34< gfgtdf> Aginor: hmm i dont think anymore that this is the issue this 
20151230 23:54:46< Aginor> gfgtdf: pardon?
20151230 23:55:29< gfgtdf> Aginor: i thought that might be related to the 'maximized, minmized and then back' but, but i don't think that anymore
20151230 23:56:45< Aginor> that would be bug #24212 and its ilk, which I am not entirly sure is fixed by these changes. I don't see it myself any longer, but I need independant verification.
20151230 23:57:20< loonycyborg> also, not sure if other compilers like msvc support system include paths in same way
20151230 23:58:58< gfgtdf> Aginor: i can test it if you merge it
--- Log closed Thu Dec 31 00:00:00 2015