--- Log opened Sat Jan 02 00:00:07 2016
20160102 00:00:28-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-szmrkzjrfusdrcvi] has quit [Ping timeout: 240 seconds]
20160102 00:00:29-!- ypnos [~ypnos@lme51.informatik.uni-erlangen.de] has quit [Ping timeout: 240 seconds]
20160102 00:00:38-!- EliDupree [~quassel@idupree.com] has quit [Ping timeout: 240 seconds]
20160102 00:00:53-!- EliDupree [~quassel@idupree.com] has joined #wesnoth-dev
20160102 00:02:15-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-ppifpapqujbweqih] has joined #wesnoth-dev
20160102 00:02:38-!- matthiaskrgr is now known as Guest86771
20160102 00:03:30-!- Guest86771 [matthiaskr@gateway/shell/panicbnc/x-ppifpapqujbweqih] has quit [Changing host]
20160102 00:03:30-!- Guest86771 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20160102 00:03:30-!- Guest86771 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20160102 00:03:30-!- Guest86771 [matthiaskr@gateway/shell/panicbnc/x-ppifpapqujbweqih] has joined #wesnoth-dev
20160102 00:04:22-!- Guest86771 is now known as matthiaskrgr_
20160102 00:05:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160102 00:21:05-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160102 00:41:08-!- Necrosporus_ is now known as Necrosporus
20160102 00:41:51-!- irker127 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160102 00:45:35-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160102 01:02:06-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 240 seconds]
20160102 01:04:37-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20160102 01:22:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20160102 01:39:42-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20160102 01:43:41-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160102 01:44:30-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20160102 01:44:30-!- wedge010 is now known as wedge009
20160102 01:57:31-!- ancestral [~ancestral@71.220.42.226] has joined #wesnoth-dev
20160102 02:03:55-!- gfgtdf_ [~chatzilla@f054175067.adsl.alicedsl.de] has joined #wesnoth-dev
20160102 02:05:59-!- gfgtdf [~chatzilla@f054138193.adsl.alicedsl.de] has quit [Ping timeout: 265 seconds]
20160102 02:06:05-!- gfgtdf_ is now known as gfgtdf
20160102 02:07:36< celticminstrel> I'm guessing that the failure of [message] to TC is related to an error in porting this block:
20160102 02:07:38< celticminstrel> https://github.com/wesnoth/wesnoth/commit/d4835b0157bc83880f316479abfef8101084ae42#diff-9a44dafa9a574351f5e1570159c3edb0L316
20160102 02:08:58< celticminstrel> In particular that bit in the ifndef.
20160102 02:09:51< celticminstrel> Does anyone happen to know how you'd do that in Lua?
20160102 03:00:01-!- gfgtdf_ [~chatzilla@78.54.161.51] has joined #wesnoth-dev
20160102 03:02:38-!- gfgtdf [~chatzilla@f054175067.adsl.alicedsl.de] has quit [Ping timeout: 276 seconds]
20160102 03:02:41-!- gfgtdf_ is now known as gfgtdf
20160102 03:51:06-!- gfgtdf [~chatzilla@78.54.161.51] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.2/20151221130713]]
20160102 03:52:16-!- ancestral [~ancestral@71.220.42.226] has quit [Quit: i go nstuf kthxbai]
20160102 03:54:10-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160102 03:57:53< vultraz> celticminstrel: I assume they should be in the unit table
20160102 04:00:39-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has joined #wesnoth-dev
20160102 04:25:52-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20160102 04:29:34< ancestral> Aginor, vultraz: I know you guys are actively putting work into the screen stuff. Just wanted to let you know, in the current state, I am unable to return to the app after switching out
20160102 04:29:50< ancestral> Hold that thought; I should rebuild first
20160102 04:37:36< ancestral> Yeah, still an issue
20160102 04:39:20< ancestral> It looks like it might have something to do with Spaces. I can switch back successfully if I switch the space, though I should have to if I command+tab back
20160102 04:39:37< ancestral> Hmm, I guess we’ll see how it works in the near future
20160102 04:40:03< ancestral> I should try one thing first though
20160102 04:41:06< ancestral> Doesn’t matter, okay
20160102 04:46:17< Aginor> ancestral: would you mind describing a bit closter what's broken?
20160102 04:46:29< Aginor> because the only thing that should be broken around that is using the resolution button
20160102 04:46:30< ancestral> Well, still several things
20160102 04:46:43< ancestral> Okay, ignoring the resolution button
20160102 04:46:51< ancestral> If I am in Wesnoth full screen
20160102 04:46:55< ancestral> And I command tab out
20160102 04:47:02< ancestral> And command tab in, I don’t get the app
20160102 04:47:10< ancestral> I’m “in the app” but I don’t see a window
20160102 04:47:15< Aginor> hmm
20160102 04:47:23< ancestral> If I move one space over, then I see the window, and it shoots me out
20160102 04:47:31< ancestral> If I move one space over again, then I’m in the app for good
20160102 04:47:36< Aginor> shoots you out?
20160102 04:47:50< ancestral> I think it sends me back to the Finder
20160102 04:48:00< ancestral> But I can test it again
20160102 04:48:36< ancestral> (Just dropped some changes I made; I’m rebuilding clean from master)
20160102 04:50:25< Aginor> I don't think any of Vultraz's changes will have affected that behaviour
20160102 04:50:59< Aginor> would you mind testing before and after PR 572 went in?
20160102 04:53:11< ancestral> I can do that
20160102 04:53:42< Aginor> thank you
20160102 04:56:00< ancestral> Okay, on rebuild, I don’t get that second wonky behavior
20160102 04:56:21< ancestral> Screen recording for you
20160102 04:56:28< Aginor> oooh, fancy :)
20160102 04:57:03< ancestral> Actually, I did get that wonky behavior
20160102 04:58:31-!- celticminstrel is now known as celmin|sleep
20160102 05:00:45< ancestral> Aginor: http://mproud.com/wesnoth/wesnoth-fullscreen-issues.m4v
20160102 05:00:54< ancestral> Let me know if you can’t view that video
20160102 05:00:56< ancestral> (13 MB)
20160102 05:09:22< Aginor> ancestral: thank you
20160102 05:09:59< ancestral> (I’m deleting that video later tonight)
20160102 05:10:11< Aginor> not a problem, I downloaded it
20160102 05:10:16< ancestral> Okay
20160102 05:10:21< ancestral> I can also retry before PR 572
20160102 05:10:26< Aginor> that's a rather odd problem
20160102 05:10:39< Aginor> please do, I may have inadvertedly broken something
20160102 05:11:23-!- irker876 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160102 05:11:23< irker876> wesnoth: ancestral wesnoth:ancestral_xcode_update 2d910ff86c15 / projectfiles/Xcode/Info.plist: Updated version number; set High Resolution Capable per SDL2 guidelines http://git.io/vukWz
20160102 05:11:32< ancestral> (my own branch)
20160102 05:11:33< Aginor> I will need to see if I can test this myself
20160102 05:12:49< ancestral> Did you mean 573?
20160102 05:13:07< ancestral> Vultraz/small_gui2_cleanup?
20160102 05:13:22< Aginor> no, https://github.com/wesnoth/wesnoth/pull/572
20160102 05:13:35< Aginor> that one did touch related code
20160102 05:13:51< Aginor> but it should also safely be tucked away in a _WIN32 #ifdef
20160102 05:13:55< ancestral> Ah ok
20160102 05:14:00-!- Appleman1234 [~Appleman1@KD119104015241.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20160102 05:14:15< ancestral> So I should go back to that commit, or the one just before it?
20160102 05:14:22< Aginor> just before please
20160102 05:14:29< Aginor> https://github.com/wesnoth/wesnoth/pull/572/files#diff-ad3c91867e1e1a7454bafd976a04b5e4R369
20160102 05:14:43< Aginor> that's what should be safe
20160102 05:15:14< Aginor> but I did also change the behaviour a bit in that commit while tidying it up
20160102 05:15:34< Aginor> I am wondering if the delay before it kicks you bakc out from your Space is significant
20160102 05:26:45< ancestral> Er
20160102 05:27:16< ancestral> If you’re referring to a delay in the video, that may just be me being deliberately slow
20160102 05:30:26< ancestral> Aginor: Okay, that fails too
20160102 05:30:41< ancestral> Maybe I didn’t try switching out when in fullscreen
20160102 05:30:55< Aginor> ancestral: fair enough
20160102 05:31:09< Aginor> ancestral: would you mind going a bit further back just to be safe?
20160102 05:31:18< ancestral> Sure, I can
20160102 05:31:52< ancestral> Okay hang on
20160102 05:31:56< ancestral> Hang on
20160102 05:32:18< ancestral> Nope never mind
20160102 05:32:31< Aginor> could you please try https://github.com/wesnoth/wesnoth/commit/20c93ce744f3cccf77561eccae9b29be0014d3c1
20160102 05:32:54< ancestral> Back to that one, or before it?
20160102 05:33:02< Aginor> that one specifically
20160102 05:33:06< ancestral> Okay
20160102 05:35:37 * Aginor swears
20160102 05:41:44< ancestral> Okay
20160102 05:41:48< ancestral> Checkout that commit
20160102 05:41:50< ancestral> Cleaned
20160102 05:41:51< ancestral> Built
20160102 05:41:53< ancestral> Same issue
20160102 05:42:10< ancestral> Switching to the space seems to work without the wonkiness this time
20160102 05:42:22< ancestral> In that, it doesn’t kick me back
20160102 05:42:56< ancestral> All of this is a minor-to-normal issue
20160102 05:43:58< Aginor> ancestral: I'm feeling a bit slow... so it's still broken with that commit?
20160102 05:44:10< Aginor> (which means, that particular thing probably never worked right)
20160102 05:44:19< ancestral> Yes, so I don’t know when this started happening
20160102 05:44:22< ancestral> Well
20160102 05:44:26< ancestral> Maybe it’s with SDL2
20160102 05:44:55< ancestral> Or it could be sometime else in 1.13.x
20160102 05:45:20< ancestral> That commit I just went back to
20160102 05:45:33< ancestral> Is that post SDL2 merge?
20160102 05:46:22< Aginor> no, that's from when you said everything was great :)
20160102 05:46:27< ancestral> Okay
20160102 05:46:37< Aginor> I can find you a commit from before the merge
20160102 05:46:42< ancestral> So apparently everything is great if you’re not switching between apps in fullscreen
20160102 05:46:55< ancestral> If so then I’d have to drop in SDL1 libs
20160102 05:47:00< Aginor> that's annoying
20160102 05:47:03< ancestral> Not opposed, but not terribly interested atm
20160102 05:47:15< Aginor> fair enough
20160102 05:47:16< ancestral> I’d rather try the 1.13.2 release
20160102 05:47:27< Aginor> yup, that'd be just as good
20160102 05:48:43< ancestral> Well then!
20160102 05:48:46< ancestral> That’s interesting
20160102 05:48:56< ancestral> 1.13.2 doesn’t even let me leave the app
20160102 05:49:43< ancestral> The current state is certainly an improvement
20160102 05:49:55< ancestral> (I vaguely remember this actually)
20160102 05:50:15< ancestral> Aginor: If you click on addons and click on a description of an addon
20160102 05:50:38< ancestral> There’s an arrow that links you to a website, if the author put a url in the description tag or whatever
20160102 05:50:46< ancestral> If you click on the arrow, it is supposed to take you to that website
20160102 05:51:09< ancestral> In 1.13.2 release, while in fullscreen, when I click on the arrow I am not taken out of the app
20160102 05:51:18< ancestral> However, when I quit, I see that my browser has the url loaded
20160102 05:51:34< ancestral> In master now, I am taken out of the app, so that’s good
20160102 05:51:55< ancestral> (Returning is just a bit troublesome)
20160102 05:52:15< Aginor> we can fix the returning issue :)
20160102 05:52:28< Aginor> I may need some help with testing/running an instrumented version though
20160102 05:52:42< Aginor> but right now isn't great for me
20160102 05:53:02< ancestral> No problem
20160102 05:53:06< ancestral> Thanks for your attention
20160102 05:54:40< Aginor> hmm
20160102 05:54:40< Aginor> not terrible either though
20160102 05:54:40< Aginor> I'm blocked with the consulting while I wait for answers so I can put some time into wesnoth
20160102 05:54:57< Aginor> although I'd rather finish fixing up the storyscreen right now
20160102 06:00:54< ancestral> No problem at all
20160102 06:00:55-!- travis-ci [~travis-ci@ec2-50-19-55-155.compute-1.amazonaws.com] has joined #wesnoth-dev
20160102 06:00:56< travis-ci> wesnoth/wesnoth#8089 (ancestral_xcode_update - 2d910ff : ancestral): The build failed.
20160102 06:00:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99787077
20160102 06:00:56-!- travis-ci [~travis-ci@ec2-50-19-55-155.compute-1.amazonaws.com] has left #wesnoth-dev []
20160102 06:01:36< ancestral> Do I worry about that, or not really?
20160102 06:06:28< Aginor> ancestral: it is fixed on master I think
20160102 06:06:40< Aginor> I recall gfgtdf submitting a fix
20160102 06:06:43< ancestral> Ah right, my branch
20160102 06:06:45< ancestral> I forgot
20160102 06:07:41< ancestral> (If it’s worth anything, if it were related, I tried this fullscreen testing with High Resolution Capable set to both true and false and it doesn’t seem to matter.)
20160102 06:07:58< ancestral> (With the switching in/out behavior)
20160102 06:08:08< Aginor> yup
20160102 06:08:20< Aginor> I don't think it makes any difference to whatever was going wrong
20160102 06:10:03-!- Appleman1234 [~Appleman1@KD119104006105.au-net.ne.jp] has joined #wesnoth-dev
20160102 06:11:46-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160102 06:15:51< irker876> wesnoth: ancestral wesnoth:ancestral_xcode_update 33dcd0f94752 / projectfiles/Xcode/Info.plist: Updated version number; set High Resolution Capable per SDL2 guidelines http://git.io/vuk0b
20160102 06:18:35< vultraz> ya know, I wonder why the window manager doesn't deal with these resolution/fullscreen things
20160102 06:19:40-!- Kwandulin [~Miranda@p200300760F250AE9292CEB9CE2476B1D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160102 06:21:04< Aginor> vultraz: what do you mean?
20160102 06:21:51< vultraz> you'd think the OS should be able to remember size/position/state
20160102 06:21:57< ancestral> So yeah, looks like we should be (and we are now) using SDL_WINDOW_FULLSCREEN_DESKTOP https://plus.google.com/+RyanGordon/posts/TERztq6nQ94
20160102 06:23:31< Aginor> ancestral: that's what you were arguing we stop doing yesterday :D
20160102 06:23:39< ancestral> I realize that
20160102 06:24:02< Aginor> vultraz: some do.
20160102 06:24:19< ancestral> Well now hmm
20160102 06:24:30< ancestral> Maybe I have SDL2 in my system folder
20160102 06:24:58< ancestral> Oh never mind looking at the wrong directory
20160102 06:27:09< irker876> wesnoth: ancestral wesnoth:ancestral_xcode_update f005d4deb349 / projectfiles/Xcode/Info.plist: Changing version to 1.13.3 http://git.io/vukum
20160102 06:27:52< Aginor> :)
20160102 06:28:27< Aginor> ancestral: I have no objections to your PR
20160102 06:28:51< ancestral> As I would hope ;-)
20160102 06:29:07< Aginor> ;)
20160102 06:32:28< irker876> wesnoth: ancestral wesnoth:ancestral_xcode_update 3f17b365ae7a / projectfiles/Xcode/Resources/SDLMain.nib/ (designable.nib keyedobjects.nib): Update copyright date http://git.io/vukuj
20160102 06:32:59< ancestral> Oh shoot I messed that up
20160102 06:35:28< irker876> wesnoth: ancestral wesnoth:ancestral_xcode_update 32944b21c28a / projectfiles/Xcode/Resources/SDLMain.nib/ (designable.nib keyedobjects.nib): Revert "Update copyright date" http://git.io/vukzE
20160102 06:36:13< ancestral> Man I keep messing things up
20160102 06:36:29< ancestral> note to self: never make a new branch the SAME as a previous unrelated branch
20160102 06:36:36< ancestral> BAD idea
20160102 06:40:50< irker876> wesnoth: ancestral wesnoth:ancestral_xcode_update_2 3cf38b651a21 / projectfiles/Xcode/ (English.lproj/InfoPlist.strings Info.plist): Updated version number; set High Resolution Capable per SDL2 guidelines; updated http://git.io/vukzh
20160102 06:42:51< irker876> wesnoth: ancestral wesnoth:master 3cf38b651a21 / projectfiles/Xcode/ (English.lproj/InfoPlist.strings Info.plist): Updated version number; set High Resolution Capable per SDL2 guidelines; updated http://git.io/vukzh
20160102 06:42:53< irker876> wesnoth: Martin Proud wesnoth:master d546d6961c45 / projectfiles/Xcode/ (English.lproj/InfoPlist.strings Info.plist): Merge pull request #575 from wesnoth/ancestral_xcode_update_2 http://git.io/vukgL
20160102 06:56:09-!- travis-ci [~travis-ci@ec2-54-226-189-61.compute-1.amazonaws.com] has joined #wesnoth-dev
20160102 06:56:10< travis-ci> wesnoth/wesnoth#8090 (ancestral_xcode_update - 33dcd0f : ancestral): The build has errored.
20160102 06:56:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99790172
20160102 06:56:10-!- travis-ci [~travis-ci@ec2-54-226-189-61.compute-1.amazonaws.com] has left #wesnoth-dev []
20160102 07:01:07< ancestral> Say
20160102 07:01:35< ancestral> Who is in charge of getting Wesnoth releases/packages to package managers?
20160102 07:01:49< ancestral> I mean, like Debian servers
20160102 07:01:58< ancestral> apt-get
20160102 07:02:19< ancestral> `aptitude install wesnoth wesnoth-music` wants to install 1.10
20160102 07:05:18< ancestral> I guess I need to try backports
20160102 07:06:42< ancestral> eh screw it
20160102 07:09:25-!- Kwandulin [~Miranda@p200300760F250AE9292CEB9CE2476B1D.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
20160102 07:14:29-!- Kwandulin [~Miranda@p200300760F250A9E292CEB9CE2476B1D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160102 07:22:04-!- travis-ci [~travis-ci@ec2-54-226-189-61.compute-1.amazonaws.com] has joined #wesnoth-dev
20160102 07:22:05< travis-ci> wesnoth/wesnoth#8092 (ancestral_xcode_update - f005d4d : ancestral): The build has errored.
20160102 07:22:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99790670
20160102 07:22:05-!- travis-ci [~travis-ci@ec2-54-226-189-61.compute-1.amazonaws.com] has left #wesnoth-dev []
20160102 07:49:57-!- travis-ci [~travis-ci@ec2-54-197-112-133.compute-1.amazonaws.com] has joined #wesnoth-dev
20160102 07:49:58< travis-ci> wesnoth/wesnoth#8094 (ancestral_xcode_update - 3f17b36 : ancestral): The build has errored.
20160102 07:49:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99790960
20160102 07:49:58-!- travis-ci [~travis-ci@ec2-54-197-112-133.compute-1.amazonaws.com] has left #wesnoth-dev []
20160102 08:02:52-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160102 08:18:57-!- travis-ci [~travis-ci@ec2-50-19-55-155.compute-1.amazonaws.com] has joined #wesnoth-dev
20160102 08:18:58< travis-ci> wesnoth/wesnoth#8096 (ancestral_xcode_update - 32944b2 : ancestral): The build has errored.
20160102 08:18:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99791174
20160102 08:18:58-!- travis-ci [~travis-ci@ec2-50-19-55-155.compute-1.amazonaws.com] has left #wesnoth-dev []
20160102 08:23:16< tomreyn> unless you have someone designated amongst the project who feels in charge of it, you could file a feature request / wishlist bug against the debian package, requesting an upgrade.
20160102 08:23:49< tomreyn> you could also talk to the maintainer of the current packages directly
20160102 08:25:04< tomreyn> or to Rh0nda here, maybe also to vincen7_c (misspellings on purpose to prevent - so far - unneccessary notifications on their part)
20160102 08:29:09< tomreyn> there is 1.12 in stable-backports, testing and unstable: https://packages.debian.org/search?keywords=wesnoth&exact=1
20160102 08:30:45< tomreyn> https://tracker.debian.org/pkg/wesnoth-1.12
20160102 08:35:09< vultraz> Aginor: I was looking at how Anura deals with window modes (jet/sirp's engine project behind Frogatto) https://github.com/anura-engine/anura/blob/trunk/src/kre/WindowManager.cpp
20160102 08:35:23< vultraz> a lot of it isn't useful to us, but it could serve as some useful reference
20160102 08:35:41< vultraz> since it also used SDL2
20160102 08:40:25-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160102 08:49:26-!- travis-ci [~travis-ci@ec2-54-197-112-133.compute-1.amazonaws.com] has joined #wesnoth-dev
20160102 08:49:27< travis-ci> wesnoth/wesnoth#8098 (ancestral_xcode_update_2 - 3cf38b6 : ancestral): The build has errored.
20160102 08:49:27< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99791329
20160102 08:49:27-!- travis-ci [~travis-ci@ec2-54-197-112-133.compute-1.amazonaws.com] has left #wesnoth-dev []
20160102 08:56:14< Aginor> vultraz: indeed
20160102 08:56:27< Aginor> vultraz: it would all be so much easier if we could toss out sdl 1
20160102 08:59:18< ancestral> https://wiki.libsdl.org/SDL_SetWindowDisplayMode
20160102 08:59:51< ancestral> Counterpart to SDL_SetWindowSize when in fullscreen mode
20160102 09:13:15< ancestral> Yes, it would seem this is what is needed
20160102 09:13:51< Aginor> ancestral: indeed
20160102 09:14:01< Aginor> I never said it's hard .)
20160102 09:16:43< Aginor> what I consider to be the hardest bit is probably updating the preferences window
20160102 09:19:44< Aginor> hmm
20160102 09:20:55< Aginor> I think I have the story screen resize aware and even rescaling/relayouting itself
20160102 09:39:44-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has quit [Quit: End Transmission.]
20160102 09:42:02-!- mjs-de [~mjs-de@p508C8BF3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160102 09:43:45-!- irker876 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160102 09:43:52-!- irker581 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160102 09:43:52< irker581> wesnoth: Andreas Löf wesnoth:resizestoryscreen 704564ae44e1 / src/storyscreen/ (controller.cpp render.cpp render.hpp): Make the story screen resize aware http://git.io/vuk7j
20160102 09:44:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160102 09:44:59-!- Kwandulin [~Miranda@p200300760F250A9E292CEB9CE2476B1D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160102 09:45:42< irker581> wesnoth: Andreas Löf wesnoth:resizestoryscreen 337eeb00ba0b / src/storyscreen/render.hpp: remove unused function header http://git.io/vuk5W
20160102 09:46:26< Aginor> vultraz: that sorts out the majority of the storyscreen
20160102 09:47:11< Aginor> there's still some glitchy buttons, but that one is a different kettle of fish from what I've done there
20160102 09:47:23< Aginor> https://github.com/wesnoth/wesnoth/pull/576
20160102 09:52:05< irker581> wesnoth: Andreas Löf wesnoth:master 9e356c40f41a / src/ (events.cpp preferences.cpp): Removed two printouts to stdout I inadvertently introduced http://git.io/vuk5N
20160102 09:55:31-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has joined #wesnoth-dev
20160102 10:10:09< ancestral> I think the issue is SDL_GPU
20160102 10:10:21< ancestral> I think that is what is causing font issues
20160102 10:10:51< ancestral> And it appears reasonable that it may not be needed any longer, with the conversion to SDL2
20160102 10:11:42< ancestral> Time to test out this theory
20160102 10:12:05< Aginor> ancestral: I'm still undecided on that one
20160102 10:12:26< ancestral> I read this: http://comments.gmane.org/gmane.games.wesnoth.devel/3356
20160102 10:12:36< Aginor> I haven't looked at it for a long time, but turning the game fully hardware accellerated might be annoying without it
20160102 10:15:04< ancestral> I could be wrong, too
20160102 10:19:12< Aginor> try taking out the offending code if you want, but it should all be nicely #ifdeffed away
20160102 10:26:11< ancestral> I noticed
20160102 10:33:58< vultraz> Aginor: we won't have to worry about 1.2 much longer, though, right? I think our release schedule says 1.13.3 should be around the middle of the month
20160102 10:34:16< ancestral> Wow
20160102 10:34:23< ancestral> You know
20160102 10:34:27< Aginor> that's feeling rather soon all of a sudden
20160102 10:34:32< vultraz> Indeed :P
20160102 10:34:42< ancestral> Maybe we just need to update SDL_GPU…
20160102 10:34:44< vultraz> I think 1.13.2 was Dec 11
20160102 10:34:51< vultraz> ancestral: are you using SDL gpu?
20160102 10:35:00< ancestral> Yes
20160102 10:35:14< ancestral> By default, yeah?
20160102 10:36:07< Aginor> * A new development release would be tagged every month, on the first Friday 00:00 UTC, except for betas and RCs for the next stable series, which would come every two weeks instead.
20160102 10:36:11< Aginor> umm
20160102 10:36:13< Aginor> so yeah
20160102 10:36:15< Aginor> that's pretty soon
20160102 10:36:29< Aginor> I'm not sure I'll have all of the GUIs fixed by then
20160102 10:36:39< vultraz> In fact we've already missed the first friday xD
20160102 10:36:54< vultraz> I think we should aim for the 15th, maybe
20160102 10:37:02< vultraz> since shadowm will be back
20160102 10:37:05< vultraz> (hopefully)
20160102 10:37:06< vultraz> or the 8th
20160102 10:37:12< vultraz> if we decide we dont need him
20160102 10:41:21< vultraz> Aginor: http://headerphile.com/sdl2/opengl-part-1-sdl-opengl-awesome/
20160102 10:44:21< ancestral> vultraz: Actually, hmmm
20160102 10:44:55< ancestral> I don’t see sdl_gpu in the project
20160102 10:45:00< ancestral> file
20160102 10:45:12< ancestral> nor sdl_savepng
20160102 10:46:12< Aginor> vultraz: yes.. the hard bit are all of the lightly tweaked bit map operations that need to be changed
20160102 10:46:45< Aginor> and the gui paradigms that a component takes a copy of the screen before rendering itself so it can restore that copy of the screen again (that's a terrible thing for resizing)
20160102 10:48:49< vultraz> Aginor: as far as I can't tell, don't we handle the game window as a giant blitted image rendered on screen
20160102 10:49:03< vultraz> with 'scrolling' done by just blitting it in different locations
20160102 10:49:50-!- travis-ci [~travis-ci@ec2-54-197-112-133.compute-1.amazonaws.com] has joined #wesnoth-dev
20160102 10:49:51< travis-ci> wesnoth/wesnoth#8102 (resizestoryscreen - 704564a : Andreas Löf): The build passed.
20160102 10:49:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99800849
20160102 10:49:51-!- travis-ci [~travis-ci@ec2-54-197-112-133.compute-1.amazonaws.com] has left #wesnoth-dev []
20160102 10:50:04< vultraz> as opposed to distinct layers
20160102 10:50:14< vultraz> for example, optimally, map redraws should not redraw the UI
20160102 10:50:23< Aginor> everything is blitted
20160102 10:50:46< vultraz> yeah
20160102 10:51:03< Aginor> that paradigm has to change to facilitate a traditional hw accelerated structure
20160102 10:51:04< vultraz> which makes it difficult, I think, to even consider implementing modern VFX goodies 
20160102 10:51:12< Aginor> but SDL_gpu might not require that
20160102 10:52:19< zookeeper> is there a way to enter the test scenario after you've started the game?
20160102 10:52:24< vultraz> no
20160102 10:52:28< zookeeper> okay
20160102 10:52:31< Aginor> I just load the autosave
20160102 10:52:40< ancestral>  /facepalm
20160102 10:52:42< ancestral> Well
20160102 10:52:45< ancestral> That explains a lot
20160102 10:53:13< ancestral> I don’t think sdl_gpu was ever in the Mac project file
20160102 10:57:14< ancestral> Hmm
20160102 10:57:46< ancestral> Was SDL_GPU fully implemented?
20160102 10:57:56 * ancestral is getting tons of build errors
20160102 11:00:12< Aginor> I doubt it was
20160102 11:00:12< vultraz> unlikely
20160102 11:00:18< Aginor> I haven't spent any time on it either
20160102 11:00:19< vultraz> and it's been unmaintained too
20160102 11:02:30< ancestral> Hmm
20160102 11:03:27< ancestral> Well, maybe that’s not my issue
20160102 11:06:10< zookeeper> celmin|sleep, vultraz, another bug probably in [message]: the speaking unit gets selected. so at the end of any event, the last unit to speak is selected.
20160102 11:17:45-!- Kwandulin [~Miranda@p200300760F250A9E35C8AAA78948E92C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160102 11:37:21-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has quit [Quit: End Transmission.]
20160102 11:50:00-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160102 11:50:23-!- travis-ci [~travis-ci@ec2-54-146-146-169.compute-1.amazonaws.com] has joined #wesnoth-dev
20160102 11:50:24< travis-ci> wesnoth/wesnoth#8104 (resizestoryscreen - 337eeb0 : Andreas Löf): The build passed.
20160102 11:50:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99800917
20160102 11:50:24-!- travis-ci [~travis-ci@ec2-54-146-146-169.compute-1.amazonaws.com] has left #wesnoth-dev []
20160102 11:52:46-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20160102 11:52:47-!- wedge010 is now known as wedge009
20160102 12:16:08-!- prkc [~prkc@catv-80-98-216-55.catv.broadband.hu] has quit [Remote host closed the connection]
20160102 12:16:24-!- prkc [~prkc@catv-80-98-216-55.catv.broadband.hu] has joined #wesnoth-dev
20160102 12:49:23-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160102 12:52:07-!- irker581 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160102 12:54:31-!- matthiaskrgr_ is now known as matthiaskrgr
20160102 13:00:51-!- Kwandulin [~Miranda@p200300760F250A9E35C8AAA78948E92C.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160102 13:23:36-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20160102 13:48:01-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20160102 13:48:16-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160102 14:09:41-!- Kwandulin [~Miranda@p200300760F250A9E9155C68B3F774422.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160102 14:49:17-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20160102 14:49:47-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160102 15:33:30< vultraz> Aginor: I've done some refactoring, and I think I have have sorted things out
20160102 15:33:40< vultraz> well, kinda
20160102 15:33:47< vultraz> but it's *some* progress...
20160102 15:39:21< vultraz> sadly, i've broken set_resolution again
20160102 15:39:30< vultraz> wesnoth crashes now :|
20160102 15:40:42< vultraz> segfault
20160102 15:48:23< vultraz> ok, fixed that
20160102 15:49:26-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20160102 15:49:38-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160102 16:17:50-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160102 16:21:02< vultraz> OK
20160102 16:21:21< vultraz> dammit
20160102 16:21:30< vultraz> always one thing
20160102 16:30:59< vultraz> huh
20160102 16:31:02< vultraz> can't reproduce that
20160102 16:31:15< vultraz> ok, time to cleanup
20160102 16:50:14-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20160102 16:50:57-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160102 17:07:29 * vultraz builds
20160102 17:14:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160102 17:21:03-!- mjs-de [~mjs-de@p508C8BF3.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20160102 17:31:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20160102 17:32:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160102 17:32:22< vultraz> everything seems to be working...
20160102 17:43:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20160102 17:45:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160102 17:48:12-!- apoi [~andi@91.141.1.198.wireless.dyn.drei.com] has joined #wesnoth-dev
20160102 17:48:27-!- apoi [~andi@91.141.1.198.wireless.dyn.drei.com] has quit [Client Quit]
20160102 17:51:10-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20160102 17:51:46-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160102 17:56:03-!- irker502 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160102 17:56:03< irker502> wesnoth: Charles Dang wesnoth:master d920cf9bd18b / src/sdl/ (window.cpp window.hpp): Split windowed mode setter into its own function http://git.io/vuLuI
20160102 17:56:04< irker502> wesnoth: Charles Dang wesnoth:master 3c5e6cbdb6d4 / src/ (game_launcher.cpp video.cpp video.hpp): More progress on refactoring window handling under SDL2 http://git.io/vuLuL
20160102 17:56:24< vultraz> Aginor: ^ took me all night, but I think I've squashed some of the issues and cleaned up the code in the process
20160102 17:56:29< vultraz> Aginor: do test when you can
20160102 17:56:48< vultraz> It works for me, but given the way things are going, it could break for you or something ;P
20160102 18:05:52-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20160102 18:08:19-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160102 18:10:10-!- louis94 [~~louis94@109.129.245.154] has quit [Remote host closed the connection]
20160102 18:11:02-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160102 18:18:13< celmin|sleep> zookeeper: Was that the case before I ported it to Lua?
20160102 18:18:24< celmin|sleep> Or vultraz or whoever.
20160102 18:18:36< celmin|sleep> (Last unit to speak remains selected)
20160102 18:18:36< vultraz> I'm thinking not
20160102 18:19:40-!- celmin|sleep is now known as celticminstrel
20160102 18:21:51< zookeeper> celticminstrel, i don't know, but it's a relatively new change anyway
20160102 18:23:00< zookeeper> and the message change seems like the most likely suspect
20160102 18:23:32< celticminstrel> So it definitely used to not to that.
20160102 18:24:04< irker502> wesnoth: Charles Dang wesnoth:master 64a5ae6851bd / src/ (5 files in 2 dirs): Added and deployed a default_title_string var http://git.io/vuLre
20160102 18:24:13< vultraz> Finally decided where to put that variable :P
20160102 18:31:50-!- travis-ci [~travis-ci@ec2-54-226-189-61.compute-1.amazonaws.com] has joined #wesnoth-dev
20160102 18:31:51< travis-ci> wesnoth/wesnoth#8108 (master - 3c5e6cb : Charles Dang): The build was broken.
20160102 18:31:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99847706
20160102 18:31:51-!- travis-ci [~travis-ci@ec2-54-226-189-61.compute-1.amazonaws.com] has left #wesnoth-dev []
20160102 18:33:30< vultraz> Of course, of course 
20160102 18:37:18< vultraz> ah, simple fix
20160102 18:47:56< irker502> wesnoth: Charles Dang wesnoth:master 68a725926524 / src/ (video.cpp video.hpp): Marked a variable as SDL1.2 only http://git.io/vuLi5
20160102 18:51:15< irker502> wesnoth: Charles Dang wesnoth:master 86417c2edd00 / src/preferences.cpp: Removed now-unnecessary workaround for bug #20332 http://git.io/vuLPw
20160102 18:51:27-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Read error: No route to host]
20160102 18:51:42-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160102 19:01:04-!- travis-ci [~travis-ci@ec2-54-197-112-133.compute-1.amazonaws.com] has joined #wesnoth-dev
20160102 19:01:05< travis-ci> wesnoth/wesnoth#8109 (master - 64a5ae6 : Charles Dang): The build was broken.
20160102 19:01:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99850950
20160102 19:01:05-!- travis-ci [~travis-ci@ec2-54-197-112-133.compute-1.amazonaws.com] has left #wesnoth-dev []
20160102 19:21:13< vultraz> celticminstrel: around?
20160102 19:23:15-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 240 seconds]
20160102 19:28:52-!- travis-ci [~travis-ci@ec2-54-197-112-133.compute-1.amazonaws.com] has joined #wesnoth-dev
20160102 19:28:53< travis-ci> wesnoth/wesnoth#8110 (master - 68a7259 : Charles Dang): The build was fixed.
20160102 19:28:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99853521
20160102 19:28:53-!- travis-ci [~travis-ci@ec2-54-197-112-133.compute-1.amazonaws.com] has left #wesnoth-dev []
20160102 19:29:40-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 260 seconds]
20160102 19:29:51< vultraz> celticminstrel: I was attempting to turn the 4 preferences setter functions into one using a template, but I can't figure out how to deal with this call: https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/mp_alerts_options.cpp#L77
20160102 19:30:26< vultraz> (the declaration would now be void set(const std::string &key, const T& value);)
20160102 19:52:16-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20160102 19:52:26-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160102 19:59:03-!- 14WAAKXGN [~travis-ci@ec2-54-197-112-133.compute-1.amazonaws.com] has joined #wesnoth-dev
20160102 19:59:04< 14WAAKXGN> wesnoth/wesnoth#8111 (master - 86417c2 : Charles Dang): The build was fixed.
20160102 19:59:04< 14WAAKXGN> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/99853796
20160102 19:59:04-!- 14WAAKXGN [~travis-ci@ec2-54-197-112-133.compute-1.amazonaws.com] has left #wesnoth-dev []
20160102 19:59:11< vultraz> heh
20160102 20:00:03-!- trewe [~trewe@bl20-13-238.dsl.telepac.pt] has joined #wesnoth-dev
20160102 20:00:31-!- trewe [~trewe@bl20-13-238.dsl.telepac.pt] has quit [Max SendQ exceeded]
20160102 20:01:06-!- trewe [~trewe@bl20-13-238.dsl.telepac.pt] has joined #wesnoth-dev
20160102 20:01:56-!- trewe [~trewe@bl20-13-238.dsl.telepac.pt] has quit [Max SendQ exceeded]
20160102 20:02:26-!- trewe [~trewe@bl20-13-238.dsl.telepac.pt] has joined #wesnoth-dev
20160102 20:02:59-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 1.0.1]
20160102 20:03:14-!- trewe [~trewe@bl20-13-238.dsl.telepac.pt] has quit [Max SendQ exceeded]
20160102 20:03:39-!- trewe [~trewe@bl20-13-238.dsl.telepac.pt] has joined #wesnoth-dev
20160102 20:04:25-!- trewe [~trewe@bl20-13-238.dsl.telepac.pt] has quit [Max SendQ exceeded]
20160102 20:12:52-!- trewe [~trewe@bl20-13-238.dsl.telepac.pt] has joined #wesnoth-dev
20160102 20:13:27-!- trewe [~trewe@bl20-13-238.dsl.telepac.pt] has quit [Max SendQ exceeded]
20160102 20:34:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160102 20:34:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160102 20:36:57-!- Kwandulin [~Miranda@p200300760F250A9E9155C68B3F774422.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160102 20:42:49< vultraz> celticminstrel: nvm, I'll try to get that to work again some other time. I think that line just needs bool -> const bool, either way
20160102 20:43:21-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160102 20:53:23-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Quit: Konversation terminated!]
20160102 20:54:01-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160102 21:04:20< zookeeper> urgh, i'm really not a good programmer. this somewhat-advanced lua string manipulation i'm trying to do is killing me.
20160102 21:27:15< Aginor> zookeeper: I'd offer to help but I have no idea about lua
20160102 21:31:51< Aginor> can someone try a VS build with https://github.com/wesnoth/wesnoth/pull/577
20160102 21:32:10< Aginor> I have no idea of visual studio comes with unistd.h
20160102 21:33:36< Aginor> internet says "no"
20160102 21:35:20< iceiceice> yes it should not
20160102 21:35:23< Aginor> vultraz: building to test now
20160102 21:35:24< iceiceice> unistd is a standard nix header
20160102 21:35:32< Aginor> iceiceice: exactly :)
20160102 21:35:57< Aginor> iceiceice: so adding it outside an #ifndef _WIN32 would break windows
20160102 21:36:47< iceiceice> yeah you are right
20160102 21:37:14< iceiceice> is ifndef WIN32 good enoguh or is leading _ required ?
20160102 21:37:21< iceiceice> i guess i assume he needs the underscore
20160102 21:37:24< Aginor> the leading _ is needed
20160102 21:37:54< iceiceice> i wonder if it works on os x
20160102 21:37:58< Aginor> at least according to other parts
20160102 21:38:06< iceiceice> so what is the story here, linux and os x includ unistd.h automatically?
20160102 21:38:08< iceiceice> and bsd does not?
20160102 21:38:14< Aginor> iceiceice: os x is a BSD for these intents and purposes, so it'll work
20160102 21:38:30< Aginor> could be freebsd vs openbsd or something
20160102 21:39:12< Aginor> looks like the person who did the PR contributes to openbsd ports
20160102 21:40:29< Aginor> hmm
20160102 21:40:38< Aginor> wesnoth crashes on startup for me
20160102 21:44:42< Aginor> wedge009: as I've spent more time trawling through the bug tracker lately I find you having commented on almost every bug I bring up :)
20160102 21:45:38-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20160102 21:47:12-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 256 seconds]
20160102 21:48:13-!- ancestral [~ancestral@231.sub-70-197-198.myvzw.com] has joined #wesnoth-dev
20160102 21:49:05< ancestral> Aginor: Yes, unistd.h is included in IS X
20160102 21:49:07< ancestral> OS X
20160102 21:50:01< Aginor> ancestral: thank you
20160102 21:51:41-!- irker502 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160102 21:53:23< wedge009> Aginor: Is that bad? I was intending to finish going through the bugs and helping where I can. But I go back to work on tomorrow. x.x.
20160102 21:53:34-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Read error: No route to host]
20160102 21:53:49-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160102 21:55:07< Aginor> wedge009: no, it's good :)
20160102 21:55:31< Aginor> wedge009: thank you
20160102 21:56:10< Aginor> vultraz: 64a5ae6851bd64636f671584ecd688f0c20d5278 broke wesnoth for me
20160102 21:59:42< Aginor> vultraz: http://pastebin.com/g8QgxYcn
20160102 21:59:59< Aginor> I'm somewhat inclined to revert that commit :)
20160102 22:06:53-!- ancestral [~ancestral@231.sub-70-197-198.myvzw.com] has quit [Quit: i go nstuf kthxbai]
20160102 22:07:16-!- ancestral [~ancestral@231.sub-70-197-198.myvzw.com] has joined #wesnoth-dev
20160102 22:09:18-!- ancestral [~ancestral@231.sub-70-197-198.myvzw.com] has quit [Read error: Connection reset by peer]
20160102 22:15:27< Aginor> hmm
20160102 22:15:44< Aginor> SDL 2.0.4 is about to be relesed if it hasn't
20160102 22:17:51< Aginor> https://hg.libsdl.org/SDL/rev/c9cce8633f13
20160102 22:25:40< celticminstrel> Hmm, I wonder if image_mods exists in u.__cfg.
20160102 22:25:58< celticminstrel> Might be better to add u.portrait that automatically applies TC if required.
20160102 22:26:17< celticminstrel> (ie, if there's no portrait and it needs to fall back to the sprite)
20160102 22:26:36-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160102 22:29:43< celticminstrel> zookeeper: Should TC be applied when an explicit image= key is used? Someone doing that can always use an explicit ~TC() after all.
20160102 22:29:55< celticminstrel> If I recall my IPF correctly.
20160102 22:29:56< zookeeper> it shouldn't
20160102 22:30:07< celticminstrel> 'kay
20160102 22:30:12-!- d4nf [~d4nf@ool-182ee6a9.dyn.optonline.net] has joined #wesnoth-dev
20160102 22:30:30< zookeeper> unless it's image=unit_image
20160102 22:30:47< celticminstrel> That was a thing?
20160102 22:30:52< zookeeper> oh, wait, nevermind, i think that was only a portrait thing
20160102 22:31:29< zookeeper> yeah it's a singleunit thing
20160102 22:32:05< zookeeper> dunno where exactly the logic for that was implemented
20160102 22:32:10< celticminstrel> What was the other problem that someone mentioned with [message]?
20160102 22:32:29< zookeeper> that it selects the talking unit?
20160102 22:32:36< celticminstrel> Ah, right.
20160102 22:33:27< zookeeper> anyway, it's worth testing the TC fix also with a unit that has profile=unit_image
20160102 22:33:53< celticminstrel> Looking at the code, there's currently no check for a magic value of "unit_image".
20160102 22:34:07< celticminstrel> I'll check if there was anything in the C++ version though.
20160102 22:34:34< zookeeper> well there is in unit.cpp
20160102 22:34:47< celticminstrel> Ah, if it's in unit.cpp then it should still work.
20160102 22:37:03< celticminstrel> Yeah, I see it.
20160102 22:37:09< celticminstrel> I'll test using unit_image, then.
20160102 22:38:28< celticminstrel> Actually, it doesn't look like image=unit_image would work in a [message]
20160102 22:38:56< celticminstrel> Rather it'd be [unit]profile=unit_image
20160102 22:41:01< zookeeper> yes
20160102 22:54:25-!- gfgtdf [~chatzilla@f054161051.adsl.alicedsl.de] has joined #wesnoth-dev
20160102 22:54:26-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has quit [Read error: Connection reset by peer]
20160102 22:54:34-!- Coffee_irc [~david@ppp121-45-0-213.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160102 22:58:06< celticminstrel> Oh wow.
20160102 22:58:21< celticminstrel> I found a bug in the core Lua-Wesnoth macros.
20160102 22:59:05< celticminstrel> return_string_attrib, to be specific.
20160102 23:04:53< gfgtdf> celticminstrel: a bug?
20160102 23:04:58< celticminstrel> Yup.
20160102 23:05:07< gfgtdf> celticminstrel: what exactly is wrong?
20160102 23:05:35< celticminstrel> The macro parameter "accessor" was not enclosed in parentheses when used, leading to an error if an expression was passed for that parameter.
20160102 23:07:47< celticminstrel> Hold on, it seems like TC isn't working for me even on the map. o.O
20160102 23:08:16< gfgtdf> celticminstrel: hmm not sure if i'd call that a bug
20160102 23:08:22< gfgtdf> celticminstrel: you are currently trying to fix message ?
20160102 23:08:27< celticminstrel> Yes.
20160102 23:10:08< celticminstrel> Also in Preferences -> Display -> Colors, all the orbs are pink.
20160102 23:10:26< celticminstrel> Looks like that also extends to on the map.
20160102 23:10:48< gfgtdf> celticminstrel: hmm here they arent pink
20160102 23:11:27< celticminstrel> Hmm, okay.
20160102 23:11:27< zookeeper> same here
20160102 23:14:14< celticminstrel> In case it was a problem that briefly existed and was then fixed, I'm recompiling with the latest commits.
20160102 23:14:22< gfgtdf> Aginor: i wonder whether we still need the workarouing now that SDL 2.0.4 was releasaed?
20160102 23:14:45< gfgtdf> celticminstrel: maybe you compiled with LOWMEM or something?
20160102 23:15:02< celticminstrel> If I still see the issue, I'll commit my changes and ask zookeeper to test the message fix for me.
20160102 23:15:19< celticminstrel> gfgtdf: Good point, but that shouldn't be the case. Still, I'll double-check to make sure.
20160102 23:19:44< celticminstrel> ancestral, I'm getting a warning now: 'CFBundleSignature' is 'org.wesnoth.Wesnoth', which can't be converted to a four-character code in MacRoman encoding (as needed for PkgInfo); using '????'
20160102 23:20:32 * celticminstrel is guessing that was ancestral, since he's the main OSX person who's been around recently.
20160102 23:51:34< Aginor> gfgtdf: I suspect not. Would you be happy to test?
20160102 23:52:13< gfgtdf> Aginor: y i can test, maybe even today
20160102 23:53:39-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20160102 23:53:52< Aginor> celticminstrel / zookeeper: are the two of you working on head of master? Because it's broken for me
20160102 23:54:10 * zookeeper isn't right now
20160102 23:55:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 265 seconds]
20160102 23:58:55< celticminstrel> Aginor: Broken how?
--- Log closed Sun Jan 03 00:00:38 2016