--- Log opened Sun Jan 10 00:00:57 2016
20160110 00:03:28-!- mjs-de [~mjs-de@x4db51b97.dyn.telefonica.de] has quit [Remote host closed the connection]
20160110 00:06:34< Aginor> gfgtdf: gcc
20160110 00:07:26< Aginor> gfgtdf: 5.3.1
20160110 00:11:25< gfgtdf> vultraz: do you have a profiler in your clodelocks toolchain ?
20160110 00:11:33< vultraz> ummmm
20160110 00:11:36< vultraz> idk
20160110 00:31:32-!- ancestral [~ancestral@143.sub-70-197-225.myvzw.com] has joined #wesnoth-dev
20160110 00:36:15-!- ancestral [~ancestral@143.sub-70-197-225.myvzw.com] has quit [Client Quit]
20160110 00:43:25-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Remote host closed the connection]
20160110 00:43:46-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160110 00:44:15-!- enchilado is now known as aeonchild
20160110 00:51:49-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20160110 01:39:10< celticminstrel> vultraz: Uh, I thought it was fairly self-explanatory...
20160110 01:47:39-!- gfgtdf [~chatzilla@f054175112.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.4/20160105164030]]
20160110 01:52:56-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20160110 02:00:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20160110 02:15:39< vultraz> celticminstrel: I mean details
20160110 02:15:49< vultraz> you think sprites should be in a box?
20160110 02:16:06< vultraz> the order of the labels?
20160110 02:16:43< celticminstrel> General layout.
20160110 02:16:54< celticminstrel> I don't think being in a box is that important.
20160110 02:20:40< celticminstrel> Put the information in the same order, at least.
20160110 02:26:53-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160110 02:48:36< Aginor>  hmm
20160110 02:48:53< Aginor> the minimum window size we're setting isn't actually looking very good at all in the main game gui
20160110 02:59:29< iceiceice> Aginor, until recently, wesnoth was supposed to work at 800 x 600
20160110 02:59:41< iceiceice> because historically that used to be relevant, also we officially targetted pandora
20160110 02:59:51< iceiceice> actually we might sitll be targeting 800 x 600, idk if that changed
20160110 03:00:11< iceiceice> but iiuc there's no official pandora build going forward
20160110 03:05:08< Aginor> hmm
20160110 03:05:16< Aginor> might have been me breaking something
20160110 03:05:32< Aginor> I'm currently adding dynamic layouts to display.?pp
20160110 03:05:37< Aginor> for the buttons
20160110 03:06:01< Aginor> previously it always created new ones, which breaks event handling if it happens when a dialog is open
20160110 03:13:38-!- esr [~esr@wesnoth/developer/esr] has quit [Ping timeout: 255 seconds]
20160110 03:13:58-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20160110 03:20:41-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20160110 03:26:11< Aginor> hmm
20160110 03:26:16< Aginor> extra hmm
20160110 03:26:29< Aginor> the game display slider isn't added immediately
20160110 03:26:32< Aginor> which is weird.
20160110 03:29:34-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20160110 03:33:18-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20160110 03:56:23-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Remote host closed the connection]
20160110 04:26:59-!- nemaara [~nemaara@c-98-224-226-115.hsd1.mi.comcast.net] has joined #wesnoth-dev
20160110 04:41:15-!- nemaara [~nemaara@c-98-224-226-115.hsd1.mi.comcast.net] has quit [Quit: nemaara]
20160110 05:09:12-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160110 05:13:59-!- Appleman1234 [~Appleman1@KD119104016075.au-net.ne.jp] has quit [Ping timeout: 264 seconds]
20160110 05:21:00-!- solvents [~quassel@69-196-152-213.dsl.teksavvy.com] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
20160110 06:05:57-!- irker288 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160110 06:05:57< irker288> wesnoth: Andreas Löf wesnoth:guifixes ac242376e914 / src/ (display.cpp display.hpp sdl/utils.cpp widgets/button.cpp): Add a dynamic layout functionality to the game display http://git.io/vubMl
20160110 06:06:34< Aginor> vultraz: that's step 1 towards fixing a bunch of the redraw issues
20160110 06:07:25< Aginor> next up is making a drawing-list of all elements, and making sure all GUI elements are actually on it
20160110 06:07:39< Aginor> it'd be so much easier if all GUI1 elements actually inherited from widget :)
20160110 06:10:42-!- Appleman1234 [~Appleman1@KD119104012061.au-net.ne.jp] has joined #wesnoth-dev
20160110 06:23:11-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has joined #wesnoth-dev
20160110 06:43:11-!- travis-ci [~travis-ci@ec2-54-144-63-165.compute-1.amazonaws.com] has joined #wesnoth-dev
20160110 06:43:12< travis-ci> wesnoth/wesnoth#8150 (guifixes - ac24237 : Andreas Löf): The build passed.
20160110 06:43:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/101367554
20160110 06:43:12-!- travis-ci [~travis-ci@ec2-54-144-63-165.compute-1.amazonaws.com] has left #wesnoth-dev []
20160110 06:48:54-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160110 07:17:33-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20160110 07:24:59-!- Necrosporus_ is now known as Necrosporus
20160110 07:37:15-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 240 seconds]
20160110 07:50:58-!- Kwandulin [~Miranda@p200300760F250A5E9CA8B2EA83719828.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160110 07:54:34-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160110 08:00:02-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160110 08:04:59-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 264 seconds]
20160110 08:24:22-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160110 09:16:33-!- nurupo_ [~nurupo.ga@198.46.138.44] has joined #wesnoth-dev
20160110 09:16:35-!- nurupo_ is now known as Guest68497
20160110 09:27:48-!- Guest68497 is now known as nurupo
20160110 09:27:49-!- nurupo [~nurupo.ga@198.46.138.44] has quit [Changing host]
20160110 09:27:49-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20160110 09:40:19-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo]
20160110 09:40:49-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20160110 09:53:07-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160110 10:02:42-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160110 10:07:17-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo]
20160110 10:07:47-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20160110 10:23:06-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20160110 10:28:46-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo]
20160110 10:29:16-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20160110 10:31:25-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Client Quit]
20160110 10:31:55-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20160110 10:44:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160110 10:57:34-!- irker288 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160110 11:12:32-!- mjs-de [~mjs-de@x4db51705.dyn.telefonica.de] has joined #wesnoth-dev
20160110 12:07:35-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 240 seconds]
20160110 12:16:02-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160110 12:17:35-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 264 seconds]
20160110 12:47:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160110 12:47:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20160110 13:08:26-!- Kwandulin [~Miranda@p200300760F250A5E9CA8B2EA83719828.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160110 13:22:35-!- irker175 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160110 13:22:35< irker175> wesnoth: Charles Dang wesnoth:master f716d6e99d0f / data/gui/default/window/unit_create.cfg src/gui/dialogs/unit_create.cpp: tunit_create: small tweak to icon display http://git.io/vuAkE
20160110 13:22:38< irker175> wesnoth: Charles Dang wesnoth:master 2c487ffd489b / / (3 files in 2 dirs): tunit_attack: major progress on GUI2 attack dialog http://git.io/vuAku
20160110 13:22:41< irker175> wesnoth: Charles Dang wesnoth:master fbb2f5895935 / src/mouse_events.cpp: Activate GUI2 Attack dialog and remove GUI1 one http://git.io/vuAkz
20160110 13:23:23< vultraz> zookeeper: ^ might do a few more layout tweaks but it's basically feature-complete 
20160110 13:23:36< vultraz> (still need to enable the Damage Calculations button, though)
20160110 13:23:45< vultraz> zookeeper: feedback appreciated 
20160110 13:26:31< zookeeper> can't compile, some boost breakage (apparently from the last day or so)
20160110 13:26:52< zookeeper> ..\..\src\gui\dialogs\unit_attack.cpp(273): error C2276: '&' : illegal operation on bound member function expression
20160110 13:26:53< zookeeper> ..\..\src\gui\dialogs\unit_attack.cpp(273): error C2780: 'boost::_bi::bind_t<_bi::dm_result<MT::* ,A1>::type,boost::_mfi::dm<M,T>,_bi::list_av_1<A1>::type> boost::bind(M T::* ,A1)' : expects 2 arguments - 3 provided
20160110 13:27:01< vultraz> ...weird
20160110 13:27:04< zookeeper> and then tons of similar boost stuff
20160110 13:27:20< vultraz> I wonder why
20160110 13:27:40< vultraz> since obviously it's been building fine for me :/
20160110 13:30:14< zookeeper> anyway... if it doesn't have the damage calculations button, then i take it that you know that there won't be a release before you get around to enabling it?
20160110 13:31:10< vultraz> Hopefully it will be a simple matter
20160110 13:32:43< vultraz> zookeeper: since you can't build, a screenshot https://www.dropbox.com/s/pqi31cid32smpxp/GUI2%20attack%20dialog.PNG?dl=0
20160110 13:32:57< zookeeper> well that's a "no" then. i'd be wary of the squeaky mallet which you'll surely get a dose of if you break the release by not having that button.
20160110 13:33:52< vultraz> a no to what?
20160110 13:34:08< vultraz> I'll try to enable it tonight
20160110 13:34:10< vultraz> I just need to look at the code
20160110 13:34:10< zookeeper> other than the icons i don't have any problems with the layout, looks all good to me
20160110 13:34:19< zookeeper> a no to the yes/no question i asked
20160110 13:35:37< zookeeper> the only other thing that's visually _slightly_ bothersome to me is how close the two units' stats are to each other; there's no visual separation between the two. maybe there could be a vertical line to keep them apart or something.
20160110 13:35:59< zookeeper> or the stats could be justified to the opposite sides rather than to the center
20160110 13:37:11-!- travis-ci [~travis-ci@ec2-23-22-3-96.compute-1.amazonaws.com] has joined #wesnoth-dev
20160110 13:37:12< travis-ci> wesnoth/wesnoth#8151 (master - fbb2f58 : Charles Dang): The build was broken.
20160110 13:37:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/101403118
20160110 13:37:12-!- travis-ci [~travis-ci@ec2-23-22-3-96.compute-1.amazonaws.com] has left #wesnoth-dev []
20160110 13:40:32< irker175> wesnoth: Charles Dang wesnoth:master 1c3d207ce1f7 / src/gui/dialogs/unit_attack.cpp: tunit_attack: attempt to fix compile error http://git.io/vuAqC
20160110 13:40:36< vultraz> zookeeper: can you try building again ^
20160110 13:42:24< zookeeper> yeah that fixed it
20160110 13:42:50-!- Appleman1234 [~Appleman1@KD119104012061.au-net.ne.jp] has quit [Ping timeout: 276 seconds]
20160110 13:44:04< lipkab> vultraz: Is there anything that requires unit references to be non-const in the various member functions of tunit_attack, or just laziness?
20160110 13:44:10< lipkab> (Hello, btw).
20160110 13:44:31< vultraz> lipkab: I don't think so
20160110 13:44:34< vultraz> Hello :)
20160110 13:45:11< lipkab> Then you should probably make them const ;)
20160110 13:46:29< zookeeper> vultraz, i presume you're aware of the glitching which happens when you open and close a unit profile, and when the alignment tooltips are displayed? the latter causes map labels to get drawn over the dialog, easily seen in the test scenario.
20160110 13:46:58< vultraz> zookeeper: if you mean the dialog disappearing, Aginor is working on it
20160110 13:47:26-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160110 13:48:43< zookeeper> yeah
20160110 13:52:55-!- Kwandulin [~Miranda@p200300760F250A5E64B82AB917090E0A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160110 14:09:03< vultraz> zookeeper: vertical line divider isn't possible 
20160110 14:13:26< vultraz> zookeeper: what I can do is increase the spacing
20160110 14:14:00-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20160110 14:15:05-!- travis-ci [~travis-ci@ec2-54-144-63-165.compute-1.amazonaws.com] has joined #wesnoth-dev
20160110 14:15:06< travis-ci> wesnoth/wesnoth#8152 (master - 1c3d207 : Charles Dang): The build has errored.
20160110 14:15:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/101404867
20160110 14:15:06-!- travis-ci [~travis-ci@ec2-54-144-63-165.compute-1.amazonaws.com] has left #wesnoth-dev []
20160110 14:15:22< irker175> wesnoth: Charles Dang wesnoth:master 3870c0cb8143 / src/gui/dialogs/unit_attack.cpp: tunit_attack: mark relevant function arguments as const http://git.io/vuAGM
20160110 14:15:25< irker175> wesnoth: Charles Dang wesnoth:master 478caacf492c / data/gui/default/window/unit_attack.cfg: tunit_attack: increase spacing between stat columns http://git.io/vuAGD
20160110 14:51:50-!- travis-ci [~travis-ci@ec2-23-22-3-96.compute-1.amazonaws.com] has joined #wesnoth-dev
20160110 14:51:51< travis-ci> wesnoth/wesnoth#8153 (master - 478caac : Charles Dang): The build passed.
20160110 14:51:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/101408179
20160110 14:51:51-!- travis-ci [~travis-ci@ec2-23-22-3-96.compute-1.amazonaws.com] has left #wesnoth-dev []
20160110 14:55:23-!- Appleman1234 [~Appleman1@KD119104013097.au-net.ne.jp] has joined #wesnoth-dev
20160110 14:57:27< irker175> wesnoth: Charles Dang wesnoth:master f349eb6c2439 / src/mouse_events.cpp: Added a fallback in case an attacking unit has no attacks http://git.io/vuAEo
20160110 14:57:31< irker175> wesnoth: Charles Dang wesnoth:master 40b09d3a4d4c / src/gui/dialogs/unit_attack.cpp: tunit_attack: append overlays/leader crown to unit sprites http://git.io/vuAEK
20160110 14:57:33< irker175> wesnoth: Charles Dang wesnoth:master 3641525cb65c / data/gui/default/window/unit_attack.cfg src/gui/dialogs/unit_attack.cpp: tunit_attack: minor cleanup http://git.io/vuAE6
20160110 15:07:45< irker175> wesnoth: Nils Kneuper wesnoth:1.12 a5dd10f88c60 / po/wesnoth-tutorial/sv.po: updated Swedish translation http://git.io/vuAgc
20160110 15:07:47< irker175> wesnoth: Nils Kneuper wesnoth:master 1bc83e79824d / po/ (wesnoth-editor/sv.po wesnoth-lib/sv.po wesnoth-tutorial/sv.po wesnoth/sv.po): updated Swedish translation http://git.io/vuAgC
20160110 15:30:19< vultraz> zookeeper: I really can't decide what to do with these icons :/
20160110 15:30:25< vultraz> I like having the alignment icons there
20160110 15:30:28< vultraz> but they take up space
20160110 15:48:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160110 15:53:54-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160110 16:20:57< irker175> wesnoth: Charles Dang wesnoth:master de7d29f36c2d / src/gui/dialogs/unit_attack.cpp: tunit_create: always use unit's side for finding TC http://git.io/vuAdf
20160110 16:21:00< irker175> wesnoth: Charles Dang wesnoth:master 6726c252a5c8 / data/gui/default/window/unit_attack.cfg src/gui/dialogs/unit_attack.cpp: tunit_attack: made alignment a status label instead of an icon http://git.io/vuAdJ
20160110 16:21:04< vultraz> zookeeper: ^ much as I didn't want to, it plain looks better
20160110 16:23:04-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 245 seconds]
20160110 16:23:57-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160110 17:05:49< irker175> wesnoth: Charles Dang wesnoth:master 8f8b18c87b17 / src/ (gui/dialogs/unit_attack.cpp gui/dialogs/unit_attack.hpp mouse_events.cpp): tunit_attack: enable Damage Calculation button functionality http://git.io/vuxJG
20160110 17:06:02< vultraz> zookeeper: ^ lot simpler than I expected
20160110 17:21:11-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 264 seconds]
20160110 17:25:33-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160110 17:30:23-!- Kwandulin [~Miranda@p200300760F250A5E64B82AB917090E0A.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160110 17:39:25< zookeeper> vultraz, looks very good to me now
20160110 17:39:33-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 265 seconds]
20160110 17:41:40< zookeeper> vultraz, except, it looks like only the first trait is displayed?
20160110 17:44:18-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160110 17:47:32< zookeeper> also HP and XP should rather be displayed in current/max format
20160110 17:48:33-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160110 17:49:45< zookeeper> and i'd be inclined to keep the names of the units somewhere, since sometimes (even if very rarely) it'll help confirm that you're actually using/attacking the right unit and didn't get two units of the same type mixed up
20160110 17:50:38< vultraz> the unit names are there
20160110 17:52:04< zookeeper> oh?
20160110 17:52:23< zookeeper> oh right i might have been testing with nameless units
20160110 17:52:25 * zookeeper checks again
20160110 17:53:28< zookeeper> nope, can't see them
20160110 17:54:08< vultraz> uh...
20160110 17:56:34< vultraz> they're right there at the top of the text
20160110 17:58:12< vultraz> zookeeper: are you sure you have named units?
20160110 17:58:13< zookeeper> they're not :P
20160110 17:58:16< zookeeper> yes
20160110 18:00:06< irker175> wesnoth: Charles Dang wesnoth:master ad0004899c81 / src/gui/dialogs/unit_attack.cpp: tunit_attack: fix only first trait being displayed http://git.io/vuxCv
20160110 18:00:09< irker175> wesnoth: Charles Dang wesnoth:master 8e31bebd8749 / src/gui/dialogs/unit_attack.cpp: tunit_attack: display max HP/XP as well http://git.io/vuxCf
20160110 18:00:21< vultraz> zookeeper: https://www.dropbox.com/s/ktc7btfhrmcn4b6/GUI2%20attack%20dialog2.PNG?dl=0 right there :| or are we talking about different things?
20160110 18:01:10< zookeeper> https://dl.dropboxusercontent.com/u/63964618/wesnoth/unit_attack_unit_names.png
20160110 18:01:15< zookeeper> deoran vs moreth
20160110 18:01:53< vultraz> whut
20160110 18:02:23< zookeeper> i'll pull those latest ones and recompile just in case MSVC messed up somehow
20160110 18:02:46< vultraz> It displays perfectly for me :|
20160110 18:02:48< vultraz> same units
20160110 18:04:13< zookeeper> the other issues are fixed now, but still no names
20160110 18:05:42< vultraz> I'm sorry, I have no idea
20160110 18:05:45< vultraz> nothing in stderr?
20160110 18:06:55< zookeeper> nope
20160110 18:07:18< vultraz> I have no idea
20160110 18:07:24< vultraz> we must call upon celticminstrel  to test
20160110 18:10:21 * zookeeper resists the temptation to suggest checking whether something was simply accidentally left uncommitted
20160110 18:10:57< celticminstrel> Test what?
20160110 18:11:20< vultraz> zookeeper: nope, nothing uncommitted 
20160110 18:11:36< vultraz> celticminstrel: can you take a look at the new attack dialog and see if the unit names show up at the top?
20160110 18:11:41< vultraz> used named units, of course
20160110 18:11:57< vultraz> (also feedback on design would be nice)
20160110 18:20:17< zookeeper> easily fixed
20160110 18:20:26< zookeeper> -const std::string& name
20160110 18:20:27< zookeeper> +const std::string name
20160110 18:21:36< vultraz> but why :/
20160110 18:21:41< vultraz> and why does it work for me and not you
20160110 18:22:12< celticminstrel> Let me look at the code...
20160110 18:22:35< vultraz> celticminstrel: line 105
20160110 18:23:13< zookeeper> well i guess you can't << a pointer? or rather, compilers just treat that case differently because it's unspecified or something
20160110 18:23:31< celticminstrel> No, you can << a pointer.
20160110 18:23:40< zookeeper> into a stringstream?
20160110 18:23:48< celticminstrel> Yes. The result is the address in hexadecimal, unless it's a char pointer.
20160110 18:24:03< zookeeper> well, i don't know then. yet that fixes it for me :p
20160110 18:24:19< celticminstrel> & is not a pointer though.
20160110 18:24:39< zookeeper> well, reference
20160110 18:24:52< zookeeper> (i think)
20160110 18:24:56< celticminstrel> I think it should work with &, but at the same time there's not really any reason to use the & since you're constructing a string from fragments.
20160110 18:25:27< celticminstrel> A reference behaves exactly like what it references, so you can << it all you want.
20160110 18:25:28< vultraz> ok, so I should make it not a reference?
20160110 18:25:45< celticminstrel> Sure.
20160110 18:26:56< irker175> wesnoth: Charles Dang wesnoth:master 6d48f1c805fc / src/gui/dialogs/unit_attack.cpp: tunit_attack: make name string not a reference http://git.io/vux0y
20160110 18:27:06-!- oldlaptop [~quassel@50-37-38-205.mskg.mi.frontiernet.net] has quit [Remote host closed the connection]
20160110 18:30:09< vultraz> celticminstrel: BTW, were you the one who said we should remove the display argument from gui1?
20160110 18:31:25< vultraz> I recall you mentioning it
20160110 18:32:49-!- oldlaptop [~quassel@50-37-38-205.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20160110 18:39:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160110 18:39:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160110 18:41:35-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 264 seconds]
20160110 18:45:57< zookeeper> vultraz, btw, are the strings for things such as the HP display unchanged? it seems like translations wouldn't need to be affected.
20160110 18:56:25-!- gfgtdf [~chatzilla@f054140211.adsl.alicedsl.de] has joined #wesnoth-dev
20160110 18:57:00< gfgtdf> vultraz: i wonder why you need the name variable int he first place, (instead of just writign the segoments directly to the stream)
20160110 19:06:26< gfgtdf> vultraz: is this bug now fixed https://gna.org/bugs/?11224 ?
20160110 19:12:07< celticminstrel> I don't recall mentioning it.
20160110 19:12:29< celticminstrel> gfgtdf has a good point.
20160110 19:12:43< celticminstrel> The + operator is slower than the << stream operator
20160110 19:25:53-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20160110 19:38:41-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160110 19:49:29-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160110 19:59:35-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 240 seconds]
20160110 20:04:48-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160110 20:53:25< vultraz> gfgtdf: pretty sure, yes
20160110 21:16:49-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 245 seconds]
20160110 21:26:37< irker175> wesnoth: ln-zookeeper wesnoth:master edd6ad4b92a2 / data/campaigns/Liberty/ (5 files in 2 dirs): Melee attack animation for Rogue Mage, by SkyOne http://git.io/vupLx
20160110 21:26:39< irker175> wesnoth: ln-zookeeper wesnoth:master 6bce363a443a / data/campaigns/Liberty/units/Rogue_Mage.cfg: Changed the Rogue Mage ranged animation http://git.io/vupLp
20160110 21:26:41< irker175> wesnoth: ln-zookeeper wesnoth:master 738030852463 / src/gui/dialogs/unit_attack.cpp: Merge branch 'master' of https://github.com/wesnoth/wesnoth http://git.io/vupLh
20160110 21:27:31< zookeeper> of course it's perfectly logical for git to refuse to push because someone had made a completely unrelated commit to a completely unrelated file -.-
20160110 21:28:39< zookeeper> also why can't i take a casual stroll around any unit .cfg anymore without bumping into something that's just wrong
20160110 21:28:40< zookeeper> {SOUND:HIT_AND_MISS magic-dark-big.ogg magic-dark-big-miss.ogg -50}
20160110 21:28:44< zookeeper> -50, really?
20160110 21:34:02-!- gfgtdf [~chatzilla@f054140211.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.4/20160105164030]]
20160110 21:36:24-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160110 21:47:07-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20160110 21:50:22-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 256 seconds]
20160110 21:55:55-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 240 seconds]
20160110 21:57:56< irker175> wesnoth: Charles Dang wesnoth:master 8ae305f1d419 / data/gui/default/window/unit_attack.cfg: tunit_attack: tweaked Profile button positioning http://git.io/vupsD
20160110 22:44:29-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Quit: Leaving]
20160110 22:45:41-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160110 22:47:52-!- mjs-de [~mjs-de@x4db51705.dyn.telefonica.de] has quit [Remote host closed the connection]
20160110 23:02:38-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20160110 23:08:26-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds]
20160110 23:10:33-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160110 23:16:17-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20160110 23:16:17-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20160110 23:16:17-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
--- Log closed Mon Jan 11 00:00:15 2016