--- Log opened Mon Jan 11 00:00:15 2016
20160111 00:20:13-!- SpoOkyMagician [~chatzilla@cpe-74-136-45-198.kya.res.rr.com] has joined #wesnoth-dev
20160111 00:33:40-!- Elsi_ is now known as Elsi
20160111 00:58:27-!- irker175 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160111 01:01:00-!- DDR [~david@ec2.happyspork.com] has quit [Max SendQ exceeded]
20160111 01:01:47-!- DDR [~david@ec2.happyspork.com] has joined #wesnoth-dev
20160111 01:28:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160111 01:28:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160111 01:44:48-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Read error: Connection reset by peer]
20160111 01:45:08-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160111 01:47:47-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Read error: Connection reset by peer]
20160111 01:48:09-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20160111 01:48:09-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20160111 01:48:09-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160111 02:06:17-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has joined #wesnoth-dev
20160111 03:04:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160111 03:04:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160111 03:14:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160111 03:48:07-!- SpoOkyMagician [~chatzilla@cpe-74-136-45-198.kya.res.rr.com] has quit [Quit: rage quit]
20160111 04:09:59-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20160111 04:28:41< Aginor> 'lo
20160111 05:15:58-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160111 06:01:41-!- irker073 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160111 06:01:41< irker073> wesnoth: Andreas Löf wesnoth:guifixes 5f5a334fba5b / src/ (14 files in 5 dirs): Make window events a separate handler for sdl_events http://git.io/vuh51
20160111 06:12:13-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160111 06:13:15-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20160111 06:15:25-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160111 06:31:29-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160111 06:35:31-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has joined #wesnoth-dev
20160111 06:37:40< vultraz> hey Aginor 
20160111 06:38:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160111 06:51:44-!- Necrosporus_ is now known as Necrosporus
20160111 06:52:19< vultraz> hey zookeeper, could you commit doofus's igloo variations?
20160111 06:53:34< zookeeper> yeah, i'll take a closer look at them today
20160111 07:17:05-!- mjs-de [~mjs-de@x4db51705.dyn.telefonica.de] has joined #wesnoth-dev
20160111 07:28:14< vultraz> Aginor: could you take a look at #580, see that it doesn't overlap with your work in guifixes?
20160111 07:31:14-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20160111 07:34:48< Aginor> ok
20160111 07:35:47< Aginor> vultraz: doesn't everlap
20160111 07:35:54< vultraz> ok :) 
20160111 07:35:57 * vultraz waits on travis
20160111 07:36:15< Aginor> vultraz: I'm not sure I approve of the change, although it's more from a general point of view in this particular case
20160111 07:36:59< vultraz> oh?
20160111 07:37:25< Aginor> by removing the dependency injection you're making the GUI more tightly coupled with the display class
20160111 07:37:54< vultraz> hm..
20160111 07:37:56< Aginor> the better option may be to see if you can simply pass in the screen surface, unless it relies on any other functionality in the display class
20160111 07:38:08< vultraz> getSurface()?
20160111 07:38:15< Aginor> mmm
20160111 07:38:26< Aginor> I think that's pretty much all guiX uses
20160111 07:38:58< vultraz> guix?
20160111 07:39:22< Aginor> GUI1 and GUI2 :)
20160111 07:40:01< Aginor> it's always better to not have classes tightly coupled if you can avoid it
20160111 07:40:09< Aginor> although in wesnoth's case it's pretty hard
20160111 07:40:12< vultraz> ah
20160111 07:40:26< vultraz> well my goal was to simplify the interaction
20160111 07:40:29< vultraz> not complicate it
20160111 07:40:37< vultraz> so if there's a simpler/better way I'll change it
20160111 07:40:56< Aginor> I'd see if it's possible to just pass in the surface
20160111 07:41:28< Aginor> make sure it's a reference or you'll crash wesnoth on a window event
20160111 07:46:39< Aginor> vultraz: with my branch I'm gearing up to doing simplistic display layering 
20160111 07:48:43< Aginor> I've also ensured that window events are passed to all event contexts
20160111 07:52:15-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20160111 07:55:59-!- Jetrel [~Jetrel@73.228.139.39] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20160111 07:57:05-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160111 08:40:09-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20160111 08:40:15-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Client Quit]
20160111 08:58:42-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160111 09:04:52-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Ping timeout: 250 seconds]
20160111 09:05:23-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20160111 09:08:51-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has quit [Quit: End Transmission.]
20160111 09:13:07-!- GiltheMudcrab [~Sasquash@c-24-21-217-33.hsd1.or.comcast.net] has joined #wesnoth-dev
20160111 09:14:06-!- GiltheMudcrab [~Sasquash@c-24-21-217-33.hsd1.or.comcast.net] has left #wesnoth-dev []
20160111 09:30:41< irker073> wesnoth: ln-zookeeper wesnoth:master b4fc7d92d995 / data/core/images/terrain/village/ (igloo.png igloo2.png igloo3.png igloo4.png): Updates to and new variations of igloos by doofus-01 http://git.io/vuj5r
20160111 09:30:43< irker073> wesnoth: ln-zookeeper wesnoth:master ca8a38c14795 / data/gui/default/window/unit_attack.cfg: Merge branch 'master' of https://github.com/wesnoth/wesnoth http://git.io/vuj5o
20160111 09:42:33-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20160111 09:57:18-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160111 10:00:23-!- zookeeper_ [~lmsnie@37.35.27.57] has joined #wesnoth-dev
20160111 10:00:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20160111 10:08:35-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 246 seconds]
20160111 10:14:00-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160111 10:42:36-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160111 10:48:26-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 250 seconds]
20160111 11:33:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160111 11:38:45-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20160111 11:55:48-!- zookeeper_ is now known as zookeeper
20160111 11:55:50-!- zookeeper [~lmsnie@37.35.27.57] has quit [Changing host]
20160111 11:55:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160111 13:19:22< vultraz> zookeeper: I forgot to deal with this (^Esd replacement from September) http://forums.wesnoth.org/viewtopic.php?p=589592#p589592 thoughts?
20160111 13:39:11-!- irker073 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160111 13:48:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160111 13:49:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160111 13:51:03< vultraz> Aginor: hey, I found a fix for the help dialog redrawing dialogs under it: remove the calls to redraw_everything() after the dialog closes 
20160111 13:51:18-!- Appleman1234 [~Appleman1@KD119104013097.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20160111 13:53:53< vultraz> Aginor: you added them in 422ab071912b1159e67427b36c528f99d4b299e3
20160111 13:57:13< zookeeper> vultraz, mmkay, i'll put those in too
20160111 13:59:36-!- irker478 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160111 13:59:36< irker478> wesnoth: ln-zookeeper wesnoth:master 9700d0fd5965 / data/core/images/terrain/embellishments/ (rocks.png rocks2.png rocks3.png rocks4.png rocks5.png rocks6.png rocks7.png): Improved sand drifts+stones from doofus-01 http://git.io/vzvXR
20160111 14:04:11< vultraz> ty
20160111 14:11:12-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160111 14:16:21< zookeeper> when i open the preferences, i end up in the display tab by default, not the general tab.
20160111 14:25:11< irker478> wesnoth: ln-zookeeper wesnoth:master 359fa77a3659 / data/ (25 files in 12 dirs): Unified axe sound timing to -50 http://git.io/vzvdI
20160111 14:26:08-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160111 14:33:11-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160111 14:34:56-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 255 seconds]
20160111 14:47:56-!- Appleman1234 [~Appleman1@KD119104004065.au-net.ne.jp] has joined #wesnoth-dev
20160111 14:49:10< irker478> wesnoth: ln-zookeeper wesnoth:master f15c7643b9b6 / data/ (26 files in 11 dirs): Unified sword sound timing to -100/-75 (cases of -75 left unchanged) http://git.io/vzfvM
20160111 15:07:48-!- louis94 [~~louis94@109.129.245.154] has quit [Ping timeout: 255 seconds]
20160111 15:16:44-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160111 15:59:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160111 16:01:00-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20160111 16:32:08-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160111 16:41:17-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20160111 17:01:38-!- gfgtdf [~chatzilla@x50ab97e3.dyn.telefonica.de] has joined #wesnoth-dev
20160111 17:02:08< gfgtdf> hmm i just noticed that using sdl 2.0.3 headers with sdl 2.0.4 binaries gives crashes.
20160111 17:02:59-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 246 seconds]
20160111 17:03:31< gfgtdf> i actually thought the all later sdl2.0.x rlease are able to substitue all sooner sdl 2.0.x releases.
20160111 17:08:25< vultraz> why would you use 2.0.3 headers with 2.0.4 binaries?
20160111 17:14:00< gfgtdf> vultraz: becasue just replacing the binaries is easier.
20160111 18:02:02-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160111 18:09:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160111 18:11:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160111 18:11:39-!- mjs-de [~mjs-de@x4db51705.dyn.telefonica.de] has quit [Remote host closed the connection]
20160111 18:16:14-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20160111 18:17:28< gfgtdf> vultraz: online ?
20160111 18:18:04-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20160111 18:23:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160111 18:23:57< Soliton> zookeeper: i expect the rounding issue to be a misunderstanding on how it's supposed to work. i have to work out the example he mentions in detail to be sure. the [object] stuff might just work differently though. but since there is little explanation there what [object] WML is being talked about i have no idea.
20160111 18:29:20< gfgtdf> vultraz: i added a comment to your pr
20160111 18:37:12< gfgtdf> Soliton: i think it about the effect qwml whihc usualyl uses utils::apply_modifier
20160111 18:42:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160111 18:54:38-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20160111 19:05:16-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20160111 19:05:33-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160111 19:06:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160111 19:07:54-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160111 19:10:59-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 245 seconds]
20160111 19:20:45-!- louis94 [~~louis94@109.129.245.154] has joined #wesnoth-dev
20160111 19:25:18-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20160111 19:33:57-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has joined #wesnoth-dev
20160111 19:52:22-!- louis94 [~~louis94@109.129.245.154] has quit [Quit: Konversation terminated!]
20160111 20:09:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160111 20:09:45< zookeeper> Soliton, gfgtdf, right, i see.
20160111 20:10:04< gfgtdf> zookeeper: i added a comment in that topic
20160111 20:10:14< zookeeper> i noticed
20160111 20:13:54< Soliton> gfgtdf: sounds like the comment for the div100rounded() function should be updated as well.
20160111 20:14:22< gfgtdf> Soliton: or the commit reverted.
20160111 20:14:40< gfgtdf> Soliton: idk what better
20160111 20:15:28< Soliton> would have to look at what kind of bug it fixed.
20160111 20:30:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160111 20:33:05-!- ancestral [~ancestral@209.181.254.220] has joined #wesnoth-dev
20160111 20:34:49-!- irker478 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160111 20:40:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160111 20:53:24-!- ancestral [~ancestral@209.181.254.220] has quit [Quit: i go nstuf kthxbai]
20160111 20:59:53-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20160111 21:10:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160111 21:12:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160111 21:29:19-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Read error: Connection reset by peer]
20160111 21:39:12-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20160111 21:39:12-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20160111 21:39:12-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160111 21:45:19-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20160111 21:47:17-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20160111 21:47:36-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160111 21:50:16-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 256 seconds]
20160111 21:53:16-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Ping timeout: 272 seconds]
20160111 21:57:50-!- Necrosporus_ is now known as Necrosporus
20160111 21:58:58-!- sfan786 [~sfan786@c-24-131-93-63.hsd1.pa.comcast.net] has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
20160111 22:02:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160111 22:02:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160111 22:05:24-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20160111 22:08:39< vultraz> gfgtdf: I think you're right, disp_.invalidate_all() might not be needed
20160111 22:10:31< vultraz> removing it doesn't seem to break anything
20160111 22:11:21< vultraz> likewise for disp_.flip() -> disp_.video().flip()
20160111 22:12:28< celticminstrel> Making CVideo a singleton is relatively easy.
20160111 22:12:48< gfgtdf> celticminstrel: im currently wokring on making cvidoe a singelton
20160111 22:13:03< celticminstrel> I did it a little while ago but didn't commit.
20160111 22:13:12< gfgtdf> celticminstrel: y same for me :)
20160111 22:13:15< celticminstrel> I had other stuff in that which didn't work though.
20160111 22:13:23< gfgtdf> celticminstrel: didnt want merging conflicts with agnor
20160111 22:13:47< celticminstrel> I stored a weak_ptr to the CVideo as a static member of the CVideo class.
20160111 22:14:04< celticminstrel> Then the static member that returns the singleton constructs it if it doesn't already exist.
20160111 22:14:09< vultraz> gfgtdf: BTW if I read your comment right, you're saying GUI1 should keep the display argument, just change it to CVideo?
20160111 22:14:11< gfgtdf> celticminstrel: i justd CVideo* :p
20160111 22:14:22< celticminstrel> Sounds dangerous. :P
20160111 22:14:34< gfgtdf> vultraz: yes that was my plan
20160111 22:14:37< gfgtdf> vultraz: but
20160111 22:15:03< gfgtdf> vultraz: to remove teh gme_dinspla memeber form game_lauher ywe also need to change the hotkey code
20160111 22:15:13< gfgtdf> game_launcher
20160111 22:15:16< vultraz> o_o
20160111 22:17:07< vultraz> hm
20160111 22:17:52< vultraz> ok so display.flip() calls CVideo'.flip()
20160111 22:18:12< vultraz> also undraws map labels for some reason
20160111 22:19:15< gfgtdf> vultraz: my thought was that gui2 also just calls video.flip afaik. So why shouldnt wokr work for gui1 too
20160111 22:19:30< vultraz> yeah it doesn't seem to change anything
20160111 22:30:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160111 22:30:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160111 22:31:04 * vultraz uncouples delay() from display
20160111 22:35:23-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160111 22:35:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: No route to host]
20160111 22:36:56< vultraz> gfgtdf: delay() should be static?
20160111 22:36:58-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has left #wesnoth-dev ["Ciao!"]
20160111 22:38:28-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160111 22:42:56-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 265 seconds]
20160111 22:48:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20160111 23:01:25-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Quit: Leaving]
20160111 23:08:07< gfgtdf> vultraz: well that was if it stays a member of display class
20160111 23:08:28< vultraz> gfgtdf: I was moving it to CVideo
20160111 23:08:32< vultraz> as a static function 
20160111 23:18:47-!- irker788 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160111 23:18:47< irker788> wesnoth: gfgtdf wesnoth:master 8f4937a47f9c / src/gui/dialogs/lua_interpreter.cpp: add a comment http://git.io/vzIGR
20160111 23:18:47< irker788> wesnoth: gfgtdf wesnoth:master d911991ad0b1 / data/campaigns/Legend_of_Wesmere/ (scenarios/chapter4/14_Human_Alliance.cfg utils/characters.cfg): some LoW cleanups http://git.io/vzIGE
20160111 23:18:48< irker788> wesnoth: gfgtdf wesnoth:master d3ff8d5855c8 / src/video.cpp: move unused codes in #if http://git.io/vzIGu
20160111 23:18:49< irker788> wesnoth: gfgtdf wesnoth:master a25de0d60cb8 / src/video.cpp: move unused codes in #if http://git.io/vzIGz
20160111 23:18:50< irker788> wesnoth: gfgtdf wesnoth:master 195caa07149e / src/video.cpp: moved unused code in #if http://git.io/vzIGg
20160111 23:18:52< irker788> wesnoth: gfgtdf wesnoth:master 9d6f15496023 / src/video.cpp: remove SDL 2.0.3 workaround http://git.io/vzIG2
20160111 23:18:54< irker788> wesnoth: gfgtdf wesnoth:master 93091519bd3d / src/ (13 files in 5 dirs): make CVideo a singleton http://git.io/vzIGa
20160111 23:20:51< vultraz> hmmm
20160111 23:20:53< gfgtdf> celticminstrel: i oushed the CVideo to singleton patch
20160111 23:21:42< vultraz> whoops
20160111 23:21:48< vultraz> I accidentally closed my PR
20160111 23:21:58< gfgtdf> Aginor: i also tested the the 2.0.3 windows workaround is indeed not neede on sdl 2.0.4 anymore, so i remved it
20160111 23:22:07< gfgtdf> Aginor: to keep the code simpler
20160111 23:22:42< gfgtdf> vultraz: maybe it automatically closes itself when it has no commits ?
20160111 23:22:46< vultraz> yeah
20160111 23:22:52< vultraz> idk how i screwed that up
20160111 23:22:54< vultraz> will fix..
20160111 23:24:40< vultraz> fixed
20160111 23:24:54< vultraz> gfgtdf: ok so should the static cvideo functions not be static anymore?
20160111 23:25:19< gfgtdf> vultraz: delay can still be static since it doesnt use any members of cvideo
20160111 23:25:26< vultraz> ok
20160111 23:25:29< vultraz> thanks
20160111 23:42:47< gfgtdf> vultraz, celticminstrel: do you know what this line does: https://github.com/wesnoth/wesnoth/blob/1.12/src/multiplayer_ui.hpp#L209
20160111 23:43:05< gfgtdf> vultraz, celticminstrel : afaik hoteys doent wokr in mp lobby at all or am i wrong?
20160111 23:44:07< vultraz> they don't appear to
20160111 23:44:17< celticminstrel> Uh. That line is pretty self-explanatory?
20160111 23:44:36< celticminstrel> I don't recall whether hotkeys work in lobby.
20160111 23:44:50< gfgtdf> celticminstrel: well but fact is that even whotkeys like 'mute' doesnt work in the lobby
20160111 23:46:17< celticminstrel> Is the hotkey handler an event handler? If it isn't, then an event handler somewhere needs to pass relevant events along to it.
20160111 23:47:01< gfgtdf> celticminstrel: yes it is an sdl_Event handler
20160111 23:47:10< gfgtdf> sdl_handler
20160111 23:49:22< celticminstrel> And it registers itself in the constructor?
20160111 23:49:57< celticminstrel> I dunno why it'd fail to receive events then...
20160111 23:53:55< gfgtdf> vultraz: do you know why sou call get_singleton() here https://github.com/wesnoth/wesnoth/commit/4ab959f4cd30f292c6b627c8219a4fbb0ef89f4e ?
20160111 23:54:10< gfgtdf> vultraz: i mean is ois already a display object
20160111 23:54:13< gfgtdf> display*
20160111 23:54:33< vultraz> hm
20160111 23:54:35< vultraz> I forgot
20160111 23:54:44< vultraz> I think using disp didn't work or something?
20160111 23:54:51< gfgtdf> vultraz: or rather in the commit which introduces this strange behviour https://github.com/wesnoth/wesnoth/commit/698f3ea467793e1aa85207e6fa5bca92a2c3a05f
20160111 23:55:20< vultraz> gfgtdf: can you test it without get_singleton? 
20160111 23:55:28< vultraz> I think it wasn't affecting window so I used it
20160111 23:55:32< vultraz> but I might be wrong
20160111 23:56:40< gfgtdf> vultraz: well, therre is only 1 Cvideo class
20160111 23:56:56< gfgtdf> vultraz: so its impossible that this codepatch calls the function ona  differetn CVideo instance
20160111 23:57:17< vultraz> ok then disp.video() should work fine
--- Log closed Tue Jan 12 00:00:16 2016