--- Log opened Wed Jan 13 00:00:38 2016
20160113 00:02:29-!- travis-ci [~travis-ci@ec2-54-144-1-53.compute-1.amazonaws.com] has joined #wesnoth-dev
20160113 00:02:30< travis-ci> wesnoth/wesnoth#8187 (master - 8c63aff : gfgtdf): The build is still failing.
20160113 00:02:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/101982324
20160113 00:02:30-!- travis-ci [~travis-ci@ec2-54-144-1-53.compute-1.amazonaws.com] has left #wesnoth-dev []
20160113 00:05:31-!- mjs-de [~mjs-de@x4db5177a.dyn.telefonica.de] has quit [Remote host closed the connection]
20160113 00:06:56< gfgtdf> hmm for some readon travis doesnt liek this line https://github.com/wesnoth/wesnoth/blob/master/src/hotkey/command_executor.hpp#L118 but i dotn know why
20160113 00:09:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160113 00:11:00 * celticminstrel decides to update all my old branches.
20160113 00:13:15< irker325> wesnoth: gfgtdf wesnoth:master 25f60358827c / src/ (dialogs.cpp game_initialization/multiplayer.cpp help/help_browser.cpp): replace some CVideo::get_singleton calls. https://github.com/wesnoth/wesnoth/commit/25f60358827c3b26b73786e413b6be1cdec1d06a
20160113 00:13:17< irker325> wesnoth: gfgtdf wesnoth:master 7deb41ce41bf / src/hotkey/command_executor.hpp: fix travis build. https://github.com/wesnoth/wesnoth/commit/7deb41ce41bf807a747dbf4dd63f81bb7c402cc1
20160113 00:14:17< gfgtdf> i wonder why irker325 doesnt create short libnks anymore
20160113 00:34:49-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20160113 00:45:08-!- travis-ci [~travis-ci@ec2-23-22-206-184.compute-1.amazonaws.com] has joined #wesnoth-dev
20160113 00:45:08< travis-ci> wesnoth/wesnoth#8188 (master - 7deb41c : gfgtdf): The build is still failing.
20160113 00:45:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/101985692
20160113 00:45:09-!- travis-ci [~travis-ci@ec2-23-22-206-184.compute-1.amazonaws.com] has left #wesnoth-dev []
20160113 00:46:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160113 00:48:19< shadowm> gfgtdf: irker doesn't create the links, it just parrots whatever information GitHub sent.
20160113 00:48:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160113 00:49:11< shadowm> GitHub's link shortener breaks on occasion, so the repository hooks default to the full links when that happens.
20160113 00:50:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160113 00:53:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160113 01:10:58< vultraz> shadowm: if you have time, could you look at the prefs pr and see if I'm going in the right direction
20160113 01:16:57< vultraz> I still need to figure out if you can pass function pointers to functions of varying return type
20160113 01:18:07< gfgtdf> functions wirth varying return type?
20160113 01:18:25< vultraz> some of the prefs setter functions are void and some are bool
20160113 01:18:54< vultraz> I could make the bools (sound setters) void but it might be useful to keep them bool since they return false if sound doesn't initialize
20160113 01:19:13< vultraz> I'll need to make an overload to deal with that
20160113 01:19:13< gfgtdf> vultraz: you can afaik easiy cast  a bool returning function to a void trtuning finction, teh retrn value will just be discarded
20160113 01:19:36< gfgtdf> vultraz: overloadd sounds good
20160113 01:21:56< vultraz> gfgtdf: ok so I have this 'general button/slider init function' https://github.com/Vultraz/wesnoth/commit/3c84a6db66e2f9d39f52233543badb77bf60a9e2 If I create an overload for simple_toggle_slider_callback(), is it possible to pass either a void or bool function as the 5th argument and have it execute the appropriate overload?
20160113 01:22:09< vultraz> as the 5th argument to simple_button_slider_pair_setup*
20160113 01:23:20< vultraz> s/function/function pointer
20160113 01:25:40< gfgtdf> vultraz: hmm from looking at teh code i'd say that you dont really use the bool return value yet
20160113 01:32:01-!- gfgtdf [~chatzilla@x50ab9553.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20160113 01:47:38< vultraz> gfgtdf: bc I haven't added the overload yet
20160113 02:00:28-!- solvents [~quassel@69-196-152-213.dsl.teksavvy.com] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
20160113 02:26:16< vultraz> gahhhhh
20160113 02:26:23 * vultraz can't figure this out
20160113 02:42:39-!- gfgtdf [~chatzilla@x50ab6eb0.dyn.telefonica.de] has joined #wesnoth-dev
20160113 02:43:02< gfgtdf> vultraz: i really think that boolean value is not that important, so i reccoment to just discard that return value
20160113 02:43:17< gfgtdf> vultraz: you can still implement it later if you need it.
20160113 02:43:23< vultraz> how do I do that?
20160113 02:44:06< gfgtdf> hmm ym first try would be to change the type of the 5. argument to boost::function<void(bool)>
20160113 02:44:10< gfgtdf> my*
20160113 02:53:30< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\dialogs\preferences_dialog.cpp|188|error: invalid conversion from 'void (*)(bool)' to 'boost::function<void(bool)> (*)(bool)' [-fpermissive]|
20160113 02:54:44< gfgtdf> hmm 'boost::function<void(bool)> (*)(bool)' lloks uite strange
20160113 02:54:47< gfgtdf> looks
20160113 02:55:21< gfgtdf> what is your code currently?
20160113 02:57:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160113 02:58:17< vultraz> , boost::function<void(bool)> (*toggle_callback) (bool)
20160113 03:02:32< gfgtdf> hmm my suggestion was to change teh 5. parameter to 'boost::function<void(bool)>'  not to 'boost::function<void(bool)> (*) (bool)'
20160113 03:05:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160113 03:07:02< vultraz> the whole param?
20160113 03:10:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160113 03:11:39< vultraz> don't i still need to name it?
20160113 03:13:40-!- irker325 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160113 03:15:28< gfgtdf> vultraz: well, yes boost::function<void(bool)>is the type
20160113 03:15:39< gfgtdf> vultraz: parameters usually ahve teh form <type> <name>
20160113 03:15:44< vultraz> yes
20160113 03:23:54< gfgtdf> vultraz: function pointers are a little strangein teh regard
20160113 03:24:03< gfgtdf> vultraz: but you can also do taht for function pointers
20160113 03:26:02< vultraz> so do I need just boost::function<void(bool)> *toggle_callback?
20160113 03:27:08< gfgtdf> vultraz: still a * to much
20160113 03:27:44< gfgtdf> vultraz: that would be a pointer to a boost::function (which itself already contains a pointer to a function)
20160113 03:35:59< vultraz> ah ty
20160113 03:36:02< vultraz> works now :)
20160113 04:04:02-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 246 seconds]
20160113 04:09:51-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160113 04:11:19-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160113 04:35:01-!- gfgtdf [~chatzilla@x50ab6eb0.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.4/20160105164030]]
20160113 04:59:36< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\dialogs\preferences_dialog.cpp|163|error: invalid conversion from 'void (*)(double)' to 'void (*)(int)' [-fpermissive]|
20160113 04:59:38< vultraz> dammit
20160113 04:59:39< vultraz> um...
20160113 04:59:43< vultraz> I think I need... a cast
20160113 05:09:44< celticminstrel> Casting function types probably isn't safe.
20160113 05:15:37-!- celticminstrel is now known as celmin|sleep
20160113 05:21:28< vultraz> ughh
20160113 05:21:34< vultraz> can't we use C++11 already
20160113 05:21:41 * vultraz wants std::to_string :(
20160113 05:22:16< vultraz> really, what's preventing us from using C++11 features
20160113 05:23:54< vultraz> it used to be compiler support, but that was years ago
20160113 05:28:30< vultraz> shadowm: are there any ideas about when we'll officially start using it 
20160113 05:42:28-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has joined #wesnoth-dev
20160113 06:05:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160113 06:10:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20160113 06:21:02-!- Kwandulin [~Miranda@p200300760F250ADCE43BAE1A37667136.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160113 06:40:35-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160113 07:09:32-!- Kwandulin [~Miranda@p200300760F250ADCE43BAE1A37667136.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160113 07:22:23-!- Kwandulin [~Miranda@p200300760F250AF0E43BAE1A37667136.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160113 07:32:28< shadowm> vultraz: Still compiler support as of less than five months ago.
20160113 07:33:07< shadowm> IIRC one or two of our Windows devs are using compilers (read: older MSVC++ versions) without support for features we want.
20160113 07:34:07-!- prkc [~prkc@catv-80-98-216-55.catv.broadband.hu] has joined #wesnoth-dev
20160113 07:50:57-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20160113 07:58:32-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160113 08:22:23< vultraz> Well we should reevaluate the status quo, hopefully
20160113 08:23:43< vultraz> It's becoming a hindrance not to have stuff like std::to_string an std::stoi
20160113 08:33:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160113 08:37:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160113 08:56:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160113 09:04:16< vultraz> gfgtdf: the buttons in the editor aren't drawing their overlays at all O_O
20160113 09:05:54-!- irker552 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160113 09:05:54< irker552> wesnoth: Charles Dang wesnoth:master 34b7f97658f1 / data/gui/default/widget/slider_default.cfg: gui2/tslider: adjust magic numbers so text area doesn't take up unnecessary spac https://github.com/wesnoth/wesnoth/commit/34b7f97658f1a8c96d872b1bf7bc049faae19715
20160113 09:06:07< vultraz> shadowm: ^
20160113 09:08:40< vultraz> gfgtdf: actually I observed the fullscreen toggle button not affecting the screen either. it's like there's a difference in the class that's holding the screen and the class that's being affected by functions like that
20160113 09:10:54< vultraz> gfgtdf: also in gui2/taddon_connect you made help use window.video() instead of disp_.video(). Should all the gui2 dialogs do that?
20160113 09:11:09< vultraz> instead of passing display or CVideo arguments?
20160113 09:13:13< vultraz> gfgtdf: if so can you remove the disp arguments to them
20160113 09:13:37< vultraz> esp the one in addon_connect is unused so it's causing travis errors
20160113 09:24:49-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160113 09:37:15< zookeeper> won't compile (still SDL1): http://pastebin.com/3fKer3ym
20160113 09:38:32< shadowm> 05:23:43 <vultraz> It's becoming a hindrance not to have stuff like std::to_string an std::stoi
20160113 09:38:50< shadowm> That's what you have lexical_cast and str_cast (utils.hpp) for.
20160113 09:39:53< shadowm> It's not a hindrance because they serve the same role as the C++11 stdlib equivalents.
20160113 09:41:47< shadowm> Also I assume you tested that commit with sufficiently large slider values.
20160113 09:42:38< shadowm> Anyway in general I said this before (to you in fact), there's hardly any reason to rush C++11 for standard library features since we're using Boost.
20160113 09:42:54< shadowm> It's language features that I'm more interested in but you hardly need to concern yourself with those.
20160113 09:56:32-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Ping timeout: 276 seconds]
20160113 10:01:32-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has joined #wesnoth-dev
20160113 10:07:46-!- travis-ci [~travis-ci@ec2-54-163-39-152.compute-1.amazonaws.com] has joined #wesnoth-dev
20160113 10:07:46< travis-ci> wesnoth/wesnoth#8194 (master - 34b7f97 : Charles Dang): The build is still failing.
20160113 10:07:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/102051979
20160113 10:07:47-!- travis-ci [~travis-ci@ec2-54-163-39-152.compute-1.amazonaws.com] has left #wesnoth-dev []
20160113 11:00:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160113 11:04:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160113 11:10:38-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 276 seconds]
20160113 11:10:44-!- mjs-de [~mjs-de@x4db5054e.dyn.telefonica.de] has joined #wesnoth-dev
20160113 11:10:58-!- Kwandulin [~Miranda@p200300760F250AF0E43BAE1A37667136.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160113 11:11:36-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160113 11:13:46-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160113 11:21:00-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160113 11:23:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160113 11:52:07 * vultraz curses the fact that preferences are spread out over 5 files
20160113 11:52:38< vultraz> later will have to consolidate 
20160113 11:58:06-!- mjs-de [~mjs-de@x4db5054e.dyn.telefonica.de] has quit [Remote host closed the connection]
20160113 11:59:46-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20160113 12:06:08-!- irker552 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160113 12:12:35< vultraz> gfgtdf: hm im having trouble using boost::ref with a cvideo object.. error: no matching function for call to 'get_pointer(CVideo&)'|
20160113 12:16:17< vultraz> either with window.video() or a private class member
20160113 12:23:15-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 240 seconds]
20160113 12:27:02-!- EdB [~edb@89-158-11-138.rev.numericable.fr] has quit [Quit: Konversation terminated!]
20160113 12:31:17-!- gfgtdf [~chatzilla@x50ab6eb0.dyn.telefonica.de] has joined #wesnoth-dev
20160113 12:31:28< gfgtdf> 20160113 09:10:54< vultraz> gfgtdf: also in gui2/taddon_connect you made help use window.video() instead of disp_.video(). Should all the gui2 dialogs do that?
20160113 12:31:58< gfgtdf> vultraz: well i made that so i dont need a display object agument in that dialog
20160113 12:32:27< gfgtdf> vultraz: i dont know of which gui2 dialogs exatly you speak
20160113 12:33:05< gfgtdf> vultraz: but i think it makes sense that the help box is shown at the same diplayas teh window
20160113 12:33:43< gfgtdf> 20160113 09:13:37< vultraz> esp the one in addon_connect is unused so it's causing travis errors
20160113 12:33:54< gfgtdf> vultraz: i thought i already fixed that
20160113 12:34:22< vultraz> gfgtdf: unit attack and unit create also have disp arguments for help and use disp_->video() to show it
20160113 12:34:23< gfgtdf> 20160113 09:08:40< vultraz> gfgtdf: actually I observed the fullscreen toggle button not affecting the screen either. it's like there's a difference in the class that's holding the screen and the class that's being affected by functions like that
20160113 12:34:31< vultraz> my question is if they could become window.video()
20160113 12:34:31< gfgtdf> vultraz: which fullscreen button?
20160113 12:34:35< vultraz> gfgtdf: in prefs
20160113 12:34:48< gfgtdf> vultraz: in teh gui2 dialog you mean ?
20160113 12:35:14< vultraz> yes. i have it calling video_.set_fullscreen() (class CVideo& object)
20160113 12:35:35< vultraz> s/class/it's a CVideo& class object
20160113 12:35:52< gfgtdf> vultraz: hmm why not.
20160113 12:37:34< vultraz> if we can always use window.video() in gui2 that will be great
20160113 12:38:17< vultraz> but there seems to be a problem bc I can't pass it through boost::ref
20160113 12:44:41-!- Kwandulin [~Miranda@p200300760F250AF074A09AF8F60CD91C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160113 12:50:06< zookeeper> so what about those compile errors i pastebinned?
20160113 12:55:34< loonycyborg> zookeeper: you sure your source isn't corrupted or you don't have outdated files in your build? Those errors don't seem to be something that could be msvc specific..
20160113 12:58:19< zookeeper> loonycyborg, not that i can tell. maybe it's related to project files, but it didn't look like that to me.
20160113 12:59:59< loonycyborg> well it seems there was recently a code reorganization related to surfaces, so could be obsolete code path due to some file that wasn't removed from project but no longer needed
20160113 13:00:15< loonycyborg> hmm or maybe it's sdl1 specific
20160113 13:00:23< loonycyborg> I could try to compile with sdl1
20160113 13:05:58< loonycyborg> src/game_initialization/create_engine.hpp:90:10: ошибка: field «minimap_img_» has incomplete type «surface»
20160113 13:07:40< loonycyborg> so yeah, seems it seems sdl1 support is broken
20160113 13:14:27-!- gfgtdf [~chatzilla@x50ab6eb0.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.4/20160105164030]]
20160113 13:20:24-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160113 13:25:30-!- gfgtdf [~chatzilla@x50ab6eb0.dyn.telefonica.de] has joined #wesnoth-dev
20160113 13:25:47< gfgtdf> zookeeper, loonycyborg hmm mostlikeley ist just some header files missing
20160113 13:27:02< gfgtdf> include directives i mean
20160113 13:32:56< vultraz> gfgtdf: do you have any fix in mind for the issues?
20160113 13:33:10< gfgtdf> vultraz: for whcih issues ?
20160113 13:33:43< vultraz> [20:04:11]	vultraz	gfgtdf: the buttons in the editor aren't drawing their overlays at all
20160113 13:33:56< vultraz> also set_fullscreen not affecting the display
20160113 13:34:06< vultraz> and [23:12:31]	vultraz	gfgtdf: hm im having trouble using boost::ref with a cvideo object.. error: no matching function for call to 'get_pointer(CVideo&)'|
20160113 13:35:21< gfgtdf> vultraz: i didnt notive problems with set_fulscreen
20160113 13:35:25< gfgtdf> notice
20160113 13:35:30< gfgtdf> [20:04:11]	vultraz	gfgtdf: the buttons in the editor aren't drawing their overlays at all
20160113 13:35:33< gfgtdf> will think about it
20160113 13:35:41< gfgtdf> 	and [23:12:31]	vultraz	gfgtdf: hm im having trouble using boost::ref with a cvideo object.. error: no matching function for call to 'get_pointer(CVideo&)'|
20160113 13:35:55< gfgtdf> you shoudl the code it ratehr hard to tell whats wrong from that message
20160113 13:36:33< vultraz> 	connect_signal_mouse_left_click(
20160113 13:36:35< vultraz> 			find_widget<tbutton>(&window, "resolution_set", false),
20160113 13:36:36< vultraz> 			boost::bind(&show_video_mode_dialog, boost::ref(window.video())));
20160113 13:36:51< gfgtdf> vultraz: and how does show_video_mode_dialog look like ?
20160113 13:37:11< vultraz> it's the one in preferences_display.cpp
20160113 13:40:38< gfgtdf> vultraz: hmm i dont see whats teh problem of with that code right now.
20160113 13:41:19< vultraz> oh, it also says note:   'CVideo' is not derived from 'const boost::reference_wrapper<T>'|
20160113 13:41:29< vultraz> i think it has something to do with your singleton commit, maybe...
20160113 13:41:39< vultraz> or maybe the disp -> cvideo refactor
20160113 13:42:56< gfgtdf> vultraz: hmm no thats unlikeley
20160113 13:43:00-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 260 seconds]
20160113 13:51:23< gfgtdf> hmm maybe you are missing some #includes?
20160113 13:52:20-!- Appleman1234 [~Appleman1@KD119104005142.au-net.ne.jp] has quit [Ping timeout: 272 seconds]
20160113 13:53:37< vultraz> I don't think so
20160113 13:53:49< vultraz> I'm including video and prefs display
20160113 13:59:22-!- Kwandulin [~Miranda@p200300760F250AF074A09AF8F60CD91C.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160113 14:10:32< vultraz> gfgtdf: Ok i figured it out
20160113 14:10:35< vultraz> I needed to specify the namespace
20160113 14:10:56< vultraz> I had "using namespace preferences;"
20160113 14:11:02< vultraz> but apparently that doesn't work here
20160113 14:11:09< vultraz> probably some explanation but I don't know it
20160113 14:11:17< vultraz> s/here/for this function
20160113 14:12:32< vultraz> so boost::bind(&preferences::show_video_mode_dialog, boost::ref(window.video()) works fine
20160113 14:12:42< vultraz> but boost::bind(&show_video_mode_dialog, boost::ref(window.video()) does not
20160113 14:14:07< vultraz> ugh. it builds, but the callback doesn't actually bring up the button :(
20160113 14:21:29< vultraz> it gets as far as the .show() call but the dialog never appears
20160113 14:21:30< vultraz> hm
20160113 14:25:40< vultraz> might be related to the icons not drawing in the editor
20160113 14:25:53< vultraz> almost like the display isn't being... updated
20160113 14:28:24< vultraz> gfgtdf: you didn't remove any calls to update_framebuffer did you?
20160113 14:36:56-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160113 14:41:43-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 265 seconds]
20160113 14:48:07-!- Appleman1234 [~Appleman1@KD119104009070.au-net.ne.jp] has joined #wesnoth-dev
20160113 14:59:41-!- ancestral [~ancestral@241.sub-70-197-207.myvzw.com] has joined #wesnoth-dev
20160113 15:18:56-!- Kwandulin [~Miranda@p200300760F250AF0F1CCA064C06B64F9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160113 15:19:59-!- ancestral [~ancestral@241.sub-70-197-207.myvzw.com] has quit [Quit: i go nstuf kthxbai]
20160113 15:42:51-!- boucman_2 [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160113 15:45:05-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 246 seconds]
20160113 15:52:18-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has quit [Remote host closed the connection]
20160113 16:00:21< gfgtdf> vultraz: well i didnt change teh gui2 gode
20160113 16:01:31< gfgtdf> vultraz: od did you mean there is currenlt y bug in the preferences menu ?
20160113 16:01:44-!- wedge010 [~Thunderbi@60.241.236.92] has joined #wesnoth-dev
20160113 16:02:58< gfgtdf> or*
20160113 16:03:12-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160113 16:04:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 245 seconds]
20160113 16:04:45-!- wedge010 is now known as wedge009
20160113 16:11:31< gfgtdf> 20160113 14:28:24< vultraz> gfgtdf: you didn't remove any calls to update_framebuffer did you?
20160113 16:11:44< gfgtdf> no, i only changes some disp.flip() calls to video.flip()
20160113 16:14:22-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20160113 16:15:52-!- irker201 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160113 16:15:52< irker201> wesnoth: gfgtdf wesnoth:master e5ad3e47ff4e / src/gui/dialogs/ (addon_connect.cpp addon_connect.hpp): fix unused variable. https://github.com/wesnoth/wesnoth/commit/e5ad3e47ff4e4f2f7a7f70ca57f1614cecef5924
20160113 16:15:52< irker201> wesnoth: gfgtdf wesnoth:master 6c12e7512556 / src/game_initialization/create_engine.hpp: attempt to fix sdl1 build https://github.com/wesnoth/wesnoth/commit/6c12e75125561c7370e66d6f0fcbbc28ddd7364e
20160113 16:15:53< irker201> wesnoth: gfgtdf wesnoth:master 75659ba9e2ea / src/editor/controller/editor_controller.hpp: fix editor buttons https://github.com/wesnoth/wesnoth/commit/75659ba9e2ea756907f5873f40c4f27ea8145742
20160113 16:15:53< gfgtdf> vultraz, zookeeper: ^
20160113 16:21:57-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has joined #wesnoth-dev
20160113 16:29:24-!- boucman_2 [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 272 seconds]
20160113 16:29:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160113 16:42:33-!- lipkab [~the_new_l@2001:738:5404:192:9e4e:36ff:fe7c:534c] has quit [Quit: Leaving]
20160113 16:44:43< vultraz> gfgtdf: ok I found the problem I was having
20160113 16:44:45< vultraz> https://github.com/wesnoth/wesnoth/blob/master/src/preferences_display.cpp#L122
20160113 16:45:11< vultraz> if I remove that line the dialog opens corrently
20160113 16:52:30-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160113 16:52:32< gfgtdf> vultraz: hmm i'd think that is mandtitory for gui1 dialogs liek preferneces
20160113 16:52:37-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160113 16:52:37-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160113 16:52:43< vultraz> ah
20160113 16:52:53< vultraz> well since I'm making it gui2 it can be removed then
20160113 17:20:51-!- mjs-de [~mjs-de@x4db5054e.dyn.telefonica.de] has joined #wesnoth-dev
20160113 17:30:33-!- Kwandulin [~Miranda@p200300760F250AF0F1CCA064C06B64F9.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160113 17:31:16< irker201> wesnoth: Celtic Minstrel wesnoth:master eb1d0e287657 / projectfiles/Xcode/Info.plist: XCode: Fix bundle signature warning https://github.com/wesnoth/wesnoth/commit/eb1d0e2876573a01383bdcdde4da3c2879dc123d
20160113 17:31:18< irker201> wesnoth: Celtic Minstrel wesnoth:master d98b74d3ad7c / src/events.cpp: Fix some missing prototype warnings https://github.com/wesnoth/wesnoth/commit/d98b74d3ad7c535684b2e251dd29f5c66f6dc514
20160113 17:31:37-!- celmin|sleep is now known as celticminstrel
20160113 17:34:53< celticminstrel> Aginor or whoever, it looks like resize_comparer (see above commit) is unused and could be removed.
20160113 17:35:14< celticminstrel> Either that, or it's supposed to be used somewhere but isn't.
20160113 17:39:16< vultraz> GUI2 prefs dialog now has about 85% of it's functionality working
20160113 17:39:47< celticminstrel> Is it activated in master?
20160113 17:40:56< vultraz> Not yet
20160113 17:41:07< vultraz> if you want to try it you need to use pr 581
20160113 17:41:31< celticminstrel> Eh, I'll wait.
20160113 17:41:40< celticminstrel> The GUI2 attack dialog is activated though, right?
20160113 17:41:43< vultraz> Yes
20160113 17:45:42< celticminstrel> Why is there so much space between level/race/alignment and hp/xp/mp? (in Create Unit)
20160113 17:46:50< celticminstrel> Hmm, as far as I can tell without side-by-side comparison, the new attack dialog looks exactly the same as before, which is good.
20160113 17:47:35< celticminstrel> What about the damage calculation dialog? Maybe that was already GUI2...
20160113 17:47:37< vultraz> celticminstrel: basically, yes, but the layout of the details is better, there's no text-over-image overlay on large sprites, and there's less info (no Race or Ability fields)
20160113 17:48:05< vultraz> celticminstrel: it is not. I don't know how to draw those bars. Probably will need a custom widget with [draw] routines like gfgtdf suggested...
20160113 17:50:08< celticminstrel> Speaking of the damage calculation dialog, I think it should use × (U+00D7) instead of * to indicate multiples.
20160113 17:50:28< celticminstrel> (Also Apple, why is that character not in any of the US keyboard layouts? >< )
20160113 17:51:06< celticminstrel> For drawing the bars, can't you just keep the code that's already there?
20160113 17:54:23< celticminstrel> The objectives window didn't disappear after being dismissed...
20160113 17:54:33< vultraz> known
20160113 17:54:50< celticminstrel> I'm just a bit surprised it's not already fixed.
20160113 17:56:23< vultraz> gfgtdf: fullscreen hotkey is broken in main menu. did you remove a handler somewhere?
20160113 17:56:59< vultraz> s/hotkey/setting
20160113 17:57:11< vultraz> actually display changing, period
20160113 17:57:15< vultraz> (res included)
20160113 17:57:48< vultraz> gfgtdf: works in game
20160113 18:04:04< vultraz> gfgtdf: earlier i thought i was everywhere but it's not
20160113 18:08:30-!- flowerhack [sid6775@gateway/web/irccloud.com/x-fgxiedwibatbutjq] has quit [K-Lined]
20160113 18:08:36-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-vbycmketxclixume] has quit [K-Lined]
20160113 18:10:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160113 18:12:36< gfgtdf> vultraz: hmm this seems to be a bug in CVideo::fullscreen
20160113 18:12:46< vultraz> oh?
20160113 18:13:04< gfgtdf> vultraz: someone added  a 'if (display::get_singleton())' there for unknown readons
20160113 18:13:07< gfgtdf> reasons
20160113 18:13:23< vultraz> I did
20160113 18:13:27< gfgtdf> vultraz: why?
20160113 18:13:31< celticminstrel> For unknown reasons?
20160113 18:13:38< vultraz> since Aginor said we should always check the existence of display::get_singleton
20160113 18:13:44< vultraz> for saftey
20160113 18:13:50< gfgtdf> vultraz: well only if you use it
20160113 18:13:52< vultraz> but if you fixed the bug related to it maybe you can remove that
20160113 18:14:26< vultraz> gfgtdf: it is used: display::get_singleton()->redraw_everything();
20160113 18:15:17< gfgtdf> vultraz: hmm i see
20160113 18:15:38< gfgtdf> vultraz: the proper fix is to onyl guard that call into a if(display::get_singleton()) and not teh whoe content of teh function
20160113 18:15:47< gfgtdf> the whole*
20160113 18:16:30< vultraz> gfgtdf: likewise for set_resolution?
20160113 18:16:49< gfgtdf> vultraz: yes
20160113 18:17:10< gfgtdf> vultraz: although i don't know when set_resulution actually gets called
20160113 18:17:31< vultraz> from show_video_mode_dialog
20160113 18:17:45-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160113 18:17:52-!- flowerhack [sid6775@gateway/web/irccloud.com/x-mckjyiupjiukrpoh] has joined #wesnoth-dev
20160113 18:19:39< vultraz> also from -r
20160113 18:20:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160113 18:22:45-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-zsatrdxkjazsgtdr] has joined #wesnoth-dev
20160113 18:27:39< vultraz> gfgtdf: that works but it's laggier than last time it worked. hm
20160113 18:27:55< gfgtdf> vultraz: the fullscreen ?
20160113 18:28:03< vultraz> fullscreen toggling yes
20160113 18:28:11< vultraz> takes maybe 2x as long
20160113 18:30:55< gfgtdf> vultraz: hmm dont know why this could be teh case
20160113 18:31:02< vultraz> me neither
20160113 18:35:06< irker201> wesnoth: Charles Dang wesnoth:master cd91cc224c66 / src/video.cpp: Restrict singleton checks in video setters to the singleton callers only https://github.com/wesnoth/wesnoth/commit/cd91cc224c66d1963bd9e0f24e1a4cda0482b3dd
20160113 18:35:09< irker201> wesnoth: Charles Dang wesnoth:master b7c507453c9b / src/attack_prediction_display.cpp: Use (U+00D7) instead of * to indicate multiples in damage calculation dialog https://github.com/wesnoth/wesnoth/commit/b7c507453c9b4e4a6549c3bb74c7fe78aff60902
20160113 18:35:12< irker201> wesnoth: Charles Dang wesnoth:master ddd2a6a96c71 / src/game_launcher.cpp: Set stored res values directly when starting game with -r https://github.com/wesnoth/wesnoth/commit/ddd2a6a96c71cc7aa125b8fab39c0a45346de8c2
20160113 18:35:17< vultraz> celticminstrel: ^
20160113 18:35:43< celticminstrel> Sorry, why are you pinging me about that?
20160113 18:36:03< vultraz> b7c507453c9b 
20160113 18:36:20< vultraz> other two not relevant to you
20160113 18:36:22< vultraz> :P
20160113 18:36:31< celticminstrel> Oh heh.
20160113 18:39:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160113 18:42:36< vultraz> celticminstrel: what version of sdl are you building with?
20160113 18:42:48< vultraz> I need someone with 2.0.3 or below to test something
20160113 18:43:02< celticminstrel> Good question.
20160113 18:43:12< celticminstrel> When was 2.0.4 released?
20160113 18:43:23< vultraz> like two weeks ago
20160113 18:43:49< vultraz> actually last week i think
20160113 18:44:08< celticminstrel> I wouldn't have that then, I guess.
20160113 18:45:14< gfgtdf> vultraz: what exactly do you want to test with 2.0.4 ?
20160113 18:45:17< gfgtdf> 2.0.3*
20160113 18:45:20< vultraz> ok, can you try this: make sure wesnoth is *starting maximized* (new session where the window is maximized, don't use the wm button), then go to prefs and set a resolution. quit, and see if the resolution is maintained. I suspect it will be
20160113 18:45:44< vultraz> for me, it does not
20160113 18:45:51< vultraz> and I want to rule out 2.0.4
20160113 18:46:47< gfgtdf> vultraz: i thought teh resukltion dislaog is only important for fullscreen.
20160113 18:47:04< vultraz> if I remove this line https://github.com/wesnoth/wesnoth/blob/master/src/preferences.cpp#L118 it DOES work for me - but IIRC it worked with that before I upgraded to 2.0.4
20160113 18:47:12< vultraz> gfgtdf: no it sets window size. it's useless in fullscreen basically
20160113 18:47:44< gfgtdf> vultraz: well, if it has no effect in fullscreen we shodul think about removignit completeley
20160113 18:48:00< vultraz> ill probably disable it in fullscreen
20160113 18:48:04< gfgtdf> vultraz: i see no advantage in a dialog just to cha nge teh window size, if its much easier to do it the nromal way
20160113 18:48:37< celticminstrel> I don't see why it has no effect in fullscreen.
20160113 18:48:47< vultraz> because we use FULLSCREEN_DESKTOP 
20160113 18:48:49< vultraz> not FULLSCREEN
20160113 18:53:56< gfgtdf> vultraz: i know that the resultion window has an effect in wesnoth 1.12
20160113 18:54:07< gfgtdf> vultraz: in fullscreen i mten
20160113 18:55:28< vultraz> it does, yeah
20160113 18:55:45< vultraz> in sdl2 Aginor decided to not support that
20160113 18:56:03-!- travis-ci [~travis-ci@ec2-54-92-209-79.compute-1.amazonaws.com] has joined #wesnoth-dev
20160113 18:56:04< travis-ci> wesnoth/wesnoth#8198 (master - d98b74d : Celtic Minstrel): The build is still failing.
20160113 18:56:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/102156560
20160113 18:56:04-!- travis-ci [~travis-ci@ec2-54-92-209-79.compute-1.amazonaws.com] has left #wesnoth-dev []
20160113 18:56:59< vultraz> id still like to know if size is preserved after you set in 2.0.3, though
20160113 19:02:29< zookeeper> gfgtdf, great, it compiled without errors now
20160113 19:13:54-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 245 seconds]
20160113 19:16:05-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160113 19:18:31< irker201> wesnoth: ln-zookeeper wesnoth:master 3fcf414e0605 / data/ (4 files in 2 dirs): Unified thorns sound timing to -100 https://github.com/wesnoth/wesnoth/commit/3fcf414e0605c7de2be4565985dda59e2474f524
20160113 19:30:03< irker201> wesnoth: ln-zookeeper wesnoth:master c4261af1c5f2 / data/core/units/ (12 files in 3 dirs): Unified claws sound timing to -100 https://github.com/wesnoth/wesnoth/commit/c4261af1c5f2c5620169e27894446fcd40043f9d
20160113 19:32:26-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20160113 19:41:40< Ivanovic> shadowm: can you add "Aldarisvet" to the translators forum group?
20160113 19:42:01< Ivanovic> thanks!
20160113 19:59:42-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160113 20:33:25-!- travis-ci [~travis-ci@ec2-54-92-209-79.compute-1.amazonaws.com] has joined #wesnoth-dev
20160113 20:33:26< travis-ci> wesnoth/wesnoth#8200 (master - ddd2a6a : Charles Dang): The build was broken.
20160113 20:33:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/102169846
20160113 20:33:26-!- travis-ci [~travis-ci@ec2-54-92-209-79.compute-1.amazonaws.com] has left #wesnoth-dev []
20160113 20:33:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160113 20:41:19< vultraz> error about resize_comparer 
20160113 20:43:01< celticminstrel> What about it?
20160113 20:46:54< vultraz> in travis
20160113 20:47:36< vultraz> src/events.cpp:328:13: error: ‘bool events::resize_comparer(SDL_Event, SDL_Event)’ defined but not used [-Werror=unused-function]
20160113 20:48:25< vultraz> I'll just remove it. if it's necessary it can be restored
20160113 20:48:48< celticminstrel> Yeah, I think it can be removed. I mentioned that earlier too.
20160113 20:49:08< vultraz> weird that I locally get this warning but I don't see it in travis:
20160113 20:49:17< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\game_initialization\multiplayer.cpp||In function 'void enter_lobby_mode(CVideo&, const config&, saved_game&, const std::vector<std::__cxx11::basic_string<char> >&)':|
20160113 20:49:20< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\game_initialization\multiplayer.cpp|722|warning: 'res' may be used uninitialized in this function [-Wmaybe-uninitialized]|
20160113 20:51:59< irker201> wesnoth: Charles Dang wesnoth:master 1304ac095433 / src/events.cpp: Removed unused static resize_comparer function https://github.com/wesnoth/wesnoth/commit/1304ac095433ae9f4bbebc630d287c0823808fb2
20160113 20:52:24< celticminstrel> Which I just made static a few commits ago. Probably should've removed it then instead. >_>
20160113 20:54:11< celticminstrel> Why is the new MP lobby disabled?
20160113 20:54:18< celticminstrel> I mean at the source level.
20160113 20:54:29< vultraz> bugs
20160113 20:54:46< vultraz> i remember there was an issue with removing listbox rows
20160113 20:54:50< vultraz> might have been fixed, though
20160113 20:54:54< vultraz> but it's still clunky 
20160113 20:55:11< celticminstrel> If it's disabled at the source level, the option for it should also be removed from prefs.
20160113 20:55:24< celticminstrel> If someone decides to enable it, the game will crash.
20160113 20:55:57< vultraz> er
20160113 20:55:59< vultraz> wait
20160113 20:56:01< vultraz> what?
20160113 20:56:06< vultraz> you can enable it and it works :/
20160113 20:56:24< celticminstrel> Not according to that warning message you just posted.
20160113 20:56:34< vultraz> oh
20160113 20:57:45< celticminstrel> The warning is because of the #if block on lines 690 and 710.
20160113 20:58:00< celticminstrel> Okay, maybe it won't crash though, because it looks like that's just an enum.
20160113 21:05:19< celticminstrel> Okay, so if you enable the experimental lobby right now, when joining a server you never see the lobby and are just dumped back to the main menu.
20160113 21:07:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160113 21:08:17< celticminstrel> vultraz: How do I get the CVideo?
20160113 21:10:09< celticminstrel> Never mind, found it.
20160113 21:10:55< celticminstrel> There are a ton of "#if 0" in the code... o.O
20160113 21:11:13< celticminstrel> More than two pages worth in grep.
20160113 21:13:10< celticminstrel> The experimental lobby is much uglier.
20160113 21:13:44< celticminstrel> And crashes if you try to view the list of users.
20160113 21:16:16< celticminstrel> An assertion failure in attempting to place a grid.
20160113 21:16:31< vultraz> now you see why we don't use it
20160113 21:17:16< celticminstrel> But the preference specifically call it experimental after all. I doubt very many people would set that option anyway.
20160113 21:17:48< celticminstrel> ^calls
20160113 21:18:34< vultraz> indeed
20160113 21:20:09< celticminstrel> And right now, with the experimental lobby disabled, setting the option prevents people from playing multiplayer at all. Is that better than the possibility of a crash?
20160113 21:20:24< vultraz> celticminstrel: might I beg your help once again... if you pass a non-type enum (ie enum { A, B , C}) to a function, will the enum value have the type of the parameter it was passed to? 
20160113 21:20:40< celticminstrel> I have no idea what you're asking.
20160113 21:20:45< vultraz> there's a function here that basically goes
20160113 21:20:47< vultraz> void _set_lobby_joins(int show)
20160113 21:20:49< vultraz> {
20160113 21:20:50< vultraz> 	if (show == SHOW_FRIENDS) {
20160113 21:20:52< vultraz> etc etc
20160113 21:20:56< vultraz> and in the header, enum { SHOW_NONE, SHOW_FRIENDS, SHOW_ALL };
20160113 21:21:06< vultraz> I'm wondering how that can be considered an int
20160113 21:21:17< celticminstrel> Enums are implicitly convertible to int.
20160113 21:22:02< vultraz> ok, so if I did, say... _set_lobby_joins(1), it would match SHOW_NONE?
20160113 21:23:29< vultraz> (or is it 0)
20160113 21:23:54< celticminstrel> Uh, I forget.
20160113 21:24:00< celticminstrel> I think SHOW_NONE is 0?
20160113 21:24:04< celticminstrel> Then they count up from there.
20160113 21:24:11< celticminstrel> So SHOW_ALL would be 2.
20160113 21:24:22< celticminstrel> But don't do that. Use the name.
20160113 21:25:52< vultraz> I'm just trying to figure out how to use this enum for radio buttons..
20160113 21:25:55< vultraz> I guess I need to name it
20160113 21:26:11< vultraz> or maybe not..
20160113 21:27:33< vultraz> I really wish someone would create actual gui2 radio buttons :(
20160113 21:29:13< gfgtdf> vultraz: i thought gui1 has alreaady radio buttons
20160113 21:29:22< vultraz> yes but not gui2
20160113 21:29:33< gfgtdf> vultraz: i meant gui2
20160113 21:29:38< irker201> wesnoth: Celtic Minstrel wesnoth:master 8f5b938c171a / src/ (4 files in 3 dirs): Fix compilation for experimental MP lobby https://github.com/wesnoth/wesnoth/commit/8f5b938c171a8cb24dfab580c4e131cdc0940ca3
20160113 21:29:39< celticminstrel> I thought it did too.
20160113 21:30:10< vultraz> gfgtdf: there's an image for it using definition="radio",  so they look like radio buttons, but they are just toggle buttons with a different skin
20160113 21:30:22< celticminstrel> The experimental lobby no longer raises compilation errors, at least.
20160113 21:30:35< vultraz> as opposed to a derived widget that makes sure only 1 member in a group can be selected at any time
20160113 21:30:45< celticminstrel> I don't think that's a major problem.
20160113 21:30:49< vultraz> gfgtdf: maybe you can add it since you've worked on gui2?
20160113 21:31:03< gfgtdf> afaik the gui2 mp lobby is disabled for multiple reasons 1) The charbox always jumps to start, 2) IT doesnt support new mp featurtes, 3) people observed random crashed from the gui2 code with it
20160113 21:31:07< vultraz> celticminstrel: it is when functionality has to be recreated every time :P
20160113 21:31:25< celticminstrel> Well, a minor problem then.
20160113 21:32:04< celticminstrel> gfgtdf: Well, I didn't re-enable it, just ensured that it'll compile if someone else does. Assuming no more weird changes to the GUI2 APIs.
20160113 21:32:11< vultraz> thankfully I have a code reference
20160113 21:32:14< celticminstrel> Or other related stuff.
20160113 21:33:18< gfgtdf> celticminstrel: y i just had teh impression that someone askes why the gui2 mp connect code isnt used
20160113 21:33:50-!- travis-ci [~travis-ci@ec2-23-22-206-184.compute-1.amazonaws.com] has joined #wesnoth-dev
20160113 21:33:51< travis-ci> wesnoth/wesnoth#8201 (master - 3fcf414 : ln-zookeeper): The build is still failing.
20160113 21:33:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/102177882
20160113 21:33:51-!- travis-ci [~travis-ci@ec2-23-22-206-184.compute-1.amazonaws.com] has left #wesnoth-dev []
20160113 21:34:21< celticminstrel> What I was wondering is why the code that invokes the GUI2 lobby is effectively commented out.
20160113 21:35:35< gfgtdf> celticminstrel: hmm its possibel that i did that wuring a recent refactor
20160113 21:36:09< gfgtdf> celticminstrel: acually your commit wont work: display::get_singleton() will return null at that point
20160113 21:36:28< celticminstrel> Ack I forgot to fix that.
20160113 21:37:15< gfgtdf> celticminstrel: i think it shodul just be 'video' (the local variable)
20160113 21:37:20< celticminstrel> It should be.
20160113 21:37:27< irker201> wesnoth: Celtic Minstrel wesnoth:master 0bae45d7d467 / src/game_initialization/multiplayer.cpp: Fixup 8f5b938 https://github.com/wesnoth/wesnoth/commit/0bae45d7d4672b76d8d3f2b8f91de65bcaa01679
20160113 21:37:34< celticminstrel> I made the changes to the lobby class for that but forgot to update the call site.
20160113 21:37:41< gfgtdf> celticminstrel: you can also remove the #if0 if you fixed cimplication of that code
20160113 21:37:58< celticminstrel> I only made it compile. I haven't fixed any bugs.
20160113 21:38:01< gfgtdf> celticminstrel: i wanted to fix complication the the gui2 lobbay later but i forgot about it
20160113 21:38:04< celticminstrel> Like the crash I mentioned.
20160113 21:38:26< gfgtdf> celticminstrel: so it now does cimplie ?
20160113 21:38:38< celticminstrel> If you take out the if 0, yes.
20160113 21:43:05< irker201> wesnoth: gfgtdf wesnoth:master b0659d7b931b / src/game_initialization/multiplayer.cpp: remove an #if https://github.com/wesnoth/wesnoth/commit/b0659d7b931b0ab1f276606d0301448608559728
20160113 21:43:15< gfgtdf> celticminstrel: ok removed the #if
20160113 21:49:12-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20160113 21:50:38-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 256 seconds]
20160113 21:51:09-!- Necrosporus_ is now known as Necrosporus
20160113 21:55:57< vultraz> ok, got my radio buttons working by copying the implementation from editor_edit_side
20160113 21:58:14< shadowm> Ivanovic: Done.
20160113 21:58:15< shadowm> vultraz: https://forums.wesnoth.org/viewtopic.php?p=592637#p592637
20160113 21:59:50< vultraz> well that does us no good
20160113 21:59:53< vultraz> he had vanished
20160113 22:00:08< shadowm> Yeah but you are kind of supposed to tell _them_ that, not me.
20160113 22:02:50< shadowm> vultraz: Also, your post is wrong. He vanished afterwards and then reappeared in September 2015. And then he disappeared again.
20160113 22:02:59< vultraz> "significant amount of time"
20160113 22:03:02< vultraz> is the key phrase 
20160113 22:03:16< shadowm> A month is rather significant for you people.
20160113 22:03:24< vultraz> It was a month?
20160113 22:03:27< vultraz> I thought it was a wekk
20160113 22:03:30< vultraz> week(
20160113 22:03:32< vultraz> week*
20160113 22:03:33< shadowm> Especially considering the amount of work you've invested into this in only three weeks just now.
20160113 22:04:29< vultraz> this?
20160113 22:04:40< shadowm> This.
20160113 22:04:47< shadowm> This, vultraz.
20160113 22:04:50< shadowm> Wesnoth.
20160113 22:04:57< vultraz> uh huh
20160113 22:05:45< vultraz> well we're at a period where Stuff Is Happening 
20160113 22:05:56< vultraz> so I'm Making Stuff Happen
20160113 22:06:16< vultraz> and speaking of Making Stuff Happen, did you see my comments to you on the PR?
20160113 22:07:12< shadowm> No I didn't.
20160113 22:07:19< shadowm> I've not looked at any PRs yet.
20160113 22:08:25< vultraz> well I mentioned you with @. If you could take a look and reply to them, that would be invaluable 
20160113 22:08:33< vultraz> I'm trying to get the prefs dialog done quickly 
20160113 22:08:41< shadowm> I get a million notifications a day and I can't ever read them all.
20160113 22:08:56< vultraz> you get a million github mentions a day?
20160113 22:09:01< shadowm> Notifications.
20160113 22:09:16< vultraz> ah
20160113 22:10:26< shadowm> I didn't plan anything about Advanced Preferences.
20160113 22:10:33< shadowm> Otherwise there'd be code.
20160113 22:12:19< shadowm> I wanted to get the rest done ASAP and figure out Advanced as a late step.
20160113 22:12:33< vultraz> Alright. I agree. First I would like to deal with the Accelerated Speed option and the remaining settings that haven't their own dialogs
20160113 22:12:49< vultraz> The first, I don't know how to deal with the fact that it's a double
20160113 22:13:00< vultraz> Second, I wonder if we'll have to make gui2 dialogs for them
20160113 22:13:08< shadowm> Since I used dynamically generated buttons nested in a listbox in an unreleased dialog, I thought that perhaps the same could be used for Advanced since the only reason it isn't done with the GUI1 version anyway is because it was GUI1.
20160113 22:14:08< shadowm> But IIRC (I don't have the code anymore) it's very tricky code, and I'm not even sure how to deal with the new multi-state advanced entries.
20160113 22:14:32< shadowm> They could either be radio buttons or nested listboxes, but I'm not sure the latter is even doable.
20160113 22:14:48< celticminstrel> Nesting a listbox in a listbox would be weird.
20160113 22:15:04< shadowm> As a backup plan I was willing to keep the GUI1 dialog around for Advanced alone.
20160113 22:15:15< shadowm> As in, if I ran out of time before a release.
20160113 22:15:37< shadowm> But guess what, I ran out of time anyway because I never finished even the layout for the GUI2 preferences dialog.
20160113 22:15:40< celticminstrel> gfgtdf: Did you see my response to my bug report?
20160113 22:15:48< vultraz> Well, now I'm here to do so
20160113 22:16:08< shadowm> OTOH you can be thankful I at least got to bless you with the power of a saner GUI2 stacked_widget.
20160113 22:16:13< shadowm> Right?
20160113 22:16:14< vultraz> Indeed
20160113 22:16:18 * vultraz is thankful
20160113 22:17:39< gfgtdf> celticminstrel: accoruing to this page: https://www.mail-archive.com/wesnoth-bugs@gna.org/maillist.html i'm the last one who responded in that thread
20160113 22:17:45< shadowm> Another option I had considered was making the whole Advanced page dynamically generated as a plain grid instead of a listbox, but again, didn't get to do the research.
20160113 22:18:12< celticminstrel> Oh, so that's a yes.
20160113 22:18:25< shadowm> That'd have been more of a UX choice -- does it make sense to be able to _select_ items if they are already checkboxes, sliders, etc.?
20160113 22:18:41< vultraz> No
20160113 22:18:43< shadowm> Or perhaps selecting them would've worked more like a tree view.
20160113 22:19:06< shadowm> Select an item to render its interactive portion visible, perhaps alongside a helpful description (tooltips suck).
20160113 22:19:45< shadowm> Then when the item isn't selected you only get to see its value, saving space and making the whole thing less cluttered... insofar as there aren't interactive widgets all over the place.
20160113 22:20:03-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160113 22:21:18< shadowm> Essentially I was going to try every option available to see what people _and_ GUI2 liked better.
20160113 22:21:25< vultraz> *every*??
20160113 22:21:31< shadowm> Yes.
20160113 22:22:55< vultraz> you're mad
20160113 22:24:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160113 22:28:30-!- travis-ci [~travis-ci@ec2-23-22-206-184.compute-1.amazonaws.com] has joined #wesnoth-dev
20160113 22:28:31< travis-ci> wesnoth/wesnoth#8202 (master - c4261af : ln-zookeeper): The build is still failing.
20160113 22:28:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/102180119
20160113 22:28:31-!- travis-ci [~travis-ci@ec2-23-22-206-184.compute-1.amazonaws.com] has left #wesnoth-dev []
20160113 22:31:01< vultraz> shadowm: well, since there are so many options, maybe you can help me solve the more manageable things first?
20160113 22:34:05< zookeeper> someone push something so travis stops bugging me about that :p
20160113 22:35:49-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20160113 22:48:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160113 22:49:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160113 23:04:15< vultraz> shadowm: ok, proposal: restrict accelerated speed from .25 to 4 at .25 intervals OR .50 to 4 at .50 intervals
20160113 23:04:55< vultraz> gui1 goes .25, up till 2 and then 3, 4, 8, 16
20160113 23:04:57< vultraz> which is weird
20160113 23:05:04< vultraz> I think we should standardize it
20160113 23:05:52< gfgtdf> vultraz: why is that weird?
20160113 23:06:15< gfgtdf> vultraz: i'd day its just the ~10 most useful options
20160113 23:06:32< vultraz> well who would play at 16x speed
20160113 23:06:37< gfgtdf> vultraz: i mean noone woudl notive a differenc ebetween x9 or x10 so why have a x9 option ?
20160113 23:06:39< vultraz> also gui2 sliders only have uniform step, I think
20160113 23:06:49< gfgtdf> vultraz: a lot of people play at x16 speed
20160113 23:07:06< zookeeper> uh, yeah, definitely keep the ludicrous speeds
20160113 23:07:06< gfgtdf> vultraz: soeciually in mp
20160113 23:07:13< gfgtdf> specially*
20160113 23:08:14< zookeeper> it might not make a difference whether the max is 10x, 16x, 20x or 32x, but something in that ballpark needs to be available
20160113 23:08:36< shadowm> vultraz: Live it like it is right now.
20160113 23:08:37< celticminstrel> vultraz: It's powers of two.
20160113 23:08:41< shadowm> *Leave
20160113 23:09:07< shadowm> (Alternative reading: I made it the way it is right now, keep it that way.)
20160113 23:09:41< vultraz> shadowm: you have it 1-11 in steps of 1
20160113 23:09:43< celticminstrel> I suppose it could be stored as an integer power rather than as a double, provided you can still display it correctly.
20160113 23:10:07< vultraz> I'm confused how to deal with this
20160113 23:10:19< shadowm> vultraz: Yes vultraz I know how it is right now because I made it that way.
20160113 23:10:31< gfgtdf> vultraz: i think you can maybe assign labels to the differnt steps
20160113 23:10:39< shadowm> I'll insist that you must keep it the way it is right now.
20160113 23:11:01< zookeeper> the current slider is one of those complex options i've never really had a bad thing to say about, it has just the right steps. well, if anything, i might be inclined to add a .5 step after 2 and 3 (even though i've personally never needed them), but that's about it.
20160113 23:11:54< gfgtdf> vultraz: you could also make it a contonis slider (that gros exponentailly) from 0.25 to 16 idk if giu2 supports that
20160113 23:12:02< gfgtdf> continious
20160113 23:12:04< Ivanovic> shadowm: thanks
20160113 23:12:06< Ivanovic> n8
20160113 23:12:31< gfgtdf> grows*
20160113 23:12:52< vultraz> shadowm: I said I would, but *how do I deal with setting double values from the int step values*!
20160113 23:14:48< shadowm> Either make sliders accept double precision values or use int values that correspond to the existing scale.
20160113 23:15:05< shadowm> I hope I don't need to explain the latter option.
20160113 23:15:44< vultraz> uh....
20160113 23:15:50< shadowm> God.
20160113 23:16:04< vultraz> the only way I;m seeing is a giant switch block :|
20160113 23:16:30< shadowm> 0 = 0.25; 1 = 0.5; 2 = 0.75; etc.
20160113 23:16:34< vultraz> yes
20160113 23:16:38< vultraz> I know what that means
20160113 23:16:46< vultraz> but I'm thinking in terms of code
20160113 23:16:51< shadowm> Who cares, it's code.
20160113 23:16:54< vultraz> you'd need a switch block for all 11 cases
20160113 23:17:03< shadowm> That's called programming.
20160113 23:17:30< shadowm> If everything was designed to make code trivial to write we wouldn't have computers.
20160113 23:18:04< shadowm> Also, let me remind you that I don't like discussing things in terms of syntax.
20160113 23:19:42< shadowm> I don't care if it's a switch block or a for loop or an if clause as long as it does whatever it's supposed to do.
20160113 23:19:51< shadowm> That's also programming.
20160113 23:20:46< shadowm> That said, don't be _that_ guy and take things to the letter by making everything inline assembly.
20160113 23:29:08< vultraz> I think I could do it like this
20160113 23:29:49< vultraz> case 0 - 8: v = 0.25 * (n + 1)
20160113 23:29:50< vultraz> case  9: 4
20160113 23:29:52< vultraz> case 10: 8
20160113 23:29:53< vultraz> case 11: 16
20160113 23:30:27< vultraz> still pondering a correlation between the final three cases
20160113 23:32:08< gfgtdf> vultraz: i wonder whether gui2 actualyl supports non-continious sliders properly? IIRC it had some probelms with it but i may be wrong
20160113 23:32:42< vultraz> probably not, so I'm just going to try an associative formula 
20160113 23:32:51-!- solvents [~quassel@69-196-152-213.dsl.teksavvy.com] has joined #wesnoth-dev
20160113 23:34:18< vultraz> AH
20160113 23:35:10< vultraz> wait, no..
20160113 23:35:11< vultraz> hm
20160113 23:35:56< zookeeper> i can't see any reason why a switch block for 11 cases would be any kind of a problem for anyone
20160113 23:36:24< zookeeper> you can have a switch block for hundreds of cases and there's not necessarily anything wrong with that either
20160113 23:36:32< vultraz> it's not, but I personally feel it would mean I'm too dumb at math to come up with a formula 
20160113 23:36:34< zookeeper> in this case it wouldn't be just because of sloppy design either, so...
20160113 23:37:08< zookeeper> think of it this way: you're smart enough that you know it's better to write a simple 11-case switch block than one fancy formula no one can figure out in the future.
20160113 23:37:30< vultraz> you can't do it in one
20160113 23:37:41< vultraz> 0-8 have one
20160113 23:37:47< vultraz> I'm just seeing if 9 10 11 can have one
20160113 23:37:55< zookeeper> everyone will look at the switch and think how smart it was to do it in such a very easy-to-understand manner
20160113 23:38:37< vultraz> I don't think there is
20160113 23:38:52< vultraz> alright, 4 switch cases it is
20160113 23:39:44< zookeeper> sounds very compact
20160113 23:43:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20160113 23:50:28< Ravana_> not suggesting to use this, but I got similar formula http://vgy.me/RC2BO3.png
20160113 23:51:45< vultraz> P_P
20160113 23:52:07< vultraz> yeah, no, way too complicated 
20160113 23:53:27< gfgtdf> vultraz: i'd really use 11 swictzha cases (or a double array with 11 elements) becasue thats teh easiest to understand.
20160113 23:55:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
--- Log closed Thu Jan 14 00:00:27 2016