--- Log opened Fri Jan 15 00:00:56 2016
20160115 00:07:10-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160115 00:38:53-!- gfgtdf [~chatzilla@x50abb0ef.dyn.telefonica.de] has joined #wesnoth-dev
20160115 00:42:39-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds]
20160115 00:48:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20160115 01:06:57-!- mjs-de [~mjs-de@x4db5177a.dyn.telefonica.de] has quit [Remote host closed the connection]
20160115 01:15:10< vultraz> shadowm: been wondering, why do we have a preferences option for Sample Rate and Buffer Size?
20160115 01:15:16< vultraz> (Advanced Sound options)
20160115 01:15:30< vultraz> shouldn't that be handled internally, not a user-facing thing?
20160115 01:15:40< vultraz> was there some bug that it was a workaround for?
20160115 01:16:02< vultraz> I'd like to know before I make a gui2 subdialog for it
20160115 01:16:51< celticminstrel> I'd say it doesn't hurt to keep it.
20160115 01:17:12< celticminstrel> It's an advanced option, so not something you'd expect users to be fiddling with much, but...
20160115 01:18:19< celticminstrel> I suppose it could help people with older, slower computers?
20160115 01:24:55< vultraz> Alright
20160115 01:25:23< vultraz> I think I'll experiment with pages within pages
20160115 01:25:25< vultraz> Pageception
20160115 01:27:32< vultraz> I *think* it can be done
20160115 01:27:48< vultraz> if it does, maybe I'll convert all the GUI2 subdialogs to pages
20160115 01:27:59< vultraz> except hotkeys
20160115 01:28:17< celticminstrel> Because hotkeys is already a separate dialog and converting it to a page would be more work.
20160115 01:28:22< celticminstrel> Plus it has pages of its own.
20160115 01:28:43< vultraz> yes
20160115 01:28:54< vultraz> Imagine pages within pages within pages :P
20160115 01:29:10< celticminstrel> Yeah, I imagine that'd be a nightmare.
20160115 01:29:12< vultraz> but I mean, the Theme and Cache dialogs could become pages
20160115 01:29:28< vultraz> Alerts
20160115 01:30:15< celticminstrel> Which page are those on, again?
20160115 01:31:22< vultraz> Cache is general
20160115 01:31:25< vultraz> Theme is display
20160115 01:31:29< vultraz> Alerts is multiplayer
20160115 01:31:39< vultraz> plus I need to do something for Friends list and Advanced Sound
20160115 01:31:47< vultraz> oh, Advanced Display could be a page too
20160115 01:32:00< celticminstrel> Theme and alerts naturally fit under display and multiplayer, respectively.
20160115 01:32:14< celticminstrel> So moving them to a new page beside display and multiplayer might be weird.
20160115 01:33:07< vultraz> celticminstrel: oh no no, I meant move them to pages within the main pages
20160115 01:33:19< vultraz> like the gui1 dialog has
20160115 01:34:33< vultraz> either that or I make Advanced Sound and Friends List their own gui2 dialogs
20160115 01:35:09< celticminstrel> Shrug!
20160115 01:35:43< celticminstrel> Friends list doubles as ignore list, right? Maybe that should be made clearer.
20160115 01:40:44< vultraz> true
20160115 02:16:13-!- gfgtdf_ [~chatzilla@x50ab9777.dyn.telefonica.de] has joined #wesnoth-dev
20160115 02:18:17-!- gfgtdf [~chatzilla@x50abb0ef.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20160115 02:18:22-!- gfgtdf_ is now known as gfgtdf
20160115 02:48:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160115 03:02:56-!- gfgtdf [~chatzilla@x50ab9777.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.4/20160105164030]]
20160115 03:45:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160115 03:49:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20160115 04:24:43-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160115 04:31:34-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160115 04:39:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160115 04:39:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160115 05:17:11-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 276 seconds]
20160115 05:39:54-!- Kwandulin [~Miranda@p200300760F250A25501E9E53FD57447B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160115 05:41:38-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has joined #wesnoth-dev
20160115 05:51:34-!- ancestral [~ancestral@71-220-42-226.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160115 05:56:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160115 06:01:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20160115 06:05:59-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160115 06:37:29-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160115 07:05:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160115 07:08:55-!- Kwandulin [~Miranda@p200300760F250A25501E9E53FD57447B.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20160115 08:02:08-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20160115 08:25:49-!- boucman_work [~jrosen@193.56.60.161] has joined #wesnoth-dev
20160115 08:25:49-!- boucman_work [~jrosen@193.56.60.161] has quit [Changing host]
20160115 08:25:49-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160115 08:35:40-!- Kwandulin [~Miranda@p200300760F250AA4501E9E53FD57447B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160115 08:37:28-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160115 08:39:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160115 08:43:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160115 09:29:02-!- Kwandulin [~Miranda@p200300760F250AA4501E9E53FD57447B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160115 09:30:08-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160115 09:41:22-!- Kwandulin [~Miranda@p200300760F250AA4A1C67E7E84287E78.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160115 10:05:09-!- Appleman1234 [~Appleman1@KD119104018086.au-net.ne.jp] has quit [Ping timeout: 245 seconds]
20160115 10:21:16-!- boucman_2 [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160115 10:21:59< zookeeper> so is 1.13.3 still planned for today or not?
20160115 10:22:33-!- Appleman1234 [~Appleman1@KD119104018086.au-net.ne.jp] has joined #wesnoth-dev
20160115 10:24:38-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 246 seconds]
20160115 10:41:47-!- DDR [~david@ec2.happyspork.com] has quit [Ping timeout: 246 seconds]
20160115 10:44:15-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 246 seconds]
20160115 10:46:40-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20160115 10:47:48-!- DDR [~david@ec2.happyspork.com] has joined #wesnoth-dev
20160115 11:00:49-!- boucman_2 [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Remote host closed the connection]
20160115 11:06:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160115 11:10:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160115 11:26:46-!- Kwandulin [~Miranda@p200300760F250AA4A1C67E7E84287E78.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160115 11:35:49-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160115 11:38:51-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160115 11:42:45-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160115 11:56:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160115 12:01:45-!- boucman [~rosen@174.16.90.92.rev.sfr.net] has joined #wesnoth-dev
20160115 12:01:56-!- boucman [~rosen@174.16.90.92.rev.sfr.net] has quit [Changing host]
20160115 12:01:56-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160115 12:26:37-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160115 12:32:55-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 260 seconds]
20160115 12:43:45-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160115 13:04:17-!- TheJJ [~rofl@ipbcc36ea9.dynamic.kabel-deutschland.de] has quit [Ping timeout: 265 seconds]
20160115 13:07:33-!- TheJJ [~rofl@ipbcc36ea9.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20160115 13:12:17-!- Kwandulin [~Miranda@p200300760F250AA4D8A606F0B28E49E3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160115 13:14:08-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160115 13:20:33-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20160115 13:40:04-!- gfgtdf [~chatzilla@x50ab9777.dyn.telefonica.de] has joined #wesnoth-dev
20160115 13:43:38-!- gfgtdf [~chatzilla@x50ab9777.dyn.telefonica.de] has quit [Client Quit]
20160115 13:44:43-!- clavii is now known as clavi
20160115 13:49:15-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160115 13:51:38-!- Appleman1234 [~Appleman1@KD119104018086.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20160115 13:56:02-!- Kwandulin [~Miranda@p200300760F250AA4D8A606F0B28E49E3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160115 13:58:47-!- mjs-de [~mjs-de@x4db69f23.dyn.telefonica.de] has joined #wesnoth-dev
20160115 13:59:22-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 265 seconds]
20160115 13:59:42-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 272 seconds]
20160115 14:13:34-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160115 14:23:54-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds]
20160115 14:34:22-!- Kwandulin [~Miranda@p200300760F250AA435A30E59AD1BCA8E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160115 14:48:36-!- Appleman1234 [~Appleman1@119.104.8.173] has joined #wesnoth-dev
20160115 14:53:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20160115 14:54:09-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160115 15:20:47-!- ancestral [~ancestral@71-220-123-109.mpls.qwest.net] has joined #wesnoth-dev
20160115 15:21:36-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160115 15:49:55-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20160115 15:51:10-!- Appleman1234 [~Appleman1@119.104.8.173] has quit [Ping timeout: 272 seconds]
20160115 16:05:42-!- Kwandulin [~Miranda@p200300760F250AA435A30E59AD1BCA8E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160115 16:20:57-!- wedge010 [~Thunderbi@60.241.236.92] has joined #wesnoth-dev
20160115 16:23:04-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 245 seconds]
20160115 16:23:05-!- wedge010 is now known as wedge009
20160115 16:29:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160115 16:31:18-!- Kwandulin [~Miranda@p200300760F250AA470EC0A4C80F478D3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160115 16:38:04< vultraz> My pages-within-pages prototype is working :D
20160115 16:38:31< celticminstrel> Fun.
20160115 16:48:01< vultraz> indeed 
20160115 16:58:01-!- ancestral [~ancestral@71-220-123-109.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160115 17:02:52< vultraz> celticminstrel: quick question: http://pastebin.com/3fnvyGEX
20160115 17:05:41-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 276 seconds]
20160115 17:06:33< celticminstrel> You can't use Boost.Bind for that. You'd need a compile-time bind mechanism.
20160115 17:06:49< celticminstrel> This is because the function is being passed as a template parameter.
20160115 17:07:17< celticminstrel> You didn't post the definition of dialog_callback...
20160115 17:07:26< celticminstrel> Which is the actual issue here.
20160115 17:07:52< celticminstrel> I guess dialog_callback is a template functor.
20160115 17:08:36< celticminstrel> I guess my answer might change depending on its definition.
20160115 17:09:26-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160115 17:09:28< vultraz> Edited
20160115 17:10:18< celticminstrel> Huh, I didn't know you could edit pastebins.
20160115 17:11:09< vultraz> this kind of code is way out of my depth 
20160115 17:11:09< celticminstrel> What do you want to pass to on_tab_select?
20160115 17:11:53< vultraz> Edited paste with definition of on_tab_select
20160115 17:11:57< vultraz> want to pass a string
20160115 17:12:35< vultraz> since I want to be able to use that function for all 4 tab bars
20160115 17:12:49< vultraz> so I want to pass the widget id as a string
20160115 17:14:25< celticminstrel> I think you can pass a string as a template parameter.
20160115 17:15:08< celticminstrel> If it's a constant string.
20160115 17:15:28< vultraz> yes, const
20160115 17:15:57< celticminstrel> So something like template<const char* id>
20160115 17:16:13< celticminstrel> Just above the definition of on_tab_select (it becomes part of the definition).
20160115 17:16:29< celticminstrel> And then instantiate it with &tpreferences::on_tab_select<"id">
20160115 17:16:35< celticminstrel> Not 100% sure if that'll work.
20160115 17:18:59-!- prkc [~prkc@46.166.190.181] has joined #wesnoth-dev
20160115 17:19:22< vultraz> sadly not :(
20160115 17:19:26< vultraz> |error: no matching function for call to 'gui2::tlistbox::set_callback_value_change(<unresolved overloaded function type>)'|
20160115 17:19:48< celticminstrel> Well, you do need to add the template bit to the declaration in the header, too.
20160115 17:20:04< celticminstrel> And you might need to move the whole definition into the header.
20160115 17:20:37< celticminstrel> Though if it's a private function, probably not.
20160115 17:21:19< vultraz> yes, it's private 
20160115 17:21:40< celticminstrel> That "probably not" only applies to moving the definition, not to updating the declaration.
20160115 17:21:51< vultraz> yes, I do know that
20160115 17:22:14< celticminstrel> You might need to move the definition though.
20160115 17:22:33< celticminstrel> The definition will need to appear before the function is used in your set_callback_value_change call.
20160115 17:23:33< celticminstrel> Just don't need to move it into the header.
20160115 17:28:48< vultraz> moving the definition before the function that calls set_callback_value_change doesn't fix the problem
20160115 17:38:23< celticminstrel> Same error?
20160115 17:41:13< celticminstrel> I dunno what would cause that particular error, sorry.
20160115 17:41:28< celticminstrel> Unless there are alternate definitions of dialog_callback.
20160115 17:43:53< vultraz> it's like it's not fully initializing the inner template or something... since it also notes: "  no known conversion for argument 1 from '<unresolved overloaded function type>' to 'const boost::function<void(gui2::twidget&)>&'|"
20160115 17:44:58< celticminstrel> You're sure it has the full definition by then?
20160115 17:47:55< vultraz> i moved it to the top of the file
20160115 17:59:50-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160115 18:01:46< vultraz> oh maybe iceiceice can help
20160115 18:05:15< iceiceice> ok, i looked back in logs,
20160115 18:05:30< iceiceice> so in C++ you usually are not allowed to use string literals as a template parameter
20160115 18:05:34< iceiceice> because it is almost always a bug
20160115 18:05:40< iceiceice> the issue is that
20160115 18:05:50< iceiceice> if i have some template `template my_template<const char *>`
20160115 18:06:01< iceiceice> and I write `my_template<"foo">` at one point in the program,
20160115 18:06:10< iceiceice> if I write `my_template<"foo">` somewhere else,
20160115 18:06:14< iceiceice> those won't be the same type.
20160115 18:06:27< iceiceice> there are two different string literals "foo" in your program then,
20160115 18:06:31< iceiceice> with two different pointers
20160115 18:06:47< iceiceice> so effectively, if you write `my_template<"foo">`, that creates a type that you can't really refer to again
20160115 18:06:56< vultraz> I see
20160115 18:06:59< iceiceice> similarly you cannot use floating point number in templates
20160115 18:07:08< iceiceice> because it will just cause horrible headaches
20160115 18:07:31< iceiceice> if you need to do this, i guess what i usually do is,
20160115 18:07:46< iceiceice> either i make the template be `template my_template<const char * const *>`
20160115 18:07:57< iceiceice> and then i like, declare `static const char * my_string = "foo"`
20160115 18:08:03< iceiceice> and then template against `&my_string`
20160115 18:08:06< iceiceice> so that its always the same pointer,
20160115 18:08:07< iceiceice> or,
20160115 18:08:15< iceiceice> template against a function that takes no arguments and yields a string
20160115 18:08:30< iceiceice> so like, `const char * my_string() { return "foo" }`
20160115 18:08:46< iceiceice> and then `template my_template<const char * (*f)()>`
20160115 18:08:52< iceiceice> and then instantiate like `my_template<&my_string>`
20160115 18:09:17< vultraz> but I need to call this function multiple times with different strings. does that mean I need multiple "my_string" functions?
20160115 18:09:23< iceiceice> sure
20160115 18:10:09< vultraz> I wonder if there's a method to return a widget's id in GUI2
20160115 18:10:28< vultraz> I could use that to consolidate into one function with an if block 
20160115 18:10:45< iceiceice> another thing is, it may be easier to avoid doing this kind of stuff
20160115 18:10:53< iceiceice> and make the code work with strings that are passed to it at run time?
20160115 18:11:17< iceiceice> i think i never saw any of this template against a string stuff in wesnoth code
20160115 18:11:27< vultraz> wouldn't I need to change the definition of dialog_callback to do that
20160115 18:11:36< iceiceice> i dont know
20160115 18:11:42< iceiceice> i'm not actually familiar with what you are trying to do
20160115 18:12:10< iceiceice> vultraz: if you need like, something you can bind,
20160115 18:12:25< iceiceice> it might be that you can write your function to take an extra parameter which is a string,
20160115 18:12:34< iceiceice> but when you bind it, you bind that parameter, isntea dof using `_1`
20160115 18:12:36< iceiceice> or `_2`
20160115 18:12:37< iceiceice> whatever
20160115 18:13:40< vultraz> honestly would be a lot simpler if the gui2 experimental listbox was finished, since that accepts a simple connect_signal_notify_modified call  >_>
20160115 18:14:00< vultraz> iceiceice: bind the parameter?
20160115 18:16:08< celticminstrel> [Jan 15@1:07:46pm] iceiceice: either i make the template be `template my_template<const char * const *>`
20160115 18:16:09< celticminstrel> I'm pretty sure you don't actually need the extra * for that though.
20160115 18:16:41< celticminstrel> I was thinking of suggesting assigning the string literals to static global variables though.
20160115 18:20:22-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160115 18:21:44< iceiceice> celticminstrel, yeah i think you are right
20160115 18:21:48< iceiceice> about not needing the extra *
20160115 18:22:32< iceiceice> vultraz: what i mean is like,
20160115 18:23:03< iceiceice> if you have some function, and you need to bin it to produce signature void(int, double), say,
20160115 18:23:09< iceiceice> *you need to bind it,
20160115 18:23:18< iceiceice> and you are wanting to template it against a string for whatever reason,
20160115 18:23:41< iceiceice> so you were going to do `boost::bind(&my_func<&my_string>, _1, _2)`
20160115 18:24:03< iceiceice> you could probably instead write the function to take a string as third argument, instead of as a template paramter,
20160115 18:24:03< celticminstrel> You could have separate set_tab_for_bank_n type functions which all call the set_tab_callback with the required string.
20160115 18:24:16< iceiceice> and do `boost::Bind(&my_func, _1, _2, my_string)`
20160115 18:24:31< celticminstrel> Lowercase B, iceiceice 
20160115 18:24:33< iceiceice> which will be easier for people to read who don't know much about templates
20160115 18:24:35< iceiceice> yes
20160115 18:24:53< celticminstrel> I think the issue here is that he can't change dialog_callback because he doesn't understand what it's doing.
20160115 18:24:56< celticminstrel> Or something.
20160115 18:25:11< iceiceice> yeah i dont know the actual code thats going on
20160115 18:25:20< celticminstrel> You didn't look at the pastebin?
20160115 18:25:26< iceiceice> no
20160115 18:25:30< iceiceice> i didnt see it
20160115 18:26:04< vultraz> iceiceice: here's a better one http://pastebin.com/cdJv9vdJ
20160115 18:30:46< iceiceice> hmm
20160115 18:33:52< iceiceice> so i don't know what overloaded function is it talkinga bout
20160115 18:34:08< iceiceice> i guess it must be "dialog_callback" ?
20160115 18:34:37< iceiceice> but yeah i think you cannot put the string literal right in as a template parameter like that
20160115 18:34:41< iceiceice> or the compiler will probably crap out
20160115 18:34:55< iceiceice> so thats the first thing i would try
20160115 18:34:59< iceiceice> the second think i would try actually
20160115 18:35:08< iceiceice> is make a nicer template than "dialog_callback"
20160115 18:35:28< iceiceice> because dialog_callback is kind of shitty, it makes you specify both the member function and the base class type
20160115 18:35:49< iceiceice> really you should only have to specify the member function, and the compiler can deduce the base class type
20160115 18:36:20< iceiceice> so if i were you i would make a second template "make_dialog_callback" or something
20160115 18:36:28< iceiceice> thats slightly easier to use that way
20160115 18:36:49< iceiceice> i did this once recently, can't remember how exactly
20160115 18:37:20< vultraz> an example would be nice since I'm totally lost in this type of code :P
20160115 18:45:44-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Read error: Connection reset by peer]
20160115 18:46:07-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20160115 18:46:07-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20160115 18:46:07-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160115 18:48:24< iceiceice> i think something like this would work?
20160115 18:48:25< iceiceice> http://hastebin.com/eyetuvenef.coffee
20160115 18:48:35-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Read error: Connection reset by peer]
20160115 18:49:07-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160115 18:50:41< iceiceice> vultraz, so i don't know if that will help your problem exactly,
20160115 18:50:49< iceiceice> but it should basically do the same thing as the "dialog_callback" template,
20160115 18:50:53< iceiceice> except that 
20160115 18:51:01< iceiceice> you use it like `make_dialog_callback(fptr)`
20160115 18:51:14< iceiceice> rather than `make_dialog_callback<my_dialog, &my_dialog::fptr>`
20160115 18:54:39< vultraz> ok, but does that let me pass an argument?
20160115 18:57:35< iceiceice> no, i guess should write another one also
20160115 18:59:28< iceiceice> hmm
20160115 18:59:36< celticminstrel> Will that work without C++11?
20160115 18:59:43< iceiceice> i'm not sure
20160115 18:59:47< iceiceice> which part do you think is C++11 only?
20160115 19:00:00< iceiceice> i think C++98 supports local structs?
20160115 19:00:02< celticminstrel> I vaguely recall C++11 relaxing some restrictions related to local structs.
20160115 19:00:06< iceiceice> hmmm
20160115 19:00:17< iceiceice> yeah i mean i wish i could use a lambda there...
20160115 19:00:22< celticminstrel> True.
20160115 19:00:27< celticminstrel> Well, that basically is a lambda.
20160115 19:00:33< iceiceice> i dont know why mordante wants to do like,
20160115 19:00:42< iceiceice> why he wants to get the D* pointer from the dialog object always
20160115 19:00:49< iceiceice> instead of just passing that in
20160115 19:01:00< iceiceice> and binding it
20160115 19:01:18< celticminstrel> I have no idea.
20160115 19:01:24< vultraz> dont worry about that
20160115 19:01:27< vultraz> if it works use it
20160115 19:01:40-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Read error: Connection reset by peer]
20160115 19:01:48< celticminstrel> You could just forget about using dialog_callback.
20160115 19:01:55< celticminstrel> And bind set_tab_callback directly.
20160115 19:02:12-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20160115 19:02:12-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20160115 19:02:12-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160115 19:02:29< celticminstrel> Then it would need to take twidget instead of twindow and get the window via .get_window().
20160115 19:02:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160115 19:03:24< vultraz> or i could complete the experimental listbox :P 
20160115 19:03:25< vultraz> jk 
20160115 19:03:30< vultraz> i can't 
20160115 19:05:30< zookeeper> boucman, do you still want animation-related bugs to be assigned to you?
20160115 19:10:06< iceiceice> ok maybe try this version?
20160115 19:10:06< iceiceice> http://hastebin.com/tenivemamo.pas
20160115 19:10:52< iceiceice> hmm that site formatted it strangely
20160115 19:10:53< iceiceice> http://hastebin.com/raw/tenivemamo
20160115 19:13:43< vultraz> should make_dialog_callback_helper be static?
20160115 19:15:10< iceiceice> sure
20160115 19:15:25-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20160115 19:15:29< iceiceice> if its in a header file then yes
20160115 19:17:19< vultraz> oh, so I'm supposed to put this in the header?
20160115 19:19:30< iceiceice> if you want to use it in other places
20160115 19:19:48< iceiceice> you could put it next to "dialog_callback" definition, since its sort of an alternative
20160115 19:20:18< zookeeper> vultraz, err, do you have any idea whether dark sorcerer's shadow wave projectile is supposed to actually represent a shadow? because it's about at the level of the sorcerer's feet...
20160115 19:20:41< vultraz> zookeeper: i would assume a 'wave of shadow energy'
20160115 19:22:08< zookeeper> looks like it's bumbadadabum's doing
20160115 19:22:59< zookeeper> and looks like there's supposed to be the shadow that i'm seeing, but _also_ the actual projectile above it
20160115 19:23:01< zookeeper> which i don't see
20160115 19:23:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160115 19:25:14< zookeeper> err, no. the animation seems to be written so that the "projectile" is just the shadow, after which there's a different effect at offset=1.0. it looks buggy and odd, nevertheless.
20160115 19:33:17-!- Aginor [~andreas@unaffiliated/aginor] has quit [Remote host closed the connection]
20160115 19:36:02< vultraz> weird, I'm getting "multiple definition" errors when putting that code with dialog_callback's definition
20160115 19:41:39< iceiceice> vultraz, hmm sorry
20160115 19:41:41< iceiceice> you could try marking it "static inline" ?
20160115 19:43:55< iceiceice> or put only the declaration in the header, and put the definition in a .cpp file somewhere
20160115 19:44:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160115 19:44:20< vultraz>  how come dialog_callback doesn't have the same issue :|
20160115 19:44:50< celticminstrel> Inline would be the key, static is irrelevant.
20160115 19:45:50< iceiceice> yeah i guess thats right
20160115 19:46:45< vultraz> does make_dialog_callback need to be something too?
20160115 19:46:51< vultraz> (i'm guessing not inline)
20160115 19:47:56< celticminstrel> Template functions should generally always be inline.
20160115 19:48:19< celticminstrel> Either implicitly (by defining them in a class) or explicitly (with the inline keyword).
20160115 19:49:51-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160115 19:50:58< vultraz> preferences_dialog.cpp|503|error: no matching function for call to 'bind(<unresolved overloaded function type>, gui2::tpreferences*, boost::arg<1>&, const char [12])'|
20160115 19:51:00< vultraz> bind.hpp|1579|note: candidate: template<class R, class F> boost::_bi::bind_t<R, F, boost::_bi::list0> boost::bind(F)|
20160115 19:51:43< vultraz> (made both make_dialog_callback_helper and make_dialog_callback inline)
20160115 19:52:48< iceiceice> what's the signature for your thing you are trying to bind?
20160115 19:52:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160115 19:54:20< vultraz> OH I forgot to remove the 	template <const char* id> line from earlier
20160115 20:05:01< vultraz> iceiceice: it works! :D
20160115 20:05:11< vultraz> much thanks
20160115 20:06:13< iceiceice> huzzah
20160115 20:06:37< vultraz> would never have been able to code that myself
20160115 20:14:27< iceiceice> i hope it works ok
20160115 20:14:40< vultraz> works perfectly 
20160115 20:14:48< iceiceice> i dont know if there was some important reason that mordante was doing this part
20160115 20:14:48< iceiceice> D* dialog = dynamic_cast<D*>(caller.dialog());
20160115 20:15:05-!- Kwandulin [~Miranda@p200300760F250AA470EC0A4C80F478D3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160115 20:15:06< iceiceice> like if it destroys your dialog and brings it back later without rebinding or something?
20160115 20:15:24< iceiceice> if it doesn't crash then its ok i guess
20160115 20:15:28< iceiceice> :)
20160115 20:16:40< celticminstrel> It's not like it's a shared_ptr. The existence of the variable doesn't guarantee it stays valid or anything.
20160115 20:17:10< celticminstrel> Though I don't think it'd be possible for the dialog to be destroyed while the dialog_callback is executing.
20160115 20:17:20< celticminstrel> But yeah, if it works and doesn't crash, then whatever.
20160115 20:17:38< vultraz> one never knows what mordante was thinking when he created gui2
20160115 20:19:43< vultraz> and since he isn't around we can't ask
20160115 20:19:50< vultraz> though I do hear he will be at FOSDEM
20160115 20:37:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160115 20:38:53-!- prkc [~prkc@46.166.190.181] has quit [Ping timeout: 246 seconds]
20160115 20:42:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20160115 20:53:20-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160115 20:59:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160115 21:03:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds]
20160115 21:06:53< vultraz> ALRIGHT 
20160115 21:07:12< vultraz> after much work, I have converted all the gui2 preferences sub-dialogs to tabbed pages
20160115 21:07:25< vultraz> still need to re-add functionality 
20160115 21:07:27< vultraz> but that's for tomorrow
20160115 21:21:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160115 21:21:26-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160115 21:23:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: No route to host]
20160115 21:23:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160115 21:26:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: No route to host]
20160115 21:26:23-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160115 21:48:49-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20160115 21:49:29-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Disconnected by services]
20160115 21:49:31-!- Necrosporus_ is now known as Necrosporus
20160115 22:04:34-!- clavii [~clavi@163.172.10.77] has joined #wesnoth-dev
20160115 22:05:45-!- clavi [~clavi@163.172.10.77] has quit [Ping timeout: 260 seconds]
20160115 22:37:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160115 22:37:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20160115 22:39:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160115 22:43:30-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160115 22:45:22< boucman> zookeeper: I havn't even compiled wesnoth since it moved to git :(
20160115 22:45:36< zookeeper> boucman, oh, okay then :P
20160115 22:48:15< zookeeper> it's probably a pretty simple one to fix if one knows what they're doing: https://gna.org/bugs/?24314
20160115 22:49:01< zookeeper> i tried to look at the code myself but somehow the solution eluded me
20160115 23:03:21< shadowm> vultraz: Don't use pages within pages, just use hidden pages outside the pagination range. Nested pages will make both the code and the WML unbelievably complex and awkward.
20160115 23:03:35< shadowm> Notice that the GUI1 version also uses hidden pages.
20160115 23:05:18< shadowm> Also, it isn't obvious, but nested WML nodes have greater memory overhead than a flat big WML node.
20160115 23:05:42< shadowm> Not that it matters for this case usage unless your username starts with v and ends with z.
20160115 23:05:46< shadowm> *use case
20160115 23:08:01< vultraz> shadowm: so make them part of the same stack as the 5 main pages?
20160115 23:08:14< shadowm> That's literally what I said above.
20160115 23:08:26-!- matthiaskrgr_ is now known as matthiaskrgr
20160115 23:08:39< vultraz> Just woke up, just confirming 
20160115 23:10:16< vultraz> Makes a lot of sense, now that I think about it
20160115 23:10:48< vultraz> Will have to change a lot of code I wrote last night, however
20160115 23:10:53< vultraz> Oh well
20160115 23:24:36-!- irker478 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160115 23:24:36< irker478> wesnoth: Ignacio R. Morelle wesnoth:1.12 89c7a8448b92 / data/core/editor/brushes.cfg: Fix editor brush name https://github.com/wesnoth/wesnoth/commit/89c7a8448b92841efc874f4f1813d1188b00b84a
20160115 23:29:04-!- mjs-de [~mjs-de@x4db69f23.dyn.telefonica.de] has quit [Remote host closed the connection]
20160115 23:36:12-!- gfgtdf [~chatzilla@x50ab9777.dyn.telefonica.de] has joined #wesnoth-dev
20160115 23:36:36< gfgtdf> vultraz: did you see this bug http://gna.org/bugs/?24310 ? It is likeley to be related to the new gui2 attack dialog 
20160115 23:36:54< vultraz> yes I saw
20160115 23:45:27< vultraz> shadowm: actually, that would be complicated... since page setting is based on index, how would you get the appropriate index for the hidden sub-page, since there are four tab bars? I could do something like... for the general tab, selected index + 6, for display, selected index + 8 (since there are two tabs in general), etc, but I'm not sure that's the best way
20160115 23:47:12-!- louis94 [~~louis94@16.152-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20160115 23:52:29< vultraz> even with get_layer_count... it still means adding on the size of all the previous tabs
20160115 23:53:02< vultraz> shadowm: is this the only solution?
20160115 23:59:44-!- GiltheMudcrab [~Sasquash@c-24-21-217-33.hsd1.or.comcast.net] has joined #wesnoth-dev
20160115 23:59:55-!- GiltheMudcrab [~Sasquash@c-24-21-217-33.hsd1.or.comcast.net] has left #wesnoth-dev []
--- Log closed Sat Jan 16 00:00:20 2016