--- Log opened Fri Jan 22 00:00:33 2016
20160122 00:05:34< shadowm> Perhaps someone might be interested in fixing it?
20160122 00:10:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160122 00:17:18-!- prkc [~prkc@46.166.188.218] has quit [Remote host closed the connection]
20160122 00:24:37< vultraz> shadowm: that someone would not be me. However, I was considering splitting the advanced prefs into three categories - toggles, sliders, and custom. Have a scroll panel with a listbox for each and the relevant widgets in each row - thoughts? 
20160122 00:25:50< shadowm> Why not ask gfgtdf about fixing the tree view bug instead?
20160122 00:26:19< shadowm> If the whole purpose of this task was working around bugs then we might as well stick to the GUI1 Preferences dialog.
20160122 00:26:38< vultraz> Well it'd also be easier for me to code
20160122 00:26:47< vultraz> Since again, I really don't know how to work with tree views
20160122 00:27:13< shadowm> I am never going to approve of anti-user pro-coder UI design.
20160122 00:27:26< vultraz> Blah 
20160122 00:33:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds]
20160122 00:40:41-!- mjs-de [~mjs-de@f048013155.adsl.alicedsl.de] has quit [Remote host closed the connection]
20160122 00:45:44< gfgtdf> shadowm, vultraz: i am away of this treeview issue (listboxes have the same issue is you try to add eelemty damicaly) i want able to fiy this for listboxes but fixing this for treeviews might be easier becasue they dont use the gernatic tgenerator implementation.
20160122 00:46:23< gfgtdf> wasn't
20160122 00:46:34< gfgtdf> generic*
20160122 00:55:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 00:55:28< gfgtdf> shadowm, vultraz actually i think that if this can be fixed for treeviews we migth actually use treeviews in the gui2 mo connect dialog insteadof listboxes, since this was afaik ne of the main reaosns against teh gui2 mp lobby.
20160122 00:55:56< gfgtdf> shadowm, vultraz this also gives us a nice was to show the detailed game confiigurations in the gui2 mp lobby
20160122 00:56:17< gfgtdf> shadowm, vultraz where there is currelty not enough space we coudl just ue expandable treview elements
20160122 00:57:51< vultraz> gfgtdf: we should have an option to get rid of the flip arrow though
20160122 00:58:20< gfgtdf> vultraz: which fip arrows?
20160122 00:58:55< vultraz> in tree views
20160122 00:59:02< vultraz> that arrow to the left of the label
20160122 00:59:26< gfgtdf> vultraz: sry still dont uderstand
20160122 00:59:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds]
20160122 01:00:05< gfgtdf> you want to add an options in preferences to change the images of the arrows in the campaoign selection dialog?
20160122 01:00:26< vultraz> no no
20160122 01:00:36< vultraz> I mean the tree view widget should have an option not to show that arrow
20160122 01:00:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 01:01:54< gfgtdf> vultraz: the trevview widgets doents show any arrows
20160122 01:03:32< gfgtdf> vultraz: the arrows in teh capaign dialog are added here: https://github.com/wesnoth/wesnoth/blob/master/data/gui/default/window/campaign_dialog.cfg#L227
20160122 01:03:49< vultraz> ohhh
20160122 01:03:53< vultraz> ok
20160122 01:05:36< vultraz> gfgtdf: if we can figure out how to integrate a treeview and a toggle panel then we can do a lot of good stuff
20160122 01:05:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160122 01:08:51< gfgtdf> vultraz: hmm i thougth we can easily put a togglepanel ina  treeview?
20160122 01:09:03< gfgtdf> vultraz: maybe we coudl even put a treeview ina  togglepanel :)
20160122 01:09:30< vultraz> gfgtdf: basically what we want is a toggle panel that you can click on and it will expand with some stuff
20160122 01:10:08< gfgtdf> vultraz: yes thats the original  usecase that treevies were added for
20160122 01:10:24< gfgtdf> vultraz: you can just replace the togglebutton on the linked lien with a togglepanel
20160122 01:10:31< gfgtdf> vultraz: important is taht teh id stays teh same
20160122 01:10:38< gfgtdf> line*
20160122 01:28:56< gfgtdf> shadowm, vultraz: do we have somtithng like flow layout in gui2?
20160122 01:29:17< vultraz> like what?
20160122 01:29:54< gfgtdf> flowlayoutpanel
20160122 01:31:28< gfgtdf> this is a widget that java and C# applications can use, it contains a list of arbitary widgets and tries to put them in a row and puts them in a next row when there is not enough  space in the current row.
20160122 01:32:54-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160122 01:33:53< shadowm> No.
20160122 01:38:48-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160122 01:41:41< vultraz> gfgtdf: hm that doesn't seem to work
20160122 01:41:51< gfgtdf> vultraz: what is teh error ?
20160122 01:41:58< vultraz> no error it just doesn't work
20160122 01:42:01< vultraz> the node is always expanded
20160122 01:42:07< gfgtdf> vultraz: you tried in campaign selectiosn dialog or in other dialog ?
20160122 01:42:14< vultraz> campaign selection
20160122 01:42:30< gfgtdf> you can show me teh changed code?
20160122 01:44:20< vultraz> http://pastebin.com/SEMNJU37
20160122 01:45:49< gfgtdf> vultraz: hmm maybe its becasue toggle panels have to tree_view_node definition
20160122 01:46:30< vultraz> hmmm
20160122 01:51:36-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Read error: Connection reset by peer]
20160122 01:51:39< gfgtdf> vultraz: wait it was wrong it actualyl requires a togle_butotn it the current form
20160122 01:51:44< gfgtdf> vultraz: this is a bug
20160122 01:51:48-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160122 01:51:49< gfgtdf> vultraz: shodul be easy to fix
20160122 01:55:15< shadowm> Huh, GUI1 menus already have a thinner border.
20160122 01:55:35< vultraz> shadowm: but they have a margin
20160122 01:55:38< shadowm> It's comboboxes that don't.
20160122 01:55:55< gfgtdf> vultraz: hmm for some unkown reason it sets the icon togglebutton to invisible in case the parent node has no icon togglebutton :S
20160122 01:55:55< vultraz> shadowm: notice my gui2 window style doesn't have that weird margin
20160122 01:56:09< shadowm> It's good that they have a margin, because it helps touchscreen users. The bad thing is that the margin is in the wrong place.
20160122 01:56:26< shadowm> It's outside the interactive area rather than around individual items.
20160122 01:56:45< shadowm> (That obviously renders it useless.)
20160122 01:56:53< gfgtdf> ahnno they onyl set the nodes expand icon toinvisible in case it has no childs
20160122 01:56:57< gfgtdf> makes sens i guess
20160122 02:02:08< vultraz> gfgtdf: so currently tree views can't do what we want?
20160122 02:03:03< gfgtdf> vultraz: no but shodul realyl be any easy fix
20160122 02:06:53-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160122 02:07:35-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160122 02:13:33-!- irker621 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160122 02:13:33< irker621> wesnoth: Ignacio R. Morelle wesnoth:master d8a918ddf47d / changelog players_changelog: Move exceptional changelog section to the top, reword bits, sync to p_c https://github.com/wesnoth/wesnoth/commit/d8a918ddf47dfea8de6c558a857f7d8e52651e98
20160122 02:13:34< irker621> wesnoth: Ignacio R. Morelle wesnoth:master e999a1c931bb / changelog src/widgets/combo.cpp: gui: Use thinner menu frame style for combobox menus https://github.com/wesnoth/wesnoth/commit/e999a1c931bbc9fb570c017d535ba3f28d52f3ef
20160122 02:17:02< vultraz> well that was simple 
20160122 02:21:52< irker621> wesnoth: Ignacio R. Morelle wesnoth:1.12 3092ef499b6c / changelog src/widgets/combo.cpp: gui: Use thinner menu frame style for combobox menus https://github.com/wesnoth/wesnoth/commit/3092ef499b6c7a886e9881ccd410a176ee4169a7
20160122 02:36:11-!- gfgtdf [~chatzilla@x55b1a1b5.dyn.telefonica.de] has quit [Ping timeout: 264 seconds]
20160122 02:53:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160122 03:11:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160122 03:11:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160122 03:12:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 03:17:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20160122 03:29:19-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160122 05:09:38-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160122 05:20:11-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160122 05:25:49-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160122 06:02:27-!- Kwandulin [~Miranda@p200300760F6924A7FCB5FC4B2A3DCB12.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160122 06:13:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 06:17:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20160122 06:34:05< vultraz> shadowm: I'm wondering (unrelated to the code issue) maybe we should move some prefs from Advanced. For example, why is Sort Lobby List in MP, but Group Players In Lobby in Advanced (I dunno if there's even a difference). Confirm Deleting Saves could be a dropdown or radio toggle (No/Yes/Only Different Version)
20160122 06:34:07< vultraz> etc etc
20160122 06:35:21< vultraz> some should obviously stay (like Editor Recent File limit)
20160122 06:35:34< vultraz> (And Show All Unit Types)
20160122 06:39:24< vultraz> Whispers from Friends Only is something that would be more useful under MP
20160122 06:39:41< vultraz> say, for someone to block whispers from someone harassing them, etc 
20160122 07:07:46< vultraz> oh, the different version thing is for loading saves
20160122 07:13:12-!- TheJJ [~rofl@ipbcc36ea9.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20160122 07:18:30-!- TheJJ [~rofl@ipbcc36ea9.dynamic.kabel-deutschland.de] has quit [Ping timeout: 260 seconds]
20160122 07:42:57-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160122 07:50:52-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160122 07:54:14-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20160122 07:54:15-!- wedge010 is now known as wedge009
20160122 08:38:37-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160122 08:40:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 08:45:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160122 08:47:07< zookeeper> vultraz, https://forums.wesnoth.org/viewtopic.php?p=593071#p593071 (1)
20160122 09:17:39-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160122 09:22:20-!- TheJJ [~rofl@ipbcc36ea9.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20160122 09:28:19-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160122 09:43:43-!- irker621 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160122 10:20:58-!- atarocch [~atarocch@151.64.69.61] has joined #wesnoth-dev
20160122 10:24:41-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 265 seconds]
20160122 10:29:00-!- Kwandulin [~Miranda@p200300760F6924A7FCB5FC4B2A3DCB12.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160122 10:51:59-!- Kwandulin [~Miranda@p200300760F692421FCB5FC4B2A3DCB12.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160122 10:55:55-!- ypnos [~ypnos@lme51.informatik.uni-erlangen.de] has joined #wesnoth-dev
20160122 10:56:33-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160122 11:03:41-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160122 11:22:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 11:26:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160122 11:30:11-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection timed out]
20160122 11:31:09-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20160122 11:31:09-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20160122 11:31:09-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160122 11:38:00-!- Kwandulin [~Miranda@p200300760F692421FCB5FC4B2A3DCB12.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160122 11:54:25-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20160122 12:12:46-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20160122 12:25:53-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160122 12:27:46-!- ypnos [~ypnos@lme51.informatik.uni-erlangen.de] has quit [Ping timeout: 240 seconds]
20160122 12:35:03-!- ypnos [~ypnos@lme51.informatik.uni-erlangen.de] has joined #wesnoth-dev
20160122 12:35:32-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160122 13:18:46-!- Qudit314159 [~user@unaffiliated/qudit314159] has joined #wesnoth-dev
20160122 13:41:56-!- Kwandulin [~Miranda@p200300760F6924213110A4B018506D4C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160122 13:47:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160122 14:00:59-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160122 14:17:37-!- mjs-de [~mjs-de@f053054049.adsl.alicedsl.de] has joined #wesnoth-dev
20160122 15:05:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160122 15:14:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160122 15:17:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160122 15:33:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160122 15:42:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160122 15:59:40-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20160122 16:03:42-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160122 16:38:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 16:39:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160122 16:40:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 16:41:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: No route to host]
20160122 16:41:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 16:48:11-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 264 seconds]
20160122 16:52:50-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160122 16:56:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160122 16:58:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160122 17:02:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20160122 17:03:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160122 17:05:32-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20160122 17:08:50-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds]
20160122 17:13:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160122 17:15:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160122 17:18:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20160122 17:21:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160122 17:27:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160122 17:34:24-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160122 17:34:25-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160122 17:34:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160122 17:39:45-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 260 seconds]
20160122 17:41:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160122 17:43:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160122 18:03:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 18:11:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160122 18:13:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20160122 18:14:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160122 18:14:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160122 18:19:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160122 18:20:43-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20160122 18:20:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160122 18:21:10-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Ping timeout: 260 seconds]
20160122 18:24:22-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20160122 18:28:30-!- prkc [~prkc@51B78693.dsl.pool.telekom.hu] has joined #wesnoth-dev
20160122 18:28:49-!- prkc [~prkc@51B78693.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20160122 18:29:35-!- Qudit314159 [~user@unaffiliated/qudit314159] has quit [Ping timeout: 240 seconds]
20160122 18:33:07-!- prkc [~prkc@51B78693.dsl.pool.telekom.hu] has joined #wesnoth-dev
20160122 18:36:51-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160122 18:37:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 18:46:06-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20160122 18:59:26-!- {V} [~V@105-70-ftth.on.nl] has quit [Ping timeout: 265 seconds]
20160122 19:00:06-!- {V} [~V@105-70-ftth.on.nl] has joined #wesnoth-dev
20160122 19:12:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160122 19:15:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 19:28:57-!- ancestral [~ancestral@63.236.20.2] has joined #wesnoth-dev
20160122 19:29:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160122 19:34:40-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20160122 19:35:21< Elvish_Hunter> Hi all
20160122 19:36:53< Elvish_Hunter> Since I received no comments on PR #582, I'm going to merge it.
20160122 19:37:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160122 19:38:15-!- irker526 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160122 19:38:15< irker526> wesnoth: Elvish_Hunter wesnoth:master d873695b5f5b / data/tools/wmllint-1.4: wmllint-1.4: replaced calls to vcmove() with os.rename() https://github.com/wesnoth/wesnoth/commit/d873695b5f5bb97f8ae30b27400f6c54ad3e30e6
20160122 19:38:15< irker526> wesnoth: Elvish_Hunter wesnoth:master 266bfee1ff32 / data/tools/wmlmove: removed wmlmove script https://github.com/wesnoth/wesnoth/commit/266bfee1ff322c4bc2ed17c9a5ce9583c123d6bf
20160122 19:38:15< irker526> wesnoth: Elvish_Hunter wesnoth:master 79f6b4d48304 / data/tools/wesnoth/ (wmltools.py wmltools3.py): wmltools: removed broken version control hooks https://github.com/wesnoth/wesnoth/commit/79f6b4d483043b39b0782e92425d085eb50f1bb5
20160122 19:38:16< irker526> wesnoth: Elvish-Hunter wesnoth:master 48459baff403 / data/tools/ (wesnoth/wmltools.py wesnoth/wmltools3.py wmllint-1.4 wmlmove): Merge pull request #582 from Elvish-Hunter/python_vc_removal https://github.com/wesnoth/wesnoth/commit/48459baff4038f6317564ec2bcfb7abaa12c9feb
20160122 19:47:10< irker526> wesnoth: Elvish_Hunter wesnoth:master 9d12141ab368 / changelog data/tools/README data/tools/wmlscope: changelog and documentation entries about wmlmove removal https://github.com/wesnoth/wesnoth/commit/9d12141ab368ea70382a324e05a0f90d9edea488
20160122 19:48:35-!- ancestral [~ancestral@63.236.20.2] has quit [Quit: i go nstuf kthxbai]
20160122 19:49:23< Elvish_Hunter> BTW, there's also this line in projectfiles/CodeLite/wesnoth.project:
20160122 19:49:42< Elvish_Hunter> <File Name="../../data/tools/wmlmove"/>
20160122 19:50:52-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160122 19:52:17< Elvish_Hunter> Since I don't know its purpose, I left it there. If someone uses CodeLite, can you please confirm if that line can be safely removed?
20160122 19:53:35-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20160122 19:53:35-!- wedge010 is now known as wedge009
20160122 19:56:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 20:08:58-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160122 20:13:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160122 20:23:48-!- atarocch_ [~atarocch@151.64.72.94] has joined #wesnoth-dev
20160122 20:24:15< zookeeper> umm. 4 commits from "Elvish_Hunter", 1 commit from "Elvish-Hunter"..?
20160122 20:28:02-!- atarocch [~atarocch@151.64.69.61] has quit [Ping timeout: 276 seconds]
20160122 20:35:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 20:37:24< vultraz> shadowm: I noticed the ttext class (src/gui/auxiliary/canvas.cpp) uses decode_font_style() for its font_style_ member, and that functions returns SDL_TTF style macros.
20160122 20:40:47< vultraz> shadowm: and the tresolution_definition_ class also seems to use decode_font_style(). Am I missing something here?
20160122 20:41:46< vultraz> I thought GUI2 wasn't supposed to use SDL_TTF 
20160122 20:46:05< Elvish_Hunter> zookeeper: they're all mine. When I registered (2013), GitHub didn't allow underscores in usernames, so I had to replace it with a dash.
20160122 20:50:10< zookeeper> sure, but it's still erratic irker (?) behavior.
20160122 20:59:23-!- gfgtdf [~chatzilla@x50abdc16.dyn.telefonica.de] has joined #wesnoth-dev
20160122 21:17:14-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has quit [Remote host closed the connection]
20160122 21:28:32< vultraz> Elvish_Hunter: why not just "Elvish Hunter" 
20160122 21:30:53< irker526> wesnoth: gfgtdf wesnoth:master 8b32fc20abd9 / src/gui/widgets/ (listbox.cpp listbox.hpp scrollbar_container.cpp scrollbar_container.hpp): Attempt to fix listbox scrollbar position after content changes. https://github.com/wesnoth/wesnoth/commit/8b32fc20abd935e1354627b85ec6808ee38cad2d
20160122 21:30:55< irker526> wesnoth: gfgtdf wesnoth:master 58b769192efd / src/gui/widgets/ (tree_view.cpp tree_view.hpp tree_view_node.cpp tree_view_node.hpp): fix gui2 treeviews resetting position when items expand https://github.com/wesnoth/wesnoth/commit/58b769192efd0907fef7d0b37b1d1ddf1a04e11a
20160122 21:30:57< irker526> wesnoth: gfgtdf wesnoth:master 7e6d7d4099b4 / src/gui/widgets/ (tree_view_node.cpp tree_view_node.hpp): make treeviws accept toggle_panels too https://github.com/wesnoth/wesnoth/commit/7e6d7d4099b4fe008354daccede5d1091977b626
20160122 21:31:00< irker526> wesnoth: gfgtdf wesnoth:master d90d76be4df3 / src/gui/widgets/ (combobox.cpp combobox.hpp): remove _tclickable form combobox https://github.com/wesnoth/wesnoth/commit/d90d76be4df3e3fe8e17451519d1b664c24bf51b
20160122 21:31:07< gfgtdf> vultraz: ^
20160122 21:34:11< vultraz> :D
20160122 21:35:34-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160122 21:39:53-!- Kwandulin [~Miranda@p200300760F6924213110A4B018506D4C.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160122 21:45:50< vultraz> gfgtdf: it's not 100% working. in the campaign dialog at least I can click the toggle panel but the options don't disappear until you scroll the list of campaigns up and back down, and even then the space is still reserved :/
20160122 21:47:10< gfgtdf> vultraz: whcih part is not working? The reset scrollbat to mke togglepanels work ?
20160122 21:48:52< gfgtdf> s/to/or
20160122 21:49:17< vultraz> I think so 
20160122 21:49:26< vultraz> yeah, that makes sense 
20160122 21:51:00< gfgtdf> vultraz: i tested it and it works for me
20160122 21:51:14< vultraz> hm
20160122 21:51:20< vultraz> can i see your testcase 
20160122 21:51:23< vultraz> maybe im doing it wrong
20160122 21:52:03< gfgtdf> vultraz: does it work for you in campaign menu no changes to the cfg file ?
20160122 21:52:04< vultraz> hmmm
20160122 21:52:39< vultraz> gfgtdf: yes
20160122 21:53:02< vultraz> works perfectly with no changes 
20160122 21:53:12< vultraz> and the scrollbar position thing is also fixed 
20160122 22:00:12< shadowm> vultraz: That doesn't mean anything, only that he reused macros from SDL_ttf.
20160122 22:00:25< gfgtdf> vultraz: i just noticed you you cannot click anything during the titlescrren amimation
20160122 22:00:38< shadowm> I'd guess that's because GUI2 did originally use SDL_ttf.
20160122 22:01:32< shadowm> The Group Players in Lobby option applies only to the GUI2 version IIRC.
20160122 22:01:52< shadowm> I don't see why Confirm Deleting Saves should have more than two states.
20160122 22:02:38< shadowm> I got at least one developer in the past to admit that they were stashing options under Advanced because they couldn't be bothered to deal with all the code needed to place them anywhere else.
20160122 22:02:54< vultraz> :| 
20160122 22:03:27< shadowm> And that's partly why I don't trust coders to design UIs.
20160122 22:03:36< vultraz> gfgtdf: what animation? it hasn't worked for years 
20160122 22:04:21< shadowm> They tend to take the least-effort route without any regard to usability.
20160122 22:04:49< gfgtdf> vultraz: hmm them maybe 'not working' menat exactly that
20160122 22:05:29< celticminstrel> Why is vultraz complaining about Elvish_Hunter but not about me?
20160122 22:06:05< celticminstrel> Most of my commits are "Celtic Minstrel" while merge commits from PRs are "Celtic_Minstrel".
20160122 22:06:08< celticminstrel> :P
20160122 22:06:36< vultraz> oh?
20160122 22:06:39< vultraz> I haven't noticed 
20160122 22:07:22< vultraz> shadowm: yeah, confirm deleting saves doesn't need more than 2 states. I misread. 
20160122 22:08:00< shadowm> Yeah would be nice if you people could get your author identification sorted out so it doesn't change all the time.
20160122 22:08:52< celticminstrel> It's not that it changes all the time, just that github sets it differently than local git.
20160122 22:09:16< shadowm> https://github.com/settings/emails <- Add any address as necessary and set it to primary
20160122 22:09:34< shadowm> https://github.com/settings/profile <- Set your name to match whatever your Git client is set to use
20160122 22:09:41< shadowm> It's not rocket science.
20160122 22:10:04-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 250 seconds]
20160122 22:10:11< celticminstrel> Oh, I thought github just used your username.
20160122 22:10:53< gfgtdf> vultraz: ok i was now also able to observe that new bug with logglepanels in treevies
20160122 22:11:20< gfgtdf> vultraz: seems to me one of these 'onyl wokrs when you click directly on the panel, doenst work when you click on teh label' things.
20160122 22:11:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160122 22:12:06< vultraz> gfgtdf: can confirm 
20160122 22:13:38< vultraz> gfgtdf: seems to me toggle panels should inherit click events from child widgets 
20160122 22:14:04< gfgtdf> vultraz: y they do usually, don'T know why this is not that case in here.
20160122 22:14:14< vultraz> :(
20160122 22:15:08< vultraz> celticminstrel: what happens if you pass null to a function pointer argument?
20160122 22:15:20< shadowm> Nothing.
20160122 22:15:27< shadowm> If you call it? Well, it should throw an exception IIRC.
20160122 22:15:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160122 22:15:49< celticminstrel> Not sure it's an exception, but definitely not a good thing.
20160122 22:15:59< shadowm> } catch(boost::bad_function_call& /*e*/) {
20160122 22:16:15< celticminstrel> Oh, that's if you pass it to a boost::function argument.
20160122 22:16:29< celticminstrel> With a bare function pointer it'd be different.
20160122 22:16:34< celticminstrel> Why do you want to pass null?
20160122 22:16:52< shadowm> Nothing would happen in that case either, if you assigned a null pointer to it.
20160122 22:17:01< vultraz> Was just wondering if I could pass null and then say if setter == NULL then dosomething else setter()
20160122 22:17:03< shadowm> Now, if you called it? Horrible things.
20160122 22:17:15< shadowm> Guaranteed to be a crash on a modern OS.
20160122 22:17:20< celticminstrel> vultraz: I don't understand what you're saying.
20160122 22:18:55< vultraz> celticminstrel: if I have a function that accepts a function pointer as a argument, can I check if the function pointer is null, and if it is do something, but if it's not, call the function passed.
20160122 22:19:26< celticminstrel> Of course you can.
20160122 22:19:51< celticminstrel> Sorry, I didn't realize you were writing the function that takes a function pointer argument.
20160122 22:20:08< celticminstrel> (Of course, it's still best to take boost::function rather than a bare pointer.)
20160122 22:20:08< vultraz> And I don't need nullptr? 
20160122 22:20:20< celticminstrel> No, just if(fcn)
20160122 22:20:30< vultraz> Ok, thanks
20160122 22:20:42< vultraz> Just wanted to make sure, since I've heard bad things about null pointers :P
20160122 22:21:40< celticminstrel> Uh.
20160122 22:21:43< celticminstrel> What sort of bad things?
20160122 22:21:53< Elvish_Hunter> Null pointers are used pretty much all the time. Maybe you heard bad things about *void pointers*...
20160122 22:23:35< shadowm> There's nothing inherently bad about null pointers unless you try to dereference them.
20160122 22:24:19< shadowm> Or calling them, if it may be the case.
20160122 22:33:25< gfgtdf> vultraz: im curremtly lookimng into that an i got the imporeassion that this is a bug in the gui2 event chain.
20160122 22:33:52< vultraz> oh crap
20160122 22:35:48< gfgtdf> vultraz: hmm wauit maybe not
20160122 22:37:55< gfgtdf> shadowm: do you know what tdispatcher::has_event exactly does ?
20160122 22:39:43-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has left #wesnoth-dev ["Ciao!"]
20160122 22:40:10-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160122 22:40:30< shadowm> Don't ask me about anything involving the GUI2 event processing chain.
20160122 22:46:54< irker526> wesnoth: gfgtdf wesnoth:master b850f0b0ac1d / src/gui/widgets/tree_view_node.cpp: fix treeviewnodes with toggle_panels https://github.com/wesnoth/wesnoth/commit/b850f0b0ac1d89945c9f1324c162b7da97e19a34
20160122 22:47:01< gfgtdf> vultraz: ^
20160122 22:51:13< vultraz> gfgtdf: that fixes it but the selection states are backwards. if you select the toggle panel the node closes, if you deselect it it opens 
20160122 22:51:35< gfgtdf> vultraz: i iirc it was always like that
20160122 22:51:46< gfgtdf> s/i/i know
20160122 22:52:01< vultraz> i think it should be an easy fix
20160122 22:52:29< gfgtdf> vultraz: meanign thid was also the cae when these were toglge buttons that the'toggeled' state closed the node.
20160122 22:53:31< gfgtdf> vultraz: i assumes this was intentional
20160122 22:54:45< gfgtdf> vultraz: ypou can change it here: https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/tree_view_node.cpp#L211 but be sure also to change teh images of the treeviewnode togglebutonn definition accorungly
20160122 22:54:48< vultraz> maybe but it's not the rightbehavior 
20160122 22:55:42< vultraz> ok
20160122 22:57:55< vultraz> hm
20160122 22:58:15< vultraz> gfgtdf: I changed it to icon_ && !icon_->get_value() and wesnoth asserts :/
20160122 23:08:42< vultraz> grid.cpp:477
20160122 23:08:56< vultraz> according the comment you're not even supposed to reach that
20160122 23:10:07< vultraz> and if i remove the assert nothing happens :|
20160122 23:13:37< vultraz> gfgtdf: I don't understand this  
20160122 23:28:42-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20160122 23:55:00< gfgtdf> vultraz: hmm only froem chanign that line it fails in grid.cpp ?
20160122 23:55:32< vultraz> gfgtdf: yes
20160122 23:55:34< gfgtdf> vultraz: from*
20160122 23:56:35< gfgtdf> vultraz: ad initlisation or when you open a node?
20160122 23:56:43< vultraz> when you open
20160122 23:56:53< vultraz> ie, on clicking the toggle panel
20160122 23:57:36< gfgtdf> vultraz: hmm maybe its somethign like previousl all noded defaulted to 'open' while thry now default to 'closed' so that they the initily size is not smaller than before so that there is not enough space when you opena  node
20160122 23:59:34< gfgtdf> vultraz: happend on titlescreen?
20160122 23:59:44< vultraz> what?
--- Log closed Sat Jan 23 00:00:00 2016