--- Log opened Sun Jan 24 00:00:18 2016
20160124 00:04:03< gfgtdf> vultraz: well i think it hapen for teh same rason why teh nodes dont appear.
20160124 00:12:36< shadowm> elias: Could you take a look at /home/wesnoth/log/addon-list-1.12 on the web server container? (I think you have access.)
20160124 00:13:35< shadowm> I don't know what to make of it other than that it's obviously broken.
20160124 00:15:02< shadowm> And apparently has been in some fashion since at least December 21st.
20160124 00:15:49-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20160124 00:26:42-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20160124 00:49:10< vultraz> gfgtdf: hmmm sounds promising. 
20160124 00:54:06-!- irker639 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160124 00:59:51< gfgtdf> vultraz: i just said i was able to rperoduce it, i didnt promose anything.
20160124 01:00:29< vultraz> gfgtdf: I meant the part where you said "i think another solutio mist be to calculate the size of the node in the unfold function in case it wasnt calculated yet" 
20160124 01:01:57< gfgtdf> vultraz: ah yes i think the preoblem is the here: https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/tree_view_node.cpp#L572 were we increase the panel, the size of the node might not be caulated yet if it was folded at the beginning
20160124 01:02:09< gfgtdf> vultraz: we we shoudl somehow add a call to caluclate teh size there
20160124 01:02:37< vultraz> but there's a call to get_unfolded_size
20160124 01:02:55< vultraz> oh I think I understand 
20160124 01:03:24< gfgtdf> vultraz: y but that just returns the stores size (0 if it wasnt calulated yet) if i understodd the code correctly
20160124 01:03:36< vultraz> ahh
20160124 01:03:38< vultraz> ok
20160124 01:03:59< vultraz> so maybe we can check if it is 0 and if so then calculate the size?
20160124 01:04:24< vultraz> calculate_best_size maybe
20160124 01:04:54< gfgtdf> vultraz: y that would be a try
20160124 01:07:21< gfgtdf> vultraz: something like twidget::set_size calculate_best_size
20160124 01:07:57< gfgtdf> vultraz: but we need to wantch out for the case where horiznal scrollbars are disabled, in which we cannot go over teh currnet size.
20160124 01:11:08< vultraz> true 
20160124 01:11:16< vultraz> but doesn't calculate_best_size already handle that
20160124 01:11:26< vultraz> or if it doesn't, shouldn't it
20160124 01:14:38-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds]
20160124 01:18:22< gfgtdf> vultraz: hmm wel at lest grid_->chmm right i think i v overseen somerthing
20160124 01:29:58< gfgtdf> vultraz: hmm what happens if you replace this: https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/tree_view_node.cpp#L376 with a grid_.get_best_size() ?
20160124 01:36:48-!- gfgtdf [~chatzilla@f054145212.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.4/20160105164030]]
20160124 01:43:20< vultraz> gfgtdf: that fixes the bug completely  :D
20160124 01:43:46< vultraz> gfgtdf: you're a genius 
20160124 01:45:41-!- ancestral [~ancestral@64.sub-70-197-198.myvzw.com] has joined #wesnoth-dev
20160124 02:06:56-!- ancestral [~ancestral@64.sub-70-197-198.myvzw.com] has quit [Quit: i go nstuf kthxbai]
20160124 02:07:30-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160124 02:11:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 272 seconds]
20160124 02:11:33-!- wedge010 is now known as wedge009
20160124 02:24:07-!- prkc [~prkc@51B78693.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20160124 02:35:40< vultraz> gfgtdf: hmmm actually there seems to be a problem. that fixes the bug for using a toggle panel but if i revert back to the toggle button in the campaign dialog the assert comes back :/
20160124 02:35:45< vultraz> and it doesn't work
20160124 02:35:51< vultraz> but it works fine with the toggle panel
20160124 02:38:19-!- mx6523 [~mx6523@104-137-14-252.res.bhn.net] has joined #wesnoth-dev
20160124 02:50:27< Aginor> g'day
20160124 02:58:13< vultraz> hey
20160124 02:58:15< vultraz> :D
20160124 03:01:35< vultraz> Aginor: are you back with more guifixes?
20160124 03:08:36-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160124 03:36:15-!- mjs-de [~mjs-de@f049233121.adsl.alicedsl.de] has quit [Remote host closed the connection]
20160124 03:48:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160124 03:59:37-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20160124 04:37:22< Aginor> vultraz: I'm back, and I think I have some spare time again
20160124 04:38:15-!- mx6523 [~mx6523@104-137-14-252.res.bhn.net] has quit [Quit: TripSit Bundled Portable Hexchat 20140612]
20160124 04:58:12< vultraz> Aginor: ahh nice nice :D
20160124 04:58:46< vultraz> Aginor: anything you want me to do?
20160124 05:01:35-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160124 05:02:16-!- Keen_ [b4fff8d2@gateway/web/freenode/ip.180.255.248.210] has joined #wesnoth-dev
20160124 05:05:55< vultraz> celticminstrel: could I trouble you for a menial task? A New Land uses the deprecated MENU_IMG_TXT[2] macros a lot - perhaps you could convert them to the new DescriptionWML syntax?
20160124 05:05:58< vultraz> or should I do it
20160124 05:06:42-!- Keen_ [b4fff8d2@gateway/web/freenode/ip.180.255.248.210] has quit [Ping timeout: 252 seconds]
20160124 05:07:55< celticminstrel> A New Land?
20160124 05:14:08< aeth> celticminstrel: A multiplayer scenario by Bob the Mighty that got mainlined.
20160124 05:14:24< celticminstrel> Ah.
20160124 05:14:36< celticminstrel> I can look into it.
20160124 05:16:28< aeth> It's kind of like an RTS (besides the lack of being real time). You build stuff.
20160124 05:16:44< aeth> So it's basically a bunch of terrain transformations via right click menus.
20160124 05:17:40-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20160124 05:21:31< celticminstrel> Huh. Something like that got mainlined?
20160124 05:22:44< shadowm> ...
20160124 05:27:45< aeth> A long time ago
20160124 05:28:19< celticminstrel> Was it in 1.10?
20160124 05:28:23< aeth> March 2008. https://github.com/wesnoth/wesnoth/commits/master/data/multiplayer/scenarios/4p_A_New_Land.cfg
20160124 05:29:16< shadowm> 1.5.0.
20160124 05:29:22< aeth> 1.5.0-svn
20160124 05:29:24< celticminstrel> Guess so.
20160124 05:29:46< celticminstrel> I must've seen it when looking through the list of scenarios, then.
20160124 05:29:53< celticminstrel> But I don't remember. Oh well.
20160124 05:29:57< aeth> I went to the changelog file of the first commit that contains 4p_A_New_Land.cfg if you want to double check my source. https://github.com/wesnoth/wesnoth/blob/50d48d6747beea76948b06eba8fae82354a2cbe5/changelog
20160124 05:30:11< shadowm> I went to this page: https://github.com/wesnoth/wesnoth/commit/50d48d6747beea76948b06eba8fae82354a2cbe5
20160124 05:30:23< shadowm> Then saw that the earliest tag is 1.5.0.
20160124 05:30:36< aeth> ah
20160124 05:30:53< aeth> so we went to the same page, but went to different places from there
20160124 05:31:14< shadowm> I wouldn't use "1.5.0-svn" as a version for this purpose. Technically you can push all kinds of crap between releases and that doesn't make it officially part of mainline.
20160124 05:31:44< shadowm> For example, right now I could push IftU and then push its removal, and the net effect is that it's still not in mainline.
20160124 05:42:35-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160124 05:44:30-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20160124 05:44:31-!- wedge010 is now known as wedge009
20160124 06:15:15< Aginor> vultraz: not right now, but thanks for the offer
20160124 06:30:53 * Aginor complains about the heat
20160124 06:52:24-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160124 06:52:51-!- Kwandulin [~Miranda@p200300760F6924F11917890EB1C61077.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160124 06:58:07< vultraz> gfgtdf: actually I think that might be a bug with toggle buttons
20160124 06:58:43< vultraz> gfgtdf: the toggle button only doesn't like the !icon_->get_value() bit
20160124 06:59:27< vultraz> gfgtdf: the toggle button in the tree view*
20160124 06:59:52< vultraz> or maybe becase the toggle panel already gives a good size
20160124 06:59:54< vultraz> im not sure
20160124 07:01:50< vultraz> gfgtdf: what I mean is that changing get_size to get_best_size in get_folded_size() doesn't affect the toggle button - it will not work as long as get_folded() is set to !icon_->get_value()
20160124 07:23:49< vultraz> gfgtdf: here's the callstack for the assert with the toggle button http://pastebin.com/Jqu0c21U
20160124 07:41:02< vultraz> gfgtdf: HM ok I removed the assert in grid.cpp and it seems that the toggle button does work, but a long mod name will cause that row not to show up
20160124 07:41:23< vultraz> so basically this
20160124 07:41:25< vultraz> [10:50:32]	gfgtdf	vultraz: ok i was now abale to reproduce teh crash y adding [modification] with a very long name
20160124 07:42:50< vultraz> gfgtdf: if I revert get_best_size back to get_size in get_folded_size() none of the mods show up at all
20160124 07:43:10< vultraz> gfgtdf: so I think this has something to do with the space allocated by the parent widget 
20160124 07:46:20< vultraz> gfgtdf: ok confirmed. if I make tree_view_node_label  very long then all mod names appear 
20160124 08:06:31< vultraz> got it 
20160124 08:07:44< vultraz> grid_ is too small
20160124 08:09:45< vultraz> it's only as big as the maximum size of tree_view_node_icon + tree_view_node_label
20160124 08:11:02< vultraz> so get_best_size fixes the problem for a toggle panel because that fills the column
20160124 08:13:08-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160124 08:15:03-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160124 08:16:59< vultraz> not sure how to fix this
20160124 08:21:01-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160124 08:33:53-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160124 08:33:54-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160124 08:34:35-!- irker862 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160124 08:34:36< irker862> wesnoth: Charles Dang wesnoth:master 16a1ffc5ede8 / src/gui/widgets/tree_view_node.cpp: ttree_view_node: get best size when querying folded node size https://github.com/wesnoth/wesnoth/commit/16a1ffc5ede8f37097f8124c017359eea49f99c5
20160124 08:34:38< irker862> wesnoth: Charles Dang wesnoth:master 264bbb52fadb / src/gui/widgets/tree_view_node.cpp: ttree_view_node: make 'folded' correspond to a unselected toggle widget https://github.com/wesnoth/wesnoth/commit/264bbb52fadbcf57f9de3cdbd91411aecd727f48
20160124 08:34:41< irker862> wesnoth: Charles Dang wesnoth:master c35433a67ced / src/gui/widgets/ (tree_view_node.cpp tree_view_node.hpp): ttree_view_node: renamed a class member variable https://github.com/wesnoth/wesnoth/commit/c35433a67cede22e0080fcd8cf810c70511a41c9
20160124 08:34:44< irker862> wesnoth: Charles Dang wesnoth:master e4d42dc883fe / data/gui/default/widget/toggle_button_tree_view_node.cfg: Swap order of tree view toggle button images https://github.com/wesnoth/wesnoth/commit/e4d42dc883fed23a2664740a9e1c8d1e0c1ba9d7
20160124 08:34:47< vultraz> gfgtdf: I pushed the progress we have so far ^
20160124 08:35:05< vultraz> gfgtdf: so we just have to fix the grid size issue
20160124 08:35:55-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160124 08:36:49< vultraz> but since toggle panels now work I can move ahead with work on Advanced Preferences in the meantime 
20160124 08:41:42< vultraz> I haven't tried a 'stack' of tree view nodes, though 
20160124 08:41:47< vultraz> Hopefully it will work
20160124 08:51:45-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160124 08:53:54< vultraz> Holy. Shit. 
20160124 08:53:59< vultraz> It's actually working
20160124 08:54:01< vultraz> !
20160124 08:55:13< vultraz> I haven't gotten to the dynamic widget states yet, but this is a huge start
20160124 09:01:35< vultraz> I wonder, though
20160124 09:03:03< vultraz> hmmmm
20160124 09:04:11< vultraz> gfgtdf: is it possible to make the previously selected node close when you select another one?
20160124 09:15:08< vultraz> shadowm: https://www.dropbox.com/s/wspasarbaduovgx/prefs_advanced_WIP_for_shdowm.PNG?dl=0
20160124 09:16:02< vultraz> shadowm: please tell me if this design is acceptable. Personally I would rather the toggle panel could expand to include the details, but I'm not sure that's possible yet
20160124 09:16:28< vultraz> shadowm: (so that the label plus the expanded area would be in one selection)
20160124 10:04:53< Necrosporus> vultraz, I do not like this 
20160124 10:05:17< vultraz> Necrosporus: elaborate 
20160124 10:05:18< Necrosporus> is it for small screen which cannot have [x] thing in same line?
20160124 10:05:36< Necrosporus> vultraz, `[x] no`
20160124 10:05:53< Necrosporus> It is confusing
20160124 10:07:43< Necrosporus> use `[x] Accept whispers from friends only` instead
20160124 10:14:37< vultraz> Necrosporus: yes, maybe you're right
20160124 10:25:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160124 10:29:11-!- Kwandulin [~Miranda@p200300760F6924F11917890EB1C61077.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
20160124 10:37:24-!- Kwandulin [~Miranda@p200300760F6924AB1917890EB1C61077.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160124 11:13:30-!- mjs-de [~mjs-de@f048021190.adsl.alicedsl.de] has joined #wesnoth-dev
20160124 11:36:00-!- irker862 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160124 12:02:52-!- clavii [~clavi@163.172.10.77] has joined #wesnoth-dev
20160124 12:04:45-!- irker666 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160124 12:04:45< irker666> wesnoth: ln-zookeeper wesnoth:master 597ca071c415 / / (21 files in 4 dirs): Updated Adobe Village and new Ruined Adobe Village, from doofus-01 https://github.com/wesnoth/wesnoth/commit/597ca071c4154abef3112568d6b13b10305074c5
20160124 12:05:35-!- clavi [~clavi@163.172.10.77] has quit [Ping timeout: 264 seconds]
20160124 12:14:44-!- Appleman1234 [~Appleman1@KD119104012001.au-net.ne.jp] has joined #wesnoth-dev
20160124 12:21:00-!- mjs-de [~mjs-de@f048021190.adsl.alicedsl.de] has quit [Remote host closed the connection]
20160124 12:37:59-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160124 12:41:00-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160124 12:45:58 * vultraz is using so much dynamic_cast
20160124 12:48:08-!- prkc [~prkc@51B78693.dsl.pool.telekom.hu] has joined #wesnoth-dev
20160124 12:48:43< loonycyborg> at least not reinterpret_cast :P
20160124 13:07:22< vultraz> derp
20160124 13:07:29< vultraz> no wonder I was getting segfaults 
20160124 13:07:36< vultraz> I was casting a null pointer to itself
20160124 13:07:38< vultraz> :|
20160124 13:10:05-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160124 13:13:41< vultraz> yeess
20160124 13:13:50< vultraz> dynamic widget swapping working
20160124 13:14:41< vultraz> I am awesome 
20160124 13:20:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160124 13:43:48-!- Kwandulin [~Miranda@p200300760F6924AB1917890EB1C61077.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160124 14:07:13-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160124 14:07:32-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160124 14:09:30-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20160124 14:09:31-!- wedge010 is now known as wedge009
20160124 14:41:51-!- Kwandulin [~Miranda@p200300760F6924AB3C6F5D53324D0AE5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160124 14:45:54< vultraz> shadowm: https://www.dropbox.com/s/19b93ufo8jorhmb/prefs_advanced_WIP_for_shdowm2.PNG?dl=0
20160124 14:45:58< vultraz> also Necrosporus 
20160124 15:03:11-!- midzer [~quassel@p4FFCE8C5.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160124 15:04:48-!- irker666 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160124 15:08:35-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20160124 15:10:29< vultraz> gfgtdf: ok regarding my question about closing nodes it doesn't seem possible since ttree_view_node::fold() and unfold() aren't implemented 
20160124 15:20:25-!- midzer [~quassel@p4FFCE8C5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160124 15:23:23< Ravana_> what the auto open whisper windows setting means?
20160124 15:23:55< vultraz> I don't know
20160124 15:24:00< vultraz> I think it has to do with the gui2 lobby
20160124 15:36:43-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160124 15:57:14-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160124 16:10:19< vultraz> celticminstrel: question: https://stackoverflow.com/questions/2152986/effective-way-to-get-the-index-of-an-iterator is "it" just referring to the iterator? 
20160124 16:15:07-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20160124 16:15:33-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160124 16:15:45< celticminstrel> Yes.
20160124 16:16:18< shadowm> vultraz: What's with the break in the background?
20160124 16:16:50< celticminstrel> ?
20160124 16:17:27< shadowm> Screenshot.
20160124 16:17:43< vultraz> shadowm: this is implemented with a tree view with two nodes, the first with a toggle panel containing the checkbox/name/value, and the other the widget
20160124 16:17:54< vultraz> tree view nodes do not get the background toggle panels do
20160124 16:18:17< vultraz> I would have liked, as I said above, to make the entire thing encompassed by the toggle panel, but I don't know if that's possible
20160124 16:18:28< vultraz> another solution would be to give tree nodes the same background
20160124 16:18:54< shadowm> It'd doable but it'll look inconsistent when crap is selected.
20160124 16:20:14< shadowm> 's
20160124 16:21:06< vultraz> doable to put the widget in the panel?
20160124 16:21:33< shadowm> No, to fake the background for non-toggle panel nodes to look like unselected toggle panels.
20160124 16:22:12< shadowm> I mean... I guess it's not a big difference right now since the screenshot shows exactly what happens when the toggle panel node is selected.
20160124 16:27:18< vultraz> Alright, I'll try it out
20160124 16:27:26< vultraz> Besides that, any comments on the design
20160124 16:29:23< shadowm> Not really.
20160124 16:30:10< vultraz> Alright
20160124 16:32:07< vultraz> shadowm: BTW, what did you say the equivalent of std::stoi was again? 
20160124 16:32:27< celticminstrel> boost::lexical_cast<int> should work.
20160124 16:32:45< celticminstrel> Is that what utils::str_cast does too? Or was that the reverse?
20160124 16:32:48< shadowm> src/util.hpp.
20160124 16:33:08< shadowm> I'm still not a fan of forcing Boost and its ridiculously fat headers upon everything.
20160124 16:35:49< shadowm> If you can't parse it yourself, lexical_cast<To, From>() converts the operand of type From to type To. str_cast<From>() is equivalent to lexical_cast<std::string, From>(), should be self-explanatory.
20160124 16:37:01< shadowm> Several of the (thankfully not inline) specializations use strtol() for this purpose.
20160124 16:37:41< celticminstrel> Also you don't actually need to specify From since the compiler detects it automatically.
20160124 16:37:59< vultraz> I figured it out 
20160124 16:38:02< celticminstrel> So yeah, str_cast is the reverse of stoi.
20160124 16:40:14< vultraz> shadowm: also, adding color to the background of tree views won't work. There's transparency in the draw colors :|
20160124 16:40:31< vultraz> "0, 0, 0, 89"
20160124 16:40:46< vultraz> meaning they overlap with the toggle panel colors and become too dark
20160124 16:41:47< vultraz> And, AFAIK, there is no way around that particular issue
20160124 16:42:26< vultraz> I thought the backgrounds were drawn to a specific color, not an opacity offset 
20160124 16:43:17< celticminstrel> That is a specific colour - black.
20160124 16:43:32< celticminstrel> Translucent black, but still black.
20160124 16:44:39-!- Mic_ [4f420610@gateway/web/freenode/ip.79.66.6.16] has joined #wesnoth-dev
20160124 16:44:57< Mic_> Hello?
20160124 16:45:09< vultraz> hello
20160124 16:45:32< Mic_> What do you do exactly?
20160124 16:45:41< vultraz> I'm a developer on the project 
20160124 16:45:47< shadowm> 13:21:34 <shadowm> No, to fake the background for non-toggle panel nodes to look like unselected toggle panels.
20160124 16:45:57< Mic_> What do I do if I want to help?
20160124 16:45:57< shadowm> vultraz: I didn't say to fake the background of the tree view.
20160124 16:46:24< vultraz> Mic_: there's a getting started link in the topic 
20160124 16:46:46< Mic_> Thanks.
20160124 16:47:01< vultraz> shadowm: there's no separate widget for a tree node 
20160124 16:47:03< vultraz> well
20160124 16:47:05< vultraz> no WML widget
20160124 16:47:10< vultraz> code
20160124 16:47:12< vultraz> that is
20160124 16:47:31< shadowm> vultraz: You could use a panel.
20160124 16:48:34< vultraz> As in, put the non-toggle node in a panel and add the background color to panels?
20160124 16:49:04< shadowm> A panel is a styled grid, essentially.
20160124 16:50:21< vultraz> But it does not take the place of a grid, right
20160124 16:50:31< shadowm> It's a styled grid.
20160124 16:50:42< shadowm> You can look at the title screen for an example.
20160124 16:50:54< shadowm> e.g. line 99.
20160124 16:51:22< vultraz> Ok, it still goes in the grid->row->column layout
20160124 16:51:27< vultraz> That's what I was wondering
20160124 16:51:37< vultraz> whether panels became panel->row->column 
20160124 16:52:27< shadowm> I think that really depends on the parent widget.
20160124 16:52:51< shadowm> For example, listboxes only accept toggle_panel and toggle_button children and forbid anything else.
20160124 16:53:10< shadowm> (Or something like that, it's been a while.)
20160124 16:56:32< vultraz> shadowm: doesn't work either, since the panel doesn't extend over the tree view's node indentation 
20160124 16:57:05< shadowm> There is a node indentation? Oh well.
20160124 16:57:19< vultraz> You can turn it off
20160124 16:57:29< vultraz> But it looks better in this case with it on
20160124 16:57:31< shadowm> I assumed there wasn't since there isn't any such thing for the toggle_panel nodes AFAICT.
20160124 16:57:45< shadowm> And that it was part of the non-toggle_panel nodes instead.
20160124 16:57:58< vultraz> tree views have a dedicated indention_step_size
20160124 16:58:00< vultraz> key
20160124 16:58:17< shadowm> I hope it's not called literally that.
20160124 16:58:21< vultraz> yes
20160124 16:58:38< celticminstrel> Not indentation_step_size?
20160124 16:58:42< vultraz> nope
20160124 16:58:45< celticminstrel> ...
20160124 17:00:13< vultraz> anyway, there seems to sadly be nothing to be done here
20160124 17:03:58-!- mjs-de [~mjs-de@f048021190.adsl.alicedsl.de] has joined #wesnoth-dev
20160124 17:06:19< vultraz> current progress pushed to fork 
20160124 17:09:55-!- iceiceice [~chris@wesnoth/developer/iceiceice] has left #wesnoth-dev ["Leaving"]
20160124 17:10:46< vultraz> I hope I'm not misusing dynamic_cast at all 
20160124 17:14:59-!- Mic_ [4f420610@gateway/web/freenode/ip.79.66.6.16] has quit [Quit: Page closed]
20160124 17:17:02-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160124 17:21:38-!- Aginor [~andreas@unaffiliated/aginor] has quit [Ping timeout: 272 seconds]
20160124 17:23:36-!- Aginor [~andreas@apollo.alternating.net] has joined #wesnoth-dev
20160124 17:23:37-!- Aginor [~andreas@apollo.alternating.net] has quit [Changing host]
20160124 17:23:37-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev
20160124 17:26:55< vultraz> gfgtdf: https://github.com/Vultraz/wesnoth/commit/72ee2c3ebe16ce1e1ef033d6c76f41900ce8ee77
20160124 17:32:53< celticminstrel> vultraz: What are you using dynamic_cast for?
20160124 17:33:22< vultraz> stuff like 
20160124 17:33:25< vultraz> tslider* advanced_pref_setter_ = dynamic_cast<tslider*>(new tslider);
20160124 17:33:38< celticminstrel> That's redundant.
20160124 17:33:43< vultraz> it is?
20160124 17:33:49< celticminstrel> "new tslider" returns a value of type tslider* already.
20160124 17:34:06< celticminstrel> There's no need for any kind of cast.
20160124 17:35:04< vultraz> But it's a class member variable defined as twidget* advanced_pref_setter_;
20160124 17:35:06< Necrosporus> vultraz, that's better, but I'm not sure why should it be duplicated, doesn't lack of V in [] mean "no" already?
20160124 17:35:24< vultraz> a pointer to class twidget not tslider
20160124 17:35:30< celticminstrel> What, vultraz?
20160124 17:35:39< celticminstrel> So your posted example is not what's actually there?
20160124 17:35:54< vultraz> celticminstrel: just look at the commit https://github.com/Vultraz/wesnoth/commit/3dc3d760421ea3f7450839b1b0ea7505dbd81ad4
20160124 17:36:18< celticminstrel> Anyway, tslider extends twidget, right? So it'd still be redundant.
20160124 17:36:37< celticminstrel> Line number?
20160124 17:36:49< celticminstrel> Oh, found it.
20160124 17:36:53< vultraz> currently 527 and 554
20160124 17:37:01< celticminstrel> [Jan 24@12:35:04pm] vultraz: But it's a class member variable defined as twidget* advanced_pref_setter_;
20160124 17:37:13< celticminstrel> No, it's a local variable that has the same name and thus hides the class member variable.
20160124 17:37:30< celticminstrel> Remove the cast, and remove the "tslider*" from the beginning of the line.
20160124 17:37:32< vultraz> oh
20160124 17:37:51< zookeeper> sometimes using a not-quite-up-to-date binary can be interesting: https://dl.dropboxusercontent.com/u/63964618/wesnoth/oops.jpg
20160124 17:37:57< celticminstrel> If that causes compile errors, then remove the cast and change the variable name, and after setting it up, assign it to the class member variable.
20160124 17:38:05< zookeeper> (it's the right-click menu)
20160124 17:38:42< zookeeper> i'm not sure why the ones on the sides are red though.
20160124 17:38:48< vultraz> yes, compile errors about twidget not having the specified members
20160124 17:38:53-!- knotwork_ [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20160124 17:39:26< celticminstrel> So you do need it to be a tslider*, so just change the variable name and assign it afterwards.
20160124 17:39:38-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 256 seconds]
20160124 17:39:40< celticminstrel> There's no need to cast when assigning a tslider* to a twidget*.
20160124 17:39:49< vultraz> well then I might as well not have the class member variable
20160124 17:39:51< celticminstrel> You only need to cast if you want to assign a twidget* to a tslider*.
20160124 17:39:59< vultraz> since all it's needed for is the call to swap_child
20160124 17:40:06< celticminstrel> (Or generally, any superclass to a variable of a subclass type.)
20160124 17:40:17< celticminstrel> Ah.
20160124 17:40:25< celticminstrel> Sure, but still, no cast needed. :)
20160124 17:43:17-!- irco [~irco@HSI-KBW-078-042-015-165.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20160124 17:43:58< vultraz> I should probably learn the purpose of the casts 
20160124 17:44:17< vultraz> I thought dynamic cast was for changing classes 
20160124 17:47:27< celticminstrel> That's not wrong, exactly.
20160124 17:48:43-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160124 17:51:15< celticminstrel> Dynamic cast is for casts that can only be resolved at runtime, which means you're working with polymorphism.
20160124 17:51:28< celticminstrel> So, classes with virtual functions.
20160124 17:52:21< celticminstrel> Usually casting from a superclass to a subclass.
20160124 17:52:54< celticminstrel> Of course, since it's working with polymorphism, that means you have either pointers or references.
20160124 18:20:58-!- Organism [~Sasquash@c-24-21-217-33.hsd1.or.comcast.net] has joined #wesnoth-dev
20160124 18:21:27-!- Organism [~Sasquash@c-24-21-217-33.hsd1.or.comcast.net] has left #wesnoth-dev []
20160124 18:28:18-!- Kwandulin [~Miranda@p200300760F6924AB3C6F5D53324D0AE5.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160124 18:36:27-!- trewe [~trewe@bl20-34-239.dsl.telepac.pt] has joined #wesnoth-dev
20160124 19:52:10-!- knotwork_ [~markm@unaffiliated/knotwork] has quit [Ping timeout: 245 seconds]
20160124 19:58:22-!- knotwork_ [~markm@99.192.89.107] has joined #wesnoth-dev
20160124 19:58:23-!- knotwork_ [~markm@99.192.89.107] has quit [Changing host]
20160124 19:58:23-!- knotwork_ [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20160124 19:59:53-!- legoktm is now known as legoktm[NE]
20160124 20:26:21-!- horrowind [~Icedove@2a02:810a:8b00:1a54:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160124 20:28:53-!- solvents [~quassel@69-196-152-213.dsl.teksavvy.com] has joined #wesnoth-dev
20160124 20:48:36-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160124 20:54:40-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20160124 20:54:40-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20160124 20:54:40-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160124 20:55:52< iceiceice> celticminstrel, this is why i say it helps alot in C++ to have some exposure to C also
20160124 20:56:02< iceiceice> (re vultraz' questions about casting)
20160124 20:56:16< celticminstrel> iceiceice: I don't think I agree, generally speaking.
20160124 20:56:49< iceiceice> i think alot of stuff makes more sense if you have some idea of how it is implemented and *why* you might want to use virtual dispatch instead of static dispatch
20160124 20:56:51< shadowm> I don't know what the questions about casting are and I don't want to read them, but I'd agree.
20160124 20:57:10< iceiceice> otherwise it just seems like a bunch of arbitrary and quite complex rules which burn you if you mess up
20160124 20:57:13< celticminstrel> That might be so, iceiceice, but that has nothing to do with C.
20160124 20:57:30< iceiceice> well thats fair
20160124 20:57:35< celticminstrel> I have no idea who shadowm is agreeing with.
20160124 20:57:43< shadowm> With iceiceice.
20160124 20:57:49< celticminstrel> I see.
20160124 20:57:53 * celticminstrel shrugs.
20160124 20:58:14< iceiceice> i mean maybe not C directly but, having done some really low level stuff helps alot even when you only want to do some high level stff
20160124 20:58:51< celticminstrel> Maybe...
20160124 21:03:41< shadowm> Not necessarily do either, you can still gain some insight into C++'s (and C's) implementation details without ever having to write a compiler or kernel if you take the time to question everything and look it up.
20160124 21:07:29< shadowm> I think one of the first questions I asked myself is "what are functions made of".
20160124 21:08:03< shadowm> It all went downhill from there.
20160124 21:09:27< shadowm> Also, "where does memory come from".
20160124 21:14:31< shadowm> Perhaps a question more appropriate for a beginner would be "where do (object) member functions live and how are they related to regular functions", especially since vultraz is working a lot with boost::bind on (hopefully) member functions for implementing GUI2 event callbacks.
20160124 21:16:52< shadowm> But yeah, questioning is paramount. Trust no-one, not even the compiler. Everyone's always hiding secrets behind your back and some day they will come back to bite you in the rear, often while debugging.
20160124 21:51:01-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Disconnected by services]
20160124 21:51:05-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20160124 21:58:59-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 264 seconds]
20160124 22:14:07-!- timotei__ [~timotei@wesnoth/developer/timotei] has quit [Remote host closed the connection]
20160124 22:15:19-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20160124 22:18:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds]
20160124 22:23:45-!- trewe [~trewe@bl20-34-239.dsl.telepac.pt] has quit [Quit: quit]
20160124 22:32:46-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160124 22:33:20-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20160124 22:39:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160124 22:41:12-!- irco [~irco@HSI-KBW-078-042-015-165.hsi3.kabel-badenwuerttemberg.de] has quit [Ping timeout: 250 seconds]
20160124 23:07:48-!- mjs-de [~mjs-de@f048021190.adsl.alicedsl.de] has quit [Remote host closed the connection]
20160124 23:10:55-!- Appleman1234 [~Appleman1@KD119104012001.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
--- Log closed Mon Jan 25 00:00:41 2016