--- Log opened Sat Jan 30 00:00:04 2016
--- Day changed Sat Jan 30 2016
20160130 00:00:04-!- VultCave is now known as vultraz
20160130 00:09:05-!- Appleman1234 [~Appleman1@KD119104018157.au-net.ne.jp] has joined #wesnoth-dev
20160130 00:14:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 00:33:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 00:50:54-!- irker854 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160130 00:53:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20160130 00:53:34-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 272 seconds]
20160130 00:58:02-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 250 seconds]
20160130 00:59:07-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160130 01:00:04-!- Jetrel_ [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20160130 01:00:10< ancestral> Hmm, what is Wesnoth? Is it a continent or kingdom? Let’s find out…
20160130 01:00:14< ancestral> https://wiki.wesnoth.org/Wesnoth
20160130 01:00:20< ancestral> Hmm…
20160130 01:03:12-!- crimson_pingvin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev
20160130 01:03:19-!- pyndragon [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20160130 01:03:56-!- higgins` [~higgins@105.ip-167-114-152.net] has joined #wesnoth-dev
20160130 01:04:16-!- Netsplit *.net <-> *.split quits: higgins, pydsigner, crimson_penguin, avtobiff, Jetrel
20160130 01:04:16-!- crimson_pingvin is now known as crimson_penguin
20160130 01:04:17-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host]
20160130 01:04:17-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20160130 01:05:24-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160130 01:06:10-!- higgins` [~higgins@105.ip-167-114-152.net] has quit [Excess Flood]
20160130 01:06:49-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160130 01:09:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 276 seconds]
20160130 01:10:00-!- higgins [~higgins@105.ip-167-114-152.net] has joined #wesnoth-dev
20160130 01:10:00-!- avtobiff [~avtobiff@c-503270d5.015-6-73746f28.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20160130 01:12:18-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160130 01:17:06-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160130 01:21:40-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 265 seconds]
20160130 01:23:05-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160130 01:26:57-!- Appleman1234 [~Appleman1@KD119104018157.au-net.ne.jp] has quit [Remote host closed the connection]
20160130 01:41:19-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160130 01:52:46-!- Greg-Boggs [~oem@2601:1c2:901:5227:178:5f3e:1dc:4aaa] has joined #wesnoth-dev
20160130 01:56:56-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160130 01:59:34-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160130 02:02:35-!- Greg-Boggs [~oem@2601:1c2:901:5227:178:5f3e:1dc:4aaa] has quit [Ping timeout: 260 seconds]
20160130 02:08:03-!- pyndragon is now known as pydsigner
20160130 02:12:35-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20160130 02:25:09-!- gfgtdf_ [~chatzilla@f050178198.adsl.alicedsl.de] has joined #wesnoth-dev
20160130 02:26:56-!- gfgtdf [~chatzilla@f054051037.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20160130 02:27:04-!- gfgtdf_ is now known as gfgtdf
20160130 02:29:03-!- prkc [~prkc@54001BD3.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20160130 02:34:40-!- irker076 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160130 02:34:40< irker076> wesnoth: Andreas Löf wesnoth:guifixes a5f8d62a75d9 / src/ (9 files in 4 dirs): Add initial support for GUI layering https://github.com/wesnoth/wesnoth/commit/a5f8d62a75d979ed897b4e5a3271016827f68bd0
20160130 02:34:45 * Aginor smiles
20160130 02:34:50-!- elias [~allefant@allegro/developer/allefant] has quit [Ping timeout: 276 seconds]
20160130 02:35:01< Aginor> vultraz: that there is some progress
20160130 02:35:14< Aginor> vultraz: try having overlapping dialogs now and see what happens :)
20160130 02:35:20-!- elias [~allefant@allegro/developer/allefant] has joined #wesnoth-dev
20160130 02:46:33-!- Appleman1234 [~Appleman1@KD119104015094.au-net.ne.jp] has joined #wesnoth-dev
20160130 02:50:02< vultraz> will do
20160130 02:51:20 * vultraz builds
20160130 02:56:22-!- Greg-Boggs [~oem@2601:1c2:901:5227:178:5f3e:1dc:4aaa] has joined #wesnoth-dev
20160130 03:01:04-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 03:03:35-!- Greg-Boggs [~oem@2601:1c2:901:5227:178:5f3e:1dc:4aaa] has quit [Ping timeout: 240 seconds]
20160130 03:05:15-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160130 03:07:05-!- Appleman1234 [~Appleman1@KD119104015094.au-net.ne.jp] has quit [Remote host closed the connection]
20160130 03:07:53-!- Appleman1234 [~Appleman1@KD119104015094.au-net.ne.jp] has joined #wesnoth-dev
20160130 03:15:37-!- Greg-Boggs [~oem@2601:1c2:901:5227:178:5f3e:1dc:4aaa] has joined #wesnoth-dev
20160130 03:21:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160130 03:39:29< ancestral> I have a rough cut of the trailer, before adding in video
20160130 03:54:49< ancestral> https://paste.ee/p/bmQDG
20160130 03:55:09< ancestral> I need help with some of these captions
20160130 04:32:10< vultraz> ancestral: you should say "dozen campaigns"
20160130 04:32:56< ancestral> Then I should change “campaign” as the verb\
20160130 04:33:47< ancestral> Is “Battle throughout Wesnoth” too cheeky?
20160130 04:33:53< vultraz> no
20160130 04:34:10< Aginor> ancestral: is this to go with the steam launch? :D
20160130 04:34:19< ancestral> Hopefully
20160130 04:34:23< vultraz> Aginor: really, really weird behavior if you minimize/go out of focus while game is loading
20160130 04:34:26< ancestral> My primary computer is in the shop
20160130 04:34:37< Aginor> who's doing steamworks integration
20160130 04:34:43< ancestral> (So I’m trying to see if I can manage without)
20160130 04:34:55< ancestral> That’s a topic for discussion?
20160130 04:35:03< Aginor> vultraz: I haven't given that set of (completely separate) UI any love yet
20160130 04:35:24< ancestral> Aginor: Having Steamworks may get more people into the game? I dunno
20160130 04:35:30< Aginor> ancestral: I was wondering if someone was working on it ;)
20160130 04:35:34< vultraz> Aginor: no no once you get in-game
20160130 04:35:36< ancestral> Wanna sign up?
20160130 04:35:53< Aginor> ancestral: not right now, I want to finish the GUI stuff first
20160130 04:36:07< Aginor> but later on, possibly
20160130 04:36:25< Aginor> it depends on if solvents accomplishes anything
20160130 04:36:28< Aginor> lastseen solvents
20160130 04:36:37< Aginor> shikadibot: lastseen solvents
20160130 04:36:37< ancestral> Aginor: I have absolutely 0 idea how the prcoess works on getting onto Steam, but I am sure they will want to test our binaries
20160130 04:36:59< ancestral> Make sure that, you know, it’s not garbage, adware in disguise, etc.
20160130 04:37:05< ancestral> Crashes galore
20160130 04:37:07< Aginor> ancestral: I know people I can talk to about the process
20160130 04:37:19< vultraz> ancestral: we can talk to the frogatto people too
20160130 04:37:21< ancestral> Like, this one guy who works there
20160130 04:37:35< vultraz> ancestral: since dave and co got frogatto through greenlight 
20160130 04:37:36< ancestral> Who, you know, sorta use to work on this game…
20160130 04:37:40< ancestral> True
20160130 04:37:49< vultraz> you are speaking of dave
20160130 04:37:53< ancestral> :-P
20160130 04:38:05< vultraz> Aginor: https://www.dropbox.com/s/jph0v89bvq31eop/weirdlayoutbug.PNG?dl=0
20160130 04:38:17< ancestral> vultraz: Are you waiting for 1.14 before going on Steam?
20160130 04:38:18< vultraz> Aginor: dialog-over-dialog works now, though
20160130 04:38:28< vultraz> ancestral: possibly
20160130 04:38:46< ancestral> It just seems to me, the more bug-free/issue-free, the better ratings
20160130 04:38:57< Aginor> vultraz: yeah, ok, I'm aware of that problem
20160130 04:39:08< vultraz> ancestral: with the stuff that's going on in 1.13 it's certainly better prepared for steam than 1.12
20160130 04:39:11< Aginor> it's gui2 doing something silly, I don't know what yet
20160130 04:39:12< vultraz> Aginor: ok good
20160130 04:39:17< ancestral> vultraz: Yes
20160130 04:39:22< Aginor> you get same problem just resizing when that window is open
20160130 04:39:22< ancestral> Absolutely
20160130 04:39:25< vultraz> Aginor: note the disappearing menu buttons though
20160130 04:39:40< Aginor> vultraz: known issue, I am tackling that next
20160130 04:39:44< vultraz> ok :)
20160130 04:39:59< Aginor> that'll require changing the behaviour of the display class a bit
20160130 04:40:02< vultraz> and since your layers work, looks like you did what you set out to do
20160130 04:40:15< Aginor> bring it in line with the expectations of a gui1 widget
20160130 04:40:37< Aginor> vultraz: it's not very proper, it's a pale shade of what it could do
20160130 04:40:52< Aginor> ideally it should be doing geometry calculations to figure out where/what to draw
20160130 04:41:00< vultraz> oo
20160130 04:41:02< vultraz> geometry 
20160130 04:41:24< Aginor> if ~component overlaps underlying component then redraw underlying component
20160130 04:41:31< Aginor> or even better, partial redraw
20160130 04:41:53< Aginor> but I don't particularily want to implement that in GUI1
20160130 04:43:54< Aginor> anyhow, I shall now go and deal with dinner and then worry about the pub
20160130 04:44:19< Aginor> vultraz: once I've dealt with those buttons and maybe the window, I think we're a lot closer to being releasable
20160130 04:44:25< Aginor> vultraz: the buttons aren't a biggie
20160130 04:44:44< Aginor> the window might be annoying because I don't understand why it's getting silly coordinates
20160130 04:46:19< Aginor> ancestral: I think storyboard is off to a nice start, but I think that slide 8 and 9 could be having some material rearranged
20160130 04:47:14< Aginor> ancestral: "play as seven unique factions, each with their unique sets of units and strategies" for slide 5, perhaps?
20160130 04:47:54-!- gfgtdf [~chatzilla@f050178198.adsl.alicedsl.de] has quit [Ping timeout: 272 seconds]
20160130 05:01:17< ancestral> Aginor: Thanks
20160130 05:03:56< vultraz> ancestral: for the multilanguage logo montage you could have a few flash by in a "zoom" style
20160130 05:04:09 * ancestral nods
20160130 05:04:15< vultraz> so like, .5 seconds for each logo to zoom towards the camera
20160130 05:04:18< vultraz> or something
20160130 05:04:37< vultraz> I also don't think you should mention "additional features"
20160130 05:05:27< vultraz> How about something like: "Download freely from a large assortment of player-made add-ons — 
20160130 05:05:28< vultraz> custom map packs, scenarios, campaigns and more""
20160130 05:06:59< vultraz> (the 'player-made' part is so we emphasize we're not marketing DLC :P )
20160130 05:08:55< vultraz> besides that (I do like "Battle throughout Wesnoth", great start :) )
20160130 05:17:20< ancestral> Okay guys
20160130 05:17:50< ancestral> I’ll post a draft before video capture, and some animation stuff with the languages
20160130 05:19:26< ancestral> vultraz: player-made or user-made?
20160130 05:22:03< ancestral> I’m not 100% sold on the scenery images I used at the beginning
20160130 05:22:18< ancestral> (That is, could swap out a few for some others)
20160130 05:22:31< ancestral> But I do think some artwork sets the tone properly
20160130 05:24:38< ancestral> http://mproud.com/wesnoth/trailer_draft_b4_vidcaps.m4v
20160130 05:25:04< ancestral> 720p on purpose as it’s a draft (47.8 MB) 
20160130 05:25:32< ancestral> (THERE WILL BE ACTUAL GAMEPLAY VID CAPTURES)
20160130 05:26:55< ancestral> Hmm, timing is a little off on the export closer to the end
20160130 05:34:53-!- irker076 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160130 05:46:25-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160130 06:01:18-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 06:02:12< ancestral> https://youtu.be/zsU2SazCwsc [unlisted]
20160130 06:02:37< ancestral> Timing is still off on some of the text animation, but I’ll fix that
20160130 06:05:26-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160130 06:06:07-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160130 06:09:14< vultraz> ancestral: player
20160130 06:09:34< ancestral> incorporated that way
20160130 06:15:15-!- Greg-Boggs [~oem@2601:1c2:901:5227:178:5f3e:1dc:4aaa] has quit [Ping timeout: 240 seconds]
20160130 06:49:25< Aginor> ancestral: I think that's a very nice start
20160130 06:50:16 * Aginor ponders
20160130 06:50:30< Aginor> steamworks and steam workshop integration would be nice :D
20160130 06:51:03< aeth> I don't think steam workshop integration would work with Wesnoth.
20160130 06:51:40< aeth> Wesnoth's add-on requirements are stricter than Steam's, and it doesn't require Steam to play.
20160130 06:52:41< Aginor> aeth: what do you mean? stricter in which way? I was thinking of it as a way for people to post content and easily install it
20160130 06:52:48< aeth> ancestral: If you're making a trailer, consider using some MP RPG maps. They're not balanced for the standard game but some of them look really cool.
20160130 06:53:08< aeth> Aginor: Everything on the Wesnoth add-on server is GPL.
20160130 06:54:07< aeth> Meanwhile Steam Workshop tends to be filled with copyright (or at least trademark) violations.
20160130 06:54:45< aeth> What that means is that more than half of the content on a hypothetical Wesnoth workshop would be LotR.
20160130 06:56:22< Aginor> aeth: yes? So you are concerned that we would need to police the community to say what they may or may not do?
20160130 06:57:07< aeth> I'm saying that it would be a complete 180 in add-on culture.
20160130 07:04:10< Aginor> aeth: are addons distributed as compiled binaries or scripts that are executed by wesnoth?
20160130 07:04:39< aeth> Aginor: Lua and WML scripts.
20160130 07:05:29< Aginor> aeth: that sounds like it will always satisfy the GPL
20160130 07:06:01< Aginor> if someone makes a derivative work it'll always be distributed as source
20160130 07:06:34< Aginor> aeth: do not confuse GPL with copyright and trademark lay. Just because something is licensed under the GPL doesn't mean it's not copyrighted
20160130 07:07:05< Aginor> I can license something under the GPL and still sue the pants off anyone who distributes it, or a modified version thereof
20160130 07:07:14< Aginor> (afaik, but ianal)
20160130 07:10:17-!- Kwandulin [~Miranda@p200300760F692408C951117C6C181940.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160130 07:26:39-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: End Transmission.]
20160130 07:46:11< vultraz> Aginor: that is very true. 
20160130 07:46:21< vultraz> Aginor: wesnoth is gpl but people hold individual copyrights
20160130 07:46:33< vultraz> in fact, that's something we will change before going on steam
20160130 07:46:52< vultraz> any copyright holder will be messaged and ask to turn over their copyright to the Wesnoth project as a collective 
20160130 07:52:41< shadowm> That is not an official decision yet and everyone should ignore what vultraz just said until further information becomes available.
20160130 07:52:54 * vultraz rolls eyes
20160130 07:53:00< vultraz> BUREAUCRACY 
20160130 07:54:36< aeth> We all know what will happen. Someone will say no and force a rewrite of some code.
20160130 07:54:56< aeth> Worse if it's music or something.
20160130 07:55:53< vultraz> If someone hypothetically says no in this hypothetical situation their work might hypothetically be removed but I don't know
20160130 07:56:05< vultraz> This is all an unofficial decision
20160130 08:21:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160130 08:21:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160130 08:23:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160130 08:23:47-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160130 08:28:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 08:28:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20160130 08:43:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 08:48:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds]
20160130 09:20:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160130 09:35:48< zookeeper> ancestral, looks pretty good to me. i would maybe avoid the wood background as the initial opener, since it just isn't that marvellous and keen-eyed viewers will notice that it's kinda patchy :p and of course some of the wording can be improved a bit, but other than that it seems solid.
20160130 09:40:52-!- Kwandulin [~Miranda@p200300760F692408C951117C6C181940.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160130 09:48:03-!- ggeneral [~anton@nat3.opti.net.ua] has joined #wesnoth-dev
20160130 09:50:37-!- _laco [~laco@static.95.25.4.46.clients.your-server.de] has quit [Ping timeout: 265 seconds]
20160130 09:54:11-!- ggeneral [~anton@nat3.opti.net.ua] has left #wesnoth-dev []
20160130 10:03:45-!- _laco [~laco@static.95.25.4.46.clients.your-server.de] has joined #wesnoth-dev
20160130 10:17:03-!- Kwandulin [~Miranda@p200300760F69240804CAF581217494D3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160130 10:23:47< vultraz> gfgtdf: i've fixed the toggle issue
20160130 10:29:10-!- Kwandulin [~Miranda@p200300760F69240804CAF581217494D3.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160130 10:30:38-!- Kwandulin [~Miranda@p200300760F69242F04CAF581217494D3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160130 10:40:10< vultraz> I'm probably going to merge the widget-related commits from my PR into master in a little 
20160130 10:55:00< vultraz> gfgtdf: hm actually only partially
20160130 11:04:10< vultraz> gfgtdf: probably should use your suggestion of closing every other node when you select a new one
20160130 11:10:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 11:14:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds]
20160130 11:16:45-!- aidanhs [~aidanhs@81.4.110.234] has quit [Ping timeout: 245 seconds]
20160130 11:21:23-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20160130 11:28:25< vultraz> gfgtdf: ok the problem is for some reason even if I use a loop sometimes more than one item can get selected and then not all of the nodes are closed
20160130 11:28:27< vultraz> weird
20160130 11:34:14< vultraz> but I did get the select event to work
20160130 11:55:16< vultraz> gfgtdf: https://github.com/Vultraz/wesnoth/commit/f5765be5bb2dea02aa7e4785a5585415a1be4953 and https://github.com/Vultraz/wesnoth/commit/50d518c431afd443417d5979e24751454adfc636
20160130 11:55:54< vultraz> latter commit only has problems bc sometimes you can end up with more than 1 widget selected when clicking on a certain area
20160130 11:59:18< vultraz> but there's the same behavior even if you use a loop which is weird
20160130 12:03:57< vultraz> gfgtdf: some of the ways more than one ends up selected is clicking the hidden space of a child widget or clicking really near the border of the toggle panel
20160130 12:04:09< vultraz> (so basically in the border of the label child)
20160130 12:12:19-!- ggenerall [~anton@nat3.opti.net.ua] has joined #wesnoth-dev
20160130 12:24:36-!- ggenerall [~anton@nat3.opti.net.ua] has left #wesnoth-dev []
20160130 12:31:13< vultraz> gfgtdf: is there some combination of gui2 events that can handle clicking on child empty space?
20160130 12:31:40< vultraz> like you added back_post_child to fix the toggle
20160130 12:41:06< vultraz> i have a feeling mixing the two events here causes problems..
20160130 12:41:13< vultraz> two widgets' events
20160130 12:56:26< vultraz> or maybe you just can't handle empty space
20160130 12:56:28< vultraz> or hidden widgets?
20160130 12:59:21< vultraz> bc part of the problem is clicking on a hiddel widget
20160130 12:59:23< vultraz> hidden*
20160130 13:04:06-!- Kwandulin [~Miranda@p200300760F69242F04CAF581217494D3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160130 13:24:42-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160130 13:26:41-!- Kwandulin [~Miranda@p200300760F69242F788FBCBAC9085FDA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160130 13:26:58-!- lipkab [~the_new_l@apn-185-10-126-236.vodafone.hu] has joined #wesnoth-dev
20160130 14:20:26-!- mjs-de [~mjs-de@x4db51a85.dyn.telefonica.de] has joined #wesnoth-dev
20160130 14:29:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160130 14:30:35-!- lipkab [~the_new_l@apn-185-10-126-236.vodafone.hu] has quit [Ping timeout: 240 seconds]
20160130 14:33:41-!- irker662 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160130 14:33:41< irker662> wesnoth: ln-zookeeper wesnoth:master 6f9a6271a06a / data/core/terrain-graphics/ (mountains.cfg new-macros.cfg): Fixed several forest<->mountain layering glitches https://github.com/wesnoth/wesnoth/commit/6f9a6271a06a15f5c67d0c005c30a07ab7b60f67
20160130 14:33:46< zookeeper> ^ possibly controversial.
20160130 14:34:35< vultraz> we'll have to see
20160130 14:35:42< zookeeper> basic problem is that the mountain images are at such an angle that you can see the slopes behind them (msot notably on the 1x3 ranges), which means that in order for trees to not get drawn under the slopes, the layering has to be made unusual, which leads to (less, IMO) problems in other situations.
20160130 14:36:08< zookeeper> ideally, someone would redraw the mountains slightly differently :p
20160130 14:39:15< vultraz> doofus's on the ones we have?
20160130 14:41:41< zookeeper> latter
20160130 14:42:59< zookeeper> and incidentally this isn't a problem at with doofus's mountains because they're in a different angle. so this will also cause some trees to be drawn on top of them, but as far as i've seen it doesn't look terrible.
20160130 14:43:29< zookeeper> but maybe i have to duplicate some of the mountain macros with different base values for those after all, i'm not sure.
20160130 14:44:05< zookeeper> ideally someone would redraw the regular mountains so that they could actually use the "right" base values, so we wouldn't need to treat the two types differently
20160130 14:48:12-!- Greg-Boggs [~oem@2601:1c2:901:5227:178:5f3e:1dc:4aaa] has joined #wesnoth-dev
20160130 15:01:20-!- Greg-Boggs [~oem@2601:1c2:901:5227:178:5f3e:1dc:4aaa] has quit [Ping timeout: 260 seconds]
20160130 15:10:23< vultraz> dammit, what's the name of that angle again...
20160130 15:10:33< vultraz> the one we were discussing awhile back with scrollbars
20160130 15:10:59< vultraz> where I said input shouldn't be accepted past the width 
20160130 15:11:03< vultraz> er, sliders
20160130 15:11:05< vultraz> not scrollbars
20160130 15:11:16< vultraz> but i can't remember what name shadowm called it
20160130 15:12:38< vultraz> orthogonal!
20160130 15:12:40< vultraz> got it
20160130 15:43:34< aeth> zookeeper: That's not the most annoying thing with mountains imo
20160130 15:44:13< aeth> The most annoying thing is that it's hard to force a 4-hex mountain in a map at all. The only way I can get that permanently is to make it a volcano, actually.
20160130 15:46:10< vultraz> uh..no?
20160130 15:46:15< vultraz> you just have to move it around
20160130 15:46:55< aeth> Literally move the mountain hexes any time the map's resized or the mountain gods just arbitrarily decide to make mountains work slightly differently over a long period of time?
20160130 15:47:06< aeth> On most maps hex position matters exactly.
20160130 15:47:29< aeth> I wouldn't mind slight adjustments in laying down mountains if it never changed, but it does ime.
20160130 15:48:32< aeth> Over time, the amount of volcanos in my maps increases because that's the only permanent way to get 4-hex mountains graphically.
20160130 15:48:34-!- prkc [~prkc@54001BD3.dsl.pool.telekom.hu] has joined #wesnoth-dev
20160130 15:51:00< aeth> Even if it never changed when laying it down, what if I wanted a chain of large 4-hex mountains? Sometimes clustering 4 mountain hexes will work 4/5 times or something, and it will look ugly.
20160130 15:54:04< aeth> The simplest solution would probably be to have a mountain peak terrain that behaved like the volcano. Explicit will never break, even on resize. Map resizing is very common, at least for my maps.
20160130 15:57:37< aeth> (I find it's easier to work on a small map and then resize it if needed, which instantly makes the appearance of mountains one of my main frustrations.)
20160130 15:59:22-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 250 seconds]
20160130 16:02:21-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160130 16:05:23< irker662> wesnoth: Charles Dang wesnoth:master 082fd28dc555 / src/gui/widgets/ (tree_view_node.cpp tree_view_node.hpp): ttree_view_node: added set_callback_state_change support https://github.com/wesnoth/wesnoth/commit/082fd28dc5552d1306f0ef0be2de0d4c946fec83
20160130 16:05:26< irker662> wesnoth: Charles Dang wesnoth:master 07794e4b33e7 / src/gui/widgets/combobox.hpp: tcombobox: added a getter method for the currently selected option's string https://github.com/wesnoth/wesnoth/commit/07794e4b33e70177deb8e11f268ceef86d176944
20160130 16:05:29< irker662> wesnoth: Charles Dang wesnoth:master 9ee26c53bf7a / src/gui/widgets/listbox.cpp: tlistbox: don't request resize when removing the last row https://github.com/wesnoth/wesnoth/commit/9ee26c53bf7a91219597348c716e1f701eb7851d
20160130 16:05:32< irker662> wesnoth: Charles Dang wesnoth:master 61ce8437a9a4 / src/gui/widgets/text_box.hpp: ttext_box: added a clear() function https://github.com/wesnoth/wesnoth/commit/61ce8437a9a4a0082f0f0bd43935707f0849be23
20160130 16:05:35< irker662> wesnoth: Charles Dang wesnoth:master 0d424e9d5dae / src/gui/widgets/ (tree_view_node.cpp tree_view_node.hpp): ttree_view: partially implemented fold() and unfold() https://github.com/wesnoth/wesnoth/commit/0d424e9d5dae9f3ed330108800dc2f263bf4ff53
20160130 16:05:38< irker662> wesnoth: Charles Dang wesnoth:master 5f67eee678e0 / src/gui/widgets/tree_view_node.cpp: ttree_view_node: bind label selection event to toggle if label is not present https://github.com/wesnoth/wesnoth/commit/5f67eee678e082b75aa67b83952572db8a096827
20160130 16:05:41< irker662> wesnoth: Charles Dang wesnoth:master 65332d6a532c / src/gui/widgets/scrollbar.cpp: tscrollbar_: make manual scroll function fire MODIFIED event https://github.com/wesnoth/wesnoth/commit/65332d6a532c6defc9f7f290d3c6851f000b127c
20160130 16:05:44< irker662> wesnoth: Charles Dang wesnoth:master ebf01eb3a43c / src/gui/widgets/ (8 files): gui2: make scrollbars only accept input in the orthogonal range https://github.com/wesnoth/wesnoth/commit/ebf01eb3a43c1d7ea3165094db6fff24042f7997
20160130 16:06:29< vultraz> ^ GUI2-related commits from my PR
20160130 16:06:58< vultraz> pushed them separately to keep its scope minimal 
20160130 16:14:23-!- travis-ci [~travis-ci@ec2-54-144-234-46.compute-1.amazonaws.com] has joined #wesnoth-dev
20160130 16:14:24< vultraz> ebf01eb3a43c , 65332d6a532c , and 9ee26c53bf7a are bugfixes
20160130 16:14:24< travis-ci> wesnoth/wesnoth#8342 (master - 6f9a627 : ln-zookeeper): The build passed.
20160130 16:14:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/105883315
20160130 16:14:24-!- travis-ci [~travis-ci@ec2-54-144-234-46.compute-1.amazonaws.com] has left #wesnoth-dev []
20160130 16:26:24< vultraz> down to a mere 58 commits in my PR, now
20160130 16:31:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 16:35:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160130 16:37:12-!- travis-ci [~travis-ci@ec2-54-144-234-46.compute-1.amazonaws.com] has joined #wesnoth-dev
20160130 16:37:13< travis-ci> wesnoth/wesnoth#8343 (master - ebf01eb : Charles Dang): The build has errored.
20160130 16:37:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/105894242
20160130 16:37:14-!- travis-ci [~travis-ci@ec2-54-144-234-46.compute-1.amazonaws.com] has left #wesnoth-dev []
20160130 17:09:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 17:14:48-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 265 seconds]
20160130 17:19:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160130 17:19:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160130 17:24:52-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160130 17:28:05< celticminstrel> So vultraz, does the treeview in the experimental lobby work now?
20160130 17:28:13< vultraz> celticminstrel: I have no idea
20160130 17:28:41< celticminstrel> I'm asking because one of your commits looks like it could've fixed it.
20160130 17:28:53< celticminstrel> It crashed when I clicked a disclosure triangle, as I recall.
20160130 17:30:53< vultraz> celticminstrel: was this in the last week?
20160130 17:31:06-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20160130 17:31:10< celticminstrel> I think so?
20160130 17:31:25< vultraz> i think gfgtdf fixed that
20160130 17:31:34< celticminstrel> 0d424e9d5dae above looks relevant.
20160130 17:31:44< celticminstrel> Oh, did he fix it previously, then?
20160130 17:32:11< celticminstrel> So does it work now?
20160130 17:32:18< vultraz> I haven't tried
20160130 17:51:58-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160130 17:52:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit []
20160130 17:52:44-!- luukunku [5357d274@gateway/web/freenode/ip.83.87.210.116] has joined #wesnoth-dev
20160130 17:53:26-!- luukunku [5357d274@gateway/web/freenode/ip.83.87.210.116] has quit [Client Quit]
20160130 17:53:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 18:02:41-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160130 18:06:20-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 245 seconds]
20160130 18:06:21-!- wedge010 is now known as wedge009
20160130 18:11:43< zookeeper> ehh, wolf names...
20160130 18:19:20< vultraz> whoot whoot!
20160130 18:19:51< vultraz> celticminstrel: I've refactored out the accl_speed_to_int/int_to_accl_speed functions :D
20160130 18:20:29< celticminstrel> Refactored out meaning... they don't exist anymore?
20160130 18:20:52< vultraz> yes, I've replaced with with vector lookup and lexical_cast
20160130 18:21:12< vultraz> you don't know if you can initialize a vector list in a constructor argument do you?
20160130 18:22:07< celticminstrel> With a list of values? Only in C++11.
20160130 18:22:42< celticminstrel> Prior to that you only have empty-list and list-of-identical-values.
20160130 18:23:00< vultraz> blah
20160130 18:23:04< vultraz> C++ we need youuu
20160130 18:23:06< vultraz> c++11*
20160130 18:23:09< vultraz> well, don't need
20160130 18:23:15< vultraz> but it has nice stuff
20160130 18:23:38< vultraz> oh well, works either way
20160130 18:24:06< celticminstrel> In C++11, lists in braces can be passed as values to functions.
20160130 18:24:43< vultraz> celticminstrel: https://github.com/wesnoth/wesnoth/commit/c277cf2e019763a7d3d3c9f4c7063cf313a94e0b
20160130 18:25:28< vultraz> so in C++11 I'd be able to have the contents of speeds[] in line 74?
20160130 18:26:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 18:26:43< celticminstrel> Why are you using insert?
20160130 18:26:53< celticminstrel> But yeah, you could.
20160130 18:27:03< celticminstrel> I guess insert does do the job.
20160130 18:27:18< celticminstrel> I'm used to doing this sort of thing with std::copy and std::back_inserter.
20160130 18:27:48< celticminstrel> Actually, come to think of it...
20160130 18:27:52< vultraz> I'm using insert because https://stackoverflow.com/questions/14561941/how-do-i-pass-multiple-ints-into-a-vector-at-once told me to :P
20160130 18:28:08< celticminstrel> Why not just call the constant one accl_speeds and omit the copying?
20160130 18:28:16< celticminstrel> Does accl_speeds need to change ever?
20160130 18:28:20< vultraz> no
20160130 18:28:58< vultraz> but you can't populate the vector using a  {} list because we're not C++ 11, I though
20160130 18:29:15< celticminstrel> Does it need to be a vector?
20160130 18:29:20< vultraz> yes
20160130 18:29:23< celticminstrel> Why?
20160130 18:29:49< vultraz> implementation of tslider.set_value_labels()
20160130 18:30:08< vultraz> apparently sliders have built in functionality to bind label values to their steps 
20160130 18:30:15< vultraz> I didn't know this before
20160130 18:30:17< celticminstrel> So you pass accl_speeds to that, which accepts a vector?
20160130 18:30:33< vultraz> yes
20160130 18:30:40< vultraz> a vector of t_string's 
20160130 18:30:44< celticminstrel> Hmm...
20160130 18:31:03< celticminstrel> Well, that commit still leaves some things to be desired though.
20160130 18:32:02< celticminstrel> Oh, actually. Yeah. Okay. Just declare speeds to be static, otherwise you're more or less copying it twice in a row every time the constructor runs.
20160130 18:32:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 18:32:43< vultraz> static outside the constructor?
20160130 18:32:54< celticminstrel> It's easier to leave it in the constructor.
20160130 18:33:08< celticminstrel> If you move it out, then you need to declare it and the put the list in a source file.
20160130 18:33:09< vultraz> ok
20160130 18:33:12< celticminstrel> Either works though.
20160130 18:33:25< celticminstrel> ^and then
20160130 18:33:25< vultraz> also hm
20160130 18:34:39< vultraz> celticminstrel: anything else?
20160130 18:34:46< vultraz> you said it had things to be desired
20160130 18:35:12< celticminstrel> That was all I noticed, but I actually didn't look at the whole thing.
20160130 18:35:57< celticminstrel> What the heck is going on at lines 415-7?
20160130 18:36:59< vultraz> slider steps start at 1, vectors start at 0
20160130 18:38:39< celticminstrel> Nonsense.
20160130 18:38:53-!- trewe [~trewe@bl20-23-201.dsl.telepac.pt] has joined #wesnoth-dev
20160130 18:39:28< vultraz> the value that is passed to set_value has to be a step value not an index value
20160130 18:39:34< vultraz> std::find return an index
20160130 18:39:51< celticminstrel> Those lines are nonsense, I mean.
20160130 18:39:57< celticminstrel> Not what you said about sliders.
20160130 18:40:24< celticminstrel> Okay, if I recall correctly, it's find(start, end, value), right?
20160130 18:40:33< vultraz> yes
20160130 18:40:41< celticminstrel> And turbo_speed() returns...?
20160130 18:40:58< vultraz> just realized I can just remove the +1/-1 from the find call and use accl_slider.set_value(selected_speed + 1);
20160130 18:41:17< celticminstrel> The +1 and -1 in the find call are nonsensical.
20160130 18:41:28< celticminstrel> It's what drew my attention to it.
20160130 18:41:32< vultraz> yeah...not sure why it worked 
20160130 18:41:38< celticminstrel> Sheer luck.
20160130 18:42:13< celticminstrel> What does turbo_speed() return?
20160130 18:42:52< vultraz> a double-type value
20160130 18:43:07< celticminstrel> Ehhh...
20160130 18:43:22< vultraz> cast it to a string, find it in the vector
20160130 18:43:27< celticminstrel> ...well, these are powers of 2, so maybe you'll be fine with lexical_cast.
20160130 18:43:27< vultraz> get the index, add one
20160130 18:43:50< celticminstrel> I don't understand the purpose of line 417 in particular.
20160130 18:44:11< vultraz> don't you always have to subtract the beginning value?
20160130 18:44:20< vultraz> that's what I've seen the usecases do :/
20160130 18:44:27< celticminstrel> Oh wait, find returns an iterator, right.
20160130 18:44:42< celticminstrel> Okay.
20160130 18:44:57< irker662> wesnoth: Nils Kneuper wesnoth:master da53084cb7ee / po/wesnoth/en_GB.po: updated British English translation https://github.com/wesnoth/wesnoth/commit/da53084cb7eee6f2162cb807ff36c1a2d52c74bc
20160130 18:44:59< celticminstrel> But subtracting 1 there is just weird.
20160130 18:45:42< vultraz> yeah
20160130 18:45:52< celticminstrel> I think part of the problem is that the grouping is wrong. Assuming the basic idea is correct, the logical grouping would be "(find(...) - begin()) - 1", but you have "find(...) - (begin() - 1)".
20160130 18:46:12< celticminstrel> Do those even come out the same?
20160130 18:47:20< celticminstrel> Not only is subtraction non-associative, but those are two different types of subtraction.
20160130 18:47:22< vultraz> apparently if you add 1 at the beginning :P
20160130 18:47:31< celticminstrel> ?
20160130 18:47:57< celticminstrel> So it should be (find(...) - begin()) + 1?
20160130 18:48:12< celticminstrel> I guess that's what you ended up with, too, except with the +1 on the next line. Alright then.
20160130 18:48:19< vultraz> I had (find(begin + 1, end, foo), begin - 1)
20160130 18:48:41< celticminstrel> I think your second , is supposed to be -
20160130 18:49:05< celticminstrel> Or wait, that's nt what you had.
20160130 18:49:08< celticminstrel> ^not
20160130 18:49:22< celticminstrel> You have find(begin + 1, end, foo) - (begin - 1)
20160130 18:49:35< vultraz> oh, right
20160130 18:49:41< celticminstrel> You're not telling me you still have begin + 1? If you have begin + 1 it'll never find the first entry.
20160130 18:49:51< vultraz> no no 
20160130 18:49:54< vultraz> I removed that
20160130 18:50:06< vultraz> https://github.com/Vultraz/wesnoth/commit/5a20c9bb58f7936f658c367bf84769165900165b
20160130 18:50:08< vultraz> updated commit
20160130 18:50:17< celticminstrel> That replaces the previous one?
20160130 18:50:32< celticminstrel> Guess so.
20160130 18:51:26< celticminstrel> Well, you have redundant parentheses around begin() on lines 416 and 417, but that aside, it looks a lot better. Did you forget +1 on line 419?
20160130 18:51:45< celticminstrel> Oh wait, that's moved down to 424.
20160130 18:52:00< celticminstrel> Or rather, it was down there all along and I was just confused.
20160130 18:52:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 18:53:39< celticminstrel> Are the trailing zeroes in speeds[] there to match lexical_cast or for other reasons?
20160130 18:54:19< celticminstrel> BTW, you can make that a "const char*const" instead of a t_string. There's really no need for it to be a t_string.
20160130 18:55:05< vultraz> why two const?
20160130 18:55:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 18:55:21< vultraz> trailing zeros are just for stylistic purposes 
20160130 18:55:59< celticminstrel> The two consts have different meanings.
20160130 18:56:21< celticminstrel> "const char x" means a char that cannot be changed.
20160130 18:56:40< celticminstrel> "const char* x" means a pointer to a char that cannot be changed; however, the pointer could be made to point to a different char.
20160130 18:57:04< celticminstrel> "char*const x" means a pointer to a char that can be changed, but the pointer can't be made to point to a different char in a different location.
20160130 18:57:15< celticminstrel> "const char*const x" combines the two.
20160130 18:57:51< celticminstrel> Incidentally, I sometimes thing of "char x[]" as roughly equivalent to "char*const x", though that might be just me.
20160130 18:58:12< celticminstrel> ^think
20160130 19:00:23< vultraz> so static const char* const speeds[] = ?
20160130 19:00:41< celticminstrel> Yeah.
20160130 19:01:02< celticminstrel> I guess the second const is technically optional, but I like to include it in situations like this.
20160130 19:01:21< vultraz> this will look so much nicer in c++11 >_>
20160130 19:01:59< celticminstrel> [Jan 30@1:55:21pm] vultraz: trailing zeros are just for stylistic purposes
20160130 19:02:08< celticminstrel> Personally I think "1.00" looks weird.
20160130 19:02:43< celticminstrel> Also, you're using lexical_cast to convert a double to a string and match it to the list. That's kind of like asking for failure.
20160130 19:03:06< celticminstrel> There's no way to control how lexical_cast formats the number. It might return "1" or "1.0" or "1.000000000".
20160130 19:03:13< vultraz> stylistic for the list 
20160130 19:03:27< vultraz> celticminstrel: well, how would you do it?
20160130 19:03:33< celticminstrel> Also, why do you use "1.00" but then "2"?
20160130 19:04:04< celticminstrel> I would use stringstreams directly (that's what lexical_cast does internally) together with either <iomanip> or .setprecision()
20160130 19:04:22< vultraz> uhhhhh
20160130 19:04:43< celticminstrel> But being inconsistent about the formatting will make that harder.
20160130 19:05:02< vultraz> it does work, though
20160130 19:05:08< vultraz> I don't see why I need to complicate it
20160130 19:05:10< celticminstrel> Does it?
20160130 19:05:28< celticminstrel> That could be just luck, too.
20160130 19:05:48< celticminstrel> There may not be any guarantees that lexical_cast behaves the same way on different machines.
20160130 19:05:55< vultraz> whattt
20160130 19:05:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 19:06:02< celticminstrel> It might return "1.00" on your machine and "1.0" on someone else's.
20160130 19:06:14< vultraz> I don't think that matters
20160130 19:06:48< celticminstrel> find(begin, end, "1.0") will return end rather than a pointer to the proper entry.
20160130 19:07:01< vultraz> oh
20160130 19:07:07< vultraz> well crap 
20160130 19:07:09< vultraz> crap crap crap
20160130 19:07:24< celticminstrel> Does it not work after all?
20160130 19:07:49< vultraz> you are right
20160130 19:07:57< vultraz> setting the value to 1 results in end next time :|
20160130 19:08:09< vultraz> damn you, floating point precision!
20160130 19:08:39< celticminstrel> You could do a manual search.
20160130 19:08:52< celticminstrel> Instead of converting double to string, convert each string to double.
20160130 19:08:58< celticminstrel> Though that sounds like it'd be slower...
20160130 19:09:13< celticminstrel> Probably not noticeably so though.
20160130 19:09:30< vultraz> what about setprecision?
20160130 19:09:52< celticminstrel> I'll make a pastebin to demonstrate this.
20160130 19:10:05< vultraz> please do
20160130 19:10:15< vultraz> I know setprecision works only in stringstreams
20160130 19:10:24< vultraz> are you saying Ineed to make a new stream
20160130 19:10:32< vultraz> use setprecision(2) on the value
20160130 19:10:39< vultraz> and return the stream's string value?
20160130 19:10:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 19:12:10-!- Jetrel_ [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Ping timeout: 260 seconds]
20160130 19:19:23-!- Appleman1234 [~Appleman1@KD119104015094.au-net.ne.jp] has quit [Ping timeout: 264 seconds]
20160130 19:24:44< celticminstrel> Here's a demo: http://pastebin.com/xRFBUGSb
20160130 19:24:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 19:25:04< celticminstrel> Requires C++11, but the ideas it demonstrates don't.
20160130 19:26:06< celticminstrel> If you change your speeds array to match the first form, it might be safe to continue using lexical_cast. (I'm not certain though.)
20160130 19:26:30< celticminstrel> If you want your speed array unchanged, you'll need to used fixed notation only for values less than 2.
20160130 19:26:52< vultraz> "first form"?
20160130 19:27:08< celticminstrel> The first form listed in the output of the demo.
20160130 19:27:57< vultraz> you have 1.2 not 1.25
20160130 19:28:24< celticminstrel> Huh, that's surprising.
20160130 19:29:31< celticminstrel> I feel like I missed something somewhere, as it looks like the precision is the same in all three... :|
20160130 19:29:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 19:30:12< celticminstrel> Still, I think "cout << fixed" would be the key to getting what you want, rather than playing with the precision setting.
20160130 19:33:08< vultraz> but what is fixed
20160130 19:33:25< celticminstrel> Exactly 2 decimal places, for example.
20160130 19:34:26< vultraz> but is it a variable?
20160130 19:34:35< celticminstrel> ?
20160130 19:35:30< vultraz> where is "fixed" defined!
20160130 19:35:56< celticminstrel> fixed is an IO-manipulator.
20160130 19:36:02< celticminstrel> A special type of function.
20160130 19:36:09< celticminstrel> endl is also an IO-manipulator.
20160130 19:38:18< vultraz> and it does?
20160130 19:38:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 19:40:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 19:40:45< celticminstrel> Sets the output mode to fixed-point.
20160130 19:41:23< vultraz> ahh
20160130 19:41:47< vultraz> and what's that "double d : speeds" syntax
20160130 19:43:11< celticminstrel> C++11 ranged-for.
20160130 19:43:20< celticminstrel> aka foreach
20160130 19:44:32< vultraz> c++ 11 y u look so nice :(
20160130 19:45:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 19:46:08-!- gfgtdf [~chatzilla@f050178198.adsl.alicedsl.de] has joined #wesnoth-dev
20160130 19:48:05< vultraz> celticminstrel: im wondering... how come you can't initialize a stingstream and add to it on the same line
20160130 19:48:09< vultraz> hey gfgtdf 
20160130 19:48:58< gfgtdf> hi
20160130 19:50:59< celticminstrel> vultraz: You can actually.
20160130 19:51:08< celticminstrel> Though I think only with a string.
20160130 19:51:44< celticminstrel> You could also probably do something like (stringstring() << fixed << d).str().
20160130 19:51:59< celticminstrel> Oh right, probably use ostringstream instead.
20160130 19:52:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 19:52:22< celticminstrel> Not that it matters. ostreamstream is output-only, stringstream can also be read from with >>
20160130 19:54:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 19:55:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 19:56:03< vultraz> damn, doesn't work
20160130 19:56:43< vultraz> says basic_ostring has no member named str()
20160130 19:56:55< vultraz> (also should I be looping over the vector with this?)
20160130 19:57:26< celticminstrel> You missed stream in the typename.
20160130 19:57:45< vultraz> 	return (std::ostringstream() << std::fixed << speed).str();
20160130 19:57:49< celticminstrel> You don't need to loop over the vector. Just output turbo_whatever.
20160130 19:57:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 19:58:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 19:58:28< vultraz> error: 'std::basic_ostream<char>::__ostream_type {aka class std::basic_ostream<char>}' has no member named 'str'|
20160130 19:58:57< vultraz> gfgtdf: did you see my message about the selection event not happening on all areas of the toggle panel in the tree view?
20160130 19:59:13< gfgtdf> vultraz: no
20160130 19:59:18-!- travis-ci [~travis-ci@ec2-54-144-234-46.compute-1.amazonaws.com] has joined #wesnoth-dev
20160130 19:59:19< travis-ci> wesnoth/wesnoth#8348 (master - da53084 : Nils Kneuper): The build passed.
20160130 19:59:19< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/105915360
20160130 19:59:19-!- travis-ci [~travis-ci@ec2-54-144-234-46.compute-1.amazonaws.com] has left #wesnoth-dev []
20160130 20:05:18< gfgtdf> vultraz: hmm why doesn id_folded here: https://github.com/wesnoth/wesnoth/commit/0d424e9d5dae9f3ed330108800dc2f263bf4ff53#diff-255ebc5ec0800339c02358939074318bR220 return the 'new state' ? thought you set the state a few lined ablow in toggle_->set_value
20160130 20:05:58< shadowm> 16:57:46 <vultraz> Ireturn (std::ostringstream() << std::fixed << speed).str();
20160130 20:06:05< shadowm> Use src/formatter.hpp.
20160130 20:08:20< shadowm> vultraz: Also, I told you to stop doing the weird column of commas thing unless it's for a constructor list.
20160130 20:08:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 20:09:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 20:12:31-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20160130 20:17:24< gfgtdf> does*
20160130 20:17:29-!- Kwandulin [~Miranda@p200300760F69242F788FBCBAC9085FDA.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160130 20:18:30< shadowm>     accl_speeds_.insert(accl_speeds_.end(), speeds, speeds + 12);
20160130 20:18:40< shadowm> You realize that this isn't very future-proof thanks to the magic number in the expression?
20160130 20:19:32< shadowm> You could either use `sizeof(speeds)/sizeof(speeds[0])` or use the null-terminated array idiom.
20160130 20:20:12< shadowm> But the latter would require you to rethink that bit (in particular the types in play, why is it t_string even).
20160130 20:20:16-!- Appleman1234 [~Appleman1@KD119104015094.au-net.ne.jp] has joined #wesnoth-dev
20160130 20:27:44< shadowm> That commit I was looking at was in wesnoth/wesnoth for some reason? What.
20160130 20:27:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 20:29:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 20:35:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 20:37:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 20:48:16< celticminstrel> You can also get the size of an array with template magic.
20160130 20:48:38< shadowm> Uh. How?
20160130 20:49:24< celticminstrel> Type traits - boost::extent I think it's called. (Or std::extent in C++11. I assume the global end() function also uses this sort of method.)
20160130 20:50:11< celticminstrel> But that probably requires decltype or typeof.
20160130 20:50:19< celticminstrel> One of which is nonstandard, the other C++11.
20160130 20:50:46< celticminstrel> The end() method should work however.
20160130 20:51:02< celticminstrel> Not sure if Boost has that anywhere.
20160130 20:51:31< celticminstrel> Anyway, it's possible yes, but probably not worthwhile here until we're using C++11.
20160130 20:52:50< shadowm> I'd appreciate it if you people tried to avoid mentioning C++11 around vultraz.
20160130 20:53:06< shadowm> He's gotten very pushy about it as it is and it's very annoying.
20160130 20:53:23< celticminstrel> (Though the array implementation of end() is probably as simple as, uh... template<typename T, int D> T* end(T (&arr)[D]) {return arr + D;} )
20160130 20:55:18< celticminstrel> (If you think it's sufficiently useful it could probably be added somewhere under a name like "array_end". Or an "array_length" that just returns D.)
20160130 20:55:59< shadowm> Most places where plain arrays are actually used either don't require this or use the null-terminated array idiom.
20160130 20:56:09< celticminstrel> Fair enough.
20160130 20:57:10< shadowm> vultraz: Hey, community guy, I have a community thing that needs to be reviewed: https://forums.wesnoth.org/viewtopic.php?f=16&t=43774
20160130 20:57:25< shadowm> I hope I am communitying it right.
20160130 20:58:21< shadowm> Oops, had Forum Moderators in the link instead of the new group. Fixed.
20160130 20:59:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 21:00:27< celticminstrel> I feel like that should be mentioned on the wiki too... but there's not even a Create Account link... is that because account creation is disabled or because the Wesnoth skin is minimal?
20160130 21:00:51< Aginor> shadowm: is it possible to have more/different/better captcha instead?
20160130 21:01:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 21:01:07< celticminstrel> That was tried already, I think.
20160130 21:01:15< celticminstrel> At least the "more" case.
20160130 21:05:30-!- Appleman1234 [~Appleman1@KD119104015094.au-net.ne.jp] has quit [Ping timeout: 245 seconds]
20160130 21:18:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 21:19:48< shadowm> Aginor: We had a questions captcha.
20160130 21:20:12< shadowm> celticminstrel: There will be a link to the forum topic in the Login page.
20160130 21:20:33< shadowm> And it's because account creation is disabled.
20160130 21:21:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 21:22:28< zookeeper> shadowm, uh, dunno why i didn't think of it earlier, but wouldn't this be the easiest way: simply have one password-style captcha which tells the user to contact <the right people> and then we just tell them the secret answer?
20160130 21:25:11< shadowm> That's not much different from this approach for users.
20160130 21:25:17< zookeeper> true
20160130 21:25:31< shadowm> The only practical difference really is that it opens up the possibility of someone leaking the answer for the bots.
20160130 21:43:41-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160130 21:44:29-!- SpoOkyMagician [~chatzilla@cpe-74-136-45-198.kya.res.rr.com] has joined #wesnoth-dev
20160130 21:45:26-!- irker662 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160130 21:54:38-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20160130 21:59:12-!- ancestral [~ancestral@63.92.240.233] has quit [Client Quit]
20160130 22:06:36-!- Appleman1234 [~Appleman1@KD119104015094.au-net.ne.jp] has joined #wesnoth-dev
20160130 22:12:08-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20160130 22:15:02-!- ancestral [~ancestral@63.92.240.233] has quit [Client Quit]
20160130 22:15:09< zookeeper> aeth, ah, i missed what you had said about mountains. if you really need specific mountain ranges to appear in specific places, then it should be pretty simple to do that as scenario-level rules.
20160130 22:15:40< zookeeper> of course if you need lots of exceptions then it easily becomes unwieldy.
20160130 22:15:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 22:18:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 22:34:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 22:36:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 22:38:50-!- Appleman1234 [~Appleman1@KD119104015094.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20160130 22:39:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 22:39:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 22:42:19-!- irker624 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160130 22:42:19< irker624> wesnoth: ln-zookeeper wesnoth:master 807d7f3a1251 / / (54 files in 3 dirs): Added new desert mountains terrain, by doofus-01 https://github.com/wesnoth/wesnoth/commit/807d7f3a12510ed37f18458e27e26b5c1b2bda5d
20160130 22:46:45-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 245 seconds]
20160130 22:48:10-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160130 22:53:33-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160130 23:05:14-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20160130 23:10:42-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20160130 23:10:57-!- VultCave is now known as vultraz
20160130 23:17:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 23:18:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 23:23:29-!- SpoOkyMagician [~chatzilla@cpe-74-136-45-198.kya.res.rr.com] has quit [Read error: Connection reset by peer]
20160130 23:24:59-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20160130 23:27:57-!- SpoOkyMagician [~chatzilla@cpe-74-136-45-198.kya.res.rr.com] has joined #wesnoth-dev
20160130 23:31:10-!- neverEnough [~nEnough@host58-11-dynamic.16-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20160130 23:32:12-!- shadowm_desktop [ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20160130 23:36:39< neverEnough> [..]/SDL_image/build$ make
20160130 23:36:59< neverEnough> WARNING: 'aclocal-1.13' is missing on your system.
20160130 23:37:33< neverEnough> there is a way to solve it that doesn't include whole system recompilation?
20160130 23:39:50< shadowm> neverEnough: Are you trying to build SDL_image from upstream's mercurial repository?
20160130 23:39:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160130 23:40:30< neverEnough> yes
20160130 23:40:38< neverEnough> debian wheezy looks too old for it
20160130 23:40:59< shadowm> No, that's not the issue. Debian stretch is also "too new" for SDL_image.
20160130 23:41:07< neverEnough> LOL
20160130 23:41:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160130 23:41:26< shadowm> Just make sure you have installed whichever version of autoconf + automake + autowhatever and run SDL_image's autogen.sh script, then configure again.
20160130 23:41:53< shadowm> Otherwise it will always insist on regenerating the toolchain with a specific version of autotools.
20160130 23:42:18< shadowm> autoconf and automake should be all you need to install, I think.
20160130 23:43:08< neverEnough> i'm stuck on this since.. long enough. Thx i'll give it one more chance
20160130 23:44:30-!- Appleman1234 [~Appleman1@KD119104003111.au-net.ne.jp] has joined #wesnoth-dev
20160130 23:46:59-!- SpoOkyMagician [~chatzilla@cpe-74-136-45-198.kya.res.rr.com] has quit [Quit: netflix and chill]
20160130 23:50:51-!- mjs-de [~mjs-de@x4db51a85.dyn.telefonica.de] has quit [Remote host closed the connection]
20160130 23:53:01< neverEnough> YES! YES! YES! thank you very much. There was no mention about autogen anywhere i read
20160130 23:53:31< shadowm> To be fair, it's their fault for leaving their toolchain half-outdated in the soruce tree.
20160130 23:54:09< shadowm> If there wasn't an outdated file in it (according to whatever obscure criteria autotools uses to define this) it wouldn't feel the need to regenerate itself.
20160130 23:55:09< shadowm> The annoying part is that since some of the files that need to be regenerated are versioned (including configure), it'll become a hassle next time you need to pull updates.
20160130 23:55:56< neverEnough> heh i'm noob enough to not understand why the toolchain in my system should matter to get some sources compiled. I couldn't figure it out by myself :(
20160130 23:56:13< shadowm> I don't remember if the other SDL companion libs had the same issue or I just ran autogen.sh preemptively for each of them after wasting 30 minutes on SDL_image.
20160130 23:57:27< neverEnough> since i got SDL compiled with no harm i guess it was not needed. I'm sure it was on _image _ttf and _net. 
20160130 23:57:36< neverEnough> i think _mixer was ok
20160130 23:57:42< shadowm> No, SDL core itself was fine.
20160130 23:58:11< shadowm> It probably goes to show how little upstream cares about the companion libs nowadays.
--- Log closed Sun Jan 31 00:00:33 2016