--- Log opened Wed Feb 03 00:00:54 2016
20160203 00:01:01-!- BPRoberts [6273bd6f@gateway/web/freenode/ip.98.115.189.111] has quit [Client Quit]
20160203 00:08:46-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160203 00:52:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160203 01:13:33< gfgtdf> Rhonda: https://www.wesnoth.org/gettext/ gives me warnings related to https
20160203 01:18:36-!- gfgtdf [~chatzilla@f054056225.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.4/20160105164030]]
20160203 01:25:59-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160203 01:26:07-!- irker566 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160203 01:26:07< irker566> wesnoth: Ignacio R. Morelle website:master 8899e7b97eb8 / gettext.wesnoth.org/ (index.extra.php index.lang.php index.php): gettext.w.o: Use same protocol for page resources and links https://github.com/wesnoth/website/commit/8899e7b97eb8c503a2433717ae0f8dbd135c3882
20160203 01:26:08< irker566> wesnoth: Ignacio R. Morelle website:master a23cd0846bf0 / gettext.wesnoth.org/index.extra.php: gettext.w.o: Remove unexpected HTML comment in PHP code https://github.com/wesnoth/website/commit/a23cd0846bf0df542a129e92b476b67336dab13a
20160203 01:26:09< irker566> wesnoth: Ignacio R. Morelle website:master 37afcb68892f / gettext.wesnoth.org/ (index.extra.php index.lang.php index.php): gettext.w.o: Less generic titles https://github.com/wesnoth/website/commit/37afcb68892f2de2cdb68fed5495b14d9e311777
20160203 01:26:11-!- ShikadiLord is now known as shadowm
20160203 01:26:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20160203 01:28:11< irker566> wesnoth: Ignacio R. Morelle website:master b8094faac349 / gettext.wesnoth.org/index.extra.php: gettext.w.o: Remove unused page https://github.com/wesnoth/website/commit/b8094faac3491c8c0171242bf2e91516146d72a3
20160203 01:28:28< shadowm> gfgtdf: Fixed.
20160203 01:31:03< shadowm> You will see this a lot elsewhere, though, especially on the forums.
20160203 01:36:25< vultraz> gfgtdf: size of the scrollbars
20160203 01:39:18< vultraz> shadowm: why not?
20160203 01:39:30< vultraz> the repeating buttons have no use on touch screens
20160203 01:39:32< shadowm> Because you are trying to paper over a bug instead of fixing it properly.
20160203 01:39:44< shadowm> I don't have a touch screen. Enough said.
20160203 01:40:04< vultraz> Uh
20160203 01:40:09< vultraz> I'm not trying to paper over it
20160203 01:40:27< shadowm> Then fix it without removing functionality.
20160203 01:40:42< vultraz> Having a single column would allow better grid positioning of the bars AND it will look better
20160203 01:41:52< vultraz> with the buttons you end up with them below the header row
20160203 01:42:37< vultraz> which looks even uglier 
20160203 01:43:39< shadowm> That's only because you aren't doing it right.
20160203 01:44:57< vultraz> We discussed this... header grid needs to be outside the purview of the vertical scrollbar 
20160203 01:45:31< vultraz> unless you split the scrollbar grid...
20160203 01:45:59< shadowm> This is what it should be like: http://pastebin.com/gUErEEc1
20160203 01:46:13< shadowm> Both scrollbar grids contain their respective buttons and grooves.
20160203 01:46:40< shadowm> Don't ask me about the footer grid, I literally don't care. I don't know what mordante was thinking when he added support for footers.
20160203 01:46:58< shadowm> The # is an empty cell.
20160203 01:50:08< vultraz> except it wouldn't
20160203 01:50:22< vultraz> wouldn't it be the -> button
20160203 01:50:45< shadowm> Look.
20160203 01:50:56< shadowm> Open a large file in Notepad, disable line wrappin, and tell me what you see.
20160203 01:51:10< shadowm> *wrapping (and possibly shrink the window)
20160203 01:51:57< shadowm> Screw it I'm doing it for you to save time.
20160203 01:54:09< shadowm> https://dl.dropboxusercontent.com/u/21371130/web/screenshots/notepad.png
20160203 01:56:48< vultraz> 404
20160203 01:57:21< shadowm> https://dl.dropboxusercontent.com/u/21371130/screenshots/notepad.png
20160203 01:57:51< vultraz> hmmmmmmmm
20160203 01:57:52< vultraz> ok
20160203 01:58:58< shadowm> Ideas for dealing with the footer that nobody ever uses and really doesn't need to exist as a feature: http://pastebin.com/HJq0yCVV
20160203 02:00:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160203 02:00:38-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds]
20160203 02:00:48< vultraz> should i remove it?
20160203 02:01:56< shadowm> Since you are obviously not going to experiment with alternate uses of it, I'd leave it alone and use one of the footer layout proposals.
20160203 02:02:28< shadowm> A proper list w/headers example: https://dl.dropboxusercontent.com/u/21371130/screenshots/filedlg.png
20160203 02:02:47< shadowm> (Who the hell knows why it's up to me, a Linux user, to show a Windows user how Windows does these things.)
20160203 02:03:32-!- SpoOkyMagician [~chatzilla@cpe-74-136-45-198.kya.res.rr.com] has quit [Quit: welp, i am bored.]
20160203 02:04:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20160203 02:05:34< shadowm> Hopefully I answered all questions that needed to be answered so I can leave again.
20160203 02:36:44-!- gfgtdf [~chatzilla@f054129144.adsl.alicedsl.de] has joined #wesnoth-dev
20160203 02:37:37< gfgtdf> someone here used notepad.exe as a example on how to do something right ? :O
20160203 02:37:59< vultraz> xD
20160203 02:43:26-!- gfgtdf [~chatzilla@f054129144.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.4/20160105164030]]
20160203 03:19:51< vultraz> ugh
20160203 03:20:02< vultraz> can't get the listboxes to display anything anymore :|
20160203 03:49:56< vultraz> ok this problem is more complicated than I thought
20160203 03:52:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160203 03:57:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160203 04:28:59-!- irker566 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160203 05:26:06-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20160203 05:36:44-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160203 06:16:49-!- Kwandulin [~Miranda@p200300760F6924226C0427BF62250E1B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160203 06:18:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160203 06:23:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160203 07:23:35< Rhonda> shadowm: Ah, thanks.  Please hilight me on such responses, wasn't seeing the warning and wondered.  :)
20160203 07:37:58-!- irker699 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160203 07:37:58< irker699> wesnoth: Nils Kneuper wesnoth:master 2aa5a965f9b9 / po/wesnoth-utbs/sv.po: updated Swedish translation https://github.com/wesnoth/wesnoth/commit/2aa5a965f9b958be45cf11096b7a9038aec660f6
20160203 08:14:54-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Quit: ChatZilla 0.9.92-rdmsoft [XULRunner 35.0.1/20150122214805]]
20160203 08:15:10-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160203 08:34:39-!- travis-ci [~travis-ci@ec2-54-158-150-74.compute-1.amazonaws.com] has joined #wesnoth-dev
20160203 08:34:40< travis-ci> wesnoth/wesnoth#8368 (master - 2aa5a96 : Nils Kneuper): The build passed.
20160203 08:34:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/106671522
20160203 08:34:40-!- travis-ci [~travis-ci@ec2-54-158-150-74.compute-1.amazonaws.com] has left #wesnoth-dev []
20160203 08:34:54-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160203 08:40:37-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160203 09:00:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160203 09:04:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds]
20160203 09:27:21< irker699> wesnoth: Andreas Löf wesnoth:guifixes b73cc895ae79 / src/ (events.cpp show_dialog.cpp widgets/widget.cpp widgets/widget.hpp): Fix GUI1 layering and redraws. https://github.com/wesnoth/wesnoth/commit/b73cc895ae79843d830f4bdbd58d65b0460802ad
20160203 09:27:32< Aginor> vultraz: ^^ that's important progress
20160203 09:28:07< Aginor> there's still niggles (and an assertion failure on exit), but this was the hard bit
20160203 09:28:47< vultraz> such a small looking change :)
20160203 09:28:51< vultraz> but progress! 
20160203 09:29:45< vultraz> (not to imply it was a small effort)
20160203 09:30:53< vultraz> Do you think we'll be release-ready by mid-month?
20160203 09:30:59-!- mjs-de [~mjs-de@f048235008.adsl.alicedsl.de] has joined #wesnoth-dev
20160203 09:40:19< Aginor> I'm still not keen on committing to any deadlines, but it's looking promising
20160203 09:40:35< Aginor> tomorrow I'll try to nail the assertion failure so builds become stable again
20160203 09:41:18< Aginor> then there's some minor things to sort out in the display class, GUI2 dialogs undrawing weirdly (should be able to just disable)
20160203 09:41:20-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 245 seconds]
20160203 09:41:43< Aginor> and making sure display buttons are re-created again (so they're resized), but in the right event context (harder)
20160203 09:42:01< Aginor> then I think most of the problems are sorted
20160203 09:43:07< Aginor> I still have quite a lot of stuff going on in my life though, which has an impact on how much time I can spend on wesnoth
20160203 09:44:06< vultraz> No rush :)
20160203 09:44:34< vultraz> I still have a couple rage-inducing GUI2 issues to sort out myself 
20160203 09:44:39< Aginor> :D
20160203 09:44:57< Aginor> it means I can stay away from it :D
20160203 09:45:25< vultraz> * Finding the implementation of the formula variables used in widgets
20160203 09:45:42< vultraz> * Fixing headers being scrolled in listboxes
20160203 09:46:08< vultraz> * Fixed tree view behavior on resize, along with scroll label handling and event propagation 
20160203 09:46:21< vultraz> Fixing*
20160203 09:46:37< vultraz> * Applying layout parameters to the Attack dialog
20160203 09:47:22< vultraz> * Finishing the prefs dialog (99% done)
20160203 09:47:36< Aginor> good job though
20160203 09:47:53< vultraz> If you have any insight on the first/second that would be very useful
20160203 09:47:56< vultraz> er
20160203 09:48:00< vultraz> first/third
20160203 09:49:37< vultraz> especially the first
20160203 09:49:47< vultraz> I can't understand any of the formula code at all
20160203 09:55:59-!- prkc [~prkc@catv-80-99-66-25.catv.broadband.hu] has joined #wesnoth-dev
20160203 10:02:25-!- Kwandulin [~Miranda@p200300760F6924226C0427BF62250E1B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160203 10:02:41< Aginor> vultraz: I haven't looked at it, and I can't look right now
20160203 10:03:05< Aginor> if I have the time, I'm happy to do pair debugging with you tomorrow, otherwise it'll have to wait until Friday or the Weekend
20160203 10:03:13< vultraz> pair debugging?
20160203 10:03:22< Aginor> kind of
20160203 10:03:29< Aginor> figuring things out together
20160203 10:04:06< vultraz> ahh
20160203 10:04:13< vultraz> well im usually around
20160203 10:06:23< Aginor> fair enough
20160203 10:06:34< Aginor> I'll holler when I can pry some time free
20160203 10:06:44< Aginor> and with that, I shall disappear now
20160203 10:06:50< Aginor> have a good evening
20160203 10:21:15-!- travis-ci [~travis-ci@ec2-54-159-173-254.compute-1.amazonaws.com] has joined #wesnoth-dev
20160203 10:21:16< travis-ci> wesnoth/wesnoth#8369 (guifixes - b73cc89 : Andreas Löf): The build is still failing.
20160203 10:21:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/106689761
20160203 10:21:16-!- travis-ci [~travis-ci@ec2-54-159-173-254.compute-1.amazonaws.com] has left #wesnoth-dev []
20160203 10:34:30-!- Kwandulin [~Miranda@p200300760F6924E66CCF9E4817B2247D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160203 10:43:20-!- prkc [~prkc@catv-80-99-66-25.catv.broadband.hu] has quit [Ping timeout: 252 seconds]
20160203 10:44:45-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160203 10:56:23-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160203 11:21:29-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160203 11:27:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160203 11:31:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds]
20160203 12:06:00-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160203 12:27:39-!- irker699 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160203 12:30:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160203 12:35:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds]
20160203 12:35:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160203 12:58:50-!- Kwandulin [~Miranda@p200300760F6924E66CCF9E4817B2247D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160203 13:25:03-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160203 13:50:28-!- gfgtdf [~chatzilla@f054129144.adsl.alicedsl.de] has joined #wesnoth-dev
20160203 13:51:15< gfgtdf> vultraz: does your pr remove the old prefences dialog or does it make teh new prferences dialog optional ?
20160203 14:05:05< gfgtdf> 20160203 09:45:42< vultraz> * Fixing headers being scrolled in listboxes
20160203 14:05:23< gfgtdf> vultraz: this is not that easy, note that there is alsoa bugreport for it https://gna.org/bugs/?23752
20160203 14:14:09< vultraz> gfgtdf: it removed the old dialog
20160203 14:18:44< vultraz> gfgtdf: yes ik it's difficult. I think the problem is the reliance on content_grid(). Somehow the scrollbars have to be bound to the content grid (grid with id = "_content_grid"
20160203 14:20:39< vultraz> but there has to be a different content grid for horizontal and vertical scrollbars 
20160203 14:22:05< vultraz> also the actual list doesn't seem to get set up properly if you remove the header from the content grid
20160203 14:23:04< vultraz> but im not sure exactly 
20160203 14:24:14< vultraz> I think what needs to be done is a couple nested grids
20160203 14:24:25< vultraz> and bind different ones to different scrollbars
20160203 14:25:07< vultraz> so like
20160203 14:25:24< vultraz> the vertical scrollbar would affect the list + footer
20160203 14:25:36< vultraz> horizontal would affect header + list +  footer
20160203 14:25:45< vultraz> (or maybe I'll move the header somewhere else)
20160203 14:25:53< vultraz> er, move the footer
20160203 14:28:18-!- Kwandulin [~Miranda@p200300760F6924E6554E8447D56FCCB0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160203 14:29:43-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160203 15:44:24-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 250 seconds]
20160203 15:49:48-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160203 15:54:30-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160203 15:56:56-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20160203 15:57:53-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20160203 15:57:53-!- wedge010 is now known as wedge009
20160203 15:58:26-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160203 16:02:05-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160203 16:14:34-!- gfgtdf [~chatzilla@f054129144.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20160203 16:29:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160203 16:31:14-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160203 16:31:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20160203 16:32:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160203 16:33:21-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20160203 16:35:58-!- Kwandulin [~Miranda@p200300760F6924E6554E8447D56FCCB0.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160203 16:49:08-!- gfgtdf [~chatzilla@f054129144.adsl.alicedsl.de] has joined #wesnoth-dev
20160203 16:58:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160203 17:00:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160203 17:03:17-!- Kwandulin [~Miranda@p200300760F6924E64963167D8FE6350E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160203 17:22:18-!- practicing01 [266b5b84@gateway/web/cgi-irc/kiwiirc.com/ip.38.107.91.132] has joined #wesnoth-dev
20160203 17:22:30< practicing01> hello
20160203 17:25:12< vultraz> allos
20160203 17:25:35< practicing01> i'm looking for a game designer partner.  i'm a programmer
20160203 17:26:38< vultraz> oh?
20160203 17:27:08< practicing01> yea.   i need help with unity abilities.  preview: http://img.ctrlv.in/img/16/02/03/56b2384607645.png
20160203 17:27:51< practicing01> oops type, not unity.  unit****
20160203 17:29:01< practicing01> 215 units is too much for me to deal with in a small time frame :(
20160203 17:29:08-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 248 seconds]
20160203 17:29:24< vultraz> So you're asking someone else to dedicate time to come up with abilities for 215 units?
20160203 17:30:37< practicing01> yep.  i'll code it and deal with the graphics that aren't done.  i'm not asking for a  long time though, i'm asking for a design that will be able to deal with 215 units in a short time
20160203 17:31:02< vultraz> generalize 
20160203 17:31:05< vultraz> reduce
20160203 17:31:48< vultraz> 215 unique units is too many for any game
20160203 17:33:21< practicing01> alrighty
20160203 17:33:24-!- practicing01 [266b5b84@gateway/web/cgi-irc/kiwiirc.com/ip.38.107.91.132] has left #wesnoth-dev []
20160203 17:33:41< vultraz> wellthen
20160203 17:47:05-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160203 17:47:11-!- boucman_work [~jrosen@100.217.26.109.rev.sfr.net] has joined #wesnoth-dev
20160203 17:47:11-!- boucman_work [~jrosen@100.217.26.109.rev.sfr.net] has quit [Client Quit]
20160203 17:49:26-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Client Quit]
20160203 17:59:18-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20160203 18:04:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160203 18:12:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160203 18:25:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160203 18:32:43< gfgtdf> does anyone know when the small_profile= key  in [unit_type]is used ? icannot find any cfg files in mainline that use it.
20160203 18:32:52< gfgtdf> you think i can remove it ?
20160203 18:34:11< Ravana_> Archaic Era uses it a lot
20160203 18:34:35< Ravana_> like small_profile="portraits/cloak.png~CROP(1,1,256,256)~SCALE(205,205)"
20160203 18:35:20< gfgtdf> Ravana_: hmm when is it used?
20160203 18:35:55< Ravana_> for most, if not all, units there
20160203 18:36:05< gfgtdf> Ravana_: according to a commit related, its only used by help is that true ?
20160203 18:36:21< Ravana_> I believe so
20160203 18:38:46< Ravana_> from core, ogres also use it
20160203 18:41:15< gfgtdf> Ravana_: hmm can't find it https://github.com/wesnoth/wesnoth/blob/master/data/core/units/ogres/Young_Ogre.cfg
20160203 18:41:44< Ravana_> I guess it was removed then, I checked from 1.13.1
20160203 18:42:09< gfgtdf> Ravana_: oh ok i think vultraz removed it
20160203 18:42:32< gfgtdf> vultraz: any opinion on removing suport for the small_profile key on [unit_type]s?
20160203 18:46:31< gfgtdf> hm ok seems liek it really has some uses in archaic era
20160203 18:53:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160203 18:53:46< vultraz> gfgtdf: I want to remove it and use scaled portraits in the help browser
20160203 18:55:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160203 18:55:17< vultraz> gfgtdf: I removed the small_profile uses in mainline, I think
20160203 18:56:22< vultraz> gfgtdf: the only place its used is help browser portraits
20160203 18:56:38< gfgtdf> vultraz: hmm you sure that scaling looks good ?
20160203 18:56:51< gfgtdf> vultraz: specially when scaling up i mean.
20160203 18:57:02< vultraz> well a few portraits had manual cropping for their help browser variations 
20160203 18:57:29< vultraz> gfgtdf: scaling up? you don't need to scale up. you need to scale down
20160203 18:57:54< gfgtdf> vultraz: how do you know this?
20160203 18:58:06< vultraz> because small profile portraits are always 205x205
20160203 18:58:18< vultraz> transparent portraits are always bigger
20160203 18:58:30< gfgtdf> vultraz: why are they always bugger?
20160203 18:58:32< gfgtdf> bigger
20160203 18:58:42< vultraz> because they wanted smaller versions for the help browser
20160203 18:59:03< vultraz> the only reason to preserve that key is for manual cropping before scaling 
20160203 18:59:52< gfgtdf> vultraz: no, my question was how do you know that profiles are at least 205x205
20160203 19:00:08< vultraz> standards
20160203 19:01:06< vultraz> no one would provide a smaller portrait
20160203 19:03:07< gfgtdf> vultraz: hmm i coudnt find that on teh haelpt page, and if i'd have to make protrit for a snake i't likeley be 250*50 or something  like that.
20160203 19:06:16-!- Kwandulin [~Miranda@p200300760F6924E64963167D8FE6350E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160203 19:07:08< vultraz> eh..
20160203 19:07:18< vultraz> a good portrait would not be so flat
20160203 19:08:40< vultraz> gfgtdf: BTW ... is it really necessary to use either dynamic polymorphism or runtime overloads like you suggested for my disambiguate_widget_value() function? I'd really rather leave it as-is
20160203 19:09:20< vultraz> it works and i don't think it harms anything
20160203 19:09:22< gfgtdf> vultraz: no the overloads are complie time things.
20160203 19:09:42< gfgtdf> vultraz: well but its quite ugly.
20160203 19:10:56< vultraz> removing the template means i have to add an extra variable just for the else block
20160203 19:13:06< gfgtdf> vultraz: you see, the reason why template acruments are used in suhc codes T there is becasue we want to use the information the we have at complie time and call the function from dependent on T. But then inside the function you completeley ignore the information in T and throw dynamic_cast at that this problem. 
20160203 19:13:35-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160203 19:13:42< vultraz> gfgtdf: well isn't dynamic_cast the only way to check the type of T?
20160203 19:14:16< gfgtdf> vultraz: no you coudl also use overloads/template specilisations. This youdl remove the ifs and also the dynamic casts.
20160203 19:14:35< vultraz> hmm
20160203 19:15:00< gfgtdf> would*
20160203 19:15:07< vultraz> i might use the latter just to have a default fallback
20160203 19:16:01< gfgtdf> vultraz: why soudl you need a fallback ?
20160203 19:16:14< vultraz> safety 
20160203 19:16:44< vultraz> i used to use it for the sliders then i discovered sliders have their own string getter
20160203 19:16:56< vultraz> so right now the else block is unused
20160203 19:17:05< vultraz> but i think it's a good safety net
20160203 19:18:26< gfgtdf> vultraz: no, such unused code just confused people who read it.
20160203 19:19:03< vultraz> hm
20160203 19:20:04< vultraz> ok ill remove the fallback
20160203 19:20:40< vultraz> i think i can probably use plain overloads then
20160203 19:24:57< gfgtdf> ok
20160203 19:27:04< ancestral> Running into build issues with homebrew
20160203 19:28:02< ancestral> https://paste.ee/p/wnk3Y
20160203 19:30:34-!- esr [~esr@wesnoth/developer/esr] has quit [Read error: Connection reset by peer]
20160203 19:31:59-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20160203 19:31:59-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20160203 19:31:59-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20160203 19:39:59< vultraz> gfgtdf: done
20160203 19:41:38< vultraz> gfgtdf: is there anything else I should fix?
20160203 19:43:16< gfgtdf> vultraz: not that i currently see
20160203 19:43:20< vultraz> ok
20160203 19:43:34< vultraz> shadowm: ^ if you have no objections I'll merge soon
20160203 19:53:08 * zookeeper finds it'd be useful to be able to somehow view how the engine sees animation branching via [if]s
20160203 19:55:04< zookeeper> it's just pretty awkward to try to expand that stuff in your head when figuring out why your various [if]s fail to work right
20160203 20:26:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160203 20:26:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160203 21:08:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160203 21:20:36-!- gfgtdf [~chatzilla@f054129144.adsl.alicedsl.de] has quit [Ping timeout: 248 seconds]
20160203 21:31:58-!- gfgtdf [~chatzilla@f054129144.adsl.alicedsl.de] has joined #wesnoth-dev
20160203 21:40:38-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160203 21:43:40-!- Appleman1234 [~Appleman1@KD119104006003.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20160203 21:50:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160203 21:55:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160203 21:59:27< shadowm> vultraz: Big objection: I'll review it first. If it passes review then you can decide whether to merge it or not.
20160203 22:00:08< shadowm> Rhonda: Okay, sure. How was FOSDEM btw? Saw any of our Wesnoth devs?
20160203 22:00:49-!- irker987 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160203 22:00:49< irker987> wesnoth: gfgtdf wesnoth:master 5caa9dd95b57 / data/lua/wml/items.lua: cleanup wml_actions.store_items https://github.com/wesnoth/wesnoth/commit/5caa9dd95b57b17bc776ad80fb4b98fbac23256c
20160203 22:00:49< irker987> wesnoth: gfgtdf wesnoth:master f95e23e7f8a5 / src/ (unit.cpp unit_types.hpp): fix [event]s in [unit_type] https://github.com/wesnoth/wesnoth/commit/f95e23e7f8a5c4d72c8b7ab3613c6d0d7469cbc7
20160203 22:00:50< irker987> wesnoth: gfgtdf wesnoth:master 63088bca6293 / src/ (unit.cpp unit_types.cpp): remove do_not_list from unit configs. https://github.com/wesnoth/wesnoth/commit/63088bca62939cf48ddbd06741707cdfd53ddd7d
20160203 22:00:51< irker987> wesnoth: gfgtdf wesnoth:master 694d43fbec5b / src/ai/contexts.cpp: fix crash in ai code https://github.com/wesnoth/wesnoth/commit/694d43fbec5be38c4f9381614a82834e040c0554
20160203 22:00:52< irker987> wesnoth: gfgtdf wesnoth:master 5deea2eb16eb / src/ (scripting/game_lua_kernel.cpp unit.cpp unit.hpp unit_types.hpp): small unit class refactor https://github.com/wesnoth/wesnoth/commit/5deea2eb16ebe4e717d4f4c02597081f202549e0
20160203 22:00:53< irker987> wesnoth: gfgtdf wesnoth:master eb86032d9c44 / src/unit.cpp: remove 'image_icon' and 'image' from units cfg_ https://github.com/wesnoth/wesnoth/commit/eb86032d9c442964ea528c2676e90b6c8d1649e8
20160203 22:00:55< irker987> wesnoth: gfgtdf wesnoth:master 3530cbf496cd / src/ (unit.cpp unit.hpp): remove cfg_ member from unit class https://github.com/wesnoth/wesnoth/commit/3530cbf496cd4ad7f3fb533980ae80eb12513025
20160203 22:00:57< irker987> wesnoth: gfgtdf wesnoth:master 1f8d36306b4e / src/unit.cpp: fix apply_to=new_advancement https://github.com/wesnoth/wesnoth/commit/1f8d36306b4e2753034b2446a94d62637ec7b12b
20160203 22:00:59< irker987> wesnoth: gfgtdf wesnoth:master 4fd79541960c / src/unit.cpp: Optimize unit attributes check https://github.com/wesnoth/wesnoth/commit/4fd79541960c82fb87bd6b4d537b77673b709cc4
20160203 22:01:01< irker987> wesnoth: gfgtdf wesnoth:master de0ad5e92af0 / src/ (scripting/game_lua_kernel.cpp unit.hpp): make unit.upkeep modifyable by lua. https://github.com/wesnoth/wesnoth/commit/de0ad5e92af04bdb8e60bea657262658824c6e0f
20160203 22:05:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160203 22:10:13< vultraz> shadowm: alright. I'll wait
20160203 22:11:05-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 260 seconds]
20160203 22:29:34-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160203 22:40:18-!- Appleman1234 [~Appleman1@KD119104015002.au-net.ne.jp] has joined #wesnoth-dev
20160203 22:48:05-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160203 23:14:14-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Ping timeout: 250 seconds]
20160203 23:18:35-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160203 23:28:59-!- midzer [~quassel@p4FFCE8C5.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
20160203 23:41:12-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20160203 23:59:35-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 260 seconds]
--- Log closed Thu Feb 04 00:00:56 2016