--- Log opened Thu Feb 04 00:00:56 2016
20160204 00:08:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds]
20160204 00:49:31-!- mjs-de [~mjs-de@f048235008.adsl.alicedsl.de] has quit [Remote host closed the connection]
20160204 01:01:03-!- irker987 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160204 01:05:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 272 seconds]
20160204 01:12:06-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 240 seconds]
20160204 01:22:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160204 01:22:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160204 01:56:26< ancestral> Okay, I figured out what’s causing the font issue on the Mac
20160204 01:56:48< ancestral>  /data/hardwired/fonts.cfg
20160204 01:57:03< ancestral> family_order=_ "DejaVu Sans,Andagii,Droid Sans Japanese,Droid Sans Fallback,Junicode"
20160204 01:57:44< ancestral> If I change that to `family_order=_ "DejaVu Sans”` fonts work fine
20160204 01:58:39< ancestral> (at least, Latin fonts work fine…)
20160204 02:08:19< shadowm> That's not a fix, that just means that something can't andle the commas on OS X.
20160204 02:10:31< shadowm> The string gets passed to pango_font_description_set_family() from Pango, so it's presumably a problem with Pango.
20160204 02:10:33< ancestral> I didn’t say it was a fix
20160204 02:10:56< shadowm> I know, but I have to state that anyway in case someone is planning to rush a "fix".
20160204 02:11:39< shadowm> It sounds somewhat related to the discussion on bug #21649.
20160204 02:12:00< shadowm> http://gna.org/bugs/?21649#comment5 and newer comments.
20160204 02:13:12< shadowm> The root of these issues probably is that the Gnome stack devs never test their stuff on any environment other than Linux/X11.
20160204 02:14:53< shadowm> "In some uses of PangoFontDescription, it is also possible to use a comma separated list of family names for this field." Such clear documentation.
20160204 02:18:14< ancestral> Wesnoth looks like shit in OS X FWIW
20160204 02:18:33< ancestral> Until this is resolved
20160204 02:18:49< shadowm> Helvetica == crap now?
20160204 02:18:50-!- gfgtdf_ [~chatzilla@f054159007.adsl.alicedsl.de] has joined #wesnoth-dev
20160204 02:19:08< ancestral> Helvetica is fine, but how it renders it looks like shit
20160204 02:19:21< shadowm> Screenshot?
20160204 02:19:30< shadowm> Because "how it renders" is probably due to an intentional change I did.
20160204 02:19:34< ancestral> Deja Vu Sans and Helvetica do not render at the same sizes and metrics
20160204 02:19:41< ancestral> Gladly, one moment
20160204 02:20:05< shadowm> Oh, you don't mean the hint style. Never mind then.
20160204 02:20:46< shadowm> With the Preferences and attack dialogs going GUI2 though there'll be less places using DejaVu Sans with this bug.
20160204 02:20:54-!- gfgtdf [~chatzilla@f054129144.adsl.alicedsl.de] has quit [Ping timeout: 252 seconds]
20160204 02:21:00-!- gfgtdf_ is now known as gfgtdf
20160204 02:21:22< shadowm> Though I guess you can make a point about the GUI1 buttons using a different font than the rest of the in-game UI.
20160204 02:21:33< shadowm> Regardless, it's starting to sound like a bug in Pango, not Wesnoth.
20160204 02:23:42< ancestral> That may be true
20160204 02:24:07< ancestral> But the text is too small to be useful as-is
20160204 02:24:20< ancestral> Putting together screenshots
20160204 02:43:15-!- gfgtdf [~chatzilla@f054159007.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.4/20160105164030]]
20160204 02:50:53< ancestral> Okay
20160204 02:51:09< ancestral> shadowm: http://mproud.com/wesnoth/font-comparison.jpg
20160204 02:51:58< ancestral> (@90% JPG; should be enough to illustrate the point. If you want PNG, let me know, but it’d be 13 MB)
20160204 02:53:38< ancestral> Top: Helvetica; Bottom: Deja Vu Sans
20160204 02:53:46< ancestral> Bah, I clipped the top of the game window
20160204 02:58:44< ancestral> Updated
20160204 03:03:17-!- SpoOkyMagician [~chatzilla@cpe-74-136-45-198.kya.res.rr.com] has joined #wesnoth-dev
20160204 03:04:36< shadowm> Yeah okay I've seen this before.
20160204 03:05:32< shadowm> It's perfectly readable to me though, not sure what that says about anything.
20160204 03:05:47< ancestral> Uhh
20160204 03:06:27< ancestral> The numbers at the top of the game window are tricky to make out, especially on monitors with high dpi
20160204 03:06:56< shadowm> They look fine to me other than their baseline being too high.
20160204 03:07:33< ancestral> The stats on the right are much harder to read; the hex position, the damage and number of attacks
20160204 03:07:44< ancestral> Can barely make out “Grassland”
20160204 03:07:55< ancestral> (though honestly, the other isn’t much better)
20160204 03:08:07< ancestral> 0’s look like shit
20160204 03:08:41< ancestral> Large amounts of text is not very legible\
20160204 03:09:39< ancestral> The Multiplayer button looks like a series of vertical lines
20160204 03:09:41< shadowm> Don't expect me to agree with you any time soon. I don't see a high-DPI screen as a necessary investment and I grew up in a world where antialasing didn't exist.
20160204 03:09:57< shadowm> My standards are definitely not the same as the average Apple user.
20160204 03:10:11< ancestral> Stop with this
20160204 03:10:17< ancestral> This isn’t Mac vs. Eveyrone else
20160204 03:10:43< ancestral> This is 13 inch screens have millions of pixels
20160204 03:10:55< shadowm> Sure, and I'm telling you that I don't see what you see because I don't have the same hardware or taste in font rendering.
20160204 03:10:56< ancestral> Even the standard, non retina 
20160204 03:11:09< ancestral> Got it, you’re not affected by this
20160204 03:11:31< ancestral> Anything else?
20160204 03:11:58< shadowm> We agreed something like a year ago that this was an issue that needed to be fixed.
20160204 03:12:18< ancestral> And I’m happy to report I have found the root of the issue just now
20160204 03:12:23< ancestral> That is all
20160204 03:12:47< ancestral> Also, the Icelandic .po file is bad
20160204 03:13:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160204 03:13:33< shadowm> And I mentioned that it sounds somewhat similar to the newline issue in that it also deals with font lists.
20160204 03:14:32< shadowm> I also mentioned that the upstream documentation doesn't really go into enough detail about the intended usage (which means that it's not really possible to decide whose fault it is until someone on an affected platform starts digging around).
20160204 03:14:33< ancestral> Thanks for the info
20160204 03:16:23< shadowm> The bottomline is that it looks generally bad, but not universally bad enough so as to warrant the language employed, or blocking further releases in the event that the issue remains unsolved.
20160204 03:17:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160204 03:44:18-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160204 03:50:40-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 250 seconds]
20160204 04:10:20-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160204 04:13:00-!- EliDupree_ [~quassel@idupree.com] has quit [Read error: Connection reset by peer]
20160204 04:13:56-!- EliDupree [~quassel@idupree.com] has joined #wesnoth-dev
20160204 04:15:05-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 260 seconds]
20160204 04:18:49-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has quit [Ping timeout: 260 seconds]
20160204 04:18:49-!- Yaiyan [~Yaiyan@46.101.48.31] has quit [Ping timeout: 260 seconds]
20160204 04:18:49-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 260 seconds]
20160204 04:19:08-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20160204 04:19:13-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20160204 04:19:14-!- lobby [~wesnoth@wesnoth/bot/lobby] has quit [Ping timeout: 263 seconds]
20160204 04:19:25-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev
20160204 04:19:25-!- Topic for #wesnoth-dev: Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160204 04:19:25-!- Topic set by shadowm [~ignacio@wesnoth/developer/shadowm] [Sun Jan 17 05:24:23 2016]
20160204 04:19:25[Users #wesnoth-dev]
20160204 04:19:25[ _laco          ] [ elias    ] [ knotwork_   ] [ Rhonda        ] 
20160204 04:19:25[ aeonchild      ] [ EliDupree] [ legoktm     ] [ shadowm       ] 
20160204 04:19:25[ aeth           ] [ Elsi     ] [ lobby       ] [ shikadibot_   ] 
20160204 04:19:25[ Aginor         ] [ esr      ] [ Lohengramm  ] [ Soliton       ] 
20160204 04:19:25[ AI0867_        ] [ Gambit   ] [ loonycyborg ] [ SpoOkyMagician] 
20160204 04:19:25[ aidanhs        ] [ Greywhind] [ matthiaskrgr] [ TC01          ] 
20160204 04:19:25[ ancestral      ] [ heirecka ] [ molgrum_    ] [ TheJJ         ] 
20160204 04:19:25[ Appleman1234   ] [ higgins  ] [ new_one     ] [ timotei__     ] 
20160204 04:19:25[ avtobiff       ] [ Ivanovic ] [ nurupo      ] [ tomreyn       ] 
20160204 04:19:25[ clavi          ] [ iwaim    ] [ oldlaptop   ] [ vincent_c     ] 
20160204 04:19:25[ Crendgrim      ] [ janebot  ] [ pydsigner   ] [ wedge009      ] 
20160204 04:19:25[ crimson_penguin] [ Jetrel   ] [ quentinp_   ] [ ypnos         ] 
20160204 04:19:25[ DDR            ] [ kidneb   ] [ Ravana_     ] [ {V}           ] 
20160204 04:19:25-!- Irssi: #wesnoth-dev: Total of 52 nicks [0 ops, 0 halfops, 0 voices, 52 normal]
20160204 04:19:39-!- Channel #wesnoth-dev created Tue Jan 27 05:28:41 2009
20160204 04:19:41-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer]
20160204 04:19:43-!- Grickit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20160204 04:19:46-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 260 seconds]
20160204 04:19:46-!- {V} [~V@105-70-ftth.on.nl] has quit [Ping timeout: 260 seconds]
20160204 04:19:46-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 260 seconds]
20160204 04:19:52-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has joined #wesnoth-dev
20160204 04:20:21-!- {V} [~V@105-70-ftth.on.nl] has joined #wesnoth-dev
20160204 04:20:36-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20160204 04:20:37-!- Irssi: Join to #wesnoth-dev was synced in 81 secs
20160204 04:20:59-!- Yaiyan [~Yaiyan@46.101.48.31] has joined #wesnoth-dev
20160204 04:21:14-!- heirecka [~heirecka@j61898.servers.jiffybox.net] has joined #wesnoth-dev
20160204 04:21:14-!- heirecka [~heirecka@j61898.servers.jiffybox.net] has quit [Changing host]
20160204 04:21:14-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20160204 04:53:17-!- SpoOkyMagician [~chatzilla@cpe-74-136-45-198.kya.res.rr.com] has quit [Quit: eh]
20160204 05:00:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160204 05:00:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160204 05:14:52-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 272 seconds]
20160204 05:21:32-!- iwaim [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20160204 05:30:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160204 05:30:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160204 06:00:19< shadowm> ancestral: I approved your membership request.
20160204 06:01:04< shadowm> Our bug handling policy of sorts is here: https://wiki.wesnoth.org/ReportingBugs#Bug_protocol
20160204 06:02:12< shadowm> As for bug search options, to my knowledge they are the same for group members/other users/anonymous sessions.
20160204 06:13:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160204 06:14:25-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160204 06:16:51-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20160204 06:17:54-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20160204 06:17:55-!- VultCave is now known as vultraz
20160204 06:17:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20160204 06:18:21-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20160204 06:18:21-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160204 06:18:26 * vultraz pings Aginor
20160204 06:19:04< vultraz> Aginor: im around for about 2 hours 
20160204 06:25:47 * Aginor pongs vultraz 
20160204 06:26:23-!- irker537 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160204 06:26:23< irker537> wesnoth: Charles Dang wesnoth:master 5370e7017d43 / src/gui/widgets/slider.cpp: tslider: exclude status label (right offset) from orthogonal range check https://github.com/wesnoth/wesnoth/commit/5370e7017d439b19836fa6d904431314f7366533
20160204 06:26:26< irker537> wesnoth: Charles Dang wesnoth:master b491950444fc / data/gui/default/window/unit_attack.cfg: tunit_attack: some layout formatting https://github.com/wesnoth/wesnoth/commit/b491950444fc55d72bbd112033e60b9b1a45a6fd
20160204 06:26:36< irker537> wesnoth: sigurdfdragon wesnoth:master 92a9164f082d / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: Change text in veteran recall message. https://github.com/wesnoth/wesnoth/commit/92a9164f082d65d024d602b8b4875ad3e191609c
20160204 06:26:38< irker537> wesnoth: sigurdfdragon wesnoth:master 293861f7a025 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: T2: Change to Elvish Archer recruit message. https://github.com/wesnoth/wesnoth/commit/293861f7a025c354fe6a7846d8bb6ac333c8d264
20160204 06:26:40< irker537> wesnoth: sigurdfdragon wesnoth:master 9b978ed59189 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: T2: Fix typos in channel village message. https://github.com/wesnoth/wesnoth/commit/9b978ed59189e175974f6e08a52b5cb882de1757
20160204 06:26:40< Aginor> I am around, but I may need to disappear on short notice in the next little while to pick up woods for a carpentry project (free stuff is good)
20160204 06:26:42< irker537> wesnoth: sigurdfdragon wesnoth:master 883e5ca588b1 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: T2: Add missing period. https://github.com/wesnoth/wesnoth/commit/883e5ca588b1957b216d6471b220caa5a87ff785
20160204 06:26:44< irker537> wesnoth: sigurdfdragon wesnoth:master 528a0cbea61d / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: T2: Add () around skirmisher text to more clearly separate from rest of paragrap https://github.com/wesnoth/wesnoth/commit/528a0cbea61d12295d585cfa00c25ece07df52c2
20160204 06:26:46< irker537> wesnoth: sigurdfdragon wesnoth:master 67c54880c0a2 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: T2: Change to leveled unit recall message. https://github.com/wesnoth/wesnoth/commit/67c54880c0a2ce5510f0cda9502351bc5a86b99d
20160204 06:26:48< irker537> wesnoth: sigurdfdragon wesnoth:master eda3da0d7f85 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: T2: Change ability reference to exactly match ability name. https://github.com/wesnoth/wesnoth/commit/eda3da0d7f8562756d993553d8147f1714b5a6d8
20160204 06:26:50< irker537> wesnoth: Charles Dang wesnoth:master 41a681fd1cb1 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: Merge pull request #586 from sigurdfdragon/Tutorial_Part_2_Typo_Fixes https://github.com/wesnoth/wesnoth/commit/41a681fd1cb19eb1fde3d4db3c89d5964ad774b7
20160204 06:28:08< irker537> wesnoth: Charles Dang wesnoth:master b386c5f819aa / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: T S2: fixed a small typo https://github.com/wesnoth/wesnoth/commit/b386c5f819aa14882a93e3d6daca263974476ad3
20160204 06:28:39< Aginor> in case it was lost int he messages
20160204 06:28:47< vultraz> I saw
20160204 06:28:51< Aginor> I am around, but I may need to disappear on short notice in the next little while to pick up woods for a carpentry project (free stuff is good)
20160204 06:28:59< vultraz> Free stuff is indeed good :)
20160204 06:29:00< Aginor> oh
20160204 06:29:02< Aginor> :D
20160204 06:29:28< vultraz> Well, I was wondering if while you're around you could help me find out where the (width) gui2 formula variable is set
20160204 06:29:39< Aginor> yup, I can give it a go
20160204 06:29:43< vultraz> I'm looking to implement a cell_width/cell_height variable set
20160204 06:30:04< vultraz> since width/height give you the dimensions of the widget
20160204 06:30:10< vultraz> excluding borders 
20160204 06:30:19< Aginor> hmm
20160204 06:30:21< vultraz> so I need some way to include borders
20160204 06:31:04< Aginor> you may want size that includes borders, margins, border width
20160204 06:31:17-!- travis-ci [~travis-ci@ec2-54-159-173-254.compute-1.amazonaws.com] has joined #wesnoth-dev
20160204 06:31:18< travis-ci> wesnoth/wesnoth#8375 (master - b491950 : Charles Dang): The build has errored.
20160204 06:31:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/106919867
20160204 06:31:18-!- travis-ci [~travis-ci@ec2-54-159-173-254.compute-1.amazonaws.com] has left #wesnoth-dev []
20160204 06:31:22< Aginor> which gives you total size and usable size
20160204 06:31:32< Aginor> and my phone just went "bing"
20160204 06:31:47< Aginor> I need to get going, I'm hopefully back in an hour or so
20160204 06:32:09< Aginor> (sorry)
20160204 06:32:11< vultraz> No problem
20160204 06:34:29-!- travis-ci [~travis-ci@ec2-54-90-170-48.compute-1.amazonaws.com] has joined #wesnoth-dev
20160204 06:34:30< travis-ci> wesnoth/wesnoth#8376 (master - 41a681f : Charles Dang): The build has errored.
20160204 06:34:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/106919907
20160204 06:34:30-!- travis-ci [~travis-ci@ec2-54-90-170-48.compute-1.amazonaws.com] has left #wesnoth-dev []
20160204 06:35:46-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: ancestral]
20160204 06:36:16-!- travis-ci [~travis-ci@ec2-54-159-173-254.compute-1.amazonaws.com] has joined #wesnoth-dev
20160204 06:36:17< travis-ci> wesnoth/wesnoth#8377 (master - b386c5f : Charles Dang): The build has errored.
20160204 06:36:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/106920110
20160204 06:36:17-!- travis-ci [~travis-ci@ec2-54-159-173-254.compute-1.amazonaws.com] has left #wesnoth-dev []
20160204 06:41:39< vultraz> dammit, why won't this one commit go through :|
20160204 06:50:12< irker537> wesnoth: Charles Dang wesnoth:master dccec3f4c9d5 / src/unit.cpp: Removed unused variable orphaned in 1f8d36306b4e2753034 https://github.com/wesnoth/wesnoth/commit/dccec3f4c9d5a865737af22de41b9681a027ec26
20160204 06:54:54-!- travis-ci [~travis-ci@ec2-54-166-105-66.compute-1.amazonaws.com] has joined #wesnoth-dev
20160204 06:54:55< travis-ci> wesnoth/wesnoth#8378 (master - dccec3f : Charles Dang): The build has errored.
20160204 06:54:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/106922194
20160204 06:54:55-!- travis-ci [~travis-ci@ec2-54-166-105-66.compute-1.amazonaws.com] has left #wesnoth-dev []
20160204 06:55:49< vultraz> well looks like travis is down
20160204 06:56:21< vultraz> shadowm: see b491950444fc 
20160204 06:56:30< vultraz> shadowm: I'm not sure how to deal with long attack names, though
20160204 06:57:52< vultraz> shadowm: best thing i can think of is measure the name string, and if it's longer than n then find the last space character, truncate it, and insert a '\n    \string
20160204 06:58:10< vultraz> '\n    '
20160204 06:58:12< vultraz> *
20160204 07:37:30< irker537> wesnoth: Charles Dang wesnoth:master eb80320adfb6 / src/help/help_topic_generators.cpp: Flip unit portraits so crop is facing window border https://github.com/wesnoth/wesnoth/commit/eb80320adfb67abb913cf62fc7a7f2fbdb0f56e7
20160204 07:38:14< vultraz> Looks MUCH better
20160204 07:45:55< irker537> wesnoth: Charles Dang wesnoth:master 7455e4cb79a1 / src/help/help.cpp: Slightly reduce help browser width https://github.com/wesnoth/wesnoth/commit/7455e4cb79a1e239e44d3ffebf79f2c175a5dfb5
20160204 07:48:34-!- midzer [~quassel@pD9FA8361.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160204 07:51:15-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160204 07:51:38< vultraz> zookeeper:  https://github.com/wesnoth/wesnoth/commit/eb80320adfb67abb913cf62fc7a7f2fbdb0f56e7
20160204 07:51:48< vultraz> looks much better now
20160204 08:05:37< zookeeper> i see
20160204 08:06:13< vultraz> dunno why I didn't think of that at the time
20160204 08:09:03-!- travis-ci [~travis-ci@54.90.170.48] has joined #wesnoth-dev
20160204 08:09:04< zookeeper> not that i personally care, but you are aware that some portraits were intended to not be flipped (due to symbols on them, etc)?
20160204 08:09:04< travis-ci> wesnoth/wesnoth#8379 (master - eb80320 : Charles Dang): The build has errored.
20160204 08:09:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/106927738
20160204 08:09:04-!- travis-ci [~travis-ci@54.90.170.48] has left #wesnoth-dev []
20160204 08:10:40< vultraz> symbols?
20160204 08:11:01< zookeeper> you know, the SoF on the grand knight and that sort of thing
20160204 08:21:34-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160204 08:22:32< vultraz> doesn't seem to make much difference
20160204 08:22:35< vultraz> Aginor: im off
20160204 08:24:15-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 245 seconds]
20160204 08:24:16-!- wedge010 is now known as wedge009
20160204 08:33:40< Rhonda> shadowm: None.  I'm not even sure if anyone was there.  But it was too crowded anyway, when I was trying to say good bye to some people I still was meeting people I haven't seen yet.
20160204 08:40:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160204 08:44:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds]
20160204 09:12:36-!- travis-ci [~travis-ci@ec2-54-166-105-66.compute-1.amazonaws.com] has joined #wesnoth-dev
20160204 09:12:37< travis-ci> wesnoth/wesnoth#8380 (master - 7455e4c : Charles Dang): The build failed.
20160204 09:12:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/106928862
20160204 09:12:37-!- travis-ci [~travis-ci@ec2-54-166-105-66.compute-1.amazonaws.com] has left #wesnoth-dev []
20160204 09:20:01< Aginor> vultraz: sorry, that took a lot longer than I expected
20160204 09:31:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160204 09:32:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160204 09:37:51< vultraz> Aginor: back now
20160204 09:49:55< Aginor> vultraz: hi
20160204 09:50:06< Aginor> ok, I have a little while now
20160204 09:50:10< Aginor> getting tired though :)
20160204 09:50:39< vultraz> if you'd rather wait for some other time that's fine
20160204 09:50:54< Aginor> depends on what you want help with
20160204 09:51:57< vultraz> well i was still hoping to find the (width)/(height) variables
20160204 09:52:19< vultraz> im also working on this weird bug where under certain circumstances, sliders won't reach max value >_>
20160204 09:52:24< Aginor> of? 
20160204 09:52:31< Aginor> rounding issues?
20160204 09:52:45< vultraz> no, I don't think so
20160204 09:52:53< vultraz> im not sure, really
20160204 09:53:13< vultraz> popped up after 34b7f97658f1a8c96d872b1bf7bc049faae19715
20160204 09:53:24< vultraz> attempted to fix in bf32cca84f169a5c8b2d9e9fc9185467245c4b17
20160204 09:54:57< vultraz> i think it may have something to do with sliders in columns with grow_factor = 0
20160204 09:55:36< vultraz> actually no, scratch that
20160204 09:57:31< Aginor> your atempted fix only reverted the previous commit
20160204 09:57:39< Aginor> was that not successful?
20160204 09:58:09< vultraz> attempted fix didn't revert the previous commit
20160204 09:58:45< vultraz> but yes, reverting the original change does fix the issue
20160204 09:59:59< Aginor> vultraz: are the height and width calculations for sliders too?
20160204 10:00:23< vultraz> height/width are formula variables that can be used in any widget
20160204 10:00:39< vultraz> that's a separate issue I wanted to fix
20160204 10:00:53< vultraz> if you look at a listbox header, it's 'hovered' background doesn't draw in its borders
20160204 10:01:09< vultraz> because i think width/height only accounts for internal space
20160204 10:02:19< vultraz> hm
20160204 10:02:25< vultraz> i think i may have fixed the slider thing
20160204 10:02:58< vultraz> yes, i appear to have done so :D
20160204 10:04:33< Aginor> great
20160204 10:08:43< vultraz> ok, now to get to the formula thing
20160204 10:08:46< irker537> wesnoth: Charles Dang wesnoth:master a7c28ee5016b / data/gui/default/widget/ (slider_default.cfg slider_minimal.cfg): tslider: tweaked slider magic numbers so maximum value is reached https://github.com/wesnoth/wesnoth/commit/a7c28ee5016b6fa9820d0db8c9d1dfed69c36f19
20160204 10:11:04< Aginor> I have absolutly no idea how any of this hangs together :/
20160204 10:11:56< vultraz> me neither
20160204 10:12:28< vultraz> there seems to be a mention of width/height variables in arc/gui/auxiliary/canvas.cpp:1480
20160204 10:12:44< vultraz> variant() seems to be declared in src/variant.hpp
20160204 10:12:50< vultraz> and I don't understand any of that code
20160204 10:14:43< Aginor> vultraz: I *think* that only exposes the internal state to the wml
20160204 10:15:13< vultraz> hm
20160204 10:15:24< vultraz> but what we want is where they are calculated :|
20160204 10:15:30< vultraz> all the variables seem to be of type game_logic::map_formula_callable
20160204 10:15:36< vultraz> which is a whole other monster
20160204 10:16:43-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Quit: Bye]
20160204 10:17:12< vultraz> the fact that game_logic::map_formula_callable is not a gui2 construct makes me wonder
20160204 10:17:27< Aginor> a listbox inherits from a widget...
20160204 10:17:53< Aginor> twidget->tcontainer_->tscrollbar_container->listbox
20160204 10:18:15< Aginor> twidget holds the width and height variables
20160204 10:18:29< Aginor> the listbox recalculates its size requirements when the contents change
20160204 10:18:34< vultraz> hmm...
20160204 10:18:53< vultraz> ok, so is there a way to exclude border size from that calculation, if we wanted?
20160204 10:19:11-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20160204 10:20:14< Aginor> tcontainer_ deals with the border
20160204 10:20:33< vultraz> hmmm
20160204 10:21:03< Aginor> tpoint tcontainer_::border_space() const
20160204 10:21:03< Aginor> { return tpoint(0, 0);
20160204 10:21:04< Aginor> }
20160204 10:21:07< vultraz> yes, this looks promising...
20160204 10:21:18< Aginor> it's a virtual method so you should be able to just override
20160204 10:24:20< vultraz> override border_space()?
20160204 10:27:37< Aginor> yes
20160204 10:28:02< Aginor> set it to a non-zero value to reserve space for it
20160204 10:28:43< Aginor> or when using the set_child method pssibly
20160204 10:29:13< vultraz> well
20160204 10:29:15< Aginor> control.cpp:233 is relevant too
20160204 10:29:26< vultraz> im not sure exactly how to proceed...
20160204 10:29:36< vultraz> the relevant case is the listbox headers' background
20160204 10:29:43< vultraz> which use trectangle
20160204 10:30:00< vultraz> and the width/height variables for the dimensions.
20160204 10:30:12< vultraz> the listbox headers are of class tgenerator
20160204 10:32:32< vultraz> as far as I can tell, the headers/footers are generated in tlistbox::finalize
20160204 10:34:13< vultraz> tgenerator doesn't inherit from tcontainer
20160204 10:40:25-!- travis-ci [~travis-ci@ec2-174-129-107-141.compute-1.amazonaws.com] has joined #wesnoth-dev
20160204 10:40:26< travis-ci> wesnoth/wesnoth#8382 (master - a7c28ee : Charles Dang): The build is still failing.
20160204 10:40:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/106951024
20160204 10:40:26-!- travis-ci [~travis-ci@ec2-174-129-107-141.compute-1.amazonaws.com] has left #wesnoth-dev []
20160204 10:44:13< Aginor> I need to sleep now
20160204 10:44:19< Aginor> good luck :)
20160204 10:45:20< vultraz> will probably wait until tomorrow when you return
20160204 10:45:28< vultraz> gfgtdf: I think you broke the unit tests 
20160204 10:48:10-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160204 11:22:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160204 11:26:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160204 11:52:34< vultraz> gfgtdf: basically every unit attribute is listed as unknown now in stderr
20160204 12:08:49-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160204 12:20:29< zookeeper> as for https://gna.org/bugs/?24366 and the water performance... it's basically entirely the fault of the transitions.
20160204 12:26:02< zookeeper> it ought to be possible to optimize them a lot, i'll see what i can do
20160204 12:48:42< vultraz> spritesheets/procedural would certainly help
20160204 12:49:37-!- zookeeper_ [~lmsnie@37.35.27.57] has joined #wesnoth-dev
20160204 12:53:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20160204 12:53:56-!- Yaiyan [~Yaiyan@46.101.48.31] has quit [Ping timeout: 240 seconds]
20160204 12:53:57-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Ping timeout: 240 seconds]
20160204 12:53:57-!- {V} [~V@105-70-ftth.on.nl] has quit [Ping timeout: 240 seconds]
20160204 12:54:13-!- Yaiyan [~Yaiyan@46.101.48.31] has joined #wesnoth-dev
20160204 12:54:31-!- {V} [~V@105-70-ftth.on.nl] has joined #wesnoth-dev
20160204 12:55:04-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160204 13:02:14-!- ggenerall [~anton@nat3.opti.net.ua] has joined #wesnoth-dev
20160204 13:09:08-!- irker537 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160204 13:15:17-!- irker843 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160204 13:15:17< irker843> wesnoth: Charles Dang wesnoth:master 99697110f5fd / data/gui/default/window/unit_attack.cfg: tunit_attack: draw a line between unit stats https://github.com/wesnoth/wesnoth/commit/99697110f5fd4defdc2dca3d30b4ab887a56c99a
20160204 13:16:41< vultraz> ancestral ^
20160204 13:18:29< vultraz> I didn't realize [drawing] was a thing
20160204 13:19:42-!- Kwandulin [~Miranda@p200300760F6924AD10C6209D436A14BD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160204 13:20:18< irker843> wesnoth: Charles Dang wesnoth:master aad0e02d1058 / data/gui/default/window/addon_list.cfg: taddon_list: strip debug borders https://github.com/wesnoth/wesnoth/commit/aad0e02d1058cc6398ff73698885820a7c948567
20160204 13:22:22< vultraz> interesting...
20160204 13:23:41< vultraz> i may not even need the tree view in preferences....
20160204 13:23:44 * vultraz ponders this
20160204 13:27:30-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 260 seconds]
20160204 13:29:49-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160204 13:36:10-!- gfgtdf [~chatzilla@f054159007.adsl.alicedsl.de] has joined #wesnoth-dev
20160204 13:36:18< gfgtdf> 20160204 11:52:34< vultraz> gfgtdf: basically every unit attribute is listed as unknown now in stderr
20160204 13:36:59< gfgtdf> yes thatsmostlikeley becasue this line https://github.com/wesnoth/wesnoth/blob/master/src/unit.cpp#L126
20160204 13:37:20< gfgtdf> uses boost::begin in thesecond parater whereis uses boost::end
20160204 13:37:38< gfgtdf> so that list desnt really get srted
20160204 13:37:42< gfgtdf> sorted
20160204 13:38:30< gfgtdf> wil fix it when i have access
20160204 13:41:20-!- gfgtdf [~chatzilla@f054159007.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.4/20160105164030]]
20160204 13:42:15-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20160204 13:46:36-!- travis-ci [~travis-ci@ec2-174-129-107-141.compute-1.amazonaws.com] has joined #wesnoth-dev
20160204 13:46:37< travis-ci> wesnoth/wesnoth#8384 (master - 9969711 : Charles Dang): The build is still failing.
20160204 13:46:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/106983532
20160204 13:46:37-!- travis-ci [~travis-ci@ec2-174-129-107-141.compute-1.amazonaws.com] has left #wesnoth-dev []
20160204 13:52:48-!- zookeeper_ is now known as zookeeper
20160204 13:52:53-!- zookeeper [~lmsnie@37.35.27.57] has quit [Changing host]
20160204 13:52:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160204 14:07:51-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160204 14:23:22-!- aidanhs [~aidanhs@81.4.110.234] has quit [Ping timeout: 250 seconds]
20160204 14:29:42-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20160204 14:39:53< vultraz> YES I think this will work
20160204 14:43:59-!- ggenerall [~anton@nat3.opti.net.ua] has left #wesnoth-dev []
20160204 14:57:55-!- mjs-de [~mjs-de@x4db62fa9.dyn.telefonica.de] has joined #wesnoth-dev
20160204 15:20:50-!- Grickit is now known as Gambit
20160204 15:42:49< vultraz> bye bye tree view
20160204 16:13:18< vultraz> bleh. grids don't have a remove_row function?
20160204 16:20:42-!- irker843 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160204 16:26:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160204 16:26:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160204 16:27:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160204 16:30:16-!- irker652 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160204 16:30:16< irker652> wesnoth: gfgtdf wesnoth:master 29db0593eeaa / src/unit.cpp: fix unit unknown attribute warning. https://github.com/wesnoth/wesnoth/commit/29db0593eeaafaa660728ecae317cfcf9abc6a40
20160204 16:35:47< vultraz> gfgtdf: could you help me with something? for some reason I can't use swap_child on the grid returned by tlistbox::get_row_grid()
20160204 16:44:58< Soliton> "There's only a const version since allowing callers to modify the grid behind our backs might give problems."
20160204 16:46:42< vultraz> Right under that is a non-const version
20160204 17:02:47< Soliton> if that's what you're using you may want to give a tiny bit more detail about your issue.
20160204 17:04:24< vultraz> well, uh... I assume the line "tgrid* main_grid = advanced.get_row_grid(this_row);" would use the non-const versions of get_row_grid, right?
20160204 17:04:36< vultraz> (advanced being a tlistbox object)
20160204 17:05:01< vultraz> er, reference
20160204 17:05:37< Soliton> if advanced is non-const. otherwise the compiler will complain.
20160204 17:06:01< vultraz> right
20160204 17:08:25-!- travis-ci [~travis-ci@ec2-54-90-170-48.compute-1.amazonaws.com] has joined #wesnoth-dev
20160204 17:08:26< travis-ci> wesnoth/wesnoth#8386 (master - 29db059 : gfgtdf): The build is still failing.
20160204 17:08:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/107029177
20160204 17:08:26-!- travis-ci [~travis-ci@ec2-54-90-170-48.compute-1.amazonaws.com] has left #wesnoth-dev []
20160204 17:09:28< vultraz> thing is, if I call something using main_grid (for example "main_grid->remove_child("pref_setter_grid");" )... nothing happens. no errors, just nothing happening
20160204 17:15:00< vultraz> i can use it to find other widgets fine, but performing operations on the grid does nothing
20160204 17:21:49-!- EliDupree [~quassel@idupree.com] has quit [Remote host closed the connection]
20160204 18:23:34-!- mjs-de [~mjs-de@x4db62fa9.dyn.telefonica.de] has quit [Remote host closed the connection]
20160204 18:25:30-!- prkc [~prkc@46.166.190.199] has joined #wesnoth-dev
20160204 19:08:03-!- EliDupree [~quassel@idupree.com] has joined #wesnoth-dev
20160204 19:30:36-!- irker652 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160204 19:34:28-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 248 seconds]
20160204 20:09:15-!- Kwandulin [~Miranda@p200300760F6924AD10C6209D436A14BD.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160204 20:12:21-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160204 20:15:55-!- prkc [~prkc@46.166.190.199] has quit [Ping timeout: 245 seconds]
20160204 20:21:37-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160204 20:24:58-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 272 seconds]
20160204 20:24:58-!- wedge010 is now known as wedge009
20160204 20:25:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160204 20:29:58-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160204 20:29:58-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160204 20:30:25-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160204 20:53:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160204 20:54:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160204 20:55:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160204 21:01:46-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20160204 21:43:38-!- Appleman1234 [~Appleman1@KD119104015002.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20160204 21:56:18-!- gfgtdf [~chatzilla@f054159007.adsl.alicedsl.de] has joined #wesnoth-dev
20160204 21:56:32-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160204 21:56:39< gfgtdf> wedge009: did you file an upstream bugreport for the pango issue ?
20160204 22:39:58-!- Appleman1234 [~Appleman1@KD119104013170.au-net.ne.jp] has joined #wesnoth-dev
20160204 23:27:52-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20160204 23:28:50-!- aidanhs [~aidanhs@81.4.110.234] has quit [Ping timeout: 252 seconds]
20160204 23:28:56-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20160204 23:47:27-!- mjs-de [~mjs-de@x4db62fa9.dyn.telefonica.de] has joined #wesnoth-dev
20160204 23:50:02-!- gfgtdf [~chatzilla@f054159007.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 43.0.4/20160105164030]]
--- Log closed Fri Feb 05 00:00:29 2016